labofsahil/github-event-dataset-2012 huggingface dataset:
Oops, didn't look carefully. z gets casted to (void *) at few lines down. ccCArrayInsertValueAtIndex(m_pAtlasIndexArray, (void*)z, indexForZ); 
I thought it was a offset of a pointer, but it looks like a value that gets inserted. anyway it get casted to a flexible-sized type(pointer).
so I thought setting intptr_t was OK 'cause intptr_t is not pointer, it's integer type that can hold pointer address. refering from www.cplusplus.com/reference/clibrary/cstdint/ . actually there's no data size conversion this way.

alternative way is doing below.
int z = ...
ccCArrayInsertValueAtIndex(m_pAtlasIndexArray, (void*)(intptr_t)z, indexForZ);
and there can be a conversion in x86_64 : int32 -> int64 .

we have to do this to get rid of warning that complains about cast between different sized types.
anyway, I think both ways aren't neat. Because 'storing integer inside pointer is a hack.
To become neat, using template container(stl or else) can be a good way to improve the neatness. but I think it's OK for not toucing the working legacy.

We can overload ccCarrayInsertValueAtIndex that hides the casting, or use template function with template specialization. but this commit will just fix the warning that'll keep the little hacking.
The "*_DIR" thingy I introduced BEFORE I started "chunking" the `urlParsed`.
Would be better if instead of changing to `_const.EQUALS_DIR` you'd rename the contant above to `EQUALS`.
Sounds like a model method.
obsolete, already replicated by mfusco
Looking at the code again, the new Entry class from resteasy throws a JAXBException which isn't caught be RuntimeException. That's why I had changed to Exception in those two places. Should I specifically catch JAXB exception around those places and rethrow a WebApplication exception or just add another catch clause? To the existing try catch block?
This import should be moved to main.less, we like to control imports in one central location
Why would $width / $height not be set? `$args = $image->getArgs();` WP Thumb sanitises it's args I think (or should) so you can rely on them
For time, use TimeGet()
would be nice if we could reuse same listener, which I think should be possible if you use `event.target` in the listener.
Let's use `core.get(name + "_options." + item.getAttribute("label"))` to stick to the convention already started.
> There isn't anything about typeof?

Inherited from general mozilla style guide :)
https://developer.mozilla.org/En/Developer_Guide/Coding_Style#Operators

Good point, I'll add that to our style guide as well!
Since we're not actually using the contents of hostname/name/logoURL in the template (just their presence), maybe ```data``` should only contain booleans like ```hasHostname``` and ```hasLogo``` instead of the actual values? That'd remove the need for stripHTML here.
nit: `function (`
Don't we need to check for `:undef` here?

Also lower in this file is the line `answer = nil if answer == :undefined` which should also be updated.
I think this would be better described by: `only allows Socket constants as strings`
No reason in particular - I think it was because I was looking through the typahead source and matched the functionality there (or perhaps another file). Either should be fine.

E.g. https://github.com/twitter/bootstrap/blob/master/js/bootstrap-typeahead.js#L220
if you don't need the maxnodeid, why have this in this tuple?
Rename to `assertResponseHeaderContains`
This file should go Http/Client/Adapter
The same observation as before.
What method assign a value to this field?
minor gripe, but remove blank line. rest is great.
Maybe we should implement a function like `CustomPreorder.mark_paid()` (DRY)
`null` is the default value anyway. In PHP there's no initialized variables.
That doesn't really compare to any other PHP code you'd write.
Why not make stuff like this modifiable?
There is, due to differences in Ai for future-proofing. this was discussed a bit between Zidane and I.
Yeah, better to have a high upper bound than limitless. We can change it to 100 or 200
Oh, I got it.
AM_INIT_AUTOMAKE with arguments is not deprecated, but we can omit it if we already use AM_SILENT_RULES.
silent rules are disabled by default so I use AM_SILENT_RULES([yes]).
@samiluukkonen Why?
why removing this driver ?
you are aware that this only affects the suggestion, right?

does midgard have a stable master now and a dev branch? you could also alias the dev branch to something like 1.2.x-dev (or whatever the next version will be) so that people can depend on 1.2.* and get the stable once it is there. see https://github.com/composer/composer/blob/master/doc/02-libraries.md#aliases
Without this line, the compiler tries to compile **dict.ex** first and gets screwed.
we probably should, would save us lots of unaligned doc.
Hmm, I thought usex resides in this eclass. Ok, will remove it.
[travis build failed](https://travis-ci.org/getpelican/pelican/jobs/3089885) here because webassets needs to be installed. Maybe you can configure travis via ``.travis.yaml`` so that it installs missing dependencies (webassets, cssmin, scss) for tests in ``TestWebAssets`` to pass.
**I'm** not ok with `$.each` ;)
OK, sounds right. Will fixor.
Can you remove these repository definitions?
Can we stop adding comments to this closed pull? It's getting confusing. :-)
Just add the comments to the appropriate new pull and reference the 
comment in the closed pull.

On 03/19/2012 08:13 AM, Sherif Makary wrote:
>> +	
>> +	/**
>> +	 *<p>
>> +	 * sample Secured ejb method using security annotations
>> +	 *</p>
>> +	 *
>> +	 */	
>> +	
>> +	@Override
>> +	@RolesAllowed({"gooduser"})
>> +	public String getSecurityInfo()
>> +	   {
>> +		//Session context injected using the resource annotation
>> +		principal = ctx.getCallerPrincipal();
>> +		
>> +   		return principal.toString();
> Regarding the "Principal", the idea was to show how to get the principal to use it in is in role, I'll change the variable scope to local variable in the new branch, also I'm going to remove the CDI support.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/131/files#r573591
It's too bad we can't use _parseAggregate anymore to spit out the arguments. The logic is pretty similar.

I wonder if instead of checking explicitly if it's a macro, we should come up with a calling convention with kwargs. If kwargs exist, it passes it a certain way, otherwise it calls it like normal. And macros that expect kwargs are generated with the right calling convention.
Dependencies are in alphabetical order for ease of scanning. Could you move this one to its appropriate location?
I thought that I had changed the function to return the array.

Sent from my iPhone

On Nov 9, 2012, at 6:42 AM, Lucas Caro <notifications@github.com> wrote:

> In omniture.module:
> 
> >      if (isset($omniture_hooked_vars['variables'])) {
> > -      $extra_variables_formatted .= _omniture_format_variables($omniture_hooked_vars['variables']);
> > -    }
> > -    if (isset($omniture_hooked_vars['footer'])) {
> > -      $footer = $omniture_hooked_vars['footer'];
> > +      $extra_variables= _omniture_format_variables($omniture_hooked_vars['variables']);
> > +      foreach($extra_variables as $key => $value) {
> I think $extra_variables is a string here @see _omniture_format_variables() and this foreach won't work as intended.
> 
> —
> Reply to this email directly or view it on GitHub.
>
hm, nah you're good
Lines 37 + 38:
Add a space before the first '>' and remove one after it.
I am not saying this is correct. I said I merged everyone elses commits so it might be that someone has this in theirs.
I am just trying to find a way for it to get the `mozwebqa` object once rather than needing to deliver it every time we instantiate the PageProvider.
thanks, I also think tests are required for this specific case.
Ok, I'll have to read up on has_one some more
thanks, I'll fix it.
On Thu, Dec 13, 2012 at 12:10 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

>
> So basically, the text is not in title case if there is an all-lower-case
> word that is not a skip word?
>
exactly

> A few questions:
> Does title-casing allow lower case words that are compound words joined by
> dash? E.g. would it be "Pre-existing or Pre-Existing"?
> Why do we not lowercase the last word?
>
currently it would be Pre-Existing, i.e. a title with Pre-existing would be
(potentially wrongly) treated as sentence case. Title case, unfortunately,
allows both, depending on context. But since it may be better to err on the
side of treating something as title case since there are likely going to be
more lowercase words if this is actually sentence case.

I think we can pretty much accomplish this check by doing the following
> (with some tweaks depending on your answer to above):
>
> const skipWords = ["but", "or", "yet", "so", "for", "and", "nor",
>   "a", "an", "the", "at", "by", "from", "in", "into", "of", "on",
>   "to", "with", "up", "down", "as", "while", "aboard", "about",
>   "above", "across", "after", "against", "along", "amid", "among",
>   "anti", "around", "as", "before", "behind", "below", "beneath",
>   "beside", "besides", "between", "beyond", "but", "despite",
>   "down", "during", "except", "for", "inside", "like", "near",
>   "off", "onto", "over", "past", "per", "plus", "round", "save",
>   "since", "than", "through", "toward", "towards", "under",
>   "underneath", "unlike", "until", "upon", "versus", "via",
>   "within", "without"];
>
> const wordRE = /\s([^\s,\.:?!]+)/g;
>
> function isTitleCase(string) {
>   var word;
>   while(word = wordRE.exec(string)) {
>     word = word[1];
>     if(skipWords.indexOf(word.toLowerCase()) != -1) continue;
>
>     if(word.toLowerCase() == word) return false;
>   }
>   return true;
> }
>
> That's clever. I just adjusted the capitalizeTitle function to not
overlook anything, but this makes more sense. The one thing that I think we
need to take care of are acronyms in the first word of the title, as in "US
drug policy" - which would need the S protected.
Add comment: This class is not thread-safe.
``IsGood`` was checked the same way as ``IsPrivate``, meaning it's something that Steam returns. If we change this I think it should be outside of this pull request.
nit: would say `we had dessert`
Maybe we should add these CSS things to a separate CSS file sometime…
Maybe this hint could go a step further and also say "Try writing an equation in terms of x using the information given in the problem."
Again, this can be made better through the use of \<code\> tags. I changed the TILDA string above to `"\\sim"`. Then, this line becomes:

    <code><var>TILDA</var><var>SIDE</var></code>

which looks much better.
nit: you added a space after `MEASURE`, and I think you did this in a couple of the other exercises as well.
Oops. Please remove this `System.out.println` call.
Yes, the non-pro features still pass on the pro version. Core functionality shouldn't be different between Nexus OSS and Pro. What Pro does is allow access to additional plug-ins which enable more features (in this case, custom metadata).
I just keep consistency in tests to not have to refactor all others...
I'll update the patch as soon as Christmas is over, don't have a remote link handy right now.
лучше выйти с ненулевым кодом возврата
Can we keep configuration schema separated from the 'test-plan' one?
After looking at this it might be cleaner to remove the `param == false || ...` since it's already being converted to a string.
Nowhere in particular, I just hate data hiding. Leads to awkward monkey patching.
FYI here is what the output looks like (a 12 person tournament):

```
INFO     2012-12-10 03:51:14,835 actions.py:339] <Model id=235, round=1, status=-1>
INFO     2012-12-10 03:51:14,837 actions.py:339] <Model id=236, round=2, status=-1>
INFO     2012-12-10 03:51:14,842 actions.py:339] <Model id=237, round=3, status=-1>
INFO     2012-12-10 03:51:14,844 actions.py:348] Participant 1 added to 237
INFO     2012-12-10 03:51:14,846 actions.py:339] <Model id=238, round=4, status=-1>
INFO     2012-12-10 03:51:14,849 actions.py:348] Participant 8 added to 238
INFO     2012-12-10 03:51:14,849 actions.py:348] Participant 9 added to 238
INFO     2012-12-10 03:51:14,851 actions.py:339] <Model id=239, round=3, status=-1>
INFO     2012-12-10 03:51:14,854 actions.py:348] Participant 4 added to 239
INFO     2012-12-10 03:51:14,857 actions.py:339] <Model id=240, round=4, status=-1>
INFO     2012-12-10 03:51:14,860 actions.py:348] Participant 5 added to 240
INFO     2012-12-10 03:51:14,860 actions.py:348] Participant 12 added to 240
INFO     2012-12-10 03:51:14,863 actions.py:339] <Model id=241, round=2, status=-1>
INFO     2012-12-10 03:51:14,867 actions.py:339] <Model id=242, round=3, status=-1>
INFO     2012-12-10 03:51:14,870 actions.py:348] Participant 2 added to 242
INFO     2012-12-10 03:51:14,875 actions.py:339] <Model id=243, round=4, status=-1>
INFO     2012-12-10 03:51:14,880 actions.py:348] Participant 7 added to 243
INFO     2012-12-10 03:51:14,881 actions.py:348] Participant 10 added to 243
INFO     2012-12-10 03:51:14,883 actions.py:339] <Model id=244, round=3, status=-1>
INFO     2012-12-10 03:51:14,886 actions.py:348] Participant 3 added to 244
INFO     2012-12-10 03:51:14,888 actions.py:339] <Model id=245, round=4, status=-1>
INFO     2012-12-10 03:51:14,891 actions.py:348] Participant 6 added to 245
INFO     2012-12-10 03:51:14,891 actions.py:348] Participant 11 added to 245
```
I'm not sure what this function returns...is it always an int? Even for millis (seems like that would be a long or a float)? If nothing else, it seems like the postcondition is `(not (neg? %))`. Or actually, can 0 be returned from this? In which case I suppose the postcondition is `(pos? %)`.
We should call into our rakefile to get the correct version number for this part.  We will be happy to add that on ourselves, though.
I mirrored this after the clojure.java.jdbc stuff, and it seems consistent with their patterns to me.  @grimradical if you agree with nick on this one let me know and i'll go rename all those methods.  Personally I think it makes it clearer that they are `internal`, though.
I like this setup, it makes the individual messages pretty slim.
Here we're actually changing what we used to be doing - is this OK in a point release? Note it *was* `::I18n.locale` and is now `Globalize.locale`
Would this suffice?:

```ruby
match '/system/thumbs/:id(/:size)' => Dragonfly[:refinery_images].endpoint { |params, app|
  app.fetch(Refinery::Image.find(params[:id]).image_uid).
      thumb(size if size.present? && Refinery::Images.user_image_sizes.keys.include?(size))
}, :as => 'thumbnail'
```
Perhaps we should get the config as a tenant admin as well to see if the values percolate?
You are catching any exception here (i.e., ``Throwable``). Just double checking this is really what you want :)
This is probably broken. Not all settings are `Booleans`. For instance, `-Xplugins-dir`, `-target`, and many others. You should use `unparse`, or have a look at the old Sbt code, how it was de-constructing `Settings` objects.
This blank line stays.  It's for readability.
Excessive debug. If you want to keep it put it under #ifdef EPG_TRACE that's what I've been doing with deep debug
Perused the Go docs, what you've got follows their style, just wish there were more fireworks to it.
Please indent correctly
It's ok now... tks.
Needs to be in PHP5 style (public instead of var). Also there's this quote after FALSE which will cause a syntax error.
Даю последний шанс на исправление, дедлайн - 12.00 в воскресенье.
В методе mutate вы производите мутацию не percentages процентов эллементов массива, а percentages раз. Это одно и тоже если число элементов массива 100, как в примере. Если же число эллементов массива изменить Ваш метод работать не будет. А если percentages будет больше количества элементов массива цикл for (;;) станет по настоящему бесконечным :)
А, и вот ещё - ответьте на такой вопрос: сколько элементов у вас в массиве после инициализации?
Вы глянте - народ вообще не так делает!

Сначала делает массив индексов, потом их перемешивает, и наконец нужный процент индексов из этого массива использует для замены значений в DNA.

Среди работ есть несколько подходов к том, как именно это делать, но суть одна
так я вроде бы тоже согласился с подсчетом процентов и внес изменения в последнем коммите
Здравствуйте.
В приложении только вью часть и нет логики, в то время как стоит статус Final. Вы что-то недозалили?
Does it matter that two instances might share the same value?  You could make it static if it does matter.
this should be `expects` instead of `stubs` shouldn't it?
Let's follow tradition and call this "Security Considerations".
As above, I'd like to include this in the loop.
Ditto - ```Topic.count.should == topic_count_before_create + 1```
Is this closer to the platonic ideal?

```C#
var repo = new Clone() {
  SourceUrl = "https://github.com/libgit2/libgit2sharp",
  WorkDir = @"C:\Users\me\Desktop\libgit2sharp",
  Progress = (a,b,c) => { /* ... */ }
}.Execute();
```
If I calculate the inverse inverse std to undo the mixing_matrix standardization I will get differences on let's say 10 % of the row values starting at about the 6th decimal. So the redo test will necessarily fail. However, np.allclose allows to set tolerance parameters. Any recomandations with this? Fiddle around or just drop the redo assert?
-o really means hosted chef organization. Now that we have OPC with organizations I could see this leading to confusion.
You're right, I've missed it.
But attr_reader must be added to Smpp::Base, right?


On Fri, Dec 7, 2012 at 5:04 PM, Ray Krueger <notifications@github.com>wrote:

> In lib/smpp/transmitter.rb:
>
> > @@ -3,6 +3,8 @@
> >
> >  class Smpp::Transmitter < Smpp::Base
> >
> > +  attr_reader :ack_ids
>
> Don't really need this, @ack_ids is declared in Smpp::Base
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/raykrueger/ruby-smpp/pull/11/files#r2350016>.
>
>



-- 

Quando hai fretta, l'unica cosa sensata da fare e' rallentare.
Isn't it better to place this in a inline code block?
没有“被”
Do you have any such modules in mind? Because Cython is basically a program plus some API definitions for common libraries, for example C++ STL or NumPy. Maybe it is better to write some macros that would reduce boilerplate.
add after run # doctest: +SKIP
Se puede hacer mejor, está medio sucio ese código. Pero la idea de usar una nueva variable `defaultPlaceKey` fue para que si el empleado no come, se le setee su oficina por defecto.
please add a line at the end of files
this code can now be removed
I was also thinking of this, and you are right that the 'x' and 'y' notation is ambiguous, and we want to be able to ultimately customize which sides (bottom/top/left/right) have ticks, tick labels, and axis labels for a given coordinate. I struggled to define an API that allows this an yet is simple to the user. As part of the API document, we should describe how we envisage making a plot like the one you showed above.
I feel like it might be better to do this ratio manipulation in the sass mixins calling this function.
:) Assuming this gets merged, it should be an easy find-and-replace.
Why is the memory hardcoded... I suppose we were waiting for flavors. Might be good to add it now.
Nope, I'm a creep and didn't test load so I never caught this. Thanks for spotting it cp16net.
hmm, you could. Other tests relying on libraries included through composer don't check it either.
This block should accept `NSUInteger` values, which is the Cocoa type most comparable to and most often used in place of `size_t`, and certainly a much better choice than `int`.
When you have a literal block, you have to have a closing point at the same level on indentation from where it started.
I've still not tested this, I took the lead from ```mathtext.py```. Hopefully travis-ci will be helpful here.
sounds good, adding one between the subplots arguments, as well
Typo: Voronooi should be Voronoi.
Yet more awesomeness you're adding to the overall setup. You da bomb!
probably should make this a HEAD so we don't end up downloading firefox.. and rename the method to represent it.
You could add ", true" to both to avoid the animations, but I haven't seen it yet, so there's no need to change that if it feels better with a double-animation.
Division by zero = NaN = unpredictable results.
Yeah, say you're trying to make a `DataValue` out of the array trapped in a timeseries. You don't want to break the values out then wrap them up again.

I think functions shouldn't try to do too much. if you want to compose these two functions, you can break them out into a predicate macro that does both things. `get-vals` already pulls out values. IMO it'd be a mistake to for `unpack-timeseries` to do this too when you might as well just compose them together.

```clojure
(def unpack-timeseries-vals
  (<- [?series :> ?start ?end ?ts]
        (schema/unpack-timeseries ?series :> ?start ?end ?wrapper)
        (schema/get-vals ?wrapper :> ?ts)))
```
```
Can we do `!shareFiles.length`?
Actually create_definition return the token.
The next thing we need to think about is whether we need a barrier here (and if so, should we be more careful to only call this when a page is dirtied for the first time?).

Without a barrier here, the tree may not be marked modified immediately when a page is modified.  On the other hand, page modifications currently acquire a spinlock, which implies a barrier, so we could avoid this one today.  If we replace that spinlock with some atomic compare-and-swap operations in the future, we'll need to check carefully whether that implies a full barrier, and at that point, we may need one here.  I think this at least deserves a big comment.
Does this match what was discussed on the phone call? I decided to add 1 to avoid divide by zero conditions.
Add a uv__once_init to core.c/uv.h and call that from util.c?
I go back and forth, but lately I've been doing the double-space thing. :P
Are you sure that the method "getRequest()" exists?
Forgive my schizophrenia.  For v1, the assumption was always that to_initjs() will include all the required <script> references.  For v2, I have decided (today) to assume that people will explicitly call methods to spit out their javascript (for both Livefyre, LFSP).   This helps emphasize that people can (and SHOULD) control where in the page the source references appear (better control over page load order).

So, just do this: remove all the stuff about including source JS and assume that it will be included by the consumer making explicit calls to source_js_v2() and (optionall) source_lfsp_js_v2(), prior to calling to_initjs_v2.
OK I'm putting it in its own class. But don't see how I could raise an exception and handle that elsewhere as the errors here come from the XML validation, so I need those functions to detect errors in the first place.
Existance Check by Value? Evlt. ein doesTagExist im DBUtil?
Good comment from Ian -- @dkastner can you work this in?
You need to use tabs not spaces to indent these three lines.
Yes, this will solve my problem, I just thought it would be better not to follow redirects automatically. In this case it would be a good idea to set the CURLOPT_MAXREDIRS in order to specify the maximum number of redirects to follow, avoiding infinite loops.
Don't lose our bug-reporting URL.
You can move setting header to the beginning of this method. Because it is shared with all code paths.
If we are precise, `get` return by default `None`. So `+` could fail. ;-) Better would be:

```
username = fb.get('username', fb.get('first_name', '') + fb.get('last_name', '')) or None
```

In this way if also `first_name` and `last_name` are empty, then username becomes `None`, what you can check later on and simply leave randomly generated username as it is.
Why would `request` and request user not be available? When you user OAuth? But we will have to change this limits anyway then.
Use tuples for such constant lists.
`panels_x_dependencies` -> `dependencies` -> `dependency`?

The first is a relational database construct used for many-to-many relations, which this is, the second two are just dependency because dependencies are always of a panel. I don't know, it's kind of mixing realms of programming here, but it's a many-to many relation technically. Not sure how much better you can get with just names. :)

Other than `_x_`, some use `_to_`, `_per_`, `_has_`, or just `X`.
The order of backends would also set the preference for images.
[Here](https://developers.google.com/accounts/docs/OAuth2Login) it is written that it is `/o/oauth2/auth` URL.

For constant strings use `'`.
*You don't have permission to access the page you requested.*
No `.` at the end.
Сломается. Выведет `~~~smarty`. Но вообще, если норм, давай оставим. Лучше парсер подрихтуем.
lol yeah, find/replace a typo!

On 08/03/12 16:01, Joe Groff wrote:
>> +[T,U | Numeric?(U) and BiggerNumeric?(U,T)]
>> +overload seqType(static T,a:U,..args) = ..seqType(U,..args);
>> +[T,S | Sequence?(S) and BiggerNumeric?(T,SequenceElementType(S))]
>> +overload seqType(static T,a:S,..args) = ..seqType(T,..args);
>> +[T,S | Sequence?(S) and BiggerNumeric?(SequenceElementType(S),T)]
>> +overload seqType(static T,a:S,..args) = ..seqType(SequenceElementType(S),..args);
>> +overload seqType(T) = T;
>> +
>> +private define seqSize;
>> +
>> +overload seqSize(s,a,..args) = ..seqSize(s,..args);
>> +[S | Sequence?(S)]
>> +overload seqSize(s,a:S,..args) = ..seqSize(max(s,size(a)),..args);
>> +overload seqSize(s) = s;
>> +
>> +private define reduceToScaler;
> Did you mean `reduceToScalar`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/236/files#r534309
I'm torn between this style, and the alternative:

```ruby
def allowed_writer_methods
  @allowed_writer_methods ||=
    begin
      allowed_writer_methods = public_instance_methods.map(&:to_s).grep(WRITER_METHOD_REGEXP).to_set
      allowed_writer_methods -= INVALID_WRITER_METHODS
      allowed_writer_methods.freeze
    end
end
```

Once I extract `Veritas::Immutable` from the veritas gem, we'll be able to simplify this down to:


```ruby
def allowed_writer_methods
  public_instance_methods.map(&:to_s).grep(WRITER_METHOD_REGEXP).to_set - INVALID_WRITER_METHODS
end

memoize :allowed_writer_methods
```

But for now I want to choose something that's simple to understand and easiest for people to read.
If the resource stream is added directly to the StreamResponse constructor lambda, it gets garbage collected which causes an exception when  Response.Content.Invoke() is called. It'd be nice to avoid digging into the manifest every time the response is invoked but I'm not sure how to accomplish that.
If you change the signature below as suggested... then this becomes

```csharp
List<AirbrakeTraceLine> traceLines = GetBackTraceLines(logEvent.Exception.InnerException, traceLines, 1);
notice.Error.Backtrace = notice.Error.Backtrace.Concat(traceLines).ToArray()
```
Not sure depending also on the request is worth it, considering that the cache can then handle further requests... The client won't hit the same asset via PHP twice anyway
@superdweebie once this PR is merged, I think this part goes to you... And should be moved on top :)
It's a scientific requirement to first group by time and then by distance.

However, I made some tests, the speed depends mainly on the windows used.
I don't have any experience with Redis, so my question might be dumb:

Why do you oepn a "multi" transaction statement for a single operation? From the Redis documentation - which I'm reading right now - it doesn't sound like I get any benefit from using it on a single operation; it looks like more of an optimisation for multiple operations to be batched in a single disk sync in the transactions log.
is bin/pfcmd properly setuid to root?
I changed it into "request_ip = request.META.get('REMOTE_ADDR')", but I'm not sure what to do with teh REMOTE_ADDR variable.
The `slice` function appears to have a floor function built in.  But point taken.
Yeah thanks! Which name you think is more descriptive?
True, it's also used one more time. Added.
Explaining this a bit would help, I agree.
Lowercase "No", and this should be a UI string.
You are right. I'll close this pull request.
This belongs in `WorldView`, not `Pi`.
JUnit style would ask for fCollector as the name of this field
Sure. I've made that change.
*fid* > *facebook_id*

Be verbose.
I tried to add that, but then search page didn't work. So I thought that i should not use it on the new page.
yes, warning is to say it is deprecated, have changed to deprecated
indentation defaulting to 2 spaces here?
Would be good to move these into their own class, rather than having live tests in a class called IntegrationTest.
What is «validate it»?
I just tried Set also. I think this `to_ary` thing probably gives us the best behaviour. See also the behaviour with to_str we discussed at length over the message must be string pull request. Presumably to_ary is also our protocol for if a thing quacks like an array?
Considerando uma configuração stática sugiro que seja colocado no settings.py.
Will do - you find it easier to read single longer if statement rather than nested ifs?
I presume this file was committed accidentally...
Also should be a .ui file
never mind, it asked permission and then centered the map over my apartment.
Not for this rev, but for these kinds of errors, we should probably think about i18n, and can probably just use the api/lib from rails to do it.  i18n on returned errors is another matter to be addressed separately, if at all.
Это лишнее сообщение. Да ещё и некорректное.
There is still the token renew scenario, enabling a setter can update the expiration date without updating the token itself.
We also usually do `} else {`.
Yikes - you shouldn't have this. Will delete.
Instead of using split, could we use nargs='2' as part of the command line parser (line 488)? 

This would have the benefit of generating a user friendly error message at parse time, rather than a run-time error - and may make the code slightly cleaner too.
<3 @stephendonner aka our resident wordsmith :-)
@FlorianLB you're right.
Would this ticket be related to that?   http://tickets.opscode.com/browse/CHEF-2748
What happened to the space before this line?
This should be a lot faster now. Implemented using `ndimage.maximum_filter1d`.
for online settings the API choice in the scikit is to use a partial_fit method rather than a custom filter_update method. I cannot tell how much we can cast this online setting into a partial_fit though
`n_visibles` is `n_samples`, right? If so, then this should just be called `X`, not `v`.
I thought every classifier should have as attribute classes_
I am -1 in exposing label_encoder_ to the user.
You're right: we should divide by `len(self._y)`
Hey it looks like this block is still in the pull.
This method is very big...
Do not modify the input buffer. Instead, just set `data = data + offset` and use the correct length.
And in setBackgroundColor too
Right, changing, introducing an inline TestRwFlag method.
1-0 stable is ahead on master.. need to fix this and create a 1-1-stable branch as well.. this evening and tomorrow are planned for that!

On Apr 19, 2012, at 7:39 PM, Jeff Dutil wrote:

>>     path = path.gsub('//','/')
>> -    path = StaticPage::remove_spree_mount_point(path) unless Rails.application.routes.named_routes[:spree].path == "/"
>> -    
>> +    path = StaticPage::remove_spree_mount_point(path) unless Rails.application.routes.named_routes[:spree].path.spec.to_s() == "/"
> 
> There is already a 1-0-stable branch so this should be fine in master.  Does the 1-0-stable branch need to be rebased with master first though?  It seems to be several commits behind master, but I'm not sure if there has already been commits other than this that would break compatibility.
> 
> @peterberkenbosch did you start working on this already?  If not I can later today as I want to get this fix into my app.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree_static_content/pull/50/files#r708469
There is already a 1-0-stable branch so this should be fine in master.  Does the 1-0-stable branch need to be rebased with master first though?  It seems to be several commits behind master, but I'm not sure if there has already been commits other than this that would break compatibility.

@peterberkenbosch did you start working on this already?  If not I can later today as I want to get this fix into my app.
Perhaps this should also be an upstream patch then, as we have no guarantee that it will indeed only be `-L` flags in LDFLAGS, and it is somewhat naive for Julia to assume so.  It should be possible to filter out only flags starting with `-L` and use those, rather than using all flags.

I'll see if I can cook that patch up once I get home tonight.
by passing 0 as base, strtoull will decide which base to use based on the prefix (hex if prefix is 0x and octal if prefix is 0)
@ryoqun I'm almost done fixing this. Module#name is a pretty messy part of Ruby. I can explain the approach once I push if you still have questions.
Please use the `NAN` macro. It's guaranteed to be defined by `collectd.h`.
makes the repo universal for all users who want to use this. As you can see, you need to clone the repo in `~/.m2/git-mvn-repo`
can you use CSS path in this place?
This is vulnerable to NullPointerExceptions... use the apache commons StringUtils.isEmpty(str) or StringUtils.isBlank(str) instead.
i guess class makes more sense. I just copied tooltips.
Applies to setupCache() in same file as well, changed that too.
newline at the start of a function
I really don't understand it, why? is really needed?
Yeah expected that the payload wont be deleted when it is successful - it should be running, I'll add a message to that effect.
`build_gaussian_pyramid` -> `pyramid_gaussian`
probably clearer just to say "the view layer"
thought I got rid of that. good catch.
Not in master.  If it is an error, we should throw an exception.  If it is important debug logging, it can be a flag; `Context` has one.  At some point, I envision a killer HUD with lots of debug goodness.
`maxTiles` -> `maximumTiles`, right?
I know that; but that actually won't fix the problem.  Eventually I will end up with the foo/bar case I listed above unless I actually replace the , with a . at some point (or remove delimiter altogether)  I agree we should handle this better than the blanket replace, I just need to figure out how.
I can try, but this is your pull request. Are you going to let me make changes to your branch?
do not call setters. Instead do searchBar.width =
Sorry, should have been more clear with this.  We aren't really setting the minimum width of the content view to be the size of its parent here.  We are essentially delegating measurement process to resolveSize.  Since we set the content view to have fill behavior (should be in tiuiscrollview somewhere), android will measure the content view to be the same size as its parent.   We do force the size to be the content width if the user specifies it to be greater than the parent width.  A more appropriate comment here would be something like "Return the content width when it's greater than the scrollview width".
I would also add a note that even when it is supported, unexpected results may occur. In MW, almost all controls create "hidden" controls under the hood to implement their functionality (e.g. a Button contains an ImageView and a Label). If the user calls add in these instances, the view will certainly be added, but it may affect the other hidden controls in unexpected ways.
Can you put this all on one line and use string interpolation?
I will play a little with the pom/setup
Any external lib for the below? (or ok using our own functions?)
```include?('to_msgpack')``` is bad because instance_methos returns an array of symbol.
Please use ```:to_msgpack``` instead.
we don't use this method we should remove it
We check @authorized variable state
Я бы не использовал местоимения We и I, лучше писать Check the state of @authorized variable
И пояснять зачем это делаем.
Well I like them too. The matter here is, as the complexity of the computation goes up, so does the awkwardness of doing it in a template as opposed to a function. So at a point it's better to relegate computations to CTFEs. But using difficulty of implementation as a decision for using template vs. using CTFE is too subjective (besides what does client code care about how hard it was for the implementer?) so that's what makes it attractive to just say: if it's computation use CTFE, otherwise use template.
Actually, I swear that puttting operators at the begining of the line is the common convention. 
 For one thing it's less bug prone - no need to  look back and forth across the line to get how things are composed.

"As I have seen" is hardly an argument cause Phobos is a mixture of conventions.  I do not know a single module that has coherent style.
In this pull I doing global substitutions  like "for(" --> "for (" I've found that 'space before paren' is not followed in std.algorithm at large. (it's supposed to)

 I suspect in the long run we just have to throw in the damn STANDARD PHOBOS code formatter tool, especially w.r.t. spaces, commas, braces and parans. Otherwise the process of reviewing a pull  goes painful ping-pong about every glitch with the spacing. And yeah, without the tool we'd still let through code with different style.
spacing around operators please
This reads like the function would change the `init` state – maybe »Sets the passed object to its initial state.«?
That's fine for now. It's private anyway.
heh, nice catch, thanks.
Oula, pardon, là pour le coup c'est moi qui ait mal regardé ton code :)

Oublie cette remarque :)
Is this a copy of the other trycatch block? If so, thoughts on refactoring into a macro?
Just tried it; the problem is I need the subtype to call `ProblemFilters.exclude[SubType]`, I don't know how to get that here.
Maybe there's a way to do `exclude[ProblemRef](name)(manifest-of-getClass)` but I'd have to figure out how to write `manifest-of-getClass`. Might be simpler to just factor out a method like 

```scala
object ProblemFilters {
  private[core] def toExcludeString(klass: Class[_], name: String): String
}
```

fwiw the toString on the exclude isn't currently identical (here it's the public syntax, there it's the case class name), though perhaps it should be. The reason I put a toString on ExcludeByName is that otherwise the one from Function1 "wins" so the default toString is just `<function1>` or something worthless instead of the normal case class one.
You're missing a comma at the end of this line.
Both should be operating off the end date of the certificate.  SubDetailsWidget.show() gets passed "end=cert.validRange().end()" which is the same information that _get_entry_image() operates on.
we don't want a generic route!
I thought it would be ok, but after more thought I think it's better to handle the parsing exception and simply filter out these events.  If we can't create a proper `ShippingEvent` it probably shouldn't be considered part of the overall event chain.
Ты уверен, что тут должно быть отрицание?
I see. This code should be in the InterceprotChainFactory then, as it being here makes things a bit harder to understand :-)
Missing `public` keyword, here and below.
What is in values at this point? Have you already aggregated all the HDF data and now slice out a piece of it?
We should cater for the common case, and the common case is that someone writes e.g.

    if (object.field == 42) { ... }

Throwing a sort of an array dereference exception would be just confusing.
There is a strong reason of course: I'm to lazy/busy. )
Yeah, let me know if you want to remove it during merge or I'll do it.
Merging with my polish.
Same MessageChannelMetrics?
Works the same as APE; and this it onInit(), so I don't think it's worth changing it.
Filed issues 160-162 in the other fork.
@brad And what exactly does this else provide the user?
There was an error raised by utcfromtimestamp at:

start = datetime.datetime.utcfromtimestamp(request.GET.get(QUERY_START, 0))
TypeError: a float is required
Too many "-" -- must be same length as preceding text.
OK, thanks for the info. I'll close the broken pull requests and sent a cummulative one with your master merged.
Notes the rambling ;)
Good call!

Order does matter. It is the order that the printers will be displayed in a ComposedBasicListBox
phpDoc missing
Well, guess it's arguable. Will leave it a `table` for now.
At this stage, blocks are only arrays of profiling data. If we want a cleaner solution, we would have to add a 'hasChildren' property in the profiling data generated in TraceableBlockRenderer and use it here to separate containers from real blocks.
2 things here..

- I would change this to only be setup when `south` is installed. 
- The `print` statement removed.
use single var declaration
idées dans lesquelles on investit
`<code>HQL</code>, <code>Criteria</code>`?
I'd prefer if you named the file 'rasterizerService.js', it seems the convention for all node files (including classes) is to start with a lowercase letter - at least that's what is used in this package.
could be a one-liner-
```
((combined_filters.size > 1) ? '(|%s)' : '%s') % combined_filters.join(' '))
```
it has no meaning.
extract the block to init @yml_hash to a private method
Isn't needed if you use the `link` template plugin to build the form action (also below).
We localize for consistency with Thunderbrd.  See the comment in the file above this section (sadly not visible here; grrr github).  I'm not clear what other e-mail clients do when forwarding inline.  One might argue this is an argument in favor of forwarding as an attachment, but I think in practice forward-inline is both all we can really support right now, and what people generally expect.

Thunderbird has the date situation easier because Thunderbird has the actual date header lying around, so localization of the date does not come into the issue at all, whereas we only have the parsed value.  The date for Thunderbird should still be formatted as per rfc 2822 at http://tools.ietf.org/html/rfc2822#section-3.3 which looks like what toUTCString() gives us, except that toUTCString discards timezone information.  That format is a little odd for humans, or at least American humans...

Honestly, I'm not really sure what to do.  I was thinking it would just be a bug we fix later.  Forward-inline is already very destructive of information since Thunderbird at least localizes anything, so it's a lesser sin.
We don't need options to point on closure library anymore. Because calcdeps get all assets paths and looking there for closure library and dependencies. So user need to place closure library anywhere and properly setup assets.
name is `sourceType`
does date work well? usually there are many problems when translating date between different langauges and i think that OpenEngSB uses also long when you're asking for different versions
could this:

`$this->config['github_url'].'?'.$this->config['access_token'];`

be consolidated into a single function (e.g. `$this->get_url()` or something like that, that would do the work to detect if an access_token was present and build the URL accordingly rather than doing it in many different places in the code...
Call this directly from the caller?
But remove the hook by first call. Than should be removed
Remove all unnecessary version properties.
I prefer it this way, its clearer I think.

I can change it if you feel strongly about it.
That dialog is asking two questions.  Let's remove the 2nd one.
You might want to add an assertion to check that successCB has been called with the expected params, and same for failCB in the other tests.
If you say so :) done
indeed, the NodeInterface declares to be traversable which is a meta-interface http://ch2.php.net/traversable

i think you need to make another NodeMock :

    abstract class NodeMock implements NodeInterface, Iterator {}

and then use the mockbuilder with that abstract class. afaik that should work. the problem is the traversable meta-interface and that you can not tell the mockbuilder to create a mock from 2 interfaces. i looked through our code but did not find an example, thought we do this somewhere else too.

the backslash is just a question of code style. strictly you tell php to look for the meta character \S but php uses this as literal \ and S because there is no \S. as this is only test, i don't mind, we have this incorrect in many places, but some future version of php might decide to be more strict about this.
Same remarks
此处用`git clone`一份，是不是应该为 "用git / clone / 一份" ?