labofsahil/github-event-dataset-2012 huggingface dataset:
Thanks, that's the information I couldn't get anyone in the original thread to spit out.

Can you give me a specific commandline that segfaults? I'd like to put a comment in the formula so this doesn't get changed again until it actually works.
Pourquoi tant de haine :(
Should we undef the LKAIRSP_INFOBOX_USE_SELECTED in LKAirspace.h I suppose?
Actually in looking at the reason Corey mentioned this bug at all, the problem was that adding a user didn't create a home directory. The default of `useradd.add``` is to set home=False. If home=False, no the -m flag to useradd isn't added, if home is a string, it will do -m directory. I think that is ultimately what needs to be fixed.

Ultimately, I rescind my previous comment in that you and seth are both right. Upon looking at the problem more, the issue is that adding a user doesn't _by default_ create their home directory unless you explicitly define it. The default is set in /etc/default/useradd in any distro that uses the passwd package (every distro), and that should be honored unless explicitly set to be somewhere else.

On IRC, @whiteinge brought up the good point. In that use case, what is the best way to have a way to not create a homedir. Also, it is non-backwards compatible.
I know, but in the past I had this errors, now don't. so, I guess It's SQLlog bug, will Install new version
Disabling -static-libgfortran made everything work fine!
oops, my dumb mistake. however this only works for properties not needing magic __get()

doing:

$this->View->request->params['action'] = 'index';
isset ($this->action) will return false

now DebugKit toolbar doesnt show anymore because its doing if (empty($this->output)) check in DebugView
Let me explain why I don't think it is necessary:

https://github.com/danmar/cppcheck/commit/0d3bf5340d338f2a1795c81dfa2e0722a6f4e9d5#diff-1

In getVariableList I replaced a 'Token::Match' + similar string compare with 'string compare inside a string compare' (in this commit), which is more convenient and this handles good with legal C++ code, and so I copypasted that to setVarId to ensure that all legal C++ 'using' code doesn't have a non-null varId. Just check the code below with --debug:

```
namespace A { void f (); }


using A::f;
using namespace std;
```

no varids and no messages.

If there isn't 'using %var%;' strings check in the cppcheck checks, then the removal of it from the tokenizer is a real waste.

Where's the problem, then? Which code would confuse cppcheck? No one answered that with facts.

And if you're right about removing the C# 'using', you didn't answer to the question in the other commit:

> Robert, is it sufficient if I remove 'using %var%;' in simplifyJavaAndCSharp?
гхм... если "поправили" - это 1695, то все равно не компилится. желающие могут проверить, а я откачу оба коммита пока. потому что смысл их непонятен вообще, а ломают они как минимум компиляцию и с полсотни спеллов, если не больше...
I try to add this npc to map by command .npc add but i have this error :
SQL: INSERT INTO creature VALUES (520071,18701,556,1,1,0,0,-78.8433,176.361,0.00964563,0.267773,25,0,0,8114,3309,0,
SQL ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
please check it.
thx for research. some possible crushfixes in testing branc (for skadi - in sd2)
These exist above.  I'll do a pass to make sure i'm not missing function docs anywhere else.
afaict, this is not getting sourced. and I'm stuck with `WAFFLE_TABLE_SUFFIX = 'amo'`. here's what I'm getting when http://dpaste.com/hold/706138/
the styles for this should match those for the "No results found" text: https://github.com/mozilla/zamboni/blob/master/media/css/impala/listing.less#L155
Why remove the tests for the bad act code?
burde det ikke være utf-8?
OK, but for changes like this we like to know why they are necessary, before pulling something that looks like nonsense.
THis IS sample Project.
Mistake : It's not Function#average but Array#average.
@chrisfilo did you ever merge this? this is the same problem alex is facing
add includes in the alphabetical order
I agree. I've got a simple example started in the dev-examples branch. I'll merge that branch likely this weekend when I've gotten further on the docs and other examples.
@kylemcdonald - here's a Visual Studio project which can be easily linked into projects

##Steps to use in windows:

1. Add the ofxCvLib project to your solution
2. Add the ofxCv include paths to your project

Visual Studio then automatically compiles the sources and copies the dll's to your project dir

To be used with https://github.com/downloads/elliotwoods/ofxCv/opencv-vs2010libs(intel%20compiler).zip .
This is a set of DLL's compiled with intel c++ compiler for improved speed.
Whoops, this is new code. And I don't actually check for Truth.
oops i meant to have it default.
is goed
Should we also be performing `git clean -fdx` to ensure that any untracked files get removed?
I'm probably just confused, but this seems wrong.... The param description says _strXMLin is a Python string (which is also indicated by the name), so how can you do .getImageFile() on it in the next line?
This update adds unwanted space in the navbar dropdowns.
@norman Hoping to see this in gem form shortly :-) Thanks!
raise an exception instead
* SHA: be6a8cc1c1ecfe9489fb51e4869af15a
* User@SHA ref: mojombo@be6a8cc1c1ecfe9
* User/Project@SHA: mojombo/god@be6a8cc
* \#Num: #1
* User/#Num: mojombo#1
* User/Project#Num: mojombo/god#1
You don't need the condition:

    Array([]) => []
    Array(1..3) => [1, 2, 3]
Is this necessary? (Won't the socket options fail if the port is out of range)? And I'm not sure either 0 or 65535 actually work...
We need to run this evolution on all deployments:


    var tgt = function(value) {
      if(value == 0) return "view"
      if(value == 10) return "modify"
      if(value == 30) return "cms"
      if(value == 42) return "own"
    }
    db.Groups.find().forEach(function(it) { it.grantType = tgt(it.grantType.value); db.Groups.save(it); })
Here, this code is much clearer than mine.
Thanks.
Change event level from directory to file.
change_block_button should maybe have a default argument? To not conflict with the original gtk method.
So this is what I have so far on getting variable sample rates to work for vgmstream. While the player still works, it doesn't make any of the songs in vgmstream play at the speed they should be.

Songs that originally played too fast when testing still play too fast.

Is there anything that I'm missing ?
So happy for this commit. ^_^ (2-space indentation drives me nutty)
overall, lgtm.
Why are you doing this? It doesn't even make sense to use tables here, and you've completely lost visual feedback on node depth by dropping the node cells. Jon asked for different colors, not to remove them completely.
Might want to use an inclusive regexp, rather than a set of negative tests, and use `eatWhile`. For example `stream.eatWhile(/[^'",()\.]/)`.

You don't have to accumulate the token yourself, you can get it with `stream.current()` (after having the stream consume it).
Okay, I was just a bit worried that I had been misunderstood.
А вдруг у кого-то нету своего логотипа :)
If you update the vendors in Symfony 1.0.9 with the options described at http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html and DoctrineMongoDBBundle locked at version v2.0.0 there are also error messages. 
Is there a list of compatible versions/commits of DoctrineMongoDBBundle, doctrine-mongodb-odm, doctrine-mongodb and the other components?
Is the end datetime set to 23:59:59 on that date?
We are in #travis on freenode if you have questions or need help.
I would prefer putting only the call to the comment or even only the command into the if-statement, since this is what differs.
The comment is good :-)
These three lines:

```

  ok( false, "" );
  endFired = true;
}
```

have a tab at the front of each
Please update help text, icons, etc. to change "Speedometer" to "MobiPerf".
в BaseView.js на 798 строке уберите коммент

798: ```// 'user_id': $('#user_id').val(),```
mira te comento, lo estoy test en arkcore, me habia equivocado en una parte y cambie la id y solucionado, el drama es este ahora no dice eternamente,ahora, como es tuyo tu sabes como funciona, te agradeceria si lo test tambien en arkcore.
+1. I am going to remove SNAPSHOT in release tag.
Are there really that many changes or is this a result of collision of different tabbing styles? If this is caused by tabs, I suggest that we would have a standard for tabbing. It is now a little bit tedious to merge these changes to https://github.com/muiku/h5bp-zendframework/blob/zfint/build/build.xml
Why not use something local?
ok, I think I understand it, it could be improved a bit.
1 - I believe I explained already in my prior post - the ZIP extraction routines I run as a a separate process beforehand - first the ROM is unzipped (if the file is of type ZIP), then it will check which extension this ROM has. After that, it calls load_rom with parameter '0' for detect_system. 

Either you could standardize the ZIP loading routines so that these are no longer port-specific and all the ports can use the same routines, or else I see no other way around it. With regards to upper-case ROM extensions - I still like to cover all bases regardless - surely a few extra 'strstr' lines can do no great harm.

About the defines - I think I already listed them before in my post - but I will do so again -

(two underscores)LIBSNES(two underscores) - This is the define for all Libsnes ports.

(two underscores)CELLOS_LV2(two underscores) - This is the define for the PS3 in general.

(two underscores)_XBOX(two underscores) - This is the define for the 360 in general

(1 underscore)MSC_VER - This is the define for both the MSVC 2010 PC and 360 solutions.

HAVE_ZLIB - This is a Zlib define.
what will this do? (havent followed the calender project).
With this commit partial spell resistance is broken, can no longer partialy resist spells. Like in Fireball did 400 dmg (232 resisted).

Also problems with _DEST_ spells like blizzard, sometimes it doesnt "reach" the place where it's casted but the animation works.
So far I haven't. This was done at a "gardening day" at my current company (acquia).
We don't use minitest in production anymore, so other things are a bit more pressing for gardening days at the moment :(
ok. i get this error when building:

g++ -o ThirdParty/PngImage.o -c -DROUTED -I/usr/include/libxml2 -I/usr/local/Cellar/libstxxl/1.3.1/include -I/usr/local/Cellar/boost/1.48.0/include -I/usr/local/Cellar/pngwriter/0.5.4/include -I/usr/X11/include ThirdParty/PngImage.cc
ThirdParty/PngImage.cc: In function 'void<unnamed>::readPngData(<unnamed>::PNGStructPtrs&, unsigned char*&, int&, int&)':
ThirdParty/PngImage.cc:148: error: invalid use of incomplete type 'struct png_info_def'
/usr/X11/include/png.h:666: error: forward declaration of 'struct png_info_def'
ThirdParty/PngImage.cc:148: error: invalid use of incomplete type 'struct png_info_def'
/usr/X11/include/png.h:666: error: forward declaration of 'struct png_info_def'
ThirdParty/PngImage.cc:149: error: invalid use of incomplete type 'struct png_info_def'
/usr/X11/include/png.h:666: error: forward declaration of 'struct png_info_def'
ThirdParty/PngImage.cc:150: error: invalid use of incomplete type 'struct png_info_def'
/usr/X11/include/png.h:666: error: forward declaration of 'struct png_info_def'
ThirdParty/PngImage.cc: In member function 'bool PngImage::loadImage(const char*, bool)':
ThirdParty/PngImage.cc:212: error: invalid use of incomplete type 'struct png_struct_def'
/usr/X11/include/png.h:795: error: forward declaration of 'struct png_struct_def'
ThirdParty/PngImage.cc: In member function 'bool PngImage::loadImageFromMemory(const unsigned char*, unsigned int)':
ThirdParty/PngImage.cc:259: error: invalid use of incomplete type 'struct png_struct_def'
/usr/X11/include/png.h:795: error: forward declaration of 'struct png_struct_def'
ThirdParty/PngImage.cc: In member function 'bool PngImage::saveImage(const char*, bool) const':
ThirdParty/PngImage.cc:297: error: invalid use of incomplete type 'struct png_struct_def'
/usr/X11/include/png.h:795: error: forward declaration of 'struct png_struct_def'
scons: *** [ThirdParty/PngImage.o] Error 1
scons: building terminated because of errors.
Tested this on retail, also fixes summoning through doors exploit
Dafuq, just change 
if (m_targets.GetUnitTarget() && m_targets.GetUnitTarget()->GetTypeId != TYPEID_PLAYER && !m_caster->IsWithinLOSInMap(m_targets.GetUnitTarget()))
if you are sure that spells should interrupt on Npcs as soon as they walk LoS ;)
No need to create a pull request
Inversão
Lots of typos in the comments there...
@plataformatec hey! could you guys release a new version with this? please please please?
This is causing me issues too.  Is there a workaround?
Thanks so much! I will re-do my chardb and check it out!  authDB hasnt changed at all right? Im using the old authdb so that my current main realm's core can use it. definitly going to check out todays changes :D
40%? should not be 10? ;)
On 1/10/2012 5:36 PM, Brad Roberts wrote:
> What a concept.. symbolic names
>

They work for the SIMD instructions because there is usually only one 
instruction per pseudo-op name.
I just noticed that some stuff of mine that you have merged has now disappeared.

The most obvious one "getBufferedAmount()": what the heck?

I thought it would be ok for me to upgrade all my code to suddenly move to the new package naming, but now I think I'll have to hold my horses.
I do need those functionalities: where did they go?
here is a real world script that shows what i am talking about https://gist.github.com/2004061  , that is logo.php on a side project, sure there are better ways to do what its doing but this shows what i am talking about.
Actually, once I figure out how to accept this I am going to accept in out of principle.
register/ and activate/complete are also defined in registartion.backends.default.urls but we are explicitly overriding them here.
I thought I fixed that already; must have been for some other project.

On reflection, it was redundant anyway - after $(ACTIVATE) we're automatically installing to the right place
I don't know what that is

On 10 Feb 2012 17:29, "Dustin Fennell" <
reply@reply.github.com>
wrote:

This probably doesn't do anything

---
Reply to this email directly or view it on GitHub:
https://github.com/Agilefant-Finnucks/agilefant/commit/197a024e4a883429d25ff32dd0a5c3aead27352b#commitcomment-955954
I've seen it elsewhere (for instance, https://github.com/rails/sass-rails/blob/master/sass-rails.gemspec). I believe the thinking is that you may have an app that uses only parts of rails, but not all of it. If you have railties, you have engines, so you can load this gem.
Hm.. I'm not exactly sure how I missed it. I was checking your dev branch a few days ago and somehow I believed that this code is not yet ported.

Anyway, good to know, I'll rebase my branch, thanks!
@FernFerret Thoughts on this? I wasn't certain if there was some other reason for the way it was being done.
Is there a reason why these can't all be the same class?
You can use <tt>fail("Interrupted.");</tt> instead.
They have added and deleted it before. It is important to not add unneeded files to the project.
Great. Thx for giving me the details about this. Great to hear that the
example works out well. In case you plan too drive this any further feel
free to ping me on the ops4j list to discuss a solution how this can be
solved cleanly.

Kind regards, Andreas

Send from my mobile. Please excuse the brevity and/or possible auto
correction errors.
On Feb 7, 2012 5:50 PM, "Zach A. Thomas" <
reply@reply.github.com>
wrote:

> Sling is (among other things) an HTTP front-end to Apache Felix. It
> determines how each request should be delegated (which servlet, etc.). So
> by "claiming" a path for use by the Wicket app, Sling will delegate
> requests for that path to the right place.
>
> This isn't in production or anything. I was doing an experiment to see if
> Sling and Wicket could co-exist. The experiment works, but I haven't tried
> to take it any further.
>
> Cheers.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zathomas/org.ops4j.pax.wicket/commit/5b2387e590db40b6514f08eb454d24d42bc0cbda#commitcomment-941751
>
No, you don't have to. You initially add files to the repository and then
git automatically tracks whatever changes you make. Try it. I also advise
you to read a git tutorial when you have time.

On Sun, Jan 15, 2012 at 17:25, Menachem D. Mostowicz <
reply@reply.github.com
> wrote:

> Why not? I thought you needed to execute a ```git add``` before each
> commit to select the files to be committed.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/InvisibleEngineer/XKCD-Downloader/commit/cc821d27bbf8ce02c913a44651220b17fd9eef9c#commitcomment-868565
>
I like the idea of having only interfaces in the public API. It may even be sufficient to only have `ResourceBundleLocator` in the public part, accompanied by a factory for creating instances as needed:

    //returns PlatformResourceBundleLocator
    ResourceBundleLocator locator = new ResourceBundleLocatorFactory().forBundle("foo");

    //returns AggregateResourceBundleLocator
    ResourceBundleLocator locator = new ResourceBundleLocatorFactory().forBundles("foo", "bar");

WDYT, should we leave it as is for 4.3 (that is, only move the enumeration into the locator class to get rid of the import) and aim for the interface-only solution in 5.0 in order to avoid breaking existing clients of the concrete classes in 4.3?
Here: https://www.codeaurora.org/gitweb/quic/la/?p=platform/hardware/msm7k.git;a=tree;h=refs/heads/gingerbread;hb=gingerbread 

I also borrowed part of the FM routing code from rmcc's libaudio work on either the lge swift or p500, and adapted it for the U8160.

If you're going to test this, make sure to check if Bluetooth audio during calls works.
if I was gunna be super picky I'd say this was missing a fullstop, not important tho!
You should add more `background-image` for browser compatibility: `-webkit-linear-gradient`, `-ms-linear-gradient`, etc ...  Like in [bootstrap](https://github.com/twitter/bootstrap/blob/master/bootstrap.css#L1400).

And by the way, `center top` doesn't work for me, but `top` works (I'm using Chrome).
Seems like the mocks should either be pending or maybe implement this stuff? If nothing else we should probably have a ticket for implementing the rest as I'm afraid it may otherwise get lost in the shuffle.
I doesn't return updated conditions now. Can I fix it anf you'll have a look?
As above, while troubleshooting the tests with actual Regal code,

1) LIB.SHARED -> LIB.STATIC (otherwise loading the shared library without requiring an installing is problematic)
2) REGALTESTS.LIBS needs to apparently include "-lm -ldl" before it works.

I will update this patch first thing tomorrow with these (and maybe one or two more) fixes, FYI.
Why do you return so many "result"? Are they all needed?
We'd better not put dialogBox into jQuery's namespace, as it depends on jQuery-UI
Yes, in the long run, we should do that.
if we're throwing the error, no need to log it here.
By the way, why do we need this class anyway? Couldn't we just use `net.spy.memcached.CacheMap` itself? it's a map and it should handle most of everything provided by this already?
What is the ErrorAttrs for? Is it actually necessary to remember that an attribute failed?
I guess so. What's your thinking?
Should include what happens if there's an exception thrown
Quite a few functions allocated here for every call, makes sense to optimize it
would it make sense to remote this method altogether and call `shutdownClientConnection` instead (it's only used at one place)
why this dance? just `extends TestKit(ActorSystem("TimerBasedThrottlerSpec"))`
Absolutely. Will add comments.
Maybe you can add that zero rates are skipped and therefore the occurrence rates are not evenly distributed (for instance is not possible anymore to derive the bin width by making the difference between subsequent magnitude values). Wouldn't be possible to put this filtering mechanism in the Source class, so that the occurrence rates are still evenly distributed? From the scientific point of view, zero rates are informative as non-zero rates.
Maybe change:
  "to handle distributed content"
to:
  "to provide remote content management"
not "Wanted" here, right?
Looks flaky...
Hm very odd. I wrote all of this code on win32 (actually I took it out from one of my branches which uses StringUtils::Format() all over the place and it always worked. I also wrote and ran the unit test for this method on win32 and it worked as well. wtf is going on?!
I think this extra [] around key is a bug.
beforeCheckRequiredFields needs to check p1 == p2
Yeah, that makes sense.

If you're going to resort to magic, probably `__getattr__()` is the better way to go (so people can just do `self._opts.interpreter`). Does that sound like a reasonable refactor to do for v0.4?

When you do use `__underscore__` methods and other Python magic, I would like you to keep [this video](http://youtu.be/6bEu9wLDjKY?t=1m33s) in mind.
Mostly a "just in case" kind of habit.
I think it's better to throw the exceptions , otherwise if an unexpected exception happens we swallow it and the test passes, when it shouldn't
i am not sure if this is a good thing to do
it is consistent for internal use, but for others it will be confusing since they will have to always add `ace_` in their css
I guess the second line is the correct one!
Assetic is using ``getFunction`` in a NodeVisitor when looking for assets. But it is checking if it is an instance of AsseticFilterFunction anyway so it won't break it.
This should use `TUIEdgeInsetsMake`. That's why it exists.
remove this and the other `error` debugging statements
I'd use a `while` loop here like in my "line" events gist: https://gist.github.com/1785026, but I won't nitpick
I should try this in a browser too. I bet I want to filter out "native code" or something like that.
Sure, lets talk about it the next time we meet. Thanks for the heads up.
I think this change already makes sure that accumulator updates only happen once -- if the task is re-run, the executionCount will be > 0.

But now that I think about this more, I don't know if that will work if the final rdd hasn't been executed before, but a dependent one has.  probably need a test for that.  Though, if this doesn't do the trick, I'm not sure how to fix it ...
Can you check this change hasn't broken `rosie lookup` and `rosie ls` - from the file view I see line 426 in `def _display_maps` is still using self.common_keys() - should fail as far as I can see.
whoops, was easier to test with one group... fixed now
лучше убрать префикс get, его нигде нет вроде. это как-то  архаизм
&& перенести на другую сторону, на следующей строке отступ 2 таба
I think you don't need this `reload` line in both tests, because it's a fresh developer instance.
How about changing this one to test `options_for_select` with special chars instead? :)
Actually, it'd probably even be more readable to move the class definition to the top of the file, outside of the ValidationsTest class.
This send seems a smell. I think we should refactor to make this method public but part of our private API.

cc @tenderlove @jonleighton
It's the best place to put this code yeah :trollface:
Yeah, I wasn't terribly happy about this either; this sounds much better. So yay on there being multiple instances of the class, but store them in a hash, yeah?
`TreeInfo` would probably be a better place for this method
It can be removed.  All this code was just copied verbatim from `numpy.histogramdd`.
and instead of `function` it would follow the other functions example if you used `expr` instead.
In general, the spaces should be fixed in all the above: `(J, P, Jcells)`
apparently the second argument of such methods should be "other"
On Jul 13, 2012, at 3:49 AM, Stefan Krastanov
<reply@reply.github.com>
wrote:

>> @@ -182,6 +182,9 @@ def __getstate__(self):
>>     def _hashable_content(self):
>>         return Symbol._hashable_content(self) + (self.dummy_index,)
>>
>> +class IntConst(Dummy):
>
> It is used by default when outputting the results, however:
>
> - it is done by substituting all symbols starting with "C" *at the end of `dsolve`*. It is not at all used internally.

That's pretty hackish. Why not just replace it internally?

> - the fact that the names do *not* start with a "C" permits the solver to distinguish constants that were created internally (not instances of this class), from constants that were already present in the input. This is important if we are solving triangular systems, because otherwise the constants get mangled. In the future the internal methods should also use this class (as it subclasses Dummy, there will be no ambiguity based on name strings), however this would require quite the effort.

It doesn't seem to be much effort to me. Maybe I'm missing something?

> - the "C" in front of it is added by the printing methods.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1322/files#r1157506
fixed.


On Mon, Nov 19, 2012 at 7:50 PM, Aaron Meurer <notifications@github.com>wrote:

> In sympy/unify/__init__.py:
>
> > @@ -0,0 +1,12 @@
> > +""" Unification in SymPy
> > +
> > +See sympy.unify.core docstring for algorithmic details
> > +
> > +See http://matthewrocklin.com/blog/work/2012/11/01/Unification/ for discussion
> > +"""
> > +
> > +import core
> > +import usympy
> > +import rewrite
>
> Yeah, the imports still work. Importing from sympy.unify.core bypasses
> __init__.py completely. (Unless I am mistaken), __init__.py is only ran
> with import sympy.unify and from sympy.unify import stuff (stuff being
> specific names or just *).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1633/files#r2175836>.
>
>
This is the default that you had used previously. I remember reading a note of yours sometime, where you indicated that you found the colors of the default highlight theme too flashy for pdfs.
and for `knitr-lang.md` too :)
Do we need checks here? Aren't these used in `publish()` only?
@cebe Thanks. Will do.
Here is a link from @samdark, which was mentioned when I have asked for use case of duplicated Meta tags:
http://developers.facebook.com/docs/opengraphprotocol/

If in this example I will attach several images or videos using Facebook Meta tags, I would be unable to append same video (meaning same HTTP link) with different options like a player size, in the current @qiangxue implementation.

For example I want to make following code:
<pre><code>
&lt;meta property="og:video" content="http://example.com/awesome.swf" /&gt;
&lt;meta property="og:video:height" content="640" /&gt;
&lt;meta property="og:video:width" content="385" /&gt;
&lt;meta property="og:video:type" content="application/x-shockwave-flash" /&gt;

&lt;meta property="og:video" content="http://example.com/awesome.swf" /&gt;
&lt;meta property="og:video:height" content="800" /&gt;
&lt;meta property="og:video:width" content="600" /&gt;
&lt;meta property="og:video:type" content="application/x-shockwave-flash" /&gt;
</code></pre>
The current implementation will not allow me to do so! I will not be able to register “og:video” for the same file twice and I will not be able to specify the “og:video:type”. So if I will use the original implementation I will receive the following:
<pre><code>
&lt;meta property="og:video" content="http://example.com/awesome.swf" /&gt;
&lt;meta property="og:video:height" content="640" /&gt;
&lt;meta property="og:video:width" content="385" /&gt;
&lt;meta property="og:video:type" content="application/x-shockwave-flash" /&gt;

&lt;meta property="og:video:height" content="800" /&gt;
&lt;meta property="og:video:width" content="600" /&gt;
</code></pre>

The original implementation has an error, which has been made while under the influence of such methods as “CClientScript::registerCssFile()”, and you just don’t want to admit it. 
I have already told you, we must reconsider this issue from the beginning.
Unlike you, I do not fear to admit I was wrong: I do NOT say the Meta tags always should be replaced, I do NOT demand the “CClientScript::registerMetaTag()” method to be removed or fully reworked.
Is that a good or bad "!!!" ?



On Wed, May 23, 2012 at 9:20 AM, Robert Martone
<reply@reply.github.com>
wrote:
>> +          break;
>> +        case "bottom":
>> +        case "below":
>> +          decorators.push("/scripts/lu-decorators/positionBelow");
>> +          break;
>> +        case "left":
>> +          decorators.push("/scripts/lu-decorators/positionLeft");
>> +          break;
>> +        case "right":
>> +          // same as default
>> +        default:
>> +          decorators.push("/scripts/lu-decorators/positionRight");
>> +      }
>> +
>> +
>> +      require.ensure( decorators, function ( require, module, exports ) {
>
> !!!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Iheartweb/Lu/pull/140/files#r868836



-- 
jimg at yojimg dot net
This is susceptible to SQL injection attacks. You should only append the order by via a prepared statement. Or you should make the order by arg look up field names and validate.
I'm pretty sure we can't pick a different name. TestResult wants a test_method because it does inspection on that method to determine its name and other information about it. The name of the method has to be 'run' because everything else in the chain expects it to be named that.

I agree that this method of communicating test completion is hacky, but it has the benefit of working without requiring a significant refactor, so I'd like to roll with it for now.

I also agree that the least I can do is add a comment explaining all this insanity, so I will do that.
I guess you could make a good argument against transparently preferring the encrypted version since it makes it impossible to use the unencrypted version if the encrypted one is present. I'm OK with removing the implicit `.gpg` check if you think that's a problem.
Это пока отложи. Хотя бы слзданные пока сделать
make this a ..versionchanged block. 

Maybe link to the `:setting:\`journal\`` for other platforms:
within the range a single shard can process.
this will prevent the MindTouch call, but do we want to update this to link to the appropriate Kuma doc url?
Trailing whitespace. Please instruct your editor to automatically remove these.
`row-fluid`
That won't work as db test case does not inherit from test case.
Please put all comments on their own lines.
The loose is not more robust than the strict comparison.
Anyway, I'll change if you still say that the loose is preferable to the strict one.
What did apache write in error log when it produced a 403?
@rxu user_posts just contains the no of displayed posts not total posts
I think it might make sense to always have a return statement in wrappers, so you don't have to update them when the real function changes. Does that make sense?
If you're not going to check for the existence of the array element, we are using PHP 5.3+ so you can do:
`$config['site_home_text'] ?: $user->lang('HOME'),`

I would prefer using empty() like so:
`!empty($config['site_home_text']) ? $config['site_home_text'] : $user->lang('HOME'),`
This is better, but we can still fail to schedule the check if the run doesn't fire the callback.  We need to set another timer.
Yes +1
autocomplete :|
结束时间也加上吧，但非必填
Why internal? `Private readonly` should do the trick right?
I thought we were going to rename Dashboard to AppGrid to avoid confusion with patient dashboard
This comment doesn't make sense here. you should put it with the code for the TopBar
what's wrong with ```num_data```?
I could argue that the extra spaces make it harder to tell if those lines are assignments or keyword arguments. But that's not really the point. PEP8 doesn't reflect the innate preferred style of any of us - it's just a common standard so we have consistent code and can get used to reading it, no matter who wrote it.

In other words, I'm in favour of the fix you've supplied which removes the spaces. ;-)
Simpler way to achieve the same thing:

1. Add an ``else`` statement to the ``if len(batch_args)`` test, setting ``batch_size = None`` in this case.

2. Replace the 3 cases in your code by:

```python
if time_prof_args or batch_args:
    return run_tests_in_batch.main(batch_size=None, time_profile=bool(time_prof_args))
```
That seems to work very well :)

On Fri, Sep 14, 2012 at 8:42 AM, nouiz <notifications@github.com> wrote:

> In theano/sandbox/cuda/async.py:
>
> > +    """
> > +    def make_node(self, x, event):
> > +        if not isinstance(x.type, tensor.TensorType):
> > +            raise TypeError(x)
> > +        return Apply(self, [x, event], [tensor.TensorType(dtype=x.dtype,
> > +                                         broadcastable=x.broadcastable)()])
> > +
> > +    def c_code(self, node, name, inputs, outputs, sub):
> > +        inp, event = inputs
> > +        out = outputs[0]
> > +        fail = sub['fail']
> > +        # eventName = "%s_event"%event
> > +        return """
> > +        cudaEventSynchronize(*(cudaEvent_t*)(PyCObject_AsVoidPtr(%(event)s)));
> > +
> > +        %(out)s = %(inp)s;
>
> You just make me thik, you need to inref if. Py_INCREF(%(inp)s);
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Theano/Theano/pull/922/files#r1607575>.
>
>
Remove it already. I should clean it.
suggest: starting with str = "", so += is always applicable.
I think you are reading too much into my comment. All I am looking for is something like this:

            # Parse the verb command line.
            verb_opts, verb_parsed_args = self.parse_args(verb_cmdargs)
            # Post-process options.
            self.process_verb_options(self.verb, verb_opts)
            # Post-process arguments.
            self.process_verb_arguments(self.verb, verb_parsed_args, verb_opts)
            # The arguments should all be attributes in verb_opts now.
            verb_args = []

that makes it clear that the value of verb_parsed_args is not referenced before or after this block.
You could get that impression in the original code f you glossed over how verb_args was unconditionally assigned at the start of the block AND at the end of the block, so the one variable was being used for a completely different value/purpose inside and outside the block. Nothing about this change has any effect on copying or mutations AFAICT.
Well, does that mean you see it as acceptable solution for this issue? Tho anyway I will look into Unit::HandeProc and few other places and will try to make something out of it, but not sure if I will have time today to show anything.
indent 4 spaces?
Duplicate specification date on this line.
@mikesherov cool - we should add a comment line with the ticket number
Agreed, special values like this that have mathematical roots need to be properly documented in the code so that people know why those values were chosen.
I'm a little confused - where does req._serviceName come from?
Oh shoot. I have VS set to tabs. Am I gonna have to switch my whole solution over to spaces?
Oy--I'm getting all the indentation confused. Do what @rlr suggests. It's the sumo/webdev convention.
Thanks. I apologize for nitpicking but I use this feature all the time.
It is removed. (note the '-')
Quand tu passes dessus profite en pour corrigé les caractéres bizarre
Logan's recent OAuth merge included some changes to abort() to add additional info: https://github.com/reddit/reddit-public/pull/562/files#L7R70

Instead of creating Yet Another Abort With Error Message (I'm pretty sure we have two now), is it possible to use/adapt some of that code?
`for dep in "${deps[@]}"; do`

All `do` and `then` should be on the same line
Sorry, my concern was less about the number of lines in the methods, and more whether extracting the methods improved understanding that much.

If I see compareNames(m1, m2), I can guess what that means, but inlining the method call to get m1.getName().compareTo(m2.getName()) makes me sure, without much in the way of line noise, it seems.
I agree with you. Work is done.
Hmm. Not sure what I was smoking here.
`startTransition`
Because getIndexFromChunkMesh is not fully implemented in this PR, you can do it if you want :P
Nevermind, I'm giving up on this. It would probably take me all afternoon (if I was lucky) to deal with the upgrade from 1.7 to 2.0 of the Windows Azure Storage Client. Not worth it unless doing it for real.
I think we can remove the ternary expression -- it seems like a no-op
Good point, thank you! Blind copy and paste error.
It's been a long time since I've written a bash script. :) I found http://tldp.org/LDP/abs/html/testconstructs.html#EX11 to explain the double square brackets. I'm not clear how it would help here though.
I was thinking of only exporting copyFile and copyDirectory to be a simpler interface.

It looks like copyFileEntry and copyDiretoryEntry are only used in SpecRunnerUtils.js and don't need to be exported. Then you can rename copyFilePath to copyFile, and rename copyDirectoryPath to copyDirectory.
Will we enforce commandFn to return $.Deferred? For synchronous commands with no return value, it's a minor annoyance to add "return new $.Deferred().resolve().promise()".
Shouldn't there also be a `('completion', _('Completion Time')),` option?
It'll be at least another day. The API side isn't hooked up yet.
OK, this is really badly documented, but it is here:

https://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.base.View.dispatch

It means that in any class method you can use `self.request`, `self.args` and `self.kwargs` to access those variables as they would be passed to view if the view would be a function.
Value is set with jQuery.
Lets add another parameter here for the config block that can be pass to sequelize:

```javascript
{
  db: String
  username: String
  password: String
  config: {
    ...
  }
}
```
This needs to get wrapped in document.addEventListener( "DOMContentLoaded", function() { ... }, false); or Butter will blow up.
This looks a bit wrong. Too many *'s?
managed to write a regex to do this in one call: replace(/['\\"]/g, "\\$&")
What's the point of `__mouseDiff`?
can't we listen for page resize instead of polling?
The api is a bit strange 'unwatched' with 'true' will use the next enum value which is 'watched'.
However, I changed it to 
pFileItem->SetOverlayImage(CGUIListItem::ICON_OVERLAY_WATCHED, false);
TIL! Sounds good!
limit (
You should make these configurable
Same as above--this doesn't assert that the view falls back correctly. So we should either adjust the docstring or the test.
Using the RFC number is most precise, but I understand your reasoning.
Call it DDNS then maybe, though first search-engine hit points to
http://en.wikipedia.org/wiki/Dynamic_DNS which doesn't help much
to clarify for newbies...
this should probably return `v` like it does when the `try` succeeds, no? The `assign` for the bounded case below as well.
(Not that it matters that much in practice, since the brackets syntax overrides the return from `assign`, but still)
@system.autoheal = val.start_with? '1'
I think it would be a good idea to put in one scenario with a sad path: either creating or updating a unit for which the name is taken, and checking that you see the error message.
`_hubs.Value` dictionary contains multiple entries for a single hub (with different indices, like type name, full name and name provided by attribute), but the values returned must be distinct.
O2?
It seems pretty confusing to have the configuration item be named `max_columns` while the module configuration constant is `MAX_WIDTH`.  Unless there is a good reason otherwise it seems like following the rule of UPPER / lower case analogs is a good idea.  In the configuration documentation that is implied by all the examples, though not stated (as far as I saw).
I didn't realize until now that there's a URL path that completely bypasses `cache_remote`. If you look in `cache_remote`, you'll see it also has some code that prints download times to the terminal.  Perhaps you should factor this out - the intent of that code was for it to be used everywhere, so that the user gets feedback regarding how long their file download will take.  Otherwise, it just hangs until the download completes.
It may be short this much.

```
taggable 'nwm'
```
你没改？ 那我来改把。
yeah, sorry for the confusion
Just do this.  But add a comment so somebody clueless doesn't later decide to 'optimize' the two macros by collapsing them into one.
True, removed in [b5af663cc573943b5f99c2c917ede0f641d89951]
no, the message is much longer than the key, it is just that the first 8 bytes is the key.
I don't speak any chinese, but it looks somehow suspicious that the 'c' of "cppcheck" is gone.
should be simply ``if``, and the braces are useless around ``instanceof``
Why does a `ClientPanel` have a `central_widget`. As I understand this, the ClientPanel represents a non Enaml widget embedded inside an Enaml hierarchy. Or is the docstring for this class incorrect?
We wrap all the other XML files - for consistency, I'd suggest we do that here as well.
It's better to use `on.exit` here, so that the env vars are restored even if there's an error.
I would say "flags" (plural) above, and perhaps say "can be passed/specified/given..." rather than "called" multiple times, but the code looks solid.
corresponding. Space before filename.
$a.insert ($value, [ $key ] ),  since we can store any kind of object
My school time wasn't perfect, have to make one more fix.
Also: `git_indexer_stats` is used to report network-transfer progress. Just sayin.
Again `unsigned int *` instead of `int *`.
I'm not sure I'm following your last sentence, could you expand on that for me?
>When the application is the first party to send the "close notify" alert, SSL_shutdown() will only send the alert and then set the SSL_SENT_SHUTDOWN flag (so that the session is considered good and will be kept in cache). SSL_shutdown() will then return with 0. If a >unidirectional shutdown is enough (the underlying connection shall be closed anyway), this first call to SSL_shutdown() is sufficient. In order to >complete the bidirectional shutdown handshake, SSL_shutdown() must be called again. The second call will make SSL_shutdown() wait for the >peer's "close notify" shutdown alert. On success, the second call to SSL_shutdown() will return with 1.

Since we are re-using the SSL connection, we need to wait for full termination. I think.
This should remain &profile.  Right now you are having it store the profile pointer into a undefined memory location.
"top_text" was dead as well.
This will never be None now, so you can delete this line.
Can you reuse configman's class_converter here instead?
Should we add these set size elements to the stats?
Let's clarify just a bit: custom ACLs == talk to opscode-authz.
Yes, it makes sense to provide TryParseAndVerify as a concrete method.

For the record I also wouldn't mind a ParseAndVerify concrete method as long is it throws another type of exception than HttpResponseException...
Yeah that's pretty ugly, will do.
IMO this means the request has too much responsibility. It should be the client that creates the connection, injects it into the request, and handles the case of redirection.
IMO you should typehint to `array $options`
missing space between the ``if`` and the brace
Why not simply remove it from the class all together since the function is in the interface anyway?
If I understand you question right, you should see difference between user's(sympy-bot.conf) and bot's(gh_values.py) defined values. First stores user defined values such as login or password from your account. Second stores repo name, owner's login and other related values. So these files have different purposes.
I'm not sure this is a good idea. [`empty()`](http://php.net/empty empty) is considered harmful. What was wrong with null? I'd recommend changing to `$ua !== null` as opposed to opening it up further. Otherwise it can cause some really strange situations where a value is passed and it ends up ignoring it completely in favour of the lobal http user agent. empty is very very tolerant, even worse than PHP's boolean false casting (such as string "0".

When for some reason `UA::parse()` is called with an empty string or "0", I would expect it to return an object with all the properties in some kind of generic state, not a fully parsed object for the global http user agent.
`new' not needed.
But then the regexpsub returns nil which is not considered to be boolean then. Have you tested that it actually works?
这个地方我也不太清楚，我在本地查看的话是没有乱码的。下回提交的时候我再仔细检查一下这个地方吧。
Ok, good to know I won't have to worry about this.
```pass``` not strictly necessary.
这里加了单引号之后就不能读配置了吧
put the URL in the pom
This is kinda weird. Why do we need this here?
I don't think we support 1.6 anymore.
Nitpick: CS
As mentioned above, this step should be folded into the "create an apartment" step.
Its nitpicking I know :-)
OK I get it now.
See other comment asking if OSGi should depend on JPADeploymentMarker.isJPADeployment().  If not, then this package change is not needed.
What's the purpose of this print?
давай тут лучше id, а не nick. И с constraint'ом на users.id
Use a switch ?
Nit (for consistency):

```javascript
document.getElementById("icc-mainheader").hidden = false;
document.getElementById("icc-mainentry").hidden = false;
```
the event listener should bind on oldPanel to prevent any unexpected `transitionend` event happens.
This color is not the one stablished in Building Blocks.
What's this heroku app for?
Why do we need to comment this out?
If you change "aboutPhone" for "deviceInfo" (which is a good thing), please remove "aboutPhone" from settings.en-US.properties, too.
https://github.com/mozilla-b2g/gaia/issues/2328
I think it is incorrect to use audio/* here.  (And I see I have the same bug in the Gallery app.)  The wildcards are used in the manifest.webapp file for matching, but here you should use the actual audio type.  file.type should work, I think.
A few days ago, playback was working. I retested this morning, and it goes through the motions, but I don't hear any audio. My otoro is still running GB, although it will be updated to ICS later today. Once it's updated, I'll retest all of the media stuff.
it's a problem of indent as you said me via skype :)
Why the instanceof check? Shouldn't we just check for null?
*nod*  Thanks.  #296 captures the need to go back and address that in the other brokers as well.
For consistency, use (!!x ^ !!y), and where's my ';'?
Why do you do this? Why does this count as "decoding"?
Leaving to be consistent with god interface.
это генератор
I'll get an example for you later today.
This doesn't seem to be the right place for this code.
I suppose if `build_wait_timeout` is negative, then the slave is running for ever and could potentially reconnect during that time?
The got_revision is only valid for the sourcestamp that caused the got_revision. In the case where there is only one sourcestamp the property 'got_revision' can be used. For the other cases got_revision does not work. I remember that we talked about this to accept got_revision not to work for multiple repositories until the got_revision is also stored somewhere in the database.
My proposal is to change the code to use 'got_revision' in case of a single sourcestamp.
https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/buildstep.py#L816, but see https://github.com/buildbot/buildbot/pull/440#discussion_r919202 for a different view.
I wanted it to run stand alone and natsort is just sugar but I will look at naturalSort. I just don't happen to have buildbot installed.

 I didn't want to bother with 2.5 since it's just a contrib script and someone using python 2.5 is using a seriously stale system.