[Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)
merged branch bdmu/ticket_5233 (PR #5234)

Commits
-------

47b8538 [Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)

Discussion
----------

[Filesystem] missing readlink breaking FilesystemTest class on Windows

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5233
Todo:
License of the code: MIT
Documentation PR:

fix for windows plateform

$file == 'C:\Users\USERNA~1\...' before touch
$file == 'C:\Users\Username\... after the touch and readlink so it can pass following assertEquals

---------------------------------------------------------------------------

by bdmu at 2012-08-13T05:35:07Z

Hello,

Another solution may be (need to test it) to add
    $this->workspace = realpath($this->workspace);
line 36, after the
    mkdir($this->workspace, 0777, true);
in the setup method

Regards,
Christophe
Update src/Symfony/Bundle/FrameworkBundle/composer.json
merged branch guilhermeblanco/patch-11 (PR #5310)

Commits
-------

595a974 Update src/Symfony/Bundle/FrameworkBundle/composer.json

Discussion
----------

Update src/Symfony/Bundle/FrameworkBundle/composer.json

Supersedes #5308

---------------------------------------------------------------------------

by guilhermeblanco at 2012-08-21T16:50:10Z

ping @fabpot
[Form] removed getPositions from PropertyPathInterface

this method was just an implementation detail (that is not even needed) and should not be part of the public API as it serves no purpose
Fixed a typo
[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
merged branch Tobion/proppath (PR #5313)

Commits
-------

79a1257 [Form] removed getPositions from PropertyPathInterface

Discussion
----------

[Form] removed getPositions from PropertyPathInterface

This method was just an implementation detail (that is not even needed as my implementation shows) and should not be part of the public API as it serves no purpose.

---------------------------------------------------------------------------

by fabpot at 2012-08-22T06:19:35Z

ping @bschussek

---------------------------------------------------------------------------

by stof at 2012-08-22T09:11:51Z

what is the performance impact of your implementation compared to the previous one ? the form binding is executing this code thousands times for big forms.

---------------------------------------------------------------------------

by Tobion at 2012-08-22T14:08:39Z

There is none of course.

---------------------------------------------------------------------------

by bschussek at 2012-08-22T15:23:57Z

Looks good to me.
merged branch goohib/fix-form-component-typo (PR #5323)

Commits
-------

bca68ca Fixed a typo

Discussion
----------

Fixed a typo

The CSRF error message won't be translated due to this typo even if the translator is enabled.
merged branch bschussek/issue5221 (PR #5319)

Commits
-------

a38232a [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Discussion
----------

[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5221
Todo: -

---------------------------------------------------------------------------

by stof at 2012-08-22T14:14:55Z

the return value of the getParent method should be updated in the phpdoc of the FormTypeInterface to mention the FormTypeInterface .And the description of the method should be updated to explain than returning an instance is discouraged as it implies a performance penalty and does not support using type extensions (if the comment in the factory also applies to the unregistered parent)

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:22:00Z

Wasn't TypeExtensions supported before? This means that Csrf will not be applied?

---------------------------------------------------------------------------

by stof at 2012-08-22T14:23:50Z

@henrikbjorn the csrf extension is targeting the FormType, which is registered in the form registry. What is not supported is having a type extension targeting an unregistered type

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:39:53Z

@stof Exactly. I find it a bit unlogical to register an extension for something that is not registered.

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:39:57Z

Okay. That wasn't what i got from reading the comment :)

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:44:27Z

@stof Updated.
removed deprecated examples from doc
merged branch meandmymonkey/remove-deprecated-examples (PR #5324)

Commits
-------

7734fdf removed deprecated examples from doc

Discussion
----------

[Validator] Removed deprecated examples from doc

Removed the MinLength examples from the Component Readme and replaced them with Length.
[Routing] removed cyclic reference Route<->CompiledRoute
merged branch Tobion/compiledroute (PR #5326)

Commits
-------

4f57d69 [Routing] removed cyclic reference Route<->CompiledRoute

Discussion
----------

[Routing] removed cyclic reference Route<->CompiledRoute

BC break: yes

I think we should remove this proxy behavior from CompiledRoute. Cyclic references are often not a good idea and in this case it doesn't even make sense. It's like an integrated decompiler ^^ when going from CompiledRoute -> Route.

It also conflicts with the single responsibility principle in OOP design as you would need to change the CompiledRoute class whenever you change the Route class.

It also mitigates problems like
```
$compiled = $route->compile();
// $route is change by some other layer
$compiled->getRoute(); // is not in synch with $compiled anymore although this getter makes us believe that
```
Merge remote-tracking branch 'upstream/master'

* upstream/master:
  [Routing] removed cyclic reference Route<->CompiledRoute
  removed deprecated examples from doc
  [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
  Fixed a typo
  [Form] removed getPositions from PropertyPathInterface
  Update src/Symfony/Bundle/FrameworkBundle/composer.json
  [Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)