labofsahil/github-event-dataset-2012 huggingface dataset:
Let's assign the `originalpermission` to a variable so we don't have to select it twice.
@bp323 We shouldn't have these divs inside of a button.
What is the reason for adding these in?

I can see that a background image is set on these, we should do that on the button instead.
Feels like a bit of a micro-optimization, but made the change anyway.
Este método altera o estado da instância, mas o processo de alteração deste estado modifica a estrutura de dados passada como argumento. Este efeito colateral é algo indesejado ou pelo menos inesperado do ponto de vista da API.
Should it just use "$settings[:api][:port].is_a?(Integer)"? Since this is the validation the API does.
"Pr" should be removed
This comment isn't clear to me. So that all of LSM could be moved to an extension?
rename to repackInPlace() or just repack()
replace means replacing entries (in ZipUtil context) although it wouldn't make sense in case of repack
>          <a href="{% url profiles_view_profile

>                  pageuser.userprofile.added_by.userprofile.display_name %}">

>            {{ pageuser.userprofile.added_by.userprofile.display_name }}

>          </a>
Also one tab
I don't know the exact implementation, but I thought Java list objects carry an int field that holds the current list length and that's what is accessed here, so it should be the same as copying that attribute into the FtanArray. If it's not, then I guess you're right though we should be sure that FtanArrays can't change size or we do have full control over that, so always the correct value is returned. As it seems the underlying list can be modified from outside, we might not be able to guarantee that.

Fair argument on the name. I'll change that. (Though, as setting the value is not possible, I think staying with that name might be ok, too).
maek return this :P
Muss irgendwo hinterlegt sein. Kann nicht generiert oder ausgelesen werden. Evtl. in ein Config-File auslagern oder per Parameter beim Start übergeben...?
Yeah... something along those lines will do.
Oh yeah, we can go back to that now :D
A better name for the method would be should_raise_exception
Made protected.
It might be useful to elaborate a little with some examples.

For example a "raw TCP input" is a valid InputKind (however a "TCP input" is not). Also, each modular input type is its own input kind.
Add also `django.conf`.
Hm, for input boxes it was OK that background was red. But OK, it is also OK like this now.
Aha. Hm. OK, this is some new GitHub feature. It displays also deleted files. I now see that there is one minus icon before. OK.
You just assume that it is there. Just specify wanted arguments and leave `**kwargs` at the end. Also name it in a reasonable way. Like:

```
def send_update_on_new_post(sender, post, **kwargs):
    ...
```

Or maybe some other better name. :-)
Define a method in horoscope providers, so that you can call:

```
horoscope.get_horoscope_provider(language).get_source_name()
horoscope.get_horoscope_provider(language).get_source_url()
```
Can this commented block just be removed?
Yep, made the change.
What would happen if you moved this method to RandomNumericSequenceLimit?
i think emty line is not needed here
where is my mistake no terrain, this send unk32 instead it, for supporting sending terrain should add one more var.
I think we previously left disabling the full wakelock until the very end of this method, otherwise the device could go to sleep without this method completing first.  I seem to recall having problems with that and intentionally moving it down.
The default is to not use the greengenes prefixes at all and include the entire header. There are likely other conventions, too. If there's a better way to organize this parsing I'd be happy to try and implement it. This actually touches on a bigger issue that is, what about when there is taxa data, not just (essentially) vectors of taxonomic ranks? The format is supposed to be able to handle that, but no working examples in our tiny test files.
Do not use exception handling to describe logic. Be explicit.... e.g   if not value: entry[key]=None 

Except for this, LGTM
I'll definitely update this before merge. Thanks for the note!
"_The_ result is an object with the following properties:"
(Pretty sure this just shows here because I initially broke it while merging)
Would prefer `_resource_manager_service`, because we often confuse our own data handling and the actual services.
Comment. Explain what's going on here? What is prev and why are we copying options from it?
Dot is missing at the end of the comment.

*default* -> *the default*
I agree.  I really like how that turned out.
While we are looking at this, multiplying by 2 followed by multiplying by 0.5 seems unnecessary. .astype(int) always rounds down, so having this in or out of the parentheses shouldn't matter.
Yes.  I think we should have another level for the size so we can specify several ways of determining the size of the output images.  So 
```
config.output.size.type = 'Fixed'
config.output.size.nx = 48
config.output.size.nx = 48
```
Also I think it's probably confusing to have the meaning of nx,ny change for the single image of postage stamps, relative to the others.  I'd rather have it always mean how big are the images for each galaxy that get written however they are written.  And then have some other means to specify how many postage stamps to have in each direction.
Well, we can specify half light radius for Moffat already... but in any case, I see your point and that is a limitation that I wasn't thinking of before.  I was thinking of how I hear people talk about galaxies and PSFs rather than the obvious and necessary connection between them - sorry.

I simply do not have time to do this today, at least not as carefully as it deserves to be done.  Does someone else want to?  (Because I'm sure you all have nothing better to do with your time.)  Or, we could work around it for this milestone, and open a new issue to clean this up by adding those additional bits of functionality later.
This should be ``setup_test_command(PACKAGENAME)`` ``rather than setup_test_command('astropy')``, I believe
We could decorate this so it gives a `DeprecationWarning
Should this be `EntityFactory<? extends T>`
I'd have created a new effector with a meaningful name, rather than have concatenate doing something surprising when special args are passed in.
Good points. I've tried to clean up most of the code of the redundant comments although I may have missed some.
What's the purpose of this wrapper?
This last rule doesn't seem to be covered in the tests.
мутний тест. якщо тестиш просто навяність списку проектів при перегляді категорії, тоді неварто прив’язуватись до селектору ```.sortable li```
I want to remove `&nbsp;` entities because I use XML validator to check HTML.
They can be written as `&#160;` of course, but I thought that these two `li` can be written as one `li`.

Right now I defined right margin for `a` element.
Key storage stores the keys for each, so that's why it is not member of certificate class.
is there a difference?
please remove the extra spaces
Can we resize the image if its size exceed this amount?
these should be private or protected, not public
What is the actual change to this file?
Ты создаёшь FileReader, при этом открывается файл в операционной системе. Следом ты передаёшь ссылку на FileReader в разные методы-конструкторы. И если случается исключение где-нибудь, то закрыть FileReader ты не можешь, т.к. у тебя ссылки на руках нет.
Ну, чтобы {0:vasya} не работало, например :)
@christianv can probably go ahead and try to map this back to index if you wish at this point.
I think the versioning was converted to a 3 digit number recently.
@opdenkamp can give you a 3 digit version number to use.
unknown flags are just ignored by configure. except for a warning message that it doesn't know about a flag.
whoops! fixed :scream_cat:
we could use `precomputed affinity matrix` also the same for How to construct the `adjacency matrix`. the general term for this is the interpoint distance matrix. also we can add the kernel arguments from `KernelPCA` here.
It is the score value. I don't know the reason, but `z` is used to document `score` in the base mixins.
I am working on #941, and as I was thinking of making n_output an optional argument (with default 1). Would you mind?
I know. Pros and cons, this is tradeoff. What do other people think?
this bit here war refactored in to _build_utils iirc.
or even `components_` and `component_indices_`...
Should probably use the detector classes we've already added. See platform-stub.js, Line 50.
Changed all 'suit' in file names, class names, method names and comments to 'suite'.
This is okay, but the best solution is probably to create a whole separate route in init.php containing the correct parameter name.
ndk_path can be None, if the path can't be guessed correctly it will be caught in the try except block below
Should all these (setWidth, setLeft, setTop) be reimplemented at the picker level?  It seems to me that these should be inherited from the UI.View
Good Idea.  Switched.
This reminds me that we need a clean way to say "this tutorial is as of bosh SHA xyz, plus patches a,b,c from gerrit"
Also this example is too large in horizontal size, it doesn't fit: can you split it on more lines?
You should check left/right are dictionaries - although as the grammar currently stands they must be  You're likely to want to allow

    SELF.dict := LEFT.dict + some-row.

(e.g., in an AGGREGATE)
I would expect the type to be always generated.
I'd maybe add a comment on this line and its analogue in Replace saying that you only need this step if your v is not already a working copy.
We should probably also have a maximum for this, and include the error messages (e.g. ":too_short => 'must be at least 2 characters long'")
For the description we can leave it as it is. Or do you have concerns with the variable name?
Period after description missing. New line after description required.
Is compass-rails properly maintained and kept up to date with compass?
Should we store this as a list of webcasts? Imagine that two camera feeds were being published for the same event.

{[{'type': 'ustream', 'channel': 'foo'},{type: 'ustream', 'channel': 'foo2'}]}
I don't see stages used in this module, so not sure why it needs stdlib. Also rather than doing if !defined, it can simply be include stdlib since it's not a parametrized class.
Why not just "pyramid" or "gaussian_pyramid"?
Or bind `resetApp`:

```javascript:
} else {
  setTimeout( _.bind(this.resetApp, this), 500 );
}
```
I prefer "ALL_EXTENSION" as default over "com_content" as default. 
Reason: now you see all categories and an end user will find the category (s)he's looking for, if the EXTENSION_FILTER needs to be changed first I image that people have more of a problem finding their category if it's not a com_content category.
Since we change Response to negotiate the type from the headers, this is not needed.  Is there a situation where you would change the type of the Response?
I've udpated the expected values
Consistent with the order of property getter/setters below and in examples.
Looks like [Array.splice(from, howmany)](http://www.w3schools.com/jsref/jsref_splice.asp) is doing the same thing
I'd prefer if we could just let the db handle resolving dependent records. Maybe we should write a migration instead of doing something as error-prone as this.
Test needs more descriptive name - ok, I know it's testing GetRuntimes, what is it testing _for_?
The return was removed here because it bypassed setRowData(). With the fix,
setRowData() is necessary to populate the data for a TiTableViewHeaderItem.
You should rename this to 'TiListView'
raising an exception is fine, what else is there to do?
What's with this change? Breaks the unit test for this method: `Invalid regular expression: /^(2(014|149)/: Unterminated group`. You're opening two groups, but closing just one.
> At least move should not overwrite immutable fields.

Disagree. `move` is unsafe and it's a user responsibility, that's all. Following your opinion we will finally end with `emplace` also not working for such types and, as a consequence, lots of derived algorithms (collections etc.) not working too. And it will be very frustrating.

As always, I'm not sure in my theoretical reasoning and suggest you to change `move` to reject `immutable` and wait for reaction from programmers.
Do _not_ use `isFloatingPoint`. `real` doesn't work with any of the endian-swapping functions, because its size is implementation dependent. If you want to make this work with more than integral types, then you need to use the same type checks as `bigEndianToNative` and friends. So, something more like

    if((isIntegral!T ||
        isSomeChar!T ||
        is(Unqual!T == bool) ||
        is(Unqual!T == float) ||
        is(Unqual!T == double)) &&
       isForwardRange!R && is(ElementType!R : const ubyte))
ufcs (everywhere I think)
It should probably also use the state transition method instead of setting the state directly.
I don't think we need to make copies of v
make this final. Make the class top level.
`SWFLogin.domain`ってちょっと違和感がない？名前的な意味で。
just realized I left in this superfluous line. I stopped supporting default heights, but left this in.
Why were the bundler tasks removed? This removes `rake build` and `rake release`, which are part of the standard release workflow.
shouldn't this implement some interface?  would make it easier to test, wouldn't it?
Do you mean instead of using "new" and "edit" use insert or update?
Our coding style is actually to be 
<pre>function bork() {</pre>
aka open the brace on the same line as the function definition.
what's the reason for class method + invocation vs plain `use`?
@chillu, e.g. if a dev just wants to change a lozenge label, he can just extend getStatusFlags() 
{ $flags = parent::getStatusFlags(); $flags['blahblah'] = 'My new lozenge';}, while keep the conditional checking stuff out and untouched.
There would be a model class method to do this... you can just stub those methods.
This is a tough one. This seems like a definite step in the right direction, but we're still ignoring the elephant in the room that we just shouldn't be writing to disk during unit tests. This is something we should work towards though, so this is a good start but we need to get those entitlement directories straight into memory.

We're also missing a (dev) functional test suite, which is something we need to keep thinking about.
Very nice!  I like how clean this is.
i was just going to suggest to hardcode this .. then again by making this a service one could maybe make it possible to configure a route prefix?
This can be shortened, no? Also, the line is somewhat long.
Sure, but why does the DDoc version need a function body?
@alexrp : Yes if the 3rd standard library appears we need to write code for that, otherwise it will just return `T.stringof`. This has been explicitly written in the pull request description, and I am not going to change it, because this is the best solution with minimal change. You could request the repo owner to revert the commit.
Perhaps we should use resolveId + ".jpaExecutor" like in StoredProc - especially because this is new in 2.2 and we eventually will do away with generated names.
Don;t think though that the constructor needs to be deprecated.
I think that got corrected with the newest push
This also shows up in some of the other files; if this is not by design the others might also need to be changed.
what is an early return?  is it when you do
return :something if something == 2
:+1: I agree using the datetime datatype would be cleaner & more performant than this varchar. this [stack overflow thread](http://stackoverflow.com/questions/1136437/inserting-a-python-datetime-datetime-object-into-mysql) might help if you're having trouble getting from string -> datetime
Same with this one?
*NOOOOOOOOOOOOOOOOO*
- yes, sql do not have the most of them
- this is a test, so performance is not critical.
but i can change to "isset" or "empty" checks... as you prefer
I assue this import is local because of an import loop? If yes, please document this.
I was thinking to add a link to our contact form, but this may not be necessary if we add a link to the facebook group.
Hmm, I sue 5.1.0. Maybe that's the reason I had problems with my latest Search doc changes. Doing an upgrade...
Having hard time to #include <webworks_utils.hpp>

I see few other extension included them and used the method you mentioned. I am wondering what I am missing.
Should I do this with all of the html code? It seems as though if I could import just one variable, then I wouldn't have to worry about framework or if there was an additional variable that needed to be added that was contained in the variable that I was already importing it would automatically be there without having to add any import statements.
Just a few style nitpics. DummyStatsD is probably better called NullStatsD. A comment in the declaration of statsd would be helpful stating the variable has side-effects in the rest of the file via the configureStatsD function.
you should document the return type
Fixed in last commit
What's the advantage of this method of finding HTML nodes over the old one?
this is also the same as having a notification attached to the manager. should be removed
I don't know what happens today to be honest. It might depend on how Hibernate ORM's engine messes with the entity state.
@wireframe Thanks for this recommendation.  This improved readability significantly.
Should have period at the end.  We have a validate.py check for this, but it's off by default because we have many old summaries that we need to go back and fix.
a file could be a directory, is it not?
Renamed to WindowsAzureServiceException. However, I am not sure if I want/need to keep this class - need to figure out whole error handling story in WinMD files. It turned out that you cannot declare public exception classes in WinMD libraries.
Thanks.  I'll remove those methods and update the config.
Please move this to the end of the dependencies list.
turn DOB into a timestamp so we can calculate over it
Break this line a bit, also in other places.
Look at the green line above it.
Should these constants be moved into an object to keep the blackberry.app namespace clean?
Yes it needs to end up in webplatform because abstraction in this [Pull Request](https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/151) has it for reading only.
Still? I thought this was going to be fixed with the new event callback thing.
when fromBackup is true send eTag message
@niran your comment was correct, I thought I had removed those. I have now in 51f444d