[EFL][WK2] Clean up construction/destruction code in Ewk_view
https://bugs.webkit.org/show_bug.cgi?id=100232

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-26
Reviewed by Kenneth Rohde Christiansen.

Simplified a lot of initialization and destruction code of Ewk_view and EwkViewImpl
put all the impl stuff to its constructor and destructor, also made EwkViewImpl member
variables private.

* UIProcess/API/efl/EwkViewImpl.cpp:
(pageViewMap):
(EwkViewImpl::addToPageViewMap):
(EwkViewImpl::removeFromPageViewMap):
(EwkViewImpl::viewFromPageViewMap):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
(EwkViewImpl::wkPage):
(EwkViewImpl::title):
(EwkViewImpl::setThemePath):
(EwkViewImpl::customTextEncodingName):
(EwkViewImpl::setCustomTextEncodingName):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informWebProcessCrashed):
(EwkViewImpl::updateTextInputState):
(EwkViewImpl::informURLChange):
(EwkViewImpl::onFaviconChanged):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
(EwkViewImpl::ewkContext):
(EwkViewImpl::backForwardList):
* UIProcess/API/efl/ewk_settings.cpp:
(Ewk_Settings::preferences):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_add):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(createEwkViewSmartClass):
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_url_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_feed_touch_event):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Crash in PagePopupController by events after WebPagePopupImpl::closePopup
https://bugs.webkit.org/show_bug.cgi?id=100454

Reviewed by Hajime Morita.

No new tests. The bug is timing-dependent.

* page/DOMWindowPagePopup.cpp:
(WebCore::DOMWindowPagePopup::~DOMWindowPagePopup):
Calls clearPagePopupClient for the associalated PagePopupController object.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::setValueAndClosePopup):
Do nothing if m_popupClient is 0.
(WebCore::PagePopupController::localizeNumberString): Ditto.
(WebCore::PagePopupController::clearPagePopupClient): Added.
* page/PagePopupController.h:
(PagePopupController): Declare clearPagePopupClient.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Skip a few tests which produce wrong pixel expectations.

* platform/efl/TestExpectations:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Refactor Localizer-related classes.
https://bugs.webkit.org/show_bug.cgi?id=100482

Reviewed by Kentaro Hara.

- Localizer has unused code
 Localizer should have function implementations only if they are used in
 multiple subclasses.
- Some Localizer subclasses hide Localizer data members
- Should use String::isNull to check initialization-or-not

No new tests. This should not change any behavior.

* platform/text/Localizer.h:
(Localizer):
- timeFormat, shortTimeFormat, and timeAMPMLabels should be pure virtual.
- Remove m_localizedDateFormatText, m_localizedShortTimeFormatText, and
  m_timeAMPMLabels
* platform/text/Localizer.cpp:
Remove implementations of timeFormat, shortTimeFormat, and timeAMPMLabels.

* platform/text/LocaleICU.h:
(LocaleICU): Introduce m_timeFormatWithSeconds and m_timeFormatWithoutSeconds.
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat):
Use new data members instead of Localizer data members.
(WebCore::LocaleICU::dateFormat): Use isNull.

* platform/text/LocaleNone.cpp:
(LocaleNone): Add timeFormat, shortTimeFormat, timeAMPMLabels
implementations, and m_timeAMPMLabels.
(WebCore::LocaleNone::timeFormat): Returns the HTML time format.
(WebCore::LocaleNone::shortTimeFormat): Returns the HTML time format.
(WebCore::LocaleNone::timeAMPMLabels): Returns "AM" and "PM".

* platform/text/LocaleWin.h:
(LocaleWin): Add m_timeFormatWithSeconds.
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::dateFormat): Use isNull.
(WebCore::LocaleWin::timeFormat): Use m_timeFormatWithSeconds.

* platform/text/mac/LocaleMac.h:
(LocaleMac): Rename m_localized*TimeFormatText to m_timeFormatWith*Seconds.
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::timeFormat): Follow the renaming.
(WebCore::LocaleMac::shortTimeFormat): Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] ASSERT currentThreadIsHoldingLock() failed in MarkedAllocator::allocateSlowCase()
https://bugs.webkit.org/show_bug.cgi?id=100504

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-10-26
Reviewed by Yong Li.

PR #232038 The similar PR # 200724.
Reviewed internally by Petter Wang.

This issue is same as bug 95492, and this patch is same as its patch.
Hold the JSLock for the current thread before we call toRef to avoid
the ASSERT failure.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132653 268f45cc-cd09-0410-ab3c-d52691b4dbfc