labofsahil/github-event-dataset-2012 huggingface dataset:
I could try to use `method_missing` in the view object. In this scenario I would check if the method called is `template_counter`, warn and then return the value, making the `redefine_method` getters and setters unnecessary. But I still would need to keep either `template_counter` or `template_iteration` as an instance variable, because method_missing won't have access to local variables. 

Does this sound better?
We can do `@columns = columns.each(&:freeze)` or `@columns = columns.each {|c| c.freeze}` to avoid allocating that extra array.
I had to copy this setup from `actionpack/test/dispatch/routing/inspector_test.rb`. I thought about adding a helper method to make it easier to setup a nested configuration. I did not find many other places that need to do it, so I decided not to abstract it for the moment.
The validations and callbacks guides are now two guides, so just link to the validations one.
maybe just say couldn't get data from wunderground?
What if it's `T` as in `def foo[T] = weakTypeOf[T]`? Does it still qualify for being a dummy type arg?
Not sure that I like this method depending on `get`. Is there any reason for that? `get` does a cache read and a whole bunch of other logic around returning the actual value for a preference. Wouldn't it be more sensible to just check for `Spree::Preference.where(:key => key).exists?` instead?
yeah this is reasonable
It's this if statement that isn't tested. You'll need some tests that look at ``x**(p/q)`` for different assumptions.

Also, this test does not appear in AskImaginaryHandler.
The old tests were testing things that aren't related to preorder_traversal, such as the behaviour of specific subclasses of Basic and their arg ordering (cf. [issue 3272](http://code.google.com/p/sympy/issues/detail?id=3272) for an example of hash randomisation causing the test for z+w*(x+y) to fail).

The new tests are true unit tests that test preorder_traversal fully, but nothing more.
It looks like they were added for convenience so when someone wants to enter notation as it appears in a book, for example, that is 1-based with singletons omitted, and see the result in the same form, they can do 

```
p = Permutation(full_cyclic_form1(what_I_see, size))
...do something
print cyclic_form1(p.cyclic_form)
```

The `full_cycle_form0` is also needed because Permutation requires that all indices be present whereas standard notation allows singletons to be omitted. Perhaps methods could be modifed to use a sparse-permutation storage and then it wouldn't matter if they used 1-based or 0-based notation.
It may be nice to define these (like `Jx` is `JxOp('J')`) so you could do `from sympy.physics.quantum.1dsho import a, ad`
as I commented before, please do not mix code style changes with code changes... create a separate PR for that
@qiangxue On some systems tests will complain about already defined constants when using phpunits-@runInseperateProcess
Can you make another PR for this feature ? Thanks.
and I already finished up this branch
I haven't experienced any problems - as long as the timezone remains constant, it shouldn't present an issue.
Are we guaranteed that this string of 3 get().remove() calls will never NPE after the get() and before the remove()?
It is extending RegisteringNode
we have a lot of index documentation already. The example below is good, but I think we can reduce some of the fore-matter.
fixed :p
Not sure what this is supposed to mean. | is a bitwise operator so you probably meant $auth-action === 'login' || $auth_action === 'link' ?
should we move the .in version to just contain this variable?
@doitian 这些等需要用上的时候再加上吧。
/users 改成 helper
We sorta have a tradition in mojito codebase to prefix variables that hold libraries with `lib`, as in `libpath = require('path')`. This is to prevent collision between variables names that make sense for the current algorithm and the libraries.

That idea is definitely not applied consistently throughout mojito thought :disappointed: though I wish it was.
No, you¹re right. I guess I did not have the latest version of the file.
Sorry about that. Can you make the change or do you want me to do it?



De : Rob Clayburn <notifications@github.com>
Répondre à : Fabrik/fabrik
<reply+p-1999295-1048936ca486dd675fd349d272dcd48ab5194ac6-1868381@reply.gith
ub.com>
Date : Wed, 31 Oct 2012 15:38:46 -0700
À : Fabrik/fabrik <fabrik@noreply.github.com>
Cc : Jean-François Questiaux <info@betterliving.be>
Objet : Re: [fabrik] Fix for the autologin function of the JUser plugin
(#507)

In plugins/fabrik_form/juser/juser.php:
> @@ -668,7 +683,7 @@ protected function setGroupIds($formModel, $me, $user)
>    $this->gidfield = $this->getFieldName($params, 'juser_field_usertype');
>    $defaultGroup = (int) $params->get('juser_field_default_group');
>    //$groupIds = (array) JArrayHelper::getValue($formModel->_formData,
$this->gidfield, $defaultGroup);
> -  $groupIds = (array) $this->getFieldValue($params, 'juser_field_usertype',
$formModel->_formData, $defaultGroup);
are  you sure about this line - i seem to remember recently chaning it to
cast to (array) as laster on we presume it is an array
 

 ‹
 Reply to this email directly or view it on GitHub
<https://github.com/Fabrik/fabrik/pull/507/files#r1999295> .
I guess I meant `===` instead.
Like this?

            var sessionType = context.Request.Session as NullSessionProvider;
            if (sessionType == null && context.Request.Session["CurrentCulture"] != null)
            {
                return (CultureInfo)context.Request.Session["CurrentCulture"];
            }
We are going to have to redo a lot of the illness stuff here, as 'illness' isn't a resource in OpenMRS.
> @pelson Does calling the super iter method not "just work"?

Unfortunately no, because Cube derives from 'CFVariableMixin', which just inherits 'object'.  Neither of these has an \__iter__ or a \__getitem__, which are what '`iter()' looks for.
So the only way is to call Cube.__iter__  with consecutive indices, and raise 'StopIteration' when it raises an 'IndexError'.

There may be a more 'ultimately efficient' way with itertools, but I cant find a nice one.
E.G. how about .. 
`itertools.imap(lambda i:cube[i], itertools.islice(itertools.count(), cube.shape[0]))`
or 
`cube_len = cube.shape[0]
return itertools.imap(lambda i:cube[i], itertools.takewhile(lambda i: i < cube_len, itertools.count()))`
??

I suspect this code would be much clearer anyway.
I would argue that you tiny bit of python code does not need a comment either.  The presence of if allow_gc check at the top should alert the astute reader in both cases that the following code deals with cleaning up unneeded stuff.

However, in the interest of make it clear for future maintainers, I will add a comment similar in spirit to yours.
Now this is just embarassing, eh?
Массив здесь, кажется, не нужен. Потому что при указании `['deps.js', 'bemdecl.js']` в merged bundle будут созданы два файла, `*.bemdecl.js` и `*.deps.js`.
perhaps protected would be better here.
I did make some suggestions.  I probably could have found a less curt/rude way to indicate comments needing improvement. As I worked through the code, I just quickly threw on the marks as I saw lackluster comments.
See comment for `isReader`.
You are a naughty, naughty boy.
`s/with HTTP method/with a HTTP method/`
Err, just in case: it was fixed yesterday.
I wouldn't swear this is 100% backwards-compatible.

But I'm also in favor of using `force_str` as sparingly as possible :)
This seems like it should be the caller's responsibility (same applies to create_model)
The tests surrounding it have comments ending with multiple hashes so I was just following those (Lines [109](https://github.com/selwin/django/blob/0208682cb6e9ae8211235785f02080ef6bc544b5/tests/regressiontests/forms/tests/models.py#L109) and [122](https://github.com/selwin/django/blob/0208682cb6e9ae8211235785f02080ef6bc544b5/tests/regressiontests/forms/tests/models.py#L122)). Want me to remove them?
This is a bit tricky. Setting *collapsible* to false *kind-of* implies *expandable* should be true, in that *collapsible* can only affect the behavior of an expanded node. In practice, each of them is only checked when attempting to toggle the state. 

So a Node can start out expanded, even if *expandable* is set to false. Similarly, you can start out a node collapsed, even if collapsible is false. It's weird, but I suppose a node that starts out in one state, then "sticks" in the other when its toggled, is potentially useful.
This is very same file as github_issue_body.txt.erb. Because of similarities (and Markdown support) between Github and Gitlab, I could use same file.
Any particular reason the URL is between quotes? Don't need it in my terminal.
An alternative to this expression is `elif curve_mode in ('loss_ratio', 'insured_loss_curve'):`. What do you think?

Same suggestion for line 852.
Can this be changed to ``list( , $code, $status) = $statusLine;``
I suddenly understand why the typed language guys are all high and mighty. Yeah, I'll assert against the empty string.

Yup, I'll write an assertion or three that doesn't trim to zero length.

Thanks @jaubourg
Oops. Ignore this.
This looks to me like it would create unnecessary garbage. Could it be made a member variable that gets cleared or kept up to date?
I'm a little puzzled with these two lines--there isn't anything by the name of error404 or error500 in fjord.base.views. What do these two lines do?
Is oiio compatible with more than one series of openjpeg? I assumed openjpeg versioned its include path due to incompatibilities.
Mind if I merge then? Doesn't seem to be any backwards-compatibility problems and it fixes at least 2 bugs.
doesn't build when I add std_cmake_args
I don't see why, it validates that the library was installed and visible to pkg-config. It's no worse than any other test that just executes a binary to see if it exists...
Is there a way we can tell the difference between an actual blank description (no description from the feed) and something that wasn't migrated correctly?  Is that a difference that even matters?
Ah. So initially the `sandbox_protocol` was passed in but unused (`api` was used via a closure). Since the call to `_process_in_sandbox` requires the `sandbox_protocol` as an argument it seemed silly to pass it back out to the callback again (and `msg` still needs to be accessed via a closure anyway). Happy to restructure a bit if there is a good suggestion.
This isn't a safe default. We don't want web requests running by default.
no need to case ss_len to socklen_t here
This should be options=None (using mutable default kwargs means they're global).
map this stuff into `/profile`?
The interface makes me sad. I originally started down this path as well, but stopped because I couldn't do it with overloads. I was hoping you were able to do something clever that involved overloads :)

I'm weighing the clutter this brings to the interface with the utility. It's a cool feature and it's only 3 new methods, but I'm not sure I'm sold yet. What were your thoughts?
I kept it as anything to do with fixing height on android will need the timeout to deal with an orientation change, which isn't necessary on other platforms (or, at least, iOS).
Not a lot of busy work with find and replace. I removed the menu  title prefixes from these titles earlier ("file-menu" "edit-menu"), but removed "menu" as well. Added back.

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 5:12 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +        /*
> +         * Debug menu
> +         */
> +        menu = addMenu(Strings.DEBUG_MENU, appMenuBar.DEBUG_MENU);
> +        menu.addMenuItem("debug-reload-wn",      Commands.DEBUG_REFRESH_WINDOW,
> +                                                                            [{key: "F5",     platform: "win"},
> +                                                                             {key: "Ctrl-R", platform:  "mac"}]);
> +
> +        menu.addMenuItem("debug-dev-tools",      Commands.DEBUG_SHOW_DEVELOPER_TOOLS);
> +        menu.addMenuItem("debug-run-tests",      Commands.DEBUG_RUN_UNIT_TESTS);
> +        menu.addMenuItem("debug-enable-jslint",  Commands.DEBUG_JSLINT);
> +        menu.addMenuItem("debug-perf-data",      Commands.DEBUG_SHOW_PERF_DATA);
> +        menu.addMenuDivider(_getNextMenuItemDividerID());
> +        menu.addMenuItem("debug-experiemental",  Commands.NO_OP);
> +        menu.addMenuItem("debug-new-window",     Commands.DEBUG_NEW_BRACKETS_WINDOW);
> +        menu.addMenuItem("debug-close-browser",  Commands.DEBUG_CLOSE_ALL_LIVE_BROWSERS);

Not to generate a ton of busywork, but... I wonder if we should keep the "menu-" prefix that we used to have on all of these.  Since they're DOM node ids, they're supposed to be unique across the whole HTML document.  Some of these (e.g. "view-sidebar") sound generic enough that they could potentially collide.

Another option would be to programmatically tack on the suffix when creating the DOM node, and again later when searching in the DOM by id.  That would keep the code cleaner and prevent people from forgetting to add the suffix on their own menu item ids.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r879168
OK, I verified that those shortcuts still work on Win7 in this branch. Good catch!
Done. I combined all of the "should add new menu item in last position..." tests.
I don't get it. No one changes this FileUtils.getNativeBracketsDirectoryPath() api and how can this return a path ending with /test?
map ugettext_noop onto this.
And ```pymacs-load-path``` does not need to be augmented at all?
@dimitri You mean this line?  This is intended, as the inline comment suggests.  To use rope only for pymacs, adding it to pymacs-load-path is enough, as pymacs adds paths in pymacs-load-path to PYTHONPATH internally in its Python process.  However, traad (the module added by this PR) does not use pymacs so it does not know about pymacs-load-path.  To use rope in both modules, adding the path for rope to PYTHONPATH is the simplest solution.
`phaseIII` is not a very descriptive variable name. Maybe `ymca_simulation` or something?
I am not use if Lars will be happy with removing run_tests and run_qa_tests. It became inconsistent with what we have in other repositories. Are we sure than run_tests and run_qa_tests are never called by Jenkins? Is some procedure looking at last_test_run.log? We are losing the log file.  I would check with Matteo to know how it runs the tests on the different repositories and if he needs a log file.
Here also i didn't need every thing then I also create a lighter class
Aha, a bit more hunting shows it got left in by mistake from my merge conflict resolution.
Why again hardcoded the same URL?
Also display language names translated to the language itself (so *Slovenščina* and not *Slovenian*).
Don't rename module like that.
Is this meant for from piplmesh.account import models?
do this above in a separate var declaration
Goodbye `EMBED_SUFFIX`, we hardly knew ye
These should still not have `__` in front of them.
If a publish failure does happen here for some reason, what happens? I *think* the "Preview" button will stay hidden, and the "Save" button will be disabled. So, to see your published project, you have to change something in order to try to save again, right?

That seems broken, but probably worthy of a completely separate ticket.
Is there anywhere you would suggest putting a function like this so it's accesible to both the default editor and the trackEvent class?
Does this need its own function? This code can probably just run inline.
@saebekassebil I think this is almost good to merge but could you leave this section in and squash your commits?  I have some updates and I'd like to do as well and I'll be getting rid of the duplication down below.
Thanks for cleaning all this up. I don't know how these tables got here, they belong to branches that they were never committed.
I kind of imagined this working the other way, starting at the salt file root and working down using ```os.walk``` so it could be used more generically. There are more directories with bad permissions set than just the keys.
According to specs, this should be the domain name in reverse. But just for  the sake of argument, could you double check what /proc/sys/kernel/domainname say? Mine didn't work either, before I set this. It's documented in the code/manpage.
maxximino/zfs@f3ddf21d5caeaa2d4d79c888a2569eef011a9906
maxximino/spl@6e9e8460527328aa11695f7cddaf13cbbd3f2af3
I still have to test them deeply, however those patches look reasonably safe. (On successful end of tests I will make another pull request.)
should be
```
s.clean_paths = ['XBImageFilters/Classes/Sample', 'XBImageFilters/Resources/Images', 'XBImageFilters.xcodeproj']
```
This isn't mentioned in the request--guessing this isn't supposed to be in here. Can you drop this patch when you squash, please?
Nice, I like the attention to detail.  :)
We need those:

    -    SSLVerifyClient optional
    -    SSLRenegBufferSize 16777216
    -    SSLVerifyDepth 2
@thomasmckay you are right about the 106 chars. I did not know that, thanks! I'll keep mi lines under 100 as well :)
No particular reason. Just my not very developed sense of ruby code beauty:)
Good feedback.  Updated with commit ca5065abb853229142b955dcf17142a8bb3d1c73
Yeah. I think using ``inner`` and getting the dot product will be better. I will fix it and try getting it done using numpy arrays.
https://github.com/SignalR/SignalR/issues/1036 lol
Typo in 'longitude'
could you rename this file something slightly different from ``cosmology.py`` given that the package has this same name?  Perhaps ``cosmologies.py`` or ``core.py`` or something like that?  People often get confused when they're doing something like ``from astropy.cosmology import cosmology` or ``from astropy.cosmology.cosmology import foo``.
Yeah, I believe this is the "right" way to do it. `None` is common for default values and PEP 8 says "Comparisons to singletons like None should always be done with is or is not, never the equality operators" (it briefly explains why). The first answer to this question has some good info too: http://stackoverflow.com/questions/3965104/not-none-test-in-python

In addition to accepting `False`, `if not username:` would also accept `[]` and who knows what else.
This requires gmake as is any how, see build examples. :)

$(shell ...) is just .... ugly

I guess

ifeq($(LMODE2), dynamic)
  ifeq($(shell uname -s), Linux)
.....

Would be another option?
I partially agree with @lorenzo, but I guess in this case `Trait` suffix could help to identify this is not a class, avoiding to instantiate or extend it.

Probably we need to discuss this topic in cakephp-core to avoid zillions of comments on this commit.
Isn't it always App to follow the folder name?
I think we should provide better explanations. For example:

```
When the floor is changed setFloor(floor) is called on OpenLayers layers that include this method, or
a floor parameter to the query string for layers with parameters (WMS and WMTS).

Mapserver layers should be ready to receive a floor parameters in the query string:
```
you should return early instead of using ``else`` (otherwise @guilhermeblanco will be mad :smile:)
I guess I don't see how a problem could arise since you're already checking that the directory exists.
put this call to fixConsole back, and remove the one above.  append_text below calls fixConsole (as it should), so the above call is a duplicate everywhere outside this block of appending to the existing div.
What will happen here if the conversion fails?  Would it be better to do the conversion in a try/except and print a warning to the user about data that didn't make it across from R to python, but not blow up altogether?
It is only used there in the main function so I don't think it needs
to be put anywhere other than that.

On Tue, May 8, 2012 at 12:35 PM, Bussonnier Matthias
<reply@reply.github.com>
wrote:
>> +    }
>> +
>> +    // stop autorefresh when page lose focus
>> +    $(window).blur(function() {
>> +        disable_autorefresh();
>> +    })
>> +
>> +    //re-enable when page get focus back
>> +    $(window).focus(function() {
>> +        enable_autorefresh();
>> +    });
>> +
>> +    // finally start it, it will refresh immediately
>> +    enable_autorefresh();
>> +
>> +    IPython.enable_autorefresh = enable_autorefresh;
>
> I thought `IPython` namespace was shallow enough in dashboard, where do you want me to put it ? should I split  the autorefresh between both `clusterlist` and `notebook_list` ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1676/files#r790637



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
What happens when declared  in a block and there are 2 json variables with {val}
Since we're creating the products in the test, we don't have to nix the products that don't exist in production. It's probably helpful to have a 0 item item.
Should this be `/etc/socorro/postgresql_middleware.ini`?
:presentation_feedback?
To be clear, the problem here would be the inability to break out of forEach
I am with you there, they dont seem to work like this anyway.
This can just be an Executor...
apparently, you should remove it :)
Oh ... indeed. Fixed.
This is wrong. It should not always return 0. See how it is handled when loading templates from the filesystem
IMO this should be just public static class variable.
You should use a document fragment instead of modifying the DOM in the loop
Are you sure about tjos change ? It does not seem equivalent. Your new code seems equivalent to ``error_reporting() & $level || $this->level & $level``
I mean, chmod returns null if the mod is not valid, it returns false if the mod fails :

This example dumps ``null``
``php
<?php
$file = __DIR__ . '/test';
touch($file);
var_dump(@chmod($file, 'hello'));
```

and this example returns false :

``php
<?php
//$file is owned by root, I can't chmod it
touch($file);
var_dump(@chmod($file, 'hello'));
```
Fixed. I introduced a new interface `PropertyMetadataContainerInterface`.
I'd note that in webkit the visual grid might be slightly off due to rounding.
all the debug stuff can go once we have test cov
How would `--type error` work with `log.error('request', err)`? (type equals request)
yes, for kFoursquareNeighborhoodCategoryID
remove this method if its not doing anything
Since impersonating another sender in Yammer is forbidden seems like this is worth testing.
I think, whis won't work if the output doesn't contain \n.
You also use below "First++", "MostCentered++", "Last++". Should be documented ? Or have I misunderstood something ?
Why Archive/Delete are not written with their trailing "e" ?
A note on style:  Having the conditional code on the same line as the if() is inconsistent with the rest of the OIIO codebase.  Can you change these to

if(predicate)
    expression;

rather than

if(predicate) expression;

thanks.
You mean Application error: Server application error or just Server application error ?
sweet, thanks. Thing will not compile otherwise anyway
Ok, now take it out again. Put it back. No, out. Back. Perfect!
7.1.2 is the first release that has meaningful i18n log messages for the OSGi subsystem. Previously all jbosgi components used plain messages. Also we did not do a review of the message conversion to i18n. See https://issues.jboss.org/browse/JBOSGI-527 for details
It is needed for waiting on server before execute operation on the next line after reload server. If I remove it it fail with: "Could not connect to remote://localhost:9999.", because server hasn't started yet.
Please use tabs for indentation, see also http://docs.jquery.com/JQuery_Core_Style_Guidelines
Thanks :), before I do some of these fixes, what would you like to do about the README? Combine them? take out the relevant parts? Make the main page README a bit longer?
I'll fix the grammar though, but the change from using the defaults requires some other changes, because the sample defaults to "/testswarm" in the contextpath instead of "/" which will break the nginx config.
ResultAction, hm... ok.
typo: ranndom -> random
No need to return a value here. Removed from the commit.
я хочу чтобы эти объекты были минимально легковесными. Ты тогда пока это место не чини, я потом его по другому попробую переделать
nit: default turn `_debug` off.
maybe just use fileType || file.type?  Because as noted above, you may want to use sdcard when fileType is defined, but is not image/* or audio/*.
What do you think of ReloadManager -> Shortcuts?
Yep, at the first point I tried to use the same method to Add and Edit, and that  " || '' " is something I forgot to remove :)
Are those changes on purpose?
Can you also move over the unit tests for this code? (if its going to live in system) I won't need it in calendar directly as I would just use the usual input[type="date"]
The String encoding/decoding stuff should be wrapped in a utility function (probably in Utils.java)
Could we put the logic for sending directly to a local task's receive queue here? This makes things more efficient by avoiding the bottleneck of a single send thread for this case.
Should we instead delete the queries with the lowest count value (aka that are asked for the least?)
Both get_cli_var and get_web_var don't check for what is needed. They just return.

get_option stuff using the new optparse does the same by returning an optparse object.

The new validate method takes :require_all or :require_one logic. But this code will be replaced by that.
Yah, that's basically what I meant by "make the implementation a tad more understandable"

Or even?

```ruby
%w(.rspec .rspecrc).map    { |f| File.join(File.expand_path("~"), f) }.
                    select { |f| File.exists?(f) }
```
Actually, looking at the source of this file, I'm seeing lots more color methods: `blue`, `magenta`, `cyan`, etc.

We should figure out what those are used for and add settings for them as well.  As this stands, half the the colors are configurable and half aren't....and it'd be nice to get a fully consistent color config system.
Always using a toString here seems a bit wasteful... I should benchmark this, but it feels like an optimized version for a single Long field might be worthwhile.
You can also group the imports here.
Oh, this was originally in another line :(
Thanks,  hurtonm,  it's my fault.
This seems like a clumsy way to do this check. Why not just use a regex?
Fixed typo, leaving in the stop command to be consistent with the god interface.
emulate -> emulated.
Is it possible to combine the NodeRepairScheduler with the PriamScheduler?  Feels non-optimal to have two different schedulers to work with.
we can of course use `in [http, https, file]` check but I guess it will be something like ten-fold slower.
Don't know, it's not returned anymore.  This method must have been using an older version of the post_data method because there were several parameter inconsistencies (it was sending the dict instead of a string, it was using a "content" property on response which doesn't exist anymore, etc.)
The use of ${session.executionRootDirectory} might be problematic: we often just build a single submodule alone.
Just specifying "zanata.xml" (or even better "src/main/zanata/zanata.xml" after it's moved) should work normally (it does for any other plugin, even when inherited).
If we are including Butter as a submodule, we can probably use it's popcorn.js submodule so we avoid having two. Mind filing an issue for that?
Ow and:

```ruby
FileUtils.mkdir('/tmp/somedir', :mode => 0770, :verbose => true, :noop => true)
```

Logs: `mkdir -m 770 /tmp/somedir`

And this is exactly how the code looks like in the `system` call, so if it's not working, please tell me why and not just 'this won't work', because that doesn't help anyone.
these should move to all the way down in the list so the id's don't change
An other good catch.
How's self.highlight_code work for you?
BTW is `javax.annotation` preferred for this purpose, or the FindBugs-specific package?
Curious - Is there ever really a time where you'd want to set this value to something other than "1.0" (as defined by the gelf spec) ?
Anyway I have added comments in `Loader` documenting the fact that `baseURI` must have trailing `/` or custom `resolve`.
This name is confusing.
Is there any reason why you would use a custom loader instance here instead of using shared one?
Please use relative require instead.
Is there value in keeping this comment ? If so, please comment reason otherwise please remove.
I think this use of the terms "node" and "revision" (where apparently "node" is the full-length hash identifier for a changeset and "revision" is the first 12 characters of it) is unusual and confusing. More conventional would be to simply call it a "changeset_id" or "revision_id", and then an abbreviated version of the latter. Which would make the name of this method something more like "truncate_revision_id".
I think the use of "threshold" here is misleading.  The "threshold" is stored in the `metric_threshold` table and is really just a pointer to the last test run that passed a given test for a particular metric datum.  So if no metric threshold is present, this is the first time the metrics test is being executed for the metric datum, in which case the algorithm walks through the push log looking for the first parent that passes the test.  

No threshold is required to pass a test, pass/fail determination is managed by the MetricMethod (model/metrics.py) implementation for that test.  So in the case of the t-test it depends on the results of `h0_rejected`, there is an interface function called `evaluate_metric_result()` that every MetricMethod implements that can be called to determine the pass/fail status.  

If there is no parent push found in the push log that passes the test for the metric datum and no "threshold" to make use of, no metric test can be performed.  This might not be a requirement for all MetricMethods, not sure how to manage that generically.

There is an assumption in this implementation that the system will eventually have a parent/child push pair for every metric datum.  This is required to bootstrap the metric_threshold.
This should also be covered by the data-tooltip attribute.
I would even get rid of those duplications as mentioned above by updating all that code.

e.g.

<span id="resident">
  <span class="label">Resident: </span>
  <span class="data">n/a</span>
</span>
@pcarlisle actually it was `Tempfile#close!`, but it's fixed now
Using member variables like this is a bad practice in testing - because they can persist between test cases they can lead to sharing state unexpectedly, and because they don't inherit into derived classes they require redoing the same setup code in every nested context.

It is much better to use a "let" function or a regular function on the parent object - which you can do using an included module, if you want to extract the code.
I think it was you that mentioned the odd `(failures)` arg I had, I'd like to maybe just remove the callback args all together and do:

```js
var runner = mocha.run(optionalCallback);

runner.on('end', function(){
  runner.stats
  runner.tests
})
```
mocking user input, the current angular test was hanging waiting for y/n, it is why travis-cl has been failing for 25 days, among other things.
you're right in general, but here, since we deal with strings, having PCRE to check string for zero value (could be `+/-0`, `00`, `0x00` etc)  is less efficient than just throw string at gmp/bcmath and check result
If we're in the else, $argNum gets set anyway, so I'm thinking something like the following would be just as efficient but clearer to read:

```php
} else {
    $argNum = func_num_args();
    if ($argNum > 2 || is_scalar($valueParameters)) {
```
ok, goes a bit against semver though, but sure, if that's the brunch convention.
moved https://github.com/alunny/cordova-plugin-spec/issues/7
this should also keep using the routing
A check for platform first would be good, as I'm not sure if this ever worked on any versions of ubuntu.
@harjis Ai ai! Catastrophic bug!
Decouple uses into logical groups
the curly bracket should be on the next line
Clever, in the good way!
That's why I said I need review since it's copied directly from legacy :)

Over there, every time eZExpiryHandler is used, registerShutdownHandler is also called.
Ok, reverted.
this version has IE9 in the test results as well: http://jsperf.com/caching-array-length/120

and it only reports a marginal improvement between hoisting and not. although decrementing instead of incrementing is nearly twice as fast.
break up into multiple lines
I thought to we enable this in general for all quick starts in case the user want to extend to CDI
"Enabled"?
A `<dt>` and `<dd>` should be paired one after the other, and contained inside a definition list... I don't think you should wrap the two in a `<div>` or have two `<dd>`s for one `<dt>`.
I realize this was already work-form, but it really should be faq-form so the name more accurately reflects what it is.
I'm really not sure why all these lines are changing if we are just adding in lines 26-29. Line 30 looks completely unnecessary and is why this pull request is such a mess. I'll just make the change on lines 26-29 on master, and you can deal with this pull request not being accepted.
Why? There might also be a cost when releasing the master lock don't you think?
And again :(

Why isn't IntelliJ smart enough to mimic what the file is already using?
Don't want to stick www.khanacademy.org in front of font data urls and because sometimes things are in quotes, sometimes not, sometimes there's a leading slash, sometimes not, etc, this seemed to basically do what I wanted.
this is a check for empty values for params, so with your updated check an error will not be thrown anymore when empty values are passed. A better change might be:

```javascript
if (!value && value !== false) {
    ...
}
```
I'm not seeing the usefulness of this immediately. Are you proposing it this way so that in the future more options could potentially be passed to the imagehelper beyond just the compression level?
I prefer my old code. Please add stuff to it, don't replace it.
стоит подключать все, которые явно используются в этом файле
Ditto on moving to `Sitemap::Store`.
love me some pry
http://theoatmeal.com/comics/ie
I didn't know this was possible.
Do you really want to do the side-effect inside the condition? :-)
I created an utility method to create and register a debug event listener from a partial function. Check the latest commit.
Style observation: by convention, we append `()` to side-effecting methods. I see the definitions have the empty parameter list, but the call sites don't.
there are many questions to be answered on using zeromq. like how do do multicast, service discovery when new nodes are brought up, etc. this refactor is premature.
The php doc says: 
> Returns the time zone on success, or FALSE if the country and region code combo cannot be found.
http://www.php.net/manual/en/function.geoip-time-zone-by-country-and-region.php

So the function should never return an empty string.
BTW an empty string is invalid, too. The Result
`$address` here
да, с вероятностью 75% она не будет использоваться повторно. но 25% остаются же :)
Интересная мысль. Так и сделаю. Спасибо.
@fljot Мне не до конца понятно. Можешь привести пример действия, которое не может быть выполнено из за того, что стоит readonly ?
Пару инструкций, возможно, и сэкономили бы на создании статического массива при запуске, но вот при вызове метода никакой экономии не вижу. Так что и экономить, по сути, не за чем.)
вы считаете что 1% это одна ячейка, в данном случае это так, а если в клетке будет ячеек != 100?
Hmm.. this is very weird. My local one did not have all these changes. I may will probably delete this branch and create a new pull request since I dont know how to fix this
Already happens in the class metadata factory
This could use a couple more tests:

 * "Weird" argument types for subscribables, like class objects, C strings, etc.
 * Non-subscribable arguments.
 * A subscribable that sends a value upon subscription.
Useless check, since `result` can't be anything _but_ `nil`.
Blergh.. it seems this error doesn't expose a key when raised in the frontend :(
Is this necessary? Won't the default behavior of the back button finish the activity? `FragmentTransactions` can change this but you can specify whether or not to add it to the back stack.
If you are using labels in your form, you can say:

    fill_in "Email", :with => ...
use:

raw[:, event_start[k] - raw.first_samp - s_start: event_start[k] - raw.first_samp + s_end] = ...
Instead of creating a new Raw instance, I think it would be cleaner to use

    new.fids = [open(fname, "rb") for fname in self.info['fnames']]

..I think this should work and sorry about the many comment iterations ;)
yes, I like that better
I vote for using scipy.signal.resample() or scipy.signal.decimate().

While resample could be used to increase the sampling rate, it assumes the signal is periodic, which may give edge artifacts. So decimate() may be the better option. A problem could be that the filter decimate() uses is not zero-phase, maybe it would be better to implement decimation ourselves using zero-phase filters. @agramfort what do you think?
2012/10/11 Alexandre Gramfort <notifications@github.com>

> In mne/fiff/evoked.py:
>
> > @@ -314,6 +314,18 @@ def plot(self, picks=None, unit=True, show=True,
> >          plot_evoked(self, picks=picks, unit=unit, show=show,
> >                      ylim=ylim, proj=proj, xlim=xlim)
> >
> > +    def to_nitime(self, picks=None):
> > +        """ Export Evoded object to NiTime
> > +        """
> > +        from nitime import TimeSeries
> > +
> > +        if picks is None:
> > +            picks = np.arange(self.data.shape[0])
> > +
> > +        evoked_ts = TimeSeries(self.data[picks], sampling_rate=self.info['sfreq'])
>
> I am still not convinced about RawFromMerge as I would think you can do
> the same with assignment raw[picks, :] = data don't
>
you think?
>

Ok, admittedly this is true for the override / inplace use case. But what
about copying or non-preloaded data? As it looks to me it messes up the
file descriptors, at least in the raw case.
On the other hand side saving to the same file is not permitted. So maybe
my care is a bit paranoic. One could just enforce users to modify their
data inplace and save the data using updated names. Although I personally
like the copy option.

Reply to this email directly or view it on
GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1819162>.
>
>
I learnt me something. :)
double spacing "League  Campaign"
no need for the brackets
Can you get rid of these unimplemented  test methods? They were generated by test generator plugin, when using it only select the @should you intent to implement
Grammar nitpick: "what laws towns need to follow" might be better expressed as: "what laws a town must follow" or the lik.
@asanghi Could you clarify what is wrong with 'allows to change' on this line?
@mandubian  I have not changed the return type and `scala.concurrent.ExecutionContext.fromExecutorService` produces a `scala.concurrent.ExecutionContext`  which is indeed an Executor
Not really, it's duplicating ruby-info functionality found in the Ruby module.
Ok ! I was totally confused !

I have update the example. But, I don't think that the sentence is really clear :p
1. 向H.264/
为H.264/

2. 标点请中文化”，“、”。“
举例的话，三个多三个以上用”、“，比如下面.mp4 .m4 .m4a之间就是”、“以及”和“
it's more like a container. please rename it and according implementations.

same holds for the one below.
The initial decision to handle or not handle the media should be made by
the mediaService according to the supplied mimeType and file extension.
I think it should be up to the MediaService to update the media metadata
with whatever metadata it needs to store locally.

Kaltura supports audio, video, and images, each with their own mimetype.

If the mediaservice is not the place to put this logic maybe we can have
the createMedia method return a set of properties that the MediaCoordinator
could add to content item.

I could add the logic to the metterhorn and brightcove modules today if we
can do it right in the MediaService.

Here's the logic in the kaltura module
https://github.com/efroese/Kaltura-OAE/blob/master/src/main/java/net/unicon/kaltura/KalturaMediaService.java#L302

On Wed, Aug 22, 2012 at 8:19 PM, Carl Hall <notifications@github.com> wrote:

> In
> contrib/media/common/src/main/java/org/sakaiproject/nakamura/media/MediaCoordinator.java:
>
> > @@ -276,7 +272,7 @@ private void disconnectFromJMS() {
> >
> >
> >    private boolean isMedia(String mimeType) {
> > -    return mimeType.equals(mediaService.getMimeType());
> > +    return mediaService.acceptsFileType(mimeType, null);
>
> This doesn't seem to pass the same logic tests as before. With BrightCove,
> the test looked like mimeType.equals("application/x-media-brightcove")but now
> application/x-media-brightcove is not checked. This is also the case with
> the Matterhorn implementation. How does application/x-media-matterhornand
> application/x-media-brightcove get handled with this new setup?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thecarlhall/nakamura/pull/2/files#r1440995>.
>
>
Does it work to instead include the Ruby version in the Gemfile?

```ruby
ruby '1.9.3'
```
What's the order of these options? Does it actually matter?
for(tag <-listenerTag; ch <- channel if ch.isOpen) ch basicCancel tag
Could you replace the assertion here with a ValueError-test as is used with the other functions?
Вот это можно (и, наверное, лучше) делать в `SecondInit`. Хотя и так норм, да.
Во, здесь ништяковый порядок инклюдов.
It's usually easiest to catch the file opening exception, do things, then raise that very caught exception. For example:

```
try:
    open(runinfo_yaml)
except IOError as e:
    self.app.log.warn(str(e))
    raise e
```

If one wants to throw an exception in an explicit manner the way it is done here, one should provide all the parameters expected for the given exception, in the case of `IOError` the syntax is `IOError(errno, error_description, filename)`, and in this very case it would be

```
raise IOError(2, "No such file", runinfo_yaml)
```
See above - I think we should be explicit when using non-pixel coordinates, by just using ``* u.arcsec`` for arcseconds for example.
I need to rephrase - I meant we should recommend users always explicitly name the arguments, e.g.

```
results = psf_photometry(data=image, coords=galactic, psf=lambda x: exp(-x**2)
```

instead of

```
results = psf_photometry(image, galactic, lambda x: exp(-x**2)
```

but this is just a style recommendation. I'll reword.
At least for yum plugin, I don't think ID certs are used. (just entitlement)

Checking behavior in rhsmcertd plugin is a good idea.

GUI and CLI will hopefully be ok if Will catches ExpiredIdentityCertException in the handle_exception and handle_gui_exception functions.

I'm not sure if doing it all the time is really worth it, this isn't supposed to even be possible now as your cert gets regenerated for you, checking it after and SSLError is reported seemed thorough enough to me. However checking it before every connection is probably not going to hurt anything.
I suggest to change this line to only trim white space (at the start and end). And if the query then still contains white space, we should not search for a geocode, as that would clearly indicate a keyword search with multiple keywords.
haha, fixed
I agree it might fail, but how are you gonna trace this when it fails when running the paralell testsuite and you're having to go back and figure out which thread printed this? Or at which time exactly?

We have logging in place for a reason, to keep track of all the events and allow us to trace bus.

Plus, there's no need why to edit any log4j config file. I'd imagine by now you should have a set of log4 config files locally which you can plug any time (IDE or Maven) by adding for example: -Dlog4j.configuration=file:/Users/g/Go/log4j/log4j-infinispan.xml - I have set that file to log trace to a local directory which i can quickly open up with Alfred (http://www.alfredapp.com/)

This is way better than modifying the code to have CONSOLE_ENABLED = true ;)

If you want a log4j crash course, ping me :)
We can definitely write an externalizer, but honestly it's a lot of code written just to avoid writing 20 bytes once for every cache we start.
Sanne... I was talking about the comment below... in line 56. :)
and why don't you use ``foreach``. We don't need the count at all.
The problem that can now occur is if collection._offsets is None.  Previously, the check on collection._paths would be sufficient to prevent an exception from being thrown when doing a len() on None.  Now that protection is gone.
do hasattr(self, 'bigextents') instead... much cleaner.  Also, wouldn't it be better to simply initialize it in the constructor?
It was a duplicate.
I disagree with that, user should have control over the urlname so they can
adjust it to have the keyword phrase they require.

But if you dont want that in the release thats fair enough.
On Apr 20, 2012 8:51 AM, "Mike Hadlow" <
reply@reply.github.com>
wrote:

> > @@ -11,6 +11,7 @@
> >               <%= this.Hidden(x => x.Category.Position) %>
> >
> >               <%= this.TextBox(x => x.Category.Name).Label("Name") %>
> > +        <%= this.TextBox(x=>x.Category.UrlName).Label("UrlName") %>
> >               <%= this.Select(x => x.Category.Parent.Id).Options(Model.Categories,
> x => x.Id, x => x.Name).Label("Parent Category") %>
>
> User shouldn't be setting the UrlName, it should be derived from the Name
> property.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mikehadlow/sutekishop/pull/1/files#r712060
>
> в отдельный request вынести

при детальном рассмотрении видно, что лучше одним т.к. порядочно изменится код, как например [здесь](https://github.com/onPHP/onphp-framework/pull/101/files#L0L43). Ни перед этим реквестом ни после не удобно.
А вот тесты предлагаю вперед этого пульнуть.
> The whole point of having this callback is that multiple loaded tiles can be combined to be rendered in a single reflow, instead of one reflow per loaded tile. The way it works is that when a tile is loaded, it will not be made visible (reflow!) immediately, but when the browser decides it is a good time to do a reflow. In the meantime other tiles may also have finished loading, and will be made visible in the same reflow.


I understand your reasoning.


> If you want to see the image placeholders without requestAnimationFrame, you need to remove the fade animation css, close the page, clear the cache, and open the page again in a new tab.


I just tried. I can't reproduce the problem. Maybe FireFox is fixed. Using FireFox 18.0a2.


> Setting visibility needs a reflow in all browsers (see https://developers.google.com/speed/articles/reflow), and we also need to set the opacity to start the fade animation properly. This is why both is done in the callback.


We're telling the browser to do a CSS transition, so the browser can optimize things and do the repaint at a later time. I'm not sure it makes sense to wait for an animation frame to request a CSS transition to the browser. But I don't know really. I can't find good information on the topic. You can merge if you feel comfortable with using rAF here. I don't, but as I said, I don't know.


> The execution flow is like this: setting the img src means we start loading. Then some time later, the image fires the onload event. Now we schedule the reflow that will make the tile visible. With the callback, the whole process finishes, so I decided to trigger loadend here. It may also allow us to remove the backbuffer immediately when the last tile has finished loading instead of using a delay, but I haven't investigated that yet.

The delay was introduced because of the fade-in transitions. Without a delay the backbuffer is removed too early and the map starts flashing.

Thanks for the explanations.
This can be deleted?