labofsahil/github-event-dataset-2012 huggingface dataset:
"HACKERCUP"에는 'C'가 두 개이므로 2로 나누는 것이 중요
Why did you encapsule this in an additional method? Fisrt, you might not always want to use $this->text, second i don't see the benefit. the gain of creating that function is almost non-existent, but it creates unnecessary jumps in the sorce code that make it hard to read. What you are doing is spagehtti code. You might want to check this out: http://sourcemaking.com/antipatterns/spaghetti-code
This was a deprecated-proposal I recognized on rails-console. It needs to be a unique name to be identified. I believe the numbers can be dropped, though.
no problem, but please stop putting comments in busybox project... my cm9 branch was setup for newer kernels (defy+)
oops some javascript parens creeped in - haven't written ruby in an age
Quizá sería una buena idea actualizar también el fichero `bin/vendors` desde la [distribución standard](https://github.com/symfony/symfony-standard/blob/master/bin/vendors)
any chance of this getting merged in?  was having the same problem (hitting the list of ZCTAs would bring down Postgres)
is this a Seam2 dependency or a JBoss 4/5 dependency? If jboss it should be in the jboss profiles
why are we maintaining this here? and same to external/bash
これだとデフォルトで `Group#manager?(user) #=> true` になってしまうのであまり良くないですかね。
何も入れずに `null` のままの方がベター？
Having it in both places can be useful, depending on peoples usage, but the File version is likely to get more usage.

@yob - it depends.  #get causes a roundtrip, but #new does not.  Here is a more concrete example:

    storage = Fog::Storage.new(:provider => 'Rackspace', ...)

    # with two roundtrips
    storage.directories.get('dir').files.get('file').url(expiry)

    # assume it exists, skip api calls
    storage.directories.new(:name => 'dir').files.new(:name => 'file').url(expiry)

    # just use request
    storage.get_object_https_url('dir', 'file', expiry)

The former is frequently easier (and safer if the file or directory might not exist) but the later is faster with less going over the wire.  I think by having both this format (which is weird but works) and a top level request so that you can call it more simply directly, it gives people options to do whatever they are comfortable with.
early on in the commit history,  "virtualenv_no_global" didn't imply "running_under_virtualenv".  the former was just checking for the global file.  later I changed "virtualenv_no_global", but didn't update these if statments.  
I can change this.
Could we require the defaultMessage here?
Ideally we need to do a better job of protocol separation.  Let's sync up on best choice over IM and/or email.  In the CAS4 branch we had separated this stuff all out, but it was a rather extreme separation that would be too much for this.
I think in general the proxy pattern is any object that wraps another object (or resource).  The way this one works is it performs some attribute lookup on a collection of objects and uses an aggregate function to return the result.

I'm using it in JobRun because it has quite a few properties that are just aggregates of all of its actions.  

I plan on using them for some of the classes that have state machines as well, since they tend to delegate calls to the state machine and just return the result.
I’d say `t: Some` instead
Shouldn't "stop" make sure that result.isCompleted so that isTerminated shows the right stuff?
good idea, but then these must be lazy, not used when enabled = false
So this is only used temporarily?
Nice!

The following version has 0 allocation for the all-or-nothing cases (which includes the default setting) and doesn't repeat the natAddress validity check for both branches.

    private def allow(natAddress: Address): Boolean = {
      import provider.remoteSettings.{ NATFirewallAddresses, NATFirewall }
      if (natAddress.host.isEmpty || natAddress.port.isEmpty) false //Partial addresses are never OK
      else NATFirewall match {
        case "whitelist" => NATFirewallAddresses.nonEmpty && NATFirewallAddresses.contains(natAddress.host.get + ":" + natAddress.port.get))
        case "blacklist" => NATFirewallAddresses.isEmpty || !NATFirewallAddresses.contains(natAddress.host.get + ":" + natAddress.port.get))
      }
}
relative...
that said, this isn't going to be perfect, "go" makes it rather difficult, but I think it can be a bit better
Find the class and group range from the index of the first non-nil group after the first (pre_chunk String)
I am +1 for BTable.  What others think?
Oh, no, I'm fine with having both!
``self._D`` is used here but there is a ``discount()`` method. ``discount()`` should be either remover or used systematically.
Ok I've fixed this, it's probably too slow still but will take care of that another time
I've done that in the past. I forget why I did it this way, I really think I was just bored and getting creative  :)
what's the rationale there?  that just means you have to go to the db with all id fetches except for duplicate fetches within a given request.
do we need this methods?
typo formatting
Ah that's the "..." (parent) item you see in the GUI. Unfortunately that depends on GUI settings so doing it like this here is not safe as the user might have the parent item disabled and the set might only contain a single movie and then items[1] wouldn't exist and it would blow up.

Probably best to go with the way I mentioned in the comment further up i.e. setting the path of the first item in the set as the path of the set's CVideoInfoTag.
This looks great! Just add a one-liner docstring indicating what this file is for. Good to see decoupling from the actual Amazon data.

Just for fun, you might want to change the names away from the Amazon names, just to prove full decoupling.
Please stick with `j-WHATEVER` for job flow IDs.

How about `j-CREW`?
you shouldn't have to hack resolve_Call to do this. create a new type called AscribeType that is the type of the ascribe operator that calls into resolve_Ascribe. see e.g. how BuiltinFnType works
Is this right?  Our docs say you can set an item to be active when designing the control, but this would always activate the first one.  We need to search for the first control with active == true and use that before selecting the first child.
This looks weird as you are not checking the return value. wouldn't this function be broken if you have an expression inside an array ?
How about `animatesAppearanceChanges` instead? "Style" sounds like the cell style, which we've already established cannot be changed after initialization.
These can be condensed into `.origin = CGPointZero`, or omitted entirely (as noted by @jwilling).
Checking `self.proxyIndicator.hidden` is unnecessary here.
Fixed in d01da28
Don't update existing code (unless it's as a new commit which does explicitly that.)  But yes, moving forward, do try to make it clear.
@solmsted mentioned the Promises/A proposal and I looked at it again. It proposes `then(success, failure, progress)` It might not be that crazy to put that in the core module. It would even allow for what we talked about closing over the deferred and let `promise.then()` be the only point of contact with the deferred.
Do this in the LifeCycleAwareChannelHandler impl.
Hi there,

I'm bumping in because I'm very interested in this topic as I do a lot of
duration measurement on my own project.
From what I've read so far, nanoTime cost is much higher than
currentTimeMillis:
http://sharmaak.blogspot.fr/2012/08/systemnanotime-vs-systemcurrenttimemill.html

Cheers,

Stéphane

2012/8/26 Norman Maurer <notifications@github.com>

> In src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorker.java:
>
> > @@ -220,7 +253,32 @@ public void run() {
> >              }
> >
> >              try {
> > -                SelectorUtil.select(selector);
> > +                long beforeSelect = System.currentTimeMillis();
>
> I read somwhere that System.nanoTime() is not really something you should
> rely on. Let me try to remember where ;) Beside that what you think of this
> workaround? Sent from my iPhone. Excuse any typos.... Am 26.08.2012 um
> 13:54 schrieb Shay Banon <notifications@github.com>:
> … <#13962cfa73bb7d1c_>
>  In
> src/main/java/org/jboss/netty/channel/socket/nio/AbstractNioWorker.java: >
> @@ -220,7 +253,32 @@ public void run() { > } > > try { > -
> SelectorUtil.select(selector); > + long beforeSelect =
> System.currentTimeMillis(); As far as I know (and I researched it a bit)
> System.nanoTime is cheaper OS call wise compared to
> System.currentTimeInMillis. Also, if you use nanoTime you get considerably
> better precision which is what you are after here (compute elapsed time). —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/netty/netty/pull/565/files#r1460786>.
>
>
I'm not sure if that will work to well.. I think we will need to have some kind of reference counting and only return buffer.unsafe() directly if this one is the only one which use it. As otherwise we may "free" a buffer that is used atm
The call of C++ ;)
space between elements of the tuple.
I've updated this to RETURN_FALSE. I've also cleaned it up a bit by removing some of the other cases.
You could use ecalloc
Can you fix the indent here please? Also a blank line to separate your name :)
This is not just defensive. Sometimes `filter[key]` return just an element and the splat operator would not work.
So that's weird.. Everything green without it?
Can you remove the `assert_nothing_raised`? Let's assert that it returns the correct values, rather than not raising something.
The goal was to check that the once the connection was overwritten, it will not reaper. I think this is out-of-date test btw. 
So, the general idea behind this commit is to provide the possibility to simply overwrite the connection for AR::Relation instance, and provide the way to communicate with remote database on a short term.
In there it might be needed yeah, but here it's not. If the decision to backport happens, then the responsible can add it I think.
I have some initial thoughts about how to do it using Long.numberOfLeadingZeros, benchmarking suggests that that would bring the check down from 10ns to 0.3ns, but the code would look highly non-obvious as a result, so I don’t think it would be worth it.
Could you change this to:

    >>> A = np.array([[1, 2], [3, 4]])
    >>> A
    array([[1, 2],
           [3, 4]])

Use of ``np.matrix`` should be discouraged.
comma after Additionally
This should be a `{` or `<` (and by the way, `pprint(Piecewise, use_unicode=False)` looks worse than this).
This fails for me in 32-bit :

```
>>> limit((x**16)/(1+x**16), x, oo)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "sympy\series\limits.py", line 194, in limit
    r = gruntz(e, z, z0, dir)
  File "sympy\series\gruntz.py", line 682, in gruntz
    r = limitinf(e, z)
  File "sympy\core\cache.py", line 91, in wrapper
    func_cache_it_cache[k] = r = func(*args, **kw_args)
  File "sympy\series\gruntz.py", line 472, in limitinf
    c0, e0 = mrv_leadterm(e, x)
  File "sympy\core\cache.py", line 91, in wrapper
    func_cache_it_cache[k] = r = func(*args, **kw_args)
  File "sympy\series\gruntz.py", line 555, in mrv_leadterm
    series = calculate_series(f, w, logx=logw)
  File "sympy\series\gruntz.py", line 518, in calculate_series
    raise ValueError('(%s).series(%s, n=16) gave no terms.' % (f, x))
ValueError: (1/(_w**16*(1 + _w**(-16)))).series(_w, n=16) gave no terms.
```
Yeah, I don't do that mostly out of laziness and because I might need to change it in the future. Are these valid reasons to make it into a function?
left, right, center -> l, r, c if the change is made above.
The name of a Dummy() (if present) is an integer so the name would have been converted to an integer (see issue 3499, http://code.google.com/p/sympy/issues/detail?id=3499). Since POSform and SOPform will convert variables to string, there is no need to pass strings from here.
Yes, I agree.
Now I'm changing step-by-step.
So next step is to figure out that kind of things, i.e., better interface for scales.
Isn't it better to use `protected` here?
See the comments above about in the assemble routines about node/element issues.
now that you mention it this name seems pretty sloppy.

i tried extra hard to make sure you could tell what this was testing. i'm renaming this.
Pull this check out and put the try block underneath it. Reduce duplication and save a call or two when max_elements_to_print is not None.
为什么只放内存？进程重启数据就丢失了。
битовая маска конечно. по вхождению подстроки pass profile или любых проч расширений в параметр debug
"when trying to [call?] it"
The modifications to this file are almost entirely to get rid of some compiler warnings, and unneeded imports. Not directly related to the main thrust of the patch.
whitespace is weird: tabs rather than three spaces?

I also prefer to avoid shell session copypasta. Report the output and the commands separately, rather than force people to parse shell scroll back.
parens after metod names make them more clear.
btw do you know any good services that i can check different browser functionality, and not just rendering?
A good practice is not to comment things out, instead just remove them.. we have git to tell us what used to be there.
Looks like that error method is not used. please replace it with except Exception:
What is fastcgi and how do I test on it?
You removed 2 but you still do 22 dom traversals.

Perform one to find all elements possibly needing to be changed and then iterate over them yourself checking class against icons array and icons state to determine precise action needed for each.
Nonetheless I agree with @p that modifying $_FILES should be avoided if in any way possible. Can't you simply store the result of this computation elsewhere for later use, rather than in $_FILES?
You could have it as an parameter to the function (as in, whether to check or not)?
This is not a good idea. Services should not be created before compilation. IMO it is acceptable to hard-code errors that occur during container construction.
phpbb_ prefix here, maybe?
Separate PR please.
I copied it form the callback above
i was thinking we don't want the DNS SRV endpoints to be configurable.
Hm, won't this return luvit instead of agent binary version? Or is this intentional?
should be fine, since tests past.

user and winner are of the same type? (ChallengeUser) If not, it's safer to check user.id and winner.id
Aș prefera ca bonus_prob să nu fie parametru în funcție, ci să îl folosești direct ca settings.QOTD_BONUS_PROB.
The problem is not about the freeze call itself, but about the performance hit that appears whenever doing something with an object that has been frozen. In my mind the questions is, what is faster:
1. a request that operates on a frozen object
2. a request that does a clone and then operates on a regular object

i.e. is the clone overhead worse than the overhead of operating on a frozen object?
please revert any 'trailing whitespace' commits
Скорее всего это проблема плагина. Да и переделывать не хочется потому что на проде нода из пакетов и одновлять её пока не планируется. Версия - 0.6.12
Otherwise i'd constantly get "Modified" messages on submodules.. Is there another way to fix this?
it is good to undef such defines right after usage (e.g. at the end of current function).
Shouldn't you also be checking ```mock_set_double_array``` ?
Would be nice if this was an actual runnable ```doctest``` that references an ```iris.sample_data_path``` file.
```python
>>> import numpy
>>> numpy.__version__
'1.6.2'
```
I'm a little concerned with adding full awareness of AsyncCompilerAgent in a place that didn't know about it before. Would it make sense to create an interface just for the stuff the CSP needs, i.e. compileAdHocPlanFuture()? For example, it could be called AdHocPlanFutureCompiler.
This does not ``get`` options, it does ``_parse_cmd_arguments``.
.all() is not needed here.
Any unexpected/fancy things happen in here? Does this deallocate children? is model removed from its parents, static/global lists?  `destructor for the model class` is about as helpful as:
Why not, what's the problem supporting "/"?
Maybe this could solve the problem:

```python
for field in getattr(get_user_model(), 'REQUIRED_FIELDS', []) 
```
link to topics/auth/default.html#authentication-in-web-requests?
@dmethvin :goberserk:

Instead of `jQuery._etoggle`... I'd like to suggest this...

```js
jQuery.event.special.toggle
```
@gibson042 thanks, i missed that :-(, i added test for this case
I was thinking perhaps we need a Grunt task for this.
This behaviour seems to also be missing now...?
Am I being blind?  What'd I miss?
autoformatting == bah >:3
This is a by product of running 'rake appraisal:install'.  This commit has the same lines in the gemfile.lock; https://github.com/seomoz/rack-authenticate/commit/0669d27f04d4bad9eb312cf6a539e8694ad85c18. Why don't I remove the gemfiles directory and add instructions in the README.rdoc for setting up and running the tests?
No, because those aren't in this codebase.
That's the longer-term plan. We need tools to back-populate the cache and reconcile it with reality occasionally before that'll be robust enough.
Probably shouldn't use #all? here.
Man sollte "ASC"/"DESC" auch großschreiben dürfen (oder auch nur am Anfang groß etc.).
How does this interact with the stuff on L1655?
Really strange... The diff should only show the few lines I added, namely the "RunNotifier()" constructor with 7 lines, and the one line with the import for "ServiceLocator". I was careful not to change anything else in the file.

I will try to figure it out, then probably cancel this pull request and submit a new one.
I think the standard is to invoke a successful callback with the first parameter as null rather than undefined. null !== undefined

If I'm wrong disregard each of these reposts. ;)
iOS seems to have some problems coming out of the transform if the translation is still applied, and the viewport remains at 200% width, with (if you're sliding right) the new page entirely off the screen. The solution is to drop the transform entirely for a split second, and then [restore it](https://github.com/Toura/mulberry/pull/477/files#L1R69), which appears to give Mobile Safari enough time to catch up.

I'll add a comment to that effect if we decide to implement this transition system, since the whole system here is decidedly weird.
Remove the return keyword (this seems to be a functional-programming CoffeeScript-ism)
I still see references to the old getRules() name in CSSInlineEditor-test -- and those tests are now failing.

Also, should we make this an "_"-prefixed 'unit test only' method, like some other modules have?  It seems risky to expose these internal data structures for other purposes.
Typo in " they're are stale"
Should be 'sourced' :)
no biggie, though
I instead changed the implementation to use a 32-bit integer.
I love the name of this method.
For the `bookmarkDataIsStale:` parameter, please can pass in `NULL` rather than `NO`. Makes it clearer that the code isn't passing a value *in*, but ignoring a *return* value instead.
No. This is not important (the syntax). The content is important. First comes built-in libraries (os, datatime, ...), then Django, then other libraries (like mongoengine), then ours.
No? Here should be an error about arguments.
```tmp_value = value```
is there anyway we could do this with a slider? That would be cool ( if it's supported for the browsers we support )
p[ p.muted() ? "unmute" : "mute" ]();
Changed default for story camp.
So, we definitely want this commented out? Can it just lie safely in this code without being commented?
Hm, not sure I follow.

Background is to say if you want a background or not. backgroundColour is what colour you want it.
That's true, except the test environment is anyone's machine and not always that controlled.

Still, I take your point.
there is undefined variable (in ECMAScript). Also, the statement is always a `true` since typeof returns a string.

You can use `continue` statement -- that will decrease indentation level:

```
   if (typeof headers[property] === 'undefined')
     continue;
```
```
Shouldn't we exit here?
I think the js below should add these dom elements if it gets data back, as part of the "what if the twitter / github apis are down, or return nothing, etc etc.
I changed this to your suggestion but kept strip and changed the comment. I think it's more prudent to eliminate both leading and trailing spaces.
returners can be written in pure Python, or in Cython.
Good call. I'm thinking a bunch of the examples in the module docstrings should be updated to use kwargs -- esp. the more complicated commands like this one.
OK.  I'll set ```ssl_version = None``` up top.

For the constructor, I'm assuming you'd rather I default ```ssl_version=None``` and then, in _new_conn(), check if ```self.ssl_version is None``` and set it there accordingly?  That way, it'll be done after ssl has been checked for and  ```SSLError``` raised.
Applied in subsequent commit.
IMO, you should mortal this hv!

    hv = (HV*)sv_2mortal((SV*)newHV());
already ignored below, no ?
RUBY_PLATFORM only displays x86_64-linux which means you can't tell if the person is using Fedora or RHEL. I think I'll stick with uname... unless it's a security problem?
```ruby
      Changeset.joins(:task_status).where('changesets.environment_id' => self.id,
        'task_statuses.state' => [TaskStatus::Status::WAITING,  TaskStatus::Status::RUNNING])
```

Looking at the implementation this checks for both promoting and deleting changesets. So we should be good!
Good point. The variables should be there (we have the $user, and $environment variable) I will fix that.
nit: ev->evt to stay consistent with the rest of Gaia
nit: give names to your anonymous functions
Function init will be call when we switch the write process to haojing.
And there is one problem now: how can we create a Node and save?
Shouldn't remove the unit from `$size`?

Btw, to simplify a bit, you could get the last 2 chars outside, once size never changes. Also, you could override the `foreach` using `array_search` + `if`.
I would recommend that you use a proper editor and then actually try to compile the code before submitting. If I had merged this, it would have broken the build.

It doesn't look like firefox is doing the right thing, but maybe there's a setting that would fix it?
For future reference: please try to avoid whitespace changes in functional pull requests, because it makes it hard to see what's really changed.
The name `high_modes` is a bit confusing.  It sounds like these are the modes that are *above* some other modes.  I would just call it `modes`.
@iamleppert  cany ou review this code as well?

not sure if input.length == 0 is a robust check for handling lambda's in the JSON/context
No need for `@see`. Instead, use `@constructs` and `@file`. See committed file (InjectCore) as example.
These styles can actually go away entirely.
You're right. I'll replace them with stuffed bunnies.
Really, it probably ought to be localized anyway, and then I can use f(...) and depend on jinja's auto-escaping.
I'd prefer this to be `%s` in case processor_id some bizarre day isn't an INTEGER field. E.g. primary keys in Mongo are 24 bit strings.
What is it with you can always writing `count` in lowercase?
We should use a template for the email, using a normal Django template.
almost identical ? Look at what is available in the Request. There is far more stuff in it.
To make this really usefull, we could generate the `res_index` files in the update-data script.
b and c are not really true as you can overwrite ``getConfiguration``
@bschussek I guess you updated the PR after he loaded the page, changing the line numbers :)
you should add a short description before the long description
Could you name it YamlReferenceDumper so that we can add dumpers for other formats later if we want without having to rename this class ?
Using direct controllers is not supported at all in 2.2. This change allows to limit the security issue by allowing to execute code only in controllers (as this feature cannot be removed in maintenance release)
Yes, that's what we suggested for the Finder as well.
Ah, this is a typo. There should have been a return above.
The value of the deprecated option should take precedence here:
```php
return null !== $options['empty_value'] ? $options['empty_value'] : ($options['required'] ? null : '');
```
- why not put this stuff right after the `os.mkdir` above?
- the `chmod` should probably occur regardless of `worker_uid` and `worker_gid`
Quite likely. Could use @log.warn instead of raising an error, if that's what you're thinking.
worth a log for the errors.
This is only formatting (Eclipse auto-formatter).
You 're right. I updated the doc
More here: http://msdn.microsoft.com/en-us/library/aa387764(VS.85).aspx

We'll have to do this for the UI installer too.
It was my signature :P

Thanks! Fixed.
Not correct. It returns a transform.
>>    better to just fake the server in the first place.

>I agree. One word of warning: It is worth remembering that it takes an awful lot of effort to mock a complex service

Perhaps I should have been more precise in my wording. Where possible we don't want to fake the *server*, because that means you're testing owslib as well as your code. It'd be better to fake owslib.
DeadBush was a child of TallGrass before I started on this. It was originally named LongGrass. You'll have to talk with whoever originally implemented TallGrass and LongGrass to understand the reasoning behind it.
according to this that's actually not the case...

http://linux.die.net/man/2/signal

but after reading that again, I'm going to change this to be a HTTP request to ensure that we don't do this mid-update.
Sont utilisés ces imports ? (je les vois pas dans cette classe)
Возможно даже будет работать что-то наподобие
```ruby
def title
  base_title = "A very nice blog"
  @title ? "#{base_title} | #{@title}" : base_title
end
```
doc strings for these ?
Are the IronJacamar TransactionSupportEnum values exposed in the management model anywhere? If so, unifying around them makes sense. However, we'd need to support the old values as well for compatibility reasons.

If the IJ values aren't used anywhere, TBH I prefer the short versions used in the messaging subsystem!

Either way, this attribute looks to be an enum but isn't handled as such in the management model, or at least it isn't done in the standard way (see, for example, uses of EnumValidator.)

None of the above are reasons to delay this patch though, so I'll merge it. Thanks, guys.
You don't need this line anymore.
`clickEvent`
nono, it was just out of curiosity. 

and I just realized that this PR is still open! I though I merged yesterday!! Sorry for the delay :(
jejeje yes sorry
Merge issue, this should be `case 'dialing'` or we will regress.
Not a fan but I don't have a better proposition to make...
Ok. Maybe it's fine but the code needs to be cleaned up in a followup since remove does not work.
It involves a constructor (and a destructor), both of which will involve registration, leading to higher startup costs.

These aren't as terrible as QString though, because at least the constructor is trivial and doesn't involve allocation.

Still: If it can be avoided, we should.
How about this? `options[:octokit][:media_type]` will become a hash.

```ruby
require 'minitest/autorun'

def media_type_header(options={})
  options = {
    :version => nil,
    :param => nil,
    :format => 'json'
  }.merge(options)

  media_type = 'application/vnd.github'

  case options[:version]
  when String
    media_type << '.' << options[:version]
  when Integer
    media_type << '.v' << options[:version].to_s
  end

  if options[:param]
    media_type << '.' << options[:param]
  end

  if options[:format]
    media_type << '+' << options[:format]
  end

  media_type
end

class TestMediaTypeHeader < MiniTest::Unit::TestCase

  def test_defaults
    assert_equal 'application/vnd.github+json', media_type_header
  end

  def test_version_string
    header = media_type_header :version => 'beta'
    assert_equal 'application/vnd.github.beta+json', header
  end

  def test_version_integer
    header = media_type_header :version => 3
    assert_equal 'application/vnd.github.v3+json', header
  end

  def test_param
    header = media_type_header :param => 'full'
    assert_equal 'application/vnd.github.full+json', header
  end

  def test_format
    header = media_type_header :format => nil
    assert_equal 'application/vnd.github', header
  end

  def test_everything
    header = media_type_header :version => 'beta', :param => 'full', :format => 'json'
    assert_equal 'application/vnd.github.beta.full+json', header
  end

end
```
&& _checkAppPoolTimer == null
There was some talk of renaming MapCreatures to Creatures (or Map to MapTerrain) to better indicate what the classes do and how they relate to each other.
On the `error` object directly?
true -> leftover!
I'm thinking of adding contributors to the README. As more and more people contribute this would start to get quite large.
Inconsistent function naming here
Anyway, no reason to bikeshed. I'll merge this and we figure it out later.
please open a new PR - it will be targeted for RVM 1.17
merged. did away with private functions.
You can combine the declaration and assignment since the pointer no longer needs to be passed to the reader:  ```int magicN = sF.readInt();```
Ah!  I will try that tonight.  Thanks for your help with this.
Why are you raising e.returncode instead of e?
Why use instance of ... why not == openInProgress   ?
The single slash refers to the root of the directory.
Yeah I thought that at first, but no. He's setting the "queue" variable so that the rest of the function can pick up and actually run the action on that new queue.
Ohh I see what you mean.  Each opening delimiter has a different closing delimiter.  Yeah I'm not sure.
The scope now is for the whole cleditor
This is not a command in the form "composer shell completion" so it should be properly capitalized as a headline "Shell Completion"
Yes, if no element is found matching the criteria, an empty array should be returned. That is consistent with other implementations.
routes are regex so you could do a conditional ?
I've preserved the old typo, will change it.
Space! Where is space between brackets and operators?
If you check `task.length` at the start of the process function, then this is not needed again here.
Did a refactor last week around this, via @gklopper, that means the `name` property now _is_ the `shortName`
not a good idea...
this should be `return message` - avoid implicit returns please :)
I think these 4 lines are already being handled via the `wp_parse_args` up at the top.  My guess is that you forgot to delete these lines when you did the array up there.  Unless, of course, those need to be in place to account for blank data in the options table.  I'm less convinced of my need to comment here, but I'm going to submit it anyways in case it triggers something in your head.
I don't think so as I'm nullifying `selectedTab`.
`deactivate` seems to be only fired from here:
https://github.com/ochameau/addon-sdk/blob/9ef15ef357a8fc9776fc25b9a8a9903804b5319f/packages/api-utils/lib/tabs/observer.js#L56

But you should have a better picture of this whole API as you wrote it, 
so if you think I should do otherwise, please tell me.
I don't force to a change here, but I do think that leveraging array map / filter / reduce would made this a lot easier:

```js

function isDirectory(entry) {
  return entry.isDirectory();
}

function isFile(entry) {
  return !isDirectory(entry)
}

function getLeafName(entry) {
  return entry.leafName
}

function readDir(path) {
  let file = MozFile(path)
  let entries = enumerator2array(file.directoryEntries)
  let dirs = entries.filter(isDirectory).map(getLeafName).filter(isAcceptableDirectory)
  let files = entries.filter(isFile).map(getLeafName).filter(isAcceptableFile)
  
  return dirs.reduce(function(result, name) {
    return result.concat(readDir(joinPath(path, name)))
  }, [{ path: path, dirnames: dirs, filenames: files }])
}
this change comes with one new dependency.
L10n!
weird. how could we pass the connection then?
Cool, didn't know about that one.
Looks like you duplicated this example group accidentally, unless I'm not noticing some difference....
space after `*/`
Thanks for the feedback.  I apologize for dropping the ball. 

I made the recommended changes, except for the refactor to the util.  I am going to tackle it next.

--jon



On Thursday, June 14, 2012 at 1:00 AM, TJ Holowaychuk wrote:

> > + .replace(/\s+\}$/, '');
> > +
> > + var spaces = str.match(/^\n?( *)/)[1].length
> > + , re = new RegExp('^ {' + spaces + '}', 'gm');
> > +
> > + str = str.replace(re, '');
> > +
> > + return str;
> > + };
> > +
> > + 
> > + runner.on('test end', function(test){
> > + tests.push(test);
> > + });
> > +
> > + runner.on('end', function(suite){
> > 
> 
> 
> unless 100% necessary we should stream the output, instead of collecting an array and outputting at the end. 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/visionmedia/mocha/pull/349/files#r982317
> 
>
もっとわかりやすく
I can write a small php script that does the hole mass-renaming and formatting thing at once.
This import is not needed.
Please remove this too if unneeded
I know you prefer Object.keys() for these kinds of loops. Why not use it here as well? :)
and here :p
If you make the above change I think this becomes backed=CACHE_ID
Indent these too! :)
Ok, coming in next commit.
Yes. As long as your current locale is UTF-8 encoded. If your locale is e.g. 'C', encoding with UTF-8 is not sufficient. In the [strftime test case](https://github.com/dmdm/test_strftime/blob/master/tests/test_strftime.py#L44) replace ``encode('ascii', errors="xmlcharrefreplace")`` with `` encode('utf-8')``. You will notice a failure like this:
```
File "/home/dm/myprojects/pelican3.0-pyk3-devel-env/src/my/test_strftime/tests/test_strftime.py", line 119, in test_strftime
    fmt("C", "%c Øl trinken beim Besäufnis", "Fri Mar  2 00:00:00 2012 Øl trinken beim Besäufnis")
  File "/home/dm/myprojects/pelican3.0-pyk3-devel-env/src/my/test_strftime/tests/test_strftime.py", line 53, in fmt
    result = unicode(result)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 25: ordinal not in range(128)
```
This should be protected with `unless Rails.env.production?`, just in case the Konacha gem got loaded in production.
先の展開を考えると `feeds/effects` とか `feeds/events` とか、わけられるようにした方がよさそうですね。
I was thinking of forcing every other function to set it to false. I don't see many functions needing it.

Just had another thought. An arguably cleaner way would be to add a `makeHPosSticky` (or just stickyHPos or something like that) option in `motionArgs`. That way we can set `stickyHPos` inside `evalInput` on `vim` according to the bit in `motionArgs`.
No. nodeunit runs anything it finds under `tests/` as a test script. Don't want that, since `test-utils.js` is a library.
Yea. This is probably a better idea. :)
> Any reason to use @commentable rather than commentable at this point?
(I want this feature lots! :D But I want to make sure it's bulletproof. ;) )

When this form is loaded from within the user's inbox page, the variable changes to <code>@commentable</code>. Not having this in the code threw all kinds of errors. I have included a comment in the next commit I'm working on to make that explicit.
It will count as changed - it is set to changed in the change state method, which the constructor calls.
Check installBind.get_syco_plugin_paths and _copy_conf.. To loop all syco plugins.
Y esto?
Couldn't think of a way to write an IP that's _guaranteed_ to be wrong here, so I just picked one that's not in the fixtures. Advice welcome :)
Ah, thanks @ohadlevy!
Will discuss in https://github.com/Katello/converge-ui/issues/74
My opinion is that, in this case, we would be exposing our Binary implementation detail and not really adding an "extension" to the JCR spec, as far as binary implementations go.
First sentence doesn't make sense
It looks like a parse error to me. The variable below isn't declared, either.
Its preferrable to changed state before setting it as a parameter in the action and check parameters.

Although some actions may store a live reference to the parameter, others may not, resulting in an undesired behaviour.
Furthermore, I'm aware some actions use checkParams to set their behaviour.
Well, in this branch, the fetch functions for those indices only expect (and require) a callback, and responder makes functions that expect an options hash _and_ a callback.  So we either present them differently in the server module, or pass them a parameter they don't need.

So I'm not sure!
I have no problems with that, it's just a habit :-)
функция relax?
Este no me mola
I agree it should match as per the link text on screen.
consistified
why not  ``case (v1, v2) => v1 + sep + v2``
Same comment as in https://github.com/scala-ide/scala-ide/pull/261/files#r2419165, in case you believe it's worth (which I'm not sure it is, to be honest :))
Is this method really useful?
My main reason was the code's duplication. But I agree that this trait needs not everything that is in ``ScalaProject``. 
Maybe you could extract a the common functionality? Or do you think is  too much burden for little gain?
Any chance to move this function in a new class?
The `MaxMindCityProvider`, MaxMindCityIspOrgProvider and the MaxMindCountryProvider have the same method.
:+1:

Just require the composer file here :)
No substantive changes in this section, that I can see. For options sections like this, I prefer the "open" style with spaces around the `=`.
I'm actually moving this method in to ShellViewModel in my next commit, so I'll inject the func there. LOL. Stay tuned for Belfry Images' new club hit, Inject the func.
I don't see namespace prefixes anywhere else in the JSON spec. Does it really belong here?
Default value is wrong (not in the list).
I think it's redundant to have it both in `onClose` and `onError`
I just left it in there since there was a reference to it.  

Maybe it needs to go smaller once the template goes small?  I'll take a look.   

--  
Kenny Lee
650-336-5533


On Saturday, December 1, 2012 at 3:57 PM, agoln wrote:

> In app/views/events/featured.html.erb:
> > @@ -1,11 +1,13 @@ > +<% badge_size ||= "small" %>  
> Usually, this is done for partials. When are you expecting this to change?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/agoln/FlashVolunteer/pull/30/files#r2286521).  
>  
>  
>
What should have been fixed here is not going through the gateways group array but rather through the $a_gatewaygroups return through the previous function call.

This way you do not miss any dynamic gateway!
For me this is a regression or converted bug
This makes me think we should make the URL a variable, and get it from the settings, but well, that's beyond scope.
there's a dojo function for this :-D
Is it even valid for `remoteHandle` to be `null` here?
@knipster yep. Here it's more a matter of what makes sense in the context of the `--help` where someone using the program will see it, so I think it makes more sense this way.
I just copied it over from the set status function in webserve.py (the json.dumps)
Don't know actually, that code was copied and pasted from before. It seems
unnecessary to me, too, I'll get rid of it. I'll also add that test
@dengemann.
On Dec 15, 2012 2:20 AM, "Alexandre Gramfort" <notifications@github.com>
wrote:

> In mne/fiff/raw.py:
>
> > +    ----------
> > +    index : list-like | int
> > +        List of ints or int representing points in time.
> > +    use_first_samp: boolean
> > +        If True, the time returned is relative to the session onset, else
> > +        relative to the recording onset.
> > +
> > +    Returns
> > +    -------
> > +    times : ndarray
> > +        Times corresponding to the index supplied.
> > +    """
> > +    if isinstance(index, int):
> > +        index = [index]
> > +
> > +    index = np.array(index, dtype=int) + (first_samp if
>
> why dtype int as you divide by a float after?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/273/files#r2428162>.
>
>
> Did you mean np.intersect1d?
> np.setdiff1d is the set difference

maybe :)
if the method doesn't fail, will this still get called?
This method name is disingenuous as it does not return a boolean or even truthy value.  Perhaps it should be `create_refinery_user_if_required` or similar.
and where is the second argument in your example about using it ?
Shouldn't this be an `<input type=submit value="Update">` element? And it is Upda<b>t</b>e not Upda<b>r</b>e
Skipped this before but the "issue" here is that you make application-manager and wiki-manager plugins part of XE which they are not right now. This might require a vote.
Чо это у этих трех _ на конце?
No es un modelo, es un Control
Yes you are right, I corrected the commit (reversed meaning and moved the text to class comment).
Geocaching.com here too
Same here and below, to ensure the thing is really gone (I understand it's a demo script, but the more complete the better)
I don't know, I feel like what the code is doing and why is made clear by the exception name of "UserAlreadyExists". Even if someone doesn't understand how it works right off they can at least see its checking if the user is already there by scanning the code.
Since {} and [] evaluate as a False in a boolean context, why not make is_valid return the dictionary or list of grievances already, and then use ```if is_valid()``` anyway?
hu what' s that ? could we refer to JIRA numbers?
i guess cancellableTasks can be final as well
@tristantarrant  +1, this wouldn't bring any performance gain.
not sure we should swalow this, at least trace-log it..
I know there is no strong need, but is it to be avoided? I like to use the logger as the implementation code is  cleaner.

I would say there is no need for lazyness, but since I already did it I'd rather keep it?
Hmm, I think I'd rather make another class extending RecentlyUsedContainer which implements this functionality. I'm open to refactoring this class to make extending easier.
Please, don't use inline styles.
Relative to the repository working directory? That seems at least somewhat complicated to calculate. Besides, we already have the info here.
Careful here. Replace is not done in place:
```
>>> a = 'foo bar'
>>> a.replace(' ', '_')
'foo_bar'
>>> a
'foo bar'
```
What triggers the exception is having colors for the hatch that come from a collection or colormap -- in which case each rgb triple is a numpy array, not something hashable as was previously assumed by the PDF and SVG backends.
Could we make it so that you can pass *request* in as an optional arg? Maybe change the signature of redirect to

```clojure
([url])
([url type])
([url type request])
```

Or something similar.
We can easily do version aliasing in a very unintrusive way - what do you think about 3d1b0f0bd9b48a3d36917c77463e79624c0e21e9?
appinfo is repeatable, so I wonder if it wouldn't be better to store this in an array.
add scroller to scroller? Is this intended?
No need to define a function.
@christianv 

What part - the underline? It is just copying the OAE lhnavigation rendering.
That's probably what this is for, but I'm not seeing it in the UI?
i need it for:
char *dirname(char *path);

see man 3 dirname
I don't really get it then - in your kernel factory you are creating a kernel with default settings only - e.g. gaussian kernel with certain width. How can the user supply a certain width to be used? Wouldn't it be better to have some clone() / copy constructor for the kernel objects to create a clone of the kernel with its parameters?
please use int32_t here
Yep. It's a fairly subtle change. The old green was a little bit more muddy than the green used in the design, so I altered it to look like the design. Paul is okay with it. He almost didn't notice the difference.
this could be a lot simpler `<% status  = experiment.active? ? 'status_enabled' : 'status_completed' %>`
There's a big comment at the start of this file that talks about how we don't write pages in the current thread, which probably needs to change.
I don't see a reason to check page-> modify->write_gen at all; if the page's write generation hasn't changed, then old_upd will necessarily be equal to *upd_entry.
I don't think I understand why you wouldn't just do [1].forEach(forEachNoCallbackIterator)
lolwut?

Yes, I know it's currently WIP, but you should add new entries as you go, not have a bunch of empty ones.
if anything, i think this function could be changed to how some of the edge cases are handled, because thiey should work the same.
Is db.checkIn thread safe?
use h3 (`###`) for sections - h1 is "Numbers" and h2 is the title of the post
я думаю это дублирование излишне
Why did you remove the sprintf ?
You could use something like RuntimeException(sprintf(' .... %s ... %s'), $type, $format));
OK, can we use the genericized type? Map<K,V>
Done, and that's a much better design.
OK, mais ça n'économise pas de ligne ça, ou alors il faudrait un truc du genre :
    $max_view = !$max->f('max_view') ? 1 : $max->f('max_view');
Je vais faire ça.
ok so basicly like these?

date = mongoengine.DateTimeField(required=True)
from_time = mongoengine.DateTimeField(required=True)
to_time = mongoengine.DateTimeField(required=True)
latitude = mongoengine.DecimalField(required=True)
longitude = mongoengine.DecimalField(required=True)
temperature = mongoengine.DecimalField
windDirection = mongoengine.StringField
windSpeed = mongoengine.DecimalField
humidity = mongoengine.DecimalField
pressure = mongoengine.DecimalField
cloudiness = mongoengine.DecimalField
fog = mongoengine.DecimalField
lowClouds = mongoengine.DecimalField
mediumClouds = mongoengine.DecimalField
highClouds = mongoengine.DecimalField
precipitation = mongoengine.DecimalField
symbol = mongoengine.IntField
I did not know that. Thats why I did it like that :)
This could be docstring.
No dot at the end. Please end the comment with `*/`.
Just commited this.
Без eval никак?
I think that would be no more than

    logging.info("Timestamp: ", timestamp)

because I think the logging module provide what function it's been called from. 
But getting rid of them is better imo. They have already been validated here.
So you still didn't fix this..
You have to call generator.next and check the result including that it raises stop iteration
Indeed (..!), the signature must be changed to accept `System.Int64[]` (since the built-in primitive type `int` maps to `System.Int32`).
This is changing current behaviour. You probably want to do:

``` ruby
amount(options[:subtotal] || money)
```
I'm happy if you say that this is outside the scope of DoctrineModule. However, I think the code has it's place, even if not in DoctrineModule. Why should every dev write the same lines of code when most of them just want to create a `function login($username, $password)`?
I will prepare a new commit (for using the prefix) and add it to this pull request.
That's a good point. Instead of hard coding the dependencies' versions here in `/hibernate-redis/pom.xml`, they should  be put in the parent `pom.xml`. I'll add those versions within `<properties>` tag in the parent `pom.xml` and commit the change.
listen можно вывести за цикл. Ждет на самом деле accept, listen только переводит сокет в режим приема соединений.
because circusd could have multiple children to reap. The next commit make it more obvious.
is this the right epsilon for cs ? below we are squaring it
vectorize gpke, work in batches to not blow memory consumption?
Are you familiar with a block form of `Hash` [constructor](http://ruby-doc.org/core-1.9.3/Hash.html#method-c-new)? It's just a way of defining default value for a hash, in that case on both levels. Though, it might be a bit tricky, so I'd understand if you reject that PR.
We should store `this.indicator.childNodes` in a var because it's used repeatedly in this method.