labofsahil/github-event-dataset-2012 huggingface dataset:
This should support "class" and not "className" for consistency - I just changed this to 'class' here and everything worked as expected.
OK. I will try to put al of the code in one file.
I think that implementation with drop down list would better, since it takes less space and it is more user friendly. What do you think
space between `search:` and `function`, like `search: function(n, ctx, self){`
Just a suggestion: you don't *need* to do this.
"Mozilla Popcorn"
new ScrollGroup.ScrollGroup?

That doesn't look right.
This looks weird, but could be right, I don't know.
Also, if you're using this more than once, it might be good to create it once at the top and reuse it.
Spacing around the 0.
Is this save() and matching restore() call really needed? It seems you have ctx.save and restores down below that should cover it?
```@deployment.stub(:new_record?).and_return(false)``` isn't necessary at all. I've taken it out. 

 I always thought that an active record couldn't be tested without been saved. I copied this line from your last pull request thinking that this was the way of faking an active record saved object. 

This is very interesting, i thought that partial stubing was the way of going. I'll give a try to this new approach of testing
Oh, didn't remember of its existence. Fixing.
The watch requisite is based on the ``watcher`` function. State Python
If `__virtual__()` returns false we can just end module investigation here and move on to the next one. This removes the need for the branch on L542.
`Option(s).map(_.toString).getOrElse("null")` is a bit more readable imho.
Should this be `IF(NOT DEFINED BUILD_NO_CLANG)`?  I would think you only want to set it if it isn't already defined...
in 2ta inja che mikonand
any particular reason you switched to the value from the returned object vs the param?  I guess it is a bit safer if perhaps you had someone change the name while the command was running ...
nit: s/source/sourceStream? probably doesn't matter.
It's there because of the original idea of overwriting the `write` method. I'll change this!
Ok, we can let rest the issue until the script is done
We should try to find a more expressive class name than `lbl` :)
This will cause extra reflow, and hard time for localization.

Can you extract `undoTitle` from mozL10n functions instead of the innerHTML?
You need the copyright comment at the top of this file.
What `fromlist` does is actually quite complicated, but the end result is that if `nm` is something like `foo.bar.baz`, then `__import__(nm)` will actually return the `foo` module.  Whereas if you do `__import__(nm, fromlist=[...])` it will return the `baz` module, since the implication is that your purpose is to import some local names from that module.  Come to think of it though, in this case you're really not trying to import any specific names from `foo.bar.baz`, so I guess passing in `''` is fine since it still forces the behavior you actually want.
It is actually the node the client is running on, it is not necessarily the leader node.
This needs to be untranslatable and the option openExternalLinks activated. You can then use ``<a href="http://en.bitcoin.it/wiki/Changelog">http://en.bitcoin.it/wiki/Changelog</a>`` as the string.
booooolean :smile:
maybe if(Crafty.image_whitelist[ext]) would be even faster?
You should escape all slashes in `$prefix`
Why did you choose to change from JPA handling this type to you manually assign the type?
I notice that you are now also joining using the @JoinColumn(name = "DTYPE"), this is still needed?
If you don't have the automatic inheritance anymore the DTYPE is going to be used?
`system_id`
I wonder if we could make this a bit more flexible: If we would pass the $child object to getType, then each driver could implement its own strategy for determining the correct RDF type (and classname mapping would be the default implementation). Or do you think that this would be overkill?
Masks should be #define's, not enums.
maybe we should return a generic exception instead of throwing an exception
Haha good to know, that's definitely a bug in those cells as well :)
I agree. We'll have two codepaths, determined at runtime. The XP path will buffer incoming data into a file created with FILE_FLAG_TEMPORARY | FILE_FLAG_DELETE_ON_CLOSE, and then play it all back when the first call to read() comes in on the stream. With RPC = 1 subtransports, that indicates the transition from the request phase to the response phase, and that transition can only occur once.

I see this work happening next week, as part of the Push pull request.
Maybe should be "make FREEBSD9=1 BASE=/cdrom/usr/freebsd-dist"
Yeah - this is for launching gdb with the profiler enabled, for debugging the profiler code (I ran into an assertion failure when running a debug build). The other scripts will be coming. I just started on the symbolicate one first, and you wanted it for testing.
Don't need var parts here.
Is that an appropriate Redis key name?
comment looks wrong, shouldn't it be detail?
why `databaseName=None` here? It's not used within the code as far as I can see.
I'm pretty sure it's not 2010 anymore. So I'm suggesting a: `'  © '+ (new Date).getFullYear() +' Nodejitsu Inc.'`
Let's try to think through what things would look like with a more structured return value. This might be a record or a proplist like `{ok, [{cookbook_delete, true|false}, {deleted_checksums, Checksums}]}`.

Also, it might be worth seeing if refactoring some of this with a helper function that handles some of the branching in funheads might improve the readability. I think it would be easier to read with a bit less nesting.
s/sort/sorted/
+1 for OAuth support in core as this is quite common nowadays and needed on
almost any website.

However, I'm not sure whether we should also include integration for
specific oauth resource owners.

On Fri, Sep 21, 2012 at 3:37 PM, Pascal Borreli <notifications@github.com>wrote:

> In src/Symfony/Component/Security/Core/User/LdapUserProvider.php:
>
> > +     * @param LdapInterface $ldap
> > +     */
> > +    public function __construct(LdapInterface $ldap)
> > +    {
> > +        $this->ldap = $ldap;
> > +    }
> > +
> > +    /**
> > +     * {@inheritDoc}
> > +     *
> > +     * Due to Ldap limitation, this method should never be called.
> > +     * Call loadUserByUsernameAndPassword instead.
> > +     */
> > +    public function loadUserByUsername($username)
> > +    {
> > +        throw new \BadMethodCallException(sprintf('You sould not call the method "%s"', __METHOD__));
>
> sould => should
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/5189/files#r1661216>.
>
>
you need to add the link to Doctrine and the ``@license`` tag (Doctrine is not MIT but LGPL)
this extra line should be removed
Yes, you could change default user/repo via this option, but if you don't want to do it each time, you could change "gh_user" and "gh_repo" in gh_values.py
もう一度ソースを見てみて、まとめられるようでしたらまとめたいと思います！
looks like function is missing associated vars for some of those deps...
Oh I was testing for updating the Anniversary. I took it out.
I prefer either the 1 line or 3 line style
  } else if (condition) {

or 
  }
  else if (condition)
 {

It would seem like the 1 line style is most consistent with the java guidelines mentioned in the wiki
@brittballard I don't love this. Choices seem to be
* Put a guard in front of `ActivityCreatorJob` every time to ensure it's a Yammer User
* Add this functionality to the ActivityCreatorJob itself.
算是解决了，直接把sample里的"&"都换成了"、"
- 一般写公式的需求里应该没有空白这一说法
- 即使有也是少数，也应该让他们自己去解决这个问题，而不是写在说明文档里面给所有人看
这一段的内容在正常写毕设论文的时候应该用不到吧？还是我想到有点极端了？或者你可以举一两个user case
Эта модель не нужна
you can use NumberTraits<...>::castToDouble ( )  directly
seperating -> separating
There's info on it in the pdf documentation (see src/doc/openimageio.pdf).  The main point is that demonstrates the optional argument mechanism.   Examples of desired behaviour:

Generate a normal histogram of 0th channel
```
oiiotool A.png --histogram 256x100 0 -o A_hist.png
```

Generate a cumulative histogram of of 0th channel:
```
oiiotool A.png --histogram:cumulative=1 256x100 0 -o A_hist_cumulative.png
```
ist in diesem diff schwer zu lesen: ich habe deine mapper-methoden aus der LeagueService entfernt. stattdessen kann ruhig immer direkt das repository aufgerufen werden, der umweg ist ueberfluessig gewesen
alle assets werden automatisch von verschiedenen urls heruntergeladen. diese zeigen zwar auf den selben server, aber da es unterschiedliche urls sind, kann der browser mehr assets parallel herunterladen.
it looks more natural 

```ruby
 if !valid_size?(options["size"]) or !valid_database?(options["databases"])
```
That's very disappointing.
More as trivia than pointing out something to change, but this is a more concise way of rescuing an error in a method:
```ruby
def foo
  bar
rescue StandardError => e
  puts "Uhoh"
end
```
Посмотри внимательно на `lib/server.js`, там результат передаётся во вложенные вызовы в том числе.
This looks like a fragment left over, clean up please.
or perhaps similar to https://github.com/basho/riak_core/commit/40d49f9864b5528b97db6a8e54626a7fb61785a7 make the ets call in a function defined in `webmachine_router`?
Looks like this needs "flag" or "option" to be grammatically correct.
On 12/03/2012 08:40 PM, liyangfnst wrote:
> In libvirt/tests/virsh_undefine.py:
>
>>       undefine_twice = params.get("undefine_twice",'no')
>>  -    uri = params.get("remote_uri","none")
>>  -    remote_ip = params.get("remote_ip","none")
>>  +    local_ip = params.get("local_ip", None)
>>  +    remote_ip = params.get("remote_ip", None)
>>  +    xml_file = params.get("xml_file","tmp.xml")
>
> Yes,os.path.join(test.tmpdir, 'tmp.xml') is better that it will clean up
> the "tmp.xml" file automatically.I will change it.Thanks...

Yep, I just remembered about that.  It's part of autotest client that 
does this, so not code I look at often, but very handy automatic feature.
these paths should probably be to "cms", not "djeese".
If you work on the Quantum code, it's known; however, a note here is a very good idea.
Probably shouldn't be encouraging people to hotlink images... ;)
backtick Ember.Mixin ?
The issue is that enumerables aren't necessarily arrays. However, they do implement `toArray` so it may be sufficient to do `objects.toArray().reverse()`.
The problem is: if you leave the control, and you were not dragging, you will still consume the mouse leave event.

I think the right logic is:

1) if not dragging, _cancel_drag return False
2) _drag_cancel_keypressed returns True, always (it's only called when dragging, anywau)
3) _drag_mouse_leave  returns the result of _cancel_drag
When I tried to send a message with unicode characters before the change, I was getting this:
```UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 280: ordinal not in range(128)```

My first idea was to apply ```unicode(msg_body, 'utf-8')``` before feeding the body to send_mail, but I got:
```TypeError: decoding Unicode is not supported```
(the message body was already a ```django.utils.safestring.SafeUnicode``` string).
This commit fixed it for me (Django 1.4).

By the way, I just found a similar commit elsewhere, this one using smart_unicode:
```raw = u'%s' % smart_unicode(message.message().as_string())```
https://github.com/michalkwiatkowski/django-database-email-backend/commit/418292637546ae4e8ed24a0fde34fe3f42fa92c9
flake8 supports py3k and runs pep8 and pyflakes (hence the name)
Same as other opacity setting; must be smashed together.
An old revision of Glue had `deliminator` but I was talked into changing it to `delimiter`. AFAIK, both are acceptable but `deliminator` is more unix-slang.
Not sure here…

The code used to _clear_ the status output and wait for a `statuschange` event to update it. Did you change this on purpose or is that a merge issue?
one var per variable per our coding guidelines.
actually that it is never displayed. I will remove that
Is it possible to adjust card sizes by using CSS here?
Looks like <code>_adjustCardSizes()</code> does similar works that CSS can achieve.
I do not recommend to set styles based on strings library, use a classname instead, or another css selector :D
Add {} when it is an if/else. You can omit them when this is a one liner 'if' only.
When are we using the search feature?
I can't find any call to openUI with a parameter.

Please remove it if it's unused.
I will not complain if you add an intermediate variable |files|.
nit: remove the false argument.
what is the benefit? consistency with the rest of the code?
Like this.  This makes the model simpler (appsettings => xmlsettings).  It removes the dependency on env var completely.
Maybe ShouldFilterMsBuildOutput(xxx).   ShouldXXX return bool as natural.   This don't try the api name to just warnings.   Upto you, change or not change (it is internal not intended for extending).
I feel like this comment should just replace the comment on line 12. Otherwise they contradict each other.
we can get rid of these debugs, or add an argument ``-d|--debug``
If non-binary data is used the original implementation bombed out because that would be undefined (assuming strings, etc).
Extract out the magic number into a class constant.
Can you specify that it's the autohide checkbox (in case more checkboxes are added in the future).
I'm confused - how is it that this "fixes" the arguments? It seems to simply wrap each word in quotes, i.e.

```shjs test word1 word2 word3```

gets mapped into

```"word1" "word2" "word3"```
That's true let's remove addressing at all
ss is not a depickled sourcestamp but an 'absolute sourcestamp'. If I understand it correct the absolute sourcestamp is a sourcestamp that has no relation with an entry in the database (filled in fields but no id's). Therefor this sourcestamp has still to be added to the database.
The addSourceStampToDatabase processes patch_info before adding the sourcestamp to the database, addSourceStamp lacks this functionality.
It was recommended to me by Matt.  I was originally going to write it using explicit looping, but the code wouldn't be very succinct at all.
Oks Work in this
[LinkedIn](http://www.linkedin.com/)は[次世代の HTML5 モバイルWebアプリ](http://www.linkedin.com/static?key=mobile)にBackbone.jsを利用しました。Backboneによってアプリのモジュール性、編成、拡張性を容易に維持することが出来たため、LinkedInのユーザー体験の複雑さをプログラムすることを可能としました。このアプリは[Zepto](http://zeptojs.com/)、[Underscore.js](https://gist.github.com/4285928)、[SASS](http://sass-lang.com/)、[iScroll](http://cubiq.org/iscroll)、HTML5 LocalStorageとcanvasも利用しています。技術チームはモバイルでのパフォーマンス改善について[LocalStorageを利用した体験談](http://engineering.linkedin.com/mobile/linkedin-ipad-using-local-storage-snappy-mobile-apps)をブログで紹介しています。
and we can't use this string func either then
Might be worth explaining that the `wrap` method itself is run on the master.
Again, Javadocs that describe when to use this API, and how it behaves will be helpful to people who want to extend from it. For example, what does the boolean result represent? I see from the source code that it's used to decide whether or not to call MatrixRun's inherited preCheckout method. But as someone implementing this extension point, I wouldn't know whether I would want that or not, without more details.
Can you please do `module.exports = windows`
I think that "Unable to decode data given in a valid image." is quite understandable for `clipboard.set("data:buggy-uri", "image")`. It's not a weak assumption that some code will later throw a exception later, I design the code explicitly in that way in order to avoid to add unnecessary complexity.
shouldn't there be a ` nodeName: "iframe",` line here?
Nit: Similar formatting comment as above.
I just kept the same `include` rule of the examples above, to be consistent.
Mind adding a description? It's not clear with the first view what this target is doing.
to what GenericBaseObjectTest ?
It would be much better if you could have a real file on disk, then make the changes to that, and assert on the result.  This is otherwise very fragile...
I decided to use IO, because File and StringIO have very common interfaces and therefore they can be used almost interchangeably for tests.
And yes, it prepares the block for the evaluation.
it "raises a ZeroDivisionError..." no?
great, this is how I expect it should look. Simple method with good name (well one exception, what udev it returns? udev devices? udev rules? udev what?) Just define is probably not needed.
right, but minimal version is 5.3.3, also phpDocumentor has it as `callback` (http://www.phpdoc.org/docs/latest/for-users/types.html)
Incorrect since and author doc tags
ok, will remove it.    Any default value here will override the logic in web_interface.rb
This is useless now, as you didn't added any file/dir there.
braces, ENTER_KEY constant, !=======
I honestly don't know, what happened here. If I open this file in my editor, everything seems ok! I did not even change anything in this line.
There is no _MSC_VER in Windows MinGW.
I don't see the word `save` anywhere else in this file. That seems odd?
Although that doesn't require that, that the URL is all that's in the string. We can talk about how to achieve that if you want.
I will see if we can have these autogenerated with paycheck?
The property value should be the name of the property in your user class. So you have a field called `githubId`, not `github_id`.
`inclusive` is also an option that is used only by evalInput, so I don't think it's too much of an issue. I think that having stickyHPos set by shared code is actually a benefit. We can then also define a different version of `|` that doesn't set the sticky bit (though that doesn't really make sense :p)

Using lastHPos that way would be breaking encapsulation. If you really want to let the individual functions set stickyHPos, maybe adding stickyHPos into the cursor object that is returned by them? Not sure if I like doing that either.
This line and 90 don't need to be blank.
This isn't in the DB, its just a field for ES so we can search on it with the search method
After changing to array in the env file, this should be:
```js
if (!user || adminUsers.indexOf(user.attributes.email) === -1) {
```

(nit note: no spaces after `!`)
Well spotted, sry!
My test ran ok with 0.12.7.  Although I think mocha 0.13 on ruby 1.9 didn't flag the original issue (just 1.8 I think), I preferred to keep the number of combinations down.
Good point. Raise as issue #66
@beneater Yeah, that's probably not the most useful option (at least, I haven't found a use for it, yet). Just letting the author know what'll happen if they don't provide a solution in that case.
Unnecessary blockquote.
How would ``mediaType`` ever be ``null``? It just got assigned to a non-null constant.
Why some methods default and others public?
Ah, sorry its hard to tell from the diff. I guess the original way assigning it to options make sense then. Sorry for the confusion.
This seems to be a regression, and not a mistake in the unit test.
I think in this step there is a slight amount of cheating. Strictly speaking, F is not defined to map to [A]^u, but you are doing so here.
hey dyud
Oh we will need to replace [the photo](http://www.flickr.com/photos/bigtallguy/131956785/), i took it from [placekitten](http://placekitten.com) so i assumed it was ok but turns out it does have [a license] (http://creativecommons.org/licenses/by/2.0/deed.en). I'll crop one of the existing images so we can be sure the license is no problem
I guess we do not, good point. Will check and fix that
It just needs the tabbing so the variable names and description are aligned.
`_.isString(principalsToAdd)` is a little more solid and in line with the UI
I assume you referred to the issue I filed here: https://github.com/spree/spree/issues/1764 correct ?
i think it can have some value. i guess the powers of this generator are around handling route-content relationship and using that to generate routes from content or to find the best locale route alternative. it is a tad more specific in terms of concepts, but still independant of any storage or application. if its really annoying here we can move it, but i think it can be useful.

about the name maybe ContentAwareGenerator would be a more descriptive name?
Yes, i agree.
But with rename column, i should first remove index on slug column and then renamed it to seo_url?
I have double checked if I can delete the "bool isCopyin" variable, but there is a possibility that "copyin" is present but "CopyinElement" is NULL, which is based on your spec.

and Since there's an extra field "nobndcheck" in "shared alloc", I have them separated.
А так же в задании сказано, что х - это процент. Поэтому и обрабатывать его нужно, как процент.
а зачем усложнять? 100 элементов задали как константу, получается кол-во элементов равно кол-ву процентов
Это так, но в вводных данных четко указано 100 элементов. Поэтому для конкретной задачи пофигу же ж)
а если он 3 раза подряд вернет число 5?
на этой позиции 3 раза произойдет мутация, а фактически для всего массива мутаций будет (countOfElement - 2)
нужно сделать доп. проверку мутировал ли уже на этой позиции геном или исключить возможность генерации позиции повторно
good stuff here, eventually this can come from csw
porque duas mensagens?
I thought it would be a handy method for consumers of the library. It would be clearer to read `$fliterCollection->hasEnabledFilters()` rather than `(boolean) count($filterCollection->getEnabledFilters()`. However, if you think it should go, I can remove it.
Could these two lines get indented?
Don't assign to local variables in the block arguments. Especially true in this case, since the variable is only used once as an argument to the partial.
Use a regular `if\n...\nend` block here.
Do we only have one `Validator` bean in our config, or is this picked up magically by its `programValidator` name?
I agree that the editor commands should be covered in those pages.  My goal is to make note that the sysadmin can define an editor to use on the command line so that s/he can more easily manage commands.  I'll add a link to those pages in my branch.
One thing to consider if we will take programmatic view definition direction is that we could actually populate view tree using Warp:

```
@ArquillianResource
UIViewRoot root;

@AfterPhase(RESTORE_VIEW)
public void populate_tree() {
    AbstractInplaceInput input = create(AbstractInplaceInput.class);
    input.setMyCoolAttribute('cool');

    viewRoot.addChild(input);
}
```

That way we won't need to duplicate efforts in abstracting test component syntax.
could this be an around_filter?
すごくないよ！
"bound" -> "submitted". In this chapter, people don't really know yet what "binding" refers to.
It's not very nice to have "xe" related stuff in a platform module. You should probably find a more generic name.
This is why there was `query['type']`, being file, folder or link.
And for this to verify that an exception is thrown.
Shouldn't this go to sympy/core/expr.py ? That's where factor() is defined.
Ok, ningún problema. Sólo tenía curiosidad.
What is this even testing?

We already have

```ruby
validates :start_date, presence: true
validates :end_date, presence: true
```

It won't save the record if it's random stuff.
There's a TypeError here if limit is None. If limit or marker can never be none in the guest code (I'd welcome the certainty) we should remove the default values.
updated: ?
Galder, you're right, there are better ways to do this, but I just wanted to make sure that the thread stops (and I did that by modifying the thread code).

The change here is only to give the thread a better name.
composer.lock should not be ignored.
I'm not sure what you don't find readable here. line 137 & 139 ?
This change means that I now get two TK widows popping up (one empty, one with a figure) with the following code:

```
import matplotlib
matplotlib.use('tkagg')
import matplotlib.pyplot as plt

plt.plot(range(10))
plt.show()
```

Presumably this is true of all other backends too. Looks like we might have to implement @astrofrog 's suggestion of making this togglable (and have pyplot toggle that toggler).
Why is this empty?

`<div class="dashboard-box-status-ok"></div>` is better ^^
Thx guys, will change it in a new commit
Remove references to the template in this method.
`(map integer xs)`
Better do this with SGString<char> than with the return output in one of the arguments. SGVector would also work
This file ideally shouldn't leave the main TT repo since it has all of our IDs and such hard-coded into it.
Lint says get_key can fail.
CheckableInterface? It's not ideal, but I'm having issues thinking of something better.
Could you add a ``@return`` annotation? Please also check line 56.
The assignment to ``$options`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
- Could you add a ``@return`` annotation?
- Is it possible to add a ``@param`` annotation for parameter ``$pathinfo`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
Unused alias
Been reading about the Amazon lately, eh?
I disagree with your crappy comment.
called after rotation
What happens if someone views the page after the version is added but before the deferred completes?
you can use $file->getExtension() != 'php'
This one is used only in the "New expense" view. when you've selected a friend that has paid the expense, then it is used.
rather than passing `**r` here, I think you should be able to just say `stream = templ.generate(self.resume)`
I try to use protected, since I've been burned over the years by people declaring behavior that I needed to modify private instead of protected.
I believe it's obvious it's the About controller. No need to mention it.
Does problem persist? Contact then GitHub.
How not working?
Please keep URL to `https://github.com/wlanslovenija/PiplMesh` here.
This [could help](http://stackoverflow.com/questions/4635734/trying-to-build-the-basic-python-extension-example-fails-windows).
When comment is added it seems, that post gets updated so on next reload post is at the top. So if we do like we do when submitting new post, that is appending it to the top, we could delete the post somehow and append it to the top and comments would reload automatically. It's just an idea though.
No. ``{{ profile.name }}`, where `name` is not a field, but method.
Dots at the end of sentences would be nice ...
т.е. я могу принимать изменение даже с этой штукой?
Don't know, likely copy and paste from Second-Stage/S09-cleanup.
Mea Culpa, thanks for spotting this.
It is necessary to see expr.delegate flag to append `*` before yield expression like,
```js
yield *v
```
Publisher.close should not be done by thread. Should be done after joining all the threads.
I think we should set up a shared SplFileInfo somewhere. I'm using this for out, and you're using it for checks. Now we're creating a new instance at least twice for the same file.
Activation order
change comment to english :)
Okay, just wanted to make sure :-)
Vad cod duplicat aici. Un singur view nu mergea ?
Gen 
@participant.route("/meeting/<int:meeting_id>/participant/<int:person_id>/update/attendance/", defaults={"what": "attend"})
@participant.route("/meeting/<int:meeting_id>/participant/<int:person_id>/update/verification/", defaults={"what": "verified"})
def update(meeting_id, person_id, what):
We're unlikely to have sub-submodules in here. Given that this relative path spec is defined within dependencyManagement section, only submodules will use this path, and it'll always be correct for them. I suggest we leave as is.
Need you to bishop me on the logic behind some of these
rather: os.path.dirname(__file__)
I meant the other way around, if (!window_id) window_id = __selected_window; and then work only with windw_id in that function. __selected_window should not be set here, the method name doesn't suggest that.
Typo in the name, _remove_ui_elemnts
Ce serait cool de supprimer ces fichiers plutôt que de les mettre ici !
Why did you move this?
It's worth checking what happens if you try to (say) `draw` an Add object that was initialized with no components.  If it's something bad, then we should check at the python layer and raise an exception rather than let C++ bomb out.

I'm not sure where the best place to do this is.  Maybe redefine _get_SBProfile for Add to check if it has any elements yet?  Or maybe it would be easier to just set SBProfile to None if there are no elements.  Then setting the flux would be an error, which is probably appropriate.  (Although I guess I don't mind the current behavior where it results in a nan that is never used for anything.)
I even think that trying to do too much / load too much functionality into the config system might, in the end, risk putting more people off than attracting those who would make full use of it.  So let's wait and see.
Removing this class brought the bullets back on the Attempt lines on my machine, and hacking the Inspect Element source to add the class back made them go away. Did you want the bullets there?
Put the CampaignHelper in helpers/campaign_helper.rb
configByKey is transient, so I don't think we want it to use toPersitedMap. We want configByKey no definitely not be null (even if empty), so that calls to getConfig() won't unnecessarily call postDeserialize() when this constructor has been called. Same for attributesByKey.

I'm not particularly happy with how I wrote this class, but I think it's good enough for now.
`IATFolder` already extends the `IATUnifiedFolder` on Plone 4 (so make it explicit is not useful).

The `IOrderable` interface... seems not used anywhere in Plone also.
Ok, that sounds strange. I'll take a look and see if I can find anything.
Ok, then it should be removed. These cases are merge mistakes I've made.
As discussed, could you use string replacement rather than concatenation here:

    '--baseurl=http://localhost:%s' % webserver.port
Could you rename it to IsPlaybackActive();
Florian, thanks for the tip. I'm always learning new things in ROS... I 
will fix this and let you know.

Michal


On 4.10.2012 11:32, Florian Weißhardt wrote:
>
> In cob_interactive_teleop/launch/interactive_teleop_safe.launch:
>
> > @@ -0,0 +1,11 @@
> > +<?xml version="1.0"?>
> > +<launch>
> > +
> > +  <rosparam ns="cob_interactive_teleop" file="$(find cob_interactive_teleop)/config/interactive_teleop.yaml" command="load" />
> > +
> > +  <node name="cob_interactive_teleop" pkg="cob_interactive_teleop" type="interactive_teleop" output="screen">
> > +    <remap from="/base_controller/command" to="/base_controller/command_safe" />
>
> to prevent many launch files for just small configuration issues, 
> there are launch file arguments (see 
> http://www.ros.org/wiki/roslaunch/XML/arg) which can be used to 
> configure included launch files from parent launch files or the console.
>
> suggestion: introduce arg "base_topic" which is by default pointing to 
> "/base_controller/command_safe" but can be overwritten by setting the 
> argument outside of the launch file.
>
> Using this approach we would on ly need one launch file for the 
> interactive teleop.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ipa320/cob_command_tools/pull/15/files#r1759741>.
>

-- 
Michal Spanel
Assistant professor
Computer Graphics and Multimedia Department
Faculty of Information Technology
Brno University of Technology
Bozetechova 2, 612 66 Brno
Czech Republic
--
E-mail: spanel@fit.vutbr.cz
Phone:  +420 54114-1294
Web:    http://www.fit.vutbr.cz/~spanel/
can we drop this method in favor of http://golang.org/pkg/net/#SplitHostPort
Breaking change. Why is this necessary?
Why don't we use `Record` here and make it `.` accessible?
Anyway, the code:

    <input ...>
    <input .../>


    <img   ...>
    <img   .../>

suggests that we do not care about HTML. And that is not true, I think.
What's the reason you are hooking these 2 methods?
Intended for the support of issue #18 ?
Though, I think that we're already doing this in places, so if we leave it for consistency, that's OK.  But someone should change this eventually.
Fucking hell, I'm hungry now.
raise, not throw. There is a difference, I promise.

throw throws a symbol or string, which can only be caught by an associated `catch` up-scope, it is not caught by rescue. `raise` will raise an exception, which must be caught by an up-scope `rescue` clause. This needs to be fixed before I can merge it.
I do not like Hungarian notation. The type of an element is just implementation details and should not really lick into stylesheets and javascript files.
Charles, I think we should just make this api to take a user_id as the argument.  I couldn't see any reason so far that we need to pass in a hash.  Also, it shouldn't be default to {}.
copy-paste из шелла. Надо вынести в отдельный класс, и использовать во всех программах.
По Code Conventions LaunchClientGui
Из-за этого не компилилось. Я поправил.
add teeth here maybe =)
We're doing it in code because it's being set based on the video that was loaded. It's different depending on the video.
This needs to be fixed.
Please check PEP 8 for imports - http://www.python.org/dev/peps/pep-0008/#imports

> Imports should be grouped in the following order:
> 
>    1. standard library imports
>    2. related third party imports
>    3. local application/library specific imports
> 
> You should put a blank line between each group of imports.
there can not be a case when test will be executed in not en-us locale?
again ``np.bincount`` I guess.
Maybe we could add that later. I just want the current functionality finished in time for the next release.
I guess I was too focused on solving it in only 1 line :-) So something like:

    unpadded_probs = np.bincount(pi, weights[i])
    probabilities[i] = np.append(unpadded_probs, np.zeros(self._classes.size - unpadded_probs.shape[0]))
This would be clearer if it was just ```If($reset)```. Please could you change the method to have a $rest argument that defaults to true instead.
Please change this to the following to the following so the 3rd party warnings are not shown (part of match PR 73):
```
#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <v8.h>
#pragma GCC diagnostic warning "-Wunused-parameter"
```
Should likely also check that the value is and integer with -?isInt32 before casting
I've run the formats on iphone as well for comparison:

iPhone formatDate
short: 6/13/12
medium: Jun 13, 2012
long: June 13, 2012

iPhone formatTime
short: 2:23 PM
medium: 2:23:40 PM
long: 2:23:40 PM EDT

You should try and match the format of the iPhone and document any differences in the apidoc.  For one the long date shouldn't include the day of the week and the medium date should only show 3 letters for the month.
Is cloud a must have, or can I _theoretically_ also list all my instances? 

If it's a **must-have**, it should go into the `__construct`.

So I think we should override the `__construct()` and add a parameter `$cloud` (as a third) and keep the `setCloud()` method to change it after the object as created.

`setCloud` should also `return $this` to allow a fluent interface.
should say 

ecl run  hello.ecl --target=hthor --server= ...
(I see the old code used to do so, but that doesn't automatically make it right)
I'm not sure this is a good long term way of suppressing the warnings.  I'm surprised the compiler doesn't already warn that this is a redundant assignment.

I think the normal approach is to comment out the parameter name. E.g.

    const SXT_CHAR* getType(int /*index*/) const
duplicated response:
I'd prefer not to print %0 in that case, as that will make it harder to spot problems. I think at least in the beginning we should be extra verbose, to catch errors earlier.

I don't want to provide dump logic to the IRExtra, since we'll probably use it for the importer as well.
This works because ``Platforms.get()`` doesn't return the JSON result from the middleware directly, but the ``hits`` dict inside of it instead.
`api = models.CurrentProducts()`
OIC. I agree that it should be on by default - if it works. I'm just not certain it does. Joanna implemented this metadata filter processing, but I think you also added the same functionality (see https://github.com/stevage/mytardis-app-atom/commit/eb7618cfdd5277ff0c48f3814d25b4fdbc51fe91 )

With the code that you added, is it still necessary to explicitly call filter_init()? I'm not familiar with how the filters work.
what will be in case if you store a 'nil' or 'false' in the hash? I assume that 'set_if_blank' will always call 'set(username, key, value)' in this case
Strange, I thought I fixed this already. (I think I may have forgot to push up my changes back to github.)
no as we do need to make sure `listener` is passed. Otherwise it will remove all listeners for the given event type.
There are three ways in the subsequent list.
This file should not be in the repo
I would rather have this file unchanged.
Ok, what does this do? siteNames is an array! I don't care if it's valid JavaScript, don't do that!
Depends on your browser support policy :
Open IE<8:
```javascript
console.log((function(somethingUndefined){ return undefined === (somethingUndefined)})()); // true: ok everything seems fine
undefined = "toto"; // let's assume someone did that by mistake ...
console.log((function(somethingUndefined){ return undefined === (somethingUndefined)})()) // false: ... WTF?
```
@ctweney nice, great way to avoid some of the duplication we had before.
Why would you comment this out?
Not certain of the logic here. Should this be an ```elif```?
calling the parent method is useless. AbstractType defines an empty method for this one, just to avoid defining it when not needed
Should you also check that sock_info and new_sock_info are not the same?
At this point model will be set for a unique account, so no need to care about other existent accounts in the store.
If Account is not valid, empty key will be set.
Why did this setting change?
Because this might be a symlink to a symlink. By looping until it's a real file, we can ensure we're in the proper directory.
Separate this into two entries, please.
Some other types can also be used as indices, so perhaps do:

```
if hasattr(n, '__index__'):
   n = n.__index__()
```
Woah, that explains it.  But then you should update the example as well, right?
Done.

Johannes Schönberger



Am 27.04.2012 um 16:19 schrieb tonysyu:

>> +
>> +plt.subplot(2, 3, 2, aspect='equal')
>> +plt.hist(image)
>> +plt.title('Histogram')
>> +plt.axvline(thresh, color='r')
>> +
>> +plt.subplot(2, 3, 3)
>> +plt.imshow(otsu_binary, cmap=plt.cm.gray)
>> +plt.title('Thresholded with Otsu')
>> +plt.axis('off')
>> +
>> +
>> +#: Adaptive thresholding
>> +plt.subplot(2, 3, 4)
>> +plt.imshow(threshold_adaptive(image, 11, method='gaussian', offset=5),
>> +    cmap=plt.cm.gray)
> 
> Yes, I intend to submit a rewrite of the example as a new PR after this is merged. On that note, would you mind adding plot_otsu.py back? (I think they deserve separate examples). If you're in the parent directory of `skimage`, you can run:
> 
>    git checkout abca94e16fb018033f9e2343d16e463c6cc5311e doc/examples/plot_otsu.py
> 
> This uses the hash for the commit just before your PR. 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/scikits-image/scikits-image/pull/178/files#r744561
Yes, it is much faster than the python equivalent.
Indentation and np.float64.
provided a valid flavorRef not flavor_id
In our original branch, we were using dojo.io. This is an attempt to replicate what dojo.io was doing.
Okay, I guess you're right, the it's all so fast it probably doesn't matter as long as the references comparisons are first (which you already have).
As always, you know way more about this stuff then me.  @bagnell Can you please add a comment with Kevin's explanation to the code.
Fail early takes priority.  Log statement moved below var declaration.
lol...purpose was to give spacing for the redirect icon, but Jessie pointed out there was no need for it. I've reverted the padding back to what it was and made the icon dimensions and sprite image more consistent.
This would be a lot more readable if I used something like: 

``python
from collections import namedtuple

FormFieldTuple = namedtuple('FormFieldTuple', 'widget document_field field_type key')

return_dict[field_key] = FormFieldTuple(widget=widget, document_field=field_dict.get('_document_field', None),
                                                                        field_dict.get('_field_type', None), field_dict.get('_key', None))
```
The `IO.copy_stream` approach is a bit more efficient than reading everything into memory.
Using open with a block makes sure we close.

    File.open(filepath, 'wb') do |fout|
      open(@params['image_url']) do |fin|
        IO.copy_stream(fin, fout)
      end
    end
> I think this is the problem, @daniel-pittman...it's resetting the
> ISO_VERSION to $1 for every call, not just the calls where the version
> number was not included when this script was run...

Ah!  I missed that in the rebase, and so it snuck back in compared to
master.  I apparently overlooked it when I reviewed the diff, too.

...and, yes, the new busybox invocation is awfully verbose.  Sorry.
this said `var cql = cql …`?
A few more line breaks between the lines in each of the following tests would be good, but not super important.
Yeah, I was wondering what was meant here, and used this fix to be coherent with the title 3 lines before that.
Thought about that too, but settled on using `-Pprod,draft`, that is: prod-mode (GWT compile), but _draft_.

I don't like having to duplicate those dependencies.
ок, можно убрать как-нибудь
I know they're just example pages, but the `type` attribute isn't required.
Kill tortoise don't give points ?
Done for loopvar. Unfortunately [items] can't be final, it is initialized lazily between the 'create' phase and the 'insert' phase.
I still got problems with that test. It runs if I build the entire project, but if fails if I execute only this one test. Could you try this and see whether that works for you:

    mvn clean test -f engine/pom.xml -s settings-example.xml -Dtest=ValidationExtensionTest
rename to `make_R_install_option` ?
Voila, j'espère que ca ira :)


2012/11/6 Raldo Chea <me@rchea.com>

> Bon je corrige le constructeur et c'est fini :)
>
>
>
> 2012/11/6 Frédéric Hardy <notifications@github.com>
>
>> In fr/Contents/chapter4.md:
>>
>> > +        )
>> > +    );
>> > +
>> > +    $loader->register();
>> > +
>> > +    use mageekguy\atoum;
>> > +
>> > +    // A commenter si vous utilisez composer
>> > +    require_once __DIR__ . '/../../../../../vendor/mageekguy.atoum.phar';
>> > +
>> > +    abstract class Test extends atoum\test
>> > +    {
>> > +        public function __construct(adapter $adapter = null, annotations\extractor $annotationExtractor = null,        asserter\generator $asserterGenerator = null, test\assertion\manager $assertionManager = null, \closure        $reflectionClassFactory = null)
>> > +        {
>> > +            $this->setTestNamespace('Tests\Units');
>> > +            parent::__construct($factory);
>>
>> Attention, il n'y a plus de factory dans atoum, donc il faudrait mettre
>> à jour le code s'y rapportant dans la documentation.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/marmotz/atoum-s-documentation/pull/10/files#r2039614>.
>>
>>
>
>
Have you tried timing on a phone?
please do not comment code! simply delete it! btw, I'm not quite sure why this part is a problem?
Yes I just checked. Chrome downloads the file nicely and lets you open
it as we expect.
cf comment above + RFE for a future PR. Maybe we want to support a `--user` or `--token` option in the Command parser that calls get_token() or get_user() or get_token_or_user()?
Why was this renamed? Use a separate event for font changes, rather than removing an existing one.
If a route does not have any requirement, it should allow all methods. Currently, it will return no method.
``getParent`` does not have any argument now IIRC
Other options, if you hate _variablename, are `var previousX` or something like `var previousTwist = { x: x, y: y, z: z }; if (previousTwist.x != x) { ... }`.
more stolen code here.  fixed.
N32 runs on 64 bit hardware and thus has the same registers as N64.
It's quite a [mess](http://www.linux-mips.org/wiki/WhatsWrongWithO32N32N64) but I tried to stick to [glibc](http://sourceware.org/git/?p=glibc.git;a=blob;f=ports/sysdeps/mips/bits/setjmp.h;h=df6fd7b2d72bfd2724077670cb0cb0bfe9e63470;hb=HEAD).
Spelling (dependant).
~~MessageHandlingException~~ MessagingException. This one is recently changed in last PR.
Just making a comment here - for the record - as a non-groovy type, I find this obvious...


    compile("commons-httpclient:commons-httpclient:3.1") {
        optional = true
        exclude group: 'junit', module: 'junit'
    }

whereas


    compile("commons-httpclient:commons-httpclient:3.1") { dep ->
            optional dep
            exclude group: 'junit', module: 'junit'
    }

looks Martian to me.
Add

throw new MessagingException("Interrupted while awaiting Delayer initialization", e)
I think the Region constructor is better.  I'm on the fence about the region name. Declaring a region is pretty simple but there are some configuration options that the user must understand. But if one is using a GMS, some familiarity with GF is expected.
This looks great, you must be an incredible programmer.
(In this case `event` argument.)
please split this line
Can we change this to "insert_indices" or something similar as it shoould only be called when a node as added
This is so the anchor tag gets through. If we ever allow user-created trees however I can see this being a huge problem.
I didn't even know this was a word haha, what's the reasoning behind this part? JSON values remain as bools etc
`which involve certain data domain` -> `which involve a certain data domain`
Even better:  `AspectJConfig`, after all it's exactly what it is
Definitely not a no-no. As discussed, this page could use a general reworking (4.5?).
Cool I'll change that up.
Not super keen on if else assignment from a readability standpoint, but will only fight about it a little.
Is it will be possible to add more sub-projects path to .gitmodules? How we will handle it? Or we should init submodules per sub-project dir?
Why the `Pass...` naming convention?  All tests should pass, right?
Maybe pull out the handling methods (fixHtml) into a static utility and test those for expected behavior.
Looks great, thanks! I tested it and it works fine.
**sûrement**. trop tôt **pour** juger. ...de leurs salaires, des locaux, etc. (parce que là, ça fait un peu: tous les salariés non développeurs sont des sangsues qui ne servent à rien.
will use  "return callBack(..)" syntax instead
Think the line is fine. Will update and add to PR.
awesome, I did not know this module existed.
This is not how this tag is usually used. Take a look at database to see an example
I'd vote to rename this option to 'prefix':

While end user usability is usually the better choice, this is a developer/researcher oriented toolkit and I think people should know and respectively made aware of that there is no such thing as a folder in (most) nowadays cloud storage architectures, rather (usually) just a flat bucket plus key name design, where the concept of 'prefix' provides a useful shortcut for folder alike hierarchy handling regardless. Diverting from the S3 API method/parameter names might likewise be confusing.

I've seen too many S3 users stumble over this already and think (but can't prove), that making them wonder about the option right away (alongside a useful help message) might be the better guidance in this regard?