labofsahil/github-event-dataset-2012 huggingface dataset:
This will be a nice change to have.  FYI, port 8000 is much more common.  Play 1 uses 8000 and Eclipse has a default of 8000.  Some people might not think to change the value from 8000 in Eclipse, which is more commonly used, and may have trouble.
http://jsperf.com/for-cycles
эксперименты с оптимизациями.
Differences from the distribution?  I retrieved it from here:
https://github.com/documentcloud/underscore/zipball/1.2.3

They match for me:

MD5 (cdnjs/ajax/libs/underscore.js/1.2.3/underscore-min.js) = eb40cdf14de93e997357c9c30017b2e6
MD5 (documentcloud-underscore-813bb57/underscore-min.js) = eb40cdf14de93e997357c9c30017b2e6
Please read my research paper (shared as a Google Doc) to get the answer to this q.
Derp, I was testing out methods  and I forgot to remove this! Any way its safe to say its Gone :)
Is this the correct typedef? Previously I had typedef'd it as a reference, but the compiler would complain about "uninitialized member reference" in the HunspellSpellChecker class def.
Some of the functional tests expected the old compatibility checks which were removed. I don't think they were necessarily what the tests tested for, but they were part of the general criteria to pass.
True, but I'd rather eliminate all Clang's static analyzer reported leaks/issues if it is possible to help developers focus on the issues pertaining only to the code they write on their own. I think the patch should be applied because of this.
Turns out IE6 leaves a 1px faint trace of the text because `color:transparent` isn't supported by IE6/7/8 (but IE7/8 hide the text properly anyway). So if you to 100% remove any trace of text in IE6, you might have to throw an IE6 hack in there.
fuzzy の付与は査読開始時に「メンテナが全体に適用」します．
Do you have a reason to put them only for MongoDB?
I'd rather move them in Core and use OgmTestCase or the existing test harness rather than `Utils.getEM()` which leaks non closed `EntityManagerFactory` instances like there is no tomorrow :)
Playable parce que CollisionEntity est la "première" à posséder une vitesse.
SoundEmitter, j'aimerais la faire hériter de Entity seulement (pour la position), mais l'héritage sur guyTest devient compliqué, j'ai préféré pas m'embêter alors que je pense qu'on va repenser cette partie ^^
A map editor has a User Interface. A mouse image is a user interface. A button is a user interface. But yes I wouldn't export that. But our game will need a user interface of its own. I want my exported file to be usable by the game engine. All that my map editor will do is export the maps. Yes a bird needs to be stored on the map editor. The bird will have a starting position. The character will have a starting position. I want to be able to place them on the right plane. If we use zOrdering This will be simple shit. Look at the fucking code its like 4 lines.
There isn't event=423 in wowhead, shouldn't it be holiday=335? http://old.wowhead.com/event=335
Thanks for the additions. I'd like to check this in, but there are some commits on the original branch since then. Can you pull the latest HEAD from master into your fork and then re-submit the pull request? I think that'll help merge things properly.
Yes you can remove the condition - swap a virtual call for cleaner code.
Yeah, I tried pylibmc, and hit the problems you're talking about. One of the goals is low drama installs, so I went with python_memcached for now. 

Again, I may revisit that decision once I run some performance tests to see if it's a critical hit. (For what I've heard, demand will not be very high for the service so python_memcached may be more than fast enough for quite some time.
The first line can be.  There are tests where there is more than one tree though so the others are not common to all tests.
Having to catch exceptions all the time when we add/remove items to the list box control seems to be a lot of overhead. The ListBoxControl could have an ErrorHandler field (set by a constructor arg) and handle errors internally.
yeah but texturepack support will break this: the images are not dynamic :S
aaah a challange, gonne be a late night... again.
Hi @goblindegook ! Thanks so much for the pull request.
I hope you don't mind, but I don't think I'll take this pull request though. I made the change to the library recently to move the QuickDialogController from a UITableViewController to a UIViewController exactly so that what you're trying to do can be done, but in my view, it's best to leave those changes to the custom code in everybody's application.

People will need to move the quickDialogTableView around in many different ways in their apps, so I would rather make it simpler for people to just do whatever they want to do.

In your case, if you subclass the QuickDialogController, you can move that loadView method to the new class; you'll only need to remove the initialization of the self.quickDialogTableView property, because it'll be initialized already.

Again, thanks so much, I really appreciate it!
Beautify is such an understatement for how great this is.
@SuppressWarnings("unchecked")
	Map<String, Object> adapterItem = (Map<String, Object>) listAdapter
		.getItem(adapterPosition);
Nice use of hover here :)
E [agora](https://github.com/hugomaiavieira/monografia/commit/05574f362e2db7ced102d8f3ca6be3062631bf5a) @rodrigomanhaes?
202E is classified as QChar::Other_Format so it needs to be checked.

I improved the efficiency as well using a different method.
I'll do pull requests next time! Thanks a lot for the patience! Next time it will be more straightforward. Best regards.
Filed as https://bugs.nemomobile.org/show_bug.cgi?id=151 - thanks
bonne idée le free !
pas pensé à ca

ya 2 - 3 truc à mettre au point demain
I'd recommend to `git tag` the last commit before a release with the release version number. This allows finding out the exact source code matching the "binary" release, which is nice for debugging and knowing in detail which change is contained in which release.
This is just a suggestion; it's a best practice for our Jangaroo IDEA plugin.
Oui enfin il en manque quelques uns (par dizaine je dirais..) des tests !!!
because you are not using qSlicerMultiVolumeExplorerModuleWidget, you should probably delete the widget qSlicerMultiVolumeExplorerModuleWidget.h/cxx files (and .ui file).
hmmm Hvaða Ævar?
It is a count call to the database. Size is the same as Count but it respects skip and limit. It's just a nasty naming convention inherited from the mongo shell (nasty in the sense that Size and Count sound like synonyms so it is unfortunate that they do slightly different things). I should have just made Count in the C# driver work like size in the mongo shell and not bothered to implement the shell's version of count... :(
is there a reason this version isn't in the npm repo? 2.1.8 (current at the time) doesn't have this fix.
it's only a matter of time milaq.  i'd rather the capability be there ready for when things happen rather than have a FAKE "720."  encoding is something i have on my agenda.
I put require 'will_paginate/collection' into lib/will_paginate_mongoid.rb. I hope that can solve the problem.
Can you test de version 1.0.4. This version includes this changes.

Thank you again
I would probably use FILTER_UNSAFE_RAW because we don't want to strip anything from a users' password.
alright. pushed two more commits.
with a proper account (that we can get if we have a professor who says we're working on a legitimate project) we apparently get a full-fledged Apache/MySQL/PHP environment.
Oops! my fault. thanks for verifying! It should just be "JsMinifier"
@emilda: Please have a look at https://github.com/jburel/Monash-Micro-Imaging-Portal/commit/bfa10858c64bc9fcb42560cfa6ecda5724d56994
I have branched developed and implemented few classes to show how to do it.
You should follow the same approach (class similar to `DataCollectionLoader`) to load the tags instead of using a static method from `PublishAgent`

2 jars are still missing from the class path
 * axiom-api
 * axis-kernel
NO ES PARA HACER AHORA: la configuración candidate_1/candidate_2/category podria ser un valor configurable en el settings.py de manera que podamos cambiarlo con mayor facilidad.
yep...


On Monday, January 9, 2012 at 1:04 PM, Luis Felipe Álvarez Burgos wrote:

> demás la idea era que le sacaran provecho a la misma
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/ciudadanointeligente/candidator.org/commit/6962982de1462dc2a3b0ed3663f8c6db9406e0c0#commitcomment-849930
>  
>
I think we'll need some type of a bitmap for tile 'options'. Then we could do something like:
tile.setOptions(TILE_IS_PASSABLE | TILE_IS_TRANSPARENT);
I do think they mean county.
actually there should be both.
bleibt der Bildschirm für immer aus ?

ich musste mindestens 5-Mal jetzt mit dem neuen Kernel auf die Home-Taste drücken, damit er wieder aufgewacht ist :P

das schien aber nur beim ersten Mal so zu sein,

ich lasse das Handy jetzt so vor sich hinträumen und versuche es später wieder aufzuwecken - ob wohl das gleiche passieren wird ? hm :/
Also, could you please move this up so it's in alphabetical order with the other `require` statements?
Ok, I didn't know what was the standard way.
We _could_ allow themes, but if it's just a matter of styling and decorations, I think simply modifying the css and js files for the mgmt webapp's overlay would suffice. Since the app  would seem to be just internal to the deployer's environment and not to the actual users, I dont suppose allowing theme options would be that beneficial.
Not sure if we need this
the reason for the `_` here is the name conflict with `def latestStats`
Since htis is essentially the only place where behaviorStackPlaceHolder is used, how was it deemed safe to remove it?
I think this could benefit from being an FSM Actor or just use become.
Order of notifications and other code in these cases seem inconsistent
This should be checked at initialization of ZeroMQExtension, not every poll. Use ZeroMQExtension(...).version to check against.

Thanks
ok, great that you created the ticket
ok, makes sense

        val values = seen.values
        val seenHead = values.head
        values.forall(_ == seenHead)
Should this switch to use the same approach for "ClusterEnvironment" as https://github.com/akka/akka/pull/675/files ?
Well, technically this only tests that the actor receives the messages in the same order in which it sends them. Inte så spännande.
you're sending the Actor instance to another Actor and not the ref, big no-no
In application.rb now along with special handling for test environments
List of functions. These are eventually composed into a single function. Is there a better way?
The deconvolution method is nearly done. I think it will be easier to add this when we put that in.
`.. [1]` and `.. [2]`
Yes, a numpy array file. At least I use it some times to store bvals and bvecs (see data.get_data)
I don't know of a use-case where the elements of arr could have a shape but not a dtype. However, at least for now, the do-string says that when arr has entries that are not ndarrays and not scalars we return arr. If a has a shape but not dtype it is not an ndarray (and not a scalar) so I feel we should return arr instead of raising an attribute error. That being said this is all pie in the sky, I'm not sure this function will ever run into something with a shape and no dtype.
By default, OdfFit already implements `directions`--so why is it re-implemented?
oops, I'll indent it to the left... saw it only after the pull request...
What is an "unbinding"? Conceptually there's a binding to a repo's distributor, but there is no such thing as an unbinding.
That's kinda wonky, doesn't help me find if something is imported or not. I'd still have to check two places.

I don't see that in PEP-8, but I also don't see anything about them having to be alphabetical, so I withdraw this blocker.
It isn't, and it is going with the next set of updates
That's done in the database anyway (there are two commits for it, one for videodb and one for musicdb) because otherwise the filtering in the filter dialog wouldn't work properly either. But I can added, doesn't really make any difference.
I would avoid using the word "logs", maybe "logged_hours?"
Annotation Processing Tool processor I suppose
okay, here, this is true. nothing wrong with saving \Draft or \Recent in the db. but below, in combineFlags(), trying to set \Recent will give unpredictable results (and should fail), as that flag should only be changeable by the server, so it should be explicitly excluded. \Recent is a pretty useless flag even on a compliant server (which is rare) unless you never have more than one client connected.

dovecot results (returns error):
. store 6 flags (\Seen \Recent)
. BAD Invalid system flag \RECENT

gmail results (clears all flags):
. fetch 1 flags
* 1 FETCH (FLAGS (new \Flagged \Seen alpine))
. OK Success
. store 1 flags (\Recent)
* 1 FETCH (FLAGS (\Recent))
. OK Success
. fetch 1 flags
* 1 FETCH (FLAGS ())
. OK Success
You need to add a get/set pair to editor.js
the curly brace should be on its own line. Btw, [PHP-CS-Fixer](http://cs.sensiolabs.org/) can do it for you
Not needed anymore, since it's Xdg spec and Gnome-Shell uses it, I'll take it out
no prob.
Wrap the two lines in `{}` or combine them into one line and move the else in front of it.
The ClassReader keeps reading from the inputstream passed in - while not exposing the underlying stream (for us to 'get' it and close the stream).
So everywhere it is used, we will need to pass along the inputstream - so that it can be closed in case use of the classreader is over or it fails (via exceptions, etc).

That being said - since this was a bug observed by a scientist here as part of using yarn port, I was more trying to get a quick fix in : and probably there might be better ways to resolve this !
Je, tenhle comment mi utekl. V driveru by to bylo lepší.
Oh, OK, I'll remove it.

So 4.0 is on a separate branch now? I'd like to get this in for Rails 4, since it's a bug fix. Should I backport it and make a separate pull request for that as well?
Umm, It is not work fine. the above testcase is a failure. I'm thinking it more.
remove line 105
the confusion is all mine, sir
The fact that the `Runnable` is ignored should be commented on.
Not all `term` trees are TermTrees
needs a comment like: With this empty line, I fight injustice.
Suggestions for a better comment here? Should I move this down closer to `TypeBounds`?
Also add a comment here?  ``# L1-norm
According to PEP8, imports from the stdlib should be at the top, before any imports from sympy. Also there should be at least one newline between the imports and the functions.
It originated from our code coverage checker, which cannot distinguish these two statements. So if the conditional is always false, it will show up as covered even though the yield is never run. Probably if the coverage checker were improved in this regard then little cases like this would be acceptable.
The same here.  Why not a @property?
Single backtick quoting is for math, double backticks for code, so rather:
```
``coord_sys.coord_function(index, name)``
```
and so on for the other instances.
`K.commutative` gives
```
 {Diagram({IdentityMorphism(Object("A"), ""): EmptySet(), IdentityMorphism(Object("B"), ""): EmptySet(), IdentityMorphism(Object("C"), ""): EmptySet(), Morphism(Object("A"), Object("B"), "f"): EmptySet(), Morphism(Object("B"), Object("C"), "g") * Morphism(Object("A"), Object("B"), "f"): EmptySet(), Morphism(Object("B"), Object("C"), "g"): EmptySet()}, {}, {Object("B"), Object("C"), Object("A")})}
```
Should I still go for it?
This does not seem necessary? [presumably you meant to check inverse transforms and realised they did not work ^^]
if the expr is <code>I/**(I+3)</code> to get 3 from the expr <code>.as_coeff_Add</code> has been used
`$this->$name=$value` would do it, no need for {}
Should spiral be hardcoded to minute?
Ich glaube es wäre sinnvoll, wenn man nur seinen eigenes Profil editieren kann.
Daher würde ich den $user nicht als Argument entgegen nehmen, sondern den user im Context verwenden (also der eingeloggte User)
Instead of a paragraph, this should be a section called "Returns" that is formatted just like the "Parameters" section, assuming you want to leave this a public function (for private functions we've generally been more lax as long as the docstring is human-readable, because sphinx doesn't need to parse it).
Should be `http://localhost:8080/index.php` as there is no url rewriting in the built-in server.
same as with cut, mkdir needs shortened argument to be compatible with both
That first example is not a representation of what you described earlier, you're calling `QUnit.begin` itself again inside of `QUnit.begin`. That is effectively the same as calling `setTimeout` within `QUnit.begin`, but without relying on undocumented behaviour.

Modified versions:
* http://jsbin.com/apodor/4
* http://jsbin.com/apodor/5

Yeah, go ahead :)
Shading GridFS
No. This function is about whether a rendering is currently in progress, which is valid whether or not the document should be rendered in the offline queue.
You should add "_profile_cache" to the parameter list, so one can easily regenerate the strings from before the placeholders are replaced with actual data
I believe not, fixing.
We should have an exception for 404s (See http://php.net/manual/en/language.exceptions.php about exceptions). I think controllers add this. cc / @imkingdavid
Although I see it was there before, then perhaps nevermind.
наистина нямаше нужда от допълнителни инструкции за формата :)
Махнах ги навсякъде, където беше възможно.
I think, yes. This line change breaks Android build so we can't accept your request as is.
'\' not needed.
So I was mistaken, gh-801 does indeed fix the bug, as there was no problem in the general case, only for min/max.
Yes, depends effectively creates a global cache on variables. This isn't ideal. 

I've added a commit to create new depends functions on the fly. This should create separate caches that are removed by the garbage collector when the dependence cmp function is no longer necessary. Code-wise this is less clean but should avoid a global memoization cache.
You will rather need nested_commit_on_success.
Never leave commented-out code, merge it properly.
Funny :-D
A note to PR #433: merging with this commit may create a conflict that tries to resurrect the call to `riak_kv_mapred_cache`.
Tis SVN artifact should be removed
Just out of curiosity: why is this change needed?
If you want to be explicit about the future contents of `mdl`, why not include "id" and "format" in the `dict` creation?
Why are these tests skipped? They're new tests, right?
Nice ;-)!
This has to change to number the windows, right? Like wndUntitled, wndUntitled2, etc... for identically named windows? (With corresponding change in _getwindowhandle)
https://github.com/fschopp/madlib/tree/design_integrate/doc/design
Just for future reference, what is the appropriate way to test things?  There wasn't much on the wiki about it.  Are there any brews with good examples I should look at?
Sorry for the comments... I already read the formula cookbook - but
obviously not thoroughly enough and by the way it's my first recipe.
I removed the comments and fixed the test method.
When I know what your answer is regarding the ncursesw dependency I will
push the changes and create a new pull request. Right?

Govinda


2012/3/24 Jack Nagel <
reply@reply.github.com
>

> > @@ -0,0 +1,28 @@
> > +require 'formula'
> > +
> > +# Documentation: https://github.com/mxcl/homebrew/wiki/Formula-Cookbook
> > +# PLEASE REMOVE ALL GENERATED COMMENTS BEFORE SUBMITTING YOUR PULL
> REQUEST!
>
> Please read this.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/11173/files#r600311
>



-- 

Govinda Fichtner | Senior Rails Developer

g.fichtner@palabea.com
www.palabea.com

Office: +49 30 232.553.79 - 15 Fax: +49 30 232.553.79 - 11
Mobile: +49 160 90 59 42 65

palabea e-Services GmbH | Torstrasse 164 | 10115 Berlin | Germany
------------------------------

Geschftsfhrer: Matthias Spanic, Fabian Hbner, Regine Haschka-Helmer |
Sitz: Berlin | HRB 106786 B | Amtsgericht: Berlin-Charlottenburg
------------------------------
IMPORTANT NOTICES: Confidential Information. The information contained in
or attached to this e-mail maybe confidential information subject to
protection by law or terms of applicable confidentiality agreements, and is
intended only for the use of the individual or entity named above. If the
reader of this message is not the intended recipient, or the employee or
agent responsible to deliver it to the intended recipient, you are hereby
notified that any dissemination, distribution, or copying of this
communication is strictly prohibited. If you are not the addressee
indicated in this message (or responsible for delivery of the message to
such person), you should destroy this message and notify the sender by
reply email.
We put the path-to-source all over the place, first, last, and it hasn't seemed to matter anywhere.
These 2 changes will break things if the values have special characters in them
In [2]: rng
Out[2]: 
<class 'pandas.tseries.index.DatetimeIndex'>
[2010-02-13 00:00:00, ..., 2010-05-06 00:00:00]
Length: 83, Freq: D, Timezone: US/Eastern
Further:

```
In [3]: rng[0]
Out[3]: Timestamp(2010, 2, 13, 0, 0, tzinfo=<DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>)

In [4]: rng[-1]
Out[4]: Timestamp(2010, 5, 6, 0, 0, tzinfo=<DstTzInfo 'US/Eastern' EDT-1 day, 20:00:00 DST>)

In [5]: rng[0].tz == rng[-1].tz
Out[5]: False
```
actually no. I explicitly want to create a new require function because it gets a clean version of require.cache :P
Yeah; I think I'll switch `wp generate posts` over in the future.
The lp_ prefix was part of the linepress prefix when we first started with this idea. We could just rename it so something that is more related to the post type itself?
Fixed. Thanks for catching that! When your pull request is in, we'll also need to add transformations for all these preferences, but these may well be in @kaspermarkus's upcoming pull request.
Ack, tab-based indentation and unsafe `if`s! Will fix it...
maybe a `res.send(..., 400)` here
I feel like those warnings should be taken out anyway
I think this should probably be two tests, one to check that its called and one to check that disabling works.
Shouldn't this return `false` (since the doc is dirty, we should get the current document in memory instead of hitting the cache)?
Yeah, because right now I'm hiding everything when we move (triangle, shadows). But forgot to remove this. Fixing it in the next pull .
Missing closing brace after this line.
We should also probably explain more how the block below accomplishes this.  If I'm reading it right, we determine whether the color value is valid by checking whether tinycolor.toString() matches the original input string or not.  But we need to normalize the color string first into the format tinycolor prefers -- otherwise strings that are valid but not in its preferred form would differ and thus be treated as invalid.
1. Oops, I intended to add that; added it now
2. Bad line/cols is #1988
3. `this.getPos()` doesn't work in cases where it spans over multiple lines :( And I didn't think this position object was very interesting so I put it on one line...
Why have you moved these exception clauses into main()?
looks like final is necessary as they are referenced by the anonymous inner class
if this map can be accessed by multiple threads, consider using ConcurrentMap.
-> Erwan Bocher
Please fix both, use only `tmp_*`. It is OK to use `elif`, forget about my previous comment.
If we don't know the gender, we have to use "they". Proper English :p
I'm going to stop commenting these, filed a ticket for future fixes:
https://webmademovies.lighthouseapp.com/projects/65733-popcorn-maker/tickets/1777-remove-rgb-box-shadow-and-border-radius-prefixes-from-less
Double slash.
Nit: capitalization.
I've taken out to an already existing configuration file call amazon_s3.yml. It's loaded at boot time using ```initializers/load_config.rb```, this the refactor method:

    def medistrano_pir_bucket_name
        AppConfig["amazon_s3"]["medistrano_pir_bucket_name"]
    end
```salt-run``` is a command. Commands should be verbatim in the documentation to what the user should run, not upper cased. This confuses people.
Lock is not unlocked if  "started && !indexerIsDead" evaluates to false.
Add javadoc to the class explaining what it is doing
Subscriptions are only indexed when they are viewed in their entirety (no search filter) in the UI. Katello cannot know the latest state of subs since that is katello's job (ie. katello does not know when to trigger update of re-indexing individual subs).

The API does not make use elasticsearch at the moment.
i dont think this makes sense ..
right now KnpMenu seems to really expect the entire menu to always be loaded, which is not very good in general but a serious issue when the menu gets larger and/or is read from an external data source.
Not sure, about that but let's not discuss that level of detail. We mostly care about the contract. What does the implementor expect?
grrr! I was looking for that last time without beeing able to find it! Thanks :)
Why should IPv6 be disabled by default for Bitcoin-Qt? :/
To Cake core knows what is the application namespace.
Why not just use `is_callable()` here.
No references to Cookie should be placed in this class. It is fine to add to the Cookie component, though
can you guarantee this for all cache drivers? or is false == the better condition here? Since its definately not 1 its a sufficient check.
What happens if we're on the discussions/new or the groups/edit page? We'll wanna make sure that these helper messages only display on the appropriate controller actions. As in, only when controller_name == 'groups' and action_name == 'show'. I think this could be done with `case "#{controller_name} #{action_name}"`. Then testing `when 'groups show'`.
This and `completedSuccessfully` should probably be booleans
I'll clean this up with a for loop
sure but Python`s "." is more expensive than in Java. Why should we do extra comparison, when we don't need? :)
But I think I'd rather just have this wrapped inside of `get_git_command_path` (which maybe could be called `git_path`?)
We should probably rename branch to ref too, since that's what it really is
```ruby
# irb
1.9.3-p125 :001 > show = { 'encrypted' => 'true' }
 => {"encrypted"=>"true"} 
1.9.3-p125 :003 > show['encrypted'] == 'true'
 => true 
1.9.3-p125 :004 > show['encrypted'] = 'other'
 => "other" 
1.9.3-p125 :005 > show['encrypted'] == 'true'
 => false 
1.9.3-p125 :006 > 
```
Is this left over from debugging?
listNodes code shouldn't be pasted twice.

have listNodes() call this, which Predicates.alwaysTrue()
I'm no fan of the nested loops either. I'll see what I can come up with.
It's actually in there, I just wasn't aware of it. Fixed!
This is cool. I probably saw this a few times before but now I finally realized how cool it was :-)
This will show up in the admin interface, which isn't localized in other places. As far as the unused gettext import, it looks like this file used to try to be localized, but it was removed as a part of [bug 649733](https://bugzilla.mozilla.org/show_bug.cgi?id=649733).
There is an extra `>` at the end here.
`eq_` with `True` or `False` as the second parameter is pointless. Just write something like

    assert user.is_verified(), 'Expected user to be verified'
whoa, frame hacks! OK, can you add a comment saying that they are introspected? Otherwise, the next time someone runs pyflakes it will say that these are undefined and someone will delete them.
You're duplicating this source, you should create a separate module for this class and then reuse it on the client subclasses.
At [line#44](https://github.com/pyrocms/pyrocms/pull/2042/files#L1R44)
Those ones will likely be returned inside the application server (and thus could have responses) whereas all the other 500+ error codes probably occurred at a higher level (e.g., web server).
Symfony does not put the docblock for private properties
This method looks weird. This class is also used by the in_memory user provider, and in such case, ``getPassword`` would be the hashed password
Don't you mean `form` instead? Idem below in other types.
You should close the file here and probably set some error message.
`total_weight != 0` should be enough with a real division. In an HDR image 1e-6 could still make a difference.
These long lines are a bit unpleasant when reading the file in plain text: would you mind justifying paragraphs as above?
good catch; thanks.
"Search the whole gallery" - leave off the period since its an action.
i aded a lot more explaination about the user's private vs public pages
the export modal is a modal, it shouldnt  change the other views behind it (like hide everyting)
an awesome new button, this makes it possibel to remove items from data lists, yippee!
Oops. Yeah, that's no good.
Why do these need a serate execution? JSFUnit?
I also ran into this  lot so there is a new "context" parameter so you can do

```js
this.task(function() { 
  // this refers to the app now
}, cb, this)

```
Should we do this into a single localizable string?

Wondering if in other countries some day they will like to use other separator, or alter the order of the information that we display.
Hum... I don't see how this would work... you probably need to do all the highlighting *in* the the callback from `getItem`.

We don't have the value of `latestCallLogVisit` right away (hint the asyncness) so we need to wait.
The only place where we're sure to have the value is in the `storage_getItem` function.

And also `storage_getItem` should be named `storageGetItem` ;)
Sorry, should be `window.opener`
thanks, definitely we need this.
Sexy!

But the initial state wasn't working for me, the button was enabled when I was clearly offline.
Toggling the connection on and off after that worked. Any idea?
Kind of repetitive the "ellipsisSide" name taking in consideration the name of the function... :-p
Great job! Only change this comment to English and It's done! Once we have our new UI Pull accepted we are going to add this functionality
@davidflanagan I think I realized why you had encountered a conflict.
In your branch, if MediaDB.UNMOUNTED, then <code>showOverlay('pluggedin')</code>,
but in my branch, if MediaDB.UNMOUNTED, then <code>showOverlay('cardinuse')</code>.
Also the files of localized strings in locales/ are different.
'this' really?
Yeah! Nice catch ;-) I have just included an update to declare the var at the beginning of the function so it can be assigned inside and outside the loop.
On 01/06/2012 04:22, Timothy Guan-tin Chien wrote:
>> +    else
>> +      this.turnScreenOn();
>> +  },
>> +
>> +  turnScreenOff: function scm_turnScreenOff() {
>> +    this._syncScreenEnabledValue();
>> +    if (!this.screenEnabled)
>> +      return false;
>> +
>> +    this.preferredBrightness = navigator.mozPower.screenBrightness;
>> +    navigator.mozPower.screenBrightness = 0.0;
>> +
>> +    this.screenEnabled = false;
>> +    setTimeout(function realScreenOff() {
>> +      navigator.mozPower.screenEnabled = false;
>> +    }, 20);
> Because 20ms is not visible by human eye -- anymore than that would.

My question is: why do we need to add a setTimeout here?
space between switch and (
arguments() it is, then. I'll file the bug about making the paths work properly with applauncher.
If I understand correctly, the "else" state should not be used.
Then, perhaps I can add a warn or a info in the log file to catch other missing/mispelling callback/states (each time the else is reached), too?
是的，这个pr无效。
Yeah, exactly. I'm not saying don't do it, I'm saying it's a PITA. :-)
Should be something like `invalidCallbackDataProvider` perhaps?
Yes, the single pipe is a bitwise or.
有道理。
Never thought to use .data().  Good idea!
Log this, instead of printing it.
Please change to use the `var Name = function Name ...` pattern.
`!ArchiveLink.createSubEntry` is always false
For a string like this you may want to consider passing in the formatting based on a dictionary: http://docs.python.org/release/2.5.2/lib/typesseq-strings.html
Careful, if you return `options`, then this function constructor won't work as expected!  Although maybe something like this is more useful:

```javascript
this.options = options || {};
```
Any reason why we dropped the `MSG_NOSIGNAL`?
The issue isn't that they are printing out random things early, it is they are getting output before proper logging is setup, so they get lost.
I like this, treating POST and GET the same way.
Documentation is always good. But an `AttributeError` is going to be an easier error to diagnos, than "`TypeError`: `NoneType` object is not callable"
nit: were
Minor style issue - we prefix 'private' attributes with _ (_callCount) instead of suffix them.
Fixed in merge request #1231. ^_^
Still getting errors with stock LuaCocos2d.cpp:
```../../../scripting/lua/cocos2dx_support/LuaCocos2d.cpp: In function ‘int tolua_Cocos2d_CCMenu_alignItemsInColumns00(lua_State*)’:
../../../scripting/lua/cocos2dx_support/LuaCocos2d.cpp:41885:61: error: array must be initialized with a brace-enclosed initializer
../../../scripting/lua/cocos2dx_support/LuaCocos2d.cpp: In function ‘int tolua_Cocos2d_CCMenu_alignItemsInRows00(lua_State*)’:
../../../scripting/lua/cocos2dx_support/LuaCocos2d.cpp:41920:61: error: array must be initialized with a brace-enclosed initializer```
If TEENSY_SUPPORT is enabled,  ADC_VOLTAGE_SUPPORT should automatically be disabled, so the warning here is obsolete.
The default is already null, don't need to pass that.
Can you even put the main as a property of the object you return? But yeah using an argument to the function is pretty odd and I'd rather avoid it.
@ochameau mentioned on IRC that he does not likes names I have proposed. @Mossop @wbamberg what do you think ? Do they read awkward ? Maybe you have a better suggestions ?
nice catch for the transition.  maybe add a comment saying we can delete the || part in about a month.
Yes, r+.
See the next pull request- it was an accidental deletion. Oops.

On Thu, Mar 15, 2012 at 5:02 PM, Owen Coutts <
reply@reply.github.com
> wrote:

> > @@ -18,9 +17,10 @@ def login_region(self):
> >          return LoginRegion(self.testsetup)
> >
> >      @property
> > -    def is_logged_in(self):
>
> @rbillings Why did you remove this? Did you find a better way for
> login/logout tests to run without this?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/qmo-tests/pull/13/files#r566204
>
It turns out that this isn't actually the class that should be used for the `verify_callback`. I tried to remove the stubbing and it turned out that the `current_cert` method doesn't exist on the `OpenSSL::SSL::SSLContext`. It is actually supposed to be an `OpenSSL::X509::StoreContext`.

This isn't your mistake, but it is something that I want to clean up. If you can fix up the other two issues, then I'll merge this in and go through and fix up the tests. I think if we use the right class there is no need for mocking because it looks like the `OpenSSL::X509::StoreContext` is simple enough to just be a value object that we setup and then pass in.
Is this the best definition of what a file containing Puppet DSL is?  It seems like this should be as stronger assertion than just "isn't Ruby", since it might otherwise cause headaches when, eg, someone uses the compiler API to determine if a file is Puppet DSL - and passes a JPEG file the user supplied or whatever. ;)
It's all gone now.
s/values/value/
I think it'd be better to not print any patch level instead of -punknown
Go for it. :-)
MIT is our preferred licence, although you can go less restrictive as well (like giving up all rights to it)
This should be "when an example completes"
This header list of columns does not match the actual data columns that are output.  Is there a driver for using `PWR_CMD` instead of `POWER_CMD` as it is called in the commanded states database?
API changes are not backward compatible, please increase the version to 2.0.0
I'd suggest to instantiate the loader within the setUp method and store it in $this->loader, as it never takes constructor arguments.
+1 from me as well. Make sure to name it AbstractTranslatorHelper, not TranslatorAbstractHelper.
I don't think that will be any package with this name
this should be aligned below the second open bracket
Caution with this
That's a good point - it would mean undoing changes every time you want to test.

Non-in-place sounds good.
Think there should be a space after the last ;
Not needed. We only support IE8+, which does support JSON.
Yes. https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String/Trim
I don't like this big if/else clause, all we use there is now() vs datetime.today() -- do that at the top of the file and just use now() in here
Yes, please, Exception makes sense
I would rename this to just `Authentication`. You could always namespace it under your application module name (`HaxxorNews` or whatever).

I would also take the contents of `MyRedirect` and put it in here. They are all related to authentication.
CS:  Extra empty line
Same with Content controller, there was no need changing RestUser/RestUserGroup to have RestLocation instead of Location.
Shouldn't this provide contentId ? (same bellow)
two emtpy lines before definitions outside classes
there is nothing wrong with VO, but the a|b|g|l|v is only relevant to us, so that that could come from a config file.
there are more protected groups p_ (for projects (or is it pr_) , li_ (for license related groups) ...
so there could be a 
VO_NAME_REGEX = re.compile(r'^(%s)vo\d{5}'%SITE_GROUP_PREFIX)
defined in utils (and SITE_GROUP_PREFIX from  a config file)
In Binary we are still using the unpack of Application, which is to unpack a .tar/gz/zip package...
This wil write a new line each time, which is not wrong per se, but it adds the same information over and over again.
The solution where we would write a new .append line is preferred.
Ithink we should use a non-nested group id such as wicket_ear or wicket-ear - just for consistency.
Looking back the logic I wrote doesn't even make sense. "HTTP" is a valid extension method, so setting the type to RESPONSE before encountering a / doesn't make sense.
use github go img
You don't need to quote the keys unless they are reserved words or contain spaces:
```js
return {name: k, total: v}
```
Make this a defineProperty getter for media.error instead
See https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/utils.py#L22
Use: https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/views.py#L359 which means you just have to return a dict
too much logic for a template. Can you make it `event.is_live()` or is this the only place in the whole site where you need to this conditional check?
I think that a user couldn't be authenticated without being active, so the difference is usually unimportant.  The edge case that might come up is if you inactivate someone who's already authenticated.
If you do end up using cleanISBN, this should be 3.0.9
ok, I'll move it after </organization>
Do you remember why this was necessary?

In general it’s better to add a fix in a separate commit together with a test to ensure we don’t introduce a regression regarding this in the future.
This could have also been moved to the `TradeManager` because threads have nothing to do with the Trade interface itself.
I'm going to assume this all works. Maybe someday you will even document it.
I think this ASCII Font is a little more smooth and bacon-y than the last. :)
No because it is namespaced. 

It's because the name factory is extremely generic, though. What kind of Factory is it? A config factory? A logger factory? A factory factory? A factory factory factory factory (lol java). 

Using a more explicit name lets another consumer know what it exactly is without reading the code or trying to infer from the usage. 

Jamie Winsor
@resetexistence

On Nov 11, 2012, at 11:21 AM, Kyle Allan <notifications@github.com> wrote:

> In lib/nexus_cli/remote_factory.rb:
> 
> > @@ -3,7 +3,7 @@
> >  require 'yaml'
> >  
> >  module NexusCli
> > -  class Factory
> > +  class RemoteFactory
> I'm actually not sure I understand this. Is it because Factory is a common name and other people could have that name in their apps?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Yup, just for gems. Carry on.
Oddly, setting sortable to false for a column is causing that col header to relocate to the first col (where filter icon would normally be). Haven't figured out why yet.
If this is changes, then all use of "urlmatch" needs to be changed to make it consistent.
I'm getting  failure at this assertion for the Personas/fox parameter: E AssertionError: Personas is not found in Add-ons for Firefox Search
We don't need to verify all IFDs, only those we intend to use.
If this has to be a string, I'd prefer we make a precondition that checks that it's a string, then just have the param be "s" or something. Also, is the postcondition here that the result is `(instance? Period %)`?
You can use `keyset` from utils instead of `(set (keys {}))`
Done in 86eaa35cc70f5254016e9b364064873db432eb42
tenantid should be tenantId
But it looks like it's just taking a copy of the general field?
Shouldn't it be one of  `SearchConstants.sort.options` via `SearchUtil.getSortParam`?
In hindsight, it probably will work, but I'd still recommend that line for clarity.
I'd like to get other people's opinions on this as well. We need a single strategy for functions that don't require a callback.

Wouldn't the utility function for getting a config value have the same problem?
This sequence is a bit concerning. If a connection fails after line #491, you are in a state where a user thinks they have removed some permissions (the ContentMembers is emptied of the users), but all users still have the content in their library and have access to the content.

I would prefer if this sequence went like this:

User #1
* Update roles CF for user
* Update ContentMembers and update library

User #2
* Update roles CF for user
* Update ContentMembers and update library

etc...

This would better control the scope of a failure and take security first.
Can you find a more meaning full name for this method? Without any documentation, it is really hard to know what it is supposed to do.
True!! That was totally not intentional, great catch!
would this not be unexpected, calling only some of the matchers? i can simply create a request from the url and forward to matchRequest to have all routers called. or, as the things you have to inject have to be routers anyways (for the generate) i could call match on them. then its up to the delegated router implementor to decide what to do.
Could this GET also be GETALL or GET_VERSIONS? I note the use of pipeline.getOperation().getSimpleName() elsewhere in this method.
They are indeed, and I've tried appending instead of prepending them while building the connection string.
Now that I look at it - there's a number of other issues, which leads me to this question - have you actually tested it? Cause I'm sure I've read about all the valid parameters in order to do that whole thing.
$this->config[$file] = isset($this->config[$file])
        ? array_merge($this->config[$file], $config)
        : $config;
This here should go ...
My mistake... I'll fix it along with other similar instances below.
Why? There is freetype font rendering code in gfx/fonts/fonts.c already.
Instead of this hardcoded path you can use `android.content.pm.ApplicationInfo.nativeLibraryDir`
This check should go even before the `gyp.opts.target` check, pretty minor though, it's already working as expected.
Whops, sorry. The refactor is necessary, but I mean, those lines:

```
# - it validates the owner is not null (should it verify it is valid?)
# - it doesn't need a redirect_uri
# - it should it verify grant_type is "password"
```

These seem to be done
Removed duplicate:

https://github.com/worldofchris/cucumber-js/commit/80b8b56993ceb427cb188d87deb817330ba5d52b

On 24 Jul 2012, at 23:05, Julien Biezemans wrote:

>> @@ -56,6 +56,12 @@ describe("Cucumber.Ast.Feature", function() {
>>     });
>>   });
>> 
>> +  describe("getUri()", function() {
> 
> This method is already [speced](https://github.com/worldofchris/cucumber-js/blob/0ee152a8ffa15fe5ff3512a2ec33536976064ab0/spec/cucumber/ast/feature_spec.js#L47) :) The original example description is wrong though, it is about *background* while we're describing *feature*.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cucumber/cucumber-js/pull/79/files#r1230303
What's this EventLab API? :)
@asm89: Is there any reason this functionality can't exist in the base filter class? This seems like very common behavior, and then the base class could be used as the default config value?
Should this be an assertion instead?
Can you please [add spaces around the return type](https://github.com/github/objective-c-conventions#blocks) here?
These guys were brutes, walking all that distance like that. I guess demi-gods are cool.
This is one of the best Shakespeare lines ever, especially when quoted by a Klingon.
To avoid pitfalls related to call userid after JTable::store.
I'm not sure if loc has to be set in extra quotaion marks cause loc sould be a string but I got in trouble with locations like: <code>a.webside.com/#index</code>
and this helped (me)
if there is a better way please let me know
thx
Indentation is wrong and there is also some trailing whitespace.
As for the `magic` command, these help descriptions should include a verb. Just adding "list the" to all of them as in `magic`'s would be great.
call it requestModule
Cool pep8 handling there. I prefer wrapping the imports in parenthesis instead of the escape character:

    from django.http import (HttpResponse, HttpResponseBadRequest,
                                           HttpResponseRedirect)

But this is only my style preference
This should not be abstract.
maybe:

...prefix: a netmask and CIDR.

This reduces the commas and clearly shows which two representations are being referenced.
I guess we don't need this file at all. You can just require() background.js directly in the test spec, right?
I think these should be arrays not maps for efficiency.
With make it a lower case "response" or :class:`Symfony\\Component\\HttpFoundation\\Response`
Yes, the article is compatible with 2.0.
yea, self.name is the queue_sid. I don't think anything is affecting self.name
Yes there is. It's next to helper.mybrain
Not big on the "rich" thing. Needs a better name
I thought about that - I can try it out this week and see how it works. You're talking about something like this?

```ruby
index(polymorphic ? %w(id type).map { |t| "#{col}_#{t}" } : "#{col}_id", index_options.is_a?(Hash) ? index_options : nil)
```
We're in the process of adding @throws clauses to these since otherwise it trips up Java: https://github.com/jboner/akka/pull/328
I've updated things and it solves (albeit inefficiently) for the general nc
polynomial factors. Much better than before. I added more tests. I also
incorporated factor_nc into the factor routine. I'm running tests now and,
tomorrow, will fix anything that failed.
I take that back. The problem is: `no method convert(Type{Float64},ASCIIString)`
It is late but I can't sleep so forgive me if I am off on this.

Using the disabled tag means that it won't parse them, not just not show them. Is that what you wanted to do here? If so, there should be a hook somewhere to add to this list.
status are now 32 bits, could you change your range from 0 to 31 ?
Please remove the selectMapSourceMenuId field completely. Instead please declare an additional independent menu item constant used only for the submenu itself. That constant does not need any relation to the MIN...MAX range of the menu items.
The preferred way to write this is using `where()`

```ruby
Book.where("name LIKE %#{params[:search}%")
```

However this is vulnerable to a particular type of attack known as 'SQL injection'.  The following avoids that vulnerability:
```ruby
Book.where("name LIKE %?%", params[:search])
```