labofsahil/github-event-dataset-2012 huggingface dataset:
> -----Original Message-----
> From: XxXPachaXxX [mailto:reply@reply.github.com]
> Sent: Monday, February 06, 2012 10:35 AM
> To: Sven Killig
> Subject: Re: [kernel_msm] Support for Qualcomm MSM7201/QSD8X50 on-chip EHCI USB controller (0e3dbcd)
> 
> hey, this isn't working on 2.6.35 kernels...when disabling usb gadgets the
> kernel give an error during compilation in htc_devices.c. THIS:
> 
> What do you think?

sorry, my patch for 2.6.35 isn't available on github, but only on
http://sven.killig.de/android/N1/2.2/usb_host
Das war auch so gewollt.
Also, please add the names of the games being added to the commit comment. Makes it easier to search for that kind of thing :)
if(!empty($salutation) && strpos($field_value, $salutation) === 0)
Thanks for the catch. Fixed. 

On Mar 8, 2012, at 3:41 PM, fehguy wrote:

> shouldn't line 193 be:
> 
> if(!serverList.contains(dbServer)) serverList += dbServer
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/wordnik/wordnik-oss/commit/e7f4f89d958e209318c68a97900a35209ad93b45#commitcomment-1063452
Hey oli, this is awesome!!
No $ reference please :(
Don't store it.

cast it from getEntity()
Oh I didn't realize this. Good thing that we reshape then in any case.
For #1213
Would it be a reasonable thing to simply allow the caller to specify a CharsetReader factory method (perhaps by putting a new member on Document)?  (Similar question for the downstream RSS package?
Thanks a lot for your patch. If you remove debug output, fix indentation to 2 spaces and add documentation for it I'll include it right away :)
Why is this a List? Why can't you specify the message yourself?
Add spaces before and after parens: `dictId( dictId )`. Also note that you can write it just like that - there will be no name clash.
@blafoo: We already had that discussion some monthes ago. cgBase is _not_ debug code. As I said before, I found at least 4 different bugs in our parsing code just because of this cache properties inspection and because of the log messages that were produced by this code _only_.
i think you need ZOOMLEVEL_MAX + 1 here, otherwise the Coordinates of the detailed cache are on par with a live-map cache retrieved at the highest zoom level.
Hm -- I'm thinking this should be primarily a style guide (although I confess I'm not sure what the difference is between that and a "coding convention".)  Right now, I think "how to express errors and exceptions" seems reasonably within the scope of a style guide.
Возможно хорошей альтернативой по быстродействию и "чистоте" кода будет перевод меню через CSS с помощью псевдо-селектора :lang и аттрибута content. Но надо проверить как оно на 10/11/12 версиях отображается.
I'm showing my ignorance of git, I suspect. I didn't know repos could be renamed, thanks for the suggestion.
Thanks for the contribution. I'm having trouble understanding how your code is functionally different to mine. In your code if a field ends with `_id` then line 81 will not execute, ie. `model_field` will be None. Then line 107 will execute and you will have `fields['None'] = 'somevalue'`.
ok. Will also do that then.
rspec ~> 2.8.1 :P
добавление, редактирование элементов
http://php.net/manual/en/reserved.variables.httpresponseheader.php
Are changes to file really needed?
Try the attributed string code from http://snippets.aktagon.com/snippets/358-How-to-make-a-clickable-link-inside-a-NSTextField-and-Cocoa
I'm not sure if the text attribute'll accept an attributed string, if not, use an accessory view: http://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSAlert_Class/Reference/Reference.html#//apple_ref/occ/instm/NSAlert/setAccessoryView:
heh.  That isn't an actual http redirect Amy, it is simply setting the internal route and path... which is what generates all the routes for the system.
那个地方没弄好，暂时就那么着放那儿了，具体的Contact要怎么个输入，还得再细细想想
these hints are related to the location of the start/end/via point, not in routing itself? or?
Sorry for the messed up commit history. I accidentally pushed the wrong commit. If you pulled in the last 5 minutes, just `git reset --hard HEAD^` and then `git pull` again.
I had some warnings:

```
cd unix && make TARGET=cygwin
make[1]: Entering directory `/home/alex/dev/xp-runners/unix'
(echo "#!/bin/sh" ; cc -E -I. -I./src -x c -C -P -D__CYGWIN=1 -imacros src/macros.h src/xp.in ) > cygwin/xp
./src/common.in:3:8: Warnung: fehlendes abschließendes Zeichen '
```
Does Jasmine really know how to interpret this file as a pointer to `vendor/ember-0.9.3.js`?
It's just that it isn't needed if we're not clustered.  So I'd rather not initialise the field.  Same with the CHMaps, and the CHMaps can be initialised with concurrency level from configs as well so hard to make them final.

The lock not being final isn't so bad - we're not synchronizing on the object ref or anything.  But yes, we need to make sure it is only ever written to once.
r+wc, go ahead and merge it in when ready
Для начинающего разработчика Рельсов очень даже хорошо:
 - покрыты тестами разная логика
 - разбито все на context  - удобно воспринимается при чтении
 - адекватные названия - сразу понятно что проверяет тест
It might be better to create a separate method for this (extract method on the lower part after the svgElement creation) and to use this method - this change breaks the existing API (it might not show in the unit tests, because related unit tests are not included in BioMixer).
Guava has a utility class for this. You could do:

InetAddresses.fromInteger(ip & 0xFFFFFFFF).getHostAddress();
Nice, I forgot about ?
I reran the app thus the symbols changed.  I am including zip of code, crashlog and symbolicated symbols.  For some reason the crashlog would not symbolicate.

Rolins-MacBook-Pro:Debug-iphoneos rnelson$ atos -arch armv7 -o HudDemo.app/HudDemo 0x0000532e
-[MBProgressHUD dealloc] (in HudDemo) (MBProgressHUD.m:202)
Rolins-MacBook-Pro:Debug-iphoneos rnelson$ atos -arch armv7 -o HudDemo.app/HudDemo 0x000062c2
__destroy_helper_block_145 (in HudDemo) (MBProgressHUD.m:271)



Thanks,
Rolin
On Feb 14, 2012, at 5:06 PM, Zachary Waldowski wrote:

> atos -arch armv7 -o HudDemo.app/HudDemo
It looks like kind of overhead to convert the UTC time to locale's time. The idea here was to have timestamps in locale's timezone. So if you take a look at strftime, there's option to have that without using any kind of conversion. specially the '%X" directive. See if you can make the change and send the patch.
Reviewed, it looks good!
removing padding, see above comment :+1:
- In the steps for Alternative installation, instead of providing link to IDE zipfile, explain that the latest
release can be found from our downloads page
( http://www.liferay.com/downloads/liferay-projects/liferay-ide ). That way,
we don't have to update the actual zip file link with each version of IDE - which in fact is currently 1.5.

- In the "Requirements" section for "Setup", Since Helios or greater
versions (e.g. Indigo) are supported by
Liferay IDE, please list the Eclipse requirement as ...
"Eclipse IDE for Java EE Developers (Helios version or greater)"
I think it's no need to remove require signal in catch statement, because if the error occurs and comes to catch statement, require "error" handler will be triggered.
cannot catch require(["dojo/text!./template.html"]) error because dojo/text not return error info to require.
Can you submit a ticket for this, btw? This commit doesn't seem to have anything to do with this convo.
That is what I thought it should be too (would make sense), but in my trials, that also failed for some projects.  Still need to check which one was failing again.  Will look at this as well when I get some time.
Hmm, this test shouldn't work that way
Better? Did you happen to test it?
do you get the cpufreq_smartassv2.c and cpufreq_smartass.c?
I have tried one from internet. compile ok,
When using it, the behavior is strange and freeze when switching between it with other governors
This revision causes MP3s to display incorrect lengths (or no lengths) while browsing.
Hopefully there is a better way to fix #1246.
I think this information should be in the config-file.
Pra não precisar ficar instanciando toda hora professor e disciplina, só usar.
To @weezel, didn't your patch request said "In the Western culture, red colour means 'failure or warning'..."? The red carpet is a part of the Western culture, isn't it? (c.f. http://en.wikipedia.org/wiki/Red_carpet)
do we really have those situations? A set of unit tests showing the situations you're trying to cover would be definitely of help.
Although I've got the tubs style installed I've got problems compiling the template...
not really needed :P
*fixed
-Better working at opera $offset function
В опере на некоторых бордах (а также в лисе на форчане) возвращался 0, и выпадающие меню не отображались.
Эта функция доступна всем популярным браузерам.
OK this is weird, I reported this exact same bug to @alesj on the 13th and he fixed it for me, but I can't find exactly his commit ATM, and I do see the buggy (-looking) code is indeed still there, so he must have fixed it in another way, but how? And why didn't I get it anymore and you still do?
Nope, stated in the WordPress Coding Standards.
No je to divné a asi to byla moje chyba... Nevím přesně kde vznikla ;)
I think we can simplify further by stealing implementation from ipaddress and skipping the extra dependency and just use:

    [rand(2**32)].pack('N').unpack('C4').join('.')

See also: https://github.com/LightMesh/ipaddress/blob/master/lib/ipaddress/ipv4.rb#L822
This has no dependencies because the `request` module will always be there when running in Node.js, correct?
Please also check "parent !== null" in case there's no selectable ancestor
Its in a loop, so it continues to try the others.
Sorry, I've just realised that I'm wrong. You might have different ids associated with different portions of the mesh, in which case you'd have cell domains `dx(1)` and `dx(2)`, for example.
We use one-liners even when it exceeds 120 chars?
It's private, now.
But I can change it to this if you like it better:

     removedMembers foreach { member ⇒
       val address = member.address
       clusterCommandConnectionFor(address) ! ClusterLeaderAction.Remove(address)
     }
Yes,  you loose a lot of the automation.  I'm not sure why we lost the rename tracking, but maybe if we merge move_packs first, we can rebase so things go more smootly.
Right - but this fix is for Nibabel 1.1.
Hmm. This means they cannot diverge from each other at the logic level in the future. Maybe we will want them to maybe not (I have no idea), but maybe having organization_ actions that just wrap the group_ actions would be the best of both worlds?
This probably needs to be two entries.

server_calls.log is set by admin.conf for the admin client
consumer_server_calls.log is set by consumer.conf for the consumer client

FWIW, those names are configurable, but you probably don't need to mention that. They'll get the idea when they look at the conf files.
Shouldn't kill be implemented especially for this Feeder since it will loop infinitely?
Wrong method name. Should be UpdateContainer.
Could you please add the location of the localized string call like this:

```
#: xbmc/settings/GUISettings.cpp
msgctxt "#36026"
msgid "Show date from EXIF data"
msgstr ""
```
Just if it is not a big trouble. If not, I can add it later.
Thanks
Should this one be wrapped in GetWrappedImageURL() ?  Otherwise the URL may not be readable to the client (it could be local to the server).
cosmetic not really required (similarly above)
да, ты прав.
I'd prefer:

```python
if not e.args:
    e.args = ['']
e.args[0] += ...
raise
```

This preserves the traceback, and allows for more future changes in `JSONDecodeError`.
I must be wrong, but I guess the imports are already added.
looks like there's a typo with "AppDelegat's" should probably just be "app delegate's"
Using the `paginate()` function probably means you can remove this extra `$page` parameter, right?
why did you remove path normalization?
OK, fine then
Can you make the test less chatty? Otherwise LGTM.
This should not be hardcoded. Please use Info object or $FREESURFER_HOME variable
It used to be a void function, but it can fail. Python API functions that can fail can never be void, because that leaves no way to propagate exceptions. Which is why this patch fixes it to not be void...

If the `fail` label only does cleanup of things that haven't been allocated yet, then of course skipping it is okay. (Though it's still confusing that this sometimes returns 1 and sometimes -1 -- it turns out these mean the same thing, but you have to think about it and check the docs to know...) But consistency of style is still important, and notice that this `return` comes *after* a `goto fail`. Basically all this stuff makes the reader have to think carefully, and people reading code have enough to think about without idiosyncratic coding styles that are very similar to those seen in buggy code...
Of course there is a % missing after the format string. But anyway, a "return self['service_description']" would be best.
Sorry for the inconvenience.
I think you can invert the condition, and test for `== :time` first. Seems easier to read.
If you see that with the change they will became more complex let me know that we can merge this without this change.
@jeremyevans Oh yes yes. Just an extra Array. Ooops! I hadn't had dinner yet!
@gazay why?
remove the semi-colons :tongue:
Would it make sense to detect groups rather than hard code 1-9?
my beautiful if-formatting!!!
If that's a fubar situation, I guess then it's better to crash.
One of the original reasons for having an anonymous order was user token access (so users were able to access their own in progress and completed orders only.)  IIRC we moved the token to order now so maybe its safe to contemplate this.
Well, to my knowledge, PEP8 disapproves such aligning.  I can't say I totally agree with that, so I'm not suggesting anything, just pointing it out.

(I think I've also seen such aligning in other parts of this pull request.)
"in nur eine" -> "in nur einer"
> If I understand correctly, `UnitSystem_whatever_whatever` is a class having some methods to define global options, that the UnitSystem (and Unit, Quantitiy) class(es) will use?
>

There is nothing global and there should not be in my opinion. All the
stuff that you want to be global should be better encapsulated in an
object. All the work is done on this object, not on some global state
that can be corrupted at any time by some unrelated function.

At least this seems like a clearer solution to me.
commit added so that unit_triangular -> triangular
Add a test on `Trace(Adjoint(Sq))`.
Hm, yes, I see what you're saying, I was mostly going off what was implemented before and is being replaced by your new implementation without really thinking about it.
ahhh, here's where the ordering problem comes. You are suggesting a depth-first application (if I have the terminology right). Also, yuo are not suggesting (and may not have done) an application of the hint to the arg-modified result. I believe it should be:

```
# apply to top-level expression, perhaps obtaining new args
if deep:
    # apply to each of the args
```

OR

```
func = self.func
if deep:
    # apply to each arg
if result.func == func, apply method to result
```
Patch looks fine. Just one note to API of AugeasWrapper.
It looks like this is not instance specific attributes, so it should be class one. And instead of this I prefer something like Active Record have
like in example below.
Second part I don't like is useless read/write. If a lot of agents have same read/write that just pass params to serialize/deserialize then I recommend to have it automatic.
So ideal example like I plan it for my augeas_serializer should look like this one:
```ruby
class Adjtime < ConfigAgent::AugeasWrapper
  lens "Adjtime.lns"
  path "/etc/adjtime"
end
```
Can you add some comments indicating that the _mh_execute_header is declared as part of the mach-o headers that we're importing. It otherwise looks like an undeclared iVar
Doesn't this save() need to be called on the newly created association model, not in this model?
I'd move this down inside the `try` block, just 'cause.
@ChrisR07 that's what I said on IRC ;-)
OK found it. Yeah, that's where we're currently working on it.
Please remove these four lines.
gcc sometimes generates pretty bad code for structs with volatile members, it's better to do a volatile cast at the place where it's used.
So why use eio_fdatasync then?

I suggest that you split off the fcntl(F_FULLSYNC) into a function that gets called by both code paths (synchronous and asynchronous).
hehe, I was trying to make the point that should someone call `start` within `begin` (whatever the reason) - it would still work as expected. 

Anyways… do you want the hacky (begin, timeout) solution, or the new "init" event?
Actually, this needs to be smarter.  Bubble it up if the error was `integrity`.  Create new `integrity` if `urls.length == 0`.
what's the -1 do?
link should smell better
This document should be in draft, as it doesn't look complete.
I tried to get Sheppy to start one, but the email thread eventually said @mozhacks should be the one.
`$db->sql_query_limit`
Converter converts to 3.1.
`$php_ext` is a string, not "mixed"
`$this->assertSame(true, apc_fetch($key));`?
There is an autoloader for tests, if it does not work please explain why.
I would generally like to delete such @ uses and see what would happen.
Please add compatibility code to make the old style work, as otherwise bisecting etc. will become unnecessarily painful.
"container" seems like a very optimistically un-scoped choice of a name here.
There are still no descriptions of what each case is testing.
@rphillips I personally don't care as long as it's consistent across the code back which currently it's not. :)

I've suggested return after the callback line, because that's what most of the existing code does and because that's the standard node.js convention.
i moved the table.insert verbatim from the rebuild function. I'll look into it more and figure out how it works.
Still imho yageconfig more suits to a runtime config, not header. I suggest global.h or similar.
I considered using `skip`. In this case, pdf generation is off by default, as it requires a latex install as well as sphinx. So it means that you generally want to enable pdf output, rather than disable any of the outputs. With skip this doesn't read so well in the double negative:

    skip in generatePdf := false

rather than

    enable in generatePdf := true

Anyway, that was my thinking for adding a custom `enable` key. I briefly checked sbt for a positive boolean key but didn't find anything suitable (would be useful for these situations). I like this better, but not worried either way.
`addXHailsSensitive` is a confusing name for this 2 part function. Since it executes the app and also adds the `X-Hails-Sensitive` header.
I think we want a trivial "Middleware"-pipeline.
I meant: What if the user had actually already set the bonsai audio object to playing? The `<audio>` element is not playing yet, of course.
As a coding standard it's a bad practice to assign to a parameter. Older versions of certain browsers would crash if you did this. Newer standards are looking like they'll disallow this practice in strict mode.
I thought i was supposed to *only* use foreaches and whiles in my view. Leave out the real functions as much as possible. Hence this method.
IMHO, it's acceptable as a temporary solution but has to be unbound from Alex' local system!
Just a general thought, but is the project configured to be built for the `MonoDebug` and `MonoRelease` build configurations?
ideally, we should remove html formatting as much as possible, and use Sencha components and layouts. Check out : http://www.sencha.com/learn/intro-to-layouts-in-sencha-touch-2/ (for example: see hbox, vbox). I believe this will maximize the ability of designers to globally change CSS and affect all our pages.
I don't know what pycuda._driver.LogicError is, is it safe to ignore?
S this is not really a valid Op.  Ops in Theano are like pure-functional operations in that their output has to be a function only of their inputs.  This Op has no inputs, and must therefore, by Theano's logic, be a constant. It would thus be called at compile-time, and removed from the graph completely. Perhaps this is part of why you've found that some optimizations interact badly with this PR.  You might also run into trouble with the MergeOptimizer if you're trying to receive several packets...

One solution, as with random numbers and other not-obviously-functional Ops, might be to create a system of names for the blocks that can be received.  The system can be sort of trivial, but it would tell the merge optimizer which Ops can be merged, and it would tell the constant-folder that this Op is not a constant.  For example, if you know at graph-construction time how many sends and receives will be made, then you can simply number them 0 to N.  Then, when you create the `op = MPIRecv(src, tag, ...)` you can see that `r5 = op(5)` is the receipt of the 5th block, and it is not generally the same data as some other `r4 = op(4)`, but it is the same as `r5cpy = op(5)`.
My mistake,thanks.
IntegrityError already does a rollback.
Welcome to my world. I didn't want to change the API of introspection, since that can't be changed without a deprecation cycle, so I have to work round it here.
@jdevera I don't think it is a problem, because most time no one cares the log at all. And using different command for different cases may increase the code redundancy.
Can you please create two `if`s for this? Like `if (instr.type === 'call') ` and `if (instr.type === 'method') `? Also it would be great if you'll fit 80 char limit.
Most of the non-observable values will be detected by a simple args[ i ].promise without the need to call jQuery.isFunction. Big performance gain, especially in old IEs.
I wonder why we're using $1 and $2 instead of variable name while argument variable optimizer is used below.
Dry mode = lots of hot air. :)

I guess I wanted to write "dry run"...
It is a temporary table. So we don't need to drop it. 

For all these temporary tables, we do not drop them at all currently.
Typical convention is the former, on the line above the gettext call.
OK, but I just discovered the built binaries this way behave differently. :(
Seems like further investigation is needed.
I'd be most comfortable skipping the bottle_current check for autocompleted urls, until we decide what to do about them.
Why remove this? They aren't addressing the same problem.
This change should be split out into another commit (and pull request).
ありがとうのリストを作るときに（検索キーが送り主もしくは受け取り手だったとしても）表示の際には双方の情報が必要、と考えて include を…、というのが用意していた答えなのですが、実際のところ、この辺りの挙動と言うか「どう書けば最適なのか」について知識が足りてないので、無駄なことをしているのかもしれません…。
Oh yes. Do you want me to do that in this PR? It should be easy enough.
This controller reuses much of the functionality of the original ``Notes`` controller. *Copying code and not reusing it is bad practice.*

A very nice way to reuse the code and add the functionality you need for the flow implementation is to treat this class as a derived class of the ``Notes`` class. This needs a bit of refactoring in the ``Notes`` class and I will outline how to do this in the following comments.
An element is never found by this id.
Ah yeah, that makes a lot of sense.  
I knew I was doing it totally wrong. Cheers.

Will fix these up tomorrow sometime when I get chance.
Had initially done it that way so that a user could run wp theme install --file some-filename.zip, but it does seem more idiomatic to do it in that way.
readline的确是常见的缺的库，不过只要按上面`build-dep`方式走，这些问题都不会存在，所以“（一般是……）”可能不必说明了。
Don't we really want this increment inside the forEach loop, or does writeTo guarantee the data is only written to a single partition?
Maybe after this gets pulled if it does :tongue:
It is possible to do it with less direct synchronization.  However, maybe it is just overkill.

Also, you need to be careful when using the skip list.  The comparator must match the equals method.

If .equals(Object other) is based on the chunk position, then you shouldn't based the comparison on the distance.  Care is needed to get everything to match,
Btw, I've run the updated tests locally to verify that they work... but you might want to just double-check that after you copy in my changes...
Oops, right -- I eventually figured that out when reading further into the diff.
You may also want to decode this as well if module.uri can have some non-English characters.
Do we need a click event? Clicking a menu item will dispatch a command, so it seems like this event isn't necessary.
I can't think of how that could happen, but I made the change to be safe.

I also fixed a few other JSLint warnings in this file.
Oops sorry, misread the first 'if' condition.  So, is !hasEndQuote && !quoteChar a case we need to worry about?  In other words, when would startChar in that HTMLUtils code be left as "" but the tokenType would still yield ATTR_VALUE?
The plugin only contains the keybindings, the actual implementation is language specific
No permission check, that is baaaad
This also falls into the "elegant but confusing" bucket for me. What would be the problem with passing it in? Seems more intuitive/explicit/pythonic(?)
It is better to keep them with the skipping decorator and add a comment about the lack of reliable data. Even if skipped they are visible so that we don't lose track of them.
I wonder if it wouldn't be better to figure out what prefix to use ahead of time. MDN suggestions a solution if you're interested: https://developer.mozilla.org/en-US/docs/CSS/CSS_animations/Detecting_CSS_animation_support
How safe do you feel about the use of clientLeft?

You felt the need to add the docs for it, so, I wonder what the risk is for using it are.

If you wanted to not use clientLeft, you can instead use offsetWidth - clientWidth to get the total padding. Divide that by 2 to get the left or right padding assuming left and right have the same padding. Would this make things safer? ClientWidth is also not standard, but we use that all over the place. Is it generally better than clientLeft?

Anyway, not going to fail it on this alone. Just want the thoughts on this.
You've ended-up with Location and Lat/Lng.  Intentional?  Why not just do Lng/Lat to skip geocode completely?
Good spot @elemoine. You're right. Note that this PR does include `ol.source.TiledWMSOptions` in `src/objectliterals.exports` so this `@typedef` should be removed.
@kellyredding - there's some possible inconsistency here and later on with the `db` command. Here the second argument is the `output` and later on it looks like a `Hash` where multiple settings can be overridden.
As we talked about, this should be "processAction" -- also make sure you are passing the minimal amount of information possible here (could you learn the game and user from a socket, for instance?)
can't wait until organize imports for scala-ide can handle effective scala conventions . . . but done.
Можно не передавать `process.cwd()`, он будет использоваться по умолчанию
I don't understand this comment about phantoms, could you clarify?
Any idea on how I can figure out the type (FS or VOL) here? That code there obviously didn't work, because impl_share = NULL when I need(ed) it.
Just to be sure: Is this check correct?
If this is a required parameter, may want to add (required) to description like name and org above.
For jeditable, we support several different  types of editable fields (e.g. edit_panel_element, edit_textfield, edit_textarea, edit_select...etc.).  There have also been cases where custom types had to be created to meet specific needs on a given page.  As a result, we may want to pass in an additional parameter (e.g. editable_type) to editable, so that this can support any editable type.

Refer to jquery.jedtiable.helpers.js for a few examples; however, there may be additional definitions in other js files.
Do we need to excplictiy specify the "inner join" part ? . I thought joins(:jobs) automatically took care of that.
Move this check outside of this method so that we don't end up caching a bunch of dummy cancellation tokens.
What does "foo" do?
Easier / more efficient to clear its contents
These double dashes should be an mdash
Nope.  Just an oversight.  (This test came from pynbody).
If the particular format (Besancon) is really static doesn't allow for variations of col_starts, col_ends, etc then you don't need to allow for these as keyword arguments.  Instead just hardwire anything that is *required* by the format.  But I have no idea about this format and whether there is any flexibility.
This plot is great -- it might lead some to believe that calling `predict_search` actually produces the graph -- of course it only produces the data.  Maybe just add some text such as -- "plotting the results with matplotlib gives:"
What do you like best?
Is there a reason to check for __linux__ specifically?
Maybe StartShutdown()?
Yes, get/set methods would be nicer. How about a common method to get/set the various options, `_isRequired`, `_allowEmpty`, `_validationDomain` ?
Is `toString` necessary here?
I'm just being explicit.

According to http://msdn.microsoft.com/en-us/library/gg679461(v=VS.103).aspx the default is: 

 > "The default strategy is an instance of DropCreateDatabaseIfModelChanges<TContext> created with useSeedData set to true."

And I figure that we don't want that, so I'm just explicitly saying, "We don't want to use any DbInitializer, kthxbai"
if session.getAttribute(LoginServlet.USER_NAME) is empty, will it raise any exception?
What is `root` here? This doesn't appear to be correct at first glance.
I'm not sure a thread is the right solution here. Nothing in Enaml is thread-safe. The only way I could see it working is if all Enaml side code executes on one thread, and all toolkit-side code executes on another. It should be easy to establish such a boundary (since the entry and exit points are the pipe), you'll still need to maintain a queue of messages and which point we may as well implement a small event loop. What do you think?
could probably be in the form

```
maint_str = case type
when 'acknowledgement'
  'has been acked'
when 'test'
  ''
else
  'is state'
end
```
Blame me - think I originally did it. I agree though
Thanks for sorting this out. I'll push a fix :)
I add it to avoid clashes with another project I was trying to integrate jclouds-virtualbox with. I think this could be removed
it cannot be ws*, ws+, it needs atleast one space after the context right?
Looks like some of the file is indented with 4 spaces rather than 2. Also, some 'blank' lines have spaces on them.
Good idea! I was really struggling with getting date time to compare nicely. I eventually got it by updated the question from the database a lot, but it was error prone.
Could we use the pretty name of the locale here, instead of the short code?
It would be easy to swap out. No worries.
Oops. That was from when I was playing around with the Robot code wondering why some things didn't work. I'll revert that.
Sorry, github put my comment in the wrong line. Don't know why. This should be in line 2379, this code:


if (xLength > yLength) {
    /*
    if (X1 > X2)
    {
        Swap(&X1, &X2);
        Swap(&Y1, &Y2);
    }
    */

Same with the other comment, it refers to a similar piece of code
why is it duplicated ?
There's no need for typehinting there are the ```$result``` ca be either a string or a integer.
The point 3 would be an issue to handle the options properly. I would also vote for point 1. This BC break only affects people using the Security component standalone, not the framework users anyway (as the class is configured by SecurityBundle). And the point 2 also breaks BC but leads to weird code.
Would be better to refer to capabilities by name.
isn't ````@event.name```` always defined?
Replace 
    
    <a href="#ID">ID</a>

with

    <a href="#identifier">identifier</a>
这个不是一个 drag量嘛，每次实例化新的，会消除对上一个实例的调用。
This should actually be:

len( np.unique( assignments[ np.where( assignments != -1 ) ] ) )
OK j'ai lu ton commentaire (heroku toolbelt)
i wonder if this will be flexible enough in the long run, but works for now i suppose
kaka => best person.
The two new items (ujson and host_pool) aren't really install requirements, they are just normal requirements for parts of this library. If pip follows the requirement block I'd like to see these listed as requirements instead of install_requirements.

(also related to my general hate for open source dependency trees, it might be nice to remove ujson completely in favor of conditional simplejson/json imports for standard libraries)
В чем прикол формы entry is not None?
Чем тебя не устраивает
if not entry ?
classytag please. like all other tags.
The whole lot of changes in this file are not sitting too well with me. They show the three different ways to decide whether to fetch tags that are hidden or not.

I would like to see that decision only in one place, probably in core eZTagsObject fetch methods and other functionallity simply transferring the flag IgnoreVisibility.
what about chroot = '/a/b/c/d'?
Please use `<li hidden>` to hide this settings. thanks!
And also: http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/
This make the logic complex and I'm not sure that something Gaia wants to do. Let's remove it.
Yup we should, will update
@vingtetun here’s a possible improvement: https://github.com/vingtetun/gaia/pull/15
b2b -> b2g

Also what is broken in the python script? We don't really need it now that we have packaged apps... @jlebar Do you have an opinion on it? I wonder if we should remove it?
Is this on the way? 
If you launch the FTU app in fullscreen(indicated in manifest.webapp, fullscreen = true), some z-index issues may be resolved.

Activity frame does not support fullscreen now. It is, if you set fullscreen ***by yourself***, something unexpected may happen.
Avoiding bug while trying to send a SMS to a 'string'
hmm we need to add a note about enabling marionette later (not in this PR) I could not find a place where we document how to do this.
Internally we _know_ to use eng builds and b2g-desktop still has this enabled by default so its not an issue. (more a thought then a reflection of this pr).
This is the main change. All status are handled now here! So 'sending', 'failed', 'received' & 'sent' (and changes between them) are handled univocally. Why this is important? Because in our old code we have some 'edge' cases that we not handled. Imagine the following:
- Send a SMS to phone number A
- It takes 5 minutes
- During this 5 minutes, you close the app, open the app and go to phone number A
- Message appears as 'sending'

What does happen once is sent?
EXPECTED: Sending is updated to Sent
CURRENTLY: We keep 'Sending' state due to when closing the app, we lost the callback.

This is fixed with this approach.
I sorted the entire requirements/prod.txt file
:+1: to @schmittjoh

Plus, i never really evaluated Pimple as a standalone library. Single class with 8 methods just could not worth users time during installation. In fact, i've wrote this custom `ServiceContainer` faster than Composer would fetch Pimple on my machine :-D Jokes aside, making single-8methods-class dependencies is dependency management gone mad for me.
Have added a more recent version and linked it in.
pass the uuid to add_target, that's why we added the uuid parameter to add_target
Fair point. You could use this or something very like it to implement AggregateBy in cascading, but that is already implemented and very unlikely to use this approach (and in any case, is more about summing a Map until the map has a certain size keys/values)

I don't mind moving it into a different namespace, but putting it in summingbird rather than algebird means it will probably only get used in summingbird.

We (obviously) moved this here from summingbird because it looked like a simple component that could be reused.
That seems good to me.  Go for it!
Hmm, I don't get this behavior. You should definitely be logging instead of printing, but you should also throw this exception up to the caller, yes?
I tried without this line and purely in CSS using the psuedo elements :before and :after... It works, but not in IE < 9... So as usual, IE makes me have to do something cool in the least cool way possible :(
Could you add a @property comment to show how to use the divisor method? Since there is no method implemented by default, the user would not know how to implement it.
current_day - переменная лишняя
можно ж просто так:
    
    if schedule.to_hash[:rrules].empty?
        schedule.start_time.to_date == date
    else
        schedule.occurs_on?(date)
    end
Yeah I'd be ignoring style clashes for the most part. But I think we should be pushing for more uniformity. The one exception I'd make would be like a block of them. e.g.

if(foo) blah();
if(bar) what();
if(gee) fluh();
if(huh) nope();

I don't think we need to do a full audit or anything, but if you happen to cross some deviation from the style, in some code you're touching anyway, might as well fix it.
It comes from another pull request I made few days ago : https://github.com/cakephp/debug_kit/pull/56
I was branching from a branch that already included these changes, but I can remove them from this pull request, and keep those matters separated

[Hidef](http://pecl.php.net/package/hidef) is a php extension for defining constants. Hidef constants are not included in `$var[''user']`, but still considerer user constant, since they are defined by the user (in a .ini file).
`delegator ?= utils.beget attributes`
Because then it defaults to the strict schema for the second pass.
don't create a new factory. use ``$this``
Seeing your comment on #1015, actually 512M is maybe safer for now, because on linux it seems to report close to 256M and that will slowly increase until I can have another go at reducing memory usage (but that will take more time).
`id`の変化をチェックする。
Let's add terms & privacy & copyright while we are at it.
A new commit has been added to this PR with the modified quotes.
This test should actually fail in master, assuming all the unicode nonsense I've been fixing works, will verify.
Why do we want to define a pk method vs. passing in a name parameter?
Good point, I'll incorporate proposed change.
Because `mod._onContent` is taking only one arguments, that is actually the first argument of the `forEach`'s callback, you should be able to remove the creation of anonymous function:

```js
windows.forEach(mod._onContent, mod);
```
More descriptive name would have being helpful.
That's interesting. I'm basically reverse-engineering good practices from the modules that have been updated to use the new framework. In addon-kit, there are only two of these, "request" and "selection", and unless I misunderstand you, neither of them implement this sort of protection:

    const { emit } = require("api-utils/event/core");

    function completed(message) {
      console.log(message);
    }

    function selected() { 
      console.log("A selection has been made.");
    }

    var request = require("request").Request({
      url: "http://api.example.com",
      onComplete: completed
    });

    var selection = require("selection");
    selection.on('select', selected);

    emit(request, "complete", "fake response");
    emit(selection, "select");

Should we raise bugs against these modules?
As written in the `readURISync` comment (https://github.com/mozilla/addon-sdk/pull/542/files#L6R85) this function is intentionally undocumented; it was decided with Irakli.
No, because that would trigger a strict warning. If a property is not present you will have to check with 'in'
This is just a small performance tweak.
I was preventing the following calls:

>   document.getElementById("init").style.display = "none";
>   document.getElementById("data").style.display = "inline";

to occur on every event when it is necessary only for the first. To do this, I changed the function to be a variable instead. Also, another small performance win is that Firefox is much faster with var declarations than function declaration (source: http://jsperf.com/function-vs-var-declaration).
the choose method will be used by driver users to fetch a new driver instance for them
i think it makes sense to allow people to not use the class constants .. no?
Same comment as below for public vs. private intent.
puppetd is a typo, caused by merge of 2.7 into 3.x, I will change it and update.
Rename this variable to "number_of_seconds_between_shots" to remove that comment.
Sorry, I did not see that. Using changed() in other classes (eg. Variable) is ok?
Nice one. That's great, I think APIs that are forgiving to users always encourages people to start using them. Cheers!
In fact the test should be removed due the almost the test of the file already test this
Why not static $cache = array(); ?
Not sure if it's in the CS, but common practices seems to be to add parentheses: return new self();
Simpler would be to:
```php
return (bool) $this->getParam('error', false);
```
If we do not have an error parameter, then the default value we provide, `false`, will be returned -- which is correct.

If we do have an error parameter, then the value will be cast to a boolean, and that will be returned. Since the error parameter is set to an exception message, this will be a non-empty, non-false value, which means that isError() will evaluate true.
I hope that this value is not a real value that could compromise your security.
This method does not make sense to me. Why not simply register the ResponseSender, trigger it, and if no response is present, return early? Or is there some advantage to registering late?
I think the better approach is to alter doWrite() to call getFirePhp(). This would have the same effect, and also ensure lazy-loading in the case that the logger is actually never invoked.
I'd separate this into two tests, one testing retrieving a white-listed controller which is invalid for the ControllerManager, and one testing an attempt to retrieve a black-listed controller.
I'd actually argue here we import MessageDescription, and change the signature of dispatch to:
```php
public function dispatch(Message $request, Message $response = null);
```
If we deprecated this I would just remove this actual code and point to new method:

```
public function updateSymfonyVersions(Bundle $bundle)
{
    return $this->updateVersionsHistory($bundle);
}
please fix the coding standards (``else`` should be on the previous line)
Indeed, a `$hydrationCacheDriver` could be a nice addition to `Doctrine\ORM\Configuration`.
Simple use case -- this:

    class ArticlesController < ApplicationController
      def show
        @article = Article.find(params[:id])
      end

      def edit
        @article = Article.find(params[:id])
      end
    end

becomes:

    class ArticlesController < ApplicationController
      before_filter :assign_article, :only => [:show, :edit]

      def show; end

      def edit; end

      private

      def assign_article
        @article = Article.find(params[:id])
      end
    end

Basically, `before_filter` runs code before your action runs.
if empty, then this can be dropped.
spaces after comma
Yes, `orderedFunctions` gets passed in `this.transformOrder` which is by default equivalent to the `transformFunctions` array containing all transform function names in the default order. So this method cannot expect the same number of values in both arguments.
I'm guessing you have an N+1 problem here - you can tell if you inspect the logs when you run the index.

Consider eager-loading the tags for each user.
Can't delete this with the first migration. I could add another one that doesn't allow null profiles.
Actually, we want curated groups (i.e. groups with a steward attached to it). That's an error on my part as the mock-up shows "popular groups", but should show "Groups with Stewards"
If you're going to pause, listen for the pause event before moving on.
hahahaha nice
Ah! That's why it wasn't working last night -- I left :partial in when I was trying to pass the locals. Updated.
Why was the .compact removed? Doesn't this mean that we'll have problems with leftover nils again? (For some reason there were stale nils in the results, which is why we needed the .compact.)
This should be orange
because of faraday's removal of addressable (which believe me, is a good thing) we have to parse the query params manually.
if we turn off validations, do we still need this?
@ohadlevy, host.rb says operatingsystem_id is required only if host is managed.

 validates_presence_of    :architecture_id, :operatingsystem_id, :if => Proc.new {|host| host.managed}
要不要判断下返回值是不是error类型？
well, technically it's not terminating, it's throwing an exception, which will be handled by the supervisor.
...  Second thought, this is more just clean up and correcting the docs?
You may want to consider defining this linear-gradient by wrapping it in a mixin and putting it in colors.
You can include `fixed: true` when you create the `MovablePoint` and it won't move.
why are we deleting the _id?
実際の定義を見てませんが、英文から察するに:

配列の残りの要素を返します。*index* を与えると、その *index* から前方にある配列の値を取得します。
L7と同様に _```javascript_ にした方がシンタックスカラーが入るので良いかと思いました。
It is the programmatic equivalent of Hermes. Thjs is a redirection level to be able to plug non-remote (non Ajax) FilesystemServices into Ares.
что такое n и m?
Кажется лучше сделать два функтора, чем передавать лишние переменные
I thought cvan suggested jQuery's loadScript() here?
Can you fix the indentation for this thread block please?
So just to make sure I'm understanding--the key here is that joins should always be empty given our current available code paths, correct?  Otherwise we'd be guaranteed to get an error when we mapped them into build-join-expr... so this is basically just infrastructure for the future?
why did you add "rest" here?  just as an optimization since you've already tested that the first item is a string?
Extreme nitpick: I'd use the word "libraries" rather than "frameworks" here.
This can just use the createColumnFamily function
Should use _rowsToComment here.
We should not have this according to our guidelines. It becomes really confusing after a while.

Should just be:

`if (callback) {
     callback(err, rows);
}`
Just wondering if there is a need to explicitly differentiate between Principal and Resource. They seem like exactly the same thing.
Ah, right, silly me. It's ok.
change this around: [namespace, ...,] key
Same as above: 'Git' instead of '<code>git</code>' ?
I ran into a similar issue with 2.5.9 and the `*/*` "fix". The problem is that most browsers send `*/*` at the end of the accepts header as a catch all. What really begins to matter is the order of the mime types in the accept header. Personally I think it is wrong to handle the */* case in the framework. It is much easier for a user to decide what their default _catch all_ case should be rather than all accepts methods returning true when `*/*` is present.

I view the `req.accepts(<some type here>)` code as a way to see if that particular mime type is explicitly accepted and not implicitly. Personally, I would be in favor of reverting this change. Handling the `*/*` case is better done at the app level.
I don't like your style
http://farm4.staticflickr.com/3382/3294440989_e55665b823.jpg
A link to the website would be useful.
Посмотрел. И понял, в чём прикол.

Изначально проперти задавался как инструмент, позволяющий на ходу синтезировать не только переменную, с которой можно работать, но и правила доступа извне к этой переменной. Я в своём проекте задавал *только* проперти. Так как у меня самая последняя версия Xcode, synthesize писать не имело смысла - это делал за меня сам Xcode! И имея следующую строку:

@property (nonatomic, readonly) NSMutableArray *DNA;

Я мог *менять* значение своей переменной, обращаясь к ней как к _DNA, а извне [myCell DNA] дал бы мне доступ только к геттерам! 

А теперь смотрим на ваш пример: вы использовали внутреннюю переменную NSMutableArray *dna и создали проперти NSArray *dna. И в файле имплементации связали их! @synthesize dna

Я не знаю, одна ли переменная по сути в памяти, или две, но если мне вручную написать @synthesize и использовать так же, как и вы, переменную вместе с проперти, у меня всё получится, да.