merged branch jonathaningram/patch-10 (PR #5718)

This PR was merged into the master branch.

Commits
-------

74e2c5e Fix incorrect inheritdoc blocks

Discussion
----------

Fix incorrect inheritdoc blocks

Also add a docblock to stopwatch member variable.
fixed #5384
added a unit test
merged branch bamarni/console (PR #5689)

This PR was merged into the 2.1 branch.

Commits
-------

86503db [Console] added a unit test
3b2eeb6 [Console] fixed #5384

Discussion
----------

[Console] Simplified find method

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5384

It simplifies the way command or command suggestions are found, also fixing issue #5384.

It's a WIP I had, my plan was to also remove the original methods findAlternatives, etc... but some other methods are relying on them, so I'm sending it as it instead of running into more refactoring.

---------------------------------------------------------------------------

by bamarni at 2012-10-06T20:35:59Z

I've refactored some code, as you can see in the tests I've changed, the exception messages have slightly changed.

---------------------------------------------------------------------------

by fabpot at 2012-10-08T13:04:36Z

I don't see the point fo this big refactoring, especially if it also changes the behavior. I think a better approach would be to do only one thing at a time. But as is, this is not mergeable.

---------------------------------------------------------------------------

by bamarni at 2012-10-08T14:01:41Z

I'll try to fix this PR to keep the same behavior and error messages as it is currently.

---------------------------------------------------------------------------

by bamarni at 2012-10-08T14:07:43Z

Well if in fact there is only one bug, it would be better to patch the current code instead of doing this refactoring, even though I think the current code which finds commands is overcomplicated.

---------------------------------------------------------------------------

by stof at 2012-10-08T14:09:18Z

Well, in this case, please submit only a bug report for the 2.1 branch (or 2.0 if it is also affected), and then you can refactor the logic in master to simplify it if needed. But a refactoring should not happen in a maintenance branch

---------------------------------------------------------------------------

by bamarni at 2012-10-09T07:32:47Z

I've patched the code.

---------------------------------------------------------------------------

by fabpot at 2012-10-09T07:37:53Z

Can you add a test for the bug fix?

---------------------------------------------------------------------------

by bamarni at 2012-10-09T21:30:21Z

here you go
UnitTest fix

Check that the e-service initialized
UnitTest fix

 - no return value
[Console] Add DialogHelper::askHiddenResponse method
Fix tests and CS
[Console] [ProgressHelper] better percentage precision
[WebProfilerBundle] moved all static assets directly into the templates

This has been done for several reasons:

 * for consistency with the way we already manage the WDT icons;
 * it makes the WebProfiler independant from the location of the assets (and from the asset() function)
 * this is the very first step to make the WebProfiler useable outside the full-stack framework (more commits soon)

There is still one asset() call though, which will be removed later on.
[WebProfilerBundle] changed all includes to use the new Twig's notation
[WebProfilerBundle] avoid the usage of the global app variable
merged branch pborreli/console-progress-precision (PR #5735)

This PR was merged into the master branch.

Commits
-------

61be89d [Console] [ProgressHelper] better percentage precision

Discussion
----------

[Console] [ProgressHelper] better percentage precision

With this code :
```php
$progress = new ProgressHelper();
$progress->start($output, 50);
$progress->display();
$progress->advance();
$progress->advance();
$progress->advance();
$progress->advance();
$progress->advance();
$progress->advance();
```
The output was :
```
  0/50 [>---------------------------]   0% // float(0)
  1/50 [>---------------------------]   0% // float(0)
  2/50 [>---------------------------]   0% // float(0)
  3/50 [==>-------------------------]  10% // float(0.1)
  4/50 [==>-------------------------]  10% // float(0.1)
  5/50 [==>-------------------------]  10% // float(0.1)
  6/50 [==>-------------------------]  10% // float(0.1)
```
With this PR :
```
  0/50 [>---------------------------]   0% // float(0)
  1/50 [>---------------------------]   2% // float(0.02)
  2/50 [=>--------------------------]   4% // float(0.04)
  3/50 [=>--------------------------]   6% // float(0.06)
  4/50 [==>-------------------------]   8% // float(0.08)
  5/50 [==>-------------------------]  10% // float(0.1)
  6/50 [===>------------------------]  12% // float(0.12)
```
Tests are included.

---------------------------------------------------------------------------

by sstok at 2012-10-13T09:22:22Z

:+1:
Fix incorrect variable in FileProfilerStorage
merged branch merk/patch-4 (PR #5738)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #5738).

Commits
-------

894377f Fix incorrect variable in FileProfilerStorage

Discussion
----------

[HttpKernel] [Profiler] Fix incorrect variable use in FileProfilerStorage

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: ~
Todo: ~
License of the code: MIT
Documentation PR: ~

---------------------------------------------------------------------------

by pborreli at 2012-10-13T06:58:57Z

:+1:

---------------------------------------------------------------------------

by sstok at 2012-10-13T09:20:33Z

This should be done 2.1 as the bug also existing there.
[WebProfilerBundle] fixed typos
[HttpKernel] unified the way the traceable event dispatcher injects information into the profiler (closes #5733)
[WebProfilerBundle] removed dependency on the templating component
[WebProfileBundle] remove dependency on the DIC

The controllers are not relying on the DIC anymore and only Twig
is used for rendering (instead of the Templating component).

The Exception controller has not been updated yet as it relies on many
external dependencies (and other bundles).
[WebProfilerBundle] fixed typo