labofsahil/github-event-dataset-2012 huggingface dataset:
Can I suggest:

`alias fml="say 'Fuck this.' && open /Applications/Microsoft\ Office\ 2008/Microsoft\ Excel.app`
Please turn this and your other commit into one commit. It can be done with an interactive rebase. It would also help if you commit message was more descriptive. The git log should also be readable when GitHub isn't there.
Maybe it would help to pause req after line 13 and resume it after line 9 or line 10.
In other news, the documentation recommends `process.nextTick(a)` over `setTimeout(a, 0)`.
Torstein, all of the directories are wrong!!!  /optescenic  :-P
yes i did. i've ammended it.

On Thu, Feb 16, 2012 at 11:45 PM, Peter Ansell
<reply@reply.github.com>
wrote:
> Did you forget to add JenaJSONLDSerializer in this commit?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/tristan/jsonld-java/commit/b7d120df9b837a8ae0ba65e2a2b8d5a4a5921ed5#commitcomment-975746
Upss.. I see now that I misspelled "Content-Type decl" in the above comment. I meant the ContentType variable under [Definition] in s-w-l.conf.
things are looking really nice. good job, dude.
+1
I'm interested in this patch, and briefly read the commit.
But do we need to use memcache with SASL to prevent from connections from unauthorized apps?
Is the method type here dropped because of Java?
It might be better to use `do-auto-save` instead of `save-buffer`.
This line gives a syntax error.
I dont see a need for this. We use namespaced resources with this controller for months (i. e. languages) and dont have any problems. What us the reason for you to change this? Does your view have the correct form_for usage?
Windows compatibility, fix examples to not use depreciated functions and added visual studio solution file + project file for someone to build in windows from scratch.
Vale, pues gracias por las repuestas ya ire mirando de vez en cuando, un saludo.
I still have an issue with the code. I have 1 tile layer in the tile map with transparent tiles and nothing on the screen is showing up. I did some trace statements and turns out the test 
    if (tile < t.maxTiles && tile >= t.firstGid) {

fails because tile = 0, t.maxTiles = 180, t.firstGrid = 1. Also, tile keeps its value on 0, although the for look goes through many tiles. Any ideas?
Once again: Please remove debug code before committing...
FYI... before my modifications, this is what the tidy command's output looks like...

	D:\Users\dparker\test>tidy -utf8 --new-blocklevel-tags 'section, article
	, aside, hgroup, header, footer, nav, figure, figcaption' --new-inline-tags 'vid
	eo, audio, embed, mark, progress, meter, time, ruby, rt, rp, canvas, command, de
	tails, datalist' --new-empty-tags 'wbr, keygen' -e "index.html"
	Error: Can't open "article,"

	Error: Can't open "aside,"

	Error: Can't open "hgroup,"

	Error: Can't open "header,"

	Error: Can't open "footer,"

	Error: Can't open "nav,"

	25 warnings, 26 errors were found! Not all warnings/errors were shown.

	This document has errors that must be fixed before
	using HTML Tidy to generate a tidied up version.

	To learn more about HTML Tidy see http://tidy.sourceforge.net
	Please fill bug reports and queries using the "tracker" on the Tidy web site.
	Additionally, questions can be sent to html-tidy@w3.org
	HTML and CSS specifications are available from http://www.w3.org/
	Lobby your company to join W3C, see http://www.w3.org/Consortium

I think this demonstrates the painful quirk that cmd.exe doesn't understand single quotes properly...
a getter method could be better instead of accessing variables directly.
- Only place lines together that perform operations on the same object. 
- All log statements should be wrapped with a if (level enabled) check unless it's an error being thrown in a catch block
- as much as possible avoid compound statements (i.e. `IndexerRegistryUtil.getIndexer(document.get("entryClassName"))`)

```java
		String entryClassName = document.get("entryClassName");

		Indexer indexer = IndexerRegistryUtil.getIndexer(entryClassName);

		String searchEngineId = indexer.getSearchEngineId();

		if (_log.isDebugEnabled()) {
			_log.debug("SearchEngineId for [" + indexer.getClass() + "] is: " + searchEngineId);
		}

		return searchEngineId;
```

Note also that there should always be spaces between operands like + && || etc.
You thought I meant swap the assignments around? I'll be more explicit in future.
Note to self: from now on, run full build with closure before merging.
Patches welcome - in fact someone had said they would patch it  but hasn't gotten around to it - so please do JFDI :)
Do we have any tests for a gem dependency with a blank (empty string) name?
We need to remove it from the readme section on optional messages as well.
I don't like this much, but converting BeautifulSoup's input to unicode before processing gives the highest HTML compatilibity rate
This is not good fix as it raises more problems. Please check my comment on this issue:
http://code.google.com/p/cocos2d-iphone/issues/detail?id=1314#c5
Yeah, i think i'll do that when i come back from sleeping, though.
Huh? I am replying to this in an email. Let's see if it goes through.

On Fri, Jan 27, 2012 at 3:19 PM, Justin Drahl
<reply@reply.github.com>
wrote:
> Who put this space here?  Get on my level!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/JustinDrahl/My-Sandbox/commit/41fa03731638f10841cf84b5f9dff39eb524a05d#commitcomment-909755
Try to avoid inserting blank lines. They make it much harder to get an overview of the code.
word should be private, you shouldn't have accessors for it.

The other 3 should be attr_reader, because client code shouldn't modify them. They're supposed to be immutable, actually.
Nice catch, will help me!
We should be able to disable the use of the index on a per-test basis. Probably by providing a method on the model for disabling and one for re-enabling, if there are a number of tests that do this.
The comment should be:

// use reflection to support Play! <= 1.2.4

(not "... <= 1.2.3")
> Unfortunately that's a skin template rather than a view

I believe the AT base_edit form looks up a `@@at_base_edit_view` view in the TAL.  Maybe that could be used.
I'll quickly make the change so you can see how this can be done.
bah, failed at uncommenting :D
Yes
https://github.com/TrinityCore/TrinityCore/pull/4839
mmm. nope.
very good work. blizzlike
"that is available in the ``EntityManager``"

should be 

"which is stored in the ``EntityManager``".
FreeBSD -> &os; ?
*Same for me.
Opensource is about sharing own work, as we did and do. We're not obliged in any way to release updates since it's up to us, and it's of course a way to piss those stealers off. You should be angry with them, not to us.

(facepalm)
DB access *can* be slow. It’s not just variable assigning.
Sorry, it was a bit late last night. Thanks for finishing the renaming.
No. `foo.js` isn't a "valid" module identifier, per the Identifier class.

    TypeError: Invalid module identifier: ./my_number.js
        in /Users/rpatterson/Projects/number/src/app.js
The comment is not accurate, the return is needed if `decoded` is NULL. Please remove the comment or change it accordingly.
Some tips:

Remove eraser variations and use a Gtk.ToggleButton instead a combo box selector.
Then, combine rectangle + toggled eraser tool to erase with rectangle.

Eraser used in GIMP:
http://tango.freedesktop.org/static/cvs/tango-art-libre/16x16/tools/draw-eraser.png Public Domain
http://tango.freedesktop.org/static/cvs/tango-art-libre/22x22/tools/draw-eraser.png Public Domain

Scalable eraser used in Inkscape:
http://commons.wikimedia.org/wiki/File:Inkscape_icons_draw_eraser.svg GPLv2+

Move undo to primary toolbar, remove eraser separator and make palette toolbar style INLINE_TOOLBAR for a better look and feel.
Darn! Should have seen that one!
It's the fruit of a fair amount of efforts in joblib
I don't really like abusing primitive-wrappers like that...

([Using and avoiding ``null``](http://code.google.com/p/guava-libraries/wiki/UsingAndAvoidingNullExplained))
You can use 

    unless params[:order].nil?
      ...
    end

instead of `if foo != nil`
you could correct with git commit --amend and use a push force. I think nobody here will yell if you do a pushed force
It's probably a good idea to add -DDHD_DEBUG to the makefile and try again. I'm not sure what other configuration to use to build, just make sure that the wifi module name matches the version expected by the kernel.

I'll rebuild too and post the log, if it has any useful debugging output.
XZ module introduced in commit d108c86a55633b3b96e3030ba3518d375534caa6
There is a small spelling mistake in the name of the array key.
Finally no more errors in Eclipse, thanks! :-)
We probably want to move these *away* from `AndroidBrowserRepositoryTest`; they're supposed to be reusable for any kind of `RepositorySession`. That'll mean having the constructor take a `waiter` argument.
I'm so pleased to see that you are actively working on this, as I am trying to look at this for as an alternative to purchasing a commercial alternative to JBehave.  One of my organization's main pain points is the usability of Eclipse for non-developers trying to write and manage .story files.  When is your little girl turning 1?  I'm anxious to see these latest improvements.
simply remove the constructor totally :)
thanks for catching that - missed the hyphen in the first line
oh yeah
======
В плагине не нужен путь к интерпретатору. Лучше тут кодировку записать `# -*- coding: utf-8 -*-` http://www.python.org/dev/peps/pep-0263/
I just did push to heroku. Is it back up?
Hilarious, but this breaks the original intent. URI /validates/ you URI, making it impossible to correctly take in user inputted URIs and splitting it correctly.

I wouldn't have made this if something in the stdlib actually did what I needed already.
试试line notes
It is no longer needed to copy libaudio.so, libaudiopolicy.so and libcamera.so to target manually to make the source compile
?
On Jan 28, 2012 6:58 AM, "turl" <
reply@reply.github.com>
wrote:

> hm?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/photon-dev-team/android_device_motorola_olympus/commit/1fdaf999ae769cebef3480794f9cac01690dab20#commitcomment-910740
>
`:member_only` は `:manager_only` の方が適切だと思います。（というか typo ですよね？）
This create() is already in the trunk , not added by me,  but I found this create() is incorrect, so adding these 2 lines to make it work. I agree don't override it , but implement save().
in that case, the method in superclass is going to be empty, and it will not be obvious that  it should be overriden is sublcass.
true, I'm not sure how I've put that up but I thought it was based on a jQuery test (it was late ;) ), but now running a similar test proves it wrong:
http://jsfiddle.net/HTYmZ/

So indeed if we fire a.b.c it should only trigger the items that are  tagged with each of those (and possibly more). So for example a.b.c.d as you mention
I'm not sure I like this behavior.  It's pretty harsh for a public method.  Why not just return a Boolean result and let the callers decide if an undefined state is an exceptional situation?  Alternatively, if this is only going to be used as an internal helper routine (as the rest of these changes indicate), it should be marked private.
Ok, will do. Note however that the contents of tests_elgg were not revised and thay may also be outdated due to changes in the tests.
Sorry. What I was trying to say was that the `var target: ActorRef` is only there to test the code. It is not visible in the doc.

I couldn't come up with a better solution to not pollute the code that is in the doc.
yes, since consistent-hashing isn't in master yet, so I will change once it is
((key,values))
same comment here regarding preRestart and postRestart
I think HeadActor needs a new and more badass name. "Robert"?
Should it overwrite the old silently? Should the new one replace the old?
Yes, in 2.1 and forward it will be, but in 2.0 that tag did not exist. And I think we should keep it as LongRunning (because long running is exactly what it is ;-) ).
Most changes are this one to have a more generic to_ method, to_name_logic didn't seem right.
pep8 tool in kivy is very outdated, current version in PyPI is 1.3.3.
@tobes I added the month in deliberately... because I wanted to take only the latest data as a base and there was no way to link to the most recent month. Perhaps it might be better to base it off a better URL.
I fixed up the descriptions of the required packages, including build-essential
is this correct? looks like it will return all activities am I missing something?

Also this looks like it could quickly get expensive if I'm following may groups with lots of datasets but maybe we should wait for that to be a problem before looking at optermising as this at least is readable.
Not at all saying this is incorrect, but out of curiosity, what's it do?
I'm confused about link_type / ref_type.  I thought we'd changed it to ref_type everywhere, which I thought made sense except in one context (link.rb, where it had a different meaning).  now it's gone?
inline method?
After a forced query: g_xrandr.Query(true) GetCurrentOutput returns the current resolution. Isn't this desktop resolution?
Hmm, no. I'll merge it and then test it.
Not that it's incorrect but it seems strange to pass the same argument twice.
Minor issue but it would be nice to have a short introductory description in the DocBlock.
But shouldn't that work as-is? You're using `proc`/`lambda`, the same way we naturally would when defining AR scopes like this, and I don't think that is at question here. Your initial question was if there might be a use case for passing some arbitrary object for `:as` -- that's what I'm asking, for a (hypothetical) example of how you could imagine that being used, sorry if that was unclear. I'm not aware of any analog to that in AR scope definitions.

@mauricio hasn't changed anything about Tire's existing ability to handle procs/lambdas here, he just wants to bail if given something else that we don't know what to do with. That seems sane and doesn't lock you out of later accepting something else if you came up with something that would be meaningful.
Very true. Also ideally the average user should never see this message. It's mainly there for the developer.
what is the 0x0 to represent? is there a macro that should be used instead?
or maybe create a separate function to contain this messiness? :)
Is there any PSR rule that I'm missing here?
All category methods should be prefixed for consistency.
^ Agreed, as above. I was just making things API-compatible.
Style: gid_t*
By the way, this file has grown way beyond setting hooks.  How about z_csharp_helper?
http://stackoverflow.com/questions/7745867/how-do-you-get-the-cursor-position-in-a-textarea
Something like this?

```javascript
    init: function(target) {
        gxp.plugins.FeedGetFeatureInfo.superclass.init.apply(this, arguments);
        this.target.on("ready", function() {
            this.target.mapPanel.layers.on({
                "add": this.addLayer,
                "remove": this.removeLayer,
                scope: this
            });
        }, this);
    },
```
Can you please move this require to each model that uses it instead?
The `assets:precompile` task writes to stderr on failure, so `out` won't tell us what happened:

bundle exec rake assets:precompile >/dev/null
/usr/share/ruby-rvm/rubies/ruby-1.9.3-p194/bin/ruby /usr/share/ruby-rvm/gems/ruby-1.9.3-p194/bin/rake assets:precompile:all RAILS_ENV=production RAILS_GROUPS=assets
rake aborted!
Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes.
  (in /home/user/projects/rails/railties/tmp/app/app/assets/javascripts/application.js)
@spastorino @header['X-Frame-Options'] ||= nil 

rescues
```

Internal Server Error

undefined method `split' for nil:NilClass
```
anyway, We don't need to send x-frame-options(nil or anything) if we don't have this in config
The +debugger+ gem can automatically show the code you're stepping through and reload it when you change it in an editor.
Good idea.  Hope people see this.   If onyl we had a "example code" section for Partest...
The magic of code reviews ;). Are you taking care of this after the merge?
You could just move things around a bit and say:

This class provides the basic mechanics for Stream Interpolation. String Interpolation allows users to embed variable references directly in *processed* string literals, for example:

    val name = "James"
    println(s"Hello, $name")  // Hello, James

Any processed string literal is rewritten as an instantiation ...
This fails for leading spaces in filenames. I added the "?" because the spacing in all my use cases was consisting (0 or 1). If there are instances where this will not be the case, I'm not sure how you'd address filenames with leading spaces.
This method is not used anywhere.
nessted -> nested
How about just call it `dual`? It's a method of a Matrix so that part of the name is redundant.
On 11.06.2012 15:32, Christopher Smith wrote:
>> +.. autofunction:: sdp_add
>> +.. autofunction:: sdp_sub
>> +.. autofunction:: sdp_mul
>> +.. autofunction:: sdp_sqr
>> +.. autofunction:: sdp_pow
>> +.. autofunction:: sdp_monic
>> +.. autofunction:: sdp_content
>> +.. autofunction:: sdp_primitive
>> +.. autofunction:: sdp_div
>> +.. autofunction:: sdp_rem
>> +.. autofunction:: sdp_quo
>> +.. autofunction:: sdp_exquo
>> +.. autofunction:: sdp_lcm
>> +.. autofunction:: sdp_gcd
>> +
>> +In commutative algebra, one often studys not only polynomials, but also
>
> studys->studies
>

Ok this one is embarassing ^^. Thanks.
Actually this current implementation never uses `symbols[0]`, does it? Is this intended?
soo previous docstring for format comment
corrected in f4c82ae
I think we can remove that function
Apache and Nginx are not WSGI servers. Apache can act as one with the optional mod_wsgi, Nginx can interact with uWSGI using the uwsgi protocol (uWSGI being the WSGI server and uwsgi the communications protocol).
Add a ruby after the three quotes, to this so it colorizes the markdown.
Please, truncate lines to 80 characters
I think these two methods should be combined into one `-prepareForReuse` method (similar to `UITableViewCell`) which is invoked only when the cell is actually about to reused (not just removed from view).
I'm absolutely ok with that. /cc @bnoordhuis @piscisaureus
If file is not there it would not be used.
I think it is good to set a defualt value to this parameter (help to orginaize the execution in our dirs structure) under .bbgs
i dunno?
What is the expected result of `WindowRefiner.forPeriodExpression("P1D").refineInterval(null, "2012-10-10")`? Could this not be put into the test function as an assertion?
the 2nd line edited.
my bad, i have fixed it. thanks
Event list is here: http://wiki.phpbb.com/Event_List
If you know of a better way of explaining the an array like the following please share it:
`'allow_avatar'			=> array('lang' => 'ALLOW_AVATARS',			'validate' => 'bool',	'type' => 'radio:yes_no', 'explain' => true),`
Should type hint to ContainerInterface.
Error catching ^^
![Russell Image](http://i.imgur.com/Ros5k.png)
fixed in 71a02fa
Added a sphinx-incremental option (off by default) to enable the normal sphinx building, without the -a -E options.
I went and made a nice helper method only to, upon further research, discover that "clazz.getCanonicalName()" is the value I want.
No idea, this was in the previous version of the code too.  I can remove it if desired.  I'm pretty sure it's not being used anyways.  (The fixtures are only used for unit tests, and the one unit tests which loads gsg5-appConfig doesn't test for "foo".)
The `callback` method is to a function that's internal to commands/compile.js, and it always passes the callback.  Guard still needed?
Лучше this.units_stat = {};
They may not be necessary, but cartopy assumes degrees and I see no harm in ensuring this assumption is correct. Note that these lines are used everywhere following ```_get_lat_lon_coords()``` elsewhere in the codebase.
The cube merging section doesn't actually say a lot. Perhaps something along the lines of:

```
* Cube merging has been re-written for the new CF datamodel with the benefit that some corner cases are now better handled. 
   Some users may find that their cubes, once merged, now have a smaller total shape and more intelligent handling of dimension coordinate picking.
```

Although I do not profess that this is perfect.
This is required by **iris** (you added the dependency in ```docs/iris/src/_templates/index.html``` when you removed the basemap dependency).
Maybe should throw an exception?
``type`` is a Python _builtin_ and we should avoid using names that are builtins as variables. ``cost_type`` might be a better name.
Use enumerate()
Fear Movement wasn't disabled during wrath on live realms, dunno where you got it from.
I had looked at the wrong test_results.  :+1:
Oh right. It could live as a protected table. Probably just copied over from the original mem3_cache.erl as this is partitions renamed.
Merged our text for the betterment of Djangosphere.
actually i copied the license and the $id$ part from Doctrine\DBAL\LockMode - but sure i'll fix it
I agree, but I prefer `parse(T, s)`. It is closer to Haskell parameter ordering style (where partial application is possible: `parseInt = parse Int`).
`.call( arguments )`?
This was an accident with ctrl + f. I reverted the others but forgot about this one :(
You should make sure any possible ERROR being in PG_TRY() block without C++ try block.
We can change or add comments in code refactoring. I think this issue is not closely related with this defect. 

Let's resolve it in a separate thread. OK?
Intuitively, this seems fine. But I have done no testing. I added a

    // FIXME: Add some justification/do some tests.
You removed my workaround. I guess there is no more problem with the python bindings, then?
This can now be:

    depends_on MPIRequirement.new(:cc)
Maybe we should just add a `--quicktest` option to do this?
Use the full path to the executable: `"#{bin}/duti"`
Order should be `homepage`, `url`, `sha1`, `head`.
mri_surf2surf has some way to map from an (approximate) fwhm specified in mm to number of smoothing iterations.  Would that be feasible to bring to the smoothing algorithm we have to give a more intuitive parameterization of the label generation? (and the smoothing itself I suppose)
This is just so that the tag we add here is that same as the tag we get after doing json.loads(json.dumps(msg)). I'll add a comment.
This function itself doesn't generate the listings. Maybe it would be better to say

"Produces various Submission listing functions."

This might be appropriate for _get_section too as it is used to generate functions.
Represent! :)
i don't like the "an error occurred" type of error messages, even though the message is actually printed. i find it better to write: "Failed to setup project: " + error message as before.
Hmm.  Good call.
I'm struggling with this naming myself.  I just named what it does.  And in reality, it's not a plugin that needs to use generated code.  It just needs compliant and appropriately named code.  So... I named it for what it does.
Perhaps include a logger message a la syncManager to indicate which services are teed up to post.
That shouldn't be there

As go for all these start and end of class newlines, I'm not copying and pasting this anymore.
Shouldn't it take varargs for Object in setText then be

ChatStyle.BLUE, "Sp", ChatStyle.WHITE, "ou", etc

Because that's what is is everywhere else, unlike in Bukkit where ChatColors were just string codes really.
Yes, that's why I wanted to avoid it. I expect $("*") to be really slow.

I think I've found a nice solution that could work creating a transparent div just for the resizing operation. I'll put together a pull request and then we can discuss it there.

Thanks for the support!
Good point. Originally I thought we needed to let keyboard events generally bubble so our global keyboard handler would still get keyboard shortcuts. But I think we have a capture handler for those, so we should get first crack at those anyway.

That said, we should probably wait until we merge with v3 to revisit this--we will probably need to do a more general fix then anyway because the parentage of the inline widgets is different.
change to $parent
Renamed as following:

proxy/ -> nativeProxy/
proxyServer -> nativeServer/
Proxy.js -> NativeProxy.js
ProxyUI.js -> NativeProxyUI.js
Yes, please do change them if you don't mind.
Seems like this could just be `var overrides = arguments[1]`
Done. I usually use this approach but this one fit on my screen as one line so I had let it go.
No.  pymacs-load-path defines additional search path only for Pymacs.  Pymacs's Python process mixes PYTHONPATH and pymacs-load-path internally and then search modules from there.  So, adding the path instead in PYTHONPATH is fine.  The only difference is that, before this patch, you cannot import rope module in other Python process.  For example, let's say you start python by `M-x shell` then type python in the shell inside of Emacs.  In there, if you type "import rope", you can't load the rope module so you will get import error.  If this patch applied, this actually works.  It is good for traad because traad needs to import rope.
Could you please explain what's going on here? It sounds like `conditions_met` should cover these scenarios.
It may be meaningful to log something if the file can't be added. Indeed, the user may wonder if something wrong happen. So let's say him that the file is not a recognized source format.
I don't know if that was legal but anyway I don't use that class anymore,  I made a new class with a lighter version of the method I needed
調整位置的 class 往上提一層
```haml
.pull-left
  %button.btn-remove
```
`giterr_last()` returns a pointer to the struct, not to the error string. What you want to print is `giterr_last()->message`. You'd also want to check that `giterr_last()` doesn't return NULL (it shouldn't be if a function returned `-1`, but bugs happen).
Some checking could be done here? Like that it cannot be in the future?
"new" projects shouldn't have an id
what about the display = "block" in start?
Can you put this where the event is actually dispatched? No reason to separate them, right?
How about "Ensure the loading spinner is off when the media is ready. Otherwise, keep it spinning."?
Lets make these one-shots, so the user doesn't need to wait for S3 to respond.

```
stores.publish.remove( embedShell );
stores.publish.remove( embedDoc );
res.json({ error: "okay" });
```
That bastard! We should probably leave it up to him to fix it then.
This is a good idea, as we may need other information in the TimeStep object. I will change that.
if (bUpdatePending)
please call the epg manager explicitly too here, and below when starting it.
this line isn't needed anymore
you can just set the boolean here, no need to compare it with the previous value first
thx! Will update shortly.
Indeed, kwargs and perhaps some magic with the inspect module will also help quite a bit with the ``salt shell`` prototype on my desktop that hasn't been published yet.
Add these comments before this function:

    /* 
     * Nginx doesn't supply such delete interface. We have tried to avoid to copy the memory. 
     * But there are too many obscure bugs with that solution. You shouldn't use this function
     * too heavily while it may hurt your performance.
     */
Is github also showing the indentation wrong here? It looks like there should be a whole pile of code indented another level, if you're adding a set of braces.
I'll update. Can you explain why this is not used more often in other places?
I believe even the AXFR/notify code doesn't use it...
Mixins are a perfectly legitimate way to separate concerns in code. I'd say let's do w/e is easier to test (and loading a class definition is not going to be an issue, even if we do this on *every* test. we're db-constrained in a *huge* way).

Technically, during testing, we should only need orchestration code when we are testing orchestration.We can load appropriate modules then, and unload them afterwards.
yes, this is a little bit hidden, https://github.com/Katello/katello/pull/241/files#L36R148. If notifier does not have controller, it cannot send any data to flash so it must store it to db (aka async).
Really? I would have thought `delete` would be appropriate for an object whose properties are more bona fide dynamic, but in this case, it feels more like something that shouldn't change the object's structure.
Yes. I was planning to talk to you about this. The initialize_cluster method takes two parameters g_pss and s_pss or something on the cloudman server. But it only uses one of them at a time, which means we can reduce the two parameters to one.
Shouldn't this field really be an origin? (e.g. http://gaiamobile.org:80)
Right, this should be removed once `isiterable` from #240 is available.
Indeed.  I think the "extra" is a typo -- sort of redundant.  I'll fix this in the docs.
fixed - very good point, thanks for catching it! this isn't actually used directly anywhere, but it still should be correct.
作为不是每天用的功能，我还是喜欢key，用顺序替代key这个约定是否太强了？
Not an estimate.
Ah I get it. I guess you want to store the time when the ClientModel is created. Better to add a QDateTime field to the structure, fill it in the constructor, then return that?
5 minutes seems like a long time for a default jitter value.  Wouldn't 1 minute work just as well.
If we're going to comment out variables, we should just delete them altogether.
We've just lost every non-Rubyist. I hear complaints about this all the time.
This is a good description to be put into a comment.

On Fri, Jun 29, 2012 at 4:13 PM, Anton Salikhmetov
<reply@reply.github.com>
wrote:
>>
>> -{WORD} return WORD;
>> +{WORD} {
>> +     /* Token value is the matching string */
>
> The `yylval` variable represents the token value. This variable is external variable for the lexer and is defined by the parser. Technically this variable has the union type. That union's fields are defined by the `%union { ... }` statement in the parser.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/euromake/uniweb/pull/7/files#r1075739
The API already uses commas as the list separator, so I don't think it's an issue.
No, that looks like pure screw-up on my part.  Thanks for the catch.
Sounds good, will do that.
Hmm, that's unfortunate as well.  Too bad there isn't a function which would do both shell splitting and globbing.
How should it be handled in your opinion?
`$HOME/.config/git/config` is just the default location for xdr, actually it's %XDG_CONFIG_HOME%/git/config.
These javaesque lines hurt my eyes.
```python
while True:
```
:)
Fancy Pants :)
Here you could directly catch the exception Elastica_Exception_NotImplemented, so all the other ones would show up in phpunit as a fail.
this is wrong :)
you only need to count interfaces on the `$class ` not on its parents

```
<?php
interface I
{}

class A implements I
{}

class B extends A
{}

$refl = new \ReflectionClass('B');
// $refl->getInterfaces() contains 'I'
```
这我就有疑问了，你原本的意思是将第四章作为一个用户可以copy的源代码文件，如果连基本的黑体、加粗等都不给用户，用户需要使用强调的地方，找不到相应的示例，那他应该查阅什么资料？他怎么知道所查阅的资料能够兼容本模板？那这章除了介绍插图插表格，列代码，数学公式，就不需要别的了？
Please add the doc, in particular for the use of the two min max values of the display
You should at least close opened file and delete any dynamic allocated buffers.
as a general rule, to improve readability, please add an explicit template tag name. thanks.
`The dashboard will show`
Ping @cedriclombardot, I told you.
Why is it loading the module to print a debug message? Is this unintentional debugging code?
This deserves a comment. Why do you need the position checks?
I realize the whole thing was copied from accordion, but accordion and tabs have different concerns. This is not related to the `heightStyle` option, it's related to simultaneous animations that need to be equalized and jumps due to fractional pixel rounding.
There's four more of this below.
好嘛，如果能拿到说明应该两种都支持，这样比较好。
你改完直接merge嘛。其他不得问题
hmm why globally?
What are the use cases for this “buttons-list” class? (btw, I think it should be “button-list” in English)

This adds another arbitrary class name, it takes ~40% of the CSS stylesheet and I’m not sure to the the point.
Add these to the `visible` CSS class.
mockMobileConnection (coding standards)
Please add a space before each !important statement so I can merge it. Thanks!
if messages is an array, can we do:

messages.forEach(ThreadUI.appendMessage);
After discussed with Kanru, he think the idleService should keep current 
behaviour. Since idle mean "no explicit user input", that means phone 
call, alarm and any remote user activity should not count as a user 
interaction.

The early idle fired since the idle count from last time user 
interaction but when you register it. As a result, we have to count the 
time ourselves in such condition. And use the action event as an 
implicit notification about user interaction.


於 2012/10/31 下午 04:55, Timothy Guan-tin Chien 提到:
>
> In apps/system/js/screen_manager.js:
>
> > @@ -93,6 +94,14 @@ var ScreenManager = {
> >
> >      // When idled, trigger the idle-screen-off process
> >      this.idleObserver.onidle = function scm_onidle() {
> > +      var idledTime = (Date.now() - self._idleRegistrationStamp) / 1000;
> > +      if (idledTime < self.idleObserver.time) {
>
> This looks like a workaround to me. Have you find out the cause of 
> this early |onidle| filing? Is this really a expected behavior of the 
> Idle API?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/mozilla-b2g/gaia/pull/6102/files#r1989480>.
>
Yes, the github unified diffs can be much harder to read than the side-by-side diffs of bugzilla, etc.  I think this is pretty much it because all the other changes are new strings or the string names were restructured to eliminate code.  Namely, I started using the built-in support for HTML node attribute setting for "placeholder"s, whereas previously we were manually loading and applying those.
This is a valid clean up :)

Yes, system app, as the embedder of the app iframe, can do this.
nit: ... `we just compare SSIDs and capabilities to tell wether`...
Compact those with `else if`
Same for all strings in the source code :)
I only exposed one method: `showHomescreen` :). Which does what the old `setDisplayedApp(null)` used to do.

Anyway, I am ok with hidding this methods. `setDisplayedApp` is also currently used by `system/js/bootstrap.js` within an eventlistener (https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/bootstrap.js#L68). That in fact tries to show the homescreen with the old `setDisplayedApp(null)` that, if I am not wrong, doesn't work anymore. I'll need to move that listener to the WindowManager code. Is that ok with you?

Thanks Vivien.
We can set an icon at the beginning (default) or at the end of the button, we need to support both choices
Also, now that I try again, I can't seem to get anything for `element.style.margin`, `element.style.marginTop`, or `element.style.marginBottom`... Which I think is because it hasn't been calculated yet, or something `*handwaves*` not sure
Ok then, so the pending deletion basics will be added within this pull request (next commit), and then you can move it to messageManager.deleteMessage :)
Remove L25-29, we don't need to handle data, it will be turn off magically when `ril.radio.disabled = true`.
CArd -> Card
Workaround there
Don't you want to consume the event? (evt.preventDefault())
Supposedly not, but I've been playing with the shared js and I can't get it to work.

I replaced this script tag with 

    [script defer src="shared/js/l10n.js"][/script]

(with pointy brackets) then ran the make file but it doesn't working.

What am I doing wrong @vingtetun ?
We already set in Utils.js. There is no need to declare again.
This code should be tracked differently Check this very related code.
Can you use the default Executable class. It's a helper we use for launching exe.
@filipewl, font-weight changed to 300. 55832fccea
I think we should, because the error message is part of the contract of the class. Also, we are only interested in the error that thrown by Ember.required if you just check for "toThrow" it can pass with any exception, also like ```ReferenceError```or other stuff that can be wrong ;-)
Wow, really beautiful.
```coffeescript
o =
  if condition
    hurr: durr
    herp: derp
  else
    durr: hurr
    herp: derp
```
You'd have to do

```coffeescript
unless g.REPLY
  if g.BOARD is 'f'
    filetag  = QR.threadSelector.value
    threadID = 'new'
  else
    threadID = QR.threadSelector.value
else
  threadID = g.THREAD_ID
```
You could attack board and thread ids in the parent's open() to the post so that you don't have to select the anchor and split its href for each type.
Make this a c-style comment.
e.g., /* ... */
We've been working towards not having magic behaviour for step arguments, so I am wary about adding more such behaviour, particularly for an existing parameter.
how about `addBuildSetForSourceStampDetails`?
@cordoval the ``update`` command does not add anything to the composer.json file. It *reads* the composer.json file and update the deps
Man, I've just noticed another annoying issue. IE7 won't trigger the 'change' event when you click on another radio value until it looses focus :(
In the next commit where you clean up some of the existing code, you'll have to take lines such as `curr_spd = cap_entry->owner;`, and instead use the `curr_spd` variable we already have...

I think you should go this next step, then I'll integrate into the main code-base.
direction and state
src/ygdkmngloader.c:133:11: warning: variable 'error' set but not used [-Wunused-but-set-variable]

just using "error" somehow (not really senseful) make the compiler happy about the warning.
Nit: The leading asterisk is misaligned.
Yes. Missed in the refactor, and works in practice due to scoping.
I personally find this naming confusing. `self` is usually always `this`. If it's not going to be, than a better name is probably warranted: `state`? `currentState`?
This method returns true regardless of what happened. Should we be checking that the key is actually created successfully?
Can we define this type of Error as a new Error class? We could do it similar as what we wanna do for the mozmill-tests API refactor:
https://github.com/geoelectric/mozmill-api-refactor/blob/master/lib/api/errors.js
Yes please. It applies to a couple of snippets. Generally I would even prefer a switch statement.
I KNOW. But I kept getting errors when importing certain bugs, so I just jacked it up. AFAICT from what I can find in BMO code the whiteboard is a MEDIUM_TEXT field. I'm not sure exactly what that means, but people can put a whole lotta crap in there :(
ですね、ちょっと手元でやってみます。
We made the addition to `libs` rather than `rdoc` because the OS packages [explicitly exclude](https://github.com/puppetlabs/facter/blob/master/conf/redhat/facter.spec#L41) the rdocs and we need to make sure that we include the license for vendored code when we deploy.
Why not structure this data as:

````
   fingerprints: {
    SHA1: "....",
    SHA256: "....",
    SHA512: "...."
   }
````
It is almost certainly better to just call the function, and catch `MethodMissing`, to indicate this problem.  That ensures that you are not checking for something that might change under you.  So, instead of pre-checking that is a function, then calling it, just call it and catch MethodMissing to decorate with a better error.
`LIB_EXT` is public api and shouldn't be removed. If Library is the only thing in node-ffi using it, then it can be defined there, and re-exported in ffi.js if you want.
Actually I take that back I think your original idea was fine, since I asked you to change this I'm rolling it back.
Import ReflectionFunctionAbstract.
Actually, on investigating this, we already have a "RenderListener" -- it's the DefaultRenderingStrategy. What we need to do is treat this like we do dispatch and route: push the exception handling into these default listeners (I use the plural, as we have both Console and HTTP variants). I'm tackling this now.
First of, this should be a separate PR. Second, I'm against this at all. What I'd agree to though is that a check should be made that a string is actually returned.
No spaces inside the brackets
Same spacing inconsistency...this seems to be in several spots so I'll just comment here.
In my environment this code runs fine even if the bundler gem has not been installed. This code is btw merged into master and is not part of this pull request.
The following is failing when I change to using overrides that explicitly
have List as the type of the parameter

def test_listDerived(self):
        class List(list):
            data = []
            def insert(self, index, item):
                self.data.insert(index, item)

        lst = List()
        self.module.insort_left(lst, 10)
        self.module.insort_right(lst, 5)
        self.assertEqual([5, 10], lst.data)

It seems like either insert or Insert on List doesn't call a Python
subclass method.



On Fri, Mar 16, 2012 at 10:51 PM, Dino Viehland <
reply@reply.github.com
> wrote:

> > +using IronPython.Runtime.Types;
> > +using IronPython.Runtime.Exceptions;
> > +
> > +[assembly: PythonModule("_bisect",
> typeof(IronPython.Modules.PythonBisectModule))]
> > +namespace IronPython.Modules {
> > +    class PythonBisectModule {
> > +        public static string __doc__ = @"Bisection algorithms.
> > +
> > +This module provides support for maintaining a list in sorted order
> without
> > +having to sort the list after each insertion. For long lists of items
> with
> > +expensive comparison operations, this can be an improvement over the
> more
> > +common approach.
> > +";
> > +
> > +        #region Private Implementation Details
> > +
>
> You can still use overloads to achieve what default parameters would, or
> you can use DefaultParameterValueAttribute explicitly.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/IronLanguages/main/pull/60/files#r571161
>



-- 
Website: http://earl-of-code.com
I think that: `d-m-y H:i:s` will be enough.
Use StringComparison.OrdinalIgnoreCase here instead of ToLower. Regular + instead of String.Concat
Įveskite buto numerį.
activemq_home includes the version number:
https://github.com/RiotGames/activemq/pull/1/files#L2R28
Surely this will set the wrong namespace every time as AbstractModule...
why the nofollow`s?

we don't mind giving credit to frameworks
For what purpose this method is?
typo: "installation"
@harjis Aika tiukka. Aika harvalla asiakkaalla taitaa olla myyjanro setattuna? Onko tosiaan speksattu niin, että vain ne asiakkaat joilla on myyjä setattuna saa tulla mukaan?
Also these two classes are explicitly tailored at SQL generation in the persisters.
these are not errors
I think you should add a test-case for the lookup option.
The newline between the two selectors could be removed, but that's all that could change, AFAIK.  I had just lined it up like this for formatting.
Maybe not, but it feels cleaner this way.
Pretty much everywhere here ...
Indentation. My bad, it seems, according to blame :-p
`return $request->query->has('code');` ?
This should be: `$this->generateUrl($path, array(), true);`
This would cause an extra periodic update loop each time the calendar settings were changed.
both could be changed, am I right ?. Do you want a pull request for this ? ;)
Nit: should be indented one more space to line up.
Yeah, that third-party validator module that's included is way too strict. I actually have a regex that I use pulled from this test suite here: http://mathiasbynens.be/demo/url-regex (@stephenhay's 38 char masterpiece, which passes all of the good ones and fails most of the bad ones). https://github.com/mozilla/openbadges/blob/development/lib/regex.js#L1

We should eventually replace that with this, but I wanted to limit the scope of this fix.
There is a [December 2010 announcement](http://www.php.net/archive/2010.php#id2010-12-16-1) that support for 5.2 stopped. There is only one release in 5.2 after which addressed a critical security issue. That's roughly two years without releases.

I think your app is a compelling reason for webhosts to update. :-) Add to that, there are plenty of webhosts which install 5.3 so in the end, they would not get the business.
You're right. I'll revert the commit on my fork and tidy it up. Can you just ignore the pull request for this particular commit?
Thanks for the feedback. I changed the labels to be more informative. Let me know if there is anything else missing.
in this case, won't api_version be v1?
port actually has a default afair
Ah gotcha, can you move it to just after `def check_versions(dir)`? This way it will only be loaded when really needed :)
Use a div around the graphie and the paragraph hint to make this into one hint
You could have modified it when you merge it. Basically just copy past the code which was deleted. And juste to quote you :  (LE: And to clarify, VIPs do not have custom armor...)
ipv6=None ? :)
вместо -1, 0, 1 нужно использовать enum, так как не ясно, что что значит
Hi David,
I made the changes and it is necessary to use the option MANY LOOKUP for
the reason explained in the previous mail. The FEW options works as well so
I'll change the order too.

Regards
Victor

On Tue, Jun 5, 2012 at 4:43 PM, Victor Herrera Cordova
<vherrer1@my.fau.edu>wrote:

> Hi David,
> Yes, we can use a LOOKUP FEW. In addition, since the recordset CTots is
> smaller than AttValues and for each record in AttValues we expect the
>  number of CTots records that match the JOIN condition to be the number of
> class values (at least 2 when binary classifier), It would be better if
> change the order in "ATots:= JOIN(CTots, AttValues, ..."  to
> "ATots:=JOIN(AttValues, CTots, ..."  and use MANY LOOKUP FEW?
>
> Regards
> Victor
>
> On Fri, Jun 1, 2012 at 6:17 PM, David Bayliss <
> reply@reply.github.com
> > wrote:
>
>> > +                     // Generating feature domain per feature
>> (class_number only used when multiple classifiers being produced at once)
>> > +                     AttValues       := TABLE(Cnts, AttribValue_Rec,
>> class_number, number, f, FEW);
>> > +                     AttCnts         := TABLE(AttValues,
>> {class_number, number, ocurrence:= COUNT(GROUP)},class_number, number,
>> FEW); // Summarize
>> > +                     AttrValue_per_Class_Rec := RECORD
>> > +                             Types.t_Discrete c;
>> > +                             AttValues.f;
>> > +                             AttValues.number;
>> > +                             AttValues.class_number;
>> > +                             AttValues.support;
>> > +                     END;
>> > +                     // Generating class x feature domain, initial
>> support = 0
>> > +                     AttrValue_per_Class_Rec form_cl_attr(CTots le,
>> AttValues ri):= TRANSFORM
>> > +                             SELF.c:= le.value;
>> > +                             SELF:= ri;
>> > +                     END;
>> > +                     ATots:= JOIN(CTots, AttValues, LEFT.number =
>> RIGHT.class_number, form_cl_attr(LEFT, RIGHT));
>>
>> AttValue was computed using ,FEW - does that mean we can use a ,LOOKUP
>> here?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/hpcc-systems/ecl-ml/pull/120/files#r918019
>>
>
>
I know this is trivial but:
can we move this here https://github.com/teodosia/Addon-Tests/blob/ae2df3c2dc67038810a45ed6365aa082623d2669/pages/desktop/regions/paginator.py#L57 
the methods fallow a paten that replicates how the elements are available on the page

thanks
multi-line param.
Needs some docs.
This should be Comment[]
Can you document this function a bit better? It might be worth documenting the format of colHash as well.
Why is the ``try`` used here? I feel like I'm missing a slice of the pie :-)
Instead of doing substring math with hardcoded string lengths, you should set up some sort of word splitting thing.

start the command parsing by doing `text.split(" ")` to split on spaces, then make sure you get "houndbot" and "boot" as the first two words, then you can compare the third word to usernames like this.