labofsahil/github-event-dataset-2012 huggingface dataset:
Glad you like it. I recommend just leaving http-server out for now. It's
better suited to being run globally. I also like mocha running globally but
I want "npm test" support.

I have ideas for test improvements too.
On Jul 6, 2012 7:19 PM, "Casey O'Hara" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,13 @@
> > +{
> > +  "name": "retina.js",
> > +  "version": "0.0.0",
> > +  "publish": "false",
> > +  "devDependencies": {
> > +    "mocha": "*",
> > +    "should": "*"
> > +  },
>
> Should we also add `"http-server": "*"`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/imulus/retinajs/pull/27/files#r1117760
>
I suspect Python 3 linecache will take care of decoding `lines` for us, and this will go wrong.
I don't understand, isn't this coupling precisely the issue this PR is meant to resolve?
No, not really.  Here is a summary:

* For the most part we are following Python's PEP 8 standard, so our devs can use one standard for coding in both JS and Python.
* But there are many things in JS that PEP 8 doesn't cover.  For those, we have decided on an style, and started to use it semi-consistently.  We have not documented it, but just have a look at some of the other .js files to see what it looks like.
* These things are evolving.
`length() > 0`?
I guess we could put position absolute attribute into the css file?
your default dvrWindow won't be used. you should have: 
```
embedPlayer.evaluate( '{mediaProxy.entry.dvrWindow}' ) || this.dvrWindow 
```
This method does the grouping your speaking of and the expansion of recurrences. Events that do not recur will be returned in the final result but not used to create instances of `RecurExpansion`.

The output is an object where the key is the events `UID` and the value is either a component or instance of `RecurExpansion`.
This api works for my purposes with CALDAV but it could be _really_ bad for huge ICAL files with a bunch of unrelated events.

I am mostly happy with what this code does but not with the API, I am back now so I will make another proposal soon. I need to get this over and landed in gaia in the next day or so to meet other commitments so I am willing to land something there first then come back to this to get the API right if we can't find the right solution in the next day or so.
well, *we* install simplejson in kpython - but yeah, good idea :)
```python
from contextlib import closing

def post_to_url(message, url):
    with closing(urllib2.urlopen(url, json.dumps(message))) as handle:
        response = handle.read()

    return response
```
tap always the returns the input back as output , if the input was not a function

so this if (key) check may be redundant
Looks like you're no longer skipping over errors, and if registering a meter fails, startup will fail. This is not the previous behavior, are we sure this won't break anyone?
If you look at the tweet_template, the default text is "giving the Firefox 4 beta a whirl" which makes this test fail. I think you need to set the text to something different that doesn't include the word "firefox" in it.
The actual URL is ``/products/(.*)``, ``versions`` is just a parameter.
I replaced it with this that no longer creates a second vector (I believe one is required though).  I believe it is equivalent:

```
return this.orthoPoint( point ).subSelf( point ).negate();
```
Here I think `chef_wm_authz:is_requesting_user` would be more clear.
Sounds good, I didn't realize that bit.
Yep, see [this spec](https://github.com/seomoz/interpol/commit/4885839dd30e15edcdb8e7ceb7fc948767ed4b64#L7R357).  That's the reason I used `unshift` (rather than `<<`) so that parsers defined later take precedence.
Fixed both camelcase and boolean.
I think you can use 2.0 unless you use `$event->getName()`, which was added in 2.1.

https://github.com/symfony/EventDispatcher/compare/2.0...master
why duplicating the constants here ?
This method seems unused
I now check the result of chmod against ``true``, tell me what you think about it
simply push to the same branch
Wrong indentation for the array
Whats the point of this test? Such general tests are not really useful.
Instead it should probably test that the session is not duplicated.
The help is using ``\n`` in previous places, not ``PHP_EOL``
It's actually common Python convention to have each module import on a separate line.
Add T docs:
[newline]
@param <T> .....
why iVar as opposed to a property?
so nil is not considered as false? I don't test it. I just expect that ycp work as least slightly similar to other languages like perl, python, C or ruby
just_filename=True, not load=False
I wasn't sure how we were going to handle input\output so I just added this in case we use XML. I believe we discussed the possibilities last meeting.
you're right. if a tasks isn't set up right that's just programmer error
Works with curl but not jquery !!!

## CURL
$ curl -i -v -X POST -d "" http://localhost:8081/data/hire/stalonne
* About to connect() to localhost port 8081 (#0)
*   Trying 127.0.0.1...
* connected
* Connected to localhost (127.0.0.1) port 8081 (#0)
> POST /data/hire/stalonne HTTP/1.1
> User-Agent: curl/7.27.0
> Host: localhost:8081
> Accept: */*
> Content-Length: 0
> Content-Type: application/x-www-form-urlencoded
> 
* additional stuff not fine transfer.c:1037: 0 0
* HTTP 1.1 or later with persistent connection, pipelining supported
< HTTP/1.1 204 No Content
HTTP/1.1 204 No Content
< Content-length: 0
Content-length: 0
< Date: Thu, 20 Dec 2012 03:15:48 GMT
Date: Thu, 20 Dec 2012 03:15:48 GMT

< 
* Connection #0 to host localhost left intact
* Closing connection #0


## POST with firefox:
Requête:

POST /data/hire/stallone HTTP/1.1
Host: localhost:8081
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:17.0) Gecko/20100101 Firefox/17.0
Accept: */*
Accept-Language: fr,fr-fr;q=0.8,en-us;q=0.5,en;q=0.3
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Type: application/x-www-form-urlencoded
Referer: http://localhost:8080/
Origin: http://localhost:8080
Pragma: no-cache
Cache-Control: no-cache
Content-Length: 0

Réponse:

HTTP/1.1 404 Not Found
Transfer-Encoding: chunked
Date: Thu, 20 Dec 2012 03:12:12 GMT


Why ???
We would not want to force a cache to start for the sole purpose of clearing it (thus preventing it from shutting down naturally).  If the requested cache is not started, I would expect the operation to fail accordingly.
why not
```java
AUTHENTICATION_PROVIDER.parseAndSetParameter(readStringAttributeElement(reader, "name"), connector, reader);
```
this included the "parsePossibleExpression" stuff + some more
I thought you added a helper method for doing this erb templating?
null это что-бы потом шлепнуться в NPE в функции prepare? Верни лучше Collections.emptyList или ImmutableList.of() — это все готовые пустые списки. Ну или совсем не проверяй на isEmpty и возвращай что есть
Let's use `escapeHTML` in SMS app instead.
As a script lives in the system, I think you could use `NotificationScreen.addNotification()` directly. That also gives you the ability to remove the notification i think. But that can be done in another bug.
I would avoid Mozilla-specific getter.

Besides, given the fact we impose peer review in Gaia and System app, the chance of being mess up is little.

I'll leave it as-is.
At the end I verified that the refactoring you suggest is not possible in case we want to be sure that every test case suite is self-contained. For example, if we move the teardown of the 'ussd message sending' suite to its parent, even with no setup of the 'ussd message reply via UI' suite (this is, with not a second USSD message sent or replied), we would get the first test case ('ussd reply message sent') of this second suite as passed because of the previous suite, but not because of the message replied. I do not know if I made myself clear... :-) In any case, moving the teardown to the parent suite causes some of the test cases to fail because of a not proper "setup + teardown".
see other pickers for review comment, I will skip this.
I notice that the apps on the dock don't have name.
Are we going to put names below the icon afterward?
I can add default value of master volume to settings.py, but we shouldn't set master value here IMO. You will get very small volume if platform fix is landed.
The reason I put <code>this.index++;</code> at the end of the <code>SubListView.update()</code> is because I wished all the operations in this function can be done, then the index increases.Although I can use index after <code>this.index++;</code> when I need <code>this.index+1</code>, but this may confuse reviewers and me cause the index is changed before <code>SubListView.update()</code> in finished.
use `data-hide-on` would get you dataset.hideOn.
You may want to use a constant.
good point. Gonna do that
jvmopts loading could also use `loadConfigFile()`, like below for sbtopts...
Antares doesn't have the SDK installed. So we've a subset of binaries on it to allow 4.0 apps to compile correctly. This points to the root of it.
For a first release, it's okay. But an issue should be created as an enhancement.
If running the command didn't raise an error, it would be violating the assumption here that the command will raise an error, and would likely lead to some unexpected failure later on.  I always prefer having errors raised as close to their source as possible.  What do you think about changing this to something like this:

``` ruby
def run_command_expecting_error(cmd)
  expect { run_command(cmd) }.to raise_error
end
```
typo in "BaseTextFormtter"
What about `tryToSignUp`? At least, it starts with a verb ...
I don´t think we need that. Each `Ember.View` has a property `state` which returns `inDOM` if the view is in the DOM.
```javascript
function hrToSec(t) { return t[0] + t[1]/1e9; }
```
might be a livesaver
Allows callers to store to multiple rows with a single call.
This comment doesn't indicate what this method does clearly, nor what its arguments are. Check out how other methods are documented for how to it a similar way.
The interfaces for an out-place and an in-place metadata implementation slightly differ.
In the out-place strategy (Context) the field is identified by the base object and its offset, as in the on*Access(Object obj, T value, long field) methods. The in-place strategy (ContextMetadata) works directly with the fields' metadata, therefore these methods are now on*Access(T value, TxField field).
The methods which are not affected by this are factorized in IContext, from which both Context{,Metadata} inherit.
@stloyd Your solution is right, the current implementation is buggy, because it exclude all files they have `.` as first character. For instance `.htaccess` and `.htpasswd`.
I think I changed this comment on accident, so I reverted it back to the original.
Gah!  Abstraction violation!

How about adding a `keys` method?
Ok, I have it in mine. Just wanted to put in in just in case.
A command should return an integer (the exit code), not a boolean.
Or this is default options to choose?
As we are casting the (potential) array to a string `string: Array` then I don't see why this would be required. On the other hand, if it's just a matter of nicer coding, I agree check for an array first is better, but I don't see that this would cause a notice / bug, am I wrong?
here GetXFFIP is not called with a flow lock
Could you make name of predicate function little more descriptive so that reading it gives an idea what it does.

For example: `isAddonPageTab`
oh... i removed that because it's now passing `allowUnverified`, but `unverified`. Otherwise, the keysigner process would need another db request...
We don't want to axe ``host``.
shouldn't that be `source = DotDict(get_symbols_from_module(source))`

Otherwise, in the case of `Mapping' type instances you're going to do `DotDict(source is already a mapping thing)` a couple of lines later.
@Midnighter Done in ede03b2. I also added a `not_implemented_for` decorator.

The `require` decorator can also be added to the other functions in `laplacianmatrix.py`. Is it OK to do it in this PR, or is it better to modify this in another one?
I have two problems with this method:

1. The name doesn't actually describe what it does. A better name would be `warn_if_near_expiration`
2. I don't think the Certificate class should be responsible for the UI of what to do if it is near expiration.

Changing to either a predicate of `near_expiration?` would seem to keep a better separation between checking for it being expired and telling the user. Another good separation would be rather than pulling out the setting directly, if the caller provided a `lead_time`. A problem that we have got throughout the codebase is a lot of dependencies everywhere on the `Puppet#[]` access to global settings, which makes pulling things apart very hard.
Ah, yes.  I pulled as-is from @kbarber 's structured facts branch. We can improve on how that's done.
To be clear, I mean the following line:

```ruby
FileUtils.rm Dir.glob(File.join(Rhosync.base_directory, "#{data.url}*"))
```

Is better suited as an instance method on the bulk data class, so it could be used by something like a cron task later.
Yes, actually it doesn't have to be this way (it's inefficient and maybe most cases for this is creating new file?). I pushed a change that fixes this.
Thanks for reviewing! As suggested, I changed to initialize fallback to NULL and set it to G(object) if necessary.
@Maks3w agreed, yeah that makes more sense. Will do, thanks!
The IPv6 stuff is being fixed now (see
https://github.com/zendframework/zf2/pull/1524)

The other failures I believe we need to discuss. You have to consider if in
a real use case you see http:/, htp:/// and example.org: as valid URIs. For
the least, I thnik it should be configurable whether they are accepted or
not.

Shahar.

On Thu, Jun 21, 2012 at 10:10 AM, Maks <
reply@reply.github.com
> wrote:

> > +            //array('http:/',                                false), //
> TODO: FAILS
> > +            array('http://',                               false),
> > +            //array('http:///',                              false),
> // TODO: FAILS
> > +            array('http://www.example.org/',               true),
> > +            array('http://www.example.org:80/',            true),
> > +            array('https://www.example.org/',              true),
> > +            array('https://www.example.org:80/',           true),
> > +            array('http://foo',                            true),
> > +            array('http://foo.local',                      true),
> > +            array('example.org',                           false),
> > +            //array('example.org:',                          true), //
> TODO: FAILS
> > +            array('ftp://user:pass@example.org/',          true),
> > +            array('http://example.org/?cat=5&test=joo',    true),
> > +            array('http://www.fi/?cat=5&amp;test=joo',     true),
> > +            //array('http://[::1]/',                         true), //
> TODO: FAILS
> > +            //array('http://[2620:0:1cfe:face:b00c::3]/',    true), //
> TODO: FAILS
>
> @cgmartin Please uncomment the data that is failing. Hide the fails goes
> against the priniciples of testing.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1521/files#r1024281
>
Won't this restrict us to testing HTTP endpoints (vs Console)? Why not simply re-use the `Zend\Mvc\Service\*` factories? What's the rationale?
s/appropriate/appropiate/
erm...:P
Just a note that if your tablename is the same as your entity name, you don't need to specify (tablename) - it's just if you have mysql being difficult with the name (like 'user'), you can specify another name ('users')
I m not sure there's a place you are using this invoker here, do you really need it ?
The benefit is not here, but in SRC_URI line.
Could you not provide one default lib and avoid exception altogether?
This will will not actually install correctly.
add a (small) docstring for this internal function aswell
I changed the way the script works (now has --name option).
Yes, that was my point for paths =) I will sent "fix" in next few mins...

ps. What about `profilepicture` ? =)
Probably just remove it.
I'm unclear about the change you are requesting here.
add MPL2 here
The test is failing due to the 4 broken locators.
I've already left a comment pointing out the problem: https://github.com/mozilla/mcom-tests/pull/55/files#L0R15
And `CSS`.
Surely there is a better way of manage permissions then adding an extra *_privacy field for each field?
JSONField comes to mind. Have a dict of all the fields and their privacy settings.
https://github.com/django-extensions/django-extensions/blob/master/django_extensions/db/fields/json.py
Is it worth having a sanity check in here? IE is this a number between 0 and 1?
I haven't tested the plugin but just wanted to note that we'll need to add "json" to the setup.py includes, or else the plugin won't work for people on Windows/Mac.
This is what triggered me finding this bug. The spreads haven't been updated for the first 100 days (because the window hasn't been filled) so there shouldn't be anything there. So this is correct behavior now.
if we don't show the os as a nested object in the json output, there is no reason why we should eager load (include) the operatingsystems.
Right, but I may want to override settings only when the combined filetype is "foo.bar", not just "foo". This is just a convenience. Otherwise, I would have to install a local config for "foo", and in there check for `&filetype ==# 'foo.bar'`.
The question here is all in present tense, but the CHOICEs have past and future?
The sentence-with-linebreaks style feels strange to me. Does it look bad if you get rid of the line breaks entirely?
The problem is that once you get lower than around 30° it starts not showing on the thing, or the angles are so small that the text doesn't look right, so I just bounded it. Everything else should be to scale though.
> Injection has been erorr !

lol.
Você poderia acrescentar testes para esse método? Há um teste, mas cobre apenas argumentos inválidos.

Se você quiser, posso fazer pair com você para ajudá-lo.
не нужно явно писать ни конструктор ни деструктор
I'm leaning towards treating all non-zero exits as errors but then making whether or not grunt-exec fails on stderr configurable. That should provide enough flexibility for most use-cases.
basically this is just generator to retrieve this class, shall i rename it to get category ?
check the code bro :)
Because this method is calling only in path_cache_key and url_cache_key methods and there is locale already set to default value I18n.locale.
You are testing that the dependency exists, that is okay. Your test misses to test that a ProjectDependency with an update set to a PackageVersion from gunicorn-del still stays.
Would `if (!rows[0])` work?
Actually, just the parameter name is wrong here.
I' prefer to do this as a separate issue and tackle module forms, creating a tenant and any other forms at once. What do you think?
I thought the `_bootstrap` function was called from the initialization logic so this can probably stay unchanged?
I haven't given it much thought yet as this just addresses file bodies, but I wouldn't think so.
I think those could be stored in Cassandra and have their own special logic/cf/...
It helps the UI determine the execution context. For example if we're on global only the local authentication should be shown.
Great. Go ahead and merge it.
That's right. I made a special case for parameter lists of size one, missing that for those the general condition implies the specific one.
Instead of communicating between these functions using global state, it might be better to rename `RunSpecFile` to `RunCurrentSpecFile` and then have it call `RunSpecFile`, which takes an argument (the spec file it should run).
I'd like to keep this line anyway, please don't touch it ;)
I don't think that `prep_query()` is supposed to replace escaping characters. There's no point of splitting this if there would be platform-specific elements passed to the subdriver instead of letting it handle it independently.
В условии к заданию необходимо выводить различия, а не совпадения символов в массивах.
Понятно, спасибо большое за помощь и потраченное время!
According to http://en.wikipedia.org/wiki/Database_index#Column_order the order of the indices is important and I think we want the submission_id before the test_script_id.
Setting something to the empty string per default is a bad idea. It's hard to catch/diagnose if things go wrong. Consider setting this to something more obvious. E.g. host1.example.com
This path needs fixing, we can't have a big series of '../' like that in our code.  I believe you already have access to the config dir via the app config settings here: https://github.com/rails/rails/blob/94dcbe8115810b4545ca8011e6c1e5386cb1c842/railties/lib/rails/engine/configuration.rb#L39 (it is in api docs, but they made it so I cant get the direct link easily now)
Тоест — да, трябва да е higher. Направи един PR да го оправиш.
Interesting point, indeed there is somewhat of a "mismatch" between what the iteration counter should mean for the MCMC simulation and what it should mean for the IterativeComputation.
This method doesn't need to require `nil` termination. We have the method signature for the selector in question, so we know exactly how many arguments should be passed in here.
This was actually the implementation from the master. I will be more then happy to test it if you provide me with a guide with no image steps.
It seems we usually favor the MarshalToStructure approach elsewhere in libgit2sharp code.
Do you think you could document the algorithm? It's not completely obvious what's going on.
Because this is "bad" for SEO. It is better to always use extended version containing the title of the resource.
We should add tests where we apply the operations from access_by_name after reading. This was the critical case that revealed this bug.
Why then not simply call this arg 'conditions' -- already the function name should be a good pointer and this doc str.
"is not" instead of != is more pythonic
The spheres are too large for my taste, I would use "scale_factors=[0.8]"
could we somehow avoid breaking compatibility?
What do you mean:
1. ```reload``` should be renamed into ```ensure_loaded```. It shouldn't since ```reload``` also do ```purge```  so semantically it's more ```reload``` rather than ```ensure```.
2. Instead ```:code.load_file``` we should use ```unsure_loaded```. In this case regular erlang modules couldn't be reloaded. Since internally module is represented as atom with __MAIN__ prefix erlang means of reloading works just fine.
3. Instead of ```reload``` the one could use ```ensure_loaded```.
should have a blank line after the declarations.
Why not let S handle this:

```python
a = S(p, rational=True)
return PythonRationalType(a.p, a.q)
```
Should be better named (such as "$data") since we are exposing it as part of API now.
У тебя теперь есть отдельный `IPostOptionsWidget`, почему бы не перенести эту пару функций туда?
Ну и тут то же самое.
This is not even true in the slightest.

If I am running GDC on ARM.   I am certainly version(GNU), but I am most definitely not version(InlineAsm_X86_Any) in this case.
The checking for the log level is not needed, unless the construction of message is deemed to be an _expensive_ operation.
Yes, git only. The tooling past there is incomplete, and will be dependent on your choice of hosting.
`(fn [node] node)` is just `identity`.
There's also changes to Input and Record here. Please highlight removal of auto-answer.
Check media type
Oops. Actually the C++ counterpart is better:

http://en.cppreference.com/w/cpp/string/basic_string/stoul
Yup. It ends up printing either
* nuget.exe install Blah.config -source "" 
* nuget.exe install Blah.config -source "http://nuget.org/api/v2;http://testsource"
Could you add a deprecation warning here when col_sep is set. It will be removed in ActiveAdmin 0.6.0.
alright just a suggestion.
great question! well because they are all strings in the configuration file and no types are associated with them from the config class. 

I realized this when i attempted to turn off volume support with False. It was still turned on. because the string existed. I figured out this is what melange was doing to convert the values. Integers should be casted as well when pulling a config value.
The condition will be moved to a variable called `fetchEnabled`.  `stateTransferNeeded` is not a good name because 'state transfer' consists of two activities: fetching and discarding, and discarding is always enabled.
This needs to be freed.
On 2012/08/30 3:11 AM, Varoquaux wrote:
> but the former is not pep8 :(

But it is.  Quoting from 
http://www.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds: 


=====

But most importantly: know when to be inconsistent -- sometimes the 
style guide just doesn't apply. When in doubt, use your best judgment. 
Look at other examples and decide what looks best. And don't hesitate to 
ask!

Two good reasons to break a particular rule:

When applying the rule would make the code less readable, even for 
someone who is used to reading code that follows the rules.

...

=====

Eric
I don't have time for a full explanation as I am about to head off on
vacation, but perhaps I can provide some clues for you.  I think this code
part has been neglected.  Other functions like plot() and scatter() utilize
pads for the data limits so that the axes wouldn't be extremely tight
around the data being plotted.  This value used to be a hard-coded 0.05 on
each endside (for a total of 0.1).  In plot() and scatter() (and possibly
bar()) we now handle this a lot more intelligently, but I think hist() was
left behind in this regard.

Note that data limits don't necessarially mean the same as view limits.  I
am not sure what the distinction is between data limits and data interval
is, though.

I hope this helps!
Ben Root
LGTM too, and +1 on what Aaron said; otherwise, ship it!
Nit: space after #
That would work probably too but I just made it start at the centre of the /\ icon element so that it would be protected against any element size changes and would scale on other screen sizes.

I emailed you some code snippets from @malini that should explain this if you haven't read them yet.
Good eye; will fix.
Можно и так. Пожалуй так и сделаю.
Pam, totally agreed. I landed the pull request already, but in general the code is ripe for calls to mysite.base.unicode_sanity.utf8() in cases like that.

So for now, I'd say, Submit a fresh pull request with that change, ensuring the tests still pass. (:
Feel free to suggest a better wording....  I totally agree on the docs - I already have a skeleton version.
This means any stable version and would automatically bump major and minor versions as well
Try out: `class="form-actions"` on the `<li>`
No idea how this API works but it seems odd to multiple a measurement by 100 without tracking units at all.
Aaaand it breaks for lein2. I'll switch to 1.0.8 for midje.
I'm using it directly from Cascalog so need some nesting. Maybe better to use a wrapper?


On Apr 20, 2012, at 2:53 PM, Sam Ritchie wrote:

>> @@ -54,8 +54,7 @@ final compositions of functions."
>> 
>> (fact
>>   "Make sure rain is shortened to length of input ts"
>> -  (shorten-ts [1 2 3] [1 2 3 4 5]) => [1 2 3])
>> +  (shorten-ts [1 2 3] [1 2 3 4 5]) => [[1 2 3]])
> 
> Hey, this is strange to me -- why would it produce a nested vector?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/15/files#r714922
I left some of the stubs in so it could be finished later.  There isn't any support for debug on rebundle as-is, so there is no reason for someone to be setting that mode on the creator.  We don't create dev images on rebundle.
add CT_NEWTONSVM to the EClassifierType in shogun/machine/Machine.h
that matrix might be HUGE! is there a way to avoid working with the whole matrix, i.e. couldn't you just use vector by vector here?
To já vím. Mně vadí to, že jsi mi změnil chování toho schedule (void) tím, že jsi z něj to naplánování dal pryč. A nechápu, proč. Už jsem ten timer_start přesunul, když jsem to našel :-)
Are you sure ``'Pagination adapter manager must extend AdapterPluginManager; received "ZendTest\\Paginator\\TestAsset\\InvalidAdapter"'`` has the correct type as "string" is not a sub-type of "string"?
How about making the return type a bit more specific; maybe use ``boolean``?
try后面应该有空格。
I don't see that change, are you sure your changes have been pushed correctly?
the naming is weird as it returns a single alias for the fixture class.
hmm, but we need to clear it after or else the text sticks. any ideas?
Let's do the class_exists('JError') trick.  If JError is present, turn the JError, otherwise throw the exception.
Excellent! I'll go with that then, thanks.
Puente is literary translation.
This is not good. We have to think a bit more about this. What we want to prevent or allow? We have lazy users (not authenticated) and non-lazy (those who registered or logged in through third-party authentication). In one other pull request (#198) we have decided that also lazy users will be able to set their e-mail addresses. So in fact everybody can go and send its confirmation token.

But what is important is that user has e-mail address defined! And that when user gets back, the same user is still logged in!
No I am not saying they are wrong. I just randomly opened some .py files to see if all imports have one empty line between them. And those that I opened were probably all from the same section. I remeber opening signals.py and some others.
e-mail address still missing.
All this code is highly complex. Much better would be if you would provide this form in home.html template, use CSS to not diplay it, and just here you clone from that element and get a new copy, which you return here (you attach event handlers before).

So for static HTML content, there is no need to construct it in JavaScript. This form is static. (You only attach data and event handlers.)
Do it inline.
hower($('#drop_down_login_options').show, $('#drop_down_login_options').hide) does not work in my browser :( thats why i changed back to wrapper functions.
Your code does not reset values for old panels which are not anymore in `get_all_panels`.
Message? What is this?
Перенести в Api
Are you not a fan of new lines? Because in my opinion this is really hard to read and easy to overlook.

Why not write:
<code>
if (!uri.isValid()) {
	return null;
}
</code>
This "version" stores the News object like this:
```json
{ "_id" : ObjectId("4fb8c2d9c6942f6f05368ea7"), "content" : "JUG means Java User Group", "newsId" : { "author" : "Guillaume", "title" : "What is a JUG ?" } }
```
But another version could be:
```json
{ "_id" : { "author" : "Guillaume", "title" : "What is a JUG ?" } , "content" : "JUG means Java User Group"}
```
What do you think ?
Regexs are fast.

```
[3] pry(main)> r = HTTParty.get('http://nytimes.com')
[4] pry(main)> s=Time.now; (r.body * 100).gsub(%r{</body>}, "Hey hey hey"); f = Time.now; puts f - s
0.000244
[5] pry(main)> s=Time.now; (r.body * 100).gsub(%r{</body>}, "Hey hey hey"); f = Time.now; puts f - s
0.062047
```
Like @cgx said, we should make sure this is not looping for a lifetime...
Sinatra sets `X-Frame-Options` header to deny cross-domain iframe embedding, but in this spec I want to make a cross-domain request (`localhost` iframe in `127.0.0.1`), so this line sets `nil` not to send `X-Frame-Options` header.
Sure. I'll grab your branch and send you a pull request for this. Mind if I get this to you sometime this evening?
Is this type annotation meant to be Bytes?
Only one implementation - why is an interface needed?
OK, perhaps not exactly in the same way. But breakpoints in Breakpoints and frame in Call Stack hve the same functionality. Also event listener tooltips, but they are not jet on your branch. Script links in the command line too, actually.
__selected_window gets the default value for the suggested window_id parameter, so you don't need here a new var.
stacked by columns ?  by not in a column ?
``data_y`` doesn't belong here as far as I can tell. If it was intended, that would break backwards compatibility.
should be replace by a norm_cdf for clarity, but not now, since this is cheaper than calling scipy.stats
I think, all you need to do is at the beginning of ``__init__``:

```
if isinstance(dist, basestring):
    from scipy import stats  #if it's not imported yet
    dist = getattr(stats, dist)
```

then you have the distribution instance itself, and anything later can stay unchanged  (ppf and fit are available as methods)
shall be `shadow(this, 'view', view);`
Another commented out security constraint.  See previous comment regarding same.
Having gotten rid of this disabling of the send button, you could also get rid of the re-enabling that happens when a response is displayed.  (Right now, it isn't doing anything -- it turns the button from enabled to enabled.)

Also, I suggest you not comment code out like this, but rather delete it outright as you did elsewhere.  The git repository still has the old code available for comparison and to revert back to if necessary.  So the commented-out code isn't needed to serve those functions.  It just adds clutter.  Over time, a program can get really hard to read and maintain if it has a lot of old commented out code in it.
You are still overwriting changes from other coders.
This is just the default file to look at when running logrep or wtop, so for now have it be the fall2012 one (that is production for now, after all).  Will switch later.
probably want a test which uses ENABLED_PROTOCOLS (and shows how to use it)
Yes, when using the `new` operator, you can omit empty parens.

I also prefer this style with regular invocations. I *much* prefer `(a b).c` over `a(b).c`. It gets across the idea that `a b` is producing some value, upon which you're accessing the member `c`. But I'm actually a minority in that respect, so I haven't changed instances like that in this code.
Let's make the package name "doc_code_merge".
Just to note: seems that Chrome implements ES6 Number.isFinite without support of boxed values: https://github.com/v8/v8/commit/e98bd723589f2d2c49858eb0c16bdfcf4eb5ea50.

ES6 spec doesn't say anything if it should support them or not.
Please change that here too, with the { on the next line.
Gotcha. This was leftover from a previous merge, I've removed it.
You will want "replace => false" on this, so if somebody had content in site.pp we won't be overwriting it with an empty one.
You don't need to submit a new PR - if you commit the change on the same branch and push it, the pull request will automatically get updated ;-)
I was looking at the views side by side to see differences. the `search_with_sphinx` view still has the 

```
    if waffle.flag_is_active(request, 'elasticsearch'):
        engine = 'elastic'
    else:
        engine = 'sphinx'
```
significant_other was causing errors
ditto here (for dataSource) and also maybe use the $request object to get the user from the Session...
I just have to be picky about copyright. If there is anything in that file which has been taken from OpenPilot it should still have the OpenPilot copyright line in here. If not, the /LicenseTemplate.txt header should be used. It would be beneficial to have the very same header across the repository as we will probably have to change it again in the future.
Providing links to discussions of theory and application? This is a sharp change from past behavior. Have we considered the consequences of seeming less like savants and others understanding the underpinnings of our code?
It's also related to your other comment regarding the DefaultJobLoader. Once we address that, this should go away, yes.
ah. sure
Everything apart from this last line is great. Maybe:

"When in doubt, strip or escape HTML and you'll remove one more potential problem"?
As was pointed out on a different pull request, is this not double filtering? `PDO::PARAM_INT` will do this for you surely?
Нет. Надо проверять, что вылетело исключение правильного типа и именно то сообщение, что в методе выбрасывающем.
Можно кешировать предыдущее значение.
Это некорректно. Надо проверять, что target реализует все переданные интерфейсы, а не наоборот.
It's essential to avoid leaking access tokens across requests if the URI object is re-used:

```ruby
MY_PROFILE_URL = Addressable::URI.parse('https://graph.facebook.com/me')

EM::HttpRequest.new(MY_PROFILE_URL).tap do |conn|
  conn.use EM::Middleware::OAuth2, :access_token => current_user.access_token
end.get
```

Without the dup, the access_token is persisted across requests, which is almost certainly not the user's intent.
can you move the search term into a variable, ta
PHP 5.2 is deprecated, while it is true that this codebase did support php5.2 I am not interested in supporting 5.2 for a second longer and I am a fan of functional programming patterns myself.

A real problem here is that the code is incomprehensible. I can't imagine it needs two array_slices, redoing `count()` on each loop, and what is returned from the method? For what use? Could this not be rewritten into basically something as simple/short as:

```php
<?php
foreach (array_chunk($this->chunks, $this->chunksize) as $selection) {
    $this->transport->request('/_bulk', 'POST', join("\n", $selection) . "\n");
}
```
上記以外の、よく使用されるGORM APIの大部分は以下を含む@DomainClassUnitTestMixin@を使用することでモック化することができます。

以下を含む@DomainClassUnitTestMixin@っておかしくありません？
why two configure flags?
And the same thing is valid for http responses.   [200] will actually create a link to the 200 response code at http://httprespons.es site.
I now import them using aliases as `np_zeros`, `np_ones` and `np_bool` to make this clearer.
+1 done
You can use the `sklearn.cross_validation.train_test_split` utility function to do this a single line (fix the `random_state` seed though to get reproducibility).
I'm totally with you on that. However given the time restrictions, it was agreed that unit-test would be enough for now.
I agre. IntelliJ did that and I did not catch it.
As discussed, I moved bootstrap.js to where it would be for TIMOB-9228
This function would be a good fit for implementing using JavaScript. Feel free to remove it since it was not part of the Jira task, or fix it according to my comments and leave it in if you want.
I've been unable to find a way to make only the variable arguments named.  The only thing I can think to do here is rework the interface so that formatKey: is always on the end instead of the beginning.

Example:
`-(RZWebServiceRequest*) makeRequestWithTarget:(id)target andParameters:(NSDictionary*)parameters enqueue:(BOOL)enqueue andFormatKey:(NSString*)key, ...;`

Would that be better?
Le token d'accés est alors disponible dans l'URL.
what's with the trailing spaces ? 

it it caused by emacs live ?
Local variables please
`'?' not in referer` is strait out of `django.middleware.common.CommonMiddleware`.  I don't know why it is there.
>Not exactly the same thing, since findFile normalises the name, which is an important part of the dedup.

I wasn't suggesting changing findFile... but search dflist explicitly for instance in addSuperFile, (or create a private method to do so)

>To be honest, it won't save much. Return an index rather than an address is saving nothing in the final assembly code.

avoiding normalizing and strcmp's is incidental, not speed critical here.
The main thing is, it would look clearer.
At the moment it _looks_ like it needs to check names, as if there could be separate instances.
why a hard dependency to the ClassLoader component ? I don't see where you need it
This should be outside of the two ``for`` loops.
Yes, sorry - I did mean driver.
instatiating => instantiating
could you avoid doing a curl init in the constructor ? the constructor should be as lightweight as possible to avoid making DI expensive. The logic should be done only when it is needed
@jordanbyron Please take a look at [this pull request](https://github.com/wicz/liskov/pull/6) where I make some of the changes that you recommended. Overall, I like it. What do you think?
Please put the built-in imports first (datetime, string, sys, time),  a blank line, then third party, another blank line and project imports last. My pedantic hat is firmly on my head today.
see comment re ```__init___``` and use as a context manager (which I really like by the way).
No, it's osfamily == Linux.
if res and res.body =~ /\<viewentries/
As described above: maybe replace "The extent of the swirling" with  "The size of the swirl in pixels"?
I agree with @mike-burns . I'll update this very soon and commit again. Thank you for your feedback.
`concat` is generally faster if you have two existing arrays.  I assume the `update` calls return arrays, so in this case this is the best way to do it.  Of course another strategy altogether would be to pass an array to update and just have that method push items onto the command list, this should be much faster than what is here now since it doesn't create throw-away arrays and gets rid of the `concat` completely.
Okay, that makes total sense and I agree with you 100% in that regard.  However, we need to make sure that these templates get documented properly in our API docs, I'm not sure that's currently the case.  I've already submitted code to have clock take a template and I believe the new code is certainly cleaner than what I had previously.
Do we need to do this on a cache hit?
Hm?

https://github.com/D-Programming-Language/phobos/blob/master/posix.mak#L55
Had an errorlevel check here, but appcmd doesn't return an exit code, so it fails because errorlvel is ""
Well, at least from the same transport.py we call LocaleCompiler with deploytype='development' hardcoded.
wait why do you we have to @property for keyboardFocusedProxy.
This seems very verbose for what you are trying to do.  You can probably create a local Builder variable for ContentProviderOperation.newInsert(Data.CONTENT_URI).  Then you can only use 'withValueBackReference(Data.RAW_CONTACT_ID, 0)' and 'withValueBackReference(Data.RAW_CONTACT_ID, 0)' when necessary.
If I remove this check, my subsequent check may crash if user have any value for jqueryUi different than `{}`.
We have git for metadata like that, the code is self-explanatory enough.
Found an issue here where this if block will sometimes get executed when ssl is set to false, but defined. Should we change this to use the ivar instead (@ssl)?
need to change grep node to grep self.view.file_name()
minor: when there are no subforms (everything is an atom), ```->``` is preferred
주변에 `comment_object`로 예상되는 게 없어서 `parent`에 붙였는데 맞게 고친 건지 잘 모르겠네요.
Rationale for change:

"R" is the unqualified range type.

The current type is Cycle!Range. Cycle!R, while probably assignable to and from Cycle!Range, may not match in terms of type.
This is not the correct coding standard (using tabs)
It should probably be noted (or better, enhanced to use) this doesn't use the deactivation utility in DeltaSpike to "turn off" an extension. All of the extensions in DeltaSpike, and hopefully those built using DeltaSpike, will use ability so developers can disable an extension in their application if they do not want it to run.
Call directly every time you need to use it. Because the `CommandProcessor` singleton is no longer `final`, it's not safe to cache this return value anywhere.
This shouldn't be here, sorry ;(
For consistency with other messages that may be displayed as alerts in the header, this should be "Never Screened for TB"
Yes... I want to fix that section....


On Tue, Jul 3, 2012 at 4:12 PM, staceyhsu <
reply@reply.github.com
> wrote:

> >
> > -I ended up catching the Shopify bug and tried working with a boutique
> web agency. As five more years passed, I realized that I knew a lot about
> running an independent computer business and that I knew a lot about
> tricking out Shopify for an ever growing list of clients. I have yet to
> give myself an official work title, nor have I declared my intentions or
> loyalty to any one type of computing. My corporation is pretty much a sad
> but expensive accounting exercise that I leave to those who get a kick out
> that kind of thing. I am sure my corporation is going to reach a decade in
> age as neglected as my vinyl collection. But one needs a corporation to run
> off invoices and interact with clients in foreign nations, so I go along
> with that. Dividends anyone?
> > +I ended up catching the Shopify bug and tried working with a boutique
> web agency. As five more years passed, I realized that I knew a lot about
> running an independent computer business and that I knew a lot about
> tricking out Shopify for an ever growing list of clients. I have yet to
> give myself an official work title, nor have I declared my intentions or
> loyalty to any one type of computing. My corporation is an expensive
> accounting exercise that I leave to those who get a kick out that kind of
> thing. While I my corporation in one sense everyday, in another sense I am
> sure it is going to reach a decade in age and I am going to look at it's
> history like I do my old vinyl LP collection. One needs a corporation to
> run off invoices and interact with clients in foreign nations, so I go
> along with that, but it has certainly not been a means to some well-planned
> out end. Dividends anyone?
>
> Typos.
>
> Original: While I my corporation in one sense everyday, in another sense I
> am sure it is going to reach a decade in age and I am going to look at it's
> history like I do my old vinyl LP collection.
> Corrected: While in one sense, I run my corporation everyday, in another
> sense I am sure it is going to reach a decade in age and I am going to look
> at its history like I do my old vinyl LP collection.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Shopify/Shopify-Developer-Book/pull/7/files#r1096066
>
Added course_path for the cancel button.
missing <space>
Can you rename this to ``shouldSerializeNull``?
Das macht Sinn -> hab mir auch überlegt, wie wir die Tabelle konstant machen können, aber hatte noch keine richtige Antwort :-) Habe für den Moment nun einfach die Konstanten entfernt.
Following your line of thought, other rules can be considered too strict, such as indentation, wrapping space around operators, single space after keyword, etc. This rule has the same objective as the others: consistent coding style.
ahh, rats.  fixed.
I understand, I am just trying to figure out if there is any value/purpose of changing it after init or after it was set, otherwise if someone sets it later and sees no change in the behavior it gets confusing IMHO
in reality its not either http or https. it's a generic schema because the .net library doesn't even use rest. But i went for http. I guess it could be https. Will change.
They are not internal functions. Some websites might want to list all the available metrics to their users and will need this functions.

On 11. 09. 12, at 11:28, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/datastream.js:
> 
> > +            plot.getPlaceholder().unbind("plotselected", onPlotSelected);
> > +        }
> > +
> > +        plot.hooks.bindEvents.push(bindEvents);
> > +        plot.hooks.processOptions.push(processOptions);
> > +        plot.hooks.shutdown.push(shutdown);
> > +    }
> > +
> > +    $.plot.plugins.push({
> > +        init: init,
> > +        options: options,
> > +        name: "datastream",
> > +        version: "0.1"
> > +    });
> > +
> > +    window.datastream = datastream;
> Internal function (metricList, metricName) can simply be anywhere. But for exposed API I suggest jQuery. Because then you can have multiple plots on same page. So you do $('#plot1').datastream(options) and this is independent and have independent state then others. (Some state can be shared in secret, but not really exposed. For example, manipulation of anchor/hash in URL should probably done together with all instances.)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
This test could probably be a unit test.
Check if the response is processed and if it's valid
you should add spaces around the ternary operator: ``$this->getSubClass() ?: $this->getClass()``