labofsahil/github-event-dataset-2012 huggingface dataset:
Formatted, tested and ready to go!

Formatted correctly accordingly to WordPress Coding Standards,  tested code in Google Chrome 20.0.1132.57, Firefox 14.0.1 and Internet Explorer 9. Report printed using HP Deskjet printer and everything output correctly.  Added PHP DocBlocks.

Formatted edd_pdf.php to WordPress Coding Standards.

** TODO **
Change @since in DocBlocks - didn't know what the next version was going to be so kept the @since to 1.1.3.2

@since need to be changed in the following files:
  includes/libraries/fpdf/fpdf.php (line 7)
  includes/libraries/fpdf/edd_pdf.php (line 7)
  includes/pdf-reports.php (line 10, 20, 132)
Extract animation construction

Trying to clean up a little. I think should make it easier to use webworkers at some point.
LPS-25611 Creation of new organizations really slow

Hi Julio, please review my work.
Regarding backporting to EE 6.0.12 - there were no any changes to database. Also I took care about LPS-19965 so I made test - added 30000 organizations, aded 3 new organizations that have parent organization and different addresses. Search organizatios by address works nice also time to add new organization is couple seconds.

Thank you Julio!
Fix drafts are indexed

This commit enforces that ONLY published posts and pages are indexed
Image tab page indicator

Hi, I've modified the tab page indicator to show a drawable instead of text, in order to mimic the ActionBar tabs with images. This is my first pull request, sorry for any mistake. The relevant commit is ec6f0a27 :)
Thanks for this great project.
Add get verified status

I'm attempting to add the to add in the api for paypal email account verification. I've copied the format that has been established, although I've been slowly tuning it. I wondering how much I should rewrite. Or in other words, what do you think so far. There are parts that I haven't attempted to work on yet, like the toString()s. I don't dig some of the ways the init stuff and like to change that but I'm not sure I'd like to do that at this time. 

Thoughts?
changes-00

-Auto authentication.
-Less necessary data writting when using createCalendar function.
-createCalendar vars should be reorganized.
add getClass() to PHPUnit_Framework_MockObject_Generator

Although generate() is public it is awkward to use (non-obvious name, "complicated" return value). This change adds a clean interface to the mock generator.

Note: this will make PHPUnit_Framework_TestCase::getMockClass() help avoiding to instantiate am object
5037

This should be revised.
std.file: Use stat instead of access to check file existence on POSIX

The reason for this change is the quirky behavior of access for SUID
programs: a file may not appear to "exist", despite that the program
would be able to open it just fine. The behavior in question is described
as follows in the access man page:

> The check is done using the calling process's real UID and GID, rather
> than the effective IDs as is done when actually attempting an operation
> (e.g., open(2)) on the file. This allows set-user-ID programs to easily
> determine the invoking user's authority.

While various operating systems provide eaccess or euidaccess functions,
these are not part of POSIX - so it's safer to use stat instead.

Please merge this only if/when it passes the [pull auto-tester](http://d.puremagic.com/test-results/pulls.ghtml).
fixed the bug file upload is broken.

Fileupload is broken because boundary is missed.

Please fix it.
Finished up the Fibonacci Javascript project
[task/travis] Fixing the pgsql travis xml file name

TICKET-#49
Fix plugin description file

See commit.
Preliminary test, coverage, benchmark support...

In addition, a few small changes to GenServer, Counter and converted the Kitty example to use GenServer
Sending a pull request

After the update to version 1.3.0, all icons except the one of the 'Failure Cause Management' menu were no longer shown. This was caused by a duplicate context within the URL, which is fixed with the proposed change.
desktop update site with feedback form

TODO: mobile version.
Make sure useLocalTimezone variable actually works

Because it was using tp.useLocalTimezone and it should have been using tp._defaults.useLocalTimezone
LPS-25905
LPS-25898
Backport of some functionality from https://github.com/guyboertje/gdata-...

...spreadsheet-ruby (which forked from this several years ago) to modify ACLs on spreadsheets.
Serialization of Case Classes must respect JsonProperty annotations.
Small change in documentation of Logging by Username or Email

Since I noticed some poeple (including me, see #476) forget to specify the provider in the firewall configuration. So I thought it might be a good idea to include in the doc.
Put images in separate dir to avoid collisions

Image names in ActiveScaffold are not very unique. You could easily end up with multiple `add.gif` files which, may override AS images or get overridden. To fix conflicts, I've put AS images inside directory.
Update source/_posts/2012-11-30-binaergewitter-talk-number-34-sicherheit...

...-durch-ignoranz.markdown
Add support for fragments and make closing while it was already closing smoother

I added the ability to specify a Fragment rather than just a layout.
Also fixed a bug where the drawer would start closing all over if showMenu() was called while it was already closing
update Korean translation

navbar
custom weather app
notification icon transparency
Update general-structure.md.

Update general-structure.md: Minor grammar corrections + fixed ordered list (bodies of text that follow each list item have to be indented or else it'll start the list over and over at #1).
Update Z_Global/Game Pace Rules.sql

Updated so theres no syntax errors
Update 1.5.md

大小写
add a language option to the installer

Hi

attached you'll find a language option for your wordpress cli installer.

Thanks for the work!

~pete
Adding samples and jsDocs.
Últimos ajustes

Bruno, conforme solicitado via basecamp, estes são os ajustes.
Por favor, instale e valide.
Fix similar to MDL-34783 - ensure that sectioncache is available for get_fast_modinfo

Take a peek at MDL-34783 to see why this is required.

From 2.3, get_fast_modinfo (well course_modinfo actually) gets upset if it can't find a sectioncache for each course it checks and as a result, resets the get_fast_modinfo() cache making it worse than useless.

You may also want to keep an eye on http://tracker.moodle.org/browse/MDL-34785
Added a test for a bug.
changed jtest to green text
Commit to add support for image in the toast notification

Allows to show images that have been configured with "setImage: forType:" method.
To use it, just call "show:(iToastType) type" instead of "show".
Multimap support

Adds support for (de)serializing Multimaps
Changed to 2.2
Documentation typos fixed

Some documentation fixes of typos for better understanding the sentences.
Update Adafruit_PWMServoDriver.cpp  Fixed setPWM - beginTransmission now works

Hi!

So happy to be able to contribute.

Corrected setPWM.  Transmission now works.

Line 53:  Set MODE1 register to " old mode or 0xA1"
This enables autoincrement allowing multibyte transmissions to be sent.

Can now set a sequence of regsiters in one transmission.
Fix #23.

My approach to fixing #23.
A couple of songs

Really cool idea, this. Added a couple of awesome songs.
Add a minimum required rubygems version to the gemspec

Adds a minimum rubygems version to check the dependency at installation time instead of runtime. 1.8.0 is the version that adds Gem::Specification#each, so that's what I set the minimum to.
Fix Russian translate
Fixed ARQ-1185 and ARQ-1186 #devoxx #hackergarten

Configurable default transaction mode + proper transaction support detection on client/remote.

That should be good for Alpha3
Update messages/ZmMsg_no.properties

Oversatt frem til linje 610
SECOAUTH-194: handle invalid redirect URI

Handle an invalid requested redirect URI by looking up the client's registered redirect
Small fixes for RollingToS3Policy
Update README to remove confusing and outdated instructions

Why 'SKIP' (+ misformat) when you can delete?
Marcus: translated personal part
Update Gallery/Files/res/values-ru/strings.xml

Подобавлял пробелов после названия категорий папок
scm location changed

Changed the scm location from some fake svn path to the github version
Add translations for login form legend
curl bulk requests

When supplying a file to curl with bulk requests, must supply --data-binary.  Regular -d works only if you're supplying its arg as a command line string.
Updated Ukrainian and Russian translations. Fixed BOM header for these translations.

I asked to take ONLY the last my commit.
Fix 3G, run daemons we meant to run. no_icc property is used in Qualcomm...

Realize it's not a lot of changes here, but found out that it's kind of a pain if you don't pull - I had to merge that silly one line change and rebase it so that I could pull your latest and commit to that...
[triv, spec] Issue 7614 - pragma(msg) accepts any type.

http://d.puremagic.com/issues/show_bug.cgi?id=7614
Added some basic JQM overrides to mobileinit.js

Hi!

I like the work you've done here and I added a bit to the mobileinit.js file. I am super new to actually using git and github as I've been using Mercurial as my main DVCS. I say all that to say this; I hope I didn't screw anything up or "do it wrong!"

Take care and you will not hurt my feelings if you don't like the changes!

Michael
Update site/ru-RU.com_hwdmediashare.ini

Hello!

I do not know how best to translate this string to Russian:
COM_HWDMS_DISCOVER=Discover

I think it better to wait for the release and then translate it from the context.
FIX: the first line "About you" should not be a list element

At least, all the other elements at that level of indentation are not lists (Your Jobs, Grants, etc...)"
Bug fix: removes spurious comma ...

... that is preventing comment form styles being applied to author, email and url fields.
Updated speaker notes

* Formatted existing notes
* Changed caching slides to reflect new name
* Added new notes where applicable
Node 0.6.xのクラスター機能を利用する。 

これを利用すると私のパソコンではほぼ3000 Req/sになれます。
Turns out, removing EBS::Rooms broke lots of stuff quite badly :(
It was the apostrophe in "Let's" being a fancy right-tilting apostrophe, but in the wrong code page (i.e. not utf-8).
I don't think getNiceFileSize() has digits... Seems like "floor()". And that can be quite a bit off the correct value. But maybe I'm mistaken?
Which type checking do you mean? I see no reason why coerce should not be used internally. And imho it is also not more readable since it is just a large code duplication.
I usually test all ruby code that is not purely configuration. This is not necessarily a stone-carved commandment, but I think it's a nice guideline.
Did you set the NodePath environement variable?
No problem.. also merged it into master branch. Thanks!
Nice work @grierj, please do keep the contributions coming
Shouldn't MiddlewareSessionTest be a subclass of  Test::Unit::TestCase instead?
I mean, in terms of flow the code works in the same way. But I agree that changing it to post-condition syntax may improve the readability. In this case I only pull down the method without refactor it. But if you want, please send a pull request.
Can we stick with the standard "addEventListener" method for these?
Необходимо убрать смайлик
There's something in the OKFN wiki:

http://wiki.okfn.org/Coding_Standards


Am 17.02.2012 um 12:01 schrieb James Casbon:

> Sorry Rufus, you want me to back out that commit?
> 
> Can you point me to your JS style guide too?  I couldn't really get
> the indent convention.
> 
> On Thu, Feb 16, 2012 at 7:49 PM, Rufus Pollock
> <reply@reply.github.com>
> wrote:
>> @jamescasbon while I appreciate the thought could we please not do this again :-) -- it's borked all my indentation (pure vim indentation on JS is often not what one wants)
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/okfn/recline/commit/b3a71e82cca77bfe24c93290dd321174c85ab3b7#commitcomment-975008
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/okfn/recline/commit/b3a71e82cca77bfe24c93290dd321174c85ab3b7#commitcomment-977523
I'm sure. This string hardcoded in gnome-session.
yepp, that function's name was `e` before. my mistake, thnx!
thanks @Schmoozerd, i wanted to do it but didn't find my old command anymore and then forgot about it... :(
*blames everyone else and the whole world and wanders off again*
I know you like curly braces
Даёт возможность указать отдельный звуковой файл для сообщений в муках
I had suggested rhino since that what I was currently using for some
unrelated Javascript unit tests - it's packaged by Ubuntu and presumably
other Linux distributions so it should be easy to add for people who don't
have it yet. Thanks!

On Mon, Feb 27, 2012 at 9:15 AM, Robert Konigsberg <
reply@reply.github.com
> wrote:

> I'm going to roll back the line continuation stuff entirely.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/danvk/dygraphs/commit/49302d658811c6d883924ef926bcd8f2e21bc931#commitcomment-1015950
>
Please remove `&& it->second`. It never makes sense to check a pointer for 0 before deleting it.
Dude. Just be happy!

-- Zef

Sent from my iPhone

On 4 mrt. 2012, at 11:31, Matt
<reply@reply.github.com>
wrote:

> Yay I don't know what this means though!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ajaxorg/cloud9/commit/16bede2ac9052563af0eb2e0aaf3cdadeeac1bcc#commitcomment-1039913
Mind you I do think it's good to test what the block context is, but it should be possible to vary that independently from the matcher behavior.

In truth, I probably should be testing matchers in isolation by verifying whether they throw  or not, instead of testing them in the context of `exec_tint`. My bad.
http://www.rssboard.org/rss-autodiscovery Point #3 says it has to be in the head.


On Wednesday, 11 January 2012 at 10:04 AM, John Gadbois wrote:

> Does the auto discovery link have to be in the head? If yes we could add a link with an rss icon maybe? This would be really useful for my support forun
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jgadbois/forem/commit/48c7cabbb04f0e802f374b5533998fd40971e0a5#commitcomment-855139
thatch goes back to change years of ignorance :)
AFAIR, java guarantees left2right evaluation of logical expressions.

On the other hand, why depend on subtleties and not make it obvious by having two lines of code instead of one? Do we want to save a line of code? :)
Now I get it!

Fine, I agree with the feature.
But I'd separate the "autorun" option of the CLI, from the parameter u are
adding to the Utils::load... API: it's a totally disconnected context. That
API is used in so many other places.

Even more keen to change that boolean autorun now...

On 28 February 2012 18:28, Jon Leighton <
reply@reply.github.com
> wrote:

> Actually, I am confused about what you're now asking. I didn't initially
> add the `__run()` thing, but the justification for it is that you won't see
> any errors etc if you open the inspector in your external browser after
> they have occurred. So you want to be able to start phantomjs and get the
> inspector in front of you before telling phantomjs to go ahead and actually
> run the script. Hence you have to type `__run()` in the inspector console.
>
> However, in my project Poltergeist, I don't want to have to force users to
> type `__run()` (see the pull request), so I added this autorun option to
> toggle that.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ariya/phantomjs/commit/e88e008ecf742f705feba07fa9ada3d21f802c82#commitcomment-1022313
>



-- 
*Ivan De Marino*
Coder, Technologist, Cook, Italian

blog.ivandemarino.me | www.linkedin.com/in/ivandemarino |
twitter.com/detronizator
In making the class for the test, I noticed that I needed this further change. In [my original use case](https://github.com/sagemath/sagelib/blob/08b0a5c081616e3ed8537d613911f7e7b1a9663a/sage/structure/element.pyx#L1564), the class, or perhaps some other mechanism in the environment there, seems to be smart enough even to be able to handle `' ' * indent`, but my toy example (and thus perhaps other users' examples) cannot. This diff chunk is not a regression fix, though, because such objects wouldn't have worked anyway before the indent parameter to the `JSONEncoder` constructor was made a string instead of an int, as far as I understand. (?)
On my system, 
'''
$ ls -al `which pager` 
lrwxrwxrwx 1 root root 23 Jan  4  2011 /usr/bin/pager -> /etc/alternatives/pager
'''
So maybe use /usr/bin/pager instead of /etc/alternatives/pager, and check for it before the other usual suspects because if should reflect the user-preferred pager?
Thank you guys for reporting and explaining!
fix in 11920.

Main idea about the new param for GetPlayer is that there might be many other places, where this could be usefull indeed - Would be happy to see suggestions :)
no. forget add #include <errno> in start of C file.
it's not have sence - parameters not saved for not-permanent pets.
FatMM not work in *nix. Only win* solution.
I will do it :)
Was 2:00 AM when I implemented it, needed to sleep to wake up for work.

What do you think of commits you can filter by own commits?
Hi Miguel,
I left some comments for you above, but there's also one other issue here that should be addressed:

This always dumps a github.users file into the current directory. However, I can run git pull-request from any location. So I would change it so that it always defaults to the root of the github repo.

Thanks Miguel,
:sparkles: :cool: :sparkles:
I was thinking we'd include the runtime stuff in the
kotlin-library.jar - so folks would either use kotlin-runtime.jar (the
minimal stuff) or more likely, kotlin-library (which has everything
you need inside and still only about 200K)

On 7 March 2012 19:05, Andrey Breslav
<reply@reply.github.com>
wrote:
> I'll have to talk to Max about it. There were some arguments for having fewer jars for now.
>
> On Mar 7, 2012, at 23:02 , James Strachan wrote:
>
>> How about kotlin-runtime.jar & "runtime" for the package for the core
>> runtime stuff (the stuff you can't avoid) and kotlin-library for the
>> core library stuff (thats optional but I'd expect many kotlin folks to
>> use it as its so kool)
>>
>> On 7 March 2012 18:52, Andrey Breslav
>> <reply@reply.github.com>
>> wrote:
>>> I was talking about the first one, not the second, but your suggestion looks good, too.
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/JetBrains/kotlin/commit/522083bf5a067bf42fb56ce0a6244a3d2b49290f#commitcomment-1054997
>>
>>
>>
>> --
>> James
>> -------
>> FuseSource
>> Email: james@fusesource.com
>> Web: http://fusesource.com
>> Twitter: jstrachan
>> Blog: http://macstrac.blogspot.com/
>>
>> Open Source Integration
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/JetBrains/kotlin/commit/522083bf5a067bf42fb56ce0a6244a3d2b49290f#commitcomment-1055042
>
> --
> Andrey Breslav
> http://jetbrains.com
> Develop with pleasure!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/JetBrains/kotlin/commit/522083bf5a067bf42fb56ce0a6244a3d2b49290f#commitcomment-1055049



-- 
James
-------
FuseSource
Email: james@fusesource.com
Web: http://fusesource.com
Twitter: jstrachan
Blog: http://macstrac.blogspot.com/

Open Source Integration
I think this should be updated with every new release since eZFind 2.6 won't work with eZP 4.1
hum I think this part is not related to this commit.
this line is not required: iface is available yet through self.iface (line 15)
This ought to be `self.instances`, though the fact that it's not failing now means this method is unnecessary for the test. And actually since the problem occurs when `defaultprovider` is nil, this whole provider seems like it might not be necessary.
I agree. Even the old IE 7.0 seems to correctly handle the NConf gui now :-)
So, useless feature now.
It's not my patch :P i only use it :)
https://github.com/clojure-consulting/sh-deps/issues/5
Same applies here .

    if( $signal instanceof Signal ) {
        $this->signal->send($this, 'pre_query', $this, $spec, $data);
    }
where do you use `SortedDict`?
Note, I was having issues with Railo's ArrayFind(), so instead I switched to a for loop for the built in counter. Caused a bit more code, but works on both ACF and Railo now.
я мало работал с change из рельсов 3,1, но помоему он работает корректно только при добавлении чего либо (удалить он сможет самостоятельно), а вот догадаться какого типа было поле parent_id ему не под силу. Думаю эту миграцию не получиться прогнать в обратную сторону.
С миграциями внимательно. Хорошая практика после прогона своей (свежей миграции) ее откатить и прогнать снова (точно не помню rake db:migrate:redo), тем самым убедимся что она работает корректно
Now you have to change your SSL certificate and revoke that one...
if this lives in code, how will the minification stuff get at it?
Cemak Forever!!11
hahaha its pretty good, although I didnt do all the font hacking - did you ?
这个地方应该是 `.typo-em`，我写错了。供着重号使用
This impl was actually overridden in every concrete subclass with "return true;", so I'm just making this return true and am getting rid of the overrides.
а еще лучше чтоб Quest объект принимал
halion portals doesnt work... gm mode usable flags only

http://www.imageup.ru/img137/wowscrnshot_010412_113042855315.jpg
@gregbell That made rebasing against master quite painfull. :)
...thanks.....alot you're awesome!! :D
但是当时刘禅两个人都能杀的到，而且从综合值来看貂蝉是更好的目标（貂蝉和庞德都是反）
I'm not convinced that copyDocument() should rename the title. It's good for rename for I'm far less sure for copy...

WDYT?
Extremely expensive method for what it does.
@robhoes Could you update the mli documentation to be more specific on the cases of duplicate keys and the intentional usage. Another possibility is to add assertions to forbid certain usages all together, but that would be a little overweight.
There is a typo here: s/;/,/
Also, logged out users are unable to access expanded views.
tr() returns a QString already
Sorry, you are right, ```ThrowStringException``` is a function, that is used by the macro ```throwError```.

This function is not different to any variadic function per se, what is different is the format attribute, that asks GCC to validate the parameters as it validates ```printf```-like functions.

    __attribute__((format(printf, 2, 3))

This means that, ```ThrowStringException``` is a function, like ```printf```, which format string is on position 2 and has 3 parameters (ie. one item).

The problem is that macro ```throwError``` has several variants, differing in number of arguments (not variadic), using ```ThrowStringException``` with different number of parameters, which generates warnings from the ```format``` attribute validation.

This is the piece of code:

    #define throwError(x)                           ThrowStringException(x, (x ## _Text))
    #define throwError1(x,a)                        ThrowStringException(x, (x ## _Text), a)
    #define throwError2(x,a,b)                      ThrowStringException(x, (x ## _Text), a, b)
    #define throwError3(x,a,b,c)                    ThrowStringException(x, (x ## _Text), a, b, c)
    #define throwError4(x,a,b,c,d)                  ThrowStringException(x, (x ## _Text), a, b, c, d)

This is the format attribute, on ```format (archetype, string-index, first-to-check)``` section:

http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html

Changing the number of parameters to zero forces GCC to ignore the number of parameters passed (ie. true variadic), but still check the format string for consistency.

If ```throwError``` had only numbered variants (1-4), this warning would not show, but it has the ```throwError(x)``` variant, to which there is no first argument.

I tried to fix this by creating a bogus argument, but that only generated other warnings because the format string had no arguments in itself, something like:

    #define throwError(x)                           ThrowStringException(x, (x ## _Text), 0)
Why not +2 ?
Won't help anyways, it's not like we haven't posted several video proofs already.
Kk, too lazy to doublecheck, thanks :/
This should probably use $r->getNamespaceName(), too!
I don't have a strong opinion.  My main concern was that you might have things associated with invalid activities or something similar.
I think what happened there was I wrote a slightly different fix that had higher performance, committed it, then realized it caused tests to fail, and then amended the commit to match your changes because they did actually work.
Looks good - please fix the directory issue & the test timezone problem.
Removes multiple choice from radians_and_degrees.html exercise
jQuery exports a global in addition to calling define. I'm happy to do a pull request if that helps.
no, remove direction override should be in Utilities/functions.h
This line should be parameter driven -- for authorization purposes, it's probably better to use 'https://www.googleapis.com/oauth2/v1/userinfo'  if you want the primary account email address. To limit access to email-only, you'll also need to set the scope should be ' https://www.googleapis.com/auth/userinfo.email' ..  Another thing -- if you want to use "https://www.googleapis.com/plus/v1/people/me", you need to enable this API service via the Google API settings.
load method will return a load deferred object.
Because controller is driven by trigger event and cannot return the deferred object to the event caller(who trigger the event), so it's better to save the deferred object on the dojo.Evented instance and all controller can share this instance.
I've changed it to "NVIDIA Optimus and AMD Switchable Graphics", that should be clear right?
I don't think we should do spillable versions of every sort algorithm... If it's large enough to spill it's unlikely to be suitable for an insertion sort.
Should consider allowing parallel (multiCPU) sorts here - if it's big enough to want to use the spilling sort it's most likely big enough to benefit from multicore.
Thanks!

Though, Shouldn't it be GPIO 1_6 is not grounded? Will correct it, thanks.
Writable.
Otherwise, what is the benefit of having a default user name?
Thanks, Artem, 

I like both ideas.

While security might be implemented in a similar way, I think it's a different issue.
À mon avis, ici, tu devrais tester $perso, vu qu'il a par défaut la valeur null ;)
@wowfurity Double check the xmlcache(found in classes/wowheadparser/xmlcache). This error means that there is something wrong with the xml cache
Sorry for my disgusting english ^-)
"extensive unit tests" -> "standalone unit tests"?
The built/minified files haven't been updated.
I've done the same but it doesn't work form me.
The project has only just been created, please follow and you'll be notified when it's complete. Stay tuned.
Not a big deal, but please take care of indentation. Good indentation makes your reviewers and contributors' life easier.
buのURLの設計はだいぶ辛いので、リファクタリングが終ったら大改造したいです
more important than bikeshedding the parameter name, I'd personally prefer a very literal help message so people know what this is really about.

help = "Run 'setup.py bdist_wheel -d DIR' prior to installing distributions.  The "wheel" package is required to build wheels."

btw, does it work for setuptools commands to have duplicate short form arguments?
there's 2 "-d" parameters?
https://bitbucket.org/dholth/wheel/src/a4ab096e2a91/wheel/bdist_wheel.py
Doing the complete match first made sense to me, in case there are multiple matching usernames. 

Eg, if I have
 * ReadySetRails
 * ReadySetGoal
 * ReadySet

as 3 distinct accounts, entering "readyset" should set the last account, not the first matching one. Perhaps a smart ambiguity-check (as you suggest below) could resolve the _best_ match, but that was more than I wanted to tackle without submitting something first! ;]

In a way, attempting the direct match *is* a first-order ambiguity check.
It is necessary to pass the then() args into the setTimeout function.
Oh, I think I misunderstood the return value of findSandboxHeader. When "null" is returned, it means something wrong happened. Otherwise an object will be returned even if there's no header found. A little tricky...
"valueValid" might be a better name
Good call w/ respect to placeholders
Formatting seems to be off.
I think we talked about it, but just to make sure that it does not get lost: don't log messages which go to deadLetters
Ticket added: https://www.assembla.com/spaces/akka/tickets/2499-byte-array-serializer
is this same as `unreachable-nodes-reaper-interval`, then it should be read from config
and for the record, it is:

    val (_, seenHead) = seen.head
nope, for testing purpose we create special Cluster instance, not the extension
I can't see that this hook is used any more. Good to have anyway?
same port, different hosts?
Just call the page migration-guides. And have links to the different ones. One in this doc (current) and the other one to the old one.
I see some inconsistency in the naming for setup and teardown.
become and unbecome are calls to perform something while whenFailing and whenRestarted are callbacks
setup and teardown should perhaps be named whenSetup and whenTeardown to indicate that they are also callbacks, or even better whenStart whenStop
I like `allow-local-routees`, another suggestion is `use-local-routees`
Or will it cross over the wire?
Needs some introduction
I have corrected the comments and renamed the `becomeOpen`/`becomeSuspended` methods below to make this more clear.
uncorking the write side is not logically connected with starting the read side, so I wouldn’t put these within one method
ah, now I see: we don’t necessarily have stats for all addresses
Adding more tests so we only do this when we have a codename: if cardname.simple? and !new_card? and Card::Codename[id.to_i]
I don't know a ton about frozen?, but I know it's not possible to unfreeze.  I think the issue is that Rails Cache uses this to avoid certain issues, but that this irreversibility is preventing Wagn from being smart in its own ways about these.   we really want to be able to figure out how to keep it from getting frozen in the first place.
This should use the Fuel::PRODUCTION constant.
The syntax is wrong, it should be: "__all__ = ('ModalView', )"
nitpick: for most other ProbDistI subclasses the first argument is named 'freqdist'
I didn't like the way it was rendered either but thought it was policy to let the render_document() handle it.

The reason I listed all the actions in detail is that I wanted the user to have enough information to remedy the situation.  The idea being that if an admin saw one or more 'pending' actions, they could fix the problem by making sure the agent is running on the consumer or trouble shoot the bus.  If the actions were 'failed' they still might trouble shoot it the same way but know that once it was fixed, to retry the bind (vs unbind).

I see where your coming from though.  If you don't mind me munging the data in the CLI, I'll take another pass at making this more digestible to the user.
Is `validate` supposed to return something?  If so, could we just test that it returns the appropriate thing (rather than testing that it doesn't raise an exception).
please add whitespaes before the || for better reading
Indent at 2 spaces using spaces
Just move the check up to after the new.

On Fri, Sep 28, 2012 at 7:19 PM, Cory Fields <notifications@github.com>wrote:

> In xbmc/windowing/egl/WinSystemEGL.cpp:
>
> > +
> > +  CLog::Log(LOGNOTICE, "%s: Using EGL Implementation: %s",__FUNCTION__,m_egl->GetNativeName().c_str());
> > +
> > +  if (!m_egl->InitNativeDisplay(&m_nativeDisplay))
> > +  {
> > +    CLog::Log(LOGERROR, "%s: Could not get native display",__FUNCTION__);
> > +    return false;
> > +  }
> > +
> > +  if (!m_egl->InitNativeWindow(&m_nativeWindow))
> > +  {
> > +    CLog::Log(LOGERROR, "%s: Could not get native window",__FUNCTION__);
> > +    return false;
> > +  }
> > +
> > +  if (!m_nativeWindow || !m_egl)
>
> will remove.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1493/files#r1715120>.
>
>
Do we need this in this example?
Do these all have to be invariant?
Weird diff updating.  This shouldn't be here, maybe it will go away :)
We use the Tiqr protocol. Animate is a competing product :)
Passing the version is perhaps better in a header and not in the data. Also, I don't see the app set the Http Accept header to JSON anywhere, this is how the server distinguishes between clients that understand json and those that don't.
Ugh, those darn tabs and spaces.
This should probably just abort().
I think this should stay named ```subject_covered_states``` because we are building up a set of states that each subject covers (and then we check those against the filtering criteria).
Can we use the Ruby 1.9 hash syntax?
Oh, right! I've rebased my sprockets patch onto Sprockets 2.2.1 as well as updating this pull request
Isn't this identical to `if token &&...`?
Oh that's a great idea! And I'll be able to put the logic of rewrapping the dummy with real args right into that object. Very nice.
Let's keep the review of the pull request focused on this pull request (i.e. on what has been changed), not on general details/fixes/cleanups for scala.concurrent. Instead, why not make a list of last minute clean up items like these, and make a separate pull. Else this pull request will no longer be described by its title.
move `quick_sort` to compatibility
This is a nice docstring, that was removed. It should go into the new functions/methods to show how to use it.
Please give an example of this. I havent really used this method before.
Interestingly, this doesn't compare equal to `A*A`.
Yes, in this case the user is expected to actually read the docstring. You would have `constructor(an_argument, another_argument, n=1, unimodular=True)` and expect the user to know how to use the function. Or if you wish you could have

```
def constructor(arg1, arg2, **kwargs);
    self.unimodular = kwargs.pop('unimodular', False)
    self.n = kwargs.pop('n', 1)
```

Thus, I still do not think that this decorator is a good idea.
I'm still not sure why this is necessary. The rows and cols properties defined in MatrixExpr should function equivalently and can't be assigned to. I don't care much about this though and am happy to merge without it.
Do you mean line 15 should be changed to:
```
pprint(pow((x/y), 50))
```
and line 17 to :
```
e = pow(sympy.Rational(2),50)/pow(sympy.Rational(10),50)
```
?
this isn't needed (?)
This is not the correct way to do it.  See sympy/external/tests/test_numpy.py.  You should use import_module, and you should set disabled=True to disable the tests.
There should be a docstring with one or two doctests showing how to use states().
> The problem I found was that Sphinx didn't recognize "API" or "Example" as valid headers.  So I've finally went ahead and modified the extension to accept arbitrary headers (as I suspected, it wasn't very difficult).  So now we can finally start organizing these long docstrings into meaningful sections (e.g., the docstrings of solve and simplify).

The problem with accepting arbitrary headers is that you then lose
consistency. e.g. it's suppose to be Examples (with an s). I would be
more in favor of adding whitelist section headers.
Yes, better to use `if(empty($this->children))`. Forgot about overall code consistency. :)

I guess it's faster to change it yourself, instead of pushing new commit to the merged PR.
The file will eventually need to be dynamic for the queuing functionality. In that case the filename parameter will be very necessary..
Shouldn't the binding get this value? especially with the `noDelay()`. Or is this just a work around?
Yeah; I think this is fine for a point release -- something like addressing table spaces (as per mailing list) is more on the fence-though, leaning towards 'probably not', and s3 format changes are always a minor version bump (to, say, 0.6)
LOLResource maybe? Please, let's not use the word "file"
Replace with "if question.is_multipart?"
you don't need to document which versions of windows are newer than XP here.

MongoDB does not support Windows XP. To use more recent versions of MongoDB, upgrade Windows.

revise and resubmit.
agreed to that Dan - will make the changes shortly - thanks!
This has nothing to do with timesync. Might want to pull it out FWIW.
Hi Scott, 

Sorry mate, I was not clear enough in my previous post. I've already pulled in your changes, altered the border class / specs and pushed to master. 
Can you update your fork with the latest master code? Hopefully there wont be too many conflicts.

Really sorry for the extra work on your part due to my poor communication skills!
Unneeded cast to list. `for f in Formula.objects.all()` works as well.
It looks like a string util. Maybe it isn't worth to make a separate function.

BTW:
```cpp
for (GLchar* end = infoLog + infoLogLength - 2;
while (end > infoLog && end == '\n')
    *end = '\0';
    end--;
}
CROSSCOMPILE should skip the appropriate detection steps, I don't think it should fake it here.
The restype of ```_ut_parse``` was correctly set such that, a bad unit, now returns the null pointer (or as ctypes, converts, ```None```), rather than an integer (this is tested indirectly).
I'm not sure we should have a default - there's no such thing in CF.
Don't ignore inline nodes -- iterate over them, just like in getScanNodeList_recurse . (Don't forget to remove the comment)
This comment feels important - but doesn't explain _why_ repair has to happen with the node connection removed.
or
<pre>
default_deprecation_kind = (
    DeprecationKind.objects.get(default=True)
)
</pre>
Yep, that'd be even easier (and clearer).

On Tue, Oct 9, 2012 at 7:29 AM, Quentin Poirier <notifications@github.com>wrote:

> In Cython/Compiler/ParseTreeTransforms.py:
>
> > @@ -179,10 +179,36 @@ def __init__(self, context):
> >              '__cythonbufferdefaults__' : self.handle_bufferdefaults
> >          }
> >
> > +    def _visit_DocString(self, node, nodeName):
> > +        result = getattr(super(PostParse, self), nodeName)(node)
> > +        if result.body.stats:
> > +            firstNode = result.body.stats[0]
> > +            if isinstance(firstNode, Nodes.ExprStatNode) and firstNode.expr.is_string_literal:
> > +                result.body.stats = result.body.stats[1:]
> > +                self.doc = firstNode.expr.value
> > +                result.doc = self.doc
> > +                return firstNode.expr, result
> > +        return None, result
> > +
> > +    def visit_FuncDefNode(self, node):
> > +        docNode, result = self._visit_DocString(node, 'visit_FuncDefNode')
>
> Since we're there, wouldn't it be better if I passed the result of the
> function?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cython/cython/pull/149/files#r1795682>.
>
>
PEP8 please.
this should be myapps/models.py or myapps.models
longitude, latitude pairs "in" units of degrees?
I don't think this is right - you can `setattr` any argument on a view, but it has to be `getattr`-able first.
There is no need to store the buzz client here IMO, especially as it will be wrong as soon as someone injects the buzz browser directly. If the browser is not injected explicitly, you should simply create the Browser relying on the defaults set in Buzz IMO
@vicb goutte 3.0 is not fully BC with 2.8. However, I think depending on ``guzzle/http`` should be enough
Assuming you left this chunk in by accident :)
Why do you call `str` thread-local?
The string cannot be passed out here;)
Same comments as above with respect to position and value.
yeah..this only fixed client hanging..
with this, client gets an error about disconnect and you can directly reconnect instead of ALT-F4ing client or waiting for a timeout.
Ahh.. right. My bad.
This is why i added `--recursive` above. It is called from the top directory and so it will recursively get submodules  in the vendor library too.
Looks like this was fixed upstream already.
Any reason why you're not using $this->prepare here, this seems to rely on PDO
Fixed the docstring.
In its current form, this appears to always filter out over18 if `c.obey_over18` even if `c.over18`. Instead, it should probably read:

```python
    if not c.over18 and (not is_api_client or c.obey_over18):
```
Ahh, good point. Does anyone see a way to fix this without making the resulting code worse than the loop? IMO this isn't very nice:

```Python
try:
    return next(l for l in links if l.sr_id == sr._id)
except StopIteration:
    raise NotFound
```

If this can't be helped, I'll close this, but what is the opinion on using ```link``` rather than ```l``` for generators/comprehensions? I could submit that patch as a separate PR.
Please don't add tons of state to toString. We should come up with a simple sane way for bindings to toString themselves . . . probably just the key.
Check your indentation
we want to use accountInstance, but it deleted after findaccount and inaccessible.

account = AccountsManager.getCurrentAccount();
account.accountInstance.setValue("pushName",pushname)
RuntimeError: Internal C++ object (Accounts.Accounts.Account) already deleted.

this is the reason
Not sure but I guess one could. I'll check this.

On Thu, Oct 11, 2012 at 10:25 AM, Carsten Urbach
<notifications@github.com>wrote:

> In solver/ortho.c:
>
> > +#include <stdio.h>
> > +#include <math.h>
> > +#include <time.h>
> > +#ifdef MPI
> > +# include <mpi.h>
> > +#endif
> > +#include "global.h"
> > +#include "linalg_eo.h"
> > +#include "start.h"
> > +#include "linalg/blas.h"
> > +#include "linalg/lapack.h"
> > +
> > +#include "ortho.h"
> > +
> > +/****************************************************************************************************/
> > +int ortho_new_vectors(spinor **Vecs, int N, int nv_old, int nv_new, double orthtol)
>
> the gram-schmidt we already have cannot be used here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/urbach/tmLQCD/pull/6/files#r1815676>.
>
>
デッドコードはコミットしないようにしましょう。
コミットする場合は、その旨をコメントしておきましょう。

後、基本的にソースコードのコメントはシングルバイト文字を使うようにしましょう。
マルチバイト文字は、環境によって文字化け、バグの原因になることがあります。
Won't work since it missing cb(), exec() is async() and will just be skipped because of missing cb(). Same with the above.
I don't want to align parameter descriptions
Relevant point. I think an IllegalAccessException will be thrown. We should catch it and throw an error more verbose. What do you think ?
YIKES. Thanks for catching that.
@peterflynn .less files now show up as "Less". Let me know if you think this should be "LESS".
Seems like we're vulnerable to a race condition here...if the rules aren't reloaded by the time the next cursor movement happens, we'll get stale data. Probably an unlikely edge case, but you could fix it by storing the promise somewhere, having `onCursorActivity()` check if the promise exists, and if so, have it do the highlighting in a `done()` handler for the promise instead of right away.
I don't see you checking on this boolean cachedHints.waiting. If you don't need it anymore, then you should remove all instances.
Escape (and those below).
Race condition:  if two threads call this function at same time ... who wins?  Likely should take the lock here and have any wrapper for drain_thread_pool (drain_thread_pool_lockme) that allows external call directly to to drain function.
Nice I tried a couple of other attempts but missed this. I'll update the code,
I see .. I guess moving the if deeper down would make things more readable .. like this maybe ?

SumValue calculationValue = (SumValue) valueService.getCalculationValue(calculation, location, period, types);
if(calculationValue != null && target.getAverage()) value = calculationValue.getAverage();
else if (calculationValue != null) value = calculationValue.getRatio();
I don't know if I should propagate the error or not... Your opinion ? That error means to me that it's not possible to get the map data source but my module is useless without data
because file_default itself has a default value, URIs with no 'file' component are legit
Use #414449 and  #282828
Typically we slide the icon over a bit but since this is a special one, we don't need it
Extra whitespace can be cleaned-up too
I'd say don't even bother adding this stuff. As long as it's obvious that you can add stuff to `butter.project`, let's just use that.
As above, try and keep headings correctly nested
I have learned something new  :)
This is not a 1.8.6 method.
why it bypasses the subrequest module?
Please add a blank line above.
the path (\"%V\") of dso module should be an absolute path
Well while it isn't necessary, I wrote it this way so you can use it like this:
```C#
SendMessageByType(ref session, (byte)MessageType.ChatMessageMonsterSay, language, chatMessage);
```
for example
And how would you make it increment? The only way I can think of is:
```C#
ChatMessageSystem = 0x00,
ChatMessageSay = ChatMessageSystem + 1,
ChatMessageParty = ChatMessageSay + 1,
```
If you want to refer to the name ChatMessageParty, you have to define it somewhere first, and this seems like the best way to do that, because I personally wouldn't like to search for every type of message I use.
If I'm wrong then correct me please.
$this->paginate is deprecated but $this->Paginator->paginate is also wrong. It should be $this->Paginator->settings
It will continue to be a stand alone library. We are not putting a drupal module file into it however. I want to keep tuque both islandora and drupal agnostic.
Oops, I needed check lua_isnil to be false. The change probably would be good as import luad.base isn't needed then.
Synchronization plans are used to configure the scheduled synchronization of the repository with the upstream.
Good point, all other subcommands are checked on the server side, except system group ones. I am going to issue an error when more systems with the same name are found (we do not want user to accidentaly add more systems). He can use uuid for that - that was the reason why we are adding it.

FYI I have accidentally squashed my fix, therefore I am forcing fast-forward push. Sorry about that, github handles this correctly but you want see the difference nicely.
Yeah, that sound perfectly reasonable to me. I'll push up a fix.
Yes the cache part and that name is good.
All your patches must be stopped in the `tearDown` method.
Good question! Right now, it will still launch the executable. It will try to talk to the first running instance though, so it should still work, but you bring up a good problem, and I have filed a bug about this: https://bugzilla.mozilla.org/show_bug.cgi?id=742794

Once this bug is fixed, we will abort if there is something using that host/port combination.
It you're talking about size bloat, Android is barely 'embedded' anymore, they have gigabytes of ram, and multi-core multi-ghz cpu's.
I didn't think O2 performed inlining very much(?), but I suppose you're right, 'Optimise' should be balanced I guess..
`can be converted to by simply` -> `can be converted by simply`
Good point! I actually haven't done much with python 3 yet. So I installed it and ran the tests. I'll change the print statements but will have to figure out why some tests are failing.
干嘛注释掉？
You use `{riak_kv, node, gets}` as an example, however, only lists work, not tuples... is the doc or the code out of sync?
Same fRun thing here too... someone should probably note whether -32700 vs -1 is the correct response?
I've merged in #829 as well.
I don't think this is safe now that `mem3_shards` has an LRU expiration policy.  We added a `mem3:get_shard/3` function to deal with that.
test data？
static_cast<NSInteger> should fit a lot better
Thanks for all of the feedback and help Craig.  I will take a closer look at these and let you know if I have any questions...which I think I will.
`float()`
This title would be clearer if it contained a verb
should be UNIMPL instead of HACK, same for the next two