labofsahil/github-event-dataset-2012 huggingface dataset:
I'll add
     //Use atomic_cas so that only one thread can increase the number of pages at a time.
    //(Don't use atomic_add because we need to check the limit hasn't been exceeded.)

It could use atomic_add for the !pageLimit case.  In fact it might be more efficient as

            if (totalPages <= pageLimit)
            {
                //Use atomic_cas so that only one thread can increase the number of pages at a time.
                //(Don't use atomic_add because we need to check the limit hasn't been exceeded.)
                if (!atomic_cas(&totalHeapPages, numHeapPages + numRequested, numHeapPages))
                    continue;
                break;
            }
            else if (!pageLimit)
            {
                atomic_add(&totalHeapPages, numRequested);
                break;
            }
URLのファイルパスをqに渡さないとフレンドリーURLが機能しなくなりませんか。
別の解決方法になったんでしたっけ…。
btw, your bundle will work properly with 0.5. The only change since the latest release is adding a check for the case when the fileinfo extension is not loaded, and adding an exception for an invalid use
thanks dzo, you seem right, its a security function.
`timeAsString` → `timeStringRepresentation`?
thx, you just finished one entry in my todo list :)
but yeah, airflow would need to be changed >.<
For those interested it's possible to support node, amd, and the usual global module patterns with dependencies, but it takes a disappointing amount of boilerplate (https://github.com/umdjs/umd/blob/master/returnExports.js). I still think its worth it, but whatever ...

When amd becomes more standard, maybe it'll be worth it to @documentcloud. For now I think this commit is the right move though.
Hi, thanks for this pull request! Big thanks for that, but i do have other plans.

I did have planned to rewrite the whole plugin where all Data like last state, owner and so on is stored in meta data and can be variable so the only thing that will be left in the mains stargate table will something like { id, metaRefID, GateName }.

Everything else will be stored in GateMetaData Table where the following column names are present { p_id, p_metaRefID, type, key, value }

p_id and p_metaRefID will be primary key. where type will be something like category and each attribute will have its key value pair.

The benefit (beside that it will safe tons of data) will be that i dont have to change the layout everytime i add a new feature to a gate and that it could be modified externally very easy.

Anyways again thanks for this request!
我已经你的提交合并。参见 commit: 446be418f7b668e400003f3d0f5ac3837ded3684
Part | Points
------------- | -------------
base | 1
*Total* | 1

Passes tests. :sparkles: 

```
Traceback (most recent call last):
  File "hw08.py", line 6, in <module>
    from math_funcs import *
  File "/Users/jacklaxson/Projects/homework-cs112/mitkrieg/hw08/math_funcs.py", line 34
    
        ^
IndentationError: expected an indented block
```

is caused by:

```python
def normalize(vec):
    
```
next time comment it out or put in a `pass` statement.
Yea. I suspect it's the latter as you've done a good job fixing all the declarations to the liking of C everywhere else.

Btw, the reason I needed debug version is because somehow I can't get https to work. Either cacert.pem isn't picked up from where it should, or I'm using a bad cert file. Either way, I needed to get debugging the code. Any ideas on that front?


Oh, and since I'm at it, do you have any thoughts on supporting multiple visual studio runtimes of wincairo in webkit-update? As in specifying the VS toolchain version and update gets the correct binaries built by the corresponding toolchain. This is useful if one doesn't want to have dependency on multiple VS runtimes just because of wincairo.

-Ash


________________________________
 From: Brent Fulgham <reply@reply.github.com>
To: Ashod Nakashian <ashodnakashian@yahoo.com> 
Sent: Monday, February 27, 2012 9:05 PM
Subject: Re: [WinCairoRequirements] Correction to the objc debug build. (c23dfd3)
 
Nice catch. Either I'm building this as objc++, or I have not built a debug version of this recently. :-\

--- 
Reply to this email directly or view it on GitHub:
https://github.com/Ashod/WinCairoRequirements/commit/c23dfd36eb8549b13afea2dc1f25012a1666390c#commitcomment-1015902
That concerns me a bit.  It means that the PEAP config has a bunch more TLS configuration items, which *might* conflict with the PEAP ones.

How about this logic instead:

- no "tls" item == use EAP-TLS configuration
- if "tls" is a CONF_PAIR, treat it as a reference to a configuration.
- if "tls" is a CONF_SECTION, treat it as an in-line TLS configuration section

It's a little more code, but clearer to the end user, I think
I am sorry but I cannot reproduce the error. Hopefully you found a solution and will push it.
As far as I can tell,  either should lead to the correct behavior,  so I think there is a problem in your test suite.     Are you sure that the backend has inferred the bytea type,  and you aren't trying to round-trip through a plain-old string type?    Also, what version of PostgreSQL are you testing against?
This is a regular commit comment.
I was wrong , this overclocking values worked bad.... i'll revert later
should this not be the selected level?
bleh.... nope.... no time to much stress at work....
we could use something like

https://github.com/Captnoord/offline_pkt_handler/blob/master/src/PyUnicodeUCS2.cpp

that way we can also incorperate it into the server.
Gracias, Enrique!
Let's say: Pöser Gyros :D
Joe where are you calling this?  We have issues with this plugin as well, we are submitting forms via ajax / $.serialize().   $.serialize() calls val() on the form elements.  Also we are using jquerytools's validator widget to validator our forms.  I've fixed an issue where the form was not getting reset: https://github.com/egnyte/jquery-placeholder/commit/925dd93d5201e892a6e6ab6d650a6ff290a38e66

Rather then depend on the ordering of form submit handlers, I'm working on adding a 'valHooks' for text input and textarea.  What do you think of this approach?  Would this help you guys.

-s
> It looks like SQLiteDatabase.update() returns an int for number of affected rows. So why not attempt an update first, if 0 rows are affected, then do an insert? This would save you the fetch at the beginning.

This is exactly how Fennec does this sort of thing. Common pattern.
Continuation committed in 73086af436ced64f59ab7a19ced111dbdc2664f0.
Count обычно называют счетчик. Можно numRows, numColumns
I'll remove both lines
@johnpolacek thanx for the fix :)
If you change the indentation of existing code please do it with a separate refactoring commit so it's easy to see what the actual logic changes are. This makes my job of merging things together easier. Thanks.
ohh my god :(
I am moving this project over from my project, Ultimate LESS Mixins and missed to change some things.
need to rename the qsd8 folder to qsd8k as being called from android.mk
It should fall back to an in-memory store if `Y.config.win.localStorage` is not available.
If you didn't get a reply back to me (apparently I never got these emails), why was this pull request merged?
Actually, __DIR__ doesn't seem to work. Going to stick with $dir.
Yes, and this might be related to some of the failures. Doing this one now.
add FIXMEs for when we go final?
why not use `toSet.max` instead of `foldLeft` ?
I have no idea if this is important or not. Is the test trying to see if `rInt` can be converted implicitly into a `Nothing`?
Nothing special, but RouterEnvelope on the other hand always unwraps before sending to destination. Broadcast is a RouterEnvelope.
I've removed the comment, the code works fine, nothing wrong with it in my opinion.
Isn't the name replica a bit confusing? No data is replicated, just more than one intervals mapped to a node on the ring. WDYT?
The disadvantage is that we don't do it like that anywhere else, so I wanted to know if this new idiom carries its weight.
Since it's not traversing a sequence but only flatMapping options you might as well do it in the yield IMO.
What does "ewma" mean?
You can close the "li" tag if you would like to embrace links into a list
The revisioning helps me sleep easy at night.  I do not personally care about an interface for it but it is nice to know any change is logged somewhere and it seems a shame to kill something already working.  My experience with model changes like this in CKAN is that they take much longer then you think and I would avoid them if at all possible.  The migrations are painful too as you normally have to rearrange the foreign key constraints.

Did you mean public/private should be part of the dataset?  It certainly should not be part of the group. I agree it makes more sense as part of the dataset  and would make the search/dictization code much cleaner.

As a compromise we could just change the name "capacity" to "role" and have it null when when a dataset is attached to a group and make a new field against a dataset called 'status'  (which would be public/private).  Its not perfect but I think this change will be much easier.
This won't raise a MissingResource if the schedule doesn't exist. Doesn't it need to for REST purposes? Even if this is run through the coordinator, for resources we're not doing a no-op for delete on a missing, it's still a MissingResource.
don't love the trait_ok! api.  reads awkwardly.

 more importantly I suspect this will break on unknown local variable (role_card)
val traceContext = originalContext map (context => action.tracer.createSubcontext(context))
if (traceContext.isEmpty) debug("Outgoing request has not trace context! {}", toRpcName(action, message))
think seq.take(scnCb.nb) would be more efficient insead of rescanning the full list everytime
I followed how it's done in org.jboss.weld.tests.specialization.weld802.SpecializationWithExtensionTest.
I will try it with addAsServiceProvider, it would definitely be simpler.
Why is this needed. It's not done everywhere. If it's needed it feels like it would be something the playercorefactory should take care of.
This file should include what is needed for the codec id list. Then we should include this file in any place that need the codec id enum.
So we never want to use what Xutf8... has returned then? Ie i can move that call to right after with a comment?
ah sorry, I missed the fact that you are in a subnamespace
$variabelen buiten quotes plaatsen.
$var = "$a $b";
versus:
$var = $a . ' ' . $b;
If this isnt really used, are you sure you want to include it?
This is a pretty weak test; you should have at least two files, and at least one of them should be subdirectory.
I guess so that external users of opts could ask whether they were defaulted, or set somewhere?

Maybe yet another reason to go 0.4.
We already know `err` is falsy here - figured it's better to be explicit
https://github.com/peters/pty.js/commit/556593887bb3bda48b1f59ae1e964aecd1d1b545
When UdpNEttyTransport and TcpNEttyTransport are differnet classes they also have different config, so no need to check these invariants then
"Level2section" as a title to display in the UI, really? :)
As above, let's move the `return` down.
This cast should not be here and could be potentially unsafe. Evaluate the current setting and pass in the appropriate type.
Spaces on all three of these lines
`NSPopover` has a somewhat strange API and shouldn't necessarily be used as a guide.
These keys should be pulled out into constant strings so the code doesn't get out of sync.
We replicate the functionality, so there is no need to do so.
Needs to align. (Same for `NeedImmediateCallbackSetter()`).
As a minor optimization it might be good to save the new count when you compute it. So

    var oldCount = 0L
    var nextCount = 0L
    do {
        oldCount = nextCount
        ...
        nextCount = tc.count()
    } while (nextCount != oldCount)
Same here, ``ndarray`` isn't a dtype.
I see what you mean. But that's a general problem that all functions accepting a string have in PHP. Not sure whether it makes sense to check for it. But if you keep the check the error message shouldn't use ucwords (just normal lowercase).
Should this be `Z_TYPE_P(tmp) == IS_STRING`, rather than not IS_NULL? From context, it's obvious that the only two possible zval types for tmp are IS_STRING and IS_NULL, but this strikes me as a potential gotcha if the function is changed down the track to return more native PHP types for numeric values.
а нельзя ли написать комментарий на одной строке, но как-то более связно и чтобы объяснялось, зачем они нужны тут?
а зачем мне отрицательные номера?
что за -3? лучше объявить все эти отрицательные константы enum'ом
Дыло бы неплохо звездочки расставить в едином стиле по всему проекту. Вариант тот, что строкой ниже все же чаще по проекту встречается.
actually if my code is ok, it could look like:

```ruby
stale_target? || find_target? ?  find_target : @target
```
Can you add parenthesis here? It will cause a warning without them.
Do we need this `0.5`?
I had same results removing and changing to ``Array()``
I reviewed this one but don't figure it out why this is not being called. @jeremy @fxn any clues?
We can optimise this one better by checking if the `cbf` produces a combiner (see `ToParCollection` in `ParIterableLike`). I will submit a patch once this is merged.
This is simple enough that it should probably be in-lined.
Assumption fail to detect that n**2 + n is odd if n is an integer (note the None result from input 4 above).
Perhaps note here that this merges the properties of morphisms in premises and conclusions? Otherwise, how is this different from just the conclusion?
Ah, sure!  It was like that in the previous version, so I automatically left it like that.  Fixing.
"Ein Bruch aus" --> "Eine Division von"
On 13.04.2012 05:54, Christopher Smith wrote:
>> +    Note that many algorithms only work with *global* orders.
>> +
>> +    For example, in the inverse lexicographic order on a single variable `x`,
>> +    high powers of `x` count as small:
>> +
>> +>>>  from sympy.polys.monomialtools import lex, InverseOrder
>> +>>>  ilex = InverseOrder(lex)
>> +>>>  ilex((5,))<  ilex((0,))
>> +    True
>> +    """
>> +
>> +    def __init__(self, O):
>> +        self.O = O
>> +
>> +    def __str__(self):
>> +        return "i" + str(self.O)
>
> Stopping here for today.
>

Again, thank you very much. I really appreciate all the work you are 
putting into this even though you have hung up your hat.
Test added for no-repeats in TransformationSet.
I think better to remove the commented lines.
if this is passed in and is not a Container, you should create the Container when the tip is shown.
Your git settings might be off as this whole file is marked as changed.
Actually, yes. All tests assert after uv_run returns, so we'll catch problems if something goes wrong anyway.
I mean we never change the parameters once they are defined.
ooops, I seemed to have missed that
shouldSetColumnNullable? or maybe shouldSetColumnTypeToNullableBigInt? (or similar)
c/resistent/resistant
I don't see what the benefit of inverting the first sentence is. It buries the more important and less intuitive point (that chunks are only split after inserts/updates, and as an aside, we should check to make sure that splits can follow updates, and not just inserts, becasue that might be wrong) in favor of the more intuitive point (that chunks are split when they get too big.
It must be, since, e.g., a JSON array of Chef Node objects gets inflated to a ruby Array of `Chef::Node` objects. No problem with switching it to YAJL.
please use $db->sql_build_array('INSERT',...
Rather than copying & pasting documentation you can simply use {@inheritDoc} for the entire docblock here.
yes, and index_page_title is the php event to put your information into the template so you can display it here.
Can phpbb_version_compare be used here?
INACTIVE_ERROR might be easier to figure out.
Hmm, persisting a language-based string here.
any reason to not do this in lua?
This could be replaced by C++11 move constructor.
Please indent using two spaces and don't try to align function calls within the call, as this wrapps your code way too far to the right.
http://hydra.nixos.org/build/3009964/download/2/manual/#chap-conventions

An example for this case:
```nix
  desktopItem = makeDesktopItem {	
    name = "IntelliJ-IDEA-CE";
    exec = "idea.sh";
    icon = "idea_CE128.png";
    comment = "IntelliJ IDEA Community Edition";
    desktopName = "IntelliJ IDEA CE";
    genericName = "IntelliJ IDEA Community Edition";
    categories = "Application;Development;";
  };
```
Do all these fields need Ids for some reason?
Indeed. But we don't want that guarantee. If you forced the projection you wouldn't be able to do:
```
plt.subplot(2, 1, 1, projection=my_own_projection)
iplt.contourf(cube_on_a_different_projection)
```
It might be worth adding a little note somewhere, stating Jasper is required to read JPEG2000 compressed GRIB2 files.
I get (presumably the same) interesting results. Do we know why the test with `np.any` is `False` and the other two `True`.

I agree that we could use the test you suggest, but I'd like to understand why it is different, and whether it is likely to change behaviour.
Docs for this file?
Can you investigate this? Can you check if the transpose have tests? Can you run them in DegugMode? Normally debugmode should raise an error if the op forget to set the view_map field. Can you test that scipy really return a view by default? Maybe the doc is wrong for some reason.
I'm not an expert on the topic, but don't we need to do something about the license here? Apparently it's "MIT license", but I couldn't easily find its exact formulation.
http://grammarist.com/usage/gantlet-gauntlet/
Suck it Trebek.
Надо убрать из default-arch знание про Лего, потому что Лего снаружи недоступно
I'm not sure enough either way to make any solid claims - regardless it works as is.
Fair, that's me misunderstanding what the tag actually does. Looks great then!
I meant bufstate. I'm just not sure why you don't try to check if there's a full message in the buffer before receiving again, it doesn't have to be a state. Just like what we do for HTTP, we only try to recv if we need to after processing the buffer.
Same as above, why not reference these as `{@code Iterable}` and `{@code Collection}`?
Actually, I think you're right rick, but for a different reason. The else if is always true, because oldIE only has `loading`,`interactive`,`complete`, so I can remove that too! Thanks!
Just realized I forgot an "expects(16)" here, will fix shortly.
The way this is unwinded is good.

Short term break the regex into many regex at ``|``.

Long term fix is to read the CSS spec and figure out many regex that will be able to parse the components. Each regex should fail fast for the wrong input, even if it is a really long string.
I'm not certain, but wouldn't you want to avoid the integer rounding by doing this? :

``` csharp	
    -origin.X * (float)destinationRectangle.Z / (float)texture.Width, 	
    -origin.Y * (float)destinationRectangle.W / (float)texture.Height,
````
The `$.fn.data` method will automatically JSON-decode things that look like JSON data.
Is there a correct way to be linking dependencies to dupes formulas or should I just let it build against the OS X distributed version?
Check the URL here.
I deleted the other code because just setting fetch_objects to True in txriak_manager would leave the code I deleted untested and unused. Setting fetch_objects to False doesn't seem that useful -- it's just result in O(N) HTTP calls again (so I thought it safest just to drop the option).
Тут должно быть не "в течение большого промежутка времени", а "на протяжении большого промежутка времени"
Is there a reason you're letting save failures not affect the sync result? That call is safe from duplicate key exceptions so if the intention was to act as a uniqueness check it's unnecessary. If that call fails it's probably indicative that something's gone badly wrong and you'd want to let the error bubble up.
Jupp genau. Davon hängt auch ab, wo der FilterIterator sitzen sollte. 
Aber bei ignoreDirs() sind wir uns ja einig, dass da die rekursive Denkweise sinnvoll ist, oder?
Und ich würds dann halt einheitlich machen.
Nit: for `unittest.TestCase` subclasses, the output for failed tests is a bit more friendly if `self.assertEquals(leftside, rightside)` is used. Example:

```
kemitche@kemi-reddit:~/tmp$ python test.py 
FF
======================================================================
FAIL: test_one (__main__.TestFoo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test.py", line 8, in test_one
    assert self.a == self.b
AssertionError

======================================================================
FAIL: test_two (__main__.TestFoo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test.py", line 11, in test_two
    self.assertEquals(self.a, self.b)
AssertionError: 'foo' != 'bar'

----------------------------------------------------------------------
Ran 2 tests in 0.000s

FAILED (failures=2)
```

Note how the second test shows what the values of the passed in variables are.
Nice! Nitpick: should you allow/consume `{w}` whitespace before the commas as well?
I removed redefenition of `[]=` since you said it's out of scope.
01922f8
suppress warnings? I still think this should extend Binding<Set<T>>
Done, moved to org.webbitserver.helpers as XssCharacterEscaper
Originally, the DEFAULT comparator compared the hash code of the two names, and if the hash codes were equal then it compared the full signatures.

The initial version of my patch changed the DEFAULT comparator to only compare the names themselves, not their hash codes.  But I subsequently reverted that based on feedback from @dsaff so the hash codes are once again compared.  The commits you now see linked from this pull request no longer change the original behavior.
Maybe a TInt21TripleObjectHashMap<Model> to store with the position ? HashSet don't allow to get the old model with the newest.
The trouble is with the Partition.Update() method. I can't think of a way to properly implement that method without locking, even if I use ConcurrentDictionary. The ConcurrentDictionary.TryUpdate method requires that the caller provide the value that is being overwritten. We would need to look that up with a separate call, which means we'd need either a lock or a loop.

I think I'd rather just leave the code lock-based, the way it is now.
Whoa. Bad merge. Thanks!
Bug fix: events now come with the event object.
These are great!  Very thorough.

One more area to cover, though: please add tests for the first/last-line edge cases (moving the bottommost line up or the topmost line down).  If I comment out the inner `if` in moveLineUp(), none of these tests will fail... but moving up the last line in the file will be totally broken.
Typo - move "a" before "generic".
Should just leave off `doc` here (but clarify with a comment that we're leaving it undefined on purpose).
Is this to prevent the browser's default key event handling?
Filename in comment doesn't match actual filename
Wouldn't it be nicer to do this?

```javascript
var server_exclude = (user.permissions.server_exclude || "").split("|").filter(function(cmd) { return cmd });
```
Do the `&nbsp;` directives really need to be there?
Yeah, was actually a mistake in the original reminder code.  I noticed it while fixing the "until" on a date functionality.
yeah, it's not used in this particular instance, but it will be used when i actually use InterfaceEditableItemMixin in some of the hqbilling stuff
Yea.. so what I don't like about this, is the following:

{DAV:}authenticated and {DAV:}unauthenticated kind of made sense to me to use that as a replacement for the 'principal name', but this is something else entirely.. it shouldn't be {DAV:}owner, but really {DAV:}property..

So what I'm thinking; in it's simplest form (array) privileges (or ACE's) are structured as follows:

```
$privilege = array(
  'principal' => '..', // {DAV:}authenticated or a principal uri
  'protected' => true/false,
  'privilege' => '{DAV:}read'
);
```

And this kinda made sense for authenticated, but maybe not property.. it's a more complex rule.

So perhaps a better way would be to do:

```
$privilege = array(
  'type' => Sabre_DAVACL_Plugin::ACE_PRINCIPAL,
  'principal' => '..', // principal uri
  'protected' => true/false,
  'privilege' => '{DAV:}read'
);
$privilege = array(
  'type' => Sabre_DAVACL_Plugin::ACE_AUTHENTICATED,
  'protected' => true/false,
  'privilege' => '{DAV:}read'
);
$privilege = array(
  'type' => Sabre_DAVACL_Plugin::ACE_UNAUTHENTICATED,
  'protected' => true/false,
  'privilege' => '{DAV:}read'
);
$property = array(
  'type' => Sabre_DAVACL_Plugin::ACE_PROPERTY,
  'protected' => true/false,
  'privilege' => '{DAV:}read'
  'property' => '{DAV:}owner',
);
```

To make this even a bit better:

```
class Sabre_DAVACL_ACE {
  const AUTHENTICATED = 1;
  const UNAUTHENTICATED = 2;
  const PRINCIPAL = 3;
  const PROPERTY = 4;

  public $type;

  public $principal;

  public $privilege;

  public $protected;

  public $property;

}
```

It would be a bit of refactoring, and a bit of a BC break, but it would be the most ideal / understandable; and matches your requirements.
The biggest issue is that any getACL() and setACL() method of all the nodes would have to use this class; but that's a level of BC break I can live with for version 1.7. It's a big step up in any case.

Now, if you feel like.. not doing this, I understand. It's beyond your original goal, but for SabreDAV i feel this all makes a bit more sense :)
Cast should not generate a compiler warning.  Also, an instance of check followed by a cast in any self respecting IDE should not generate an error.
You just extend `validate` method (first call parent, then continue with range checks). You can also create maybe a generic field which can take upper date as argument and checks against that and then you set this parameter to current day, for example.

For such things it is always the best to check how existing (provided/official) fields are defined.
Yeah, silly title. :) Improved, hopefully.
Add also `link_caption`, `link_description`?
We can leave comments out. Git history is useful.
Why have two lessToCSS blocks?
Instead of this, can you expose an API endpoint in `crashreporter` to just execute a test report?
all of the lines in the above function are indented too much.

change them to 2 spaces
capitalize the L
Don't we already do all of this work? Is there some way we can tack it on to the projectData object so we don't have to repeat this step?
Whitespace around "title-card"
This looks like a good idea, but adding new features means adding documentation too :-)
I can even do it for you, but I need at least an explanation of how it's meant to work.
Well, but you can still do `nosetests -v` right?
This is same implementation (done in same way) as method above. NPE will happen in both, if you pass in `null`.

The Goodies are not yet released, and template was added in latest snap, so that would mean releasing Goodies, bumping it in nexus and then we could use it....
The scala style guide seems to suggest that I should not use braces in this case.  I'm not certain that this will become more clear if I wrap it in curly braces.
Yes, that makes sense. I was looking through the source trying to find where there might be a phantom type :).
Is it really 8M on your system? It's 8 here.
nice, no half measures for tandem
Returns an `Eventual` value fulfilled with `onFulfill(fullfilmentValue)` (where `fullfilmentValue` is what `value` is fulfilled with`.
Didn't we move these out of this glue layer?
When the product is saved, there is a before_save filter that will assign the label.  At that point, it will perform a 'labelize', check for uniqueness and either use it or append "_"+cp_id to it to ensure uniqueness.   As a result, I removed the label here to avoid the duplicated labelize.
indeed. I missed it because I created the file by copying the ListRenderer
This is **very** ineffective. You are looping over all the array to add **one** point.

A much better solution IMO is to do a recursive check and then look **only** at the new part:

```
for p in array[:-2]:
    if not deviation<epsilon:
        add 50 more points
        call the same function on  the new 50 more points
```
Use linebreak instead of `---`
This comment was there before. I don't know what does it mean.

On Fri, Sep 21, 2012 at 5:27 PM, Paul A Martel <notifications@github.com>wrote:

> In src/ee/executors/unionexecutor.cpp:
>
> > +            //
> > +            for (int ctr = 0, cnt = (int)m_input_tables.size(); ctr < cnt; ctr++) {
> > +                Table* input_table = m_input_tables[ctr];
> > +                assert(input_table);
> > +                TableIterator iterator = input_table->iterator();
> > +                TableTuple tuple(input_table->schema());
> > +                while (iterator.next(tuple)) {
> > +                    if (!m_output_table->insertTuple(tuple)) {
> > +                        VOLT_ERROR("Failed to insert tuple from input table '%s' into"
> > +                                   " output table '%s'",
> > +                                   input_table->name().c_str(),
> > +                                   m_output_table->name().c_str());
> > +                        return false;
> > +                    }
> > +                }
> > +            // FIXME: node->tables[ctr]->onTableRead(undo);
>
> I don't understand this FIXME line. What's broken?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665939>.
>
>
"behold into" -> "beholden to"
It doesn't worth such a complicate pattern:

      const DEBUG=false;
      function debug(msg) {
        dump(...);
      }
what about dump(data + '\n');?
I don't fully understand why you made this change... shouldn't .rst files be in ``docs/autsummary`` rather than in the source tree?  Thats my understanding of how autosummary works (although I admit I haven't yet tested it)
These will come out nicer if you directly reference the methods so that hyperlinks appear in the sphinx docs.  E.g., `` `~astropy.cosmology.core.FLRWCosmology._efunc` ``.  Note the use of ``~`` at the beginning - that will cause the link to appear in the sphinx docs as just "_efunc", but it now also points to the current documentation page.
Fair enough... would you prefer ``'scipy, matplotlib'`` or ``['scipy', 'matplotlib']``? (I think I prefer the former)
Could you add an "!" at the end of the message? Yes a nitpick ;-).
Is the app folder always going to be named App?
"void* arg" is really really non-descriptive. Why does it need to require a void pointer and how about calling it socknameOutput so we know what it will be set to?
I'm indifferent in this case. I'll move it if there is a good place for it to live. Is this `enaml.utils` material?
This shouldn't be called 'Orders'
I just checked and you're right, LagartoDOMBuilders can't be reset
My bad and will do. 

Open to other feedback on the pull request as needed, of course. 

On 2012-09-05, at 8:08 AM, Matt Burke <notifications@github.com> wrote:

> In GitTfs/Commands/Info.cs:
> 
> > +    public class Info : GitTfsCommand
> > +    {
> > +        Globals globals;
> > +        TextWriter stdout;
> > +        IGitHelpers githelpers;
> > +        IHelpHelper help;
> > +        IGitTfsVersionProvider versionProvider;
> > +
> > +        /// <summary>
> > +        /// Initializes a new instance of the Info class.
> > +        /// </summary>
> > +        /// <param name="globals"></param>
> > +        /// <param name="stdout"></param>
> > +        /// <param name="githelpers"></param>
> > +        /// <param name="help"></param>
> > +        public Info(Globals globals, TextWriter stdout, IGitHelpers githelpers, IHelpHelper help, IGitTfsVersionProvider versionProvider)
> Not all of these objects are used. Please drop the ones that aren't.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Don't now sql well, but looking for the answer to this question, `DISTINCT`seem a more appropriate way than `GROUP BY`.
Am I missing something ?
Oh weird.  What happens in KDE?  The file contents are inserted?
Can you change this to `print("Hello World")` so it's easy to test from Python 3 (I've just done it locally, and it does work). The brackets are valid in Python 2 for a single argument.
doesn't need its own file.

make VirtualMachinePredicates.isTemplate

move this to a static inner class, and use to impl ^^
This method should accept Iterable or Collection\<String\>
You can remove this `fieldnames` parameter. `DictReader` will use the first line of the CSV as delimiters. Then you can remove the line `next(header)`.
The phrase "click to hide more information on this topic" seems a little clunky, and may be especially confusing when translated. Maybe just "Click to hide this topic"?

This is really a copywriting thing, not a code thing, I just want to make sure the instruction is clear before we commit the strings for l10n.
We don't want to force pip or virtualenv on everybody.
Yay for extracting repeated code!
Add an extra space before the `#` just for consistency. </nitpick>
I think the problem is, as you said a bit later, that I don't verify it's not empty. I'll change it to the following and keep that exception's name if it's ok with you.

``if params["signature"] is None or params["signature"] == "":``
I'm still unhappy about this and I should have voiced it more earlier. 

This file is in external but you're using it as a web service. I know we've been talking about a major refactoring but for now can we make it a bit more right instead? 

1. Instead of calling it `json_result` (because it's not JSON anyway) we call the variable `result`

2. Instead of swallowing the error, let it raise. This is quite a low level API class and the swallowing should be done "higher up". 

Also, does a cursor need to be closed? If so, the other code I reviewed this morning needs to close the cursor too. And if it does need to be closed, that can go wrong and that would mean the `connection.close()` doesn't get called.
You are right, it returns a 200. The problem though is that if I return a 400 or 500, I can't return any custom error message, and then we can't tell our user what went wrong server-side. I believe this is a limitation of web.py, and I suggest we leave it as is for now until we have a better tool and can return better errors. Thoughts? 

If I'm wrong or just missed something, please correct me, but I think it's impossible to send a custom error message with a 500 HTTP error in the current state of the middleware.
Next line here for the `{`.
We have now found that this throttling on failing local:// requests broke scenes that have large amount of EC_Materials. EC_Material "broken" flow changes timings because all of the output material refs did not fails at once when the scene came to the client. When some of the EC_Material output material request in EC_Mesh failed here with a delay it broken the "hacked/to be removed" logic of AssetRefListener to hook to AssetCreated when the request failed. Now when the request failed AssetRefListener was too late to connect to AssetCreated, as the generated output material had already been created and that signal for the failed ref never came. Hence no reloading after the creation was done and EC_Materials broke.

The EC_Material logic is completely flawed and I'm working on a fix right now  that would not require us removing these throttling lines. But it seems that it may be required. Once fix im doing is creating a notion of "generated://" refs that are never requested from the AssetAPI in AssetRefListener but it waits of AssetCreated signal and then monitors Loaded for that generated material, I also had to add proper Loaded signal emitting after dependencies have been fetched for cloned material assets.

P.S Scenes with ~low amount of EC_Material output request fails will not break because there are so little of them that this throttling never hits in. Once it does you are screwed, eg. hundreds of EC_Materials in scene.
@jalliot I'm ont it
Client::enableProfiler() with profiler existing
profiler service is removed from the container
Client::request() -> fatal error, although it should just continue without profiling
the same goes for the `==` above as well.
Also, what about moving the `FormHelper` to the Templating component too then.
extra spaces here :)
Can you remove the parenthesis as they are not needed here?
information without s
Why is there some logic creating a Reference here ?

And btw, why ``_services`` ?
This will fail on PHP 5.5 as it does not throw a LogicException but a warning
we dont have StudlyCase variable names but camelCase. Also the name could be $util instead.
No, if `htmlPattern` is null, it was not specified, it will try the fallback with `getNonDelimitedPattern`.

If it was specified but empty, it’s because it’s disabled and the developer specifically wants no client-side validation while having server-side validation.

Example of this case scenario is when using [pcre flags](http://ca3.php.net/manual/en/reference.pcre.pattern.modifiers.php) not available client-side.
Will do that. I was not able to run ClientSpec.scala.. I will give it
another shot.

Saurabh

On Mon, Jul 16, 2012 at 2:36 PM, Anirudh Srinivas
<reply@reply.github.com>
wrote:
>> @@ -348,6 +360,38 @@ class Client(service: Service[Command, Reply]) {
>>        case EmptyMBulkReply()    => Future.value(Map())
>>      }
>>
>> +  def lPush(key: String, value: Array[Byte]): Future[Int] =
>
> Could you add comments in a similar style to the other functions? And could you also add some test cases in ClientSpec.scala for the new commands?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twitter/finagle/pull/90/files#r1173581
use i18n for these.
#define kMaxCheckInDuration 24  ?
good catch, forgot to flip back after testing.
Uncomfortable putting logged in/out logic in the model. Those feel like presentation concerns appropriate for view/controller.

Or is this more `has_ever_logged_in?`? Which makes more sense to me. Or `has_logged_in_once`.
Use std::set<Vertex> (see above).
s/metircs/metrics/
Rename to withEntityClass or withEntityType
The commented out code that this replaces was actually quite useful, but it was disabled ~18 months ago because it was painfully slow...
I think this is too specific to include in Flame, probably better to have it in a subclass in the application code.
Using `window.location.search` would give you the query string if it exists and returns empty(falsy) if there's no query string.
Actually, if chosen were to be hosted at CDNJS their project mission would be to host all released versions, given that there is a pull request for it. So I think in practice it is quite a safe assumption to be able to include chosen from there in the examples. In event of a new release it should be feasible to wait for the corresponding pull request to be merged and change the examples afterwards. Also note that I did only mention CDNJS as an example. Personally I would consider it a superior CDN to say just using GitHub's raw-feature because it sends correct MIME-headers that might avoid some problems with fussy browsers. Requiring a checked out working copy as currently imposes a big hurdle to users of chosen especially when they are not familiar with Git and should be considered the worst variant, I think. Adding to that, the versions in the gh-pages are not necessarily the latest releases and need to keep updated manually.
coaster utils?
The given timeout should be used in orderly server shutdown.
This should be changed to `add_dataset` as well.
`navigator.mozSettings.createLock().set`
This would add padding to all inputs, even if they don't have a reset button. I would try to fix this in the BB, when the button type=reset is added.
@basiclines ideas?
This kind of string concatenation is not l10n friendly but i guess you are going to do it altogether later.
Remove this check or the incorrect binding somewhere
This change handler is in the system app, so it is running all the time. It will be called every time the user takes a picture in the camera app, which is unnecessary.  Since you have to call stat() before receiving any transfers, I recommend that you don't bother registering a change handler at all, and just do everything with the stat() call.
Let me clarify that a bit if the phone is _off_ and the event is totally passed the user will not be notified when calendar starts up again. (If I had my phone off for 3 days I don't want to be notified of everything that I can no longer attend but again that is my personal preference)
Instead of setting the height manually can we have a class that does |height: -moz-calc(100% - xxxpx) where xxx is the height of the statusbar?
Main bug here it that 'deleteFromMsgDB' it wasn't treat as async. (there was a 'for' loop :S). Now it's working properly.
can we be more explicit in the selector specified, section[data-type="list"], for instance . By the way I thought it was necessary to use quotes in the attribute selector but probably it works without them.
`onsubmit="return false;"` violates Content Security Policy.
Handle this in the javascript.

Once again, apply dialog with old style, you may not do this. Because old style is not constructed by a form.
Err... I don't think so.

Sorry for the late comment, but @crdlc just brought this to my attention.

* Long press on the landing (search) page => wallpaper picker
* Long press on icons => edit apps
* Long press *anywhere else on the grid* (grey-ish transparent area) => **nothing**
For some reason, the font-size is not being applied here
You're right, string would be better. We can pass 'json', 'raw', 'text+json', etc.

How about this?

```ruby
def media_type_header(octokit_options)
 "application/vnd.github.v#{octokit_options[:version]}+#{octokit_options[:media_type]}"
end
Extenzivní dokumentace je fajn, ale přijde mi mnohem užitečnější se v angličtině epicky rozepsat o významu daných kusů kódu -- takhle je to takový triviální, bez nadhodnoty vůči samopopisnému kódu. Znáš docco? Můžeme používat docco. Ten výstup je moc hezký: http://jashkenas.github.com/docco/
Yeah just did a quick edit on the commit.

- sent from a tablet device that isn't an iPad
On 28 Dec 2012 23:46, "Arunmozhi" <notifications@github.com> wrote:

> In src/ui/symbollayer/widget_symbolslist.ui:
>
> > @@ -311,13 +314,6 @@
> >        <number>2</number>
> >       </property>
> >       <item>
> > -      <widget class="QLabel" name="lblSymbolName">
>
> If you wish to have. Oops. you have closed it? Very well then.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/qgis/Quantum-GIS/pull/369/files#r2515346>.
>
>
no its jasmine!
Yep, good idea. I'll add it.
I don't get what this does or why you're doing it.
Please explain why you potentially need a ZK lock for the noobs.
Why have default values for these if the method isn't implemented?
StringBuffer is faster when adding in a loop!
This code duplicates ``client/tests/virt/virttest/utils_misc.py:run_tests()`` or visa-versa.
please remove this log statement
Is it a binary file?
Should it use "rb"?
Why not Simply return visibleFields count?
Why are you doing all these: `|| Project.columns_hash["attr"].default` ?
(just curious, what's the rationale for this rather than just `bold`?)
prefer 'while'  instead of 'until'

```while !@event_queue.empty? ```
this link should probably be:

`['grok'](../../filters/grok)`
clean this code
I find this function to be very complicated and hard to read. I would really prefer something among these lines:


```js
function isMatchingContext(context, node) {
  return context.length ? context.every(function(context) context.isCurrent(node))
                        : PageContext().isCurrent(node);
}

function isWorkerContextless(item, popupNode) {
  let worker = getItemWorkerForWindow(item, popupNode.ownerDocument.defaultView);
  return !worker || !worker.isAnyContextCurrent(popupNode);
}

function isItemVisible(item, popupNode) {
  let worker = null
  return isMatchingContext(popupNode) && !isWorkerContextless(worker)
}
```

P.S.: Ideas is to enable reading function without necessary diving into impl details, and dive into them only once the overall ideas in clear.
When I read this line and see `box2` I'm just sad, there is absolutely 0 chance I can guess what it will do, I'm forced to look into implementation details to continue reading. Also in SDK we name functions with verbs high order functions with adjectives, would be great if you could follow that convention.
++ awesome
You could use the decorator `require' from networkx/utils/decorators.py
`Puppet::Parser::Collector` don't have `each` method. That'd make sense if it had.
Indeed, I was hesitating to change it. Notably because "equal" in the description meant the purpose of the behavior. But "duplicate" is indeed more precise yet descriptive.
The first case is taken from the previous spec.
Should I refactor the whole spec to make it more consistent?
I left it as much as possible identical to be sure to only improve the coverage, but maybe it makes more sense to have more focused cases.
Thanks for the review!
It's a bit odd that this routine returns "launchlock" for any SIM-Z position that is outside of nominal allowed positions.  Is it not possible for the rest of the mission that SIM-Z of 83852 or -95181 will be commanded?  Nearly all of those intermediate positions are not "launchlock" but represent a different condition that should be signalled with an exception here.
`route` (come sopra)
Yoda conditioning on line 83 (green one)

 http://www.dodgycoder.net/2011/11/yoda-conditions-pokemon-exception.html
put spaces after each comma
I'm wondering if we shouldn't trigger an event in this situation, as we potentially might end up omitting some headers if we detect headers have already been sent. A separate flag could track whether _this_ class has sent them, vs. whether the response reports having sent them (via `headers_sent`).
`trasporta` -> `include`
@DASPRiD see my note above -- while I may have done the original split, it's clear it falls withing 100 characters and causes no need for scrolling in the Github UI, and thus passes the readability test.
Generel question here: Should one use `hooks.callAll` or `hooks.aCallAll` in a situation like this?
( @redhog / @cweider / @jhollinger )
You are using camelCased vars above, and dashed ones here. Wouldn't it be easier to have one kind of usage?
No, AM_INIT_AUTOMAKE still uses this argument. You can check http://www.gnu.org/software/automake/manual/html_node/List-of-Automake-options.html#List-of-Automake-options for details.
This is only used with pi, which is a vector. So I think yes.

Incidentally, should I be making fold-right and other helpers private?
Was wrong about the imprecision of DateTime.parse, works fine for the canvas strings, it just has issues with the google task dates. The monkeying around that I ended up doing with google tasks feels quite unnatural. I'm thinking it might warrant a discussion with christian and scot about maybe dropping the epoch and datetime for google tasks, and switching to just date.
No longer needed, removed.
Good point, overlooked that.
if(empty($errorCode))
            return;
… which should be fine, given the above assignment.
These tests should be marked with `@nondestructive` if they don't leave a trace on the website.
Why don't you create an extra unvouched user in the setup function of this class?
Yip i'm pretty sure it's only for registration purposes
Extra whitespace at beginning of bracket.
Throw a username in here.
Now that I look at this, your double newlines might of been inteneded. If so, I think you have an argument to keep them as is.
This is reverting our changes, please do not merge this.
I've removed it because: Name doesn't have to be sent to server when a user is updating only template attribute.