Always add a U suffix to an unsigned constant

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
ISSUE:1190 envgen error checking for integer params

Add integer validation for command line
parameters.

Add meaningful error messages when integer
validation fails.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
cannotRemove refactoring

Renamed cannotModify to canModify, same with remove,
and moving the logic inside the file, since it didn't
belong to directories anyway. Instead of using flags,
now using what the methods mean and one call the other
when need.

There is a kludge in Dir::cannotRemove() that will be
cleaned in a subsequent patch, as soon as doRemoveEntry
gets a file as argument, not a filename.

If I manage to finish this second step before this pull
request is pulled, I'll merge them two.
Add superfile name to error
Fix regressions in recent inline table code

- Wrong type was used in a comparison expression creating an assert

- Temp row was creating the wrong TAK kind - which meant it crashed
  at runtime.

- TempRow should have been changed to inlinerow (probably part of the
  cause of the TAKkind issue).

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
This commit only reformats the code.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
gh-1776 EclWatch pauses/clears queues for Roxie/HThor

A drop down menu is added for Roxie/HThor cluster to
pauses/clears queues. I also improved the index.xslt:
better confirmation messages; removed old code lines
which are no longer used; changed some function names
and variable names for better read.

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
Revised based on review

Signed-off-by: Kevin Wang <kevin.wang@lexisnexis.com>
Emergency fixes to Installing_and_RunningTheHPCCPlatform/hpcc_ldap.xml doc and images
Pagination issues for the Ldap document sections
Fix #2090 Rename ECL macro args and enhance descriptions

Renamed the pipe macro arguments and comments to better reflect their meaning

Signed-off-by: russ <russ@russ-VirtualBox.(none)>
Roxie generated filenames for index parts were incorrect

Roxie generating file names for index parts other than the top-level
key incorrectly. This would lead to some confusion, and possibly additional
copying of files, but no other ill effect as far as I can see.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Roxie file cache was not checking timestamps

The code for checking and comparing filestamps when deciding if Roxie's
cached copy of a file was up to date seems to have been lost in the
big refactoring of package files, meaning that file mismatches would only
be detected when the size changed.

This had a few unfortunate effects:

1. Index changes are likely to be only detected by slaves but not by server
   nodes. This leads to 'partially suspended' queries which were are not
   giving helpful error messages.
2. If data is refreshed on thor, Roxie might continue to read a previously
   cached version of the data, even if Roxie was restarted.

See gh-2096. This is not a complete fix for all the issues there, since Roxie
is still falsely reporting that two versions of a data file are required
at the same time when all queries using the previous version have been
unloaded.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Roxie assert error on partially suspended queries

If a Roxie slave thinks that a query is suspended, but the server does not
(this can happen when a file part is missing, for example), then the error
reported if the query is executed wille be an internal assert failure
rather than something more helpful.

See issue gh-2096.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Roxie caching local files too long

Roxie was nto clearing the local file cache when the last query
that referenced a file was released. This means that it was not
possible to load a new query that referenced an updated version
of a file without restarting roxie

Fixes gh-2096.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #2099 from richardkchapman/roxie-filenames

Roxie generated filenames for index parts were incorrect

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2100 from richardkchapman/roxie-filedates

Roxie filedates

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2101 from richardkchapman/roxie-partially-suspended

Roxie assert error on partially suspended queries

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Daregress refactoring/cleanup

Major refactoring on daregress suite, with a better
way of adding new tests and a simpler error report.
Also, added a transaction test to the list.

While refactoring, I cleaned up a bit of the code
and found three issues with the current implementation:

1. While creating a new superfile within a transaction,
the pointer returned was the result of a dir-lookup,
so in the case of active transactions, it'd be NULL.
This bug is fixed with the current patch.

2. I managed to reduce the window to which a newly created
superfile would be available in the filesystem, even before
commit, by locking it straight after creation. There's
still a tiny gap (heavy loaded systems might hit it) in
between the two lines.

3. If adding the creation of the superfile inside the
transaction, in the tests' conditions (which might not
be correct), the sub files are not added. Since this
works with FileServices, I'm guessing it's something wrong
with the test, and not the DFS itself. Will create an issue
on github to investigate.
Remove unused port argument