labofsahil/github-event-dataset-2012 huggingface dataset:
Hi Dmitry,

Thanks for your reply. I got a comment from Andrei, and he pretty much
requested the enforces be changed into asserts, so that gives us the 100%
sure part of our query.

Thankyou for your insight,

Paul

On Tue, Sep 11, 2012 at 9:19 PM, Dmitry Olshansky
<notifications@github.com>wrote:

> In std/container.d:
>
> >          void popBack()
> >          {
> > -            enforce(_first);
> > -            assert(_last);
> > +            enforce(_last);
> > +            assert(_first);
>
> I would point out that all of std.range and pretty much any range based
> code is using asserts.
> The reason is that it's only guaranteed that c.front, c.popFront, c.back,
> c.popBack are defined if assert(!c.empty) holds otherwise it's a logic
> error on behalf of programmer.
> Same reasoning should be applied to containers.
> Also note that e.g. built-in array's RangeError is an *Error* thus equal
> in severity & meaning to AssertError.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/D-Programming-Language/phobos/pull/785/files#r1579600>.
>
>
Where do you see that idiom emerging? I always prefer templates to CTFE functions with only template parameters, and I wouldn't have noticed so far that Phobos had a different policy. Besides, Denis just moved that template over from `std.typecons`.
Can you please tell me what this boolean is for?
This is better done as $HOME/production-rpc-webserver, I think.
Untested property, munge code doesn't run.
bzip2, was alrady anounced in v0.8
Subclass?
Add a comment to make it clear that this is a band-aid, and only acceptable with a single Firefox instance (for code maintainability).
is it possible that this method is called with null? would there be a usable different return value than a nullpointer?
use a constant instead of null to make the code easier to read at this place pls
The whole imprint page has been capsulated into a separate panel. I've done that as I need the imprint text also in a modal dialog on the login page. According to the DRY coding style I have moved it to a reusable panel
What do you mean?

Am 2012-10-19 06:15, schrieb Andreas Pieber:
>>       public Long commit(EDBCommit commit) throws EDBException {
>>           if (commit.isCommitted()) {
>>               throw new EDBException("EDBCommit is already commitet.");
>>           }
>> +        if (commit.getParentRevisionNumber() != null
> maybe it's a good idea controlling this via a property for backward compatibility?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/784/files#r1886604
>
If we're going to be making edits, we should do proper namespacing -> \PSU::db
Not intended no. What is planned is to move the controls into the edit page window in this circumstance (why the controls need to be generic enough to work in both the preview window and the edit page window). This unfortunately hasn't been implemented yet.
Why were these all changed?
Not sure what this was doing here. It wasn't used anywhere else at all.
Genau so!! Perfekt!  :+1:
ah right, was thinking too much about the separate route object per language use case. 

so what remains to be done is having the route document transform the locale piece of the path into {_locale} and use the locale in requirement rather than default. this should be optional behaviour - or maybe we want to do a LocaleAwareRoute object?
хм, пропустил
This does quite a bit of extra work fetching the suite again for every case in a suite. What I would do instead is build up a dictionary mapping suite names to list of case objects that should be included in that suite (that dictionary can be initialized with the suites from the `suites` key of the main data dictionary). Then once you've gone through all the cases, you can just loop over that dictionary and you only have to do the fetch/create check for each suite once.
When building up string output, it's a lot more efficient in Python (and the code is a bit cleaner) if you initialize it as an empty list and build it up as a list of lines with `.append()`, and then at the very end join those lines together with `"\n".join(lines)`, rather than repeatedly concatenating strings.
I think this method is already too long. Making it longer will make it more heavy, harder to read and to test.
I think having this as external is more portable.
MINOR: Missing return comment.
That's a little different; that scheduler doesn't send messages, it schedules attempts to check whether the socket is connected or not.

Thanks for making me look at it again, though; it should use the global scheduler by default rather than creating its own if not provided.
I'll change the log but the XSD is hard because it's a shared attribute. I'll make some reference doc changes instead.
remove `<para>`
Where'd this magic number come from?
Seu formatador de XML continua incorreto. Corrija-o conforme eu havia pedido.
I think the same would apply to `$localFormBuilderVars` and `$useStatements`, these are per-file states. I'll try to make a failing test first
I would have the project simply under `/`. There would be a showcase of everything possible.
I'm a little iffy on this part.  @bodepd : I may open a new pull with another commit on top of this one.
this is the real meat of this PR
You're rigth but this one is first version not definitive. But I'll change it.
Sounds good.  Less is more.  Less methods in public scope is more.  Hopefully @kring knows how to test the private ones.
Why use `GetEnumerator` / `MoveNext` / `Current` instead of `foreach`?
Ceci dit je te dis de la merde, il me fait les mêmes problèmes sur les fichiers de script SQL...
Prochain projet, on n'utilise pas de caractère...
or, no, that's just "if (search['multiple'])"
(It is easier to add new things this way.)
Can you add ``true`` as third argument?
Quaternions and vectors could go into their own library too. Or there may already be a JS library for this. ([glmatrix](https://github.com/toji/gl-matrix)? or something else...)
Is there a reason to leave this commented out?
_legally_!? What about successfully?
Shouldn't this be a fail?
Why not use defaultDiacriticsRemovalMap directly?
What is the standard markdown for command lines? Found nothing about it, sorry.
No problem, your welcome :) Thanks for your time also.
Nice use of `qvga`.

I guess I'm ok with that.  I want to keep this a filter regardless.
small item. Please update the copyright year.
If the cancel button is used it will be removed from the option dialog only on iPAD.
Also the whole paragraph I think is IOS specific.
Should be made clear for this return type that it is `nil` if the blob data cannot represent an image.
I moved Backups to LIB folder like a week ago, but that wasn't actually enough to disable iCloud backup.  We are now explicitly marking these files, so they are fine to move back (technically should be in lib/app support/ folder, but no sense making this migration even more trouble).  Also, hopefully backups won't be used anymore with ios6+ anyway.
You can change this to a generic Collection of `ClientRecord`s, mm?
Since there will now only be one extention,  I think this comment need to be revised
This is totally nitpicky, but I'd prefer for this to be (c) 2011-2012, so we retain the origination date.
Ok and thanks :-) I just now read it
This should look like:

`$template->assign_var('SN_IM_PLAY_SOUND_ON_PAGELOAD', $play_sound_on_load ? 'true' : 'false');`
just decorating change, but we really should follow coding guidelines.
Can you get the 'terms of use error message' from e.getMessage(), rather than hard coding it as the message field in the newly formed exception?
I have made all of the suggested corrections, but I am still working on the
request for the search. I will do a git push on the same git pull request.

On Mon, May 14, 2012 at 4:04 PM, Kyle Campos <
reply@reply.github.com
> wrote:

> > +    # Navigate to Enrollment Home
> > +    self.homepage() unless(!opts[:nav_homepage])
> > +
> > +    puts "viewing academic calendar as: #{opts[:view_person]}"
> > +    puts "test name #{testname}"
> > +
> > +    enrollment_home
> > +    search_for_calendar
> > +    view_acal
> > +
> > +
> > +  end
> > +  def enrollment_home(opts={})
> > +
> > +
>  @request.add("/portal.do?channelTitle=Enrollment%20Home&channelUrl=#{@request.url}/kr-rad/launch?viewId=enrollmentHomeView&methodToCall=start")
> > +
>  @request.add('/kr-krad/launch?viewId=enrollmentHomeView&methodToCall=start')
>
> There shouldn't be any hard references to the web context, "kr-rad",
> that's stored in the config object so you should retrieve it from there.
> Also if the request begins with the web context then you can ignore it all
> together, the core API will insert it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/kcampos/Open-Performance-Automation-Framework/pull/25/files#r820119
>
Depends on the filename.
Redundant fix was caused by the fact the installer mentioned in issue #32 (as well the code comes with newest installer) doesn't have the fix you mentioned.
We need to have an installer that reflects latest changed in the next branch.

I'm closing this pull request since it's not bringing new fixes, thanks.