labofsahil/github-event-dataset-2012 huggingface dataset:
Because you won't always know what these fields are. For example when you
use the Tika extraction stage to get the contents of a file, the default
name of the field containing the actual content will be
name_of_file_content, and the title  metadata field would be
name_of_file_title.

We could just make the tika extractor call the field the same thing for
every document ofc, but this is something that is good to have anyway. At
gard they kept changing the name of their binaryfield, so in the end we had
5 different fields we tried to copy to body. But they all ended in _content
so with this feature it would have been smoother.

Roar

On Tue, Oct 30, 2012 at 4:17 PM, Joel Westberg <notifications@github.com>wrote:

> In
> stages/processing/basic/src/main/java/com/findwise/hydra/stage/CopyStage.java:
>
> > -		Logger.debug("Copying field " + fromField + " to field " + toField
> > -				+ " value: " + valString);
> > -	}
> > +    @Parameter(name = "prefix", description = "Input field prefix")
> > +    private String prefix = "";
> > +    @Parameter(name = "postfix", description = "Input field postfix")
> > +    private String postfix = "";
> > +
> > +    @Override
> > +    public void stageInit() throws RequiredArgumentMissingException {
> > +    }
> > +
> > +    @Override
> > +    public void processField(LocalDocument doc, String fromField, String toField)
> > +            throws ProcessException {
> > +        String fromFieldStr = prefix + fromField + postfix;
>
> Why would you ever need this? Why not just configure the input field to be
> whatever the actual field name is?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Findwise/Hydra/pull/107/files#r1979642>.
>
>
I think in throwing an exception we'd actually have to do something about it. What could we do if the adapterRef is missing in this case?
This conditional is kind of convoluted. Any reason not to do: 
```
if is_browser
...
elsif is_tablet
...
elsif is_phone
```
Note: this is the way we used to hide the control before 0159dc2 came along and changed things.  But we don't want to just roll back to that state, because without $.remove(), jQuery will retain the node's metadata forever (it's stored in a global map, not hung off the DOM node).
The second half of this function seems quite similar to findFirst() below (except without the match-highlighting stuff, which I think we'd also need here if we ever make highlights visible).  Would it be better to just directly call findFirst() on the initial search field value?
Yup, #1499.
If you use `.children().eq(1)` here instead of `.children()[1]`, the additional `$()` wrapper would not be required.
layout.nil?(レイアウトファイルが明示的に指定されていない) or layout == true (レイアウトを使う)
ならばデフォルトのlayoutファイル :layout.erb等を使用する

erb :foo, :layout => :bar_layout
erb :foo, :layout => false
みたいな書き方を想定しているのでこんな条件になってるんですかね。
those two produce different urls
1) "/api/giannis/cloud9/download"
2) "/giannis/cloud9/api/project/download"

is that on purpose?
Yes, they are
They aren't suposed to be shown anyway
Nothing should match a `Jade expression` but a `Jade expression` - only this one is returned as a match and hence will directly be expanded

Also, when we support the zen coding - they will be directly expanded - not suggested and may move out of being HTML completions to be `HTML` language feature (haven't give a thought into making it generic yet)
Doh! I knew I should have changed that when I pasted it instead of "I'll get to that later." Yeah, the comment should be updated...I figured the inclusion of this would be an item we'd discuss, because I thought that it should be included somewhere on how to use it, but there was nothing in place for that.

In the end, I think adding it to the documentation (and also, perhaps, including the documentation in the source, as opposed to just being on the website) might be a good idea.
these should be uint64 now, right? is that possible?
typically i like to format my key 'prefixes' like "name" (for "by_name with no slug") then "name slug" (for "by_name_with_slug")---makes the keys easier to generate in the long run
See http://stackoverflow.com/questions/1555326/java-class-cast-vs-cast-operator. It does not really matter in that case, but generally it avoids compiler warnings and then added SuppressWarnings annotations.
Perhaps I'm confused, but aren't xlim and ylim both in limits.r already?
This logic should probably be pulled out into it's own method. 

`if(!VerifyInternetConnection()){ return new TeamResponse {etc.}}`
needs to be handlePositions based on your changes above
These two functions, findOverlappingTrackEvent and findOverlappingTrackEventFromRect are far too similar.

Either remove findOverlappingTrackEvent outright. Or, update findOverlappingTrackEvent to simply call findOverlappingTrackEventFromRect, and pass in the rect.

I already see a bug that was fixed in findOverlappingTrackEvent that was not fixed in findOverlappingTrackEventFromRect.

in findOverlappingTrackEvent
if ( trackEventView !== otherTrackEventView && !otherTrackEventView.dragging ) {

and

findOverlappingTrackEvent
if ( !otherTrackEventView.dragging ) {

Should probably want to pull the findOverlappingTrackEvent version in to findOverlappingTrackEvent. Seems more complete.
Drop this if block, see below.
Move to the top and only create this once.
Can we put this in the default config so that it's accessible to all templates?
ah this was probably due to a previous attempt as well, will revert
Why not use my XHR module?
Yeah that would be cool - if you checkout this branch and send me a pull request we can bundle it all in together!
Global search and replace: from `handel` to `handle`
Perhaps all the supported baudrates should be mentioned.
Agreed, but i'd rather wait for native speakers to define exact text anyway ;)
I honestly can't figure out what the diff here is. The version in my repo is exactly the same as the one in master.
Just a feature to not cause the notification at startup, OR to cause it.

bindbackend defaults to not notify.

On Mon, Mar 12, 2012 at 03:28:11AM -0700, Habbie wrote:
> > +
> > +TinyDNSBackend::TinyDNSBackend(const string &suffix)
> > +{
> > +	setArgPrefix("tinydns"+suffix);
> > +	d_taiepoch = 4611686018427387904ULL + getArgAsNum("tai-adjust");
> > +}
> > +
> > +void TinyDNSBackend::getUpdatedMasters(vector<DomainInfo>* domains) {
> > +	Lock l(&s_domainInfoLock);
> > +	
> > +	if (s_domainInfo.size() == 0) {
> > +		bool notifyOnStartup = mustDo("notify-on-startup");
> > +		getAllDomains(&s_domainInfo);
> > +		
> > +		// little bit of optimization at startup.
> > +		if (! notifyOnStartup) {
> 
> Why have this flag? Does the bindbackend have it?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Habbie/powerdns/pull/20/files#r544674
indentation needs fix
To make these packable in arrays, could time-zones be a fixed-length character buffer instead of an arbitrary string?
I agree that for messages it's probably not needed in most cases, for exceptions though it's great. Maybe just capture if level is above ERROR?
Perhaps the best method is to make the automatic initialize call optional. That way, the first launch call will not block. However, all subsequent method calls will block. If the user doesn't want those to block either, he/she can always use "get_machine_status" to determine whether the server is ready, before making the call?
This list of ids make me thing you want to use a class name instead.
I'm not a fan of the ``apc`` abbreviation - I don't think 'astropy' should contribute any letters to the abbreviation (since we don't do that elsewhere). How about

    >>> from astropy import coordinates as coord

or

    >>> from astropy import coordinates as crd
I agree -- I think lat/lon are clear enough and I've seen that convention used in many places elsewhere.
I'm confused, why should error instances have interpolation/convolution methods?
Same comments about using `'\n'.join` to build up multi-line strings.  Also there's no reason to make this `import numpy as np` in-line.  Numpy is used all over the place in Astropy so there's more to lose than there is to gain by doing this.
Yeah, so replace GetProxy to return a proxyType and use that. Returning all the information is better IMO. I just don't see the need for two functions, one which returns a subset of the information that the other does.
It does NOT call remove(), which is one of the bigger changes in this pull. We leave the mq where it is and try to re-use it.
Gotcha, thanks for clearing that up.
I would use ``mixed`` instead
@Vrtak-CZ missing newline before `if`
no, there's no particular reason I used classnames, but since you mention it: Using real rdf types (i.e. what is rendered in the HTML) will of course take away some flexibility from the library. For example, if I wanted to use two different configurations for sioc:post in the same page (one with category information, the other one without, but with the author's name instead, and one of them linked with partOf and the other one with replyTo for example), that won't be possible any more with this PR. But I guess this is the price we have to pay. RDF really is an "anything goes" format, and there's no sane way to encapsulate it all in a library. But this examle was why I didn't use rdf type names s identifiers in the config in the first place (like I said in another comment, one of the design principles was to treat all browser-visibile rdf data as arbitrary strings)
Move these up to the list at the top of the file.
Can you please put the `{` on the same line?
Could you please put spaces after commas and around =?
And indeed this as written will cause failures if matplotlib isn't present, see test_pr report.
OK, I no longer explicitly specify a version of pyzmq and it seems to be working just fine.
Ah ok, that's fine then :)
_animatingToPageIndex = -1 here?
I was wrong about this the code was structured to handle this but its not doing any checking it does not need without this case.
Is it a feature or bug we can parse it without a value?
Something like [this](https://github.com/benstraub/libgit2/blob/dc1b0909d6ec96def686de11ac987892abf7538f/src/checkout.c#L50)? It's a little clunky, since you give it both a blob OID and a path, but both are (unfortunately) necessary.
Again, use "\\\\s*" instead of " *"
And this would be .span_narrow(5), or .span_narrow(4) to leave an empty column.
Since the view are getting numerous, you can just `import views` and reference them like `views.foo`. Personally, I'm ok with `from views import *` but that's looked down on.
YAY, we won't forget this ever again :-)
For the most part, yes. I added the ``get_index()`` method.
I'm not a big fan of this type of thing; we have git history for that. this'll just get out of date - if someone else comes in some day and does a bunch of work in this module, then what should this say?
Lines 18 and 19 are still tab prefixed.
Maybe a clone of this one as this just returns the reference now while delta is a new vector. This is more more consistency.
Use statements should be re-ordered alphabetically.
What is the reason you renamed it to refreshState()? If we do this, we should probably leave a proxy to refresh which is deprecated.
Same as above (line 2379)
а є тест, який перевіряє тільки обов’язкові поля?
@Tobion please keep the old API for this PR. Optimizations might come in a subsequent PR if needed.
wouldn't it be simpler to test against `isValidName`?
Does the question still stand if you make this protected ?
> Either way, if this is necessary I think it belongs in a separate pull request

will you submit it ?
type Fatall -> Fatal
This doesnt seem to be called, so the property `parentCollection` seems useless.
That's really ugly and slow.
the rubber.sh wouldn't need to do the path in addition to say rubber-ruby.sh - just have the one file manage the path
That syntax doesn't appear to be supported. Sorry for the nasty paste, but it's just irb output. 

I also removed them and ran the specs which failed.

```ruby
1.9.3p327 :005 > { test: 5 }
 => {:test=>5} 
1.9.3p327 :006 > { test: { test: 2 } }
 => {:test=>{:test=>2}} 
1.9.3p327 :007 > { test: test: 2 }
SyntaxError: (irb):7: syntax error, unexpected tLABEL
{ test: test: 2 }
             ^
	from /Users/brittballard/.rvm/rubies/ruby-1.9.3-p327/bin/irb:16:in `<main>'
```
When we break parens onto newlines, we do it for parens in the method.
As this test currently works the event has to be saved. We send the id in the post data.
nitpick - change 'to a' to 'from a'
Nasty interplay with ```color```/```edgecolor```/```ec```...
Having a `return` in the middle of a function is a bit unfriendly. Since you're already using the `for...else` structure you could easily convert the `return` to a `break`.
The parentheses are unnecessary and do not help. I'd remove them.
i think:

load().then(function () {
  console.log("done", arguments)
}).fail(function (e) {
  console.error(e)
})

is slightly more readable.

But, why not let the exception just propagate and log naturally with .end() instead of .fail()?
What basis is there for that claim? Sending should be instantaneous.
this kind of logic should go in a helper class
Do you mean for the empty_widget and/or the tab bar area? I think editors should not be able to contribute actions there, though the task might want to. Empty widget can be customized by putting up custom widget. This method is meant mostly so that editors and others who implement their own custom menu can get the default custom menu actions of the editor area.
If we're going to verify the time value, it would be more complete to test `<= 0`.
AS's code style is cuddled braces for all blocks include if/else. I will sometimes look the other way if its consistent in the file, but in this case its mixing styles
What is the motivation behind this? I had to re-work my IntelliJ IDEA settings so it would not optimize imports this way.
How about stealing an id from EeLogger, reducing it's block to 20, instead of allocating a new block to EE?
I'm not sure that this does what you think it does. In the mapper, `getCommentById()` will only return false if the `PDOStatement::execute` fails which is not the same as no results being found. 

That is, http://api.joind.in/v2.1/event_comments/100100 succeeds, but there is no results returned as comment id 100100 doesn't exist.
I don't know what role="application" does. The whole CSS building blocks thing makes me nervous.  I worry that we're dramatically increasing the complexity of the CSS.  Do you know what it does or why it is necessary?
one var per line, (gaia coding standards)
why strict comparison instead of ===?
no, this will not happen, removed this, thanks.
proper indentation (I know it was from before, but if you could fix it when rebasing, I'll be thankful)
Many people will interpret the k in `kMinFontSize` as indicating a constant.
This variable should be renamed `minFontSize` for example.
I don't understand it :( should we implement a UI in this pull request?
Maybe a break line to separate methods and increase readability.
Clever; I had to look twice because the idiom looked wrong, but is not.  A ternary op would be less wasteful, however.
Fair enough. I'll revive these.
I think this is a bad change.  If we need to continue even though a command returned an error, we should handle it in the specific command.  That can also, eg, filter to only non-fatal errors, or try again, or any similar number of things.
Nix these two top returns.
couple of tricks
parentheses :wink:
I'll add a TODO and an issue to do this later.
should just use shorthand here: `/../g`
moved but roughly kept the name as there is already a run there and this is launching it.
As of now it's hardcoded since we build it from source. It could be changed at a later date. Python 2.7.3 is the current version GAE uses in production.
what about `count`? :)
I think it's better to put filename to the evaluate environment instead since it is more semantically correct (filename is the same for all rulesets)
silex/silex-phar maybe ?
My thoughts for future iterations of this code would be to also have a 'TagFetcher' that would fetch post by a given tag from a specified server. Then the two classes could share common code in a module or something.
But for now I made all non-api methods private, since they're not used anywhere else, and using instance_eval was one of the ways google came up with to use for rspec testing private methods :)
そうですね。thatなりwhichなりがあっても文法的にはOKかと。  
無くても文法的には問題ないはずです、きっと。。。  
関係代名詞の省略っていうパターンかなと。  

質問とは関連がありませんが、  
私の場合、and により2つの文章をつないでいる場合は、それぞれを単体で主語を補完しながら読むようにしています。
今回のケースですと、

In real code の後の文は:
- (you will) never use `update_attributes` blindly.
- (you) always whitelist the attributes you allow to be changed.
という2つの文章に分かれています。  
こうすると長い文はかなり短くなりますので、文章の構造を把握しやすくなると思います。
And now again it can be simplified to `if (flash = $("#flash-container")).length` :)
and then please squash you commits to one
Indentation here is weird, I think?
We are doing a copy here. Is there a zero copy support available in Napatech ? In this case, you can use PacketSetData (see https://github.com/regit/suricata/blob/master/src/source-af-packet.c#L749). You could also use the data release mechanism: https://github.com/regit/suricata/commit/8fecd95a6750977872ab3ebc5ddbe926da61c302

PS: the code line is really long here
hmm.. why are you using std::string for character/replace? can't you just use 'char' instead? that should also make your replacing a bit tidier too I guess

while (pos != npos)
{
    str[pos] = repl;
    pos = str.find(....)
}

you also avoid string copies there (no need for new_str) - I guess you did it that way to allow for multiple-character replaces, but since you're not doing that, I don't think there's any need for the complexity?
Add level:
$actions = JAccess::getActions('com_menus', $level);
I'm not sure this is correct behavior. loader's `unload` passed instances of a `loader` and not the loader module itself. In this case you seem to unload loader module along with an individual loader instance. Which also means that unloading any instance of a `loader` will unload the whole module thing. 

Only reason why it still works for tests is a live references to a loader instances. If you really want to unload this module then just do it from the shimmed `require` itself. I don't know what are the implications of that, but they are same as ones here.
However, that might be tainted by the download time of the main script.
Also this is not used in the test
Could we switch the visibility from `public` to `protected` then?
That doesn't need to live through to the shipping version, although keeping it in the git history won't hurt.
We should retain this here, also, since `require 'puppet'` is a valid entry-point for programs that want to consume our services.

We need *both*, sadly.

Will take once that is fixed.
@joshcooper  updated both split and white space.
an update-versions task in standard-project can generate this file, at least when this project is used in embedded mode in the birdcage.  when in detached mode in github, this file can just be edited directly by hand.
The name 'runnable' is overloaded... would prefer isRunnable.
dont change this
`quale metodo HTTP è stato utilizzato`
No need for an else -- just close the if {} and do your return:
```php
if ($ord > 255) {
    return sprintf('&#x%04X;', $ord);
}
return sprintf('&#x%02X;', $ord;
```
I changed that because of the option "cookie_httponly" which maps to the method [get|set]CookieHttpOnly.
The simple in_array check doesn't work because of case sesitivity.
(Before this change it maps to [get|set]CookieHTTPOnly)
`passando <varname>$_POST</varname> al primo parametro.`
Thanks for noticing, I corrected it.

I didn't change it to class_name, because the setClassName function is automatically resolved and called by setOptions when using className as option name.

If you insists on renaming it to class_name, let me know so I can refactor it.

Thanks !!
yes, intentionally
Not my change, see SHA: 94f62fbf292f82fa0bb98e17651682e98a2489ab
@cordoval many IDEs are supporting it, not only PhpStorm
Is it really necessary for this method to be public?
My logic for this is that the develop init is called from the makefile and packaged together to simplify things. I will switch it around and try it out
i wonder if mapped superclass should not allow to set referenceable/versionable as well? i see no good reason not to allow setting that in mapped superclass.
We could generalize this a little bit and use it for both native scripts and the generated scripts. What do you think?
deal with in ldap.search()
Normally comments go on their own line
fixed: @contacts = current_user.contacts.includes(:tags)
small formatting issue, please be consistent with spaces between the +   it should be: host + ": " + name
https://github.com/mozilla/mozillians/pull/276
For a moment I was extending this template for the API html helper/future docs and the to_html does not provide a request object. (afaik)
In the other pull I removed this change.
So consider it optional
here and in other spots get rid of the extra space
hm. ok. i put it in there because sometime in my learning path, it seemed to need it, but i can see that it's working without too.
Why refresh the pointer here? If you move that behind the peeks for the const addresses you can get rid of ok_p. Also, considering this is only refreshing the front pointer, you could rename the refreshPointers function to something clearer like refreshFrontPtr()
Could be used `client.storageUrl` instead? You are forcing that url on your client? Where did it come from?
Perhaps the option should also just be `dependent` and not `dependent_destroy`: just make it accept the same values that the `dependent` option of has_many does, and pass it though without having to check it at all. In other words, it would look like:

class Something < ActiveRecord::Base
  extend FriendlyId
  friendly_id :name, use: [:slugged, :history], dependent: :destroy
end

What do you think?
Yup. I'll try it out tomorrow.
nice, I like how this turned out.
This changes the functionality here. Do you have a test case that says it was broken before and fixed now?
This should have a limit to be useful. (like 30 or 60 seconds).  Otherwise, if the service breaks for 30 minutes, it could take a very very long time to recover.  So, it should change to exponential with a cap.
Very good idea !! About the name perhaps we change it later.  Know we have to prouve our design by practice
Alignment here also
@kellyredding - there's a couple "hanlder"'s in the Anatomy of a View section
This would also require the appropriate zip tool for Windows, which can be found probably at the same location as the unzip one.
There's a lot of weird whitespace changes going on in this file. What's going on here?
probably should remove semicolons to be consistent...
same here. the order of ops is invalid. I cannot reproduce the error with valid test cases.
Again, add a using statement
Get rid of the center tag, please
Man, I love `inject`
good comment, good to have consistency.
Can you improve this comment? Currently it really doesn't say much. Thanks! :)
shouldn't this be ...

```ruby
pattern = "#{javascripts.split("/").join(File::SEPARATOR)}*.js(.*)?"
```

...or similar?

So that it doesn't match `foo.jssssss`
`alias_method_chain` is a way of overriding a method but retaining the original version.

In this case `alias_method_chain` creates a method called `rebuild_with_invalidate_cached_urls!` and `rebuild_without_invalidate_cached_urls!`

The 'without' method is the original and the 'with' method is the new one that we've just defined. The first step is calling the the original and then we're calling our custom logic. This ensures that awesome_nested_set can still run its logic.

However, I can put a raise in this method and nothing fails suggesting that we're not testing that this method gets called at all.  Fail.
I'm assuming we don't need a callback when the values are read from cache ?
Oops, for some reason I thought this was an endpoint for getting a single comment by comment id. If this gets all of the comments for the content, the endpoint should be `/api/content/:contentId/comments`.
I think just a 200 is fine here.
Might be worth documenting what the alias is in relationship to the groupId
I'm in 2 minds as to whether or not the getComment function needs to specify a contentId. In theory, the comment id should allow you to also retrieve the content item the content is for.
The specific module functionality is not in use anymore. The test was removed.
Deprecated functionality has been replaced now.
:work_options는 대체 뭐냐? 저게 외부에서 읽을 일이 있어보이지는 않는데?
Then there is only 1 ``apply`` method. Better documentation of these heuristics is needed
Need to think about this, not sure this should be necessary.
again: `player` is niet een goed idee. `character` is beter
Метод shuffle не соотвествует идиоме ООП. В данном случае метод принадлежит объекту класса Cell но не выполняет с ним никаких действий. Метод работает с обхектом переданным по ссылке. А если нам понадобится перемешать какой-либо другой массив ? Нам придёться создать объект Cell и вызвать у него метод shuffle. Правильней было бы создать категорию для NSMutableArray (а лучше для NSArray, поскольку он его родитель) и реальзовать в категории метод shuffle. Тогда всегда и везде мы бы могли вызвать
[instanceOfNSMutableArray shuffle]
I think you'd want validations for all the non-null attributes as defined in schema.rb Same for other model classes.
This is a pretty hefty method.  Perhaps not for this check-in but splitting it up into logical sub-units might make the code more understandable.
filter-specific statistics
No longer shipped to the client.
"A list of hostnames or IP addresses for Diamond servers to be contacted for this search, separated by..."
Throw an error if <hash> doesn't occur in the file.
You'll want to check this is actually set, because sending an empty variable will cause an error. Bonus points points to display an informative message for how to set it!
These are nice. I'm not really sure about calling them `_ws`, since `ws` usually stands for white space, and these lens default to nothing, not white space.

Also, it would be good to add tests to `test_quote.aug` for these, as all denitions in `quote.aug` are tested.
Yes it would! Fixed!
I've read about Scala break performance concerns. In this case, the outer break will only be broken once when the entire set is   "covered". The inner loop will be also only broken when the entire set has been covered (once). Thus, I won't be too concerned. 

I have measured the performance on both single partitionedId case vs multiple partitionedIds case, they both match the current performance numbers.
On 19.10.2012, at 21:48, Martin Luessi <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -883,6 +884,31 @@ def append(self, raws, preload=None):
> >      def close(self):
> >          [f.close() for f in self.fids]
> >  
> > +    def copy(self, fname=None):
> > +        """ Return copy of Raw instance
> > +        Parameters
> > +        ----------
> > +        fname : str | None
> > +            If data not preloaded in memory a string will open a corresponding
> > +            memory map. else in thie case np.empty will be used.
> > +        """
> > +        if self._preloaded:
> > +            new = deepcopy(self)
> > +        else:
> > +            if isinstance(fname, str):
> Instead of creating a new Raw instance, I think it would be cleaner to use
> 
> new.fids = [open(fname, "rb") for fname in self.info['fnames']]
> ..I think this should work and sorry about the many comment iterations ;)
> 
> —
> 
thanks for this!!


> Reply to this email directly or view it on GitHub.
>
This should probably call `model.get_mapping_type()` which could return `model._meta.db_table`, but might not if the model class overrides that method.
And apparently it is a BIF. Just found it in the erlang docs. Learn something new everyday.
Gehört das (151–153) nicht unter §4.3 anstelle der alten Zeile 145?
It does not. What does happen is that the test times out. So it ends up being recorded as a test fail.
Not sure how to use zstyle and doc is skimpy at best. I think I see how to set a zstyle, but how do you prefer that I go about retrieving it? Define a prompt_char function somewhere?
No, it's just not displayed here because it was not modified.
已译
Can link to http://gitready.com/intermediate/2009/03/04/pick-out-individual-commits.html
Yes, it's ok to use it like this in this example.
An advanced example could be to make concurrent requests and wait for all of them to succeed:
Future.collect(Seq(
  client.search("types"),
  client.search("sbt"),
  client.search("functional")
)).get()
Done! Added a test
yeah, that's neater! I wasn't aware of that usage.
a little more explanation would be useful. OK, really -- I'm stopping here. :-)
Какой пиздец этот ваш xlib, однако.
Y por qué pertenece a una instancia de Attachment? Qué relación tiene con este attachment en particular?
Curious here, was there a specific reason you chose to output to the log versus stderr (.debug)?
I don't think you want to do this.  The Systems menu item does work if you click it, but it goes to the same place as :systems-all-page.

So if there's a task navigating to :systems-tab it should be navigating to :systems-all-page.
I think you have missed something clever.  I have missed something clever too, because I'm not sure why it works.  At any rate I just wanted to avoid variable name collisions.  I saw this used in other tests so I copied it.

On Jul 20, 2012, at 11:50 PM, Pete Bacon Darwin wrote:

>>     beforeEach(module('ui'));
>> -    beforeEach(inject(function ($rootScope) {
>> -        scope = $rootScope.$new();
>> +    beforeEach(inject(function (_$rootScope_, _$compile_) {
> 
> Why are you using _$rootScope_ and _$compile_ here?  Have I missed something clever?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/angular-ui/angular-ui/pull/81/files#r1210559
Here and everywhere else, please separate all control structures (and their bracketed code blocks) from surrounding code with a blank line.
If you remove the +1 in the menu item creation, then the relational operators need to be changed here.
Please add jsdoc comments for ctor()
the os.chown and os.chmod would also be screwed if images.fetch didn't download a regular file.

I think the assumption is OK.
I'd rather have the DBInstance.find_by filter based on tenant_id. This is more an after thought so we don't have to do this right now. But it might be good to consider  filtering the db query now that we have tenant_id in the database. 
One thing from earlier conversations was that it was annoying for an admin user to see everything like nova show now from the public api to an admin user. This might be something we can fix in Reddwarf, not what we have the tenant_id
-1

We already have getCacheName(), what's wrong with it?
I'm not sure I follow.  

* What is being stored in this temp results map/cache?
* Who uses these temp results?  E.g., in a cluster of {A, B, C, D, E}, for an M/R task kicked off on A, a single temp results map/cache is created for all temp results generated on all of {A, B, C, D, E}?  And if so, who then uses these temp results?  A?  Or the node generating the result (e.g., all of {A, B, C, D, E})?
Yes, but how do I access the base of log scale axis?
The idea was simply to not break anything else that was already passing something fruity. I think it might just get down to the point where the ```transform_path``` etc. methods are called and blow up if they don't exist on the thing in ```self._transform```, though I am not entirely sure.

I'm not too fussed either way, but I am happy to be less generous and just try calling the ```_as_mpl_transform``` method, and if it doesn't exist, oh well... what is your preference?
As a general rule, when adding a new argument to an existing function, it should be added to the end of the call signature just in case the function was called with all positional arguments by a user.
Why did you take this out? We want to re-raise an exception because if any is thrown we want to stop the process with a traceback at this point and alert the user rather than continuing to attempt to run.
Also I wonder if we can completely get rid of run_tests() and move it's code into this method. I don't see a reason for another such simple wrapper.
We should use PEP 8 for imports here - http://www.python.org/dev/peps/pep-0008/#imports
    Imports should be grouped in the following order:
        standard library imports
        related third party imports
        local application/library specific imports
    You should put a blank line between each group of imports.
See previous comments about asserting this within the connect method.
This logic might actually be better in GaiaTestCase to do something along the lines of the following:

if wifi test var is defined:
    // do the logic you show

That way, the wifi enabling logic can be reused by any test easily

Also you need to take into account that wifi could be enabled, but under a different ssid
- Faça um commit separado, pf, pra corrigir esses urls locais para relativos ../
We can probably remove showSettings here, as this widget doesn't have a settings view.
@gsilver Could you convert this to use the new CSS style?
thanks, I'll revise it.
@chillu I've removed the preference for 5.4 and just left the requirement at 5.3+ for now.
@chillu / @halkyon any reason why we need to do this? Could we automatically populate $template using classname with a fallback of parent class and so on?
I don't think this was me, but it looks like that was commented out anyway?
What do you mean by making it private, set public to false on the definition?
"read"ではなく"all"にしてはどうでしょう？
どちらでも動作に影響はないですが、現在は認可が全アリか全ナシのどちらかなので、"all"が妥当かと思います。
this is a codemirror thing - the codemirror lines are in a div with class "codemirror-lines" and you don't have access to that other than queryselecting it (what do you mean multiple codemirror instances on a single page? surely no one will ever want to do that).

That said, passing it as argument is a good idea, so I'll change it to that.
why not use `where(:alternative => alternative)` ?
The functionality didn't seem to warrant a new sub-directory, so I added it to conn - I'm not attached to that decision.
여기서는 2-depth에서도 항상 ListDataProvider를 생성해서 맵에 추가하는데, 생성하기 전에 이미 맵에 들어있지 않은지 확인해야 합니다.
Double quotes according to Nils and Igor and Callum....
ah you're right.
Are you sure you want to override the parameter ``$options``? This often makes code less readable. I also found this on lines 83, and 104.
Ok. Thanks.

You can push a new commit on your gles20 branch, and that commit will appear in the queue of commits to merge. No need to open a new pull request
DbLoader is not the right name IMO. It should be OrmLoader instead
Maybe you could use the BaseFragment onResumeUseCase & onPauseUseCase methods.
For example, take a look at WatchedGridFragment.
There already is a `phpunit.xml` configuration file in the repository. Why add another one?
What was the change in this file? This is a pretty heinous diff...
Here we just list
This assignment[:Answer] stuff is very specific -- feels like it should be refactored out. (maybe a new class to hold these things?)
You do know that `is_anonymous` is defined as `not is_authenticated`? :-)
Ok thanks for the hint. Hopefully I manage to fix this :)
Found out that too late, sorry.
You should maybe use xpath or something. This is ugly.
Use jQuery.grep to remove the user from the array.
No need for those variables. Just do `$('#id_password1')`. We will not rename element IDs so often.
Or just `openhours_content`.
For now we will have only 50x50 images of users. We will improve that later.
That's basically the old code, left as a backup if the new one is not available.
Typo `hart` -> `heart`
no need to create an empty list, it's enough just use what  _changed_fields contains.
tab at EOL removed
use OnEffectHitTarget, during BeforeHit, GetHitUnit() will return NULL
convert in creature_text
Username ja, Passwort nein (das sollte auch nicht getrimmt werden, Leerzeichen sind theoretisch gültig).
"$identity is here an `Application\User\Entity` instance (as we configured it above)

^ that's enough here ^
Now, it adds a more detailed description
supported list outdated (or out of sync with README.network-devices)
`[key.to_s].pack('m0').chomp.tr('+/', '-_')` would work on 1.8/1.9 and remove dependency on base64 while being a more urlsafe way to encode the value as base64.

See https://github.com/ruby/ruby/blob/trunk/lib/base64.rb#L61-90 for the stdlib implementation, I only added `chomp` for 1.8 compat.
it depends on the json structure. If you have a complex json and just want to access some field deep in the structure, avoiding tuple wrapping and creation of new maps and objects could make some difference. Besides, if someone have to bother adding a field specification to speed up processing, why not use it in the most effective way?
```
@config = args[:config] || load_config_file
```

Or args.fetch ?
Correct, and for this case all deployments are related ti get deployment logically as they need to locate the deployment
=> comments
Should use double quotes in new code.
If rc == NGX_OK, call the NgxFetchWrite directly.
I will do that yet. Thanks.
There should be a ` after the attribute
Decent quick fix.  I'm not 100% clear on the conditions that lead to this, but it sounds like no one is, so this is reasonable.
has better sentence flow imo.  though, i'd change "ways" to "situations"
Yes, I believe that's what Jimmy is saying:

Map<T1, T2> object = new HashMap<T1, T2>();

Even better, use com.google.common.collect.Maps for Guava:

Map<T1, T2> object = Maps.newHashMap();

Nima

On Fri, Feb 24, 2012 at 12:59 PM, Zhai Ke <
reply@reply.github.com
> wrote:

> > +        * (-1.0 / 12.0 + f
> > +            * (1.0 / 120.0 + f
> > +                * (-1.0 / 252.0 + f
> > +                    * (1.0 / 240.0 + f
> > +                        * (-1.0 / 132.0 + f
> > +                            * (691.0 / 32760.0 + f * (-1.0 / 12.0 + f * 3617.0
> / 8160.0)))))));
> > +    return r + Math.log(x) - 0.5 / x + t;
> > +  }
> > +
> > +  /**
> > +   * Approximate the trigamma of x.
> > +   *
> > +   * @param x
> > +   * @return
> > +   */
> > +  public static double trigamma(double x) {
>
> I don't understand, Map is an interface, right? Are you staying something
> like Map map = new HashMap()?
>
> On Feb 24, 2012, at 12:53 PM, Nima Asadi wrote:
>
> > (that's sed syntax: substitute Map for HashMap)
> >
> > Nima
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lintool/Mr.LDA/pull/1/files#r486093
>
I added the compiler.jar to the repo, but we could also install it at download time.
J'aimerais bien qu'on gère les attributs multivalués.
J'ai créé un bug ici : https://issues.jasig.org/browse/PERSONDIR-61
Mais il n'est pas intégré pour l'instant...

Pour notre esup-portail 3.2.x, j'ai dupliqué le fichier https://github.com/Jasig/person-directory/blob/master/person-directory-impl/src/main/java/org/jasig/services/persondir/support/web/RequestAttributeSourceFilter.java dans Portail/uPortal_rel-3.2.4/uportal-impl/src/main/java/org/jasig/services/persondir/support/web/RequestAttributeSourceFilter.java puis j'ai appliqué le patch.
Je peux proposer un pull request avec ça. Mais peut-être y-a-t'il une solution plus propre pour appliquer un patch sur person-directory ?
I'm going to remove the default arguments, will let you know when pushed.  Please revert if desired!
Is this line indicating that readnoise maybe should be read_noise?  We usually use an underscore to separate words in kwargs.
"Regardless of how the Image was constructed" is really only relevant to ImageView, not Image.  ImageView can be constructed from a numpy array, so we wanted to make clear that the connection was made regardless of whether numpy did the initial memory allocation or galsim.  This doesn't apply to Image, so I think this phrase should be removed for the Image doc.
Are these ```ar1 = ...``` and ```ar2 = ...``` vestiges of debugging?  They don't seem to get used.
The underscore means they are hidden in python, which I thought we wanted to do since we are encouraging people to use Shear, Ellipse, HSMShapeData instead of their C++ counterparts.  Having the underscore basically means that python users don't see them and get confused about what to use, yet since they are wrapped we developers can use them if necessary to communicate between layers, so I thought this was a good compromise.
here by spec i mean count x template ... i think that's clear enough no?
@raphaeleidus then `_.escape(123)` would return an empty string instead of "123". The point of this fix is so that null and undefined don't come out as "null" and "undefined". Check the tests I added.
This forces <code>-&pi; <= theta <= &pi;</code>, which is different to...
I got stack overflow in brain with this expression :)
I think a more concise comment like "For more information, see LINK" would be appropriate.
Can you 2 fight this out and either close this pull request or change it? ;)
``error: [5xx Error] File: application/views/report/index.php; Line: 238; Message: Undefined variable: current_product_bug_url``
Revert this file before I hit you with a trout.
> is there a better way to set CSS?

Would be easier to have it once for all Handlebars morphs in the base theme.
But as long as we don't have something like that, this way should work just fine.
Get back to me when the theming has been merged into master ;)
Ok ... Fehler lag/liegt in der Umstellung auf Einsatzort. Der kommt bei mir komplett leer an. Das kann ich aber leider ned erklären o.ä. das ist bitte dann dein Job
@yuhunglin Actually that was was what we were already doing and other libraries like jQuery do exactly the same:
http://ajax.googleapis.com/ajax/libs/jquery/1.8.2/jquery.js (read first/last line)
This way there is no need to bubble up to the real window object and that gives it a very slight performance boost.
mock_app.name = 'API %s' % mock_app.name
this is a valid fail
this variable(developer_paypal_page) is not used in the test
can we remove the assignment
Why did you change that actually?
Regarding the mixed tab/spaces and format, I just copied it from contrib.comments so that explains the weirdness. I'll see if Pycharm has auto formatting or do it manually. Thanks.
Optional: Why return the class name here? Or put this in base Wallpost, right?
On Sun, Oct 14, 2012 at 11:43:32AM -0700, Andreas Mueller wrote:
> "unfortunately" all estimators have a score-function...

Awesome! I am surprised, but happily surprised. Even the clustering ones?

But I guess that our code should also work with estimators that we did
not design. These might not have a score method.
I meant that it would be nice to be able to use the multiclass perceptron from `SGDClassifier` too (if it's already possible, I missed it sorry). I would use `multi_class="natural"` to enable the natural extension of a binary loss function.
use +=
If I understand correctly, this will also take care of the next (line 571) line:

    self._classes, self._y = _unique(y, return_inverse=True)
We need to remove both, which is what needs the TODO.
Two less lines to just apply the filter to the class variable. Noting to fix later.
these paths are wrong, there shouldn't be any platform dependant paths in this file
I found no documentation on that
change to "master" when merging
I wondered about that...
yes, you are correct.
Agreed, missed that by accident.
Put that back.
Good point, there is no "fallthrough" condition so I might as well remove the ```continue```s
the difference that i find quite significant is that my version doesn't imply that all current members where self appointed.
Adding a second param here is kind of a fail. A better pattern might be to act like a decorator, i.e.:

    rack_req = Rack::Request.new(env) # parses env and provides the params method, as well as an env method! -- rails provides controller.request
    AuthorizationCodeRequest.new rack_req
okay. I had just copied SpdyInputStream
`brew audit` complains about trailing whitespace. Some git thing or so.
I think that's a good idea!
OK!
I try to do something later today. In gmt + 1. 
Should I be on irc too? :)
Add RMDIR Docs
Please alphabetize.
This is another repeated constant. Should we move it somewhere more global?
That line, is not necessary.  I added it and then figured out that our project had not loaded the:
django.core.context_processors.request context processor.   I will remove the check.

It might make sense to write some code to verify the proper context processors are loaded, but I'll leave that to a different changeset.  





On Thursday, September 6, 2012 at 11:26 PM, sdcooke wrote:

> In experiments/utils.py:
> > @@ -38,6 +38,8 @@ def get_registered_user(self): > return self.user > > def is_bot(self): > + if not self.request or not self.request.META:  
> This doesn't seem to be the right way/place to do this to me - not having a RequestContext doesn't make a user a bot...
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/mixcloud/django-experiments/pull/73/files#r1545241).  
>  
>  
>  
>
Folders added belonging to accounts not handled by the model at this point should be ignored.
ditto: we no longer link this to gst, so this can go away?
@ is just an instance variable whereas @@ is global/static?
Variable for second argument
OK, so let's keep it this way.
I'd avoid post-conditions (`x unless y`) and negative condtions:

```ruby
if @target_method.blank?
  raise TargetNotDefinedError
end
```
Also, we're going to be committing other things to it, for account
management, etc...  We're adding it now as we build our system and
will submit soon.

On Fri, Jun 29, 2012 at 10:25 AM, Ilya Sterin <isterin@gmail.com> wrote:
> Haha, weird, I didn't explicitly do it.  Not sure how it happened.
> I'll change back.
>
> On Fri, Jun 29, 2012 at 10:13 AM, Joaquin Rivera Padron
> <reply@reply.github.com>
> wrote:
>>> @@ -3,7 +3,7 @@
>>>  /**
>>>   * Defines ThreeScaleClient class.
>>>   *
>>> - * @copyright 2010 3scale networks S.L.
>>> + * @copyright 2010 threescale networks S.L.
>>
>> company name is 3scale ;-)
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/3scale/3scale_ws_api_for_php/pull/2/files#r1076110
>
>
>
> --
> Ilya



-- 
Ilya
I had the same question after thinking about this some more last night.  Maybe returning undefined would be better than throwing?  Date.parse ends up returning NaN rather than trowing (it would normally return milliseconds).
Or I guess we don't know how many commands the quad will return.  Hmm.
Should be "Sets the ellipsoid".  And I guess the get should be "Gets" then.
Perhaps we should generalize it a bit by calling it a viewer rather than a camera?
not sure such a definition belongs to here. More like a model
is this the only way to implement this? it looks **awkward**.  can we just do this? var self = {dragEnd: same signature as the paren, dragMove: same signature as the parent} and then $.extend(self, DraggingHandler(...)) ..
Feel free to refactor this
Why? If there isn't an actual description then what value are you adding to the Javadoc?
I understand where you're coming from (it took me a while to get used to it myself coming from the Java/C++ world), but once again this is done to save bytes and is the JavaScript-y way of doing things
there should be a space before the bracket here
We shouldn't be defining global functions inside of an aui:script block that has a use attribute.

If the functions aren't used outside of this block, we can just assign them to local variables, and if they are referenced outside of this block, then we need to remove the use attribute and use `Liferay.provide`
This is wrong. Imagine two hosts configured with the same log directory (and docroot).

Let's say one is defined for IPv4 and another for IPv6. This will not work.
I'm further puzzled by the comment describing this block:

`# Since the template will use auth...`

Unless I am mistaken, `auth` seems to have been a leftover variable that was no longer in use prior to this commit (`grep -R auth modules/apache/*`).

Anyway, just really confused about its use.
ok, então manteremos até ser corrigido no parent. []s
move definitions down to initialization