labofsahil/github-event-dataset-2012 huggingface dataset:
This addition is not needed to make Brackets run, but it is needed to avoid an error message on the console. Would you rather have it removed?
This needs to be localized (like the lines above it). Add the string in src/nls/root/strings.js and then reference its key here.
We could just use the numeric value of Date.getTime()
And this one, and the one below :)
(I'll accept the pull request with or without this next suggestion

 I tend to like in-lining list arguments. I generally only spread arguments over multiple lines when they are keyword arguments or keys in a dictionary. In other words:
```python
db.rename_column('cards', 'atk', 'attack')
```
you can use `strerror_r()` to get the error string to use with the `fprintf()`
These are getting a bit awkward. I'm not sure what the correct solution is here but once we look at factoring out the Client implementations and making it more config based we should be able to find something that doesn't involve enumerating if statements for each type.
cool, didn't know this
Ah, I see that the comment is here, may we should move it a few lines up
Is there a reason why  you throw an exception with some error message, catch it 3 lines below and log the error message instead of just logging the error message directly? This looks like an anti-pattern.

It also calls ```invalidateUserInput()``` twice in this case, is this intended?
Totally fair. I'll try and make that change tomorrow.
don't leave commented code.
Get rid of musicvideo and context from this list.
Same as https://github.com/mozilla/butter/pull/1236/files#L1R8
Still need to get rid of this `+`.
I would love to use `span` here if we can. At the very least, leave a comment saying what this is. I thought it was italics :P.
Very useful addition
On 08/07/2012 02:41 PM, Peter Waller wrote:
> [float target_integral]/

Done.

Best,

Seb
例子这样就好：
    location /static/css/ {
        concat on;
        concat_max_files 20;
    }

    location /static/js/ {
        concat on;
        concat_max_files 30;
    }
I think a loop would be faster here (and below), it can return immediately after the hit and avoid creating temporaries
Updated the js files touched to use this convention (system.js, packages.js and system.js).
Table needs a header row, like 'name'
should this return?
wrong indentation. Please use spaces, not tabs
Switched to one static class (same as routecollection extensions)
* Xu_R facedesks (-.-) (_ _) *wham*
Why do you need to specify `auto` here?
Why do you need that? you control all the scope of your own window.
Wait, are you saying that the emulator is automatically built along with the rest of gecko when you run build.sh?
I would have thought that you'd have to pass an argument to ./build.sh to get it to build the emulator.
Is there some way I can turn that off and shorten my build times?
You should use `libcloud.utils.py3.urlencode`.
For future-proofness, it would be best to also import ``print_function`` and change the print statements to the Python 3 syntax ``print()``.
This code block works and there is no practical performance penalty for parsing the formats twice, but is there a reason not to just use the `col.format` values that get defined later?  Now that I am learning about DAOphot a little more it seems like the format header line is absolutely required, so it seems like you should be able to do this all in one line (later in the code):
```
col_widths = [int(col_len_def.search(col.format).group()) for col in self.cols]
```
This hinges on not needing to do the `width[-1] = 80 - sum()` bit.
Print `az` first, i.e. `(az, el)`, to be consistent with the other coordinates which all first print the longitudinal coordinate, i.e. `(lon, lat)`?
Can we show the results here?  (Even if truncated for brevity).
fixedalong with the others from @astrofrog's comment above
I'm going to go have me some franch fries and drink some Peh-roo
There's no point in implementing it. The only case where you'd use it, is something that needs to be solved in another way: you'd need to have taken an upgradable lock in the first place. If data was read while in the shared lock, and used to make an update while having the exclusive lock, the results will be wrong if an update happens in between.

Ideally, every public method of a well-encapsulated data structure will either take a readonly or upgradable lock, and the inner code can take exclusive locks when necessary. Not taking an upgradable lock if you intend to make modification in the same lock-session is simply an error.
This is suspicious. I think that the value of `i` will be same for every load callback. Relying `Ext.each` should be an easy way to fix that.
Then it should be an internal explanation with an amazing warning message.
That previous note was from Craig, ignore the incorrect github account
Please remove this import since it adds an explicit import dependency on `traitsui`
`_space_` is deprecated in favor of `spacer`
Well, technically you don't need a parent to create something. I'm still a bit unclear on how it would have to be set up on the create.js side, but @bergie mentioned a couple of times that creating objects without parents should be possible. The reason I never tried implementing it in createphp is that I don't know how to determine the object's type if I can't derive it from a parent reference, which was mentioned in some other tickets.

Anyhow, maybe we can change the wording in the exception to say that creation without parent is not supported at the moment or something to that effect
Variables are camelcased, see codingstandards.
I wanted to avoid `shell=True` but I thought IPython allows space in editor config, no? For example, `emacsclient -tty`.  If user want to set a path to editor program containing spaces (especially on Windows), it will be problem because you can't do `editor.split()`.  You can use shlex in stdlib but I think it's too much for this purpose.  What do you think?
Just curious, how well did jsbeautifier do and what did you have to do with sed?
Can we follow PEP8 style names like left_arrow, right_arrow, etc.  Even though this is JS, I have been following PEP8 in the Javascript as much as possible.
On second thought, couldn't this just return an `int`-encoded boolean/error? There's precedence with `git_branch_is_head`.
Hate to be a partypooper, but this is going to race. We'd have to explicitly initialize the CNG interface, or alternatively, lock the initialization function.
We need `GIT_` prefixes for these macros. `GIT_SSL` or the likes.
"Otherwise only the last selected item" (the query parameters being in the URL is an implementation detail)
I'd put the ``%`` at the end of the line, not the beginning, but I am unsure if that's what PEP8 demands.
Fixed with overrides in `home.html`.
yeah... that's why i kept it separate. i just forgot. because i'm dumb.
Nit: FirefoxOS -> Firefox OS here and elsewhere.
OK for me. I didn't know of the single_value_sql function
Updated the version in de8ff7c, not sure if there's a good way to compare requirements.txt but will look into it... I am mostly concerned that we have known versions going through the dev->stage->prod cycle.
I seem to remember some sort of "SELECT OR INSERT .... WHERE ..." or something like that which returns 1 or 0. 

If you can't find something postgres-hacky like that, at least do two SQL queries inside the same connection.
To lessen the chances of a clash with a template function this new function should be exported as `_loadTemplates` I think.
Can you explain this one please dude? I guess this could fix an issue where HMVC requests to a page dont work?
This is strange. Can you provide a full code example?
Looks like there is a lot of template comments, especially in here.  These need to be removed or rewritten.
I don't see an problem with addRoute() receiving both routes and collections. It does exactly the same thing whether the argument is a route or a collection.
I think my solution can easily be used for Drupal. You custom UrlMatcher would simply do something like

    public function match($pathinfo)
    {
        if ($pathinfo instanceof Request)
            return parent:match($pathinfo->request->attributes->get('system_path'));
        }
        return parent:match($pathinfo);
    }
``isValid`` is deprecated. You should implement ``validate`` instead
you should remove ``_type`` from the type name (it is totally useless: all form types are types) and prefix it with ``propel_`` to avoid clashes)
This shouldn't be changed. In Finnish we don't capital letter in the default shortening of the week days. 

They should still be su_ma_ti_ke_to_pe_la .

See references:
 http://webcgi.oulu.fi/oykk/abc/kielenhuolto/oikeinkirjoitus/lyhenteet/lyhenteiden_lajit/
 http://koulut.tampere.fi/materiaalit/kieli/3_2_3.html
 http://fi.wikipedia.org/wiki/Lyhenne
yeah i forgot i had alot of these ill just close the request for now and trim out the unnecessary files
remove comment above, code is obvious
Hash syntax, quotes.
Ah ok, it's to stick with the doc-comments convention `Class#method()`
Dit bestand graag verplaatsen naar SuperPC/Models/Repositories/Interfaces
Like in other part, add a Box to handle the semantic of a failure.
Monty exposes a ```monty.RESOURCES_DIR```. Could we use a similar approach for Cartopy?

I think it might be easier for a user to remember ```cartopy.DATA_DIR``` (or whatever) rather than ```os.path.dirname(ccrs.__file__)```.
tbh, I'd prefer the verbosity of something like "child_plugins" to the orthographical wrongness of "childrens"
These lines are simply indented by one character.
There are only two corpus views, one for read and one for write. this replaces all the others and just sets up the two current corpus views. 

This also means we only have two places for the corpus, either fullscreen or embedded
indeed, did not thought about that when changed the log line, how do I solve this kind of change, remove the old localised messages and start some process to find the new ones? Or do I need to figure out the translations by myself?
This header isn't needed. It looks like this was unintentionally left behind?
constructor should be private
This is because you never deployed a bundle with persistence.xml in it.
The issue with unresolved bundles passing through DUPs after the MODULE phase is discussed in great length in https://issues.jboss.org/browse/AS7-5477

> can the developer use both OSGi persistence (e.g. no EE @PersistenceUnit/PersistenceContext injection or equivalent) and EE container managed support?

We'll have to look at that - I'd say yes.
spacing between parens and quotes
Removed usage of .disableSelection(). That also removed the need to write a comment and test - WIN WIN! I can't really tell in which case it was possible to select text before; the only way I found working was double click, and even that just in IE7, not Chrome.
Hi Scott
Everett Zufelt said this was needed to sandbox the screen reader to the modal dialog.
He's the best one to answer this.
LR
Should there be a `free(tracks)` here as well?
FWIW, I hope not. But... being completely honest, that's mostly a problem for Twitter, not for us. Calling something that's written on the source code available for everyone to peruse a secret is beyond ironic, but if Twitter's happy with anyone using the API as if it were the Gaia app, then that's Twitter problem. Although in that case they should just have used 'password' as consumer secret and be done with it.

Also, and before anyone asks (if someone was going to do) this is pretty easy to spot, but I don't know of any way to hide a secret on a users' device from said user that will last hidden any reasonable period of time. So the only way to keep that secret secret would be to not send it/store it on the users' device at all.
`PickRepeat.daysOfWeek` ?
nit: I would move the comment inside the if block if i was you
same here, avoid tweaking style in Javascript
no need for adding ' around the name of the method.
better way to do this: 

    certificates.forEach(function(c, i) {...});
The functional tests sound way too heavy compared with the node.js version selection tests. I am concerned in practice we will be unnecessarily loosing coverage by moving these tests to the functional group. These tests run in a snap, so time cannot be a concern here. What is your concern with leaving them as unit tests?
________________________________________
From: David Fowler [reply@reply.github.com]
Sent: Tuesday, July 10, 2012 9:39 AM
To: Tomasz Janczuk
Subject: Re: [kudu] Support for multiple node.js versions (#120)

> @@ -129,5 +132,184 @@ public void TestJsFileWithAspxAndNodesModuleFolder()
>
>              Assert.Equal(null, nodeSiteEnabler.GetNodeStartFile());
>          }
> +
> +        private string CreateTempDirectory()
> +        {
> +            string path = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());

Yes, the functional tests are very slow to run. Check out the wiki docs here https://github.com/projectkudu/kudu/wiki/Running-tests

---
Reply to this email directly or view it on GitHub:
https://github.com/projectkudu/kudu/pull/120/files#r1132723
This is patched in current visor, you can use `IsErrNoEnt`
FYI: Not reviewing this module
What if the time that is passed in is already a time?  `Time.parse(Time.now)` returns an error since it expects a string.  Seems like this should probably accept either, but I'm up to discuss.
'agent99 how is bluesteel performing' -> channel gets told 'bluesteel apdex is 0.8'?

Sounds ok to me; prompting discussion about performance is a good thing.
I still don't understand this TODO. What does it mean that "public should be done transactionally"?
`data` doesn't mean shit.
The type, headers, upCallbacks are data too.
Leave it as `form`, which implies in its name that this is the 'data' that will be sent.
i used this in a Healthcare demo where it was useful but your comments on correctness are valid so happy to leave this out until we need it and then do it propertly
I've done a lot of testing, and I am unable to find a circumstance in which `optionList` is **not** null.  Does anybody know when this code is used, or is the optionList stuff just dead code?

**Update:** to clarify, `optionList` is **always** null in all of my tests.  This means that the block of code here never actually executes, and thus the entire `transferOptions()` function never evaluates properly, and the only line of code in here that actually does anything is `optionsTable.remove(fromItem, fromStats);`
I would like to have the option to still read the password with getpass. That way if you run the from the command line your google password is not in the history.
Das muss wohl noch angepasst werden ;-)
This is more than `addLink`, but the same comment I made about `datetime` objects from the db, and handlng adding the link in `base.Endpoint` probably apply here.
`instance = this`
Use the `tar` shell command instead of throw an exception?
What do you think?
why wouldnt you use the bang method rather than throwing this manually?
for which particular VNC it is?
Is this the _only_ kind of `SSLError` that can occur, or just the only one we don't wish to retry?
This doesn't follow our style guidelines, please check out the [wiki](http://wikipedia.org)
这里可能产生 IndexError。
@ochameau aren't we supposed to be using `'` and not `"`?
on -> you
Does the flow always go through siteCount first?  Is there any danger of allSiteInfo being undefined at this point?
That's not what I intended to see. I will come up with an own commit.
nit:please use brackets around the comparison
I've added it as I haven't yet figured out how it's working :) I will remove after it will be clear or changed
Good catch. Updated with the next commit.
i think we still need to do a lot of work to make the QOM interface a but more enjoyable and less verbose. this is a step in that direction. obviously one looses the implicit validation. but no we don't validate anywhere else but i don't think that is necessary
this should be documented as it has to be implemented by children classes.
@vrthra can you add `/^legacy_run/`
Fixed in https://github.com/puppetlabs/puppet/pull/630
@daniel-pittman does this work if the current user has full control over `file`, but the user does not own the file? I assume it should work, but I remember Nick saying he had problems with preserving the ACL of the overwritten file.
You have to create slots for the user defined signals
This is not necessary at all. If the window is NULL, there will be an error (segfault or whatever they call it in Win32 land) in any case and it will be a lot nicer to deal with in a debugger if this kind of checks are not made.
Single percent is meant for EOL comments.  Just saying cause this will confuse emacs erlang-mode.  Deal with my nitpicking comments :)
I'm curious why you used `$(document.getElementById("output_" + this.session_id))` instead of `$("#output_"+this.session_id)`.  Is this significantly faster or something?
If you ask a user to provide some timestamp, he'll close your app and never open it again. :) Still, if you want to prevent users from deleting valuable data, you could add another confirmation step.

--  
oleg dashevskii
Отправлено при помощи Sparrow (http://www.sparrowmailapp.com/?sig)


среда, 25 июля 2012 г. в 17:09, Anton Petrunich написал:

> > export_datetime = begin
> > Time.parse(params[:import][:csv].original_filename.split('-').last)
> > + # FIXME you can't rely on the filename
> >  
>  
>  
> In this case we can't delete data via export.  
> I have only one suggestion to solve timestamp-based delete -- user should provide data actuality timestamp via web interface on import form.
> In this case we can remove all records, which not updated from this time and do not listed in CSV file.
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/solenko/phonebook/pull/1/files#r1233642
>  
>
isn't ```switch``` better than this long ```if ... else if ... else``` constructs?
Shouldn't this be `true` instead of `"true"` ?
Explicit if/else is preferred personally.
s/inherits/inheriting/
Instead of addValidator(), maybe setValidators() and getValidators()? I might want to set the entire validator array.
> What is the typical timestamp column type for DB writers?

The column type is [timestamp or datetime](http://dev.mysql.com/doc/refman/5.1/en/datetime.html) for MySQL (or MariaDB).
ну и тут тоже можно уменьшить дубли, мы вызываем urls.create_and_activate_api_subscriptions_url в любом случае
это тметодя получает хэш с определеннными параметрами всегда, значит надо добавлятть в хэш некоторые элеменыт по условию

все можно сделать так

arguments = {:subscription_name  => subscription, :format => :json}
arguments.merge!({:resource_type => resource.class.name, :resource_id   => resource.id}) unless resource.nil?
urls.create_and_activate_api_subscriptions_url(arguments)
use Knp\Bundle\KnpBundlesBundle\Entity\Bundle;

refacor it in next PR to use just (Bundle $budle)
ANOTHER UGLY PART
Actually I see what you mean. You're right that it will when USE_SYSTEM_HEADERS=NO. My mistake.
Not required, but recommended since it doesn't require a separate method.
Thanks :) updating the pull request.
this is refactored out the next wallop
Adding a back reference is the same number of characters in the regular expression and adds an extra argument in the replace function. Seems like it doesn't really buy us anything.
Missing line break between assignment and method call
I think that  a better option would be to rename the open that's in utils to pelican_open for instance, and use the open from codecs explicitly when needed, because here I'm not sure everything will behave the way we want :-)
rename this patch file to 'old-libstdc++-hash_fun-map-set.patch', since it's not tied to gcc but to libstdc++
I'd go with the latter.
Is that presumptuous? Can the admin URL be config'd as something else?
Man, that sucks. I really dislike that.
Right on; sounds good.
Should be able to `.get('db')` from habitat and receive the object being built here by hand.
maybe rename the function `getPreviousOptions` as well?
This is on a button, so should be in the form of a verb phrase (e.g. Format SAML Response)
general.use_original_file()
should be:
"firstName": Chester L., Jr.
"lastName": Craig
citeproc handles this


On Tue, Dec 4, 2012 at 8:37 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In Google Patents.js:
>
> > +				"title": "Cold-water soluble tamarind gum, process for its preparation and its application in sizing textile warp",
> > +				"abstractNote": "A novel composition of crude tamarind kernel powder (TKP) is disclosed. The novel composition results from a process which makes TKP soluble in cold water; this process is not dependent on purification of TKP, but involves dissolving it in hot water and evaporating the resulting solution. The novel TKP composition has utility in textile, paper, and oilfield applications.",
> > +				"libraryCatalog": "Google Patents"
> > +			}
> > +		]
> > +	},
> > +	{
> > +		"type": "web",
> > +		"url": "http://www.google.com/patents/US4748058",
> > +		"items": [
> > +			{
> > +				"itemType": "patent",
> > +				"creators": [
> > +					{
> > +						"firstName": "Chester L. Craig",
> > +						"lastName": "Jr",
>
> This is clearly broken, but I don't recall right now how we handle this.
> Does "Jr." go into the first name? If so, how is that formatted?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/503/files#r2316299>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
Maybe it would make more sense if you created a constructor method that can return null if there is an error (aka factory method).
Side comment on this - we should try to avoid these sorts of changes...
you are correct, the .longValue() is better.

As for auto-boxing, are you sure it's slower than creating new Objects ? (AFAIK the compiler uses some object pools in certain cases)
you can rebase your commit and force push
ok so this is a comment
"everything related" -> "everything related to"
Please look for more concole.* in your source code~
Shouldn't the attribute name contain "Usage" instead of "Composer"?
Sadly not always development and test servers have valid ssl certificates so it would be nice to have a possibility to use this line there
Oops, probably I messed up with git.
почему не использовать итератор вектора?
в init перенесем?
я думаю, что можно убрать слова get и Division без потери смысла
I don't see a problem here. It's only being used from inside the same compilation unit, so the initialization IS guaranteed to happen before the class uses it. #defines are just bad for various reasons.
I don't know--there are a lot of levels of debugging in java that can be *insanely* detailed.  And they are used by a lot of the third-party libraries.  I'm inclined to think that DEBUG is as low as we want to go without someone taking the extra time to specifically ask for a more granular one.
I presume that I should get rid of the whitespace here too, then.
Yeah, you are totally right about letting Bone do this.  Will fix up.
Yep, but I prefer them (most of the times).
Couldn't the dummy_app task do this itself?
Do we have the current ttl here? If so, we could avoid updating if the update is within the last x seconds of the last update.
Can you earmark this for removal with a TODO?
I would slightly extend this test by doing the following:

1) Get all tenants, check that there are 2 of them
2) Create a new tenant
3) Get all tenants, check that there are 3 of them
4) Delete/disable the tenant
5) Get all tenants, check that there are 2 of them
While you're in here can you please add a block comment header for this test.
A method may have more than one classifier.. I am not proud of this code, but I spent some time thinking of better designs and didn't find something that I like. Any suggestions are welcome.
Italicize "Allow Multiple Categories"
sure! i was thinking that we might extract some tab related things from the controller as well if necessary
If the constructor isn't declared and explicitly private or protected, then direct instantiation is not prevented.
Вы не сохраняете ДНК во временную переменную, вы по сути сделали ещё один "ярлык" на свою ДНК, и будете работать с ней.

Символ звёздочка означает, что переменная - указатель. Она указывает на какую-то область в памяти, где находится наш объект. В данном случае присваевается не значение массива, а указатель на этот массив.
А вот тут, уже мой недочет. Просто когда выносил в отдельный файл категорию, переименовал и забыл, что название должно быть иное.
Бросается в глаза небрежность  кода и несоблюдение правил хорошего тона. Например, блоки циклов хорошо обёртывать в фигурные скобки, даже если блок из одной строки.
Same as the mac comment. This comment is a little confusing here since the code immediately following is when the shift key is not down.
The line doesn't mention or use ```canChooseDirectories``` —possibly looked at the wrong column of your diff?
no need to remove this space
not sure what you mean, I dont see any eval/Functions in here
will swap to MIT
why keep those commented out typedefs?
My thought was that I wanted to minimize leakage of easily identifiable information through the logs, but fair point. It's at a non-standard logging level and is hopefully obviously potentially-compromising information. [Fixed](https://github.com/Thynix/fred-staging/commit/fd7c52f46d68809c7a9688c0ffca21664b0dbbd6).
Derp. Nice catch.
@salva16 I assume it was an accident to remove this comment?
Yeah, js/lib/socket.io seems like the right place for it.

Can we make it optional somehow, so it's only pulled in if needed?

i.e. for people running on OpenShift, and for anyone using an Arduino controller?
Can we make this optional?  I'm worried about our test-kitchen setup getting too heavy and polluting the test.
disperse vs disparate?
I had to change some of them to def in order to test them... they were implemented as lazy val underneath, which meant I couldn't have one test testing with a domain or application context set on the session, and another without, without restarting the JVM.  Changing to val solves this.  It is a performance hit, though I don't believe it's a big one, and it's one that can be solved in other ways (we might decide to implement some sort of parsed config cache in application to deal with this, for example).  And I think the tests here are really important.  So on the trait I changed them all to def for consistency, and then in the implementation had some as vals and some as defs.
the rule is "same length than the title"
<link doc="ngx_core_module.xml" id="user"/>用<link doc="ngx_core_module.xml" id="user"/>
有一个错了
麻烦在前面加上
  Copyright (C) Igor Sysoev
  Copyright (C) Nginx, Inc.

官方版权，以示尊重
This line is where the params are merged into the existing params.
can you make that blue?
Again, `o = Object.create(null)` is a more concise solution.
Примерно по той же причине, по которой локальные переменные лучше глобальных.

Локальный анонимный неймспейс, ээ, локальнее функции-члена класса. И
имеет меньше доступа к меньшему числу переменных. Поэтому лучше. Таким
кодом легче управлять, и легче делать предположения о том, что он
делает.
`dists` if can
多一個 `%p` 的用意是??
I would prefer to use '_cents' for now.
Is this necessary to raise an exception? I feel like most DB APIs allow you to start a transaction as many times as you want.
missing a c in account. I had the same typo in my PR
If we're setting custom headers we should use a proper prefix.
we need to kwargs it.
`god_mode` :godmode:
should this default limit be configureable?
Really nice that you tied the operations back to the domain. Much simple.
Tämä on nyt sama kuin:
~~~clojure
(cons (first coll) (my-take (dec n) (rest coll)))
~~~
Let me do some more testing and i'll let you know what i find.
Thanks German,  

I'd rather not having to add ActiveSupport as a dependency specially because it only breaks with 1.8, could you try to refactor your solution?
No need for a dedicated class, this can be in the `AuthorizationServiceProvider::boot()` method.
Comment added in 838b9713ece51ecd01b7304378b99eb3596be18e.
`[module].quantify` must return a `dict: attribute -> float`, or else it won't work with `analyze.py`.
This was a little hack for the cxf plugin. I was thinking to remove it because we would use cxf anymore. Should I remove it or rewrite it?
Just to be double sure: can we test the remove whitespace option within the iteration above? The object we iterate over would then have anther key expectedWithTrim, for example.
Need to also ensure

```php
$this->getTarget() == 'Email'
```

Really, we should probably accept the `target` (`source` in `class.ticket.php::create` I believe) in the `$info` array and ensure that matches, but otherwise, the above block is a good start
I added `puts "test"` to my database.rb file and this is the output when running the example

    ~/Code/goliath/examples/grape $ ruby server.rb -vs -e production
    test
    [24298:INFO] 2012-05-09 10:12:35 :: Starting server on 0.0.0.0:9000 in production mode. Watch out for stones.
@bp323 Can we fix the lines that have changed to comply with our styleguide?
This could blow up if `String` is supplied. Please use `PropertiesUtil.toStringArray(properties.get(PROP_DATE_FORMAT), new String[0])` instead.
This is better :-) I think we should keep specific versions as much as possible, otherwise we will have the issues as before when using this dev-master.
Just FYI, Node already has a module for parsing urls built in - `require('url'); parsed = url.parse(myUrl);`
I'm not sure whether throwing an exception here is the right thing to do. The intention is to buffer uploads to a temporary file. We do the chmod and unlink for security reasons. Of chmod and unlink don't work because e.g. the system administrator is using a strange filesystem then my opinion is that the operation should continue; the sysadmin is responsible for choosing a filesystem that allows security features to work.

That said, continuing silently is probably not good either. I think you should print a warning here.
Are you sure the variable ``$stmtResource`` exists, or did you maybe forget to declare it?
Please always use braces to surround the code block of FOR statements.
The same as above - now simplified
add space after if; remove spaces inside parentheses
Made appropriate change.
But along with this I have changed scaleY to be scaleY += 1;
for this screen 4 squares should be presented with click listeners. 
If setting scaleX not equal to scaleY we will not have a square. 
Actually this difference in scaling is mostly needed for buttons. Originally there are buttons with width = 200 and height = 20. For blackberry this values are cut off. width = 400 and height = 60 is enough that's why for button containing views this scales are 2 for width and 3 for height. 
But here no button is used so setting them equal to have squares on the view.
Magisterką byś się zajął
Ist zuständig für den ForwardedFor-Header, der teilweise von Proxies gesetzt wird.
Sil, we recently updated the guidelines, the recommended naming for bundles is now "cfdc_<sketchname>_<bundlename>", see https://github.com/cfengine/design-center/wiki/How-to-write-a-new-sketch for details.
Sounds good. I'll also do this further down, where the raw strings are also used for the RegExp()
To avoid the costly `count` and `=`:
~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
In fact it does.  It's not really the best fix (as there are other options) but that's actually what led me here.  I took a few stabs at the regex and decided that this was a quicker path to something working ;-)
cmd is the default filter so we don't have to add it explicitly.
Not really standard for datastore options... it differs from datastore to datastore although some options are semi standard like "namespace" which declares the feature type namespace and "url" for stores that accept a url/file parameter. Anyways, if you do decide to make the option something a bit more i think its fine to have the importer add in some behaviour specific for the csv datastore... we already do this for things oracle.
I'm not sure, but does empty? works on strings too? (I know it works in rails, but i think thats rails specific)
Use label for checkbox. Not just have text next to it. Connect it semantically.
This is not constant. Also, global variables should be kept to minimum.
Ah, would that explain the 'module broken' error when trying to compile 
the sqrt.x86.clay module with debugging symbols ?

On 29/02/12 19:45, Joe Groff wrote:
>> @@ -0,0 +1,10 @@
>> +
>> +public import math.native.*;
>> +import simd.*;
>> +
>> +private external ("llvm.x86.sse2.sqrt.sd")
> LLVM intrinsic externals need the `llvm` attribute so they will be codegenned as LLVM intrinsics rather than as C functions:
>
> ```
> private external ("llvm.x86.sse2.sqrt.sd", llvm)
>      x86_sqrtsd(a:Vec[Double,2]) : Vec[Double,2];
> ```
>
> The externals in math/simd/simd.x86.clay should use the `llvm` attribute too.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/229/files#r503175
It would, of course, be highly preferable to have a test suite that is able to run the negative tests.
>I'd personally leave the 1.4 there certainly, rather than remove it completely. It's 2.7, so it's certainly useful over nothing at all.

Sounds like the best plan at this point.
Не персистент
Hi

This is to avoid memory leaks with the transfer from Core Foundation objects back into ARC. When __bridge_transfer is done for 'result' we leave it to ARC. The 'result = result' line is to avoid Xcode Anaylzer warnings as this value is unused.

Also see: http://stackoverflow.com/questions/7827730/iphone-fetch-data-dictionary-from-keychain

regards
peter

________________________________
From: Victor Ilyukevich [notifications@github.com]
Sent: Sunday, 25 November 2012 10:46 PM
To: MugunthKumar/MKStoreKit
Cc: support (One Red Dog Media)
Subject: Re: [MKStoreKit] Fix for Memory leaks in Keychain (#114)


In Externals/SFHFKeychainUtils.m:

> @@ -182,9 +182,15 @@ + (NSString *) getPasswordForUsername: (NSString *) username andServiceName: (NS
>    // version of this code (which set the password as a generic attribute instead of password data).
>    NSMutableDictionary *attributeQuery = [query mutableCopy];
>    [attributeQuery setObject: (id) kCFBooleanTrue forKey:(__bridge_transfer id) kSecReturnAttributes];
> -  CFTypeRef attrResult = NULL;
> -  OSStatus status = SecItemCopyMatching((__bridge_retained CFDictionaryRef) attributeQuery, &attrResult);
> -  //NSDictionary *attributeResult = (__bridge_transfer NSDictionary *)attrResult;
> +
> +  CFDictionaryRef cfquery = (__bridge_retained CFDictionaryRef)attributeQuery;
> +  CFDictionaryRef attrResult = NULL;
> +  OSStatus status = SecItemCopyMatching(cfquery, (CFTypeRef *)&attrResult);
> +  CFRelease(cfquery);
> +  NSDictionary *result = (__bridge_transfer NSDictionary *)attrResult;
> +  result = result;


What it is the reason for it? o_O

—
Reply to this email directly or view it on GitHub<https://github.com/MugunthKumar/MKStoreKit/pull/114/files#r2216589>.
please preserve the whitespace convention (spaces). You can view whitespace in Visual Studio by hitting ctrl+r, ctrl+w
So ists weniger overhead :) Aber wenn du willst kann ichs bei Gelegenheit anpassen (oder du machsts gleich selbst).
Najaa.... ;)
Can we be sure mktemp exists on windows?
Inner spacing: `console.log( x );`
Yeah, good point, I'll move this to HadoopUtils
The other benefit of moving things to `.prototype` is performance and memory use (minimal change here, but generally applicable).  By defining them on the prototype, they're only defined once, and all instances share a reference to the same functions.  When defined in the constructor, they're defined on each call to the constructor and multiple instances of `Heater` will point to individual instances of these functions.
Yea, if you want this in Network, move it somewhere appropriate. But I think that this is much less important in Network. I did this to save some time on CSS parsing which became heavy when moving the zoomer overlay a lot. I don't think Network suffers from this.
Maybe your editor just deletes all trailing white space. No problem though as long as it's only two lines.
extra_fit_funcs and cov_params_func are similar to my callback idea.

What I don't see right now is whether in this case it's better to have them as extra arguments or have them as extra methods with explicit hasattr check. 

My guess is that this will be only relevant when we have more levels in the class hierarchy and we need to hand around extra function arguments.
One disadvantage is that this is mainly an internal argument, while the signature for the fit method is targeted towards users.
i add second @author section in phpdoc. is this normal?
I'm not sure what this is for and if commenting it was the right thing to do. Same with finders below this line.
please add a value to the ALT attribute as well, so this is accessible to users on screen readers
@ngokevin :+1:
Hmmm.  I see your point about x, but it is pretty standard in papers defining equations for NFW (for example http://adsabs.harvard.edu/abs/2000ApJ...534...34W which is the standard I tend to refer to), and r IS also confusing.  Perhaps we can bring in a 3rd person for another opinion?  @barnabytprowe ?
use the route application#index

frontpage seems redundant -- the application index is the frontpage
BrooklynJcloudsSetupHolder: this is much nicer than the old code
I'd use `checkFileExists`, as that is consistent with guava's checkNotNull etc.
well, if the user has something weird in his resolv.conf or hosts, that's *not* server's problem.
We won't do something crappy as:
RewriteCond %{HTTP_HOST} alias1
RewriteRule ...
RewriteCond %{HTTP_HOST} alias2
....

This is non-sense. Really.
HTTP_HOST isn't random as long as we do not have some """power-user""" bitching with /etc/hosts or dns resolver.
Same here. The `#` is the start of a comment, so the link to the cancel action is not shown. Try it in http://localhost:3000/en/users/edit
This is true, except for in search jobs. There can be a delay before a job is ready, and we can't get a refresh from it until then. Due to how our tests were written, this got brushed under the rug, but this is what led Wim to add the isReady method as well as the isDone method in the Java SDK.
Test added back in.
Yeah, that's obviously much cleaner. Changed it.
Why is `=` escaped in both cases?
OK. Anyway, after some thought, I would rename insert to add and allow timestamp, but timestamp should be equal or larger than the latest one. It should be monotonically increasing. It you do not specify timestamp, this is natural to happen. I am not sure if we really have to check that or just define that you should be using API like that and that if you are not, bad things can happen. This is why I would rename it.
Make this name more meaningful. cycleTips.
Funky. I didn't know you could use non-ascii characters in a css stylesheet.
Awww no cedilla?
Integer.toString уже возвращает String
А если [1] будет пустым?
If this is a test then leave it here and rename with test but it looks it should be a page object or functions in page objects.

Can you move it out of the test and break it down into the page object for the page it represents? 

Remove the assertions from it and put them into the test.
This is essentially doing an assertion here so it should not be contained in this file. The assertion should always be put in the test itself.for a few reasons. 
Firstly it makes the test very readable.. for example `assert.equal(date_on_page, date_today) is fairly clear to what's being asserted.

Also it is better to use the date directly in the assertion instead of just true or false. This is because when it fails it will give a more informative failure message.
More specifically, does the helper template give more flexibility than having these requirements buried in the gem?
Use the built-in skimage logger:

```python
log = skimage.get_log('filters.rank')
log.error('My error message')
```
This sentence doesn't parse.
All input validation should go into fit, I think.
Which is some what weird, as this doesn't need to be called. So put it in ``fit`` and in ``__init__``?
The problem with having it just in ``__init__`` is that GridSearch uses ``set_params`` and therefore would circumvent the check.
Is it possible to use this line in the dense case too? (to get rid of the if / else)
Le 24/10/2012 23:37, serge-sans-paille a écrit :
>
> In pythran/interface.py:
>
> > @@ -177,6 +176,8 @@ def compile(compiler, module, output_filename=None, cppflags=list(), cxxflags=li
> >      tc.ldflags.append('-lpython{0}'.format(sys.version[:3]))
> >      tc.ldflags.append('-lboost_python')
> >      tc.ldflags.append('-fPIC')
> > +    tc.ldflags.append('-lgmpxx')
> > +    tc.ldflags.append('-lgmp')
> >
>
> ya besoin des deux ?
> rajoute un test comme pour boost_python pour détecter si la lib est pas là
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/serge-sans-paille/pythran/pull/21/files#r1934663>.
>
Je vais tester si on a besoin des deux ou pas.
Pour le test, il me semble que gmp est installé automatiquement avec gcc 
non?
why cast here?
Seems that its not complete on RIM's side. We can leave it as it is till the next beta to reiterate over it.
Fixed. Changed to "ForgotPassword"
Let's strip both `realpath()` calls and I'm fine :)
Yes, but the way I'm checking (later) for dynamic resolution is by inspecting the property directly... I'll rethink this.
What implications / issues would there be, if we increased this to 64bit at this juncture ?
What should the semantics be if the ESCAPE character is the last character if the field?  Is that always impossible?
so true. i started off from the Timestampable because the logic is very similar. its done this way there too.

changed it now, simplifies quite a bit.
agreed - though this is in here for debugging at this point. still trying to figure out how this backfill is working. I'll remove this once fixed.
@maethu is this correct or is it simplelayout.types.common or something that should be added to the buildout?
I did add this to prevent the remaining log entries from grabbing the messages from Rudder. This is why I added the "final" flag to the Rudder syslog-ng entry.

The selector will ensure that our entry will be added before any "log" statement, so the final flag will have any effect (the log configuration is evaluated "a la iptables", if added at the bottom of the file the final flag will have no effect)
fixed in next commit, reverted the changed colors and font, too
`$validSettingKeys` i see some PHP variables here :)
may be we need to check which exception exactly we receive ?
for example check that IOException's cause is ExitCodeException and it's exitCode equals to smth
why are you excluding .project here ? this would mean the project can't be imported directly into eclipse ?
I agree. 'Automatic' is most suitable when the module can auto-detect.
Why not just do `if response.status_code in [ 400, 401, ... ]` and avoid all of the changes to http.py?  Or be overly blunt with `if response.status_code > 400` (not recommended ;) ).
Ah, copy and paste fail. Will remove.
It's the JavaScript equivalent of "internal" in my opinion, so I see nothing wrong with it.  That being said, unless there's a really good reason for it to be private, I see nothing wrong about documenting it and making it public.
Similar comment throughout.  I was originally over-zealous with `@see`.  I would at least drop all the non `3D` ones except for the one it mirrors.
Not a single regex, but: `grep -r "'undefined'" Source/ | grep -v typeof`
That works too, I think the .net rectangle has all of them, which is redundant.  Let's go with yours.
API doc functional test (apidoc/validate.py) failed:
```
Titanium/Network/Network.yml:
	x Titanium.Network
		x NOTIFICATION_TYPE_NEWSSTAND
			x Required property "summary" not found
```
This 'if' statement can be merged with the 'else if' statement from above.
just called bubbleParent
extra parenthesis not necessary. The dot operator has a higher precedence than prefix operators.
I think this should be "expected dictionary"?

"[ERROR] Invalid analytics event received. Expected dictionary, got %@"
"order" is repeated ... Omit "order of" here, or change "stored in the same order" below to "maintained".
I'm not a big fan of having things repeated twice, but I'm ignorant of the technical details. Why $(build-classpath infinispan/infinispan-cachestore-jdbc) instead of $(build-classpath infinispan/cachestore-jdbc)?
This is not my code. I think it should just not be here currently.  Move this out of the project all together.
Fixed  this. Now, getting the left and right border also.
Missing space after `foreach`.
Вообще-то этот код — это хак был, чтобы не переводить билд с руби (что странно, но зато пока работает).

Энивей, надо этот цсс подключать через SASS. Тем более, что ты в их оригинальный так и так наши классы вмазал.
This version identifier is never set. Let's not pollute the code with it.
I dont know, if someone/something kills the running process, we'll want it to keep locked till we sort out the issue right?
Could you add a link to this section in "Téléchargement et installation" section (and fix number of ways ?)
Can we split lines here?

Also, "existent" not "existant".
sry, forgot to replace that. shame on me : )
also, symlinks.
@chillu, done the suggested changes as to make the UT clearer. Thanks. Pull requests re-merged.
JavaScript cannot work with methods with identical names and identical number of parameters. Because of that I had to create a bunch of static methods with different names.
It's not a good practice to use fully qualified class names in the code. It's recommended to use `use` statement and then just `Configuration::isEmulated`
What is the deal with the commented out stuff? Does it need fixed or removed?
Let's wait for a PR that adds Mongo ODM support.
аргументы?
no, that comment was from before you pushed this docstring
Exactly -- *some* of these rules (not all of them, but some) end up being indicators that a refactor might be wise.
Pad the `if`
Why is the `$config` argument needed?
Shouldn't this be in api/src/test/resources ?
So, Gary, do you also think that we should deprecate all literal  'value' attributes, as we discuss in the https://jira.springsource.org/browse/INT-2463?
Well, it __does__ matter from a performance perspective. Like I said, the abstract class adds the prefix so __he__ should remove them. Plus, in context, he knows __which__ prefix to remove. Doing it here means you do unnecessary work.
I am assuming that 2048 is a default. Is there a possibility someone wants to change it?
This is a problem. You are passing the result of this method to doParse(..) call later and there is no null check in it. I am not sure why 'isNested()' check is necessary, but if it is you have to take care of a null check
I was originally going to suggest that (new JIRA issue for the SmartLifecycle).

However, I think it's a big problem because we send out any delayed messages from the store in afterPropertiesSet() which is too soon and many, if not all such messages will likely fail downstream.

Perhaps a quicker alternalive (for M2) is to implement ApplicationListener<ContextRefreshedEvent>; that way, we can be sure the other components are initialized first.

In fact, even if we implement SmartLifecycle later, it is probably best to emit the messages when the context is fully refreshed, rather than relying on the use setting the phase properly.

Thoughts?
these changes brake the title bar behavior for channels without a status node, like https://beta.buddycloud.org/private@buddycloud.org

the channel title should be always at the same position.
What's the difference in this usage? 
I'm looking at https://github.com/doctrine/mongodb-odm/blob/5a4076ec9c4419113c2fa78ea3bb1f7914cb1e29/lib/Doctrine/ODM/MongoDB/Mapping/Annotations/DoctrineAnnotations.php#L26
Oh, sorry, I will pull the new request to fix that.
HI :)  Is not possible to turn it off. That's why we need to check if the view is our own view.