labofsahil/github-event-dataset-2012 huggingface dataset:
I think this could be confusing to later-you in a couple of months... There''s an `attr_reader :suit` in this class. You're not writing over that variable (since it was a reader), but you could be if that gets changed later on.

Possibly something like this would be more explicit

```
def to_s
  "#{suit_abbreviation}-#{value}"
end

def suit_abbreviation
  case suit
  when :diamonds then "D"
  when :hearts then "H"
  when :spaids then "S"
  when :clubs then "C" 
  end
end
```

Of course, you could even do this if you wanted

```
def to_s
  "#{suit.to_s[0].upcase}-{value}"
end
```
名前空間を汚さないので、 mixin するのは Loggable に変えてもらってもよいでしょうか。
Why the new line here?
AppKernel ?
Is this piships.lua business necessary (similar to models or systems)? Can't we just call pi_load_lua directly?
this seems wrong as you will not return the listener but the id for lazy ones
Why not just write each Polygon as you go, rather than adding them to a collection and then writing all the polygons in the collection at the end?  You'd save memory that way.
Yes I got ahead of my self on thinking of what needs to be done. I keep a ready to use repo of the sdk for linux on github.  Sorry for the confusion
-----Original Message-----
From: Eric Pearson <notifications@github.com>
Date: Wed, 05 Dec 2012 13:53:24 
To: blackberry/BB10-Webworks-Packager<BB10-Webworks-Packager@noreply.github.com>
Reply-To: blackberry/BB10-Webworks-Packager <reply@reply.github.com>
Cc: Mike Robinson<badtoyz@gmail.com>
Subject: Re: [BB10-Webworks-Packager] Updating README.md - Adding info for
 prereq step to build node on Linux (#229)

> @@ -7,6 +7,7 @@ This repo contains the code for the BlackBerry 10 WebWorks Packager and submodul
>  2. Install [BlackBerry Native SDK](https://bdsc.webapps.blackberry.com/native/).
>  3. Install [BlackBerry 10 WebWorks SDK](https://developer.blackberry.com/html5/download/sdk).
>  4. [*Windows*] Add Git bin to PATH. i.e. `*Installation Directory*\bin`
> +5. [*Linux*] Build node[v0.6.10], ensure it works on your distro and copy the binary into `third_party\node\linux\` folder

Oh I understand, the native packager needs java to run. Those are included with the NDK.

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry/BB10-Webworks-Packager/pull/229/files#r2327772
不要随手回车加空行。每次commit之前，先用git diff看看修改对不对，有没有不小心加的没必要的东西。如果commit了之后发现有问题，用git commit --amend可以修改最后一个commit。不要留任何无实际意义的commit。

textlib.php不需修改后，你整个补丁应该只有一个commit
ya lets put that on the backlog tho cuz arg[:14] is oogly :)
there is a racecondition if we have two connections:
PHPCR\RepositoryException: Unexpected error talking to the backend: SQLSTATE[HY000]: General error: 17 database schema has changed
should change to https:// ...
I would really like to see names for the test describing what the success criteria is, not just what's being run. Something along the lines of "generate batch basic deployment should ..." It's a lot easier to navigate the tests when you can easily see what's being tested for, not just what functionality is being run. And yes, I know our existing test suite doesn't do this either in many cases.
Ok, I guess peek won't work then. This should be fine as long as `next?` and `next_item` are called in pairs.
not a blocker, but we should track this with an issue.
Is this file changed?
Can we split this into separate cases and give more informative errors? Something like, "Must include a parameter name in '#{param}'." Probably better to use the more idiomatic param_array[0].nil? or param_array[0].empty?
Because you have documented all of these children in this way they appear incorrectly as static. Please change them to be children of the fileEntry object.
We will have to rename any methods with a leading `_` as this is not allowed by Apple; these methods should probably be marked deprecated as a result.
This "helper" does so much work and has so many options its would probably be clearer to refactor the whole thing.  Still, doing this for now.

Basically, there are three database locations:
1. "Normal" dir -- LIB/<nested dires WebKit/LocalStorage etc>/<normal filenames>
2. "Caches" dir -- LIB/Caches/<normal filenames>
3. "Backup" dir -- DOC/Backups/<renamed filenames>

And between these three, there are various migration paths, most of which only consider 2 of the 3, which is why this helper is based on 2 locations and has a notion of "direction".

Maybe I should add this explanation to this method.
the file should be rather included into the root manual instead of providing a new one.
Missing an access modifier
This should not be in production code
Same, I think it helps keep the code flowing correctly from a readability standpoint.
No modern objc syntax.