labofsahil/github-event-dataset-2012 huggingface dataset:
I am not refering to the whole function - I am referring to the last two 
lines. You take dRndSorted, add a counter and then filter id <= 
sampleSize - that just pulls out the first sampleSize records ...

David
On 06/21/2012 05:44 PM, Victor Herrera wrote:
>> +
>> +// 	Returns a random sample without replacement from the original dataset.
>> +//	The instances are picked randomly one by one without replacement (an instance can be picked only once)
>> +//	until until the desired size is reached. Maximun size is the original one.
>> +// 		originalData : original discretized dataset
>> +// 		pctSize      : [OPTIONAL] size of the sample expressed as a percentaje of original dataset, default value is 100
>> +//
>> +	EXPORT RndSampleWithoutReplace(DATASET(Types.DiscreteField) originalData, Types.t_Discrete pctSize = 100) := FUNCTION
>> +		dsOrig := originalData;
>> +		dsIds 	:= dsOrig(number=1);
>> +		origSize := COUNT(dsIds);
>> +		dRnd := PROJECT(dsIds, AddRandom(LEFT));
>> +		dRndSorted := SORT(dRnd,rnd);
>> +		sampleSize := MIN(100, origSize * pctSize DIV 100);
>> +		ds_ids := PROJECT(dRndSorted, TRANSFORM(Types.DiscreteField, SELF.id := COUNTER, SELF.number:=0, SELF.value := LEFT.id));
>> +		RETURN GeneratedData(ds_ids(id<= sampleSize), dsOrig);
> Hello David,
> I reviewed CHOOSEN function and compared it to RndSampleWithoutReplace,
> CHOOSEN returns the first N number of RECORDS starting at position STARTPOS from any RECORDSET
> while RSWR returns a pctSize percentage of RECORDS from a DATASET(Types.DiscreteField),
> however  RSWR does a random selection of "id" based on a temporary rnd field,
> returns one RECORDSET (genIdList) of Types.DiscreteField with id:= new Id and value:= original id, just in case need to track back
> and another RECORDSET (genSubSample) that contains all RECORDS from original Dataset having id in genIdList.value,
> these new RECORDS are generated with id:= genIdList.Id, number:= originalDS.number and value:=  originalDS.number.
> The purpose of this method, as well as other methods in this module, is to generate a subsample of the original dataset but treating records with same id as a unit.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hpcc-systems/ecl-ml/pull/126/files#r1029817
You could try just running an indentation function on this whole file. In Emacs I can do `C-x h C-M-\` and it indents everything properly in the whole file. Can you run something like that here?
Would you care to refactor this entire condition? It's really confusing.
Shouldn't this be .logger('telemetry') ?
`Function(defaultConfig)` -> `Function`
I'm going to change these methods to be smarter about when these types of things actually need to be re-indexed. E.g., if you update the link in a link content, members don't need to be reindexed.
I fixed the docs
* Replace "Saveas Draft" with "Save as Draft".
* Add comma "This makes the content available for display, ..."
No, I mean

```ruby
return entry =~ /(.*)~$/
```

So that "file~name.md" doesn't match.

Could you please also add a unit test for this function.
The tests still pass when :tag_name is removed from Frame#attach_command. However, it seems that the alert and filefield specs fail when :tag_name is removed from Element#generate_ruby_code.
Is this used, or is it for ZAT?
so we have to store a valueType instead of a direct selectorValue
copy and pasted from mi_attempts_controller
Ой)
Загляните в мое решение. 
https://github.com/hmmvot/osx-project-1
В Cell+Mutator.m у меня работает и dna (для доступа к полю объекта), и self.dna, и self->dna.
Может вы делаете что то не так?

А valueForKey убивает весь смысл инкапсуляции (которая в Objective C держится на честном слове разработчика и выполнением им некоторых правил по написанию кода).
стоит заменить 100 на DNAArrayLength
potentially namespace this uniquely per configuration object instance
Wasn't respecting the interface
No problem...can you give me some guidance as to where I should put the test case?
Should this be locked to something specific instead of latest to avoid API breakages?
so options.delay is measured in 1/60s of a second?
Done. https://github.com/laurentj/gitiwiki/pull/7
For this PR, how should I do ? Another commit to remove the change in that file ?
用clojure.tools.logging来打日志吧？
It would be more general (i.e., work for me) to do this:

```
try
    from enthought.mayavi import mlab
except
    try
        from mayavi import mlab
    except
        ...
```
> Where shall I add it. In the doc string?

in this docstring. At least we know why this function exists.

A
If you don't want to add the 'gap_percentage' thing, I can also try it out after you're done with this and see if it's better or not...
`get_indexes` and `get_doctypes` both return strings. They're poorly named. So by grabbing the first thing in the string, you're actually grabbing the first character.
True indeed, I'll extend the warning to mention that and maybe provide a simple search/replace line for easier fixing.
The thing is that i need to mock some methods at the sametime invoke the actual code in some and at the same time i want some not to be called at all, to achieve this, i  need to use stub for specific methods otherwise i will end up having the code cluttered with calls like Mockito.spy, Mockito.doCallRealMethod and Mockito.doNothing everywhere, i basically found stub much cleaner.
See comment above about opinion.

I'm not trying to be a hardass, but presenting all options equally, and then explaining which makes most sense for a given application, should be more helpful to newcomers.
A uppercase
You can maybe use a `:method:` link?

    :method:`Symfony\\Bundle\\FrameworkBundle\\Console\\Application::run`
capitalize the `C` here as well
请按最新英文文档添加rev标记
github上的cn目录下面已经更新了
“A synchronous API returns a result immediately. An asynchronous API does something that might take a while” — that’s not *quite* right. It’s more that a synchronous API *waits* for a result to complete, while an asynchronous one does not.
Can you change this to Wikimedia Foundation?
Humm. So the issue here is that the base template does not use the @ notation but that partial does? If so the flag might be the only way to do this due to the two phase compilation but I just want to confirm that we are making this as automated as possible.
Leftover commented code, should be removed.
On second thought, you should break these lines to the 80 character limit.
Giving another thought. What if we remove the old order and also cleaning up the related order contents. How does it affect the  diagnostic purposes @BDQ mentioned in above comment. This will keep the orders table clean with in-progress orders only.
Sorry, I guess my question here is what's with the comments? I am a little unclear what is being said here...
"1 miesiąc temu" => "miesiąc temu"
If the repository has already been promoted, isn't that a fatal error?  i mean, trying again is not going to help.  so i think you should just let that error propagate and let the caller handle it however he wants.  In otherwords, remove these two lines.
I'd rather prefer csv.Sniffer though :+1: ;)

e.g:

https://github.com/SciLifeLab/bcbb/blob/master/nextgen/bcbio/solexa/samplesheet.py#L80
You should prefix getter setter in this class
deprecated package annotation
May want to change the messaging.
Correct me if I'm wrong, but objects in anonymous namespace are implicitly static (and their symbol isn't exposed). Am I wrong?
It also chokes if you even have a space in the page name. Setting the name to "The Status", I get this error (which is the same as with the special character):

(eval):1: syntax error, unexpected tCONSTANT, expecting '<' or ';' or '\n'
class ::Admin::The StatusController < ActiveAdmin::PageController; end
                                   ^ (SyntaxError)
understandable. nuke them tho
Would you mind changing this use use `as`?
Just as a marker.
How do you know all these things @tristantarrant :-)? I think if we are able to do it with general UUIDs lets not add more dependencies. Although I can see how useful it could be to have address of the command sender encoded. Maybe we should just use Bela's UUIDs? But then people might be confused to see these uuid looking exactly like addresses.
Why create a concurrent hash map here?
Well if it is wrong then you shouldn't coy it then.  :)
Vladimir, I ran the test in the debugger and ee.getCause() is indeed an ISE. Why do you think it wouldn't be an ISE?
Indeed. I think the reason he removed it is because he doesn't have the `intl` extension. having a check for `$this->transliterator` seems ok with me, and then maybe add a `suggest` to `composer.json` for `ext-intl`.
This fails if it isn't cast. It seems to try the comparison with a weird type.
this, too, is a change in functionality, but seems like the right one (raising instead of just issuing a warning)
Been in numpy for as long as I have ever known.  It is also in the math module, and is part of the C-standard math.h.
That's odd.  I didn't mean to not include those files.  Adding now...
We might want to add a comment here stating that it has to be this form and why.  This will prevent future devs from "fixing" this odd semantic.
Can you make this function 'return result.error === null' so we can check on the python side there were no errors during the process?
`:only` used only in `:use` so you can either omit it here or create `:use` clause:
```clojure
(:use [snakejure.core :only (receive-all enqueue)]
         [aleph.object :only (object-client)])
```
Let's modify this test to use "roughly", like `(map roughly [1.1846 ,,,,])`, since it doesn't actually need to be THAT specific.
thread_name will continue to be nil unti the changes for core to reliably set thread_name in the payload is merged to release, which did not happen in 4.0
Please don't remove the other bundles.
@dooremont please fix spaces and
translate the name & description to French.
Why are we still passing the questionSetId around?
I see this can be easily done with <int32_t, std::pair<float64_t, float64_t> > (hello Soeren! :D) and new method get_label_prob()
The "loading" message needs to appear at the very beginning of page loading, when jQuery hasn't yet been loaded. Prior to this CSS animation refactor, this was a CSS transition, but it was kludgier because we had to add a class via inline JS to trigger the transition.
only needs to do this.. you can throw away the if statement entirely.. ie:
```
protected function check_coordinate_value($coord)
{
return floatval($coord);
}
```

And we don't need $this->cord at all..
I don't think "ckptbase" should be set here, __wt_bt_cache_flush() should be passed NULL in the case of the WT_SYNC_FUZZY.
No idea. Gone.
Also add a return statement here to be able to remove the if( $mode === 'categorized' )
Are you sure ``$this->getDefaultOptions(array())`` has the correct type as "array" is not a sub-type of "array"?
Is it possible to add a ``@param`` annotation for parameter ``$value`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? Please also check line 87.
? source is supported for all events, as far as i know
The asset folder is already there so I removed this line and TODO
Right, that's what I was referring to. I guess also cyrillic alphabet, etc. The only reliable way I can think of is by building a list of many many capital letters supported by Unicode. Or we can just do it for the most commonly used languages.
Must be a rendering issue.  Are you using a font that doesn't support emacs semicolons?
Do you want the entire algorithm block or just the iteration strategy block?

       <algorithm id="de" class="ec.EC">
            <iterationStrategy
class="ec.iterationstrategies.DifferentialEvolutionIterationStrategy">
                <trialVectorCreationStrategy
class="entity.operators.creation.SaDECreationStrategy"/>
            </iterationStrategy>
            <initialisationStrategy
class="algorithm.initialisation.ClonedPopulationInitialisationStrategy">
                <entityNumber value="50"/>
                <entityType class="ec.Individual"/>
            </initialisationStrategy>
            <addStoppingCondition
class="stoppingcondition.MeasuredStoppingCondition" target="5000"/>
        </algorithm>

or
       <iterationStrategy
class="ec.iterationstrategies.DifferentialEvolutionIterationStrategy">
           <trialVectorCreationStrategy
class="entity.operators.creation.SaDECreationStrategy"/>
       </iterationStrategy>

On Tue, Aug 28, 2012 at 1:47 PM, Bennie Leonard <notifications@github.com>wrote:

> In docs/user/self-adapting-des.md:
>
> > +choose one of two creation strategies that will be used to generate a trial vector for a particular
> > +individual. At first there is an equal probability to choose both strategies. As time passes, the
> > +probability is adapted depending on the total number of offspring surviving to the next generation,
> > +making the more successful creation strategy more likely to be chosen.
> > +
> > +
> > +# XML Examples
> > +
> > +## Qin and Suganthan's Self Adaptive DE
> > +To use the Self-adaptive Trial Vector creation strategy described by Qin and Suganthan the
> > +iterationStrategy must be given SaDECreationStrategy as the class of the trialVectorCreationStrategy.
> > +
> > +XML:
> > +
> > +    <trialVectorCreationStrategy class="entity.operators.creation.SaDECreationStrategy"/>
> > +
>
> Please give the entire ... block here with the new
> trialVectorCreationStrategy.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cilib/cilib.github.com/pull/24/files#r1473713>.
>
>



-- 
Regards,
Kristina Georgieva
MSc Computer Science
CILib Research Assistant
With regards to the proxy notes: can we rather assume that there is no proxy and then include a note for proxy users? Like this:

  To install this, type the following into command line:

  gem install rdiscount

  Note: If you are behind a proxy,  use `gem install  -p http://username:password@proxy:port rdiscount`

I think it's much more likely that users won't be behind proxies...
How about: "However, Dart classes have implicit interfaces" ?
This is incorrect.
For the inheritance hierarchy "class Form : Control : Component : object", your code would return `Component`, but correct is `Control`.
You only need the direct base type, not the whole hierarchy, so use `result.DirectBaseTypes.FirstOrDefault(t => t.Kind != TypeKind.Interface)` instead.
Or using the `set->predicate`:
~~~clojure
(every? (set->predicate (:awards book)) awards)
~~~
Didn't you want these to be `SimpleXMLElement` ?
spell out please
static method ?
let me redo  a pass on that
while making this change, i noticed that for eg. OperatingSystemNotSupportedError is not defined under the KnifeSolo module.
DRY this case up?
&lt; is the html form of "<". It's missing the opposing &gt; for ">" ...
JavaDoc's might need the HTML encoding to properly generate the right text.
Don't change case.
You do not need parenthesis around. And good, more such checks!
And import only modules!
Add a TODO with a comment to check for multiple user objects returned. We have to do that check in all backends and decide what to do. But you do not have to decide that now. Just add a TODO.
```
created_time = mongoengine.DateTimeField(default=lambda: timezone.now(), required=True)
```
(We can see that it works by CSS class change, and user feedback there.)
Why not? We just copy data the first time. Later on user can change it as she wants.
A bit misusing label?
Or forget this. :-) Just make move last space outside of the translated string. It will be enough for now.
Write about this 5 days in the confirmation e-mail (so that they know how fast they should be).
Each element on the list should have its open hours displayed, maybe some logo/photo, name, and link to the more info on OpenHours website.
Function arguments.
Now it all works and gives the expected output.
Move `open` after `position`.
where are `disable_review`, `subtotal`, `shipping`, `handling`, `tax`, and `locale` used as options? anywhere?
Does `:version` and `:merchant` really need to be passed in? Seems like it can use the default version?
Will there be cases where http://host/bags/<space>_public/tiddlers will not point to the same place as http://<space>.host/bags/<space>_public/tiddlers ?
Thank you, I am gonna look.
yes, you should specify all its parents, and I agree that it should be well documented (I'm working on this point :)
"related_name" is the name of the related "RelatedCollection" on the related model, so, the name of the related stuff... so related_name seems good to me.
Note that i based my naming on how django did for the same things... to possible django users would use this with little ease
so `stdout_stream.filename` option too ?
Don't use a separate log file - use the standard log file.  This is an optional config setting that bumps up to a higher config level - using a different file just makes things worse (changing the config to set rest_api_debug is equivalent to saying "I want a higher debug log level") but I don't see how having a different file helps.
Is this code new, or moved? `_tops`?
OK, cool. I wondered if it should pass the ivar (and actually tried it), but couldn't see any difference in the way the interface behaved.
It's not too difficult, and small issues like the above can always be corrected later (they only influence doc build, not using statsmodels). A good primer on reStructuredText markup is http://sphinx.pocoo.org/rest.html, and docstrings are written according to https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt.
Yeah that probably works. I like this pattern and I think we should try to be somewhat standard with it.
This should now work in master.
Space around `==`.
Should have been, pushed a fix.
personally i think too complicated, we should just treat enrichers as a subtype/pattern within policies (ones which only emit new sensors).  worth moving to mailing list?
This code looks strange: should the try-finally block be outside of the if `(code!=null)` so that it will always reset the blockingDetails, even if `code==null`?

If we do want this behaviour (i.e. to leave it set when null is passed in), then it would be much cleaner to have to separate methods for the different behaviours.
Handily Alex's https://github.com/brooklyncentral/brooklyn/pull/333 fixes that (superseded by brooklyncentral/brooklyn/pull/344) so LocalManagementContext is instantiated separately, rather than implicitly in the `AppcloudApplication.getManagementContext`.

But we necessarily want to depend on that for this pull request!
\@throws what?
Are these imports necessary?
forget it, tranlations goes in #30 branch
Is there a check somewhere for col->count > 0 so this won't crash?
`host` and `port` might actually be redundant - this definition should run on the server the database is running and not over the wire. Also, it would require password auth (or an open database) which would be a blocking prompt halting the execution of chef.
I don't think we want or need this constant defined outside this one context.  Can you use an anonymous class (e.g. `Class.new`) and/or use `stub_const` if you want it assigned to a constant?  That way we don't "leak" the constant outside of this example.
because I want the end result to be between 0 and 4 (inclusive).
I could use '100' with 'ceiling' instead if you prefer.
design doesn't need it (that's why it's a pass ... just a note for further thought really)
And what an address it is!
Неправильная обработка null
Is it possible to do this in the stylesheet?
What is the 8356e7 here?
`tab.linkedBrowser.contentDocument`
instead of writing `found_link = Link.find(@link)` and `:link_id => found_link`, can you just write `:link_id => @link`?
What I meant to say was that I don't have a strong opinion either way. That said, I think your suggestion to have just an absolute threshold parameter, but default to a relative value is pretty reasonable.
Maybe just ``Attributes that have been estimated from the data must always have a name ending with...`` ok?
I see - if I remember correctly, numpy once used uint8 to represent boolean types but this seems to have gone - anyways, locks good to me - thx
yeah but we use the training data to fit the model, not train it ^^
But ok, not really important.
Typo `Versino`
Probablyyyy need to post it on the forums (either of us) and we decide on one final template. THEN we get everyone to use it (I am sure ZNickq would love a template file to import into Netbeans/IntelliJ so he doesn't have to bother with formatting no more).
Should not print this property if it is TRUSTdefault
Oh nevermind the template is called Test not type.
`BlackberryNDK()` will not work in all cases.  If the ndk is not in an auto discoverable location it will raise an exception.  use self.ndk instead
Initialize, Free, and DuplicateObject are InitExtension, FreeExtension, and CloneObject in the template project now.
I would prefer two different macros - even though they do almost the same.  It doesn't really matter though.
As far as I read, it's a Gnome thing, so I think even on non-Linux environments that do support Gnome (if there is any), it should work. This is not exclusive of Unity, though it works much better on Unity (especially the extra commands).
it's not row size, but # rows

And yes it's a hard limit elsewhere, can't have > 2^32 rows in memory for now at least.
That should be more than enough in general, apart from toy queries with tiny rows.
(if you add them statically, I mean), Jlib will be ok since you have references to it, but jhtree won't, I suspect
Why spill the keys as well as the rows?  Isn't it more efficient to recreate them from the rows and avoid two spill files?
How did that get in there?!

Do a search and replace of `self.assertEqual(` with `eq_(`
I think this should be `from unittest import TestCase` otherwise you're going to get all the django setUp/tearDown nonesense around models that we don't need for this test case.
For one, it keeps random strings out of the code. It also allows the framework to translated to other languages, should someone be interested in doing so.
but if it's not absolute, and no `filename` is given you're already defaulting to views/partial, unless im missing something
We have decided to go with names `getXULWindow`, `getBaseWindow` as they describe closer what functions do.
This class is just intended to be sort of an 'interface' for a general puppet option parser API.  There are currently two implementations.. one based on the Ruby stdlib OptionParser implementation, and one based on "trollop".
Okay, I can understand that (nobody using the execute command). 

Notification: go to your github "home" page and click on "edit your profile". There's a 'Notification Center' tab on the left hand where you can choose how you want to be notified. 

Glad to hear that the discussion isn't bothering you. :) 

I think my last question is: when I imported your changes locally and removed the cast (StatefulKnowledgeSessionImpl) -- just left line 50/64 as it was, then the test did _not_ fail. 

Do you know why? And if possible, can you modify the test so that it would fail if you didn't use the StatefulKnowledgeSessionImpl method?
句號後的空白可以刪掉?
The actual changes start here
I wouldn't have picked this particular film :)
Good catch @cadorn, thanks!
Shouldn't this be `post.status`?
@jsqu99 we need here the correct version of your new 1-0-stable branch
I'm very accepting. :open_hands:
That looks very inefficient. I suggest using the StringEncoding API instead.
returning without a prior disconnect in this case
is filename needed really? i dont think, correct me if I'm wrong please
```print_good``` won't exist in this context. @bperry-r7 lied to you.  =)  Still, we must avoid writing directly to $stdout, so it's probably better for this to be a ```ilog``` if anything.
Should this file the RightScale license?
wouldn't it be short just to divide by _xref at the place where _inv_xref is used?
用coffee用coffee用coffee
dar naomidi basi omid ast  :trollface:
FFmpeg, no adapter, to keep in line with Handbrake
Can we remove this now that multi-frustum is in?
If `_boundingVolume` is really a bounding sphere in all the primitives now, we should rename it to `_boundingSphere` as @mramato and I discussed.  However, the returned property in `update` should still be `boundingVolume` since the renderer can deal with any bounding volume, not just spheres.
These functions can be simplified down (perhaps inlined?) to 

```javascript
domClass.toggle('buttonRun', 'highlightToolbarButton', light);
```
Validate inputs?
The terms are largely interchangeable, but our so-called "mocks" are generally actually fakes and not mocks, given that we don't configure them with expectations ahead of time: http://martinfowler.com/articles/mocksArentStubs.html
@alexrp I'm not sure that I understand about `MODEL`. Utilities as well as `dmd` most of the time is built to native binary. Specifying `MODEL=32` would make 32bit platform as default even when it built on 64bit platform. While missing `-m<model>` should result in building native code.
分辨率设定、剪切平面设定都算画面设定。
#420 is filed
Should we print a warning or error in the else clause?
Ehh...I see where your coming from on fstatSync not technically being exactly what you need, but it really strikes me as splitting hairs. 

The node approach is provide the minimum set of APIs necessary to get the job done and thus providing a smaller (and easier to learn) API. There is no need to provide a separate open method since it can already be accomplished using other means.

As far as no comment leaving the assumption that the API exists but we didn't use it...I just don't see it. The only reason I even left the original comment was because you took the time to leave a comment. Without the comment, I would have breezed right by it without thinking twice :).
Why does Android have a different default than iOS?
I'm stopping commenting here. The basic premise of this implementation is wrong and this class needs to be trashed and re-written from scratch.
I don't see why we shouldn't have a much tighter threshold for freshness - say less than 10 minutes.  If the location is older than that, we could register one for the purpose of getting a fresh fix.
It'd be better to use the constants defined above here, as well as defining the constants in this file, so that we're not duplicating string constants.
Another one I think you meant to leave static :)
Should be The horiZontal distance ..
Make sure all of your function curlies have spaces before them.
...then always access `file.data` here.
так у тебя dragArea это jQuery  или список селекторов? и если первый, то ты уверен, что хочешь хранить в переменных ссылки на дом-элементы? %)
user_count should be cast to an int in the page object, not in the test.
three newlines seems like a bit much
Fine if it is not a regression. We should improve that at some point.
Since we're doing decoding anyway, I don't think we should restrict the strings to have the same character type.
It's probably my typo, but this should be "replaced with" rather than just "replaced." The same goes for `sformat`. And please rebase so there's only 1 commit. Once that's done, I think that this will be good to go.
Since this case is radically different from everything else, you may want to reify it in the signature of strideBack and make it a separate implementation.
Did you mean to remove the comments for `dropFront` and `dropBack`?
There's also no need for the type of `opDollar` and `slice.opDollar` to match. Simply have `opDollar` return `DollarToken` (or the dollar type local to this range if `DollarToken` is unavailable) and `opSlice` accept it. Since you're using `$` when actually slicing `_source_`, `_source` doesn't care what type you used for `opDollar` in `Chunks`.
Use `std.exception.enforce` for "test condition and throw if it is failed".
The documentation is inconsistent with the example, and both are inconsistent with the implementation.
Any reason this isn't a function?
i build my project using maven so there is no ABS library folder per se (get recreated for each build) so this might not be applicable. thanks for your help anyway!
It is rather a URI  than a ENDPOINT
Could you provide some comments in this file?
It requires at least some modification. In the past, the edit or create button just redirects to the create or edit user page. Now it triggers a jquery event which opens a modal dialog. Finally it is AJAX based now so the test must be adopted to the new AJAX behaviour. For now and in order to not delay the further review and to finalize this milestone I would suggest to delete it and make an issue to create a new testcase in the future.


-----Ursprüngliche Nachricht-----
Von: Christoph Gritschenberger [mailto:reply@reply.github.com] 
Gesendet: Dienstag, 26. Juni 2012 13:14
An: Gregor Kastner
Betreff: Re: [openengsb-framework] Openengsb 2201/adminui look (#647)

> -
> -    @Test
> -    public void testErrorMessage_shouldReturnUserExists() throws Exception {
> -        tester.startPage(UserEditPage.class);
> -        userManager.createUser("user1");
> -        tester.debugComponentTrees();
> -        FormTester formTester = tester.newFormTester("userEditor:userEditorContainer:userForm");
> -        formTester.setValue("username", "user1");
> -        formTester.setValue("password", "password");
> -        formTester.setValue("passwordVerification", "password");
> -        formTester.submit();
> -        tester.assertErrorMessages(new String[]{ localization(UserEditPanel.class, "userExistError") });
> -    }
> -
> +    // TODO Fix test as UserEditPage does not exist anymore. Now there is used a Modal dialogue in the UserListPage
> +    /*

We cannot leave it commented. It's either fix or delete.
So I guess the new user-manager requires new unit-tests, right?

---
Reply to this email directly or view it on GitHub:
https://github.com/openengsb/openengsb-framework/pull/647/files#r1049959
shouldSkipBundle?
yep, definitely +1

On Mon, Oct 22, 2012 at 7:06 PM, Christoph Gritschenberger <
notifications@github.com> wrote:

> In
> components/services/src/main/java/org/openengsb/core/services/internal/ConnectorRegistrationManager.java:
>
> > @@ -232,9 +259,9 @@ private void updateAttributes(String domainType, String connectorType, String id
> >
> >      protected ConnectorInstanceFactory getConnectorFactory(String domainType, String connectorType) {
> >          Filter connectorFilter = FilterUtils.makeFilter(ConnectorInstanceFactory.class,
> > -            String.format("(&(%s=%s)(%s=%s))",
> > -                Constants.DOMAIN_KEY, domainType,
> > -                Constants.CONNECTOR_KEY, connectorType));
> > +                String.format("(&(%s=%s)(%s=%s))",
>
> Anyways, I'd say we create a separate issue for that and go ahead with
> this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/785/files#r1906255>.
>
>
Document @raise
khob berize
az nazare code php ke khata ijad nemikone
pass include na require
This is copy/paste from other steps, need to review "_" in erlang,
The above is a bit of a structural change beyond what you mention in the pull request.  Could you explain these lines better?  (or take them out and I'll pull this in directly).  Thanks a lot!
I tihnk this is valid, the only useless case here is `defaultValue`
Why not call here just `this.openFolder();`?
Or interchange `getFolder()` & `getTransactionContext()`:
````java
public Folder getFolder() {
    return this.getTransactionContext().getFolder();
}
public MailReceiverContext getTransactionContext() {
  if (this.contextHolder.get() == null) {
      try {
           this.openFolder();
      }
      catch (MessagingException e) {
        throw new org.springframework.integration.MessagingException("Failed to open folder", e);
      }
    }
   return this.contextHolder.get();
}
````
However, it's just polishing, so, never mind ;-)
Should this be removed for prod?
nit: This comment is now a good 6 lines above the code it is commenting on.  Either delete it or move it.
On 03/02/2012 07:02 AM, Neil H Watson wrote:
> I get burned on readme and meta more than anything else.  Diego,
> can you publish example templates or clearer requirements for these
> things.

To be fair I don't think its quite defined yet, I keep bringing it up
hoping to get a definition :)

-- 
Nick Anderson <nick@cmdln.org>
Sort of? but it is more awkward than anything else. Maybe just "use this control to position elements"
Please move this to `service.gemspec` below the nokogiri dependency

```
s.add_dependency 'tinder', '1.9.1'
```
Add status error (404) in the response.
Ok, in this case, if you continue your commits, they are concatenated to this pull request.
Working with branches is fundamental (amongs other) to solve this kind of issue.
I expect that "one pull request = one branch" is a good rule.
I begin to appreciate a lot github ^^
agreed, dropdown makes more sense here.
I'm having trouble figuring out exactly why it's needed here, but I clarified somewhat.
ping @kjszymanski
Generally speaking, I'll use categories instead of subclassing if I'm only anticipating some additive functionality to the existing class.  If you anticipate getting into more complex and/or "replacement" functionality for the existing class, subclassing is the way to go.
На самом деле вопрос спорный =)
OK, that makes sense given how iOS does font loading. Thanks for clarifying.
Summary should be one sentence. The rest of this text should be in a description: field. (Goes for the remaining summaries in this file; other files look good in this respect.)
This is an IntentProxy (not just any normal proxy)
почему encoding = null? Что выдаст iconv('UTF-8', null, ...)?
$output = array(0=>array('@content'=>$output));
Was switching to the Snapshot version in order to avoid exceptions in the log file due to INT-2656. M3 might be too noisy...
I think the $encoder passed in would have to be of type EncoderRegistry to be able to call getEncoder.
Sorry, I did this for testing purposes and forgot to change it back -.-
I'll update the pull request (including the other changes you asked for).
We need to prepend a license here
I think my reasoning for not putting it in the package.json was flawed. Node modules folder is not included with the maven build so theoretically you could have put this in package.json but since its only used at build time, I think its better here.
Opened issue: blackberry/BB10-WebWorks-Framework#130
Is this happening on Android also? From the bug description, seems like an iOS only issue. If that's the case, is this an iOS limitation?
Oh, wait, you deleted this. Heh!