[chromium] Enable more clang warnings
https://bugs.webkit.org/show_bug.cgi?id=97257

Reviewed by James Robinson.

Source/WebCore:

Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
warns on this and it's a common source of error for Chromium patches.

No new tests, should compile cleanly.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
* WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
there are lots of violations in these files.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
https://bugs.webkit.org/show_bug.cgi?id=97260

Rubber stamped by Geoffrey Garen.
        
Supporting it will become difficult as we add more indexing types. It makes more
sense to kill, especially since we don't appear to use it or test it, ever.

* runtime/ArrayConventions.h:
(JSC):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
* runtime/ArrayStorage.h:
(JSC::ArrayStorage::copyHeaderFromDuringGC):
(ArrayStorage):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
* runtime/JSArray.h:
(JSArray):
(JSC::createArrayButterfly):
(JSC::JSArray::tryCreateUninitialized):
(JSC::constructArray):
* runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC):
* runtime/JSObject.h:
(JSC::JSObject::initializeIndex):
(JSObject):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Unreviewed build fix. webkit_unit_tests have global constructors.

* WebKitUnitTests.gyp: Remove -Wglobal-constructors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed.  Start running tests on the mac-ews.
        
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Measure how often web pages use Worker and SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=97273

Reviewed by Ojan Vafai.

We're not considering removing these features, but it will give us a
baseline idea of how often they're used.

* page/FeatureObserver.h:
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Win] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=97274

* platform/win/Skipped:
Add fast/forms/number/number-spinbutton-click-in-iframe.html because
Apple Win port doesn't have spin button in testing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225

Reviewed by Ojan Vafai.

It is now incorrect in the new syntax to have a line like:

    foo.html [ WontFix Crash ]

This will generate a lint warning and be treated as an invalid
line. Fixing this caused a whole bunch of unit tests to need updating
to no longer be marked as WontFix :). Also, this patch adjusts
the warnings so that missing Bug() identifiers will cause lint
warnings but will *not* cause the line to be treated as invalid.
Fixing these issues also revealed that test_hung_thread was no
longer testing the right logic, so I adjusted the timeouts in
test.py to make that test work again.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_test_in_another_thread):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.is_invalid):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(BasicTests.test_basic):
(test_get_test_set):
(test_parse_warning):
(test_pixel_tests_flag):
(SemanticTests.test_missing_bugid):
(SemanticTests):
(SemanticTests.test_skip_and_wontfix):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_hung_thread):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Updated Lion-specific results after r129176.

* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129185 268f45cc-cd09-0410-ab3c-d52691b4dbfc