labofsahil/github-event-dataset-2012 huggingface dataset:
but that spell IS right i added...there's just something from them guards missing
they have detections the symbols above there heads shows its working...
but i've got to add it to there script to teleport you if stealthed i think,

alliance/horde IS not to under any circumstances unless gm to go into the other factions areas
(in Dalaran)
all the other other city guards attack like if you were not stealthed... 

atm no guards in game have that symbol over there heads if u walk up to them under stealth.
horde in sw...can stealth clear to king in sw
raid za is fucked
so is orig
stealthers are OP exploiters/buggers by default atm lolol

i think this is getting too big for me to do holy shit
i'll be on this for months 
(unless i write a hack script for it... which means ill be on this for months).
all guards need fixed
all bosses need fixed

there is not one boss without stealth detection ingame
blizz made it that way so ppl don't skip bosses
and guards were that way since city conquest was removed
patch 2.1

more help would be effn great... cuz this is big bug not for us but  for tc as well.
This commit allows to the enable/disable command logic to apply and remove highlighting when applied.
Also adds a command to the command palette.
It fits on one line in 78 chars :)
Hallo Jan-Christoph,

gerne und danke dir für die initiale Übersetzung und ein offenes Ohr für meine Verbesserungsvorschläge.
I
Ich habe oben noch mal zurück kommentiert und wäre so wie es dann wäre auch sehr zufrieden.

Wir können dann nur hoffen, dass Shaun auch dazu kommt, möglichst bald eine neue Version mit allen neuen Pulls für die Paketverwaltung fertig macht. Dann kann man das Modul auch wieder bedenkenlos für Seiten von anderen (Kunden) nutzen.

Beste Grüße zurück,
Marc
Ummm… no.

Say you’ve got three criteria, each of them with a range of 0 to 10 (inclusive). If the first one has a weight of 50 and the others each have 25, the rating assigned to the first one gets multiplied by 5 (50 / 10) and the answers to the others get multiplied by 2.5 (25 / 10). The totals are then added up, and end up as a total score out of 100 (50 + 25 + 25).
This assert should fail because the new status is updated in DB (volumeEntity), but not in the local object (volume)
Hmm, yeah finish() has sleep() at the end of it. However, it shouldn't be hanging. I guess you are calling finish on the wrong thread. I'll look into it.
A file is missing. Where is memcopy.c? Compile fails.
Oops.  Pew pew!
getBytes should take an encoding argument, and will thus throw an UnsupportedEncodingException. The existing code used "US-ASCII".
OK, nice to know! Thanks for an insanely fast reply.
It's perfectly fine! Given that your "framework" point of view, I agree.
I also get `File to import not found or unreadable: active_scaffold_colors` when precompiling. (Rails 3.1)  I removed the import and put `*= require active_scaffold_default`.  I can do a pull request, but not sure if this is what you want.
how do I increase the waiting time before it disconnected when I didn't do anything...
I adopted this fix on Android 2.3.6 (of course, I replaced the functions that are not available on Android 2.3.4), but it seemed not work well. There is still noise. From log, I found that mTailBufferCount didn't have chance to decrease to 0. After track stopped and destroyed, process_l() just could run one or two times, which was too little to remove the noise. I think it is that MixerThread::threadLoop() stops when there is no track, leads to EffectChain::process_l() having to chance to run.
hai chri

i wand more example how to use tpl file  and how can handle the form in
tpl,how to interactive web site using tpl











On Tue, Jan 31, 2012 at 11:15 AM, Christopher Tombleson <
reply@reply.github.com
> wrote:

> The implementation of MVC I use here is not the standard implementation
> that you would see from frameworks like Zend, Cake PHP etc.
> I have component library which can be used as a based to build an MVC
> system, it's called CribzLib and you can find it on my github. It is pretty
> straight forward. For what purpose do you need a MVC system for, sometimes
> it can be overkill.
>
> Thanks for the interest in my work. Feel free to email me with any
> question if you need any help: chris@cribznetwork.com
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/chtombleson/cribz-cms-framework-mvc/commit/83d759ef3fcdda436aa6175cee43c8d96fa9e435#commitcomment-917030
>



-- 













 Thanking you


With Regards,

*VELAYUDHAM.R*
*ARYVART SOFTWARES PRIVATE LIMITED.*
I was getting the same error. But now I'm stuck with undefined method `paginate' for #<Class:0x007fbc8624fff0>?
I'm sure I've installed everything correctly and even restarted the server.
I should have noted that currently `#` is only supported for comments starting a line (as the first character).  I will create test cases to demonstrate this.
保存にミスって途中までしか日本語になってなかったので修正しました．
I have a mistake that incomplete translation to Japanese.
So modified to complete translation.
`getPost(e.target)` может указывать не только на существующие посты, но и на быстрые превьюшки, которые не имеют свойства Num. Данное изменение должно быть откачено, чтобы восстановить пометку родительского поста.
Actually I intend to fix it and move it in one step. Don't you already have this?
If it was necessary, it would be in WordPress core code, but there's not a single instance of it in any file. I've also never noticed in any plugin, or any theme code, even the popular ones, so if it was important, someone would have complained by now.

Also, the encoding directive wasn't supported until PHP 5.3, and even then only when it's compiled with `--enable-zend-multibyte`. In the meantime, anyone who is using 5.3.1 may well experience issues when requiring a file like this which has a `declare` at the top of it - https://bugs.php.net/bug.php?id=50464.

So, adding it in will only, at best, do absolutely nothing useful, and at worst, cause fatal errors.
Could we change the comment according to my previous suggestion
I'm not really sure why I'd want to use this.  It provides something like ```Factory.build(:project_imagegateway)``` instead of ```Factory.build(:project, :name => 'imagegateway')```, which is almost the same amount of typing and screen space but is much clearer to me.
A code comment about how these two lines work will be useful to people.
Place $.rib.saveEventHandlers() here is because setProperty only focus on current property need to change, it will update the main.js file with any condition, even user make the event handler be blank.
Better use `**kwargs` to match standard argument naming.
No. REMOVED is the tombstone state. Never present in the gossiping exchange but part of the semantics and the model. 
A node can only have status REMOVED if if is removed and not part of the cluster any more. I am only returning REMOVED now to the user since that is what the user would expect from a REMOVED node. 
'self' should not be an Option since then we would have to maintain the node's state in two different places. 
The current impl is the way to do it.
Why is this needed? (it's very expensive)
The refactoring is just as reliable and much more complete and correct.  I think you need to take a closer look at why all this helps and how it connects to the id based caching and tag/trunk/right/left* stuff.
On the naming, maybe we could reuse the same as "scroll_distance" used in scrollview ? Or just the "min_distance" ? for consistency :)
There's a small typo here ("migth") :)
My experience showed that fmin is more robust to noise compared to fmin_bfgs. I think the gradient based methods will be more likely to get caught in a local maximum.
@tobes Is there anything else you'd like to see included as a reference for extension developers for accessing the ckan library?
I think the {..} might be confusing to translators as these are usually substituted maybe <field>:<value> or something - maybe i'm crazy
Ok, the rationale was that I wanted to call render_document_list instead of iterate and call render_document. The latter was causing two blank spaces when fields were applied, making the output look awkward. The former, when I finally get around to the tweaks I want to do, will be able to optionally skip the blank lines between when applicable
"rpmtools" is a fairly ambiguous name, can you drop a module-level docstring in here to describe what's within? At first glance it looks like a model but it's bigger than that since they include install and update functionality (which I'm guessing the callbacks are used in).
consider setting COMPILER_PATH via arg (using optparse, or just sys.argv), and falling back on an environment variable (os.environ[COMPILER_PATH]), this is highly desirable, but not required for this pull
Where are the command deletions happening now?
ну ок, а где хранится оператор, заказавший услугу, как поле называется, видимо это должен быть пользователь, из-за которого сделалась услуга из сервиса, но я ничего такого упорно в тригерах не вижу?
>_<

I'll get it later.
Too many braces here. Also, the `Tile` class has width/height methods that forward to its image, please use those.
"internal padding on grid elements" ? we already have `$grid-padding` and need to make sure these things aren't confused.
I'll just name it ```Twig_ExtendedLoaderInterface``` and remove the dependency from ```Twig_LoaderInterface```
Framework enums should be defined with an explicit type (a relatively new compiler feature), for forward-compatibility, like so:

    typedef enum : NSUInteger {
Removed the change from my branch, will fill a separate issue if I manage to reproduce the issue (I currently don't)
I'm afraid I don't understand what you mean in these two comments...
That will be addressed in separate commit later.
I think it would make "more sense" to let 08 extend from 07. At least it sounds more logic, even if it will not matter :)
This line looks incorrectly indented. Maybe using spaces here?
7.6.6 стайлгайд
Is this error only used when `source_type` is not present?
Oh, I mean, it's still a bad idea, but just saying.

I think it's a terrible way to write code, but I'm not in charge around here.
It's more speedy and readable. And block usually used if we need yield self. WDYT?
Shouldn't it use ActiveSupport::JSON?
well, the test was ported from Akka and I didn’t want to change it more than necessary
`freeTypeParamsOfTerms` will now also discover symbols behind `PolyType`-s. Is this change desired? The test case for SI-4070, mentioned above, still passes.
The TODO shouldn't be there, but in the while I found some problems when
adding products with different promotions to the same cart, so please don't
pull this in. I'll add some commits as far as I know how to fix it.

AS

On 11 May 2012 03:03, Ryan Bigg <
reply@reply.github.com
> wrote:

> >        end
> >      end
> > +
> > +    def target_products
> > +      #TODO: product groups?
>
> Left over TODO?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree/pull/1526/files#r806131
>
Please write a test for this controller action. And also submit a patch to spree-guides to add this method to the API documentation. Thanks!
I don't know how that function became so convoluted. Just make it

```
if rep:
    return list(range(self._degree))
return [self.orbit(i) for i in range(self._degree)]
```
With the current implementation, `unify` makes the decision of returning broken objects. If you want callers to decide how to rebuild the objects, *they* should be the ones calling `construct()` or whatever, not `unify()`. On the other hand, if you want to return sympy objects, what's wrong with `return t.op(*map(construct, t.args))`?
set works.
>
> To use my code you need to do `from sympy import plot` (no capital
> letters). If matplotlib is not installed it will use ascii plots. If
> matplotlib is installed it will use it instead. If matplotlib is NOT
> the current unreleased development branch the 3D plots will fail due
> to bug in their coloring routines (this is not checked for in my
> code).
>

I really don't have the time now to wrap my brain around what is going
on to give this a good review. I know you have some TODOs but this
doesn't break anything with the current master, if I understand
correctly, since pyglet is still supported (though not shipped with
sympy). You are just providing another development path for producing
plots. As such I would say let's get this going and improve as issues
arise. Do you agree? Have others been in agreement?
why are you adding a subs routine? These cases are already handled. Again, automatic evaluation handles the case of an odd multiple of pi/2, returning zoo rather than nan:

```
>>> tan(x).subs(tan(x),y)
y
>>> tan(x).subs(x,3*pi/2)
zoo
```
yes, but the group ends at the ), not at the \\), which is a literal ), not a grouping )
why would you need the emit raw functionality? Do you have a use-case for this?
Problem I see is that you really on internal API that can be easily change or modified. If you use public API, then your test verify complete workflow and should be more robust and stable. And also It increase readability
Whats the problem with that, the method is static itself. (didn't check the rest of the code.)
There's no good way to extend this class so no reason to have `protected` modifier. If people will request it, it will be easy to change visibility level. `private` is better for framework developers: we can change internals much more when things are `private`.
Caching would be doe by the entity manager in any case.
Yes and useless since the values it returns could become completely invalid. Removing.
Why only the numerics?
Same here, not just readability,
minor formatting: `if (this._options.imageMagick) return ...`
for consistency, please space this "function () {"
See the comment on .equals(). If necessary there is a method in System that provides a "material" hashCode.
This **function**
[There's an `is_template` field in the database](https://github.com/mozilla/kuma/blob/master/apps/wiki/models.py#L409). You should use that here, instead, i.e.:

    docs = Document.objects.filter(is_template=True)
Change `item` to something less generic maybe? I would go for `attend-button`.
you can use a truthy check here like if (!lockNavBar)
also.. need for prod?
Why is it a bad idea? Just sending around $phpbb_container makes things infinitely easier because I don't need to build functions like:

function blah (dbal $db, template, $template, user $user, cache $cache, $phpbb_root_path, $php_ext, $variable1, $variable2)

Instead it's just:
function blah (ContainerBuilder $phpbb_container, $variable1, $variable2)

Much more readable, usable, and it's not a complete bitch to add additional dependencies if the function has to change a little and requires a new dependency.
Do not build this twice.
This looks like a static call which will break in php 5.4. This function, the parent and the other extractors probably need to be marked static as appropriate.
Config is no longer an array. It is now an object `phpbb_config`, though it can still be accessed like an array.
fixed. Added a unref to not block the eventloop on the setInterval.
This entire function seems to be a dup of the prior one, with one ! as the only difference. Adding a param to a shared private routine and making the two public routines wrappers would be a dry-er approach.
Excellent! Glad you are using a constant to capture this.
Too much whitespace. Only require two blank lines.
bare except?
I think the typeConstructor used on GPU should raise an exception if the dtype is not float32, instead of silently ignoring the dtype. This would make it easier to detect dtype mismatch.
No problem!  I'll clean it up and issue one.

Benjamin A. Petersen
ben@benjaminapetersen.me (mailto:ben@benjaminapetersen.me)
linkedin.com/in/benjaminapetersen (http://www.linkedin.com/in/benjaminapetersen)
facebook.com/benjamin.a.petersen (http://www.facebook.com/benjamin.a.petersen)
twitter.com/#!/bapetersen (https://twitter.com/#!/bapetersen)
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Wednesday, July 18, 2012 at 10:24 AM, Alex Ehlke wrote:

> > animate = animate || this.options.animate;
> > 
> > + // var keyword to avoid global!
> > + // var tag = $(tag); 
> > 
> 
> 
> Hey Benjamin, sorry - meant to do this but got busy. If you want to submit a pull request with the changes discussed ill gladly pull it, thanks.
> 
> Sent from my iPhone
> 
> On Jul 18, 2012, at 11:24 AM, "Benjamin A. Petersen"<reply@reply.github.com (mailto:reply@reply.github.com)> wrote:
> 
> > > animate = animate || this.options.animate;
> > > 
> > > + // var keyword to avoid global!
> > > + // var tag = $(tag); 
> > > 
> > 
> > 
> > Alex, would you like me to do anything else to this? I can cut my comments out & clean up the items you mentioned so it is a clean commit. 
> > 
> > Benjamin A. Petersen
> > ben@benjaminapetersen.me (mailto:ben@benjaminapetersen.me)
> > linkedin.com/in/benjaminapetersen (http://www.linkedin.com/in/benjaminapetersen)
> > facebook.com/benjamin.a.petersen (http://www.facebook.com/benjamin.a.petersen)
> > twitter.com/#!/bapetersen (https://twitter.com/#!/bapetersen)
> > Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
> > 
> > 
> > On Wednesday, June 27, 2012 at 9:50 AM, Ben Petersen wrote:
> > 
> > > Good call Alex. You are right.
> > > 
> > > Benjamin A. Petersen
> > > ben@benjaminapetersen.me (mailto:ben@benjaminapetersen.me)
> > > linkedin.com/in/benjaminapetersen (http://www.linkedin.com/in/benjaminapetersen)
> > > facebook.com/benjamin.a.petersen (http://www.facebook.com/benjamin.a.petersen)
> > > twitter.com/#!/bapetersen (https://twitter.com/#!/bapetersen)
> > > Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
> > > 
> > > 
> > > On Wednesday, June 27, 2012 at 11:49 AM, Alex Ehlke wrote:
> > > 
> > > > > animate = animate || this.options.animate;
> > > > > 
> > > > > + // var keyword to avoid global!
> > > > > + // var tag = $(tag); 
> > > > > 
> > > > 
> > > > 
> > > > 
> > > > However this should never be undefined unless there is a programmer error, since `tag` is required, and so this will always bind to the `tag` parameter passed to removeTag. So no need for `var` here.
> > > > 
> > > > ---
> > > > Reply to this email directly or view it on GitHub:
> > > > https://github.com/aehlke/tag-it/pull/82/files#r1061040
> > > > 
> > > 
> > > 
> > 
> > 
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/aehlke/tag-it/pull/82/files#r1188738
> > 
> 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aehlke/tag-it/pull/82/files#r1189922
> 
>
We sort imports like this:

standard library

external libraries

ralph

relative imports
I meant line 54, e.g. `query = list(query)`.
We need to clarify and disambiguate how we refer to time throughout the simulation.  Don't we just care that the time < final_time - why add to current_time.  Also, don't we want to allow simulations to end without decomissioning facilities?
This doesn't seem right, you shouldn't be creating a new cache and then changing the global one. You should create the new cache, create a model with some sort of "dont add to cache" flag, and then explicitly adding it to the new cache.
No extra space.
Any reason for self.__unicode__ instead of text_type(self)?
i am a bit confused why there should be a trailing comma without further elements. Will add it though.
@Hounddog PHP allows adding a trailing comma in arrays. And this is helpful when formatting them on several lines to avoid such diffs just because of the comma:

```patch
array(
-            'assets' => $filterExpression
+            'assets' => $filterExpression,
+            'include' =>$filter
)
```
Space here
You should call `ObjectAllocator->Deallocate` from `Object::operator delete`, so that the destructor still gets invoked.
it's a nested loop...?
I'm not sure about this. parse_url_into_model was always meant to be a class method (though I realize that's not documented). If we were going to make it support being an object method, why wouldn't we avoid the $pclass->new() call and use the $self (actually called $class at this point) instead? I'm very hesitant to have code poking into the parser objects directly when the superclass doesn't know anything about the object structure (or even if trying to deref it as a hash will work). I'm not sure how to proceed on that, though, since we don't have a way to specify these arguments to an already existing parser object...
I'd suggest an `else if` here for clarity.
Yes, this is off topic.
Why don't you just say "utils/fmgroids.h"
Please, change the 4 spaces into 2.
Should this failing crash mopidy?
s/implment/implement/
If you are removing usage of `escape` why do we still need the method at all?
On all platforms. But thanks for the info — I’m new to this whole creating Homebrew formulae thing and didn’t know about `:autoconf`.
This is starting to feel a bit like browser sniffing in the bad old days of web development. Wouldn't it be nice if we had a `system_provides_autotools?` method?
Pattern for commands that only have one action is usually just defining def run (doesn't require a default_action).
This is a bit too technical.  Suggest:

    There are multiple versions of this cartridge.  Please select the appropriate version.
Is this line necessary? I think we already require `cl` at the top of `cabbage.el`
ah, it self.strip()
i meant string.strip()
in self.strip() very harmful HTMLStripper, i removed it in  my build. Check my changes.
首先这个文件要`git mv 14-linux.md source/`，根目录下放的是knitr输出文件。虽然我估计你这里不大可能有R代码，但有没有都没关系。
garbadge.
should be deleted but don't know how.
Do you think we can safely get rid of the -provisional prefixes now that we're moving to a registry-based model, or do you think it is preferable to keep them in until they've been formally registered?
I think that the check is correct as written but could be expressed more clearly. As written, if the first check "fails" branch 1 evaluates to true which then short-circuits the 2nd branch. However, it could more clearly (but lengthily) be written as 
if (! (expandSpec.options && expandSpec.options.key)) 
or even more shortly as
if (fluid.get(expandSpec, "options.key") === undefined)

note that a key whose value is the number 0 is not an impossible input to the system.
This is not meant to be a user level function and hence intentionally not in the `op_` namespace?
By convention, we have a blank line between return bailouts and functional code.
I made ContextMenu extend Menu to solve this. Great suggestion.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Thursday, June 07, 2012 4:16 PM
To: Ty Voliter
Subject: Re: [brackets] Context Menu API (for review only) (#1012)

> @@ -623,6 +750,40 @@ define(function (require, exports, module) {
>          menu.addMenuItem("menu-debug-close-browser",  Commands.DEBUG_CLOSE_ALL_LIVE_BROWSERS);
>          menu.addMenuItem("menu-debug-use-tab-chars",  Commands.DEBUG_USE_TAB_CHARS);
>  
> +
> +
> +        /**
> +         * Context Menus Test Code
> +         *
> +         */
> +        var project_cmenu = registerContextMenu("cmenutest1");

Would be nice if caller could operate on the object returned from registerContextMenu() and not have to call getMenu()

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1012/files#r948136
I was confused by this comment about the "spacebar". Doesn't this API support any key?

 I think it should say "return true/false to indicate whether hinting should be triggered by this key"
Let's either remove or not misspell.
I believe you need to note this in the top-level README as well.
it's marked safe in the template...is that enough?
Something wrong happened. Shouldn't we log something in order to warn the user ?
Why not simply using `$.extend` ?
**get_combined_value** was written only for dealing with the combined Content-Length case, so I didn't consider quoted-string at all. Its behavior of handling combined values maybe inappropriate to other cases.

Is there any other place where we might need to handle header with combined values? I can look into it and try  to make this more sophisticated.
Question: is there any other status code we might get?  Maybe we should add an else that console.warns it?
missing a space here.
Move this logo to the public folder
Whitespace around "on"
CSSlint doesn't use find though, it just takes a string... I think we need this?
Uhhh, what?
I meant in the code :P.
Nice, so express doesn't have a csrf_required kind of thing?

This looks good though.
info()
setRepositoryIndexContextSearchable call seems redundant. Why is it needed here?
The URL is a write access one. Please change it to: `git://github.com/brunow/BaseKit.git`
This target should go too--it's dead code now, right?
Unintentional, removing...
Also, Is contents_readable?   the most appropriate permission here?
Need to add a comma on line 4 and 5 after the gym leader names.
As above, inconsistency in names `AUTO_COLNAME` vs. `auto_column_name`.
I might try to resist the urge for too much premature optimization.  Maybe these results don't need to be cached at all, depending on the use case.

I might be able to implement an alternative version of `lazyproperty` whose behavior can be controlled by a global configuration variable too.  Some applications may not need these results to be cached at all if they're only going to be accessed once.  Other applications may prefer to sacrifice the extra computation time (which isn't much in most case) for the memory usage.
Would you mind testing this for bitcoind then, so we can re-open?
I suggest using one function that takes a boolean
goodness... it's all moved from main.cpp...  this'll break quite a few other pulls I suspect...
Extra space before closing `)`
I would use version_compare() and store the result somewhere, in case the developer is formatting tons of numbers.
Shouldn't it be ```'className' => 'DbAcl'``` ?
Align all `=>`
No extra whitespace

    {'characterID': character_id}
Does this really need to be imported here?
I have some code to make docurium show depreciation warnings, but I think that until 1.0, we can break the API whoever much we feel like.
This will fail if HEAD is detached. Something like `git_reference_create_symbolic(&head, repo, GIT_HEAD_FILE, git_reference_name(ref), 1);` would work in any case.
I removed the double walk, but now there's no data for `payload.stats->total`. I'll see what I can do with `git_index_read_tree`.
char* uin, *status, *client_type; // 空格, 注意编码规范
Move it up into the same line as the declaration. Then kill setupModule().
go copy-paste errors!
When there are no plugins it seems like this throws ``undefined method `each' for nil:NilClass (NoMethodError)``.

A simple fix would be to add `return if options.plugins.nil?` before iterating the plugins.
Tohle mi přijde jako hezký příklad, proč je coffee script nepřehledný. Jak poznám, kde končí podmínka v ifu? Vždyť recordingNow může být volání funkce, ne? Ale to je jen moje osobní poznámka.
I just (1 minute ago) pushed a change where sponsor logo definitions go in templates/sponsors/X.mako. Please make one of those, and make it conform to the style (including setting appropriate height, width, and alt attributes). Thanks!
What I mean is the way we handle it in other places, like https://github.com/pypa/virtualenv/blob/a9454bcebe68719d70af35d64e01e86b1965c657/virtualenv.py#L972-979

All you have to do is to get the exception object from sys.exc_info(), like so:

    try:
        do_something()
    except Exception:
        e = sys.exc_info()[1]
        handle_exception_somehow(e)
what is this indentation ????
This would be more readable if it was formatted on several lines IMO
Not sure about the behaviour of `filemtime` with directories but I'm not sure it will return the date of the last modified file inside.
Please reset the libxml internal errors before throwing the exception
Since we can create a context from a request, can't we do that and allow this object to work in more circumstances?  If someone provides a request but no context, just generate a context and then we don't need to throw anything.
I'm not sure about the @author annotation, but I don't think it makes sense if you just touched one line in the file. 

However, I'll defer that to @fabpot since I don't know how this is handled elsewhere.
Please respect the PSR-2 coding standards
shouldn't this be xcache :) ?
This check is done in the set-up stage of the parent class.
this isn't specifically one path, it's just like __PATH__ so it's multiple colon-delimited paths. I guess we would iterate them and see which are writeable etc. Personally I hate how unix directories are structured haha but we should follow that I suppose.
Not sure what the standard is for ternary operator indentation.
actually used that first.. but to my surprise it failed in the simulator with unrecognized selector sent to instance.
same comment boost::Sequence != stl sequence concept ?
Also, this will simplify your code below.
Same for this - why not a method of the class?
It's a bit odd to rely on float arithmetic inside an int->int calculation.  Could we refactor this to say fully in 'int-land'?
dieser ganze batzen passiert jetzt halt in der user-klasse und kann immer wieder verwendet werden - und ist nicht so unuebersichtlich wie hier
файлы с ```~``` нужно добавить в .gitignore
No - the time to send is quite a long time in terms of number of hashes
``isinstance(settings.LANGUAGES, tuple)``!
Are the a.ip values numbers or strings? Will sorting them produce a predictable value?
The names/symbols used in the code may have been confusing... The code does not exactly mean that it checks if (v is an object). Rather the code checks if v fits in the category where we need to go into properties in v and perform "Stateful to plain object conversion” for each of those. We need to perform such conversion against Stateful and plain object, but not for primitive values or for non-plain objects (like Date, RegExp).
This looks like a typo. I'd say get a couple tests for this engine before we put it in.
If `message.message()` is already a unicode string, I think this breaks. I don't have my setup so I'm wondering - did you check?
Could this possibly end up getting an exception that occurred during a call to ServiceContainerHelper.start() and throwing it again during a call to ServiceContainerHelper.stop()? Is there any reason to do this check if targetState is DOWN or REMOVED?
And remove this change.
I did create a new message at first stating the same reason and then
reworked after discussion with Paul since the KB article could mention
multiple deprecations.

I ll revert to what I had.

Sent from my iPhone

On 15 Nov 2012, at 20:14, Brian Stansberry <notifications@github.com> wrote:

In
clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/InfinispanLogger.java:

>       */
>      @LogMessage(level = WARN)
> -    @Message(id = 10283, value = "The 'eager' attribute specified on the 'transaction' element of a cache is no longer valid")
> -    void eagerAttributeDeprecated();
> +    @Message(id = 10283, value = "The '%s' attribute is deprecated and its value was ignored")

You shouldn't repurpose an existing message like this. The message id
becomes a key into a kbase article and if the message is repurposed the
kbase article may be misleading.

Instead, create a new one. If the old one becomes unused, that's ok. If
unused commenting it out is ok. (Leaving it in the file commented out is a
good way to show the history and remove peoples' temptation to reuse the id
#.)

—
Reply to this email directly or view it on
GitHub<https://github.com/jbossas/jboss-as/pull/3361/files#r2143934>.
Started that right now, but I have to leave shortly, so I will finish this later at night.
Well, I wouldnt have to convert it back to integration/basic if I had noticed that annotation :)


Oh, I yell, I yell, but I dont care, only ppl who can hear me are crews working with jackhammers and other loud equipment - Im first to move new neighbourhood and other houses are still in raw state, so I indulge myself.
If this check is done in a separate Stage.MODEL handler, added in this populateModel method, then if a remove and an add are done as part of a composite op, the check (correctly) will pass. Here it will fail.
I'm testing this patch now and won't hold up merging it due to this unused method, but we should talk about whether it should be used to trigger putting the server out of sync.
The value has already been resolved in super class AbstractWriteAttributeHandler.execute(OperationContext, ModelNode). if the value was not defined, we set the default value.

In my changes, I remove a redundant call to AttributeDefinition.resolveModelAttribute(OperationContext, ModelNode)

afaik, only CLIENT_ID and GROUP_ID are set to null if they are not defined. Other attributes should have defined default values
The param should be false for "read-attribute" though. :)
That means that `moveToTop()` will no longer be chainable.
Oops! Sorry I forgot the navigator.mozSettings to check...
if (!navigator.mozSms || !navigator.mozSettings) {
  document.write('<script type="text/javascript" src="js/desktopTesting.js"><\/script>');
}
nit: `onLocalized(Security.init);`
I think we should remove app. it will trigger surprises later if we keep it.
Add a line break above.
Remove this and pop up will work.
Ahah my editor shows me the trailing spaces but not the trailing lines.
Fixed ;)
nit: add a space above.
@filipewl , approximate title and subtitle using negative margin and changed the subtitle to span element.  8727ecf3a4 61faf715c9
Implement an http://en.wikipedia.org/wiki/Observer_pattern 
Creatures notify the world when their positions change and the world logs this change to send off later. Instead of checking every tile for a creature ID.
`profile.is_a? TrueClass` is a bit awkward.  Maybe something like this would be better?

``` ruby
if profile && !profile.is_a?(Integer)
  10
else
  profile
end
```
Why pre-run nginx?  Maybe add a comment
Do you actually see a use case for this in a map/reduce context? I get it in the storm/etc context, but I wonder if this should be part of summingbird's realtime support rather than algebird, because other systems (like hadoop) have other ways of ensuring that you don't lose data during parallel aggregation, and thread safety may or may not matter, etc.
do you need the foldLeft here? Can't you just do a (1 to k).toList.map { x => ... }.reverse and get the same result?
Incorrect. This is not the maximum time that exponential backoffs can occur for. Like in my previous diff's comment, the caller could sleep for 1023 seconds, realize that this is lower than 1024, and then double its sleep time for the next iteration of the loop. It then will sleep for 1023*2=2046 seconds, which is far greater than this value.
Why does this `pass`? Shouldn't it `raise NotImplementedError`?
and this regis call a philippe ?
Sounds good to me -- I actually like 'childIndex' better, but I was trying to be deferential to CodeMirror's apparent preference for short variable names :-)

You think 'normalNodeI' -> 'normalNodeIndex' is ok too then?  Or better to just go back to 'normalNode'?
This type of function could really do with some docstrings, explaining what all the arguments do, and values they expect.

It took reading the code to figure out why `buildRequestCompletions` was a dictionary with keys in `42..44`.
On Mon, Mar 26, 2012 at 12:42 PM, Tom Prince
<reply@reply.github.com>
wrote:
>>
>>      :param miss_fn: function to call, with key as parameter, for cache misses.
>> -        This function *must* return a Deferred.
>> +        The function should return the value associated with the key argument,
>> +     or None if there is no value associated with the key.
>
> This looks like you have tabs instead of spaces here. Also further down.

No tab characters that I can see...

$ grep -P '\t' master/docs/developer/utils.rst
$

?

Thanks,

Stefan
Looks like a redundant change, as it's already captured in 329. Probably leftover from pre-commit edit to that error handling section.
No, problem still persist even not bundling resteasy. We would need to keep doing the same filtering process to get EAP6 assembly working for 5.5.
i'd suggest using "i" as index variable to avoid such statements:
"buttonStatus[ctr].ctr++;"
"buttonStatus[ctr].ctr = 0;"
The reason I used lists:any is because the NewSubscriber is a pid(), while the proplists of Subscribers has a key = ref() and value = pid()
When we want to create a monitor for a new subscriber, we only know the pid() and unfortunately I could not find an easy library that will see if a proper tuple with a matching value exists in a proplist
perhaps the rebalancing could be abstracted out to a different function for the sake of code clarity? Not really sure if that's necessary though.
As for `html.js` module, same here.
you introduce global here and please use camelCase. No need to follow python that closely :D
If we have one window lot of this code feels unnecessary and it's also impossible to test.
No idea. The code (python in python-lib/cuddlefish/options_defaults.py and JS in python-lib/cuddlefish/app-extension/bootstrap.js) was ignoring floats when I got there. Looks like Erik Vold added that in 299ec7969d78be6df34eb705aa803b0f8044cfa7. Can prefs be floats? The comments on that commit suggest they have to be integers.
You can get rit of `is` as we accept everything.
And improve `ok` with something like this:

    ok: function (value) {
      try {
        JSON.stringify(value);
      }
      catch(e) {
        return false;
      }
      return true;
    },
nevermind me, I didn't see the `catch` underneath that logs a better message.
Why do we have to use aDir as parameter here? I would take the class property internally and setup a getter/setter so we can get rid of prepareFile().
Is this actually ready?
Fixed in https://github.com/puppetlabs/puppet/pull/625
That other line just goes away, doesn't it?
No default to start sounds good to me. +1 for returning something other than the original: the new constant seems most reasonable to me at this time.
alphabetize import statements
i'll stop repeating all of these, search/replace:

`s/foreach(/foreach (/g`

`s/if(/if (/g`
i was wrong, `@link` can be used as normal tag or as inline tag
There's the old static management of keys (self::$_defaultAccessKey and  self::$_defaultSecretKey), I don't know if it's used in other Amazon classes or if it can be removed, so I kept them. I can understand the need to store keys for later use (such as, getting them from a config file read at bootstrap), but then, I would either use the registry or extend the class in my application to do that. I don't see the "store the keys for later use" as a feature specific of Amazon/S3 service
Replace the above with the "createAdapterFromManager()" method I detailed in a previous comment.
Should add an @deprecated annotation, pointing to the new method.
This import is only used in a docblock
Please remove if unneeded
Should we `cd` into the `~/khan` directory before doing this?
the behat deps should go in ``require-dev`` (and the bundle is deprecate btw)
I think we should still have the GLib.ConnectBefore attribute here (and possibly for the key release event as well). That would let us solve some bugs with the text tool (like bug #1074877).
switch:
corner1.translate(side).getMaterial().equals(...
with:
corner1.translate(side).isMaterial(...
 and I'll merge this.
Your name and url
Does it really make sense to have 2 urls for the same feed ?
Decouple the nested uses into logical blocks.
Can't we change this entire block to a ternary and eliminate the else?
did you really mean to do this change?
yea I forgot you can just do `instance.defults( "pluginName", { /* defaults */ });` looks good to me!
No need for a ".". not a sentence
"if base and mpilib:" should be "if not base or not mpilib:"

Ran into this already, fixed it.
Need to have the backslash here for it to work, no?
Actually the way I have this here will only reject it if their username has nothing but this type of character. I didn't want to change the method too much; would it work properly if I changed the isValid check to instead return a validated string and use that for the rest of the method?
I don't think we need the --nonbedrock command line argument. This will remove the argument for all the tests
I think this is a great future task 
At the moment we just want to recover the lost coverage
This should be a docstring style comment. And it disagrees with the test, which asserts that there *is* an API key value.
And space here.
Break this into an if statement for readability
Hi Maurice,

Dave F. solved the problem in the SimpleCtdDataProducer. It was to do with the use of a while True loop in the data producer. So even when the processes were being shutdown, this loop was still running and at some point it found that its publisher was sort of dying or not there anymore.

Dave F. used a pattern which sets a gevent event when the process is closing down and then uses this event in the while loop in order to make sure that when the process is closing down, the loop ends right there. It is a great pattern. It definitely solved the error I was seeing in the SimpleCtdDataProducer.

There is a pull request, PR 228, which contains the patch fix.

As I mentioned to Dave, there are several modules in coi-services which are similar in what they want to accomplish (publish data streams or publish granule within while loops) which use the "while True" pattern, which as we have found out is not safe. Some of these modules are actually not being used in tests but when they do get used, they will throw the above Exception, which can become tricky to pin point.

As Dave mentioned, may be someone (could be me) can replace the "while True" with Dave's pattern during design week as part of code clean up.

I think that modules that do their work at the top level should not really be using the "while True" a lot but use the above pattern because in reality they are not meant to run forever and so they need to shut down when they should shut down and it is better if the programmer knows when it is supposed to shut down.

Thanks,
Swarbhanu.

From: Dave Foster <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/coi-services <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday, August 9, 2012 10:45 AM
To: ooici/coi-services <coi-services@noreply.github.com<mailto:coi-services@noreply.github.com>>
Cc: Swarbhanu Chatterjee <SChatterjee@asascience.com<mailto:SChatterjee@asascience.com>>
Subject: [coi-services] Safer termination of SimpleCtdDataProducer (#228)


For @swarbhanu<https://github.com/swarbhanu>

The SimpleCtdDataProducer was running a while True loop with no way of breaking out of it. It was causing it to try and keep publishing even when it was supposed to have been shut down, so long after the connection dies and the channel goes away, it keeps trying to use it.

This patch applies a simple pattern for both safe shutdown and how to do the timeout. Comments in line.

________________________________
You can merge this Pull Request by running:

  git pull https://github.com/daf/coi-services safer_publisher

Or view, comment on, or merge it at:

  https://github.com/ooici/coi-services/pull/228

Commit Summary

 *   Safer termination of SimpleCtdDataProducer

File Changes

 *   M ion/services/sa/test/simple_ctd_data_producer.py (11)

Patch Links

 *   https://github.com/ooici/coi-services/pull/228.patch
 *   https://github.com/ooici/coi-services/pull/228.diff

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/228>.
resetMaxAge called only when session change?
What happens if I login user and don't touch session ever after? Session expires? Very unpractical. This needs be solved first.
Ditto, re: the comment above.
Oops, sorry about that. I don't really use Ruby and an example I had found showed an array being passed in for the flags argument. Seemed kind of weird to me at the time, most other languages tend to do a union of all the flags, but when I tested it locally, it worked. I guess I didn't get it installed properly cause I tried it again with a fresh install and I do get an error now. I'll update the pull request. Thanks for pointing that out, sorry for taking up so much of your guys' time with this.
did we change around where this is currently being used by modules? I know I personally call this function anywhere I want a PID.
Moved to the watchdog now
`scrobbleSent` should have type `Status`, and `Status` should probably be renamed to something like `ScrobbleState` or something like that.

Also, don't use integer codes, use the names for each status (`NewSong`, `NowPlaying`, or `FinalStatus`)

While you're at it, `scrobbleSent` can become `scrobbleState` or Status.
Not sure.
What if $time passed is 0. This is a common error when people get time wrong. Shall we allow scripts running since the epoch?
Otoh maybe it's better to show the user some weird data than silently fixing his errors...
I guess +1 then
This can be protected maybe to only expose it as attribute.
Keep it in the run, we will just ahve to exclude native if it is run on the Mac
Some of these are config for third-party JS libraries, so we need to use their names. Not sure if this is one of them, though.
I'm not sure if that's any better, but hey there's a function for it!
`shift` is the idiomatic ruby way of removing the first element from an enumerable.

This is a technical nitpick, but... If the order the page parts were created changes, this test will fail. Changing this line to something like `page.parts.clear` or `page.parts = []` to explicitly remove all of them makes more sense to me.
We should probably use a full path here. I don't know for sure but I bet that the environment variable $RETHINKDB is not meant to expand to the parent directory for all test directories.
This function should return an 'err' as well, as a failed Cassandra query would return an error.
I don't think we need to check for the `err` here. We can just use `setTimeout`
So that we can determine if there was an error. I suppose we could remove the `request` event and only log on `error` and `response`. Do you have any other recommendations?
I'd like to put this back. This was added in because of a comment by Branden on my PR. He thinks it's better for this function to set its own default explicitly, rather than rely on a default set in getAuthzMembers, which could change at some point.
That's not possible, because we need access to the keys array inside of the loop.
Not particularly, it's just what I'm used to doing. I'll look again and see if the base class already has a log object or something.
I have never edited the user guide so far. Maybe if one could familiarize me.
Вот именно - имя категории "генерируется" xCode, а не мной лично - в условии было сказано "Создайте категорию mutator класса Cell."
В этом методе у вас ошибка. Конкретно эта строчка меняет переменную dna ПОЛНОСТЬЮ. Даже если вы мутируете клетку лишнь на 1%, она изменится до неузнаваемости.
А что если генератор случайных чисел два раза сгенерирует одно и тоже число, что вполне вероятно. В результате полученный index будет одинаковым и ваша программа два раза заменит один и тот же элемент. Таким образом условие про обязательную замену определённого процента ячеек не будет соблюдено.
кроме того, что они там не нужны, ничего.
@RSEvseev всё бы хорошо, если бы Objective-C не мог бы посылать сообщения объекту nil. А он может, это в порядке вещей.

@lilumi то, что вы хотите сделать, реализуется вылавливанием ошибки. В методе initWithLength её генирируете, а отлавливать должны при вызове, соответственно там и надо использовать. Но как мне объяснили - плохая практика.
Просили ссылку, но у меня конкретно по теме ничего нет, зато есть "общая" ссылка по Objective-C в целом: http://unclemif.com/public/objective-c-frame.html
"Teetähis"
..эти все?..)
Therefore the send_blobs RPC SHOULD only be used after the setup RPC, and only if the server...
rename this file to config.py
Look at JTable::store , there you can find an insertid after insertObject or updateObject , depending on which parameter has received JTable::store itself.

Eng. Gabriele Pongelli.