labofsahil/github-event-dataset-2012 huggingface dataset:
This should be `int width  = (int) luaL_checkint(L, 4);` Because the third parameter is `render_mode` for DjvuReflow. And accordingly the next line is `int height = (int) luaL_checkint(L, 5);`
Sir, done, Sir!
same here the Parameters should be before Attributes in the first docstring. you can leave empty the doctsring for ```__init__```
Ahh, good to know.
Indeed I was trying to catch None-picks...
Smart numpy.

2012/10/11 Alexandre Gramfort <notifications@github.com>

> In mne/fiff/evoked.py:
>
> > @@ -314,6 +314,18 @@ def plot(self, picks=None, unit=True, show=True,
> >          plot_evoked(self, picks=picks, unit=unit, show=show,
> >                      ylim=ylim, proj=proj, xlim=xlim)
> >
> > +    def to_nitime(self, picks=None):
> > +        """ Export Evoded object to NiTime
> > +        """
> > +        from nitime import TimeSeries
> > +
> > +        if picks is None:
> > +            picks = np.arange(self.data.shape[0])
> > +
> > +        evoked_ts = TimeSeries(self.data[picks], sampling_rate=self.info['sfreq'])
>
> by doing this "self.data[picks]" you do a copy even if picks is None. Is
> that on purpose?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1818082>.
>
>
is it on purpose to have width = height?
It seems indeed to be caused by roundoff error, https://github.com/mne-tools/mne-python/pull/146 fixes it.
in case it's not clear use:

```
from .baseline import rescale
```
please iterate over all the results not just the one in index 0
Thanks for getting back to me, Moses. There should be something in the minimal base set that allows us to identify what we are running on. The problem with /etc/redhat-release is that there's no standard, where there could easily be. E.g. there could be an agreed-upon /etc/distro-version (enforced by the FHS?) which would encode some useful values in YAML format.

So it would be nice if there was some command that spits out `el6' or `f16'. But I guess there isn't, and we can't rely on lsb_release. What a mess. But hey, that's Linux for you. Automation? What is that?

What is the syntax for a Fedora /etc/redhat-release file? If you can provide that, I'll submit a better patch that just parses that file.

I have to say that this is all a ton of work for such a small change, and it really discourages me from contributing :-(
I think I saw this used somewhere else, you might want to dump it into its own method

`@user.get_preference(pref)` or something like that
@rtyler should url.host and uri.port be set to the capybara.app_host? Isn't this the REST host and port that Connect  will use to ask sauce for a tunnel box?
Also, Connect 2 doesn't need a :domain anymore
Sorry I missed that.
Can you point me to the coding guidelines for the sf2 docs?


-- 
  mit freundlichen Grüßen
  Markus Tacker ~ http://tckr.cc/
The 'line' after a heading should be as long as the heading itself, could you please change this in this document?
Can this be `create` since we mixed in `SyntaxMethods`?
Can't we use something like `test/unit/**` ? I don't wanna maintain this list.
Yeah, here it is.

I think its just redundant to then keep the original one.
Does `outline: auto` even exist? Tried to look it up, but did not see it listed as a value for any outline properties: http://www.w3.org/wiki/CSS/Properties#Outline
Might want to drop this approach and instead using the immutable builder approach. ConsumerParameters(essentials).withFoo(foo).withPigdog(pigdog) ...
remove, pointless exercise in reinventing negation.
A bit correction in where condition. We need last incomplete order so it should be 
```current_user.orders.where("completed_at IS NULL").order("updated_at").last```
Плохо. Если ты слушаешь из коллекции, и альбум-арт был загружен отдельно, то он не подцепится здесь.

Впрочем, похрену, сам это починю.
`tabs` 的內容因為有多個頁面共用, 所以可以 partial
`li`
Create**s**
If you're moving the types test till later, move the types declaration with it, and concatenate the delegateClassName declaration to this var block.
I don't like that we are setting defaults for the flavor_id and tenant_id, but if setting nullable=False requires a default then we'll do it, if not lets remove them, our code to update these values should take care of that, I mean making sure we set those values.
Not sure if this is just a Rubyism I don't know about, but generally in most programming languages it is best practice to keep assignments out of comparison operations. I think it would be best to write:

```ruby
carbon_interface = node['graphite']['carbon']['interface']
if carbon_interface:
 ...
```

That way it's clear you intended the assignment to the carbon_interface variable and didn't accidentally mistake = with ==.
Did you look at org.infinispan.util.Util.addHexByte() ? It's private but we could make it public, since you seem to be reimplementing similar logic?
before completion can only throw RuntimeException, what about only catch that and avoid the instanceof?
Wait… it actually looks like _this_ is the wrong one. We shouldn't be extracting anything into `resourcePath`.
Could you put a space before `>`?
+1 fail fast ftw
The home button does work, it just needs to be run from the top level frame. see `test_cards_view` for an example.
While I like the idea of getting a single header retrieved as a string, shouldn't the response from this call be consistent?
Wrong is value against which you assert, I guess it should be  $this->assertEquals($b, PMA...)
I don't mind the schema/ two-liners, but unpack-timeseries could also extract the ts value. Is there ever a situation when we're unpacking a ts and don't immediately want the vals?
I will read tomorrow the JS coding style...

On Tue, Sep 4, 2012 at 9:13 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> > @@ -182,6 +182,48 @@ var rulemap = {
> >      return cb();
> >    },
> >
> > +  minlen$: function(ctxt,cb){
> > +	var minLength = ctxt.rule.spec;
>
> minLength would be better as minlen - more consistent with rest of the
> codebase
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/8/files#r1525833>.
>
>



-- 

*malex*
Should document an @throws
@arnodeclercq Can we change this to a real button instead? We don't allow `href="#"` and it seems like this is calling an action
Can you add some docs to this function?
OK, thank you! I have updated to use the built-in get_unique_labels()
This should fix the failed ContentControllerTest cases
``useAttributeAsKey`` should be dropped as there is no reason to use an associative array here (the keys are not considered by the filter)
how old is that commit though, they could've refactored some stuff since then (also that commit doesn't match up exactly with this chunk of code in playground in the state we forked from (all I got rid of was a single experiment.save call where the comment is, while that commit iterates through all the experiments ? ?)

Although yeah, I feel like they did have a save there on purpose but nothing broke when I took it out (ie whole test suite passes & nothing seemed off when I was manually testing w/ testapp) so not really sure @_@
You're right, I've pushed a fix.  I guess my testing created bitmaps that were structurally correct but meaningless for Bloom lookups...
WT_REF_EVICT_WALK is really badly named, since it's set for checkpoint threads?

The WT_TREE_EVICT flag to __wt_tree_walk is equally problematic.
space after switch too
If I'm not mistaken, the Silex ```before``` hook is triggered at the following line (422 : ```$this['dispatcher']->dispatch(SilexEvents::BEFORE, $event);````), **after** the middlewares ?

I just added a Unit Test to check that (see following commit).
should be check.output
cocnepts -> concepts
Should the type for parameter ``$docBlock`` not be "string|null" instead of "string"?
Are you sure that the method "isDir()" exists?
I doubt that you're allowed to do this in our scripts?
according to the Twig coding standards, the filter name should use underscores, not camel case.
getConfirmOrder()
Could you remove that line? Thanks.
Perhaps a stupid detail: since we're on 1.6 officially, shouldn't we be linking to 1.6 docs?
The question is also if you really want to check existence, maybe you want to retrieve that element which matches?
Or is field empty already covered by validation before ... anyway, it is cleaner what check does this method do and what is checked somewhere else if you turn the logic around (so raising only if there is something wrong).
Don't translate this. Don't translate semi-internal error messages because then it is really hard to Google. Hm, maybe this string should even not be marked as translated.
This URL does not work for me.
TODO as of  wlanslovenija/PiplMesh@6a06c735e07f4d881d28d43f6405dd335fdc4da3
Can't do this! There is no php formula in Homebrew.
Assuming that the `Composite` inherits from `AbstractType`:

An exception of type *System.MissingMethodException* is thrown with message *Constructor on type 'Foo' not found* because in that case, while we have chosen the correct constructor, we are invoking the proxy type by supplying an instance of the `Composite` type. We can't convert from one type to another though.

There is not much to do here, I think..
what changed here and why?
no idea.  will fix.


On Fri, Nov 9, 2012 at 3:19 AM, Moxie Marlinspike
<notifications@github.com>wrote:

> In src/org/thoughtcrime/redphone/call/InitiatingCallManager.java:
>
> > @@ -24,6 +24,7 @@
> >  import org.thoughtcrime.redphone.crypto.SecureRtpSocket;
> >  import org.thoughtcrime.redphone.crypto.zrtp.MasterSecret;
> >  import org.thoughtcrime.redphone.crypto.zrtp.ZRTPInitiatorSocket;
> > +import org.thoughtcrime.redphone.network.LowLatencySocketConnector;
>
> eh?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/58/files#r2080486>.
>
>
iterator option added here
We need to wrap this call inside a try - catch block to ensure that it doesn't raise an uncaught exception.  Otherwise we might be here for ever!
I just followed the convention from Bundler's gemspec
nit: make sure the if / else body are indented :)
I would like a little comment explaining what this does ;)
What does this function do? Maybe an example input/output will help.
What's this function do? Maybe easier to understand with an example of how it's called.
that's a long list of kwds, and we cannot use **my_bounds if return_weights are set

maybe combining bounds into a dict, see also comment below on boiler plate
Most of this should be merged into the ruby-cldr gem instead of twitter-cldr.  That's where all the CLDR xml files are parsed, plus it's nice to give back to that library and keep our implementation separate from their more generic one.
not related just fatal, because class doesn`t exist
The differences between the "if" and "else" cases here seem to be

 - opcontrol --setup call for sgs2
 - choosing CPU_CYCLES hardware counter instead of --timer SW interrupts

opcontrol will dynamically tell us which HW events the kernel supports, so I'd like to see these branches unified, dynamically switching on what the kernel provides.

e.g., the kernel we use for nexus s provides HW events.
Space before `}}`.
I keep clicking the link, but nothing happens!  How did you master hackers accomplish this trickery?!
Well, I agree with you that the other way is more intuitive! (In CCDNoise I was wrapping Gary's code in Python, so he took care of getting the definitions right...)
My preference is never to use aliases (`as np`) at a level of the code that the user is expected to see.  If they choose to copy bits and pieces out of a demo script, and they forget to import numpy at the top of their script as we did, the error that python gives should make it immediately clear what to do:
```
NameError: name 'numpy' is not defined
```
If the error has `np` instead, and aren't used to this alias, then they would have to look through the script to see where we defined np.

However, in the code that we write that isn't at public scope, it's fine to use the `as np` alias.  I probably mildly prefer not to (it only saves three extra characters each time), but I don't see it as a problem if people prefer that.
Mention that it's a factor of 3 in linear size, not area?
This is equivalent to the chord stuff when obscuration == 0.  We still need chord and all the rest for when obscuration != 0.  This basically skips a bunch of multiplications by 0 and such so it's faster if obs == 0.
Barney, are you fixing this to?  I'm happy to do it or for you to, but since we both seem to be editing, I don't want to duplicate.
We haven't a lot of pull requests (and I actually don't know what workflow we are expecting), so I don't want to startle you, but I expect you to fix my remarks and then I'll accept your pull request (or I have to do it myself?).
It's very confusing to allow a variable named ready_quiz to be of type Video
We have updated the feature file and removed this step def as it seems redundant in our test approach. You can see the update at https://github.com/zeuslearning/rigse/commit/25396cee177d16e9a54e8557ee7ecdf932224c23.

We shall add this fix in an upcoming pull request.
Yeah, I tend to avoid it as well, but here it is being used as a NFE, which really isn't a detestable practice in JS.
why not  view.$("#" + name)  ?
Why deny debugging in war distribution?
again, you can just initialize hashes with {}
In case this PR gets favored over #211 then this string should be translated.
Recommend blank lines above and below these new lines to emphasize a separate operation.
thx for the tip ;)
Where is m_deleted set? I see it checked in onResolvingFinished but I don't see it being set to true anywhere?
I'm fine with renaming and moving it to npm, but I'm not sure how to name it: path-resolver, dependency-resolver, find-dependencies?
On 07/03/2012 11:16, Etienne Segonzac wrote:
>> @@ -1,6 +1,9 @@
>>   'use strict';
>>
>>   function profilePictureForNumber(number) {
>> +  if (typeof(number) == 'string')
>> +    number = parseInt(number.replace(/[^0-9]/g, ''));
> Yeah I'm phasing out multiple "{" and "-"

my bad i've read |/^[0-9]/g|
Well, remove the "else". so if it's negative, we still show "0 second(s) ago"
Cause it needs values of data['queries'].
Is there a way to extract the minimax algorithm here into it's own class/module?
Aici ati omis <code>this</code>.
yep your right, my local artifacts were out of date - closing
this is not needed because `== null` checks for `=== null` and `=== undefined`
-1 поток?
Это не ошибка.
Note this applies to all references to these products.
Already ran into this bug and fixed it... do we need `super` here or not?
there's another case of it a little further down in the file too.
this is wrong. You broke the support of form type given by name (which was used in the testsuite btw, meaning you probably broke it)
I talked about the other kernels in the paper in my last comment here.
> you would have a method that returns a different number of parameters but you
> wouldn't know that number until the function returns, IMHO a bad idea.

Indeed, I agree.
Heh, done
start doesn't need to be public since it is called in ready and not from outside
I added you (i think) to have push/pull access to this repo. As far as i know, this means that all your work, as of now, still remains in  your branch until you push the big green button at the bottom of the screen which will automatically merge all the commits into the Khan/kiln-review branch. 

Let me know if that's not working, you should be able to merge these changes in whenever without waiting for me, but it's fun to talk about code anyway.
s/supporting/supported/
This file doesn't seem like the appropriate place to have this code.  blackberry.py's purpose is to create the structure for a new project, it is not intended to be used as a lib.

Maybe the render code should be extracted to a lib where it can be used from for both builder and blackberry.  On the other hand mako.Template is already a lib.  This generateBarDescriptor should go in builder.

Alternatively it may make sense to move all the templating code in the BlackberryNdk lib even though it doesn't necessarily relate to the ndk.
Is there a reason we don't set the "source" property?
Agreed I'll refactor this test
On Nov 19, 2012 1:27 PM, "Hardy Ferentschik" <notifications@github.com>
wrote:

> In
> hibernate-search-orm/src/test/java/org/hibernate/search/test/id/UnorderedIdScanTest.java:
>
> > +
> > +import org.hibernate.search.test.SearchTestCase;
> > +import org.hibernate.search.test.util.TestForIssue;
> > +
> > +/**
> > + * No test method is needed as we just want to
> > + * verify the SessionFactory is able to start when
> > + * using this entity.
> > + *
> > + * @author Sanne Grinovero
> > + */
> > +@TestForIssue(jiraKey = "HSEARCH-1048")
> > +public class UnorderedIdScanTest extends SearchTestCase {
> > +
> > +	public void testStartup() {
> > +		//Just verify the SearchFactory could be built
>
> Sure. My comments is more about the fact that there is no single
> annotation. Maybe we could get the *DocumentBuilder* for *
> InvertedIdOrdererEntity* and assert it is not null.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hibernate/hibernate-search/pull/353/files#r2166038>.
>
>
You can't handle escape like that.  You'll need to note if the last match was an escape, and if it was treat an escape as a normal character.

This is used for unicode (utf8) and ascii reading, and there is nothing to stop your separators, terminators and escape characters from being multi-byte strings.  You should have a test case that does that.
That's a larger change than it seems.. rowcount_t are thor typedef's and this is in common/thorhelper used by other engines.

Everything should probably use the same typedefs really.
I think it is, spill will have performed a noteSpilled(), i.e. adjusted firstRow, so the 2nd flushRows() call is resetting firstRow/numRows.
Yes, I'm actually not using it in the view, I just forgot to remove it from here. Thanks for catching it!
No reason at all - just time. I wrote the below hack pretty quickly - but after your comments about the performance of HTTP transfers compared to NFS, I'm not sure it's even necessary. Anyway, I'll see how I go with your suggestion.
The plain synchronized came from the parent class. But yes, not used here, gonna remove it.

You are right, this may behave inaccurately if you clean cache while another thread is trying to read it.
By the way, I'm not getting any notification about these comments.. do you know how to enable email notifications about this?
Can you change it to be just "Probability prediction"
I think for files we only use on a single page that most users may not visit, we should try to keep the javascript separate. Makes other pageviews faster, and we shouldn't take the hit until we need it.
This string "CVE" looks like a constant that belongs to some model (issue.rb if such exists).
The author format should be changed to:

<pre>
Scott Sutherland <scott.sutherland[at]netspi.com>
</pre>
This makes me think that ```"``` should be a badchar for the unix target.
Good point. When I was reading this in the if-block, it took me a minute to understand what it did. But here, the function name tells you exactly what it's doing. Ignore my original comment.
The code compiles with msvc9 but the _resample extension is not using OpenMP unless `/openmp` is added to `extra_compile_args`. OpenMP requires the full Microsoft Visual C++ redistributable package to be installed on users systems.
I broke config stuff out into a module. This should be fine as long as the module is not stateful.
I think this should check for allowing a `nil` value as well, e.g.:

```ruby
@options[:allow_blank] == allows_value_of('') && allows_value_of(nil)
```
Obviously not needed if we add `envVars` on hosts.
There's no reason to say "Static method" Just say "Creates a new material using an existing materialId."
Unnecessary parentheses.  If this is all temp code as suggested in the comment above, then don't worry about changing it.
Probably add a comment saying we are doing this because we can't access the depth buffer on all browsers yet.  This algorithm is really a workaround.
Instead of having an if-else statement, you can just do data.bubbles = !!data.bubbles
I think it's OK here. The control displays discrete pages of content, as opposed to a scroll view, which you can move pixel-by-pixel or line-by-line. And it's got a paging control, which we can't really rename because it's in a bunch of properties. So as Opie says, maybe just describe in the intro how the control arranges a series of child views as discrete pages.
The logic in the last 20 ish lines of code seems like it could be cleaned up.
This may be a bad assumption. You should have something more intelligent in the future to check this, e.g., see of the name appears somewhere in the higher parts.
I don't know, and I defer to someone with more experience with postgresql.
you should use a relative path so that browsing the doc for another branch or tag does not send you back to master when following a link.

And you have a type: ``MongoDB``, not ``MondoDB``
Запросто может рассинхронизироваться.
The `int` form should definitely go. Can you send a pull request that fixes the docs?
This test was not needed, as the code naturally handles empty. No point in paying every time for a case which should rarilly happen.
I think there's another possible optimization here:
This variable is currently thread local and therefore needs to be initialized whenever a new thread is started, but as it's the same function for all threads this variable could be ```shared``` or ```__gshared``` instead.

So I'd mark this variable ```__gshared``` and change the ```static this()``` to ```shared static this()```
I'm not sure if this deserves a newline before it to separate the blocks, but I wouldn't mind it being a talking point for the styleguide.
Well, I would do something like:

```
custom_paths = {
                          'files': ["bin/geant4%s" % x for x in [".sh", ".csh", "-config"] +
                                   ["lib64/libG4%s.so" % x for x in ['analysis', 'event', 'GMocren', 'materials', 'persistency', 'readout', 'Tree', 'VRML']],
                          'dirs': ['include/Geant4'],
```
See this?
There are several examples online (IE http://stackoverflow.com/questions/3643939/java-process-with-input-output-stream ) of different ways to read all a processes input. I think though someone more familiar with PMS internals should write it as I don't know if there's any PMS specific classes that you would want to use
you could simplify this a little by referring to it as 'httpd' which is the title of the service. That way, this module doesnt have to worry about the name of the apache service.
I considered that implementation.  In the view, I'd need to be able to differentiate dividers from registrations, and I'm not sure how.

Also, could you clarify why you represented dividers as DIVIDER('YESTERDAY')?
And, I think the current looks more like:
[[a, false], [b, false], [c, "YESTERDAY"], [d false], [e, false], [f, false]]
great idea, tried, but seems I cannot get the new $className() part working. It works in isolated class however once it is in a library referencing multiple class files, it fails :( It is just one of the quirk of PHP.
Usually you'll use camelCase  function names like getFile ;)
Also, if you think this function might be of value for future tests (seems to be a reasonable assumption) move this out of the test file and into runner.js
GHC is just a build dependency here. That's why you're getting conflicts when the built module is being loaded.
Can you break this down into several ifs, for example:

```php

if (!$property->groups) {
    return true;
}

foreach ($property->groups as $group) {
    // ...
}

return true;
```

This makes the different conditions a bit more obvious.
Should be `.on()`
Уникод пойдет по пизде.
Лучше `toUtf8 ().constData ()`
Парой строчек ниже тоже не забудь заменить.
I don't follow. What effect would that have?
No, it's arch-specific. There's an image type for e.g. ARM too.
Why not do
if (hudson.Platform.current() == hudson.Platform.WINDOWS)

?
Since you have a list view here, shouldn't the stores already be in the context as 'object_list'? Or am I missing something?
error messages to translations
Now we have a full activity so we can use its properties to build a more meaningful message

On Part 3 we will see how to use `jade` templates server side and client side
I tried that, but `fs.realpathSync` errors on `'<cli>'` and `'<stdin>'`, so it would have to test for those special non-filenames anyway.
Does this line even compile?  I don't see an end to this statement ...
pero esto no
Je mettrais pas cette phrase, même si elle est vraie :-)
Yes, this is important in particular to help partners that integrate
with our CLI / automation scenarios

On 11/19/12, André Rodrigues <notifications@github.com> wrote:
>> +
>> +    channel.PUT(settings, callback);
>> +  };
>> +
>> +  mobile.getApnsSettings = function (options, callback) {
>> +    log.verbose('Subscription', options.subscription);
>> +    var channel = getMobileChannel(options)
>> +      .path('mobileservices')
>> +      .path(options.servicename)
>> +      .path('apns')
>> +      .path('settings');
>> +
>> +    channel.GET(callback);
>> +  };
>> +
>> +  mobile.setApnsSettings = function (options, settings, callback) {
>
> Going forward we're thinking on making this sort of operations split from
> the commands one. Idea is that we could publish all of these as a module on
> it's own, instead of part of our CLI so that other modules can use. If you
> want, you could start this effort here.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/WindowsAzure/azure-sdk-tools-xplat/pull/18/files#r2175173
>
typo overrid?
why the symfony coding standard use yoda conditions also it protect you.
are be div asliam bg-color dadam doros shod
Mamnoonam
Yes, I agree. Have fixed this.
@pivanov Thx! BTW: We still need the fonts.css for browser preview please keep the link declaration!
Doubled percentage signs.
I am 100% open to a different package for this interceptor feature. Any proposal?

 I have no precise idea in mind but more than one type of interceptor is definitely in the realm of possibilities. That's why I created the subpackage to be future proof.
In my HTML pull request, I introduce the concept of having the callback take an argument which is whether we advise saving the account after the operation.  The general idea is to let some higher level logic (in mail universe) potentially be smarter about triggering saves so it can avoid flooding the system.  I don't actually believe the user will be able to overload us in the touch UI case, but I think in a keyboard binding case where the user could hit the delete key several times a second, that's an example where it would come into play.

No need to change anything about this now, but do you think my strategy sounds reasonable?
@kwallis @nukulb 
According to [invocation framework wiki] (http://wikis.rim.net/display/dpa/iF+Application+PPS+-+Trunk+-+May+1+2012#iFApplicationPPS-Trunk-May12012-QueryTargetsMessages), target_type is a mandatory parameter, but this isn't made clear in this documentation.

Also, if it's a mandatory parameter, we should expose constants for users to use? The possible target types are:
VIEWER | APPLICATION | SERVICE | ALL
It seems strange to have this both as a class method and an accessor. Should the property just be called 'locale', or are they functionally equivalent?
Need to store this, as we require it for refresh flow.
@jordanbyron do you think it's is necessary to query the lockable field from outside of the class? If not, I'd rather remove these lines, but if we need it, then I think it's best to make it readonly.
* Remove unnecessary compile dependencies.
* Add the Splunk dependency:

    compile("com.splunk:splunk:$splunkVersion")
Do we know if this defaults to "inProcess"
We should be consistent in naming (registerEvent vs registerEvents)
this is still needed?