labofsahil/github-event-dataset-2012 huggingface dataset:
Lets restore `declare.in(source, WARMUP_RNG)` for initialization. Otherwise sanity data already merged will not match to these tests.
Use `var`
why remove the recipe description?
Would be nice to be using cartopy here. Example:

```
>>> import iris
>>> import iris.tests as tests
>>> path = tests.get_data_path(('PP', 'ukVorog', 'ukv_orog_refonly.pp'))
>>> cube = master_cube[210:238, 424:450]
>>> grid_north_pole_longitude = cube.coord_system('RotatedGeogCS').grid_north_pole_longitude
>>> grid_north_pole_latitude = cube.coord_system('RotatedGeogCS').grid_north_pole_latitude
>>> lats, lons = iris.analysis.cartography.get_lat_lon_grids(cube)
>>> rlons, rlats = iris.analysis.cartography.rotate_pole(lons, lats, grid_north_pole_longitude, grid_north_pole_latitude)


>>> rlons[0, 0]
-0.17049882452749962
>>> rlats[0, 0]
-1.7322000065387122
>>> lons[0, 0]
-2.7694539705984536
>>> lats[0, 0]
50.767481925299272

>>> import cartopy.crs as ccrs
>>> rp = ccrs.RotatedGeodetic(grid_north_pole_longitude, grid_north_pole_latitude)
>>> gd = ccrs.Geodetic()
>>> gd.transform_point(rlons[0, 0], rlats[0, 0], rp)
(-2.7694539705978425, 50.76748192530357)
>>> rp.transform_point(lons[0, 0], lats[0, 0], gd)
(-0.17049882452792256, -1.7322000065430092)
```
`<?php`
Where to the variables get marked? It sounds like something that I'd rather avoid (inplace modification of variables is typically undesirable) but I don't see where it's actually being done.
we should really get in the habit of reading the CUDA device properties rather than hard-coding such numbers. How hard is it?
I'll take care of it. Not sure why it happens.
this `return;` is not necessary.
Fetch instead of Download
warehouse should be removed from here if defined below.
duplicate object class is not supported in cakephp anyway.  It may seem to work, but it will break randomly.
:nose: :poop:
I think this part of fix should be merged, this is no need to reinit bundle again, we just need to use the existing one.
this file appears to be a duplicate of test/unit/bom-garbage-no-webvtt.vtt, there are also others, check the files in the directory
On Mon, Apr 2, 2012 at 6:57 AM, agemogolk
<reply@reply.github.com>
wrote:
> I think the best solution is to find a way of making Operator? possible.

How about passing the operators and operator positions out-of-line as
symbol parameters, so that `x * (y,z) + w` becomes
`infixOperator[(*),1,(+),3](x,y,z,w)`? That allows prefix and infix
operators to be passed together in a recoverable way, and I think the
code to decompose that form would be simpler and thus faster as well.

-Joe
typo: initialize
I didn't get it until I looked closer. The font they use for `code` isn't so hot on my machine.
Yeah, I think we can dispense with "desc.language.label", since it should be obvious from the content of the field…
And moving it to the end of the description line seems like a good idea, too.

Something like:
<td>{{ desc.description.label }}:</td><td>{{ desc.description.value }} {{ desc.language|data_verbose_field }}</td>
You don't have to. I'm just a stickler for prettiness in code. If it's hard or whatever it is not important.
This points to an HTML document. I believe you want `url 'http://www.us.apache.org/dist/subversion/subversion-1.7.6.tar.bz2'` (or one of the mirror URLs).
IMHO it's better to rename kind -> type, so it will be:
``` javascript
{
  name: 'foobar',
  func: foobar,
  type: 'generic'
}
```
Should be ELSEIF
It is used occasionally to send stuff on `.outbound` and `.event`.
This is in #242, I think.
Is there a way we can test this more accurately? It strikes me as a bit odd that both `test_restore_ttl` and `test_restore_ttl_frozen` use the same `assertTrue` check.
A good example would be: `Session store: the connection to the mongodb server is not yet available.`
It is like this so that the individual tests each have their own import set for the modules being tested.  If the tests need std lib imports then those can go at the top of the file as normal.  Keeping each test with its own import set allows a few nice features:

1) Imports can be tested (see ImportTest) as a specific unit test
2) Imports from one test don't leak into another and potentially give invalid results.
3) Any failed imports fail the specific test and not the whole test suite.
Upon further inspection, can we grab all of these by using `getattr(thing, `target_`+key, None)` instead of involving the `target`?

Should the `"url"` key be permalink (similar to `thing.target_path`)?
getInjectedClasses calls getClassesAnnotatedWith which only returns classes being handled on the current pass (only classes generated on the last pass). If we didn't do this, classes that existed in the previous pass but referenced nonexistent classes at the time would not be re-included in this pass.
Supporting aliases will result in many false positives IMO.  Revert back to just supporting plain ids?
我记得Mac下默认图形设备是`quartz()`，看来我还是得找个正常的Mac机器看看，你玩的都是暗黑魔法。谢谢！
or even parts.each_with_index do |part, i|
I always forget about the dojo stuff! But yeah, it's really just a type check.
OK, but it might make it easier for person running tests to interpret the results.
This is the handler for the FILE_OPEN command. It is registered in the init function at the bottom of the file. It changes the FILE_OPEN command to take an optional object with a `files` field which is a list of file paths to open. Maybe the `files` field should be changed to `fullPaths` to be closer to the old `fullPath` field from before.
Did you mean to delete this block?
usually you want to xml-escape anything you're putting in an xml string, unless you've already validated `audio_file_url` elsewhere.
I know this isn't the best way to do it.  However, I considered exceptions, but then you run the risk of exposing sensitive information to the person who is forbidden.  If someone can come up with a better way, I would be more than happy to discuss it.
apart from positions, like x and y.
if currentFilter is null, nothing is done
is the 31 chars limit in the PEP 8 recommendations?
use a div for grouping elements, p is just for paragraphs within text
All this I would leave out.
Should we have a comment here explaining why there are 2 password setters (and also because there is a comment already for the register_password setter, above)?
Remove please!
I don't.

I am removing this when I add in the scroll listener in 2045.

We'll get and set the width via: https://github.com/mozilla/butter/pull/846/files#L0R151

superscrollbar.js no longer cares about media's default width. Only media as a concept of this.
Not missing a semicolon.
Add some spacing here before the last bracket.
We've been talking about this in #2184 and I think we're going to try and always use UPPER_CASE now.
Would putting this in the local etc make sense? It isn't a script or executable, right?
HTTP_SESSION_STICKY=YES

-> 

HTTP_UPSTREAM_SESSION_STICKY=YES
Is this needed? Let's come up with a better name in that case. Just adding a 1 to the name isn't very descriptive.
Let's add a javadoc for each of these sources describing what they do
``xml_file`` is a little too generic for my taste; let's call it ``metadata_file`` or something instead.  If we just call it ``xml_file`` I'd be concerned about future additions to this form that also add XML files for other purposes.
'initialize cdb database' sounds like creating it, perhaps say 'initialize cdb structure' or 'initialize cdb handle'
Accidental debug message, now removed.
I would add index
Minor annoyance but couldn't ```"selected" unless !@next_environment)``` have been  ```"selected" if @next_environment)```
you change the `continue` statement into a `break` statement. Is this appropriate?
Mended.
do you have to mask out HY_NOT? type2relflags ignores it anyway.
I think this should stay in, because it's useful to be able to trivially implement any DE EOS by just overwriting a single function.  It may not be used often, but if it's used even once, it's worth leaving in (because it's already implemented).

That said, I agree with @nhmc that `w` (or maybe `wde` is a better name than `get_w` because of the already-existing convention for `H` et al.
Probably better to add `cextern/sofa/` to `include_dirs` in the `setup_package.py` rather than hard code a relative path to `sofa` here.  This will make it harder to use a system-installed `sofa` if any when that makes sense down the road.
Done in 9d79a9c - I learned something about dictionaries today! Didn't know about these methods :-)
typo for failures - I  wanted the list ordered by all single failures first, then multiple failures.
I really don't like these functions. Especially the last one, it just calls the one above and should return true or false, not a Listing object. We should only add functions like this as we need them in other areas. Here's what I probably would have done:

```ruby
def bookmarks
  lists.where(name: "Bookmarks").first
end

def bookmarked? video
  bookmarks.listings.where(video_id: video.id).exists
end
```

Even those are just guesses, these really need to be driven by need as we write the views.
Same comment here, maybe:
    proxyType npInfo;
    {
          LOCK(); npInfo = nameproxyInfo;
    }
    ... then proceed to use npInfo instead of the static nameproxyInfo.
@markstory There was a check for the $count here again
You shouldn't need to backup + restore values in Configure as this should be done in CakeTestCase::setup().
We use to add comments to test cases explaining what we are testing
Need space after `if`. Please use the code sniffer.
This could result in data loss
OK, I will make the change.
Actually I have used the file headers found in @twpayne 's Spherical and GoogleEarthView addins => should those files be updated as well?
We should use the `spawn_link(M, F, A)` variant here to better deal with hot code upgrades.
I can assign it to a variable if that's what you want. The perf cost is null since it's LINQ to objects.

Something like this?

```
Claim emailClaim = identity.Claims.SingleOrDefault(c => c.ClaimType == ClaimTypes.Email);
if (emailClaim != null)
{
    email = emailClaim.Value;   
}
```
2 spaces, maybe they're 2 tabs? (translated to spaces by the text editor?)
@craigambrose cheers for that. =)  PS - the rest of this pull request is my homework for Extract Method.
I disagree. When things are blatantly too long, its highly annoying. Just look at Java. Certain clients are also hyper-critical about verbosity.
That reads like pretty black magic. Might just be me, but might be worth adding some documentation/comments.
Either make this more nicely descriptive or remove it
Like I mentioned before, basically an api change here. I kinda don't care.
you *can * , and double space before `If` 2 lines above.
On second thoughts, that won't work by itself, because the functions below expect to be able to pass their default (currently  `None`) through to get the default. So everything that calls these should have `getdefaultencoding()` as its default too.
The `io` module follows Python 3 conventions, so `io.StringIO` only accepts unicode. In Python 2, `sys.stdout.write` can be handed either unicode or 8-bit strings, so we do need to use `StringIO.StringIO` for this.
Maybe you could add this to your global gitignore instead. Also the labs/virtualbox/.DS_Store is still in the PR.
Terrence, unfortunately the design of the map-reduce API makes this impossible. The interface looks like public interface SenseiMapReduce<MapResult extends Serializable, ReduceResult extends Serializable> extends Serializable, but Map is not itself serializable. Perhaps that's something we can rethink.
Putting ctiy/asn/country inside the constructor means we'll load these every time a NetLocation is instantiated, e.g. for every relay in the consensus. Hmm. Am I missing something, an pygeoip is caching these itself or similar, and create_geoip() is fast?

How about a set_geoip_data_directory() or similar at the module level (and leave all the databases at the module level). Thus any NetLocation objects instantiated after the call would get locations from the new data files.

I don't see how you'd use this as it sits, anyway, as NetLocation objects are instantiated inside Router during updates.
Remove this file, should still work and we don't have a database.
Maybe I should chunk this so it doesnt get a huge result set?
Also, the ``.sort()`` call fails since ``tags`` at this point is a queryset and that has no ``.sort()`` method. So to sort the tags here, it should be:

    tags.order_by('name')
This is the [Jerry Springer](http://en.wikipedia.org/wiki/Jerry_Springer) of code reviews.

I added a link in case @cvan didn't know who that was.
Quite right :)
Sorry for that.
public/assets should stay there IMHO, since it's project specific.

On Sep 26, 2012, at 5:45 PM, James Herdman <notifications@github.com> wrote:

> In .gitignore:
> 
> > @@ -0,0 +1,5 @@
> > +.sass-cache*
> > +public/assets/*
> > +
> > +.DS_Store
> Generally speaking this should be in your global gitignore file as this kind of cruft can vary wildly depending on the OS, or even the text editor. Please see Ignoring Files on Github's help section.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Well let's say extracting the ooc varargs fields writing code into its own function would be good, imho.
I've made this to randomize coordinates of name and somewhat prevent overlapping
if there are multiple candidates to choose among (that is, more than one candidate with maximal length), select the shortest possible region with an extractor match.

That is, when trying to find prefix and there are multiple choices, it chooses the last one (the first one in the reversed tokens set) that gives a result between each prefix candidate and the end limit of the scan. Then, when trying to find the suffix, it searches it between the found prefix and the end limit of the scan, as normally, but again, if multiple candidates, tries the first one.
You're right. I relaxed this cause we're not really interested in all the crap a server prints but only the logging coming out of the app, but of course I'm biased since I wanted to avoid printing to `env['rack.errors']` as it complicates things on the JRuby side. 

I'll look into "extensible" logging all the way down to **jruby-rack** in embedded scenarios, but I can't promise anything.
The original mixes styles, so I just put this straight.
Right. A header doesn't hurt, but that was not the entire point. There is already ResponseHeaderBag::makeDisposition($disposition, $filename, $filenameFallback = ''), because content dispositions are a more general concept. The only thing that BinaryFileResponse can provide beyond that (and that would make it useful to have some special handling here), is setting good defaults based on the file name it has. Thus a flag that decides whether to automatically set that or not would do it. Would you be happier with `$autoDisposition = 'inline'`? Or wasn't I able to convince you? ;)
I think this line should be dropped as PRs are tested automatically by Travis anyway, and the description is likely to describe only the state for the initial submission whereas Travis will update its status
@relwell OK, i understand now. You are right.
I should let the ConnectionException ?
why static ? You are not using it as a static method
This looks weird as short description of the method.
使いたい場面次第ではあるけど Topic 主語がよさそう。
どちらにせよ実装も topic 主語の方に見た方が楽になるはず。
Ah! I should have just used a for-loop here. Thanks for pointing this out.
This is a completely different issue altogether, please oen a new PR.
please use `[[items lastObject] title]`
lack of error handling here by design, the piece of importance is the 20 closest venues so there's a UIAlertView there
For these particular examples, how about a refactoring like this?

```ruby
# view
<%= og_tag 'image', "https://#{ENV['HOSTNAME']}/logo.png" %>

# helper
def og_tag(name, content)
  content_tag :meta, property: "og:#{name}", content: content
end
```
semicolons are noise which is unnecessary in Kotlin :)
I vote that we ignore greyscale entirely.  The only cases we should handle are:

1. n channels, with alpha clearly marked.
2. 3 channel, implied alpha=1.0
3. 4 channel without alpha marked, assume alpha is channel 3

This limits the complexity of the implementation while allowing for all the common cases.

An app that anticipates other oddball cases is free to doctor the spec or the image itself (for example, by adding and marking an alpha channel) prior to passing it to over().

Simplify, simplify. (But not so much that it's useless for *common* cases.)

	-- lg


On Jun 21, 2012, at 4:32 PM, StefanStavrev wrote:

>> +    
>> +	ImageBuf::ConstIterator<Atype, float> a (A);
>> +	ImageBuf::ConstIterator<Btype, float> b (B);    
>> +    ImageBuf::Iterator<Rtype, float> r (R, roi);               
>> +    for ( ; ! r.done(); r++) {
>> +        a.pos (r.x(), r.y(), r.z());
>> +        b.pos (r.x(), r.y(), r.z());
>> +
>> +        if (! a.valid()) {
>> +            if (! b.valid()) {
>> +                // a and b invalid.
>> +                for (int c = 0; c < channels_R; c++) { r[c] = 0.0f; }
>> +            } else {
>> +                // a invalid, b valid.
>> +                for (int c = 0; c < channels_B; c++) { r[c] = b[c]; }
>> +                if (! has_alpha_B) { r[3] = 1.0f; }
> 
> Oops missed the z channel, that would be {GR, GRA, GRZ, GRAZ, RGB, RGBA, RGBZ, RGBAZ, INVALID}.
> 
> It makes sense for a grayscale image to have alpha or z channel attached.
> 
> The first four are grayscale images and the second four are color images. For some algorithms the math is different for grayscale and color. I would then have:
> 
> // call here the function to tag the image
> 
> if (color) { }
> else if (grayscale) { }
> else { }
> 
> You see where I am going? I feel uncomfortable thinking about "images with 5,6,... channels", I feel like we need to "classify" valid images for which we can apply our operations. We can even have some class called GENERAL if you will, but let's at least define it.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenImageIO/oiio/pull/381/files#r1030406

--
Larry Gritz
lg@larrygritz.com
In keeping with the above, I think it's ok for A or B to be single channel, and treat them as opaque.
Yup, my apologies. This one was formatting when I was trying to fix some compiler warnings. I got fed up with reading it so I formatted a lot of it. :)
for what it this runner needed?
I didn't see it on the next line because I'm an idiot. This is the best way, then, I agree, carry on.
Murali, to be more specific, Mark is pointing out the fact that the data stored in addressbook['groups'] is actually an ORM object representing the data relationship. More specifically, akanda.userapi.db.models.AddressBook.groups is an orm.relationship pointing back to AddressBookGroup which also points (in part) to AddressBookEntry objects.

As such, your serializer will need to iterate through the .groups attribute, which in turn may also need to iterate through the AddressBookGroup.entries objects (if that data is meaningful to return here... I don't know if it is).

Mark, do you have a recommendation on how deep to go here? What's going to be used/needed?
This is what I actually made a change too. Notepad++ changed the line endings.
Enabled them again, was some kind of artifact.
`_create()` doesn't accept any parameters, this should just be `this._super()`.
Hi, I think it is safe to say that we can use the BSD licensed IME Mozc. But we still need a definite answer on this from legal.

In the main time, can you guys submit another pull request on `function km_showPendingSymbols(symbols, highlightStart, highlightEnd, highlightState)`, in order to break the blocking on keyboard vs IME? There will be a major refactor of keyboard.js from TF -- IME API will not change (I hope), but before that we need to introduce all changes to IME API in keyboard.js (for them to copy from).
For some reason I don't see the transition happening. Also, I think the original translateY animation would be more suitable.
It might be better to separate this out into another method which is called by showTopSItesTab() and then called again on every keyup. The reason I say this is that there's no need to reset all that CSS every time the user enters a letter.
What if we modified information from the an existing uuid (like surname)? 

Or this PR is just about adding/removing new elements and we will do that in a follow up?
nit: extract in a var to avoid the `.\n`
nit:
```javascript
bcancel.addEventListener('click', function(evt) {
  document.body.removeChild(document.getElementById('confirm-auth'));
  ImageUploader.setStatus(self.name + ' authentication canceled');
});
```
yep. good point to be fixed.
should we disable instead of hide? For Facebook we disable the option is there is no network connection, for instance.
Nice separation of UI and (so to call it) functionality, sir... ;-p Great job! Definitely something to replicate in many other places in the Communications app :-)
Why do we remove `fullscreen-app` here?
That's some ugly wrapping. Why is `key` empty?
This should be using standard for loops, not for...in, same as above
remove Metric suffix.

This will read: Metric.minkowskiIteraableMetric, I prefer Metric to just appear once.
I'm confused as to what the evidence stuff does here. Are you using it at all? Is it needed for the cast?
Erase this argument since you're not using it.
This will display all the statistics also in the frontend, too? Did you also check our statistics module?
Following code should be inside if, because of if the view has been embedded, we will not touch title or metadata.
remove category here, too
?? you dont like the raise Exception for error catching?
One thing that comes to mind, thinking of this, is that if all masters have all schedulers, then I think that all schedulers will typically be running on a single master, rather than distributed across the cluster. I'm not sure if there is a good solution to it, but if it is the case, we should at least document that fact. (That this handles fallover but not load-balancing)
Thanks for catching!
You also need to change the decorator from `deferredGenertor` to `inlineCallbacks` for this to work.
this var will get hosted to the top of the function since JS is function scoped.  You may want to move the declaration up.
moved it into method comment
This generates a lot of noise, saying
```
In scala-refactoring, checking out branch origin/release/scala-ide-2.1.0.m2-2.10.0-RC1
Note: checking out 'origin/release/scala-ide-2.1.0.m2-2.10.0-RC1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name
```

Better add `-q` to make it quiet.
у вас норм Serializers заработали? У меня так и не завелись, поэтому стал использовать jBuilder.
@dubcanada np - i'll do it. i'm working on this mr now
k got it
we're exposing the userid outside of our servers for the first time with the API change.  train-2012.03.28 did not expose it, train-2012.04.11 will expose it in a number of different API calls.  This userid is the same that is in the encrypted cookie, which is the same that is in the database.
whoa!  this is really cool!  contextmanager.  what a neat trick!
reply is a string containing a number > 0, so yep - if (reply) will work well
> For example: variableList, variablesList, variablesTree?

I would say just expand to `variableList`.

> Without style="height: xxxxx" or rows="xxx" <tree> gets collapsed! Try it! :)

In that case please move the style definition out into the css file.
a spaces between `$key` and `$properties`
That's because the Behavior class should have this responsability ;)


2012/7/28 Jérémie Augustin <
reply@reply.github.com
>

> > @@ -746,4 +747,34 @@ public function
> getBehaviorContentBase($contentName, $modifier)
> >              }
> >          }
> >      }
> > +
> > +    /**
> > +     * Use Propel simple templating system to render a PHP file using
> variables
> > +     * passed as arguments. The template file name is relative to the
> behavior's
> > +     * directory name.
> > +     *
> > +     * @param  string $filename
> > +     * @param  array  $vars
> > +     * @param  string $templateDir
> > +     * @return string
> > +     */
> > +    public function renderTemplate($filename, $vars = array(),
> $templateDir = '/templates/')
>
> not realy, a dirty code duplication (copy and past from behavior class)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/propelorm/Propel2/pull/281/files#r1258400
>
This seems like a big problem, as you note.  We should try and get to the bottom of why this happens before we merge this, because it seems like it could cause all sorts of strange failure modes.
Nick, do you think it's worth calling out that the title _must_ be "puppet" ?  This really surprised me, because almost all other resources in Puppet can have user-defined titles.  This cannot.  It's magic.
@daniel-pittman same comment here
If I'm understanding the bug correctly, the problem is that 2nd and later runs base their time off of multiples of the runinterval from the start time. This only checks that the first run is splayed, but not that subsequent runs are still splayed correctly.
why not a doc string? ;)  btw -- should has typo
strlen($this->data[$name]) === 0 is better here than checking for ''.

Why?

php -r 'var_dump('0' == "");'
bool(true)

is technically valid.
About this test I don't know if Zend\Db has planed implement this feature.

@ralphschindler  Can you help us with this?

For the record the issue is wrong and the correct is ZF-10642
Ok, got it, I will update the code and notify you when finished. Thanks !!
This is not a good way to concatenate strings, use StringBuilder instead so you don't create a bunch of unnecessary objects.
Please write some comments, especially regarding system name (suid)
This seems rather convoluted: `if (errno != 0 || *eptr != '\0' || l < 0)` should be enough, right?
have you tried using shorter names? I wonder if what @stof says usually applies here as well
yes works 100% well with this now, and relative include paths allow to install in a subdir
if not key:
why is the vType relevant here?
I disagree. Inlining templates to be used by JavaScript in the HTML page is like inlining the JavaScript itself which we don't do. We also don't inline CSS to be used in the page. We could inline all of these things but we don't because serving assets as separate files allows us HTTP header caching options that differ from the headers sent with the page. Also, commonly used templates served as separate asset files can be served only once and shared by multiple pages rather than downloaded in each page.

I agree manually writing out HTML templates in JavaScript is not particularly pretty and that is why the JavaScript template files explain that these templates should be the results of compiling HTML source files into these JavaScript files. It is not practical for this example to actually require the machinery that does this compiling so I supplied the manually compiled template files instead.
don't pass the connection object if all you need/want is the time zone.
pos -> pat (or pattern)
It does so- the code walks through newargs and copies/expands as necessary into expanded_args. expanded_args is then swapped back into newargs.

I will have a look at this and see if there is any way to make the code more clear, or at least add a comment.
I totally tried using `{% url %}` before and it failed, but it's working now. *shrug*
Why do we need this if we are already setting the cleaned data in users/forms.py?
Odd indent, and tag needs to be outside the `<dt>`.
I'm not sure if running the app against an old schema is a real use case. Is this something you'd actually want to do?
make it `start: function( event, options ) {`
I wish I could say that there wasn't a reason I added that, but there was... in Chrome there were async issues with the paused attribute not being updated before the next `requestAnimationFrame` call was made and the tests wouldn't pass. I agree that the whole thing sucks, but it really happened and it was really frustrating
Instead of initiating a page object kb_article_history, i think it's better if you modify this click_show_history() method so that it returns a page object of the KnowledgeBaseShowHistory type.
This way you can delete the lines:
https://github.com/mozilla/sumo-tests/pull/83/files#L1R214
https://github.com/mozilla/sumo-tests/pull/83/files#L1R217
why are we removing the schema from the repo?
Try use sys.version_info
Use self._marionette
too long method name, try testGetMessage() or something. This kind of text can go in the String param of a particular assertXXX()
Haha. OK. I'll update this.
Yup... it returns `nil` for any `site: ...` cookbooks
这个末尾的逗号还是留着吧，真的是经验之笔
Blank line after this line, please
Woah, what's happening here?
We still need to recache on `popstate`. The cached path here doesn't follow the same `$.pjax` code path, so the page you went back to won't be cached when you leave it.
название файла слабо отражает то, что в нем записано
This is the wrong error. We are checking type compatibility, not the fact it's a computed column.
Which ticket is this?
Currently, yes. The only packages we automatically build are .debs. I want to improve on that later, but for now, supporting only debian at least gets us some testing. This is more about testing the code than the packages, and PuppetDB is more platform-agnostic than Puppet (whose entire point is to do things on varying platforms), so I don't think we lose too much value.
I really don't know what better write there .)
Ah, good catch. Browsers follow the redirect and return the content of that page. In the upcoming PR I'll change it to a 200/401 scenario.
This will need to change for external auths (google, facebook, ..) as well. Should I send users back to / where the UI can do an ajax call to /system/me to determine whether the authentication succeeded? (a query string parameter can be provided if that's deemed useful)
Actually, while writing the doc, I realized ``forceReload()`` better conveys what the method is doing (rather than ``loadFirstTime``). Say something if you disagree ;)
`SocketAttach` is not a class. It is more a convention of the name of an attaching connector, reused by the Eclipse implementation. Great right?
Add figure showing the portlet. Then run the number-images ant target on the chapter. See https://github.com/jhinkey/liferay-docs/blob/master/guidelines/liferay-documentation-tools.markdown#markdown-image-numbers-tool on the number-images target.
Ch. 6 ii
(The text here comes from Ch. 12 in the current UG.)
Missing ';' at the end of this line.
Slechte methode naam. Iets beter is:

```js
this.adjustProjectileAngle();
```

Zowiezo, hoort dit niet in de `Projectile` entity? Waarom zou de `Character` de angle moeten aanpassen?
В данном случае более правильно будет replaceObjectAtIndex:, а не insertObject:.
Я все еще не понимаю насчет категорий. В постановке задаче говориться сделать именно так. Что я не так сделал?
Ну я в любом случае совсем правильно выразился изначально, так что не буду говорить по этому поводу. Скажу лишь, что для того, чтобы запарковать автомобиль, сначала для него место ищется, а уж потом паркуются.
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
why are we git ignoring geoext?
Yes, this in intended. With a single backspace you get an error that `resppshell.ico` couldn't be found. Didn't have the same issue with `res\brackets.ico`.
Using the Array.isArray() method here just for explicitness, as well as the fact that (for whatever ridiculous reason) there's nothing stopping someone from assigning a 'length' property within a plain object.
`disposed` should be set back to `NO` before this.
Hi @gseguin !
Thanks a lot for looking at this!
@ioannagian: And again, you removed the bug fix.
Will do. Good catch.
As I said this was more a sort of hack to quickly see what I wanted and to expose the functionality.
You're right, what you describe is exactly what I see. I was thinking, np.abs should do it but I was wrong.
I will try to cast to i4 before entering the loop, that should do it. 
Thanks!
comment : str
start the property name with lowercase character.
it's better for readability to use the forEach method with arrays rather than for(var i ...) whenever possible. Remove the for loop used here and use:
```
itemsArray.forEach(function(item) { ... });
```
No, that was an accident. I didn't intend for this pull to be merged though, just a general review. @davidascher has suggested merging these kinds of reviews though, since everything is valid comments. I'll remove that though...just need to figure out how. In the meantime, don't merge this ;)
Good catch! Fixed at https://github.com/wluyima/openmrs-core/commit/fd3c52287ac4bfc9b098c4c2b3486070eca1449f
Oh, yeah .. You should be more specific about what you mean, cause at first I had no idea what you were talking about.
I'm not sure what was meant here: who is using the ``requires_channel``? The developer who writes the code (which made me add this comma), or is it the access_control rules? But maybe it does not even matter. What do you think?

If you really want me to remove this comma, how should I do this? Should I add a reverting commit to this pull request? Or make another pull request?
name标签是要翻译的
Why are we even keeping this code here?
Use TestLatch instead
Я как-то с ними себя лучше чувствую. Увереннее что-ли
Пробелы лишние (правда, это неважно, если ты сюда перенесешь определение eventFilter).
link style also can define here
indeed, making it configurable could be the best solution
¿Por qué un struct?
cool use of reject, but why are you rejecting zero?
Unary operator must have a space before and after
NGHUTPR of course but this comment isn't really true. This code makes sense from the standpoint of any instance- it should work for even the basest of the instance base classes.
On the other hand gcr.wire can work for all commands while command.init(..) is specific to each command, and this method is supposed to be generic. The problem is not easily solved now so we'll add a TODO for addressing it later. Dan suggested some refactoring to have a unified mechanism for processing both CacheRpcCommands and non-cache-rpc ReplicableCommands through the InboundInvocationHandler.  This would also have the nice benefit of properly initializing the command before perform().
All the keys may have been local at prepare time but remote at rollback time.
Aha, I changed it to exploded if/else. @danberindei it does not matter 
this much... it should be ok now!
On 12-12-03 12:09 PM, Adrian Nistor wrote:
>
> In core/src/main/java/org/infinispan/distexec/DefaultExecutorService.java:
>
> > @@ -241,7 +249,7 @@ public void shutdown() {
> >     }
> >
> >     protected List<Address> getMembers() {
> > -      return rpc.getTransport().getMembers();
> > +      return rpc!= null? rpc.getTransport().getMembers():Collections.singletonList(getAddress());
>
> I think @danberindei <https://github.com/danberindei> commented about 
> the lack of whitespace between operators and operands. Makes it a bit 
> harder to read.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/infinispan/infinispan/pull/1497/files#r2295054>.
>
Have to manually make the directories as gdc doesn't do it automatically like dmd.
Afaik the guessing order says the "order", see https://github.com/lunetics/LocaleBundle/blob/listener/LocaleGuesser/LocaleGuesserManager.php#L86
There is a tricky one! The ```text.py``` module, which does the same (and is where I stole the idea from) states:

```ACCEPTS: string or anything printable with '%s' conversion.```

How does that sound?
Or brackets. Good thinking.
>As I understand it, this would mean that:
>
>`PathPatch(path, transform=None)`
>and
>`PathPatch(path)`
>have different behaviour.

This is where we need to agree or disagree. Having them behave differently is inconsistent with the rest of the codebase (I think).
oh it's back 
Is this intended?
Should define the html tag type in this xpath as 'Wallpaper' label is very generic and if they change the page we may click on the wrong element.
The test is failing here because in the step above you launch and switch to the Homescreen app frame.

From the homescreen you can't enable WiFi so this step just times out.
We can do that when this method is duplicated in more than one test/app object. Right now there is no real benefit.
Add ```<h2>``` title
Formatting on this is problematic. Please fix.
Can this be done with autoload, or moved down into run_console so we don't pull in irb with every server?
what are ?a and ?b?
@danhammer can we catch the specific `singular matrix` error that this is trying to address? I don't remember how specific the exception type was. If nothing else we can always just revert back to that `singular?` function, no?
If we are going to carry this forward this should be for EC2 only.  Also, why is this in bootstrap_common_debug instead of bootstrap_common?
@bp323 It didn't, thanks for spotting
Opening braces must go to a new line, always
That p_ prefix on method parameters must be removed. Code guidelines in wiki may be outdated.
The new `media` parameter needs to be documented as an optional param. In addition, Google Closure Compiler conventions call for naming optional arguments like `opt_media` to clarify their use. Check out this page for info on how to properly annotate params: https://developers.google.com/closure/compiler/docs/js-for-compiler

I think the right way to annotate this one would be:

    @param {string=} opt_media The media attribute for the stylesheet (optional).
Could you change `escape` to `encodeURIComponent`?
Why are we getting rid of this? It checks to make sure that:-
* When either one of the date fields(to or from) is selected, that its corresponding field is also selected i.e you don't have only one date field value
*  The dates selected are not dates greater than today's date
If you want to catch ANY exception you need to do

catch (Exception $e)

not


catch (Kohana_Exception $e)



On Thu, Nov 29, 2012 at 11:45 PM, Angela Oduor <notifications@github.com>wrote:

> In application/helpers/xml.php:
>
> > +					$node_value = trim($db->escape_str($element-
> >nodeValue));
> > +				}
> > +				else
> > +				{
> > +					return FALSE;
> > +				}
> > +			}
> > +			
> > +			// This is an attribute
> > +			else
> > +			{
> > +				$attribute = $node->getAttribute($tag_name);
> > +				$node_value = trim($db->escape_str($attribute));
> > +			}
> > +		}
> > +		catch (Kohana_Exception $e)
>
> It's basically meant to catch ANY exceptions in general.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ushahidi/Ushahidi_Web/pull/944/files#r2263198>.
>
>



-- 
Robbie Mackay

Software Developer, External Projects
Ushahidi Inc
m: +64 27 576 2243
e: robbie@ushahidi.com
skype: robbie.mackay
Also I think the file should be renamed to UPGRADE to accommodate for any BC breaking changes.
Just curious, is this documented somewhere? Or is it documented somewhere that title indices are "stable" and never change?
check if ($condition) ?!
Nah, I wouldn't worry about a throw - maybe make it log/warn though, so it'll show up yellow
This change removes some unnecessary escape sequences, cleaning up the output.
nit: C# has lambda arg type inference, so you can generally leave off the arg type.
Actually `lib/assets/stylesheets` and `vendor/assets/stylesheets` would work too.
Why was this changed too? Please don't rebase. It means you can't look at how it was before the rebase.
there's also java.lang.UnsupportedOperationException
In the past, we let splunkd be the arbiter of version control (i.e. REST
endpoints would fail if you made a request ti a version of splunk that
didn't support it), and getters would fail with a "no key" exception if the
key did not exist in the data -- and setters would fail when you updated
the server.

One can argue putting version knowledge in the client (i.e. SDK) is the
proper thing to do -- and there is another argument that says it is not.  I
think we should revisit this discussion and at least be consistent. The SDK
was originally intended to support 4.2+ -- and there are not very many
version specific changes across all the dot (minor) releases. 5.0 might be
the exception.

Wim

On Thu, Oct 4, 2012 at 2:31 PM, David Foster <notifications@github.com>wrote:

> In splunk/com/splunk/Index.java:
>
> > @@ -135,6 +158,21 @@ public int getBloomfilterTotalSizeKB() {
> >      }
> >
> >      /**
> > +     * Returns the positive integer of bucketRebuildMemoryHint,
> > +     * or -1 if that field is set to "auto".
> > +     *
> > +     * @return A positive integer, or -1 for "auto".
> > +     */
> > +    public String getBucketRebuildMemoryHint() throws OperationNotSupportedException {
>
> When migrating to use UnsupportedOperationException, please remove the
> throws clauses on the method declarations. UOE is a runtime exception so
> the clauses are not necessary.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/splunk/splunk-sdk-java/pull/12/files#r1767269>.
>
>
Je ne connaissait pas cette technique. Mais tu peux la laisser. Effectivement, quand le répertoire cache n'existe pas, ça pose problème, donc laissons comme ça.
Please use `count()` here. Instead of try/except.
Ok, then I will just leave empty form (additionalInfoForm). And we will choose the right type of field later...
OK, 77 is reaaaaly tooo much. Do 20, more then enough.
Spaces around `(i, contributor)`. :-) You are really out of luck. But it is so hard to make consistent code style?
I'd pass in a hash that gets merged instead. it's not clear what the boolean being passed would change when calling this method
this emty line can be removed
add

case MECHANIC_ROOT:
case MECHANIC_SILENCE:
case MECHANIC_INTERRUPT:
i believe using GetUnitOwner() return the dispelled unit
and here^^
It's not wrong, but it would be very nice if you could use the logger messages embedded in the _Log_ interface?

So here you would have:

    log.redisStopping();

Which allows the internationalization team to translate it or redefine the logging level.
Also here, it would be great if you could use the JBoss Logger recommended approach (although this is not wrong, so it's optional: I could change this later if you prefer).

The approach in this case would be to have somethin like

    throw log.missingPropertiesAtStartup();

Actually now that I read the message, it would be much better for who uses this if you could include an appropriate message in the _checkRequiredSettings_ so that you can actually say what property is missing. I'm pretty sure that will save a lot of time and swearing from who will use this code.
oh... in my environment I needed to add this line in order to complete the spec, so something would be wrong in my env. I will delete this.
Never mind. Figured it out by myself.
for this class these are just blobs (term is used in SerializedBlock), but for users they are 'records'. I will both to records.
Wouldn't it make sense to pass the index itself in, instead of the index-manager? So we don't have do the lookup all the time?
If possible, it would be nice to sort these variables in alphabetical order to improve the mainatianability.
For this a case I don't see much benefit in a regular expression. I find it quicker to read as is.
What do you mean? Think it's all checked for.
Fixed the name, it wasn't actually making a function. Also that code is just moved.
I will be honest, these conditions are confuse to me. For all hour == 12, will it change to 00?

` else if (pm[meridian]) hour = parseInt(hour) + 12;`
If it is meridian and 15PM, will it increment 12?
Customary to use `||` instead of `or` operator here.
All these annotations have been reviewed.  The ones that still say DefaultEventDescriptionBuilder are still being cut over to the correct builder types.
Do we need an else here?  As the logic underneath here will call "regular" DS.
Do we need to check for null here?
Pas sûr du réel bénéfice de cet ajout : les logs sont déjà suffisamment long dans avoir à en ajouter !
With the new changes I made, the argument to the SBProfile draw command must be an ImageView.  The argument to the python draw command is either Image or ImageView.  (It also takes the scale from the image itself, so there is no dx option for the SBProfile draw command anymore.)
Some ideas:
`galsim.GaussianVariate`
`galsim.noise.Gaussian`
This should be updated to `gradlew build`
repo isn't parameterized, just where it gets written to locally
oui mais dans ce cas la tu ne peux pas dire counterpart. Hadopi ne met pas du tout en danger des sites a contenu genere par des utiilisateurs
Tu pourrais ptet faire une partie plus detaillée genre tuto, analyse ligne par ligne du script ou t'expliques bien ce que tu fais. Ca permettrait aussi d'aborder ce que tu as evoqué plus haut :la creation d'un user par tache avec ses privilieges bien delimités. Les mecs avaient bien kiffé ton article DNS la tu pourrais avoir une partie dans le meme esprit.
Should be Apache Cordova. Even Phonegap documentation calls it like that.
“maximun” → “maximum”

“remove one main page or move” → “remove or move one main page”
Is password required? There is no way to have a username without a password?

The log message also looks a bit informal "so defaulting"..
hmm, actually no, it will not be unregistered automatically, which means that your code is not enough as the ApcClassLoader is appended, not prepended so the composer loadr will be used first
There must be a cleaner way to handle this user input. With all of these Skin attributes,
what if we just had a Map<AttributeName,AttributeValue> instead of all these fields? I
picture the number of attributes exploding in size as our page become more complex.
@dzuelke +1
Did you search for all instances of this string and change them if they existed?
Actually i copied that from the mpu6000 driver. I would let it be for now to stay in sync.
This allows your vm to have your host rsa key so you can talk to github / gerrit etc.
It was the hole purpose of sharing .host-ssh into the vm
FIXED :)?
NPE кидать неправильно
А чем этот класс от Closers твоего отличается?
yes, it totally makes sense to me, to use github to store comments and changes.
I was impressed the other week when I listened to a talk given by Dan Yoder, http://fluentconf.com/fluent2012/public/schedule/detail/25798
He suggested storing all client data in gists on github or on similar services and doing all the heavy lifting on the client side, so that projects could be done without expensive server infrastructure. He said, his clients loved the fact that data was stored on github and even considered this a plus.
`newForWindow`, then we check if it's a content or chrome window? Think about a content sidebar, or a jetpack iframe, etc.
Rather than repeat the client constructor, just pass None for consumer_key and consumer_secret if they're not provided:

    consumer_key = user and user.consumer_key or None
    consumer_secret = user and user.consumer_secret or None
    self._client = Client(
        domain=MARKETPLACE_DOMAIN,
        consumer_key=consumer_key,
        consumer_secret=consumer_secret)
This type of syntax would be better for the methods doing typing.
PEP8 issue: base.py:14:1: E302 expected 2 blank lines, found 1
We should add an -init method implementation to the PALManager and move the above initialization code there.
Well actually this was not intended ... I messed things up because I first made the changes in the original repo's clone, then forked and CP'd the file in my forked one ... Don't know why this happened though ...

I close this and make a new pull request
```
this.isOpened() ? this.close() : this.open();
```
I've introduced ``_decision_function`` in order to avoid duplicate ``atleast2d_or_csr`` checks, however, this introduces another function call which might be costly (e.g. if you make predictions on single samples) - should I use a type check instead?