CopiedSpace::tryAllocateOversize assumes system page size
https://bugs.webkit.org/show_bug.cgi?id=80615

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-03-15
Reviewed by Geoffrey Garen.

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateOversize):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::oversizeBlockFor):
* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::create):
* wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Move NotificationContents into Notification
https://bugs.webkit.org/show_bug.cgi?id=80487
<rdar://problem/10965519>

Reviewed by Jian Li.

Source/WebCore:

* notifications/Notification.cpp: Alter signature of constructor to take the fields directly instead of
a NotificationContents instance.
(WebCore::Notification::Notification): Derive KURL from string representation of icon.
(WebCore::Notification::create):
* notifications/Notification.h:
(Notification): Remove contents() accessor and replace with get for title and body. iconURL()
already existed, but use local variable instead of going through NotificationContents.
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):
* notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createNotification): Refactor to use new constructor.
* notifications/NotificationContents.h: Removed.

Remove NotificationContents.h from project files
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Refactor to use accessor methods on Notification.
* src/WebNotification.cpp:
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):

Source/WebKit/mac:

* WebView/WebNotification.mm: Refactor to use accessor methods on Notification.
(-[WebNotification title]):
(-[WebNotification body]):

Source/WebKit/qt:

Refactor to use accessor methods on Notification.
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2:

* UIProcess/Notifications/WebNotificationManagerProxy.cpp: Remove extraneous include.
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Refactor to use accessor methods on Notification.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update the start-queue.sh script to match what we're using on the bots
https://bugs.webkit.org/show_bug.cgi?id=81277

Reviewed by Eric Seidel.

Over time we've added more magic git commands to clean up the local repo after
it has been borked in various ways. The idea behind this sequence is to clear
out any changes in the working copy and then to rebuild the master branch from
origin/master.

This patch also removes the watchdog timer that we've stopped using on the
bots.

This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
Note: Eric and I are experimenting with GitHub to see if it might be
useful for WebKit.  If you have thoughts on this topic, please feel
free to grab Eric or me on #webkit to chat.  I assume that he and I are
the only ones who care about this file so using this alternative
process for this patch shouldn't cause any trouble.

* EWSTools/start-queue.sh:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Change default WebSocket protocol to the latest one
https://bugs.webkit.org/show_bug.cgi?id=73630

Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
Use RFC6455 WebSocket protocol by default.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Selection is not collapsed in some WK2 editing tests
https://bugs.webkit.org/show_bug.cgi?id=69889

Add some expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/mac-wk2/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
https://bugs.webkit.org/show_bug.cgi?id=81107

Add "bool multipleFilesAllowed" to the parameter list of RenderThemeQt::fileListNameForWidth.
This way the base class function is properly overridden.
The need for this change became obvious after r110560 where the OVERRIDE keyword had been
added to the function signature.

Reviewed by Simon Hausmann.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
only some tiles rendered when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=81282
<rdar://problem/11058898>

Reviewed by Andreas Kling.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::rectForTileIndex):
Make sure that the tile cache bounds are scaled accordingly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834

Tools:

Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setValueForUser):
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setValueForUser):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):

LayoutTests:

removed test, no longer needed as test passes and matches baseline expected results and also updated wk2 skipped file to no longer skip this test.

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

* platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed.
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WinCairo] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=81278

Reviewed by Eric Seidel.

Modify the #include declarations for several Cairo-related files
so that the wtf types are included using the full path.

* platform/graphics/FontPlatformData.h:
* platform/graphics/cairo/OwnPtrCairo.h:
* platform/graphics/cairo/RefPtrCairo.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
webgl/context-lost failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=81284

Unreviewed. Adding the failing results to platform/mac.

* platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Added.
* platform/mac/fast/canvas/webgl/context-lost-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Try to fix the Snow Leopard build.

* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::pdfKitBundle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make the array pointer parameters in the Typed Array create() methods const.
https://bugs.webkit.org/show_bug.cgi?id=81147

Patch by David Dorwin <ddorwin@chromium.org> on 2012-03-15
Reviewed by Kenneth Russell.

This allows const arrays to be passed to these methods.
They use PassRefPtr<Subclass> create(), which already has a const parameter.

* wtf/Int16Array.h:
(Int16Array):
(WTF::Int16Array::create):
* wtf/Int32Array.h:
(Int32Array):
(WTF::Int32Array::create):
* wtf/Int8Array.h:
(Int8Array):
(WTF::Int8Array::create):
* wtf/Uint16Array.h:
(Uint16Array):
(WTF::Uint16Array::create):
* wtf/Uint32Array.h:
(Uint32Array):
(WTF::Uint32Array::create):
* wtf/Uint8Array.h:
(Uint8Array):
(WTF::Uint8Array::create):
* wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):
(WTF::Uint8ClampedArray::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Refactoring] Rename StringBuilder variables in MarkupAccumulator.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=81288

Reviewed by Adam Barth.

This is a refactoring for fixing bug 81214. Currently MarkupAccumulator mixes
'out' and 'result' for variable names of StringBuilder. This patch unifies them
to 'result'.

No tests. No change in behavior.

* editing/MarkupAccumulator.cpp: Renamed 'out' to 'result'.
(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes): Renamed 'node' to 'targetNode' for clarification
(and for avoiding style check error in MarkupAccumulator.h).
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):
* editing/MarkupAccumulator.h: Removed redundant variable names.
(MarkupAccumulator):
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/11059777>

Unreviewed skip of flaky test canvas/philip/tests/2d.line.cap.round.html.

* platform/mac/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
webgl/framebuffer-object-attachment failing on lion
https://bugs.webkit.org/show_bug.cgi?id=81290

Unreviewed. Adding the failing results to platform/mac.

* platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Share code in FormAssociatedElement by resetting the form owner whenever insertedIntoTree is called
https://bugs.webkit.org/show_bug.cgi?id=81160

Reviewed by Kent Tamura.

Source/WebCore:

The only difference between the previous insertedIntoTree method and
resetFormOwner was a missing element->inDocument() check in the
former. But that check is actually important, as seen by the included test case.

Test: fast/forms/form-attribute-not-in-document.html

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedIntoTree):

LayoutTests:

* fast/forms/form-attribute-not-in-document-expected.txt: Added.
* fast/forms/form-attribute-not-in-document.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] RateLimiter should hold a reference to its context
https://bugs.webkit.org/show_bug.cgi?id=80761

Reviewed by Stephen White.

* platform/graphics/chromium/RateLimiter.h:
(RateLimiter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
fast/events/pagehide-timeout.html, pageshow-pagehide-on-back-cached-with-frames.html, and
pageshow-pagehide-on-back-cached.html flakey on Lion Intel Debug WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=81291

Skip these tests on mac-wk2 to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
https://bugs.webkit.org/show_bug.cgi?id=81156

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

Creates CCOverdrawMetrics which can be called to inform it about
draws/paints. At the end of the frame, the CCOverdrawMetrics
recordMetrics() method will put its data into histograms, a
TRACE_COUNTER for culling information, and a TRACE_EVENT for details
about the number of opaque/translucent pixels.

Covered by existing tests.

* WebCore.gypi:
* platform/chromium/TraceEvent.h:
(TraceEvent):
(WebCore::TraceEvent::addTraceEvent):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Added.
(WebCore):
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::wedgeProduct):
(WebCore::quadArea):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h: Added.
(WebCore):
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsDrawnOpaque):
(WebCore::CCOverdrawMetrics::pixelsDrawnTranslucent):
(WebCore::CCOverdrawMetrics::pixelsCulled):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(WebCore):
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
https://bugs.webkit.org/show_bug.cgi?id=81293

Reviewed by Adam Barth.

r110595 introduced new format of the author field of ChangeLog entry:
"Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
Updte chanelog.py to support it.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._split_contributor_names):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_authors):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110922 268f45cc-cd09-0410-ab3c-d52691b4dbfc