labofsahil/github-event-dataset-2012 huggingface dataset:
We should preserve the single-arg constructor for backwards compatibility (it's trivial to just make it call this(inputFormatClassName, "")).
let's put those import on the top of the module
you don't neeed to do that . returning keys of watcher.pids is enough.
Well, until yesterday, this is what you were doing. Then you starting putting them in objects, which is even nicer, albeit a little slower. And all of a sudden, you start optimizing for speed while we are attempting to optimize readability, which sounds like a bad idea.
Added a more comprehensive comment explaining the tradeoff.
You can use here `contains` too.
By incomplete you mean that the icon is missing? That will be fixed with Tonys pull request. Have fixed the name of the ui-string.
This code doesn't look like it's ngx specific. Could we share it with mod_pagespeed? TODO perhaps?
Indentation (and fits on one line).
It looks like the last two keyword arguments have been reversed here. Picky: the signature is no longer pep-8 compliant. Need to keep line lengths to 79 characters or less.
I'd really recommend to use the following formatting for things like this one:

```ruby
TIME_IN_SECONDS = {
    :second => 1,
    :minute => 60,
    :hour   => 3600,
    :day    => 86400,
    :week   => 604800,
    :month  => 2629743.83,
    :year   => 31556926
}
```

It results in a smaller indention, makes the code more readable (arguable, but it looks that way to me) and in the future (maybe not in this particular case, but in general) it'll give you a nicer git diff, because if you add/remove values to the hash/array you will only add/remove lines without ever changing existing ones (the first and the last in your case).
How about `tokens_with_placeholders_for`?
Interestingly, running `bundle exec rake update:locales_resources` now outputs a bunch of `plurals.rb` files in each locale resource directory - is this the reason why?
Does this class really belong to `shared` directory? If so, I think it's better to wrap it into `Shared` module as it's done with other classes in this directory. In most cases it's better if modules are nested in the same way as directories are.
I'd rather not obscure the settings import because I think it's better for it to be clear that it's being imported, so a user would have a better chance of finding it and seeing how to change theme colors, etc. `themes/toura` isn't really toura-specific anymore, it just happens to be the name of the theme. 

The 'styles/base' could be removed. But I was thinking that I wanted to encourage users to put styles there, so the root base.scss file doesn't get filled up with styles. I'm on the fence as to whether this is helpful or just getting in the way.
Please use consistent assignment syntax. (Space before and after `=`.)
Are there unit tests for this file?
I think it's useful to have longer variable names, and i'd especially avoid single letter variables
Yep, missed that one.
Was going to ask, out of interest whereabouts, the threshold / "too much" value for the FluxDensity variation interval splitting is set... But then I dug around and found it in `src/OneDimensionalDeviate.cpp`.  It's all personal preference, but I think that as the *.h files are definitely the go-to location for documentation, it might be preferable to define the "magic numbers" there.  How do other people feel about this?
OK, happy to adopt that style!
I think this breakdown is fantastic, thank you Mike.  The fact that the photon shooting through the `OpticalPSF` is so much quicker than the FFT image generation is quite indicative... It means that it's not likely to be the setup that's demanding the time, but rather the `maxK` leading to big arrays for the 2D DFT convolution.  The fact that the OpticalPSF is typically small if we're being realistic (thus large in k space relative to the other PSF profiles) doesn't help!
I don't like the idea of hijacking another request object.

If you put the key/code with the ID in the request object, we could kill off the ID based search when we upgrade, but still have the GetImportedRequest object.
Assuming the `rules_string` variable has been declared, it is more appropriate to use an `if-else` block here as the conditions deal with easy predictions.
Does this template get used for summative, timed exams also? If so, is the pencil still the right icon? What about surveys?

I don't doubt that you know much better than me how the look and feel should be, but I can imagine this template being used for a bunch of different cases, and I want to be sure pencil is right for all of them.
I can't see an @\AfterTest method (or whatever) to shutdown the execution manager, and thus its thread pool.
use `options[:profile]` here, avoid creating another variable.
There's an aspect of this test which is a bit confusing: `owner.item` returns one item, so `owner.should have(1).item` looks like it may be using that method (but simply wrapping it with `Array()` or whatever).  I assume `owner.items` has 1 thing in it, but the context isn't shown in the diff.

Maybe you could make `owner.item` raise an error to demonstrate that it's not being called?
Please move this to webinos/test/policy
Moved SignalR specific usings after system usings
I'd prefer the type-prefixes from Bitcoin's coding style not to be used in the setting-names, but that's a detail :)
i think Commentable carries some factored out code that will work for anything that is a comment
For info some people already dislike that on top of the file ;)
Should be a blank line before this doc block.
> the flagrant offenders being the second and fourth lines.

Yeah, unfortunately `MacOS.snow_leopard?` was historically defined as `MACOS_VERSION >= 10.6` which is a total misnomer. Unfortunately, it is probably too late to correct this behavior.
I agree -- OK to create this is an issue for a future pull request?
Maybe something like this:

```ruby
class SyntaxErrorUtil < Struct.new(:exception)

  REGEX = /\A(.*):(\d*): (.*)$/

  def matches?
    exception.is_a?(SyntaxError) && exception.to_s =~ REGEX
  end

  # ...

end
```
I wrote that, and I'm on the FIG so I'm ok with the content. There are no other PSRs at the moment, so there is no confusion by the meaning. Also, none of the others could be considered style guides so I dont think that would cause confusion.

Maybe *"PSRs 0 to 2 each add on to the recommendation before it"* would cover all the bases?
Опять же случай с пробелами перед и после ==
Это не очень хорошо читается.

```javascript
var filterResult = this.items.filter(function (event) {
    return event.participants.indexOf(partName) !== -1; 
});

tempCollection = new Collection(filterResult);
```
Должно быть MembersToBind.GETTERS_AND_SETTERS
Нет, семантика null - это закрытие стрима. Т.е. надо завершать приложение. Это происходит по нажатию на Ctrl + D в линуксе.
the annoying %1$s stuff again... I think you missed it last time.
I'm not sure about using `valueFn` here, but in a plugin we don't have `HTML_PARSER` so this was close enough. @lsmith said on #yui that the idea is to touch the DOM as little as possible.
Is it ok to go through this path? If it's not, but we do, use `todo()` instead of `info()`.
Looks like in this case `hud`, `SEC`, etc. would be leaked to the global scope in this case.
if Groonga["terms"] は一段外(もしtermsテーブルがあったら、Groonga::Schema.define を行う)で括った方が良いんじゃないかと思ったのですが、どうですかねぃ。
モックとして振る舞う@Simple@ドメインクラスになっています。
↓
@Simple@ドメインクラスとして振る舞うモックを宣言しています。

逆な気がします。「〜を宣言しています。」は意訳です。
原文でも@....@は使ってないけど、漏れてるだけな気がしている
no there's no -dev package (yet). and there isn't much that's duplicated except for headers.
atomics is something that cannot be shared with xbmc (cause that will defeat the purpose of it), so the one method we need from it that used to be part of libhts was copied.
it think you better return NULL if the connection dropped, so demux stops
Add a parrameter $catchhidden, true or false?
And let that one decide weather to catch doted files or not.
``skimage.img_as_float``
What do you think about adding a temporary warning here to note the changed behavior? It's possible someone may have relied on the error. I'm fine either way.
Minor important, but selem_num should be enough here?
I rewrote the whole thing in python. The only real difference from the original is the method for redistributing the clipped histogram.  I think it is fast enough as is, but I can profile/push to cython if desired.
Done  in 44e32a4.
the `max_n is None` case should also be handled here if I am not mistaken.
They are suboptimal.
I don't really like the whitespace between '.' and 'fit'. Is this PEP8? :)
maybe low memory computers?
Ok forget what I said. I was thinking about multinomial logistic regression but this is some weird 1 vs rest binary logistic regression... supid me.
you can use sklearn.utils.shuffle here.
In PCA, a related attribute is `components_`.
Hi Jonathan,

I thought logistic was being used with corrLDA based on this function. Is
that not the case?

Thanks.

double dv_update(SEXP annotations, int dd,
 double beta_z, double var,
 int nw, int method, int logistic) {
  if (method == sLDA) {
    return beta_z / nw;
  } else if (method == corrLDA) {
    if (logistic) {
      double x_d = LOGICAL(annotations)[dd] * 2 - 1;
      return 1.0 / (1.0 + exp(-x_d * beta_z)) / nw;
    } else {
      double x_d = REAL(annotations)[dd];
      return exp(-(x_d - beta_z) * (x_d - beta_z) / (2 * var)) / nw;
    }
  } else if (method == prodLDA) {
    error("Not implemented.");
  }
}

On Wed, Dec 19, 2012 at 9:57 PM, Jonathan Chang <notifications@github.com>wrote:

> In src/gibbs.c:
>
> >        error("method must be between 1 and 3.");
> >      }
> > -
> > -    dv = (double *)R_alloc(nd, sizeof(double));
> > +	if (method==sLDA && logistic){
>
> Can logistic be used with anything other than sLDA?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/slycoder/R-lda-deprecated/pull/1/files#r2473629>.
>
>
Please make it a positive list
`#if linux || __sun&&__SVR4`.
umm so what's the situation? are you waiting for me to do something?
Not sure why this was moved it's the same type of method, it doesn't take a TiObject* as param like the others.  No need to revert though.
Still need to unwrap all the arguments from V8::Local<V8::Value>, regular sprintf requires to allocate buffers and Qt implementation of sprintf is safe.

So i don't think it's simpler to go with regular sprintf
Is this the correct naming?  I would think it more correct to be isInitialized, but english is not my first language.  The current just sounds funny to me but i may be wrong.
well, for example, how does debian allow you to specify bonding modes?
active-active, LACP, active passive? that's done in the bonding_opts
parameter in rhel.. if we don't feed it the info we need, we don't have a
bond that works.



On Tue, Dec 11, 2012 at 4:53 PM, Adrien Thebo <notifications@github.com>wrote:

> In manifests/bond.pp:
>
> > @@ -21,12 +21,13 @@
> >  #
> >  define network::bond(
> >    $slaves,
> > -  $ensure    = present,
> > -  $ipaddress = undef,
> > -  $netmask   = undef,
> > -  $method    = undef,
> > -  $family    = undef,
> > -  $onboot    = undef,
> > +  $ensure       = present,
> > +  $ipaddress    = undef,
> > +  $netmask      = undef,
> > +  $method       = undef,
> > +  $family       = undef,
> > +  $onboot       = undef,
> > +  $bonding_opts = undef,
>
> This is definitely a needed feature but it's redhat specific; would it
> make sense to be able to specify the most common parameters for bonding,
> and then let the debian and redhat bonding interfaces sort out how to apply
> that?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/adrienthebo/puppet-network/pull/17/files#r2386266>.
>
>
`Applicative` will give you a more concise way to write this:

```haskell
instance Arbitrary Bullet where
  arbitrary = Bullet <$> arbitrary <*> arbitrary
```
Sure, I just wasn't sure how injection works with the new service manager component.
I thought numRows() was 64bit actually, until I checked a moment ago.
Ok, now it makes sense.

About workunit, later in the same function there's this code:

    if (port)
      roxieServer.setown(createRoxieSocketListener(port, numThreads, listenQueue, suspended));
    else
      roxieServer.setown(createRoxieWorkUnitListener(numThreads, suspended));

Which means, if port is zero, it's a workunit load. But ```runOnce``` is defined as:

    runOnce = globals->getPropInt("port", 0) == 0;

So, I thought that ```runOnce``` actually meant workunit load. Now it looks like it means either standalone or workunit, if it's going to run once. (which is kinda obvious). 

So, just testing for ```runOnce``` should be enough. No?
renaming to follow standard
We should be using a non-zero value for the exception code.  Possibly it should also be using createOutOfMemException() or a more general variant.  For instance calling checked_malloc().

Strictly speaking the format specifier should be %d not %ld (since it isn't a long variable).  However, the variables also should be size32_t, rather than ints.....  very old code.
pedantically, should link before appending.
Right, sorry for false alarm.
comment needed.
Still something I need to change here?
This seems a bit overly complicated. You can just do:
`if (hashString.match(dateRangeTypeValPattern)) { ...`
I think there was a rebasing problem here, this function doesn't exist anymore in master.
I think you're right.  Previously I consider the nova-common.postinst script has done this task for the default state_dir, so I just to manage the state_path if is not the default value. Always  managing the state dir is a better idea.
En effet, en plus je me rappelle que ça me piquait un peu mais j'ai pas corrigé non plus.
I suggest `_really__traverse_command_without_joking_at_all` ;)
Well, I *really* suggest `index_and_traverse_command`.
really?? that is bad/bug... I will try to give a shout and figure out later on today then
this would be easier to read if condition was other way round:

```js
if (uri && styleSheetService.sheetRegistered(uri, styleSheetService.USER_SHEET))
  styleSheetService.unregisterSheet(uri, styleSheetService.USER_SHEET);
```

Also you could `null`-ify `this._registeredStyleURI` regardless of the conditional, in fact it's more logical to have
it set to `null` after this function is executed.
Like the comment about about reading, we must not allow a user to write a raw GC pointer into GC memory.
Why did you put this here?
Why are you catching the null pointer and why are you not throwing it?
is this a drop down? If so please rename selectDropdownValue or just selectValue rather than combo.
Same as above (`hasattr`?).
A problem with this implementation (`__call__` instead of `forward`) is that you can no longer forward warp an image. At the moment you would have to call `warp(image, tform.__call__)` which is not really obvious in my opinion.
You didn't write the test so I'd feel bad holding up the PR, but yeah there's some other weaknesses here too which could be addressed.

For now, just check the structure of volume and ips to make sure it matches what you expect. Expect the volumes to be there; if it becomes a problem in the future we can consider making those assertions conditional (this is a guess but I think all of the tests we have which create malformed instances clean up the instances before they're finished). Also if you could test the values using a regex for just the new stuff you added it'd be a great start for reforming the rest of the test.
@tfili can you review you this?
Also do we have an explicit object with just `width` and `height` properties?  Or maybe a `Cartesian2` will do.  For performance, we are moving away from object literals as beautiful as they are.
This, `executeCommands`, and `Scene` in general are much cleaner now.  Get the organization right, and see how simple - err, well, reasonabe - the logic becomes?
The screen shot of my notes didn't inspire you - https://groups.google.com/forum/#!topic/cesium-dev/30RpYJHdGLA ?!?!?!

lol :)
Should use a series of enumerated constants (possibly from a protocol definition file) instead of magic words. Will keep things simpler. Note that in cases like this, we may want to be using the identify (`===`) operator instead of equality (`==`) although I'm unsure if there would be any valid type coercion to produce these string results.
In my testing, child views added to a search bar didn't appear on iOS.
Given that getInstance() is going to fail with an exception only once, I'd suggest the following:
try {
cookieManager = CookieManager.getInstance();
} catch(IllegalStateException e) {
cookieManager = CookieSyncManager.createInstance(proxy.getTiContext().getTiApp());
}
Addressed in next update.
Both len and i should be initialized above where the variables are declared.
Does it make sense to follow the Dart style guide (even though this isn't Dart) and put spaces around the "*" operator?
Well, yes, though I actually need to learn how to use travis. Changes those two lines is not a big deal.
These translations need to be fixed the same way
This should be `if(isInputRange!R && (isUniformRNG!Random || is(Random == void))`. Right now, it's failing to test the first template parameter.
Don't use a ddoc comment if it's not supposed to end up in the documentation. Use a regular comment.
I'm trying to avoid any significant interface changes for now. I just want to get the module into a workable state. I'm thinking interface changes can wait until when the module goes through the review process.
It's a bug. It's exactly the one I came asking about above.

http://d.puremagic.com/issues/show_bug.cgi?id=8847
not sure if there's a better way to check if a folder is empty, but this works
I'd be really inclined to wrap this in a `try` block, too. If this throws an NPE or something on a background thread, sadness will ensue.
The default styling on the label is to be block, which ends up taking too much space.  We can set the ".label" style to be inline, but this may cause cascading issues in other locations.  Frankly this is an annoying part of the CSS cleanup that needs to occur.
At least the error needs to be logged, will tell the developer sooner that they need to install GM :)
You are right the "Empty" is not needed, I put it because I also modified the if condition and I made a mistake.

The previous if condition was true just when the field was empty string (or none if nullable field), therefore it wouldn't update any field unless it was empty (or null).

The fb_update_required is not used in this function, but this function get called when the fb_update_required of the User object is set to True (and also in user registration). I didn't modify that, but it starts in lines 76-80 in connect.py and follows through _login_user and _connect_user functions until _update_user function.

The other thing I modifiy was a new setting flag which force the auth backend to set True the fb_update_required attribute of returned User object. This setting flag is False by default. I also modified the authbackend to use this flag.
Eh ... will fail if `$this->ar_select[0]` has NULL values:

	mysql> DESCRIBE `test`;
	+-------+--------------+------+-----+---------+----------------+
	| Field | Type         | Null | Key | Default | Extra          |
	+-------+--------------+------+-----+---------+----------------+
	| id    | int(11)      | NO   | PRI | NULL    | auto_increment |
	| test  | varchar(128) | YES  |     | dummy   |                |
	+-------+--------------+------+-----+---------+----------------+
	2 rows in set (0.01 sec)
	
	mysql> SELECT * FROM `test`;
	+----+-------+
	| id | test  |
	+----+-------+
	|  1 | test1 |
	|  2 | test2 |
	|  3 | NULL  |
	+----+-------+
	3 rows in set (0.00 sec)
	
	mysql> SELECT COUNT(*) FROM `test`;
	+----------+
	| COUNT(*) |
	+----------+
	|        3 |
	+----------+
	1 row in set (0.00 sec)
	
	mysql> SELECT COUNT(`test`) FROM `test`;
	+---------------+
	| COUNT(`test`) |
	+---------------+
	|             2 |
	+---------------+
	1 row in set (0.00 sec)

What's the purpose of this anyway?
this would mean i need to write a lot more code into the tests .. its fine like it is.
this should be removed as there is no such file anymore in your PR
should be flagged for translation?
This seems backwards?   Why remove default for Dell?
you should use ``defaultTrue()`` and ``defaultFalse()``
It's mainly because I'm still stuck on Symfony 2.0.X (I'm using trunk of that branch).
Unfortunately, I can't move for now. But if @schmittjoh creates a branch I can easily provide the update for 2.1, which is probably compatible with Symfony 2.1. =)

Mainly it requires a use change and the method change (from getEntityManagerForClass to getManagerForClass).
I think it's a good starting point at least.
Є
Can't we use the following:

```javascript
$(topnavToggle).toggleClass('inserter_toggle_active');
```

http://api.jquery.com/toggleClass/
http://jsfiddle.net/75JWK/
Delete the declaration of DEFAULT_EDITOR as well
"id" is actually the beginning of the explanation of what widgetid is. I've added some more spaces to make that clearer.
Should this be `$rootel.on` instead of `$(window).on`?
Commit 17fcbf4 adds the documentation.
Hmm.. @olegz , your view on it?
Where was here? Please comment your code.
This indentation is strange. Do like:

```
$.getJSON($.datastream.defaults.url, function (data) {
    callback(data.objects);
});
```
Group your vars together, e.g. separate with commas instead of using the var keyword multiple times. It's a holdover from the web where typing multiple vars takes up more code space.
should it go in 1 line instead?
break long run of commands into smaller private methods
it is easy to understand, modify, maintain, why should we delete it so?
відступи
Don't messages also have a unique attribute "created"? I'd prefer using that, since the actual message text is not guaranteed to be unique, which might mess up the logic here in those cases.
I prefer help to be all peer-to-peer community based, and bugs to be yours and my responsibility... i barely have enough time now to release the app :(
we should put the row back on the import-data-list class, it is used so that the datum's grammatical judgement line up etc. (the formatting is currently broken because the updatingcollection view isnt using our clases, but thats a seperate bug)...
`actor_role_in_actee_org` is the top-level check method which is used by the role(s) and is called like any other check method as part of the ACL verification. 

Every other check method in the module is added (by the decorator) to ORGROLE_CHECKS which is a mapping from the type being checked to the check function. The short of it is, that `actor_role_in_actee_org` is called for every type and dispatches the actual checking to the other methods that are type-specific. If there are no type specific checks, it looks for an `organization` attribute. In any other case it raises an InvalidActeeTypeException.
> That's why I created the subpackage to be future proof.

That does not sound very agile? ;-)

+1 for _org.hibernate.search.indexing.interceptor_ I think that will allow for some nice package refactoring further down the track
dflist is the cached files right?

what happens, then if it gets to here, because it failed to lock all above, and has called all actio.retry()'s
and there is a file in the cache, which another process also wants? i.e. both have in cache, both have read locks to it..
Are you saying that can't happen anymore?
`TestCase` has `assertIn` and `assertNotIn` methods that give better error messages than these. I'm going to switch these to use those when I merge this.
cant we control that via the server process?

On Tue, Jul 24, 2012 at 8:53 AM, Peter Grman
<reply@reply.github.com>
wrote:
>> + * ownership. The AASTI licenses this file to you under the Apache License,
>> + * Version 2.0 (the "License"); you may not use this file except in compliance
>> + * with the License. You may obtain a copy of the License at
>> + *
>> + *     http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +
>> +package org.openengsb.domain.requirement;
>> +
>> +public enum Status {
>
> the more i think about, the more i tend to say - not really, but i need somehow to define what users can do with it - if it's a "normal" workflow i know (from WF - only one user can access the object at one time)
>
> on the other hand we could also have just a list of who approved it already and once it's aproved by som person or by some number of people it is finished.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-domain-requirement/pull/1/files#r1222567
I think usage of __FUNCTION__ is overcomplicating here, particularly as the docs are supposed to illustrate examples. Can you just use "udpateCMSFields"?
Change from number to employee_id
Does this method just look for model-entries with the same keyname?
So...no way to test encryption when running tests?
Can you update the documentation ?
If cmdline.minify defaults to true, then we should have session.minify defaults to true... this logic is easier to follow
what about child type of the collection type ?
It was the idea of a test that spanned multiple modules. I'm not sure the terminology is correct, but I wanted to see that everything worked with all of the modules loaded and working together
糟糕.. 当时没看这么细. 我原来理解是"可以到这边 `git clone` 一份"
我的想法是中文文本里参杂英文体验不太好, 接近代码就尽量用代码替换
glissement sémantique : "build job" => "tâche de build". Si on met seulement "tâche de TU..." on s'éloigne du sujet des jobs Jenkins.