labofsahil/github-event-dataset-2012 huggingface dataset:
Peter,
  Update on this. With more of the refactoring with commands, the command parameter is now required. I created a "NO_OP" command for the "Experimental" menu item.

-----Original Message-----
From: Peter Thiess [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 1:46 PM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> -                        shortcut = keyCmd.replace(/-/g, "+");
> -                    }
> +        if (keyBindings && !command) {
> +            throw new Error("addMenItem(): keyBindings specified but missing command parameter");
> +        }
> +
> +        if (typeof (command) === "string") {
> +            command = CommandManager.get(command);
> +        }
> +        
> +        if (name === "---") {
> +            $menuItem = $("<li><hr class='divider'></li>");
> +        } else {
> +            $menuItem = $("<li><a href='#' id='" + id + "'> <span class='menu-name'>" + name + "</span></a></li>");
> +
> +            if (command) {

To me this looks like a command would be optional. Should that be limited to special menu items like separators?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r871076
Fixed. Earlier they were all top level in the module with the prefix "INSERT_" before each, but I can imagine these constants be used for other actions than insertion like delete or before, so I'll leave them without the vert.

Ty

-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 10:59 AM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> -        "menu-edit-find": Commands.EDIT_FIND,
> -        "menu-edit-find-in-files": Commands.EDIT_FIND_IN_FILES,
> -        "menu-edit-find-next": Commands.EDIT_FIND_NEXT,
> -        "menu-edit-find-previous": Commands.EDIT_FIND_PREVIOUS,
> -        "menu-edit-replace": Commands.EDIT_REPLACE,
> +      * Insertion position constants
> +      * Used by addMenu(), addMenuItem(), and addSubMenu() to
> +      * specify the relative position of a newly created menu object
> +      * @enum {string}
> +      */
> +    var insert = {
> +        BEFORE:  "before",
> +        AFTER:   "after",
> +        FIRST:   "first",
> +        LAST:    "last"
> +    };

I think these should just be top-level constants inside the Menus module, so from outside you can just refer to `Menus.BEFORE` instead of `Menus.insert.BEFORE`.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r869706
The automatic sort is there to sort when an event happens and not when the user decides to sort it by using an option in the menu.

Mi idea of Automatic Sort was mainly for `Sort by Name` and `Sort by Type`. The problem is that if you want the working set always sorted, you need to sort it every time you open/add a new document to the working set. Automatic Sort will solve this. If you activate sort by name and automatic sort and then open/add a new document the working set will be automatically sorted. 

For MRU order it made less sense as the order changes on every selection. Using the `currentDocumentChange` for the automatic sort made it sort the working set on every document selection, which made it feel wrong (the document will go to the top as soon as you click it). But to sort it when a new document is added made some sense as all the new documents will be at the top of the list.

But maybe you just want to sort it once and then reorder the documents or you don't care about new documents that are added to the list. I feel like is better to give the option, than having it always automatically sorted.

If you don't pass any events to `register` the automatic menu item will be disabled. if you pass at leas one, and no function,  the code will just call the sort function from the sort object once the event is triggered. So actually sort by type and name do work with the automatic sort option checked.
prepend() takes a raw HTML string, so you'll need to escape 'query' (see StringUtils.htmlEscape()).  Or you could insert the string using $.text(), which automatically escapes for you (see line above).
No need to go (quite) this low level:
```python
[column.name for column in self.cards.columns]
```

Also, `%s` syntax is deprecated as of python 3.0; use `format()` instead:
```python
raise AttributeError(u'No {0} column found in the table {1}'.format(old_column, table_name)

The overall construct can be simplified, but as it's mostly a stylistic change, I'll address it after the fact.
this should be changed. You're pretty close, but there's a few issues.

$score * 0.1 will work correctly for up to 9 components or properties, 10 or more will yield unexpected results. To be safe: 

instead of multiplying the the position by 0.1, multiple the top part with 10000 or such. 
So this would become $score = 40000 + $position;

Also note that you can reduce:

``
$score = $position;
$score = 4+($score*0.1);
return $score;
``

to:

```
return 4 + $position * 0.1; 
```

And it's still as readable ;)
I have revised your changes, I have slightly edited a commend and now it LGTM. You can merge.
debug ? should be removed !
If you need to return something with a special meaning (which isn't ideal), returning null instead of an empty string would be better.
This comment is obsolete?
I use to define this way if I'm sure that I will not reuse the class (which I won't inside .registration). I know this is not necessary but I find it neat because you know exactly which element is when looking at CSS code. And you can have then a div with same class but other styling.

I think it would be better to define the standard look of forms separately out of the registration class so that's reusable. But I haven't got that project in mind - I just fixed few things I've noticed :)
lol wut.
Why not

togglePreviewButton( butter.project.isSaved ):
toggleSaveState( !butter.project.id );
Yeah, it's always an array; you can verify this by searching for the string `butter.project.data`
ugh, that just broke markup

```javascript
p[ p.muted() ? "unmute" : "mute" ]();
```
Shouldn't this be "stop" to match with above?
`WebmakerNav` should be `_webmakerNav` or something similar.
Ok, I think I get it now. Filing a "profiling" ticket.
That's right, `<script></script>` Github markdown deleted it about
these should be declared outside of for loops/if statements as JavaScript does't have block scope. May as well put at the top of the function.
How about `kAnnotationMinSizePx` at the top of the file?
Sure, should I do the same with sentry/raven?
if we want to only output the body we don't need to expand_layouts at all:

```ruby
@templater.render('{{{content}}}', self.payload)
```
I tossed all of this in favor of a simple `send`. `total` might not respond with a textual description, but it is easy enough to backfill that for compatibility's sake.
这里是有意这么做的，如果更换了so文件，那么需要重启nginx。
原因是这样子的：
reload的时候，我无法卸载老的已经加载的dso模块，因为linux下dloepn打开都是有引用计数的。而不卸载老的加载的模块，就无法强制加载新的dso模块。
不过我确实应该文档里面注明的，明天我会修改下文档。
谢谢！
neat, didn't know about that, thanks
4 times 2 is 8, not 12 though. `span2` means that this element spans 2 columns.
Shouldn't this use `it.step`?
Probably worth filing a bug, but not subject of this PR
Build passed after adding that line, see commit below.
Does the removal return async tasks?  If so, should we be using PulpTaskStatus::wait_for_tasks on line 55?  If no, should we be just returning a 'success/failure' code?
Should the 'data-title' values be translated?  (e.g. here, line 13..etc)
Yeah, I think katello-upgrade is definitely the better place. Please do not move the migration, but only the upgrade logic (I had to read your comment 10 times until I realized you only want to move the upgrade logic and not the migration itself :-)
Did you mean to commit this with the placekitten images?
Good point! I'm short on time for the next couple of days, so feel free to fix directly in master!
the build paths end up in the assertions at multiple occasions. not using DS here result in / in the results.
I have read around that {} was a good convention to use to quickly identify strings vs arrays. Easy enough to set back to [] if preferred.
Two comments:

* We could possibly listen to map events instead of layerstore events.
* The layer name is not an identifier. Why not do ```getLayersBy('id', record.id)```?
Maybe add a comment here to say what it is for
Do we never need the FixedInst anymore?
`Time.stub(:now => 2.years.ago)`
Hmmm... doing it this way looks like it will mean having to special-case the regex validator, since we don't want to be continually re-compile the regular expression when it hasn't changed.

I'll continue to work it through to see what it looks like.
Rich validation must *always* be done on the server. You have zero guarantees that the client actually validated the text all. The worst case scenario is that the client is malicious and is sending intentionally bad data. Client-side validators are simply conveniences that make interactions appear faster to the user.
Rename to `getPropertyValueHTML`?
Nit: for tidiness' sake:

    ret = bson.M{"source": value, "tag:" cs.tag}

then drop the else clause.
Ok!
 I saw that but didn't know how it end up like that. This file was a copy/paste from TfsHelper.Common.cs 
I thought it was like that in the original file
Yea, no problem.  I hit auto-format to fix up my own stuff and it did that.
Yes, something like that - although we should check that the HTML Cython generates is in UTF-8. That's the most logical choice, though.

A bit of digging turns up that the `cast_bytes_py2` is a quirk of distutils - we shouldn't need that for reading the HTML file:

https://github.com/ipython/ipython/pull/1770#discussion_r905178
I have _NOT_ tested this in Windows, so this may, or may not, actually work.
hmm.. thread.sleep?
Try RateLimiter as this is at least easier to test:
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/RateLimiter.html

or retryable predicate...
Performance:  for a multigraph, worst case is E^2 in the number of edges E.  (Consider a multigraph with only two vertices and E edges connecting them.)

Can't we improve this by looking up e in g, verifying that it is in the edge set, and verifying that its source and target are the same (without enumerating all edges between them)?
Not sure about this naming this is what I have been thinking it should be called but my use case is very specific and probably not so much for ICAL as for CALDAV
Oh, sorry I didn't know, I'm developing my first project right now with Laravel. 

If you agree I can change it, but I think is a good pull request anyway since with Response::json method you are removing functionality to the function json_encode.
I don't think so. The Model class, from which Pivot class inherits, handles calls to ``` connection() ``` with the ```__call()``` magic method. So, setting ```static::$connection = $connection;``` above should maintain existing functionality.
Why build the counters on Constructor and not init()?
Make this code run

if __name__ == '__main__':

We can reuse this as a library for other scripts, which can be useful.  Regardless, this is python style.
Seeing `SORT_DOCUMENTS` and `SORTBY_DOCUMENTS` is kind of confusing. What about renaming the latter to `SORTBY_CHOICES`?
I think the aaq url pattern doesn't have a product_key or category_key, so those arguments will always be None. Should we remove them?
Total nit, but the args to equals() are reversed here compared with the other tests.
I'd like to see this actually test the extension of AR & AM if that's what the spec description says it does. Currently this test doesn't do what it says is does.
I may have misunderstood something here but shouldn't the method with the additional parameters be added alongside the old one and have the old be marked as deprecated? Otherwise, why was the change introduced in the first place? Didn't we need it?
The same is true for {prune,include}WhereLastRelationshipIs() below.
Instead of this, you can specify `private $vars = array();`.
.. from the controller in the same way ..
same as above (`Sets` and a dot at the end).
@stof I don't believe the resources node is compiled more than once, because the rendered output is in a loop, but the node compiles to a single variable during the template caching process.
You have a typo (`tthorw`) and we use `"` instead of ``` for variable delimiters (`"%s"` instead of ``%s``)
typo: testClearRemoves...
Could you use a ColumnMap or not?
Refactored. Thanks.
...yes, there is.
This is merged with the latest version.
This looks like the only thing changing from ViewAsPdf. Better to refactor to avoid duplicate code.
While I struggle with the repetition, I can't argue with the clarity. :thumbsup:
We shouldn't require an arbitrary name. If we need a piece of unique data about each check, why not use it's index in the list?
Checking pattern[numpos] == 0 to check for the end of the std::string is undefined behaviour I think.  You probably need (numpos < pattern.size()) instead.
I would rather not upload to a link, this may cause problems when someone will deploy app while upload is in progress.
wow, github really makes you work to find relevant posts!
Ce serait pas mal d'ajouter "gem install git_tracker" également car on s'en sert pour l'intégration Pivotal Tracker.
I find in this file 3 different JQuery definitions: CMS, $ and JQuery. Is there a need for this inconsistency?
This should be 

String clientBindAddress = configuration.getClientBindAddress();

with ProtocolConnectionConfiguration exposing a getter and a setter and the default value for the underlying field set in the constructor using the system property.
I think we still need the "DROP TABLE {table_name};" in order to be able to run different tests using the same dataset (otherwise, after using the dataset table_name once, all other tests that use the same dataset ERROR out since the table_name already exists).
Please fix all the occurences of missing spaces before a '{'
you don't need to put this here if this is only used in `unloadPanel()`
debug should be removed I think
nit: indentation is wrong:

      musicdb.enumerate('metadata.' + option, null, 'nextunique',
                                       TilesView.update.bind(TilesView))
The globals should be removed and their values should be put here.
@albertopq mmm I tried it in firefoxnightly and it worked, take a look to my last commit.

Trying now in otoro.
Some weeks ago it was yes :D
I still think we should not use any class for radio buttons / checkboxes. These are supposed to be **generic**, thus applicable everywhere as long as it’s included in it `<label>` — and when the stylesheet is loaded.
yep, dropped.
btw, is that still related to drawers/sidebars or is it a duplicate of another building block ?
This is not needed. 

I remember spending some time researching if we still need this and concluded that we don't. Especially not if you're using the html5 doctype.
Is this (or the removal of the MAction base class) going to be a problematic API break?
Version and param are optional. Let's see if we can model the media_type/param/format trio that the [API uses](http://developer.github.com/v3/media/) and echoes back. Something like:

``` ruby
def media_type_header(media_type_ish='application/vnd.github.beta+json')
  case media_type_ish
  when String
     media_type_ish
  when Hash
    media_type_ish[:media_type] ||= 'github.beta'
    vendor_header = [media_type_ish[:media_type], media_type_ish[:param], media_type_ish[:format]].compact * '.'
    "application/vnd.#{vendor_header}"
  end
end
```

Or something. It's late down here.
don't put extra spaces around brackets.
This absolutely needs to be simplified for developers.
why remove bin?
I have the same error in my code, probably before the commit I did some changes and then I checked only local_cmd. I didn't test build_job_jar and so I couldn't find the error. I confirm that after + there is ":" + CLASSPATH.
the spacing should be different?
Noted. This will be addressed with the other task of fixing god.
Function is currently used in:

* if announcement doesn't exist or you don't have create/edit rights
* If category doesn't exist or you don't have display/create/edit/admin rights
* If topic doesn't exist or you don't have display/create/edit/moderator rights
* Poll doesn't exist of you don't have rights to vote

There's only one case when better error would be internal error (redirect loop in moved topics, which can only happen if something changes db outside Kunena)...
This line has no effect (never used).
Fine by me. Just saw the delete version at https://github.com/LearnBoost/stylus/blob/master/lib/visitor/compiler.js#L370
Indent this line properly.
`g.BOARD` won't work for inlined cross-board quotes.
Same naming note for `zen_user_status` and `git_ticket_status`
кто это ))
Nah that is overkill really, as the operation is almost identical except the + offset.
That would make it possible to have a log like this:

```
[DT1] The service did not start successfully
[DT2] [TopShelf] Started
```

To me, that's kind of confusing.
It seems that this would have been pulling in everything in app/assets/javascripts/ into the compiled application.js, which is quite a few files: https://github.com/alphagov/frontend/tree/master/app/assets/javascripts is this intended?
Change the type of "state" from String to boolean or Dropwizard's BooleanParam.  Let Jersey coerce to boolean automatically.
Not sure what you mean, the point of sorting is to sort and not preserve the order? Copying the array allows you to keep the old order as well though.
This files have to be installed to /usr/share/qutim, but not /usr/share
Add class "invisible" to CSS and add it to div classes
Default value for issues_enabled (and some other) is TRUE, but if I pass the nil - it will be FALSE. I think this is wrong behavior.

That only solution that I see is use something like this

    project_attrs = {}
    params.each_pair do |k, v|
      if Project.responds_to k.to_sym
        project_attrs[k] = v
      end
    end
    Project.create_by_user(project_attrs, current_user)

What do you think?
Very ugly long line string concatenation ;) not a major issue, but could use a template and .replace() as per:
https://github.com/guardian/frontend/blob/master/common/app/assets/javascripts/modules/adverts/iframeadslot.js#L46
urgh, we really need to fix that global thing
wonder if we should check if the flag is set, think it's okay not to. A sig that has pkt_data but no file_data is not wrong I think
Let's be a little less railsy. :)

```ruby
# Make sure the context has everything we need. Noop: Subclasses can implement.
def validate
end
```

Then we don't need a `respond_to?` check.
That method doesn't exist. Correct would be JFactory::getApplication()->input.
But that's the point, your example is perfectly valid. If you pass an image's data that you can't decode in a valid image, you will get an exception. So there is no error about that. I'm not sure I'm following you. In the way the code is now, we can have:

    clipboard.set("data:text/html,<b>foo</b>");

as well, that is consistent now that we can pass a data URL, that is equivalent to have:

    clipboard.set("<b>foo</b>", "html");

Of course if I have something like:

    cliboard.set("data:buggy-uri");

It will ends to set that data as plain text.

I do not see the advantage to throw an exception for images at this point, if it's throw in any case, and give to us the ability to detect the data type in general.
Of course I could throw the exception only if `aDataType` is equals to "image", but I don't see the point to add another check here and a new exception if this scenario is in any case trapped later.
Does that mean that the workaround implemented in loader.js:freeze() doesn't work and throw?
If you add a pseudo module `@loader` which return loader instance, would it work?
`let program = require('@loader').load(loader, loader.main).exports;`
It is weird. Here we load a new module `require('api-utils/loader')` instead of using the existing one.
Is there any reason to use `\s\S` instead of `.`?
fixed.  see additional commits.
`dir(some_module)` always returns a list of strings. 

One thing we could do is something like `... if not key.startswith(key)`
We only execute cfx in order to check that it's active, and that we can therefore execute other commands.
Please remove the ternary operator here. It makes it kinda hard to read. Also please better align those rows.
Again, this is all just a straight copy from mortar, as I'm assuming it does the right thing for front-end.

That said, I don't mind discussing that here or in the mortar repo.

I agree; this will get hairy fast. @jlongster -- we should maybe have a more "empty" app.js for mortar, yeah?
@zaphod42 We started with that but we need to test the windows functionality via the tests whether we're running on windows or not. Similarly, unix functionality when running tests on windows. The windows tests will break when running on linux because linux's `File::PATH_SEPARATOR` is `:` while causes the windows paths to tokenize as `C`, `\\test1;C`, `\\test2`.

Agreed it is slightly less readable, but affords testing the functionality properly.
extract the 3 parts of the version check if block into separate methods. This will clean up this longer method and make understanding each individual version of upstart easier.

Probably make those 3 methods private.
Sure, we can. But even if we'd have parent  builder, we have to go up to the parent object, get all association reflections and select one, which is related to current (self) object. So I'm not sure is it a good idea to change one-liner for that :) Maybe there's a more simple way that I'm not aware of.

If you insist on that, I'll rewrite it.
define is no longer needed in ycp in SLE11. @mvidner  am I right?
Camel case please. Also, the var docblock can just be ServiceManager since there's a use statement.
The above conditional was a work around for PluginBroker. Not needed with SM support.
The last 4 comments of mine were trying to point it out.. :/
expect we'll add http cache logic by passing response headers & $method to the config arg here.
This section sounds redundant with the "install" section just after, nah?
Jos toimitusvko ( 1 - 51 ) == $di ( 1 - 7 )
If you require Doctrine Common 2.4, you could use ``@Enum`` to validate the content of the array
absolutely right :)

2012/10/1 Jan Urbański <notifications@github.com>

> In libsaas/services/intercom/resource.py:
>
> > +
> > +    def update(self, *args, **kwargs):
> > +        raise base.MethodNotSupported()
> > +
> > +    @base.apimethod
> > +    def get(self, user_id=None, email=None):
> > +        """
> > +        Fetch the object's data.
> > +
> > +        :var user_id: The user_id of the user that should be returned.
> > +            Required if no email.
> > +        :vartype user_id: int
> > +
> > +        :var email: The email of the user that should be returned.
> > +            Required if no user_id.
> > +        :vartype email: int
>
> :vartype email: str right? There's a few more of those below
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ducksboard/libsaas/pull/25/files#r1726789>.
>
>
Please add the `## Examples` header
but yeah, fine :+1:
What argument above ?

The UrlHandler will be replaced by Symfony's URL generator anyway. Adding a todo.
Should it return EMPTY_VALUE if not set?
`callee` is deprecated.

From MDN:

> Note: You should avoid using arguments.callee() and just give every function (expression) a name.

https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Functions_and_function_scope/arguments/callee
Drop line (pep8).
OK, fine. Open a ticket for it, this is not so important imho.

Actually, it might break stuff. 

If you now don't specify an easyblock in a .eb file for a software package that has no dedicated easyblock, it will fall back to Application, so it will try the default configure/make/make install procedure.

If you make this configurable, easyconfig files that do work for us (because we use Application as fallback), may not work for others if they change the fallback class. I don't think we want that. If someone uses an easyconfig file, EasyBuild should use the same build procedure everywhere, regardless of the EasyBuild configuration (save for install dir and stuff like that).
I can do that if you'd like. I can do it on this branch, wait until this is merged or do it on the current master.
This will error if the GET param doesn't equal `bits[1]`, and it's not a search page, with a `TypeError: NoneType object is not scriptable`
`return http.HttpResponse("Not allowed because it's not you")`
...or deleting them?
Nuke this line, and the numTrackEvents var
True, supposed to be called `test_restkin_tracer_server_error_while_connecting`. Will fix it :)
You can't re-define variables inside of a loop.  Initialize `locale` and `countryCode` outside of the loop using the `var` statement.
can you remove the commented code?
Does it mean we need seaparate config files for each type of testrun we have to execute for candidate builds?
There's no need to import the codecs module here, since you're not using it. (`.encode()` and `.decode()` are string properties)
You have to upgrade maven-gwt plugin to 2.5.0-rc1
Do we need this bit of comment anymore given the import speaks for itself?
Wrapped to the same line; intentional?

Also, backticks instead of quotes around "adduser" (same with the second).
...and what about adding an optional array to the function arguments to specify save options?
I mean, if we add to the function declaration this:
..., $saveOptions = array()) { ...
so that the third parameter of imageJPEG could be
(is_array($saveOptions) && is_numeric($saveOptions['jpgQuality'])) ? $saveOptions['jpgQuality']  : default quality
I may change this back. I wasn't happy with the wording on the tooltips, but didn't come up with anything I liked better. I probably should have stuck with the original wording.

Thanks for the feedback.

Sent from my iPhone

On Dec 11, 2012, at 1:22, "Dominique Dumont" <notifications@github.com<mailto:notifications@github.com>> wrote:


In project-view/source/ProjectList.js:

>                       ]},
>                       {kind: "onyx.TooltipDecorator", components: [
>                               {kind: "onyx.IconButton", src: "$project-view//assets/images/project_view_edit.png", onclick: "doScanProject"},
> -                             {kind: "onyx.Tooltip", content: "Scan for Projects..."}
> +                             {kind: "onyx.Tooltip", content: "Import or Scan for Projects..."}


Hmm the idea behind the "import" feature is to be able to import an existing javascript project developed outside of Ares. Which means that the imported project will not have a "project.json" file. Unfortunately, doScanProject will not not import a directory without this file.

On the other hand, doCreateProject will create a project.json file into an existing project. That's why the button attached to doCreateProject was labeled "Create or Import project".

Did I miss something else ?

All the best

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/ares-project/pull/144/files#r2375643>.
I wasn't so sure about this. Restored to default in 9abacd6, thanks!
I don't understand here. The second argument of the table constructor is the columns.
The last assert is failing, due to the fact that it compares a string with an integer:
E       assert u'26,051 users' == 26051
You need to strip the string and return the int from it.
/s/pozitive/positive
Same here. Chekf if max volume has really changed.
this should be @defgroup state_attitude Attitude representations
since that was deleted further up....
Or since you use params below, just name params after `@generateParamsString` `string` or something. You know what I mean.
Instead of reverse merge can you just merge the conditions on top of the hash?
I'm assuming you use a ternary operation to filter out incorrect values like strings etc?
There can be more reasons to check for `canManage` than to just unlock access to content. If we need to check a user's ability to "manage" a piece of content and not just throw an error if they can't (i.e., we want to use the result for business-logic purposes), we'll always have to perform 2 checks (1 for access to see, then one for access to manage) in the consumer of the API, lest we have to sniff out errors in the back-end to determine if it was a "you cannot manage" err, and not a "an error occurred" err. I think if I'm a user of the ContentAPI, this would make things unnecessarily difficult. Maybe a discussion item for the next stand-up.
If we stringify the extra field, then we can just parse it there rather than iterating all keys.
Spacing, should be `if (count($keys) == 1) {`
I'd like to have here, so subclasses may call parent::__constructor() without an error message. This way we might add something to the base constructor later without breaking all the sub classes. Does this make sense?
тут можна ще зменшити кіл-сть аргументів. подумай
Поле Description указано в модели и обрабатывается, однако  не создаётся в seeds.rb по умолчанию.
it's a bit tricky because there are a few things I would want to include ideally. I think the most common use would probably be adding a pathname and query-string via object or string, something like `req.buildUrl('/foo', { sort: 'asc' })`, but even then im not sure it belongs in Express unless we can come up with a better API for a few reasons. one) it looks weird, two) it would require that people do stuff like `res.redirect(req.buildUrl('/path', req.query))` which kinda sucks if they want to retain a query-string
whitespace - please clean up.
avoid in memory queries. This can be done with AR

```ruby
def self.want_update
  where(wants_update: true)
end
```

The advantages are:
  1. Faster in DB
  2. If records grow there is no memory problem in our app - in you example if there were 1M users all would be loaded then reduced.
  3. the result is an ActiveRelation. This behaved like an array but is lazy. So the query is not called until the array is used. Also this allows for chaining. e.g. User.want_update.admins where admins is an query like `def self.admins; where(admin: true); end`

Active Relation is really powerful so I would look into to it a bit more
BTW, you will love ruby:

```ruby
if foo
  # do something
elsif bar
  # do something else
else
  # do something else else
end
I've commented the changes you requested.  Do I need to do another pull request?  Thanks, BIll

On Nov 15, 2012, at 7:43 AM, Andrey Andreev wrote:

> In user_guide_src/source/changelog.rst:
> 
> > @@ -446,6 +446,7 @@ Bug fixes for 3.0
> >  -  Fixed a bug (#1220) - :doc:`Profiler Library <general/profiling>` didn't display information for database objects that are instantiated inside models.
> >  -  Fixed a bug (#1978) - :doc:`Directory Helper <helpers/directory_helper>` function :php:func:`directory_map()`'s return array didn't make a distinction between directories and file indexes when a directory with a numeric name is present.
> >  -  Fixed a bug (#777) - :doc:`Loader Library <libraries/loader>` didn't look for helper extensions in added package paths.
> > +-  Fixed Doc Errors (#17) - :doc:`Javascript Library <libraries/javascript>` Updated document to reflect working code.
> This should be removed.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Да, я знаю, просто сейчас вроде считается, что `x = x + 1` более читабельная конструкция, по крайней мере в мире JavaScript.
This counts equal gens, but we need to count gens that differ.
NSMutableArray возвратит массив, который можно изменить, NSArray - неизменяемый массив.
вообще страшно очень. я бы все-таки еще тогда влепил явное преобразование (unsigned int)(arc4random()%3). как-то так. и да, я читал обьявление arc4random() :)
Why is c_sort_by an instance variable? If it's not dereferenced in any views it should be a local var (no @ sign). Thoughts?
Removed since you already implemented this in your branch.
Yeah, that is a great idea and something I have wanted to do for sometime but never got around to it.
The skip_xhr config is needed to make the XHR (Ajax) calls work to populate
the map with pinpoints. The fall_back sets whether pages without an XML
view will fall back to the HTML view - websites go either way in general,
sometimes they refuse to render content that hasn't been explicitly
formatted for mobile and sometimes they just take you to whatever's
available.

Sameer.

On Sun, Apr 22, 2012 at 2:08 PM, Janis Lee <
reply@reply.github.com
> wrote:

> > @@ -2,6 +2,11 @@ class ApplicationController < ActionController::Base
> >      include SessionsHelper
> >      include Mobylette::RespondToMobileRequests
> >
> > +    mobylette_config do |config|
> > +      config[:fall_back] = false
> > +      config[:skip_xhr_requests] = true
> > +    end
> > +
>
> What does this do?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/agoln/FlashVolunteer/pull/27/files#r718288
>
Much better yes.
I'd think empty would be the simplest way.
Bleh, yeah, I think you're right. Anything else seems way more confusing and error-prone.
This should also check for `NULL`.
Aren't you just doubling the change in the Y position by adding the coordinate difference to the scrollTop difference? Maybe I'm missing something here about the values that are reported.
I know that we've asked people to use BaseModuleActivator instead of ModuleActivator directly, but since I'm particularly pushing to backport this to 1.9.2, I want to be extra careful not to break modules (since no significant testing happens between 1.9.1 and 1.9.2).

I propose that we add a new interface DaemonTokenAwareModuleActivator extends ModuleActivator, with this one method.

Then we have BaseModuleActivator actually implement DaemonTokenAwareModuleActivator, providing a setter but no getter for that property.
Was this auto-reformatted or did you reformat it? If you did reformat, it is not a good idea to do so at the same time as a change to code because it is not obvious to see what changed in the diff.
me too actually. I can change it.
you should mention that the XSD validation is optional (returning ``false`` will disable the XSD validation for this namespace)
这些指令全部是用于覆盖默认值，所以这里没有“默认”的意思，全部都应该去掉。
Yes, that's what I mean, and I totally agree with you.

Look at the tests around there and the caching in
Attachment#instance_read() and Attachment#instance_write(). Somebody
else has a different opinion and I fear there is code out there
relying on this. Until #reload is called, the tests suggest that
@dummy.avatar.updated_at even if @dummy does not respond to
:avatar_updated_at. The tests further suggest that when @dummy.reload
is called, @dummy.avatar.updated_at should stop returning the cached
value. This last part is the one I don't see how to implement. This is
also why I decided it's just unfeasible to support this behavior and
deleted the test. Unless you want to potentially break people relying
on this caching, the best option is probably just to declare #reload
broken wrt to this caching.

On Tue, Jun 12, 2012 at 4:43 PM, Geoffrey Hichborn
<reply@reply.github.com>
wrote:
>> @@ -1090,12 +1090,6 @@ def do_after_all; end
>>        assert_equal now.to_i, @dummy.avatar.updated_at.to_i
>>      end
>>
>> -    should "return nil when reloaded and sent #avatar_updated_at" do
>
> You mean, what if dummy doesn't respond to avatar_updated_at?  It should probably return nil or raise NoMethodError (though I think raising an exception is a little aggressive).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/thoughtbot/paperclip/pull/914/files#r971018
This should most definitely go into test/resources and not main/resources
Похоже, это должна быть const-функция.
Why add these ... and if so - Comment the block
Este link se genera mal. Aparentemente hay que agregar el http:// para que se genere ok.
I think you'll have to clone my fork, then put that in .julia. That's what I'm doing.

 -- John

On Nov 26, 2012, at 11:34 PM, Chris DuBois <notifications@github.com> wrote:

> In src/read.jl:
> 
> > +  end
> > +
> > +  # Count the number of lines we've read
> > +  i = nrows
> > +
> > +  # Iterate over lines
> > +  # If any entries violate type expectations, loosen them
> > +  # Don't change type inference for missing fields
> > +  for line in each_line(f)
> > +    i += 1
> > +    if i >= Inf # Used to be 100. Changed to insure that all files are correctly
> > +      break
> > +    end
> > +    fields = split_delimited_line(chomp(line), delimiter, quotation_symbol)
> > +    for j in 1:ncols
> > +      if !contains(missingness_indicators, fields[j])
> What's the best way to try out the latest in this branch using Pkg? I have been using `curl [url of patch]; git am`, but I am curious how others are doing it.
> …
> —
> Reply to this email directly or view it on GitHub.
> 
>
Would love to see these separated out with a conditional (if input == this do this else do this) rather than returning the whole string each time, but it does work.
please use standards doc blocks
Well, the most useful thing would be to print the offending value or fields
directly, alongside a link to acceptable values.  E.g.

This code is an invalid BodyPosition: dcterms:title "Right upper extremity"
Uric: http://invalid
Dcterms:identifier 123
Sp:system ..

And include a deep link to the value set in our wiki date model page...
On Apr 9, 2012 7:34 AM, "nschwertner" <
reply@reply.github.com>
wrote:

> > +   ?c rdf:type %s .
> > +   ?c sp:code ?uri .
> > +   ?uri rdf:type sp:Code .
> > +   ?uri rdf:type ?code.
> > +   ?uri dcterms:identifier ?identifier .
> > +   ?uri dcterms:title ?title .
> > +   ?uri sp:system ?system .
> > +   FILTER (str(?code) != sp:Code) .
> > +}""" % (get_prefix_defs(prefixes), model, type)
> > +
> > +    # Add the query to the list of queries
> > +    queries.append({
> > +        "type": "match",
> > +        "query": q,
> > +        "description": "Coded values should match constraints",
> > +        "constraints": data[constraint]["oneOf"]
>
> Agreed. Could you provide an example of the output format that you think
> would work better here?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/chb/smart_sample_apps/pull/1/files#r660190
>
long fallback
Valmiin `last`-funktion käyttäminen ei ole OK. Tarkoituksena oli toteuttaa se itse käyttäen rekursiota.
AIT only interrupts the threads, it doesn't report exceptions that happened on those threads.
do we still need to use the deprecated configuration API?
Aha... I see. Ok. No, I think you have used the tag correctly.
Why don't we just say

```
for (size_t i = 0; i < N; ++i)
```

to make it even more obvious there's nothing special about this loop.
I did wonder how things ended up in the gallery. This needs a rethink I guess.
Yep it is, I'll do it as a Pivotal Task
Okay let's get rid of this, the only WMS versions used out there should be 1.1.1 and 1.3.0.
Wondering if we still need this test, and actually `blankImageUrl` altogether.
'tis docstringed already. Github isn't showing enough lines!
Should include other oae- prefixed folders as well.
I added it in when using SparseTagOperation as an example component that worked. When adding the @Reference to repository as Zach suggested and it didn't work, I added that as well as a troubleshooting measure. I didn't take it out simply because it was consistent with SparseTagOperation. I have no problems taking it out, as it indeed does not require immediate activation (nor does it appear that SparseTagOperation does, now that I inspect it closer).
I initially didn't because the jquery docs only mentioned resize(), .bind() and .trigger(), but .on is supposed to be the counter part to trigger() anyway, and .on("resize", ...) works, so I achange I shall.
Also, I think we should add a few more tests to this file:

1. A test that verifies that the code to test for the webkit bug only runs on user agents that claim to have a WebKit engine.
1. A test that exercises the code which tests for the webkit bug (probably with a fake DOM helper) to test that it performs the expected actions.
The test fails even with the new file.

1) Download_Helper_Test::testXMLText
CSV Download failed. Content mismatch
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
     </translation>
+    <translation locale="fr_FR">
+     <translation_title>C2 Translation</translation_title>
+     <translation_description>C2 Translation Description</translation_description>
+    </translation>

@@ @@
  <reports>
-  <report id="9999" approved="1" verified="0" form_name="Default Form" mode="1">
+  <report id="9999" approved="1" verified="0" form_name="Default form" mode="1">

@@ @@
    </report_categories>
+   <custom_fields/>
   </report>
  </reports>
 </

2. 2) Download_Helper_Test::testDownloadCSV
CSV Download failed. Content mismatch
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'"#","FORM #","INCIDENT TITLE","INCIDENT DATE","LOCATION","DESCRIPTION","CATEGORY","LATITUDE","LONGITUDE","FIRST NAME","LAST NAME","EMAIL","APPROVED","VERIFIED"
+'"#","FORM #","INCIDENT TITLE","INCIDENT DATE","LOCATION","DESCRIPTION","CATEGORY","LATITUDE","LONGITUDE","Test Date-1","FIRST NAME","LAST NAME","EMAIL","APPROVED","VERIFIED"
 "9999","1","The Zombie Apocalypse on Facebook ' "" quote &","2012-12-21 00:01:00","El Cerrito, CA","Foodstuffs, come join in on the fun...bring friends with ""like minds"". Snacks will be provided...as they arrive. Dancing optional, shuffling encouraged. Boomsticks and flamethrowers must be checked at the door.  Party kicks off as soon as the Mayan Calendar expires, and rocks until the break of a new dawn.
 
 & ; ' "" <>
 
-http://forum.x-kirov.ru/topic/2383-попала-в-дтп-чудом-осталась-жива","C2,C1","10.311179","-150.27082","","","","YES","NO"
+http://forum.x-kirov.ru/topic/2383-попала-в-дтп-чудом-осталась-жива","C2,C1","10.311179","-150.27082","","","","","YES","NO"
I saw that and wondered whether we should do this up in `__session_truncate` for all cursor types?  You took out the `search` calls from there...
This one is unrelated to JSON, it's because without it I had to keep re-selecting the big JSON as the model to use each time I restarted the console. I checked it in because I thought it would be useful for everyone. Perhaps I should have checked it in separately. the default DB is hsqldb in 'create-drop' mode, I thought it was OK to avoid doing that when 'update' was specified.

Should I take this one out?
asInstanceOf could throw an exception. We rather want the type to return matches=false here I think. At least if there is any possibility for the user to define the $name attribute as attribute and not as tag name.
You're right. I've amended that commit with None checks.
namespace is a required value and should stay there as a hint, maybe add a getter/setter to make it more clear like setUrl
Github/git is getting a little weird on working out line differences
I think this is more informative than "match found"
won't that always return `'identityy'`? if I assume you meant to put `counter()` instead of `'y'`, I'm still not sure I see your reasoning - could you explain a little further?
Stop commenting!
That's intentional. If you look in the old code for the 3 classes, JPathway and JRouter used to return a JError object but JMenu returned null. Without this the CMS installation actually fails to work.

We could deal with this in JApplication of course, I thought this was desirable for B/C but I wouldn't mind changing it.
please also remove the ``liip_imagine.cache.clearer.class`` parameter from this file
I think it's nice to see that something went wrong no?
The yum_repository LWRP is used in the yum::epel recipe. We should probably do this:

```ruby
include_recipe "yum::epel" if node['platform_family'] == 'rhel'
```

Since this would be relevant on other RHEL distros besides centos.
You're going to hate me, but I think we should be consistent with lowerCamelCase, rather than use_underscores :)
@stof: thanks - we should build the coding standard into travis some day :-) one question: what did you mean by "brace"? a space (there is) or a bracket, or what?
Yes. This is the tricky thing because it depends on the maintainer of MongoEngine. I would for multiple global variables here, because there are currently local variables. And it probable "looks" a bit faster to have variables and not dict (probably is not really any difference). But yes, a valid point.

Otherwise, if I would do my own library, a dictionary is probably better. Also because you can extend it from some other module. Hmm. Maybe then go with a dict and have an argument prepared why you are using dict. You can also do:

```
QUERY_TERMS = {"operators" : (tuple), "match_operators": (tuple)}
QUERY_TERMS_ALL = sum(QUERY_TERMS.values(), ())
```

Use tuples instead of lists for constant lists.
Hm, I defined it often as a one big hidden div just before `</body>`. (We will probably not have only this as a fragment in the future.)

Define another Sekizai block at the end, because multiple panels could all want to add something there. So similar to how we handle JavaScript and CSS blocks.

I do not understand what has moving a map with this? You just use fragment of one entry, then you clone it every time, populating it with data from JSON. So yes, in the loop you clone the fragment, populate it, and insert into the list.
So, I think it is normal that Celery does not work if not everything from requirements.txt is installed successfully. So, you should make sure that everything is installed successfully. Have you tried searching the Google how to install those problematic libraries on Windows?
One empty line before this.
http://shrani.si/f/3p/zV/4F3HF7ai/f.png
I thought you meant to replace both with one.
"Google" was good, it is a name. Not "google".
Or `comment_uri`/`comment_url`.
Of course not. Why use JS?

Anyway, you will have to add new context variable in our context processor and construct the filepath in Python. And use that then in template. Read second paragraph:

https://docs.djangoproject.com/en/dev/howto/static-files/#with-a-template-tag
As I mentioned in the task thing, if you have the window set to always on top with the timer bringing it back, then you cannot access the ShellView screen properly - you can move it, you can change which tab it's on, you can even adjust settings, you just can't close it, minimise it or save anything.

If anyone has some thoughts on why that is the case, I'm all ears.
Can it use True/False then? Or something like (moviedata_status != 'N')?
I recommend changing this to be something that implies it's assigned to multiple people so it's not confused with a TaskInstance. Although it is superficial and not necessary if difficult.
Aren't these escapes needed? Otherwise you get a big italicized section rather than two underscores in names.
This should just be ```token``` instead of ```token.getBegin(), token.getEnd()```.
Text noch in strings.xml auslagern
Entfernen wenn nicht mehr benötigt.
Could this use the "pubchemcompound" namespace instead so we avoid colocating the compount and substance identifiers in a single pubchem namespace?
```ruby
@collection.detect {|subscription| subscription.william_id == subscription_id}
```
verify with `is_callable()` here and eventually throw an `InvalidArgumentException`? I think it's better than doing it later.
I apologize on this issue. I knew how important following the code formatting was from another pull request, but the issue occurred again. It won't happen again. I formatted the part and committed as in the commit, [Format white spaces in EntityKey class ](https://github.com/seiyak/hibernate-ogm/commit/bb9876ba4dc3191a1cf15b5b04cb570f3b166c30).
if it failed, chances are that output will be undef, see pf_run's documentation
I think we still need this for some use cases (I know I had some) - or should it be an argument to __init__ ?
This could be a good candidate for HadoopUtils.writeListToConfigAsJson(..)