labofsahil/github-event-dataset-2012 huggingface dataset:
Sweet. Thanks for giving it a look!
Just thinking: why not moving this `foreach` inside the timer callback, right at the beginning?

It wouldn't change much in certain corner cases, in the sense that some libevent resources may be left intact if the event loop sits idle with no timer events being fired, but we wouldn't need to actively add new timers to trigger the cleanup (and putting that at the beginning of the callback avoids the dreaded `Cannot destroy active lambda function` fatal error).
```grains['host']``` comes with ```platform.uname()``` at the top of ```os_data()```
Use unified format for all daemons.
(for performance reasons - sending across 200 people seems like a slow op, and it's probably not what users want)
That's ok, but the criteria should be whether it looks good, how readable is it, not whether it follows any particular style.
and what about LESS ?
the if has three reasons - the comment only lists one :)
Is this still used in the haml?  If not, can we remove it?
From a quick scan of the haml in my branch i don't see any javascript declarations for it.
Actually @halter73 already fixed it.
This will generate Javascript error for current IMEngines.

Let's ignore the double tap functionality if this is an IME keyboard.
@eteq - yes, I didn't realize that these coordinates are not strictly angular coordinates.  The ability to ask for 3-d separations between two coordinate objects means that each coordinate subclass needs to define a (potentially) time dependent reference frame center in some absolute frame.  In other words if you advertise that the Coordinates class supports 3-d coordinates in difference reference frames, then you should provide the machinery to do that right.  Maybe this can be done with a hook for a function that generates the reference frame center?
If you indent, can you use 4 spaces :)?
I don't really like this code as it makes assumptions about the parent object and does explicit casts. Why not use a signal 'verifyMessage(QString addr)'?
arent here still lots of coding standard violations?
unqueriedLayerText: "Diese Ebene unterstützt die Abfrage nicht " +
@sbrunner is there something automatically inserted before "box (WFS GetFeature)." ? What should box/boite mean?
Aligns `=` signs
Sorry, I forgot to remove this code, this was a test. I fixed it and moved this test in AnnotationReaderTest.php instead of AbstractReaderTest.php.
It seems to me you are talking in terms of theory ("a constructor should do X") versus my rather practical argument -- namely, it would complicate the class needlessly because of how *this*  specific class is. I fail to see why on earth would anyone instantiate an object without calling any methods on it. For this edge case you want me to complicate the class? If you insist, I of course will do it -- although I still haven't heard an affirmative "yes the approach is something we can live with".
Jasmine is the tool of choice, but this is where I tend to be a bit lax
too. I think we all need to start doing a lot better with our JS quality
and testing practices (referring to rails devs in general). So, don't take
my comments here to be proof of my mad JS testing skills, just a general
desire to improve them.

On Mon, Mar 12, 2012 at 1:44 AM, jonlemmon <
reply@reply.github.com
> wrote:

> > +
> > +current_user_tags = ""
> > +
> > +$ ->
> > +  group_id = $("#group_id").val()
> > +  $("#users-list").children().each (index, element) =>
> > +    $.ajax(
> > +      url: '/users/' + $(element).attr("id")  + '/user_group_tags.json',
> > +      success: (data, status, o) ->
> > +        current_user_tags = eval(data)
> > +        $("#user-tags-" + $(element).attr("id")).tokenInput(
> > +          "/group/" + group_id + "/group_tags.json"
> > +          prePopulate: current_user_tags, crossDomain: false,
> processPrePopulate: true, preventDuplicates: true, theme: "facebook",
> > +          onAdd: (item)-> $.ajax("/groups/" + group_id +
> "/add_user_tag/" + item.name + "/user/" + $(element).attr("id")),
> > +          onDelete: (item)-> $.ajax("/groups/" + group_id +
> "/delete_user_tag/" + item.name + "/user/" + $(element).attr("id")),
> > +        )
>
> I'm not familiar with writing tests for javascript. Craig, do you have a
> preferred method/testing-framework?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/enspiral/loomio/pull/16/files#r543361
>
Can we do the derived calculation as well here? e.g. add a 'total' element to the dict?
Must have been from some residual changes I had done. I'll remove and rebase.
That never made it into a released version, so it doesn't need a news item
This loop looks a little odd and needs commenting. Also, when possible use Read_U32 etc instead of reading the PSP ram though a pointer like that (for endianness neutrality)
Forgot about that, will fix, thanks.
What's the rationale for the leading underscores on these parameters? Are they supposed to be private? The docstring has them without the leading underscore.
Ah, yes - this was down to me not knowing that this was a fixed API
I guess we couldn't reuse the topic icons that are uploaded and used for desktop templates? If so, we might want to change that again then so that desktop also uses a sprite.
code changed significantly here, but also added error handling for this.
needs adjustment
Was it necessary to change this as well? :) (It's fine, I'm just curious, and I know I do those things too. )
the 'fetch_transform_save_app' imports 'main' from 'generic_app' because it doesn't need its own.   If it were to redefine that function then it makes sense that classes derived from it would also need that redefinition.  It's kind of a poor man's inheritance at the module level.  I'll add comments to explain.
Better still is `contextlib.nested`. You can apply multiple context managers in a single `with`, and you don't get the overbroad application of a decorator.
"content" instead of "contents".
You might want to upgrade this even more soon. When the fix for the dotdict attributeError thing lands.
Okay, we'll leave it like this for now then
@jcredding I'd stick to the pattern and call this `params_value`
Why did you add the first underscore to this variable name?
I added a Gemfile, but likewise, the Gemfile.lock does not belong in the repo.
@Crell when the typehing of the constructor argument 10 lines below shows it is a RequestContext, is it really an issue ? even IDEs are able to use the constructor now.
I think its too useful to hide it. According to RFC 3986 a path may also not start with two slashes. But in real life I've seen such paths in URLs and browser can cope with it. For this reason its not practical to enforce how the path should be supplied in the method.
This looks weird to me as you are storing ``'block'`` or ``'none'`` in it, which are both truthy values.
It should be `0 === $a`.
we declare this on class level normally
This field is not a boolean but an integer.
and the order is wrong: ```@param integer $result``
Why this `!`?
Could you move the function to a static member of FormUtil please? I dislike the duplication of logic here and in FormHelper.

I agree that FormUtil is no perfect destination, but this will become better once we merge the common logic of the rendering helpers (Twig and PHP).
I'm getting the first two comments from the descending list and then reversing it so that the last comment shows up on the bottom.
We could explicitly ignore events on VMs that have been destroyed by checking the 'op' field for 'Del' here
return Box[Int] (can fail)
That wouldn't be a generator. Thoughts?
Im meaning to change that to ocean after it's been finished. It's just a fallback incase no biome can be decided.
"delinated"

what you wrote in README is better
this shoud be with `var` and inside of `(function() { })();` to prevent global namespace pollution
Might as well fill in the master here? Then the user gets that data if they want it and also knows if it was a failure to find the reference or the underlying data.
Peut être ajouter un lien "Vous voulez être sponsor? Contactez nous!"
Change this to a `click_link` or other Capybara DSL other than `visit`.
You shouldn't combine static English text with the i18n output. I've corrected this in a separate commit.
Up to 2.6rem for avoiding the duplicated line
maybe we can have all this code as part of another JS module devoted to MMI
Will ```img.hidden``` cause a reflow like ```display: none```? The current code carefully avoided reflows.
Remove this comment and put the following line back to the row array.
If you keep the /lockscreen/ dir for css, it makes sense to keep it for JS too.
Why do you need try/catch? Can't you simply check for navigator.mozMobileconnection?
I would prefer not to modify the input, because it's part of a Building Block. Probably it's good to 'block' the input while sending, but if while sending we come back to ThreadList and we go to 'new', input is disabled... Could you fix this behaviour?
I guess this has to exist for qDBusRegisterMetaType, but isn't used? Is there any reason to not let it have a proper implementation? It's kind of odd to have it silently always send invalid data.
No true

On 05-12-12 00:17, Arnout Kazemier wrote:
>
> In lib/replace.js:
>
> > +/**
> > + * Replace the variables by the keys in replacements surrounded by brackets in data.
> > + *
> > + * @param {Object} data
> > + * @param {String} type
> > + * @param {Object} replacements
> > + * @api private
> > + */
> > +
> > +module.exports = function replace (data, type, replacements) {
> > +  var literals = replacements[type];
> > +
> > +  // Loop each key replacement combination, wrap in brackets.
> > +  Object.keys(literals).forEach(function loopReplacements (original) {
> > +    data.content = data.content.replace(
> > +        new RegExp('{' + original + '}', 'g')
>
> ye, but you wouldn't need a regexp at all then :p
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/observing/square/pull/49/files#r2314453>.
>
Probably not related to this change but N/A should be in resources.
I would generally prefer string-JSON to BSON for the data in the database.  It makes it easier for human debugging later, and a smoother path to PostgreSQL 9.2 JSON column support.
If you wish to have. Oops. you have closed it? Very well then.
FWIW - it was never intended to be part of the public API - only to support minute(s) and/or second(s).
フィルター

→

    フィルタ
Yeah feels 6 one way, half a dozen another. Case objects are fine.
haha no worries, thanks for the fix
Combine both if blocks into a single if(isGzip) {} else {}
Is this still a TODO item or does the script delete dependency installers now?
Yes, that would work, but why not create and use ->authorise() instead? This is clearly ACL question: can user see this item?
period after sentence
I don't think I understand what you mean by not hard-coding URLs. What exactly is a URL template tag?
You might want to look at using a ModelForm here. It would keep you from duplicating most of this. Also, it's generally best practice to put all of your forms in a `forms.py`file isntead of straight in your views.py
It would be better to return @"Hatena" only. If you wish to translate it (why?) than please use SHKLocalizedString macro and provide some localisation.
Should be `atoum/AtoumBundle` no ?
In many places params is assumed to mostly be read-only.  Why is a copy being made?  There should not be a problem of two VMs sharing the same params instance because, nothing should be modifying it :)  This is why parsed networking info is kept separately in /tmp/address_cache (keyed by vm.instance property).  All else being equal, as long as vm.instance is different, there should be no problem with multiple VMs sharing params b/c they will each get non-conflicting setup in cache.
This would make more sense as

```python
if done:
    s = "built "
else:
   s = "building "
This isn't quite right, is it?  This specifies which codebase (not which changes) the source step should use to select the right source stamp.
well that's awkward.  this file is tabbed, and some of your edits are spaced, some are tabbed.  do we want to always tab so it looks normal?
It’s a pity. I really like Chai and don’t understand why they need to depend on ES5 getters in this point. Isn’t there a backwards-compatible mode? It would be totally easy to make called a normal method if the user wants IE8 back compat.
Hey, by reviewing your codes, I found that win7 or win8 devices support multi-touch.
But i think your codes about dealing with multi-touch is wrong.
You should collect all touch events in one WM_TOUCH event, then invoking 'handleTouchesBegin(numberOfTouches, id array, posX array, posY array);'
Formatting error?
this should also be done before throwing an exception
That was tabs vs. whitespaces. Used tabs in my change.
Thanks Justin - that is the change I was not sure if I could make
Please change it to `#!/usr/bin/env bash` here and other places.
What does this do and why is it not loaded in the same way as the other js?
On Mon, Oct 8, 2012 at 1:31 PM, Victor Julien <notifications@github.com>wrote:

> In src/flow.h:
>
> > @@ -481,6 +481,23 @@ static inline void FlowSetSessionNoApplayerInspectionFlag(Flow *f) {
> >      f->flags |= FLOW_NO_APPLAYER_INSPECTION;
> >  }
> >
> > +#define FlowReference(dst_f_ptr, f) do {            \
> > +        if ((f) != NULL) {                          \
> > +            FlowIncrUsecnt((f));                    \
> > +            *(dst_f_ptr) = f;                       \
> > +        }                                           \
> > +    } while (0)
> > +
> > +/* \todo there is another copy of this same macro inside decode.h.  The reason
>
> is there still?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/127/files#r1782504>.
>
>

No, it's not.  The comment got left over.

-- 
Anoop Saldanha
That's no bad idea. It would make the output more readable. I will add it.
Use e.g. `<code>` to clearly mark filenames.
Basically, I'm not very interested in maintaining those 2 regexs. They are quite complicated and non-intuitive. If the jquery UI developers are interested in maintaining them, I'm happy to use their code. Furthermore, having jquery already in this plugin would clean up other things in the code. If you like, I can look at adapting what you've done here with something I'm more open to maintaining.
Does it? You never say "cars prices".
This sucks, but fine for now, we should find a better pattern for the future though. Maybe submit a bug and comment here that we'll fix it as a part of  Bug XXXX.
Sure it can, I just like grouping things that are related.
needs to check for user_staged also
is a 403 better?  `.forbidden()` ?
Here you want to set the default location, means the profile folder.
why background-image property is used but not just background?
%s/expect/except no?
Everything I deleted, I had checked and ported if it was missing in either the spec or acceptance tests.  If you can positively identify it as "not covered", great, otherwise I did check that. :)
Does this cause problems for anything in Ruby 1.9.3, when it causes UTF-8 tagged strings to be handled?
@MaxMartin doesn't the puppet cert app just use the ruby data structure, not the pson?
Sorry, the merge had a ton of conflicts...I must have messed up on that one.

On Mon, Oct 8, 2012 at 4:36 PM, sbarman <notifications@github.com> wrote:

> In scripts/background/mainpanel.js:
>
> > @@ -741,13 +845,6 @@ var Controller = (function ControllerClosure() {
> >        console.log("saving script");
> >        var events = this.record.getEvents();
> >        this.scriptServer.saveScript(name, events);
> > -    },
> > -    getScript: function(name) {
> > -      console.log("getting script");
> > -      var events = this.scriptServer.getScript(name, this);
> > -    },
> > -    setEvents: function(events) {
> > -      this.record.setEvents(events);
>
> Not sure why these are removed
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sbarman/webscript/pull/1/files#r1790342>.
>
>
Simply find the active ID html element, replace it's inner html with the partial that we would normally render on the index.html.erb, and voila!
+1

The getConsoleUsage() method has 100+ lines too :pensive:
If the options are flat, we can likely just use iterator_to_array.
> Can you do that here too, with the libs?

Sure... 

>Can you add it to our Wiki with a short description? 
>https://github.com/addyosmani/todomvc/wiki/Other-implementations

Sure...

Might be worth thinking to come with an extended version of todomvc, which includes things like auth, registration, user pages, admin pages, and so on...
Since Meteor doesn't have any form of routing built-in, I think it should use our backup solution, Crossroads.js, mentioned in the App Spec. What do you think?
REJECTED.
why do you want this in <a> tag?
@anti Muuttujan settaus kommentoituna? Ok? HIDAS kysely...
? this is weird.
I have mixed feeling about this. I could really go either way. Part me me likes keeping it with the context of the method and another part wants to keep it short and simple.
Nitpick: I <3 vertical whitespace. IMO there should be an empty line above this one.
This is quite a typical way of doing things ATM. As I said, as there is no standard, things can be done in any way, but I think that departing from the common-used approaches is confusing to the user.
Sorry, should have picked this up before - needs to JBoss Server.
Worth explicitly noting that this differs from the root readme?
Will that mess up stuff like anonymous CSRF? Why not use the in-memory cache instead?
I don't see a check for the change of start/end? Why are we hinging on this still?
Hey James, could this be written like this?

    val evictions = for {
      (evictionId, libs) <- libraries.groupBy(_.library.evictionId) if libs.size > 1
      testLib <- libs.find(_.config == IdeaLibrary.TestScope)
    } yield
      testLib -> libs.filterNot(_ == testLib)
:-) I will remove it and highlight it in the mpl pull request for discussion.
I'll fix this later, but double quotes in the future please :P
I don't think the issue is with the query but rather the issue is that we are looping through each one and attempting to create the record again. Each iteration through the do loop and running create again is the time killer. Using group drastically cuts down on the iterations. 

See the difference: 
https://gist.github.com/4019346
i guess you dont need order?
while i understand that you mostly focused on ec2 and other cloud providers, not all fog providers behave in the same way, for example, ovirt https://github.com/fog/fog/blob/master/lib/fog/ovirt/models/compute/server.rb#L118 

I would like to get your code merged in asap, but its not trivial when foreman needs to take care for so many options.
This is a good plan, but the method really belongs in navigation.rb.

Any chance of a patch on a topic branch so I can just merge it straight in (you'll then get authorship in the commit history too)?
You don't need the `+` in here, just use spaces to make it line up.
We don't put extra spaces in our square brackets (so `[OP]`) but we do put extra spaces in our object literals (so `{ "+" ... "+" }`).
only preference
good point, on it
Use the session var $_SESSION['TASK']
It does evaluate left to right, so that says:
if this is NOT an object AND is NOT an instance of CollectionAttributeKey....

if the variable is not an object, then it will always fail because instanceof can only be called on an object

so it will get to the `is_object` check, and if it is not an object then it will stop evaluating and skip to the `else` so, 

if $fak is an object, it skips to the else, if it isn't an object, then instance of will always fail, because instance of can only be run on an object.

thats why I said the `&&` should be `||` or the instance of check should be removed because it that statement, the instanceof will always fail.
``if ( ! $confirmation) {``
I'd avoid passing the config as a constructor parameter. After all it is not a hard dependency.
the usual "standard" for ids and class is to use a dash to separate words (I know there are a lots of exception... :))
you should add the chmod call done by Composer so that the phar is executable. Currently, if you make the phar executable, it will not be executable after the update anymore
these have happened due to the merge conflict!
I know it's nitpicky but I prefer this:

```ruby
tab.templates = %w[all] if tab.templates.empty?
```
Matter of taste again I think.. but I should use 2 words here.
How does this work when we are running with multiple app servers? Do we mount a path on our file storage server on all of the app servers?
It is still working and in use. If you check you will see that there isn't any open pull request.

If you have any issue you can send a pull request and I will be very happy to accept it. As I said, mergulhao's fork is another approach that can be linked here but not in this way.

You can change your PR to add these differences and I totally agree to put it on the Readme.

Thanks for your PR
I'd stick with "templates" or "tmpl". "tmpls" feels a little abbreviated to me.
Dit is zodat de character stopt met de "lopen" animatie? Gaat die animatie ook weer aan als je dan weer begint te lopen?
Curly braces need to be placed on separate lines, like you've done with the `if()`s.
This, plus the following lines can be replaced with:

    return isset($CI->config) : $CI->config->item($item) : FALSE;
я так и подумал что это не отсюда.
Моя вина, невнимательно прочитал сначала. :)

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
в NSIndexSet *indexes хранятся случайные значения индексов. 
Метод enumerateIndexesUsingBlock просто проходит по ним по очереди.

Если распечатать их, то будет следующее:
2012-11-13 11:07:22.244 osx-project-1[30486:303] 13
2012-11-13 11:07:22.244 osx-project-1[30486:303] 19
2012-11-13 11:07:22.245 osx-project-1[30486:303] 21
2012-11-13 11:07:22.245 osx-project-1[30486:303] 22
2012-11-13 11:07:22.246 osx-project-1[30486:303] 25
2012-11-13 11:07:22.246 osx-project-1[30486:303] 47
2012-11-13 11:07:22.247 osx-project-1[30486:303] 49
2012-11-13 11:07:22.247 osx-project-1[30486:303] 71
2012-11-13 11:07:22.247 osx-project-1[30486:303] 87
2012-11-13 11:07:22.248 osx-project-1[30486:303] 95

2012-11-13 11:07:22.248 osx-project-1[30486:303] 1
2012-11-13 11:07:22.249 osx-project-1[30486:303] 6
2012-11-13 11:07:22.250 osx-project-1[30486:303] 9
2012-11-13 11:07:22.250 osx-project-1[30486:303] 11
2012-11-13 11:07:22.251 osx-project-1[30486:303] 32
2012-11-13 11:07:22.251 osx-project-1[30486:303] 44
2012-11-13 11:07:22.251 osx-project-1[30486:303] 47
2012-11-13 11:07:22.252 osx-project-1[30486:303] 55
2012-11-13 11:07:22.252 osx-project-1[30486:303] 63
2012-11-13 11:07:22.253 osx-project-1[30486:303] 69
2012-11-13 11:07:22.253 osx-project-1[30486:303] 76
2012-11-13 11:07:22.254 osx-project-1[30486:303] 78
2012-11-13 11:07:22.254 osx-project-1[30486:303] 79
2012-11-13 11:07:22.255 osx-project-1[30486:303] 92
2012-11-13 11:07:22.255 osx-project-1[30486:303] 93
Good point.  I will update accordingly with something along the lines of:

File.join(Rails.root, 'config', 'user_keys.yml')
Ah, shit. This was left over from trying a bunch of different things when all of this wasn't working.
Is this an abort-worthy error or merely a loggable error?
instance of Raw
I don't follow. What did you want to say here?
would it be possible to use `#find_tool` or `#check_tool` in the utils to make sure this is present before using?
@cordoval --dev is indeed useless here. And to be honest if people rely on that class and it's documented I would say the class should be moved out of the Tests dir into a Test namespace like WebTestCase. Telling people to install the framework from source if they want to test their forms is kind of messed up.
Is this from Diesel? I've never seen `inject_into`, only `inject_into_file`.
JS linting reports: "Bad escapement."

This is probably because of the backslash use. Please check that this line is correct, and make sure that there's a test for it in the  test/jquery.ime.test.js .
will do. coming up in master shortly
I doubt it.  Remember that the font is not monospace, so it would really look like this:

l    l
o  e
o  a
p  d
   e
   r

And anyway, it looks pretty bad even when to do line up.  Why can't we just explain what they are in plain English?
`10.times` no space
把 L17 ~ L19 都 `<!-- -->` 吧，因為照片 imageTile 還沒更新
Yeah, good point, but I could also have named it differently (e.g. create_books_and_characters) and then it would be a bit more obvious. However I guess since things like the scaffolding generator will create one migration per model/table, it makes sense to stick to that pattern.
Yep. The same with `options` [line 18](https://github.com/angular-ui/angular-ui/pull/314/files#L0R18) ?
this doesn't have the version number...  I need to fix L57-59.  it ended up with 2 folders on install if version not specified.

I think it should just use $packageFolder.  I think you define that in chocolatey-nuget.ps1
Not quite sure why it is checking for all the the group only, but yet the line was USER
does the data() get called in the views now?
Ignore it... we might need to validate that in the future. so it won't even get to this step with none.
yup, moved it to StateTransferInterceptor. will update the PR soon.
@Test annotation?
Oh, shoot, you're right, my bad. I'll fix this.
This should be `copy` to indicate that the array won't mutate.
Could you put the `for c` on this line too?
results/* and tests/results/* because git doesn't care about directories, it cares about files
I was wrong here, because initialWidth is the size at the start of the gesture, and aspect ratio is fixed. This will work as intended.
I think we still use python2.6
do you really need to call vec here?
@nicolaasmatthijs We shouldn't be binding an `onClick` handler to the window/document. This is just writing a `live` in a different way.

Can't we change it to something like this:

`$('#contentpermissions_members_autosuggest_cancelbutton').on('click', hideShare);`
or
`$('#contentpermissions_members_autosuggest_container').on('click', '#contentpermissions_members_autosuggest_cancelbutton', hideShare);`

That way the event won't bubble up that much.
@christianv I split this onto 2 lines.
Because the label for the dataset is embedded in the feature file. I'm using the streaming features to extract the labels.
I'm not sure if this can work with php < 5.4
Tohle je spravna pripominka. A je to spatne. Fungovat to bude, ale ne spravne. Musi se osetrit opravdu tri vetve, ja jsem ty dve omylem slil:

pridani na zacatek -> v tom pripade volat replan()
do prostred
na konec -> musim zkontrolovat, ze i==NULL.

Predtim jsem volal replan() vzdy, pak jsem to optimalizoval...
Why is this private but others are protected? Shouldn't these all be private? I think this concerns other entities too.
Whitelist instead of blacklist, that way new actions are secure by default
Could you fix the typo here on connection spelling?
The assignment to ``$cacheKey`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Uh....sorry?
Rather building up this hash, why not just do `@hash = Hash.new([])`?
Your code here is bringing up a good point. I wonder if we should have a separate synonym entry to illustrate the difference between C# user-defined value types and how JS and Dart only have primitive value types?
Vaikka testit toista väittävätkin, ei tämä voi toimia. Joku vertailu joukkojen sisällöllekkin tulisi tehdä. Ei pistettä tästä.
This should be // Replace to fit the check style standard.
Typo: this will complete both `Address` and `Book` but not `Address Book`.
Ouch. Podias corrigir esta linha para ficar correcta (em UTF-8)?
getting "build_prompt:3: command not found: prompt_contextx" error, removing x fixed the problem.
Need to keep laxcomma: true because of the way the build scripts work. i.e:

```
[
        /*>>fontface*/        'fontface'          /*>>fontface*/
        /*>>touch*/           ,'touch'            /*>>touch*/
        /*>>csstransforms3d*/ ,'csstransforms3d'  /*>>csstransforms3d*/
        /*>>generatedcontent*/,'generatedcontent' /*>>generatedcontent*/

    ]
```
Why don't we just delete this now?
(default: https)
Ah. Runnable wouldn't work because it has no return type. And there's no generic Predicate class in the Java standard library.

If there was, I would have recommended:

```
public static boolean assertEventuallyTrue(Predicate predicate);
public static boolean assertEventuallyTrue(Predicate predicate, int tries, int pauseTime);
```

Any other parameters the predicate requires could be passed in by closure.
Indent with spaces. (sorry, I forgot to use 4 spaces here)
I guess you forgot an echo here? ;)
And in map initialization callback you do:

```
$(window).tigger('mapready');
```
Use `ReferenceField`.
Update returns some number. I think it is the number of objects inserted or something like this.
You should probably just remove all this stuff? So, all testing stuff. Now we have a normal way to post comments.
Use tuples.
Yes, good. Please do not translate internal errors. It is much easier to debug like that. :-)
I agree with you, this could very well be an error.
No I was counting on it. I simply didn't have all of your information. :p
If you moved the intersect method to a different class, you may also consider moving the fill up code to its own method for readability.
This is fixed and I added a few more docs.  Would appreciate a second pass through.
Hm, bin auch unschlüssig. Einerseits ist man blöd wenn man Leerzeichen am Anfang oder Schluss verwendet. Andererseits wärs theoretisch ganz in Ordnung und gar nicht ungeschickt.

Ich glaube ich mach das `trim` trotzdem wieder hin :)
guter Einwand. mache den erst im onPostExecute. 
Meine Überlegung war, dass der im UI Thread ausgeführt werden sollte. Oder muss das nicht sein?
please can you make some sort of assertion? e.g. add a proper href to the link and check that current_url does indeed change.
yeah, good idea, fixed.
@oschaaf 
Either fixing the portability issue now or putting in a TODO is fine with me.

Aside from that, LGTM.
If I'm not mistaken... (yay memory management, I may well be wrong!)

This method is an `init` method so it'll get called in the following manner:

	QSObject *myNewObject = [[QSObject alloc] initWithArray:myArray];

now the `alloc` in the above code increases myNewObject's retain count by one. If an `existingObject` is returned, then it already has a retain count of 1 (or more I guess) so it is autoreleased so as to not increase the retain count from the original `alloc` message.

I'm happy to go through and debug the `[object retainCount]` to see what's what. I've made myself think this might not actually be right now...
my guess is copy is redundant here will copy twice: 1 + ... creates new temporary array
Not in "util/time". Keeping unless someone wants to generalize later.
On Oct 3, 2012, at 1:11 PM, rmandelb wrote:
> Hmmm. I see your point about x, but it is pretty standard in papers defining equations for NFW (for example http://adsabs.harvard.edu/abs/2000ApJ...534...34W which is the standard I tend to refer to), and r IS also confusing. Perhaps we can bring in a 3rd person for another opinion? @barnabytprowe ?
> 

I guess we already have a third opinion, being Peter, who wrote the code in the first place.  He apparently preferred x.
should use Float.MAX_VALUE
Removed setting entirely in 2576220.
Don't commit temporary files -- delete this
You should use `material.is_a? Investigation` instead
Mock has a nice helper called `ANY` that can make this prettier:

```python
from mock import ANY

fake.assert_called_once_with('https://unverifier.persona.org/verify', ANY)
```

The following line is harder, though. Perhaps we should add a CONTAINS helper to mock's next release. :P
It would, but it would make most of the listings empty. I have a jira on me to add set up testing data in the test_collections.py tests, and I'll probably do something about it then.
Yes, thanks for catching it. I rephrased that sentence and left that part in :)

The correct sentece is just this: 
>> This method uses the lock service to guard against multiple threads trying to insert the same counter because this service is called asynchronously from the social activity service.


---------------------
Zsolt



On 2012. Apr. 26, at 3:36 AM, James Ross Hinkey wrote:

>> </p>]]></comment>
>> 		<author><![CDATA[Zsolt Berentey]]></author>
>> 		<author><![CDATA[Shuyang Zhou]]></author>
>> 		<method>
>> 			<name>addActivityCounter</name>
>> -			<comment><![CDATA[Adds an activity counter into the database.
>> +			<comment><![CDATA[Adds an activity counter with a default period length.
>> 
>> <p>
>> This method uses the lock service to guard against multiple threads trying to insert the same counter because this service is called asynchronously from the social activity service, this method must , so it is using the lock service for that.
> 
> @zberentey Hi Zsolt, please clarify what is intended by the part of the description that states "..., this method must , ...". It seems as though some text may be missing. thanks.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/zberentey/liferay-portal/pull/55/files#r736579
This will probably seem silly, but for these fields send in `true` or `false` instead of a number. The ActiveRecord class or PHP database extension should be responsible for working out if it needs to be typecast. PostgreSQL for example has actual booleans.
This is genuinely a gawk script, not a bash script, so gawk should be the thing launched at the beginning of the file.
Guard clause
Yeah.  A long time ago in Android you didn't want to use a virtual method, but they fixed that in Froyo.
Сделай здесь вместо new Integer(value) -- использование статического метода Integer.valueOf
У тебя ведь есть ComparatorForStrings. Можно ликвидировать copy-paste.
s/submited_app_names/submitted_app_names, ditto for:

s/submited_apps
docsting - what values are acceptable for <code>premium_app</code>
I was following the suggestions from [here](https://github.com/nelmio/NelmioApiDocBundle/issues/12#issuecomment-5688676)

So... is the issue that you can declare something like:

```
@ApiDoc(
    formType = 'text'
)
```

So this breaks that?
```ruby
require 'chef/version_constraint'

if Chef::VersionConstraint.new("< 11.0.0")
  Chef::Log.warn("...message above...")
end
```
I did not implement the TV filter, so I can't give reference here.
`mean_hidden`
different amount of training samples
I got it for the list comprehension: you need the 'pop'.
_B_oston
@GaelVaroquaux Actually what I want to know is whether we can and will just get a serials of estimators which have ``fit_transform`` pipelined together? I did not make myself clear. Just as we will have a kmeans issue #1157. I would rather love to help add a ```fit_transform``` to kmeans and have a pipelined spectral clustering ( I personally take this as a very cool feature ;) ) though this may not be a qulaified implementation for SpectralClustering estimator.
I did that but got weird results for GMP. I'll investigate..


Le 6 mars 2012  11:06, Jacques-Olivier Lachaud a crit :

>> @@ -70,7 +70,7 @@ inline
>> DGtal::PointVector<dim, TComponent>::PointVector()
>> {
>>   for ( Dimension i = 0; i < dim; ++i )
>> -    myArray[ i ] = 0;
>> +    myArray[ i ] = NumberTraits<TComponent>::zero();
> 
> myArray[ i ] = NumberTraits<TComponent>::ZERO; // faster ?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/DGtal-team/DGtal/pull/293/files#r522346

----------------
David Coeurjolly - Directeur de recherche CNRS
CNRS, LIRIS-UMR 5205
Universit de Lyon
Batiment Nautibus
43 boulevard du 11 novembre 1918, 69622 Villeurbanne cedex, France
Tel : (+33) [0]4.72.44.82.40  Fax : (+33) [0]4.72.43.15.36
http://liris.cnrs.fr/david.coeurjolly
This is the compile as a whole block, but you didn't add this functionality to the next block which is compile separately.  Both should have this capability.  That starts to suggest that the error handling belongs inside execute, but I'm not sure that's the best path either.  Thoughts?
Actually, scratch that, I see that this is for an entity method and the other is for testing a service
Oddly, the test suite passed with `propel/propel`. I suppose that means we really have no Propel test coverage.
Following the pattern from here
https://github.com/Multiverse/Multiverse-Core/blob/master/src/main/java/com/onarandombox/MultiverseCore/utils/PermissionTools.java#L105
Je renommerai "Task" en "Issue" ou "Bug"
Car Task ça fait plus référence à une tâche asynchrone d'Akka (cf. taches/QuiPrend)
do super calls not work here?
" :" > ":"
@hferentschik, I don't want to block the pull because of that; having sync Tika is better than not having it. You think a subsequent improvement could be possible?
I'll add a comment to that effect
That's something different (and you need to worry about underflow when doing that bit).
I've had similar code before, where there's no versioning in the serialized format, where, as you've done, you have to check if there's extra data (remaining()) at end of legacy serialized format. But I've normally had a single deserialize method that has conditional sections based on version, e.g.:

if (0 == msg.remaining()) //legacy
..return;

unsigned version;
msg.deserialize(version);
if (version >= 1)
..msg.deserialize(in, escape);
//e.g.
if (version >= 2)
..msg.deserialize..
I came to the same conclusion when drafting the URI requirement... Since boost is already a dependency, I think we should start moving towards dumping the internal library...
Have you tested this with an LN build? I suspect that removing OSSDIR will either break the build or the installer.
Ops, yes, you're right in both cases. BC won't break, and I don't know why I thought there was an alternative way to setup a listener, so you can get called the method you want for one event (allowing the example I mentioned). 

We can use the same class then for now.
Why `request.REQUEST`?! Above you were using `request.GET`
@peterbe So, earlier I use the response variable for the response from the API call. I suppose I can safely overwrite it here but, would it not be better to rather use a different variable name as I did here?
Oh, and these are not really related to Sql Server 2012 are they? Please create a separate Jira issue for these, to make sure they show up in the release notes. Also, according to the docs datepart and datalength are both supported already in MSSQL 2000 so they should go in that dialect instead.
Found the DOM bug. I cant believe this worked...
@briandk Ah, that makes sense. The partial argument matching feature of R seems bizarre to me.
Why is it necessary to copy the Properties object?
Why "Save B as..."?
this is totally useless. You overwrite the method only to call the parent one.
should this include?

# Managed by RightScale
# DO NOT EDIT BY HAND
Probably better - will change this when the example is updated with another image.
Alright. I think the code was just a little bit too messed up. Here is what I think the callback should look like:

```javascript
callback: function(i) {
    cease = (pages <= i);
    if (cease) {
        // Show the user that we have stopped scrolling on purpose.
        results.show();
    } else {
        $.ajax({
            data:{'page': i + 1},
            dataType: 'html',
            success: function(data) {
                paginator.before($(data));
            }
        });
    }
}
```
I'm not thrilled with throwing the exception here since it will probably leave the `BillboardCollection` in a questionable state, but this is a `DeveloperError` as opposed to a `RuntimeError`, and developers aren't supposed to catch a `DeveloperError`; they're supposed to fix their code.

I'm not sure where else we could throw this exception without it being slow.  We can't do it in `setImageIndex` or `setTextureAtlas` because it could throw depending on the order of calls.  The only alternative is to validate at the start of `update` (like we do in all the other primitives) in a separate loop, but what a waste of CPU cycles.  Ugh.

Oh, we should add the `@exception` to the doc for update.
Like I mentioned earlier, instead of !images, you should be using typeof here.
Not in the generated doc.
This should use `Cartesian3.multiplyComponents` so `position` can be an object literal. Does this method belong here or on `Ellipsoid`?
Remove extra with
iOS also has a meta-color called 'stripped' that, on the iPhone and iPod touch, but NOT on iPads, is the grey pinstriping that lies under grouped table views.
Yes. Without this `#define` check, if an app uses the `Ti.UI.iPad` but not `Ti.UI.iOS` namespace, this code will not be compiled in and there will be a build failure.
Try dropping the parens. They're going away in M1.
I was reading the code again and noticed that the timezone is UTC. So it's good. I'm asking myself now if UTC is the right thing for the URLs or if we should just use settings.TIME_ZONE.
(It's still UTC in the database)
While you're on that, could you rebase against latest upstream/master?
Calling `repository_path` with `@project.repository` rather than `@project`, and only when `@project.repository` exists fixed an error for me when creating the repository for a project.
Let us use `Async.sleep`.
он даже за пределы функции не выходит
True enough, but the problem there is that that `takeExactly` returns `auto`, so looking at the docs for it isn't necessarily going to help much. If it returned a definitive type, it probably would have been listed here rather than saying that it returned the same type that `takeExactly` did.
Huh? `Lines` and `Chunks` have no `opCall`.
I think this looks fine, just remove const.
Obviously, it's personal preference, but with a line this short, I'd favor just making it a single line and save the vertical space. I don't see what the extra line buys you. It's nowhere near the line limit.
See `ForeachType` in `std.traits`; it does the same thing. That line just turns the body into a delegate with an `inout int` parameter.
I wouldn't even bother to define len, but no matter.
... if we rename the file, we should update it here too :)
This is particularly important in light of the comment elsewhere:

```
        // It would be good to set the X-If-Unmodified-Since header to `timestamp`
        // for this PUT to ensure at least some level of transactionality.
        // Unfortunately, the servers don't support it after a wipe right now
        // (bug 693893), so we're going to defer this until bug 692700.
```

We could race generating and uploading keys, and we'd be convinced that we just uploaded some. Leave them non-persisted. `onFreshStart` will restart the session and redownload anyway.
same note as above about caching the reference to a local variable
"until now"  is unusual, either use "up until now", "by now", "yet",....
Should this and line 2906 below be commented out? Or was this for testing?
Unless there's a strong reason for obfuscating using hex codes, please use (I believe) `"\r"` and `"."`.
get it together josh
agreed, shouldn't be there.
Also just realized that doctors may have multiple specialties
It was for BC because before the default was always a string. I personally don't mind..
I don't think this logic is correct. This will flag anyone with a form that is _not_ the TB screening form.
Shouldn't this be "All " + ... ?
is it OK in our PHP syntax guidelines to have an if clause with one statement and no curly braces?
Maybe change this to ``jms_serializer.builder`` to make it a bit shorter, and it should be prototype-scoped.
Can you add a description above to clarify what this array does?
The title of this file should be changed to reflect it was edited by us, like all our other third-party plugin edits
> Should be unnecessary – as far as I recall, all x86_64 CPUs out there implement SSE2.

This is not guaranteed as far as I can gather from Intel manuals and Wikipedia, but in practice, it is true, so let's go with that.

> You might also want to make this a naked function to avoid that DMD emits the EBP saving code.

Done.
Fix all the broken tabs!
LinkedHashSet was Serializable; I guess it's ok we no longer are Serializable, but we should probably remove these transient modifiers.

If you agree, I'll remove them during the merge.
I'm not sure why this abstraction is necessary. It simply wraps BeanFactory methods.
Just replace `${2:hub}.getPatchCord()` by `${2:stream}`
if you don't save the encounter, you can avoid this test.
@seejee: Looks good to me and should make #46 a little easier.
I believe this is a first in RDLI. Kudos to you for updating these good sir.
Check for example Django CMS:

https://github.com/divio/django-cms/blob/develop/runtests.sh
https://github.com/divio/django-cms/tree/develop/tests
don't use space between - and 50px :)
yea, ideally. don't think you need to hold up this pull request for that, however
Good one again, I'll try to see how I can check for the session being destroyed
please change the "" to null, otherwise good to be merged
Ah.  So maybe the bug is that it gets detected as a comsub in the first place?  I'll try and find where/why it happens, but my guess is it has something to do with the way movxmmconst loads values through the gp registers or something like that.  Or possibly there is an exception somewhere for ST but not XMM.
I'll try and do it tonight if I have time, but moving the line back and running the test cases _should_ be enough to reproduce it if you don't want to wait.
I'm not sure what a 'modseq' is, so I just put in 'XXX'. What really goes here?
ditto re type's meaning
OK. Let me be very explicit. What if you're doing CORS and UserAgent is not a valid request header? But User-Agent is? Because you're hard coded to send UserAgent, the request fails.
KrollObject
On 09/27/2012 10:40 AM, mtaylor wrote:
>
> In app/models/image_management/provider_image.rb:
>
> >
> > -    accepts_nested_attributes_for :target_image
> > +    # FIXME Check to see if this is a setting we can add to Rails configuration.
> > +    # i.e. json_include_resource_name = true
>
> Thanks. I'll remove those methods and update the config.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/aeolus-incubator/image-management-engine/pull/20/files#r1704794>. 
>
>
It seems that github does not send a mail when a comment is updated.  In 
case you are following comments in mail I've pasted my updated comment 
below:

Thanks. I'll remove those methods and update the config.


      Comment 2

After a little more consideration, I'm not sure we want to set this in 
the config. The setting is on ActiveRecord::Base and therefore would 
override any settings in the host application. I am going to leave this 
as it is for now and follow this up later with a patch. We could 
implement this using this setting but by either:

  *

    Setting this in the controller using: e.g. user.as_json(root: false)

  *

    Adding another class in the chain that will be used for any
    ActiveRecord settings specific to ImageManagement. For example:

class ImageManagement::Base < ActiveRecord::Base
include_root_in_json = false
end

class ImageManagement::TargetImage < ImageManagement::Base
...

What are your thoughts?
Okay.png
You can override the webplatform.js or the 18n.js by putting it in the root of your framework. From there it is bundled into the root of your application where the platform tag can pick it up.
Can you add the `data["rim:permissions"] = {}; //ensure no run_when_backgrounded permission exists` to this test as well.
disagree, I believe only the dialog needs it. This will probably need to be removed.
Need to delete GLOBAL.window after
We are just doing this until SSLActionReject is changed to do what we want?
I don't know. I haven't touched anything that extension but this test is suddenly broken.
Nothing was really changed in this file. I suggest you to revert the unintentional changes you made here (so that this file is not part of your commit).
How does templating work? Are you introducing additional dependencies?
Tässä vois käyttää edellisen tehtävän `divides?`-funktiota avuksi