[Qt][WK2] New fast/forms/number/number-spinbutton-click-in-iframe.html fails
https://bugs.webkit.org/show_bug.cgi?id=96634

Unreviewed gardening.

* platform/qt-5.0-wk2/Skipped: skip the failing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Gardening after r128375, r128431
https://bugs.webkit.org/show_bug.cgi?id=96630

Unreviewed gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-13

* platform/efl/TestExpectations: Unskip fast/overflow/overflow-height-float-not-removed-crash.html.
* platform/efl/fast/table/height-percent-test-vertical-expected.png: Rebase.
* platform/efl/fast/table/height-percent-test-vertical-expected.txt: Ditto.
* platform/efl/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. Rebase.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=96632

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-13
Reviewed by Carlos Garcia Campos.

Fix this by using atk_object_get_n_accessible_children instead of
calling getChildren() from childCount.

* WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
(WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
loop by using atk_object_get_n_accessible_children().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: NMI: instrument KURL directly.
https://bugs.webkit.org/show_bug.cgi?id=96624

Reviewed by Yury Semikhatsky.

I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
CString* were also instrumented.

Drive by fix: Instrumentation code in QualifiedName was moved to cpp.

Source/WebCore:

* bindings/v8/V8DOMMap.h:
* dom/Attribute.h:
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/QualifiedName.h:
(QualifiedNameImpl):
(QualifiedName):
* dom/WebCoreMemoryInstrumentation.cpp:
* dom/WebCoreMemoryInstrumentation.h:
(WebCore):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
(WebCore):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
* platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore):
(InstrumentedOwner):
(WebCore::InstrumentedOwner::InstrumentedOwner):
(WebCore::InstrumentedOwner::reportMemoryUsage):
(WebCore::TEST):

Source/WTF:

* wtf/text/CString.h:
(CStringBuffer):
(WTF::CStringBuffer::reportMemoryUsage):
(CString):
(WTF::CString::reportMemoryUsage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fix UIProcess build with Qt on Windows
https://bugs.webkit.org/show_bug.cgi?id=96635

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13
Reviewed by Csaba Osztrogonác.

Enabling setShouldCloseConnectionOnProcessTermination on the connection
is something that is only implemented in ConnectionUnix, not
ConnectionWin.cpp, where appears to be built-in functionality.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file

Unless it's actually a dependency of the public QtWebKit API.

We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
files with their _PRIVATE equivivalent, but that's likely to break when
someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
clean up the variables in default_post.

This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
longer needed, as it was a workaround for the intermediate libraries ending
up in the prl file. And, since CONFIG -= staticlib was there to support
the explicitlib option, we can remove that too (as well as the exception
for gprof, since it would be empty). If gprof needs tweaks to always link
statically they should go in gprof.prf.

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: NMI: remove the dependency of platform sources from WebCore header introduced by NMI instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=96367

Reviewed by Yury Semikhatsky.

the target is to move 'platform' specific instrumentation code
from WebCoreMemoryInstrumentation into the new PlatformMemoryInstrumentation.

Drive by fix: New type DOM.Image was introduced.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* platform/KURL.cpp:
* platform/KURLGoogle.cpp:
* platform/PlatformMemoryInstrumentation.cpp: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
* platform/PlatformMemoryInstrumentation.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.cpp.
(WebCore):
(PlatformMemoryTypes):
* platform/SharedBuffer.cpp:
* platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.h:
* platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

Specifying a few slow tests on the debug configuration that pass
when given sufficient time to do so.

Branching expectations for three spellcheck test failures, on release
configuration they time out while on the debug configuration they
have enough time to fail.

* platform/gtk/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk: 

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools: 

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. Currently it points to a subdirectory in the layout tests results
directory. At least on the builders this ensures an empty cache directory
with each test run.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][DRT] Implement LayoutTestController::layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=82294

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Add a support method for getting layerTreeAsText.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::layerTreeAsText):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.

* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::layerTreeAsText):

LayoutTests:

The tests are no longer failing because of missing layerTreeAsText
but due to accelerated compositing not being enabled.

* platform/efl/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS

Reviewed by Ossy.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=96645
PR #207307

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

We use canScrollRenderBox to promote the layer as scrollable instead
of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
We should assert against the former as well.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
* Api/InRegionScroller_p.h:
(WebCore):
(InRegionScrollerPrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] REGRESSION(r128245): It made zillion API tests fail
https://bugs.webkit.org/show_bug.cgi?id=96531

Reviewed by Jocelyn Turcotte.

Preferences have to be updated after the drawing area was created
for compositing mode to be set.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, add my Intel email address to the list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fix build of WTR and the QML2 plugin on Windows
https://bugs.webkit.org/show_bug.cgi?id=96652

Reviewed by Tor Arne Vestbø.

Some components that we build such as WTR or the QML2 plugin include
WebKit2 header files as well as WebKit2's config.h. Only the include
paths of WebKit2 are required for that at the moment (WEBKIT +=
webkit2). Only on Windows WebKit2's config.h also includes
WebCore/config.h, which in turn requires to have WebCore/platform in
your include search path. That in turn means that any component that
wants to use WebKit2 headers also needs the WebCore headers, but only
one Windows. It turns out that for the Qt build we don't need it, so
skip it in our configuration and make the include path requirement
the same across all the platforms we build.

* config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
The Script run-launcher should support -2 in combination with --efl
https://bugs.webkit.org/show_bug.cgi?id=96639

Reviewed by Simon Hausmann.

Support running the MiniBrowser then supplied -2 as argument.

* Scripts/run-launcher:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
https://bugs.webkit.org/show_bug.cgi?id=96633

Reviewed by Csaba Osztrogonác.

WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
It's the usual problem and the usual solution is to rename one of the conflicting files.
This patch chooses to rename DRT instead of WTR and MBR.

Fixed include order at the same time to match style guide.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
(messageHandler):
(isOption):
(takeOptionValue):
(printUsage):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION: hit test doesn't take iframe scroll position into account
https://bugs.webkit.org/show_bug.cgi?id=96541

Source/WebCore:

Reviewed by Antonio Gomes.

Convert the coordinate correctly by taking scroll position plus frame
borders and padding into account.

Test: fast/events/touch/touch-inside-iframe-scrolled.html

* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):

LayoutTests:

Reviewed by Antonio Gomes.
Test written by Rick Byers.

Test that scroll position is taken into account in hit testing.

* fast/events/touch/resources/touch-inside-iframe-scrolled2.html: Added.
* fast/events/touch/touch-inside-iframe-scrolled-expected.txt: Added.
* fast/events/touch/touch-inside-iframe-scrolled.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed fix for: REGRESSION(r128451): It broke inspector/profiler/memory-instrumentation-cached-images.html
https://bugs.webkit.org/show_bug.cgi?id=96653

* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-cached-images-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Remove a lot of C'ism from Ewk_Tiled_Backing_Store
https://bugs.webkit.org/show_bug.cgi?id=96631

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13
Reviewed by Kenneth Rohde Christiansen.

Remove a lot of C'ism from Ewk_Tiled_Backing_Store and
fix coding style.

* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_updates_process):
(_ewk_tiled_backing_store_flush):
(_ewk_tiled_backing_store_tile_new):
(_ewk_tiled_backing_store_item_resize):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_tile_dissociate_all):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_first):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_process_idler_start):
(_ewk_tiled_backing_store_disable_render):
(_ewk_tiled_backing_store_enable_render):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_changed):
(_ewk_tiled_backing_store_view_cols_end_del):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_row_del):
(_ewk_tiled_backing_store_view_rows_range_del):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_smart_member_del):
(_ewk_tiled_backing_store_smart_member_add):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_show):
(_ewk_tiled_backing_store_smart_hide):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_smart_calculate_size):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_fill_renderers):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_render_cb_set):
(ewk_tiled_backing_store_tile_unused_cache_get):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_zoom_weak_smooth_scale_set):
(ewk_tiled_backing_store_alpha_set):
(ewk_tiled_backing_store_update):
(ewk_tiled_backing_store_updates_process_pre_set):
(ewk_tiled_backing_store_updates_process_post_set):
(ewk_tiled_backing_store_disabled_update_set):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):
(ewk_tiled_backing_store_pre_render_cancel):
(ewk_tiled_backing_store_disable_render):
(ewk_tiled_backing_store_enable_render):
* ewk/ewk_tiled_backing_store_private.h:
(_Ewk_Tile_Stats):
(_Ewk_Tile):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_smart_backing_store_add):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128464 268f45cc-cd09-0410-ab3c-d52691b4dbfc