labofsahil/github-event-dataset-2012 huggingface dataset:
very much so, duplicated 4 times. fixed now.
There could be multiple language objects in expr, including multiple calls. Originally, I had combined them into a call using `{`. However, I realized that eval() handles expressions directly, so it was cleaner to coerce to an expression. This change was obviously aiming for the minimal change. You might consider having parse_all return expression objects instead of lists in the 'expr' column. But I don't understand the code base yet.
Now that this is getting tested, it'll have to be `extract_hist_ranges` (instead of `extract_input_ranges`).
If we made the timeout part of the BlobStoreContext.getSigner factory, would we touch fewer call sites?  This also seems like the correct approach so we can support timeouts on other operations such as deleteBlob.
Provide another overload of the RetryAfterException constructor so you don't have to pass null.
Oh, man. Thanks for pointing that out. The idea that the repository can be NULL was part of the original design that I was discussing with @csware, but I had to drop that feature. The code to do attribute lookups is too tied to having a repository object right now. I just forgot to update the header comment.

I'll add tests for the other cases!
Does this need the self-ending slash?
{{ url('firefox.performance') }}
no `</ul>`.
Please remove this comment.

This is a comment that would fit in a test suite.
So... I think this isn't necessary? I think es_utils prepends for you, so you just need to make the prefix the build name.
This is my new favorite friend. I wish I had looked for and discovered it last week.
That makes sense. Thanks for looking into it.
Line break missing before echo.
Space before the "." separator on the line below
Maybe better use a const, instead of a magic value?
@fabpot is this the right direction?

basically the idea is to create a new input in case we don't have the command definition key

my question is:

how can i easily get the $args below on 661

thanks :+1:
Did you test `return $this->closure($options, $previousValue)` for speed ?
Symfony does not use the ``@author`` annotation on any testcase AFAIK
Can we use the absolute `http://neat.bourbon.io/examples/` instead?
User#owner?(topic) より User#has?(topic) とかのほうが自然かしら?
もしくはTopic#owner?(user) のほうがよさそうな気がします…
or `receiveContactEndorsed` - to correspond with the push notification
`activeVenues` is mutable, so use `sortUsingComparator:` instead of creating new array and returning mutableCopy
openAmountWithVelocity = openAmount + ...
The only alternative is cutting and pasting the code, which in my opinion
is worse.

Sent from my iPhone

On Dec 6, 2012, at 4:32 PM, Adarsh Pandit <notifications@github.com> wrote:

In app/models/private_messenger.rb:

> @@ -0,0 +1,15 @@
> +module PrivateMessenger
> +  def remind
> +    @help_out = get_help_out_text
> +    @message_body = PrivateMessage.new('/shared/reminder.erb', binding).body

I'm happy with this abstraction of the text to the erb template, but the
rest of this module feels like its too physically removed from it's actual
usage.

For me, reading a class like GroupPrivateMessenger is now more difficult
with use of this model..

—
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/238/files#r2343622>.
Why was this bit removed? Seems that it was added not long ago when Lion came out to support a new formatting of top. See ed19f0e
Since this test is focused on testing the resources file, for clarity and to ensure that it is in fact testing some function in resources I think this should point to the resource.  If you need the extension to help in testing the resource (which you shouldn't, or else we have done something wrong) you could just define `@extension = Runcible::Extensions::Consumer`
Update to reflect the MIT license in other files por favor.
It seems a bit odd to me to pass src as a reference and out as a pointer, but that matches what the code in this function was using in maketx.cpp so it resulted in many fewer changes to keep it that way. I wasn't sure how you preferred to handle references. My personal style is to only pass const references, and pass any potentially mutable parameters as pointers.
Why `priv_dir()/../priv` instead of just `priv_dir()`?
How can the editors contribute context menu actions?
@mockee  这个也顺手加上`nonatomic`吧
Needs i18n and context.
Also, is an optional module dependency needed since the class implementing the platform mbean server comes from the jmx subsystem?
Can you modify the patch to get rid of it from the AS build then?
We can probably just use `if` here.
We can't just wholesale remove the overlay event functionality.
photoState wouldn't be available here in non-newsletter mode...
Good, you got my r+.
Long standing node / js (projects I have worked on) always have the callback as the last argument.
Calbacks are only triggered once and always have their first argument as null or an error and the other arguments for success conditions.

Its a pattern I have used throughout calendar.

```js

var controller;

// function last
controller.findAssociated([], {}, function() {

});


// options as last
controller.findAssociated([], function() {

}, {});
```

Having the callback last is mostly for consistency but I also think it looks quite a bit better when you do need to pass the arguments.
Can I see an example, please?
It seems that I forgot to clean all the logs, sorry
Just did a |grep -r localStorage apps/*| and there is already some that use it :/
apps/dialer/js/recents.js
apps/fm/js/fm.js
apps/music/js/MediaDB.js
apps/gallery/shared/js/mediadb.js

@dominickuo @davidflanagan @RayCheung Any way to remove those localStorage uses?
I have included your suggestion but the prepopulation of call entries in the Call Log in the desktop won't work because of this: https://github.com/gtorodelvalle/gaia/blob/master/apps/communications/dialer/js/dialer.js#L5
should we protect agains a possible 'type' not in the configs?
You don't need the comment here.
Oki doki. That's a mode. Maybe instead of a className it should be a data-mode thing?
The usual convention is to prefix that with k, like var kSplashTimeout = 700;
please add this here:

body[data-transitioning] .loading:after {
  animation-name: none;
}

so while panning the rotation is frozen and the fps will be OK, thanks
You are correct. They are unnecessary values.
One thing worth noting is that this shortcut is not going to do what we want when we implement unified folders.  In that case, we really need to get the list of folders associated with the account the message actually belongs to.  However, we can deal with that when unified folders actually happen.  But please put a comment to the effect of "XXX Unified folders will require us to make sure we get the folder list for the account the message originates from."
Maybe you need just the result from the deleteRequest? (yes, I'm lazy, didn't check the callback)
This `key?` or `value?` logic is a bit counter-intuitive.  What do you think about something like this instead?

``` ruby
VT100_COLORS = { ... }
VT100_COLOR_CODES = VT100_COLORS.values.to_set

def color_code_for(code_or_symbol)
  if VT100_COLOR_CODES.include?(code_or_symbol)
    code_or_symbol
  else
    VT100_COLORS.fetch(code_or_symbol) do
      color_code_for(:white)
    end
  end
end


def colorize(text, code_or_symbol)
  "\e[#{color_code_for(code_or_symbol)}m#{text}\e[0m"
end
```
You can use :status => .... It's the state of a state machine and should not be set manually. Normally status= should be private. I had to authorize that can of creation (using :status => ... ) to be able to build an item from the database, but normal code should not use it.

A add_source and add_target methods exists on Order and should be used for that.
原文ではバッククォート無し
ok sorry for that ;-)
Is the goal here to allow both default strategy and list of strategies? It should only allow one (i.e. you can have options.scheme OR options.strategies but not both, and option.scheme should be normalized into options.strategies first, with a flag for "default scheme" set).
should be entity keys.
Fine. You can bring it up to the team at today's Scrum meeting and explain why you made this design choice. I'll add a sticky on the Scrum board for this issue.
Can you please remove these remarks? DeuceSTM is Apache2.
You can remove this line. There is already a similar log message inside the Logger class.
That was intentional since they're really two pieces of one item (dev virtualization).
No, LibraryInstaller is a supertype of InstallerInstaller, instanceof only returns true for subtypes of type InstallerInstaller.
Just for completeness: in your `require` and `require-dev` fields.
lots of h1s?
New attributes should be [declared at the class level](http://ipython.org/ipython-doc/stable/development/coding_guide.html#attribute-declarations-for-objects).
"many reasons"
`paths` sounds good to me.
Please use api-utils/system/events instead. I plan to deprecate this soonish!
This method returns true regardless of what happened. Should we be checking that the key is actually deleted successfully?
I would keep it as you stated above, except local variables are camel case also.
Ah, I missed the default one. The default is controlled by a setting? I think structuring the data has an effect on consuming it. It is the difference of getting all of the fingerprints by looking at a single data structure vs filter all of the keys for those with a prefix.
Should this be `@filename.inspect` instead?
@haus there are two other places where `_sbindir` is used, looks to be creating a symlink, on lines 61-62
Can you change this back to 2? Otherwise, running the ``__main__`` method in the trusted kernel manager fails.
Okay, let’s just leave it as it is then.
As written, there's not really a reason to have start as a variable here. You could have multiple return statements, e.g.

    if ( j < 2 ) {
      return 2 - j;
    } else if ( j >= 2 && j <= 3 ){
      return 0;
    } else {
      return j - 3;
    }
I think that especially in ycp with a lot of semicolon it is better for readability to have:
```
string attrib = rule[ "rule"]:"";
if ( attrib == "ID" )
  attrib = "KERNELS";
```
This way you don't need to check for KERNELS and also it is much more readable that in fact you do translation of ID to KERNELS.
Doesn't sound very useful @Thinkscape. I think just using strtr() instead would make more sense.
ok, updated, cmiiw.
have updated
Marked to be changed after the I18n PR gets merged.
Ah ok. are box drawing characters that useful though?
Please change those two to usage of parameters, and define default one in `parameters.yml.dist` with value of: `error@knpbundles.com`
GameMode's will most likely be undergoing a re factor shortly, so I'll hold of on this for now.
Would you like to implement routing using Flatiron Director in this app so we have reference implementation? Ref the linked ticket above.
renamed to bind-modules
proprietary, causes inconsistent behaviour. suggest not using.
but it's only a requirement if you choose to use a redis-backed cache, right?
Minor optimization:
Move lines 107-112 directly into array creation, after line 89.
Will avoid array resizing as well as some extra lookups.
Then should the "Build the Archive" Build be after the Undeploy as well? It looks strange sandwiched between "Build and Deploy the Archive" and "Undeploy the Archive".
I still think I like it first since it explains that it only builds to test for compile errors and the next logical step is to build and deploy.
@flack I just added a ticket on making the server failure notifications persistent: bergie/create#94 In VIE we also have a long-standing issue on client-side validation: bergie/VIE#21

Please add comments to those on how you would like these things to be supported.
could use an ID here.
`s/tofumatt/jsocol/`
Odd indent.
https://github.com/mozilla/mozillians/pull/241/files#L12R11
This is highly non-obvious from the feature request issues. I'll refactor it and push new patches.
This line is failing lint.

Problem at line 59 character 33: Expected '{' and instead saw 'return'.
Newline at end of every file, please.
please add braces, thanks
The code change looks good, but this phrase is actually not true - whether by design or by bug, the owner _can_ add works to a closed collection - I just did it on Test.
Wouldn't it be better to check all clients? Currently checks will stop after the first fail. A solution would be to collect all failing clients and then call `$this->buildResult(...)`.
are you using those users to test roles?
Hm good call. So 13.0b2 we get from the $VERSION parameter, right? Then we probably should leave this in for now and have for Nightly builds:

[finished] mozilla-central_l10n: Firefox Nightly mac en-US (20120515030518)

We update the jobs and the python config to always add the version number when requesting a job. Then we will always have the version number which is way better than 'Nightly'. I'm ok for now bug lets create a new issue to get this fixed.
I think report would be better here.
Can we remove the drupal set message as well?
How about "don't work"?
This is the new method on the DocumentStore.
Also don't naively assume `xml_dict.title` is a string, it can be `None`.
why are you using this format for centroids? Why not just have the row be the index of the centroid?
Thanks! This has been fixed.
ботвень
назвал так назвал
Note that I only detect keywords within the property values, we don't want "padding" property to become a keyword. So these are not strictly "keywords". However, from the highlighter perspective, I think it makes sense to decorate these as such.
why are these wrapped? I assumed it was due to X11 headers being a bloody mess, but @Venemo unwapped everything without too much pain in the past
wool
Show me an example of how to do that with your system and I'll change the code.

I'm really running out of time I can spend on the nit-picky stuff.
Move this up a line so the let binding is on the same line (more idiomatic and consistent with the rest of our code)
Might want to swap the order of these arguments. I could see it being useful to use `(partial throw-limit-exception! limit)`.
I'd prefer to see this broken out into two separate functions: `set-store-usage!` and `set-temp-usage!`. Each of those should take `broker` and `megabytes` as args, and I suppose noop when `megabytes` is nil. That'll let you still thread things through `build-embedded-broker`, and each function will only be responsible for a single thing.
Can we use _.isBoolean for this?
At a later point in time, we might want to make this a (test) util function.
Done, also added a test case. The commentId will be needed by the UI so that is still returning.
This is dangerous. The ``this`` reference can escape during initialization.
Perhaps if this class is CMF-specific and not relevant to anyone else, the way the rest of this library is, that class should move to the CMF Routing bundle?  Drupal is going to have its own provider and generator as well, which will just be in Drupal's repository.  Presumably ezPublish will do the same.
this hash or its alternate do not seem like a model concern. I think the state of the toggle is what should be returned.
Why is there commented-out code? Will it become relevant later?
It is working in local mode!
On Feb 23, 2012, at 6:13 PM, Steve Johnson wrote:

>> +        # Get all script parameters as a list
>> +
>> +#        abs_input_paths = []
>> +#        for i in self._input_paths:
>> +#            abs_input_paths.append(os.path.abspath(i))
>> +#
>> +#        input_paths_str =  'INPUT=' + ','.join(abs_input_paths)
>> +#        log.debug('Pig_input_paths_str: %s'%input_paths_str)
>> +#        output_path_str = 'OUTPUT=' + self._output_dir
>> +#        log.debug('Pig_output_path_str: %s'%output_path_str)
>> +#
>> +#
>> +#        args.extend(['-p', input_paths_str])
>> +#        args.extend(['-p', output_path_str])
>> +        return args
>> +
> 
> If Pig isn't working in local mode, we shouldn't keep dead code in the master branch. Definitely hang on to it for the future but clear it out of this version.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483582
`null` => `NULL`
I'm just wondering if `$_SERVER['QUERY_STRING']` is not more reliable than $_GET. 

Personally, I've seen issues with $_POST due to bad PHP configuration settings, and since $_GET is parsed from the query string, I would think it would be more probable to have issues with `$_GET` in the first place, making the use of `$_GET` a redundancy over `$_SERVER['QUERY_STRING']`.
self.DNA = newDNA;

Читабельнее ИМХО
В принципе, нам не нужны вспомогательные переменные, можно сразу сравнивать элементы двух массивов.
Здесь вскрывается интересный момент: несмотря на то, что вы не считаете, что в данном задании нужно высчитывать количество из процента, зато обрабатываете случай, когда сравниваются две ДНК, **разные по количеству символов**. Это как?
Резюмируя соглашусь с Олегом. Вся проблема в разночтении из-за неточности в задании. Заменять на новое, отличное от старого, значение - более верно логически. Однако, судя по заданию, полностью случайная мутация, когда мутируемый ген может мутировать в себя же, так же не противоречит исходным данным.
Кривова-то. У объектов NSArray есть методы isEqual, isEqualTo, isNotEqualTo - лучше воспользоваться одним из них. И вы считаете количество одинаковых символов, а нужно-то как раз наоборот.
Смею утверждать, что правильно.
Индексы для мутации берутся из ```arrShuffle``` после  ```[arrShuffle shuffle] ``` и поэтому всегда разные.
Да,я уже понял что за глупость написал и удалил коммент :)
Сделал коммит, надеюсь теперь все в порядке.
В условии этого не было
И правда. Спасибо за разъяснение.
В более ранних версиях Xcode не позволил бы тебе сделать такое (не помню, правда, насколько ранних версиях). Компилятор не мог адекватно реагировать на операцию присваивания в этом блоке, решением было ввести в двойные скобки ((self = [super init])).

Это я так, просто для справки. =)
Could you do this if check in MarkusConfigurator. Think of this file as a config file with a bunch of optional defined constants. Defaults, and logic handling should be done in MarkUsConfigurator. Sorry for not being clear about this. Please do keep the great comment!

You could make it more apparent that a constant is related to the Automated Test Engine (ATE) by prefixing it with "ATE_"
We could eagerly construct layers in image's constructor.
I don't think we need a link to reading about factories.
Yup. :-). I'll merge this in right now, and create a tech debt (Mark just said the same).
voce não deve definir um layout para ajax. você deve utilizar context switch: http://ncona.com/2011/11/using-ajax-with-zend-framework/
It's the same everywhere. :)
That feels wrong since it's not *trying*, it's *checking*. It'd point to `displayIfNeeded` or `layoutIfNeeded` as counterexamples.
If you wanted to be more coffeescript-ish, you could use a list comprehension here.
Kanskje dette er en god anledning til å sjekke at `assigns(:issue_steps)` skjer på riktige steder, burde være ganske greit å legge til controller-specen.
why this indirection to pass boolean hard, as this isn't used with "false" anywhere ?
One more DRYing step:

```javascript
var $el;
if ( ) {
  $el = this.element.parent();
} else {
  $el = this.element;
} 
$el.addClass( "ui-disabled" );
```
>There are definitly cases where there is a referenceName but the msg is empty. In fact, this appears to be the normal case when pushing a reference (without any issues) - In this case where there is no message, I think it makes sense to pass along the empty message.

From the user perspective, I'm not sure that would be that "informative" ;-)

If no message means "Nothing bad happened", how about replacing the empty message with something like `"Succesfully pushed"` and adding this to `pushStatusUpdates`?

/cc @carlosmn, @congyiwu, @phkelley 

>I am not sure if there would be cases where this would be called when the reference name is empty - will have to investigate that possibility.

If that doesn't look like a valid case, maybe should we just add a default behavior to just throw an Exception... and wait for a bug to to be reported?

>Both the `referenceName` and `msg` are empty? Should we add anything to `pushStatusUpdates`?

Maybe should we also throw here?
this is overwritten by the line below
Damn was I blind. % score_func obviously was missing.
If I would be near you deserved a beer :)

2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> > +            raise ValueError('No ECG channel available. Please '
> > +                             'select a channel resembling the ECG.')
> > +    else:
> > +        pick = pick_channels(container.ch_names, include=[target])
> > +        if len(pick) == 0:
> > +            raise ValueError('%s not in channel list (%s)' %
> > +                              (target, container.ch_names))
> > +    return pick
> > +
> > +
> > +def _find_sources(sources, target, score_func):
> > +    """Helper Function"""
> > +    if isinstance(score_func, str):
> > +        score_func = score_funcs.get(score_func, score_func)
> > +    if not callable(score_func):
> > +        raise ValueError('%s is not a valid score_func.')
>
> I don't have the bug my brain python parser sees it :) you miss the string
> formatting argument :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1966107>.
>
>
also to me verbose should be None by default as param everywhere so it's trivial toggle globally verbosity. if not specified the verbosity is the default global. If verbose=True or False for a function then this function overrides de global state and decides to log or not?
Yes, definitely more elegant, +1
I got push to u.



On Tue, Dec 11, 2012 at 11:13 PM, Hilary Ho <notifications@github.com>wrote:

> In archives2012.html:
>
> > +    <title>Archives - 2012</title>
> > +    <meta name="viewport" content="width=device-width, initial-scale=1.0">
> > +    <meta name="description" content="">
> > +    <meta name="author" content="NexVend Sdn Bhd">
> > +
> > +    <!-- Le styles -->
> > +	<link href="css/bootstrap.css" rel="stylesheet">
> > +    <link href="css/bootstrap-responsive.css" rel="stylesheet">
> > +
> > +    <!-- HTML5 shim, for IE6-8 support of HTML5 elements -->
> > +    <!--[if lt IE 9]>
> > +      <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
> > +    <![endif]-->
> > +
> > +    <link rel="shortcut icon" href="img/favicon.ico">
> > +    <link rel="apple-touch-icon-precomposed" sizes="144x144" href="ico/apple-touch-icon-144-precomposed.png">
>
> These few lines can be remove. unwanted links.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nvcHilary/SMCwebsite/pull/9/files#r2379051>.
>
>



-- 
Regards,
vincent
I think if these are indented two spaces (like the bullet point itself) they may render below the bullet point.
Yea, I wasn't sure about that either. Should I only keep the one in book/security.rst? as that is the one most likely to be read.
Isn't it "Now, you have .."?
It is not specific to 2.1.5. It is true as soon as you switch from the UniversalClassLoader to Composer
This seems very ugly to me. We can do this:

    $mergedOptions = array_merge(
        $options,
        array('some_default' => 'values')
    );

This is the way we do it in symfony if we use an array on one line, this removes the example that every array item should end with a comma, so maybe we should do this:

    $mergedOptions = array_merge(
        $options,
        array(
            'some_default' => 'values',
        )
    );

But I thought we use the original example everywhere in the Symfony code, so it is the standard.
to open a php bloc, you have to use double colon like 

```
change the TransportChain class::
```
No problem, I’ll do that.
包含变量的日志文件描述符
已统
this feels like it could be written in a better way.
Lots of blocking avoided, though currently when we create a producer or consumer, there is no guarantee that the underlying channel has been started. We return the actor, and it is up to the caller to verify that the channel is up by using a channel callback to monitor the state. So, in the examples and tests, we potentially block before sending a message from the producer. I'm open to other alternatives, but the only one that comes to mind is blocking within the AMQP extension when we make the request for a new consumer/producer. I don't think that's a great idea since these things are supposed to be fault tolerant, and it seems reasonable to get one that will eventually start when an underlying fault has been resolved.
Your intent here, to give the magic numbers a name, is good. It's still pretty magical, and needs a comment describing what these codes are for, and which functions use them.
Why ```alias``` here and ```alias_method``` for the other two? Moreover, this syntax is incorrect for alias. It should be ```alias :last_week :prev_week```
check other examples -- is this suppose to be single or double underlined?
А вдруг `item` пустой?
I wonder if this should be moved into the `VimInstance` to enable something like the following?

```ruby
@pid = vim.spawn(name, vimrc_path)
```
It would be quite useless to invoke $grid->setVisibleColumns(); wouldn't it?
Ok, I missed that there was a decision made. Will fix.
And while we list 9 products for grid, I think we can list 5 or 10 posts.
I broke BC in `rawMeasures` as well. Should I revert all breaking changes? I could save them until we have a consensus on a new `navdata` structure.
Actually maybe we should  use weak references here, specifically weakref.WeakKeyDictionary.
See http://docs.python.org/library/weakref.html for details.
Wont work if coll is `[false]`.
The following two patterns are semantically equivalent:

```objc
if ((self = [super init])) {
    // Do initialization here.
}

return self;
```

```objc
self = [super init];
if (self == nil) return nil;

// Do initialization here.

return self;
```

We simply prefer the latter. It better highlights the normal code path (instead of being indented, it's at the top level) and makes the comparison more explicit.
There's a trailing backslash been left in at the end of this line.
Is it critical that you have this version of freetype? What happens if you don't specify this?
@pelson: It is not entirely obvious that the backends qt4agg, wxagg and tkagg are so different. qt4 differs from tk by just classes it calls. In wx the difference is that there's a `FigureFrame` object, which has to be passed to a figure manager. Now `__init__` of `FigureFrame` does what your `new_figure_manager_given_figure` does, and it also creates a figure manager. However at the same time, both `__init__` of `FigureManagerWx` and `FigureFrameWx` require almost identical information, so it doesn't seem so crazy if e.g. `FigureManagerWx` initialized `FigureFrameWx`. This would also make sense given that `FigureManager` is the central object in other backends. Overall: I realize that for keeping backwards compatibility one would need to use an alias, and that it is not immediately obvious how to implement the proper behaviour, however it seems that the current state of backends is a mixture of OO code with weird naming scheme (why does one need `backends.tkagg.FigureManagerTkAgg` instead of `backends.tkagg.FigureManager`?), and copy-paste-modify non-OO code. This is a pain to interface to: for example IPython needed to hack into the code, to implement their own backend. I think that temporary existence of two ways of doing the same thing is a relatively low cost for having one of these ways clean.
Ok, I ran the tests with a heavily modified test_image.py. Most of the tests fail due to typesetting differences, but I would say everything is in order. I also tried running all the matplotlib examples and uploaded the results [here](https://github.com/pwuertz/matplotlib-backend-pgf/wiki/Examples%20Gallery). I think most of it looks good, but a pixel-perfect comparison can be troublesome :/.
Also I think that something is odd with the image sizes calculated by draw_image, but let's forget about that for now :)
Thought I had the latest version when i added that.

David
On Apr 20, 2012 8:37 AM, "Mike Hadlow" <
reply@reply.github.com>
wrote:

> > @@ -1,5 +1,6 @@
> >  [Oo]bj
> >  [Bb]in
> > +[Aa]pp_Data
>
> Latest version has this, why not pull and merge.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mikehadlow/sutekishop/pull/1/files#r712006
>
here are some suggestions:
http://selenium.googlecode.com/svn/trunk/docs/api/py/webdriver/selenium.webdriver.common.alert.html

http://selenium.googlecode.com/svn/trunk/docs/api/py/webdriver_remote/selenium.webdriver.remote.webdriver.html#selenium.webdriver.remote.webdriver.WebDriver.switch_to_alert
Also see pull #40 for closing any open apps during the parent setUp.
make default 'last_update_cache' Michael doesn't like using DM...
Well, I know that it is not nice but I had no other idea. Here is the problem:
There are two threads that  are running and both have the same exception handler. When the event throws an exception then it forwards the method and the exception to the exception handler. This one invokes the method again. It follows that endloops can happen. How do I stop this loop (or the invocation of the method)? The next problem is that the exception handler is not accessed outside the bride.

I didn't found a other way than a static variable.
It's planned - made the pull request for the initial review.
my editor is currently configured to put tabs, when I tab... And it line up with the rest, in my editor...
You mean  I have to always use spaces instead of tabs, right?

commit posted!

BTW It would seriously help me to be more in tune with your way of coding, if you could post me some sort of short developer rules/guidelines. ;-) ...
Should be `(== ?float-val nodata :> false)`
Let's keep this to 2 lines for readability.
Thanks, @mrvisser, I'll make the change.
I need it to extract the initial values (and the lower bounds) for NLOPT.
forgot to free m_refocunt
Same goes for that, please stick to `yoursite.com`
Clippers are the bestest.
Needs a blank line separating the functions.
Yes. Initially this is a patch for 3.0, so the code is actually in use right now. Can be removed from 3.1 I guess.
Are you sure ``$loaderType`` has the correct type as ``*`` is not a sub-type of ``string``?
Should the return type not be "Request\StreamRequest|string" instead of "null"?
没有使用，就不用引入进来啦。
"a hundred" => "one hundred"
it'd be cool to get a code snippet for this eventually. We tried pretty hard in C# 4 to make interacting with the DOM look a lot like interacting with it from JS--dynamic types and all ;-)
You should remove pull_request, there's no specific responder for it.  You can add one by defining `receive_pull_request`.
Addressed in b680047f07b60f79196e59f77cc79909d0067121
oops this is wrong.
You're missing the ; at the end of the line.
Stupid question, why is $glue double quoted instead of just being directly used?
Implementado Buscadores: Propriedades Compostas
I guess the kerb domain needs to be extracted into a setting value?
I think I mentioned this earlier, but: we currently require all mc questions to be answered, but I could potentially see this changing. Can you do a similar 'No response given' in case `mc_question_option` is nil, or is there a reason not to? (Or I'm fine with leaving as is if you just add a todo.)
Do't now how to replace 

try:
                desc = desc.encode("utf-8")
            except UnicodeError:
                desc = unicode(desc, "utf-8")

Always get errors
Brace on the line before, at the end.
Style this label and input same as we have style elsewhere. (for attribute for example).
This is still not valid XHTML. You cannot just have text immediately after `<ul>`
That's not what "I want". MDZ got a decent point here and we should be getting on a common-point there. That's what MDZ should be commenting on.
Ah.. right.
stimmt....
this needs and id or some identifier as to what it is. Either id or aria-role
I factored this out of the plugin execution so that it doesn't need to be defined each time the plugin is called.
I would add a call to ``cannotBeEmpty()`` on the prototype as an empty item is wrong here anyway (and warning early is better)
`null|object`?
to be removed?
kill all the threads.
$desc to $description?
We usually have an en dash for these kind of things: "–".
Seems `[buffer, ["span", token[STR]].concat(attrs)];` is not working as a template when buffer is "".
Was this conditional case for Fedora, or SUSE perhaps?
@jeffkaufman: done
You already are setting that with your two functions ;)
Sorry for the emails!!
I don't see the details yet.

Should this be ``__init__`` arguments only ? How much is there stale state (cached attributes) if options are changed on the same instance ?
Or should this wipe the stored attributes that are not compatible with the latest arguments?
catch-all  isn't really code - what about just having it be "catchall" (no quotes) instead  of `catch-all`?
I believe Array.indexOf() is not implemented on IE7/8, and I can't think of a nice way to use Array as a hash set without doing a liner scan, but you know a better way, please send a pull request.
sure that could've worked too :)
Please move choices to upper-level constants.
Huh... I renamed the class to have the lowercase 't', but it looks like git didn't pick up the rename?  It's named properly locally but not on github.  I'll investigate.
Since you are just calling this method from the unit tests, can you pls reduce visibility to package or default?
Yes, the same trick is possible here.  Since the code already does a few logs and maybe a sqrt for each photon, we won't see any large-factor speed gains from swapping a sin and cos for another 2 sqrts.
The way to do this is to declare the `_re` variable as `mutable`.  This tells the compiler that this variable is allowed to be changed from within a `const` method.  This is ok, and doesn't break the "immutable" nature of the SBMoffat class.  It's still conceptually immutable.  You're just storing the result of a calculation for reuse.  This is completely fine.

In fact, part of the reason it's fine is that you _can_ count on the object not having things like `_beta` change between successive calls to `getHalfLightRadius`.  If the object weren't conceptually immutable, then you _would_ have to redo the calculation every time.
thanks for the feedback, I will fix this.
This will be important soon, hint hint wink wink
If we are using settingslocal.py, this shouldn't be committed.  We need to move our Facebook and Google keys over to it as well after generating new ones, because the current ones were publicly posted in the 319 repo.
ca s'appelle un subscription model
I can't find these four lines in the Java code.
Can you provide a sample of what a MercurialSCM xml looks like? It's really help for someone else looking at this, and hoping to add additional methods or default values.
My bad. I thought it **started** in 1.3.
Is this still on the page?!
コメントです！
I think a better default value would be None (mutable default arguments are not really safe in Python)
Why was indentation changed here?
? не думаю, що це гарний спосіб використання атрибуту id
є кастомні data-* атрибути
No problem, I'll rename it. I chose this form because I thought it would be more user friendly to excplicitly state that the product is not discountable than to unmark those products that are not.
Aici linia aceea oricum nu face nimic. Nu merge cu this, pentru ca e un constructor privat si nu poti asigna o valoare statica unei variabile de instanta. Momentan am sters linia.
I'm glad you asked!  I wasn't trying to get logging perfect in this pull request.  I created https://github.com/aeolus-incubator/thor-cli/issues/3 for that and hope to see some feedback there.  But for now, perhaps just change the default logging level to WARN?  I put it at INFO because only developers are going to be using/hacking on this in the immediate future and I wanted the default to be useful.  But I can change it.  /me shrugs
I was wondering about something like this:

public class JsonParser {

    private final Gson gson = new Gson();

    public static JsonElement parse(byte[] responseBody){
        try {
            String responseAsString = new String(responseBody, "utf-8");
            com.google.gson.JsonParser parser = new com.google.gson.JsonParser();
            return parser.parse(responseAsString);
        } catch (UnsupportedEncodingException e) {
            throw new RuntimeException("Was unable to parse provided JSON");
        }
    }
}

Wdyt?
См. документацию к методу read.
Попробуй передать массив new double[] {}
The generalization of the wrap uri won't work for customers who deploy on their own servers. After I've chatted with Service Bus folks it turned out that the authentication for service bus will be totally different on private servers (using certificate or windows credentials). So in summary, it'll not hurt to generalize wrap but that generalization would not be used.
I'd prefer to avoid this if possible. We seem to only use two things from `subprocess` (`CalledProcessError`) and `check_output`, so we can be a bit more explicit.
You can just check for `input[invalid]`, no need for `thing`
Oh, I see the docstring actually explains it. still, the code seems a bit to complex.
no camel case please ;)
nit, weird whitespace here, (i assume you've probably found all of these so i'll stop harping on them)
Oh, c'est normal que cette partie ait été supprimée? J'avoue ne pas voir les conséquences sur le site déployé, mais c'est bizarre que ce soit un "else connected" qui soit supprimé.
Don't remove this, it still needs to be done. Better to just do it now.
Harut, the code in this function is not part of this patch.

For the record i do not think that more parentheses make it more readable.
change to
if (top_ != NULL)
remove `1000`
Do we need this cpp file?
I'm not sure why Titanium have hide and show functions. It seems dedundant since visible=false and setVisible(false) does the same thing as hide(). Since hide and show are not setter or getter methods they need to be implemented in TiUIBase
For now it's set to absolute because it's work in progress. It may be moved to docked in the future. I can't answer your question until I investigate the various layout strategies.
grr, you are right. 

On 24.12.2012, at 17:50, Alexandre Gramfort <notifications@github.com> wrote:

> In source/index.rst:
> 
> > @@ -267,9 +281,12 @@ What else can you do?
> >  What comes next?
> >  ================
> >  
> > -    - sparse solvers
> > -    - beamformers (e.g. LCMV)
> > -    - coherence measures
> > +    - frequency domain beamformers (e.g. DICS)
> > +	- improved M/EEG data simulation utilities
> > +	- band-stop and notch-filters for removal of power line artifacts 
> there seem to be indent pb here
> 
> —
> Reply to this email directly or view it on GitHub.
>
s/Html5/HTML5/
method arguments are usually camelCase with the exception of named arguments which are traditionally all lowercase (like python)
Not sure if this is something lost from previous commits.. but rowsToSort expansion (inside CSimpleSorterBase::addRow) is unprotected now..

And, this isn't the approach I meant re. rowsToSort capacity I was talking about..
As it stands, it's going to increment several times, until indexCapacity catches up with rowsToSort capacity.

What you should be doing is checking rowsToSort capacity _after_ you've added a row, i.e. after any potential rowsToSort capactiy.
You don't need +1, and you will expand index exactly once per rowsToSort capacity.

Alternatively, you could derive DynamicRoxieOutputRowArray::ensure which is a virtual.
Ok, maybe that will also simplify the eclcc regression script.
>>Can you check on MacOSx if /usr/share/applications exists? And what's in there?

It does not exist on my machine
Shortcut as `{+auto_play, +show_user, -sharing}`
No need for brackets.
not a huge deal but in general I'd prefer things like re-formatting/re-factoring (like moving existing code into a new file) to be in it's own commit
special membership types like that for Cal should maybe also be mentioned here?
I am a little worried about resource duplicates here. Does it make more sense to create a cinder::client class and include that here?
`AttributeError: 'PreparedRequest' object has no attribute 'files'`

Sample o/p of `r.__dict__`

```
{'body': None, 'url': 'https://api.twitter.com/oauth/request_token?oauth_callback=http%3A%2F%2Fexample.com', 'hooks': {'response': []}, 'auth': None, 'headers': {'Accept-Encoding': 'gzip, deflate, compress', 'Accept': '*/*', 'User-Agent': 'Twython v2.5.5'}, 'params': None, 'allow_redirects': None, 'proxies': None, 'method': u'GET'}
```
`requests PrepareRequest` or `mixins` doesn't have `files` attribute. Only `Request` Class has `files` object. 
Link to code: https://github.com/kennethreitz/requests/blob/master/requests/models.py#L206
The question has still not be answered. When we have set self.debug we can use DEBUG instead of INFO.
Now that the filtering is being handled we can gut filterRevisions.

I am also tempted to suggest doing the sorting and limiting in sql, but if we ever want to do something like toplogical sort, that becomes trickier. @djimtce: Thoughs?
Alright. I have filed https://github.com/mozilla/nightlytt/issues/20 for it. 

So I have seen now that Heather was happy with code. I will check it locally and if everything is fine we could get it landed later today.
Typo plus empty code
@shacker Added the jira at https://jira.media.berkeley.edu/jira/browse/CLC-256
@ctweney curious if we could store expirationTime as a timestamp instead. Doesn't block merge.
Now `ce` is the same function as `count`, so `(map count collection)` does the same thing.
this one seems unused
Wow, that's nuts!
Cant use instance variables here, storefile needs to be called with the current state tracked in 'c'
I wonder if you need to specify the full path to "rm". IIRC I've seen some unix-based servers not understanding basic commands unless you provide the full path, I can't remember if "rm" has that problem though.
Oh, you mean the *name* `nuS` ? "new Symbols". I'm a recovering [metal head](http://www.urbandictionary.com/define.php?term=Nu&defid=4458219). Bad me. Don't hesitate to change without warning.
typo: `orphant` -> `orphaned`
By convention (i.e. [PEP257](http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings)), the summary line should fit on one line. Maybe remove the second use of `transformation`?
Yeah, that's fair.  It's probably not extremely important to support commas since we're primarily using this for data exchange where consistency is pretty important.  But if you do want to change the regex, just replace all occurrences of `\.` with `[\.,]`.
Should we also check `creationArgs.length > 0` here?
The problem is if we don't have an `<ios>` section at all - this doesn't get triggered. One thing that can be done is instead is a has-key check before iterating through the ios plist below.
Why not just put the check in beforeTextChange and make this a no-op if the new length is beyond the limit?  It seems that would require less code and be much more efficient since we would not need to pull the current value and reset it in the case of the limit being hit.

http://developer.android.com/reference/android/text/TextWatcher.html
that was the bug root
Modified in 9bea6173d1ec3aa55be7bd44a6172b4eded16f2e
Please just let me know in case it's something else
extract line.replace(....) in a function named strip_trailing_spaces() for better visiblity
The very comments in a PR are a form of review, as are further contributions. You should probably remove the whole note.
is there any reason that you can't just use:

autorequire(:package) { ['httpd'] }

?
an exception while resolving an exception (INCEPTION)?
Is warn the right log level? Or should we go error?
`JST[tpl]?()`

http://f.cl.ly/items/3c2m2M2e2r2d251L1K32/Screen%20Shot%202012-12-11%20at%209.23.31%20PM.png
Давай чейнить с обычным отступом.
I can't tell what values you indicated in this comment. It turned them into an image or something.

"It doesn't work when one is ? and the other is ?" hmmm
Yeah, that's why I said "you're not using" :). Your job here is simply great -and no, Symfony users are using Twig.
может лучше в инициализации проставлять эту строку ?
That's mostly just me being not very experienced using tuples. I'll address this then.
> But there are several places in druntime in particular where the array copy syntax is used to initialize objects manually like that, and they don't seem to have a problem with that.

As I see, druntime always uses `ClassInfo.init` which is a field, not `TypeInfo.init()` as in my pull (in the pull it always that because of `if (is(T == struct))`).

And according to [dmd ABI](http://dlang.org/abi.html) the first class field is `__vptr` that isn't `null` so there as no ability for `ClassInfo.init` to be zero-filled and, possible, optimized to `null`+`length` pair.

> So what gives?

E.g. ability to call `memset`.
> Infinite ranges can be random access, and slicing and infinite range (while a strange notion) is legal.

Okay...
Do you really want this profile?
`STATUS_OK`.
This should never be true if the record was fetched from a Sync server, so please add a comment to that effect.
remoteHostId
This seems problematic to me, that it should be configured last, but there's no hint from the API that this is the case. No?
Will it throw an RTE ? Or will it simply fail silently?
Maybe a `configureLast` method could be a solution? Or some kind of configuration ordering mechanism?
could definitely use a docstring explaining what handler is and how to change it using the config system above
I think it should accept: 'dash', 'underscore', '-' & '_'
It's not used in the Invitation class
I'm not in favor of this throwing when for a 404.  That could be an expected result.
Can we mention here that you'd set it to 0.0.0.0 if you want it to listen on all interfaces?
This is too restrictive. ```http://www.geocaching.com/map/*``` should be better.
T,

> Wouldn't an actual round trip be accessing the rels-int with bdrxml rather than xpath?


Educate me.

Whereas fox_obj has a dc & now rels_ext attribute/object reference, I don't think it has an attribute-reference to rels-int -- thus the datastream approach.

I figured it was still 'round-trip' by looking at the generated-xml as loaded back into a fox_obj -- though I guess since I'm dropping into lxml, it's more like 270º.

Show me how you'd do it fully from bdrxml when you have a chance.

-b

---
Birkin James Diana
Programmer, Digital Technologies
Brown University Library
birkin_diana@brown.edu


On Aug 22, 2012, at 3:57 PM, Ted Lawless <notifications@github.com> wrote:

> In test/foxml.py:
> 
> > +      ri.about = u'aaa'
> > +      ri.download_filename = u'bbb'
> > +      iri.content_list.append( ri )
> > +      ri2 = RelsInt()  # second rels-int
> > +      ri2.about = u'ccc'
> > +      ri2.download_filename = u'ddd'
> > +      iri.content_list.append( ri2 )
> > +      ## parental attachments
> > +      ds.version.append( iri )
> > +      self.fox.datastream.append( ds )
> > +      ## test after round-trip
> > +      fox_obj = xmlmap.load_xmlobject_from_string( self.fox.serialize(), Fox )
> > +      fox_obj_ds = fox_obj.datastream[2]  # not dc or rels-ext
> > +      self.assertTrue( fox_obj_ds.id == u'RELS-INT' )
> > +      NS = { u'foxml': u'info:fedora/fedora-system:def/foxml#' }
> > +      xpath = u'''/foxml:digitalObject/foxml:datastream/foxml:datastreamVersion/foxml:xmlContent/*[namespace-uri()='http://www.w3.org/1999/02/22-rdf-syntax-ns#' and local-name()='RDF']/*[namespace-uri()='http://www.w3.org/1999/02/22-rdf-syntax-ns#' and local-name()='Description']/*[namespace-uri()='info:fedora/fedora-system:def/model#' and local-name()='downloadFilename']'''
> 
> Wouldn't an actual round trip be accessing the rels-int with bdrxml rather than xpath?
> 
> —
> Reply to this email directly or view it on GitHub.