fix double-click in Holdings Maintenance

so that it won't attempt to spawn the Item Editor for non-items

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Vandelay: Rewrite Inspect Queues Interface

This accomplishes several things:
1 - Load the list of queues on page load
2 - Single-click access (rather than select and click) to queues
3 - Batch Deletion of Queues

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Vandelay: Update Current Type/ID on queue retrieve

Because other parts of the javascript need those values.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Vandelay: Add some padding for inspect queue list

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Serial Note Sort Fix

Serial notes are currently sorting backwards from what is intended
(and what is expected based on other interfaces).  This was caused
by adding a sort to the middle-layer code which resulted in an
unwanted double reverse.

[whitespace adjustment by LFW per request of DBS]

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Remove unsafe thesaurus/control-set mapping

Evergreen 2.2 and beyond includes new Authority Control Set functionality
intended to allow the definition of locally defined authority control
headings.  The primary mechanism for determining which Control Set is used
by any given authority record is to look at the thesaurus fixed field
(mnemonic: Subj), which currently must be uniquely linked to a Control Set.
Failing that (in the case of no thesaurus code at all), there is a backup
mechanism: if the thesaurus value for the authority record is missing or not
used by any configured Control Set then Evergreen will look at the first Main
Entry (1xx) field in the record, and find a control set which uses this field.
This is, obviously, not perfect, but for non-overlapping authority field
schemes, it works very well.

However, the seed data for Evergreen currently includes the "no attempt to
code" value of "|" in the set of thesauri that point to the LoC Control Set.
This value ("|") is also the default value for the Subj fixed field.  This
means that the fallback mechanism is very likely never reached, and anything
short of fully specifying an appropriate thesaurus code for any non-LoC
authority record will run afoul of a similar outcome as the bib-data loss
situation described in bug #983487.

We can avoid this situation in most cases by /not/ tying the "|" thesaurus
value to the LoC control set.

This commit accomplishes this goal by allowing the Control Set for a thesaurus
to be NULL, removing the Control Set for "|" and removing the Control Set
recorded for records with "|" as the thesaurus value, thereby forcing Main
Entry inspection on any use of the authority record where Control Set is
required.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Fix in-transit hold retarget

Tell the abort transit function to not commit our editor on us, basically.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Security fix for Launchpad Bug 1003052.

Bug reported by James Fournie:

Revoking the UPDATE_MARC permission doesn't actually seem to prevent a
user from editing a record. Our use case is that we would like a user
to create new records but not edit existing MARC records.

Changing CREATE_MARC to UPDATE_MARC in OpenILS::Application::Cat's
biblio_record_replace_marc() method seems to fix the problem.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Security fix: Prevent login by deleted and barred users

An existing comment in the code suggested that we thought we were already
keeping barred users out.  LP #1010671 brings up that deleted users were
not being kept out.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Security fix: For auth, give same stacktrace for all cases of LOGIN_FAILED

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Remove antiquated 1.6 directory from docs folder.

This was used for early DocBook testing and is no longer needed.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>
TPAC: Add record detail navigation to page bottom

A usability rule of thumb suggests that navigation on long pages should
not require you to scroll back up to the top of the page from the
bottom; that gets old fast. We already do this on search results pages;
bring the same good practice to record details.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Release Building Script

make_release.sh [-v VERSION] [-f PREV_BRANCH | -t | -b] [-F PREV_VERSION] [-n] [-p]
   VERSION is auto-detected by default and is based on the currently checked out branch.
   PREV_BRANCH is auto-detected by default but that isn't reliable. Include remote name!
   PREV_VERSION Is auto-detected by default and is based on the PREV_BRANCH's name.
   -n specifies that you don't want an upgrade script to be auto-generated.
   -p specifies that this is a preview build.
   -t turns on tag only mode.
   -b turns on build only mode.
   NOTE: -t and -b override PREV_BRANCH/PREV_VERSION, but -b overrides -t.

When building a release you should have git2cl in your PATH as well as
all packages needed for building i18n and staff clients.

Usage examples:

Tagging a major version root (no need for git2cl/staff client deps):

    git checkout -b rel_X_Y origin/master
    build/tools/make_release.sh -t

Building a release:

    git checkout -b rel_X_Y_Z rel_X_Y
    build/tools/make_release.sh

Building a new major release:

    git checkout -b rel_X_Y_Z rel_X_Y
    build/tools/make_release.sh -f origin/tags/rel_U_V_W

Specifying a version outright:

    build/tools/make_release.sh -v X.Y.Z

Very Specific Example: Building the 2.2 RC1 release:

    git checkout -b rel_2_2_rc2 origin/rel_2_2
    build/tools/make_release -f origin/rel_2_1 -n -p

Release files are placed in a "release" folder one level up from your git
root directory.

Nothing is pushed to remote servers, but dojo and xulrunner files may be
downloaded. Dojo to install in the release tarball properly, xulrunner for
building the staff client and avoiding issues with xulrunner changes if
end-users build a custom staff client (say, for autoupdate purposes).

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
git2cl mangles the changelog; let's just use git's log

git2cl does bizarre things to line wrapping. The log it generates looks
deranged. Let's just use what git gives us; it's clean and easy to
parse, even if it doesn't adhere to the GNU changelog standards
(www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html).

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Revert to generic ftp.mozilla.org hostname

download02.mozilla.org started returning 403 errors; ftp.mozilla.org
seems to work again, so let's go with that.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Avoid file extensions on scripts

Borrowing from the Debian policy, you might reimplement the same
functionality using a different language such as Perl or Python. So
avoid having a file extension in the first place. What are we, Windows
users?

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Stop editing README header

We no longer have the version in the README header, so we don't need to
update it with a new value.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Fix version numbers in 2.1 -> 2.2 upgrade script

Justin Hopkins spotted the problem, and offered a fix in LP #1015807.
I'm just doing it slightly differently here.  Thanks Justin!

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Fix Title Holds

Holdable formats was being filled in with oargs, causing random failures.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
lp#1014664: add new columns to CDBI table definitions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>