Deploy ASCIILiteral hotness throughout WebCore
https://bugs.webkit.org/show_bug.cgi?id=95282

Reviewed by Eric Seidel.

As recommended by http://trac.webkit.org/wiki/EfficientStrings.
This patch converts all the DEFINE_STATIC_LOCAL Strings.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::kind):
* css/CSSPropertySourceData.cpp:
(WebCore::CSSPropertySourceData::toString):
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::undefinedItemType):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::notifyFinished):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::shouldAddNamespaceElement):
* html/FormController.cpp:
(WebCore::formStateSignature):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::canLoadUrl):
* html/ImageInputType.cpp:
(WebCore::ImageInputType::appendFormData):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
* inspector/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
* inspector/InspectorOverlay.cpp:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultDatabaseFilename):
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):
(WebCore::CSPDirectiveList::addDirective):
* page/Page.cpp:
(WebCore::Page::groupName):
* platform/animation/Animation.cpp:
(WebCore::Animation::initialAnimationName):
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::defaultGUIFont):
* platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
* platform/graphics/filters/CustomFilterCompiledProgram.cpp:
(WebCore):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
* svg/SVGAngle.cpp:
(WebCore::SVGAngle::valueAsString):
* svg/SVGTransform.cpp:
(WebCore::SVGTransform::transformTypePrefixForParsing):
* xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processXMLEntity):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening on the 64bit build bot.

The following test cases don't crash so they should be removed from
WK2 TestExpectations file.
inspector/elements/event-listeners-about-blank.html
inspector/console/console-assert.html
inspector/debugger/debugger-step-out.html
inspector/debugger/debugger-suspend-active-dom-objects.html
fast/forms/fieldset/fieldset-crash.html
fast/events/keyevent-iframe-removed-crash.html

The following test cases pass only in WK2 so marked them as pass.
fast/loader/opaque-base-url.html
canvas/philip/tests/2d.text.draw.fontface.notinpage.html
editing/execCommand/indent-paragraphs.html
fast/animation/request-animation-frame-during-modal.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/frames/seamless/seamless-inherited-document-style.html
fast/js/names.html
http/tests/security/cross-frame-access-call.html
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html

The following test case is marked as known failure.
fast/events/tab-focus-link-in-canvas.html

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302

Reviewed by Chris Fleizach.

Source/WebCore: 

Changes the accessibility logic so that a generic element that's focusable is
not ignored for accessibility, and returns its inner text as its title. That way
if you Tab to the element, a reasonable accessibility notification is generated.

One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.

Also fixes logic that determined if an element was contentEditable by making
sure it catches the case with no attribute value (e.g. <div contentEditable>),
which also implies contentEditable=true according to the spec.

Test: accessibility/focusable-div.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests: 

Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.

Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").

* accessibility/editable-webarea-context-menu-point.html:
* accessibility/focusable-div-expected.txt: Added.
* accessibility/focusable-div.html: Added.
* accessibility/table-detection.html:
* platform/mac/accessibility/listbox-hit-test.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Move several files to remove webkit1 dependency from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=95264

Reviewed by Gyuyoung Kim.

Source/WebCore:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

No behavior change. Just a refactoring.

* PlatformEfl.cmake: Removed files which moved from sources and WebKit/efl/WebCoreSupport from includes.
* WebCore.gypi: Ditto.

Source/WebKit:

* PlatformEfl.cmake: Added files which is moved.

Source/WebKit/efl:

ColorChooserEfl.cpp, PopupMenuEfl.cpp and SearchPopupMenuEfl.cpp are WebKit1/Efl
specific files and they can not be shared with WebKit2/Efl.

In order to remove WebKit dependency from WebCore, this patch moves them
to WebKit/efl/WebCoreSupport.

* WebCoreSupport/ColorChooserEfl.cpp: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.cpp.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
* WebCoreSupport/ColorChooserEfl.h: Renamed from Source/WebCore/platform/efl/ColorChooserEfl.h.
(WebCore):
(ColorChooserEfl):
* WebCoreSupport/PopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.cpp.
(WebCore):
(WebCore::PopupMenuEfl::PopupMenuEfl):
(WebCore::PopupMenuEfl::~PopupMenuEfl):
(WebCore::PopupMenuEfl::show):
(WebCore::PopupMenuEfl::hide):
(WebCore::PopupMenuEfl::updateFromElement):
(WebCore::PopupMenuEfl::disconnectClient):
* WebCoreSupport/PopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/PopupMenuEfl.h.
(WebCore):
(PopupMenuEfl):
(WebCore::PopupMenuEfl::client):
* WebCoreSupport/SearchPopupMenuEfl.cpp: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.cpp.
(WebCore):
(WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
(WebCore::SearchPopupMenuEfl::popupMenu):
(WebCore::SearchPopupMenuEfl::saveRecentSearches):
(WebCore::SearchPopupMenuEfl::loadRecentSearches):
(WebCore::SearchPopupMenuEfl::enabled):
* WebCoreSupport/SearchPopupMenuEfl.h: Renamed from Source/WebCore/platform/efl/SearchPopupMenuEfl.h.
(WebCore):
(SearchPopupMenuEfl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AX: Canvas should have a distinct role
https://bugs.webkit.org/show_bug.cgi?id=95248

Reviewed by Chris Fleizach.

Source/WebCore:

Add new role for a canvas element, and a method to determine if
a canvas has fallback content, so each platform can decide on the
appropriate role mapping to use.

Test: accessibility/canvas-description-and-role.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isCanvas):
(WebCore::AccessibilityObject::canvasHasFallbackContent):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::canHaveChildren):
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper role]):

Source/WebKit/chromium:

Add support for canvas accessibility role.

* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:

Source/WebKit/win:

Map new CanvasRole to the same as ImageRole.

* AccessibleBase.cpp:
(MSAARole):

Tools:

Add support for canvas accessibility role.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(roleToString):

LayoutTests:

Add new tests for canvas role.

* accessibility/canvas.html: Deleted.
* accessibility/canvas-expected.txt: Deleted.
* accessibility/canvas-description-and-role.html: Added.
* platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/mac/accessibility/canvas.html: Added.
* platform/mac/accessibility/canvas-expected.txt: Added.
* platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK1] Unreviewd gardening. Skip failing css3 filter test.
https://bugs.webkit.org/show_bug.cgi?id=95308

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-29

* platform/qt-5.0-wk1/Skipped: skip css3/filters/null-effect-check.html after r126927.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126973 268f45cc-cd09-0410-ab3c-d52691b4dbfc