labofsahil/github-event-dataset-2012 huggingface dataset:
Maybe create bin/config-update-secret <cluster> <node> <number>? And it sshes to the machine and overwrites the existing secret file with whatever the ssh user has on their laptop?
Does this mean 15 mins was not enough?
There's nothing in the step that would hint that you're on the database page in a browser.  This seems out of place.
Lorsque les paramètres s'étendent sur plusieurs lignes, la convention est ainsi : https://gist.github.com/4124651
This is still missing a tag. E.g. `:tag => '0.1'`.
whitespace error ;)
All duplication removed.
Can you add a permission check so that we only show it when the user has permissions to access this page?
It seems so. Anyway, some explanatory comment here would be fine: might be misleading otherwise.
This is a bad idea. You have introduced coupling to the singleton here inside an object that should not have any knowledge of its existence. I would expect that the redirect request already includes the headers from the original request… but if it, the right thing to do would be to copy the HTTP headers dictionary from the original request to the new one rather than going back to the client.
Use the optional parameter syntax when calling parameters like this so it's more readable.
I think this works. Somewhere there needs to be a check that all of the unioned tuples have the same shape -- if that isn't flagged by the parser, it would have to happen here by comparing the children's outputSchema.

OutputSchema is generally an area that I think needs work.
Actually I wrote that code ages ago -- a lot of this stuff came from the Angle machinery I wrote for apwlib -- and it definitely needs to be updated. I agree with @iguananaut here, but I think it makes the most sense for him to issue a PR with that block of code on your branch.
I wonder whether this could be rephrased better - if people have FK5 J2000 coordinates, they don't want to use this class technically speaking. But on the other hand this should be the system of choice to represent coordinates given that it is much better defined.
rpc call is fine with me
Don't do this. Use the `after_create` callback.
Shouldn't this be conditional on !windows?
Oops wrong place to reply, that previous bit was for the throw/error switch. As to `try` vs `try/of`, the differences are subtle enough that I get worried about not remembering them correctly for each particular case. If you have a strong preference for the `try/of` I'll swap that out but this was just me thinking "I don't remember the specifics so write it the obvious way".
Hope this all sits with you OK. My current thinking is it may be best to actually hold on this code.  We are about to merge discussions and proposals into loomios.  I am not sure about the implications this will have on your code, but it may be easier to make this shift without extra navigation code to worry about. This is just my feeling though, I will talk to Jon on Monday and get his professional opinion. It would be cool to get these shortcuts in soon.
This should be done the new way: 

Given I am logged in
And I am an admin of a group
select 的 timeout 参数含义和 poll 是不一样的！
An underline is missing.
I suggest instead using a `github_api` flag, set to 3 by default.  That way, when they make a v4, v5, etc, the update code is cleaner rather than special-casing 'v2' only.
N.B. From the docs: "Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later)."

To my mind, that makes `NamedTemporaryFile` pretty useless. My usual workaround is to use a `TemporaryDirectory` and create a regular named file within that.
This page says IE9: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys
The workaround on that page looks quite ugly (dontEnumBug)
default_ref is expected to be const.
...Even though if `#ifdef`'ed out.
Should probably raise a `jinja2.exceptions.TemplateSyntaxError` here.
its the fastest way to remove the file handles from the form before the form is passed on to the next transformation.
"parameters" instead of "paramters".
I think we should leave all the changes in setupdb_app.py out of this particular patch. I made changes that restrict support to only 9.2. I haven't tested backward compatibility with 9.0 and our new schema dumps.
what if it's empty? That should raise the `BadArgumentError`
Yep, will add comment
I started in the Page model too. But, at that time, I thought I was going to work on the <i>email-user-to-update-profile</i> story as well. So, it made sense to create a generic ReminderHandler for managing such reminders. It would keep the models from getting bloated and that is also why I was using a generic naming scheme. In retrospect, it definitely goes against YAGNI.
This should help:

http://www.pyrocms.com/docs/2.0/developers/contributing-changes-with-git
Should use the explicit form here, see also #24.
Ok. Is there any need for any delay here? If so it would be nice to know why.
you could use `ArrayObject `s to avoid references.
Which method of FormConfigInterface would we then proxy and which not? I don't think this makes sense.
I would say that `strlen` is not in constant time. The computation time of this if-clause therfore still depends on the length of *both* strings. 

Also the computation for `(strlen($str1) === strlen($str2))` is more costly (because it does no fast-exit). Thefore an attacker can try an increasing length of password input to check for the length of password.
it is not, on that line $block is assigned a value, $ib is just assigned the same values as $block.
that's correct,  I fixed it in the `filterResponse` method
You should have a look to https://github.com/Gregwar/FormBundle/blob/master/Type/EntityIdType.php#L40
The component is up to date there ! :)
@tobion sure for me it is, but i am sure someone will ask that question for real.
oh. yeah. besides, I shouldn't have to put `export MAD_PATH=$HOME/.local/share/mad` in my .profile. mad should just use `../share/mad`. Ok, I figured it out., just gotta update my pull req... I'm still a github noob.

"hate how unix dirs are structured", yeah... heheh, those kinda comments jump right out at me now that I'm toying with a "new OS" kickstarter proposal :)
Even DOS has a better dir structure, organized by app.
No style guide entry, although this sounds like a solid rule and good candidate for a pull request.
tag menu
Add return 0; to remove warning.
Un-comment please.
I think he means the resulting string is not really English as we know it. ;-)
The benefit comes from making the *intent clear*, and the logic *more robust*.
 - `^` => the code will perform a logical XOR.
 - `is not` => the code is doing an identity check. *If* the values literally are True/False then that implies logical XOR. But if one of them is True/False and the other is 0/1 then `is not` just won't work. `0 is not False` gives `True`!
Uses FiberError because thread.rb uses ThreadError
This CSS file is generated from the corresponding style.less file. If the styles should be removed then they should be removed from the LESS.
haha I thought this might be mildly controversial, but that reaction is even better :D
Sorry, I'm not sure how to remove the dependency whilst we still need to check to see if the argument is an event (`instanceof Ember.$.Event`).

Can you elaborate on how to remove the dependency?  Cheers
Just to drag the discussion on further… ;o)

Returning `undefined` doesn't make it skip the cache, it stores `undefined` in the cache. `cacheFor` returns `undefined` in both versions of the code, one from the cache and the other because the function doesn't return anything.

I just noticed that `get` uses the `key in cache` check, so that's an argument for using that version in `cacheFor` for consistency sake - but in the end it all results in the same thing being returned so I'm not arguing for it to be changed back!

    Cp.get = function(obj, keyName) {
      var ret, cache;

      if (this._cacheable) {
        cache = meta(obj).cache;
        if (keyName in cache) return cache[keyName];
        ret = cache[keyName] = this.func.call(obj, keyName);
      } else {
        ret = this.func.call(obj, keyName);
      }
      return ret ;
    };

Again, all academic and this pull request now makes `cacheFor` behave the same as a `get` with a cached value, previously `cacheFor` would return `undefined` for falsy values but `get` would return the cached falsy value.

I hadn't noticed that inconsistency but it's nice that this fixes it too.
``BSD`` ``mktemp`` requires a full template name to be given or at least a prefix basename, unlike ``GNU`` ``mktemp``. With that fix, it will work almost the same way on both platforms:

- ``OS X`` (``BSD``): ``/var/folders/my/wbhq41n50vs3gvpyvjqn2xhm0000gn/T/tmp.XXXXXX.JzEHSLEB`` (Note that the ``XXXXXX`` are not replaced, being part of the prefix)
- ``Linux`` (``GNU``): ``/tmp/tmp.jbNIHc``
Log a WARN? (Same comment for the 1.1 and 1.2 variants.)
On :reload FrameworkActivator.create is called, which resets the static activated flag. If you like a can pass an instance of the FrameworkActivator to every client of it and get rid of all statics - the semantic would not change however.
@motaboy ok, thanks i just wanted to make sure.
That is correct. Without draggable, the title text can be selected. Which seems good to me.
Есть такой тип - "serial", колонка типа int с автоинкрементом. Лучше бы его использовать
ok guys, I'm sorry!! :p no need to jump on me!! :D Fixing it!
one var per line
If <code>moveMessage()</code> api is not ready, I think you can comment on TODO only without some code being marked.
It might be good to amend the comment then, especially as "we recommend" without a rationale is not really helpful.  For example, I think a reasonable comment might be:

"Synchronously load l10n resources to minimize flickering from displaying the app with non-localized strings and then updating the strings.  Although this will block all script execution on this page, we expect that the l10n resources are available locally on flash-storage."

Note that I personally think the synchronous XHR is a bad idea; better instead to just have the app display a fake loading screen (or nothing, via display:none) and clear it when "localized" happens rather than forcing the app to delay its initialization.  (Assuming it does delay it; I am unclear on whether synchronous XHR causes a 'script blocker' to be placed on the page or not while the nested event loop is spinning to service the synchronous XHR.)
alert? Is it on purpose?
Just curious that how do we decide the MAX_IMAGE_FILE_SIZE and MAX_IMAGE_PIXEL_SIZE here, are they magic numbers?
better if we delete logs from the release?
Could it be a constant, the iconURL?
This one looks weird grammar-wise.
Hum ... I re-read comment on #2033 it seem this module is needed for other functions in the future. If so this could stay, but I really don't like the usage of mozSettings.
just to be sure this is only a test from the root of the directory correct? I don't know maybe someone uses test/ deeper in.
You can use the new shorthand syntax and apply 100% instead of fixed height here: `url("images/btn_generic.png") repeat-x / auto 100%`
Any reason to use Recents instead of this?
Can be the size of the canvas defined in CSS? I don't know it's only a question
It was not working because during the first run this condition `(currentApp == homescreen && newApp)` was true due to currentApp and homescreen were null. Fixed with new refactor of this PR.
But see, it was good to add that test. ;-)
You should prefer [rspec `let` blocks](https://www.relishapp.com/rspec/rspec-core/v/2-11/docs/helper-methods/let-and-let) to member variables in tests.
@Kami fixed in 2cde85c
~~~
同様に "Every Month（毎月）" がデフォルトですがチェックを外せば年のうちの月を指定できます。
~~~

→

~~~
同様に "Every Month（毎月）" がデフォルトですがチェックを外せばその年の特定の月を指定できます。
~~~
Ок, перечитаю укр. вариант в ближайшее время. Большое спасибо за старания.

30 окт. 2012, в 13:37, Tima Maslyuchenko <notifications@github.com> написал(а):

> In config/locales/ru.yml:
> 
> > @@ -406,7 +406,7 @@ ru:
> >    error: "ошибка"
> >    errors: 
> >      messages: 
> > -      could_not_create_taxon: "Could not create taxon"
> > +      could_not_create_taxon: "Не могу создать таксон"
> @devilcoders я не очень силен в русской грамматике. Создавал украинскую локаль - параллельно увидел недоработку.
> Но думаю что вы прави, ваш вариант звучить лучше
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I get an `null` object error in this line. I think it is because the `createFinishLineImage` method from line 21 never gets called in the code base
This is a review comment
Admittedly my signal knowledge is poor - but why 11 and not 9?
I don't get why you have this argument and the login IP address.
Also add ``og_create_field(OG_ACCESS_FIELD, 'node', $bundle);``
What has this to do with the pull request?
Can you put a comment here describing azimuth?
added this, with closing `})(jQuery);` at the end
Now how to control lua related codes ?
This return statement is wrong. It does not return a consistent value.
I don't think we can always add the second sort option, because one time it's `posts.id` and the other it's `participations.id` ... or do you have something else in mind, that might be more elegant? :P
I wrote "pseudo code" for a reason ;)

that last warning is redundant in the sentence and start_with? is a method of String, nothing globally defined.
That was it. Somehow I missed that when copy+pasting. Test passes now! Thanks!
Again, remove the binary files.
Yup. It's super annoying to debug things. Wondering if we can let developers turn it on/off in conf?
Sure. I was going for it by mail but here is good too. TAILQ_FOREACH is equivalent to something like for(item; item != NULL; item = item->next). So if we do free(item) in the loop we access freed data when getting the next item. I've tried a coccinelle patch to detect the issue but I did not succeed till now.
maybe we can default to /opt/napatech3/lib/
set this to experimental if you think the config names/meanings are going to change in the future
Oh and in fact some defaults (that are useful) are actually provided like `@loader/options` and `@loader/unload` pseudo-modules.
I think we might be able to avoid iterations by using weakmaps, but let's defer that for the future.
I see, you're removing the need for underscore. However, when this is compressed into a single script, won't it have to parse the whole thing before it executes any of it?
we assume all of our deps will mount the heartbeat handler at the same location as we do.  fair enough.
Not for this pull request, but it would be great to re-use these constants in tests from the production code, so there is only one place to update them.
I agree, I just don't think we want *that* logger.  Cribbed from someone online...
I think PEP8 says the second line should just line up with the parenthesis. See the example in this section: http://www.python.org/dev/peps/pep-0008/#maximum-line-length
We should be consistent: `double` returns a `RSpec::Mocks::Mock`, `stub_const` should return one of the two classes you created. You've already got the reader: `original_value`
nope, check `app/assets/stylesheets/application.css` and `app/assets/javascripts/application.js`
add "safe_" to stats here and elsewhere to single these out...
prefer to specify this as a cmdline option rather than use JVM option
Strange, diff did not show different indentation. I'll fix it in next time.

Check for sh is done elsewhere.
I just copy pasted what Matthew did for other view helper. Same signature.
Take a look of #1550 to see how to transform PluginBroker in ServiceManager
Remove the test, instead of commenting it out.
Another option is using the `%include` feature of `hgrc`. From `hg help config`:

```
    A line of the form "%include file" will include "file" into the current
    configuration file. The inclusion is recursive, which means that included
    files can include other files. Filenames are relative to the configuration
    file in which the "%include" directive is found. Environment variables and
    "~user" constructs are expanded in "file". This lets you do something
    like:

      %include ~/.hgrc.d/$HOST.rc

    to include a different configuration file on each computer you use.
```
``if (null === $packagistName)``
typo in the name: ``canonical``
Spacing:

-> `this.addModel( TodoModel.NAME, new TodoModel() );`
Can you put `<for each="<%= data.tasks %>">` on a new line? Same with the closing tag.
your indent script made it happen... It was correct before I ran it ;-)
log.riaseException with proper message and excpetion class
i prefer an identifier for met office of mo (wmo suggest world meteorological organisation to many)
Do you mean by creating another one in ESTestCase? If so then it's because someone told me that that whole thing was bad practice.
This is somewhat worrying, given that makeValidEmailTests does not hang?
It looks like you'll only send trackadded for adding a new plugin track, and not a cue. Is this intended?
Ah, this is actually going to error, I think - author is always a pseud, so if you're on the user's main works page, it won't be set. (The author variables should really all be renamed to pseud so that this is clearer.)
`process.nextTick` ?
Why nested class? can't this go into its own file?
required same as os, unless deploying the a compure resource with image based deployment
You can `rebase -i master` and then exclude the changes you want. However, the functionality you've added is already in a Hiccup branch.
I do not approve of this diff. The imports were in alphabetical order, according to our Java coding standards. This is an unnecessary and incorrect diff.
I think that this should be an abstract class, so that we can define the methods while providing implemented helper methods. For example, we'll have to pass in things like ExecutionContext, NamespaceRegistry, and NodeTypeManager. We can actually use the repository's ExecutionContext, which should reflect the namespaces mapped by the repository and will not have any Session-specific namespace mappings; after all, the connectors deal with content.
Effective use of leet speak convinces me to incorporate this changeset into my codebase
Nope, the order of arguments is based on keys, and decided in protocol.py. Hence the "quotes" around last.
Missing initialization of $arrayLang variable
кажется тут и ниже много похожего кода.
nice tweak <3
remember, feed the monkey
Just to make sure I'm on the same page as you - the missing . before VideoFile and later before Video? Something about the "made available" wording?
`refinerycms-settings` is not required :)
I think we should leave it up to the actual REST endpoints to set default values. By doing this, worst case will be that params is

```
{
  'start': undefined,
  'limit': undefined
}
```

which is caught by request and not submitted to the REST endpoint.
We should probably change this to 2 spaces so it is consistent with the rest of the codebase.
Might be easier to just do a multiget with both global and the current tenant here ?
I'm struggling to see the use case for this function, although I might not fully understand it. If this does what I think it does, i.e. for a list of principals return all the items for a specific objectType for which they have a role, we might not really need it.
True true..
ah, i see you want to be able to return null. ok, lets keep this - but then update the doc on the RouteObjectInterface
The original is incorrect according to RFC's on Last-Modified http headers:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
I seem to remember seeing something about this on the list. As long as everyone agreed that this is the right thing to do, it looks fine.
Testing a fix if you're not sure.
What is the new equivilent of `'local'`?
случайной буквой может оказаться та же самая буква, что не является заменой.
"Мутирующая" буква не может изменяться на саму себя. Метод mutate из за этого меняет не СТРОГО X процентов
Неправильно то, что при замене скажем 20 элементов из 100, на самом деле заменится гораздо больше элементов. Так как при каждой итерации замены программа заменяет сразу два элемента. Тоесть если взять массив DNA и идентичный ему DNA1, потом мутировать на 20 элементов DNA1 и сравнить, то различие может быть больше чем 20.

Вот
2012-11-09 09:35:55.913 DNA[2376:303] A T G C // DNA
2012-11-09 09:35:55.915 DNA[2376:303] A T G C // DNA1
2012-11-09 09:35:55.915 DNA[2376:303] hamming 0 // разница 0, как и должно быть
2012-11-09 09:35:55.916 DNA[2376:303] mutate // Мутируем только DNA1, на 50% тоесть 2 элемента
2012-11-09 09:35:55.916 DNA[2376:303] До мутации A T G C
2012-11-09 09:35:55.917 DNA[2376:303] После мутации G G A A 
2012-11-09 09:35:55.917 DNA[2376:303] hamming 4 // Сравниваем DNA и DNA1, разница в 4, а должно быть 2
Нажмите вверху Issues, там единственная работа с Label 8/10. Обратите внимание, что Рахим явно сделал замечание по этому поводу. 
https://github.com/Hexlet/osx-project-1/pull/8
Можно за такую оплошность снять 0.5 балла.
@karguine @pingvin4eg простите, я думал, речь идёт об имплементации метода mutate. 

Всё правильно, тут привязка к DNALength не нужна.
You don't actually need to stub this, since is false by default
You should not use variables in a gettext call as the variable is resolved first. Instead use sprintf() to format the string e.g. sprintf(gettext("%d entries in this table."), $count). Also I find it quite strange that the link is (was) on the 'all' keyword and not on 'Delete'.
Why provide this here vs. the superclass?
Another comment on line 3
dist docstring missing
In the case where we default to "verbose=None" and have users expect "verbose=True" to /always/ write to the log is that it will require this type of logic in every logging call:
```
if verbose == True:
    old_level = logger.level
    logger.setLevel('INFO')
    logger.info('whatever')
    logger.setLevel(old_level)
```
Because if the user had the log level otherwise set to 'WARNING', any call to logger.info otherwise gets ignored.

I'm fine with doing it this way if necessary, but then I'm going to advocate (again) for us implementing a wrapper function so that if we decide to change the behavior in the future (or how we do logging), then the logic can be changed in just one place instead of hundreds.
Do we need the copy? Epochs never modifies the raw object, so this seems unnecessary and inflates memory consumption. Especially when raw has been preloaded and we do e.g. `epochs['left_visual']`, the whole Raw object will be copied (see @christianmbrodbeck  comment above)
Can you add a unit test here to make sure this doesn't sneak back in somehow?  It basically would just confirm that the void reason doesn't ahve anything else on it.  See https://wiki.openmrs.org/display/docs/Unit+Testing+With+at-should+Annotation for how we do the annotations, method names, etc for unit tests.
Hmm, it is not private because I use it in DeferringMustacheFactory.  I didn't add constructors with the failFast flag in that or the FallbackMustacheFactory.  I can either add them as well or I can just default it to false since we won't be using either.  Not sure which is preferred.
"with and example netmask" vs "with a typical netmask"
Kind of a long line. I would write:

var listener = jasmine.createSpy("...");
chrome.extension.onRequest.addListener(listener);

You don't need andCallFake. You can just create the spy and use the Jasmine APIs to check that it was called, with which arguments, etc.
and add the use statement so that the code can work when copy-pasting it
换用逗号吧
Не похоже, чтобы ты в этой и предыдущей функции использовал что-то из `LJXmlRPC`. Они — отличный кандидат на вынос в локальный неймспейс.
Ну зачем два раза же. Одного (в списке инициализации) хватит.
Ok, la deberíamos editar, pero si RavenDB falla, falla. Algo hay que hacer.
PuckmanX
Yes, it's been moved above the "private" line.  Seemed neater than explicitly declaring it public.
I agree.Fixing it in the next pull request. :)
I don't think this ```(when-not ...)``` expression should be *outside* the ```doseq```.

The idea here is that the caller can specify a package, package-group, or *both*.  If he specifies both, and the :select-package-group is clicked, what if the next thing is a package and not a package group?

The issue is you need to know inside the doseq which one you are doing.  You can just add a boolean:

```
(defn add-package [name {:keys [package package-group]}]
  (navigate :named-system-page-content {:system-name name})
  (browser click :system-content-packages)
  (doseq [[items exp-status is-group?] [[package "Add Package Complete" false]
                                        [package-group "Add Package Group Complete" true]]]
    (when items
      (when is-group? (browser click :select-package-group))
      (->browser (setText :system-package-name items)
                 (typeKeys :system-package-name "blur")
                 (click :system-add-content))
      (Thread/sleep 20000)
      (assert/is (= exp-status
                    (browser getText :pkg-install-status))))))
```
same here no consistency for getters and setter method name
rename this method to requireSetup ; why don't you have create this command inside the Alchemy namespace ?
Hi Daniel,
Thanks, but I think this does not cover all situations. Right now, you only check wether the contents of the field lead to a valid record, otherwise you use the placeholder. This does not cover the situation where the value is actually a URL string, where there is no longer a direct relationship to a record.

I propose the following:
First check if the value of the field is empty. If it is, show a placeholder; nothing has been selected.
If is it not empty, check if it is numeric. If it is numeric, we can assume it is a record id.
If it is not numeric, is must be a url.

This is the method I used in the Rails Admin implementation of this, here:
https://github.com/bastiaanterhorst/rich/blob/objects/lib/rich/rails_admin/config/fields/types/rich_picker.rb

What do you think?

Best,
Bastiaan
Following our conversation we concluded that the the cached space didn't have to be updated. That doesn't matter as the new code I will submit (once you've approved it) doesn't use the .add statement. ( sent you an e-mail )
Can you make them call consistent? It looks sloppy that one is `"` and the other is quot
Definitely. Nicely spotted :)
We shouldn't be casting this – we're destroying `const` safety.
seems to be a space missing.
But now it is *not* destroyed atexit, correct?
Note the change in scope. This fixes the obtuse message:

```
>>> import matplotlib.pyplot as plt
>>> import numpy as np
>>> plt.imshow(np.arange(12).reshape(3, 4), cmap='hots')
<matplotlib.image.AxesImage object at 0x25265d0>
>>> plt.show()
Traceback (most recent call last):
  File "matplotlib/backends/backend_gtk.py", line 423, in expose_event
    self._render_figure(self._pixmap, w, h)
  File "matplotlib/backends/backend_gtkagg.py", line 75, in _render_figure
    FigureCanvasAgg.draw(self)
  File "matplotlib/backends/backend_agg.py", line 433, in draw
    self.figure.draw(self.renderer)
  File "matplotlib/artist.py", line 55, in draw_wrapper
    draw(artist, renderer, *args, **kwargs)
  File "matplotlib/figure.py", line 925, in draw
    func(*args)
  File "matplotlib/artist.py", line 55, in draw_wrapper
    draw(artist, renderer, *args, **kwargs)
  File "matplotlib/axes.py", line 1998, in draw
    a.draw(renderer)
  File "matplotlib/artist.py", line 55, in draw_wrapper
    draw(artist, renderer, *args, **kwargs)
  File "matplotlib/image.py", line 359, in draw
    im = self.make_image(renderer.get_image_magnification())
  File "matplotlib/image.py", line 579, in make_image
    transformed_viewLim)
  File "matplotlib/image.py", line 202, in _get_unsampled_image
    x = self.to_rgba(self._A, bytes=False)
  File "matplotlib/cm.py", line 241, in to_rgba
    x = self.cmap(x, alpha=alpha, bytes=bytes)
TypeError: 'NoneType' object is not callable
```
I think there's already a function that covers this logic
А давай вынесем beginTransaction() в метод begin(), что бы при создании объекта он ничего не писал в базу, а только создавался
Не знаю что имел в виду Женя, но я понял это как некий интерейс для дтранзакционности в БД, сейчас у нас есть "BaseTransaction" и "DBTransaction" которые нигде не используются, ну собсно понятно почему )))
Вот за место них сделать интерфейс DBTransactional и дальше этот интефейс имплементировать в сам дравер и диалект )))

Лично я так подумал.
Almost all validators I've seen pass with a positive result, so I'd prefer to see this as `isValid`, `isAvailable`, etc.
Ok, I see that up in `locateWidgets`. It's pretty far removed from this function, though. I don't know this code well enough, but it seems like the widgetId could actually be generated in this method, then locateWidgets doesn't have to provide a default?
Should this text, including alt's be i18n resources?
some is wrong with indention here. and please use C as external parameter and internally use lambda = 1.0/C
silverstripe.log and debug.log aren't files generated by SilverStripe, so they will confuse more than help in this case.
I think the text disappearing was a bug which should be now fixed
Hele ty časovače jsou v tom seznamu 'timers' seřazený jak? Respektive ten, co má expirovat nejdřív, je na začátku (head) nebo na konci?
... yeah me neither, fixing that.
why should this return true if vanity is not collecting?
Please add newlines at end of file.
First, please check the IRC logs in -dev from yesterday.

Second, how do I package extensions for the test so that they can automatically be added?

Third, as I mentioned in IRC, I've already tested this on my own and it works. So far I've spent about 2 hours just trying to get the tests to run when I have everything set up, and so far it is needing a lot of work (adding objects to bootstrap.php for global use within tests, etc.). And even when I've done all that, it still doesn't work because for some reason unknown to both igorw and I, $db->sql_escape() (line 158 in the extension manager) doesn't return the value of the input. And yes, I checked that the input is not empty.

So yeah, this is becoming more work than it's worth. Yes, I understand the benefit of tests, but given that 1) the test framework doesn't want to work, and 2) I don't know how to package up the extensions for inclusion without putting them in the main phpBB area of the repo, this is becoming majorly counter productive.
I'm not sure about this... :)
- Is it possible to add a ``@param`` annotation for parameter ``$basepath`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
- Is it possible to add a ``@param`` annotation for parameter ``$urlparams`` which defines the array type; using ``array<SomeType>``, or ``SomeType[]``?
Bitte Zeile entfernen
I think it would be less brittle to just test for `Backbone.on === Backbone.Events.on`.
```php
<?php
$mapper = new DishMapper();
```
I wonder if this was originally done for the benefit of the CLI?
Since the loggers aren't an argument of this method I wonder if this is the correct exception.
The semantics of this `submit` are not consistent with TcpInput's: You can submit multiple events with this method.
You store width and height (bounds) hard-coded as global variables in Python. You use that for "within_box". And pass them to JavaScript. And use them to check if they are inside of bounds when map is displayed.
No no no. This is not good. What if openhours panel's ready function is run before the this one? You have to fix this as I described before.
I feel like `divide` shouldn't be defined for integers.
In [Growing Object-Oriented Software, Guided by Tests](http://www.amazon.com/gp/product/0321503627/ref=as_li_ss_tl?ie=UTF8&camp=1789&creative=390957&creativeASIN=0321503627&linkCode=as2&tag=ploeh-20) there's this point that we should 'listen to our tests,' because they often provide interesting insights if only we care to notice.

In this case, the need of a repetitive Fixture Setup of the `context` seems to tell us something, I think...
What units are measures and time_frames given in? Are we able to create normalised versions for comparison?
Can you make constants for all the possible units? See `CMPagingDescriptor` (both the .h and the .m files) for how `extern` works.
`nonatomic` plz
I think `storeOnlyKeys` needs a better naming. Actually, I'm quite against this one, the user should instead override the factory for such a particular use case imo...
He can still use our auth adapter and then his own storage produced by his factory... I'd completely skip this part if possible then...
I don't understand. This protects against `next` being called when `sort_order` has not been set.
topsponsor=Top Sponsors
Yes, it does depend on the scroll position. I don't think we really need a test for that as it's the documented behaviour of PhantomJS' `page.sendEvent('click' ...)` API.
yep, I doesn't have SD card installed on my otoro, therefore, |cleanup| will never return. I skip cleanup since the test case for factory reset doesn't require an SD card.
Doesn't that need a check for null?
I think we talked briefly about it, but is it really consistent to have an alternating text here? I think we have that nowhere else? We can't change the string for a while now, so it's probably the best option anyway.
There isn't a min version of each?
because I'm working here with ``res_trimmed`` : res_trimmed.resid  (from self.est_model fit) doesn't contain all observations, only the inliers.

So. I need to calculate the errors for the full dataset given by endog exog, not the one from the "trimmed" dataset endog[iin], exog[iin]

(aside: in the initial estimate with the random starting values ``iin`` only contains k_vars + 1 observations, not really all inliers.)
Named public profile to match omniauth-linkedin for easy parse.
> In case of conflict user may load only namespaced versions.

наверное это еще не сделано
you should add the leading backslash, otherwise the phpdoc is wrong. Here, you are using a relative class name, meaning it would be a non-existant class (same in ``@parma`` btw)
A very useless comment!
Am I right that this will just work for things on classpath that are accessible from the remote machine?
What are the limitations? e.g. would libs/*.jar be supported?
Worth documenting what's possible in the VanillaJavaApp.CLASSPATH
Jeg ville kanskje skrevet denne som:

Let's take a look at our login controller for an example of how to implement this sequential protocol.
I've fixed this with a new commit.
This is exactly the same as `login` but returns a different page. D'ya think we can remove the duplication somehow by returning the page object if it's a new user?
:+1:

On 9 May 2012, at 09:26 PM, jstraw
<reply@reply.github.com>
wrote:

>> @@ -136,7 +136,7 @@ def search(self, ip):
>>
>>
>>     def create(self, name, port,
>> -               protocol, nodes, virtualIps):
>> +               protocol, nodes, virtualIps, algorithm=None):
>
> Why set algorithm to None when you could just set it to 'RANDOM' if there isn't a one set?
>
> Then you could remove the "if not algorithm" section entirely as it's been done above.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/python-cloudlb/pull/22/files#r797744
Because routing specs are generally unnecessary. Controller specs and integration tests are the routing tests.
This is sweet :)
The Monolog doc should not contain Symfony-related stuff. It is a standalone library and should stay documented as one.
This example could go in a cookbook article of the Symfony doc though.
I was thinking that formatted message could be redundancy with all other data.
This also add the possibility to pass additional JAVA_OPTS
Я не очень понимаю. Я же вроде пишу, что этот extension не поддерживается. Нужно что-то еще?
То есть, большое название метода не должно означать использование расширенного  вывода?
`newForAllChromeWindows`
I think the Wait is OK but the locator was causing a problem because when you upload the same image a second time the background image url is not a url but a uuid hence my locator failed.
I revised to:
`div.preview div.preview-thumb[style^='background-image']:not([class~='error-loading'])`

I didn't experience the poor loading time that you suggested but it would fail more gracefully if you put a WebDriverWait into the __init__() to of the Media class , we can safely assume that we want the loading spinner to clear every time we click edit and instantiate the class.
This is strange to have in a open-source project. Please remove. Have the necessary files for test in something like src/test/resources (mvn default) and user GEO_CODING_HOME otherwise. So remove all the developer specific dirs.
I see thincloud-test as our configuration preferences for a test harness.
Or just missing "strength" content?
I agree. Let's see what you think about my above answer, if we end up throwing an exception instead of returning null, then it will be ok.
Perhaps a link to the PCA documentation in the scikit-learn or wikipedia
Could you use nose.tools's `assert_equal` here instead?
Sorry, I don't understand this. Can you elaborate?
space after `for` and before `)`
Not sure why we need a separate blackberry clause here, as the code is the same as for android.  unless this is to change in the near future, please just make a "if platform == 'android' or platform == 'blackberry':" clause
Is it right that the container would be NULL? Seems like that would be a problem. Otherwise, use `NULL`
Yeah, they're just NSObjects.
` : `  `: `
this should be

rowMem = owner.queryJob().queryRowManager()->getExpectedCapacity(initKeySize, 0) * max;

but it also doesn't take into account nested child records.
You also seemed to have lost the previous changes here.. where you avoid needing to inc. 'heapsize' and used 'i'
As mentioned above, isn't `signature` a required parameter. In that case, this `get()` method should raise a TypeError if you try to use it without a `signature`.
This can be an integer.
See? Finch is good! Finch does semver!
Please use `do...end` for multi-line blocks. Also make sure you're using two spaces instead of tabs for indentation.
This line dipatch strict warnings during tests: `reference to undefined property options.remote`
I agree, I will make another ticket for this.
Shouldn't this be `@user.name = ""`?
Thinking about this more, what's the point in the sanity checks here? The pagination value can just be passed directly to RequestConfig, and let it do the sanity checks (it already does some).
Somehow you've ended up with these methods twice.
I'm really not sure of the difference between udp_sweep and the udp_probe modules... sorry. But if both module are necessary, seems like udp_probe should be migrated to use the UDPScanner mixin too. If the purpose of the modules are the same, and udp_sweep has been migrated, and udp_probe not, maybe is a good time to announce udp_probe as deprecated.

Sorry if this topic has been talked before and I'm not aware of it....
```Post::File#exist?``` does this in a more portable way, please use it instead.
You should leave this as a reference under 'References'.
Let's use 2011/10/26, the date on which the Cython MD5 hash was implemented.
Moving this line up here will append `null` to the string, when null is passed, which sounds wrong. Why did you need to move it here? Perhaps there is a better fix.
Interesting. Again, this probably shouldn't have `?as=u`, that's a problem with the target. (And an example of why looking for specific targets isn't a great idea.) This is also hard-coded in the SUMO url configs, so we could just add a `test_redirects` module and test things like this and `/contribute`.
This part is all Stoner.
Explicitly return `undefined` since that is your intention unless @shunter advises otherwise.
I'm not sure why we did this.  Billboards are also this way so I probably initially coded it.  I suppose throwing an exception here is better.  For actual properties that can't be `undefined`, we usually throw the exception in `update`.
I used a method as value for 'extra_score' before but it threw me an error saying it needed a str or something. I'll see if I can fix it.
WCF Style is the only real one! :P
Don't think we support this in Android
Discussed this with Arthur and he will be re-writing this to better describe this behavior/bug for Android.
It would be good to have a description of ACLs here... But also OK to leave that for me in a later rev.
Yes, it's definitely that easy! :)
There is no predefined image size for the small image, using a div like that is to generate a preview of part of the image. Use img doesn't do the samething.
I think stylistically, true/false is clearer, and is easier to express in both ruby and json for overriding in role attributes (in case you prefer your roles one or the other), and less nuance about whether its on, off, true, false, 0, 1, whatever.

This should be added to the readme though.
You're absolutely right on this one; I hadn't had enough coffee yet. Carry on!
Ok. I just talked to @rcoleman about this and he explained that `${name}` can't be unique because in this resource it evaluates to `$docroot ` which can be the same.

@akumria changing the title back to include the original information
Let's keep JS convention and call it `logAs` or `logMaker` or something.
уже нет
test test comment
You only use `$this` once... you could just do `var $parent = $(this).parent();` and remove this line.
please use doxygen for this... see http://paparazzi.github.com/docs/master/styledoxygen.html
I know that these are just unit tests, but please use camelCase, not PascalCase for enum names. That's the naming convention that Phobos uses. Types and eponymous enums which result in types are named with PascalCase, but pretty much everything else is camelCased.
And, qualified of delegate type is not formatted?
Added! Except, if someone new to the project comes along, and accidentally checks in .DS_Store, that's also confusing. I don't think it's a big issue, because developers don't live in .gitignore.
Can you add the proposal_dependencies method, e.g. like : https://github.com/dellcloudedge/barclamp-glance/blob/master/crowbar_framework/app/models/glance_service.rb#L18
The collection line I added in exchange for the following lines I removed from UploadMockServer in TestClientsEngineStage:

```
// Note: collection is not saved in CryptoRecord.toJSONObject() upon upload.
// So its value is null and is set here so ClientRecord.equals() may be used.
uploadedRecord.collection = lastComputedLocalClientRecord.collection;
```
Simply because it seemed neater to me. I assume the reason it was not there before was because we are uploading to a clients collection and don't need to write it in every record on the server? If so, I'm happy to remove it.

The lastModified line I added to help test `handleWBO(CryptoRecord record)` in the download delegate. The delegate accesses a downloaded record's `lastModified` field so I use `toJSONObject()` in my `DownloadLocalRecordMockServer` to pass down a record with a lastModified field.

Perhaps this was not the right place to make this addition? Should I instead be creating a "modified" key/value pair from within the MockServer?
Why are you not writing into `writtenFolders` here? In fact, what is `writtenFolders` actually for? I don't see anywhere that it gets used.
This entire layout thing needs to be redone. We shouldn't have css classes like "two-lines" (and I'm not sure if we even need address containers when each field as extra boxes around them (and there's a field wrapper). I would try to reduce this to as minimal as possible.
Shouldn't this be /^Lacuna::DB::Result::Building::LCOT.?/ unless the T may or may not be there? Maybe you don't want to allow stealing of LCOB buildings?
Using .nutrans files so nuspecs are built at build time.
s/Patiends/Patients/
Ok it makes sense ;-) ParamConverter's listener has priority '0' so it will be necessary to change FOS Format Listener priority to hmhm... '2'? Will it be OK?
This line was just removed to contrast with the blank line below, not because it _shouldn't_ be here.
Spaces should not be needed, but I sometimes add them anyway, might just get rid of them...
trim white space here pwease
I don't think you want to pass packet_data to this function.
you shouldn't remove `if (trace)` as checking the static constant will always be better than actually invoking the tracef method
Should be single-quotes
With NBST we'll send the lock info and the state separately, so it would be cleaner if we had two different StateTransferControlCommand types: APPLY_STATE and APPLY_LOCKS.
`CommandError` shouldn't be raised here, there's no guarantee this object is only used from a management command. Another sign that this code really is a concern of the management command and belongs there, not here.
This else clause is just wrong. Who knows what these other versions might be, and whether the declarations would be correct for them. The right way to do this is to have

    static assert(0);

for the else clause. Even better, revert to the previous version which is correct by definition for all versions.
We can use $class->test if we are using at least PHP 5.3
Do you mean using quotes in print()? Using quotes does interpolate the array and print one item, which is the string produced by interpolating `@synopsis` (that string is basically the contents of `@synopsis` separated by spaces). Otherwise, print takes arguments in list context, doesn't it? (http://szabgab.com/scalar-and-list-context-in-perl.html). I have tested it and It does produce the correct output.
Inside payloads we also add the messageId and the URL, so we are modifying it. We can send that payload and not the whole object.
That's right !
Not sure if I should add an option for that, because `Zend\Version::getLatest()` will fail on systems with `allow_url_fopen` set to off.
Property doc should always start with "Gets" or "Gets or sets".  It sounds stupid, but it's very useful information for determining via Intellisense whether or not a property is writable.
deal with this
Good catch. In the context this test runs its not a problem but it's still bad form. I'll change this.
maybe we should rephrase this to "Tested to work with mysql, postgres and sqlite". seems something has to be done for each database in the end.
Yup, ignore everything I've said - you're absolutely right.  Apologies.
Technically a GCS subscription verification email.  We haven't actually wired up that functionality at the ESP's whether they even offer it.
Yea, I gave it some more thought and you're right. Though you might want to write:
this(method, null) 
rather than explicitly calling super.
There's two options, either define a new message type or just set the fields to be null. I think the null options should be sufficient since we can get the rpcAction to fill in the blanks after it is received from the controller.
And the do without this patch?
Tengo que investigar la API de guava para ver porque contains no usa el equals redefinido ¬¬ o si podría usarlo eventualmente.
поехала табуляция
Was this necessary? Trying to understand what the difference is between " and ' when used this way...
Regina, 

Is there a reason that an exception shouldn't be thrown here?  Could you document that in the pull request OR add the exception back?

Dave
css reset mojood dar pooshe asli ezafe shod !
How about using ```if not actee.user.organizations.exists():```
why use tempfield? couldn't you just do :
```python
field=FIELD_TYPES[question.question.field_type]()
field.choices=get_choices(question.question)
```
then you can skip line 95
Done:
https://github.com/telefonicaid/Gaia-UI-Building-Blocks/commit/cb3e7dc31dd4dd22b332aa53fae32b7a8ec1a643
тут тогда тоже exceprion, как при создании картинки
Should be ``auto_query``.
Fix dporssi.
Ditto re what kind of units?
Checks the length of vars, if it's equal to 1 it passes it by, if it's NOT equal to one it enters the forloop to construct outstring.
Changing eric's command? Thats like asking for war ._.
If i accept this he's gonna chop my head off, burn it, and eat it.
That's fine, I'll pull them in.  Thanks for the feedback and the PR's!
Might add a quick comment here //Remove leading dashes [--]
Is the header itself really supposed to "ease" in? (I'm being picky, feel free to correct me if it is).