labofsahil/github-event-dataset-2012 huggingface dataset:
I'm honored of being of help.
As I understand, you are adding python-beautifulsoup as a dependency.
After your last commit, nothing changed in here.
So I tried: aptitude install python-beautifulsoup and now it continues further until:

Unhandled options: object, object-subrequest
Cloning into 'git2changelog'...
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
make: *** [vendor/git2changelog/git2changelog.py] Error 128

Is it a key problem on my side I guess?
Should you add the beautifulsoup dependency in the doc before the build?
BTW, I am running debian testing system, not a freedombox (I will!)
No problem Pablo, my pleasure.
ooh... nice
Why don’t you like uppercase letters here?
Meter esto lo mas rapido que podais, que esta noche lo testeo con la raid ;)
Why the change?

Foursquare says the page is still /oauth2/authorize
heh. I'm making a sweep and updating all my `.g8` templates to use the newer `ls(user, lib)` support in defaults.properties so I don't have to manually update these any more. I was having a hard time figuring out what exactly the latest version for the web plugin was. I don't think the maintainer is following the conventions `addSbtPlugin(... % ... %...)` expects which is a pitty but I'll figure it out. Thanks :)
If would be much easier to read if this was all in 1 PHP block, like:

    <?php
      if ($_POST['num1'] && $_POST['function'] && $_POST['num2']) {
        if ($_POST['function'] == '+') {
          $subtotal = $_POST['num1'] + $_POST['num2'];
        } elseif ($_POST['function'] == '-') {
          $subtotal = $_POST['num1'] - $_POST['num2'];
        }
underworld building still shows % up to 50
Suggestion: you should probably call your directory `samples` (lower-case) and not `Examples`.
The fix looks good to me.
It's not very clear from the test what it's supposed to be doing or why though.
Made some comments that should clear it up a bit.

Thanks!
Will blog.posts work for a blog with thousands of posts? Will it retrieve all posts? Should we use find instead?
Clarity, an individual line in a stacktrace, and because lines are cheap :)

(Really all subsequent uses of newRecord should be rec.)
I was assuming even where variable size rows were in use, the client of the memory manager might be able to suggest sensible chunk sizes.
cleaned up relay packet
thx,
followed the change in other device repos
like https://github.com/CyanogenMod/android_device_htc_bravo/commit/756d84d8cc9b4c83887d65c2c0641376d3a4ec1d

for leo:
https://github.com/cmhtcleo/android_device_htc_leo/commit/60e8019aa32e01b4c8152e2c7d1570c851b63b92
Nice!! Maar waaraan lag het nu precies dat je soms door muren heen kon?
PaginatorMixin is missing in mixins.__all__
Yeah, so how did the wait make it work?

On Wed, Feb 15, 2012 at 2:27 PM, Aaron Schlesinger
<reply@reply.github.com>
wrote:
> I #fail
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/stackmob/stackmob-java-client-sdk/commit/039044dadbb8bbb69bdce1e429a3de290f043132#commitcomment-971624
¿Qué pasa si el candidato no tiene foto?
Thanks for catching that.

(note: in a pinch you could just have used an empty header, but this is obviously better)
is_object?
Disregard me, I forgot my own principles.
Whoa! Way too verbose for stuff in `Rag.agglomerate()`. Please wrap into a function, e.g., `def update_frozen_sets(self, n1, n2)`.

I also think it might be clearer to use a copy of `self.frozen_edges` so that you don't need to use so many steps. That is:

```python
for x, y in self.frozen_edges.copy():
    if n2 in [x, y]:
        self.frozen_edges.remove((x, y))
        if x == n2:
            self.frozen_edges.add((n1, y))
        if y == n2:
            self.frozen_edges.add((x, n1))
```
Oh.. that's cool. Thanks Myron! I guess I don't have any use case for this
then!

On Saturday, December 8, 2012, Myron Marston wrote:

> In lib/vcr.rb:
>
> > @@ -172,6 +172,17 @@ def use_cassette(name, options = {}, &block)
> >      end
> >    end
> >
> > +  # Checks if a cassette exists in the cassette library directory.
> > +  #
> > +  # @example
> > +  #   VCR.cassette_exists?('my_cassette_name')
> > +  #
> > +  # @return boolean
> > +  def cassette_exists?(name)
> > +    file_path = File.join(self.configuration.cassette_library_dir, "#{name}.yml")
> > +    File.exists? file_path
> > +  end
>
>  Could you point me to the right direction?
>
> Did you see the links I included in my comment above?
>
> I'm basically changing a sleep to be longer if the cassette *does not*
> exist (it makes an API call out and waits some time if the thing it's
> trying to get isn't ready). The tests are much longer without being able to
> check.
>
> Honestly, for your use case, it sounds like using a hook might be better:
>
> VCR.configure do |vcr|
>   vcr.after_http_request(:real?) do |request|
>     sleep 2
>   endend
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/vcr/vcr/pull/232/files#r2356452>.
>
>


-- 
Ramon Tayag
I discussed that with @papandreou and we thought it wiser to keep a (correct) count along the way in case this gets turned into a stream at some point.
Is that a future possibility? Otherwise I'll just make the change you proposed right away.
I just realized this isnt going to work when types are able to be cat to each other.

http://play.golang.org/p/sfBQd4V3x1
scripttest does create `$TMPDIR`, so long as you call clean(), which it does as part of its setup. `TestPipEnvironment` overrides that and does *not* call clean(), presumably as an optimization, so I think the fault lies with `TestPipEnvironment`, and that's why I've fixed it here.
Yeah, I think that's a great idea—sometimes it can be confusing to know where to look. The only downside to doing this is that if Twitter change their site layout the instructions will be wrong, but that's not a big job.

I'll work up some changes that walk through the process using `Launchy` and add them in here soon.
Yeah I think that's a reasonable way to do it—Am I right in thinking that this means we won't need that first set of instructions for creating an app? i.e. that `t authorize` should just ask for the key/secret straight up (although maybe still keeping a call to Launchy at the start to open the list of the user's apps from which to get the key/secret)?
Why isn't MAX_WAIT_TIME defined as a Duration in the first place.
MAX_WAIT_TIME naming is not scala style.
No need for the braces here.
Yeah, Viktor noticed the same. Will change to message.
Is it still testing the same things, if so, LGTM
auc ctor
Why is there a StatsMessages and Messages interface that looks like the same? The same question for TransformationMessages. Is this something specific to Java usage? I do not see Messages imported, or linked from docs.
Symbolic names ftw
Actually, this will blow up if they don't exist.  I'd need to user fetch_or_new_trait.  I think they have to have an ID, though it may be trash.

Not sure, ties in a little with the issue of non-simple? cards with codenames for all parts.  I think we should give them codenames, but that's a medium sized change.
Not sure why we don't just do this when we parse the translcusion parameters, maybe I'll see how that goes ...
No, the point is you can test it for existence with nil?, it will return the card if it is real.  Would you suggest a ! postfix for the one that does the 'new' (below) and make this one no postfix?
Wait, now you have me confused.  The green is the code going in and it has the 'info', which is what you want, right?  You probably fixed this.
```php
  DB::delete('widgets')->where('name', '=', 'menu/'.$menu->name)->execute();
```
instead

```php
  DB::delete('widgets')->where('widget', '=', 'menu/'.$menu->name)->execute();
```
Ah, yes, that makes sense. That's fine then :)
Curious mixed spellings of "canceled" vs. "cancelled". It's not uncommon to find discrepancies within a project, but it's fun to find one assigned to the other!
Technically, else is supported:

"Each item in turn is assigned to the target list using the standard rules for assignments, and then the suite is executed. When the items are exhausted (which is immediately when the sequence is empty), the suite in the else clause, if present, is executed, and the loop terminates.

A break statement executed in the first suite terminates the loop without executing the else clause’s suite. A continue statement executed in the first suite skips the rest of the suite and continues with the next item, or with the else clause if there was no next item."

In this case, it's technically not needed since there aren't any breaks in the loop, just returns. 

The "return None" part is needed, it's the end recursion state. In the event that a directory is found that does not contain the searched for file either in itself or its sub-directories, it returns None so it's not added to the running list of directories (line 191).

The else is used for 2 reasons:
1. Clarity to show it only returns None if the list of contents in the directory is exhausted without finding the match.
2. Because there are so few cases that I can actually use else on a for loop and it felt kinda cool. I'm not gonna lie, this was a big factor. :)
This one is a bit fuzzier from the PEP-8 point of view. It's not multiple arguments. But they do mention that for continuation lines they should be indented enough such that they don't blur with the lines below it. At very least, the second line here should have 4 spaces of indent.
Same with the mixed quotes
This was missing in my develop too.  Your develop was missing more than just this one
This is where the binding happens, and this triggers the save_with stuff and validations.
would it make sens to compute all of these once only and store it in the Table?
I think some systems expose a aplay -L pcm called spdif, think it shouldn't hurt to add it?
This seem overly complicated. Why isn't AE_FMT_S16NE  defined to AE_FMT_S16BE or AE_FMT_S16LE based on WORDS_BIGENDIAN format from the start?
этот метод не нужен. Нам не нужно фильтровать по признаку наличия запасов на складе. get_active_warehouses достаточно
Useless: already included in 
/datasource/{0}/table/{1} *:GET/*"
Can we add these to gitignore and just make sure our deploy process compiles?
I think I'm missing your point... you want this:

<code>
public function log ($level, $message, array $context = array())
{
    $this->log($level, $message, $context):
}
</code>
These param directives are a good place to put units. I guess the units of amt should match the units of supply_ , but it could be worth specifying that explicitly.
It might be possible to prettify it a bit more:

    ActorRefProtocol.newBuilder.setPath(
      if (ref.path.address.host.isDefined) ref.path.toString else ref.path.toStringWithAddress(defaultAddress)
    ).build()
you should add spaces around the ``+`` operator
I hate to be last every time. Have been for over 20 years.
The first part of this check seems unnecessary. The count should be zero by definition, since we just removed all its objects.
Why was `12` chosen?
Incorrect indentation from here down.
A view controller should never do this to its own view. It will result in unpredictable autoresizing behavior when embedded into something else.
Thanks for updating your pull request. I should have spoken up before, but in your previous commit you were simply being consistent with the header view code that was immediately before your code. Sorry to make you have to create another commit, but can you either revert this section back to the previous checks to match the style above, or alternatively update the header view code to match this?
In this case the WSF_FILTER_HANDLER ... would be specialized for WSF_URI_TEMPLATE_HANDLER
We might need to review that aspect.
Вот так делать ненадо.
Теперь compile для watch всегда возвращает анонимную функцию.
А watch ее оборачивает

У тебя должен был появится еще один if а за ним обертка "fs.writeFileSync(file_name, 'var ' + file.replace('.xml', '') + source, 'utf8');"
Proč?
Unnecessary empty Javadoc block. Let's remove it.
I don't think it's a good idea - what it is testing? Fixed order of values in the hash? Why would we want to test for that? You yourself can see that this leads to a lot of changes each time method is added, why do that? I thinl %d's should be left alone.
No. It's just a word I get used to.
Ok, I couldn't spot it being used in the code.
We can't hardcode Active Record here. Maybe we can provide a hook named `runner` as we did for `rake_tasks`, `console` and so forth. You can find their implementation here:

https://github.com/rails/rails/blob/master/railties/lib/rails/railtie.rb#L136

WDYT? Thanks a lot :)
Please move this to AC::Rendering or AbsC::Rendering? I would say AbsC::Rendering.
Remove extra space after assert_equal
Perhaps you'd need to add another test to check merging a HWIA to another HWIA, where the super call would take place right?
This exception can be raised very early in the bootstrapping sequence of sympy. Importing from sympy.utilities cannot be assumed to be safe at this stage.
This can be written as just `val treeInfo.Applied(fun0, targs, argss) = ann`.
The docstring could be clearer. What about:

    Represents the optimization result.

    Common attributes
    -----------------
    x : ndarray
        The optimization solution.
    success : bool
        Whether or not the optimizer terminated successfully.
    status : int
        Termination status of the optimizer. Its value depends on
        the optimizer. Refer to `message` for details.
    message : str
        Description of the cause of termination.
    fun, jac, hess : ndarray
        Values of objective function, Jacobian and Hessian (if available).
    nfev, njev, nhev: int
        The number of evaluations of the objective functions and of its
        Jacobian and Hessian.
    nit: int
        The number of iterations performed by the optimizer.

    Note
    ----
    This is essentially a subclass of dict with attribute accessors.
I agree it would be nice to use a single dummy user record if necessary instead of a new user record for every guest order.  Perhaps the new user record for guest orders has something to do with promotions though?
True – forgot about the case where someone would not include the promo component.
This is not the case. Not imaginary does not imply real.
-1 to arbitrary and unnecessary limits.
Again, perhaps deprecation worthy?
@ellisonbg I am guessing you were commenting on the _generate_outer_prod in tensor_product.  I plan to remove that function.

The function here is just to reuse code needed within the for and if constructs.  Am I in sync?
This can be, `if base == 1`, I believe.
```
from sympy.ntheory.residue_ntheory import int_tested
a, b = int_tested(a, b)
```
why the extra div here?
Should be OK then.
`intval($attr[3][$id])` => `(int)$attr[3][$id]`. We use Type Casting where it possible. @samdark Am i right?
Er, its not really encrypting much.
this `hsStrcpy` will need to go away once fFileName is a plString
Written out directly, the line still isn't any wider than what fit's in GitHub's source code viewer. Not sure it's worth it here.
This file contains actual changes in addition to s/^I/    /g. Introduced SQLReporterBaseTestCase and SQLReporterDiscoveryFailureTestCase.
OK. dropped.
Please, use "RecipesController" instead.
> our Rakefile requires `bundler/setup`

That's a cute trick. I shall remember.
This should be more explicit about the clock skew issue and that it only pertains to OS X. But it's not a show-stopper, we'll address it in a follow-up commit.
Fair enough - maybe then you could put the comment about the `datetime` case on a separate line within the `else` block - I think this would make it explicit.
There's no mocks here--we're just verifying that we don't actually alter the given response. But as it looks like I'm going to have to alter the filtering mechanism, this test will get re-done anyway.
Not a big fan of the raw int here, maybe store the full-on UP_TO_DATE/FAILED/CANCELLED strings in the DB? Or have a reverse-resolve method in ScanStatement that returns a PairScanState?
This comment needs to be addressed and removed before this patch can be merged.
Maybe brunoais is right in storing node in variable. Well, it maybe does not make bug difference now, but it is at least more extensible for the future.

btw, shouldn't quotes be used in selector?
```js
$('textarea[name="message"]').val();
```
(I know it will work without them, but according to my knowledge, quotes should be used if it is string.
They are no longer present in develop. I can extract a separate PR if desired.
It was changed from data() to attr() while the jquery PullRequest was made.
Indentation here?
Then, also the logic behind these SQL statements should be explained: First an UPDATE is tried which can fail if such as row already exists. Then a DELETE removes the leftovers.
sql_fetchrowset() or use the while loop instead of the foreach
nope, its `ARP  - PRODUCT - ICON` an identifier used by WiX
Why not just have it call self.log(...)? the c:getLog()("STUFF") is sort of ugly.
Can we actually make this string be something like "Handling %.2f requests per second". We should try to keep statuses human readable (although statuses on failed checks are more important).
There should probably be a generator function that builds these two functions and takes either Bundle or Binary as an argument.
https://github.com/uxebu/guides/blob/master/coding-style.md#errors
This was just moved from a different location in the file.  The logging subsystem needs reconsideration, but that's outside the scope of the pull request.
The default value is actually 10000 as per the original hard coded value.
Sure thing. Noted :)
argh, looks like the `@test` macro breaks when the expression includes quoted parts...
that's correct... Infact while making on-the-fly patientlists, even name and description is not required. Only searchQuery needs to be part of the GET call through the URL
This is not valid python 2.4
This type is meant to have no satisfying elements. I don't want to allow float32/float64 NaNs because that kind of implies it's a float32 or float64 in some way. There is no NaN for int dtypes so I couldn't make a mixin version that is consistent across all dtypes and allows them to be explicitly set to the value NaN. I just pushed a new commit changing the name to NullType and raising ValueErrors saying that no value is permissible.
what if the n_threads is too big?
around here it would be good to define a new variable like

  out_shape = (len(idx),) + x_orig.shape[1:]

That subexpression appears several times below and clutters the code.
I am sorry that I do not get your idea. I should ask you tomorrow in office.

---
Not done(xin).
Clarity: release number vs. release no? 
Spelling: omitted vs. ommitted
Grammar: Too many ambiguous 'it's, suggest: "If omitted, will be read from version.txt."
Why have the accessor at all?
なるほど、エラー処理を追加してメッセージで出力して、可能ならrmというロジックの方がいいですね。
This whole file could be as well a single line of code.
`application:unload/1` has been known to do strange things in the past. But, I think that may have been before we started running each app's eunits as a separate rebar invocation. If it passes all platforms now, we can return to its debugging when/if necessary.
The headers being set in the request creation are ones set when the client in instantiated, if the user wants to overwrite these variables you would want to set them after the default server/header variables.

```php
use Goutte\Client;
$client = new Client(array('HTTP_USER_AGENT' => 'foo'));
$client->setHeader('User-Agent', 'boo'); //Will overwrite foo
```
Whoops. `[^"]+`. Try that.
Can you add a docblock here that has ``@return array``?
`i` should remain on its own line here.
palloc0 is also in danger.
The way you've crafted your `def install` works I suppose, but there are three suggestions I have based on my experience crafting cmake formulas and the cmake man page.  Homebrew uses `std_cmake_args`, I would build out of source (OOS), and I would put the source dir last like this:

```rb
def install
  args = std_cmake_args + %W[
    -DCMAKE_INSTALL_PREFIX=#{prefix}
    -DDEFAULT_CONF_PATH=#{etc}
    -DDISABLE_SCTP=ON
  ]
  args << '-DALL_EXTENSIONS=ON' if build.include? 'with-all-extensions'
  args << '..'
  mkdir build do
    system 'cmake', *args
    system 'make'
    system 'make install'
  end

  other commands to move directories that possibly are subdirectories
  of the new `build` dir.  CMake puts a lot of things below that.

end
```
`depends_on :libpng`

because it's smarter than just build libpng.
You're right.
I'll find a better solution, something like using setAttribute.


On Nov 29, 2012, at 12:43 PM, icewind1991 <notifications@github.com> wrote:

> In settings/js/users.js:
> 
> >  		tr.find('td.groups').empty();
> >  		if (tr.find('td.subadmins').length > 0) {
> > -			var subadminSelect = $('<select multiple="multiple" class="subadminsselect" data-placehoder="subadmins" title="' + t('files', 'Group Admin') + '">');
> > -			subadminSelect.data('username', username);
> > -			subadminSelect.data('userGroups', groups);
> > -			subadminSelect.data('subadmin', subadmin);
> > +			var subadminSelect = $('<select multiple="multiple" class="subadminsselect" data-placehoder="subadmins" data-username="' + username + '" data-user-groups="' + groups + '" data-subadmin="' + subadmin + '" title="' + t('files', 'Group Admin') + '">');
> These 2 changes will break things if the values have special characters in them
> 
> —
> Reply to this email directly or view it on GitHub.
>
You should use `OC_Helper::linkTo` here.
You can actually set this to self.message_store.redis too. I'm think the cache should have a sub-redis store that's passed in though. Am I right in thinking the message_store is here mostly for use in the unimplemented `.reconcile()` method? Maybe message_store and a sub-redis should be passed in?
Probably worth mentioning an example advanced copying for packages and package groups with filters as well.
Ew, that's a pain to have to account for.
ah ok.. hatte vorhin gregor gefragt obs möglich wär vom autoloader auszuschliessen..
So while doing this conversion I did find one advantage of using ```<package>.<symbol>``` imports instead of ```<module>.<symbol>```  or ```<package>.<module>.<symbol>``` with the package based ones since you are using ```from <module> import *``` at the package level you can only pull in items that are in __all__ (or using ```@export``` decorator)
It's an outdated diff (i.e. comment on a line of code which has been modified). You should still be able to find it in the issue

On Sep 10, 2012, at 11:30 PM, Pablo Hoffman <notifications@github.com> wrote:

> In scrapy/contracts/default.py:
> 
> > +# contracts
> > +class UrlContract(Contract):
> > +    """ Contract to set the url of the request (mandatory)
> > +        @url http://scrapy.org
> > +    """
> > +
> > +    name = 'url'
> > +
> > +    def adjust_request_args(self, args):
> > +        args['url'] = self.args[0]
> > +        return args
> > +
> > +class ReturnsContract(Contract):
> > +    """ Contract to check the output of a callback
> > +        @returns items, 1
> > +        @returns requests, 1+
> I can't see that comment on github now, did you remove it? On Mon, Sep 10, 2012 at 6:24 PM, Alexandru Cepoi <notifications@github.com>wrote:
> …
> —
> Reply to this email directly or view it on GitHub.
> 
>
Yeah that would be a good idea :)

About the strong opinion, maybe we could check if the controller responds to `set_auto_crumb` or some method like that and call this code otherwise.
It would allow easy overriding but let the behavior by default. It would have to be documented correctly so it's clear for the users :)
And rename this to `attributes`
After you get rid of `first_new_id` per the above comment then this looks good for merge and install.
Capitalize @parameter
I don't think this belongs in the project, you can create a global gitignore and put this in there.
On a super low level, I'd be interested to know what gets optimized more; doing the `>` and returning a boolean vs. NOT doing the extra arithmetic and just returning `@observers().length` which would result in an int getting passed around. I would GUESS that, counterintuitively, the latter would actually be slower since now all comparisons need some kind of bool cast... anyway, </rambling>
I was tempted to edit the English root locale, replacing *Today* with *Nowadays*.
We explicitly handle this in ``EditorManager _showNoEditor()``. An editor will always have focus unless we have zero open editors. ``onBlur`` handling will matter later when we have a more cohesive focus story for all widgets.
This captures the locale at startup, but does not track any changes to the locale made by the user from the _Debug > Switch Language_ menu item. You'll need to update brackets.locale in DebugCommandHandlers.js too.
I think the .done() and .fail() callbacks should be vertically aligned to make this code easier to read. I haven't verified this passes JSLint, but something like this:

    parseLessCode(content, url)
        .done(function (css) {
            result.resolve(addInlineStyleSheet(css));
        })
        .fail(result.reject);
Did you want to swap in the upgraded regexps that Glenn came up with, or wait until later?
Why isn't this in a makefile which is then called from here?
Oh, I see. It's a bit of a hack but I get it now. Eventually might want to have it so that `default_text = None` is equivalent to autoselecting the first option if none is specified, and then you could put both in the list. Carry on...
+1. Personally, after I started always using brackets for one-line conditionals, it makes it very slightly more difficult to read code that omits them, because I notice the syntactic difference and have to suppress the part of brain that wants syntactic differences to correspond to semantic differences.  And you will definitely get bitten by what Danny said on occasion.


I like this answer, which advocates only leaving out brackets if you can fit the statement on the same line as the condition.  http://programmers.stackexchange.com/a/16530  Sort of like with ternary expressions, where I'd say that if they're not easily readable on one line it's better to just do an if-else block
Ok, I'll revert this. Not sure why I thought `el-get-update` was meant to be synchronous. Probably because #653 could have problems when updating multiple packages at the same time...
`n` doesn't appear to be used. It might be useful to use `n` when there are many different values of `x`. (Although I suspect we might want more than 101 steps).
There's no need to keep the commented-out old code.
This listener is runnable. Does it offer synchronization guarantees ?
I propose to return `MSG_NOTFOUND`, instead of `MSG_FAILED` for `read_*` calls where the DB cannot find the key.
Why super?
Remove one of these body declarations, https://github.com/mozilla/butter/pull/1225/files#L2R3
On a new line please (for convention).
Is `options` actually used anywhere?
Why would you do this? This creates a hole in the parental lock protection. A user could start an instant timer and watch the content while it's being recorded...
Is this ever called with framework=True?
Readout a MBus device on address 59 from 2400Bd:

 mbus-serial-request-data-multi-reply -b 2400 /dev/ttyS0 59
ah, ok.  It's in the linux check style, which seems sort of linter-y, but I guess it's non-standard.
You can make this one the only union function to be defined, and remove the other one. One will always be able to call the g1.union(g2) from https://github.com/w3c/banana-rdf/blob/master/rdf/src/main/scala/syntax/GraphSyntax.scala#L14
After reading documentation for you method I strongly don't see reason for such error log - ```Creates new list with reversed order of elements. Return nil if list is nil.``` so it is documented as common and expected behavior
There's another similar, possible, indentation issue here.
You should reference a commit has here and ask authors to add version tags. We have (template)[https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template] for this
Changed, now uses Array#detect
No changes would be required to this file
This module contains code that is common to the system and system group errata controllers.  Since it is not used by views, it is best placed in a module as has been done vs within a helper.  The module itself could be placed in any of several places (e.g. here, lib or some other location we define for modules).  Since we already had a few modules that were used by the UI controllers stored in this location, I placed this one there as well.  Perhaps in the future, we should do some directory reorganization/refactoring and place them in a different location.
On the contrary, especially for colored plots we do further operations. But I am not worried about the speed (you are right, it is a minor difference). It is just not an idiomatic way to work with numpy.
Why is `Distinct()` useful here?
I think method filters should support the types of things possible with MVC action filters, e.g.:
 - be able to shortcut the execution and return a response/broadcast themselves
 - get the invocation parameters and alter them before the method is invoked
 - change the return value *after* the method has been invoked

To achieve this the OnMethodInvoking method probably needs to accept a HubContext, ClientAgent, GroupManager, invocation parameters and possibly the next filter in the chain (or something along these lines).

The OnMethodInvoked would need similar things, with the addition of any exception thrown by the method invocation so that it can deal with that too.

Come to think of it, our current default behavior of catching exceptions and returning a faulted HubResult could itself be a filter.
Remove this or L122?
Du! ;o) ... it´s more personal
I also think that using simple matrix operations (as far as I know that's what they are) is much faster than going every time to cartesian, make the shift and then back again. 
I think in the end the transformation should be written in simple arithmetic (no numpy matrix operations ... )so that ndarrays and - in future - errors have an easy time.
Can we be guaranteed that there won't be any open handles to the temp file at this point?  Otherwise this will blow up in Windows.
Maybe just add something like:
```
if not tmp.closed:
    tmp.close()
```

This kind of thing blows up so often when running tests in Windows, I'm almost paranoid about it :)  I hate littering temp files all over the place.
LOL! Me too. @jaredmorrow did it for me :)
If you really want to prefix `tr("Bitcoin - ")` to all titles, why not do it in message or some other inner function? This prevents having to change all these messages, and translators from having to translate Bitcoin a zillion times :)
I will just remove it from helper tests. Adding the "required" css class only depends on value of "allowEmpty" anyway. That's why I didn't get any fails for test cases. No point in having unneeded options.
Should be `*/` (end nitpick) :smile:
@markstory You mean constants in the Configure class itself? Or for the tests? I mean I had these arrays as class constants `Configure::DEFAULT_ERROR_HANDLER` and `Configure::DEFAULT_EXCEPTION_HANDLER` before, but I changed it back because I wasn't sure if that's the right way...
Won't this cause trouble with app and plugin tests?
You don't need two `if`s here.
This is desirable (because cjdns is actually a networking interface and should thus be available when network.target has been reached), but has a side effect. This can be quite racey, so cjdns could be started before _any_ other network interface has even started to be configured (i.e. no IPs or routes configured). I wonder whether the UDP interface can deal with that? If so, this should be fine and the most preferable solution, otherwise one may have to fix something about that.
I think this needs to have a separate up and down method (instead of change). You can only use "change" if you're calling straight migration commands (e.g. `add_column`). If you're doing anything with ruby (like iterating through objects) you'll have to provide separate up and down methods.
IMO it's not as clear as it would be otherwise, but I'll trust your judgement.
I think point out you need to run it using java -jar magenta.jar is a minimum for the CLI.  Either way, it doesn't belong in the lib documentation.
Hmmm... this is a bit dangerous to do. Which exceptions could we have here? What is our strategy to deal with them, if one happens?
Is this not equivalent to numMonths = -numMonths; ?
Good point .. I should make it to actually return the intersection of the
values from obj.__all__ and those from dir(obj). That would guarantee the
names are "right" (well, as right as the existing implementation, as it
*is* also possible that the user has overridden __dir__(), which could
produce wrong names). I'll push that fix tomorrow, along with a related
test .. any other suggestions?

Tim

On 15 March 2012 16:54, Thomas Kluyver <
reply@reply.github.com
> wrote:

> > @@ -44,49 +44,39 @@ def dir2(obj):
> >      have such bugs).
> >      """
> >
> > +    # If the object has the __all__ attribute, return the given list
> > +    try:
> > +        return getattr(obj, '__all__')
>
> Note that we only have the module author's word for it that names in
> `__all__` actually exist - we should make sure that it doesn't blow up if
> one of the names is wrong. This gets called by wildcard searching and tab
> completion, I think.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1497/files#r563996
>
this code will be much easier to read as a FluentIterable

ex.
   FluentIterable
       .from(backend.list)
       .transform(toFrontend())
       .toImmutableSet();
No. We have the annotation on the class.
remove this version (logback version is managed in the parent pom)
Nice catch! I think you are right. Fixed it in the code.
I would write a  basic unit test for this function, you may have noticed I am somewhat of a fanatic =/
If these are public enough to be in the JSON object, maybe the underscore should be removed?
`Object.create(null)`; is the right kind of object to use for dictionaries/maps in ES5 (no prototype and the like) I don't have concrete numbers to say if its better then {} but it will avoid the prototype enumeration during forin loops.
On Mon, Sep 10, 2012 at 11:07:13AM -0700, Russell Belfer wrote:

> The existing code checks the `-diff` attribute before doing any
> loading, so that is already in place. Also, we check the first 4K for
> binary-ness as well, but only once we have decided that the file
> should be loaded. This is done after the entire blob is loaded into
> memory, however.

OK, all of that sounds great.

> My intent with this "don't diff big blobs" was to emulate the
> `big_file_threshold` from core git, but I guess that threshold doesn't
> apply for diff.

Yeah, core git diff doesn't care about it at all.

> My goal is to give the user a way to stop the diff processing as early
> as possible if the blob is really large. It is possible / likely that
> the first half of the diff will have to be loaded into memory since
> there is a good chance that is coming from a pack file. However, I can
> still prevent the need to load it into memory twice.

In practice, I'm not sure it will matter much. Big files do tend to be
binary, so you are really only caring about what happens when:

  1. You really do have a big text file. I'd say you should probably
     try to diff it, and let the user's machine be the judge of what's
     possible.

  2. Your binary heuristic fails, and you end up spending a lot of
     cycles (or worse, crashing) trying to come up with a useless
     answer.

It sounds like you're trying to be safe to handle case (2) gracefully,
which is not an unreasonable goal.

> I'll isolate all this work in a couple of commits and if you decide
> you hate it, we can just reset and rip it all out.

I don't think you can go too wrong either way. Like I said, we're
talking about corner cases here. You can always ship it and wait until
somebody complains about the behavior. There's a reasonable chance that
day may never come.

-Peff
Yeah @arrbee is right. When we are calling other *external* functions from inside the API, we want to keep both their error codes and the error message they set, because they will always be more accurate than whatever we could manually set here.
Thanks for review, as said it wasn't the "best" implem. Refacto is available here : [pull request #65](https://github.com/mageekguy/atoum/pull/65) , feedbacks are welcome.
@jlongster as mentioned above this comes from home.html in the mozorg app so I do not know. One note though, I am working of the dev branch for the privacy stuff, not sure if that makes a difference as to what has been done in this regard.
What's this here ^?
camelCase in js
I'd rather not put tastypie in INSTALLED_APPS, unless we know that we need to. It'll result in a couple tastypie models that we don't actually need or use being created in the database. As far as I can tell, for our usage there's no need to have it in INSTALLED_APPS, and the docs seem to confirm this.
But you're not passing it on to web.py.
When mixing positional and keyword arguments is very important to be explicit. What I would like to see here is:


```python
buildutil.insert_build(cursor, product_name, version,
                 beta_number, repository, ignore_duplicates=True)
```

(sorry about the f'ed up indentation)
`__` means to the code-reader: "don't worry about it you don't need it. we get this but won't be using it"
Is this file necessary in source control? How is this file updated? When is it used? Why do you prefer this over schema.rb?
Will follow up on this. #65
Please remove `$collection` everywhere it is not needed.
If we don't extend it, custom themes are broken.
yeah, this one could be kept in the toolbar
duplicated space before ``cannot``
Should be "Normalizes"
I would put the `if (isset)` and this statement in the `countParentClass()` then if you have 'A < B' and B is processed before A you can return the value without counting again.
Yes you are right not very useful... I remove it.
s/incldues/includes/
Maybe have a look at the build_plugin_tree() function to write this a bit more compact.
Bad copy-paste and worst search-and-replace, sorry. 
I have it in a note on my priority list and it's just under ticket DHC-615.
I'll change it in the next commit
All of our tests need to be IPv6 friendly
what's going on here exactly? was there a problem with the whitespace before, or is your editor not set to use 1 tab = 4 spaces?
Thanks again, Anton.

I used a Varien_Object for the variables array because that enables the use of nice chained calls like `if ($observer->getEvent()->getTransport()->getVariables()->getSubscriber())` in event observers, but regarding the overhead, you are right of course.
This variation is more work for the developer bus less performance overhead during execution:
    
    $variables = $observer->getEvent()->getTransport()->getVariables();
    if (isset($variables['subscriber']) && $variables['subscriber']) {
 
  
A brief explanation regarding the event placement: I added the event in this way, because this is how the setting of the store_id of the newsletter/subscriber currently works in Magento 1.
Currently it only affects the "logo_url" and "logo_alt" variables. The `_applyDesignConfig()` processing isn't affected because the store_id is only set on the processor instance, not the core/design_package.
I wondered about that, and I'm glad you agree this is a bug.
ну надо тогда сделать проверку - если last login был меньше чем час назад то не обновлять
nit: ui_us -> sn_us
I don't think you should check storage space here.  I'd do it above in showReceivePrompt().  If the user is not going to be able to accept a transfer because device storage is not available or not big enough, then you should't ask them to accept or decline... You should just decline automatically and tell the user, I think.
please use === here
You can just modify the l10n-id. There is no need to change id here.
Ah, ok.  I'll move it there.
It seems reasonable for it to be optional, but that adds another permutation I didn't want to add a unit test for at this time to make sure we're not trying to pass around an empty display name rather than just omit it.

In terms of the invalid thing, it seems like an HTML5 problem.  Some people seem to try and work around it by specifying the CSS selector as ":focus:invalid" instead of ":invalid", but that has different issues.
btn->button
Is this the same Request object that we had in the fb_contact.js file?
Originally, I wanted to protect the dataSource from accessing the values, cause changing the dataSource will mess-up the UI, also may play the wrong songs.
These dataSource getter/setter design are also happened in the ListView, SubListView and PlayerView, so I followed my initially design and applied it on TileView.
But in now state, I think using function call is a suitable way to implement this,  I would like to change the getter/setter way to function call like <code>setDataSource(source)</code> in the following up.
nit: Promt -> Prompt
Then: 
`return (this._dialogStacks[origin] &&
             this._dialogStacks[origin].length);`

I meant that there is no need for the `> 0` :)
uber-pathetic but isn't the convention to use `i` as index loop variables? :)
For the subject, how about just "Password Recovery"
I can see where https://github.com/satyr/coco/issues/171 comes from now. I'd argue that in a micro-optimization sense, having an extra method and object creation (the `__extend`) outweighs the benefit of shorter syntax in this case, especially since I want the native versions to take precedence with `?=`. Having a  `<<<?` operator is harder to justify here.

On a different note, I should totally be extending `Node`, not `Element`. whoops.
Add carrier return after require for readability.
I don't know the word ```termo``` is, is something like ```term```.
Pleas use term() instead of any()
I would change this to be "AppScale Systems, Inc."
Please conform to existing code conventions (camelCase variables, whitespace, etc.)
Goes through the array and returns the first name that is a valid style name for an element, useful for vendor-prefixed styles like transform.
There's too much steps here. Let's use this technique -- http://knplabs.com/blog/behat-like-a-boss-meta-steps
I need to check whether or not an archiver is active on the current board.
%s removed.

Re the exception -- It is unlikely to happen.  It's the exceptional case :-)

It is easy to catch this case so why not?  I came across documentation stating why a generic runtime exception would be thrown in each of these cases, and if the problem ever comes up. the person looking back to the code will know.  Otherwise it isn't clear what caused the generic RuntimeError.  Simple enough to remove this, but insignificant in cost so my vote is to keep it, but you can always veto.
You might want to fix that :P
I'm not that comfortable with patterns that I would have known that off hand, and the test gives me a good impression of the intention behind it. I wrote the tests to make sure I got that right.
A workaround would be to assert properties on the route instance that is pushed into `Backbone.history.handlers`. Also router.match is supposed to return the constructed route so you could expect properties to be set there as well.
Indeed, nevermind me :)
why not using a phpunit mock object, like everywhere else in the testsuite ?
Default value is "undefined", but not "null"
remove the space between `errorHandler` and `(`
Can you please make sure you have a space after each comma, and around each `=`?
did you remove this line intentionally?
Done, though I'm slightly worried about the confusion between the method onClick and the argument onClick so I renamed the method to whenClicked.
I can't find this method in source code, is it `rejection`?
Could you please change this to `Branch(name)` instead ?
Line 69 shows:

```
if(info && info.type) {
 onAddressInfo(info);
}
else {
```

Since types are no longer stored on the email address, I believe this can safely be removed.
Thanks for the information. It's absolutely clear now.
Good call- I saw that earlier and meant to remove it but forgot!
remove the a href link directly. no more links under lower footer. I don't want to do promotion for any companies.
It's odd to say an option is being ignored when you're raising an error and not just a warning.
Again, please follow the coding style/PEP8 for the formatting here. Commas should be followed by a space, a comma should be before the line break, not after it.

Finally, the English language does not use a space before "!" and "?".
How about `raise_no_default_stub_error` or `raise_missing_default_stub_error`? I think either aligns better with the other `raise_xxx_error` method names. WDYT?
This should be ``self.fkm = ForkingKernelManager(self.filename)``
isn't that already solved by adjusting the `lim` at the start of the function? Running `Getdir(SIZE-1`, 1000)` yields the correct result, ie: the last entry in the list.
Definitely should *not* have this one; we're promoting `ServiceLocatorAwareInterface` as the only interface you should utilize inside your code.
Assuming this will get reworked "real soon now"
Ah, there is a problem with that.
iter isn't an MWWorld::Ptr, it's an object with -> overloaded so it behave the same way, but it won't be accepted as a function argument.
@cordoval At least NetBeans and Zend Studio also understand this type of comments. But I think it can be usefull for ViM/Textmate/Sublime users too :)
So I have access to config in the lazy closure.
Can just use:

    if f in testSets:
Totally missed this when I got rid of it. Oops.
Maybe this should include other protocols like HTTPS/FTP, but I'm not sure. I only tested HTTP.
Another suggestion, up to your consideration lines 173-178 and 179-183 looks like repetition so that could be refactored into its own function (if it stays that way).
is a spacial placeholder a naming convention or is there more to it? if so, can you point me to details?
Order is not guaranteed it seems when you just convert it to a set:

In [1]: l = [1,2,3,2,1,3,4,3,2,1,2,4,5]

In [2]: list(set(l))
Out[2]: [1, 2, 3, 4, 5]

In [3]: l1 = [5,1,2,3,2,1,3,4,3,2,1,2,4,5]

In [4]: list(set(l1))
Out[4]: [1, 2, 3, 4, 5]

The last is _not_ what you want.
two empty lines before definitions of functions outside classes
Use single quote style, no interpolation is done.
"profile-photo"
I was typing the bug from memory
I would just take this out of the function and inline it.
@cmcavoy take a look at this and see if you think this is a reasonable start.
Is it possible that `extensionMatch` could be an empty array? Seems unlikely, but I figured I'd ask :)
If its automagically added don't take the time to remove them. They will crop back anyway. 

Sent from my digital shackles. 

On Mar 26, 2012, at 10:08 AM, Ed Cranford<reply@reply.github.com> wrote:

>>             "ips": [
>>                 {
>> -                    "address": "10.0.2.16",
>> +                    "address": "10.0.2.16", 
> 
> I have no idea, I blame json.dumps
> 
> I can remove it by hand but since these are created automagically what would that solve
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/430/files#r603374
unused `lcd`
if it does, that's a bug. The intention is to use the block to do custom-validation on the input parameters, but it shouldn't affect the retval at all.

I will add a unit test for that.
Ah yes, I think that was replaced by the option "authentication_mode"
@ohadlevy, the controller didn't change, but the index did.  I removed the operatingsystem_ids from "index" but kept them in "show"