labofsahil/github-event-dataset-2012 huggingface dataset:
In conjunction with https://github.com/mozilla/butter/pull/1011/files#L2R117, I think you're safe not to bother storing `_backupInterval`.
A timer inside a constructor seems a little awful
Why the disparity between _ and no-_? Can you choose one and stick with it here?
Uh oh, flickr doesn't seem to have an https version of their API
This is another duplicate, it seems. There are two places where `.play-button-container` is mentioned.
padding on right bracket
also non-unique test id
@shazow, @wallunit 

What would be nicer? The same API for both method, ignoring server_name for the fallback function,
or something like this:

```python
if SSLContext:
    def ssl_wrap_socket(...): # new implementation, arguments a superset of the fallback one
else:
    ssl_wrap_socket = ssl.wrap_socket
```
You are objecting to printf bitching if you gave it %something it didn't comprehend only?  Could either use the slf4j {} thingy or IMO better to use guava-like thingy that only knows about %s, though I don't think that is public we'd have to dup that code.
reminder to remove this comment, its no longer applicable
Tämä kannattaa olla long-tyyppinen, sillä ID:t voivat kantapuolella ylittää javan intin arvon. Tästä syystä yleensä ID:t ovat longeja.
The Scala style guide suggests omitting braces for if/else expressions, but I can see the argument for
```scala
if (span.name != "")
  Future.join(
    for (serviceName <- span.serviceNames.toSeq
      if serviceName != "")
      yield spanMap.add(serviceName, span.name)
  )
else
  Future.Unit
```

Is that more like what you would like to see?
In general I like the for syntax, but I think you're right that collect makes it cleaner in this case.
Let's remove it completely if it's not used.
we should define i as a variable
Is the routing correct? Shouldn't it be:
```csharp
public TravelModule () : base("travels")
```
? Please test it.
I bet it's less overhead---instead of checking the type inside functions, the 
compiler will do that for us.
Was the reason removing this to not duplicate the validations that are already in foreman, just curious
Are these numpy arrays? Why/Why not? If they were there is maybe a nice way to calculate this.
One instead of many.
It is against Gaia coding policy to use console message in a code path without any error nor debug switch.

If you need this, you need 

    if (this.debug)
        console.log(...)

and have `this.debug` set as false in Gaia so everyone who really need to test out SIM can change it.
Better to use `is not` here, since that's the only comparison that makes sense anyways.
Didn't work for me.  Not sure if this was covered by the above "Nevermind".
test/script_tests.cpp: In function ‘CScript ParseScript(std::string)’:
test/script_tests.cpp:53:80: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
This is the equivalent of (in C):
```char *s = malloc(8);
memcpy(s, "testing", 8);
free(s);
fopen(s, "a");```

Try this:
```std::string file = GetDebugLogName();
fileout = fopen(file.c_str(), "a");```
If you change this file, please also change the file in Cake/Console/Templates/skel
Is this path correct?
you should use ``MappingException`` like for other methods IMO
this can be written as `'inputError limit-250' if model_name == "group"` to save on space
I think you should also do `unload("dll-rcpp")` here.
Did a regex for `print >>` catch this line? I don't think it's a problem, though - now that it's changed, leave it unless there's an issue with it.
You got it everywhere else, but one missing is all it takes.

Does this fix your singleton issue?
Instead of these `Any()` traits, do you think it's worthwhile to do a simple trait validator that checks for the necessary attribute (`send_multipart`, I believe)?
Now that we are explicitly defining the method, can we get rid of this eval?
are you sure you want spring's Assert here?
The inspect docs suggest making sure you delete the frame using a try-finally clause: http://docs.python.org/library/inspect.html#the-interpreter-stack
Good point. I support that change.
not exactly what it looks like, since MTAuthorization was moved to mtapi.py.  i assumed that since there wasn't an "core.manage_productversions" that this would be an acceptable substitute.
(Or, if we want to be consistent with the appmenu code in Firefox: `appmenu_simulator`.)
Fixed in 73d1211 but not using -e (this is editable mode and installs things differently than we need)
I like nitpicking. Please nitpick with me every time you can. :)
that's the type of crap that I need spotted...
the stderr output is uninteresting to us.  Each run of MDSW produces a huge amount of STDERR output (as in potentially 100MB):  enough to fill the output buffers set up by popen.  Once the stderr output buffer is full, you can no longer read from stdout.  That sets up a deadlock (see commentary in http://docs.python.org/2/library/subprocess).  Since the stderr output is of no use to us, it's easier to throw it away than to try to consume it and avoid a deadlock.
I'm not seeing where the specific configuration requirements of the individual jobs is loaded.  For example, the bugzilla cron job needs to know the URL to direct Bugzilla queries to, and the number of days into the past to search.  If these aren't loaded at config time, configman will not offer them as options at runtime or allow them in contabber's config file.

if you cannot load them at run time, then the only alternative that I could think of is to run them as separate processes and allow them to have their own config files.
No need to make a variable. Just:

```
self[name].close()
del self[name]
```
`request.LANG` might be close to what you want
Ok, I will do that :P
!== 24
This should read: `@param string $slug The module slug`
This flag is unused (and the property is not declared anymore). You should remove it
this does not follow the Symfony CS. You should use a ``const`` for each constant
@stof, nothing escapes to you. Really man, you are impressive!
what is this use statement for an unknown class ?
Because it's not true. It matches path + context and not "only URLs", which is almost identical to the request.
maybe even `propel1_`
try it without the default header accept, the first may be enough to have AFNetworking automagically parse it as JSON?
I used an ivar since it's just a private int; if we want to use strictly properties I'll change it up, lemme know.
No, replies work fine with lastId concept.
Not sure if you can mutate a `build_stubbed` object. Maybe it's ok if you don't save?

Consider this approach which may be clearer to read
```ruby
event = build_stubbed(:event)
owner = event.owner
invitation = build_stubbed(:invitation, sender: owner, event: event)
poll_link = link_to(
  event.name,
  event_url(event, guest_email: invitation.invitee.email),
  html_options = { style: 'color: #HEX }
)
```
Would rename here to something more descriptive like `set_reminded_timestamp`.
把这儿改成 roman 后（目测应该是明天了吧）我再merge吧
@huxuan 其实我个人并不太推荐或不太习惯你这种注释的风格或方式。
因为如果文档中的第六章一直没动笔的话，整个注释就相当于是给其他的代码贡献者的最直接的解释说明。所以我个人比较倾向于比较轻松而更为具体介绍性的注释(注释并不需要很“官方”，所以以前我都把具体的这个代码参考自哪里等写到注释里供后人参考)。
当然，如果你觉得这样比较妥当的话，就这样的注释风格也可以。
Looks the same call to me ;-)
Found even better - https://github.com/dchelimsky/rspec/blob/master/lib/spec/matchers/match_array.rb#L53 :)
```if @title```
There's no %s in the string literal being appended. Did you mean to add a comment after the }?
@trek :+1:
A few notes on step file naming:

* Append `_steps` to the file name: `user_steps.rb`, not `user.rb`.
* Name steps after the concept they deal with, e.g. `apartment_steps.rb`, `user_steps.rb` (careful with that one, it's easy to have a huge `user_steps.rb` file). Do not name step files after feature files, like `steps/user_can_favorite.rb`.
My idea was to ensure a "unique" result in jndi, which indicates reference is not resolved (because the factory has not been updated yet to support the feature, or because it's not desirable to do such dereference). I tested it, jndi view works fine with it, but if you still consider it's better to stick with Object I have no prob in changing it.
I am not aware how to do this, I ll be happy to look at how to do this
cleanly.

Sent from my iPhone

On 15 Nov 2012, at 20:54, Brian Stansberry <notifications@github.com> wrote:

In
clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/subsystem/DistributedCacheResource.java:

> @@ -62,15 +62,15 @@
>                      .setDefaultValue(new ModelNode().set(2))
>                      .build();
>
> -    static final SimpleAttributeDefinition VIRTUAL_NODES =

Completely removing this will break the management API with no prior
deprecation. I'll push up a commit in a bit showing how I'd prefer this be
done.

—
Reply to this email directly or view it on
GitHub<https://github.com/jbossas/jboss-as/pull/3361/files#r2144532>.
I have put again "Defer", but it performance it is lower than putting all scripts at the bottom... Do you know if we could improve this loading method by the core of B2G?
with the click action we add selection to list, change the header and disable buttons. If I don't use the click, I will have to repeat all the checkings three times.
j -> field
Oups. You can't but let's declare them closer to the second block.
gniiiiiiiiiiiiiik
This was the original "calender app" (with the ical parser) which Andreas wrote. I would like to keep it around for a little while longer until I extract out the parser into the new library I am writing.
fixed indentation, hidden is for giving content to scrapers, this is only conditionally hidden, so display:none is right, right?
this is still going to effect your other tests because its not torn down as far as I can tell.
Do you really want to use moz-hyphens? It slow down page loading by around 190ms because it needs to load a file from the hard drive.
These seem not super useful either, though going between pages isn't so super frequent so I don't care much. I would be very careful with excessive allocations during pan movements since those are very frequent.
OOPS, first time know this...FIXING.
We'll definitely look into that :)
P.S. It should use single quotes to meet the code style guidelines
Thanks for the info; I did not know that. Pushed.
I removed this function and added new class.
Yeah, Nan explained that. :)  No, it can just stay.
Let's go with `:xhr_referer` instead of `:turbolinks`.
@solnic how do you see these being implemented, would `#fetch_node` just do `relations.fetch(name, &block)` or something similar?
craaaaazy :astonished:
Should setup a SIGCHLD handler here too, and set `@pid = nil if Process.waitpid == @pid` for the next alive? call
Actually, if we want to be slightly more lax here, we could do:

if (items.isEmpty) { monoid.zero }
else { items.reduce { reduce(_,_) } }

This allows us to work with non-empty lists of semi-groups (things, such as Either[L,R], that don't have valid zeros).
%s ClientID... goooood idea

have you actually tested it? :)
Don't know what CF means and comes from
Hmm, I wonder if you don't just want to return the query and let the caller fetch the results and turn them into a list? Again I'm really really worried about the memory consumption of loading a bunch of measurements into memory all at once. Also, a caller of this method would have no way of knowing that only QUERY_FETCH_LIMIT results were returned when there may have been others - I'd prefer the caller control how fetching is done.
lines 161-223:
Saving the token not always succeeds. Then the token object is created with nil valued key and secret properties.
Testing with "isEqualTo:" will yield true. The result is that "oauth_token=(null)" is added to the parameters.

lines 226+:
The extraOAuthParameters are double URLEncoded in the original implementation.
When specifying an extra oauth parameter, the oauth server will not accept the request as the oauth verifier does not match.
The oauth service we talk to has a required extra oauth parameter, and this fixes the library to work for us.
leave()
Sburb.inputDisabled.checkCompletion() is checked twice, otherwise this looks good.
"You don't say" ;)
The first test in that file tests that condition.
Can't we use the `Dict` protocol here to get these values? Or maybe something in the `Keyword` module
[New Rdio](http://rdio.com/new)はBackbone.jsをベースとしてコンポーネントベースフレームワークを使って一から作成されました。すべての画面上の構成要素は[Rdio API](http://developer.rdio.com/)で提供されたデータによってダイナミックにロードされ、レンダリングされます。変更がプッシュされるとすべての構成素は、ページのリロードやユーザーの音楽を中断することなく変更が反映できます。このすべてがBackboneのviewとmodelsに依存しており、また、すべてのURLのルーティングはBackboneのRouterで処理されます。リアルタイムにデーター変更の信号が送られた時、BackboneのEventsはデーター変更に関連した構成要素に通知します。Backboneは新しくてダイナミックでリアルタイムなRdioのWebおよびデスクトップアプリケーションの中核を構成しています。
This is the end point that is still in discussion with Loz and Chris, so ins't currently being added to page via js. And will likely change. Shall I remove route/controller for the time being. I personally left it in so I didn't have to branch off.
No, a relative import won't work here - nbconvert is not inside a package.
.. or itemGroup
Fixes:
```
NoMethodError (undefined method `read' for #<String:0x00000005d84190>):
app/controllers/attachments_controller.rb:88:in `upload'
```

Not sure why, but I was getting a String instead of a File in @temp_file. `@temp_file#read` should not be called in this case. Redmine already accounts for this: https://github.com/redmine/redmine/blob/master/app/models/attachment.rb#L112-L117. I did the same as in redmine master, calling `@temp_file.read` only if `@temp_file.respond_to?(:read)`
When a default value was passed to defineAttribute(name, descriptor) as a property of the descriptor argument, it was ignored and null would be used instead. So I added a check, that said that check is not good enough... be right back
It doesn't seem to accept exotic UTF8 characters.
@Mossop, any advice about utf8 string and xpcoms? :)
```
  let inputStream = Cc["@mozilla.org/io/string-input-stream;1"]  
                  .createInstance(Ci.nsIStringInputStream);
  inputStream.setData(data, data.length);
  return inputStream;
```
```
  const converter = Cc["@mozilla.org/intl/scriptableunicodeconverter"].
                  createInstance(Ci.nsIScriptableUnicodeConverter);
  converter.charset = "UTF-8";
  return converter.convertToInputStream(data);
```
I'm currently using second form in order to build an inputstream for nsIZipWriter:
`zw.addEntryStream(pathInZip, 0, COMPRESSION_DEFAULT, stream, false);`
`data` is a string containing wild UTF8 characters.
While second form works, the first doesn't throw any exception, but the file isn't written in zip file.
I'm not sure I agree that it's a good idea to treat something that is not a keyword as keyword, and call `prototype` something else when it's exactly that ?
Be consistent with the file's convention: if it uses " for string, don't mix with '.
Nit: Maybe avoid extra reference is better.
Tests needed for both of these new actions.
See comment above about moving a large portion of this into a file in the /lib directory that can be included from both views.js and here.
I'm not sure. I wasn't sure if the original label needed to stay put, so it was easiest for me to just replace the contents.
yay, updated documentation.
__whimboo__ commented on commit
>  There is no need for an if/else condition. Please directly put the code in the above try/catch block.

I desagree about that. 
`haveAM` is _almost_ as safe as `have_EM` [was][1]. 
But the recommended `try ... catch` method is more unsafe. It could hide underlying problems. (At least more than `haveAM` could.)


[1]: https://github.com/mozilla/nightlytt/pull/85#discussion_r983446
The name has been chosed in reference to ubuntu. Maybe openruntu would have
been a better choice.
This hase been done to allow us to make a new templates with another OS,
for exampe for a fedora based, openroda.


On Thu, Dec 6, 2012 at 9:58 AM, Romain <notifications@github.com> wrote:

> In Makefile:
>
> >  	@echo "Install npm modules"
> >  	npm install .
> >  	@echo "Optionally run make certs to generate test certs"
> > +	sudo mount -o bind templates /usr/lib/lxc/templates
> > +	sudo lxc-create -t openrutu -n openrutu-model
>
> why openrutu?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openruko/dynohost/pull/8/files#r2332271>.
>
>
I think that it is becoming common wisdom among Rubyists that 3 lines (+/- 2) is a good method length. There are various reasons (better discussion in person; remind me to talk about Composed Method), but consider this:

* The whole class is only 37 lines, so it is not likely to scroll your window.
* If you need to understand just one (or two) methods, you can see what it is doing without understanding others because of descriptive names (assuming I gave them good names).
* If you need to understand the whole class, you were going to have to read the whole thing anyway.
* If we have to change, say, how we determine which part of an email we get the body from, we only have to change `body_location` and methods that use it still make perfect sense.
maybe it's only the phpName option never used ;)
@aboe76 The execution methods are mixed into the provider, so this change shouldn't be necessary
I think this is actually a shell behavior
The spec description ("returns true") and the expectation disagree.
typo :O
I just used the code from the previous version, but changing it to Python boolean values doesn't seem to have any harmful effect, so I changed it.
I would add a class for the individual pills (e.g: `.carousel-pill`). This way people can use any element they want, like `<button>` or `<a>`, rather than forcing everyone to use `<span>`. The `.carousel-control` is already done this way.
Unit tests should not pollute the file systems :) Please re-write this test to, for example, use StringIO instead.
This can be simply get_class($this), as we're in a non-static context here.
rename to "adapterFactory"
You still didn't fix the //CraftBukkit, if( ){, and this now has an extra space. Time to get more coffee? :P
Also as far as I can tell this would fail since there's no global getMedia function.
this is wrong. It contains a VcsDriver, not a RepositoryInterface (meaning the naming of the property is totally crappy btw)
OK, this will do the same but I find it less intuitive to have the condition that matches first while iterating the loop as the second condition in the code ... somehow this is against the flow. 
The best would be to iterate the collection back to front ...
__file__ doesn't work on my machine  (win7 x64). getting "<interactive namespace>" as filename. Have to figure out what's wrong here.
Fix import order: first import, then from x import y + alphabetical ordering
It shouldn't this is fixed inside the easyblock.py file.
I am already trying to follow this rule in my code, but if it's used everywhere it might make it easier to not miss interpolations etc.
Shallow copy OK here?
Indent is wrong on this file - should be 4 spaces as for other files in this commit
As before, this comment doesn't make much sense
2 spaces on each side?
Need to document this and #except
broken out the tests within the same test class.
Actually that pointer gets wiped out and changed every time you change location, so yeah, it might be pretty often. Pretty much every time the loading screen is visible.
Why is it !self.collections.select for anon collections but not for unrevealed collections?
Probably best
Should be `if(!options.defer)`... if we don't defer, then it's safe to call `next()` here.  If we do defer, we shouldn't call `next()` again, right?  I've always wondered... what happens if you `res.send(...)` and then call `next(err)`???
ah! you need the request so I guess you can't use the `signals.pre_save`
Should update this to 1.3.3 since that is the first release it will be available in
finals on these
Please use straight quotes
I'd prefer and instead of or.
I would maybe change this line to just be ``if (_direct_map[keys + ':' + action]) {``.  

Yours is more explicit, but unless I'm missing something I think it should be safe to just check for that
Sorry for the wrong hint yesterday, this could/should be the following only (but this does not affect Symfony session handler):

```
return self::$hasStarted = self::getHandlerInstance()->sessionStart();
```
Should object_id be appended instead of inserted in the middel?
ok, makes sense then.
we usually have the case statements on their own line
Any reason for the underscore prefix?
better to use the form:
var qstr = [ 'UPDATE', .... ].join('')
This line still needed?  Thought that we wanted inline_elements_for to be invoked during each item, just not output
Could you please change this to MongoDB.
In coffeescript, @ = this, so you can call `@overlap` or whatever you were using t = this for
You can use the `doto` function here.

    (doto (ConsoleAppender.)
      (.setLayout layout)
      (.setThreshold Level/DEBUG)
      (.activateOptions))

It might make sense to extract that code to a separate function (`debug-logger` perhaps?).
I built a local copy of the gem with these 2 lines related to LOAD_PATH commented out, and it didn't seem to have any affect on the gem itself.
:thumbsup: Yeah I like the idea.
It would be valuable to also know which module's configuration changed. E.g., if the logger configuration changed, the logger would need to know to refresh all the active loggers. I think that could be outscoped, though. Just thinking out loud.
If we just pass in the commentId, this can be changed to the following:

1) Get the comment from Comments
2) Check for access to the Content for the comment (calling either hasAccess or getContent)
I would remove it completely. Unused code quickly accumulates, and having it around means that it needs unit tests around, it needs to be fixed when stuff is refactored and could be used by custom modules without knowing if it really works. In the long run, that's going to take more time and money. Nakamura was full of unused code, and it created a maintenance nightmare.
As discussed offline I'll leave this in now but this will go away once we hook up the UI.
I added the removed logging back in.
Could you add a block of documentation describing what each test does? This would make them in line with the rest of the tests.
Should we add a listener for the `warn` and `error` events?
It might make sense to start splitting tenant specific functionality (start, stop, etc.) from generic configuration stuff.
Dang! what a huge regression I was about to push.
I feel like you could have this return a char * and use strcmp.  Wouldn't require any allocations or frees.
подивися заодно чи можна такі урли зробити
"/blog/page/{page}"

тобто додати page для сторінок
I think its ok to make OkComputer just a namespace
Wrong indention ;)
Why don't you add this in the parent pom instead of copying it into every samples?
This *needs* to have braces: http://codeigniter.com/user_guide/general/styleguide.html#strings

While you do that, you might want to revert back line 72, though there's no rule for that.
Some people prefer to use parenthesis, some not and they can all switch them back and forth each time they make a change, but as silly as it is - an argument that no parenthesis saves 2 bytes wins me on its side.
Думаю для размеров массива эдак до 10000 — даже 5-кратное превышение итераций — это абсолютно некритично. А уж тем более на 100. Есть конечно способы уменьшить количество итераций, но исключить повторы, но думаю это как раз излишняя оптимизация
What purpose did self.request serve?
please remove this extra line you are adding in each class at the beginning
Shouldn't this be done once when the fragment is first created?
Det här ser ju helt galet ut, hur tänkte du?
Yes, hence "eventually" :) If you have a NewEpochs class that initializes with data, then the current Epochs could be transformed into a function that create such objects to keep the api backwards compatible (or subclass to make type-checking work as well).
Did you mean np.intersect1d?
np.setdiff1d is the set difference
.... but keeping the separate treatment for the channel types:

```Python

    out = data.copy()

    for idxs in ch_type_idx:
        if idxs.shape[0]:
            ch_std = np.std(data[idxs], axis=1)
            out[idxs] /= ch_std

    out = out[picks]

```
I would apply the whitener to the mixing matrix for the argument mentioned above
Hey @agramfort, would it make sense to put the function I wrote for the spatio-temporal clustering example in mne.viz and use it here as well? That way we could have a pretty source-space plot for the website, too :)
This can never be null, see the code in user.getUserProperties, i think you intended to test that the user has at least one property but in the test data set you set the user id on the user property to 5510 instead of 5511
I'd just use the same linked list as above.
@MosesMendoza updated both.
We should be careful adding dependencies.. every dependency we add decreases the number of situations where we can run this (i think)

I know I have issues with that faraday gem
Might want to look at doing this "out of band" either with some sort of job queue, or with fork or something.
There should be a space after `..`
@drak @weaverryan good point about using the short syntax to make these bits short/more readable. Its just force of habit that lead me to use the longer syntax as I think that is better generally but not in this case. 

@weaverryan I remember having some discussion about to which to use a while ago, is there a general policy on this at the moment? If it is to use the longer syntax apart from for particularly short block then maybe this needs adding to the contribution section and (an admittedly arbitrary) number of lines under which the short syntax should be used decided upon.
设定Nginx与服务器通信的尝试失败的次数。在<literal>fail_timeout</literal>参数定义的时间段内，如果失败的次数达到此值，nginx认为服务器在<literal>fail_timeout</literal>定义的时间段内不可用。
In fact, "default" is the trick i use to overcome the form validation, but we can make overloading of server with a different server value.
This will work until we have a mandatory default_ircserver in config.js.
if (childrenRefs.isInstanceOf[TerminatingChildrenContainer]) dispatcher suspend this
и сюда foreach
Ты точно уверен, что в шаред_птр оборачивать аккаунт стоит не сразу?
Это весьма error-prone и чревато трудноотлавливаемыми багами.
Хуй у тебя утек. И выше тоже. Смотри последнюю строчку метода.
> Creo que la clase Assembly tiene un método estático que te deja acceder al current assembly.

Este código ya estaba, solo lo moví. Por otro lado, cual sería la ventaja a utilizar ese método?
Modify procedure to return early
I would prefer to have this message issued at warning rather than error.  The reason for this is that Adhearsion often will run on a different machine than Asterisk and thus this test would be meaningless (either a false positive or a false negative).

Even better: is it possible to change the test to send the command to Asterisk and have it execute via the System command instead?
Can somebody explain why we have brackets here?
Why do your changes fail at git so badly? What's changed?
In the rich client is next set to None? We could do a few asserts on that in places, at least in the pagination tests.
You are right! Lines 91-93 should be moved to line 89. That way only once do we define cache configuration - the default if user did not provide his configuration. Ok with that?
configuration field is not being used
Is an explicit copy of the String required here?
mind creating a jira for that then? It's out of scope for this
What's this for? It doesn't seem to be used.
How about createDistributedTask()? The 'get' in the name seems to imply that every call returns the same builder.
I'd also make the Callable a parameter to this method, since it's not optional.
This is actually true
Dude! Also http://www.nczonline.net/blog/2012/06/12/the-care-and-feeding-of-software-engineers-or-why-engineers-are-grumpy/
Agreed, but I don't think either version would work sensibly with rgb as a masked array.  And the docstring says "floats", with no mention of masked array support.
Consider combining this into a single **if** statement:

```
if conf_intervals is not None and conf_intervals[i] is not None:
    ...
else:
    ...
```
why EVENTS.jsm vs events.jsm?
s/contact with/contact us with/
testvars is available in the test and can be passed as an argument. see previous comment
Should the "above" be uncommented?
If I expose cssCache and jsCache I only have a reference to those objects, so I can't just replace them with a new object. That will just replace the references. The code to empty the caches will be more complex. Do you still prefer exposing the caches instead of a clear method?

I did override document.createElement earlier, so that should be easy to revert back to.
i guess the query language is not case sensitive. but it looks more consistent like this :-)
Switch to: `http://go.plymouth.edu/glpi`
Style nit... maybe move this comment into the docstring. Dunno.
Why would we use the size to look up the version? Why would we create the same version with different sizes?
We should avoid double execution of `generateNav`
All the concrete subclasses of DomainObjectSQH are expected to remember to call super.configureQuery(). This makes me a little nervous (somebody might forget the magic super invocation). Can you move the subclasses's unique logic to a hook method that's called from the superclass?
this change is wrong as ``foo.bar.html.twig`` is a valid file name for a template
Why not add this as a default in the Config?
Using DB escape here is a bad idea.
1. In general you should escape variables as late as possible, or as close to the DB insert as possible.. that way its easier to see if everything was escaped correctly.
2. In this case you're going to be double escaping you're mostly (or entirely?) using the ORM to insert records, it auto escapes values before insert.
Are you sure ``'getSharedManager'`` has the correct type as ``string`` is not a sub-type of ``object<PHPUnit_Framework_Constraint>|string``?
Sorry für den Grammatiknazi, aber recommende**d**...
That may be true, but we need a uniform way to track end-user/app/server usage, regardless of the source. I'll talk to marc
Technically, any class has its implicit interface. You don't need to use abstract. Can you generalize this section?
Was this a change you introduced?
I don't think we should say abstract here.
name is actually optional. While we should recommend they fill it in, we can kill this check.
This won't work if the book has more awards than in the parameter set `awards`. But you could use `every?`:
~~~clojure
(every? (set->predicate (:awards book)) awards)
~~~
Myöskään tässä valmiin `every?`-funktion käyttäminen ei ole sallittua
I'm not sure this change is wise.  I seem to remember some databases require quoting of numeric values if the column is a string type (DB2 maybe?).
Yes, activating such a plugin would cause jQuery to always load, unless you coded it in such a way that it only loaded on certain pages. For instance, you could have a plugin that works with a component to let you choose which pages load jQuery and which ones don't.
Porque ambas son optativas. O sea, el usuario puede elegir:
- dia y hora
- dia solo
- hora solo
Maybe use "avanzado" or something else?
So we don't need the checkbox?
We write lower-case post.
Ok, but I do not get the rest then. Do we still have use one `registerUpdatesProcessor` or does each type has its own `registerUpdatesProcessor`?
No problem, fix it. :-)
Some text about what this e-mail is is missing (for those who might now have registered).

Also some footer should be made, with link to the site and so on. So that people know from who this e-mail is.
Can you do that those panels are registered only if we are running in debug mode?
Click callback gets `event` argument.
This method should be moved to HoroscopeBase. That's why we have base class. ;-)
Oh, no. Django commands support automatic passing of parameters. Use that. ;-)
I'll finish reviewing this tomorrow
For whatever reason, there is a mixture of tabs and spaces here. Don't know how that happened. I'll fix that.
OK - it's no big deal... After all, it's an implementation detail, so don't let that comment of mine stop you :)
As in the previous comment about `AbstractGenericType<T>`, this significantly changes the type hierarchy and invariants of the class.

How can we be certain that no false negatives have been introduced by this change?
https://github.com/Gacko/TrinityGacko/commit/f25ff104efee8150a52d906b2bedd9587b022527
See other note about pubchem:
Still seems dangerous. What if they register for it themselves and this gets called prematurely? I think there should be a nil-check with an error logged to the console.
use pf::util's isenabled() to avoid hard-coded strings
Correct.  We now have a fixed window length (present day, present month, etc) instead of sliding window.
"list items" or " `<li>`" please.
Capitalize HTML
This example makes more sense if the `inner()` function is called somewhere.
здесь лучше .pop, если одновременно будут 'finish' и сразу за ним 'quit'
True, it doesn't make sense for the crafter either. `get_entries` is the one to use here, filtered is about type and xhr filters, they don't apply here. I think the API is okay for the actual logger UI, makes more sense in that context.
That is what I want to say. But maybe it reads easier with a comma between the two.
I'd be +1 on changing it to /i[3-6]86/ just to be explicit about what we want to catch.
`NgxFecthResolveDone` -> `NgxFetchResolveDone`
I assume if the icon doesn't exist it gets caught by the assert in the <Icon> constructor, yes?
10000km? Should probably be a constant somewhere. I'm not fussy, just noting it :)
Please remove those 3 blank lines you added
If you're dealing with indeterminate numbers of strings, please use something like:

```python
subjects = ''.join(u"    | {0}\n".format(s) for s in book.subj)
```

Using ``+=`` will slow down the program. Plus comprehensions are faster than for loops.
Ah, I missed that. I didn't listen to what "namey" was trying to saying. I had eyes only for $(elt).val().
Will capitalize this (the `psf` > `PSF`) here and in the YAML...
Might clarify: this is the random seed used when drawing random shears from a power spectrum, when generating random pixel noise, both, ...?
I had thought that you were doing that, based on our conversation on
Friday.


On Mon, Nov 19, 2012 at 4:40 PM, Sef Kloninger <notifications@github.com>wrote:

> In reports/networking_activity.sh:
>
> > @@ -0,0 +1,11 @@
> > +#!/bin/bash -e
> > +
> > +mysql -N < networking_activity.sql > networking_activity.dat
> > +
> > +gnuplot < networking_activity.plot
>
> Did you miss checking in the networking_activity.plot? Or did you want me
> to do the gnuplot and chef parts for this? That'd be OK, just want to
> understand.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Stanford-Online/class2go/pull/1332/files#r2175277>.
>
>
Alright. Thanks. I will do the fix so this function uses the middleware instead. I believe, reading through the middleware, that you have more specific exception handling. So would that be sufficient?

I will send you some results on the execution time for different nums of students shortly. I am running a db_populate --massive with 4000 students on my machine and its taking some time to fill the DB.

Can I take the fix for undelayed writing of rows as a P1 and work on it after the pull request is merged?

----- Jason Bau <notifications@github.com> wrote:
>In main/courses/reports/views.py:
>> @@ -0,0 +1,16 @@
> > +from courses.reports.data_aggregation import *
> > +from django.http import HttpResponse
> > +from django.shortcuts import render_to_response
> > +from django.template import Context, loader
> > +from django.template import RequestContext
> > +from courses.actions import auth_is_course_admin_view_wrapper
> > +
> > +@auth_is_course_admin_view_wrapper
> > +def main(request, course_prefix, course_suffix):
> > +  try:
> > +    common_page_data = get_common_page_data(request, course_prefix, course_suffix)
> > +  except:
>
>sorry, i'm going to make a stink about this one.

> please catch only certain types of exceptions, instead of all exceptions. You should only catch the exceptions you expect, and can handle, meaning you should be minimizing the set rather than maximizing.
> 
>I am going to gate the pull request on this fix.
> 
>
>        —

>        Reply to this email directly or view it on GitHub.
>
>
We should leave a commented `# require "activerecord/railtie"` here as does rails when you do `rails new -O`

(but I'll merge anyway :)
this trigger is already in always
I'd prefer `(8 !== PHP_INT_SIZE)`, if only to be consistent with the other tests.
That is not the point. I understand it has nothing to do with this specific issue, but extra things to check in other tests should be considered as a good thing. It is *nice* to see that other tests failed as well because of bugs.
Uh - oh. No problem. Can you let me know at least if my approach was correct? As in, assuming that the `onready` event is not deprecated, your code review comments would then be...?

This is one of my first attempts at contributing so all criticisms will be taken constructively, rest assured.
`ProfessionCategory`
Fixed (and rebased).
again, no need for require_relative because of `test.libs << 'test'` in Rakefile
You're right. I've moved the logic into Index, and handled disabling and reenabling the index there if we're on Splunk <5.0.
Of course. She'll get her crack at this as well.
You copied the typo from the original comment. Should be:

    if (ini_get('open_basedir') == '' && ini_get('safe_mode') == 'Off') {
These are in scalding now (0.8.1) so they shouldn't also be here, right?
I'm curiour, what's the advantage of using this form vs using interpolation?
Sounds good but I want to try on the device to see if there is any dithering (bands on each 'rows' of the gradient)
There is a priority, actually: ShardOfflineExeption, Throwable, ShardBlackHoleException. The execution logic in the job processor handles ShardOfflineException and ShardBlackHoleException specially.
Please can you stick to the [style guide](http://docs.pyrocms.com/2.1/manual/index.php/developers/contributing/coding-standards).
High volumes of these exist already... D'ya mind not adding a second in, it tends to confuse people a fair bit.
It is intentional this object works with 32 bit while the other qint64?
personal curiosity - what's the difference between timedelta and relativedelta?
no, it gets the simpleClassName of the class itself, which is what toString does
On 08/10/2012 10:29, Helen Flynn wrote:
> In docs/sphinx/loci/bio-formats-about.txt:
>
>> @@ -0,0 +1,70 @@
>> +About
>> +=====
>> +
>> +The primary goal of Bio-Formats is to facilitate the exchange of
>> +microscopy data between different software packages and
>> +organizations. It achieves this by converting proprietary
>> +microscopy data into an open standard called the `OME data
>> +model <http://genomebiology.com/2005/6/5/R47>`_, particularly into the
>> +OME-TIFF_ file format.
>> +
>
> Is that necessary once this is all hosted on OME site? The documentation
> will then be available from the top menu while you're on this page anyway.

I think the reference to the published paper should be retained in the
documentation, though we probably don't need it for links which point
inside the documentation.


Roger

The University of Dundee is a registered Scottish Charity, No: SC015096
Yes, we need it in the same package because my PR on the Scala project made ``global.interruptsEnabled`` package private, and not public. I did it this way because I wanted to make it ``hard`` for other plugins to access ``interruptsEnabled``.

As for possible incorrect behavior, I've built a worksheet locally and installed and it seems fine...
How does this function compare with the existing: http://scikit-image.org/docs/dev/api/skimage.filter.html?highlight=bilateral#skimage.filter.denoise_bilateral
is it possible that the ``b_* `` are not properly set? e.g. what if ``random_int < len(idx_list)`` is never true?
My only worry is that `n_samples` could be required for certain stopping criteria like `min_samples_leaf` (but it currently isn't). It is being used by `export_graphviz` though. Should `export_graphviz` show both the `n_samples` and `weighted_n_samples`?
The changes to SVC and NuSVC come from #1485, so I should add the comment there.
Solved it using a helper function.
Actually I  think it would even be more interesting to unroll the 4 variants to remove as many `if` tests as possible from the inner foor loops: 

- sym is True and squared is True

- sym is False and squared is True

- sym is True and squared is False

- sym is False and squred is False
Can you document the formula that you're applying to transform the data?
By "it doesn't work", I mean compiling the feature hasher actually fails when this is *not* commented out.
Maybe you could add a section on the behavior w.r.t. the overfitting issue? I assume that high values for `learning_rate` and `n_estimators` will favor overfitting on data with noisy labels? Are there any practical tips (e.g. some kind of efficient early stopping  with a validation set) to deal with this?
same remark here. BTW, this should be turned into a doctest by adding the `>>> ` prefix. Tu run the doctests on the narrative documentation, use:

```
make test-doc
```

from the top level folder of the scikit-learn source tree.
ні. тут мають бути налаштування для production. завжди
I promise I am good an maths! :P Corrected
this dialog will again face the same problem of incorrect handling.
don't need to clone customPalette
No, len is the smaller of len1 and len2.
This `parsePrimaryExp` call would accept `@a => a`.
I'm not sure this is correct or not.
You're right, it's not consistent. I changed it that way to make it easier to add new configuration options. I'm updating the pull request.
autocapitalization is not supported by BB afaik
Please pay attention to your english
I just moved the commenting to be in line with what we talked about in class. Prior to today, I didn't know the function descriptions were supposed to go in the header either.
The base definition does not regard NULL as matching anything. I don't know what it would break if it did.

Not sure whether it's wise to mix refactoring such as this with this commit, or whether would be better to do that separately.
See comments on a previous diff about not having a pointer to the current context.
Wow weird, is that actually creating the variable? What value does it give it? ``null``? I'd go with an actual assignment as this seems pretty unusual to me, but maybe it's common in PHP in which case it's fine.
Why do you need this? 

We never need the timezone since we don't use Django ORM models. And since you always format the date before you send it over HTTP we never need the timezone either. Using `utc_now()` is no different from using `datetime.datetime.utcnow()` when all you do is is `mydate.strftime('%Y %H')`
First of all, it's not clear what this file depends on. I believe it depends on the following:

* `$` - so common it's obvious
* `document` - of course
* `socSearchFormModel`
* `prodVersMap`

At least document it. 
Also, I would make the last two looking more like constants so it's obvious what they do. E.g. `SOC_SEARCH_FORM_MODEL`.

Actually to be really correct the best way is to use the closure notation:

```javascript
(function(foo, bar) {
    'use strict';
    var foobar = foo + bar;
})(SOME, CONSTANT);
```

If you run that through a linter it'll be happy. That way the variables (in this example) `foo` and `bar` are locally scoped. That is by the way, the common pattern you need to avoid linter problems when you use `'use strict'` and need `$` and `window`. E.g. something like this:

```javascript
(function($, window) {
})($, window);
```

More important that winning brownie points with linters is to make it less surprising to code-readers like you and me.
OK, a few issues with this.

1. You're assuming all consumers are sitting on public IPv4 addresses and won't get NAT'ed.
2. If the provider is using a reverse proxy, it'll need to be set up correctly to pass the remote address through.

A "public reverse proxy, private server cluster" setup will probably choke on this, whether it's the consumer (#1) or the producer (#2).

Any reason why you don't just hand out username/password combos instead?
Voi kai nämä sitten kun API:n sisältö vakiintuu kopioida takaisin yhdeksi funktiokutsuksi, mutta nyt vielä helpompi kun voi tuosta "periä" ominaisuuksia.
The reason it fails is probably that the material is not marked smooth.
Oh I see your comment in the commit. It's because `String` is for short strings and `Text` is for long ones. Most of the databases (postgres, mysql, etc.) treat them as separate data types so datamapper does also. Just change it to `Text` instead of `String` and remove the length restriction
how is this related to registration ?
Fields for test_ext
@shacker it was the fastest solution at that time but we should actually try to refactor it. Would you mind opening a jira for it? Don't think it's a high priority though.
(if sync for instance creates multiple birthdays, and you try modify an anniversary, it'll delete all the existing dates, set the first birthday correctly, and then all others as anniversaries - that seems wrong)
This should be "Log file name" not long file name, according to the InShell advisory.
68824 : Odin Secure FTP Expert Server Crafted LIST Response Handling Overflow
This can be moved into a utility function, so that you can call (both here and in `ihaar2d`):

```python
extraRows = get_padding(origRows, levels)
extraCols = get_padding(origCols, levels)
```

Also, is this loop the same as:

```python
def get_padding(width, levels):
    divisor = 2**levels
    remainder = mod(width, divisor)
    if remainder == 0:
        return 0
    return divisor - remainder
```
401 is generic for all requests - I added info to README about it
This should probably be:

    catch: :error, other when is_exception(other) and not is_record(other, AssertionError)

So we avoid catching Erlang errors.
Four spaces for indentation.
self.CFG.get() should work, because it's a (modified) dict, but there is always potential for a bug.
Hmm, I'm not sure if it will be clear to people what this means. Granted, I'm not sure "use the default orphan pseud" was any clearer, but we may want to revisit the language here.
Perhaps this is an obvious question, but do we support arrays of rgbaf?
What order are they in?  Perhaps show it in an `@example`.
Is this and similar specs overkill?  Elsewhere we just do something like:
```
expect(function () {
    new CentralBodySurface({
        imageryLayerCollection : new ImageryLayerCollection()
    })
}).toThrow();
```
Why not just `this.outlineWidth`?  That is what the original polyline code had:
```
var rs = this._rsPick;
rs.lineWidth = outlineWidth;
rs.depthTest.enabled = useDepthTest;
```
Why is this `@private`?
Let's just default no credit, rather than crediting AGI.
I guess in this case it's equivalent, but using `TypeName.clone(whatever)` everywhere is a better convention to start using as a default, since it will work whether not the parameter is an instance of TypeName.  e.g. `Color.clone(defaultValue(description.outlineColor, Color.BLACK))` works whether `description.outlineColor` is a Color, or the default value of Color.BLACK, or simply an object with the appropriate red, green, blue, alpha properties.

I can change it if you want, though.
In android, it looks like we have BOTH fieldName, and getFieldName which do the same thing.  This is more of an FYI, I don't think any actions needs to be taken here.
Needs copyright update
`wrap` property is set to true.
On Mobile web the color precedence is tab.backgroundColor, tabGrp.activeTabBackgroundColor, tabGrp.tabsBackgroundColor.
On IOS the backgroundColor applies to all states and all tabs