labofsahil/github-event-dataset-2012 huggingface dataset:
Migrations should be reversible. In my opinion, remove_index should be provided as well.
Yes, getDistributedNodes() under native ShadowDOM returns a NodeList.
call should grab values until we get something that is no longer a basic value type. basic values are values are things that aren't call basically. This would have to be changed if we implemented that (call foo bar) thing in the future to just be isValueType. I had to change this because the "as" token in a range clause isn't a tokenClose and so it would error, trying to consume a basic value out of an "as".
Hi,

The default value is the same with session library and captcha helper document.
можно, конечно и через for (int i = 0; i <= LENGTH; i++), но просто так короче. наверное, сказывается старая школа программирования.
Для такого уже существует метод description, перегрузите его.
Since ShowSaveDialog will only return a single item, it would be better to pass in a reference to an ExtensionString rather than a list.
Pluck is new to me...nice!
If the gem isn't directly used on the tests, I would prefer putting it into the `Gemfile` (just as `guard` for example). Imagine pry depends on something that impedes switching to newer gem versions.
We should note that struct and union types are unsupported.
I suggest using `'df . | tail -1'` instead of `'df /mnt/us/' | tail -1'`, so it works also for emulator mode.
Prefer `IEnumerable` on externally-facing APIs.
if classes are not meant to be used by the user it should be prefixed with an underscore `_ EpochMeanConEstBase `
It looks like it will still be possible to add PLV and PPC (pairwise-calculated version of PLV) using this framework. Is that right? Or will some modifications need to be made to do pairwise calculations?
should it do the same thing? or be smart and know about vertnos? If it's the same thing I can leave with stc.data as it's explicit.
Not alphabetical. :)  (A nit-pick I know)
@wluyima do you recall why this is the case?
I prefer using a class for striking or indicating "retired" versus the now-deprecated `<strike>` element.
I think the tests fail because you are changing the global
config.authentication_keys to also consider "email_confirmation" and not
all models have it.

Do tests still fail if you remove the change in the devise initializer? If
not, I would just set the authentication_keys directly in the model you
created in test/models_test and then we may have the best of both worlds.

Thanks a lot!
second change (added try catch)
This function does not belong here; it belongs in the Ruby module and not in this form. It will have to be modified to be customisable via zstyles.
Thanks, it's ok right now,
sealed trait Node
    object Node {
      private case class NodeImpl(name: String) extends Node { override def toString(): String = "Node(" + name + ")" }
      def apply(name: String): Node = NodeImpl(hash(name))
    }
Плохо передавать уже интерфейсы прямо в сигналах, ибо сигналы не умеют в неймспейсы. Поэтому в азотхе, в частности, везде передаются QObject'ы.
we don't want to expire this user_token -- would be worth asking API team if the documentation doesn't say
This is still out of date, see: https://github.com/MahApps/MahApps.Metro/blob/master/MahApps.Metro/Themes/Generic.xaml#L580
These two functions are the exact same code.  Needs refactor.
Could you do `@comment.votes.find_by_user_id(current_user)`? This will return `nil` if nothing is found.
Blank line to separate these please.
You should better use a Twig template for rendering HTML
Hi and thanks for reading this through ...

I did not look into I18n machinery very deeply. What I do know is that the added scenario doesn't work without this change. So the view doesn't use the overridden translation until this line is changed. This could also have something to do with the moment of execution of this line in comparison with the adding of the translations in the rails app.
Need them or not, 80 column rule
This is just fine. You would need a helper function with more parameters :).
The antlr stuff sits in the server-side interpreter. On the client I just need to quickly distinguish between client and server commands. There is no need for the client to parse nor understand the complexities of the server commands
Guys, I suggest you create a fork if you want to add support for strings, or _anything_ else than a semicolon or sharp character. As it is, there is no support for them and as such your code would be at fault.
self.contact is undefined - which ended up causing this test to fail.
``postReply `` doesn't support ``$files`` parameter anymore - it's part of this PR.
Yes, but it doesn't work if you're comparing 1 and 1.0. There the type difference causes the comparison to return false. I'm trying to tweak it so that the type doesn't matter, but it's not working yet with `(not (== ...))`.
For the short drop, we take the min. A `nodata` value of -9999.0 will be the minimum, so we temporarily replace it with a large value, do `(reductions min clean-shorts)` to get the correct values in each spot, and replace the large value with the standard `nodata` value.
Newline needed before `[fire`.
place the undefined test outermost so that the function exits as soon as it knows there is no work to do
@apex13 Since we're removing `...filler_`, can we also remove it from the HTML?
The class name is misleading since this is also used to collect another person's library or a world's library. How about something like "LibraryContentQueryHandler"?
and here too ...
ok, sorry about that. Is it ok this time or should I separate it in and do new 
pull requests?
hmmhh can you somehow check for os  greater equal 10.8 here? Otherwise we will have the same issue with the next os release.
If so, there would be nice to comment such places, because someone can think that this class is sealed by design and inheriting from it is forbiden.
This should be an array node:

```yaml
assetic:
    gzip:
        enable: false
        level: 9
```
Ack on the comment and avoiding saving the transaction state.

I had thought about making `session->txn` into a pointer and about caching a transaction context: I don't think that works without adding locking into normal transaction paths.  The problem is if a checkpoint completes while eviction is in progress in another thread, that thread ends up with transaction that is no longer valid.

It also isn't desirable to do eviction with a stale context: real committed changes to a page may be skipped, and a page that could be evicted may stay in memory.
== is actually the correct one because of parameters from controller etc... must fix zendrend. method can also be extracted.
So, I guess you prefer `that` other than `self`.

Should we put this in the coding standards? it's usually one of the things that people disagree on.
type error. Unfortunately this compiles, because Java defines Object.equals(anyOther: Object) and doesn't check types here.
``function fromArray()`` does not seem to conform to the naming convention (``^(?:is|has|should|may|supports)``). I also found this on lines 200, and 361.
Should the return type not be "array<integer,array<integer,integer>|array<integer,string|integer>|array<integer,double|integer>|array<integer,string>|array<integer,double>|array<integer,string|double>>" instead of "array"?
- Are you sure you want to override the parameter ``$query``? This often makes code less readable.
- Are you sure ``$this->class`` has the correct type as "object<Doctrine\ODM\MongoDB\Mapping\ClassMetadata>" is not a sub-type of "object<Doctrine\ODM\MongoDB\Query\ClassMetadata>"?
Customized should be good. Thanks. :)
English is very ambiguous with this phrase ... the meaning depends on the emphasis and location of 'just'.

is designed just to address these issues - only these issues and nothing else
is designed *just* to address these issues - primarily these issues and few others as well
is designed to address *just* these issues - these issues among many others.
OK I'll add it.  If I remember correctly, doesn't this also require:

    <param name="enableHtmlAccess" value="true" />

in the Silverlight object definition?
The version will be listed last. That window of erroneous ordering will be very short, though.
It isn't strictly necessary but I think it makes it more readable.  I'm happy to adjust if we are standardizing one way or another.
OK on both.
For consistency, help output should not end in periods
Apparently not. A victim of cut/paste entire methods and their comments.
It is nothing wrong to have a rich context because then users (people who design templates) can play more and maybe do in the template something you have not envisioned. I really hate when I do not have everything I need in the template.

But yes, there is no need to put URL in the context, just put everything you need there to be able to construct the URL from the token.

So I suggest:
 * SITE_NAME (we should define settings.SITE_NAME for this)
 * user object
 * request object
 * confirmation_token
 * CONFIRMATION_TOKEN_VALIDITY (capital letters all, because it is a constant)

Then you can use `url` tag (Django built-in) and `fullurl` (from [django-missing](http://django-missing.readthedocs.org/en/latest/templatetags.html#missing.templatetags.url_tags.fullurl)) to create everything else you need.
Btw: At first look this looks the same as in django. Is this really necessary ? I think that there wouldnt be any major changes. It is simple enough now. But if you insist :) ??
In anonymous functions, we use spaces around arguments' `()`.
I want to change labels, and change required to false. (So that I could have only 1 class for password, and in account form I would only change those labels...)
Great opportunity to learn! :-) Read how inheritance works in Python and how methods definitions are search for (order).

(It is nothing special - it just searches for first definition, and the first definition is yours, and then you call next definition by search further with super.)

Of course things can become quite fun:

https://en.wikipedia.org/wiki/Diamond_problem
Why is not just one time field (not just date) not enough?
Write TODO above the line of importance, not bellow, put empty line between fields and methods. It is not only that ids should be statics, but nonconsecutive. We do not write dot at the end of TODO comments.
The problem above is probably in how post_date is formatted. Can you write here one example of the format?
Can we have mapfield of mapfield? One for columns and the second one for IDs?
I think it is sensible to include a class to avoid any other `time` elements being unintentionally affected someday.
Remove this from ul (it should go before the ul). Remove the height and width (make a new file, header-logo.png, that is 25% the size).
Actually, Jesper (colleague) was referring to one of our servers with php 5.3.13, on FreeBSD that (for some reason) didn't have the extension installed. I also thought it should be installed by default. I could add the warning but then I'd have to do that for everything you can disable.
Same as before, not all epics are listed
It's not needed.
The compiler will automatically infere it.
Per [http://technet.microsoft.com/en-us/library/bb727005.aspx](http://technet.microsoft.com/en-us/library/bb727005.aspx), a windows hosts file can handle non-link-local ipv6 entries.
need a new line or github complains
$SNMP's TRUE and FALSE are actually both true values in perl (see below)! These constants are meant to be used when interacting over SNMP only. Use $TRUE, $FALSE instead.

from pf::SNMP::constants:
```perl

=item TruthValue - defined by RFC 1903 (SNMP Textual Conventions) aka SNMPv2-TC

 true (1)
 false (2)

=cut
Readonly::Scalar our $TRUE => 1;
Readonly::Scalar our $FALSE => 2;
```
PHP doesn't accept visibility qualifiers with classes.
Dead code thanks to the `return;` above
I'm just going to assume this is similar to the descriptive.OptFuncts in the repo until we have the other changes merged in and you can rebase. You're still going to need to remove the stuff that's in el_desc from git before we merge this, but we can worry about that later.
seems like a duplication of https://github.com/sixty-nine/Jackrabbit-startup-script
does not really belong into the sandbox imho.
maybe @sixty-nine could integrate some of the additional features into his script and then we could include that?
This sucks less
Import only modules, not directly its content.
you touched that but did not change to assertThat? ;)
You would need a scanner / parser that knows what a valid `<a href="...">` tag looks like. Not exactly trivial but it should be possible to do in ~50 lines of code or less.

It's a greedy match, by the way, but a non-greedy match doesn't cut it either. Example:

```javascript
> '<a>bc<a>def</a>cb</a>'.match(/(<a.*a>)/gi) // greedy
[ '<a>bc<a>def</a>cb</a>' ]
> '<a>bc<a>def</a>cb</a>'.match(/(<a.*?a>)/gi) // non-greedy
[ '<a>bc<a>' ]
```

For the CS-y inclined: regular expressions are a [type 3 grammar](http://en.wikipedia.org/wiki/Chomsky_hierarchy#The_hierarchy) while XML and HTML are type 2 grammars. Context-free grammars can parse regular grammars but not the other way around.
Any reason these can't all be protocol relative?
Nope.  Not correct at all.  I'll fix.
I went for granular try...catch blocks for the sole reason of having explicit messages indicating specifically what the code is trying to do (get a store, connect to store, open a folder, etc...) when the exception gets thrown. It is kinda noisy and theoretically this should be pretty discernable from the root cause exception info, so I'm on the fence.
you can use a php for loop. DRY, dont' repeat yourself.
Somehow my comment didn't quite end up where I wanted it. Yes, line 370 is very clear and in my opinion should be written this way. I like the new npix computation better. Thanks!
This then relates to a question I wanted to raise below, but have been learning my way around the new stuff first.  Is it not confusing for the type names to not match the deviate class names wherever this is possible (e.g. where a corresponding class exists)?  The `Gaussian` is a GSObject name too, and `GaussianDeviate` is very clearly not that.  I also don't see the improvement in renaming `UniformDeviate` to `Random` for a config type... It just means we're going to need to provide a key matching types to classes in the code itself.  It seems to me that this would be better only done where no precise counterpart exists (e.g. `RandomCircle`).
> I didn't change the documentation for this function at all, since I thought it would be worth waiting for the functionality to be finalized. e.g. Should we split this into two functions? Here or in 248?
> 

Yes, split, but in 248.
Yes.  Thank you.
In that case, it'd be worth grepping through this file for other instances of the same thing.  I saw a few others that I didn't comment on.
I also tried ParVector and did par.foreach which worked great but I thought that was overkill.
It seems that you can also place an additional command argument after !quote based on line 147-148.  Need to update this command explanation to detail that. I would also add the comment you have there on line 145 to the explanation as well.
I dont' think this is right; the getConfig() returns a PortRange, which is what you're adding to the Collection<Integer>.
The super.getRequiredOpenPorts should pick these up automatically by walking through the config keys to see which are PortRanges.
"Error authenticating credentials", instead of "Error authentication credentials".

A bit confusing that an AuthenticationException doesn't mean unauthorized, but agree that's what the dropwizard javadoc says!
`term.note` まで引数に与えると、アノテーションをつけている場合などにうまくいかないようです。
そもそも `logaling-command` の `add` などでチェックしている箇所では `note` は引数に与えていないので、このケースでは `term.note` は引数に与えないで良さそうです！
My concern here is if VerifyDeployment fails, should the code in this function continue to run to completion?
Why delete the entire `test_examples` file?
Was this actually a change from a released version? I thought we decided it was already like this.
this might not be required inline with above suggestion
Weird! :)
@stloyd ``instanceof`` will not work as the variable will be a string, not a DateTime
nit: remove those
should not be config:dump-reference ?
Commented code?  (# = comment too right?)
Readd these comments.
I may be missing something here, but master still has FaultTolerantStepFactoryBean in the factory package...not item:
https://github.com/SpringSource/spring-batch/blob/master/spring-batch-core/src/main/java/org/springframework/batch/core/step/factory/FaultTolerantStepFactoryBean.java
I don't think the maintenance stuff needs to be an endpoint. The `testing` branch adds a spot for it on startup.
kye == key
Thanks for catching that, Michelle. In fact, deadMansBlur() here does do something useful for keyboard interactions, and removing it introduces a problem in all browsers. Probably better a bug in one browser than in all, until we fix the one browser. I'll push a fix, with comments.
Note that deadMansBlur() is not doing the desired job for mouse interactions, which is probably the cause of FLUID-4650.
Is there another way to check for full screen mode? In this check, if opera or IE ever introduce full screen we still won't offer it. 

Also, any reason to triple 'not' the check?
I'm not sure we want this event. A `toolPanel` is supposed to emit a `ready` event, and the `toolbox` re-emit this event (from the `toolbox`) as `{toolPanel.id}-ready` (see issue #74).
It's possible this file doesn't exist, if Eclipse isn't used. There should be an alternative way to specify library projects, via an attribute for example, where I can list paths to library projects manually. Also, is it possible that a library projects references other library projects (recursion?)
I need the package access for the unit tests. Because the API is so IO heavy, the tests are really Mock dependent.
Hey Adi if we craft this locator correctly we can use it twice! Start by removing the `.inactive` part.

Firstly we can use it to click on the link when in the sorting tests.

Secondly you can check that the class contains inactive by first finding the element and then using `element.get_attribute('class') == 'inactive'` and return the bool value of that in `is_seven_disabled`
Changed to value0 and weight
This one better, @amueller ?
You asked me about the reason of us not implementing so many algorithms: this is one of them ;)

(the others were mentioned by @GaelVaroquaux).
Instead of starting with the equation, start by telling us what kind of application-centric problem is solves.
Do I understand correctly that sparse matrices are supported for `X`? If so, that should be documented and you might want to pass `sparse_format="csc"` to `check_arrays` (I'm assuming that's the fastest format for doing `mean(axis=0)`, please check this).
0 is safe here right? I guess it is, just checking.
agreed, the ui object is the real gross part about it and it caused me a fair bit of bewilderment until i actually played with mercurial in ipython for a while.

the one thing i will say in favor of `import bar as baz`  is that since we're still using py2.5 and simplejson, we have a fair amount of our codebase that includes `import simplejson as json` which, since simplejson and json have the same effective api, will make *that* transition easier (assuming we remain using python and appengine! ha)
`git merge origin/${BASE_BRANCH_NAME}`
wrong underline
No, I wouldn't use `SimpleAnnotationReader` at all.
The problem isn't using a custom slot - it's just the equivalent of a 'version' number. We can do that, but then we have to either change HS's module to use our custom slot, or create a new HS module with a custom slot. And it's not easy to _modify_ a module without some installer. 

Creating a separate module for the Lucene Regex would be messy, too.
I think we should not use _ReflectHelper_ directly, instead we should use _ClassLoaderHelper#classForName_. Maybe we need to introduce a variant without the additional _componentDescription_ parameter. This way we reduce the number of dependencies to annotation commons. 

In fact I would even inline _ReflectHelper#classForName_ into _ClassLoaderHelper_.
I realise it didn't before, but we don't normally put code like this on a single line, even though I agree it takes up a lot of space on multiple lines.
Can this not be done in the view? Where python belongs.
We need this macro for pagination on some sites, please do not remove it.
No objections from me.
Well, this change is still in effect in the master branch. Could you please revert it ?
навіщо?
nit: `logger` please as variable name. so we are in sync with report.
Fix bracket's style
I'm not sure if that will ever happen.. The CommandBasedStatefulKnowledgeSession creates this commands to be executed against a "real" session. For that reason, inside the context there is always a StatefulKnowledgeSessionImpl, as far as I know. Which really make senses. Executing a command against a CommandBasedStatefulKnowledgeSession will be something extremely recursive, because new commands will be created once again. I did that cast because the signature of the execute method accepting a context was not exposed in the interfaces, which basically means that nobody was using the execute command (as far as my analysis goes).

My two cents
Thats OK for me and i will do it, but the i2c/master directory is already quite crowded. It suggest to move each driver in its own subdirectory.
Please add the code line numbers in your comments  where ever  you are suggesting me make changes.
remove from smoke test.
Replace explicit variable type declaration with var keyword. It should not change the behaviour, does it? It has nothing to do with the IList refactoring; I just saw it when passing by.
Again, instructions could be useful, even when there is encouraging  :)

http://www.redmine.org/projects/redmine/wiki/RedmineRegister
`alt` attribute here and no slash at the end.
company name is 3scale ;-)
Awesome!

On Tue, Oct 23, 2012 at 2:56 PM, Abdelrahman Elogeel <
notifications@github.com> wrote:

> In
> WindowsAzurePowershell/src/Management.CloudService/XmlSchema/ServiceDefinitionSchema.cs:
>
> > -        /// <remarks/>
> > -        [System.Xml.Serialization.XmlIgnoreAttribute()]
> > -        public bool sizeInMBSpecified
> > -        {
> > -            get
> > -            {
> > -                return this.sizeInMBFieldSpecified;
> > -            }
> > -            set
> > -            {
> > -                this.sizeInMBFieldSpecified = value;
> > -            }
> > -        }
> > +        ///// <remarks/>
> > +        //[System.Xml.Serialization.XmlIgnoreAttribute()]
> > +        //public bool sizeInMBSpecified
>
> Remove or add to do
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WindowsAzure/azure-sdk-tools/pull/486/files#r1922232>.
>
>
yes, it is typical, though this is our only multi-line example
Mobile Web defaults to -1
Please use either "the `scrollToBottom` method" or just "`scrollToBottom`" here.

"to the `bottom-end`" should be "to the bottom" unless `bottom-end` is a property name or string literal.
Just member names -- everything else is original.
Never make member variables public.
надо наверное поделить на uploadcare.global и uploadcare.default_widget_settings
Хмм, нашел фичу видимо C++0x

// Disable copy from lvalue.
      type(const type&) = delete;
      type& operator=(const type&) = delete;

Стоит запилить?

Вопрос не в тему: у вас используют c++0x в каком-то виде?
Since you are later doing len of name, I would make some kind of assertion that it is a string ish object
Do you mean the way I changed it now? Or do I need to add a line break after each opening brace and indent the the numbers to the next indentation level?
How about `writefln("[%(%(%d %)\n %)]", mat);` (a space after \n) to decorate output?
FYI: `&T.init` was illegal code
Can you confirm these are in ascending order by integer value?
I was hoping we can eventually make the base component have a default 'removed' method that will unbind all the watchers automatically. So we would have less code to generated for each component.
I'll change that. I think I will extract _DestructibleBeanInstance_ from _InjectingConstraintValidatorFactory_ and use it in _ValidatorFactoryBean_ as well.
This is probably better as a comment on the @Stateless annotation, the class level javadoc should be used to explain the class.
And this is a slight lie. If the folder insertion fails, subsequent children won't be able to be inserted.

I perhaps suggest doing things a little differently: flush folders *immediately*, or batch together folders and flush them when a non-folder is encountered. We want to know if a folder insert fails before we try to do anything with the children.
Or blank. n/a is not valid
This line doesn't do anything, as the name you have assigned the exact same name to your package as it would have normally.

I recommend you assign your package a name without ‘sublime’ in the name, since it goes without saying it's a Sublime Text 2 package. Something like this would work well:

    "SublimeBingTranslator": "Bing Translator",
is there a way to plug in a try/catch here to make this safer?
Hmm, we need to write own HTML page to test that shit.

I will commit what I have created for this purpose locally.
I was doing that as a pattern in other models; however…. This change allows us to have the /2.0/crowbar/2.0/XXX objects to run from the crowbar_controller.

That model is more general for barclamps in general.  I’m trying to avoid having the Crowbar barclamp require a lot of controllers because each controller becomes an illegal barclamp name.

For example, the current code base would fail for barclamps named docs, support, nodes, groups, service and others.

From: aabes [mailto:notifications@github.com]
Sent: Wednesday, November 07, 2012 4:29 PM
To: dellcloudedge/barclamp-crowbar
Cc: Hirschfeld, Rob
Subject: Re: [barclamp-crowbar] CMDB code in non-breaking state (some tests failing) [1/1] (#260)


In crowbar_framework/app/controllers/crowbar_controller.rb:

> +      :accepts=>['2.0'],

> +      :actions=>['node','group','cmdb'],

> +      :license=>'apache2',

> +      :copyright=>'Dell, Inc 2012'

> +    }

> +  end

> +

> +  def node

> +    render :text=>"TODO: IMPLEMENT"

> +  end

> +

> +  def cmdb

> +    render :text=>I18n.t('api.wrong_version', :version=>params[:version]) unless params[:version].eql?('2.0')

> +    @cmdb = Cmdb.find_key(params[:id]) if params[:id]

> +

> +    # POST

can we use the ruby CRUD methods - index, create, edit etc?

—
Reply to this email directly or view it on GitHub<https://github.com/dellcloudedge/barclamp-crowbar/pull/260/files#r2062317>.
Might be worth a FIXME note about the fact that these symbols shouldn't be public ...
While I admit different resources, if resources don't match this list, 
nothing gets shown; this is why there's

Matrix.js:418:        if(ESP.ResourceIcons[resourc]!='undefined'){

Directory.js:243:                if 
(ESP.ResourceIcons[section.resource_requests[i][0]]!='undefined') {

--- it'll only show anything if ResourceIcons has a valid icon for it.

On 10/29/2012 10:04 PM, Jordan Moldow wrote:
>
> In esp/public/media/scripts/ajaxschedulingmodule/ESP/Util.js:
>
> > @@ -1,3 +1,15 @@
> > +ESP.ResourceIcons={
> > +    	'Computer lab':'!',
> > +	'LCD projector':'"',
> > +	'Sound system':'#',
> > +	'Kitchen':'$',
> > +	'!Classroom space':'%',/*outdoor*/
> > +	'Discussion':'&',
> > +	'Moveable tables':"'",
> > +	'Lecture':'(',
> > +	'Classroom space':')',
> > +	};
> > +
>
> Unfortunately, our website doesn't have a consistent notion of 
> resource types. Every program has different resources. If you look at 
> Splash 2012 vs. Splash 2011 vs. HSSP vs. Stanford Splash vs. Chicago 
> Splash etc., you'll see that they all use different resources. So this 
> hard-coded list will only function properly for a very specific set of 
> programs, that set up their resources exactly the way that you have 
> assumed that they will.
>
> I don't think we should merge this code unless errors are handled 
> gracefully (i.e., if your resources don't match this list, the 
> scheduler won't look messed up, and will have the same display and 
> functionality as it normally does). And we should eventually look for 
> a better solution to this problem (which I plan to do within the next 
> few months anyway).
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/learning-unlimited/ESP-Website/pull/425/files#r1974508>. 
>
>
Is `:text` intended to be empty?
True, fixing it now.
I don't sure, that this a good idea. If we do this, we will must to split loop over $propertyAnnotations on two parts: first for "real" properties and second - for virtual. IMHO, it's bad.
By the way, (I know, it's implicitly, but) methods can not  to have "Exclude", "Expose" and "Accessor" annotations.
Tell me, please, if i missed something.
Not sure why you did this here.  Now we have duplicated logic in __init__ and in new_axes().
ok, fixed, I think.
Please let's have something other than lowercase L for a variable name.
put a warning in this code that you MUST get the "generatedBy" when getting the entity. failure to do so will delete the generated by on the next store entity.
Dave

This logic can not exist in the parser. Any value you are checking here could be a placeholder or expression and non of them are resolved until later. 
So the best way would be to set values on the handler as is and than do the validation and re-assignments  in the onInit() method.
Make it 'volatile' and you can fix it in MongoDbMessageStore as well
Oops - this is the rollback case - of course it's going to still be there. Doh
Maybe **volatile**?...
The point is both a common ancestor as well as a place to put common functionality as we develop it into the future.  Consider it a downpayment on a better architecture.
Ah okay; I guess it works for `it` and not `its`.  Feel free to use what you had originally.
Upon further thought, regardless of the code duplication issue, it should not be the concern of the parameter list if it is, as its entirety, indented or not.
ok, you hide the block first
Moved to base.js
I started with that but that gave the full namespaced classname, whereas actually we just want the class 'key' here. Couldn't see if that was stored in any variable anywhere?
cool, but I've a better idea, use git describe to recover it. see new commit ;)
Where are the unit tests for this and other `Cartesian` properties?  I take it there were no tests to begin with?  We should add them as we start to add non-trivial things like this.
Move to display constants
BasePlugin should not be extended by developers. Please only extend the classes in the mokol.spi package. BasePlugin and BaseCommand exist to allow package-private access to certain methods in the Shell class.
This is the correct thing to do with an embedded document list, because the 'pk' is actually its index within the list -- embedded documents do not have their own id. If it is possible to have a list of related resources from another collection, then perhaps the last line should be:

```python
if getattr(bundle.obj, 'pk') is None:
    bundle.obj.pk = unicode(len(object_list) - 1)
```
If we block on getMessage it might be better to use a blocking queue so we don't have to deal with locks ourselves
can you pass in the duration so different tests can use a long touch in the future for other things theoretically and then just default 1000
Don't we need to

    App::uses('AppShell', 'Console/Command');

?
we have here an indentation problem. Please check that throughout all the files.
I misunderstood your comment. Fixed
Hardcoded path to ZF2?
This class will be removed in favor of GCD or `[NSOperationQueue mainQueue]`, both of which are system standards that replace this functionality. Should be removed from API documentation.
You write too much JS
please change the primitive type int with the class Integer. The primitive type won't work with the getOpenEngSBModelEntries method.
All classes and class members have been updated with explicitly specified visibility attributes.
this naming strategy should be configurable (you can make it an optional parameter and create a CamelCaseStrategy if omitted)
Add assertion for *parameterValue*.
I don't have a good answer other than it was missed in review. Personally I always would prefer to know there's an error than get back undefined which is meaningless.

@nukulb @kwallis or anyone else care to throw their opinion in?
This function needs some unit tests
Not



From: Nukul Bhasin
To: blackberry-webworks/BB10-WebWorks-Framework
Reply To: blackberry-webworks/BB10-WebWorks-Framework
Re: [BB10-WebWorks-Framework] Adds orientation API to the blackberry.app (#246)
2012-11-05 12:00:04 PM



In ext/app/client.js:

> @@ -50,6 +50,23 @@ defineReadOnlyField("name");
>
>  defineReadOnlyField("version");
>
> +function lockOrientation(orientation, receiveRotateEvents) {
> +    if (typeof receiveRotateEvents === "boolean") {
> +        return window.webworks.execSync(ID, "lockOrientation", {orientation: orientation, receiveRotateEvents: receiveRotateEvents});
> +    } else {
> +        return window.webworks.execSync(ID, "lockOrientation", {orientation: orientation, receiveRotateEvents: false});
> +    }
> +}
> +
> +function unlockOrientation() {
> +    window.webworks.execSync(ID, "unlockOrientation");
> +}
> +


ummm, confused now, so does the spec call orientation writable or not?

\u2014
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/246/files#r2031817>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
They do throttle. I was on HSPA+ according to my phone, but it was at 120kbps.
Yeh I noticed my mess up after going to bed and tried to fix it on my phone, which ended in disaster. Should be sorted now.
Because we're trying not to specify much in the way of how code is formatted. The guide is more about how things should be named than how they should be formatted. Everyone has different formatting styles, and we'll be bikeshedding to death if we try to settle on one (and we'll probably all endu being unhappy with it in the end anyway). So, we're keeping the number of formatting rules to an absolute minimum.