labofsahil/github-event-dataset-2012 huggingface dataset:
There's no way to resolve an expression against the entire domain. Any expression that's allowed in domain.xml is intended for resolution on each server.

Also, I don't like expressions in things that serve as names. Names end up becoming part of resource addresses, and those can't handle expressions. That doesn't apply to this case, but I'd rather keep it simple and not use expression in names.
This seems to make management changes but doesn't clean them up.
I could jump on the gmail bandwagon an use gnarf37@gmail.com ;)  (I'm actually trying to collect all my jQuery related stuff there anyway )
attroperties... Probably not needed anymore since jQuery 1.6 understands the difference.
We'll need to get the same fix from master as referenced above.
just a nit, but I'd call this prolog or something different than fnStr
Wait, isn't `(4rem - 4rem)/2` a fancy way to say `0`?
by the way now the homescreen doesn't receive the DOM_VK_HOME event but the DOM_VK_ESCAPE yes, do you know something about it? thanks Vivien
no dead code if possible
Wondering how the linter didn't pick this.
then what should we put as the checkbox value ?
the object now is being reused. concerning the proposed change -1 . I think the done and failed serve as an abstraction of what is being done once a request is done or fails.
unless I miss something, this is not a proper way to join tables.
Yep, agree, we should check the even and the odd, anyway like the idea of make the phone numbers random.
just `self.debug_reverse.setdefault(h, set()).add(key)` :-)
Asi by bylo fajn, kdybychom pouzivali http://twitter.github.com/bootstrap/javascript.html#alerts ale to je jen do budoucna, takze spis jen jako TODO.
Does it make sense to use the common version header instead of a version parameter?
Don't like this (the globbing that is), but can't see any other way to do it.
My proposition is to keep only the original author of the file or use the format like:
@author: quermit, dejw
Rename to `installClickHandlerLast`.
@jessicabarbalho I already read this. Is this a requirement of design team? To show in a url the locale parameter?
So... North is negative X-axis (aka left)? :D
Is it required to be 10? Should changing the step size cause a failing test? Maybe it´s enough test if `stepSize`is defined ... Please tell me, I don´t know.
Side effect of how I refactored in Eclipse: first I renamed the class to `PmsConfigurationImpl`, then I extracted the interface and finally I moved the interface class to the api package.

Looks like it will take some manual cleaning up afterward.
try:

    [[ "$(uname -v)" =~ ^joyent ]] ||
      PATH="/usr/gnu/bin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin:$PATH"
>In ArchiveLink, wouldn't it be better to collect all values and send it to Redirect afterwards?

What do you mean?

>...sounds a bit silly.

You don't plan on searching for multiple things at once here.

Actually you'll have to use something like

```coffeescript
Redirect.to 'search',
  board: 'a'
  type: 'tripcode'
  value: '!MayhemxaEo'
```
to avoid guessing the type.
Hi kongove, for libvirt input method/target, it's a precondition to create a pool, if the pool doesn't exist, we should terminate virt-v2v converting/importing testing.  akong, thanks ;)
os.sep instead of / again?
You are about extension removal?
Not too happy with this. If there is an issue in the Filesystem stuff or the AutoloadGenerator please add a test to highlight it and I'll try to fix it. But ugly hacks should be avoided if we can.
This is wrong IMO. It should checkout the appropriate reference first to be sure it builds the right archive
Missing line break. Separate logical blocks by line breaking them
Haven't looked....I'm guessing these are the only model classes that are used in XML parsing?
Should be some comments above this line that explain what this plugin is for, where to find out more information about SQS, etc.

Example: https://github.com/logstash/logstash/blob/master/lib/logstash/inputs/heroku.rb#L4-17
There should be a way to get window form the `rawTab` which should be used here. This module should not be aware of `tabNs`.
I usually prefer something like \s\S, that is commonly used in the community, to indicate "everything" when I don't want to provide a full regexp pattern that match the specs. The dot is generic enough, but doesn't really means "everything".
However I do not have any hard feeling about it, so if you prefer the dot in that case I can replace it.
Is it a key value map ?
Hum. I can't see why we would use such promises?
`promise` and `future` are resolved immediatly. I don't see why we would use a promise if we immediatly have the result.
Nice way to generate ephemeral emails.
@lloyd - the entire cache is only populated once per server start?
this file should not exist, this is a merge error.
1. Disable the extension
2. Modify the log folder to an invalid path
3. Enable the extension

Those steps will cause us to fail initially initializing the logger and resetting the pref.
@rbillings Why did you remove this? Did you find a better way for login/logout tests to run without this?
这个id不是唯一的，唯一标示视频的是一个path 应该是  /channel/id 这个我再考虑下是不是得给视频一个唯一id..
ok. restoring it
Maybe it's better to call this user "admin"...
@apenney first, thanks for the contribution.
If we're going to fallback from `ifconfig` to `ip`, then we should have tests and fixtures for that. The tests help us be explicit about the behaviour that we expect. Therefore, ideally, I'd like to see some additional tests related to order only:
* if we have `ifconfig`, then we expect its output to look like X and we get Y from it (ifconfig parsing correctness, you have this one)
* if we don't have `ifconfig` then we should test for existence of `ip` (order test with guard of not trying to call something not there)
* if we don't have A but do have B the we should call B (order test)
* if we call B then the output should look like X and we get Y from it. (parsing correctness test)
This causes specs to fail, because they are (awesomely) regexing for "2011" to appear in the help docs.  Which means that we either need to fix the spec's regex to be tolerant or change the spec to 2012 and update all of the faces.  Probably the former is better.

if we change it to /20\d\d/ then no one will have to worry about it until the poor suckers who get stuck cleaning up "Y 2.1K" bugs in 2099.

     # ./spec/integration/faces/documentation_spec.rb:52
There isn't much in this block, but isn't it still best to not catch things like signal interrupts, systemexit, or memory errors?
Perhaps :file:`{$SERVER}/sagecell/` (i.e., an extra trailing slash too)
Fair point, though it does seem to pass the tests, but I can see race conditions happening later on.
statsOutputDirectory
there was a bug here i didnt notice, you can take a look at https://github.com/visionmedia/mocha/commit/cfec01222c1406404abae345bd245ddc26c8bb25 if you're curious
You can move this function out of `process_request` method (to the module level), and use lambda for `SimpleLazyObject`. `process_request` method will be probably simpler in this case:

    def process_request(self, request):
        request.user = SimpleLazyObject(lambda: get_user(request))
Let's rename it to `github_id` and set `unique` to `True`.
Please add a comment with the meaning of `0x0f`
missing empty line between 30 and 31
self.__dict__["private"] = bool(flags & kRTChatPrivate)
@satuaalto strpos($_SERVER['SCRIPT_NAME'], "asiakkaantilaukset.php") !== FALSE
This can be simplified:

    def username
      user.username
    end

Or, even more simply, you can just delegate this method by putting this at the top of your class:

    delegate :username, :to => :user
> I'm also wondering what is the use case for having FEED_DOMAIN != SITEURL:
> why would we want the feeds to be served at a different url than SITEURL?

I have no idea xD
I think we need @ametaireau take on this.
"[JBoss Deployment Structure File](https://docs.jboss.org/author/display/AS7/Developer+Guide#DeveloperGuide-JBossDeploymentStructureFile)." -> just a plain angle brackets link.
Sounds good. Right now it doesn't flow well :-)

On 1 Apr 2012, at 16:12, sgilda wrote:

>> +
>> +All you need to build this project is Java 6.0 (Java SDK 1.6) or better, Maven 3.0 or better.
>> +
>> +The application this project produces is designed to be run on JBoss Enterprise Application Platform 6 or JBoss AS 7. 
>> +
>> +
>> +Configure Maven
>> +---------------
>> +
>> +If you have not yet done so, you must [Configure Maven](../README.html/#mavenconfiguration) before testing the quickstarts.
>> +
>> +
>> +Add an Application User
>> +---------------
>> +
>> +This quickstart uses a secured management interface and requires that you create an application user to access the running application. Instructions to set up an Application user can be found here:  [Add an Application User](../README.html/#addapplicationuser)
> 
> I would prefer to leave this section and remove it from the "What is it?"
> It is more likely to be overlooked in the beginning section.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r630801
Sorry. I'm unclear what I need to do here. :-(

On 03/22/2012 05:16 PM, Pete Muir wrote:
>> +<user-name>  sa</user-name>
>> +<password>  sa</password>
>> +</recover-credential>
>> +</recovery>
>> +<validation>
>> +<validate-on-match>  false</validate-on-match>
>> +<background-validation>  false</background-validation>
>> +<background-validation-millis>  0</background-validation-millis>
>> +</validation>
>> +<statement>
>> +<prepared-statement-cache-size>  0</prepared-statement-cache-size>
>> +<share-prepared-statements>  false</share-prepared-statements>
>> +</statement>
>> +</xa-datasource>
>> +
>> +
> These instructions could be easily generalised to be for any datasource.
>
> Though, I am wondering if we wouldn't be better off using a deployable datasource.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/161/files#r593504
Why is this necessary and are you confident that it won't break MSVS 2008 or 2010?
So, we should unconditionally patch Date.parse?
Can't, really, since we don't globally support RTL right now, so I can't predict how to detect that we're in RTL. (We'll probably add `body.rtl` but it might be the `dir` attribute, etc.)
Should set height and width to 0px here too.
All tests should start from a known state. We should be able to assume that the page is not currently being watched, and allow the test to fail if it is. In the ideal world we'll be using a fresh test account and therefore no watched pages would persist from previous runs.

I would prefer to see an assertion that the page is not being watched with a suitable failure message, and remove the logic. To make this more robust you could even click on the random page link so the page being watched has less chance of being the same between tests. Note that if you do this you should capture the page name for debug purposes if a failure did occur.
this stops granting all privileges but what about the specific privilege for loading files or something similar? is that even possible?
Probably a leftover from TDD.
subjectを使う条件下をよく理解していなかったため、とりあえずitとしてしまっています。
たしかに、テスト実行時の可読性は下記の方が良さそうですね・・・

``
context "with '@hoge'"
  subject{ munoh.remove_noise("@hoge tweet!") }
  it{ should eq "tweet!" }
end
```
Ok. I rolled the dice twice, and "Rung" is now the new word we will all use...

Anyway, I agree on the conflict with Log.Level, and of the words listed I can only see "Scope" as a potential substitution. So we can try that.
`objects_hash` does not exist anymore, I guess it should be `objects_by_uuid`
Last sentence could use a reword.
Change to:

$oApp = new Application();

Don't forget the parenthesis
ahh. first non-book encounter with CI
странная конструкция..
All of the following deletions are okay because we end up recomputing the scroll area size in the call to updateScroll() that I added at the bottom of this function.
This should be done a bit differently, to take advantage of form validation.

the form needs to be validated:
```py
if form.validate():
    #Now we use the form.data dict:
    event.name = form.data.get('name')
    event.date = form.data.get('date')
    event.location = form.data.get('location')

else:
    #put form in context and return the same rendered template.
In OpenSlide terminology this should be `macro` rather than `thumbnail`.
I think you're right, yeah...the face does indeed need to change! I'll also fixup the unused var.
We try to keep all the CQL things uppercase. 
ie: `UPDATE Config SET ' + tempQuery.join(', ') + 'WHERE tenantid=?'`
Incorporate Nose-ster in the image and caption by using a different name (e.g., "Nose ring") for your related asset.
On travis composer is already installed :)
Понял о чем, прошу прощения. Я не в курсе этого, лучше спросить на форуме.
Спасибо за знакомство с функцией lround! :)
Странная реализация перемешивания массива, так как есть ненулевая вероятность что какой-то элемент останется на своем месте, или еще более забавно — вернется обратно на свое место в результате двух перестановок. В общем — получается случайная возможность что какой-то элемент останется на своем месте при мутации
Спасибо за отзыв. Пожалуй, соглашусь что так будет правильнее и исправлю
Данный код не гарантирует того что символ будет замещен на другой - в результате чего не произойдет мутации
например у вас на даной позиции находиться символ "A" и метод [self getRandomChar] так же возвращает "A".
Количество элементов, по сути, роли играть не должно, ведь в задании сказано чётко - методу mutator передаётся процент, который нужно изменить в последовательности. То, что сейчас ТЗ такое, что в последовательности 100 элементов, роли не играет. Завтра их будет 450 или вовсе 30.
Меня вот проверяющий пнул, что я 0 отбрасываю. =) По идее, ничего страшного в нуле нет, цикл не должен будет отрабатывать, а соответственно, ничего не должно поменяться.
This is probably not a good idea. We should find a solution that doesn't rely on `rescue`. Even if we do have to use `rescue`, rescuing `Exception` is a big no-no in Ruby.
Can you please [explicitly compare against nil](https://github.com/github/objective-c-conventions#expressions) here?
We should have at least one test that uses the macro, even if it doesn't do much, just so we have an automated way to make sure it expands correctly.
:ok_hand: You bet!
Also, `string.format()` is not needed for the header, but only for the data. I'll get rid of it in battery.lua as well.
The indentation in this function looks very screwy in this diff, is there a problem with tabs vs spaces?
Ok, what's the best way to handle it? I basically just need to know whether the device has a wifi connection or not.
> Basically it depends on how the time series are "clustered" inside the label. So maybe we shouldn't add the scaling.

ok fair enough. Let me remove it.
or -> for
this is scary. How did that change?
Come to think of it, it probably is, I'll add a copy().
Would it make sense to have a hemi parameter as well? It seems to me that if you use e.g. dSPM, neither hemi will ever be exactly all zero, so automatic hemi determination will fail.
> If I calculate the inverse inverse std to undo the mixing_matrix
> standardization I will get differences on let's say 10 % of the row values
> starting at about the 6th decimal. So the redo test will necessarily fail.
> However, np.allclose allows to set tolerance parameters. Any recomandations
> with this? Fiddle around or just drop the redo assert?

don't do this here but in a test using

from numpy.testing import assert_array_almost_equal

assert_array_almost_equal(a, b, decimal=6)
can you add a test that the warning is actually raised when you decimate too much?

see example of warning interception:

https://github.com/mne-tools/mne-python/blob/master/mne/fiff/tests/test_raw.py#L166
same here. Why are those lines here?
And it produces empty filename in KDE 4.9. I won't merge this change.
Instead of specifying < openmrs:globalPropery > I would rather be able to say caseConversion="global" so that I don't have to remember the gp name.
We're not fully consistent throughout the docs in this way, but we generally try to avoid using "we". Typically that means that I use "you" instead. For example, this sentence becomes:

>
Store the class in a file called ...
Is there a `FindCython.cmake` file available? This should be re-factored out so we can use it in other projects.
Shoot, we should make a CMake modules repository on GitHub of all of the files we'd have to create for this.
Oops, yea, this logic should be something like if filepath:sub(1, path.root:len()) == path.root then
double, пробел после двоеточия

А еще lang="en" больше не нужно.
tld?
Funciona ya que el `no-repeat`no tiene sentido si no hay una imagen y los navegadores son bastante tolerantes para parsear los colores. Creo que lo mejor es eliminar `no-repeat.
You have to check that the user is authorized to remove this account
Account is not found
Since this is no longer top level, we have to declare it here.
I'm not sure why you did this. Not all browsers (IE, big surprise) support console.log. Please revert these changes.
Well it did, the intention of the min/max was to allocate a range of id's for map specific menus - with the recent change I think the code will change to use a different approach and therefore this may go away with that.
the commented spec

  describe "#per_page" do
    it "should default to namespace.default_per_page" do
      namespace.should_receive(:default_per_page).and_return(5)
      config.per_page.should == 5
    end
  end

Explanation

if you could see that you have used here Category model, that is being generated by 'rake setup' while generating demo application for test.

And the gem 'kaminari', that you are using for pagination set default_per_page to '25' for each model, if you have not specified the record to display per page like

   class Category < ActiveRecord::Base
     paginates_per 50
   end
  
   you have not set anything like this.

   so default_per_page is set to '25' by default.

   so if you do namespace.default_per_page, this returns '25'   

   Now, with the line of code below you stubbed the value of 'default_per_page' to return '5' instead of '25'  
      
     namespace.should_receive(:default_per_page).and_return(5)

   Now, as you can see config is an object of ActiveAdmin::Resource class

     config.per_page is still '25'

   because, its value is set to self.resource_class(Category) default_per_page(which is '25', here as kaminari default,if you do not specify
   in the model) 

   see code below

      def initialize(*args)
        super
        @paginate = true
        if self.resource_class.respond_to?(:default_per_page) 
          @per_page = self.resource_class.default_per_page
        end
         if @per_page.nil? || @per_page == 0
           @per_page = namespace.default_per_page
         end
      end
     
   And therefore,

     config.per_page.should == 5 , this will never be true, as config.per_page is '25'
its server_default? really? that seems so very odd :D Why do these have defaults anyway?
Make sure you rebase and switch to InfinispanCollections.emptyMap
That was part of a previous direction I was trying to take. I have to problem with changing it to boolean.
This was a typo!!! And a bad one
you should link to the github project instead of the raw file IMO
My test fails here...

I'm getting the value wrong or is there a bug?
grep for middle.image
This is fine, I didn't know this was agreed upon. Could you change the padding on the element to `4px 2px` so the blue border has the same width an all sides?
Chris - we still need to change UI to send ":operation" => "basicity" for this to work.
- Are you sure you want to override the parameter ``$mimeType``? This often makes code less readable.
- Please always use braces to surround the code block of IF statements.
Are you sure you want to override the parameter ``$redirect``? This often makes code less readable.
Is it possible to define the element type for the returned array (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 169.
Should the return type not be "JsonRenderer" instead of "JsonStrategy"?
Can you add the `options = {}` here as well that way it's consistent with the other methods?
yes, I intended for this function to contain multiple function calls to build the project structure., although now that I think about it, it could be moved outside of this scope.
DRY - {{ 'selected="selected"' if t.type_id in notify_types }}
I dunno, IE7 is 3 versions back http://caniuse.com/queryselector . I vote for supporting current and previous browser versions. 

But in general i'm hostile to supporting old versions of stuff.  So I'm interested in what would be useful for you?
This won't work since error.message is never set. I think this was complimentary to line 155/156:

     $this->set('error.message', 'Unable to decompress data');
     return false;

I think you can simplify the whole thing to just this:

     $this->_getTarInfo($this->_data);

The exception will just fall trough than.
Turns out you don't need most of this! I did a search; python apparently comes with a word wrap feature: http://docs.python.org/library/textwrap.html

```
from textwrap import TextWrapper

bullets = []
wrapper = TextWrapper(width=80, initial_indent='* ', subsequent_indent='  ')

for paragraph in text.split('\n\n'): # Want to separate based on paragraph breaks, not just line breaks
    bullets.append(wrapper.fill(paragraph.strip()))

return'\n'.join(bullets)
```
This documentation is no longer correct.
This is not REST API.
Is this file missing?
If' we're not using jquery on the other reps yet, should this change not be in tiddler.html instead?

I kind of assume that jquery will be needed everywhere eventually, but that's eventually.
Theese brackets are not consistent with the other parts of the code, its just for codestyle, yes, we prefer 1 line things be without brackets
some line comments so any can read and understand what is doing some line of code.
do my eyes deceive me? =)
We should update this to lodash
Also again I think that the constants for specifying distance should be here and not in `CMStoreOptions`
This will cause fatal, prefix with `\`.
You can remove the duplication :-)
I've added additional commit - for using wooga.castle.prefix
This should be moved to build config of parent pom.xml-- I'm guessing the same config is used by all submodules.
definedvalues -> defined values
Ah okay; got why we needed the template. Nevermind my previous comment then.
"care _of_ propagation" - although I suspect that the whole sentence could be improved
Why the `else` ?

OTOH, all the calls to this "private" method have two arguments, so we might skip these tests.
Is it always possible that cfg_s->server_context could be NULL? It doesn't look like it's consistently checked before being used (like in ngx_http_pagespeed_determine_request_options).
Only the slsqp version has been changed so far...I'm waiting until we finalize the notation before I change the cvxopt version.
This is fairly platform-specific - can we use `Net::HTTP` instead?
In the very near future there may also be workers that are specific to cloud9infra, can we account for that?
No unnecessary empty lines please.
Yes.  Good idea.
Whereas the generation for the others packages was automatic, I will 
manually generate this one because here we apply "Sed" on some files 
which do not exist yet.

Thu, 4 Oct 2012 16:45:34 -0700, Thomas Gazagnaire :
>
> In packages/cairo1.ocaml-1.2.0/files/opam.ml:
>
> > @@ -13,21 +13,21 @@ end
> >  module Sed : SED = struct
>
> I think your forgot to remove this opam.ml
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/OCamlPro/opam-repository/pull/105/files#r1768301>.
>
The name is not even necessary, Maven will fall back to the id which is often more convenient when there is a problem and you don't know where it comes.
comment to 282 line
since this page is used all the time it would be better to include the search_materials.js in the main application.js file. This will reduce the number requests needed to load this page. To do that you need to modify:
app/assets/javascripts/application.js
and add a new require line for search_materials

For admin pages (like the home page content, and help page content editing) it is fine to use separate javascript_include_tags, however we might in the future want to consolidate all of those into an admin.js file.
BTW, you don't need to refer to it on the `window` namespace. All browsers pick from there anyway.
:migrate_data here too.
Ah damn, das hani überseh.
Need an example that yields with multiple args. Otherwise, this all looks really good.
As said above - is it possible to push all the implemented methods up to the abstract models module?
Again this will probably slow down the transition!
On 28/02/2012 13:18, Ben Francis wrote:
>>
>> -<div id="filter-controls">
>> -<span class="button" onclick="Camera.toggleFilter(this)" data-filter="fGB">blur</span>
>> -<span class="button" onclick="Camera.toggleFilter(this)" data-filter="fCMS">saturate</span>
>> +<div id="controls">
>> +<a id="switch_button" name="Switch source"></a>
>> +<a id="capture_button" name="Capture"></a>
>> +<a id="gallery_button" name="Go to gallery" href="../gallery/gallery.html"></a>
> On Tue, Feb 28, 2012 at 8:20 AM, vingtetun<
> reply@reply.github.com
>> wrote:
>> nit: The convenstion is to to use '-' as a separator instead of '_'
>>
> Done.
>
>
>> Also do you really want to replace the full application with the gallery
>> app? Sounds to me that you want to open a the gallery as a new application?
>> (window.parent.WindowManager('../gallery/gallery.html)). And can you add a
>> comment next to this code to remember to replace it once we have intents
>> (good use case for it!)
>>
> Actually I'm not sure this is a good use case for intents because no
> information is being exchanged, it's just a simple hyperlink from one web
> resource (app) to another. What kind of intent would it be?

What is you have installed another gallery application? This is an 
intent that just request to open an application that stores images.

> The window manager should detect that the hyperlink goes somewhere outside
> of the app, that the URL corresponds to the origin of another installed app
> and open a new app window with the gallery app inside. Unfortunately this
> won't work yet because all apps are served from the same origin.
>
There is some truth here but to me this should be automatically convert 
to an intent that redirect to a browser application (or propose to 
choose between them)
This is not true :P
I know it can be painful, but lets copy over each individual field here.  In the future there may be things that aren't appropriate to transfer, and this deepcopy would hide that.
On Thu, Feb 23, 2012 at 2:11 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>> +                    orig_result_return = handle.update(self.current_job,
>> +                                           dict(result=orig_result))
>> +                    return_val.append(orig_result_return)
>> +
>> +                    num_new = len(result) - 1
>> +                    new_ids = self.trials.new_trial_ids(num_new)
>> +
>> +                    for new_tid, r in zip(new_ids, result[1:]):
>> +                        spec, res = r
>> +                        new_rec = copy.deepcopy(self.current_job)
>> +                        new_rec.pop('_id')
>> +                        old_tid = new_rec['misc'].pop('tid')
>> +                        assert old_tid == new_rec.pop('tid')
>> +                        new_rec['misc']['from_tid'] = old_tid
>> +                        new_rec['tid'] = new_tid
>> +                        new_rec['misc']['tid'] = new_tid
>
> ANother option on this whole thing is to allow BanditAlgos to provide lists of configs and let the bandit algo sort out how it will compute them.

You'll have to elaborate if you're serious about this, I don't get it.
That would be good. I think this has good changes to be pulled into master, in case we furthermore have some in code documentation (i.e. doxygen) for all the isFoo methods.
Yeah, this may need to be returned to it's original state, I'm not sure, however, it was causing a stack overflow on the unit tests.
I think you want to check if the `Worker` is alive and pop a waiting client off of `#state.waiting` here.
```region_id``` is faster to read than ```r_id```  

I don't think we should be renaming too much stuff in hotfixes, especially when we are renaming them to less clear names.
Zac, I actually forgot an ``` instance_variable_set("@#{resource_name}", retval)``` right here, so it is not actually memoizing like the previous code.
This is very nice too
Oh, so currently if I do this:

```
  # assets_dir is the path to your theme assets.
  config.assets_dir = ":root/app/themes/:name/assets"

  # views_dir is the path to your theme views
  config.views_dir =  ":root/app/themes/:name/views"
```

The paths for the themes is not supposes to be added to ```assets.paths``` ?
Been fiddling with it for a while and couldn't get it to work.

Having those directories seems like a good default for unified themes though? Wouldn't want to put views in the rails assets folder.
which operating system
I am not sure which strategy is better. My opinion however is that we should do that in another PR. Both for AdaBoost and Gradient Tree Boosting. 

From a practical point of view though, I prefer the reverse approach. Use a large value of n_estimators and then prune if needed (using the `stage_` functions). (Everything is already there to do that, both for adaboost and gradient boosting.)
Hmm actually you removed that parameter? (why?)
there is a backport of the new bincount in utils. it provides the ``min_length`` keyword with does exactly this ;)
squash the last 2 lines

this makes me think that the external function that gives the strong_set should accept as parameter Xy and gram to be reused with precomputed gram matrix
the use of "payer" here seems misleading to me. Does the person need to pay or to receive money? Maybe should we name this "receiver"?
Yes, this is how I ended up doing it: https://github.com/squizlabs/PHP_CodeSniffer/commit/e0beeefdf90c4b8c693af8bc7000e15cf0c24ca6

Note that this change has already been released so it can be tested via composer now.
haha nice good plan
any reason we need to return false rather than nothing?
Same advice as last time.. change it to int32_t and it's a lot clearer 
that a specific size is intended.

On Wed, 5 Sep 2012, Walter Bright wrote:

> Date: Wed, 5 Sep 2012 14:07:00 -0700
> From: Walter Bright <notifications@github.com>
> Reply-To: D-Programming-Language/dmd
>     <reply+p-1538292-70a8da0f79039c3c7a05545d35b8e23dc4276cb4-40242@reply.gith
>     ub.com>
> To: D-Programming-Language/dmd <dmd@noreply.github.com>
> Subject: Re: [dmd] fix VC build failures due to added/removed files and a few
>     more issues (#1101)
> 
> > @@ -11,7 +17,7 @@ struct filehdr
> >  #define IMAGE_FILE_MACHINE_I386    0x14C        // x86
> >  #define IMAGE_FILE_MACHINE_AMD64   0x8664       // x86_64
> >          unsigned short f_nscns; // number of sections (96 is max)
> > -        long f_timdat;          // creation date, number of seconds since 1970
> > +        time_t f_timdat;        // creation date, number of seconds since 1970
> 
> No. The spec for coff is very specific - 4 bytes for the time. Using time_t makes it variable.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/D-Programming-Language/dmd/pull/1101/files#r1538292
If there are still things that need to be updated but need to wait for R6 to find the answers then add them to the JIra Issue for reworking label/font after R6
Comment out the unused parameters to avoid warnings.
No need to update the "patch" version yet, since we've not released 1.7.0-p1 "final". We can keep using the SNAPSHOT version for new changes, and freeze 1.7.0-p1 (and upload the Maven Central) when you feel you're ready.

Can you revert to 1.7.0-p1-SNAPSHOT ?
Are you OK with the signature change of filter_fp?
`eft` ?
Just where the line breaks
I think this is about the only thing I miss from Java... ;)
because it's wrong
can be simplified to 

sb = from.sb;

including the conditional code.
is the String.valueOf() really needed?
Then this needs to become `return currentversions` right?
Same here as for __init__
I'm not sure that `document.createElementNS(XUL, 'browser')` is going to work for an HTML document.
So that we should say `privileged XUL document`.

I would prefer removing `(which is either top level window or document from chrome)` as defining a privileged document would require a whole page!
A top level window isn't necessary privileged. If you do newTopWindow("http://mozilla.org"), this document won't be privileged, even if you pass {chrome:true}.
I thought about the clear cache case.  clearCache() is mostly used to support unit tests.  There may be a case where clearCache() is called when the configuration changes, but the caller of that method _should_ also be reloading the configuration.
So lazy in this case could be fine
Fair enough.  This is also very straightforward javascript, so it's unlikely to cause maintenance burden in the future.
this is a BC break as people have to change their code rendering the controller.
Please don't change the default language, or at least keep it on a different commit out of the merge request ^^,
What's your preferred solution for this? Should I change `prestart` to do `npm install && npm run-script grunt` ?

I'm not sure if this is the best way -- it'll run new build every time I want to run `npm start` which could be an overkill. Especially if I want to run tests on non-minified code which is BTW the default selected option on the page when you run `npm start`  -- you have to tick a checkbox to enable 'use minified code'.

I can think of the following alternatives:
1) a shell script which will run the build if certain files are not found, otherwise ask interactively 'hey, you seem to have a build, but do you want to do a fresh one?'
2) same as above, but just log a warning ("you won't be able to run tests on minified code") instead of doing automagic.
please use the @FindBy.
This logic is weird IMO. Calling the method twice would throw a notice.
@shacker can we change this? We shouldn't have href="#"
Hrmm, not thrilled about the duplicated routing, but until I can offer a better solution, there's not much to bicker about for now.
I noticed that - shows weird indent on GH but no spaces shown in my editor. Puzzling.
@christianv made the default final-redirection target /profile in his client-side pull, so please change that here too.
@shacker can we use single quotes?
Can we add that as a comment to the code? Want to make sure future readers understand why.
I can point out whitespace issues though! `function flatten( item, folder ) {`
@fcharlier is this auth host supposed to be the keystone server? Parameter docs would be really appreciated
Missing \\ ?
Next commit will have the following output.

```
msf  post(gpg_creds) > exploit

[*] Finding .gnupg directories
[*] Looting 1 directories
[*] Downloading /home/user/.gnupg/pubring.gpg -> pubring.gpg
[+] File stored in: /home/user/.msf4/loot/20121004211229_default_192.168.2.2_gpg.pubring_046822.txt
[*] Downloading /home/user/.gnupg/random_seed -> random_seed
[+] File stored in: /home/user/.msf4/loot/20121004211230_default_192.168.2.2_gpg.random_seed_574616.txt
[*] Downloading /home/user/.gnupg/secring.gpg -> secring.gpg
[+] File stored in: /home/user/.msf4/loot/20121004211231_default_192.168.2.2_gpg.secring_613248.txt
[*] Downloading /home/user/.gnupg/sshcontrol -> sshcontrol
[+] File stored in: /home/user/.msf4/loot/20121004211232_default_192.168.2.2_gpg.sshcontrol_953833.txt
[*] Downloading /home/user/.gnupg/trustdb.gpg -> trustdb.gpg
[+] File stored in: /home/user/.msf4/loot/20121004211233_default_192.168.2.2_gpg.trustdb_631340.txt
[*] Post module execution completed

```

```

msf  post(gpg_creds) > loot

Loot
====

host         service  type             name             content     info                    path
----         -------  ----             ----             -------     ----                    ----
192.168.2.2           gpg.trustdb      gpg_trustdb.gpg  text/plain  GnuPG trustdb.gpg File  /home/user/.msf4/loot/20121004211233_default_192.168.2.2_gpg.trustdb_631340.txt
192.168.2.2           gpg.sshcontrol   gpg_sshcontrol   text/plain  GnuPG sshcontrol File   /home/user/.msf4/loot/20121004211232_default_192.168.2.2_gpg.sshcontrol_953833.txt
192.168.2.2           gpg.secring      gpg_secring.gpg  text/plain  GnuPG secring.gpg File  /home/user/.msf4/loot/20121004211231_default_192.168.2.2_gpg.secring_613248.txt
192.168.2.2           gpg.random_seed  gpg_random_seed  text/plain  GnuPG random_seed File  /home/user/.msf4/loot/20121004211230_default_192.168.2.2_gpg.random_seed_574616.txt
192.168.2.2           gpg.pubring      gpg_pubring.gpg  text/plain  GnuPG pubring.gpg File  /home/user/.msf4/loot/20121004211229_default_192.168.2.2_gpg.pubring_046822.txt
```
This needs to be in a try catch as user may not have permissions to read the dir. 

[*] Recusrively searching for Groups.xml on DOMAIN...
[-] Post failed: Rex::Post::Meterpreter::RequestError stdapi_fs_ls: Operation failed: 1396
[-] Call stack:
[-]   /opt/metasploit/msf3/lib/rex/post/meterpreter/extensions/stdapi/fs/dir.rb:61:in `entries'
[-]   /opt/metasploit/msf3/lib/rex/post/dir.rb:19:in `foreach'
[-]   /opt/metasploit/msf3/modules/post/windows/gather/credentials/enum_gp_local_passwords.rb:83:in `find_paths'
[-]   /opt/metasploit/msf3/modules/post/windows/gather/credentials/enum_gp_local_passwords.rb:71:in `block in run'
[-]   /opt/metasploit/msf3/modules/post/windows/gather/credentials/enum_gp_local_passwords.rb:68:in `each'
[-]   /opt/metasploit/msf3/modules/post/windows/gather/credentials/enum_gp_local_passwords.rb:68:in `run'
Maybe define `zoom_level = 2**(level-1)` and use it in the three zoom calculations. (For readability, rather than efficiency.)
I would tend to agree here. I realize it's a fine distinction, but the fact is you can call this many times and it will always update, if the remote resource changed, then the end result changes, but in the end it's always doing the same thing repeatably.
You will need to listen to the LegendItemList
That's fine with me, as long as we have a clear write-up of doc best practices for me to work off of.
tests 2, 6, 7, 8 and 9 have diffs which don't look different to me. Am I missing something?
Incorrect method name `removeChild`
the change in handleGetActiveTab should be merged already. Did you update with master?
Thanks - fixed in next update.
Use >= and the FR passes on Nexus with Android 4.0.4
There should be some validation to make sure driverGlobal.harnessConfigsDir exists.
Agreed, I'd rather stick with print(). I put the error in the log because I'm also logging all of the other appcache events. (Since the tutorial doesn't do much with most of them I thought it would be a useful illustration of the order in which things happen when working with the cache.) But there's certainly no reason we couldn't show it in the alert as well.
s/document.query/query/g
It's not really nice to have constants that change in a subclass.
You could define all of these in the constructor, however, then you would need an instance of the class when you want to access them.
Please use LGPL
I didn't touch this line, plus doesn't make sense as part of this commit, I'm sure we can land this right after :)
Over the weekend I tried for an object mapper.  Succeeded, but there where some inconsistencies I did not like (do we allow the for modification of keys as well as values?).  For now, lets go ahead and remove the object input option from the two families.  I'll have a patch up by the afternoon.
you're missing a quote at the end
No. The title is simply used to *name* the resource.

What is created is the path.
А насчет каста?
>>The matter of faulting one for one's style (particularly if just a mainstream one) is not even in the question, so it's odd to even mention.

>I bring it up because you're indicating that there's something wrong with the style being used here, and nowhere has it been agreed to use the style that you're suggesting over the one being used here. So, it seemed like you were objecting to code using this style at all.

The main issue here is that we're changing a module that has 9KLOC written in one style to one that has 8,99KLOC written in one style and a couple dozen lines written in a different style. This is not only jarring for readers regardless of their own preferred style, it also creates a precedent - now people will start making their own random style changes together with their actual code (some of that is happening already). So before long the whole code becomes a mess.

Again: we had largely agreed to preserve the extant style when making relatively small changes to a module.

>Now, if you want to argue that the code here doesn't follow the style of the module as a whole, then there are grounds for that, since we're trying to keep the style in modules consistent, but if you get picky enough about what constitutes the style of the file, then there you are always going to find problems. Personally, it never even would have occurred to me to do any other kind of indentation, even if I were trying to follow the style in the file. And it's not like the style of the file is all that consistent anyway - just look at stuff like whether the body of the if statement goes on its own line or not or whether braces are used or not.

And that doesn't help either. But mentioning that the problem already exists is no justification for creating more of it.

>It doesn't even consistently put braces on their own line, even though that's one of the few universal rules. The reality of the matter is that unless you watch every single commit to a module like a hawk and insist on a particular style for every commit, the style is not going to be consistent, even if the majority of committers try to keep it consistent. And without you explaining somewhere what exactly constitutes the style of the file, I'm sure that a number of us will screw it up even if we're trying to follow the style that you want.

Aw, come on. This is not a court of law. The style of any module is fairly easy to discern and follow. We could and should add some linter that detects such issues automatically, and fixes some. We do this at Facebook, and it does make for better code and easier to review diffs.

>So, if you want to insist on your style of indenting, because it's consistent with the rest of the module, then fine, but if you're going to be super picky about formatting, I think that it's pretty much a given that you're going to be disappointed.

I don't think my disappointment is at stake here as figuring what's better for the project. And it's a given that random changes to a module's style is not better for the project.
I don't really get what you mean by "`$(D dchar) qualified like $(D T)` then?
s/will never return successful/will not return successfully/
Shouldn't you only observe ProcessInjectionTarget<Person>?
This is only ever called in test code. Don't add it to the interface; just implement it in `MockClientsDataDelegate` and adjust the types of call sites.

(Phrased differently: would it ever be meaningful for me to call this from real code? I think not.)
pls always document exceptions; what do they mean, when they're thrown (typically at least, ...)
The client always 'wins' as per the spec. (at least my understanding). The reason I added the server weights was in the case where the client doesn't give a preference, for example, assigns equal q weighting to multiple media types or uses an asterisk form. For example, Google Chrome gives equal weight to text/html and application/xml+xhtml, but a modern website would usually have a preference to generate HTML5 (text/html)
agree, but we should do that in mendocino, right?

if it were python, i'd write a decorator.  is there an analogous approach in clojure?
rm 87
Ok, probably we can check if on an argument is set ParamConverter annotation. I will try to make it that way.
Transformation of double to single quotes across the entire codebase are outside the scope of this PR, please revert.
you could remove ``getManager`` here as the registry has a shortcut for ``getRepository`` directly
I think the fox really walked, didn't he?
No, I was wrong here, I thought only the actual import methods returned an `ImportResult`, but actually `map_dict_list` (or `add_dicts` if you rename it) also does. I'm not a huge fan of that - I think it'd be better to be consistent about which methods return an `ImportResult`. Currently this one is the only non-import method that does - I think the external API of `SuiteImporter` would be nicer if it didn't, and any warnings/errors were just delayed and added to the result when you actually call the `SuiteImporter`'s import method. But given the internal structure of `SuiteImporter`, since the dict of suites is keyed by name, you can't actually add a suite without a name. So I guess you'd need to add a separate internal list of "suites without names that someone tried to add". Up to you, I don't feel that strongly.
:+1:

For reference, see [RFC 2606](http://tools.ietf.org/html/rfc2606).
I don't know if it matters. Like `controls` in a `video` tag. I never put `="true"`. Is that a HTML validation infringement too?
No reason other than making the comment visible and ugly.
Is statics last a Spring convention? My Ctrl-Shift-O puts them at the top.
What's the motivation for changing these keys? Can we do this in a point release?

Doesn't this mean that entities stored using 2.1.0 won't be visible in 2.1.1?
I see your point, but in this case adding async operations here would change the signature of the method in question (to pass in the callback) and break this test anyway.

-Chris

From: André Rodrigues [mailto:notifications@github.com]
Sent: Thursday, August 16, 2012 1:11 AM
To: WindowsAzure/azure-sdk-for-node
Cc: Chris Tavares
Subject: Re: [azure-sdk-for-node] Making errors instance of Error() (#317)


In test/services/core/serviceclient-tests.js:

> +  , azure = testutil.libRequire('azure')

> +  , ServiceClient = azure.ServiceClient;

> +

> +suite('serviceclient-tests', function () {

> +  test('NormalizedErrorsAreErrors', function () {

> +    var error = {

> +      'message': 'this is an error message',

> +      'ResultCode': 500,

> +      'somethingElse': 'goes here'

> +    };

> +

> +    var normalizedError = ServiceClient.prototype._normalizeError(error);

> +

> +    normalizedError.should.be.an.instanceOf(Error);

> +    normalizedError.should.have.keys('message', 'resultcode', 'somethingelse');

> +  });

I see. Wouldn't it still be safer anyways ? Example: in case someone adds a async call in the future and happens to forget to add the done ?

—
Reply to this email directly or view it on GitHub<https://github.com/WindowsAzure/azure-sdk-for-node/pull/317/files#r1390511>.
Yes! my formula is to do the most simplest thing first if you are repeating that make it dry but in this case there was a bit of hurry so I just kept it this way it will be updated in the next pull request

--
Wasim

On 15-Oct-2012, at 11:56 PM, naleksi <notifications@github.com> wrote:

> In lib/tasks/surveyor_custom_tasks.rake:
> 
> > @@ -31,6 +31,11 @@ namespace :surveyor do
> >          elsif question_number > 8
> >            question_number -= 4
> >          end
> > +        if question_number >= 9 && question_number <= 15
> Renumbering through a lookup table instead of hardcoded rules might be more maintainable. Probably even better would be some general renumbering rule, so that the same custom_task would work as broadly as possible. However, that is bigger refactoring that should be postponed until other surveys have been prepared.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Noo, you be breaking my close tags. Use <br/>, not <br> for XHTML compliance.
There should be a message for every exception thrown.
So, do we store the message digest in the microTable HashMap in BigInteger also ?