labofsahil/github-event-dataset-2012 huggingface dataset:
thx for comments on original author's patch, I'll make improvements and endeavor to take a bit more ownership of patches I revise.

re transactions - mod_wsgi docs have this to say:

"Because the auth provider is always run in the Apache child processes and never in the context of a mod_wsgi daemon process, if the authentication check is making use of the internals of some Python web framework, it is recommended that the application using that web framework also be run in embedded mode and the same application group. This is the case as the Python web frameworks often bring in a huge amount of code even if using only one small part of them. This will result in a lot of memory being used in the Apache child processes just to support the auth provider."

so,  pro: the connection_close should never slam connections of the wsgi handler working on requests, con: the auth handling child process in Apache needs to load up enough of Django and the ORM to perform the auth check.
Could you please explain the reasoning behind this? Why shouldn't we just write `gem 'rails',  '3.2.0'`?
As with above, I wanted cleaner hlint (especially as I would like to be able to happily use hlint on my own developments in cabal itself). In any case, is there a benefit to listing the number of fields in the constructor here?
Why isn't `jQuery.fn` being used?
Because if `a:contains((Link))` is valid, isn't `a:contains()Link()` as well? And then what do you do with `a:contains():eq(0)`?

We need to differentiate subselectors from unquoted strings.
@slygamer

This seems like it was unnecessary as Threading.BlockOnUIThread() does GL.Flush() internally.

Right?
Can you open a new issue for it? I think it's unrelated to the stored playlists cleanup.
Ideally is a state achieved by more than simple renaming. It was conscious choice not to change any of that in this PR. :-)
We should probably put this in base.py. local.py is really for overriding settings--not creating new ones.
The name change is because if I `import json` and then try and use `json.dumps`, it tries to call the method `dumps` on the function being defined, since it is also named `json`. This might just be a case of poor naming, but I think this name makes the most sense for the template filter.
Can't hardcode /usr/local
I'm the source.

ladspa, while vital, isn't updated anymore, so this can't be pushed upstream.
here is where I call the partial for the common navigation
So the rule is to always use classes? Like: 
function Translation(){}
Translation.prototype.translate = function () {}
module.exports = new Translation();

Of course the constructor is empty and no code will be executed.
namesvorschläge? "bytes"?
I'm a little surprised this passes travis, since this must read `generate = staticmethod(generate)` to work correctly.
I suggested it because I noticed we're using a lot of shell methods, and ShellJS could remove 3 (mkdirp, rimraf, which) dependencies (it has none of its own) and make it even more JS like and succinct to do shell operations.

But no strong opinions on it, just thought it would make that kind of stuff easier. Maybe just create a ticket and discuss it for the future?
Hoist these variables out as advised before
Is there a way to change the default save option on the TableStorageProvider?
Please spin it as a new bug. This is not just a simple change. I don't want to make any logic changes in HTMLUtils.js since any change may introduce another one easily.
Google translate gave me "Perhaps some of the actions that use index files may not work properly." May just be another bad translation, but this should read "Actions that look up files in the index may function incorrectly."
Could we link directly to the section on Live Development? I was able to manually add an anchor tag (though github does something a little weird with the anchor and renames it), so you can link to `https://github.com/adobe/brackets/wiki/Troubleshooting#wiki-livedev`.

Also, it looks like there isn't actually any info there yet on installing multiuser Chrome, etc. Were you planning to add that, or do you want to open a separate issue to get that updated?
I ended up removing _removePopup() function completely since complexity of having this helper function isn't worth the savings of reusing the "index" var. I don't expect there to be many visible popups at one time, so computing the index more than once isn't costly. I also made the other simplifications you suggested.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Wednesday, July 18, 2012 1:25 PM
To: Ty Voliter
Subject: Re: [brackets] fixes issues #1270 #1271 #1272, ESC key handling with popups (#1276)

> @@ -91,8 +84,7 @@ define(function (require, exports, module) {
>       */
>      function removePopUp($popUp) {
>          var index = _popUps.indexOf($popUp[0]),
> -            initiallyInDOM = $popUp.data("initiallyInDOM"),
> -            removeHandler = $popUp.data("removeHandler");
> +            removeHandler = $popUp.data("PopUpManager-removeHandler");
>          
>          if (index >= 0) {
>              _removePopUp($popUp, index);

_removePopUp is a private function that's only called in 2 places. Seems unnecessary to have the 3rd parameter optional. Why not specify it here, then remove the logic that sets the default value?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1276/files#r1191579
By the way, the eXclusive OR might not look obvious, but I felt it was less misleading than a not-equal-to operator.
can we reuse fetchText from mode completer.

btw why does this use sync xhr?
Using an anonymous function here is a little bit fragile, in the face of hot code loading. Changing the code, recompiling, and loading the module will not change the definition in the registration. The registered definition may even be expunged by repeated code loads, which would lead to bad-function errors when calculating stats.

Since there's no need to close over a variable here, a `{Module::atom(), Function::atom()}` tuple would fit the bill, and be more stable.
Also, we should be tracking threads that we create and be periodically checking if they're still alive. Otherwise it'll be possible to get into weird situations where everything looks alive at the OS level but stats won't be going through because the client threads died. Note to self that we should also add similar logic to the server side as well.
Same thing as `First_Name`
LGTM (but we will need to discuss what's the approach we want to use with "poor" tests)
I don't get it, why it this line needed? why we need overloaded method?
We do not know how many languages we will support. But for now do not use drop down list, we can always change design latter.
This is better. I would leave it like this until we will try to mangle with URL anchor. Then we will have to use JavaScript additionally to change the value as we change the URL anchor. But until then this is better.
I don't think you meant to do this, right? If you can avoid it, don't update the Popcorn submodule incidentally.
Why do we do this check here and not in EditorHelper?  It seems odd to force editor authors to have to deal with this dependency.
What about non-webm, do we care for 0.5.x?
Some indentation would be nice here.
This prefix is not necessary
You don't need to do this redirection. `ToolTip` is an obvious dependency here, so just use it directly.
What does `100` represent? Can it be a const instead to avoid magic numbers?
misuse of `parseInt` -- `value * SCALE_BASE` is not a string
This is what I added
ПРоблемы с отступами
I'm not sure how I feel about this; it's kind of tricky to read.
It feels like there should be a method on Product that just takes an environment and returns the repos in its default content view. I'm guessing that I am overlooking something though?
This seemed like somewhat of a dangling after thought if it is the only link hanging out at the bottom of the application itself.  I feel like user's ability to google or go to our website directly is enough.
Can't you move this code in the setting observer?
I see this keyboard even if I try to reach a symbol layout from English layout (there is even a "拼" button on it)
With my PR you can change this to `Table(dset)` as it is ducktyped (I know only a minor improvement :wink: )
是的，我来改~
我认为： 外部一致应该不是数据一致，是调用方式一致，外部我们需要提供一个js的sdk的东西，让写js的人不需要知道我们的url和参数的关系，只要通过a.b.c类似一致的方式获取数据就好了（让js的'.'等价于php的'->'）。这个本来让hax帮我写的，他一直没时间啊。。。
Afaik this could be the same file to which bitcoind writes, no? So Leave as is.
It's very frequent in my output.. Hmmm. Would you prefer another command line flag other than -debug were used for this?
qmake FIRST_CLASS_MESSAGING=1
almost the entire codebase uses loggers rather than fprintf, they are better because they can print the time and log level and they can in the future be switched on and off on a line by line basis.
PHP behavior here is to throw a NOTICE, can we emulate that with E_USER_NOTICE instead?
Have you checked that marking it as `js` works or do we need to mark it as `javascript`?
installed_system_id
But expr is `parsed$expr[[i]]` so that's already pulled out?
To get this to work for me I need annotate to imply force otherwise I get the file not found error below.

Simply setting `args.force = True` in the same block as `need_cythonize = True` solves the problem for me.

```
Cython completed successfully but the annotated source could not be read.
[Errno 2] No such file or directory: u'C:\\Users\\dhirschfeld\\.ipython\\cython\\_cython_magic_6eb34c8621696ead6242b637e2311da9.html'
```
Seems like `render-error` in the other branch should be called `js-error`.  Aren't they really the same thing?
Or 'call signature'
I think this can be a class level attribute, since it's static.
wouldn't you want super.apply(from) as default?
That's my IDE removing white spaces at the end of the lines. I will change the settings.
Same thing here with offsetting by `frame.origin.y`.
You evil, evil man. Let's leave an empty string unless @arrbee has a better idea.

(I don't consider exporting an `extern const char *` magic pointer value a better idea. :p)
`qDeleteAll` should work for `QMap` as well.
This goes back 4 spaces.
Actually, you should be passing user here right?
What's up with these commented lines? Do they represent a todo item? They should either be uncommented or removed.
oh yeah,  I forgot about that...  added an if check for this one.
Extreme nit-picking champships:  s/x/i
This is not needed if you don't do anything in it. The super() call is implicit.
As I'm using ``'report'`` as the default value on the middleware side, I'd like you to use it as well. If we ever add other values or add something that checks for that value, we will avoid stupid bugs. Also consistency is always good! :)
It might be a good idea to refactor the `.=` into an `implode(' ', $actions);` where `$actions` would be turned into an array
Since this function could be called several times it might be worth having a check whether this template function is already part of poirot before we add it, and its partial, again.

Probably something simple like:

    if (methodName in poirot) return true
Despite having proffered the example, I actually quite agree. Disregard the if.
Could you use the `CURRENT_LANGUAGE` constant for this instead please?
We've made a lot of changes to the installer, these will conflict. Can you do this in the 2.2/develop branch to reduce conflicts?
extra blank line here.
I changed `Form::add()` and `FormBuilder::add()` to accept numerics.
is it intended to change the icon only in verbose mode ?
yesyes, My bad. fixing it allready ;-)
I would like to keep the class even in master if possible.
FormUtil does not seem to be used
it should be ``{@inheritDoc}``
The function name must be fully qualified.
There are several reason why I thought it would be better to wrap ChannelBuffer and provide a separate interface.

1. Each time a user intends to read from a MySQL packet, a ChannelBuffer needs to be created with the correct ByteOrder. It just seemed more naturally to offer an interface specific to the codec that assures this.

2. There are specific methods that a ChannelBuffer doesn't offer and are at the core of the protocol (readLengthCodedString/Bytes and writeLengthCodedString/Bytes). This could have easily been offered as a method in a an object ex. Buffer.readLengthCodedString(c: ChannelBuffer). Again, I thought it would be more naturally to provide this as part of an interface.
Why these comments don't follow standard C# style?
standard through rest of feed view controller gives preference to original post over reply in conditionals
space in naming standard as mentioned above
The thinking here was that there could be tons of replies for a post that the user doesn't necessarily care about, bogging down the original response of posts.
It's also more complicated on the backend side as there could be a recent reply to a post that shouldn't necessarily come back if the original post is too old to show up.
We haven't done it usually on this project, but it makes reading difficult so I'd say I'm in favor.

Not worth doing wholesale, maybe just as you encounter it?
行末多余空格
Testing the bind_a;; tests bind also
Encapsulate Field in an internal class.  Include serializer and TTL from optional TTL annotation.  This will make serialization much faster since you won't have to call Coercions all the time.
Missing "e" for Archive.
This change still needs to make it in...
The newline doesn't help readability for me, but I can appreciate that it might for others. 

If we are going to do it that way, I would prefer to see a full blown mapping using dictionary syntax, with the ```::``` directive and a newline before the example, and a newline after it.
Этот метод можно переписать на цепочку вызовов `.then()`.
Вложенные вызовы `Q.when()` выглядят ничуть не лучше вложенных колбеков.
Посмотри, как реализована функция `start()` в `lib/server.js`, например:
https://github.com/bem/bem-tools/blob/server/lib/server.js#L11
This file should be deleted, we no longer need it!
Would prefer `@players[name].cards.hand(true).length`
Mag dit niet op FreeBSD?!
the method useDefaultintroduction and setIntroduction are unused
I don't believe CDNJS is a leading 'standard' for hosting JS libraries, and to concur with @stof, the examples should always run on the latest released version, and CDNJS won't always have the latest version. Although the examples need some fixup anyway, because not all the features are documented yet.
static_cast?
I don't believe these changes are correct.
I don't get what you mean here, there is just one server start in @Before method, one initialization of InitialContext in @BeforeClass,... Besides, the only currently included test works with stopping servers so some servers might be turned off after it, so we need to turn them on again in @Before for other tests (if any) to be able to work.
Why are you removing tests?
The option is read as text, we should also set it as text. Same above for optgroup.
Everett noted that ideally the modal would be a sibling to its triggering element but obviously thats not achievable.
He was happy with this removed from non-modal dialogs.
Just thought you wanted to limit it to JS from looking at existing file, but sure, will update the .editorconfig later today.
не получится что у нас на каждый просмотр странички пойдет update в базу?
nit, we could have a `.asterisk` class
Nit: would you put the FTU section at the end of the file, rather than splitting the “Device” section, please?
you are right. and the condition has been simplified.
`alarm-edit` ?
Steve is going to modify 'DeleteMethod' in next pull ;)
ok, sounds reasonable. I was just curious.
if you use the `hidden` attribute, you can leave this rule alone :)
I think [no](https://developer.mozilla.org/en/DOM/element.setCapture)

>Call this method during the handling of a mousedown event to retarget all mouse events to this element **until the mouse button is released** or document.releaseCapture()  is called.
This only fixes the list views; it doesn't fix the problem for the tiles view.

I don't like that you have to manually apply this style in JS.  Could you instead apply it to the container element?

Or, if that doesn't work how about li.list-item:last-child { padding-bottom: 4rem; }
I think enabling deleting a FB contact would break things. I suggest to create an issue and address it in another PR. 
#4092 is tracking the issue.
this is the content of the main region
You can just explicitly list the arguments in the function(...); no need for the fancy destructuring assignment here.
The details of the 'edit bookmark' functionality are being discussed @ https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.gaia/uatQKVZvgJk[1-25]

from a quick glance I think this is v2 priority for the UI, and definitely wont block this pull request, but a related issue should be opened
to show the link functionality in an independent view without losing context in contacts and without polluting contacts/index.html
since you're optimizing, consider:

for(var n=0, len=word.length; n < len; ++n)

I don't actually know that this ends up being faster, but I see it in hot loops.
Also, aren't status cods always numbers, why are we storing it as a string?
This comment should go because there are plenty of reasons to use this feature in production.
dunno why it shows up weird here, it looks fine in mine =P I'll get on those
Good point. A default Monoid on this doesn't make sense.
I think M_hat.write would work.
Move everything below to ``../server.py``, rename this to ``mock.py`` and the package to ``views``
I don't understand. Isn't this using the updated DB interface?
Please document this function and also should this raise an exception if the caller is using this function incorrect?
Move the node_load() outside to own variable.
Typo: "Measurement". You have this typo in several places, including the comments, please scour the source for this.
Should I be moving all of my javascript to the bottom of the page including the `<link>` tags for importing jQuery and dataTables?
there is no need to check #ifdef,  you can hide response body creation in SHKLog() macro. This way you might avoid #ifdef
Just spy on the function Route, doesn't it work?
Should this line be 'self.textField = [[[CustomUITextField alloc] initWithFrame: frameRect] autorelease];' ?
Since textField is a retain propety.
IMO it should be: `$buffer = '';`
Waiting for feedback before following up on this.
possibly controversial: making private code public
If  `#flash-container` doesn't exist, `$("#flash-container")` will return `[]` which will evaluate to `true`. A solution could be 
```coffeescript
flash = $("#flash-container")
if flash.length
   flash.click -> $(@).slideUp("slow")
   ...
```
done - d914a1b50caf8620852c8cdcc96b483a2b2a4979
move to model
before_create
We don't support anything earlier than Gecko 2.0 now so do we even need to handle the case where triggerNode doesn't work?
@seanmonstar - that's good to know. Thanks @warner, your assessment is sound.
Should we add this catch-all back in?
Is there a good description of this somewhere?
I would use "... has not been changed"
It seems like this should probably rescue StandardError and Psych::SyntaxError specifically
Conflict wasn't resolved when merging.
Moving `dashboard.js` caused the graphs to not display.  Moved all but `dashboard.js`
I've verified -- the original logic attempts to pull from the peering manager first, and then, if no instance is present, tries to pull from the current instance. As such, this represents a change in logic and a potential break.
There's no reason to re-format this paragraph. The CS states a soft limit of 80 characters, and a hard limit of 120. a few characters over is not a problem.
As parallel execution may follow I'd prefer current (eager) algorithm to avoid possible exceptions in other threads.
Do we really need the ellipseColor1 and Color2 parameters? It seems like everyone is passing in the same colors.
Yup, it just needs a test case, and it needs to be pointed at the **dev** branch.
K, minor nitpick: per the coding standard, we don't do inline comments. Other than that, this looks perfect, and I'll merge immediately.
See comment on commit
RbacService.
unused use statements should be remove, not commented
updated, pushed


On Thu, Nov 8, 2012 at 3:19 AM, José Valim <notifications@github.com> wrote:

> In lib/mix/test/mix/cli_test.exs:
>
> >        assert output =~ %r(\* creating lib/new_with_tests.ex)
> >
> > -      output = mix "test"
> > +      output = mix "test", [{"EXUNIT_CONFIG","none"}]
>
> Simply add System.set_env("EXUNIT_CONFIG", "none") at the top of
> lib/mix/test/test_helper.exs.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/636/files#r2067941>.
>
>
If you begin doing any non-trivial amount of date handling with JavaScript, you should use Moment.js: http://momentjs.com/
Does the config override the command line or vice versa? I think the command line should have the final say, and I am not sure the above code does that.
Order of import statements
I would love to arbitrate, but in all honesty, you both know more about this that I do!

I certainly feel we need to do this consistently across any JBoss project that touches REST, so I think we need to resolve one way or another.

Right now, it seems that Marius has convention on his side. But instinctively I would agree with Mike's scheme.
This should have some comments, could you send a pull after merge for this?
should all these var's go up higher? I know variable hoisting will take care of it, but I was confused by the cache_key reference in 64 before I noticed this.
Nits: s/dont/don't, s/bedrock/the Bedrock
You can just return the result of this line
No need to ask him, people will want that URL to be localizable. /contribute is en-US specific right now, but someone has been trying to localize the page for es-ES. More localizations for that page or other contribute pages will happen in the future. 

How would I go about making that link localizable?
And then here you could do:
```python
r = logged_in_client(vouched=True).get(reverse('search'), 
                                       dict(q='Fin', nonvouched_only=1),
                                       follow=True)
```
Typo: you should add a space after the bug number.
`Event` part is obvious.
Munoh has many rooms というassociationを追加しましたが、特にcontroller specは変更せず、FactoryGirlを修正しました。
Sounds good to me. If you remove the need for the url parameter as per @zacc's comment then you wouldn't need it in launch either. I think the switch_to_frame argument in launch should default to true.
I think that the options attribute could be removed because it is not currently used.
Yeah. I'll put up minified versions of everything and package it all up once its r+
This file can be completely empty.
There's a missing ) at the end.
Missed the indentation for this one.
Please add `USING CONSISTENCY QUORUM` to these queries.
I realize the API doc specifies single (`user`) but wouldn't it make more sense to have it in plural form (`users`)?
Some popular endpoints such as foursquare and twitter seem to use the plural form.
Is there any reason for not running this before line 19 and then using the group object in the checks on line 20 and 24?
> On the other hand, it is true that I'm filtering on trait, module and abstract classes. I should check what happens in Java for abstract classes

Also in Java abstract test classes are not reported. So, the behavior is consistent (to the Java one).
Should be a space between the * and the start of the comment.
@tsetimmy 
I modify VisitHicudaExprList a little bit, so this function is no need anymore.
(will fix)
Misschien ook handig om deze functie te noemen: `handleWallCollision`?
Why change this to be less reliable?
Просто я хочу добавить полноценную категорию, без изменения файлов головного класса Cell
Я читал внимательно и несколько раз тех задание для проекта. Там нет четкого указания на этот факт.
Читая комментарии других я видел что из этого в результате выросла проблема! Это говорит о том что ТЗ поставлено пока не профессиональным постановщиком. Да и все это задание - это проба нового инструментария. А алгоритм как убрать повторения можно дописать и я видел несколько очень красивых решений этой проблемы.
percent - процентный показатель, и вы об этом совсем забыли.
at -> with
Huge issue here: pending and undefined should be yellow; skipped should be cyan. ;)
这里还有个小建议，参数校验是否用base里的check-arg？我们自己先用上。
哥们，用locking是不够的，这里的问题没有改变。需要在locking里做double check，也就是再取一次：
(locking (:register-lock eventbus)
    (when-not (@handlers event-name)
       (swap! handlers assoc-in [event-name] [])))
I would call this parameter `shake` since we don't know if it's a shake ID yet.
Powinno być: "Odpowiedź (...) jest niepoprawna". Literówka na końcu.
to be honest I am not a huge fan of this trick to equalize number of epochs.
to do so I would do:

```
epochs1.drop_bad_epochs()
epochs2.drop_bad_epochs()
epochs1 = epochs1[:min(epochs1.events.shape[0], epochs2.events.shape[0])]
epochs2 = epochs1[:epochs1.events.shape[0]]
```

but i feel there must a principled statistical way of dealing with imbalanced number of epochs
can you still pass ecg?
please use `&&` rather than `and` :-)
Not too sure what to name this but to keep with convention, this was decided upon.
It's in the config like this in the standard distribution though so its in keeping with that
I think that it is related to the new thrift (srooge) compiler, it generates an interface that expect an Future[Unit] as return type.
Future.void is used for java compatibility
Only if you feel like it.
I changed this from an unsigned to a signed integer because the Python C functions (PyString_FromStringAndSize or PyBytes_FromStringAndSize) expect a Py_ssize_t length.
But autoScroll still makes sense for horizontal scrollbars right? E.g. with very wide HTML output?
Why is this on multiple lines and why is there a trailing comma?
Fixed all of these to foreach.
Look at using `pluralize` here as well as @efatsi suggested
I was expecting the method signature here to be: mult(2,2) instead of having 2 tests that the method accepts an array.
Can we add some API docs here?
not sure if this is correct and what it's for.. saw it being done in the tutorial so did the same
Automatic unit conversion would indeed be nice. I'll add a note to the document to mention that this would be nice, and it should just be part of the internal magic (like coordinate transformations).
No, I get it.

The return of memory_string_to_pages is an int type. If its "0" then it just stays a string. That's HORRIBLE python programming practices, you should be able to at least assert the type of a variable at any point.

Its pretty simple, all I want is
If target == "0":
  Target = 0
Else:
  Try:
    ...

Its really simple and I can't possibly understand how you could defend not fixing this.
Yeah i noticed an api call returning the wrong code back when i was testing. I ended up removing the method. I think the create is even returning the wrong thing. (201 instead of a 202 accepted) I'll take a look at these some more.
Short-term concession while we lacked the mgmt api in RDLI
haaa.....; still coming in :)
FieldクラスとPocketクラスが使用されていません。
上記クラスを使用したサンプルとすることが望ましいと思います。

また、上記クラスを使用する場合、setCardメソッドは不要になると思います。
also, I have a preference for "x.flat" or "x.flatten()", but that's only a personal preference.
:D 
It's ok for now
Add a quick in-line comment with an explanation as to what this magic number does.
I actually changed that since, I realized it makes more sense to just have the path / separated and replaceAll with File/separator

(defn get-resource
  "returns a URL for a resource relative to the public folder of the application
   expects path to be a / separated string relative to the public folder, eg:
   (get-resource \"css/screen.css\" )"
  [relative-path]
  (if relative-path
    (->> (.replaceAll relative-path "/" File/separator)
      (str "public" File/separator)
      (io/resource))))

(defn slurp-resource
  "Opens a reader on f and reads all its contents, returning a string. 
   Path is specified the same way as for get-resource"
  [path]
  (if-let [resource (get-resource path)] 
    (->> resource (io/input-stream) (slurp))))
OpenLayers.Util.vendorPrefix sounds like a good name to me, but then maybe the method names are a bit too expressive?
OpenLayers.Util.vendorPrefix.jsPrefix(..)

How about:
OpenLayers.Util.vendorPrefix.js(...) or OpenLayers.Util.vendorPrefix.jsProp(...) or OpenLayers.Util.vendorPrefix.getJs(...)? Any preference?
this string is not the same as it used to be, if you want to break it down: delimit parts of the string on each line and the use the concatenation operator
How .delegate will help avoid 2 functions (.on() / .off())? It will be undelegate(), delegate() this case.
jQuery team offers us use .on() / off() for event binding from 1.7+ version
You forgot to remove this too.
`forma.source.tilesets`, no need for the clj; or do `src/clj/forma/source/tilesets.clj`
noval is not correct here - the API semantics require the test to be _.isUndefined at the top level
please follow the conventions of the other rules - we may factor out this top level test itself (will require thought however)
no, the code is still under construction. We would add  at least cut_plane_algorithm()  and  CCCP()  function to make it complete. After that I would debug the code.  Thanks.
Wrong ;)
You are right. Should be cblas_dsdot
I've read up a bit on that and it seems to be common to have the parentheses on methods that have side effects, so it might be better to have def read() and below def close() again, as both do have side effects? We could leave the base.read and base.close, though they can't ever change as, as stated, they have side effects and it might be a good idea to show that.
Are you sure ``'getListeners'`` has the correct type as ``string`` is not a sub-type of ``object<PHPUnit_Framework_Constraint>|string``?
where do the values 320 and 480 come from ?
Instead of using while (true), how about scheduling this in a Timer + TimerTask? 
http://docs.oracle.com/javase/1.4.2/docs/api/java/util/Timer.html#scheduleAtFixedRate(java.util.TimerTask, java.util.Date, long)
s/t/y
Borra esta linea en blanco please!
Habit of mine I still do myself.
We do this globally in the file then yes?
Tämähän tekee nyt saman kuin `(filter pred a-seq)`.
Current master is good for me :) I do not know Pyton library so much.
That's very odd.
any tests we can borrow? :)
попробуй заменить ```before_validation :assign_tags``` на ```after_save :assign_tags``` в модели Post, как на railcast
Read the rest of comments first. ;-)
Anyway, use [deatch](http://api.jquery.com/detach/). And not append&remove.

So this could be really simplified. jQuery is great to work on sets of elements. So you should just find a selector, which selects all your panels and move them to the first column. So no need for for loops if you are working with jQuery. `.each` is mostly needed when you want to do something completely else, not connected with DOM manipulation.

Hint: [:gt](http://api.jquery.com/gt-selector/).
Do you mean DOM insertion? Can I use tags in a string?
Hm, I think I know where the problem comes. From JSON objects. If we serialize Python object we get underscored attributes names. Grrr.
This is distance of node from the rendered map's edge.
You can provide here link to our contact page. And also change "support system or web page" text accordingly.
Maybe add an open brace?  A whole try block under an un-braced if condition is slightly confusing.
This should probably be handled in __init__. Being at the module level, the choices will be populated once at import and not change if attributes are added/deleted until the Python process is cycled or restarted.
i thought we used to add names at the end of others ;) :P
Two things:

- avoid "we", per the style guide
- since these articles may be consumed out of sequence, "already covered" isn't necessarily accurate -- better to link to another resource where the concept you're referring to is covered
as discussed above, this would force the user to specify TextInputFormat.class even to enabled nested. We can fold this arg also into options string.
This was added recently and can be broken, I think. As far as I know not used outside.
Unless I'm missing something - this overly complicated.

   item.name = item.id 
and
   item.name = item['id']

Are the same statements in JavaScript - thus doing the testing for (settings.tokenValue == "id") is a no-op.
ok, so the same would apply to "linkedct" (clinicaltrials.gov)?

m.



On Sun, Sep 16, 2012 at 7:59 PM, Peter Ansell <notifications@github.com>wrote:

> In ns.php:
>
> > @@ -72,6 +72,7 @@ class CNamespace
> >  	'dip'       => array('name' => 'Database of Interacting Proteins','url'=>'http://dip.doe-mbi.ucla.edu/dip/Main.cgi'),
> >  	'ddbj'      => array('name' => 'DDBJ sequence database'),
> >  	'dpd'		=> array('name' => 'Health Canada Drug Product Database','url'=>'http://www.hc-sc.gc.ca/dhp-mps/prodpharma/databasdon/index-eng.php'),
> > +	'dbpedia'	=> array('name' => 'DBPedia', 'url'=>'http://dbpedia.org'),
>
> I don't quite understand what is meant by Jose's comment about staying
> true to the sources data. To the non-RDF world, Wikipedia is the
> authoritative source for the content that is current stored inside of
> DBpedia. We are unique in referencing "DBpedia" as the center of the known
> universe, as others refer to "Wikipedia" in the same way.
>
> Linking from dbpedia resources to wikipedia pages is good, whether using
> rdfs:seeAlso or another slightly more semantically meaningful predicate.
>
> However, I am essentially arguing that we change the preferred namespace
> for the dataset from "dbpedia" to "wikipedia", as Wikipedia is the original
> source of information, and the authoritative source of the identifiers. The
> reason I bring it up is that in future someone else may republish parts of
> Wikipedia in RDF forms that differ from the DBpedia method, possibly using
> different predicates and type structures. It would look a little strange to
> refer to their resources as dbpedia, even if they are only reusing
> Wikipedia identifiers, in their view, and their organisation has a
> different identity.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/micheldumontier/php-lib/pull/14/files#r1615488>.
>
>



-- 
Michel Dumontier
Associate Professor of Bioinformatics, Carleton University
Chair, W3C Semantic Web for Health Care and the Life Sciences Interest Group
http://dumontierlab.com
This is a bit useless - it's already there as "from" below...
It does not show on here, but need to change the `@link` in the license for `ServiceManagementSettings.php` from

    * @link      https://github.com/windowsazure\common\internal/azure-sdk-for-php

to 

    * @link      https://github.com/windowsazure/azure-sdk-for-php
I mean 'future'.
How come this is changed now? Does it now no longer match the "Host" line if it's the last one?
Looks like temporary code.
ist? :)
Definitely remove the exact match switch. Instead of just shamelessly copying and assume that the BASH completion did it properly, you should be asking if this stuff is really necessary because the way we use it is only when the branch is not available, not all the time. I am not convinced that making this style customisable is the right thing to do. The only other time I would use describe is to generate a version number and that's done in a build script.
Err, good question. Will fix.
Template comment!
Blizz used "Bônus" and "Penalidades"
Oh, I remembered the particular case where I thought safe would be helpful: OpticalPSF.  That does a fair amount of calculation when it constructs itself.  So if we can cache it and only do that once, that should help speed things up.  So maybe not so much premature optimization.  :)
> I like the Wiki idea. Would you like me to do the page?
> 

If you're up for it, that would be great.  Would you then change the reference guide to point to it as well as having a link in the dox here?  I assume that Mike will make his stuff on 243 point to it as well.

FWIW, I think it can be pretty short, so hopefully not too time consuming.
I went ahead and did this.  It wasn't much work to make the change really.  Actually, it was more work changing the test suite to match the current correct values.

If you think this needs more discussion and an issue of its own, we can easily revert it (it's the last two commits on this branch) and apply them on a different branch instead.  But I don't really see a downside, so I think it's probably fine to just leave it here.
strftime is already imported on line 10.
I wouldn't return `{error, notfound}` here. You can have a perfectly valid 2I query that returns 0 keys.
brooklyn.SSH category is correct -- see BrooklynLogging.SSH_IO
I'm not convinced that was the right thing to do. Do we sometimes use a logger named "log4j.logger.brooklyn.SSH" in our code?

Longer term, we need to decide whether loggers should always use the package+class name, or whether we're going to use "nicely named" loggers such as "brooklyn.SSH". Perhaps it's a code smell indication that our package names could be improved...
there are a few methods eg addIfNotNull ... user might be depending on MutableMap.  in theory.
in practice you're probably right -- but probably better fix by doing a MutableMap toLHM.

wdyt?
Using a File resource would be much more efficient here...

file { /etc/alternatives/ruby:
  ensure => link,
  target => /usr/bin/ruby1.8, 
}
I didn't notice this earlier, but there's two things to note here:

0. I like to put "expected values" or "constants" on the left side of the comparison operators.

0. Since you're expecting `0`, you could just do `not (time % 4)`. That's up to you, though.
You need to give the non-link non-form-element elements tabindex to make them focusable, then you won't have to do this manually (and tabbing will work).
I could support that alternative. Just remember that BillingLogic is the Open Source part of our project.
So we should think in broader terms.
While we don't have every 2 months or every 3 months would should support that.
このメソッドももう不要ですかねぃ？(使われてなさそう)
well, that is obviously what you are trying to fix... Kind of sucks it is the only way :(
I prefer to keep lines capped at 80 chars, hence the wrapped string.
Same here re: caching :)
I agree that a relative URL is wrong, but this is required because of the temporary way we're hosting all the apps on localhost and I think that directly calling the homescreen app's WindowManager object would be even worse. Eventually this should either be a hyperlink with an absolute URL to another origin which the window manager automatically opens as the Gallery app, or some new kind of intent for launching apps. Alternatively the camera and gallery could be different entry points to the same app as previously discussed.
We don't keep .project in repo. Remove this and recommit.
I'm not sure but maybe better to return MKNetworkOperation? Just to be in the same format as other network methods...
I just pushed an update to the OP repo that deletes these.  It also fixes a bug with the ECC.  The ECC was initialized in the packet handler, which was removed, so it was not being initialized.  I also turned the watchdog back on on the pipx/oplink.
Looking at Packages/Default/exec.py, a more robust way to do the error check would be:

    errs = self.output_view.find_all_results()
    if len(errs) == 0:
Can you tell us exactly what the rescue and re-raise is accomplishing?
Обращение к usersOnline без synchronized-блока.
Все методы называются handle. Слишком обще.
А сколько примерно посоветуете? Ну runtimeGetAvailiableProcessors * 10 пойдет?
Will this work on django 1.2-1.3 ?
We usually use `list-style-image` + `-moz-image-region`. Not sure which one is better…
Does this need to be a tuple?
The well known "Package not found". Maybe it has changed, but we tried to debug this error with @Seldaek last week, and no way to fix it.
Can we layout these fields differently? (see blog model for example)
I thought that the pattern might be useful, but I'm not tied to it. I guess wanted see if the pattern was practical and could be used as a generally with our other APIs.. I do agree, though, that there's not much benefit for the extra complexity. Yep, let's chat about it IRL tomorrow.
I'm worried this isn't always the right thing. `highlight_content` sometimes calls `show_plain_file` which returns unescaped file content :(
I take it that CodeRay does escaping for us?

```
      tokens = CodeRay.scan_file(tempfile.path, :ruby)
      highlighted_file = CodeRay.encode_tokens(tokens, :span)
```
Could you please mark ``__init__`` as an abstract method using abc? That prevents people from instantiating the class and tells the common tests not to try to instantiate it.
The idea was to always convert to float64 "silently" (which is kind of the default numpy type), **except** when the data is already a float32 array, in which case it remains float32.
I think we default-convert to float64 in most estimators.
This test includes asserts for a float32 and a non-float32 case. I can also check that int is converted to float64,

I'll add tests for zeros and the sanity check on distances.
> Can also be written more directly:

>     if any(sp.issparse(X) for X in Xs):

Done so in 0f0f794
decimal=2 only?
Your code is making several passes over the dataset. It would be more efficient to factor the additions / subtractions and the multiplications / divisions into one step.
I'd rather use "scikit-learn" (lowercase) to be consistent with the rest of the project.
I guess it should be ``mode`` was renamed ...
Hehe, just random luck I happened to look!
do not use a loop here, very innefficient
How about:
```
On BlackBerry, 'Cancel' and 'OK' buttons will be automatically created if none are explicitly defined. Providing buttonNames will omit these buttons and use those provided instead.
```
`user-scalable=yes` is the default, so it’s not needed here.
Same here: if developer needs debugger - he knows what to do.
Can this be discovered?
MSVC doesn't like variable array definitions like this.. (i.e. compile error)
Should use:
 subFiles = new int[n]

Or :
OwnedMalloc<unsigned> subFiles(n, true);
I know there's no default argument now, just worried if that change and this does not get changed at the same time...
I have to check both existence and value, since using item() on a non-existing item asserts and isItem() returns true if ((sn-1) < used), which could return the wrong value in the case files came out-of-order.
ensure still needs to be virtual and different in derived case, due to the locking..
The enum is used to create a set of flags, and I don't usually return (or pass) the values using the enum when it is legal to return a combination of the values.
There would have been no harm in making 64bit now, as it is it's restricted to significanly less than 32bit, because of overflow that will occur in the nodeid * numRows code.

I think you should make all 64bit now, that's what I had meant by making it consistent type - BUT - that's when I thought numRows() already returned 64bit (hence prev. comment "Gavin probably made numRows() 64bit..")
I've seen this in examples around the web...

    #define BUFF_SIZE ((sizeof(struct inotify_event)+FILENAME_MAX)*1024)
You can use deconstructing here
`track{username: user_name, avatar_url: user_avatar_url} = track.user`
Maybe use `%w{}`
maybe change `ignored_plugin_name` to `section_name`, since that's all it is anymore?
@peterbe hmm good point, I really don't like having to do this. It's because Socorro and Bugzilla disagree on the product name - it's very mozilla-centric.
There was a change that I missed that had just dropped the "<1.4" requirement, but we actually specifically need 1.4 because I'm using the "with self.settings" testing feature in my new tests.
Homebrew can be at other places than `/usr/local`. I am not sure if this is really needed. You know probably better.
Hi Tim,

On Thu, Mar 8, 2012 at 5:21 PM, Tim Dettrick <
reply@reply.github.com
> wrote:

> > @@ -19,7 +19,6 @@ eggs =
> >      django-celery
> >      django-kombu
> >      iso8601
> > -    pytz # Timezone library
>
> Um, we need that! The [timezone-aware date handling](
> https://github.com/mytardis/mytardis/blob/master/tardis/tardis_portal/util.py)
> won't work without it.
>

Exactly. Given that we need it (and not that it would just be nice to have
it) I moved it to setup.py for the tardis project. We got panned at the AS
and UoM because we use separate buildout.cfg files for the synch which
didn't add  pytz. If it's an actual dependency of the project and lives on
pypi, I lean towards adding it to the setup.py for the project. Buildout
still gets you the package just the same and this way people who don't use
a standard buildout don't need to think about it. Thoughts?

We just singled out pytz here because it came up in an error. Ideally, we'd
like to do the same for any other dependencies in buildout, but that's a
task for another day.


> It would be super-bad for the new OAI-PMH app. So bad that I'm wondering
> how you managed to get the tests to pass...
>

Goddamn magic. Also, as I said above, setup.py.


>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mytardis/mytardis/pull/64/files#r532781
>
Seems like a complex way to write `Pathname.new(dir).children.select {|x| x =~ /\.rb$/ }` or so.  Season to taste, check the documentation for the options that might help make that more efficient.
What about having an empty constructor for all the cocos2d classes, and put all the initialization code on init.
eg:
```js
    /* void constructor */
    ctor:function () {
        this._super();
    },

    /**
     * Initialize
     * @return {Boolean}
     */
    init:function () {
        if( this._super() ) {
               this._ignoreAnchorPointForPosition = true;
               this.setAnchorPoint(cc.p(0.5, 0.5));
               this.setContentSize(cc.Director.getInstance().getWinSize());
               this.setContentSize(cc.Director.getInstance().getWinSize());
               return true;
       }
       return false;
    }
```
It should be forbidden to call:
```js
var scene = new cc.Scene(); // <--This won't work on JSB
```

And we should redefine create as:

```js
cc.Scene.create = function () {
    var scene = cc.Scene();   // It is OK to call "new" here, since this is "hidden" from the users
    scene.init();
    return scene;
};
```

What do you think about it ?
Could we parameterize the number of seconds?
@christianv Done
As discussed with @raydavis, I'll add addressable to the GemFile and I'll look whether we can remove this require statement.
I agree. originally i had it so i could get rid of the default margin/padding in body, but I found another way to do it.
do .query's stack as ORs?
`(not (empty? ...))` voisi olla parempi testi.
@stof thanks for the feedback, lets use RuntimeException then. it is correct to not require curl in the composer.json as this service is optional and users can use the bundle without.
Consider using ```defaultdict(list)```
Where is this initial `@mailer` coming from for the `.nil?` check? :question:
It isn't clear to me why this is better. It seems hacky, and it will fail if we ever implement a code-parsing dependency generator. But I implemented this in commit 394f7fd.
if you use include instead of declaring the class as a resource it will work.
thelightcosine, that's debatable, and that is one debate none of us will win no matter which side you're on.  In the end, that's all personal preference.
Again, I think a comment more "rdoc compliant" to comment function would be more suitable. The use of down case and just one # would be sufficient, something like:

<pre>
# Method to force SQL Server to authenticate
</pre>
That is my own syntax for comments which are meant for multiple code lines. Removed that.
Yeah, this is silly. There's no reason to have the conditionals here.
We've recently updated Dylan to use the C3 algorithm for superclass linearization, which leads to monotonic method orderings.
s/Affer/Affero/ (and the one below)
ok, that's fine.
There's a ton of places in this file where `that.scene` can be accessed and cached once at the beginning of the function rather than accessing it over and over again.