labofsahil/github-event-dataset-2012 huggingface dataset:
Shouldn't we be comparing error codes rather than the message?
technically, this is supported on iOS
This bracket should be on the same line as the "else"
Hmm,  not sure why I made this white, when it's obviously black. 
Thanks for spotting this - fixed in next update.
not sure why that happen, it should of been a rename on the file, not an addition. will fix
You should be able to use var here instead of the explicit types (here and below).
I had to! It was too cute.
You can use:

    self.create_session = create_session or sessionmaker()
Ok, more encoding evilness. Then your line makes sense.

The production machine uses python2.7.
I agree. I've been doing that for list commands. I can't think of a previously implemented command that could be rewritten to use this though. Let me know if you have any in mind.
This will also match 4x2 and will give wrong results for versions like 3.21 or 13.2 (will both result in 3.2)

Please use a better regex that uses "\." instead of "." to ensure the dot matches only dots and that version numbers with more than one digit match.

grep -o '[0-9]\{1,\}\.[0-9]\{1,\}'

will work, but it will still fail for version numbers with two dots like 1.2.3

In other words: I'm not sure if grep is the correct tool ;-)  - at least you should tune the regex to also work for 1.2.3 style version numbers. I'll leave that as an exercise for you ;-)

Oh, and you should check if $version contains a sane value (checking for non-empty should be enough) and, if needed, abort the script. In this case, you can simply use the grep exitcode:

version=$(grep ...) || { echo "grepping for version failed"; exit 1; }
This will result in `cb` being called twice, right?
Are these functions needed? - they're not used anywhere
Also these shouldn't be in test_ python file.
I think we cannot be sure that the user is allowed to change his password via DokuWiki, can we?
In my changes I've used `$D` pretty much everywhere.
I wouldn't *garantee* there wouldn't be any bugs, but there shouldn't anyways. In any case, we'd at least be able to run some real unittests.
I think this is supposed to be _y? and on line 114 _z
The quickstart is in the wrong branch then. It's in master-eap6. It needs to be moved to master-wfk.
If I'm right, that *definitely* warrants a  comment :)
yes.   will do
Are you sure about removal of this controller ? Events were added for groups, but there is no code for firing them here.
Should be `Router.initialize()`
I assume this works because it is specially treated by ``json_encode``?
I have replaced the third parameter in "jms_serializer.serializer" definition (jms_serializer.object_constructor => jms_serializer.doctrine_object_constructor). So I have to rewrite all arguments of service.
Nope, added it  because I copied the ObjectWithVirtualProperties. There are some unused "use" calls, I'll remove it now.
So schreibst du ein File auf die Festplatte vom Server.
Das solle für s'erste reichen.

Das kannst dann später von Hand runter laden.... 
machen wir dann später...
Comma has been removed :) Thanks.
@croby @nicolaasmatthijs isn't this just lazy evaluation? http://en.wikipedia.org/wiki/Lazy_evaluation
This should be using the sakai.api.Content.getMimeTypeData function
I **will not** finally fix current `destroy` implementation (like I did with `emplace`) as I hate it. You can accept or reject these fixes, I will not add more fixes here.
date filter settings. (enabling + year dropdown range)
>java.lang.String.class

overdid... ;-)
Actually i see a few things, let me make another push
sup with dat yo?
test receipt data will be enough.

I can add this test though to test if both urls(sandbox and production) are reachable.
Don't use the `.eql?` method is my recommendation.
Add a @module <module name> tag. I know I haven't always been good about that myself, but I'm trying to make sure I always add it now.
Oh, it looks like you still need to pull the changes from my repo, as you don't have some of the changes I made.
this `<p>` is not closed.
Can you just omit these and add checks in the partial, so you don't have to pass in empty each time?
It was moved to the default.yml file
remove client call from here. have presenter do delete, and have view delete the view element.
Yes, other than in the last test where theme has no theme provided they are similar. I'll refactor that.
I keep getting confused with collect vs map vs match, tbh. In this case map might be enough to simplify the code.
Redundant since the call was missing. I'll replace this test when I do the above one.
Why is this multipart?
Why `partial=True`?
If you pass the filename through to here like that, it exposes this part of the code to a lot of information about the outside world. For the sake of encapsulation and separations of concerns, i'd suggest to only pass the bare data, i.e. e.g. message_dict.
Yes it is. I used it just to differentiate as it is a passed parameter in horizons/gui/keylistner/maplistner.py
Please clean up all commeted code.
I was to only comment it out... I think adding an extra column next to every existing column is confusing. Users may want to add a blank column in a specific place but not everywhere. Is it possible to make the tabular view more spreadsheet-like, i.e. insert a column in a specific place, copy the content of a column (not just a cell) etc.?
> UTF-8 is used by 73.4% of all the websites whose character encoding we know

windows-1251 http://w3techs.com/technologies/details/en-windows1251/all/all
UTF-8 http://w3techs.com/technologies/details/en-utf8/all/all
khodet benevis yad begireeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee !
This block? The time selector you mean? It has been provided from UX people, so we've implemented it!
I've solved the indentation issue, what a good eye :D
https://github.com/telefonicaid/Gaia-UI-Building-Blocks/commit/d14fe152df719b0802018ebcf18c919314b8b1eb
Also the use of "role=banner" is not the correct one in this case, maybe the name is the same as in w3c, but it does not have the same behaviour:

http://www.w3.org/TR/wai-aria/roles#banner
It is better to use SNAPSHOT version for now - we are going to make some changes her. Plus it is better to use the same version for eclipse and maven plugins and to manage them in one place to ease releases.
Why it's `i` shouldn't it be `j` instead
Nevermind, it's mentioned in the docs.
Missing period.  And probably "applications server" =>  "application server" or "server hosting the application."
This seems unnecessary, and the null return makes `checkAndUpload` deceptive. Can we not inline this in `checkAndUpload` and pass through the throws, or catch and abort there?
Please do not use "till" as it is not formal english.
Rather use something like "getExpirationDate"
maybe put a TODO comment in the javadoc here to remove @Ignore whenever the core ticket is done ...
I'm not sure a sitemap is allowed/usefull when not at root
Shouldn't be it's own step
Had to do this to get the framework loading. In the old way the modules were loaded but not defined, allowing us to define JNEXT before we started the framework. In the new way there is no load method, so this needed to be done. It might make a good opportunity to switch to the newest jnext.js and not make changes.
Grep for '0.2.17' in the repository, there are more occasions.
not sure what you mean with extra return?
Does this not need a matching change in `rtl.css.scss`?
Ok, will change
this replaces all your getters/setters below!
Yeah, we'll use yours. You can ignore the version changes in these patches.
Unless there's another reason I'm unaware of, I'm going to exclude any metadata changes made to anything outside of the new custom settings that's been added, I don't think we need to tweak any of the object types, etc., but let me know if you feel otherwise.