labofsahil/github-event-dataset-2012 huggingface dataset:
OK. Mozes tie pouzitia code nejako vhodne okomentovat (napisat, ze su z XML, a ze ktore co znamena)?
M is only the codename for this new Microsoft programming language.  It will probably change when / if this gets released.
10 is putting an upper limit, when the user specified infinite wait. This is to avoid possible bugs where output never indicates itself as being done. Looking at it, the logic is actually slightly wrong, which I will fix now.
A bit late, but for future reference, `py3compat.cast_bytes_py2` exists for this kind of situation.
That has been fixed in the pull request.
Can you add a short comment? I had to read the function three times before I understood what this does.
I'll fix those up. :)
It violates the chef_wm behavior if you don't (also, it does actually go boom).  Same with auth_info.
Because tweetbot posts everything as "image.jpg" or "movie.m4v".*  So not a requirement..but a requirement if you wanted more than one image ;)

* http://tapbots.net/tweetbot/custom_media/
Please use American English, i.e. "color" instead of "colour".
Initialization is done when the plugin receives a plugin channel message containing the protocol version in CUIChannelListener.java. It only gets called if CUI hasn't been initialized, which for a session, it has been.
Filed @ #76
oops, will be fixed
well, if another param was used, it means that you were already changing the behavior.
I think @stofbot is right. This component does depends on `symfony/config`...
@Tobion instead of injecting the UrlGenerator (as suggested previously) to get the RequestContext from it, simply inject the RequestContext itself (in the constructor like other deps)
Indeed. I dont think it's out of the scope of the current POC. I'll try to implement that without any BC break soon.
Another example I saw: `text/html; level=1`.
Doing that in the merge extension pass seems good to me.

What you describe about the rare case does not seem like something we want to support.
typo at the end ? `-n`
IMO no need for `isset`
small nit-pick but `val == round(n * 100)` and `if val == 100` :D whitespace
There was a corner case involving multiple commas in a sequence.  I went with:
```bash
sed -re 's/(^|[^\])((\\\\)*),,*/\1\2\n/g' -e 's/\\,/,/g' -e 's/\\\\/\\/g'
```
rename this to post
bat文件是后来加进来的，这个待以后再更正吧。
Sounds right. I will move the text output code in the caller in oiiotool.cpp.

We can figure out later how exactly to output as text.
Yes, you're certainly right about that.
This isn't valid! What was the intent?
I'll remove this in future commits - not nice to have full paths (even if commented) in the repos.
data['nodes_extended'] only has nodes with "roles_filter" and with "guest" virt value, so there is no need to refilter by that.
Inline doc is important I believe. Why would you not see this as so important ?
The datum fields all have masks and values, having the mask lets us show the user something that is not in the database. The user can edit the mask, then Backbone's save makes sure that the value does not get edited if the the value is encryted and the user cannot see it. What this means for our map-reduce functions in Couch is that the mask is now the primary place to search and retrive data if it is a DatumField.

User -> Mask -> Backbone -> Value
Why does the wrapper element need a defined height at all?
It shouldn't be an error to not have an __init__ method. For example, if we made a ConjugateGradient SearchDirection I don't think it would have any settings that need to be configured in __init__.
We could also keep the flat namespace, but move code to submodules and use wildcard imports to move them back into the `spotify.capi` namespace.
nit: please leave an empty line at the end of each file.
We are missing `li` elements as containers
Since you're already passing the Application object why do you need to add all the other parameters? Just extract them from the object itself :)
mfriends --> friendsMessage
nfriends --> numFriends

is that ok?
Please add a comment above `onCall()` if it's also a workaround.
but why do you need the !important? It doesn't seems like there is a loft of styles applied to SPAN (see http://mxr.mozilla.org/mozilla-central/source/layout/style/html.css)  It seems like the rule is not in the order you expect. Let's try to remove the !important in order to fix the real problems :)
You use that just to retrieve the icon, the previous way was good enough or if you really want to proceed this way give it a clearer name and move this code closer to where it is used.
`cacheData`?
Answer (this is faster): you should do (2), and this function can stay here for now

that is, 

      return {
        id:
        label:
        ...
      };

would be enough for this function
'forwad' should be 'forward'
comment drifts off; although juts appending "a ..." could work :)
And after speaking with Ayman, we need to correct this. Behaviour is as follows:
- If we choose to DeleteAll, and we accept on confirmation, that is the same as Done button, so we have to delete them all and exit the thread.
- If we choose to Delete Selected, we hide them from the view, but we need to press Done button to really delete them from DB

* This behaviour will be implemented on next commit.
Hmm, on second thought, I’m not sure the `tablist` role can be applied to the `filters.css` block anyway: a `role=tablist` element requires a `role=tab` child, which probably makes no sense with filters.
Is is on purpose?
Addressed in  	f34f023.
Thanks for the reminding.
What's the rationale for creating a new z-index-level or reusing one?

@alivedise any best practice we should follow?
This code is only executed if there is no 'mozTelephony', so it's only focused in Desktop (Browser) testing. Now It's only for rendering some logs in calllog in order to check markup & css.
nit: `while (entries.hasMoreElements()) {` (space)
Why not allow async on GET or DELETE?
According to [Section 6.3.1](http://tools.ietf.org/html/rfc3501#section-6.3.1) of RFC 3501 for the SELECT command:

> If the client is permitted to modify the mailbox, the server SHOULD prefix the text of the tagged OK response with the "[READ-WRITE]" response code.

The example goes on to show:
` S: A142 OK [READ-WRITE] SELECT completed`

Additionally, [Section 6.3.2](http://tools.ietf.org/html/rfc3501#section-6.3.2) is more specific, using the MUST keyword:

> The text of the tagged OK response to the EXAMINE command MUST begin with the "[READ-ONLY]" response code.

Do you think that is enough to assume this should be safe?

Cheers
No it reads the `updated_at` value from the `participant`. If for some reason the participant already has a `timestamp` value in it's set of `labels` then we do nothing and leave it as is.
Should be 1 or 3 periods. Two is weird :)
This file has been removed

On 2012-10-24 18:31, Daniel Pittman wrote:
>
> In spec/persist/rz_persist_postgres_controller_spec.rb:
>
> > +require "project_razor"
> > +require "rspec"
> > +require "rz_rspec_matchers"
> > +require "uuid"
> > +
> > +# true == will remove all records from collection when done
> > +# false == will leave them for debugging
> > +CLEANUP = true
> > +
> > +RSpec.configure do |config|
> > +  config.include(RZRSpecMatchers)
> > +end
> > +
> > +describe ProjectRazor::Persist::Controller do
> > +  before(:all) do
> > +    @config = ProjectRazor::Config::Server.new
>
> You should prefer rspec |let| blocks 
> <https://www.relishapp.com/rspec/rspec-core/v/2-11/docs/helper-methods/let-and-let> 
> to member variables in tests.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930560>.
>
Whoops.  Patch on the way.
Because I'd like to use the require function in the jsenv context, I added it.
What do you think?
Just a random question.  Have you thought about showing asynchronous sequencing with Future + for-expressions?   Would make an awesome example.  If you don't have time, I'll try to pull something from a presentation I'm about to give on it.
@dkubb `nodes.fetch(name, &block)` so I could write:

``` ruby
node = relations.fetch_node(name) {
  node = relations.build_node(name, relation)
  relations.add_node(node)
  node
}
```
~~~
その制御のためにセーフガードを作れることを考慮しましょう
~~~

~~~
その制御のためのセーフガードを作れることを頭に入れておきましょう。
~~~
This if/else tree was about to get unruly. thanks for pulling this into a factory
Don't return a void protobuf if we're never expecting to get an unknown type - throw an Exception so that we can learn what the unknown types are and start adding cases for them.
This line looks like it should be indented so it belongs to the if-block above. Won't you only want to add the talk if there were no pre-existing talks?
What are these `Dropdown` sections referring to, the windows that pop up when the _Setup_ buttons are clicked? If so, you may want to rename these comments to `<section> Setup`, e.g. `Audio Input Setup`. Because some of those windows contain other options than only dropdowns.
I don't see any other vars named 'normalNode' in the code...  Do you mean in general that using naming to distinguish between vars that hold nodes vs. node indices goes against CodeMirror style?  Or just that the particular suffix "I" isn't a good one?
I guess we have to do some work to understand how our subfields overlap when it comes to photometry!  When you're doing photometry, where does the error on the fluxes of each pixel come from?

As I wrote it, this is meant to mirror how Source Extractor works. I don't know if you use it for what you do, but SExtractor first calculates the background and background variance of an image (in which an attempt is made to crop sources statistically). It then subtracts the background and uses the variance to set thresholds for finding objects. Then when calculating the uncertainty in a flux measurement, it uses the equation on line 382. This is equivalent to NOT subtracting a background and just setting the flux error equal to the poisson error on the flux in the aperture. If one does not background-subtract before running `aperture_photometry()`, one would set `bkgerr=0`.

The idea with having `bkgerr` as an input is that we're sort of assuming that the image is background-subtracted already. In which case we need to tell the function what the variance in that background was. And its likely that it would have been calculated as an input to the (yet-to-be-written) object-finding function.
Coding style, from PEP8, there is no white-space around equality sign '=' in function's arguments list.
Should we consider turning off tty output of error_logger for the life of the script?
I had the doc here backwards. To prove the doc correction is correct, see these two unit tests, which show that "?:" means "present/not-present" and "?#:" means "truish/falsish".

    def testTempValueColonTernaryTrue(self):
        return self.doTestSimpleWithProperties('%(prop_temp:?:present:missing)s', 'present',
                prop_temp=lambda b: True)

    def testTempValueColonTernaryHashTrue(self):
        return self.doTestSimpleWithProperties('%(prop_temp:#?|truish|falsish)s', 'truish',
                prop_temp=lambda b: 1)
ah no, it is an old one outside the diff...
My bad, sorry guys :)
Do you mean "on the first line" or "anywhere, at the beginning of the line"?
Couldn't use $g as doesn't support the [1] at the end to select specific item in array. could pass that into $g again but then would go through qwery for second time, therefore slower than this solution.
Please use FLOWLOCK_RDLOCK(f) / FLOWLOCK_WRLOCK(f) macro's.
It is not clear how "button" or "link" map to "horizontal" or "vertical".

Recommend changing the "displayAs" options to accept "horizontal" or "vertical" instead.
use `expectedHTML[0]` here
Also you pay a cost of `state` object here just in order to be able to curry without closure.
I think its better you make this into external js file and import it. Put this file before the </body>.  It allows the page to load faster.
what does doctrine/common do here?
Here you need the "ruby file case" name of the file; are you sure that `name.to_s.downcase` is always correct?
This is more reliably written as 
Puppet[:libdir] = my_fixture_dir

Our spec setup will automatically reset settings after each test.
You need to remove the references to this.
Why +10?
When `pgroup` is `nil` or `false` process group will not create.
Should this `id` be an array like the others?
wahhhhhhh :whale:
I see second time this condition ( or similar ). I think it will be better to moved it to own method that can be called. I am not domain expert, so my name guess is just guess.

```
boolean isOldBusInterace( string interface )
{
   return issubstring(interface, "-bus-");
}

boolean isOldIDInterface (string interface )
{
  return issubstring(interface, "-bus-");
}

global map< string, string> getUdevFromIfaceName( string interface)
{
   if(  !isOldIDIntercface ( interface ) || isOldIDInterface )
   ...
```

What makes me curious is if this statement is related each other and why condition is different from one at the top?
If it is not related, then I recommend to move it to own ifs, otherwise it looks like it is related
Instead of use braces end the statement with a `;`
Why are you changing this? We use "bool" typically throughout the framework...
There is a extra line here
Shall I fix something here?
You should break those lines, as you are using $textDomaine[$message[$messageKey]] several times here, please cache it somewhere so that the lines are shorter.
I'm talking about the different behavior introduced by this lines in xmlFileNameToRst()

```
if ('.xml' === strtolower(substr($name, -4))) {
            $name = substr($name, 0, strlen($name) - 4);
}
```
When you called that function only with filename the result will be 'foo.rst' but when is used from the xi:include then the argument has the extension too, so the result is `foo.bar.rst` when `bar != xml`
this should be boolean|int
I really don't understand all this cleanup things...
1. We definitely prefer thin over mongrel as it works quicker and is kinda more modern one
2. The "old" debugging stuff (lines 21-32) works for all of us. Your setup maybe too, but are u sure?
If you really want to cleanup Gemfile, please do it as separate commit, at least we'll be able to revert it.
reset this code to the code in MC-DEV
Ah, I will ask for separate emails.
IMO this should be implemented on `Developer` and `Organization` entities, not here, with checks for equality of class types.
Given that EntitiesContext is per-request-scope, won't _packageRegistrationRepo.CommitChanges() and _packageRepo.CommitChanges() be calling SaveChanges on the same EntityContext object already? If we can verify that info, do we still need a TransactionScope?
@jacob314
-> `return this.$.isDone ? "done" : "";
**21.3 How Automake can help in silencing make**
To enable the use of silent-rules in his package, a developer needs to do *either* of the following:

    Add the silent-rules option as argument to AM_INIT_AUTOMAKE.
    Call the AM_SILENT_RULES macro from within the configure.ac file.
ok, as our discussion on IRC i'll drop ETag handling for now and leave it up to Varnish
Oh, it is always a good question how to right such things all projects have different styles :) Will fix.
yeah .. i knew i forgot to come back to this.
I imagine this would work thanks to the fact that Erlang's dict is implemented as a tagged tuple meaning that it looks like a record to Elixir? If we can rely on this, then I'll get rid of the redundant Dict.Record.

But for Orddict the implementation should still be defined as `for: List`, right?
Add a todo here about making sure to use a api that is cached.
This is a mock here. Thus the directory doesn't matter.
Main Menu module = 1, what are the others?
We automagically prepend python- to all provides and requires in the RPM, so these prefixes should not be present here. I will merge and change it myself so we can check if it actually works :-p
Shouldn't it check here for token expiration before returning it?
Version is now 7.1.1-SNAPSHOT :-D
This is inefficient, you are creating a temporary object just for this line and then indexing it at 0,1,2 in the next. Let's just put these values in the next line.
Oops, yeah those should be fixed as well.
hm, readability. I like it :-p
Please add double quotes `"` in href `href="{{ persona }}"`
No, remove them from the puppet manifest. Not from the docs. We discussed this on IRC already.
Might as well remove this argument then if it's not being used.
change this to an `ok()`, as you're always setting `loaded` above
Did you have times where Youtube loaded fast enough to actually hit this condition? oO
Alas, it's a security issue to tack ".html_safe" onto a ts message -- that's because eventually we're hoping to make these accessible to our translator volunteers, so the ts has to be treated as theoretically contain user-entered data. 

The best way to get around this is sadly pretty ugly. 

1) surround the link with ts's -- so for instance: 

ts("Your ") + view_context.link_to(ts("history"), user_readings_path(current_user)) + ts(" was updated. ...") 

Unfortunately, THAT will then not be html_safe & the link won't display, so then: 

2) Manually escape the ts() content with the h() function from the view:
view_context.h(ts"Your ")) +  view_context.link_to(view_context.h(ts("history")), user_readings_path(current_user)) + view_context.h(ts(" was updated. ..."))

3) Then HTML-safe the whole shebang together. 
(view_context.h(ts"Your ")) +  view_context.link_to(view_context.h(ts("history")), user_readings_path(current_user)) + view_context.h(ts(" was updated. ..."))).html_safe

I know it is gross :( If you come up with a better solution that works that would be awesome. :P
You should make it infalible if you plan on keeping `is_ready` to `true`. This is strictly equivalent, the only difference is that here liq will keep calling `is_ready` b/c the source is fallible but `is_ready` will always return `true` so it will always be ok.. So the source is infallible :-)
その方がいい気がするなー．
Pretty sure thats not the javadoc style we use.
you can simply to host.subnet
Yeah, that was the case. Good to know. It works fine.
Simplify this by just doing:

if app:

If app is None, then the if block won't be executed.
This may change to a composite
nit: I prefer `<= 10` to `< 11` in this case.
Strange thing with this. Previously I added those slashes for autoload to be working. I had error with the missing ending `r` without them. Now I updated composer itself and vendors and it seems to be good.
in the successful case, we have the list of output nodes which were created. In the case of an unexpected exception, how can we get that (the exception can occur at any point during the sequencing code and can have any number of causes) ?
var result = [];
     var lists=$("input.select");
     $.each($("ul.file-list a.file-title"), function(i, n) {
     n = $(n);
     lists[i].checked && result.push({url: n.attr("href"), title: n.text()});
You don't need to add this; the file already contains this import just a few lines above (lines 39 to 42).
Can you test there is `foo` in the resource?
отступы надо везде поправить. невозможно читать
Linting:
[L669:C9] 'row' is not defined.
        row = cachedRows[i];
All the __init__.py file in the project contain this line 
I added for continuity
This file belongs in the same location as the `log4php.dist.xml` file
Indeed. I converted it just for thoroughness.
Should the benchmark be in the test tree as well?  (Again, just a general question--not for this pull req.)
This URL should probably be a POST to /api/config/:tenantId with oae-authentication/twitter-authentication/twitter-authentication-enabled=false
it takes `comments` as well.
I see. But why not mapping both ``null`` and ``NoSymbol`` to ``<undefined>``. Basically, why not having the following:

```scala
l.map { x => 
  if (x.symbol == null || x.symbol.exists) "undefined" 
  else x.symbol.fullName
}.mkString("( ", ", ", " )")
```

The intention is that if an empty symbol exist, it doesn't screw up too much the argument list.

Hopefully this makes sense, it's hard to comment on a one-liner :-)
Especially since those machines are actual physical ones. @dmathieu maybe submit a pull request with corrections?
add

    'sess_time_to_update'
То же самое. При наличии _DNAamount память выделяется под 100 объектов.
Тоже было в лекции, просто напомню: у некоторых классов есть специальные методы, названные так же, как и класс, в которых уже заложена конструкция alloc&init. Например, следующие строчки идентичны:

`NSString *dpo = [[NSString alloc] init];
NSString *dpo = [NSString string];`

В случае с NSNumber, можно поступить так же:

`[indexes_array addObject:[NSNumber numberWithInt:i];`

Пишется и читается быстрее.
Ага, только япогорячился, сказав, что можно только в Cell.m указать. Если указать только в Cell.h, то она будет доступна и для категорий, и везде, где подключается класс. Однако, если объявитьпеременную только в Cell.m - она должна быть видна только в имплементации класса.
<% unless @filter_words.nil? %>
What is this crap?
`any` and `all` + variations could be on stream but it's cool if you don't want to implement them yet.
24x6? Is this a thing you can do?
Maybe turn 4 * 60 * 60 into some constant, I have no idea what it's supposed to mean.
为什么会挂了呢？只是这个事件的处理挂了，后续再次进入的话，应该还会继续处理。
What's the use of this assert?
What part of this file requires UTF-8?
what is the purpose of those two lines?
should comment /*for language change*/
hmm, you edited the PR after I loaded the page but before I commented, so the comments are in the wrong place. This one should be on the line 235
This should be:

    {% include 'AcmeTaskBundle:Task:prototypeTask.html.twig'
        with {'form': form.task.vars.form}
    %}
you should not use ``I`` in the doc
推荐使用这个库可用的最新版本；在写这个文档时它的最新版本是2.0.35。
needs a kwargs
So there is no constructor for Java API usage that allows the Map? (I'm assuming Java would use j.u.Map)
yeah, but its a driveway coupling(http://www.theregister.co.uk/2008/04/18/emergent_design_part_three/print.html). ConsumerRegistry doesn't need to know that Activation actually provides it. It wants a system by itself.
I will do a PR in a while
Should be inside the `try` block. Close quietly and check for `null` in finally.
Refactor lines 78 and 79 into a common private method to be used by both methods. (this and the one below)
`===` should always be used. Why? Glad you asked: http://stackoverflow.com/questions/359494/javascript-vs-does-it-matter-which-equal-operator-i-use.
Yes! Quite embarrassed about that. I just squashed all my commits and hope no one would see this ... too late :-)
Can you merge this with the work I did, please? I created a Paths. Moving mine into yours is fine.
I should mention that you can use process.on('uncaughtException' ... but its not ideal, and if you have code that trys to log to graylog on uncaughtException ~ another exception is raised, and so begins the loop
nvm, i see the lock in the calling function
So i guess even if it fails in the time_out we set it to deleted? why not just set it to deleted w/o a poll then :)
Took you a long time to write :D
why? I think it is unnecessary
If there is no file then it content hasn't hash

we also have ```serialize($inputs)```. it's depend from inputs filenames
Also, as a bit of sanity check, is it ever possible for x/ysteps to be zero?
There are a number of existing uses within the `matplotlib.delaunay` module that require the original untransformed triangle and edge arrays.  For example `griddata` calls the various delaunay interpolator functions.
Oh, wow... I don't know how I missed that. It's fixed.
I'm not sure if it is more expensive, but I find these two lines easier to read in the following form:

Old: 

```
diff = a % 2 == 0 
output = np.where(diff, a, 0)
```

New:

```
a[a % 2 != 0] = 0
```

Obviously they have different semantics, but given the output array is only in scope in this function, it seems reasonable to modify it inplace...
I don't see where it would be needed, reading the code.
`(Toggle)?`?
Ah, yes; that's a good point. If I go the CSS transition route, I also won't need to duplicate this large block of code for other elements that may need it. Will fix.
the point is not the external documentation; I assue you that at maxium
it's read as a starting point; independently the code NEEDS to be kept
readable

On Tue, Aug 7, 2012 at 5:34 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/ActiveMQ/ActiveMQProtocol.cs:
>
> > +        /// Format, which activeMQ uses to marshall/unmarshall messages
> > +        /// </summary>
> > +        public static OpenWireFormat format;
> > +#endregion
> > +        #region Constructors
> > +        public ActiveMQProtocol() {}
> > +        public ActiveMQProtocol(Object obj, int socketNumber)
> > +        {
> > +            this.SocketNumber = socketNumber;
> > +            this.Message = (Command)obj;
> > +            if (obj is WireFormatInfo)
> > +            {
> > +                format.RenegotiateWireFormat((WireFormatInfo)obj);
> > +            }
> > +        }
> > +        #endregion
>
> I have to write a complete chapter about this part in the .Net Bridge. I
> need some time for it. I will add it when I finished that part in the
> master theses document
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1322585>.
>
>
your point is noted.  this was a (very!) convenient limitation -- and it helps with a sort of in-line documentation.
I meant to delete this pail comment thing. Could you kill it?
@bp323: Explore.css should either be removed from category.html if it is unused, or the classes should be consolidated in a shared file.
@bp323 awesome!
I just read this discussion here: http://www.mail-archive.com/numpy-discussion@scipy.org/msg29403.html
please document these paramters - what is l? what itr?

is l perhaps 1/C ? if so I would prefer to keep C around and set some reasonable default for itr and some function to get/set itr?
Yes. Sure, top level categories that have subcategories end up being listed first on the report submission pages, but I don't see any harm done by this. Everything else works just as it should.
Removed the './' parts.
"great deal of"
Unfortunately, that is the meat of this commit. Behind the scenes, the test config works very similarly to what was being set before, but apparently something is being set that wasn't before. Is this referring to #44?
should it really be displayed as an error ? UNKNOWN means that the check service has not been able to perform the check, but it does not mean it is a failure.
Because if you know there is keyboard shortcuts and don't remember witch ones, you can easely display them without having to use the mouse. 

But, yes, there is nothing in the interface that indicates that keyboard shortcuts are available. 
A keyboard icon may do that but a didn't know were to put it without giving it too much much visibility. 
Maybe in a footer ?
We should probably have it still take Args as the type of the second argument. I'm envisioning peculiar situations where you end up assembling args in some generic context, and having them get shunted various places. If we insist on a specific type here, it becomes impossible.
Why this div?
Not really. You can check the flag from upsert and see if new entry was created. And if it was, you have already data available to push (`station` object).
`id` to `pk` please.
Ok, fresh head...

I was referring to the logic that was previously inlined:

`(!script.type || rscriptType.test( script.type ))`

...that is now in `handleScript`. With the inlined version, we're spared the call to `rscriptType.test( script.type )` if no `type` is set - because we can safely assume that this is an executable script. In the new version, you've moved all of the previously inlined logic into a function, which means that we lose the  benefit of potentially avoiding the function call. Now, whenever ` jQuery.nodeName( elem, "script" )` is true, the runtime will always have to enter a different function scope and create a new execution context. Additionally, the argument to this function is a DOM node, which contains circular references, making it impossible for modern method tracing and JIT compilers to optimize. You could argue that abstracting the code into a function is a better practice and I would readily agree with you, but there is also a balance of performance that needs to be struck.
Concatenate_block_size should be a required argument.
Could you rewrite this as `'with' is not allowed in strict mode.`.
Seems like Work in Progress on saving dye effects to armors? but commented out.
Agreed, I moved it to be part of the options hash. Tests are added accordingly.
True. May not Trade or Trash?
Should also check if it is `instanceof` and eventually return eagerly?
PACKAGER => PACKAGE
list(self.clients.values())
These are all APIs that are supported in 2011 version. There's other 2 APIs were added in 2012 which we are not targeting now.
The API call will fail, resulting in an error log message, but as I recall the program continues. I might be wrong.
I wouldn't imagine there being a difference between rgb() and hex. rgba() probably means slower painting, but we need it for consistency with other things.
I stole the style from cls.CSSTokenizer.types, but yes, no point in copying that. Fixing. Putting them in there one by one I find ugly though, repeating just to align is strange to me. This looks like generated code. We do it in other places too though, so if it's policy, I'll fix.
Is `NgxUrlAsyncFetcher::Init()` ever called?  It's not overriding a base class method and I don't see any calls to it here.
Ditto above (sorry to be so irritating, these nonetheless look fine in DOxygen itself)
Either way is fine with me.  It would clearly be a user error to try to draw something with no components added together (whatever that means), or to redefine the flux of such a thing.  We just want to make sure that a reasonable error message is emitted rather than a crash.  

I guess setting SBProfile = None would be sensible, and not much extra work, right?  

It looks like we would just want to add a line in the GSObject definition of _get_SBProfile that would check if SBProfile is still None even after calling _SBInitialize.  Then it should raise some kind of exception that the profile cannot be constructed with the values given.  

This would provide flexibility in the future to allow for constructors (of things other than Add) that don't have all required information yet if it would be more convenient to provide that information later in the code.
I guess I don't find it confusing for `config.image.noise.type = Gaussian` to mean something different from `config.psf.type = Gaussian`.  Context matters.  Obviously we can't have two classes be the same name in python, but it's not confusing to have the same word mean different things in the config files for two different `type`s.

I guess I view the various Deviate classes as tools to use in the code, rather than concepts that deserve a corresponding item in the config file.  For example, you say that PoissonDeviate doesn't have "much earthly use", but in fact you yourself used it when implementing the `CCDNoise.applyTo` function.  So it is useful.  It's just not what people mean when the say an image has "Poisson noise".  The meaning of `config.noise.type = Poisson` is to use each pixel value's signal as the mean in a PoissonDeviate.  In other words, CCDNoise with read_noise=0, as you say.  (It turns out also to be directly applicable after photon shooting, since then the Poisson noise of the object is already on the image, so you only need to add the sky noise, which is a constant, so you can use PoissonDeviate directly on the whole image.)

I don't mind changing some of my names for various concepts in the config structure.  However, I don't want to force the naming choices to conform to the limitations of our back-end implementation (e.g. Gaussian can't mean two different things).  We should choose whatever names will be clearest for the user.  Then if it is convenient to make our back-end stuff match, we can do that.
fine, just a variable name change
And same for the other transient *ByKey fields.
I see why you need lib/doc_code_merger.dart, but why do you need doc_code_merger_console.dart?
Right, but this also ensures that the EDProduct is always present if one chooses to write out everything. 
I will fuss with this a bit to see if I can find a better solution than just making a filter-less path with the complete chain.
It seemed more readable to have the tuplizer part factored from the skim paths...
The convention for ids is to use '-' as a separator
On 09/03/2012 10:39, Vivien wrote:
> On 09/03/2012 09:29, Ben Francis wrote:
>>> @@ -3,6 +3,9 @@
>>>
>>>   const kDefaultWait = 2000;
>>>
>>> +// Until we have a better mechanism, disable mozbrowser for testing
>>> +SpecialPowers.setBoolPref('dom.mozBrowserFramesEnabled', false);
>> Ouch. That's going to make writing tests for the browser app pretty 
>> much impossible. Why is this necessary?
> I wonder if I can use events to magically remote that. let me look.

That could work, not with events but by letting each tests specify when 
it should start testing.

I can change that but it would require some time. I think it's not a 
priority except if you plan to come with browser tests tonight?
Same for those 2 lines.

Also, I had changed the indentation and that didn't make it too.
Why not make this static? Commands don't change dynamically.
`get_user_by_id ` 和 `get_users_by_ids` 可以并发地同时获取。
These if(!husk) checks make the control flow much less readable than it could be. Instead, break the robolimb code out of the if(individual_limbs) block, and instead check for if(individual_limbs || husk), similar to how it already happens with damage masks(they work in the same way, I don't know why I put robolimbs in this block to begin with).
It is not writing alarms, it subscribes to global messages and displays them. 
Separating them is not impossible but I would have to pass references to the graphicitems.
So yes I can change the class name, any ideas?
Tu utilises des symboles. Préfère des string. 

Relis tout ici pour voir comment organiser un yaml :
http://guides.rubyonrails.org/i18n.html
Previously, the BCC was not automatically sent, but now it is.

Not sure if that is feasible, but would it be possible to send to an empty recipient (and just use BCC this way)?
Why do you remove the `http-equiv="content-type"` here?
Assume this wasn't used anywhere?
Да, это надо требовать от пользователя. Но надо валидировать.
Пробелы вокруг :
Строчными буквами.
Можно ведь компаратор использовать.
Тест может падать при смене дня (поскольку new Date() и Calendar.getInstance() могут получить разную дату).
this locator actually points to two images. I imagine that webdriver is only returning the first one.
self = <tests.mobile.test_home_page.TestHomepage instance at 0x03554080>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x036530F8>

    @pytest.mark.nondestructive
    def test_that_verifies_featured_application_section(self, mozwebqa):
    
        home_page = Home(mozwebqa)
        home_page.go_to_homepage()
    
        #Assert.true(home_page.is_the_current_page)
    
        # Check if featured section is visible and contains applications
        Assert.true(home_page.is_featured_section_visible)
>       Assert.equal(home_page.featured_section_elements_count, 6)

File "F:\workspace\Marketplace\marketplace-tests\tests\mobile\test_home_page.py", line 25

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <class unittestzero.Assert at 0x03558870>, first = 0, second = 6
msg = None

    @classmethod
    def equal(self, first, second, msg=None):
>       assert first == second, msg
E       assert 0 == 6

File "C:\Python26\lib\site-packages\unittestzero.py", line 45
AssertionError
Validation added to the model, so users can't vote on the same link twice through curl.  I think I need to leave the view helpers though because I don't know how else to check on the status of a user's vote without them.
Please call `pl.show()` explicitly at the end of the example.
On 10/14/2012 08:25 PM, Olivier Grisel wrote:
>
> In sklearn/grid_search.py:
>
> > @@ -449,9 +442,5 @@ def _fit(self, X, y):
> >      def score(self, X, y=None):
> >          if hasattr(self.best_estimator_, 'score'):
> >              return self.best_estimator_.score(X, y)
> > -        if self.score_func is None:
> > -            raise ValueError("No score function explicitly defined, "
> > -                             "and the estimator doesn't provide one %s"
> > -                             % self.best_estimator_)
>
> It used to be the case that score was not part of the required API: if 
> you just implement your own fit / predict estimator you might have 
> expected to be able to use the grid search tools on it.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/scikit-learn/scikit-learn/pull/1210/files#r1837718>.
>
But this is only the case if you didn't inherit from ``ClassifierMixin`` 
or ``RegressorMixin``.
I though that was the minimum requirement for the API.

If this is not the case, then I can add some dummy classes to test this 
case.
The question is: do we really want to support it.
make drawView private _drawView
You really like `;` :D
When using third party code we should be sure to specifically indicate that code's license.  See our License directory under the main Madlib branch.
You should check that each array entry can be cast to a string successfully, e.g. if (l->IsString()) etc...
Yeesh, YourKit-hater! :) 

Commit 59af747 does this.
Yes I realized could go over if not multiple, but wouldn't matter.
Also if REG_SLEEP was > 60K then wouldn't need changing.
But for it's purpose it's fine I think.
Shouldn't lastEscape be reset to NULL?
I think it probably should be, but some of the functions (addFilesFromWorkunit) should be global functions (or members of something else) instead of members of this interface.

I think they only access public functions of the interface (addFile), and add dependencies on workunit and eclhelper.hpp which wouldn't be present otherwise.

(What made me start wondering was the cmake list of files is a bit strange pulling things in from different directories.)
Did valgrind flag these as used uninitialized ?
Yes, but that crash is unrelated to the SOAPCALL change and should be in a separate commit
indentation would help readability here
Can we put this file in .gitignore? It's not really interesting
This stuff makes the comment above it not make sense, just switch them around.
It actually doesn't work that way - I talked to Ilya and Derek yesterday about that because I thought it SHOULD work that way, but it does not
if you change the name of your dataprovider, please remember to update them in your test.
@elicochran Where is this this icon coming from? I couldn't find it in the img/myb folder
@shacker I feel a bit uncomfortable with this, isn't there a way to set the line-height on this or some of the elements in there?
FXD :-)
Tabs it is!
Done in b30cdcf.
"ruby -c" ftw.  I've been super happy with syntastic vim plugin.
Neither the title nor description really tell me what this module is about. It's a small thing, but it should mention python or expect in there somewhere.
Why don't we want to check if it matches something with a trailing slash?
To the 'develop' branch. = )
We rarely - well, never - pass Cartesians like this.  Instead, consider `x0, y0, x1, y1`.  Actually, consider using `Cartesian2` as mentioned below.
From the testing I've done, concat executes faster but produces more garbage than the in-place alternative `commandList.push.apply(commandList, otherArray)`.
Sounds good. Should we be keeping a list of required improvements after this initial rev in a ticket somewhere?
We can probably factor out line 209 and just do something like:

    if (win != null ) {
        // fire for window
    } else {
        // fire for tab
    }
Yes, but you're adding a newline after that empty string. That means the first line is always blank, which kind of looks ugly to me.
Can it really be something other than a String? It might be "", but I doubt it would be null.
Yes, that's the goal.
In that case, we'll try and find it somewhere else (in the installed easyconfigs).
The logic seems to be the same everywhere you do this. The only thing to change is the exact call to a this.http method. What if you made your wrapper a little larger instead? Something like:

var requester = function(path, httpcall, callback) {
    return this._requestWrapper(function(innerCallback) {
        httpcall(that.urlify(path), httpcall, innerCallback)
    }, callback);
}

but probably modify _requestWrapper itself, since it's only used in this idiom.
Эти ивенты с `e.target` жуткие вообще, конечно.
Is dropping the glance_sql_connection string here intentional?
Please just change add whitespace in front of the numbers in the array so that they line up.
Cleaning up the rest of the module can be done in a separate commit. Most of the code in this module is really really old.
The code itself looks good to me.
Ah, okay. I guess that static arrays can still count for `isSomeString`. I do find that to be a bit worrisome though, since it means that there's no guarantee that `isSomeString!S` is a pseudo-reference type (which dynamic arrays are) or a value type (which static arrays are). I'm not quite sure what the implications of that are, but I would definitely be worried about templated functions making wrong assumptions about the string types that they're using (like that you could append to them).
`immutable(const(int)[const(int)]);` should be formatted to `immutable(int[const(int)])`, is this supposed to that?
RefCounted!Payload?
I really think that each loop level needs to be indented. Personally, I'd also use another set of braces, but regardless of that, I think that it's generally misleading to put something at the same level of indentation as something which nests inside it.
Can you edit the root LICENSE file too, and add this text like we do on dartlang (http://dart.googlecode.com/svn/branches/bleeding_edge/LICENSE)


This license applies to all parts of Dart that are not externally
maintained libraries. The external maintained libraries used by
Dart are:

todomvc - in samples/todomvc

The libraries may have their own licenses; we recommend you read them,
as their terms may differ from the terms below.
Test for parameter name provider is missing (needs to be configured in `validation-custom-config.xml`, too).
Add a note about not being synchronized…
Do we want bmr_id=? or bmr_pidm=? here?
Just tested this in PHP and `'c' === 'с'` evaluates to false. This might be an encoding problem, since MongoDB requires UTF-8 strings.
This is an inline comment. Remove this excess whitespace.
Should we call out that we do not support new features introduces in Storage 1.7? Like copy blobs across accounts, async copy, etc.?
Since you're defining it at the bottom, do you need to define it here?
I wouldn't mind a comment here explaining what this is about.
may not need to create this unless it's different than default
I am not in favor of hardcoding the paths here.  That defeats the way Rails works with routes
Where is this data actually held? Is it possible to represent this with an integer offset instead of a full pointer?
Ah darn. Well I've done the `@warn` anyway just in case, and provided a comment. We can keep the file around indefinitely, or choose to break backward compatibility and force people to deal with it. I'm really fine either way.
This actually returns a list -- not a string. Seems like we can use `compact(join($existing, $addition))` which are already built into compass and sass.
So, instead of enforcing `QUnit.config.reorder`, couldn't you use the `module`'s `setup` function to just authenticate before each test? I'd prefer not to use something edge-y like this flag if we can avoid it.

S'okay if it's a huge effort right now. But, really, exploiting the module setup function is good practice.
You're right!
Ill fix and spec this...
@denis-sh: A large number of coding guidelines require/recommend to have only one declaration by line, so I'm somewhat surprised you have never heard of it before. I agree with Andrej here – don't write needlessly confusing code, especially if it can be trivially avoided.
range slider form
docs? blank lines?
You didn't address this comment about improving the test.
s/us/is/
Probably did, so I'll check in the morning. Although I am not to hot on staying compatible with EOLed version of JVM ;)
Anyway, the real argument here is SPR itself and whatever its compatible with everything else should be so I'll fix it
We could by passing an integer index to _compile_integral so it knows what to call it - is this what you mean?
Ну оно в оригинале как-то так же
OSX is also case-sensitive. Which files are we testing that get case-sensitivity wrong then?
I think we could remove some duplication here... if you want to not-search if the user did blank, then maybe you could

```
def nil_movie
  Movie.new(id: 0, title: "NOTHINGFOUNDHERE", year: 0, score: 0)
end

def self.search_by_title(title)
  return nil_movie if title.blank?
  # regular stuff
  else
    return nil_movie
  end
end
```
what about 

SECTION_REGEX = /^\s*\[([\w\d\.\-\/]+)\]\s*$/
SETTING_REGEX = /^\s*([\w\d\.\\\/\-]+)\s*=\s*([\S]+)\s*$/
That `exit` isn't needed.
Your argument about no way to reach the state is true, since there was no void facility. However, i think its always good to write backward combatible code, lets assume the customer had a customisation on a different module etc.
remove a and h variables
On some sites I've worked with before, it was common to send different kinds of emails from different users, so the global DEFAULT_FROM_EMAIL doesn't help.

And yet this seems like something that an administrator (not a developer) might want to configure, so it shouldn't be in the code, it should be in configuration. Hence the option to set it per email.

Similarly extra headers; in some cases the administrator might want to add a content-type, mailer, x-been-here, etc. header to the message.

Yes, these could be in the database, but that's over complicated for some use cases. Rails does it this way, the simple way. (in fact it's even simpler in Rails, just add headers first and then leave a blank line separating them from the body)
Will a generator be more efficient here? Do you always have to use all of the authentication methods?
Also, map() seems a little bit more idiomatic in this line of code.
`return map(lambda auth: auth(self), self.authentication_classes)`
I'm not sure if referencing self in a lambda is a good idea though.
You mean, check the actual data to be rendered?
Pas fan de "notre modeste talent".
EnthousiaSmante.
Need to set webView_ to nil as well?
It would be useful to have error message printed into the Jenkins console.
yay buzz word compliant.  maybe we should come up with a more specific requirement.
Ok,
1. specified a .md file path manually

2. pressed enter specified .md file displayed

3.  url still contained specified .md file path in src=

4. select and uploaded another .md file

5. src= part gone from url new .md file is showing

I didn't noticed any issue without src= part
Response code should be returned here rather than a "response_code" in the json body so it will return a 500 if needed.
Clearly this was messed up before. Can we put this in a finally block?
кто такой ind? это логичное название?
For differentiation public methods and fields from private analogues)
Agreed on @arthurevans wording
woups indeed. :-( Fixed. Sorry.
what "how"? I´m sorry but I cant figure out what you want to point out here.
Remember, I wanted to keep this chapter quite general and go into openengsb details in the next chapter.
maybe rather: "an example" or something like this? the title sounds strange :-)
Spaces between arguments: `select: function(event, ui){`