labofsahil/github-event-dataset-2012 huggingface dataset:
Please use a `Set` here so that we get O(1) lookup. I am also not at all keep on using `Mutex_m` in this way. Let's just create a mutex and store it in a separate attribute.

Also, these are purely implementation details, so we don't need to expose this stuff publicly. I'd just use a class variable here I think.
Looks like it should use the new syntax here as well, right?
because expr `itself` does not have a method foo
Yay!  I need to go refactor my tests now :)
It should. It would be un-sympy like to drop a symbol that is passed in symbols. Makint this loop on `xrange(n - k + 1)` would then necessitate (at least) the change indicated above at line 330.
If you make that change then in the test suite you can give the input in those three ways to confirm that they all give the same answer:

```
ans = SOPform('xy', [[1, 0]])
assert OPform([x, y], [[1, 0]]) == ans
assert OPform(['x', 'y'], [[1, 0]]) == ans
```
`**kwargs`
my 2to3 branch has a commit that updates the error message to read

```
git was not found: make sure it is in your PATH environment or hardcode it into
use2to3, changing
  files = check_output(['git', 'ls-files'])
to something like the following (for Windows)
  files = check_output(['C:/Program Files/Git/bin/git', 'ls-files']).
Exiting...
```
not enough \n
whitespace `$r=new ...`
nope :-( this code throws "TypeError: Illegal invocation" in chrome:
`var a = window.performance.now; a();`

also i've put the msRequestAnimationFrame back, and made one more slight check, just to be sure.
This allows it to transparently use the `.gpg` version of a netrc file if it's present. If we want the encrypted version only to be used when explicitly requested then we should remove this `elsif` branch. It's a judgement call. If we do leave it, I think recursing is the right thing here to avoid duplication.
Does the background runs on mac too? If so add it to the linux description (also includes Mac).
I wasn't aware of that.  I expected that the guest user was an integral part of the system, but apparently not.  A workaround to this is to add guest as a member of 'diffa' only if they exist as a user.
Sorry -- not quite sure what you're looking for here...
should the last """ be on the next line?
Il faudrait utiliser *row-fluid* ici. Les *row-fluid* sont pour le responsive design et les *row* pour l'ordinaire. Il faut utiliser *row-fluid* partout ou *row* partout.
Why are only BBCode and Smilies allowed, shouldn't it also parse magic urls?
Because both of the above if() conditionals result in the same outcome, perhaps consider merging them? The conditions would probably need to be broken up over multiple lines so that it's not just one long line, though.
fixed, will appear in the next push
Sorry I should have clarified, you should use $lang_path = __DIR__ . "/../../phpBB/ - to make sure this is independent of where phpunit is actually run from.
Delete queries never fetch `$result`
# is counting the length of the array.
nu e nevoie de doua linii goale
i agree we should be wrapping these `.run()` and `.exec()` calls that throws errors by default. issue #32
A nit, but I wouldn't name this callback, it's more like the "walker" than a function you call on async completion or in case of error.
$availableUnits и $Units одно и то же?
Can you require `html` in browserify ?
Change the command to "make -j %d opencv_python" to limit build to python wrapper only
>    We can leave XML catalog management up to the user, suggest running asciidoc by pkgs.myEnvFun overrides or wrapper the a2x binary to use a default bundle of Docbook DTDs and stylesheets.

I don't think so. I -- as a user of asciidoc -- don't want to manage XML
catalogs or define my own wrapper scripts. I just want to run `a2x` and
have it work out of the box. IMHO, the best way to accomplish that is
wrapping the binary in a script that transparently creates the necessary
environment at run-time.

 >    We need to be careful to allow the users to override the docbook version that we use.

Well, the docbook package is an argument to the asciidoc expression that can be overridden by users to whatever version they'd like to use. Personally, I'm not sure why anyone might want to use a different version of docbook, though. What is the use case?

 >    How is this problem solved for perl, which has a similar problem with ${PERL5LIB}? 

Perl scripts that need non-standard modules at run-time are usually wrapped in a script that sets PERL5LIB appropriately.

 >    Does it make sense to call the setup hooks from the user's shell that initialization, where $HOME/.nix-profile/bin is added to the path?

I am not sure whether I follow ... could you please explain that idea in slightly more detail?
will need to flesh out in more detail what the appropriate categories are. probably from ICD10 and SnowMedCT.
I think we should only require exactly what we need, so the loader when we deploy doesn't have unnecessary files.
This isn't "wind" anymore.
You could use a `collections.Counter` for this section, e.g. `counter.update(_months_in_season(season))`
I'm not sure it is a good idea to keep a precise number of allocs. If the compilation pipeline changes, or if some optimizations change, these numbers could change. The important thing to test is that all the memory allocated is freed at the right time, not the amount of temporarily-allocated memory.
Now that your optimization should run by default, can you revert that change too?
Remove all that debug code
I should be shamed for this. Fix it.
So I wrote the diffPair class mainly for the following two reasons:
-There're many places in the diff function where determining if two planNodeList equal is needed( diffPair.equals() );
-A tunable general diff output as above is needed.
Declare the 80% constant private static final near MAX_DESIRED_PENDING_BYTES?
Add every device in a separate transaction
a DeprecationWarning is only appropriate if a feature is actually being deprecated, whereas here I believe the intent is only to warn that one is calling array on non-numpy enabled gis datam
I use byval-lambda in [`lambdaPack`](https://github.com/galchinsky/clay/blob/lambdaCaptFin/lib-clay/core/lambdas/lambdas.clay#L7) to save packed closure. If change it to hand-made callable, it could be possible to use only byrefs, but I think it will make compilation slower because of reference-dereference inlining or stuff like that.
We now support email-less accounts, such as on weibo.
Oh maybe I'm just being thick... it seemed like you can only have one service associated with an user. Did I miss something?
This line has been changed just a few days ago...
https://github.com/mono/MonoGame/pull/696/files#L1R1003
I feel this is unrelated to the stored playlists cleanup as well, but I totally agree that it's important, so I intend to fix this right away.
This needs to be re-indented.
I know you were talking about it on IRC, but could you elaborate in the pull request on why there's an OpenSSL dep?
@n1k0 my terminology in the ticket regarding testing the 'page.confirm' event handler was incorrect, it's a filter not an event handler, and there currently is no casper method for removing filters
Should this be `return self.finish_request(...)`? At least I think this should be consistent with `return self.handle_status_message(...)` on line 74.
Sorry, I totally missed that. If it makes sense, I'm going to re-organise the developers' page to make the workflow explicit (move the testing and flake8 sections right before 'pushing your changes').
Ugh.  Yeah - code that was shaped from an abandoned direction.  <facepalm />
Maybe that won't work, that assumes you're passing in a DeclaredType. This method should definitely take a TypeElement or a TypeMirror and do the work on that . . .  hide all of the string manipulation in one place.

You can probably do this without string manipulation by asking for the raw type of the parameterized type. See the visitor in typeToString for an example.
Sounds good to me. Thanks for your detailed explanation.

@dsaff Do you agree?
This search for an existing dat appears multiple times.  Can it not be refactored into a single function?
I may end up listening to orientation change in IOS in the JS code.
It might be a little clearer to reverse the flag's sense, so it's `doAnimation` instead of `skipAnimation` (so you don't have to think "Am I not skipping the animation?").
Is there a reason not to use [[ ]] here?
Only text used in a dialog will actually get turned into a clickable link though -- since the style implies actual functionality changes there, it seems fairly closely bound to Dialog for now.
YES! (Well actually, a promise). This is a good idea.
Nit: the timeout arg is optional in waitsForDone().  Probably no reason not to use the default value here.
I know this isn't part of your change, but these 2 strings are almost the same but have a slight difference. The first says "but also has unsaved changes" and the second says "but has unsaved changes" (missing "also"). Seems like they should be consistent.
Shouldn't this simply be `if(window.localStorage && localStorage.lastLoadTime && parseInt(localStorage.lastLoadTime, 10) > 4000`?
Could dry this up with the same code above
+1. or can we at least fail fast if it's not passed in? i don't like this silent failure business.
is formelement.validationrule.label coming from message.properties? if its a 'code' its not really a 'message', right? aren't those kind of 2 different things?
Add 'Z' to the end of the date to indicate UTC. The `isoformat()` call does not add it because we store without timezone information in the db.
I suggest:
```java
private boolean isHandlerHasHisOptions(NamedOptionDef option, Set<OptionHandler> present) {
	for (String req : option.requires()) {
		if (!present.contains(findOptionHandler(require))) {
			return false;
		}
	}
	return true;
}
```

Modern and more understandable.
Do all imports on top of the file. Import only modules.
I would still use classes, but just those we can define in templates, because it makes things more table (we do not have to be so precise with mapping of styles, `li ul li` is ugly and error-prone). And yes, you can remove the renderer.
*they* -> *she*
This comment is just a bit inaccurate. `trackBottom` doesn't exist.
I like this. Much less confusing.
ya apparently in that node formatting thing it says that's standard. but we can change it to 4 if you want?
0.35 and 1.5 are some magic constants. could you give them a names and define few lines above?
Nice! I won't worry so much about calling out migrations then ;)
Doesn't it still have empty elements in the page though? Because you're inserting the dom elements directly in the template rather than through the js?
First, I didn't want that a `BBOX` value in the `baseParams` would overwrite the calculated one. Second, I didn't know `goog.object.extend` returned the target object.
That's added 3 days ago? ;)

Sure, will convert to that or another "template" like this one:
https://github.com/cstamas/sisu-goodies/commit/abd24693a27295d61bdf51d5fa2c81876f0c3779

But right now, it would need sisu-goodies release and bump on Nexus, so will defer for now.
one thought i had - maybe we should not treat "manual" as requesting all of your friends - seems like there's no real need to make the client's friend list exactly the same as on the server?
These should be configurable too
So, one minor problem is that this raises an AttributeError if the site admin has a format that isn't one of the ones we support. e.g. "flv".

We could solve this by adding some text to the configuration documentation in the admin guide.

We could also skip any formats that throw AttributeErrors.

I think maybe doing both is a good idea, but I could be swayed by better ideas.
As a side note, this macro is a big mess. We should be doing javascript tihngs in the middle of the page like this. It'd be better to figure this all out in the view code and then toss the relevant javascript includes at the top of the page. Or something along those lines.

But... I think that's a problem for a different day.

My javascript-fu sucks. So I'm going to find someone else to eyeball this.
Agreed. Chored.
I see in many cases throughout the specs the usage of LocaleHelperMethods::set_default_locale.  Is set_default_locale still needed?   Should they be combined?
replace that line with
```ruby
:system_group_ids=>self.system_group_ids
```
Minor thing, I am ok if you want to ignore this one ...
I updated the code to do it this way, to follow similar pattern as candlepin and pulp (we keep the install classes for them there as well).
you should add space after the commas
I find this code rather unreadable :smile:. It looks good and I'm a big LINQ fanboy but there's a lack of comments and too many things going on in one method that bugs me.
Yeah, that's a good idea. It's already possible to set the timeout value via the vm_ready_timeout parameter. However, this throws an exception when the timeout elapses. So we should add a method to say - don't block at all. Perhaps one easy way is to make the automatic call to "initialize" optional. That way, the initialize method is not called automatically (and therefore, no blocking occurs). However, any subsequent calls to methods will block, because the server is not ready anyway. We could remove that blocking too, but I wonder whether that's a good idea?
How do you envisage a covariant standard deviation be implemented, and wouldn't it be worth implementing as a separate class, e.g. ``SDCovariantError``?
I think I fixed all of these now
Having just tried to implement the simple caching scheme I ran into a few issues.  I think it mostly works,  but I'm going to heed your advice and leave this optimization for the future.  I have this work chucked off to the side in a feature branch `time-cache` now.
so, I did think about this. The confirm/0 method is spawned from the riak_test_runner, which then spawn_links this function. When the process that is the confirm/0 finishes, the process that is linked to it (this function) is also terminated.
if it's for log purpose， please use Log instead of System.out.println
this is a BC break as the new method contains more methods, meaning all O*M projects will have to be updated before merging
Should be `-1` to be consistent with `FilesystemCache#doFetch()`
I'm ok with this for now.. but it feels a bit weird, but I can also understand it..  However at this stage my preference would be that we explicitly write groups into the permissions logic rather than hang off the discussion. The group is there to be a permission thing.
Same indentation problems throughout this file.
Need to cover the case where `PYTHONPATH` is not in `os.environ`.
Do you think we need to have open and close strings other than the default ones?
I think having progress jump backwards is very problematic. It seems vastly preferable to have it jump forward. Imagine this being displayed as a progress bar in the UI. A backwards jump is not good a nice user experience.

By the way, I actually think as implemented, this jump will happen somewhere during the second phase (first phase is removing files). You can move the jump to the first phase by replicating the "is there a submodule that would need to be checked out" logic while scanning through the deletes, but I opted not to do that since I knew that further rethinking of the progress reporting would still be yet to come.

Another alternative is to exclude the third pass from the progress reporting completely since it just calls mkdir on the submodule. We could then require an explicit call to checkout submodules and/or add a submodule callback a la the notification callback.
This can be abstracted.

```c
int gitno_connect(git_transport *t, const char *host, int port)
{
    ...
}
````
don't hardcode en-US in the url (there is locale detection on webmaker.org and we may translate it in 2013)
Right. I was just being consistent with `SEARCH_DEFAULT_CATEGORIES = (10, 20,)`
i like it!  done.
thanks Tarek!
I'm sorry about the ugly test infrastructure. I initially wrote that code before I really understood the unittest module. And I'm not sure if nose had even come out back then :)
No more backup type?
This is never used in this file.
why removing the low confidence check ?
it could be:

```
<?php

if (getter) {
$values[] = ...;
continue;
}

if (property) {
$values[] = ...;
continue;
}

throw new;
```
I was looking to avoid verbosity, but I guess at the cost of clarity. Reverted back to original if-statements structure.
You can leave the comments in (see "Disabled this behaviour as the syntax is not yet final"), but please indent them to align with the other comments.
I would move the event object outside the ``Console`` namespace
@Tobion the matcher and the generator are meant to share the same context, otherwise it becomes a pain to support parameters in the context (for instance when implementing host-based routing, where different contexts would be a mess as soon as they become out of sync)
don't see why you are using DIRECTORY_SEPARATOR here, windows has no problem to deal with `/` in file paths
This is actually not correct. The method should return null if $value is null or an empty string.
Why opening the streams in that scenario?
You should set a property `contentSent` (or sth like that) that you'd set to `true` here. Then in `sendContent` you could return prematurely if the variable is true.
Can you remove the `@api` tag here and below. We will mark them later on. Thanks.
the method is not compatible with `AbstractType` :)
You'll need to save the reader index here so that it is restored next time. See the [FrameDecoder example](http://docs.jboss.org/netty/3.1/api/org/jboss/netty/handler/codec/frame/FrameDecoder.html)
did you fix this error?
no need to log this
I should clarify and add "... in the ruby tags only. HTML can be double quotes."
This is wordy.

I might `include Rails.application.routes.url_helpers` before the test, then use `event_url(event)`. Much easier to read.
恩，关于merge都是开源和版本管理相关的内容，大家一起学习吧
我每次merge的时候除了浏览每一行修改以外
还会在本地pull一下你的最新代码，编译一遍确定没有更多的错误
才会merge的，merge不是一个很慎重的行为
出发 onstart 方法？应该是触发吧
MeshFromPoints
Add catch all handler for unknown columns.  It's type should by Map<String, V>.  V can be a basic type of add ability to specify a custom serializer.
or actually, the whole code becomes:

```
try:
    return KNOWN_EPSG[epsg.upper()]
except KeyError:
    raise cartopy.exceptions.UnhandledEpsgError("Unhandled epsg code {}".format(epsg))
```
Parentheses are preferred over backslashes in PEP8 (http://www.python.org/dev/peps/pep-0008/#maximum-line-length)
I'm not opposed to standardized formatting, but I find it odd that line breaks are enforced and properly spaced comments are not! :P

// This is a good comment.
//This is a bad comment. :(
also arguably, ``force_language`` or ``ForceLanguage``.
also see _this link on bocoup.com_ 

to

Also see _more about implementing iframe[srcdoc] responsibly on Bocoup's blog.
This one already exists.
Thanks Brian, I pushed a change to enumerate the legal values for default-extended-persistence-inheritance and tagged default-vfs as a boolean (assuming that is enough since that implies true/false)
It's worth considering mozGetAll to try and make this go as fast as possible for startup.
In the order by lastname (default case) we just have to follow the list (as it's now ordered), in the other tests, the one that order by given name, yes, we check that the positions changed based on the order.

But you are totally right, we need to check in this tests the correct highlighting. Good catch, will fix the PR.

Thanks!
In this file, the line `327` => `document.getElementById(ssid).childNodes[0].innerHTML = status;` you should point properly  to the second `<p>` inside the list item:

`document.getElementById(ssid).querySelector('p:last-child').innerHTML = status;` or whatever selector that you prefer to use.
{
        tags: ['album', 'artist', 'title', 'picture'],
        dataReader: FileAPIReader(file)
      });
shouldn't we send a `webapps-install-denied` mozContentEvent here?
This is the main objection I have regarding this PR: we shouldn’t use any arbitrary class name here.

How about using a `<form>` element with two submit/reset buttons instead?
Yes, this could be removed. 'status-inactive' may  accomplish with 'attentionscreenhide'. but the timer could be canceled,
Rebasing is like one of my favorites hobbies anyway :)
Perhaps we could remove the try/catch, it's a bit slower and replace it with a check if the api exists.
This is not expectected code. Probably it is easier to make translation via translate.osmand.net.
Shuld this be IList<string> or IEnumerable<string>?
Not so much a nicety as a way of grouping things together for multiplicity (zero or more of this group, one or more of that group, etc.)
Could this object be updated to use `Adamanitum`? It looks like it's written in the same style as veritas, where state is not mutated outside of the `#initialize` method.
You can use `__method__` here too. (and anywhere else you have something similar)
body p { margin-bottom: 0cm; margin-top: 0pt; } 
    On 10/7/2012 21:28, Argyris Zymnis
      wrote:
    
      
        @@ -135,4 +136,12 @@ trait FieldConversions extends LowPriorityFieldConversions {
     val f2 = uf(pair._2)
     (f1, f2)
   }
+  
+  /**
+   * HBase 'deserialization' - HBase's native Array[Byte] type to either String and Long.
+   * Note that additional types are implicitly converted and therefore conversions to 
+   * Int and Double/Float are support as well. 
+   */
+  implicit def bytesToString(bytes: Array[Byte]): String = Bytes.toString(bytes)

      
      
Yeah not entirely sure how to proceed here. Let me think about it some more and I'll get back to you.

---
Reply to this email directly or view it on GitHub:
https://github.com/twitter/scalding/pull/121/files#r1133823

    
    Hi Argyris,
    I have been playing around with Scalding to try solve this out, and
    the more I delved into the code the more I understood your initial
    rejection towards the 2 implicits I have written. I got to the
    conclusion that the only place I could deserialize the HBase
    Array[Byte] in time, is before the TupleGetter#get is being called
    in GeneratedConversions.
    Well, I won't get into the details, but I need you to suggest how
    much discomfort this causes you:class
        HBaseJob(override val args: Args) extends Job(args) with
        HBaseConversions with FieldConversions
    ... to save you the gory details. The end result is that HBase
    deserialization works (!) without modifications to the rest of
    Scalding infrastructure and especially the implicit type conversion
    mechanisms. To achieve this isolation I eventually needed to create
    an HBase "job" that inherits from HBaseConverstions - a class that
    holds an implementation that "decorates" the TupleGetter#get call 
    If you are cool with the whole HBaseJob concept than I would be more
    than happy to proceed ..
    All the best,
    Amit Mor
This function doesn't create command-lines.
Yeah why not, I'll replace it.
Now that we're serving a redirect this header isn't needed.
This is addressed in 945a08abd798d5b8e41c6f0ec6bc4bedfeb075a9.
Schedulers shouldn't be keeping local state, that's how :)

I think Timed is actually in better shape than you suggest.  Triggerable
and Dependent need some work.
Not quite sure ont he point of this, but I merged it anyways, no harm.
Move m_settingsItem to private section below, follow coding style
Be careful with such supposition. Because we always have to keep in mind that each constant of this class __have to__ mean level
> If so, are we testing that layouts aren't broken if that JS fails to run for any reason?

Nope! Maybe I should change that to a div until we figure out what we want to do here?
On Mon, Oct 8, 2012 at 1:32 PM, Victor Julien <notifications@github.com>wrote:

> In src/flow.h:
>
> > @@ -477,6 +477,23 @@ static inline void FlowSetSessionNoApplayerInspectionFlag(Flow *f) {
> >      f->flags |= FLOW_NO_APPLAYER_INSPECTION;
> >  }
> >
> > +#define FlowReference(dst_f_ptr, f) do {        \
> > +        if ((f) != NULL) {                      \
> > +            FlowIncrUsecnt((f));                \
> > +            *(dst_f_ptr) = f;                   \
> > +        }                                       \
> > +    } while (0)
> > +
> > +/* \todo there is another copy of this same macro inside decode.h.  The reason
>
> is there still?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/128/files#r1782514>.
>
>

No, it's not.  The comment got left over.

-- 
Anoop Saldanha
Thanks for pointing it out. I wasn't aware that there is a tool for style checking. Will fix it.
If you were happy with only supporting `:text` and `:index` locators, this could be done in `UiaDll`.  I was thinking of doing this anyway, because if you had a `ListView` with a ton of rows it could be expensive to grab all of the items every time.
I don't know if patch above actually works, but it gives an idea I think.
Yes, looks overkill to me.
Maybe `tab` or `tabInternals` is a typical naming we use elsewhere for this.
These files will change, I am just writing some code to extract strings automatically.
Nit: This should end with a period.
Should this be case-insensitive?
Forget the white space requirement.
Please observe PEP8: 
> load_pretty_printer:4:38: W291 trailing whitespace
> load_pretty_printer:7:28: E211 whitespace before '('
This is not really suitable to send one log message per warning is it? Why not combine all into one log message? the "Security configuration has validation warnings" message could be so far removed from where the rest of the logging gets printed
In short, more unit test and less functional test
Should we add a filter to return a DateTime ? I think most of the time our code will deal with DateTime instead of string as it is much more convenient (or maybe add an option to return DateTime).
Not an issue. The argument itself is untyped; the docblock is indicating what specific types this implementation is looking for.
No, AbstractObject and ObjectInterface are inside the same namespace Zend\Barcode\Object
This shouldn't be in the generic interface because is only a particularity of ValidatorChain
I'm thinking these should be named routeStartup and routeShutdown for consistency with the component-level method names.
Indentation messed up in whole function.
Formatting should be symmetrical here.
Portal creation is identical in the Overworld and the Nether but fails in the End, so I updated the commit to reflect that.
done!

On Dec 10, 2012, at 10:59 PM, Mike White <notifications@github.com> wrote:

> In mvp/models.py:
> 
> > @@ -1,3 +1,4 @@
> > +from StringIO import StringIO
> 
> can you remove this?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
From a coding standards point of view, I'd rather see this as a ternary expression. I won't block on this though:

return (valuesArray.length > 0) ? this.getDataSourceItemByValueRecursively(valuesArray, arrayOfItems[i].value) : arrayOfItems[i];
Yes, thanks for the heads up, will add a better test for it later as well, setting/getting is not enough to trigger it in the unit tests
CS Nitpick : one argument per line when using developed syntax.
You probably need to change mapfishapp for this one.
Cheers, fixed
docstrings for all classes and methods
there is no such thing as a HPC LDAP (it is also referenced a few times further down)
to make the code generally reusable, maybe we should also add the schema so others know what is meant by a group (and eg a project)?
needs to be moved into `else:` block above (and only when data is actually there?)
self.toolkit()
it should be just <code>libs/</code>
Why ERRORS not Errors?
Don't use magic strings. `'VO'` should be a constant and then imported.
Since this might be `options` or a `track`, let's make this more generic and call it `data` (this is how the DOM handles event-specific data objects)
This doesn't need to be a function we only access it once
Added some configurable options to elect which module of the process definitions to define, will come back to this and make it scalable and more concrete.
Yeah, I've been thinking about the name also and I agree that `approximateSize()` feels a little bit verbose. I am, however, also inhesitant to simply call `size()` since that's not really descriptive of how the real functionality. `approxSize()` would be shorter but also pretty uggly.
If there is no per-instance private state being maintained, go ahead and omit the `WeakMap`
this breaks other tests i guess which do not relay on fog mock, can you disable it in  a teardown and validate all tests pass?
I'd recommend against these short ones. It works today when you have the models.py file. But in five years when someone writes a migration script for the mysql database dump they won't know what `I` and `S` means. 

Instead I suggest you do this:
```python
class MyModel:
    INITIATED = 'initiated'
    SCHEDULED = 'scheduled'
    STATUS_CHOICES = (
        (INITIATED, 'Initiated'),
        (SCHEDULED, 'Scheduled'),
    )
   status = models.CharField(max_length=20, choices=STATUS_CHOICES, default=INITIATED)
```

Then you can do cool things like this later:

```python
events = Event.objects.filter(status=Event.SCHEDULED)
```

Lastly, depending on how many more status choices you envision you might consider naming the constants something like this instead: `STATUS_SCHEDULED`, `STATUS_INITIATED`.
Yes, this is verified. Harvest changed this in a recent update.
Again I don't think PID is defined here.
Hmm, looks like you're right. I'll see if I can find time to write a script to fix all of those.
More duplicates follow.
Capital letter in "note".
Lets compile this regex upfront for the ever so slight performance benefit.
@hectcastro any luck on this?
Didn't do this because I was sorting the keys to ensure that the commands are alphabetized.
hmph. we should be avoiding this and using foo.depends, for maximum impact of parallel builds
I am not sure, but someone should check the interaction with pam_systemd ( who also place user in their own cgroups on login )
It shouldn't be I think. This checks two things:

- Can I manage the content? If I can, delete is possible
- Is this content mine? If I can, delete is possible.

One of the two needs to be `true`.
This shouldn't need to be passed in as the request is already on the aarRestContext
Because this is removed, you can probably remove some of the indentation between the types and the parameter names
Oh, it does call a callback. But why is it being disabled?
You're right, all fine! :)
Why are you removing the user class?
set the value to an instance variable so you dont have to keep hitting the dictionary
Sounds right, ok.
Именно поэтому в своём методе init нужно воспользоваться конструкцией `self = [super init]` - это вызовет инициализацию класса-родителя, в данном случае NSObject
Misread the code, thought that it was doing a set with the return from this function. Anyway, fixed.
This `client` creation (and all other instances) could also be moved into the test setup to save time.
If I remember correctly, the spatio_temporal_cluster_test example and the source-space connectivity each produced STC files that could similarly be displayed, too.
put js links and all the script under the last tag before </body>. this will allow the site to load faster. remember this trick.
Your change overwrote this whole file (probably by changing the line endings). When you redo the pull request, can you try to fix that?
Time to remove this comment?
All that is fine until you get the question: what happens if an enumerator terminates without sending an EOF? In the case of chunked result we send it ourselves, but with feed and body, it is not the case.

I guess it is the design of ChunkedResult that is a bit weird. First, it could encode its response alone (using an enumeratee) without relying heavily on Netty, second it should be natively taking an Enumerator (and not giving its Iteratees) in the same way feed does.
Use complete sentences and proper grammar. Move this to the top of the file around the description or where the prompt is defined.
Yes, you right!
What do you think of "Passing additional information" ?
There should be an empty line here
you should remove this line, there shouldn't be an empty line between the file comment and the code
Please declare `new_position` first i.e. `var new_position`
Typos affecting readability. Also seems like some commas are missing.

Also, is "chart junk" being used pejoratively or is that a term of art?
I really don't like the mix of data and display in the REST model. Getting the author identifier why not but that is just one way to display the user name and it force to load the author document when all you want is to get object datas. It should at least be possible to enable/disable all those rendering helpers with a URL parameter.
Why couldn't you use `current_user.orders.where("completed_at IS NOT NULL").order("updated_at").last` here?
yes, I concur. The distinction in the directory name was anecdotal after having made the logging directory configurable. Mainly a quick-fix to address both issues simultaneously, in this case pre-scanning for *_SUITE.erl is simple and direct with the common test suite naming convention. Also thank you for giving this your attention.
A bit of PEP8 is required here in general, could you go through it a bit?:

http://www.python.org/dev/peps/pep-0008/
Pedantry: $return_error should be the last param
please add missing extra line
I have a slight preference for
```
if info is not None:
```

re pep8 "Comparisons to singletons like None should always be done with is or is not, never the equality operators."

I think either is ok in this case though, so ack either way.
This should be "list.isEmpty()", as that is what we are really interested in.
Sweet example. I'm happy to merge it along with this patch, but it doesn't really belong to it I think.
This is only for Concerta so I will copy to concerta and remove the block.
See https://issues.jboss.org/browse/ISPN-2366. By setting it to false getCache() returns as soon as the joiner receives the first CH which does not include it as owner to any key. At this point the member is fully functional and the fact that it does not hold state yet does not stop the user to invoke cache API immediately. Everything will of course go remote because we do not have any local state yet.  If it is set to true getCache() would block until the actual state is received and the joiner becomes member of the read CH (as in 5.1), which might take a lot if the clustered data is large. The default value for this flag is true in order to maintain old behaviour unchanged. But clients that want a quicker 'boot' can now turn this off.
ここはtoStringメソッドで良いのではないでしょうか。
Sure.  The gist is that this prevents deallocating/reallocating a StringIO buffer on every call.
I wonder if this is actually still broken.
A nice bonus might be the ability to pass in a kwarg with a list of colors if the user wants to override the color defaults.
I think there is supposed to be an empty line after the end of the code-block. Stylistically it doesn't hurt either.
This init is not required as `CrashStatsBasePage` is alreayd inherited.
Just to be clear, all of this works even if the request middleware is not being used, right? A cursory glance leads me to believe yes, but just making sure.
make default 0
> Is there an automated system that can check against many browsers and many versions?

No. I personally use http://www.browserstack.com when I need to test in several browsers.

> And, should the inline conditional test of `window.HTMLElement` be necessary, then it would have to be moved to `OpenLayers.Util.isElement`, right?

Right. `OpenLayers.Util.isElement` is supposed to work cross-browser already. https://github.com/openlayers/openlayers/blob/master/lib/OpenLayers/Util.js#L38
You should keep the translatable message as a string in the __() function, otherwise it will not be picked up by the script that generates the po file.
You could do the same thing as in line 288 (see below) to wrap this line.
It's unlikely to ever fail since we're sticking the data in the attribute ourselves, but I think we should specify parseInt's radix parameter.
Why are we still setting the value here?
Ok a preferência pelo design orientado a objetos, mas a complexidade e número linhas de código foram dobrados e nenhuma funcionalidade foi adicionada... há uma justificativa?
"an individual record's" instead of "a individual records"
this index isn't needed because you have the composite index above.
Isn't this flag really the same as testing if cache_pool is non-NULL?   Do we need both?
@defries postslug?
Maybe add comment along the line of "Returns 'True' if all the fields are Searchable"
Not sure why this is in the sociology less file...
I guess this change is ok, but the singular arguments should be fully supported.
lol, sneaking yourself into the avatar table. ;)
najjjaa. Bin mir da auch nicht so sicher, wo es am besten ist.
Aber eigentlich würde es in das Util gehören. Soll ich die Methode um 2 Node Parameter ergänzen?
> Works in IE8+. Works in IE7 but requires Sizzle/jQuery. (And of course works in all of the other browsers.)

That works for me.
1. As @dianaprajescu said, it's now consistent with the doc block (I would hence argue that we're not changine the API, but fixing a bug in our implementation of the API).
2. The whole point of this function is to mimic parse_url with added unicode support. Parse_url returns false in such an instance, so that's our target functionality.
Same question as above, why is the since tag changing?
Oops, no you can't, fixed.
typo here at `resoltuion`.
66.localhost? о_0
thanks, needed better text there. done
We should delete the image, if we don't reference it anymore.
Python 2.5 support doesn't work here (though for what it's worth it would work if you added `from __future__ import with_statement`). Only SymPy itself has to support 2.5-3.3 (including everything that runs through use2to3). All build and convenience scripts just need to support 2.7, especially ones in separate repositories like this one.
npm link'd to a real project, amazing how much better the tests become...
This is also necessary for IE? Then comment it please.
No `'` at the end of the line.
OK, this is very evident from the code. Useless comment.
I don't know what should I comment... I added one line anyway.
But why here? It's no good.
OK. I see. Then you will have to create your own external file.
I didn't, probably Pycharm did, I will fix it.
Why a new form? Why we could not reuse registration form?
Issue is, the variable "afilename"  is itself holding the folder structure.
Removing slaashes will cause all the pages to be saved directly under the
course.
On Sep 14, 2012 7:55 PM, "Savant Krishna" <notifications@github.com> wrote:

> In main.py:
>
> > -							for link in self.br.links():
> > -								if (link.find("pluginfile.php")!=-1):
> > -									response=self.br.open(link)
> > -                	extension=response.geturl().rsplit('.',1)[1].split('?')[0]
> > -                	save_path=os.path.join(self.folderNames[course]+'/',afilename+'.'+extension)
> > -                	output=open(save_path,'w')
> > -                	output.write(response.read())
> > -                	output.close()
> > +                    response=self.br.open(allFiles[afile])
> > +                    if(self.getpdf):
> > +                        if (response.info()["Content-type"].split(";")[0]=="text/html"):
> > +                            for link in self.br.links():
> > +                                if (link.url.find("pluginfile.php")!=-1):
> > +                                    response=self.br.open(link.url)
> > +                    extension=response.geturl().rsplit('.',1)[1].split('?')[0]
> > +                    save_path=os.path.join(self.folderNames[course]+'/',afilename.replace("/","_")+'.'+extension.replace('/','_'))
>
> Filename should not contain any '/'. That's what I did there. Replaced any
> '/' with '_'.
> output=open('..../.../..,''w') will create an IOError
> This does not change the folder structure.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Manishearth/Moodle-Sync/pull/1/files#r1608014>.
>
>
We need to assert that the deployables that are listed are actually the ones for the catalog. Right now I think it assumes it returns Deployables.all.
We should add some more test data that includes deployables not associated with the catalog.
where does post_data come from?
You probably generated the classmap without having all git submodules in place. While this is fine when having some generic autoloader in place somewhere, it is a problem for people not using composer.

Please run

```sh
git submodule update --init
```

before generating the classmap, as what is under `vendor/` must be loaded in order for the module to run :)
Tricky one. @bakura10 is there any way to avoid having empty strings like that submitted?
it make sense.
added these so that alignment could be messed with. Sam seems to think that it looks better when the lines line up
I know this is just a test, but you are opening an input stream without ever closing it.

Why not simply use a String? Then you would not have this issue (although it is still a good practice to always close what you open).

new BytArrayInputStream(s.getBytes("UTF-8")) to get an input stream from a string...
Aggreed, repushed without join mocked.

I hope I'm this sharp when I'm sober for a few months!
But if there are...?
Better use hook_form_FORM_ID_alter().
Good to see this go! :)
Would be cool if arguments were supported for throttled functions, I guess they could be bound for the timeout. Or since it wouldn't be used right now, maybe add a comment to the description that arguments are discarded.
Isn't that what `_on_reset_state` is for?
Isn't that check kind of superfluous?
Needs a file comment explaining what an ngx_fetch is for.
Yes, I think, for now, I would just point users to get standard errors or confidence intervals for ``all`` effects in a loop, by themselves.
I didn't see much except for looping over the entire function. And with evaluation at different points there is not much savings.
minor: does X >= 0 actually matter anywhere?
Yes, makes perfect sense.


On Fri, Nov 16, 2012 at 3:29 PM, Skipper Seabold
<notifications@github.com>wrote:

> In examples/example_interaction_categorial.py:
>
> > @@ -0,0 +1,16 @@
> > +
> > +import numpy as np
> > +from statsmodels.graphics.factorplots import interaction_plot
> > +from pandas import Series
> > +
> > +np.random.seed(12345)
> > +weight = Series(np.repeat(['low', 'hi', 'low', 'hi'], 15))
>
> You might consider using
>
>
> weight = Series(np.repeat(['low', 'hi', 'low', 'hi'], 15), name='weight')
>
> for aesthetics. There's a small problem with unnamed Series in that the
> name attribute exists but it's None and this shows up in plots. We don't
> account for that in this code yet.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/statsmodels/statsmodels/pull/569/files#r2152076>.
>
>
we can use this script as a top-level example, that can be rendered in html
needs editing to render to html
it's possible to keep the original as unchanged copy
Still public!
Rename maybe library to *gravatar_tags*?
contine => continue

also, what's `c()` ? :)
This could be shortened to
```ruby
return trusted_keys.any? { |trusted_key| new_resource.certificate == trusted_key["certificate"]["pem"] }
```
http://ruby-doc.org/core-1.9.3/Enumerable.html#method-i-any-3F
Yikes, this getConfigFile() method is getting big and unwieldy!
What if we call it buildList ... Is a v useful shortcut.

Thx for reviewing! Have checked it works and really useful eg in cloudstack
where is not tagged right
On Sep 27, 2012 7:10 PM, "Aled Sage" <notifications@github.com> wrote:

> In core/src/main/java/brooklyn/util/text/QuotedStringTokenizer.java:
>
> > @@ -48,6 +48,30 @@ public QuotedStringTokenizer(String stringToTokenize, String quoteChars, boolean
> >  		this.includeDelimiters = includeDelimiters;
> >  		updateNextToken();
> >  	}
> > +	
> > +	public static class Builder {
> > +	    private String quoteChars = DEFAULT_QUOTE_CHARS;
> > +	    private boolean includeQuotes=true;
> > +	    private String delimiterChars=DEFAULT_DELIMITERS;
> > +	    private boolean includeDelimiters=false;
> > +
> > +	    public QuotedStringTokenizer build(String stringToTokenize) {
> > +	        return new QuotedStringTokenizer(stringToTokenize, quoteChars, includeQuotes, delimiterChars, includeDelimiters);
> > +	    }
> > +        public List<String> tokenizeAll(String stringToTokenize) {
>
> This seems a strange method to have in a builder.
> I'd have expected to instead call build(mystring).tokenizeAll(), or
> something like that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/brooklyncentral/brooklyn/pull/328/files#r1713279>.
>
>
`decisions and choices`
Agreed & fixed.
問題になるのは DashboardController の方ですねぃ(上記があるのは UserConfigsControllerですた)
From what I'm seeing in the actual implementation, this should read:

 > Using the `message.add_to()` method, you can add either a single or multiple recipients to your message.  Optionally, you can also supply a name to correspond with each supplied email address.
> 
> `message.add_cc()` and `message.add_bcc()` are aliases for `add_to()` (?)

Examples of using `add_to` would be awesome too.
Shouldn't you be issuing this warning if the version is *less than* 5?
Question, not a comment: 10000 waited for 10 seconds.  What does removing it do?  Simply wait indefinitely?  Or is there a default timeout?
I was planning to have scientific calculations, I was mostly modelling it from the android calculator, getting the ui right is a big fiddly though, so I just implemented the basics first
Here, should be ``$params['dur'] = ...``
That validation should be taken care of for you in the api you are calling with this client.  If not, that api has a bug
Perhaps a bit a JavaDoc saying this property needs accessor (getter/setter) methods?
hard coded header name;
Что является разделителем для слов?
Круто. И как прикажешь его создавать?
Тест зависит от локали пользователя.
Without any context, there is no way to make a correct determination in ssl_verify_peer, especially whether the domain name match (or lack of a match) is important enough to cause a connection failure.   The error, and the depth level are the minimum items required to do this.  The other patch, 334, does the host name check internally (which should be enhanced as ibc suggests), but there should still be more information passed to ssl_verify_peer.
hmm ``` array_shift() ``` will shift off the first element... though thats not what we want...

``` 
reset($files);
current($files);
```

would do the trick, while ``` current ``` will return what we need for the ``` preg_match ```
Overly cautious or you actually came across a case where there was no active thread? Inquiring minds want to know!
翻訳されていない？
You should change this to osfamily instead of operatingsystem.
What's with the quoted PropertyNames?
element**s**
Okay - fixing :hourglass_flowing_sand:
Another, ugly option is to just copy and paste the kernel functions section here... Actually, if it were possible to put the original here, and then copy it into the narrative docs at build-time by some sort of Sphinx magic, that would be ideal.
I don't think we want this dependency, we already have a dependency on mockito, but in general we try and avoid mock based unit tests, and instead use arquillian based integration tests.
you might probably need .refreshMap(true) to force refresh, if lat/lon hasn't changed, refreshMap will probably do nothing.
Wait, why is the artifact scalding_2.8.1 and the version is 0.3.4?
Now default alignment is `STRUCTALIGN_DEFAULT`, not 0.
Shouldn't this throw an exception like the one above?
Why do you say "older" ?
I'm very glad to see a performance test!
But I tried to run it, and fails to start the Hibernate SessionFactory. is it missing some configuration file? How should I start it?

If I'm missing the obvious, please add it to the class comments..
Adding method CFile::getINotifyQueueLength to determine how much to read when flushing the queue.  Now it's possible to allocate enough buffer space to read the entire queue in 1 pass.