labofsahil/github-event-dataset-2012 huggingface dataset:
But as soon as you know you've set isHPCCNode you know you will not skip this computer, and you never seem to check isSqlOrLdap past the check directly below.  I'd think you would break as soon as isHPCCNode is set.

Also, if the computer doesn't show up at all in the software should you also just skip it?  If so, you could simply look for an HPCCNode, break immediately, and skip it otherwise.
added the text()

The commas have been proven to be more efficient when echoing than periods
off the top of my head, i don't know. i'll wait for the tests so that i can get a better idea of what the change is about.
Modern - Number divisible by 3
Medical - Number divisible by 5
ModernMedical - Number divisible by both 3 and 5
Вот так вот "Don't"
Fix: order completion without shipping costs
Yeah, someone pointed me to `/etc/bash_completion`, which works. I had thought that installing the `bash-completion` package would do it; I didn't realize there was an extra step of sourcing the completion rules.
I know and I agree. We need to review the colorthemes class, the wizard and make them extensible and semantic. The latest changes look nice but doesn't allow the creation of other themes styled in a different way (and the users will be very confused with the mixing part).
I know that in other places buttonSecondaryBackgroundColor was used, but I don't like that very much. The problem is that the property is used for its color in the default theme, and not for a semantic purpose, and this is wrong. It means that we're imposing invisible conditions on colors. Nothing stops a user from creating a color theme where buttons have the same color as the page background, which means that the shadow will be invisible. The only two colors that are guaranteed to be visible on the page background are the text color and the link color.

In the future we should completely review the way we use theme properties.
This is never used in this function.
Good start guys. Check out this test first to see how they setup rspec

https://github.com/Devbootcamp/test-first-teaching/tree/master/learn_ruby/screen_scrape

They used two local static files to write their tests against.
А это-то зачем?
Это всё хорошо если в код не закралась логическая ошибка...
Permission is spelled wrong
commit para introducir una excepcion en caso de que no haya conexion a internet
OK, so this explains the inelegant special case you later noticed you needed: your `setNext` and `setPrev` have the right idea, but aren't quite right. `siblingify` doesn't check `prev_next` and `next_prev`, `siblingify` checks `prev` and `next` and sets `firstChild` and `lastChild`, respectively, if they're `0`. Your `setPrev` and `setNext`, using it the way you have, checks `prev_next` and `next_prev` and sets `lastChild` and `firstChild`, respectively.

I do like `setNext` and `setPrev` without the `self.next = next`, especially the part where they infer the `parent`, if you think of them as "wrappers" for `.next =` and `.prev =` that work even if `self` is 0, by inferring and modifying the `parent`! Like,

    function setNext(node, next) {
      if (node)
        node.next = next;
      else
        next.parent.firstChild = next;
    }

Then your `siblingify` without the `.parent` setting would be right, but we could just replace `siblingify` with that, too.
Thanks for the report @jorix: the problem is in Popup.js line 473: `this.closeDiv.style.width` is now empty and `parseInt(this.closeDiv.style.width)` returns `NaN`.
Very useful!
I would change it a bit on the js side:
Defining `$.fn.render` makes render available to jQuery in general (outside the scope of your function) which is not necessary. Use a simple function that returns your table and call $(id).html.
Also wrapping jQuery to an anonymous function like `(function($) { ... })(jQuery);` is preferable as notation and has some (useless here) advantages ;)
@FrozenCanuck Great! Glad this is fixed properly.
http://calendaraboutnothing.com/~simplychris
^^^ Reason for the sloppy commit.. I know it's no excuse...I know.
Let's give some context.
Thanks - Good catch. I decided to include both forms as it is possible to have unescaped quotes from other networks.
this is not neccessery
Think it ought to be fixed in the Error/Info class instead by checking if there's any args before calling string.Format
No space between ! and the operand.
shouldn't you trypehint the arguments ?
@Martin: no, I mean that also PYZOwner should get back.

@Hartmut: the problem is that we have no control over zipimport; for instance, it doesn't work if the zip file is embedded into a PKG appended to an executable, like we create in one-file.
Pex overwrites it?
FACEDESK!
Server uptime: 12 Hour(s) 37 Minute(s) 38 Second(s).
UPDATE game_event SET lenght = 20160 WHERE eventEntry = 8; -> for the duration also or atleast Furion stated so. :?
こちらで確認した限り標準のMODXだとこの時点でヘッダは何も出力していなかったので、ヘッダの出力を見て何も出力してなければいったんセッションを切るように終始しました。

https://github.com/modxcms-jp/evolution-jp/commit/46dbec66b2ea9a9ab9b2516035579c1942a18583

これでwarningは出なくなります。
が、ヘッダを出すようなMODXを扱っていて、rss先に問題がある場合は重くなっちゃいますね。
(そういった環境の人はあんまりいないような気はしています…)
should be fixed soon, see https://github.com/neo4j/community/pull/227
get the message right
en teoría no da el ejecutable, da un launcher que te mete el código en el ejecutable o el ejecutable directamente pero "camuflado"

de todas formas dudo que sea ilegal porque hay cantidad de servidores actuando con esto y por ahora no han tenido problema, lo verdaderamente ilegal es lo que ha pasado con el 4.3.2, que jode los wow's y hay gente pasandose archivos internos, carpetas "Data" y tal para solucionarlo, una movida jajaja
we'd love to to [sic]
Oh great news! Thank you!
remove commented and unwanted code
Here is our sad path.
I'm doing API throttling and reporting based on client ID deeper in the app. I currently have a separate API key system in place, but as I'm integrating an OAuth2 server, it makes sense to reuse the client ID for these purposes.
That scares me...
use dojo/_base/window global instead of dojo.global
Sure, I will add that to the README  - Colin
OK, so we're trading a DB write for a DB read followed by a possible DB write.

How about this: `db.update` with `WHERE guid = $newRecord.guid AND lastModified < $newRecord.modified`?

One call into the DB, won't make any changes unnecessarily.


wrt `shouldUpload`: as we just discussed, we never upload a client record for another client unless we're sending them a command (and my opinion is that we should use a `GET` followed by a `PUT` with `If-Unmodified-Since` to achieve that). We should only upload our own client record if the server-side record is missing or stale. Stale is defined as:

* modified time is older than some threshold (7 days, vs TTL of 21 days)
* someone sent us a command, and now we need to upload a cleared record.

If someone sent us a command, strictly speaking we should do another `If-Unmodified-Since` `PUT`, and if it fails process any new commands. But that's a topic for future discussion :)
Seems it's the other way around; 1.9 barfs on the colon and the semicolon works under 1.8/1.9 (tested with a simple script and by verifying in irb that I can load spam_observer.rb w/ no syntax errors).
If Jenkins is bleating then it can be reconfigured or ignored or **the issues can be addressed**. It's not a marketing department we should be appeasing by faking fixes.

You are correct that a few of those FIXMEs can be demoted or removed, but the idea that "it's two years old so it's no longer a bug" is a recipe for wasted effort, and a slap in the face for the developers - in this case mainly me - who've spent time investigating, documenting and flagging internal issues for remediation.
Agreed, it's probably best not to wait for these to be lazy loaded.  Am I right in assuming, however, that this commit was optional, i.e., that it's a performance tweak and not a bugfix?
we will have this discussed tomorrow.
@astro: please add a note to the install instructions about topic channels.
--
Simon Tennant
simon@buddycloud.com
+49 17 8545 0880

On 13 Feb 2012, at 18:55, highfellow wrote:

> Do you need a separate prosody instance?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/buddycloud/buddycloud-webclient/commit/eced14d343231d95e3fdc8ca18dbe73ad5c3f2d1#commitcomment-961115
could use an 'extensions' array in here, too
I did only label which is the same as labelText. I didn't know how to resolve code. Is there an example?
for button being a submit button? :)

<button type="submit" id="" ... />

http://www.w3schools.com/tags/tag_button.asp
That should have said html5...
Как и боялся, детектор новых постов работает некорректно.
Вы таки не разобрались, что посты в развернутом избранном не должны учитываться.
if you want to create a plugin with only one shortcode and two dashboard widgets as functionality this is the perfect file to use.
not needed to fix this issue 8)

maybe later... 8)
Can we move this up so it is not nested under `#credentials_path`) since it is really part of the `Fog` module API by itself.

Maybe rename to be `#find_credentials`
"_selectedNode" might be better than "selectedNode"
These lines are not necessary now as template function and htmlAttribute can take effect at the same time
Wouldn't this basically say that if you could hit submit it failed and you re-submit fast enough, that would be considered a failure?  There's no accounting for number of times?
This prevents using invalid values which will cause exceptions
We most likely want to do the nulling-out in a finally block
I just saw that after I pushed. Already fixed locally
can try... the problem is already illustrated with the behaviorStackPlaceHolder trick, which is that 1) the behavior stack depends on the actor instance (it already depends on instance.receive, and with this patch additionally depends on instance.aroundReceive)... but 2) we want to allow modifying the behavior stack while constructing the instance. Already newActor() contains the fixup to put instance.receive in front of the stack, and with this patch it needs the additional fixup to apply instance.aroundReceive to the stack elements.

Possibly there's a cleanup that eliminates behaviorStackPlaceHolder as well?

The cleanest cleanup would be to prohibit using become() during construction, but obviously that isn't compatible.

A possibility might be to make Actor fill in ActorCell.behaviorStack and ActorCell.actor during Actor construction... that could look like, in ActorContext:

```scala
def private[actor] setInstance(instance: Actor): Unit
```

In ActorCell:

```scala
override def setInstance(instance: Actor): Unit = {
  require(actor eq null) // we can only be invoked once
  actor = instance
  behaviorStack = Stack.empty.push(actor.aroundReceive(actor.receive))
}
```

In Actor, the initializer for `val context` would do a `context.setInstance(this)` and therefore the instance must be set before anyone can invoke `context.become`.

We'd remove `behaviorStack` and `actor` initialization in `newActor`, and kill off behaviorStackPlaceHolder.
and make a third one, `diffSeen`, that handles SeenChanged,
SeenChanged is only for test purpose (INTERNAL API) and I think that can and should be disabled by default, so it makes sense to place that into a separate method, which is a nop by default
Great catch! :-)
hmm, any chance that this will fail with an infinite loop?
I think once the channels are children, this will clear up a lot of code.
Seems to be unused, so I say, yes
Hmm.  By default these cards don't exist.  So this won't detect when card is added.
Don't forget the square brackets for IPv6 addresses.
The chain of deciding on an exchange name is this:

1) If the notifier config specifies an "exchange", that name is used.
2) If not, then we look in server.conf for a default value.
3) if a name is not specified in server.conf, it defaults to "amq.topic" which the AMQP spec guarantees will exist.
Same as above, don't we need to indicate which distributor type is being unbound?
This is wrong. You can't change SORT_METHOD_PLAYLIST_ORDER because smartplaylists have their own sorting which the user can specify so we can't ignore that and sort by SortTitle. But the %T instead of the %L makes sense.
Sure, we can add the ffmpeg streams to the demuxer streams right after the pmt signal. Language should be set by pmt, right? Will give this a try.

My synapses are running hot with that ffmpeg stuff :)
до 156 строчки = можно пробелами стабулировать в линию
Docs! Also update docs for `JOB`.
Need foreign key constraints for gene_id and contact_id
Well, to be fair, I don't recalculate :)

This method is `@private` and is used mainly by the tests so that the spec can start thread B to capture the lock, and can know that B is blocked waiting for acquisition. You're correct, it *should* recalculate, but the omission here is not committing a new sin.
The `**kwargs` argument should *not* be removed from the `_rest_call` method.

There are use cases like this:

```py
def _rest_call(url, method='GET', fetch_all=True, **kwargs):
    res = requests.get('https://api.github.com/user', **kwargs)
    return res
```

```py
res = _rest_call('<URL>', auth=('user', 'pass'))
print res.status_code
```
This was implicit but I guess making it explicit like this is better. I would argue that putting method before fetch_all is a good idea. What do you think? Also @berkerpeksag?
the readme has probably been written before the switch to using the cucumber file :) @everzet can you confirm ? or maybe it is only gherkin than reuses translations ?
This looks like a generic bug fix maybe?? Seems kind of random. Same with the change to "device-tree" file.
In rhino based processors I prefer to encapsulate rhino interaction with RhinoScriptBuilder which allows usage of commons.js and other utility scripts (ex:  json2.js, rhino.js). You can try to use a similar approach.
yes fixing now. Will wait for other issues if any before commiting fix.

On Wed, Dec 19, 2012 at 10:22 AM, Filipe Nepomuceno <
notifications@github.com> wrote:

> In
> library/src/main/java/net/sourceforge/cilib/algorithm/population/AbstractCooperativeIterationStrategy.java:
>
> > @@ -137,4 +141,13 @@ public void clearDataPatterns(ClusterParticle particle) {
> >              centroid.clearDataItems();
> >          }
> >      }
> > +
> > +    public boolean getetIsElitist() {
>
> Should be getIsElitist?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cilib/cilib/pull/86/files#r2460534>.
>
>



-- 
Regards,
Kristina Georgieva
MSc Computer Science
CILib Research Assistant
I guess I should have clarified more - I think doSetParent should probably be private - did you have a specific need for it to be public?
I don't know if you're opening pull requests that contain the same code or what, but I've mentioned before (here or elsewhere) that this method needs a rename for clarity.
Okay, I did some digging and it turns out that -pthread was added as an alias for -pthreads in 4.2 (mirrors/gcc@4207fff4). Now, I don't mind landing this patch but I recall that some machines at Joyent still have gcc 3.4 as the default compiler - on those machines, the build will be broken.
That comment also applies to `src/cares_wrap.cc` and probably others. :-)
Missing whitespace. :-)
The reason I kept this attribute setting was in case there's another handler in the pipeline that will modify readable() on the ChannelHandlerContext.  In this instance, we need to make sure that we're not overriding another handler's modifications - the attribute ensures that we will only make modifications if __this__ handler needs to.

I'm quite happy to swap it out as you suggest, but it feels cleaner to keep the handlers self-contained.
Getting close ;) These lines need an extra indent. Also, checking an unsigned integer for a negative value should raise a compile warning at minimum. I think the value checks need to be done away with in any case as [the documentation](http://docs.python.org/release/2.4/api/longObjects.html) doesn't indicate any special return value as a possible error code, but perhaps that is a defect of the documentation.
Yes.  Any suggestions about what it should be a list of?
No to snad ne :-)
закомментированный код лучше убрать
typo: `libraries`.
No, I don't. I'll remove it.
yes, else we would have one shared attribute_alias hash for all models

On Thu, Jun 21, 2012 at 4:14 PM, Rafael Mendonça França <
reply@reply.github.com
> wrote:

> > @@ -192,6 +193,7 @@ def attribute_method_affix(*affixes)
> >        #   person.nickname # => "Bob"
> >        #   person.name     # => "Bob"
> >        def alias_attribute(new_name, old_name)
> > +        self.attribute_aliases = attribute_aliases.merge new_name.to_s
> => old_name.to_s
>
> we really need to cal merge here? `self.attribute_aliases[new_name.to_s] =
> old_name.to_s` doesn't work?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/6800/files#r1026243
>
the error would not reveal itself since we didn't use this type for anything
what is now the RHS of the local variable that stores the last element,
was simply directly inlined and its formal type was forgotten

thus, I can't have a test that would fail before and now succeeds, except if I break up the commit into introducing the local variables
and only then fixing this type
The JVM spec doesn't say anything on that matter ... it doesn't even mention whether it is supported/recommended to add non-checked exceptions to the Exceptions attribute.

Apart from that, I think we are good to go.
I thought we decided that this would be show()?
this assumes that plt exists and it is named this way. is that a problem?
The first four parameters you wrote about-
# of times it appeared as a Symbol,
 # of times it appeared as a Not(symbol),
 # of times it appeared as a Symbol in an And or Or,
 # of times it appeared as a Not(Symbol) in an And or Or,

I guess these are enough to uniquely identify a variable's fingerprint in the function.
Is this assertion incomplete?
I'll do something...perhaps put it in the `__getitem__` routine. Curiously, it doesn't enter a recursion loop. I haven't figured out why.
Yes, you find the smallest and permute to in on L55 in trace.py, but you find the first index of the smallest arg. Thus, neither ``Tr(A*B*A*C*B)`` nor ``Tr(A*C*B*A*B)`` permute their args, since both start with ``A``, so the args don't match, even though they should be the same.
No, more like this:

```python
a, b, c = symbols('a b c')
A, B, C = symbols('A B C', commutative=False)
Tr(a*b*c*C*A*B) -> a*b*c*Tr(A*B*C)
```

The important thing is that `C*A*B` is cyclically permuted to `A*B*C` because `A<B<C`.
I was unaware of it. I will add it now.
What would you suggest. would `_iterable` be ok? I agree that this could use a better name.
Perhaps add a comment to that effect.
It worth to use caching but this "assoc_recurrence_memo" wrapper is not used anywhere in SymPy, and not tested.

The aim of this wrapper not only the caching itself, but also to evolve the recursion to circle, to avoid stack overflow. 

It can be easyToFix issue for someone else after this pushed in.
@chrisdurtschi  is correct.
A more useful shortcut should create the message from parameters.

```
  public function mail($from = null, $to = null, $subject = null, $body = null)
  {
    return $this['mailer']->send(Swift_Message::newInstance()
      ->setFrom($from)
      ->setTo($to)
      ->setSubject($subject)
      ->setBody($body)
    ));
  }
```
this should be `BOOL`  and not `WINBOOL`
Do we also need all of these ````&nbsp;```` additions in ````_action_search.html.erb````?
Also, note that our drivers implementations are not compatible with each other in their UUID serialization/deserialization logic, which causes a lot of problems.
I'm not sure of the first version with Windows service support, but mongod.exe had it in 2.0.  mongos.exe got this support more recently, maybe in 2.1.1.
none or None?
With that math, rename topics to topics_visible.
Add comma?
"if you"
Maybe base the string on an existing message, so it sounds similar?
page, not step?
chdir has been added later becuase sphinx search makes binlog files on the current execution directory which leads to some binlog files in phpBB/adm/
maybe we should instead change the location of the files, the question is do we want them in phpbb installation or sphinx folder only?
we would need to trip it on the read. worth it?
This has been fixed in some recent commit.
UpgradePollEmitter, UpgradeCheckEmitter maybe that is better
I read your comment but I still don't understand why this was removed. If g is in one of the cosets then no multiplication needs to be done: you can just return that element (with padding identities to bring the total length up to, now, the length of G.base):

```
    return [I]*(len(g.base) - 1) + [g]
```
Lines 116 - 136 have lots of repeated logic. Suggest abstracting the shared code to a helper method and pass the panel and button type as args (e.g. RaxaEmr.Outpatient.view.patient.labresulthistorypanel, ConfirmLabResultHistoryButton), instead of repeating all the lines.
I'd swap the list comprehension for a generator expression ... but otherwise, yes, that would read easier.
I don't think self.tri0 is doing an upcast.  It is set to numpy's triu or tril and those preserve dtype:

```python
>>> tril(ones((3,3), 'float32'))
array([[ 1.,  0.,  0.],
       [ 1.,  1.,  0.],
       [ 1.,  1.,  1.]], dtype=float32)
>>> triu(ones((3,3), 'float32'))
array([[ 1.,  1.,  1.],
       [ 0.,  1.,  1.],
       [ 0.,  0.,  1.]], dtype=float32)
```
It seems to me, the type of output should be the widest type of x, w, v, gw, and gv.

I actually plan to share code that implements eigh.grad() as a theano expression rather than a hand-coded op.  This would take care of type promotion.
if !msg.isReadOnly() == true, then this MUST be m_isLeader, right? I think the m_isLeader check is redundant here...
Что за magic numbers? Может, ввести константы? И комментариев добавить.
It is the same checks and functionality used in the function: LoadFileAsItemList. So, perhaps we should change both... or even extract and reuse similar code?
In FormHelper we currently use only `Model`, so we need to identify it so both in Controller and View
This was our last usage of the setBornOn method.  It is deprecated and should be removed from the Model class now.
Meowwww
You cannot use `is_callable()` (but `method_exists()` works fine):

```php

<?php

class Foo
{
    public function __call($a, $b)
    {
    }
}

var_dump(is_callable(array(new Foo(), '__invoke')));
all have getBoundingRectClient OR the webkit convert. Just do a check for existence of the function before invoking.
Actually, I'd be okay with 2 replace calls from the results of this discussion...
http://blog.stevenlevithan.com/archives/faster-trim-javascript
perhaps a comment here that this is specifically for opera 12?
I am not sure if this is still the duplicate of the below version.
Yeah, I definitely want to flatten this a bit. I agree there should be a package that oauth1 and 2 can keep some shared functionality in. One thing I want to accomplish with this is make the popup and authing process available outside of accounts-* packages for the purpose of apps being able to consume oauth APIs.
I think we want to give these models and the DocURL/DocURLDesc models a common base class, since they're really quite similar.
Still, as it is this evaluates to false:

```
$ mkdir /tmp/foo
$ touch /tmp/foo/.DS_Store
$ brew irb
irb(main):001:0> p = Pathname.new("/tmp/foo")
=> #<Pathname:/tmp/foo>
irb(main):002:0> p.directory?
=> true
irb(main):003:0> p.rmdir_if_possible
=> false
irb(main):004:0> p.directory?
=> false
```

it should return early or just replace `rmdir; true` with `retry`.
Support HOMEBREW_MAKE_JOBS & MAKEFLAGS: 33d0a20bdbf82e10019feba51f90592e56f813ed
we have git, just remove this line
Why do you delete the route from the request? It might be necessary across the lifecycle of this request.
Nit: The opening quotes should align. The trailing `+` are not necessary (and if left out, the `% module` can be safely included in the parens)
This is as designed in previous. No issue.
Capitalize first letter in each comment
Cool. Though I can imagine all sorts of non-human things happening on Travis like a timeout, machine restart, etc. Presumably in those cases they wouldn't report a success anyway.
As _setupAds always runs before _setupAdTag, I think it'd be clearer if it came first in the file.
Should this be `return previousErrorHandler(message, url, line);`? (I don't know if the return value is meaningful for onerror event handlers, but just in case...)
Assuming that's what you want, this is a little better: $(".vert-resizing").removeClass("vert-resizing")
Fix indentation. Use spaces, not tabs.
Instead of "läuft" I would suggest something different. "Brackets wurde in HTML programmiert, ist derzeit jedoch lediglich als Desktop Anwendung verfügbar, um [....]."
Same comments as "checked" test above.
`updateBreakpoints` may need to be called internally like in the case of [dbg-node.js:70](https://github.com/ajaxorg/cloud9/blob/3b3532e38af5c2b22a672aa7b9e3684eb79d7c67/plugins-client/ext.dbg-node/dbg-node.js#L70).
mime key has been removed from this action.
uhm, I don't understand the comment. The correct name for a primitive boolean getter is "isXxxx". If you call it "setXxx", most of the other java bean code will stop working.
newline here please.
request to to ? :-)
Can you use HMapIV from Cloud9 for small memory footprint?
This field is not translatable?
Added TODO. Before fixing this, you will have to explain first part to me like I am 5. I am not sure where and how shall we move this.
Oh yea, I saw this as I was going through the source code but I just ignored it for some reason...
You have some strange checks below.  Instead of doing `+foo` to `foo|0` to force it to always be a number (i.e., 0 or >0).  That way you know that seconds is 0 or >0 below.
../index.html
There will always be a target. If none is provided (like oft happens with our current basic template) I default it to the medias parent node.
Sometimes you .push and other times .concat, why one over the other?
Ok, then I will add another one, so that it is not alone
now the installation script will copy the user_agent module's configuration
Actually, is the requirement now: `hash` and `hashWithSalt` or an instance of Generic for the data type

We don't want to assume the user has an instance of Generic.
Nevermind, noticed the check() method below, good work!
well I do agree that it is a bit odd that we have these syntax types, these Syntax[T] things and the mime types too. But it all seems to work out. Perhaps we'll find a simplification later.
The docs suggest it's faster, which is the main reason I bring it up.
What happens here if you actually pass something? Why have the Maybe Int argument?
Oh, sry, I see now (I have a Twitter syndrome, not being able to read more than 140 characters at once :), you can also call:

Organization.find_by_id(id) = it return either the org or nil, if nothing found.
#hhh yomama
Also, the only valid event after an `end` is a `close`, and no events are supposed to be emitted after an `error`.

What I describe here is, I believe, the most consistent way to propagate the maximum possible information, while still adhering to the specified contract.

However, in addition, this class provides direct accessors for the data and error, exactly because it can be a pain to sort out what's going on with the events.
How are you then accounting for the counter that establishes unique diagnostic output file names?
copy/paste error (joinorder?)
Done

On Fri, Sep 21, 2012 at 5:27 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/planner/QueryPlanner.java:
>
> > +                childrenPlans.add(bestSelectPlan);
> > +                orderIsDeterministic = orderIsDeterministic && bestSelectPlan.isOrderDeterministic();
> > +                contentIsDeterministic = contentIsDeterministic && bestSelectPlan.isContentDeterministic();
> > +            }
> > +
> > +            // For now the best plan for union is the sum of best plans for the selects
> > +            bestPlan = m_assembler.getNextUnionPlan(parsedStmt, parsedUnionStmt.m_unionType, childrenPlans);
> > +
> > +            bestPlan.sql = m_sql;
> > +
> > +            bestPlan.statementGuaranteesDeterminism(contentIsDeterministic, orderIsDeterministic);
> > +
> > +            // compute the cost - total of all children
> > +            bestPlan.cost = 0.0;
> > +            for (CompiledPlan bestSelectPlan : childrenPlans) {
> > +                bestPlan.cost += bestSelectPlan.cost;
>
> This could be merged into the original loop, as I did with the
> ...IsDeterministic flags in the post-merge cleanup.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665950>.
>
>
Looks like a rogue C-d crept into your buffer.
Does this end up being printed on the riak_test log or to the node's log? If the latter, it should probably be changed to `io:format`, in which case it will go to the riak_test log.
It IS :), as ``MSG_ERROR = (ICON_ERROR | BTN_OK | MODAL)``.
URI!
s/overwrite/override
Also should be scheme.
All those lines seem to do is reset [this](https://github.com/cakephp/cakephp/blob/master/lib/Cake/Model/Model.php#L2407-L2410) which is not being changed any more so no need to revert it.
I think everywhere it says "Start new proposal" it should say "Create new proposal".

To me it makes sense that you "start a discussion" and you "create a proposal".
This could probably just be...

    return {
            'online': ...
        }
Still needs to escape stuff that doesn't match `reCropURL`. Which is a bit tricky, admittedly.

Also, I'd consider renaming p1 -> urlValue, length -> limit.
It's even been promoted to the main repo :)

cf. https://github.com/libgit2/libgit2sharp/commit/8344599c36c65dcfb0ac5547a11c994598b19dcc
I think 'osx' should be an option here.
should be Supplier not provider as getting the urlkey could imply i/o
It probably still makes sense if we support append and uniq.  But I would be perfectly happy to kill all of those.
Why notjust `cmake`? Is the a good reason why it wouldn't be in your path and you wouldn't know about it?
@jlongster I grabbed this from home.html in the mozorg app, I would also prefer not to have the inline stuff if it can be avoided.
There is no need to add role="presentation" to this, it's there by default on images with empty alt attributes 
http://dev.w3.org/html5/spec/wai-aria.html#wai-aria
I had them all like this but then realized QUnit wants the expected second. Missed this one though :-)
Relevant documentation:

http://ask.github.com/celery/userguide/tasks.html#context

http://ask.github.com/celery/userguide/tasks.html#retrying-a-task-if-something-fails

http://ask.github.com/celery/reference/celery.task.base.html

As a side note, it's confusing that his web-site is "ask.github.com".
we try to keep the imports in alphabetical order.
I would indent once more here and on the following lines, to align on the beginning of the variable name on the previous line. I'm actually not sure what our style guides are for JavaScript, do we even have one?
Use ObjectMapper from jackson instead
not sure how this got changed, guess running tests change them ?
I don't think so. I didn't think of that when writing the sample.
It returns a `ValidatorBuilder` instead of the Interface for sure because it cannot be changed.
But then what's the use case for a `ValidatorBuilderInterface` at all?
Yup, realized that at the same time you posted
well, let's try that then. :)
Apostrophe on line 4 and 13 - intentional?
Perhaps the cause is the fact we're explicitly setting the types in the factories?
版权就写BHOSC吧，可以把各个人的名字写到一个Maintainers或者Contributors的列表里
Brace on the previous line, methinks. ;)
Nu ne trebuie această migrare.
Sorry if this is being too picky, but this is inconsistent with the other path declarations.  Further, I don't see how this line works for id=nil?
param mismatch
Having client = nil and then setting it,  while is a bit more python-esque I think works well here in terms of readability. Leave it.
It's probably more appropriate to use ```goalsStr.replace()``` rather than ```replaceAll()```.
I figured (maybe unnecessarily) that recompiling with the pathinfo values was more reliable in case of any future/alternative platform that used some alternate form of filenaming - on the basis that pathinfo would always be consistent with itself.

Also, your example isn't quite right I think (mine above isn't either) - it would need to be `substr($page,0,-3)`.

I'm happy with it as is, but if you want me to switch it to use substr I'm happy to do so.
Can you `defer` this script too?
`ussd.js` is also deferred anyway.
L10N seems not be implemented in this version
Same for |contactPhoneNumber|, |phoneEntry|, |secondaryInfo| and |phoneNumber| :)
Yap, using local scope variable would have better performance than using variable in global scope (like ThreadUI).
I am not sure I get your point in this comment.
What's the state needed to activate an IME?

BTW, so far our Asian IMEs like zhuyin & pinyin do not contain latin layout.
But, we may need to remove Asian IMEs for V1 because of OOM issues.
Cool, always happy to see setTimeouts go away from gaia code.
important bit adds alarms
thats the result of a dump, let me clean up
Do we need these if we specify a token file (or visa versa)? I maybe like this better than the *.sh file that's read in -- this seems easier to specify different keys for different clouds.
That would change the logic to `&handlers || &handlers = []`, which isn't necessary, again.
Oh, wasn't diagonal movement supposed to be possible? I remember this somewhere.
Cool. If I know how to document the DRb options I'm happy to do it. I'll watch for updates :)
SET PHASERS TO STUN!
「」いらない説
コンテキスト変数→ "context" 変数
ジョブコンテキストジョブ→ジョブコンテキスト `job`
以後も同じ
If we use `be_success` here we should use the RSpec matchers in the two lines above. RSpec has a lot of predefined matchers `https://www.relishapp.com/rspec/rspec-expectations/docs`. So in this case we could use `equal(json_track)` etc.
lazy val for these?
Check [Compass](http://compass-style.org/reference/compass/css3/border_radius/)
Add PHPdocs.
why do not you use supplied ```setOAuthParameterName:withValue``` method?
On 06/14/2012 02:10 AM, Tom Prince wrote:
> Is it possible to handle this in `setUp`, and clean up afterwards?

Sure. Actually, it's a leftover of initial copy from 
`test_changes_gitpoller`. I'm not sure it's that useful to keep it here 
I didn't look at what #2116 precisely says, but it smells like testing 
it with GitPoller is a bit awkward, the issue of environment and 
subprocesses must be more general.

Can we safely remove this from `test_changes_hgpoller` ?
This should also be added to the manual.
Why not use

    if (CC_TARGET_PLATFORM == CC_PLATFORM_IOS)
glBlendFunc(GL_SRC_ALPA_SATURATE, GL_ZERO) != glBlendFuncSeparate(GL_SRC_ALPA_SATURATE, GL_ZERO, GL_SRC_ALPA_SATURATE, GL_ZERO).

Because GL_SRC_ALPA_SATURATE can only be used for source RGB blend factor.
Fixed and commited.
I don't see the point of hiding the warnings, it makes debugging harder.
you need to use ``escapeshellarg`` here too
Should use `aborting`
特定の`error`コールバックを指定して渡されたときは、通常の`"error"`イベントの
Agree, for > 1000 posts all will be eager.
I think it will be better to use `@project.issues.new(params[:issue])` instead of next strings. Just use `issue[milestone_id]=3` format when update issue url
Also please convert this to Haml.
Indentation was a matter of tabs being replaced by spaces. I poked around some more and am replacing the if() with an assert(), since thd shouldn't ever be null.
Good job with all of this code to set the priority.  You also have to add the `rlimit` code.  As I said before (and you reiterated in your comments), if you don't do this, then Linux will not let you consume more than 95% of the CPU.  That would be very bad for the thread that is in an infinite loop taking tsc.
Yes, it is because of the current implementation of nbconvert:

def render_heading,
def render_code,
def render_markdown,
render_raw,

they have to return a list of strings, so I have to convert the metadata 
dict to string to "inject it" before the source of each cell to marked 
properly for be later rendered by def build_slides.

It is more easy to make a string for a dict than changing how nbconvert 
deal with the content of each cell, so I am +1 to give the work to deal 
with this kind of transformation to reveal class to accommodate to 
nbconvert structure.
right, probably can add support for an optional info.jelly page for ManagemenLinks to handle such custom output
Please refactor this method into 2 other methods: one which does error handling and one which does result handling.
acho que apenas unimed ficaria melhor, já que serviria tanto pro pessoal daqui quanto de outro lugares tb. Dai se for interessante pro médico saber se é unimed bh ou unimed betim (o que acho improvavel), ele mesmo cria um termo.
"that the script will expose a single"
> self module uses some fields from it.

https://github.com/Gozala/addon-sdk/blob/edf492ae7b400eb1458a3c7628a335abf4f246cc/packages/api-utils/lib/self.js#L11
```
const { id, name, prefixURI, rootURI,
        version, loadReason } = require('@loader/options');
```
`version` seems to be the only one field used from metadata. Can't we just fetch this field and avoid processing all metadata dictionnary?
Is there value in this comment, if yes please comment why, otherwise please remove.
But instead of doing:
```
let mainID = "./main"
let paths = {
  ...
  './': prefixURI + name + '/lib/'
}
```

You would do:
```
let mainID = "addon/main";
let paths = {
  ...
  'addon/': prefixURI + name + '/lib/'
}
```
I'm not suggesting to get rid of relative path support. I just thing using it for main is weird and that it would be easier to define paths in the same way than others.
Awesome docstring! Really helps clarify what the code is doing and why.
what on earth is that. ;)
we should keep this line
This is all stuff from mortar. I agree, but we should file the issues there? Maybe I shouldn't include it in the github repo and force folks to use the `make mortar` command.
> What do we do to make sure it is in sync with what gets written to VERSION?

Ideally we'd have only a VERSION file, not a constant, and it would be version controlled, possibly overwritten with `git describe > VERSION` when building from HEAD instead of a tag.  This pull request was meant to illustrate how this might look and facilitate discussion.
This doesn't necessarily work on an installed Puppet, I believe.  The Ruby library path can be something like `/usr/lib/ruby/1.8/puppet.rb`, which doesn't match your regular expression.

Have you verified this works as expected across all our platforms?

Likewise, I don't know that Windows installs as `bin/puppet`, so this might not behave as desired there.

Can we restructure this to "select" rather than "reject" lines?
Why did you _not_ rename the signal here?
Looks like it is actually iOS 4.3, but I'm not to concerned about not supporting older versions than that.
Thanks, John. We'll make that change as soon as possible; how should
we deal with JRuby and Rubinius' behaviour? Use `not_compliant_on`?

On 31 Mar 2012, at 19:07, John Firebaugh
<reply@reply.github.com>
wrote:

>> @@ -247,4 +247,14 @@ def a(*n); super(*n); end
>>       Super::AliasWithSuper::Trigger.foo.should == [:b, :a]
>>     }.should_not raise_error(NoMethodError)
>>   end
>> +
>> +  it "passes along modified rest args when they weren't originally empty" do
>> +    Super::RestArgsWithSuper::B.new.a("bar").should == ["bar", "foo"]
>> +  end
>> +
>> +  ruby_bug "#6239", "1.8.7.358" do
>
> Based on [matz's response](https://bugs.ruby-lang.org/issues/6239#note-2), `ruby_bug` is not the appropriate guard here. Instead we need two specs: one for `ruby_version_is ""..."1.9"` and one for `ruby_version_is "1.9"`.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rubyspec/rubyspec/pull/130/files#r630002
Sure you can rebase this branch. GitHub will catch all changes correctly.
Seems like with an explicit check for dir size, it's not needed at all.
`$method` is unused
This is another possibility to let the method dispatcher handle this.  You can have overloads which accept a strongly typed List object directly (insort_left(List a, ...))  and another overload which  does the "insert" call for non-List types.  That would be a little cleaner (and would also properly handle subclasses of List :) )
Fixed, along with the other block comments in this function.
Not sure what you mean, for now it shows:
0 item
1 item
2 items
3 items

That's correct right?
The jquery example also work this way.
Doesn't Python 3 support the relative import stuff added in 2.6? is there a reason we can't just change this to e.g. `from .attribute_dict import AttributeDict`?
`$classes = classes(this.current[0])` and then reuse within same function body
put comment on line above (shortens line)

rewording suggestion: "do the character remapping, return same char by default"
if (opers...equals(operation  <- remove the odd whitespace after the (
This seems very fragile. If you have ALWAYS_EAGER set to True during tests, shouldn't it block until the task is finished running? Or does ES queue the action also? 

(I've never worked w/ ES)
The display name wasn't being populated during this step so it's useless.
It might be time to wrap this:
```js
app.use(middleware.csrf({ 
  whitelist: [
    '/backpack/authenticate', 
    '/issuer/validator/?',
    '/displayer/convert/.+',
    '/issuer/frameless.*'
  ] 
}));
```
I think you shouldn't have removed the ";"... It's safer to use the ";" even when it is optional.
@ohadlevy , medium_id is not required in host.rb, but operatingsystem_id is required with a conditional that host is managed.
Should I update the host.rb file to require medium_id with the same conditional?
yeah, this is where the having 3 different types of data in one table fall apart :)
With DOMParser, neither of these should be necessary (although removing the . replacing regexp will probably change things below).
What is this "null"? Add a "Variable variable = null" above and use "variable" instead of "null".
You shouldn't have `<code>` tags inside the `.solution`. (This applies to all of the problem types you wrote.)
"...by substituting the known values <b>for</b> the variables..."
You can drop the second line change; the ssl.verify has that default
already, I just missed it. No need to force it, I think.

On Nov 9, 2012 5:52 PM, "Jamie Winsor" <notifications@github.com> wrote:
>
> In lib/berkshelf/cli.rb:
>
> > @@ -183,7 +183,7 @@ def upload
> >          client_name: Berkshelf::Config.instance.chef.node_name,
> >          client_key: Berkshelf::Config.instance.chef.client_key,
> >          ssl: {
> > -          verify: (options[:ssl_verify] ||
Berkshelf::Config.instance.ssl.verify)
> > +          verify: (options[:ssl_verify] ||
Berkshelf::Config.instance.ssl.verify || true)
> >          }
>
> I don't think this would be necessary if we marked the option as required
in the Berkshelf::Config
>
> attribute 'ssl.verify',
>   required: true,
>   type: Boolean,
>   default: true
>
> Do you think this is a better approach?
>
> —
> Reply to this email directly or view it on GitHub.
Rename it to "maybe_reconnect" and I'm all happy!
I guess that suggest to a beginner to keep the JavaScript in the HTML file is not a good idea...
Comments below logic still
It is not and I already removed it. Probably forgot that one there.
> On Unix-like systems:
ah no, it is a missing level for the previous closing brace
This is me ignoring your pull request because you are commenting shit that should make sense from reading the codebase.

If you want comments, toss it in the docblock.
OK I am happy that this detects the js event has triggerd.

I do think the function name needs ot be changed though. it is called `click_` but it also returns something. it needs to be `click_hold_and_return_class` or something descriptive!
just a hint. if you want to print the default value you can use `%default` for it.
Sure, let's switch this back to an integer and that way the code can be more flexible in allowing user defined or newly defined status codes.
`"psr-0": { "Console\\Color2": "" }` should do just as well.
doh. I was using it for blogs and a youtube playlist engine I was making and just 'cut and pasted' that. *slunks in shame*
I blame the dog, should be fixed now.
It might be worth clarifying why this is needed.
I'm not convinced that we need to create a default tenant in here. Some sort of admin UI when installing the application could take care of that. The issue with the default tenant is that it will be hard to ever change its tenant id.
Huh, fascinating. Perhaps it happens at User.save time, and doesn't work
with User.create?  Who knows.  Anyway, if it makes tests pass, I withdraw
my objection, I guess.

On Wed, Nov 7, 2012 at 11:14 AM, pozorvlak <notifications@github.com> wrote:

> In spec/controllers/member_controller_spec.rb:
>
> > @@ -19,6 +19,7 @@ def valid_session
> >    describe "GET index" do
> >      it "assigns all members as @members" do
> >        user = User.create! valid_attributes
> > +      user.slug = "irrelevant"
>
> I probably shouldn't, but the tests failed without those lines - do they
> pass on your machine?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sauramaia/growstuff/pull/1/files#r2050501>.
>
>



-- 
Alex "Skud" Bayley
skud@infotrope.net
http://infotrope.net/
Is is necessary that `action` has a getter?
It should only search for 'core/Loader.php' as the Loader class can be extended.
Can this be avoided?
Eventually we will delete directories, so this name is appropriate.
@jmikola I added them only to be consistent with the other methods in the class.
Another empty catch block :(
Again, here the description could be "Prints a nice abstract of the given topic"
Define a var for result.weatherdata and use it instead of repeating result.weatherdata.
Lluis, are you using OpenMRS Test Case Generator to generate these tests? I'm asking because the method name is not correct and I don't see you adding @should on the geForms method. See https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
better than ``yes|no`` (which only describes the state when opening the PR): the travis icon (unless we enable the travis builds on PRs in which case we will already have them without the contributor having to setup travis)
I see what you mean @weaverryan what do you think I should do with this? I can split this bit off into a more general working with the container builder cookbook page but it leaves the top half quite theoretical and not really a cookbook style page, would it be better going into the service container part of the book?
总是可以在<path>nginx.conf</path>文件中用<link doc="ngx_core_module.xml" id="pid"/>指令来修改
No IDEA (read: I bet IDEA generated noise).
don't know.  fixed.
Why not only `options[:reverse] = @options[:reverse_years]`?
strip only does the ends of the string; perhaps s = s.replace(' ', '') would be better?
+1 on `retrieveAssertion`
(I'd rather just delete commented code)
why logging in the same file and what happens to the 'show log' option in the task manager ?
it's IE hack i think !
Ha ha, sorry about that. I keep forgetting that newline. Will fix.
Not sure about all these.

First off, they are raising `ArgumentError` rather than setting nice errors on the model on save. 

Secondly I think we can do this nicer. I will look at them 1 by 1
`unshift` is ok if `*` is used:

```ruby
I18n.load_path.unshift *Dir[File.expand_path('../active_admin/locales/*.yml', __FILE__)]
```

`unshift` should be faster than `+`