nrwt: move per-test result output into printing.py
https://bugs.webkit.org/show_bug.cgi?id=91465

Reviewed by Ojan Vafai.

This moves the last substantive logging/printing code from the
manager into printing.py. Subsequent patches in this thread can
largely focus on cleaning up printing.py and will leave the rest
of the code alone.

This patch also removes manager.update() and
manager.update_summary(), two routines that were no longer being
used or needed (they have been dead for a long time but I didn't
notice them until now).

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.results_directory):
(Manager._look_for_new_crash_logs):
(Manager._update_summary_with_result):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_finished_test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r122884.
http://trac.webkit.org/changeset/122884
https://bugs.webkit.org/show_bug.cgi?id=91408

Broke the chromium-win build.

* public/WebIDBMetadata.h:
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed chromium lion/snowleopard rebaseline for r122883.

* platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac/fast/block/basic/014-expected.png:
* platform/chromium-mac/fast/inline/002-expected.png:
* platform/chromium-mac/fast/table/table-display-types-strict-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DragImageChromiumMac.cpp is never compiled and can be removed
https://bugs.webkit.org/show_bug.cgi?id=91545

Reviewed by Tony Chang.

This file would only be compiled on chromium-mac, but it's excluded
from that build. This is likely left over from the CG configuration.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/DragImageChromiumMac.cpp: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Add --encode-binary command line option for DRT
https://bugs.webkit.org/show_bug.cgi?id=91532

Reviewed by Adam Barth.

When the option presents, DRT will encode binary output data in base64.
ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
binary data output.

This change is a refactoring to replace the original hard-coded code for Android.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
(TestEventPrinter::handleImage):
(TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
* DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dump):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setEncodeBinary):
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
(ChromiumAndroidPort.__init__):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix a bug where optimize-baselines would incorrectly fail to optimize
https://bugs.webkit.org/show_bug.cgi?id=91551

Reviewed by Adam Barth.

In some cases, optimize-baseline would correctly optimize the results, but because
we weren't filtering the virtual ports out of _results_by_port_name, we thought
that we had failed to optimize.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
(BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
(BaselineOptimizer.optimize): Filter out virtual ports.
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
(BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
(BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
(BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
(BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expecatations.


* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nrwt: rename printer.print_update to printer.write_update to match metered_stream
https://bugs.webkit.org/show_bug.cgi?id=91557

Reviewed by Ojan Vafai.

Now that all of the printing logic is in printer.py, I want the
public interface to printer to follow the meteredstream
interface where possible. renaming write_update() gets us close.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager._set_up_run):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
(Manager._clobber_old_results):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.write_update):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_write_update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122904 268f45cc-cd09-0410-ab3c-d52691b4dbfc