labofsahil/github-event-dataset-2012 huggingface dataset:
I believe we do this by default, and a list is only deleted when all members leave. Correct me if I'm wrong.

If I'm right, this TODO is no longer needed.
Confusing explanation. 

no need to give api-like documentation (i.e. prototype command documentation.) in this more practical document. It's fine to improve the API docs and then just cross reference.
any kind of document.
same nit.
Moved to stylesheet;  my bad.
missing semicolon (same for one below)
Using your web browser, visit the location where you placed
the AS should not be needed anymore?!
Copyright was 2007.
As long as the template is rendered at some point, it doesn't matter where. We run page_footer so that we have the DEBUG information (if needed) and so that garbage_collection() is run. 

However, because controllers return a response instead of directly echoing, we don't want to display or exit, but we still want the other affects of page_footer.
<3 cleaning up error counting
nice find. fixed.
Python naming style for vars, please. (time_stamp, not timeStamp)
`if not last_run: last_run = 'never'`
prefer:

if (typeof callback === 'function') { callback(...) };
Thanks for your kind advice and references.
I modified performance test regarding to your request.

FYI, every other performance tests in the current ocl module don't use `PERF_TEST_P` and `TEST_CYCLE()` at all.
I agree they should match, but my instinct is to go with the less rigorous match to give it the best chance of finding something. Either way, it can be addressed in a separate PR. I've taken this change out.
NB. I've added a general comment which contradicts what I said above!
Todo: add update values to the outputs as well
Afore y' becuse me, take a look at your spelling.
The sense of this test seems reversed --  "If dryrun, then rmtree" should be "if dryrun, then echo the equivalent rmtree command, else rmtree"

The rest of this changeset looks good.
There is a ticket in our issue tracker
Why have `add_index_exchanges` and `trigger_exchange`?  I feel like
`add_index_exchange` makes more sense because exchanges are being
added to the exchange queue (so perhaps `queue_exchange` would make
most sense).  The word "trigger" makes me thing it's happening
immediately.
Is this using global namespace, or is this sorted out by AMD?
I think you should use `six` to support both Python 2 and Python 3.

```py
from django.utils.six.moves import xrange
```
These error messages generally only appear in tests (when strict is on), so having the number in there is really useful - still, I'll change the message to have type in there.
the phpdoc should mention the interface, not the implementation
One thing you could do is move most of the logic to a plain function, and then call it in a lightweight task function, kind of like what I did here: https://github.com/gem/oq-engine/pull/937/files

This way, you can just write tests for a plain function (and you don't have to deal with the oqtask decorator and everything that it brings with it).
The reason because I prefer keep it in this way is in prevision to be able to build Python Package without using packager.sh script (windows users haven't bash).
The packager.sh script already checks setup.py, __init__.py and debian/changelog to prevent misalignment between versions before package build
What is the purpose of lambdaRepack here?
Otherwise:
a) We exit this exception block without having assigned rv and the return statement will fail.
b) If, somehow, the return succeeded we would have consumed the error without any indication to the user, which would be wrong.

=> the correct thing to do is re-raise the exception after restoring client_min_messages.
Files generated by installer, not needed on Git.
rename setupOptions to options
What gives with on and off, if this is a boolean why not use ``gobject.property(type=bool)``?
Gaël asked me to use pyplot explicitely and avoid aliases as much as possible (except for numpy -> np)
yes use stable
Isn't this against out coding guidelines? https://github.com/owncloud/documentation/blob/master/developer_manual/codingguidelines.rst#control-structures
My Unicoded kids are forever in your debt.
Good catch. Unit tests don't cover docstrings. :-)
This call back stuff with local variables gives me a bit of a WAT? What's the story here?
Reading good docstrings makes me happy in the same way as petting kittens does.
Yeah - no need to package the examples as long as they're easy to find in the source bundle.
Oh yeah, those all need to be uncommented, they were commented out for labs
yes, you're right, my mistake. :)
Should we assert on position and size here?
what about copyrights?
(int) 1E3 is a verbose way of saying 1000, right?
Ok Good to know. I'll edit this file to follow suit.
``beforeProjectClose`` doesn't fire when the window closes. This plus removing line 985 above causes the working set to not be saved at all. Is there a reason I'm not seeing for this change?
Whoops, yes. Fixed.
Also $filenameDiv should be $filenameSpan if we keep the span.
I can't actually seem to drag the sidebar open once it's been hidden--I end up resizing the window.
much cleaner, thanks.
Looks like I'm too late :), but I think this might be inefficient. I think $.extend() copies all the items from the second arg into the first. So this would be more efficient as `$.extend(Strings, { ABOUT_ICON: brackets.config.about_icon })`, since that will do only one copy instead of copying each string over.
Should we do that ?
I don't expect children of `DebugHandler` to re-implement this function and the `debugger.js` interface has it like this
Is there a difference between `_` and `\_`?
A way, but ugly. Find another way. :-)
Is this implementation now ok?
fix spacing for myevents to make it two words.
How about just "Time which will be rounded"?
Much less gross. Very nice.

To make it a little less confusing to read, think we can just declare

`function check(){` instead of making it a var?
s/blob/file/ ?
Given that `filteredList` is already jQuery-aware, there's really no need to run it through `$()` every time like this. `filteredList.css` *should* just work. (See also: `filteredList.find`.)
I like the exclamation point convention. I've renamed both methods as suggested
that's not my change. That's from the merge. Not sure what this is for. Sorry I should have rebased.... I'll get into that.
Add one more test which takes all the stream names together
Variable definitions at top of the function scope.
Typo!

Another minor issue is why "test__" instead of just "test_"? Otherwise, awesome test, thanks @vals, I hope @chapmanb could integrate this one upstream some day...
Should be `dec=45`
@laanwj I would love to rename that function to coreEvent() or something as error() is not suitable IMHO. What do you think?
Why did you remove the default value? Just because the param can take a string value too doesn't mean it cannot have array() as default value.
but I don't need to test a validation rule to work... I need to test a custom validation object is imported and initialized.
Don't know how to write that code.

Can you help?
Please write ``constructor``, not `ctor``
Here's why it's not a good idea to add this function in a namespace that gets imported: That function still needs to have some record of the loaded package -- it needs to know the name of the package (which is why it's a closure). if the closure is put into a namespace -- call it foo::system.file -- then there can be only one copy of that function in the whole R session.  So if you load_all multiple packages, then it will return modified results only for one of them. It could work if the function didn't have to be a closure, but I can't think of a good way to do that.
numFonts is not used?
The docstrings say that `silent=True` will force store_history to be False, but it doesn't look like this line will do that - if store_history and silent are both True, store_history will be left as True, I think?
I've been a bit reluctant to add things to the current docs, because I really want to trash them entirely and start from scratch, but obviously I should document new features as they are added.
Should use https if possible here.
...as in, I'm sure there's some sort of legacy dust sprinkled on this that I just don't get.
If you look at the `run()` method. Only the call to `getNightlies()` depends on a date. Meaning that we could remove the `except URLError` block on the `getReleases()`. That would kill the job and the next time it gets to `getNightlies()` it'll have the backfilled date. 

Still, there are situations when it could get half-way through a bunch of URL fetching and break. Doesn't that mean we might swallow the error, miss out on the backfill date, and thus miss data which we never carried on with. 

My new proposed solution is simpler:

* we remove all `except URLError` blocks
* before ever calling `buildutil.insert_build()` we incorporate `buildutil.build_exists()` to prevent accidentally inserting duplicates
* The few times when errors do happen and we potentially re-run files we have processed before, they get blocked by `buildutil.build_exists()` returning True. 

Whatcha think? After all, it's kinda weird that it wasn't already using `buildutil.build_exists()`.
Is this going to break all other apps that depend on generic_app such as crontabber.py?
Null checks are not necessary as instanceof null is already false, so for the first 3 if branches the from != null ? is not needed
`),` should go to next line
nope.  which is good
This class writes data, and reads data from a debug file you can specify. It is often a preferred method of debugging when the debug notifications are not allowed to be visible to the public eye.
you're calling method.getGenericParameterTypes() here and method.getParameterTypes() below. If you wanna make a small optimization, call only one of these and store the result?
в parameters.ini
через анотацію @Security можна просто задати роль юзера
через іншу анотацію можна одразу перевіряти чи він власник квитка. зараз це не перевіряється і я можу друкунти будь-який квиток
We are not consistent anyway as we go to `Resources/views/` when using the location notation. So, it was done for three main reasons: trying to be as far as possible as the current notation to avoid confusion (or not), removing something that is, by convention, always present anyway, and more importantly trying to be more agnostic for when the templates are used outside of the full-stack framework.

Now, I'm open to any suggestion and if the majority think we need/can keep the bundle suffix, that would fine for me as well.
I agree that we cannot really ensure it's unmodifiable in a feasable way. So I think there is no real need for such a proxy.
I see. But it's still strange. Because $blockData/$resource is not even used in this method. So I could pass anything like null and the method would create an error (when not called in the order you assume) as this->template is not set yet.
in which programming language comes or before and?
Here are all methods of the Twig extensions to provide extension points: https://github.com/fabpot/Twig/blob/master/lib/Twig/ExtensionInterface.php#L29 And all these can also be registered directly. So this implementation is incomplete
This is really important as you are currently breaking everything for people not using ldap.
typo: OPTIONS
no need to use ``else`` here as the ``if`` returns
Where is the opening of this </li>?
if the JSON is empty or has wrong format ```NSDictionary *userInfo = [[JSON objectForKey:@"params"] objectForKey:@"params"];``` can raise an exception
problem is that `AFJSONRequestOperation` does not accept "text/plain" mime type
Этот метод надо перенести в коллекцию эвентов.
Would it be a duplicate of FreemanChain::turnedCode() ?
kDocFont should not fall through to QPlasmaDevModeDat -- you should probably move kDocFont after kDocDevMode and leave the TODO comment in its body (allowing it to fall through to the default/NULL case)
Not really. Will remove.
My concern was not so much the if-else, as that it seems a little strange to have to know the exact contents of the hand when all you want is "they discarded _everything_"
I think this makes it easier for libraries without access to drupal experience, to add a field and have it rendered if the default rendering turns out to be acceptable.
Besides I can't see the harm.
Maybe it is a bit slower, I suggest a benchmarking it. Though, I don't think I will find the time to do it.
Furthermore: http://munich2012.drupal.org/program/sessions/real-data-why-your-intuition-isnt-trustworthy :)
Perhaps put the `ask_wizard` in a while loop until they give valid credentials?
If we're actually going to accept this change then why comment out this line instead of just removing it altogether?
Ok, but not that you are casting a byte to an int and then back again. Ah and you might want to check the other enums, change byte <-> enum conversion to getXXXByValue(..), I used other method names. Also, the enums might want to be in their own class files.
Yes It's confusing for everybody since its not very intuitive, let me try to explain:

This is actually how you configure persistent file-store in Infinispan. The purpose of this cache is to (also) store all sessions in the file store and have them available upon restart. Purge configures that the cache won't be started emptied on start and in combination with setting passivation to false, all sessions will be stored in the file store. Actually, the classic passivation as we know it (from say HA profiles) does not make sense here since all the sessions are passivated on the disk already! :-)
Almost right :), unassigned should come first, so move `helper` up.
this is not needed any more no? actually was removed from the code when the ordering landed in the backend
I don't know where the file gets stored by the bluetooth module, but device storage uses /sdcard as its root, so you don't include that in the path.  I'm hoping that gecko uses a capital D and strores files in Downloads/ instead of downloads/. But that doesn't really matter.
I added to utility_tray.js 
I removed the  window.removeEventListener('appopen', hideTray);
and now it works
Oops, here's my bad. Should be moved to only `attentionscreenshow`.
Official options here would be 
```
<script defer>
<script defer="defer">
<script defer="">
```
not sure if defer=defer is a standard. For consistency with the rest of js files, I'd use <script defer> anyway
That .split().pop() trick is sweet!
What about this:
<code>nav[data-type="sidebar"]</code> - for sidebar 
<code>nav[data-type="sidebar"] ~ section[role="region"]</code> - for main region and 
<code>nav[data-type="sidebar"][data-state="visible"] ~ section[role="region"] {
  transform: translateX(80%);
}</code> to show the sidebar?
Hmm, I’d prefer to keep the old markup here for now:
* the `role="dialog"` attribute is meaningful
* without a parent `<section>` element, this `<h1>` element is incorrect (because it isn’t the main title of the whole document)

This should either stay a dialog box (and we'll apply the related building block when it lands) or be changed to a standard panel. I think the first one would make more sense.
You use this.getMessages(ThreadListUI.renderThreads) for rendering the ListUI page but ThreadUI.renderMessages(ThreadUI.filter) for List page, why not sync theses two rendering behavior?
Do we want to add convenience method for composite metrics? _metric = context.registerMetric("foo", new CompositeMetric(), 5);

The interface would be ICompositeMetric { void doRegistration(TopologyContext context); }
Thankfully, making the order of `$supported` significant only serves to specify unspecified behavior in the other implementations (it doesn't actually "change the rules", it just "makes a new rule"). I haven't tested other implementations' behavior as far as what happens when there are ties, but I wouldn't be surprised to learn that there are already inconsistencies between them.

Thanks for reviewing/merging, and again sorry that I handed this over to you as one big fat blob of changes. In the future I'll try to submit more atomic pull requests. :smile:
I update dependencies in MANIFEST.MF and feature.xml: https://github.com/skyluc/scalatest/commit/2a18319e49fb480400954df47c24d2428ca7c6a7
Why go through the buffer-list potentially twice? Isn't easier to just do a mapc and kill all matching buffer the first time around?
eg:
(mapc #'(lambda (buf) (when (string-match "bla" (buffer-name buf)) (kill-buffer -buf)))
Ah, true, I was assuming commutativity, which I shouldn't have been. That'll make the code uglier :(
Maybe a comment to explain this:
/** This Source writes out the TupleEntry as a JSON map. Probably only useful for writing, on read it is identical to TextLineScheme
 */
Close the file once you're done with it.
Comment why you do this `zfill`.
You should change this to `L.latLngBounds` (the one you used is a constructor, not a factory method).
Ah right it was because of `Error: Invalid tag specified.`.
`data` -> `form`
Done. Also I slipped in #64's resolution in between.
These are static to avoid excess object creation.
Doesn't debugkit almost always run in debug mode?
Can not remove this function, it is needed for js-binding.
Because js-binding can not generate binding codes for the function that has default value.
Btw, a method with a return value of ``string|false`` is weird. the value meaning "nothing" in PHP is ``null``, not ``false``.
I realize, but I don't think we have to care about that given that this feature is almost only used by Sf2 bundles at this point. I don't think any non-namespaced package will need this, but if it comes up we can always fix it. I try to focus on what brings the most value these days given the amount of work there is.
this is not enough. You need to handle underscores in the short class name to be PSR-0 compliant
True! Since you plan on using the script, can you issue a PR for this?
On 28 June 2012 16:37, Ian Darwin <
reply@reply.github.com
> wrote:

> >
> > -    <para>The term rule engine is quite ambiguous in that it can be any
> system
> > +    <para>The term "rules engine" is quite ambiguous in that it can be
> any system
> >      that uses rules, in any form, that can be applied to data to produce
> >      outcomes. This includes simple systems like form validation and
> dynamic
> >      expression engines. The book "How to Build a Business Rules Engine
> (2004)"
>
> Thanks for your multiple edits. SInce at least one is an edit to my edit,
> I presume (I'm new to this process) I should:
>        1) Cancel my pull request, and
>        2) Apply your changes, commit, push
>        3) Make another pull request.
>
> And, do you have commit privs or are you an outside commenter like me?
>

I think that I have, but have never exercised it. We can let this pull
request happen, and
then I might clean up.
-W


>
> Thanks
> Ian D
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/droolsjbpm/drools/pull/125/files#r1068173
>
I think this indent level is a bit much.
Note: `@env['REQUEST_URI']` isn't same as `@request.path_info`, because the latter doesn't include query string, but in this case I think it's correct to use this one as typically git clients send POST like `/test.git/git-receive-pack` (without query string)
For the simple reason why: "dir/sub/" is often the same path as "dir/sub". But I can remove it.
We're selling ads that probably about 10% of users look at, and that's why they're 10% of the price of the ads at the top.

The model may change in the future to viewable ads, and there are some tests going on, but right now, that's how they're sold so we will keep that switch off for the timebeing.
Can't call ```repos.splice``` inside of loop through ```repos.length``` because splicing (in this case removing an element) changes the length of ```repos```, therefore not all elements will be iterated over.
Kindly do not abuse the include tag ... its meant for including templates, not static files.

The reason behind it is simple. *Every* time a page is requested, those static files will have to pass through the templates compiler. Since static files will never contain template tags anyways, it will unnecessarily slow our app down.
Where is this method used?
The example is wrong; it should be `gist'`.
Nit: maybe this closure can move to the top scope ?
Here and at `sys.exit(0)` line, it looks like you are using 2 spaces indentation instead of 4 (we have bigger indentation in python)
so dirty it makes my skin crawl.
Scratch that comment, the type comes in from info, not the record.
On Debian systems, you can use "editor file.ext" to open up file.ext in your preferred editor. This might be a good way to phrase it in the docs if it also works on other distros.
Having subclasses override a property like this is effectively the same as just having them do `LOCK_FILE = "populate_summary_cache"`, and the latter's a lot simpler; if there's no calculation or instance-level variation going on I don't think the property is useful.
I put it into datazillamodel and broke it out, renamed flag to claim_rows
Agreed. We don't need a lib at all probably, but rapid prototyping yadda yadda. I'll remove it.
mmh, really?
That's true, and it leaves these methods untested without the library installed.  Given this commit's already in master, what procedure would you suggest?  Shall I follow up later with another ticket after to stub out the library and move them to acceptance tests?  I could also follow up with another commit on this branch to change them to stubs and then that should merge in ok to master.
I chose `NoMethodError` because when the resource type doesn't exist, then a method that allows creating it doesn't exist too. On the other hand `InvalidTypeError` is more informative. I'll update the code.

Also thanks for finding the typo.
Schema is the name of the schema to associate with the index.
Also, OS X apparently takes ``RLIMIT_AS`` as a suggestion, not as a hard limit (from the previous codebase). This might also occur for other resource limits, I don't know.
It would be nice to use functional interface rather than a variable ''udev_rule's', but I don't have any strong opinion at this stage.
`Module`
I'm not sure this will do what you think it does. If the peering manager can't retrieve the instance, we need to try and create it locally. Maybe I'm reading the diff wrong, though...
I'm thinking we should do the same as we do with route and dispatch, and create a Zend\Mvc\RenderListener that encapsulates this. It'll be more consistent, allow swapping out internals more easily, and keep the functionality more readable.
Hmm, probably `RangeException` would be a better fit in both cases
If it ain't broken...don't fix it ;)
Yeah, I just copied some code I found online for that part >.<  Looks good to me!
I'd love it if you'd write a unit test that exposes the issue and shows how this fixes it. Having said that, I didn't see existing tests for this method so I'm ok either way. :)
Agreed with @Afforess
Your name ^

And remove the Getting Started and Need Help.

- Also add in a short description of Ember.
- How to run the tests
Just do `for iterm in result`.
you should check if the previousUser is different from the current user. Otherwise, you will do 2 useless DB changes as the second will revert the first
you should keep a empty line before ```if```

```php
<?php
$this->identityMap[$targetClass->rootEntityName][$relatedIdHash] = $newValue;
// empty line
if ($newValue instanceof NotifyPropertyChanged) {
	$newValue->addPropertyChangedListener($this);
}
and here $documentClass = null
This is already cached, so you don't need to search the DOM again:

this.tableView.$element
true, it was to avoid having to call the closure several times, but realistically speaking it is unneeded micro optimization.
Is it OK to introduce a dependency to paycheck here? (http://pypi.python.org/pypi/paycheck/) I cannot get setup.py to install that as a dependency, so this is not present, it will fail horribly when importing this module.

Proposed test:

~~~~

class TestNub(unittest.TestCase):
    """Test for the nub function."""

    @with_checker([int])
    def test_nub(self, list_of_ints):
        nubbed = nub(2 * list_of_ints)
        self.assertTrue(len(list_of_ints) >= len(nubbed))
        for (x, y) in [(x_, y_) for x_ in list_of_ints for y_ in list_of_ints]:
            self.assertTrue((list_of_ints.index(x) <= list_of_ints.index(y)) == (nubbed.index(x) <= nubbed.index(y)))
~~~~
why is there an http method for the API and then an https one ? Wouldn't it be better to use https in both cases ?
if the content is ``null`` (possible according to the first check in the method), this is broken
I didn't edit much of what was there. I agree about "as such". Changed it to read: "An example MDB will dequeue this message and print the following contents:"

This also doesn't make any sense: "a message is produced container the details of the user"
I believe they meant: "a message is produced containing the details of the user"
I think this needs to mention EAP as well.
Is it intentional that we passing the `start` and `end` events into `process_mocha_event`, even though it doesn't seems to be doing anything with it? Perhaps the code would be a little less confusing if we guarded it with an `if/else`.
Change "at maximum" => "at most"
s/_iamge/_image
Please use double quotes for HTML attributes (to be consistent).
What is all of this doing? (docstring would be nice -- but in general I don't get this)
No end of line comma.
You're right. I'll make the changes tomorrow.



On Oct 15, 2012, at 8:12 PM, Ohad Levy <notifications@github.com> wrote:

> In app/models/setting.rb:
> 
> > @@ -91,6 +91,16 @@ def save_as_settings_type
> >      end
> >    end
> >  
> > +  def ensure_values_not_zero
> > +    # set value to default if zero or negative
> > +    # id => 4, name => entries_per_page - if zero, error FloatDomainError Infinity
> > +    # id => 7, name => idle_timeout - if zero,user is logged out immediately
> > +    # id => 18, name => puppet_interval
> > +    if [4,7,18].include?(self.id) && self.value <= 0
> Are you sure ids are always the same? you might need to go by name here
> 
> —
> Reply to this email directly or view it on GitHub.
>
> fnameescape has more bugs that can't really pass to the original argument to command(without !).

Have you raised this on the vim_dev mailing list? If there are really serious issues, I think fixing the function is way better than some groups silently working around it. Maybe I'm not using that many strange file names, but for the most part this works for me just fine.

> This is famous issue in japanese vim plugin developers.

You mean this group: https://github.com/vim-jp? This is interesting. Do you closely work together, or even know each other in person? (I'm German, but married to a Japanese woman, and been to Japan twice.) I was surprised how quickly you (@mattn) picked up my pull request, although it was for @thinca.
Same here, imo this is fine via modules
Yay, more probles are resolved
Should any of these exceptions be logged?   for debugging purposes?
The !! Seems to be unnecessary
Don't use spanish names
Yes, I told you this before
I suppose this could be:

```ruby
@pages = @page_list_manipulators.inject([]) do |result, (_, inst)|
```

But it really isn't a big deal either way.
okay, nevermind then, I'll fix all this in another commit
Do you want to me to put it in a separate controller spec or just remove this assertion?
The reason I did it that way was so we're not outputting a bunch of
{
...
    "mediumPicture": undefined
...
}

to the UI. Having said that, I just tested it, and it seems JSON.stringify removes keys with undefined values, so we can do the shorthands.
I'll change it my next commit
This should probably be 201
Can it done without the pattern matching? it is not really useful here.
Convention is to use uppercase for types, i.e., ``JMap``
Please use current (i.e., 6.1 releases) for examples.
навіщо? тег додається до запису, а не записи до тегу
Deze naam is ook een beetje vreemd.

Wat denk je van `commander` en `character`? Dus `commander` extends `character`?
Needs spaces around the exclamation mark. See the style guide: http://codeigniter.com/user_guide/general/styleguide.html
Don't we leave them alone unless there is a valid reason for change?
No private properties or methods please - that makes libraries hard to extend.
Yes, the parameters are space-separated.

- Timothy J. Warren
http://timshomepage.net
tim@timshomepage.net


On Tue, Apr 3, 2012 at 1:28 PM, Andrey Andreev <
reply@reply.github.com
> wrote:

> > @@ -89,7 +89,7 @@ public function __construct($params)
> >
> >               if ($this->username !== '')
> >               {
> > -                     $this->dsn .= 'username='.$this->username.' ';
> > +                     $this->dsn .= ' user='.$this->username.' ';
>
> Is that space really needed?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/1240/files#r640464
>
substringFromIndex:(arc4random()%3+1) возвращает подстроку с позиции arc4random()%3+1. Позиции в строке считаются с 0, а не с 1, поэтому в результате в DNA будут подстроки вида TGC, GC, C.
А если будет раз за разом выпадать тот же рэндомный индекс? То код будет тут крутиться, пока не выпадет что-то другое. И так на каждом из меняемых символов.
Спасибо за замечания всем! 
Без них бы, я еще долго не обратил внимания на этот тонкий момент
исправлю следующим коммитом
```objective-c
[NSMutableArray arrayWithCapacity: 100]
```
Создав массив таким образом вы существенно сократите время требуемое для его заполнения.
смотри, здесь основное действующее лицо - это ответы. Но находится это в модели вопросов. Мне кажется этой логике самое место в модели answer, еще и пусть вызывается из вот того метода make_right
The [documentation for SHFileOperation](http://msdn.microsoft.com/en-us/library/windows/desktop/bb762164(v=vs.85).aspx) says that `GetLastError()` should not be used. You should pass the return value of `SHFileOperation()` to `ConvertWinErrorCode()`, and also make sure the important errors are getting mapped correctly.
Comment should be updated to say "save" instead of "select" and remove "or directory".
Added commets good, but you've nuked the JSDuck style comment blocks, like these?
@property {Object} act
Rather they were left in
Right, I'm just not sure it's actually useful for sequences. A method to get a distinct sequence, sure, but this seems minimally useful.
Those cases (return types of blocks) have been because of Objective-C's limited type system. When we _can_ type things as `id<RACStream>` without issue, we should.
If there's an error, there probably isn't going to be data to spit out. Consider either returning in the `if` clause, or using an else clause.
Why do you want t index before / during copying? Why isn't it sufficient to
copy and then do the indexing / overwriting as is now?


On Thu, Dec 6, 2012 at 5:31 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
> _data is private so nobody is supposed to modify it, I would just use
> numpy indexing , i.e.
>
> if preload:
>     new._data = self._data[index]
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337217>.
>
>
see the difference between raw.time_to_index and .time_as_index -- you could explicitly put two names there of which one is expected to be a lists and the other a dict.
e.g. event_names, mappings or so. 
makes sense?

On 12.12.2012, at 04:09, Eric89GXL <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> > @@ -866,8 +873,122 @@ def to_nitime(self, picks=None, epochs_idx=None, collapse=False,
> >  
> >          return epochs_ts
> >  
> > +    def equalize_event_counts(self, *args, **kwargs):
> > +        """Equalize the number of trials in each condition
> *args is the only way I know of to have a variable number of input arguments. I figured the docstring would clarify it for people.
> 
> —
> Reply to this email directly or view it on GitHub.
>
I think they're not, but I can check again.
Just add an additional commit to your pull request. No need to make a new one. That's why it's often preferable to put the commits for a pull request into a separate branch, as the pull request will always reference the head of the branch you chose during your request.

Am 20.12.2012 um 09:02 schrieb Stefan Klein <notifications@github.com>:

> In Frameworks/Ajax/ERJQueryMobile/Sources/er/jquerymobile/components/ERQMHeaderBar.java:
> 
> > @@ -1,10 +1,10 @@
> >  package er.jquerymobile.components;
> >  
> > -import org.apache.log4j.Logger;
> > +import org.apache.log4j.*;
> Sorry, need to change my eclipse settings. Should i create a pull request with original imports ?
> 
> \
> Reply to this email directly or view it on GitHub.
>
Aah that's pretty fantastic then, I definitely see what you're trying to down.
You should remove line 29 and 30 and replace the single colon by 2 colons.
It's on my list :)
It may be easier to add the ValidatorExtension here instead of adding the different type extensions and type guessers manually
详细的情况参见<link doc="../hash.xml">哈希表设置</link>。
Ok I see. What would be the exact code to do that ?
case cr: ConsumerRequest =>
  val reply = if (connection.isDefined) Some(newConsumer(cr.consumerParameters))
                     else {
                        log.warning("Unable to create new consumer - no connection")
                        None
                     }
  sender ! reply
agreed - any ideas?
Cuando arregles dale al merge nomás. Si hoy me hago un rato hago el deploy a DEV y el paquete para que Juan lo suba a PROD para que vaya practicando.
Performance? `type()` will always return a string, and all strings are true.
What's the global for?
it says Android 4.1 must be installed but talks about 2.3.3 before... not sure if that is really consistent...
This class would deserve a test
You were already passing the URL into the AsyncTask.  Here, we're just grabbing it out from the params to use it in the asyncTask.

This should be null checked.  I'll leave it to you to figure out what that entails.

The `params` is a weird thing in Java.  It's a passed in array of URL values.  Since you only passed in one URL, we're just pulling out the first URL. (at index 0, so `params[0]`).
Right now it doesn't add value at all. I thought it to display the instrument info + relationships to other concepts.
For instance, to show a list (read-only) of Students using this instrument.
A random number, right? :trollface:
Right way to define path to load asset! 

Having dot removed and replace it with underscore helps when creating package.  Also package can't contain name starting with number so i had to start version number starting with some character which is v in this case.
Yeah, I think it's an aesthetic thing, but if it's called _check I'd expect it to either succeed silently or raise an exception if it fails, while I'd expect a boolean function to take a name like is_valid.

Honestly, having _check_valid and _check_valid_name here's a little confusing, so I agree with a name change.
@danberidei yes it does make a difference for local caches. when this is explicitly disabled (it is enabled by default) we don't add a locking interceptor to the interceptor chain.  So concurrent updates are very un-predictable. I think (this would require more though though) that this would only affect consistency, but I really want to discourage people doing concurrent updates on a cache that  doesn't have the locking interceptor in the stack as this would open a can of worms.
Sure, as we said on IRC.
CacheStatus class is very similar to the LocalCacheStatus from the LocalTopologyManager (2/3 fields in common) - might worth extracting a base class. Also naming-wise: CacheStatus-->ClusterCacheStatus would be more consistent with the LocalTM->ClusterTM "convention"
You could also write:
`} catch (SuspectException) {
   // Ignore SuspectExceptions - if the node has gone away then there is nothing to invalidate anyway.
} catch (Exception e) {
 log.failedInvalidatingRemoteCache(e);
}`
BTW we should NOT use `log.isInfoEnabled()` in such a case as the log level is defined in the log interface: DRY
These should be `BOOL`s and use `YES`/`NO`.
This needs to zero out the `delta` property of any hunks.
watch out when doing asarray().  We support masked arrays, so it really should be asanyarray().  Although, admittedly, in this context, it probably makes no difference.
This line is making the test_colors script fail.
I think it would be better to rename this file to something like ```test_rcparams.rc```.

Additionally, it might be worth mentioning inside the file that this is only used in the ```test_rcparams.py``` tests.
No, because the bins argument to histogram expects an array with all of the boundary values, from the minimum value of the first bin, to the maximum value of the last bin. The resulting histogram has len(bins)-1 values, so passing an array with 257 elements results in a histogram of 256 elements that counts the number of values of each byte.

`np.arange(256)` would mean that the 254 and 255 values would be merged into a single bin.
If the test is removed, you'll also need to remove this method because it's no longer used
If you'd borrowed this from another repo, I'd say you should add that repo as a submodule. Since it's not, it's a wash either way. Are there tests for this somewhere?
Can you just put a custom message here? `message='Picker container was not displayed`  . We do this because the default messages for assertBoolean are pretty useless, ie Expected True got False.
Custom message with the name of the case it is trying to locate. As it is now you can't tell whehter it's the 1st, 2nd or 5th or whatever case that has failed.
Почему бы и нет, к примеру DBTransactional, также в диалекте реализовать эти методы и вроде как бы гуд должно получится :-)
what use has an empty constructor here?
isn't this just `map flatten`?
Great catch! Fixed in 14bf308
Just confirming that we're silently ignoring an exception here. If that's what we want, cool, but maybe let's add a docstring here that explains why we can safely ignore it. Otherwise we should totally man handle this exception.
Intentional comments?
What is the significance of the 1000000? It seems like magic to me.
same here - just use Linear
please add a newline before and after the for loop
provides instead of provide, minimises (I'm assuming en_gb over en_us, otherwise minimizes) instead of minimize and needs instead of needed. With docs, present tense usually reads the best.
What's the meaning of -1 here? What is correct_state doing?
does this introduce steps that need to be taken before a merge into wpm can be done? If so, this is probably a really bad idea (anything that gets in the way of "update friendlycode pointer and it works" is probably a change in the wrong direction)
Was this intentionally changed to package private?
This is a pattern to prevent serializing objects that won't be logged, maybe the original author thought Query.toString() would be slow/expensive and should only be run if the message is definitely going to be logged?
Awesome. I'll make a note to add unit tests for categories stuff soon
This is an implementation detail and does not belong on the interface.
Because I use `test` variable in `forEachNoCallbackIterator` for doing `test.equal(x, 1);` and `test.done();`.
Do you want me to remove that code for now?


On Thu, Nov 15, 2012 at 10:45 AM, Philip Schatz <notifications@github.com>wrote:

> In css/ccap-biology.less:
>
> > @@ -361,9 +361,11 @@ div.section .titlepage .abstract {
> >
> >    .solution { display:none; } //hide solution in this feature
> >
> > -}
> > -
> > +  &.span-all {
> > +    img { min-width: (2 * @column);}
>
> My concern with that is that if the image resolution is too low the image
> will be stretched out (I don't think that was their intent) and the
> solution would be to upload a higher resolution image (and min-width would
> never be triggered0.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/29/files#r2140997>.
>
>
Is it possible to add a ``@param`` annotation for parameter ``$expectedHost`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
Should the type for parameter ``$container`` not be "AbstractContainer|null" instead of "AbstractContainer"?
Should the type for parameter ``$manager`` not be ``EntityManager|null``?
TableViewSection hasn't been worked on yet.  I should not be executed on BB.
This is a good idea, and I forgot about this until now. Thanks! I'll add the other contributors too once this is committed.
the indentation should use 4 spaces, not 2 spaces or tabs
I just didn't see a need to offer chaining here.  By all accounts `execute()` would be the last link in any chain.  After the router has been executed there is really nothing else left to do.  Do you really think that's useful?
Yeah, they look great! Thanks.
We should consider making a Filter (builder) helper and then doing a `.filter = filter.toString()`. That would simplify and make the code a little more readable.
http://msdn.microsoft.com/en-us/library/ie/ms536350(v=vs.85).aspx
The clearAttributes method clears only persistent HTML attributes. The ID attribute, styles, and script-only properties are not affected.
Can't rely on a timer for this. If aReason==APP_STARTUP, listen for a new browser window to open (listening for domwindowopened, via Services.ww.registerNotification) and load. Otherwise, just do stuff immediately.
First the Coding Standard is wrong here.

The fsockopen is used because it is faster than any other option, and this does matter when you are checking on stuff like images exists server side.

Also i think that the proxy thing should not be done in the code but server side or in with some custom code by extending this class and overwriting it.
This is not an action, it's a title. It should be "Co-Autores Activos"
spaces around = pls :)
Request.Form["token"]

Can this change to `token` from the action parameter?
What happens if the MV fields have a "\n" as part of the field?
=> is automatically set based on whether SonataDoctrinePhpcrAdminBundle is available.

please also replace SonataAdminBundle with SonataDoctrinePhpcrAdminBundle above.
As-tu rencontré des erreurs avec le code de cette librairie? Comme elle n'est pas issue du bilboplanet ce n'est pas mon code. Mais je suis étonné car je n'ai pas eu d'erreurs jusqu'à maintenant
Empty line between subscribers and TODOs.
Haha, me neither I never even had it open. Will fix it back. The problem was I didn't sync igypigi's fixes, and than there was somekind of bug in Github for Mac and it crashed in the middle of commit , ...
Not our bug, that is just how tastypie works (currently object is always none; nowhere in tastypies code is is_authorized called with object argument).
I replaced is_authorized with apply_limits which is more suited for this kind of work.
Good. Just please use `blocktrans` tags for such long passages of text.
Set `allowed_methods` to `()`. The idea is that we try to not expose user objects, but still allow referencing them.
It seems they are named *OpenHours*.
Is not `authi.request_token.key` == `settings.CONSUMER_KEY`? And `authi.request_token.secret` == `settings.CONSUMER_SECRET`? Why store this into session?
Don't remove the fails_with_llvm unless you've tested it on llvm-gcc build 2334 and it builds, and don't add `depends_on 'llvm'`, the llvm formula is not the llvm-gcc compiler from Xcode.
I also have doubts about this, not only creatures can be vehicles, players can too.
Swap checks to avoid unneccessary lookup
i think this place is not so good, we should update the realmid for db appenders on sLog->SetRealmID(realmID);
your change will destroy all appenders/loggers and create new one
Just add new commits and push to the branch and it will show up here ;)
Should be: var dictionary = values.ToDictionary(key => key[0], value => value[1]);
move this to outside the case
Yeah, let's postpone until we have specific examples, and we can start a page of recommendations at that point.
Exceptions are expensive (http://developer.apple.com/library/ios/#documentation/cocoa/conceptual/objectivec/Chapters/ocExceptionHandling.html), although if we think it'll be cleaner we can do that.
Good one, it's simpler now.
`which enables` ? you should mention it's enabled when set to true, or I'll assume I just have to specify any value. Don't copy paste from previous entry, as this one has different behaviour..
That's cool, just curious!
reopening Module makes me uneasy - I'll bet we avoid doing this?
web.py  haven't been used since the development of pysilhouette started.
It seems like a code smell having to mock this out (if you have to, it should be a stub)
dbpedia specifies entity URIs as well as linking to the wikipedia "topic
pages"

m.

On Thu, Sep 13, 2012 at 6:18 PM, Peter Ansell <notifications@github.com>wrote:

> In ns.php:
>
> > @@ -72,6 +72,7 @@ class CNamespace
> >  	'dip'       => array('name' => 'Database of Interacting Proteins','url'=>'http://dip.doe-mbi.ucla.edu/dip/Main.cgi'),
> >  	'ddbj'      => array('name' => 'DDBJ sequence database'),
> >  	'dpd'		=> array('name' => 'Health Canada Drug Product Database','url'=>'http://www.hc-sc.gc.ca/dhp-mps/prodpharma/databasdon/index-eng.php'),
> > +	'dbpedia'	=> array('name' => 'DBPedia', 'url'=>'http://dbpedia.org'),
>
> How do we feel about using the namespace "wikipedia" instead of "dbpedia"?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/micheldumontier/php-lib/pull/14/files#r1603078>.
>
>



-- 
Michel Dumontier
Associate Professor of Bioinformatics, Carleton University
Chair, W3C Semantic Web for Health Care and the Life Sciences Interest Group
http://dumontierlab.com
Yes, looks like a shortcut
предлагаю вынести в enhancement request
I was wondering how you did this. This is really nice.
I commented that because I thought it was useless, you need it?
You really shouldn't declare a variable without using `var` - can lead to all sorts of scoping problems.
there was bad old code left in HttpPollHelper, just pushed a fix
LOG.warn?
In general it's good to add new stuff in pure-java rather than groovy these days. Unless there's a reason that would be hard in this case?
Yep. I missed out the scrollTop! I'll see if I can fork this again and do this without so many dirty commits.
Yes, local hoisting. It benched a little better, though I only tried that change alone a time or two, and there's some variance. Should probably hoist `unicode` as well; just missed it.
This file is duplicated. There is a `spec/spec_helper.rb` and this one (`spec/spec/spec_helper.rb`)
This will spawn a thread every time a Url drawable is set. This could results in hundreds of threads being temporarily spawned, for every image shown. Thread pool may be more appropriate here, but preferably maybe only even do this once by moving the hasCleaned check to the outside of the thread creation.
You probably don't want your token in here!