labofsahil/github-event-dataset-2012 huggingface dataset:
Very nice.  Much more declarative and a good way to work around the lack of pattern matching.
Are you Nexus?
This thing has some serious problem, if you want to use it for privacy stuff.
You can still quote the posts to get the text, you can still pm the author based on that post to get the text. The text is displayed in the search.

It has almost the same problems like the forum-password feature.
> Replacing std::vector with std::map is not a good idea when we have possibly tens of thousands of files. You switch to less efficient container types for what gain?
I replaced one std::vector with a std::set, because we often do std::find operations on it.
I replaced one std::vector and a std::map with a single std::map. So I removed redundant data. There was a map before, containing as much elements as the new one. (Similar replacements in testrunner are related to the initial change in checkexecutor)

> Which brings me to the point that some of the commit messages are rather vague or ambiguous to what they actually change
I'll try to improve my commit messages.
You can specify the binstubs directory too: `bundle install --binstubs=exe`, but I already have "bin" in my `PATH` :)
I suggest we default it on bundle registration.

On Sunday, February 19, 2012, Phill Sparks wrote:

> The only problem with putting that in the bundle config is that it's
> up to the **app developer** to set it correctly not the _bundle
> developer_.  All the other config options are config for the app
> developer (location, handles, auto).  I guess choosing not to include
> it is a choice for the app developer, as long as they know the
> consequences.
>
> On Sun, Feb 19, 2012 at 12:57, Taylor Otwell
> <reply@reply.github.com <javascript:;>>
> wrote:
> >
> > I think it might be nice to have a "namespace" option in bundle config.
> That way we don't have to do all that guessing in auto-loader. I'll add it.
> >
> > On Feb 19, 2012, at 5:v28 AM, Phill Sparks<reply@reply.github.com<javascript:;>>
> wrote:
> >
> > > Why?  I liked this feature!  Now you have to start eloquent (and
> others) before you can use them - I'd rather not ('auto' => true) these -
> that's not the point.  And having to Bundle::start('eloquent') in every
> model just isn't elegant.
> > >
> > > Do you have a suggestion for how to register bundle namespaces?
> > >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/laravel/laravel/commit/f41717dcb195ae3bc400e8da660ae7410b2204fe#commitcomment-982466
>
hehe passiert ^^
a general rule for jQuery coding standard is that variables without any value goes together on one line, but variables that get some value assigned should go in a separate row

http://docs.jquery.com/JQuery_Core_Style_Guidelines#Assignment
@xarly no es tan grave, en el comit 1600 iba perfecto, unas 20h on...pero se metio algo y se jodio todo, pero esta muuuy estable ya, antes iba peor...
По моему лучше-бы откатить этот коммит, пока не будет до конца ясно насколько он здесь нужен, а то со всякими разными системами автообновения... потом проблем проблем не оберёшся.
here is the table with those info from previous comment
http://www.gamingconsortium.org/gotisch/table.html
we had that forced crash a few mins before 17:00, so it was lagging at 16:45 too already
+1 undergarun about transports :S
http://pastebin.com/dM83Jzqg
or `{% trans %}`?
qui stavo iniziando ad associare le immagini al termine in base al nome - Mauro.
行末不要留空格。
van a soñar conmigo y las migraciones jajajaja
@vicb I know it is not strictly equivalent. But the tests never pass ``null`` AFAIK. The default value is only there to make it optional to pass an empty array.
I dunno why, but it seems like a bad practice to me. Will have to check how to improve it.
I think root should be removed after all other users be removed
A Prob
 You have modify the sdcarddetect. for the Ramps
 1 you added SDCARDDETECTINVERTED 
2 and added the Pin31 for the SDCARDDETECT
 3 and make the Pin 33 for the Beeper

The in old Version works SDRamps whisout you inverted SDCARDDETECT and NOT an SDCARDDETECT
Many elektronik people make a little Wire on the SDRamps and you have an real SDCarddetecd on the SDRamps, you dont need not  inverted the Signal
The best way is ask in the Firmware HAVE you have a little Wire on the SDRamps or not, whe you have a Wire NOT invertet the Signal, you have not a Wire the inverted
An the Pin for the SDRAMPS Carddetect is Pin 49 !!,  not 31  

This ist not the best way
 1The best way is NOT INVERTED the SDCARDDETECT !
 2 Pin 49 for the SDCARDDETECT !!
 3 and make the Pin 59 for the Beeper 

Only you must make an little Wire Bridge only of the SDRamps from the Cardslot to an pad of teh SDRamps and the Carddetect works very well, when plug the Card inside or outside the Cardslot and you see on the LCD 

Thanks 

Hardwarekiller
had to update aether as well to make it all compile
You use pwds in cgroup_common.py on line 111. etc. And you add again '/'. One of these '/' is not necessary. 
May be you should use os.path.join("path1","path2") if you concatenate two path.
Again minor mistake, because cgroups are only on linux.
Why you're welcome! :D

PS-- Not sure if you've looked at the [Hydrogen MVC Starter](https://github.com/TomFrost/Hydrogen-MVC-Starter) recently, but there's now a way to put your autoconfig file inside of your codebase, rather than inside of the Hydrogen library folder.  It's not a huge deal, but the main benefit is that you can add hydrogen as a submodule to your project without it complaining when you change files, and you can fork Hydrogen and submit pull requests without worrying about your custom autoconfig coming with it.  Your call, though :).  If you like the idea, just drop this in your code somewhere before you require() hydrogen.inc.php:

    // Obviously change the path to whatever makes sense in your codebase -- you can change the filename too.
    define('HYDROGEN_AUTOCONFIG_PATH', __DIR__ . '/../../config/hydrogen.autoconfig.php');

Cheers!
With this new way of rendering, I got rid of the purely immediate-style drawing of widgets. Instead they are all stateful now meaning that you have to tell them when you want them to be drawn or not. It makes sense, because in almost all cases you only have a single GUI instance and it only renders to one target ( the main window ). All objects in the GUI are part of it and there should be no reason to manually draw each widget by itself because that's what the GUI is there to manage. It might seem strange after using SFML to draw for so long, but this is the more efficient and GPU friendly way of rendering. If you really need to draw single widgets themselves, you could still manage showing and hiding them with Show() and calling Display(). You would create something like a window with no style to contain widgets that should be shown together and hidden together and control whether that window is drawn or not. I must stress that this method of drawing is NOT RECOMMENDED, and performance will suffer horribly. As such you really shouldn't draw this way in production code. I might consider allowing attaching separate instances of the renderer to widgets to be able to control the rendering more, but the whole idea is to reduce the API overhead as much as possible and in that sense this would only be useful in cases like yours where you want to draw single widgets by themselves. I'm just wondering, why do you have to render a single widget by itself instead of everything together? If it's because you use one view per widget, I will add support for custom views per widget as soon as I have more time, as part of implementing Viewport drawing again.
Sorry, this shouldn't have made it in
Please don't use qsort on container classes, this defeates the abstraction level introduced with containers. Use Common::sort instead, which actually gives you the same guarantees as qsort.
Yeah I just saw that... sorry @arthur-debert
je pensais que github envoyait un mail à la personne qui avait soumis un pull request ?
sinon tu peux t'inscrire sur la mailing list dédié au repository git (dolibarr-git) afin de recevoir toutes les notifications, pour le moment elle se trouve encore sur savannah, mais je vais faire une annonce pour utiliser dorénavant celle de Doliforge :

actuelle : https://savannah.nongnu.org/mail/?group=dolibarr

prochaine : https://doliforge.org/mail/?group_id=144

tu peux t'inscrire sur les deux en attendant.
Is we need this class? It duplicates the functionality of RazorPower class.
Psst don't you mean 0x1FFFFF, unless of course you want to 0-out everything :)
why did you check in "hello world" message? is it for test?
Partials are available inside views. E.g:   'main_eco', 'main_myview', etc.
Unfortunately, i'm not narrowtux. So I can't do anything about the main code base.  I've been following your fork because I'm trying to get it working on our servers.
Take a look at the implementation in https://github.com/dain/galaxy-server/blob/master/galaxy-shared/src/main/java/com/proofpoint/galaxy/shared/FileUtils.java
curl https://dl-ssl.google.com/dl/googlesource/git-repo/repo > ~/bin/…

…repo

repo init -u git://github.com/thekraven/android.git -b gingerbread
repo sync -j16
Hi have you fixed the problem? This function would be useful for me coz recently I encounter a stardict dictionary which contain images and it didn't work in goldendict...
What are the advantages? I thought glut gave you more control.
But how do we handle this regarding breadcrumbs and the like?

- Check for at /wiki menu entry and use that if available
- Add a setting and an optional wiki_frontpage module which enables this
So this change here broke the compiler, because it turns a type parameter `T?` into `T&Object` which we don't have the logic to handle. The question is: is this the proper behaviour?

@quintesse: this is the reason for the failing Bug242 test after your merge.
hack by vlad, rewritten by nerv
This is the wrong way to do this. We don't want to make the core functionality more complex to support a niche utility found in Tools menu.

The right way to do this is to do the watermarking as a post-processing step.

Since we don't really want to implement PDF reading and modify the raw PDF contents, the right place to put the post-processing in is after we have a pml.Document and before we call pdf.generate on that. The post-processing can then iterate over pml.Document.pages and add/modify the pml operations on each page as it sees fit.

So:

1) Add generatePML function to screenplay, where all of the code from generatePDF goes to. It returns pager.doc.
2) All generatePDF does is:

    return pdf.generate(self.generatePML(isExport))
3) The watermarking post-processing calls generatePML(True), post-processes the returned pml document to add watermarking, and calls pdf.generate itself.
Since all of the requests are going to api.twilio.com, you could probably ship only our certificate and do fine.
Shouldn't this be deleted?
> It's the nature of decorators that they are closures: They must return what
> are essentially lambdas.

That's only true for parameterized decorators, which this is not (anymore).

    $ cat foo.py
    def deco(func):
        print "DECORATING", func
        return func

    @deco
    def foo():
        print "FOO"

    $ python foo.py
    DECORATING <function foo at 0xb73d63e4>

cf. http://www.siafoo.net/article/68
The y>400 and y<400 you have here miss the (common) y==400 case. In stock scummvm, we have y>399 and y<400 as the two cases for high-res and low-res layouts.
perfect work!
Yes I understood you, but I thought that is better comparing to None, because If  None, will use is_sensitive parameter for block button too.
If you set it as default to False or True, you can't to this,.
The netname will never have unicode characters, libicecc doesn't support unicode characters, so we don't need the  QString overhead, better to stay with the QByteArray
Why did you had to rename the system API functions? Is there a naming conflict?
@d0ru: btw -- you aren't Teodor the one who who filed http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600272, aren't you?
Have a look at 4b0e8c916b9dac14ee5131725ae503eb15369084 - i removed the need for the extra function and touch of a file.
ugggglllyyy!  but I can't think of a better way to test this right now.
it is working?
I suppose I should not host MooTools from my personal server for final release.
hi any body
Yes. Those are pretty awesome. @Immutable is also great annotation for example if you are creating mayby something like cache keys or something else non modifiable :)
Now your SwissPostCode.groovy looks nice. No more boilerplate.
Can we put this in a constant or something to avoid duplicating with the context setup?
I can bring my interface up in `ip` and still have carrier contain "0" and operstate contain "down".

    # ip link show up dev eth0
    2: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN qlen 1000
11.61 r1250
OK, I had the "default" dependency in, as I thought one would dump the stuff to default, and then depend on it.
Sort of a lib/util dump. :-)
I did some work on brush rotation a while ago, https://github.com/jacksonmj/The-Powder-Toy/tree/experimental-brushrotate

I got particle creation and render_cursor working, but wasn't happy with the user interface for setting brush angle. Interface is one of the messiest parts of powder toy, so I eventually got distracted and forgot about it.
when this all gets tidied up, it'll probably be useful to have a *catalog of events* similar to what's here 

http://documentcloud.github.com/backbone/#FAQ-events
This also changes the P4/P5 classification. Lou and I decided that P5 means that "dual core or more".
What kind of hosting environment are you on? IIS?
same code block with imagePinProperty in both **if** and **else** statements. could be optimized to one statement after the if-else.
+1 on the changes to solve leaking connections. I haven't looked at the pool shutdown code.
Up to now I'm pretty sure that what happened was that the backend thinks it's equivalent to a ceylon `Character`. So it will treat it as an erased `Character`, which is `int`. And because in Java you can assign a `char` to an `int` it all works out. If it needs to be boxed `Character.instance(int)` will be used which at least gives something usable.
The problem of occurs when we need to generate an override or an interface implementation. I have no idea how Stef thinks to handle that, he hasn't explained his new idea yet :)
Thanks Shauren.
closes https://github.com/TrinityCore/TrinityCore/issues/1485
Why `_id` btw?
I rewrote it...but I don't think we need to mention who did what in source code. If you really want to know that one one can use git blame.
Yes. Also, line 55 is probably redundant now.
Very good that you use a "realistic" message!
I originally kept support for Permissions because I used it on my own server until a few months ago. Now I have to keep it because PEX is a terrible permission handler, and unless I use the bridge, it doesn't return accurate permissions.
I this one fixes also the issue with arcane blast and other AOE effects?
Fixed by 04bdf9ebe88a75c2286cd873c889c3924b17ecb1. Thanks!
Oh. Sorry. Then just dump my request! :)
Is it browser compatible?
That has nothing to do with this commit
Ooops, thanks.
Yep, definitely, I will add a comment
Dieses Programm ist im moment noch sehr mit vorsicht zu genießen und Handlungen sollten wohl bedacht sein
This was before I took over Loader and made the `resolve` method that works so much better than this hack.
You'll notice that I originally had it so that ajax downloads of ROMs were done via base64. This was done foe IE9 compatibility, since IE9 has issues with binary ajax transfers.
I just saw my patch would return invalid IPv6 addresses, if their last four bytes are IPv4-adresses:
`::ffff:127.0.0.1` is `::ffff:7f00:1`. This means, you could change it to `::ffff:7f00:0` to get rid of the last two bytes.
`::ffff:192.0.43.10` is equivalent to `::ffff:c000:2b0a`. This means, you could null `2b0a`: `::ffff:c000:0`. My patch would create ``::ffff:0`, which is invalid (two bytes missing).
Should this comment go away? I'm not seeing any code that it would be referencing (after checking Google Translate, that is ;))
This fix, actually breaks applications where you have several routes that finish with the same name such as /admin/items, /user/items since the functions that generates the ID is only considering the last keyword after the slash.
sdfdsfas
Do HDMI work with AOSP ICS or is the device/motorola/triumph to blame?
Kyle explained that this was most likely just accuracy problems due to large timesteps.
**Set**GlusterVolumeOptionCommand
this sysfs needs to be corrected/fixed to take into account the "use_for_scaling" option in the "acpu_freq_tbl" structure, else u will see frequencies which are disabled (use_for_scaling==0)...

for the fix refer to this patch:
https://github.com/DooMLoRD/Xperia-2011-Kernel-2.6.32.9/commit/cdda2cdf82ce35ccd0432b1a0cbc4a59b821fe3a#diff-6
The warnings are okay, the other one is not
Please help me with cooper;)
I dont thin in what can be problem(I add kernel and init from working kernel by anonimus) But it still not working(
Maybe we should add a slider here or two for Max/min speed.
Added virtual,
but it needs to be public to implement the new methods in the interface IWindowFrameEventSink
agreed,  see comment above
Not in all places, only when you want a shallow copy or a new object.
in-line styles are "BAD"... absolutely not something we want to be promoting or encouraging developers to use or depend on.

While I'll accept this commit for initial implimentation, we REALLY need to move towards creating and maintaining a custom per-application CSS mapping that we generate during serialize steps, like for layout, code and live views, as well as on export.  Then, these additional style attributes become available to be changed via CSS editing rather than adding more and more properties directly to the widgets.
we don't typically do the inherit doc
Typo: Jacobi
Because I haven't implemented parloops that only have a matrix argument
Thanks a lot! Should have read the InputStream doc more carefully - will fix it.
fixed that optimization
Use JavaConverters instead
Fold config into a one liner.
This is also giving me the creeps: need to look more closely how long exactly it might be spinning.
hmm? I thought our style was the previous version?
I'd prefer something like: tryInitializeSSL (dropping the _?)
Ok. I think we solved it during lunch.
like a bouce
Yes quite confident, the only thing that can go wrong is registration, in which case the actor is stopped and never goes into service
Shouldn't we include the ActorSystem name here?
I'll see what I can do, perhaps just take the url of the current page and add as site
Some day someone will either add some code in there or refactor it to be a method call instead...
Putting try-fainally is just a very cheap way to ensure structural integrity and harmonize the way locks are handled.
It would also make me sleep better :-)
"..due to unreachable *nodes* [{}]"
fixed, moved the probability to config
I removed 'revert', but we still need to update the cardname references in card content.  That is now this method in the Reference chuck classes.
other than **a** decorator instance
Exact. Plus the fact that the emote shortcut should get a final fix for the historical offset problem in a better way.

I'll do both in another pull request.
We may want to put the mayavi loading logic inside of viz._show_odf as well?
ICON_SIZE has been moved to to the Utils.getRoundIcon method https://github.com/crdlc/gaia/pull/11/files#L3R75
Почему не будет?
Is this necessary? If so, increase the iterations.
This could be `this.set(input, false);` as there is no way to bind to the change event before the model has been initialized.
Actually no, that's not a good approach. I'm actually not sure what the consequences of setting the object to self would be in this case.

But the bigger problem (besides the reference cycle) is that you're not removing the notification properly. If you read the documentation, it states that the return of this new method is:

> **Return Value**
> An opaque object to act as the observer.

So you need to keep a reference to this "token", and use that when you remove the observer in dealloc using `removeObserver:`, passing the token in.

Long story short, block-based observers aren't very nice.
This could instead use `[NSColor colorWithCalibratedWhite:1.0 alpha:0.24].tui_CGColor`, which simplifies the memory management.
It looks like pattern of obtaining a Scala `Iterator[(_, _)]` from a `HashMap` can be expressed using [`JavaConversions.mapAsScalaMap`](http://www.scala-lang.org/api/current/index.html#scala.collection.JavaConversions$); I'm not sure if there's a performance difference, though:
```scala
import scala.collection.JavaConversions
import java.util.HashMap

object Test {
    def main(args: Array[String]) {
        val javaMap = new HashMap[Int,Int]()
        javaMap.put(1, 2)
        javaMap.put(3, 4)
        val scalaMap = JavaConversions.mapAsScalaMap(javaMap)
        val iter : Iterator[Any] = scalaMap.toIterable.iterator
        println(iter.next())
        println(iter.next())
    }
}
```
`"%" + k` here and in the other lines would just fit, I think
Json?
Nechybí Honzo, protože tohle je tam kvůli testu "minimalContainer", který metodu vyžaduje.
What do you think,  is it worth to have this or shall we remove this class?
не понял? это вы про что?
я понимаю. но когда оно отлажено (а оно отлажено?), отладочный код надо убирать
I think this will be always defined, why do you need to test using `Test::Unit::Error in this particular case?
I realized later that the fish test was redundant.  

For "search" I was trying to assert that the method returns false when the string is not the plural form, just to have a negative assertion so that I couldn't make the test pass by just always returning true.  I could mock the inflector call to return a different string, if that's preferred.
Better to simply not add the deprecation to master
```
the hash keys for fixture classes are no longer expected to be 'table_names' but 'fixture/names', and they are stored as strings
```

Right, but `set_fixture_class` /accepts/ symbol keys.

In any case, I agree with you. Let's leave the change and see whether it breaks anything :)
I tried setting scope.where_values = [left.or(right)] however it did not persist.  The only way I could do this was to clear the scope down.  This kills other things unintentionally.  If there's a way to do this, please can someone advise.  If not, I think I need to save all the other 'values' and reassign after the scope clear.
On a second thought, unfortunately we don't be able make this another `emptyValDef`, because the `Super` part is supposed to get attributed during `typedPrimaryConstrBody`. 

We could introduce another attachment for that or change `SuperCallArgsAttachment` to accommodate for the attributed `Super`, and then using the attached info to adjust the primary constructor during `typedTemplate`. However, given the scope of necessary changes (beyond a few lines) and the fact that, according to Martin, the whole thing is to be rewritten soon, I'd say we don't do the follow-up refactoring.
On a second thought, maybe we can move this hackery into `mkDefaultMirrorRef` and have `reifyEnclosingRuntimeClass` return EmptyTree for super calls of top level objects?
I agree that if we use this library in a single threaded mode then this exception makes sense, as this code should never be called if valid == false.
You want

```python
client.query(hek.attrs.Time(tstart,tend), hek.attrs.EventType('FL') | hek.attrs.EventType('CE'))
```
or even easier
```python
client.query(hek.attrs.Time(tstart,tend), hek.attrs.FL | hek.attrs.CE)
```

because you want to match either FL or CE. You have to think of the query as a logic expression every requested item must match, therefor FL & CE can never be given, because an event is either a FL or a CE.

```python
result = client.query(hek.attrs.Time(tstart,tend), hek.attrs.AR & (hek.attrs.AR.SpotAreaRepr > 20))
```

Would do what you wanted, there is some unfortunate operator precedence going on in 
```python
hek.attrs.EventType('AR') & hek.attrs.AR_SpotAreaRepr > 20
```

Cheers.
I'm in series mode and thinking of Order. Maybe if the were called FactorOrdering or MonomialCmp it would be more clear (to me). Perhaps refring to the order of factors in a product would be better than product order (but that may just be my lack of exposure showing). And then the docstring would say something like, "The order of factorors in a product can be customized by... " or "In order sort monomials, ...
Perhaps it should be possible to show the product of `lex` over `x_1`, `x_2` with `grlex` over `y_1`, `y_2`, `y_3` instead and provide two example cases: 

* `(2, 1, 1, 0, 0)` > `(1, 10, 0, 2, 0)`;

* `(2, 1, 1, 0, 0)` < `(2, 1, 0, 2, 0)`

to show how the orders interact.
you could strike out "Going ahead and" and just start with "Computing"
This smells like a recursive trap...perhaps

```
esimp = simplify(e)
if esimp != e:
    return limit(e, z, z0, dir)
```

Although Mul's are cached, as I recall, it still hurts to see Mul(*r) computed twice in a row. How about

```
if r:
    m = Mul(*r)
    if m is not S.NaN:
        return m
```
Yes this sounds like a good idea.

Note that ipython notebooks are not the only reason to implement latex printing. But I agree that there seems no reasonable way (at the moment) to print diagrams in latex, so don't bother. When the real diagram printing code is there we can see if it is practical to invoke during latex printing.
In that case, that's probably what it should do.
round brackets -> parantheses
```
In [1]: x = sympify(1.0)

In [2]: x.is_integer
Out[2]: False
```
Order is wrong. Should be moved upwards a bit.
done 789938d1bf60739c8ebcf1d34950c28a1a0e4f22
There was space indentation before.
rm uncessary empty lines and comments from this class
Possibly.  The `#define`s were an expedient solution to pressing problem.  Feel free to submit a patch.
`xrange()` will break when running the tests with Python 3.
It's a marker. Nothing happens.
no it's ok. rest_client_wrapper inherits base_wrapper, so need to be included after it, but as base uses rest for post_file (actually, just needs exception classes) it's good to include it here.
yep! I will re-request.
I suspect that this breaks uclibc builds.
I think we need to be careful to avoid making it seem like chunks are structures that hold data. Chunks describe data, but don't hold it.

"you have a large amount of data in a collection and very view chunks, as is the case..."
This is a pretty roundabout way of testing this. To test that the registry DSL is included in the Chef::Resource base class, you should put tests in spec/unit/resource_spec that assert that it responds to the registry DSL methods:
```ruby
resource.should respond_to(:registry_dsl_method)
```
To make the tests work on both Unix and Windows, I've been using a technique where I create a subclass of the class I'm testing, then forcibly include the windows-specific module:
```ruby
ResourceOnWindows = Class.new(Chef::Resource) do
  include Chef::WindowsSpecificModule
end
```
You'll still want tests to ensure the windows functionality is included automatically on windows, so it's okay to have `:windows_only` tests for that.

For tests that define/test how the registry DSL itself works, I'd create a separate test file, e.g., spec/unit/dsl/registry_spec
change this content to proper thing and then again send for merge
Should be just one `*`
You need to check if sqlite3_open exists before calling it with @. See postgres or firebird adapters for the correct logic.
Also you've added whitespace on this line.
No, I couldn't even get compilation working without this. The changes to eclipse-templates/.classpath & ivy/libraries.properties were for eclipse
use only single quotes, do not mix them
Got a better phrasing in mind?
Why no `canPlayType` as in the original?
recommend creating an enum to capture all of your page #s ... that way it's clear where you're navigating..

I find 

STUDY_SCREEN = 5 
...
setActiveItem(STUDY_SCREEN)

to be much more readable.
These vars should only be defined once and referred to from a common location (e.g. utils.js). Currently, they are also defined in app/controller/PaperEntry.js. Note that in one the username is ```'admin'``` while in the other it is ```'Admin'```! If this is a mistake, all the more reason to combine them in one place.
I don't think that a version of ```gitwash_dumper.py``` should be added to our repository. Although it's a stable approach, it will go stale.

Previously, to build the gitwash documentation the builder had to manually get the ```gitwash_dumper.py``` script. This involved working out how to get it i.e. Google gitwash, hit the GH page, read the GH gitwash instructions, get and use the magic curl command.

I guess the compromise might be to split the ```curl -O https://raw.github.com/matthew-brett/gitwash/master/gitwash_dumper.py``` command into a separate script that could be run by the documentation builder for convenience sake. In the end, they'd be running two scripts instead of one :(
drop this try/catch -- also the one in IndexScanPlanNode
Right, this doesn't solve the problem of a node rejoin and disappear too fast. The problem is that the coordinator doesn't know about the new sites when the coordinator sends out work. So validating the list against the known sites and known failed sites may not solve the problem?
``clone`` implies the effect of cloning will be returned by this routine. A name like ``assign_from`` describes what is actually happening.
Для лучшей кросс-платформенности (windows) я бы использовал `PATH.join(BEMBL_TECHS_PATH, 'i18n.js')` и в других строках тоже.
Whatever manager is needs to be documented, or it shouldn't be a parameter on a public API.
I think there could be some room for code-reuse. I know get_indexes() has been a big pain to maintain (dropped columns, same column indexed as unique, and as part of non-unique index etc).

Perhaps add a new underlying method which returns multicolumn indexes, and multicolumn constraints alike. Something like
list of: {name:  NamedTuple(cols=list(cols), unique=True, primary_key=True, constraint=True, index=True)}.
I didn't know about `cached_property`. Interesting implementation too :)
erm, this is an exact copy of the same method in DBALException: https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/DBALException.php#L39
This breaks code using oldName.
Probably should remove this line as well as the one below- Might not want to change the sample test?
I want to update email here too, if it's nil. because when I first built this app, I didn't store user email from omniauth hash, so in the production there are 3 users who don't have email.

but somehow the omniauth hash doesn't contain the email here, maybe the the return hash for creation and just login is different. need further investigation.
This should be gettext'd. I didn't see it in previous passes.
I thought so, but I can't seem to find the right magic invocation. `-KU` according to the manpage is for kanji and in practice I was still getting encoding errors:

```
invalid multibyte escape: /^\037\213/ (SyntaxError)
invalid multibyte escape: /^\037\235/
invalid multibyte escape: /^\xFD7zXZ\x00/
```

Which is weird. Similar story with `-Eutf-8:utf-8`.
It says "# should be obsolete with some newer versions (current version is: 3.0.1)" in line 38. Isn't that enough?
Can this be simplified to:

```ruby
if email && name && token && token_ok?(email, token)
  { :email => email, :name => name, :token => token }
end
```
Please use brackets for if structures.

http://owncloud.org/dev/coding-style-guide/
I mean this:

```python
# NOTE: we ignore the scroll_step value passed into set_increments()
# and calculate the change using deltaY, which is in device
# coordinates.
```

It is platform-specific.  It doesn't need to be a docstring; just a note about why we ignore the values.
Could these config settings can potentially be strings?
This was an issue on 1.6.1, and unfortunately many users are going to be stuck on 1.6.1 for some time (e.g. Ubuntu 12.04 LTS...)
So this forces the DEBUG line to be printed no matter what the format?
Same for this default.
Please specify the accepted values here.
Yup. Root is the ObjectGraph that has no base.
What's a unitary binding?
As far as I know, Exception.__init__() accepts only a single string `message` parameter.
This would return null for previously installed apps. Is that a problem?
again, could this template be used to display other types of products instead of books?
The algorithm does not seem exact.
Randy,

Be welcome. It's really a pleasure contribute to Brackets. I'm sorry that i changed it context, but I was confused because of that call of openAndSelectDocument() at drop function on WorkspaceSetView module. I thought that it was only to a drag and drop event. Now, I fixed it.

I just think it's a bit confusing have a rename second click event on project tree, it already have a double click event, that is add the selected file to Workspace Set. I can implement it to project tree, but how I said to me it's a bit confusing have two effects and a same gesture to project tree. Let me know if you decide that is better implement it to project tree too.

I'm ready for another review.

Thanks,
Gabriel
Not clear why this is necessary since we no longer have a disabled folder in the source tree.
I figured out why it is skipping some files. If you reach the search limit and bail out of the search loop, the `lastIndex` property of `queryExpr` is not reset. When you go to search the next file, it starts from `lastIndex`. To fix this, set `queryExpr.lastIndex` to 0 if the search limit is reached.
I see Edición used for the edit menu in other apps. Which is more common?
Since all of our code uses magic numbers I created a code clean up bug for this issue https://github.com/adobe/brackets/issues/1241 since we should clean this up everywhere.

-----Original Message-----
From: Randy Edmunds [mailto:reply@reply.github.com] 
Sent: Wednesday, July 11, 2012 7:39 PM
To: Ty Voliter
Subject: Re: [brackets] HTML Tag Code Hinting (#1236)

>       */
> -    function _onKeyEvent(event, editor, keyboardEvent) {
> -        if (keyboardEvent.type !== "keypress") {
> +    CodeHintList.prototype.handleKeyEvent = function (editor, event) {
> +        var keyCode = event.keyCode;
> +        
> +        // Up arrow, down arrow and enter key are always handled here
> +        if (keyCode === 38 || keyCode === 40 || keyCode === 13) {

These magic numbers should be defined as enums,

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1236/files#r1146540
This should use `<span class='dialog-filename'>` instead of `<b>` for consistency with other dialog strings displaying filenames.
Hmm, I guess it must, otherwise things like the `pipe()` pattern you use below wouldn't work either. Wish this were documented clearly somewhere in jQuery...
Yeah. I did and it didnt give me any error, but ill double check.
According to [git blame](https://github.com/ajaxorg/cloud9/blame/28e9ce80f4254f0ccfb62cc8cf648ff41bc19dd6/plugins-client/ext.help/help.js) it was added by @mattpardee. I have no idea what it refers to, I'll take it out if it works without it.
"belongs to, thereby, Hence," ?
Changed docstring to „The temporary folder must allow creation of any files with writable permissions.”.
I think this will 500 if the right params aren't passed in? Which is probably more correct than routing an empty message, although would be nice to 500 more gracefully/with more info.
Here, it doesn't make sense that you create a function, then immediately call it, and assign the return value to `getInfoForEl`. Since you don't return anything from calling the function, `getInfoForEl` will be undefined.

And it's also unnecessary to have that many arguments, no arguments are actually needed because for every single one of these calls they will all be the same. The only thing that changes is the value from `el = elTypes.shift();`

Something like this would be cleaner

```js
function getInfoForEl() {
  var el = elTypes.shift();
  requestOptions.url = INFO_URL + id + el;

  ...
}

getInfoForEl();
```
I'll do, docstrings in the api module and perhaps also in the lower modules need to be fixed ;)
Duplicated line, w/ UseNLog below?
I pulled the latest version from the main repository and it's already done as it should be :)
This is also not being used
whitespace here and a few others still
I am not seeing this make any difference.
Why is this one the only one with a return?
do we need to do this second check? and if so, does it need to be coerced to a  bool to check for existance?
Remove the ?butteruid
Note: this was just clipped out of `src/editor/editor.js` to put it in its own file for cleanliness and extendability.
It's not really commented :) it will be un-commented when pre-processor will be run
Still seems to say `nose.test` not `nose.tools`, unless I'm crazy or something is going wrong with github.
this should be using UniqueBroadcastID() instead. EpgID() is the id of the container
This should probably be `OpenLayers`, not `JSDoc:`.
I have two concerns here, one a much bigger deal than the other:

1. We are assuming the user's CAS login name can be directly transformed into their email address.  This is not a valid assumption - eg. see Ben's user name in iMedidata.  Although in most cases this would merely cause inconvenience, it's also a potential security hole.  We need to find some alternative way to match up users in iMedidata and users in Agi.

2. Much less importantly, this could be implemented much more efficiently by using ActiveRecord's finders so the DB query fetches the right user, rather than filtering it in the app.  It's not really a big deal with the scale of data we have in the users table, but there's no particular reason not to just use a more specific query here when the framework makes it so straightforward.
ok it seems this is particular to my dns setup.

'missing' resolves to Inet4Address of missing/67.215.65.132

which is coming from my DNS provider, opendns.com ( use it to pretend I can keep my kids from internet baddies ).

Not sure the best way to work around.
I think it would be better if this was set to null instead.
这个label只用了一次，去掉吧？
This probably doesn't need to be wrapped in an anonymous function
=> UsersBan.

(une entité : UserBan, et la table, comme elle en a plusieurs, elles a DES utilisateurs bannsi, donc UserSBan)
In that case, I would suggest to state there StandardError explicitly. This implicit behaviour is some kind of tricky (at least I could find an answer for that last year)
Please use `===` to ensure strict equality.
run the code quality tests, this will raise a warning
¡Bel usó una Poké Ball!
please reorder the methods by visibility to follow the Sf2 coding standards used by the library
I'd like to know whether it is possible and doesn't make the API harder to use. If so, then I think it should be changed.
Because homescreen should be loaded from homescreen.gaiamobile.org not gaiamobile.org - permissions granted to homescreen.gaiamobile.org don't apply to gaiamobile.org as far as I know because it's a different origin.
Remove the full stop (period) at the end of set_current`
This isn't really intended as a public module...  I just thought it nicer to group together all of the functionality related to physical types in a single module, rather than adding it to core.  This module is explicitly not included in the docs and there is a warning to this effect in the module docstring.  Should it also have its name preceded by an underscore?
I would delete this line, it just repeats the title
testnet should be lowercase
Why not "50"?
Ok, then I guess I will remove this whole foreach loop and move it to a function in ValidationSet class itself.
I wanted to save this one for you, but it's here for completeness. :p
Just cleanup I noticed - unrelated to extensions.
Thinking about it, I think we should go forward with the current implementation. If they are broken behaviour, let's implement some test case and fix the issues. We are in a much better shape than before with this code. I will add some notes in the mock_application.py file to make sure the potential issues are captured.
We still only do the change notification if the new value doesn't compare equal. Does that make sense? Do we have any traits for mutable types that trigger notifications?
Let's try to keep the first line of the docstring shorter, eventually adding a description of what in does in a longer explanation after.
This is going to break in Python 3, since it was moved to the `io` package.
any chance the code or dependency this license applies to can be highlighted, or better yet dual licensed so we can eliminate FUD around LGPL?  Ex. jackson dual licenses their jars asl and lgpl, maybe this code can be as well?
What about `HTML::encode()` or the shortcut `e()` instead? `htmlspecialchars()` without the appropriate parameters will just cause other problems... e.g. with single quotes.
`revparse_lookup_fully_qualifed_ref` can be rewritten using the new `git_reference_name_to_oid` function as:

```c
{
    git_oid resolved;

    if (git_reference_name_to_oid(&resolved, repo, spec) < 0)
        return -1;

    return git_object_lookup(out, repo, &resolved, GIT_OBJ_ANY);
}
```
Ok, consistency is good.
My example was the persisted object, but I used this to output all the requested items, and have provided the output above. I didn't feel it was necessary to paste everything into the comment.
i guess this is missing an assertion of the environments data? and assigning some envs, too.
again I think it should be used only in scope that it is needed. You need it only in two branches.
I also meant to ask if updating the details.php file to include the preview_hash was necessary/desired in addition to the hash, hadn't heard differently. I'd imagine the details.php sets up a fresh install while the migrations handle the upgrade...
You mean for the file_exists(). It was just a secondary check.
clone keeps strings frozen, whereas dup clears the frozen attribute
seems useless to me
why changing this line ? We don't align ``=`` in Symfony. It makes updates painful (changing many lines when you add a new longer key), and you don't align the whole block anyway
yes, it returns a catalogue. but it does not find it. All places using ``find`` as naming are actually finding the object. Here, you are eventually filtering the catalogue, but finding it is done before calling the method
there has to be a criteria dividing certain messages from others that would explain this better, rather than just saying much more
same here for the typehint
this should fail under php 5.4
I'm not sure, in [Twig's core tests](http://twig.sensiolabs.org/doc/tests/index.html), underscores are omitted.
Can't understand the two latest. Looks like you're missing `o`.
"the have been"
We fix the banmask in removing E and SHUN but not K or G?
OMG, I just realized that this is showing up as new.  I guess I didn't do a pull request for my last set of fixes about a month ago!  Based on user feedback of problems.
В этой функции что-то с отступами не то, поэтому теряешься в логике
I know nearly nothing about R, but why do you need to create a variable just to return it immediately?  Wouldn't 

```R
..
resource = ..
getURL(.build_url(resource, ...), customrequest= "DELETE")
}
```
work the same?

Also (and pardon again my ignoRance) the indentation looks funny.
yeah that's reasonable
I changed the implementation to use `Ember.Application.detectInstance`. I've tried this before but it wouldn't work. Now that there is a reset of `Ember.Namespace.NAMESPACES` in the `setup` of the tests (see [287a246#L1R73](https://github.com/pangratz/ember.js/commit/287a246c024eff1b393a2a6565ad5a65535b9aba#L1R73)), it works...
This could repeat the familyName twice in the title. name == givenName + familyName
Is this passing the linter?
`defaultValue`... merging anyway
Nit: leaving blank lines pleases @vingtetun ;-)
This will only match on URI, shouldn't we be matching on title too?
Yes, I did this just after making the other pull request.
Maybe this should not actually be named 'test_contacts' it does test that we can launch contacts but its more to test gaia_apps.js.
Yep. Duplication alert.

Not sure we want to duplicate this code and if we have too definitely don't want the USSD check here :)
And definitely don't want the function name to be the same ;)
Since you have footer-button-container, footer-buttons, class="button" let's convert 'btn' to button :)
remove this line if you changed L123
My fault :)
nit: Add a name to your anonymous function
Sorry, That's line 134, not in diff
You don't really need settings as a variable. |var lock = navigator.mozSettings.createLock();| is enough.
I like that. Tests FTW. Thanks for patching this.
What happened to +? Why are you using String.Concat? This looks extremely verbose and is hard to read.
Interesting approach. Not how I'd have done it, but I like this better. Fits in nicely with the way the generic client commands work.
this was copy pasted from the puppet broker, should I just remove it?
@rphillips fixed in 40b6bf4
It's a small point, but I wonder if you want to use `Hash#fetch` anytime you're accessing something in a Hash that you expect to exist. These days I only ever use `Hash#[]` when it's ok for the value to be nil.
may split these into separate helper methods?
This code is very similar to the one above. Maybe use the code above and do a transpose instead of copy pasting?
nevermind those values are additive
sure! sounds good
I prefer the nodeunit syntax:

```
exports.testDownload = function (test) {

}
```
Could do with exact definition.

true = just generated, so not populated
false = loaded from disk (but may not be populated)

or whatever is the conditions.
Is the 'Source' here a typo?
That's a lot of inclinations and thoughts :)

  1. The buildmaster config isn't really the focus here, so I think it's OK to leave it in the file.  It's pretty bare-bones, in hopes that changes to non-core components (e.g., GitPoller or Triggerable) won't affect the test.
  2. We may *not* need to write it to a file -- I'll verify that and change if so.
  3. How would exocet help in this case?  If the problem you're looking to solve is re-creating instances, that could be fixed by writing a makeBuildmasterConfig function and calling that from the config file.  I actually *like* the additional testing of starting the same config objects twice.
  4. I think that testing process startup should be a different test - the things that will go wrong there are platform-specific (and it will be difficult to keep the test finding problems users will see, rather than generating its own complexities).  Similarly, I'd love to have a test that runs a build, but this is not the one.