labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, SoundPool.load (in both cases - with file name or assets file description) does not throw an exception but returns 0 instead of.

At the line "soundID = this.mSoundPool.load(this.mContext.getAssets().openFd(pPath), 0);" exception is thrown by _openFd_ [call](http://developer.android.com/reference/android/content/res/AssetManager.html#openFd%28java.lang.String%29) :

E/Cocos2dxSound(9355): java.io.FileNotFoundException: zzzz.wav
E/Cocos2dxSound(9355): 	at android.content.res.AssetManager.openAssetFd(Native Method)
E/Cocos2dxSound(9355): 	at android.content.res.AssetManager.openFd(AssetManager.java:341)
E/Cocos2dxSound(9355): 	at org.cocos2dx.lib.Cocos2dxSound.createSoundIDFromAsset(Cocos2dxSound.java:273)
E/Cocos2dxSound(9355): 	at org.cocos2dx.lib.Cocos2dxSound.preloadEffect(Cocos2dxSound.java:110)
E/Cocos2dxSound(9355): 	at org.cocos2dx.lib.Cocos2dxHelper.preloadEffect(Cocos2dxHelper.java:165)
...

If somehow value returned by openFd a moment later will become unusable due to any reason - SoundPool returns 0 on such value, like for example if add the next check at the end of createSoundIDFromAsset:
```
		try {
			android.content.res.AssetFileDescriptor fd = null;
			soundID = this.mSoundPool.load(fd, 0);
		} catch (final Exception e) {
			soundID = Cocos2dxSound.INVALID_SOUND_ID;
			Log.e(Cocos2dxSound.TAG, "error: " + e.getMessage(), e);
		}
		Log.d(Cocos2dxSound.TAG, "id 2: " + soundID);
```
There will no be any info about an exception as it was not thrown, and just a line that 0 as ID is returned:
D/Cocos2dxSound(9355): id 2: 0
True, I used the puts when I was testing it and I forgot to change it XD
indicate that this content match has to be within a certain distance of the previous content keyword match
just 2012
ahh nvm I see how it is used now.
The best would be to avoid such error prone code.
A least put a comment to highlight this usecase.
`walkDir` behaves like `os.walk` from python: http://www.saltycrane.com/blog/2007/03/python-oswalk-example/
The only difference is that `path` is a relative path from the original path given to `walkDir`. (Just because we don't have relpath function and I didn't wanted to implement it)

Here it looks like you return all directories and all files without being able to figure out from which folder each of these are.
The first version seems to implement the same behavior than os.walk.

I'm not sure it is easier to follow especially in lines around reduce usage. Whereas the original code can surely be read by any guy used to read js xpcom code. I'd really like that jetpack code can be easily read/patched/maintained by any mozilla-central devs and that we end up using similar pratices to existing mozilla-central code:
http://mxr.mozilla.org/mozilla-central/search?string=.directoryEntries&find=\.js&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Not necessary all SDK code, but especially the low level one, which interact with xpcom and can be broken by new mozilla-central revision. If we would like to be integrated with other mozilla teams, we will need to unhide our unit tests on tinderbox and allow them to understand what they broke and why. So that they can land fixes in addon-sdk repo while landing a modification in mozilla-central. I'm considering such abstraction on top of xpcom interfaces as being negative about this, even if it can be usefull for new addon developers.
k, I added a comment mentioning bug 792670
I still kept this internal method. I can move it to tabs/utils but I can't use existing methods as-is.
`getTabs` for example is inefficient. The overuse of reduce and filter is very inefficient too.
So I can see multiple options here:
  * keep it as-is: an internal method in page-mod
  * move it as-is to tabs/utils
  * move it to tabs/utils and try to use some methods from this module. I would have to modify getTabs and avoid using reduce.

I'm extra carefull about performances here as this code is going to be executed on any new content document (once per installed addon using page-mod!), so that it *is going* to slow down web pages loading. We have to lower this effect as much as possible.

FYI, performances of `reduce` http://jsperf.com/eval-join-vs-reduce/3
That's published from this: https://github.com/jedp/node-cef
Oh yea, I didn't notice that either. Does the gradient override the grain.png? Or is the png transparent?
This comment is obsolete, yes?
This is all over the place. Maybe we should have these just accept this object, rather than the string? Should save parsing the email over and over and over.
Why do you hardcode the path at two different locations: here and in src/helpers/gdbconnector.py?
In a case like this, where a conditional exists to handle a specific ruby version, I like to move it out into the class body where I conditionally define a helper method.  In your case, it could be like this:

``` ruby
def method_defined_directly_on_klass?
  if @klass.method_defined?(@method) || @klass.private_method_defined?(@method)
    method_owned_by_klass?(@klass.instance_method(@method))
  end
end

if method(:class).respond_to?(:owner)
  def method_owned_by_klass?(method)
    method.owner == @klass
  end
else
  def method_owned_by_klass?(method)
    # On 1.8.6, which does not support Method#owner, we have no choice but
    # to assume it's defined on the klass even if it may be defined on
    # a superclass.
    true
  end
end
```

I like this better for a few reasons:

* The conditional is going to take the exact same branch at runtime every single time.  Doing it this way makes that clear by resolving the conditional up front when the class is defined.
* It's kinda polymorphic (at runtime at least), even if this isn't the typical way people think of polymorphism.
* I think the code is cleaner this way.

Thoughts?
Rewrite this `unless`/`else` with the positive case (`if b`) first.
``CONFIG`` is from the old code, it's not defined here.
should can?
shit I really liked this! :punch:
Sorry, meant the `ResponseSender` itself.
That's true, i changed with typehinting.
I don't see the reasons for remove this test (later I will explain the reason because should be)
Oh, I think its just an inverted version of testAdapterProvidedNoResult,
Set the default adapter:
AbstractTable::setDefaultAdapter($this->_adapterHasResult); (which doesn't exist)
run without an adapter:
$validator = new RecordExistsValidator('users', 'field1', 'id != 1');
therefore also irrelevant
Don't we have that class already in ArcBees infrastructure?

If not, we should add it.
`if (`, not `if(`
You call `count()` forcing to integer is useless =)
typo here: ``sometimes``
This looks ambiguous. Does it pass lint?
@vesak Nyt mun mielestä nää optionit pitäis olla eri riippuen onko parametri V vai W asennossa.
the point is, you cannot have 2 states at the same time. So it cannot be STATE_MOVED and STATE_REORDERED at the same time.
:+1: good job applying what we talked about the other day.
Ahhh, I see what you're doing. Well you always want to validate the presence of a `username`, because you don't want them to be able to remove it. Because the password fields are virtual attributes you could require them both on create, and then only require password confirmation if they have also have a password field, because that indicates they are actually trying to change their password. You should look at how, simplest_aut, authlogic, and devise handle this for inspiration.

To describe the requirement here: you always want a username on the model, and you want the password fields present when they are creating the record or when they are updating the password.
Können wir hier rex_get() verwenden?
docstring doesn't make sense, should use `pass` for an empty configure
It renders fine in my version of markdown. I tried installing ruby and the redcarpet gem but I get compilation errors. Is it documented how to install the prerequisites for parsing the markdown files:

FYI My error is:

/home/mmusgrov/source/as/quickstarts/quickstart/dist/github-flavored-markdown.rb:51:in `optionize': undefined method `each_with_object' for [:with_toc_data, :hard_wrap, :xhtml]:Array (NoMethodError)
What's the best practice? I mean, if the IDs are different and not null or zero, than it's safe to say they are not equal. But that's not applicable to hashCode since nodes with null ID and non-zero ID would be equal but have different hash.
So, only organic properties?
This fails under REE (try running 'rake all_rubies').
s/TestSmsPage/TestSMSPage
Space between more > a
Nit: line up with `reverse`?
Is that a tastypie thing? If so then my mistake.
@AlinT what would your suggestion be? 

<code> _page_title = 'Editing User:%s - MozillaWiki' % (mozwebqa.credentials['default']['name']))</code>
Yeah, I figured you were probably asleep, and neither of them is critical, so whenever you get a chance!
This is good, but since nova/exception is being modified anyway why not just add the dictionary as a field to this type? Then rather than using json.loads you can just grab the property.
the @vm is from the original code.  If it needs to be that way, you might need to check other similar usages in foreman.  I'll fix that in my commit.
This is not relevant to the get_mozmill-environment job as it is a multi-configuration job. The node is tied to master in the configuration axes.
There's nothing wrong with this syntax, but in Zotero 3.0+ you can also load the translator as a web translator instead of an import translator and call translator.translate().
good catch, it would miss the parameter and print only the empty braces.
Might be interesting to implement a jQuery accordion in place of all this.
No need for the bold, here.
Why are you blockquoting this? Also, it hasn't had any problems with security in the past (if you know of anything, link to a source).
yikes. forgot to delete that.
Why return a Response object? This is not the result of a queue execution. Why not return a boolean stating that everything went fine?
I decided to stick with the default constructor for NodeMapping.  This would be the only call to this constructor, so there is no re-use.
why not put this in an external stylesheet ?
small typo: backward instead of beackward :)
а кто будет читать это?
The form also has a class of `.login`, will that cause issues?
This change was merely about line length
This will not be a problem actually because this is the master branch which doesn't do that anymore ;-)
Right, zero fill bit shifting is equivalent to the internal `ToUint32()` operation, limiting the result to any number from 0 - 2<sup>32</sup>.
Any reason why we're using user: here? The userId is already prefixed with u:
The callback.err documentation would be nice.
I wanted to test that a local variable comes first, for a *scope completion*. Member completions are probably not affected by this change.
The default configuration is currently for Scala 2.9. @dragos do we want to change that?
`1,4` 这种其实会忽略掉后面的，只取第一个的值，至于用 `,` 是从正则那借过来，因为这货和 `3-1` 的区别在于，它只是一个区间。

`3-1`、`3-2` 和 `3-3` 只能告诉别人「有多少个」、「这是第几个」，但 `1,4` 的意思则是「至少 1 个，最多 4 个」。
does this need to be localised?
Should probably use `==` here, so it catches 0, spaces, etc.
А что, собственно, не так?
А, ну тут да, но это не бесконечный, а просто неоптимальный :) бесконечным
он быть не может, если генератор случайных чисел не совсем ущербный :)

Best regards,

Grigory Loskutov


On Tue, Nov 6, 2012 at 8:43 PM, tarpaha <notifications@github.com> wrote:

> In DNA/DNA/main.m:
>
> > +-(void)mutate:(int)percent;
> > +@end
> > +
> > +@implementation Cell (Mutator)
> > +
> > +-(void)mutate:(int)percent {
> > +    int percentMutated = 0;
> > +    srandomdev();
> > +    for (int i = 0; i < [[self DNA] count] ; i++) {
> > +        if (random() % (100-i) < (percent - percentMutated)) {
> > +            percentMutated++;
> > +            NSString* currentVariant = [[self DNA] objectAtIndex:i];
> > +            NSString* variant = currentVariant;
> > +            while (variant == currentVariant) {
> > +                variant = [NSString stringWithFormat:@"%c", [Cell returnRandomGene]];
> > +            }
>
> Теоретически бесконечным я назвал цикл рандомизации гена
> while (variant == currentVariant) {
>
> variant = [NSString stringWithFormat:@"%c", [Cell returnRandomGene]];
> }
> Согласитесь, что random (пусть и с очень малой вероятностью) может долго
> возвращать одно и тоже число (к тому же на выборке из 4х элементов)
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/Hexlet/osx-project-1/pull/31/files#r2044918>.
>
>
И если уж на то пошло, то категорию можно объявить даже в файле Cell.h, нужно только не забыть её правильно реализовать.
The quick proxy is a standalone util. It is not intended to run as a python module. It there any reasons to do it this way?
what is this?  It doesn't make sense and I don't see it used  anywhere
`instanceof` is bad to rely on -- arrays and objects from different contexts (iframes or occasionally in node with certain flags set) will not pass the `instanceof` check
All the other code in Doctrine has a space between `if` and `(`
need to specify default value if the property is not existed. It would be ${gatein.jcr.repository.default:repository}
If I'm not mistaken, that line is necessary to make sure that images within the page load properly. The problem here is that I think the base should be set to the fileUrl, or in the case where the page we just loaded contains a base tag, it should be set to that base tag path.
Use `that` or `$.proxy` or `_bind()` (from new widget factory). If Mobile is already using `self` everywhere else, don't worry about this for now.
* the first `\` shouldn't be required.
* check that your indentation configuration matches the php-activerecord one.
Bra hittat!
seletion-> selection
Turns out this would be a big pain, since .plot() creates subplots for each of the channel types...
Rather than comment these lines out, let's just remove them. We'll always have them in Git history.
Exactly. JSON, XML, and even HTML can be served with mime type application/...
Why not use `unfold` instead of `unfoldM`?
Aren't we losing the original exception (throwable) here?
Ok ;)
Maybe you should mark the `JsValueWrapper` as `sealed` to prevent a runtime ClassCastException if some dumb user writes `obj("foo"->new JsValueWrapper{})`
This doesn't need to be a spy (see below).
This should be used at the previous line, instead of the `:`.
Please specify the other formats aswell (and route names should follow the conventions, which uses underscores instead of studyCaps):

    .. configuration-block::    

        .. code-block:: yaml

            acme_static
                pattern: /static
                defaults:
                    _controller: TemplateController:Template:template
                    template: 'AcmeBundle::static.html.twig'
                    maxAge: 86400
                    sharedMaxAge: 86400

        .. code-block:: xml

            <?xml version="1.0" encoding="UTF-8" ?>

            <routes xmlns="http://symfony.com/schema/routing"
                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                xsi:schemaLocation="http://symfony.com/schema/routing http://symfony.com/schema/routing/routing-1.0.xsd">

                <route id="acme_static" pattern="/static">
                    <default key="_controller">TemplateController:Template:template</default>
                    <default key="template">AcmeBundle::static.html.twig</default>
                    <default key="maxAge">86400</default>
                    <default key="sharedMaxAge">86400</default>
                </route>
            </routes>

        .. code-block:: php

            use Symfony\Component\Routing\RouteCollection;
            use Symfony\Component\Routing\Route;

            $collection = new RouteCollection();
            $collection->add('acme_static', new Route('/static', array(
                '_controller'  => 'TemplateController:Template:template',
                'template'     => 'Acmebundle::static.html.twig',
                'maxAge'       => 86400,
                'sharedMaxAge' => 86400,
            )));

            return $collection;
this is wrong. The doc is using rST, not Markdown
I agree, so now the question is, how can we retrieve the DB value
here. I don't know how to hook into reload without monkeypatching
ActiveModel.

On Tue, Jun 12, 2012 at 2:33 PM, Geoffrey Hichborn
<reply@reply.github.com>
wrote:
>> @@ -1090,12 +1090,6 @@ def do_after_all; end
>>        assert_equal now.to_i, @dummy.avatar.updated_at.to_i
>>      end
>>
>> -    should "return nil when reloaded and sent #avatar_updated_at" do
>
> The DB value should be the correct value.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/thoughtbot/paperclip/pull/914/files#r969645
How about calling the preprocessor "coverage" ?
I know it's istanbul inside, but as a developer, I don't care. I only know, I need to preprocess files in order to get the coverage.
Are you allowed to do that? I added this from Akela to test the modified version of ConvertDateFormatTest but didn't make any modifications beside the package. Apache license says:

You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works
Shouldn't that be `warn_missing = warn_missing` ?
Wouldn't it be better to store an Option[Promise[Connection]] and then register all inbound channel requests as callbacks so that when the Promise gets completed all waiting guys can get a new channel?
legacy - ported as is
Because I want the cluster management actors to live under the 'systemGuardian'. 
I could create a dummy parent supervisor for the cluster management actors, might be a good idea. Is that what you mean? 
So /system/clusterManagementSupervisor/*
?
then we should make sure that this actor gets suspended; good catch!
Кстати, `INotifyDescriptor_` ты тоже можешь инициализировать в списке инициализации.
В смысле? Это же не enum class
> leechraft
> американцы
НУ ТЫ ПОНЕЛ!

Ок. Попробую что-нибудь сделать.
Perdón Andrés, pero preferí editarte el comentario y que no estuviera público en GitHub. No sabemos qué información podemos estar comprometiendo a futuro.
No, me parece bárbaro, son cosas que se le escapan a cualquiera y viene muy bien que alguien las vea.
Is this so that you can double click on the icon/corner and close the app? 

If so, I cannot get this to trigger, ever.
@b97pla seqmaster?
yes. that's good. I was lazy when writing this.
Need you to change this back to root or add it to your .gitignore file so that it doesn't mess with everyone's database settings.
Use absolute url from UrlGenrator
please remove extra parenthesis and spaces
How do you suggest I test it against rails 2 and 3 ?
Man, that's expensive.
done. added a comment
bela informs me, that he is not involved with this anymore. I don't want to change the API. Best thing would be simply to mark the method deprecated.
Anyway, the problem is related to the orientationLock in VideoPlayer.qml ... I can't reproduce the bug without setting the lock
эюя себе! эко я себе в спину ножом. --amend не возбраняется? для чистоты коммитов.
These are clearly config parameters, just like the resolutions etc.
This seems like a really good use case for RightSupport::Ruby::EasySingleton ...
Added inputs for both and tested.
You're calling the block with `response.body` (a String object), but NSXMLParser is going to expect a Data object. You should probably return `response.body.to_data`
Pois é, esta era uma questão na qual não identifiquei uma maneira melhor, pois como o render irá saber se o feed é de navegação ou é de acquisição para utilizar o content type adequado?
possibly remove this, if we are sure it won't be used
Here and after - that is not the best way
is $_FILES['uploadfile']['tmp_name'] guaranteed to be set here? or will we get an undefined index error here if no file is posted?
Maybe the dates in the future option should only be allowable in cases where you have incidents with dates in the future, instead of opening it up completely all together, which would mean having to check against incident dates. 
Regarding selection of both dates, Mmmmmm, sounds viable. I don't see why that can't be done :)
Use AND instead of &&
https://wiki.ushahidi.com/display/WIKI/Coding+Style+Guide
Should we test for a small number of transactions, rather than calling bsearch immediately?   If it's just a few transactions, might as well walk the list instead of doing a binary search?   Alternatively, we could inline our own bsearch, it's not a lot of code?   I'm not arguing one way or the other, but I figured you inlined this code for a reason.
OK, I'll extract the variable so it will be more clear, thanks for the feedback.
- Are you sure ``$context`` has the correct type as ``*`` is not a sub-type of ``resource``? Please also check line 203.
- Are you sure ``'ssl'`` has the correct type as ``string`` is not a sub-type of ``string``? Please also check line 203.
- Are you sure ``'capath'`` has the correct type as ``string`` is not a sub-type of ``string``?
not used below
Opened #10 to track this.
space before null.
Consider wrapping noSuchMethod code in backticks
how does this affect all other documents that have this class?
I'm really not a fan of this method. If you have suggestions on improving it, please let me know.
p-l-e-a-s-e
Hehe, não tem problema. Se eu continuar curioso posso atacar isso da maneira burra: pegar num dicionário, fazer MD5 de tudo e comparar. :P
It is: https://github.com/collective/tinymce/blob/3.4.7-plone/jscripts/tiny_mce/tinymce_wysiwyg_support.pt. I merged it just now: collective/tinymce@9f06db9374
Yep, looks fine. You have my blessing!
And made constructor private.
These two tests for minor should also have "and major >= 0".
Hm, so you just send URL and then client should do another request again? Hmm.
(This is just an idea, but somewhere around this lines I think it would be most useful to users. Just having a panel to display info is unnecessary.)
Maybe you should read documentation about queries we currently have and reasons for why they are like that. Also comments on the original pull request for this feature could help you. Then you will understand how the query works and what is that condition.
`rage_limit`, nice name. :-) So, `rate_limit` is correct.
I want you to make a difference between what data and how you are storing it and what data and how your are displaying it.

Because we have a source that is providing us with data already in machine format, it is the best if we try to simply map to it in our local version, we simply copy data from there to our database. So, what they have is:
 * time when prediction was made
 * timespan of the prediction
 * different values for that prediction

Once you start storing that into the database then you decide which and how you will display that data.

> so u want me to save all data like windDirection windSpeed humidity pressure cloudiness fog lowClouds mediumClouds highClouds at all possible timespans ?

Yes.

> but this data is not accessible at all hours ?

What you mean by that?

> should I make an array for each data and save it ?

Array? Why? Can you provide an example of what you mean by that?
`FormView`.
But schema defined in #278 supports this? You have a `Panel` document, which can have next to `layout` value any other property which might not be connected with the layout?

So why are you having one more level of indirection? Compare proposed schema in #278 with yours. Am I missing something?
While only this item was added `CompositeType.cs` the whole file looks changed probably due to line endings.
there are five bits
Recalculation is not needed, splitAmount already contains this value
Looks like my comment on the previous pull request didn't get posted. Silly iPhone...

Please change the regex to this: `/(Acceptance|Integration)( ?Test)?\z/i`
Shouldn't this return getForUpdateSkipLockedString()?
`'{0, "\\x30"}'`
Oh, you have changed the algorithm to copy the array. Why is that?
No need to check for `resource`
Ouch, that hurts. Coming soon !
x[nan_idx[:,None], nan_idx] would avoid a copy here, I don't know if it matters
or switch to use ``min`` as in my other comment, which counts only one
Appending elements to "where" as you create them results in unnecessary reflows and the expensive kind of DOM building if "where" is already in the page's DOM. Building up a set of elements then bulk appending them is better. I think jQuery supports this kind of thing.
method only needs builder parameter
typo spelling
I actually removed the constructor that only took 1 argument, since it seemed pretty silly without the add() function to add additional profiles.  And the list argument is now `std::list<SBProfile>`  (no pointer).
There are a lot of white-space changes in this file.
Could you turn auto-format off in your IDE please?
Check response code.
I really want to think more about our use of config, and how it's passed around and used. I worry things are getting more complicated and less obvious But I'm not sure what a better approach would be. And given this is needed asap then I'll merge and think about it subsequently...
exactly. especially open genesis is not interested in the minutes of time when the class was created. nobody cares (link to lurkmore required)
Yes, you are. It's exactly because of test independence that there is 1 assertion at 1 time.
If I were to assert both A & B at the same time it would violate test isolation
The original code from Devise was not a Ruby expression. It was plain text with the `#{}` mark within it.

You changed it to `%p=`, so the content of `<p>` is a Ruby expression. The `#` character is outside an string, so it is a comment, not an interpolated expression.
Not under review.  However, I think the model is to write output to one of the PowerShell streams (error, debug, verbose, output)
You might want to default options to {}
I'm a bit confused by this change.. you are reading the link from c->link.. and then about 100lines down the function it is overwritten by db->link.. seemingly without any specifc reason.. did you just forget to remove that line? c->link and db->link should be pointing to the same object
This should be `LoginViewController`
So I might have read the same question but used a different answer. I'll see about implementing the shell-only (+ standard readlink) solution.
Like before, could we indicate that this method requires user interactions, like `StartAuthenticationFlow` or something?
@marcw I mean this:

```php
<?php
if ($this->repository instanceof UserProviderInterface) {
    $refreshedUser = $this->repository->refreshUser($user);
} else {
    $id = /* ... */
    if (null === $refreshedUser = $this->repository->find($id)) {
        throw new UsernameNotFoundException(sprintf('User with id %s not found', json_encode($id)));
    }
}
Indentation doesn't look right.
I can delete my repo and refork, but I don't know what exactly you're talking about.
Not sure if it matters, but keep in mind that VCS_BRANCH and VCS_TAG *can* have spaces in them.
Of course it does. Where have you been the last years?
Oops, my mistake. Fixed!
wp_insert_post() only returns false on failure, so you only need to check `if ( $post_id )`
Agreed, and the for loop seems unnecessary. The bug is a great catch.

Merging and making a change.
That sounds sensible as a business rule for now.
Missing heading underline?
`inline` not allowd in pxd files. Please remove in all pxds.
Regarding the TV filter: I was planning to implement a more modern approach to the TV minimization problem. Though I'm not sure when there will be enough time for this. See: http://www.ipol.im/pub/art/2012/g-tvd/article_lr.pdf
Maybe use `np.arange`?
What about renaming `sort_idxs` to `increasing_probas_indices`?
Defining arrays like this does not allow fast indexing (this was true in cython <0.16; I'm not sure if it's been fixed that since then).
> I myself am pro sklearn.neural. I certainly won't forget this.

+1
Comme tu le faisais remarquer, va falloir automatiser tout ça...
Mind changing the message to: "Modifying a document is not allowed" ?
Why three lines of

    pinger.waitForConnection( 5000 );
Don't we have a lookup table for this somewhere? Other than that, looks good to me.
What is this? Why do you have git submodules here? Why do you commit that?
`case` statements need indented.
Looks like this fullName should be a StringAttr ..
Yes true, changed
Should there be short forms of these options too? e.g. ECLOPT_PROCESS_S ("-p") ?
I'm not sure that visual studio (or c++) supports returning a function that returns void.  (I often wish it did.)
Synchronization objects have replaced the explicit locks and unlocks.
I'm not convinced by this use of numRows.  numrows is likely to be very close to maxRows (e..g, within 10% once 10 rows are added).  If anything it would make more sense for it to always = maxRows.
Good point, I think at this point then, unless you spot other issues, I'd be tempted not to change again.
strictly speaking it should be using maxRows.
Why is this configurable?
ha i was just noting these pep8 problems, in an unrelated bug :)

break this commit out to it's own PR, better form in general (we want to be able to back out or otherwise examine functional changes separately etc.)
The implemented behavior is as described by : https://github.com/WindowsAzure/azure-sdk-for-node/issues/354.

Also, we want to minimize breaking people and, as such, taking into consideration something that is used by the emulator.
Reminds me of a poem from my youth [I Eat My Peas with Honey](http://www.poetryfoundation.org/poem/171639)

> I eat my peas with honey; 
> I've done it all my life. 
> It makes the peas taste funny, 
> But it keeps them on the knife.
remove all the changes that aren't linked to this test case.
Yes, please make it /api/google/handle_callback to match canvas.
I got used to "var" because it makes code shorter and easier to refactor (when renaming classes or introducing interfaces). With VS 2010 I get "ConfigFile" as tooltip when the mouse is hovering over "var". Right click --> Goto definition goes to definition. So I see no problem there (the drawback of "var" is that an IDE is needed to see and navigate to the type but I assume most people do).

But since it is also a matter of taste I will not insist. Shall I revert the line?
Please use the 5.1 schema
Why add häfte.tex to gitignore?
Why only the head of the list?
La fonction a pour but de n'ajouter dans la file d'attente qu'un job ne s'y trouvant actuellement pas.

La ligne vérifie simpelement que tous les args du nouveau job sont identique avec ceux d'un job déjà contenu dans la file.
Avec un array_diff, la vérification ne s'éffectuant pas dans les deux sens, je ne serai jamais sûr que les objets sont strictement identique sans devoir regarder précisement le retour de la fonction et ne pas me contenter d'un simple count.

Non ?
This should be single-quoted, as far as puppet-lint goes.
Did you forget to use timeout?
Wouldn't it be better to read the entire packet and then parse it, thus not leaving the socket open?  I like StringIO for this, but either way just parse it using similar logic so you end up with a hash like info_pkt['data'] = sock.recv(packet_len) etc
you probably don't even need DefaultOptions at all.
no reason to make these more lines than needed. only if > 80 chars is a good rule of thumb.
@stefanv fixed in subsequent commit
Oh, terrible bug. Renamed the variables in one of the last commits and totally mixed them as a result.
Hmm if the radii are equal, the radii squared better be, too.  Of course, you're not enforcing the invariant that `radiiSquared===radii*radii` anymore for some reason, so maybe this is needed after all.
应该和键盘命令的枚举合到一起，因为都是功能映射而已，攻击\防御没规定就只能映射到鼠标的。
GetHashCode must return the same value for two values that are equal. Based on the definition of Equals above, this should be:

```C#
return this.name.GetHashCode();
```
On Android, it can also be called after the section is added to a table. It won't throw exception if the section is already added to a table.
It's there...probably just not visible. Check the .children property.
I know, it's my coding style, I guess. I will keep it in mind for next time. Thanks.
I would name this to something less confusing like 'waitExtraFrameOnResume', and also leave a comment on what you are doing here.
Either remove the '{' or close it after 'return;' on the next line.
You should include high precision times, try making 'ss' into 'ss.SSS' to get at least milliseconds?
there should be `each` used here, not `map`
To be fair, I was sleep-drunk at the time. But this is good to know.
AFAIK since it's already trusted you can do cast(T*)cast(void*)_value;  class reference is cast-able to void pointer
Why the addition of alignment here?
Is there a difference between this and `R r;`?
> It seems to me that you're putting this note here just because you just found some calls in Phobos...

Not really. I'm not that self entitled. Actually, it was the other way around. I was looking at walkLength because I was curious about how to find the count of a narrowString.

Upon seeing the implementation I though: "Oh. Wait, this is actually an algorithm...", to which I set out to find any miss-usage in phobos. And sure enough, I did.

I agree with your points, and hesitated to put the note for the same reasons you evoked. That said, I feel that walkLength *is* more vulnerable than other algorithms (because it doesn't feel like one), so decided to put it. I know it is redundant, but I thought that function really deserved the reminder.

If you both think the comment is useless and badly worded, I'll remove it.
Sorry - the naming convention: useThisNamingConvention instead_of_this_naming_convention.
You don't need to keep a reference to the group in self. the groups are available globally.
Put the null check above here, please?
Link should be http rather than https, but otherwise fine.
Oddly enough, \'' renders as \' in the user's web browser. However, changing it to just \' (which would seem to make sense) is apparently a syntax error in YAML. So as a workaround I used the UTF8 curly apostrophe.
Let's make this `*args`? That way I could just do `@allowed_methods('get', 'post', 'update')`.
I was unable to find the requirement to name variables after their types; I think that the word "value" is already descriptive enough and does not need the type prefix. Also, I think I saw a statement in Cwalina's book that discourages using type names in interfaces and variables.
performance, json_encode will cause overhead, thus we do not do json_encoding unless there is a value.
used in the controller on line 49
thanks for the rails intro, through out these comments.
There's no chef server available in the dev environment.
Für die Leserlichkeit bitte folgendes verwenden:

if($order->getState() != Order::STATE_DELIVERED){
...
}

Gefahr des Verlesens bei == ist (zu) gross...
please always use brackets
И зачем это здесь?
const QString& text
Init list

и ниже тоже
Du könntest hier (zum besseren Verständnis für mit Bitwise-operations Unerfahrene) auch `CCFramework.HasEnumFlag()` nutzen.

(EN: you could also use `CCFramework.HasEnumFlag()` for better readability.)
> Throwing a sort of an array dereference exception would be just confusing.

That's not what I'm saying we should... I'm saying that throwing `NullPointerError` is inconsistent, unreliable, and confusing. I say this a systems programmer who knows what the resulting assembly actually does. As such, I want an `InvalidMemoryError` because I am not dereferencing anything that is the value `0x0`.

@klickverbot What is your point? I am saying I want an `InvalidMemoryError` instead of a `NullPointerError`. I don't see how that makes this module any less resilient to that problem.
So close, but you missed on just two lines up!
Since this is original code, this is probably a question for @markfisher ...

If the delayer is not given its own task scheduler; this might change the characteristics of the global task scheduler.

Is that what we want? Or, should we only make this change if this element got a specific scheduler.

For example, if we have two delayers, one with the option true and the other with it false only one will get the expected behavior. I realize the same would happen if two delayers get the same explicit scheduler, but it doesn't seem right to allow components to mess with the global scheduler.
Actually, this works too...

````
	<util:list id="patterns">
		<value>org.springframework.integration.jmx.config:type=*,name=testPublisher</value>
		<value>org.springframework.integration.jmx.config:type=*,name=testPub*</value>
	</util:list>
````

... and it's a little more concise.

I will take a look at your suggested improvements.
Don't we need to make this @Transactional now we're doing multiple updates?
Shouldn't this be false for null? Otherwise we'll allow the CT to be set to null.
Because I wanted "v" in the doc version.  The generated version has them though, so I'm not entirely sure why it was necessary to add "v" in here to get it to generate correctly.  :shrugs:
I think both 'the' or 'this' would work.
this will fail if we're on https.
Program to Interface

Set<String> REPORT_NAMES
revert this change -- should remain -SNAPSHOT
does getTopNodes only need an aclHelper? no securitycontext?
How have you managed to get rid of this?
either create getters and setter or make it at least protected
I don't see why you'd have to bother with them in `fit` or `transform`. I was thinking along the lines of

    @property
    def norm(self):
        return self._tfidf.norm
Hmm, this is unfortunate. Not quite sure what we're testing with the above anymore, then?
нужна стрктура Интервал
I need to set clientDownloadDelegate to the mock version when testing which is easier to do by overriding `init()` and setting it here. Maybe 

`if (shouldDownload()) {
// set clientDownloadDelegate
...`

would be better?
that registry is part of what we call Engineering knowledge base
The leading zero in comments may cause confusion with octal numbers
Intentional - the rest explorer screen are unusable on a small screen.
Also, once you target honeycomb or higher, you can see that the async rest calls are broken.
This checkin reveals the bug and then fixes it at once.
Первый раз для того, чтобы применить стиль к треду. А второй внутри foaAll, чтобы удалить стиль из треда. По-другому никак.
fnSucc
Че енто за ърня?
I was able to get tests using JNEXT working here - https://github.com/blackberry-webworks/BB10-WebWorks-Framework/blob/b748d9ace51facfb32ed60be0d18ef06cb382dc8/test/unit/ext/blackberry.event/index.js
This may not be needed.