labofsahil/github-event-dataset-2012 huggingface dataset:
btw, it looks like the BlockDiagonalMatrix is working as I would expect. I tried:

```

>>> BlockDiagMatrix(Identity(3),MatrixSymbol('a', 2, 3)*2,Identity(1))
[I,   0, 0]
[0, 2*a, 0]
[0,   0, I]
>>> _.as_explicit()
[1, 0, 0,      0,      0,      0, 0]
[0, 1, 0,      0,      0,      0, 0]
[0, 0, 1,      0,      0,      0, 0]
[0, 0, 0, 2*a_00, 2*a_01, 2*a_02, 0]
[0, 0, 0, 2*a_10, 2*a_11, 2*a_12, 0]
[0, 0, 0,      0,      0,      0, 1]
>>> BlockDiagMatrix(Identity(3),MatrixSymbol('a', 2, 4)*2,Identity(3)).as_explicit()
[1, 0, 0,      0,      0,      0,      0, 0, 0, 0]
[0, 1, 0,      0,      0,      0,      0, 0, 0, 0]
[0, 0, 1,      0,      0,      0,      0, 0, 0, 0]
[0, 0, 0, 2*a_00, 2*a_01, 2*a_02, 2*a_03, 0, 0, 0]
[0, 0, 0, 2*a_10, 2*a_11, 2*a_12, 2*a_13, 0, 0, 0]
[0, 0, 0,      0,      0,      0,      0, 1, 0, 0]
[0, 0, 0,      0,      0,      0,      0, 0, 1, 0]
[0, 0, 0,      0,      0,      0,      0, 0, 0, 1]
>>> BlockDiagMatrix(Identity(3),MatrixSymbol('a', 2, 4)*2,MatrixSymbol('b',0,2)).as_explicit()
[1, 0, 0,      0,      0,      0,      0, 0, 0]
[0, 1, 0,      0,      0,      0,      0, 0, 0]
[0, 0, 1,      0,      0,      0,      0, 0, 0]
[0, 0, 0, 2*a_00, 2*a_01, 2*a_02, 2*a_03, 0, 0]
[0, 0, 0, 2*a_10, 2*a_11, 2*a_12, 2*a_13, 0, 0]
>>> BlockDiagMatrix(Identity(3),MatrixSymbol('a', 2, 4)*2,MatrixSymbol('b',2,0)).as_explicit()
[1, 0, 0,      0,      0,      0,      0]
[0, 1, 0,      0,      0,      0,      0]
[0, 0, 1,      0,      0,      0,      0]
[0, 0, 0, 2*a_00, 2*a_01, 2*a_02, 2*a_03]
[0, 0, 0, 2*a_10, 2*a_11, 2*a_12, 2*a_13]
[0, 0, 0,      0,      0,      0,      0]
[0, 0, 0,      0,      0,      0,      0]
>>> BlockDiagMatrix(Identity(3),MatrixSymbol('a', 2, 4)*2,MatrixSymbol('b',3,1)).as_explicit()
[1, 0, 0,      0,      0,      0,      0,    0]
[0, 1, 0,      0,      0,      0,      0,    0]
[0, 0, 1,      0,      0,      0,      0,    0]
[0, 0, 0, 2*a_00, 2*a_01, 2*a_02, 2*a_03,    0]
[0, 0, 0, 2*a_10, 2*a_11, 2*a_12, 2*a_13,    0]
[0, 0, 0,      0,      0,      0,      0, b_00]
[0, 0, 0,      0,      0,      0,      0, b_10]
[0, 0, 0,      0,      0,      0,      0, b_20]
```

I'm glad to see that it handles the 0-length rows and columns.
If factored two functions out of it; it will be in next commit.
just trying to show the convention for numbering as described in the docstring: top face, next 5 equitorial faces and the 5 below them, and the bottom face. (And the list of indices is too long if they are unwrapped.)
this seems like something that should be done through the printing module. I am not sure as I do not know what exactly you want to do. Anyway, returning a string does not seem like a good idea, because you can not do any operations on it.
This else block is unnecessary, it will perform this by default.
Should a note be added that this overrides "from future import division"? It seems pretty clear that this is the case, though.
imo, if using phpmyadmin, it's better to use the import function.
This include will be required in other html files. Run tools/find_missing_includes.rb to see which files need to be updated.
We typically extract the final method and use it throughout, not the namespace.
yep i've just pushed the fix to that typo
Potentially. The main (only?) difference from PairActorSupervisor.findActor() is that it will create an actor when one isn't found in the registry. The PAS creates actors eagerly at startup, whereas in the EscalationManager it seemed better to do it lazily.
is it worth adding the validator flag while you're here?
I'm confused by these changes which seem unrelated.
Add @return null
Wrong description?!
This will have to be changed any time a config entry is added to the fixture file. Not good.
Is GitHub showing this wrong or didn't you remove the defines when moving the constants into class variables?
Do we not want this as a permission setting on the module itself?
This looks wrong, per http://tech.yipit.com/2011/11/16/183772396/. The diff is already correctly (?) retrieved earlier in the hook for linting.
can not use isset() ?
Are negative values allowed? Should test them if they are.
Any particular reason for the space between the second quote and the colon? I've never noticed it done in the rest of phpBB, so it's inconsistent to do it here.
Why would there be no need to delete?
Its part of the template events infrastructure that you made... 8efb6635db3af782e714595f8cc1005a6dbffb83
This is fine. I'd only worry about chrome or firefox---if you know what css tends to be cross browser compatible go for it, but testing more is too much effort----we'll wait for folks to have problems and then deal with it. 
Plus, I'm expecting us to redo the layouts and css later as we iterate / polish / get feedback, etc.
Not going to hold you to this though :)
Classes have private visibility by default, no need to specify it.
one last thing: could you use `tools.isArray(a)`, please? And don’t forget to include the tools module ;-)

Background: The iframe runner might create sub-iframes for sub movies. Arrays from different frames might not pass this test.

Looks good otherwise. Thanks!
Please use the form

```ruby
Time.parse("2013-03-27")
```

Don't inject a timezone unless the timezone is explicitly included in the response.
Sorry to be a stickler but can you add spaces after each ':' in the object, so "{bottom: 0" and not "{bottom:0" - our js hint build task is going to fail with this formatting
This rules dude.
Not to download file from github and put it to repo, as aszlig said?
Also, why strictness on dependencies in cabal-files is removed?
we had been using ------------ instead of ======= and I believe some code in dochelpers might even rely on that
I still contend that parsing a string is a strange way to do things, i.e. "GRIB -> seconds" instead of "GRIB -> string -> seconds". A direct conversion would be simpler, less error-prone, and faster.
floatTag.changeLoc = _changeLoc;
Minor coding style nitpicking: as concise as it may be, this is not readable. Some much easier to understand would be for instance to add a check just before the ``for arg in args:`` line:

```python
    if arg == numpy.newaxis:
        continue
```
wrong comments. Should be RandomStateType.
I think Ariel will probably name this petWatchdog() instead of kicking.
rows_from_table
Use one line comment starting with # for this type of comments
the name of the method does not imply what it is doing ?. I think it should be notifyUserOfNoAnnouncedJobs()
Of course! I'll also test it (and just noticed there is a problem with `force_text` in the default method).
unset removes the properties from the class, which can lead to E_STRICT errors later if something tries to read them (as it will try to read undefined properties), which is likely to happen if you use 2 instance of the class. You should set the properties to ``null`` instead.
For a simple typo we could theoretically fix in merge.  I'm inclined to say here that there will be at least one followup commit to account for some other review feedback and the change can be incorporated into that.
It's up to the number of attributes. The most number of elements we tested is about 1500. I want to know why this is not scalable. Using this method, the aggregate process is the same as using ArrayBuildState.
hm reordered... but does not really matter i guess. it is for testing only anyway
Love it. I'll fix this.
Yes! :-)

I was thinking that we remove the sys.argv munging from `mopidy.core`, and simply do a filter on `arg.startswith('--gst')` here before we pass the remainder of `sys.argv` to `Gst.init()`.

I guess we also could move `Gst.init()` into `GStreamer.__init__()`, removing even more magic done at import time.
No, I think having the accept language be the default will be fine.
I've corrected this.
Thanks
If the tarball is a `.tar.xz`, it needs a `depends_on 'xz' => :build`
This would be a little cleaner with `<<-EOS.undent`, which will allow you to indent the string in the method without adding extra whitespace.
firstName -> prenom
lastName -> nom
username -> login
s/Try for FF doesn't have a setter for these property's./Try for Firefox, which doesn't have a setter for these properties./
This line and the line before occur three times in the class. You can extract it to a method fieldsAreAnnotated().
Mostly, just provide a raw object to the model constructor, and see that the model that's returned has the properties you expect.
I'm not crazy about leaving stubs for future support. These would be clearer if they were all written as
```
if (!this.useHtml5Player || !this.player) { return; }
// ... do stuff

If/when we add phonegap audio support, this can easily be changed to whatever we need.
New question: it looks like we _do_ show attribute value hints for unquoted attributes in some cases.  So, is this comment incorrect?  Or is this code supposed to block hinting for all unquoted valued, but is buggy?
Nit: it could be clearer that it's an array (since it looks like inclusive/exclusive range notation, at first I thought it would be a bag with 'start' & 'end' properties).
Externalize string, ``Tab Size: {0}``
Function name should be ``testCommand``
Is this an Apache conf file?
I think toBeFalsy() is a more robust check here.
One more note: it seems like we'll want this timestamp-based caching pattern in multiple places (CSSUtils could benefit, as well as Quick Open... and it's very similar to existing code in FileSyncManager).  Is there a way to generalize this, perhaps by baking it into DirtyDocumentTracker?  Or maybe even folding that whole class into FileIndexManager's responsibilities?
Also, the test I was suggesting we add here is `<div dir=""`, not `<div dir="`.  We should keep this one, but I still think it'd be good to add the other -- we don't have any tests to make sure insertion doesn't double the closing quote, etc.
The problem is: I only need it for matching things like `#doIt` or `table#cool` and only for the preceding identifier to be replaced the the `replaceText`
Such a very small use case, shouldn't move to `base_handler`
note note
OK. Thanks for the tips anyway. I just updated the code and pushed it.
Not sure if it works with Emacs 23. I'll have to write some tests to exercise this code and run the tests under both 24 and 23.
i'm wondering if some of that method can be refactored with the one of DataElementExportController. isn't the code very similar ?
Done last week fyi ;)
Nice addition.
No, it should be:

```
raise forms.ValidationError(self.error_messages['bounds'])
```

And now make it work like this. :-) (Hint: Set `default_error_messages` attribute of `LimitedDateTimeField`.)
Add `"units": "%"` please
How about this:
"Set lastTrackBottom to 0 initially so that if there are no tracks, we can still add a TrackEvent to the track-container."

And this on line 50:
"Otherwise, lastTrackBottom will be set to the bottom value of the rectangle of the bottom-most track."
Even better:

var i = dialogs.length;
while( i-- ){
  ... dialogs[ i ]...
}
do we have access to our classList shim here? If so this is fine.
Should be 0
Are 2 lines standard in the js world? I always find it a little awkward.
Shouldn't all these be removed now?
Patched and released to RubyGems.
I've splited in two steps:
```
Given /^there is an Agi Database$/ do
  @awesome_db = FactoryGirl.create(:database, :name => "awesome-db", 
                                              :availability_zone => "us-east-1e", 
                                              :security_group_name => "sg-of-awesome-db", 
                                              :ec2_sg_to_authorize => "ctms-distro-app001java")
end

Given /^I'm viewing the Agi Database$/ do
  visit database_path(@awesome_db)
end```
Just wondering is this a new coding standard? It's just that I only see 10 mentions of "@throws ...NPE..." and 4 mentions of "@param ...non-null..." in the entire Nexus codebase, but I suspect that many functions will NPE when you pass in null. Also maybe we should consider using the standard JSR 305 @Nullable / @Nonnull annotations to make it explicit to tools rather than hidden away in the javadoc.
would prefer use hamcrest or Fest Asserts

In future avoid using assertTrue/assertEquals when testing measurable conditions so that when it fails, we have a more meaningful message than something wasn't true. Using assertThat in this case could for example tell us what it was equal to or instance of.
1. You probably meant to use private[this]

2. The combination of a mutable datastructure and a var doesn't make sense. If its mutable, you can make the reference constant.
We can use "find" here since it's only one entry we're looking for.
I wrote a test for the case when is no DB, and a few others for different arguments given as `character`. I noticed that there is no need to check for a `TypeError` since `character` is a string even when you give a number as the parameter for the request.
If this isn't necessary, it should be removed.
There is no ‘Classes’ directory in the repo, so that first entry isn’t needed here. It does no harm, but just a FYI.
Here I use <code>-moz-calc()</code> is because the button can use the rest  width after <code>(25% - 40px)</code>
The 40px is the width of margin-left + margin-right, so I can keep the button always 40px to the screen edges and be placed center.
(In the future, maybe landscape mode and different screen resolutions)
Higher up, there was an instance where you also accepted ``d``.
Here's an example of the sort of thing that worries me.  Lets suppose we have two `NDData` images `a` and `b` we want to combine: `a` uses a boolean mask like the one here where False is "good pixel", and True is "bad pixel". `b`, on the other hand, is a (slightly) more complicated integer masking scheme where 0 is "good pixel", 1 is "cosmetic defect", and 2 is "saturated pixel".  If I then want to add these two images, I naturally expect False and 0 to combine to give 0, but all other combinations should give whatever the integer value is (e.g. False w/ 1 -> 1 and True w/ 1-> 1, False w/ 2-> 2, etc.).  But that's not what happens - instead I get all kinds of weirdness like False w/ 2 -> False.  

The key point is that you can't count on boolean masks combining with boolean masks all the time, and given that, it seems dangerous/confusing to override the standard numpy behavior.
@mdboom - definitely agree, this error reporting was just a placeholder while working on the main functionality.  All of the numerical error codes returned by any SOFA routine here should be translated here into the relevant error string message that gets raised.  I might leave this for now as an issue to deal with later.
Ah I missed that, because it's in an #ifdef, which my compiler ignores, because I compile the GUI version. It should be a StartShutdown().
You should have spaces around `=>`
move() doesnt have a default value either. and both shoudnt have. they make no sense without since you always need to pass sth to make it actually do sth.
Also - removing the default doesnt make it NOT take a string as a value.
While the salt string generated is used only for hashing internally it could be useful as a random string generator which is often needed for various purposed in an app. Having this function as public would avoid having to write your own function.

Just a suggestion though. I am fine if making it protected if that's the general consensus.
What about userland dbo's that don't implement this method?
Sample code showing how to add a GoogleEarth plugin to a Viewer (or gxp.Viewer?):

(ditto for other sample code change requests below)
It passed on ie9/vista on sauce
This method helper name could be much better. For starters, it's using camelCase and under_scores (ruby methods shouldn't have capital letters in them). 

Also, the name itself isn't very descriptive. What is this method doing? I have no clue from reading the method name. Is it adding a class for character-length validation? If so, a name like `max_length_validation_class(max_length)` would make much more sense to me. `max_length` would be an integer parameter that gets passed through and assigned in `limit-#{max_length}`. 

Also, I don't see why you would need to pass in and double check the model name... I'd probably axe that.
Don't need explicit return
its to support JMX and JSON objects i think, you cant use complex objects
Please try to follow the coding style that we have been using in the JavaScript.  In this case it would look like:

``var IPython = (function (IPython) {``
is this a String or enum (just askin)
want to be sure about this change -- the javadoc matched the code previously, i've changed both, because i think that is the direction we want (the location specified in the predicate should equal or contain the input location, not the other way around).  that seems to be what the predicate name suggests -- "locationEqualsOrChildOf(" + location.getId() + ")".
this class has too many responsibilities, and the word "Cloud" is way overloaded.  This needs to be broken up into delegates, IMHO
Why not remove this completely?
correct superclass
In the bug (801587), this was discussed. We did not want to use this page because, at least right now, it sends people to a page about Mobile Firefox. Ideally we would like to have a button that just started a download, but decided that it was a bad idea to reimplement that logic.
I'm wondering if either of these divisions could produce a DivideByZero error. You could do the easy thing and do:

    if num_docs and total_visits:
        coverage += ((float(up_to_date_docs) / num_docs) *
            (float(visits) / total_visits))
ES can add a timestamp field which is essentially the same thing (scroll down to Timestamp):

http://www.elasticsearch.org/guide/reference/api/index_.html

But I think we're using an older version of ES in production that doesn't support it. I didn't want to spend the time to figure it out, so I just implemented it by hand.
Definitely worth mentioning that the reply text needs to be less than 140 characters and can't include any additional wiki markup.

Also, these are replies, so they include the person's twitter name as part of the 140 characters. So maybe they should really be 130 characters or less?
Is this not a duplicate of the same test case by the same name in `test_productversion_env_resource.py`?
It's funny that you use ``error`` for debugging, I usually use ``debug`` instead. Anyway, could you please remove those logs?
Use syntax "if :" / "endif;" instead of "if { }"
This should be simply ``CacheDriverInterface`` as you have a use statement
Is:

     $this->currentLine[0] === '-'

better?
Doing so wouldn't guarantee that the constructor actually uses the method.
There are a lot of other SQL queries which don't return result sets. To avoid confusion it's probably better not to try to list them here.
Or instead of adding application.conf to .gitingore we do this:
mail.smtp.pass=passwd.pwd

where passwd.pwd is the file that contains the password and then we add passwd.pwd to .gitingore. This way everyone only has to maintain passwd.pwd. passwd.pwd is less likely to change, so it is easier to maintain. 
How about that?
I pulled out the click event handler from the inline form into a stand-alone function and applied jquery click event handler where the validation of the email text field happens. It is more transparent than putting into the save handler.
We've been doing this `describe` call without parens.
No specific concern. Just wasn't sure about the intent. In an `ApplicationController`, I think every method could be private as they're helpers for other controllers, not exposed endpoints?
Please add a newline here
I'm not sure on this one. I don't like the idea of ```get_extent``` failing silently and telling me something that isn't really true.
I've yet to see issues with the Natural Earth or GSHHS datasets. I would like avoid a transform unless absolutely necessary.
lb is defined in the brush afaik.
It's the lookat block.
it would be better to separate them by comma imo.
Sorry I was looking at the tabs wrong, this makes sense as is.
Wonderful regression. Maybe I'll tell you how I fixed it in mainline if you ask nicely.
It's probably best to include a brief description and not just the number.
I had to require it somewhere so that it got picked up for the tests.  ArrayController seemed the logical place as that is where sortable was required.  

Any suggestions on another way to get the files picked up by the test runner?
But then the name of the parameter should probably change.
non-sync read, and not volatile
I went for deployment error considering that the component is not truly usable, without the injection.
Can this be left as subsystems-osgi-only.xml? I don't know for sure if we care very much about backwards compatibility of the examples but keeping the name should be ok in any case.
Hi Amos, why did you need to comment out the undeploy?
We need to change our routes generator to pattern match on binaries too. A test should fail but it doesn't, so we need to write one first.
I think it is. First you pull the 'real' messages from the database, then you concat the pending messages you have in your local database, each db with its particular order, so when you have it all in one, u must reorder it.

Could be done adding the pending messages on the correct position, but if we concat, we need the sorting after.
please could you explain me what is _this? thanks a lot
I suggest

responseSTKCommand({
   resultCode: icc.STK_RESULT_OK
})
I tried that but it doesn't work
Let me give it a shot ;-)
I have a different proposal for that instead of using the /shared/ folder. Please remove this from the current application approach (Embed it directly into your application).
I have changed the account type to "imap+smtp" and "activesync", display like "IMAP+SMTP" and  "ActiveSync".
Since POP3 is not supported, so just removed it.
The transition is too complex to implement. Would skip it this time.
(And here.)
Remove spaces around `Set Manually`
Oups, can you remove this one from the pull request please? :)
"auto-destroy"? That's not what QPointer does. QPointer is a weak reference to a QObject, that will be nulled when the object is deleted by some other means. Perhaps you want a QSharedPointer?
I think we need to pass Notifier.setup an array of the two notifier classes.  Also I think this should be probably done in janky_app after #setup in config/environment.rb and not in janky itself.
There is no particular reason for this. 

It's just that the precision goes down with this value being lower.

On Fri, Dec 07, 2012 at 06:31:39PM -0800, Jan Pöschko wrote:
> > +     = 1100.100110011001100110011001_2
> > +    """
> > +
> > +    def apply(self, expr, n, evaluation):
> > +        'BaseForm[expr_, n_]'
> > +
> > +        from mathics.core.expression import from_python
> > +        base = n.get_int_value()
> > +
> > +        if isinstance(expr, Real):
> > +            (num, real) = divmod(expr.get_real_value(), 1)
> > +
> > +            # converts the decimal part to an integer
> > +            # check http://stackoverflow.com/questions/4838994/float-to-binary
> > +            # for more answers
> > +            real = int(real * base**25)
> 
> why 25?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/poeschko/Mathics/pull/73/files#r2356020
ScalaProject has a ``javaProject`` field which contains the equivalent Java project.
Спасибо. Поставьте "+1" тогда в общих комментариях. Ну или как тут у вас принято? =)
Can we move this to Source.scala?
Here I am using ``SIGKILL`` because I found the SMTP server mock was not getting properly terminated, and after running tests there remained dangling processes.
Log these instead of printing them.
I fixed that, both here and in plPXPhysical (where I copied this code from).
docstring, not comment
```coffeescript
data.isSearch = type is 'thread'
```
You can just use `data.threadID` later in this function since it's only used once.
Parse the exception message, tell the user what version of Java they need?
Should be `} catch (...) {`
Please use the process executor instead of using ``exec`` directly.

Btw, ``exec`` does not capture the error output (at least on Windows) so it is a bad idea.
Please remove the ``@return void``
Okay I'm removing aliasrc
**Fixed**
closing brace of #ifdef
')
I really wish Windows apps wouldn't forget the newline at the ends of files.  Really annoying.
How can I do it better? Add few more 'if' statements with transitional hash? I don't see any way to do it cleanest...
If I skip this part cannot visual studio deduce compile arguments: "could not deduce template argument for..." and will generate errors for a call like this: normalize("const char* here", "/").The method will only simply convert a const char* or const wchar_t*  to its corresponding string implementation, what is wrong with that?
at this point, i think we can really comment it out.
See previous comments for `tun_recver.c`.
Can you add a check to see that the correct content is in the proper list? See https://github.com/inliniac/suricata/blob/master/src/detect-content.c#L551 for how you can get the content of the pattern. In this case you can do DetectContentData *cd = sm->ctx; then do the check based on the link.
With the changes above, we'll need additional tests to cover those cases.
I thought `import x` comes before `from x import`? At least I've seen that more often and prefer it personally.

</bikeshed>
you can remove ':default => 0' - the default value for config settings is nil, btw, so you can check for that later when you want to set the real default
Renamed from org-mode without actually changing the markup. Fixed.
It doesn't seem that useful to pass a function if it isn't reinvoked properly when its result changes.

The workaround here seems to be explicitly passing the function's dependencies in "updateLabelOn". Recommend documenting that to the user here.

If it is common to have a function that just passes through a particular slot of the model, you might consider supporting that case explicitly. (I don't know if this case is common.)
You're right, thanks. I didn't think about backwards compatinility too much.

But your naming proposal is also confusing - "long" implies the old setting, so it would also break backwards compatibility by changing the name.

Probably something like the following could be acceptable:

* $g_calendar_js_date_format (for the current setting, so it stays untouched)
* $g_calendar_js_date_no_time_format (for the new one where you don't want to see a time part)

Should be ok then...
That doesn't really explain why a `nsISupportsInterfacePointer` is needed to makes the clipboard's data available for the others application. It is something I figured out. Or do you mean I should add something like "To understand the copy action on platform side, see: http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsCopySupport.cpp?rev=7857c5bff017#530" ?
Does that mean that relative path in another package than addon package would be broken?
BTW, are will still using this metadata object somewhere in code?
Can we rely on the the fact that the 1st attach will always for the top frame?
Our code convention is `typeof(val)`
On propagated error I suspect this to fail, since `error.stack` will be always set. In some occasions it may work but that's if stack filter reduces stack to
`""`. This feels quite fragile now. Maybe it would be better to mark already handled exceptions and ignore them on propagation, for example by adding `isLoadError: true` to an errors created and thrown below. That way we can skip them, unless I'm missing something else now :/
Perhaps "Persona requires that JavaScript is enabled".
These locking imports aren't used and should be removed - or maybe they should be used? Does this command require locking?
I added data to each object, so that it inserts not empty objects. **But** I think I removed tests that explicitely test insertion of empty objects.
Please change to:

    if ('validate' === $behavior->getName() && $table->hasBehavior('validate')) {
good to remove
Yes it does seem a bit unlikely, but I'll test it for our core facts to make sure. I'm just saying its a risk we need to consider - nothing needs to be changed at this point.
The motivating factor there would be the "DSL" nature during class construction, which is usually why we have these variant "get or set" methods.  So that you know, not because you need take a specific action.
No worries! Thanks for all the work on this.
could you change this to `this.$element.off().removeData('tooltip')`
Non tradotto?
this part.
the same note as above
Because this exception has been superseded by DomainException now is unnecessary.
@shevron, I agree with you on the "http:/", "http:///" and "custom-scheme:", whether they should be valid or not.

Did some digging into the HTML5 spec: the Url validation should follow RFC3986 and RFC3987 as a *valid absolute URL*.  My impression from RFC3987's parsing rules, is that a *valid absolute URL* should, at a minimum, **only** have to consist of a scheme (file:/, mailto:, custom.scheme:)

http://tools.ietf.org/html/rfc3987
```python
   ipath          = ipath-abempty   ; begins with "/" or is empty
                  / ipath-absolute  ; begins with "/" but not "//"
                  / ipath-noscheme  ; begins with a non-colon segment
                  / ipath-rootless  ; begins with a segment
                  / ipath-empty     ; zero characters

   ihier-part     = "//" iauthority ipath-abempty
                  / ipath-absolute
                  / ipath-rootless
                  / ipath-empty

   scheme         = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )

   absolute-IRI   = scheme ":" ihier-part [ "?" iquery ]
```
Note the "ipath-empty" and "scheme" rules (which allow for  +/-/.).
This seems to be what Chrome is doing, with extra validations for common schemes (ie. "http:" and "ftp:" fail, while "http:/foo", "ftp:/foo", and "custom:" succeed).

In Firefox, it does not appear to be doing the extra validations that Chrome is doing (ie. "http:" and "ftp:" both succeed in FF).

My initial hope was that the FormUrl element, in it's default state, could be in parity with the browser validation. 

Since the browsers are doing different validations (some more helpful than others), I think I'd opt instead towards having the FormUrl element use a stricter/more helpful validation as a default. If the browser passes it's (loose) client-side validation, oh well. The user could always change the validation themselves to that crazy Regex if they wanted.

For the IPV6 tests, I had locally rebased with PR 1524 but still had encountered failures for:
'http://[::1]/'
'http://[2620:0:1cfe:face:b00c::3]/'

I may not have rebased and pulled in your changes correctly - I'll verify later on today and report back.

Thanks for the feedback all!
css license
This would extends ViewImpl instead
Can you make it scope?
To avoid ambiguity between `net.minecraft.server.ChunkCoordinates` and `org.bukkit.ChunkCoordinates`.
When I tackle named routes (refactoring linkTo etc) I'll move them up yes.

WebComponent? Controller?
Oh I see. Will do ;)
It should probably just be referred to as "Model-View binding". I'll merge this PR and make the change my self. Thanks.
curly braces are missing
Something here about using a new independent migration to remove columns.
Ok, I have pushed some changes. For now we will have just Module.split,
that returns a list of binaries. You can then use List.last to return the
list element. In general, we will need better ways to slice a list, we
could either implement it in Enum (for example, change Enum.split to accept
negative number as arguments) or add it just to List.  For now, I think it
doesn't make much sense to Enum (since it forces you to traverse the whole
thing), but we can worry about it later.
Indeed, that's not necessary (but quite safe given the use of the ConfigurationConverter). At the moment it's not possible to properly fix this given the deep freeze of eZ Publish Legacy. I add a todo for this.
eZTemplate is missing
Are you indenting with tab or spaces? please run repoman full to check whether everything is right.
"included" ?
Where is `Make.UNKNOWN` being created here? It's not?
This is now removed.
Indent here too.
I might be dense, but I still don't follow.
That's cool. As long as there's a good reason and it works :)
Probably more useful to have it automatically do the migrate. You never know what sort of wacky things you'll need to do when debugging, but might as well deal with that when it happens. DISREGARD!
rename the function plz
Replace with
httpdUtils.build_index()
yes, maybe it would be enough to return the domain ids ?

if not, I would use the domain partial instead
The top level `.gitignore` applies also in subdirectories, you don't need to repeat `Makefile` and `Makefile.in` next time.
This does not seem like a very good test for detect. It would match on their home page (http://bofip.impots.gouv.fr/bofip/1-PGP.html), which does not look like a single item import to me (but I could be wrong).
add some comment to this line.
why would we replace a configurable webpath url from the config, which is proxy compatible, with the url from the request object, which is not?
You don't want all the actions to be done with the file firewall.yml openned
The only line you need is the below one.
if you had the row be the index of the centroid (ie, the centroids matrix would be KxM), then this would be a call to `GetRowVector` instead of `FiltCol`
this is big and complicated enough that i'd prefer to see it as a regular test
This line is especially genius!
vertices
with -> using
Can you expand 'commentCreated' so it checks that a comment is returned?

Also, can you add a check for comment every time a comment is created in the tests? In the create comments tests, this should be a full check (level, alias, body, etc.). In other tests, an existence check should be enough. It's important that will also check that the comment returns when replying.
These are dispersed throughout the unit tests:

1. verify downloading user picture 
2. verify uploading, cropping and downloading of group profile pictures
3. verify the thumbnail is present in group search results

I've added one in for search results as well.
Re-take the image, selecting a couple values in the multi-valued vocab and selecting a single value in the other vocab. The red text from the image is unnecessary.
嗯。所有代码都是可改滴
I agree that makes no sense.

passcrypt is not plain auth specific
Shouldn't something like m_Seed = (rand()&0xffff) << 16 | rand()&0xffff; be fine? this looks odd.
Can you translate this to English please or remove it as I'm not sure it will add much.
oh no sorry, it does return the _first_ for "*/*"
Braces need to be put alone on separate lines as per the [coding style guide](http://codeigniter.com/user_guide/general/styleguide.html). And since it needs to be edited for that, you might want to do a *slight* speed improvement:

    if ($this->proxy === FALSE)
    {
        $server = $this->server;
        $port = $this->port;
    }
    else
    {
        $server = $this->proxy;
        $port = $this->proxy_port;
    }

This way we'll always have just one variable assignment.
We don't call MySQL "My" and we don't call MSSQL "MS".

PostgreSQL is called "PostgreSQL".
That usually happened when I calculated the byte position wrong causing assertion errors, but since dmd's unhanded exception printing format end's with this line anyways, I figured I should keep this check to avoid a Vim error if anything whatsoever goes wrong.
Спасибо! Это все от незнания какие методы есть у классов, какие когда лучше использовать, я как слепой котенок, который натыкается на все подряд — что нашел первым в гугле, то и использовал.
@nanotears "Метод должен заменить X процентов символов в массиве DNA в случайном порядке;" - для меня двояко это звучит.

"Также в одном из комментариев в обсуждении проекта Рахим отметил, что мутировавший символ должен обязательно замениться на другой. В текущей реализации символ A может замениться опять на А." - обсуждение есть обсуждение, а в заднии ничего про это не сказано.
отступы везде
`self.role_id ||=  Role.find_by_name(:user).id`
colors wäre besser auf off, damit es windows consolen compatibel bleibt. 
alle anderen (du + ich) können einfach phpunit --colors aufrufen.
dang, I sure wish I'd added name and id to the filtering for the RunResource.  Perhaps add a #TODO comment here to use them when they're added to the api.  (I just added those to the api in the master branch, and that may get deployed next week sometime when I fix another bug.
we don't need this `clearfix` nonsense! ;)
Word wrap this and the duplicate comment below at 80 characters.
Why "stateful?"
I don't know how valid this test is. Do we actually want to depend on `+zip:reduce:` subscribing to the same signal multiple times?
Another Commands: None
Perhaps this is another area for a separate issue? "Find all scripts not listing a command and document the command?
is it modified in this case?
Ok, a swe wrote the Epochs.copy I wasn't sure whether there might be cases
when the epochs modifies the raw...
What about Epochs.copy(copy_raw=False) as default?
Errors should be indicated using LOG_ERR() macro
Was removing these lines enough to fix it?
This code deactivate all the extensions that depends on the deactivated one.
For example:
Ext3 depend on Ext2 that depend on Ext1.
If you deactivate Ext1 it will automatically deactivate the other two on cascade.
Btw on line 236 it's better to use 'extensions.active' since we don't need to deactivate extensions that are already inactive.
I don't really like the array-indexing here, but I'm not sure that the approach I'd use is much better:
```python
        genfields = dict(zip(['IMSI', 'Subscriber type', 'OperatorID', 'SessionID', 'ValiPort'], genarray))
```
agreed. will update in a separate pull that adds saner boolean input transformation for all variables, not just here
Nice use of the 3 arg version of `on`
It is maybe better to add a use statement on top of this example to avoid to long lines:

    use Acme\HelloBundle\Newsletter\NewsletterManager;

        $newsletter = new NewsletterManager($mailer);
it should be ``Override Symfony Structure`` IMO, so that the index is more clear
"Fetching an object back from the database is even easier."
I'm merging this in right now (looks great!), but I think this paragraph is too complicated or just doesn't read very clearly. What do you think?
如果源变量的值正好跟特殊参数同名（看下面），它要用“<literal>\</literal>” 字符作为前缀。
use explicit charset
Добавить пустых строк перед комментариями.
Это, конечно, правильный код и красивый финт, но пожалей читающего в будущем, сделай нормально, в два действия.
`lang="en"` уже давно не нужно в xsd.
Легаси. Я все равно потом по ним sed'ом пройдусь. Так меньше всяких левых
коммитов будет в репе.
Эм, почему это?
Тебя Игно покусал шоле?
Cleanup unnecessary comments.
This file is obsolete!
Yes, you're probably right. I'm just laying the foundations (and was in a slight hurry), but I guess there should be a **kw argument here to allow for such cases.
This error won't be caught anywhere. I think we should just notify the user via status bar.
add space after `//`
haha, yea, well there were 2 test_show methods, so i renamed this one since it wasnt being used anyway. i wonder how that happened ;) But seriously, we need to flesh out the exception hierarchy and what happens when we pass bad instance IDs in, can u work on that @cp16net?
Tarkoituksena oli rekursiota käyttäen toteuttaa itse tulo, ei käyttää valmista toteutusta.
I think I wanted to keep the order, although it probably doesn't matter.
Looks like you have since fixed the np.any() I thought you needed.
Yes, but you do not import it from pylab.  The example doesn't run.  Test it.
Double quotes here as well
This message is wrong. I changed the plugin. The NPanday file is repleaced by wsdlExeFolderLocation and cscExeFolderLocation. The message could be something like
 "csc.exe could not be found Add. Set the path to th csc folder incscExeFolderLocation"
Please don't use such log-highlighting-art
I guess it must work, because you are using it all over the place.  Boolean field type?
Nice test case
Added more useful docs. Basically, keeping double precision values for interpolated or averaged values gives us meaningless numerical precision. Ints also require way less storage space!
Looks like we're assuming avg and min are the same. That seems unrealistic? Or does it not matter? This has been around for a while, maybe better to ask Dan.
@christianv Fair enough. https://jira.sakaiproject.org/browse/SAKIII-5542
Should data we want to apply contain as much vectors as m_labels has?
I've always liked UpperCamel in templates but happy to be outvoted here.
Here you can set the user name for all php files!
Are you sure the class "GmagickException" actually exists, or did you maybe forget to add a USE statement?
Are these two 'require' lines needed? They're usually not. What does the documentation say?
This would have to be `object.on(events, callback || context, context);` to account for event maps.
This is one of those "I need to check before I bind"

```js
if (callback) this.on('event', callback);
```

vs "it'll do the check for me"

```js
this.on('event', callback);
```

Backbone currently checks for `this.comparator` before trying to run `this.sort()`, so this one could go either way...
Ah deixa pra la, agora q eu vi que voce so moveu pro lugar certo
Hmm, looks like we've never tested that. You're right; we should. I'll correct it.
What do you mean it doesn't?
You've got indentation wrong here.
I dont know how /translate works on mac/linux or anything else but i get code above and this at the end of file:

#~ msgid "If you don't have an account "
#~ msgstr "Če nimaš računa "

#~ msgid "click here to register."
#~ msgstr "klikni sem za registracijo."

If that is ok and the way it's supposed to be.
Use interpolation here when translating. It could happen that in some languages location could be only last word.
Same problem with ID.
`'` instead of `"`.
Yes. As I wrote above, you have to fix this to RFC2822. Configure Tastypie to use it and use the same formatting function it is used by Tastypie.
Not in markdown. It will just put the URL in line.
```include``` www.yahoo.com
please remove the trailing whitespace you added
deauthenticateMac is already used in Switch modules, maybe i could implement deauthenticateMacMethod in pf::SNMP that does the code above.
We should introduce event.stopPropagation here as well, and then explain that `return false` does both preventDefault and stopPropagation
Also, this is slightly incorrect, in that the @version tag is for the version in which it first appeared. But I guess bulk update is the most reasonable at this point. We will keep up to date with new APIs?
The options to call get hosted service properties API.
We discussed it over lunch. Passing it now.
I like the approach you've taken here. Trade accuracy for fuel when its not important.
The USSD session ends, but the application session needs to stay around to handle "more content" SMS messages.
Ok, I thought you changed your mind after seeing the same check on setDefaultTempPath.
I figured that should be handled by `QSSearchObjectView`, and as far as I can tell, it is. I was probably thinking about that incorrectly, since `QSSearchObjectView` was actually only set up to handle the notification, and not the initial icon loading, but… It must already be taken care of somewhere else because I haven't been able to produce a situation where the icon in one of the panes doesn't appear correctly.
My first reading was that res stands for residuals
maybe ``_solve`` (or ``_estimate``)
Better to accept a hash of options here and use TwitterCldr.get_locale if no locale is specified.
Can we fold this functionality into the existing `LocalizedNumber` class?
Right. I missed this one. Other examples are correct.
Does an ```@brief``` at the top of a file actually show up anywhere in the documentation?  I can't find it...
It might be nice to put names on the fields in this result, or make it a record.
you should combine some of these tests, right? This is a result without a precondition... shouldn't there be a 1-1 correlation between user stories and tests?
Just delete this, and update refs to new location.
personally against supporting port, but i don't feel strongly
Assertion looks wrong (asserting message is not null, rather than something else?)
I like to make fields like this final by default. But no big deal, unless you're unlucky enough to have another thread see the old uninitialized value of your non-final field (http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html#finalRight).
This isn't safe. If I chose to write a task that returned an exception (rather than threw an exception), then this code would throw it.
Better to use two separate variables for result and throwable.
This is a lot of boilerplate code (e.g. the code for a, b, c, d is essentially exactly the same) and very unmaintainable. I'd do it in a for loop with two iterations if possible, or, if not, split it up into some local functions.
`initialize` is now probably a better name. Before the `require` did the initialization and you configured it afterwards.
When we add Float64Array it's going to be annoying to come back and find this big switch, what about the slightly looser "argValue && argValue.buffer && argValue.buffer instanceof ArrayBuffer"
Hannes Magnusson <notifications@github.com> wrote:

> > +		} else if (strcmp(option_value, "false") == 0) {
> > +			servers->default_fire_and_forget = 0;
> > +		} else {
> > +			*error_message = strdup("The value of 'fireAndForget' needs to
> be either 'true' or 'false'");
> > +			return 3;
> > +		}
> > +		return 0;
> > +	}
> > +
> > +	if (strcasecmp(option_name, "w") == 0) {
> > +		/* Rough check to see whether this is a numeric string or not */
> > +		if (option_value[0] >= '0' && option_value[0] <= '9' ||
> option_value[0] == '-') {
> > +			servers->default_w = atoi(option_value);
> > +			mongo_manager_log(manager, MLOG_PARSE, MLOG_INFO, "- Found
> option 'w': %d", servers->default_w);
> > +			if (servers->default_w < 1) {
> > +				*error_message = strdup("The value of 'w' needs to be 1 or
> higher (or a string).");
> 
> Are you sure about that? I don't remember 0 being specifically
> disallowed
W=0 makes no sense at all though... But I'll check what the spec says
wondering if this will render a decimal for older versions of json/simplejson
Well spotted, I didn't see that at all!

In a future refactor I think it would be worth adding in different, more granular, exception classes here too as opposed to everything raising `OpenTokException` (they'd still extend `OpenTokException` so you could still just rescue from the base-class.
same could be done for d.feed.title
Consider making this key list a bulleted list, which appears to be the style for many similar object descriptions.
In a spirit of Walkabout, I would call it Kangaroo ;)
is_id is preferable to isID in python for local variables. Also, boolean flags in functions is a code smell, It would probably be more readable to have the logic separated out:

```python
def show_movie_url(url):
   #...

def show_movie_by_title(title):
    return show_movie_url("http://www.omdbapi.com/?" + urllib.urlencode({
        'r': 'xml',
        'plot': 'full',
        't': title
    })

def show_movie_by_id(movie_id):
    return show_movie_url("http://www.omdbapi.com/?" + urllib.urlencode({
        'r': 'xml',
        'plot': 'full',
        'i': movie_id
    })
```

Of course it might be more pythonic to just pass kwargs to urllib.urlencode:

```python
def show_movie(**kwargs):
    url_params = {
        'r': 'xml',
        'plot': 'full'
    }
    url_params.update(kwargs)

    url = "http://www.omdbapi.com/?" + urllib.urlencode(url_params)
```
i added this test, already, why this?
Due to a side effect of the value 0 when using empty with strings, it is not going to work in this instance. I believe we are safe just simply checking for an empty string. http://www.zachstronaut.com/posts/2009/02/09/careful-with-php-empty.html
This should be moved to the constructor for consistency.
What's the purpose of this method? I saw that becomes an 'exemplar', just don't know what this means
jslint was bitching at me, I went a bit ADD on it...does it break intended functionality?
Ой, забыл исправить