labofsahil/github-event-dataset-2012 huggingface dataset:
Site cleanup

I set out to do a quick and dirty typography overhaul to make things more consistent and a bit cleaner, but I kept running into things I didn't like, so this lead me down something of a rabbit hole of design tweaks to the OSM site. 

__this is not yet complete__ but I wanted to submit it now as a pull request to let people check out what I'm up to. I hope to polish this up and have it ready to merge tomorrow or wednesday at the latest.

Goals here are to have better content hierarchy,  better vertical rhythm, more consistent UI, cleaner markup with less tables, all while keeping the basics pretty much intact. There are a lot of things I didn't touch even though they need to be updated (lots of tables where stuff shouldn't be tables, mostly). 

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now a lot easier to know what you're looking at. The header has a page title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more rhythm and breathing room throughout the site.

Screenshots:

- map view with key: http://cl.ly/image/1Q3h2C473U40/o
- profile: http://cl.ly/image/3P3C472X1429/o
- user diary: http://cl.ly/image/1o0n0i17130x/o
- changesets: http://cl.ly/image/2G1f332z3p20/o
- status messages: http://cl.ly/image/2g3V232u3f2e/o

Todo:

- I might take another pass at improving the changeset page. Not happy with the table layout there.
- Browser testing
- RTL testing
- Adjustments for 'small' layout
- Q & A

I know there are other problems here or things I've missed - would love another set of eyes to look over this! I am still getting comfortable working on the site - it's my first time ever digging into a ruby or rails site so I'm not familiar with the templating language yet.

Note: this has been merged with #148, so if this is accepted the changes from that pull request will also be accepted.
keypress event got registered twice in Firefox

when moving up/down within the typeahead dropdrown in firefox (tested with 16.0.1) you always moved 2 steps ahead/back instead of just one. this was caused because the keypress event got registered twice in the "listen" method.
Change umask from 0 to 077

For https://bugzilla.redhat.com/show_bug.cgi?id=796417

Signed-off-by: Steve Loranz <sloranz@redhat.com>
contrib-3478: adding new instance defaults to settings

Here are the suggested changes for adding site-wide defaults for the various instance settings. 

I have this tested on both 1.9 and 2.2. I did my best not to change any strings but some user feedback indicated that the settings page might be a bit confusing. I have therefore added to strings (default and default_desc) to en/ and en_utf8/. I can't help with the translations.
Fix RAils

Hello,

fix spelling of "Rails" for the engine to load correctly
fixed ternary operator expression

ternary operator expression is inverse. 

Sample Code

```
{{ pagination.sortable('id', 'r.id', {'class': 'current'}, {'sort': 'r.id', 'direction': 'asc'})|raw }} # direction=desc
{{ pagination.sortable('title', 'r.title', {}, {'sort': 'r.title', 'direction': 'desc'})|raw }} # direction=asc
```
Binary file persistence

@ Helge: The binary stream reading and writing is now integrated with the scene graph. 
Note: am about to build a complex demo using this system, so if there are any bugs I will definitely find them.
Added documentation links for the 1.3.0 RC 2 and 1.3.0 releases

1.3.0 is still building (test link: http://demobox.github.com/jclouds-maven-site-1.3.0/1.3.0/jclouds-multi/). ETA in ~5h.

But I think we should be able to merge this already - by the time people start using the links the site should be available.
[Tree] unused code cleanup

Removes unused private methods, unused variables.
rakep build enhancements

I've cleaned up this pull request: https://github.com/livingsocial/rake-pipeline/pull/37 so it should be easier to follow. The high points:

 - Uses a faster digest method
 - adds `rakep build --clean`
 - adds a mutex around assetfile checking / pipeline rebuilding
 - separates command-line stuff out of Runner
 - quiets `rakep build` and `rakep clean`
 - fixes a bug where an Assetfile is read twice when running the server
LPS-25505

LPS-23512 missed to remove the href parameter in the bottom button row
please fix the attack bug

attack ?? walk??
update for example app to run with mongoDB and mongoHQ
Make SC.Widget.Events work

SC.get and SC.Widget.Events are asynchronous operations[1]. I couldn't figure out how to have random tracks pulled every time a track finished playing. Instead I decided to retrieve a list of tracks, store it in an array and randomly pick one whenever a song finished playing or a user clicked the next track button.

[1] http://en.wikipedia.org/wiki/Asynchronous_I/O
Sao Pablo Page Markup
String#to_postgres_array may process NilClass elements.

I test it on rails 3.2.2 and pg 0.13.2
Mostly flatfile patches

some changes needed for the comparing of type/view prompts and their keys.
Also some changes in how the repositories for flatfile save and load the prompts.
GPCONSOLE-4

This is a fix for GPCONSOLE-4 which causes the code editor to cut everything off after about 140 lines.
Fixes #69: Handles null year with 302 redirect.

Checks year, if nothing is in the string then redirect using 302 to
"/team/team_number".
oneseg: fix capture and record

これで目立った不具合はfix!?
Fix iOS 6 issue & reorganize project.

Fix issue #2.

I reorganized the code and the project because it was really messy.

Sorry for the huge changes but I think it was needed :D
add foreman to Gemfile, fix formatting in web.rb

title says it all.
Something

Some Cookie system, Update system and Typo
Fixing the date_i18n in email-template

Get the date right in {date} in email template

Changed the translation after #403
Converted Discount Admin Page to WP List Table and Other Updates

Finished conversion of discount admin page to WP List Table.

See #633

* Created the `EDD_Discount_Codes_Table` Class
* Rewrote the Discount Codes Admin  page for the new table
* I also added a few little extra here and there. ;)
TIDOC-368 APIDoc: Update docs for high-priority Android/Calendar modules

https://jira.appcelerator.org/browse/TIDOC-368
Timob 7348

http://jira.appcelerator.org/browse/TIMOB-7348

Test steps in Jira

NOTE: We need to discuss parity with mobileweb before merging this.
Faster rerun through checkout reuse

Revert an incorrectly included part of the original change, and better cleanup of the repository now that it could theoretically be dirtied by someone.
Correct a typo on jquery append

Add a $ to the documentFragment exemple to generate the dom fragment bef.ore appendChild
Initial rough implementation of searching your neighborhood
Black dev

I made updates and added clicker quizzes to Wednesday's lecture.
[FIXED JENKINS-13618] Corrected DataBoundConstructor

to match the configuration form

Removed descriptor new instance override as no longer needed.
Add hash bang to stop error

Stops

```
/usr/local/bin/nbworker: line 1: syntax error near unexpected token `('
/usr/local/bin/nbworker: line 1: `var BeanstalkWorkerCluster = require('../lib/beanstalk_worker_cluster').BeanstalkWorkerCluster;'
```
[task/ci] Adding notifications and dbs to travis

TICKET-#34
LPS-24849 Source formatting fix

Hi Sergio,

As we discussed this fix is needed because a source formatting changed the logic a little bit. This will correct the logic.

Thanks,

Máté
Added labels to checkboxes

Added labels to checkboxes to make checkbox descriptions clickable.
Different inputs

reading different types of data from the api and based on that creating html
Updating Contact Explorer to use inline.js
BUGFIX clearfix added for checkbox by it's self in userforms
LPS-23960 - consolidating fixes from LPS-18201, LPS-23960, LPS-25063
Issue #433

Skończyłam zadanie, możesz już zacząć testować.
ported showcase view from customizable confluence

This is just the basis...needs some cleaning...will do this the next hours/days

Can I pull the trigger?

Max
fixed infinite loop in _devel_sharedir

See #2
Workweek doodle and new-post.py python3 compatibility
SOS-728
Default language is loaded from the ewz_recaptcha.locale_key config vari...

...able. It seems there is no need to call $container->getParameter twice to load the language value.
Pull this

Stuff
Anyformat minimal

This is the same as my "master" pull request, but with minimal changes to dzil configuration. If you want the code changes but you want to keep the dzil config mostly the same, accept this pull request and reject my other one.
Update filenames in CFSpreadsheet examples

Two of the examples for CFSpreadsheet used the filenames from the CFJavaScript example. Updated those filenames to the CSS files used in the first example.
修改了一处代码与对应图片内容不全一致的地方，可能会给读者造成误解，同时，此处代码原本未被正确编译成HTML。
psycopg2: Avoid causing a 2nd error in an aborted transaction

Asking for connection isolation_level results in a query executed by
psycopg2. However, all queries ran in an aborted transaction will result
in a new error.

This is my biggest annoyance with the debug toolbar -- whenever a query
causes an aborted transaction, the original error is hidden and a new
exception is thrown:

    InternalError: current transaction is aborted, commands ignored until
    end of transaction block
Changed defmethod to defun.
Update scripts/build_environment.sh
Primes Challenge erledigt
Fix advanced3d example
Fix array_merge error when there's no route params.
Pull request: Fix signing on mac
Few Small Changes

Okay! Did a few small things. 
Comments.php: no responses changed to no responses yet.
Added theme support for post thumbnails in additional functions file. 
Searchform.php: Added s to enter term…
Fix for issue #178.
A more robust leaf? function

The leaf? function dies if lft or rgt are nil.  Here is a suggested fix.
Hello Bryant, some last changes to support a couple of new methods.
Rowend/26 catalog payment
Major rebase; add some delegate methods
Replace deprecated Dancer keywords before and after with hooks.
work-around UniqueConstraint issue GORM

...SCF. This bug-report explains what was happening: http://jira.grails.org/browse/GRAILS-8389.
PLFM-1292 work. Added versioning to Synapse client and to Entity Bundle, and Snapshot model objects
Swizzling improvements and change to the screen size test

I have improved the safety of the method swizzling by adding adding some checks before the swizzle occurs.

I have also made the screen size check less specific to the iPhone 5 and am using the screen ratio instead.  I've changed the return value to `UIUserInterfaceIdiomPhoneWide`
Error handling on stream
Update 05d6f93feae23e30fbb41cab955bf36aa84a602e

est ce que je peux connecter mon telephone android à une imprimante usb puis envoyer les données à imprimer( des simple string) ?
pull request for you chaps

...added a second feature to prove browser instances are shared across features
This makes the extension works with gnome.shell 3.2.2.1

I send the pull request because I had problems installing the extension in debian wheezy, because is using gnome-shell 3.2.2.1 and for some reason, even having version 3.2 in the metadata version list, the extension wasn't being loaded.
Added in encoder initialization and then commented it out
Awful patch, just needed to turn the site live again

... solution. Pagination next?

Signed-off-by: Andrew Miller <amiller@dappervision.com>
JS not required for homepage examples and "your code here" (the 2nd)

This is a cleanup of #38
You can't undo or transform negative exceptions in Tbird. I don't know about "etc".
reverted this part of the commit.
Just tested with build from pieh and extra buttons in the grouplist behave as expected.

ie extra button controls placed above or below (or both if so desired) the default button control are then rendered before or after the main context menu controls.

Many thanks.
I don't think that fix is going to fly, as I think that videodb://2/2/ type paths will now try and set an invalid fanart?

I think the fix is

if (item.IsVideoDb() || (item.HasVideoInfoTag() && !item.GetVideoInfoTag().IsEmpty()))
{
  // carry on...
}
Shouldn't the wiki display 404 only if the user has no permission to create wiki pages and create page creation if he does?
PHP glob() function utilization: http://php.net/manual/fr/function.glob.php
罷了，沒想到更好的辦法，若然你堅持這樣設就重新commit之類吧，我始終還是被gnome3陰掉......
Even if implemented within the pimpl, it's usually preferred to split declaration / definition.
We don't use brackets here
caps lock xD
Whoops. Don't think I meant to keep this line_wrap change. Will fix next time.
Should this not be:
/give <player> <item> [amount ] [data]
?
faked events is a hack to begin with and now it's starting to look messy.
high time to find a proper way of getting our hands on the element we're creating the popup for.
I could have written an entirely separate note to say "you should also have a windows branch here", but it seemed less efficient.  Reading it again, of course, I see that I also failed to clearly communicate that intent.  It made perfect sense in my own head.

Execution like that avoids a whole pile of work-arounds and other safety features that we have in the execution helpers to make sure things work well, and correctly, on all the various crazy Ruby versions and platforms we have.  New bits go to the same place; ideally, we shouldn't be introducing new random places that fork and exec without the same work-arounds.
The default is the filename minus the -test.sh. If the user wants to
make their own description (a feature I regret having) they can set it
with `describe`; which is where you're seeing it be set again.

On Thu, Jan 26, 2012 at 4:20 PM, Richard Hartmann
<reply@reply.github.com>
wrote:
> What about roundup_basename? As it is, you are using roundup_desc twice. Either I missed the importance of this or it's a bug.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/RichiH/roundup/commit/f773919a7ca635ebc1b20c149eb1496aca47c109#commitcomment-906437
Looks nice however you appear to be using wrong whitespace(tabs?) :(
```java

private void marshallReportData(list<IJAXBReportData>);
```
I know, but before it can be pulled, I need the jump.el changes to be merged. And there were some issues around that - something about repo access. There is an outstanding pull request for that. I am hoping rinari development doesn't make all my changes obsolete by then. :)
Really? It falls out of the for loop immediately, so it really just saves a clear. I still don't care for it. (Granted, I've always been an indentation-should-equal-control-flow person.) We should also pull _thread_local.es_index_task_set into a local so we don't have to do some the locking twice. And name _thread_local something more descriptive, like _local_tasks.
The Hitchhiker's Hack 3.3.5   (confirm) WARDEN memory hack NOT Detected!!!!!  but speed hack fly hack and teleport DETECTING, normal anticheat. ALSO not detecting air jump hack.
http://www.4shared.com/zip/l8b-tn2j/The_Hitchhikers_Hack_335.html
void value not ignored as it ought to be
Yup :) Can even attach debugger to live instances if you want.

Compiles only happen at deploy time, not during development.
Except that you need the `$page` for `$this->for_page($page, $per_page)`.
So this ready for testing?
Right, shouldn't include 'title'. We special case the HTML "core" attributes (id, class, title) in Maqetta. These attributes are on every HTML element, so we don't include them in the metadata.
related: http://xkcd.com/149/
PRIdPTR seems to me practically useless for printf (heap size is printed with 'M' suffix to be more human-readable and that value fits into 32-bit).
WARN_PRIdPTR exists just because WARN proc accepts only values of word type.
This is not new, this was added by myself and is used from all new-style middleware services to convert a string to a datetime. The fact that you return a timezone-aware datetime is actually what makes my life easier as all code from search and report/list will work out of the box.
I looked at the LocaleField class and it uses the same choices. Should be
OK I think?

--pm

sent from my mobile.
On Feb 11, 2012 3:05 PM, "luke crouch" <
reply@reply.github.com>
wrote:

> Something we have to be careful of is the profile locale field is sent to
> MindTouch. Which is probably why we specify choices in the form. I'll check
> to see if this is good for profile edits going to MindTouch ...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/pmclanahan/kuma/commit/e7b63ec7cc53b5e8edd5768bd3533dc41ba55430#commitcomment-956947
>
This commit breaks some searches that use the +/- syntax at the beginning of words, e.g. "cars -Ferrari"
ок наови его skip
These should be in a standalone class.
These were actually intended to be 'replaceAll'. Doesn't matter much, though, since the calling code is hardly alive.
do you actually need another `u` for these subsequent lines?
done with rev 4961e0e
btw, padding with `0`s could be easily accomplished by testing for non-zero milliseconds (which would safe us from calling `formatTime "%Q"` in the first place for whole-seconds) and then just using `take 4 $ formatTime ... "%Q" t ++ "000"`
Oups yes, I'll make a hugeclean when getting all back to img :p


Jean

On Wed, Feb 29, 2012 at 4:56 PM, Andreas Karfusehr <
reply@reply.github.com
> wrote:

> Could you please only upload icons and images that we relay need? I don't
> think we need a background image for example ;)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/naparuba/shinken/commit/81967b4e2c8d0da5d46b3e4da14aa713d440da18#commitcomment-1026642
>
I know the other methods don't have it, but please add a name to the parameter.
Nice! Gotta play around with that when I get a chance :)
Its returning the variable else that got bound in the case statement.
Shameful edit. :(
Can you move all this to a file? Not inline JavaScript? There is no reason for having in-page JavaScript except if you want to take some configuration parameters from the template. (Like language.) Then try to have only that in-page.
@alta189 you check twice if it is org.spout...change the second one to org.getspout
else "Must pass a single feature literal"?
Hi Christian,

I tried something to fix your bug. I roll back the old entity finding technique but if it fails, I used the new one. I think that it should fix your bug, but since I am not able to reproduce it, I cannot know. Thus, may you try this new version and see if it works ?

Thanks,

Claude
That's what the setting is for. On Heroku you can't do it through a reverse proxy, and we want to be able to support Heroku.
I think the qualified keyword here should just be `:overtone.sc.buffer/buffer`. I get a "Invalid token" exception when this is read.
`g['mimetype'] or '-1'` would suffice
A vanilla version of vim moves down to the newly split line and reindents for me.  Is that not true for you?
No it isn't TomG's fault, in fact his rol is overrated. We've got more/equal done to the ICS port than he has, 75% of the work is done by others, where TomG takes the credit for. I'm pretty sure he hasn't patched surfacelinger, but someone else who doesn't want to share outside the CM project. Oh and he won't release, he's been giving excuses every time such as "Oh it doesn't build this time" or "Oh just have to do recovery".
But good news regarding the flipped screen hack, if you look at surfacelinger.cpp (its actually in the open CM repo as well) the flipped screen is just a macro activating a new option in the switch menu for ro.so.hwrotation. So if you don't set ro.so.hwrotation the screen isn't flipped. You also need the libgralloc-qsd8k in hardware/msm7k, taken from codeaurora-gingerbread. To get that compiling you need some extra variables in the headers in hardware/libhardware.
Wouldn't be more straight forward if each `SpawnReason` value has a boolean if it is `natural` (and will be canceled if not allowed) and simply check `spawnReason.isNatural()`? So if new reasons come up, you only have to add the reason.

Fabian
Please make it as an Array or a List.
Scalatra は、status code の set の場合には
https://github.com/scalatra/scalatra/blob/2.0.2/core/src/main/scala/org/scalatra/CoreDsl.scala#L58

```scala
response.setStatus(500)
```
が

```scala
status(500)
```

というように書けたりと、よく行うような操作(例えば、redirectの処理、contentTypeの設定や取得)に関しては、いくつかちょっとだけ短く書けるショートカットが用意されてますよ
@ohararyan @sminnee It actually removes the margin from ALL constructive buttons in the CMS.
Can you please go through the UI and ensure this doesn't cause any alignment issues? Particularly when constructive (green) and normal (grey) buttons are used side-by-side.
you could just add a .rspec file on you project with --drb :)
Category should be implemented by Serialiazable, see Page class.
postfix while would be more compact and still readable
Unnecessary, you never change the array.
Might be a point, could have a comment indicating where the constants
are maybe..
This is what did it....if there's metadata on the first form, transfer it to the macro result.
What about moving the date-checking code up to Minion so that any worker would get the benefit of the check?

Also, you should swap out the import wildcard for the specific classes you are using (DateTime and Duration)
The fix looks good. But why would you want to remove the test databases, add Gemfile.lock, fix typos, instruct Google to not show translation help, and fix #54 all in one commit? #54 specific changes need to be isolated into a separate commit and the regexp improvement squashed into the same commit. Let me know if you have any questions.
@terabyte101 Be kind, stop sending messages without significant content
Ah, i think I like this routing convention...
Please explain to the group why you did this :-) Although you sorta did in #1353
This line too is too long, pep8 standard mandates lines of less than 80 characters.
здесь также потенциальная дыра в приложении: пользователь может не санкционировано поменять роль и стать админом.
смотри attr_accessible  и проставляй вручную если с записью работает админ (а если совсем по феншую то лучше если current_user может проставлять роль согласно кастомной абилити)
Also Eugine to Eugene.
nice commit...
use LOG.error
yeah this didn't actually work any way :) it was just a quick attempt. I just moved back to the other hamlbars gem for now... we may bail if it becomes a problem.
http://www.youtube.com/watch?v=igUsHrFqegE&t=2m43s
Yes, we may be able to add more context later
woops, zal gefixed zijn i/d volgende commit
(1) the function names should not contain "_" (not a big deal - just saying)
(2) the code needs to be a separate project under sandbox (also mavenize it)
(3) i should be able to run any "coverage" function from command line without any code change. no more running projects from eclipse - everything needs to be run from a jar.
I know what DEPLOYED_APPLICATION_NAME is for. I was just trying to get the "all-in-one-job" working, but it look like it's not possible by modifying the existing script, so I will try other solutions (having a different script or using a "super build.xml" that build everything, à la Wonder).
Encontré este commit https://github.com/Arkania/ArkCORE/commit/c8aa52c4bbbf322a3c8a8b5cb58eb8814b039723#commitcomment-906363  aun no he podido probarlo por que falta el sql, quizás este en la db de ArkCore pero yo con tantas lineas me lio xd, si te enteras de algo avisa, de todas formas comente el commit a ver que me dicen, un saludo.
DELETE FROM creature_ai_scripts WHERE creature_id IN (27900); fix error
Is this a good hash code for vectors?  Wouldn't that essentially make the two vectors {0, 1} and {1, 0} have the same hash code?  In cases where we have a lot of really sparse vectors with approximately the same number of single occurance features per vector (common in wordsi), they would all have the same hash code and end up in the same bucket, thus eliminating any benefit from storing them in a hash map or hash set.  

Maybe it should be something along the lines of 
sum_nonzerovalues (value XOR index)  
that way the hashcode is incorporating the index of the value as well.
I'm saying that every OTHER test is going to want to expect that File.exist? is going to be called - this will be the only one that doesn't (because it fails early before anything is loaded).  So instead of repeating those two File.expects(:exist?) lines in EVERY test, just keep it in the before :each do block and split this single test out.  It would make for cleaner tests, in my opinion.
Issue fixed.

Since Jbuilder returns JSON strings and not hashes, I replaced the @clients.to_json call in the show view for staff plans with a call to _.map(@clients, function(e){JSON.parse(e)}) to make the whole thing consistent.
This expects the following DB update:

delete from spell_script_target where entry = 39364;
insert into spell_script_target values
(39364, 1, 18732);

insert into creature_linking_template values
(19224, 555, 18732, 4112), -- void portal (despawn on death / evade)
(19226, 555, 18732, 4112); -- void traveler (despawn on death / evade)
Good to see dodgy APIs being rendered unnecessary.
No. I got this message, also.
On Feb 25, 2012 4:40 PM, "annerusley" <
reply@reply.github.com>
wrote:

> Dan,
> Thank you so much for the update! I'm looking forward to pulling it to
> take a look.
>
> BTW- I think you may have sent this message and the next message to me
> only.
>
> ~ Anne
>
> anne.rusley@gmail.com
> 952-925-9024
> mobile 952-994-9024
>
> On Feb 25, 2012, at 4:33 PM, sedan444 wrote:
>
> > First of all, I cleaned up some Accessor stuff.
> >
> > Then I created a controller called NewspaperRecordController.  You can
> see what it does by going to mhsbake/newspaperrecords.  Essentially, it is
> an alias for NewspaperReelController.  That is, it uses the NewspaperReels
> model.  However, it has it's own index and view ctp files (add and edit are
> yet to come).  This allows us to expand these index and view files to show
> additional data.
> >
> > The trick was to modify the NewspaperReels model so that it returns all
> data for a given record.  I had to tweak the $belongsTo array and add
> Newspaper to it (Andy, please take a look at what I did).  The benefit of
> this is that everything necessary to populate the Newspaper Records page
> (or to populate a single record view) is done with one query (I don't count
> the 'count' query).
> >
> > The add and edit functions will be a little tricky, as we need to make
> sure each table is updated correctly.  Also, everything we do here will
> need to be paralleled in Archives.  If someone else does Archives, please
> look at the changes made specifically in this commit.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/anhonigman1848/mhsbake/commit/216a59d3efc6d87d76b4ca1986cdbf43850103f8#commitcomment-1011569
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/anhonigman1848/mhsbake/commit/216a59d3efc6d87d76b4ca1986cdbf43850103f8#commitcomment-1011576
>
Corresponding CB: Bukkit/CraftBukkit-Bleeding@11cc269fc32d74e552b4c0100c9b9d31f4cdd321

The Multiverse branch that can be used to verify behavior: Multiverse/Multiverse-Core@4631fd0a612c6f9f2cdf50c4ac46233e5aec27a0
Either your comment is unnecessarily truncated, or line 128 is too long.
It could be, but this usually indicates an error in your application logic, as the recently-closed tickets that raised this issue demonstrated. I think it's best to scream bloody murder here.
Agreed!  :-)  For simplicity sake, I would make a static method in a utility class.
What type of game is this going to be? I was thinking we were doing something like FF Tactics or Fire Emblem but according to what you're talking about, that doesn't seem to be the case.
Why would you need to store your User Interface in your map editor?
Does the bird need to be stored in our map editor?

A map editor should store static items, not movable characters. We are not trying to create the game engine.

Also, do we really need to be able to walk under a bridge? We don't need to be Final Fantasy. That's just asking for mental suicide. Simple shit first, THEN expand to make it more complicated.
```SQL
+DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY;
```

Delete statement incorrect.
@Dreadii, me too.
I think would have been clearer coded as 

```
if (memTraceLevel >= 2 || (statsCyclesInterval && (((cyclesNow = get_cycles_now()) - lastStatsCycles) >= statsCyclesInterval))
```
Why the fux are you storing all this data ....
@dntndus9611 이 코드는 이러저러 예외 처리가 되어있지 않습니다. 인수로 파일명을 넘겨야 합니다.

argc, argv, env 인수가 각각 무엇을 의미하는지 숙지하고 있는지?
vale ahora caigo, dices las tumbas. Si y no, las tumbas se jodieron al 20% (no sé el porque aún) y estuvimos con un debuff de +100% de daño de escarcha todos durante el encuentro. Si te refieres a eso si. Lo de la abominación no.
lgfm
This will be easier with mongoengine 0.6:  https://github.com/hmarr/mongoengine/commit/0301135f96be83ee613664e875409a9d4b590137
Тестов бы побольше.
In what encoding do you keep your source code? This should not happen with utf8 code. Maybe we should try to detect the encoding here, although it seems like a huge overkill for the codebrowser to do something like that.
@cheald thank you for your updates :)  Would you be able to provide an example of when this would be used?
Looks like there's an unsubscribe "webhook" http://apidocs.mailchimp.com/webhooks/
Indention should be with 2 spaces and not tabs according to Drupal coding standards.
It would be useful to say that this property can be set in $SONAR_RUNNER_HOME/conf/sonar-runner.properties or in online settings. Don't you think ?
Documentation change reviewed. **accepted**
But to have real fun we need a message generator :)
Or maybe just a hundred or so predefined ones :)

Maybe something does it already?
Don't know what fugue is but this looks good.
Should be refactored to split class ( els[i].className ) array of words.. Current regexp handles numbers as strings causing collisions, and needs to be updated or replaced by numerical equality.
Again, here, we need some same defaults:
languages = getattr(settings, 'LANGUAGES', ['en'])
default_language = getattr(settings, 'DEFAULT_LANGUAGE', 'en')
for language in languages:
   if language == default_language
     # and so on
public final позволит не писать под них gette`ры. + конст целостность, они же не меняются совсем
A mí me gustaba casi más la Bold... almenos para los títulos... para gustos, los colores!
Leave 2 blank spaces before comment (pep8)
Seems safe :-)
May be making this dict defined at class level(or type level to be precise) would be better. Also instead of defining a static list, may be you can add some kind of meta class to the "Box" base class so that it will populate the list automatically when a new class is derived.
maybe you should reset the vars from start method
Hey, send a pull request to the collective fork please and I'll merge: https://github.com/collective/webcouturier.dropdownmenu
if you don't use some ZF way to do it, there is no need to copy-paste the parent method as you still extend the NativeAdapter
I wonder if we should make it a top level class to be able to use it programmatically in the future.
I removed this annoying feature.
Never mind... your test coverage looks pretty thorough, so don't bother going through and commenting this... I will have Cordt run some manual tests.
This is a nice, elegant way to do this, but Isn't there an issue here if you have stateId="2" and you have both a concept and a state with id="2"?

Let me know if you think I'm wrong, but if I'm right don't worry about changing it now, because I am going to need to rewrite this method into an getState(STring identifier) method when writing the functionality to make sure that forms with the workflowState tag export properly... hopefully later today.
Oh yeah, the plain tools package didn't require a `content` dir. There's a goofy nuget bug where a package must have a content dir if it depends on a package with a content dir (resharper). However, for similarity, I can add one and then the nuspec and ps1 files start to look more similar.
There are still some files who needs to get into the build left. Will do that soon
Hi, Flinny

It's a BFS-powered kernel, right? Turns out autogroup with CFS kernel would be better for Desire Z after some quick tests by myself. I can't be sure of zram module effects on 512MB RAM devices, but it did affect the performance of smaller RAM devices(like HTC Tattoo).
I'd rather stick to ``'w'`` mode for the sake of being explicit (we're dealing with text files here).

Could you rewrite this to use ``sys.version_info`` like in [here](https://github.com/bow/volt/blob/master/volt/engine/core.py#L394) and forego using ``unicode_literals`` at all?
Sounds good. I'll try to get some time to work on that.

Thanks for the feedback! I'm learning a ton while working on this, and appreciate the time you've taken to share your perspective.



On Monday, May 28, 2012 at 12:43 PM, Erik Michaels-Ober wrote:

> > profiles[username] ||= {}
> > profiles[username].merge!(profile)
> > write
> > end
> > 
> > + def find(username, comparison_length = 99)
> > + profiles.keys.detect{ |key| key.match(Regexp.new(username.downcase[0..comparison_length], "i")) }
> > 
> 
> 
> I think it's important for the gem to be predictable. Typing `t set active s` won't actually work consistently, since profiles are stored in a hash, which has non-deterministic order (at least, this is true in Ruby 1.8 and it's not a good idea to depend on hash order). You could sort the items in the hash, but even this wouldn't guarantee that `t set active s` would consistently select `sam` (e.g. what if you later authorized an account with the user name `s`).
> 
> Additionally, I think there are benefits to having the logic in `t` match the logic in `thor`, since `t` depends on `thor`. Once a user learns the rules of `thor`, it may be confusing if `t` follows a different set of rules for its internal logic.
> 
> In conclusion, if a user types an ambiguous command, I think they would expect to see an error. If users depend on this working, it could be dangerous. For example, if a user expects `t set active s` to switch to `sam` but it actually switches to another user and then they proceed to delete tweets or direct messages, these are irreversible operations.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sferik/t/pull/51/files#r889546
> 
>
Yes. But to be safe, please use the second filter. There's possibility that  the scroller doesn't have a child in other page view.
Grouping I'm going to a branch of another from
In my testing, it works with Firefox, Chrome and Safari. Didn't check IE, which I would think doesn't have support for it. Ugh!

So, the change would perhaps turn into using a jQuery plugin to do the logging, or adding `if (!window.console)` before the call. I prefer the latter, but will look into plugins.
Doesn't this mean you're adding it to the list for availableAttributes also?
If I move the code to the memcached integration module then the EncryptedMapDecorator test would stay in the clear pass directory and this test would go to the memcached directory. So where would this new base class class for the two tests go? In cas-server-core?
we don't use this JS-like construction in PHP yet:P
Ask Jonas, he's coordinated that.
my previous comment was about alpha,
Wikipedia: "The half-life of the weights (the interval over which the weights decrease by a factor of two) is approximately N/2.8854 (within 1% if N > 5)."
I don't know if that helps people to decide.
It was something that @rkuhn and I talked about. We don't like the way the full ActorContext is exposed to RouteeProvider and RouterConfig (outside of the actor).
The purpose of this was to reduces this *full* exposure.
Are you also saying "makes the *look like*" is ok?
Sorry for this ping-pong.
Perhaps make it public. I don't see any problem in that this is queryable in the cluster user API.
It looked like the java docs didn't specify this stuff, but I just realized
if I click on the api they jump to a fuller definition. I'll link to that.

Turns out the apis can also throw errors. Any ideas for the cleanest way to
deal with that? Should we fail the operation and make a new error case
class to send back to the owner? (eg for Accept, Closed isn't quite the
right response because it might be possible to Accept again with different
set of options)
"This section gives a brief overview of the general ideas behind the akka-camel module, the
 	 31	
+remaining sections go into the details. " <-- pretty superfluous, don't you think?
Performance is of no concern here, I think. But Viktor’s suggestion also makes the intention clear. I just proposed `subsetOf` because we don’t use it yet ;-)
Yeah, though there are probably multiple ways around it. If we get an error sending to `nsqd` from within the `finishLoop` (see, for example, line 460-463), we try to call `stopFinishLoop` and then `continue` to the next loop iteration. The problem is that if that channel is unbuffered, then `stopFinishLoop` is blocked, waiting for execution to continue in `finishLoop` - but we are blocked in `finishLoop` by the call to `stopFinishLoop` - it's a guaranteed deadlock. Now, I do see your point though, and I think a related race condition would still be present with the way I had organized the atomic reads and decrements prior to my last commit. 

One thing that might be able to help things would be for the draining goroutine to be selecting between `finishedMessages` and a timer, so that after a reasonable amount of time it will no longer wait for anything else on finishedMessages. Not a great solution, but might be an improvement?
Added New Helper
Yeah debug is very useful but also insanely verbose. Hard to see anything in there. I definitely wish to keep `:info` on STDOUT by default, and maybe `:debug` to file, but not sure about the latter because the file would quickly grow to insane sizes.
I believe searchsorted uses side='left' as default, and I believe that's the side we need. The main issue is the `len(a) - a[::-1]` part adds a lot of overhead. I don't think numpy has a search descending only search ascending, ie searchsorted.
OK, @MrBago knows my opinion on this one :)
shouldn't it check `and not time_interp` 

and conversely `if time_interp and slice_order is None: raise ValueError`
I think you can skip the ```is not None``` part here.
Same as above, maybe avoid calling this a plugin?
I'll revisit.
Why have two versions of `fake_create_mrjob_tar_gz()`, one with the side effect, and one without? I think you should just have one with the side effect; it takes almost no additional time, and it's closer to what the real code does.

Also, we still test that the tarball gets created correctly, right?
I think this sort of magic just for `'interpreter'` is unexpected.

More common ways of doing this:
 * set `self._interpreter` when the runner is constructed
 * have a `self._interpreter()` function
 * do `interpreter = self._opts['interpreter'] or self._opts['python_bin'` in the few places you currently use `self._opts['interpreter']`.

You could make an `_interpreter()` function,
venture_role_parent = venture_role.parent
Math.round(Math.random() * abc.length) can be equal to abc.length, abc[abc.length] will return "undefined" so our generated property will not have a fixed size.
You probably want to delete this?  Peter spotted it too
So the only difference between check-deps and compile is that check_deps invokes save_dep_dirs/2? Why?
According to erts sources file:make_link/2 works on newer Windows versions.
Comment does not add anything, please leave it out.
It should be `type + msg` right?
I think this is a typo: this block has the content "block2base" but block c1 has the content "blockc1base" (with and without "c")
Done..... 虽然没加到`ime.h`里面
No need to save the fonts, again.
Ha, and I forgot it also when I merged it *g*
In non-graphical REPLs, or when `geiser-repl-inline-images` is nil, i would insert the #<Image:...> text in the buffer, converted into a button that, when clicked, either inlines the image or opens the external image viewer.  Since we would be keeping a cache of files as described above, the button would simply look at the file name in the buttonized text and do whatever it needs to do with the file, provided it's still there.
ok, let's keep it like that. so the IDE will tell the programmer when he actually uses the event.
Are paused and playing flags used anymore? They should conform to how we notate states - see List
Rename to `d3_xhr_send`.
I suspect you need to use `../.virtualenv.py ` here, because it is executed from the Python directory.
You don't need to do this: the PublicFeatured mixin already uses Omeka_Filter_Boolean on those before saving.
I don't think so - they can find this information by reviewing the script index pages and it saves us from having to make sure this document stays up-to-date as we add new parallel scripts (which was a problem in the previous version of this document which still listed only three parallel scripts).
@carlosantoniodasilva absolutely! Thanks for pointing this out :)
OK.  I think I did that correctly. Squashed then force pushed.
@jeremy It's nilling out user-provided size. I followed the style of other code in this case.

- https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/tags/file_field.rb
- https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/tags/date_field.rb
- https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/tags/hidden_field.rb
BTW, I know I made it look like this is specific to PostgreSQL+Arrays, but other data types would benefit from proper type casting.
`bind` is (somewhat) deprecated and `on` should be instead for event binding.
@al2o3cr You are correct in that your example would pass this validation, as I would expect it to. `aliases` *includes* the value `1` which is in the list of acceptable values.

Why I opened this pull request is exactly why I wanted discussion like you provided. If it doesn't make sense, then it doesn't. But the language is similar so it's worth discussing. My main point is that I am living on the edge of dropping Active Model validations completely because they simply don't cover all standard use cases for non-relational mappers, and maybe that's just the way it has to be. I already had to drop `ActiveModel::Dirty`, so maybe it's just time for the next.

Your example, however, does seem like an extreme case simply to prove a point. I wonder how many would actually be attempting to set values of that nature and be validating inclusion at the same time.
I think we can add this case only to document this behavior if anyone want to change this code. But this is only a suggestion.
Pease leave a comment there for people who will still be inclined to use the assert: "don't make it more painful than it needs to be: use -Ytraceids-debug".
Mmmm. This asks for cyclic reference errors. Are you sure?
I wondered that too, but they made RefTree a class and the class has to come first.
`.distinct` seems reasonable.
My mistake, one check is for the for `@order.adjustments.promotion.eligible` and the other is for `@order.adjustments.promotion`.
I do not think that there is any need. This is just some internal information that does not play any role in hash or eq for instance, so the simplest solution should be ok.
I think you should use symbol. What's the point in not using a class that is available? My suggestion was:

- if the user provides a name, store that as a symbol
- *otherwise*, store a dummy
Cool. I didn't realize that. Actually I wish that we just always used the first system.
Spacing around the `+` sign? Or is it unnecessary when it comes to string concatenation?
You could use `()`.
OK. I will inspect this code. thanks!
see 6eeb71c for the syncronization logic
... and here also
You could pull this out of the try block, thereby running less code in a try and removing some duplication in the except.
I want to see what chunks are filtered (the beginning and end) and in what order.

Your test above (line 122) has two active filters, and I want to see them more clearly.
Can you clarify why the text above was deleted?  Was it incorrect?  Seems like if there are on_modify and on_set methods, they should be called if we are in fact setting and modifying the value.
Best practice: wrap handle in parens.
Needs a bit more whitespace here inside braces
remove lines 7-9 these are the defaults
I don't know why your schema is so different. I suggest not commiting this.
we call it the user group?
You may run foo and bar on the.
Hmm, I thought MDN had its own twitter account, but I couldn't tell you what it is. 

We can always change this later, though, if there is one or we create one. Might be nice to make this a configurable value at that point, too - either in Constance or settings_local.py
Yeah, 100's of DB queries (also cached) are still a bazillion times faster than 100's of HTTP requests :)
view comment below about dom caching. applies to here too
Nit: maybe change the name to ```jdbcTemplate```.
I agree with @callumacrae , "you should not use" warns you that error will occur if you do so, "you cannot use" means the developer will not be able to put a comma there. Or that is what I understand between should not and cannot :p
`All files should end in a newline so the last line does not appear as modified in diffs, when a line is appended to the file.` I've added the line on purpose to comply with the coding guidelines.
I call it a "user account". It doesn't make sense to me to say "Delete own user", it makes sense to say "Delete own account" or "delete own user account".
Table definition should be done in `/includes/constants.php`, the other defines would probably fit better as class constants.
style nit: space between quote and ..
I don't recall any of Display structures in WinAPI, do you? Also the code will be different, I suggest to wrap all platform dependent code in #ifdef macro, not just structures.
>> Actually 'if' block is unnecessary
currently yes, but should be improved later.
It prevented AST from being built. a+b when a and b where expressions.
It is meta.maintainers . You could also add platforms and license...
> >  Does it make sense to call the setup hooks from the user's shell that initialization, where $HOME/.nix-profile/bin is added to the path?

> I  am not sure whether I follow ... could you please explain that idea in slightly more detail?

When a user enters a pkgs.MyEnvFun derivation, all of the inputs into that environment get their setup hooks run and environment variables get set. However, when a user adds a package to their profile using `nix-env -i`, the setup hooks are not run, and those environment variables are not set.. 

I would like a stanza to include in my `.profile` that would run all the setupHooks  of all of the packages I've installed in my `~/.nix-profile`.

>  I -- as a user of asciidoc -- don't want to manage XML catalogs or define my own wrapper scripts. I just want to run a2x and have it work out of the box. IMHO, the best way to accomplish that is wrapping the binary in a script that transparently creates the necessary environment at run-time.

A wrapper makes sense to make things work when asciidoc is installed into a user profile, and I've come up with a clever mechanism to workaround the qualms I had with writing such a wrapper. I think I'll update makeWrapper and add a `-setup-hooks` flag that will call the setup hooks of the buildInputs to be called in the wrapper before executing the command.
If you are posting to the druglist it has to go to a different store pointing to raxacore/raxadrug, as POST is not currently working for the normal /drug (GET is still working there though)
needed later
should ```getId``` and ```setId``` be public and ```getBillItemId``` and ```setBillItemId``` be private? this is a common issue across many classes I've seen in OpenMRS. it's non-ideal to have two methods, both public, that do the same thing.
remove database version dependency
Assert_fast is a confusing variable name to me.

Consider renaming this variable to "perform_using_take"
Commented out lines should be removed
Doesn't offset imply union in Clipper?