labofsahil/github-event-dataset-2012 huggingface dataset:
Btw, I asked to avoid to avoid abbreviating ``constructorArguments`` to ``cstorArgs`` to keep it readable, but ``conn`` is used in the whole Doctrine codebase each time a connection is stored in a variable (both DBAL and ORM) so I would vote for keeping it in this cases (same for ``params``, which may even be used in method names IIRC)
Yes, it does. I am going to update it
Can you add full attribution to the `LICENSE` file? This will mostly be useful if we want to PR this back upstream.
The old behavior was to only use the events toggle if the first *two* arguments were functions. It may not matter, but it's worth noting.
>Again, more assumptions about the situation.

You said "The patch won't be merged upstream". Am I supposed to infer otherwise from that?
I'm glad this is now in Ruby. Good work. I'd say though that the final three parameters should use an options-style hash:

```ruby
puts_columns food, {:stars => stars, :colors => colors, :sort => true }
```

Also IMO sort doesn't need to be handled in the function ;) That is something the API-consumer can do if they choose to before passing items.
According to the output of `brew audit dfc`, this line should read

    system "make PREFIX=\"#{prefix}\" MANDIR=\"#{man}\" install"
I certainly like that.

vim has a similar requirement: `share/vim/vimfiles`
Let's not create this pathname object twice.

```rb
def xctoolchain_path
  @xctoolchain_path ||= begin
     path = Pathname.new ...
     path.exist? ? path : nil
  end
end
```
I forgot to nuke it. Fixed.
This drops the 'sent' key from the batch status so this change will need to be tracked in Vumi Go.
the more problematic case is when one of the file system operations in ``setupProject()`` fails and leaves the newly created project folders in an intermediate / undefined state. what do you think about trying to clean it up after a failed attempt ?
Hmm brauchen wir die getCurrentXXX() shortcuts? GetCurrent->getXXX() sollte auch ausreichen oder?
Stimmt, dann war es vorher aber auch schon falsch, weil rex_path::media() lieferte per default den relativen pfad, also das selbe wie jetzt rex_url.
What's `C0103`?
Not sure about static injections, but we agreed to punt on this notion until later when we can talk about how to validate.  For now, the workaround is that a module must include the parent.
makes db.my_table[key] work for GAE keys
Please add some line breaks to make this more readable
why did you add this above the "package" line?
@dsaff 
They do not now. I mean i was trying to fail the notifier.

But it was worth to test and debug it with 1, 2, 3, 4, 1000, and 10.000 parallel listeners.

One test hanged due to a dead lock in one specific use case, where i understood my fault.  Thus i had to fix RunNotifier, just see my change there.

The failure can be also considered deadlock after 15 sec of timeout.
But the notifier has a proper synchronization and all the usecases are now free of deadlocks.
This doesn't look right. Did you mean to commit it?
Good catch! I wasn't aware I missed this one.
Looks like there's a little whitespace problem here...it actually looks like most of the rest of the file uses tabs instead of spaces. Probably not worth fixing at this point.
My concern with putting the folder name on the left is it would make the horizontal position of the text field vary quite a bit, perhaps unpredictably so.

Your other proposed changes would still work if we left the label on the right, though...

My only other hesitation is that we've avoided the term "project" up until recently (pretty sure that's why I didn't use it when I originally wrote this).  But we started using it fairly prominently in the UI last sprint, so I think that change would be ok now.
The reason was that the function takes a list of file paths instead of just one path, although maybe it should be `_doOpenFilesWithOptionalPaths` with a `fullPaths` parameter?
I think it will help interpret test results faster if "timeout" is somewhere in the timeout message. Maybe it's added somewhere else?
I would make this line be "Получить сейчас!" without the "его"
When displaying URLs, the default way that they wrap is terrible. Basically, they only wrap on hyphens and spaces. Take a look at the technique in this article to see if this can be improved: http://perishablepress.com/wrapping-content/

Note that we also need to do this in other places in UI (e.g. error dialogs, Find in Files results), so some reusable classes would be nice.
In theory, flex-box sounds awesome, but it took very little code to replace it. Yeah, I've been using floats and margins for years and they still seem wrong :) Maybe the sidebar/editor layout could have been implemented using inline-boxes, but we may have run into the same performance problems as with flex-box.
You should be able to use the existing $openFilesContainer (in place of $container) instead of doing this document search.
Please indent according to coding standards.
Are the "prefix" and "suffix" really needed for this test?
shouldn't we use Ext.application ?
This just comments out the wp-less plugin code that wasn't working. I didnt try to debug it because I wanted to try the more straightforward approach first and that worked just fine.
Do we want to delete it or not? It's commented out now.

Also, you need a SpinWait after an invocation to a filesystem delete in a multi-user OS, or you have a race condition on the line below that re-creates it.
a tiny bit of javadoc...?
Of course it is normal that it changes the file as it adapts it to current code. For obsolete translations it does not remove it because it could be useful later on. But in our case we can remove this translation as it was just a bug.
I removed language initialization. I hope this is the correct and only magical thing :D
Want to add the Stamen map types as well? `STAMEN-TONER` `STAMEN-TERRAIN` `STAMEN-WATERCOLOR`
Similar to what I'm doing in the S3 ticket, this should update our README.md.  If you want to file a follow-up bug to do it once this + S3 lands, that's cool.  But let's do it.
actually it looks like it's never used at all
There's a lint error here: `src/util/lang.js: line 86, col 11, Move the invocation into the parens that contain the function.`

While I do *love* the creativity you employed here to introduce and utilize the `timeArr` variable, this approach is strictly more expensive than just storing `timeArr` explicitly with a  `var` statement.

This is interesting though: what happens if you have something that's longer than a day? Do the hours/minutes/seconds make sense still?
Same as https://github.com/mozilla/butter/pull/946/files#L3R30
This comment needs to be much much shorter or outside the dict. One line only please.
I've solved the problem with commit maxximino/zfs@b2f001299194f7622f80e6377188386b7261e54e . Did you miss it (it was referenced in the text of previous pull request) or you've solved differently on purpose?
If you prefer to "approximate" with a oneliner, vap->va_gid looks more reasonable to me.
is this intentional as well?  Seems like you are merging headpin's config into katello's master and pulp would be off by default
I'll have to check. Possibly because of issues under 1.9.3. Another possible explanation is the red cloth was crashing the profiler, and I forgot to restore the Gemfile after I was done.
Curious.. Why this change :)
So how are we actually going to use the options?
Don't think I can use the channel name as `$record['context']['type']`. The type is arbitrary, and defined inside the application when `addRecord()` is called.  
`$record['context']['type']` is used to define the type of the action, e.g. : get (request of a page), write (creation of a file, like a thumbnail), etc ... $type name can be anything, and tied to the record, to the logger instance.

The way `addRecord` is build, I can only add this piece of data using $context. These datas are needed by Cube. I think that these datas can be placed in $context, as they are informations about the context (get, write etc ..).

Should I keep the code as is, but add a default value for `$record['context']['type']` and throw a NOTICE when missing ?
statics hurt parallelism.
I think tim just meant to pick a name that is semantic rather than descriptive of the color. What does the blue button do? Call the class that.
I thought about it. In Amazon multipart upload, the uploadId keeps lingering if the upload is not aborted explicitly. 

Using boto, we can observe all the pending multipart uploads.
```
connection = boto.s3.S3Connection(...)
bucket = connection.get_bucket(container_name)
uploads = bucket.get_all_multipart_uploads()
```

So, Ideally we should abort the multipart upload in case of any exception. Else, we will leave lingering uploads pending in S3. That is why, I decided to catch a generic exception.

Will change the code to ensure that the specific exception is thrown back
(This comment also applies to many of the other methods, but this is the first place I noticed it): It looks to me like when a python float/scalar is input, a scalar is output, right?  I definitely like that behavior, but you should make it clear in the ``Returns`` section that the output type is ndarray or float (and note that it's a float only if the input is a float)
对，g！
http://www.erlang.org/doc/man/string.html#to_upper-1
Mostly a note to myself... but I have a feeling we might soon implement 'gentle' block discouragement-- if we get another block/chain with equal work to the one we have now, perhaps orphan the existing one if we like the new one better (maybe: it removes more transactions from the memory pool than the current best, or it is from one of my mining consortium buddies, or has some of my wallet transactions in it).

Anyway, the ChainWork > condition here must match the condition elsewhere, and if we ever change it to something more complicated the condition here needs careful testing/thought.
Windows doesn't provide a microsecond clock? Or boost::posix_time::microsec_block fails to implement its name?
More spaces needed here, and the same concerns with new markup causing issues in existing applications.  Also you should HTML escape $params['page'].  You can never be too safe.
maybe this should be of type string since it can only be string or null, right?
this will be the first 'goto' in the source tree..  I don't want 'goto' in the main codebase though, tests are ok if you insist :P
Use SELECT 1 ..., see master
Calling `load_all` in document will use the default `export_all=TRUE`. Maybe this line should be move below the call to `document`?
Please use real tabs instead of 4 spaces, also in the rest of your changes :)
I don't think that will work on Python 3 - `StringIO.StringIO` translatest to `io.StringIO`, which expects unicode.  `io.BytesIO` should be the thing to use here. Have a look at the code in `read_py_url()` (which could itself be adapted to call `source_to_unicode`, if this gained a few more options).
@ranyefet  is the iframe CSS issue not handled by https://github.com/kaltura/mwEmbed/blob/2f5fbdedb111684f78358b0151ac96c12ba52b21/modules/KalturaSupport/loader.js#L574

I have added a deprecation note in 946af252fa5d9720c31d0da26750efdfcfff67a9

Let me know if this works for mediaSapce current use case, and if we can migrate them to directly including relevant css in rewrite target in a future version.
This line probably shouldn't go into production. Please remove.
The breadcrumb arrows look below center. I know they're perfectly centered mathematically, but the height of the image is making it so the points of the arrows are a little lower than the center of the text. If that's by design then ignore me, but with a little fiddling it looks like background-positiion: 100% 30%; pulls the arrows up where my eye wants them to be.

The next/prev arrows line up just fine because the images aren't as tall, it's only the breadcrumbs that droop.
Do we need to install here given that the middleware will do it? (Commenting this doesn't break the tests)
Oh, this is much more obvious now. explicit wins.
I'm pretty sure that this isn't quite right. If you look at this loop, it's iterating over the interval filters (created, then updated) to see if the user specified a filter rule there and applying the max-question-age-filter as a default if nothing was specified. That applies to both normal and advanced searches.

I think the bug asked for the max-question-age-filter to be applied to the normal search (a=0) and only to created.

I don't see anything in the comments changing that description of the work to be done. Was there a conversation that changed the requirements?
Also, we should switch to this syntax:

    try:
        blah blah blah
    except Exception as exc:
        blah blah blah

It's clearer that it's creating a name binding and not catching an error of type "exc". This is in the new Django coding recommendations at https://docs.djangoproject.com/en/dev/topics/python3/
(But that is just a curiousity. r+ stands either way) :-)
That's fine by me. Thanks for the answer.
hah, good point
you spelled "Stimulator" wrong.
In the future, please don't escape single quotes like this. Just wrap in double quotes.
HashSet --> LinkedHashSet
There must be a way to distinguish whether a subpattern matched the empty string or did not match at all and was optional.
You can use ValueGuess instead.
After installing symfony during the hack day the test was failing on my machine and an other person on Ubuntu 12.10. So I guessed that it was fixed in a later version of the ICU. 

So I made the function more detailed so that also the number behind the second dot of the version is taken into account.

It now is correct on my local machine but it fails on Travis. So I need to figure out where the change is in the ICU lib to find the correct version number to switch from BR to R.
Symfony uses private properties by default so you should change the visibility IMO
@woodspire If what your class is accessing is only the TableMap, you won't need to mock other stuff. The goal of using mocks is to avoid having to build the full dependency graph. You only mock the direct deps.
This method is implementation specific as its return value is specific to each implementation. So adding it in the interface does not provide any value IMO. Using it already ties your code to a specific implementation, and it forces to implement such method even when there is no raw driver (see your ApcCache)
What is AutoPage?
I'd swap lines 5/6 so it reads "Here is a Thing, now I'll stub File to return the Thing"
Agree. We should fix wherever/whenever we find it to start. I did some searching for it in https://github.com/yammer/sched.do/pull/217 and converted a bunch.
其实这儿还可以把“主要符号对照表”这个也加进来。
Oopsy. good catch there.
remove the /* */
LessFunctor must be optional (default type : std::less...)
Huh.  So it can.  I hate multityping. :P
I found the code that detects both in app.py and basically did exactly that.
Here's memory leak: m_scanline_data points to memory allocated with new[], but there is no delete[]. I would prefer shared_array (Larry, can we use boost pointers in plugins?)
I don't think it can, its only function is to create a fresh instance of the ImageInput subclass and return it.  But it's probably safer to put a check here anyway.
Alle Fehler, die beim Login auftrten, werden an diesen Handler weitergeleitet, wo sie in jeder Form "bearbeitet" werden koennen.
It needs to be able to stick an entry in the breadcrumb trail, and the breadcrumb trail is driven by the primary section (and parents), and the artefact title.

It's effectively adding a pseudo-section to the breadcrumb, with a custom URL.
On 12/03/2012 08:53 PM, liyangfnst wrote:
> In libvirt/tests/virsh_undefine.py:
>
>>
>>       vm_name = params.get("main_vm","vm1")
>>  -    vm = env.get_vm(params["main_vm"])
>>  -    vm.is_alive()
>>  -    vm.wait_for_login()
>>  -    vm_id = virsh.domid(vm_name).strip()
>>  -    vm_uuid = virsh.domuuid(vm_name).strip()
>>  +    vm = env.get_vm(vm_name)
>>  +    vm_id = vm.get_id()
>>  +    vm_uuid = vm.get_uuid()
>>  +    host_type = virsh.driver()
>>  +    if host_type =="qemu":
>>  +        uri ="qemu+ssh://%s/system"  % local_ip
>>  +    elif host_type =="xen":
>>  +        uri ="xen+ssh://%s/"  % local_ip
>
> Sorry, libvirt_vm.normalize_connect_uri(uri) function just returns
> "qemu:///system" or "xen:///". It doesn't contain the IP address and
> "ssh" connection.

Yes, I think you're right.  What about making a 
libvirt_vm.complete_uri(ip_or_hostname) which checks virsh.driver() and 
returns completed string?  I think this would be good general-use 
funtion to have in higher-level library, no?
This is still correct for Unix based systems. Why would this change?
Very sorry to open the PR immaturely. I am just trying different options. Current there are 8 test failures when running the whole suite. It has something to do with this. I am still in trying fix the build state
Maybe add a note that other than the prefix stuff, this is standard django behavior
do we need to save the page after changing the FK? I think not.
I think you're right. That should work. I'll make the changes and do some testing to confirm.
Hooray for not supporting jQuery 1.3.2 :-)
calling this method `start` is very misleading...
`pass` is the Python noop. But at least log something, especially if neither file-fetching succeeds.
Go ahead and create a mechanism for this.  I don't want to have placeholder stuff on the production site.

Additionally, you can immediately follow tags with content, ````p Subtitle will go here. Somehow.```` -- there's no reason to use the pipe operator here.
Not sure if it should go in this test file or elsewhere, but we should add code that tests submission when enumerator credentials are turned on.
better not to have anonymous function.
nit: use all `null` or all `''` (I prefer `null`)
Bot.io isn't going to be a happy robot :)
I'll ask him for all the linting issues, this will be quicker.
when getWeekStartDate returns 0 (currentDay === startDay), than createDay uses date.getDate() instead of given day (0).
I guess I would prefer that you save the value once before the timeout, like |var time = _appSettings.option('calltime');| and then do a time += duration; _appSettings.option('calltime', time);

How does it sounds?
Same comment as above about the formatting.
I don't think this will work.
IMHO the comment is superfluous
Hi Jose, can you move this part to a specific stylesheet or do you need to have it here?
buttons as landed.
Agreed, the `connecting` state is incorrect here and `currentNetwork` is likely to point to a non-relevant object.

If the wifi manager isn’t enabled, I’d say it should say something like `offline` (fullstatus-disconnected) or `disabled`, right?
In fact I removed the use of the CustomDialog object from any place of the Communications app. It was being used also in the Contacts tabs for some messages shown to the user.
I think we should keep `danger` classname, if not the edit mode selection buttons will look like grey color instead of red
`RepeatPickerView`
`as_p` is usually weird... but we should be marking our forms as safe and not have to use the filter.
haha ok fine.. leave it as is :)
I don't suppose we need to log every relation
sure; make sense, I just pushed again.
just a minor hint: you can write this as

    for hue, points in zip(function_hues, mesh_points):
        ...
This breaks conjunction with `DelegateBehavior`, where a column of the pattern is provided by the target class ("parent") and not by this class.
I didn't understand what you are trying to say here. For ssl it is /var/www/pulp_puppet/https/repos while for non-ssl  /var/www/pulp_puppet/http/repos.
> It is essentially delayed now

Its not delay. It happens on page load. Really should touch replaceState until we have too.
(I don't use Travis, I just run the tests from the command-line using [PHPUnit](https://github.com/sebastianbergmann/phpunit).)
wow dude you have green rage
This method does nothing, and is never called
What about using a tighter matcher on this, like `#equal?` ?
fix :palm_tree:
Why `.json` ?
Yes, to join int with long you would need to do:

pipe1.map { tup => (tup._1.toLong, tup._2) } join pipe2
I don't understand why you're reassigning the speaker (especially when testing the presentation time).
You should remove any general help from here. General help is better provided by `help_*()` methods. So look at `help_talk()`, `help_config()`, etc.
Exactly.  And while I agree that, traditionally speaking, they're long-ish names, by Pythonic standards they're pretty average.
It's meant to be that way. Each service may have to implement different calls for sending out its message and/or handling events.

The describeUser method could be merged, though.
did you mean to say sad sad
Okay.
Btw, CoffeeScript is making garbage out of it:
```
  if (!(this[prop] != null)) {
    continue;
  }
```
Also for short loops, a normal `if` with indentation is shorter than a `continue` statement.
What is this trying to achieve? if the typeof window is undefined then use undefined, otherwise keep the same... I struggle to see any difference introduced by this line.
Just to clarify, do you mean doing this?

var gst_exports;

...etc...
if (global_setup_teardown_file) {
  ...
  gst_exports = require(global_setup_teardown_file);
  ...
}

?
I add __preg_quote__ to avoid using any regex pattern.
And __preg_quote__ will escape naturally the * so I guess I need this?
dead break statement
it simply means that we cannot add another argument *after* this one. (array arguments have to come at the end as they will catch all arguments remaining to put them in the array). But using an argument for packages is better than an option IMO as they are what the command work on.
Why not just put that in the PearInstaller? I don't think it's needed for non-PEAR packages.
What's wrong with the toplevel cancel? :)
Maybe swap the place with _submittable, I like it if methods are defined after they are called. This usually leads from a high abstraction level to a lower one in the file which gives you earlier an idea what is actually done without reading the absolute details on how it is done ;)
Backboneのすべてのパブリックのクラスとモジュールは〜
CRON_SUPPORT_TEST and CRON_VFS_SUPPORT are hidden now if TEENSY_SUPPORT is active.
Could you please fixing the indenting, and the spacing on the following line (needs a space after `}`)
By saing that I would expect it to become `text/plain` if it isn't set. Same thing for parameters.
where does `listNS` come from?
It -> If
One thing you could do here for clarity is just set self.submit to transitionComplete instead of verify on Module declaration. From my brief look at the code, it does not look like self.submit is ever called when submit is set to transitionComplete. I was initially confused where transitionComplete was getting called.
please add the new line.
That's pretty interesting. Do you have more information about it? Why does it happen that the anonymouse declaration is that much faster?
Sweet change. Good to see that we can have a single method for it.
@zaphod42 had suggested that this should be limited to only these two rather than all so that we would not  have this behavior across all properties (unless we know for sure they were removed too.)
To test that glob characters don't cause a problem - writing a whole bunch of extra tests seemed excessive
Will do. By the way the issue I wrote to highlight got fixed in ruby 2.0, but I couldn't get the specs to run on my machine at the time, not sure why. So I've left this hanging.
https://github.com/rubyspec/rubyspec/pull/150/files#L0R73
I believe it now raises an ArgumentError on ruby 2.0
the purpose of this test is to reset the default adapter:
AbstractTable::setDefaultAdapter(null);
and then set it within the validator, since the getDefaultAdapter function does not exist and the adapter has to be provided in the constructor, this test becomes irrelevant.
Docblocks were wrong (and had been before). Instead I updated those.
Both lines are the same? \u0022 is the unicode escape for ". JSON interprets them as the same thing.
Once you've incorporated the previous comment, this can be moved out of the else condition.
I needed to change it, because for my Collection to work, I have to call some elements by a number (0, 1, 2...) in order to be indexed correctly (of course this is not a recommended practice I think to name form elements by an integer, but in this particular case I have no other choice ;-).

And !empty(0) === false while strlen('0') > 0 === true :)
if you use `Date $date = null` as signature for the first argument then you don't need the next check
Named requests would be sweet.  Are you moving stuff out of base component?  Seems like anything having to do with routing/linking should be in SimpleComponent.

BTW - we should come up with a better name than SimpleComponent.

-Mike

Mike Reich
Seabourne Consulting
Office: (202) 684-6971
Cell: (503) 621-7056
mike@seabourneinc.com



On Mar 26, 2012, at 10:51 AM, Luke Opperman wrote:

>> -class Install extends BaseComponent {
>> -	public function __construct() {
>> -		parent::__construct();
>> -	}
>> +class Install extends \Cumula\Application\SimpleComponent {
>> +	public $defaultConfig = array(
>> +		'basePath' => '/install'
>> +		);
>> +	public $routes = array(
>> +		'/' => 'startInstall',
>> +		'/setup_user' => 'setupUser',
>> +		'/system_check' => 'systemCheck',
>> +		'/save_user' => 'saveUser',
>> +		'/finished' => 'finished',
>> +		'/complete' => 'complete'
>> +		);
> 
> I like it too. Ideally I'd like a way to also provide 'named' urls (for linkTo, redirects, etc) so that both the url structure and the code structure can be rearranged without needing to change all url references. It's too handy to ignore. Perhaps the array values can be either strings or some NamedRoute object/array. Anyways, seems extensible in that direction with this still as a clear simple option.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Cumula/cumula-core/pull/35/files#r603233
Is there a better way in Doxygen to make multiple words as ```<tt>```?
Actually this one is meant to be part of this pull request, because it is working around a Razor bug in MVC4.
________________________________
From: Luan Nguyen
Sent: 11/13/2012 10:16 PM
To: NuGet/NuGetGallery
Cc: Tim Lovell-Smith
Subject: Re: [NuGetGallery] Update gallery Website to depend on asp.net MVC 4. (#642)


In Website/Views/Packages/ContactOwners.cshtml:

> @@ -17,7 +18,7 @@
>              @Html.AntiForgeryToken()
>              <div class="form-field">
>                  <label for="NotUsed">To</label>
> -                <input name="NotUsed" type="text" value="@Model.Owners.Flatten(@<text>@item.Username</text>)" disabled="disabled" />
> +                <input name="NotUsed" type="text" value="@owners" disabled="disabled" />


Again, this is not related to this pull request.

-
Reply to this email directly or view it on GitHub<https://github.com/NuGet/NuGetGallery/pull/642/files#r2120609>.
May I ask what the difference between hooks.callAll and hooks.aCallAll is? I did not find any docs about it.
`<script src="js/libs/knockout-2.0.0.js" type="text/javascript"></script>` 
->
`<script src="js/libs/knockout-2.0.0.js"></script>`

Also use /lib instead of /libs
This method probably needs documentation that at least explains the expected format of ```named_sql``` and what the reset of the arguments do. This might also be a good place to explain why we use OGR and what need to be installed?
Odd, in what way do they fail?
Aivan. Näin on käytännösäkin tilanne kannasta katottuna.

On 6.11.2012, at 13.21, Joni Kanerva <notifications@github.com> wrote:

> In myyntires/eikateinen.php:
> 
> > \ No newline at end of file
> > +		if ($myysaatili == "") {
> > +			if ($kateisrow["kassa"] != "") {
> > +				$myysaatili = $kateisrow["kassa"];
> > +			}
> > +			else {
> > +				$myysaatili = $yhtiorow['kassa'];
> > +			}
> > +		}
> > +	}
> > +	else {
> > +		if($laskurow['kassalipas'] != '') {
> > +			//haetaan kassalippaan tilit kassalippaan takaa
> > +			$kassalipas_query = "	SELECT kassa,
> Ei ole mahdollista, että kassalippaalta puuttuu tilitietoja. Ne ovat pakollisia. Tarkistus tehdään kassalipastarkista.inc tiedostossa.
> …
> —
> Reply to this email directly or view it on GitHub.
> 
>
@FabioBatSilva I think I'm with @stof on this one...
I totally agree we should follow JPA/Hibernate closely, but there're some optimizations and minimal changes required sometimes.
this is wrong. You should not reset it to an array but to an ArrayCollection. Putting an array in the property would break thinks
Missing line break between assignment statement and conditional statement.
Also, the `=` signs are not aligned.
Needs changing to "on this journal" (or similar), to account for both communities and personal journals. For this style?
You don't need the `list_to_atom()` call anymore, the rest should still "stay".
TODO: Listen to escaped (post-merge)
Hi,

>> > +sourceURLs = ['ftp://selab.janelia.org/pub/software/%s' % name]
>>
>> use http download URLs, if possible
>
> I also prefer that but, these guys seem to only provide the software
> at an ftp endpoint.

fyi.

as regards the above, there is also a more generic subject to discuss about
how to manage downloads; one corner case I met is an HPC system which has
the unusual policy to not allow download/compile cycles on the same nodes.

The workaround I found was to use easybuild with the stop action after
fetching against
all possible .eb files, then spawn it as normal (orthogonality paid
back once more!)

It would be nice to be able to "feed" the process from some kind of
caching server
(easybuild sources mirror anyone? http/ftp/rsync...) or local caching directory.

I don't create an issue on the above since I can't tell what the issue
is about ;-)
but it is a good topic to discuss in a next meeting and see what we
come up with.

cheers,
Fotis
Just asking, but is this the canonical style instead of (key, val) ?
I missed it before, this needs `$Sockets` like the other one.
This is not equivalent. pds.dataBlock reads the packet from the stream so the next one can be processed which has to be done even if Opus is disabled.
Yep, I think that the TODO is likely to stay there for some time :)
thanks. appreciate all the suggestions - I've taken them all and significantly simplified the whole thing.
Is this a missing bit from earlier haml work, or what does it do?
This probably won't be visible at all for people with crappy old passive-matrix LCD screens with crappy contrast :(
join should be upper case
Ok i will remove this
True, we should only do that when absolutely necessary!
No, because the `dispose()` will trigger a `VMDisconnectedEvent` which needs to be processed by the actor.
// AMD module
    if (typeof define === 'function' && define.amd) {
      define('swfobject', create(window));
I'll fix these but it's good to look at the code around and see what the style is `function(){` instead of `function () {` etc
Ah ok. But we should make those settings not required in the manifest?
Please delete the code instead of commenting it out. We have version control...
Again, same question as with the years - why is the number changed?
Не обязательно. Я решил сделать отдельный метод, в котором можно задавать любое значение длины молекулы.
init же формирует молекулу со значением по-умолчанию - 100.
Call? Cell же))
I've found having something available to trigger an error comes in handy, if only for when things are working so smoothly you wonder if errors are being reported properly. What about it unnerves you?
Will do.

On Tue, Apr 10, 2012 at 6:06 PM, Corey Donohoe <
reply@reply.github.com
> wrote:

> > @@ -85,7 +85,8 @@ module.exports = (robot) ->
> >        if statusCode == 201
> >          msg.reply body
> >        else
> > -        msg.reply body
> > +        console.log body
> > +        response = "Error F7U12: Can't Setup."
>
> Oh, I was commenting on the console.log out. Let us know if you get it
> sorted.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/github/hubot-scripts/pull/371/files#r668761
>



-- 
Brett Hardin
www.sourceninja.com
http://angel.co/sourceninja

P: 408.685.1569
The output might appear cleaner with `indent=4` and `sort_keys=True`.
My thought was to stick with what's in the FIFF file as closely as possible (because I don't even know what HIS means :) )
@Eric89GXL  comment made me think that it may make sense to support modes other than multi-taper. Fieldtrip for example supports connectivity computation using time-freq decompositions. Would it make sense to support this as well using Morlet wavelets? We could have a parameter `spectral_mode` which could me `'multitaper'` (default), or `'morlet'`. This should allow the addition of other modes like the one Eric suggested pretty easy. 

WDYT?
If the user overrides the `id` field and named it something else, does this still work? Should we be using the `autofield` or whatever django calls it?
why do you need this and? the nest string you concatenate on line 351 below is a concept field so why not pull this out of the if clause?
purely a style thing, but I would prefer:

```
if FIle.exists?(path)
  path
else
  nil
end
```

Or even a ternary operator. I may be in the minority.
@richardmiller - I think the choice is obvious - when you need to render something other than PHP specifically you should use `..code-block:: ` and the other instance is when you need to make a tabbed block, with YAML/XML/PHP, then a codeblock is obviously required. In the docs I wrote for sessions for example I have no need for tabbed blocks and it's all done in short syntax because it's just PHP, even though some examples are large. When looking at the plain text it's quite readable like that - in fact, the less RST markup, then better frankly.
My bad, I missed this commit.
HTTP管线化
我们没有找到很标准的说法
所以还是用"流水线(pipelined)"吧
This list is just from exceptions which I've experienced in production applications over the past several years, as I mentioned in the pull request.  I'm actually more concerned that there are additional exceptions thrown from the Errno module:

```ruby
> Errno.constants.sort
 => [:E2BIG, :EACCES, :EADDRINUSE, :EADDRNOTAVAIL, :EADV, :EAFNOSUPPORT, :EAGAIN, :EALREADY, :EAUTH, :EBADE, :EBADF, :EBADFD, :EBADMSG, :EBADR, :EBADRPC, :EBADRQC, :EBADSLT, :EBFONT, :EBUSY, :ECANCELED, :ECHILD, :ECHRNG, :ECOMM, :ECONNABORTED, :ECONNREFUSED, :ECONNRESET, :EDEADLK, :EDEADLOCK, :EDESTADDRREQ, :EDOM, :EDOOFUS, :EDOTDOT, :EDQUOT, :EEXIST, :EFAULT, :EFBIG, :EFTYPE, :EHOSTDOWN, :EHOSTUNREACH, :EIDRM, :EILSEQ, :EINPROGRESS, :EINTR, :EINVAL, :EIO, :EIPSEC, :EISCONN, :EISDIR, :EISNAM, :EKEYEXPIRED, :EKEYREJECTED, :EKEYREVOKED, :EL2HLT, :EL2NSYNC, :EL3HLT, :EL3RST, :ELIBACC, :ELIBBAD, :ELIBEXEC, :ELIBMAX, :ELIBSCN, :ELNRNG, :ELOOP, :EMEDIUMTYPE, :EMFILE, :EMLINK, :EMSGSIZE, :EMULTIHOP, :ENAMETOOLONG, :ENAVAIL, :ENEEDAUTH, :ENETDOWN, :ENETRESET, :ENETUNREACH, :ENFILE, :ENOANO, :ENOATTR, :ENOBUFS, :ENOCSI, :ENODATA, :ENODEV, :ENOENT, :ENOEXEC, :ENOKEY, :ENOLCK, :ENOLINK, :ENOMEDIUM, :ENOMEM, :ENOMSG, :ENONET, :ENOPKG, :ENOPROTOOPT, :ENOSPC, :ENOSR, :ENOSTR, :ENOSYS, :ENOTBLK, :ENOTCONN, :ENOTDIR, :ENOTEMPTY, :ENOTNAM, :ENOTRECOVERABLE, :ENOTSOCK, :ENOTSUP, :ENOTTY, :ENOTUNIQ, :ENXIO, :EOPNOTSUPP, :EOVERFLOW, :EOWNERDEAD, :EPERM, :EPFNOSUPPORT, :EPIPE, :EPROCLIM, :EPROCUNAVAIL, :EPROGMISMATCH, :EPROGUNAVAIL, :EPROTO, :EPROTONOSUPPORT, :EPROTOTYPE, :ERANGE, :EREMCHG, :EREMOTE, :EREMOTEIO, :ERESTART, :ERFKILL, :EROFS, :ERPCMISMATCH, :ESHUTDOWN, :ESOCKTNOSUPPORT, :ESPIPE, :ESRCH, :ESRMNT, :ESTALE, :ESTRPIPE, :ETIME, :ETIMEDOUT, :ETOOMANYREFS, :ETXTBSY, :EUCLEAN, :EUNATCH, :EUSERS, :EWOULDBLOCK, :EXDEV, :EXFULL, :NOERROR] 
```

As you can see, there are quite a few of them, and they are basically impossible to track down.  But again, those are ones that have bitten me at one point or another in the past.
Any way we can get some backwards compatibility here?

```ruby
proxy[:user] || proxy[:uri].user
```
Its to check my fork. Change it on yours.
`get_instances` is an internal method correct? so Page and PageSize always passed as part of a params dict, don't need kwargs here
Yea, It was a duplicate test.
Hahaha, yeah, they did:

https://github.com/jaraco/path.py/blob/master/path.py#L125

```python
# The / operator joins paths.
def __div__(self, rel):
    """ fp.__div__(rel) == fp / rel == fp.joinpath(rel)

    Join two path components, adding a separator character if
    needed.
    """
    return self.__class__(self.module.join(self, rel))

# Make the / operator work even when true division is enabled.
 __truediv__ = __div__
```

I like it because I find it much more readable, but it is a bit wonky.
Is this just adding more flexible instantiation? And you don't want

```python
>>> PythonRationalType(PythonRationalType(1,2))
PythonRationalType(0, 1)
```

How about renaming it to _PythonRationalType and making it a private function?
No, this is right. NaN is the otherwise condition.  See the prior discussion, both here and on the mailing list.  During the deprecation cycle, you can force (expr, cond) pairs to be viewed as that (rather than (expr_otherwise, True)) by manually adding nan as the otherwise condition (this is the default otherwise condition, so this changes nothing).
No, I was referring to a line that seems to be gone now.  GitHub left my comment for some reason.  You can ignore this comment now.
I tried using `set` in __add__ ; it is a bit slower; that does not matter because this routine takes little time;
but I do not see why using `set` the code would be clearer.
Ты это для каждого аккаунта что ли делаешь?
Ты уверен, что показывать номер ошибки — хорошая идея?
Почему так? Может, я хочу закрыть таб и управлять LMP через трей?
Minor thing; Instead of "out object value" you could return an EvaluationResult :) "out" is not used in many places in fubu.
Variable naming: $user_surveys / $asurvey
typo s/corrctly/correctly/
All these comments might not be necessary. The two lines after UPDATE, the comments there, though, are good.
I wonder if split/strip wouldn't really be easier to understand than what appears to be an incantation to Yig, the Father of Serpents
CHM.remove() only throws an exception if the path is null, and I'm pretty sure you can't create a File with a null path.
You overwrite the iframe in the modal body in the modal_video.js file. Do you need to have the iframe in the html too?
80 seems like an awkward rule. I'd make sure it's clear the goal here is readability, not "80 characters or we set you on fire". Plus, I'd hate to be the person who writes the pre-commit test to reject all files with lines > 80 characters...
But really, you may as well just use string equality:

```
if s == 'auto'
```
Is there any benefit to defaulting to None? Wouldn't it simplify the code to default to 0 and just jump straight in to ```theta1 = startangle / 360.0```?
Thanks for the note here :) this was a curiosity to me.
not req'd
I would be inclined to make this 30 seconds (the emulator is slow) or make it configurable. I believe this is already filed in [bug 794687](https://bugzilla.mozilla.org/show_bug.cgi?id=794687)
This set -eu is used to abort the script on any error. This way the "&& \" can be removed from the line ends in this script as set -eu just has the same effect.
I like how you've changed it. Much clearer.
@bp323 Fixed this & some style issues in a follow up commit
yep, but this a part of bridge. I created wrappers for  all used in newscoop methods.
I think this should probably just be filed as a separate bug for better error reporting, as fixing this is a bit non-trivial--jQuery's ajax error reporting callback returns different information in different arguments that we'd want to do a bit of logic with to provide users with reasonably useful information.
Ahh ok. Consider adding some comments to explain the format.
@question_form_action is only defined in this one place -- are you expecting it to be set somewhere?  If not, why is it here?

Are searches still happening through JS?  If not, shouldn't we ditch this file and the "format.js" in QuestionsController::search?
Potential Rewording?

> Purging an extension clears an extension's data while retaining its files.
重複性的東西可以練習用 array 跑 .each 做喔

```haml
- [[:review, "商品使用心得", '109x29'], [:new_product, "最新商品", '78x29']].each do |data|
  %li
    = link_to( image_tag("/assets/top_menu/#{data[0]}.gif"), "#", :alt => data[1], :size =>  data[2])
    = image_tag("/assets/top_menu/dash.gif")
```
It'd be better to use a "See also" box. Take a look at the source of the [Basics](http://freeseer.github.com/docs/contribute/basics.html) page, there's a few there.
Are you sure you want to override the parameter ``$helpHtml``? This often makes code less readable.
I though there are more changes than that, but diff shows that most of code is the same.  So why not to move common code to a separate file to reduce code duplication (and the probability of making changes only in one file of two)? Could you do that please? It's OK if not, I can do that myself during (or after) merge, but maybe in a couple of days.
cannot be int. Should be char(38)
Also add the additional audit columns:
<column name="creator" type="int">
  <constraints nullable="false"/>
</column>
<column name="date_created" type="DATETIME">
  <constraints nullable="false"/>
</column>
<column defaultValueBoolean="false" name="voided" type="BOOLEAN">
  <constraints nullable="false"/>
</column>
<column name="voided_by" type="int"/>
<column name="date_voided" type="DATETIME"/>
<column name="void_reason" type="varchar(255)"/>
<column name="changed_by" type="int"/>
<column name="date_changed" type="DATETIME"/>
Would be useful to show the entire relationship object here.
This method is used to validate file format before storing it on the server. Therefore it must not be cluster aware as it is used on temporary files.

However I'm updating the `initialize()` method to fetch file from cluster before calling this method.
I would include IDexterityContent in the conditional import above, then just check IDexterityContent.providedBy(obj)
You want to check lower limit here, no?
because user gender defaults to female and doesnt take into consideration facebook gender because of the fi statement
if user.gender is None:
No, `/profile/<username>/`.
No, this is not the correct way to translate strings which depend on count of some object. Read documentation. You will have to separately translate strings for hugs and for runs and then concatenate them together.
`.show()`?
Why is it copied?
Were the tests using setInterval before?
Ok, as suggested by @mdz444 I will removed this implementation of resurrection and sent a pullrequest to carmack78.

Let me know if other modifications (mainly experience, items and equipment saving) is ok
Cool conversion, I like it.
I wonder if we could leave the old mapping of capture => mark, and call reauth "partial_capture" on our side.

Then I think the code below will be more clear on what exactly we're doing.
There is such added already however I forgot to add type filter. Thanks.
Das ist glaub nicht nötig...
I have just made a change so the LinkedHashMap behind the DBObject is constructed with the size from columnNames.length. Also switched to a DBObject for consistency and readability.
Right. But we want to extend PigStorage().
Sounds good.
On Sep 19, 2012 11:52 AM, "Veena Basavaraj" <notifications@github.com>
wrote:

> In test/jasmine-test/spec/helpersTests.js:
>
> > +  },
> > +  {
> > +    name:     "ne helper matching string case",
> > +    source:   "{@ne key=\"foo\" value=\"foo\"}not equal{/ne}",
> > +    context:  {},
> > +    expected: "",
> > +    message: "ne helper matching string case"
> > +  },
> > +  {
> > +    name:     "ne helper non matching string case",
> > +    source:   "{@ne key=\"foo\" value=\"bar\"}not equal{:else}bar{/ne}",
> > +    context:  {},
> > +    expected: "not equal",
> > +    message: "ne helper non matching string case"
> > +  },
> > +  {
>
> there is a type parameter ( would suggest adding foe type="number" and few
> others i dont remember on the top of my head.. test cases for completion )
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linkedin/dustjs-helpers/pull/14/files#r1643419>.
>
>
Nitpick: extra space at the beginning.
Might skip braces here.
ah, you might need to use the inline keyword. Ex:

inline GoogleString PointerToString(void* pointer) {
  return StringPrintf("%p", pointer);
}

from string_util.h:102
No, this is incorrect. You cannot include a UI header in qbtsession.cpp. This will break qbittorrent-nox.
If you called 'return' on this line, it would enable you to remove the 'package' variable all together. What you have done looks fine, though. This is purely a style thing.
Instead of this `key_val` thing you can do:

```ruby
current.inject({}) do |ret, (key, value)|
  ret[key] = expand(val, haystack)
  ret
end
```
Yea, looks cleaner to me
Wrong Nikp :)

This nikp doesn't much like php ;)
If there is no assets dir (e.g it's nil) then this will throw an exception:

      FileUtils.cp_r(
        File.join(@assets[:location], @assets[:dir], '.'),
        assets_dir
      )

(to test, just open 'irb' and do File.join( 'foo', nil ) )

We should either make sure it's empty string, or do something else. Semantically, I'm not even sure what would happen if the File copy tried to copy the base asset dir...
And then change the check here to be != 0.
AH good spot, thank you, I'll fix the docstring...

On 31 May 2012, at 09:37, Jörg Dietrich wrote:

>> @@ -333,8 +333,8 @@ class OpticalPSF(GSObject):
>>     --------------
>>     @code
>>     optical_psf = galsim.OpticalPSF(lam_over_D, defocus=0., astig1=0., astig2=0., coma1=0.,
>> -                                        coma2=0., spher=0., circular_pupil=True, interpolantxy=None,
>> -                                        dx=1., oversampling=1.5, pad_factor=2)
>> +                                        coma2=0., spher=0., circular_pupil=True, obs=0.,
>> +                                        interpolantxy=None, dx=1., oversampling=1.5, pad_factor=1.5)
> 
> The dx=1. seems to be left over from an earlier version.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/173/files#r909194

--
Barnaby Rowe

Jet Propulsion Laboratory
California Institute of Technology
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom
it seems like it might be a tiny % quicker to move this test into the `if real_space:` block directly below, starting at line 628.
Quite right.  That was backwards.
This debug output should be deleted
The comment does not help. A comment should describe the non-obvious. Most programmers would understand this. Please add the explanation of why a keyPress is something else than a keyDown and keyUp. You gave me the explanation, but I do not need to know. It is the coders who need to know this.
actually, not count().  exists() is better.
ok, i'll fix.
I ran a jslint check and this wasn't reported, do we have a particular ruleset ?
The reason Sam called it "deployments" instead of "wars" is that they are not all wars. For example, it could be ears or it could be some jar that contributes services in as7. I think that Sam got the name "deployments" from AS7 docs - if so then I think it's a good name to go with.
Would it be possible to compose the "default" case with 2 existing templates ? Something like:
    template("apache/simple-redirect-ssl.erb", "apache/vhost-ssl.erb")
It seems to me there is a lot of duplication between vhost-redirect-ssl.erb and vhost-ssl.erb -> risk of discrepancy sooner or later.
I can't understand a need for this change.
But, dmd said `getTypeIds is not accessible` at code in DragSource.
It may be a bug in the compiler.
comment could be helpful.  I'm guessing that jelly doesn't wire up transitive deps like .cloud?
Ah, I thought the concat module did that automatically. I will update this.
this time it’s a real comment, to tell what properties are expected in the 'network' object.
I was thinking you'd literally put that url with the {profile_id} bit into settings.py.
Oops, yep!  I can update real quick too.
what is sdfsdf ?