From Richard Sharpe:

I noticed some inconsistencies in the command naming. The following
patch fixes those (so that they now match between SMB and SMB2):



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43495 f5534014-38df-0310-8fa8-9805f1628bb7
Validate 'offset' before calling proto_item_set_end(); prevents potential 'Dissector Bug' msg
Addresses comment in Bug #7390 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7390#c1


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43496 f5534014-38df-0310-8fa8-9805f1628bb7
Display expert codes in hexadecimal (less painful for my eyes :))


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43497 f5534014-38df-0310-8fa8-9805f1628bb7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7406 :

Build the idl2wrs man page (including the HTML version) but don't install
them: a developer might want to read the man page and the Debian development
package wants to install them.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43498 f5534014-38df-0310-8fa8-9805f1628bb7
General cleanup:
- Remove _U_ when function arg is actually used;
- Use consistent formatting and whitespace style.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43500 f5534014-38df-0310-8fa8-9805f1628bb7
Don't supply a fallback error message for pcap_open() unless it actually
fails.

This may clear up the problem most recently reported in bug 7021 after
the crash was fixed, where the capture starts successfully but an error
dialog pops up.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43501 f5534014-38df-0310-8fa8-9805f1628bb7
From Martin Raison via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7414
PMIPV6 support over IPV4 network

PMIPv6 is an extension of MIPv6, adding a certain number of options to the
MIPv6 protocol. These options are already implemented in the wireshark
dissector, and the MIPv6 headers are recognized, but only inside IPv6 packets.

However, RFC5844 extends the PMIPv6 protocol to make it work over IPv4 networks
: as explained in section 4 of this RFC, the MIPv6 message is carried inside an
IPv4 packet with a UDP header. The port number in the UDP header is 5436



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43505 f5534014-38df-0310-8fa8-9805f1628bb7
From Jakub Zawadzki: Fix "typeahead search broken in Display Filter Expression Window"

Revert SVN #42291.

Fixes Bug #7412: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7412



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43506 f5534014-38df-0310-8fa8-9805f1628bb7
Fix for "predefined values sometimes missing in Display Filter Expression window.

See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7413

Essentially: BASE_CUSTOM was being used as a mask rather than a field value.



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43507 f5534014-38df-0310-8fa8-9805f1628bb7
Don't show (essentially meaningless) numeric values of the expert codes.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43508 f5534014-38df-0310-8fa8-9805f1628bb7
Fix compiler warning: "format not a string literal and no format arguments"


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43509 f5534014-38df-0310-8fa8-9805f1628bb7
Prettify display of O_RDONLY and O_ACCMODE flags


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43510 f5534014-38df-0310-8fa8-9805f1628bb7
Commit file which should have been part of SVN #43506

From Jakub Zawadzki: Fix "typeahead search broken in Display Filter Expression Window"
 
 Revert SVN #42291.
 
 Fixes Bug #7412: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7412



git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43511 f5534014-38df-0310-8fa8-9805f1628bb7
Rename the GArray of interfaces "if_array", to indicate what it really
is, and rename the routine that creates it to "make_if_array()".


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43514 f5534014-38df-0310-8fa8-9805f1628bb7
From Pontus Fuchs:

	add a capture_dlg_refresh_if() routine to redraw the list of
	interfaces in the Capture -> Interfaces dialog if the lsit of
	known interfaces is updated, and have it do that not by
	destroying and reconstructing the entire dialog box, but just by
	destroying and reconstructing the table containing the
	interfaces and their statistics.

From me:

	have a refresh_interfaces_cb() routine in ui/gtk/main.c that
	scans the local interfaces and refreshes *all* the widgets that
	have interface lists;

	add a "Refresh Interfaces" item to the Capture menu that calls
	that;

	have the "Refresh" button in the "Manage Interfaces" window also
	call that;

	rename the Capture Options window routine dlg_window_present()
	to capture_dlg_window_present() to make it clearer *which*
	dialog it checks for;

	fix Pontus' patch to call capture_stat_stop() *before* nulling
	out the global pointer for the statistics cache - if it's called
	*after* nulling it out, the argument passed to
	capture_stat_stop() is null, and it doesn't kill off the dumpcap
	gathering the statistics so they just pile up (and, at least on
	OS X, chewing up BPF devices until you run out of BPF devices
	that have the right ownership and permissions for dumpcap to use
	as a normal user);

	if refreshing the interfaces fails to get an interface list,
	close the Capture Interfaces dialog.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43515 f5534014-38df-0310-8fa8-9805f1628bb7
No pcap, no interfaces, no interface lists to refresh.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43516 f5534014-38df-0310-8fa8-9805f1628bb7
Detangle the code that manages the interface list on the welcome screen:

    fill_capture_box():

	if there are interfaces on which to capture, constructs the
	interface list, otherwise destroys the interface list and puts
	up a message.

    update_capture_box():

	updates the interface list to reflect current reality.

    welcome_if_panel_reload():

	if there is an interface list, and if there are interfaces on
	which to capture (so that we still want that list), updates the
	list by calling update_capture_box(), otherwise creates or
	destroys it by calling fill_capture_box() (as either it doesn't
	exist but now needs to or does exist but needs to go away).

Have refresh_local_interface_lists(), which re-fetches the list of local
interfaces and updates every interface list that includes local
interfaces, and refresh_non_local_interface_lists(), which only updates
interface lists that (also) include interfaces other than local
interfaces (such as pipes and remote interfaces).  Call them in the
apprpriate places (if we know the list of local interfaces has been
updated, call refresh_local_interface_lists(), otherwise, if we know
interfaces other than local interfaces have been added or removed, call
refresh_non_local_interface_lists()).

Don't have any routine that updates the interface list for one widget
update the interface list for any other widget; leave the global
updating of interface lists up to refresh_local_interface_lists() and
refresh_non_local_interface_lists() - only call one of them if any
interface lists are to be updated.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43517 f5534014-38df-0310-8fa8-9805f1628bb7
Make scan_local_interfaces() local to ui/gtk/main.c; widgets/windows
that want a list of interfaces should either call
fill_in_local_interfaces() to make sure the list has been populated at
least once or refresh_local_interface_lists() if they want the list to
be rescanned.

Also make get_interface_type() local to ui/gtk/main.c, as it's not
called from outside ui/gtk/main.c.

Don't declare fill_in_local_interfaces() or hide_interface() unless we
have pcap - we don't define them unless we have pcap.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43518 f5534014-38df-0310-8fa8-9805f1628bb7
Comment/#ifdef out a currently-unused variable.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43519 f5534014-38df-0310-8fa8-9805f1628bb7
Update some refresh_interfaces_cb() calls appropriately.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43520 f5534014-38df-0310-8fa8-9805f1628bb7