gh-2956 Roxie support for HTTPCALL activity

Roxie was throwing an exception "Unimplemented activity" if a query
tried to use HTTPCALL.

Fixes gh-2956.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
gh-3009 LOCAL on a keyed join causes Roxie to misbehave

LOCAL on a keyed join is really only meaningful inside an ALLNODES
(typically used with NOROOT indexes). However, as coded, LOCAL would
cause incorrect behaviour if specified in other situations.

This change causes the local to be ignored except in an ALLNODES or
potentially in a child query called from remote code such as an index
filter condition. It's debatable what the correct behaviour in the latter
case is.

It's also debatable whether the compiler should have given a warning or
error when LOCAL is specified in cases that do not make sense.

Fixes gh-3009.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3062 from richardkchapman/roxie-httpcall-gh2956

gh-2956 Roxie support for HTTPCALL activity

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #3068 from richardkchapman/roxie-local-gh3009

gh-3009 LOCAL on a keyed join causes Roxie to misbehave

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Fix gh-2933 - Ensure pid files are removed on reboot

Thor creates some additional pid files in it's instance directory.
If the node is cold booted, these pid files persist and are checked on the next Thor startup, by that time the pids could belond to other processes, in which case Thor can deadlock waiting for an old pid to exit, or in the case of slaves, could kill a random hpcc process believing it was a thorslave.

Ensure pid files are written to /var/run, which is cleared on reboot

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Fix gh-3063 - possible crash in esp

A subscriber object that was being link counted by the subscription mechasnism was being destroyed on the stack, consequently a notification could, depending on timing, lead to late invalid access to the destoyed subscriber object.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Fix schemas not matching results when using xpaths

Causes missing column values in display of results.

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
Incorporate changes based on feedback
 - Common up and refactor code for Hardware and Software copy
 - Refactor iterator syntax
 - Remove unused variable
 - Remove extraneous code

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Minor optimization based on feedback.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Add result_lib.xslt support for displaying attributes

Signed-off-by: Anthony Fishbeck <Anthony.Fishbeck@lexisnexis.com>
gh-3054 Fix incorrect 'Cluster Stopped' display for hThor and Roxie

In 3.8.0, Roxie and hThor clusters walways displayed 'Cluster stopped'
on the main activities page, even though the clusters were in fact running
properly.

This patch fixes that, and also ensures that workunits being run on
roxie via queue are displayed on the activities page.

Fixes gh-3054.
Fixes gh-2017.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3072 from jakesmith/gh-2933

Fix gh-2933 - Ensure pid files are removed on reboot

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Changes based on feedback and improved error message.
  - Error message alerts only when there is an issue.
  - More verbose error message.

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Fix gh-3024 Allow set permissions for repository root

When examining repository module type, code was referencing incorrect
resource name variable, resulting in "repository." being prepended to the
resource name (so "repository" because "repository.repository". Corrected
code to look at namebuf.str and tested on Windows and Ubuntu. The 0
return code will be address in gh-3023

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
Merge pull request #3033 from garonsky/issue-2659_copy_and_paste

Fix gh-2649 Configmgr- copy and paste

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3080 from RussWhitehead/ldapPerms

Fix gh-3024 Allow set permissions for repository root

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
FIX gh-3023 Fix error calling MakeAbsoluteSD

MakeAbsoluteSD is a Win32 API, and when it fails, a call to GetLastError
retrieves the error code. However in Linux it is a method call implemented
in permissions.cpp, and in that implemenation it does not "SetLastError"
(a Win32 call).

In this bug, the call to MakeAbsoluteSD failed, and the error message was
built up from a call to GetLastError, which returns 0 since nothing was
set. This fix adds debug logging to the Linux implementation of that call,
and does not call GetLastError unless its a Win32 build

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
Fix gh-2788 - rogue error following disk full

A disk full condition, caused the compress writer to throw a spurious follow
on error, as disk write tried to close the input in the exception handling

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #3084 from jakesmith/gh-2788

Fix gh-2788 - rogue error following disk full

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3077 from richardkchapman/server-status-gh3054

gh-3054 Fix incorrect 'Cluster Stopped' display for hThor and Roxie

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>