labofsahil/github-event-dataset-2012 huggingface dataset:
You would get such results on a non-transactional database or a database in memory. Maybe on a very fast solid state drive.

For a 4200 rpm laptop drive with a 12 ms access time, each of the 35 transactions will take about 12 ms, which comes out to 0.42 seconds per test case. At 135 test cases this comes out to 56 seconds for the entire test suite. Continued in follow-up comment.
Should definately be `$request->is_set_post()`.
we still need to check for err here so that we aren't trying to parse a bunch of data that doesn't exist which will result in generating a bunch of secondary errors.
The maximum length of those three ints is something around 80 chars on 64 bit. I think it is OK as the buffer is 256.
Ma intereseaza si textul afisat inainte de fiecare camp.
A precision of `0` would fail. Could you please add according tests?

You just want to check for "undefined" and "null". Use this instead: 

```
// checks for undefined and null
if (precision != null) {
```
I think empty params are left out to "optimize" the URL -- so that it's as short as possible.
This syntax is not available in Python 2.6, so we need `self.assertRaises(gevent.Timeout, b.recv)`

Also, lets extend the timeout for `g` to a more comfortable distance (say, 0.5).  We can get false failures when running tests on slow VMs if our times are too short.
One loop nest is removed. It was there before anyway, if you feel like it's useless, I'm open to discuss its removal.
might need a dos2unix
style: NIT no need for space here
Both messages updated with ajgent's review.
trivial: error message doesn't match if constraint (if allows 0; message does not).
s/riak_kv_pb_object/riak_kv_pb_index
Yes, the setter is used in InstallTest and the getter only in Install
Érdemesebb valami általánosabb URLt választani ahol később másik beállítások is lehetnek.
I think you should open an issue on whether the swt/things should be modules or classes.
No, that's about how I assessed it too. I'd like to keep it explicit in the backends for now - once the Oracle one is ported over and written it might be the case that we switch it to a feature flag, but that's not too hard to do.
Thanks for the tip. The bash scripting I do has to be compatible with older bash versions so I don't know all the cool tricks!
One line is missing here:  ``rnd.seed(seed)``
s/two counters are dicts/two counters are in a dict/
Reverted to the lambda format, and changed to use ':' (which is indeed the source of the hlint warning).

That said, I disagree about the point-free, as the reduction step is only necessary if you're used to reading lambdas more than reading point-free style.

In my own code I generally use point-free more than lambdas, so for me the necessary reduction step is the other way around...
"Overload has *fewer* parameters than declaration". It'd also be nice if the error message mentioned the exact numbers involved.
I also updated these for loops to use one forEach instead which IMO is cleaner.
This needs to be wrapped in gettext.
That's one of the things I fixed which got lost in a commit blizzard.
Oh, how I hate those "? ?" right after each other. Yes, it's more compact. 

```ruby
if as_framework?
  return prefix+"Frameworks/Python.framework/Versions/2.7/lib"
else
  return lib
end  
```

that should be clearer and the comments are redundant, now that I look at them.
Use a list:

```rb
system "make", "prefix=#{prefix}", "compdir=#{prefix}", "install"
```
Don't need to use a heredoc for a single line (i.e. just use a quoted string).
Should change the formula option to `--without-ossp-uuid` for consistency. The option also needs to be added to the `def options` block.
I'm a bit confused about why this is needed now. Was it always missing?
On OS X, that's done by resetting `current_pos = self.get_slider_pos()` and using the variable.  That avoids calling `get_slider_pos()` twice in some of the cases.
The last argument is "options" from handlebars and we don't want to populate this
Was ist, wenn ich einen Status im 200er möchte, werfe ich dann auch eine Exception? Wäre es nicht besser, diese Methode public zu lassen, um auch ohne Abbruch den Status ändern zu können?
But it's not.  It's an unmodifiable set.  We're not using Guava and ImmutableSet. :p
It had better not.  I hope many provides methods can be listed this way, so they're one-liners and really easy to consume.
Yeah I think so. Wow, that's good I guess.
Now that one can specify a `TimeUnit`, I think `millisecond` would be a clearer parameter name. What do you think?
I believe you, I'll change it. Do you have a reference for this thought I want to know why.
Once again, I find `recordOrPrototype` to be a much more descriptive identifier. I would have no idea what `subject` means coming into this cold.
No—the source should be unique per source. I'd propose 'main' as the convention for the primary tour, but in principle other tours could be imported, and certainly multiple feeds will be imported. Each one will need a unique "source" name.
Actually, JSLint won't let me do that :) So I need to assign it to something anyway.
yeah, I think I'd like to postpone this
Set here as well.
其他的 center, right 亦同
Is it case sensitive or insensitive? You could extend and use our own.
No, you should do all `li` inside of `li.form_field` inline. :-)
spacing inside bracket.
preload=auto
Spacing around `{`.
No need for the extra space here.
Looks like this is also not being used. Why is it here?
I was able to get this working without modification on my laptop, so the problem is clearly something on this iMac.
that's a extended glob feature I use a bit too much.
Ah looks like it was missing before? Thanks for that!
There will be no problem in the next few days
interesting fact: without this check a few pixels in my test image got 35ff00 instead of 36ff00. floats!
In fact the code that uses the `mimeTypes` method is  

```
  def result[Obj](code: Int, writer: BlockingWriter[Obj,_])(obj: Obj) = {
    SimpleResult(
      header = ResponseHeader(200, Map("Content-Type" -> writer.syntax.mimeTypes.head.mime)),  //todo
      body = toEnum(writer)(obj)
    )
  }
```

It would be good to have in Syntax a method `official`, `default`, `ietf`, ...  that fetches the default mime type 

so that one could write 
`writer.syntax.mimeTypes.official` 
instead of 
`writer.syntax.mimeTypes.head.mime`
Can you add some documentation stating what each Path means..
i was wondering may be we should have SourcePath and DestinationPath classes abtracting out this..but we can do that later...just some docum around this would be helpful...
Actually, this has no `catch`, so catching just the correct exception would also be good.
Also this. Can you put these in a separate pull request please? These are obviously right independent of the rest of this pull request.
Scoped the idx variable to the for loop:

for (var idx=noticeArray.length-1; idx>=0; idx-=1) {
...
}
The `i` switch isn't needed.
``$record['context']['type']`` ? What's this ?
Use IDs for your input tags
You can still use lazyproperty in this case, rather than `__getattr__`.  You can see how I do that here: https://github.com/astropy/astropy/pull/237/files#L2R109

The metaclass loops over all the available time format conversions and creates a new property for them when instantiating the class.  In fairness, is this a little black-magic and not necessarily the easiest code to understand.

Though to do this with `__getattr__` your idea is fine too, though I would just make the cache a "private" variable :)
Do you need this sub-section header?
I'll wait to see if others prefer `pattern` or `wildcard`.
No, that and mapFiles[] could be moved into CDBEnv as well.
There's ton of places where the signal argument is not used, also in Qt itself, no need to be sad about it :)
Indeed the fieldList is a whitelist. I too think it should be a protected method.
No. ``Before`` and ``After`` don't establish requirement relationships, as per the manpage on ``systemd.unit(5)``:
> Configures ordering dependencies between units. If a unit foo.service contains a setting ``Before=bar.service`` and both units are being started, bar.service's start-up is delayed until foo.service is started up. Note that this setting is independent of and orthogonal to the requirement dependencies as configured by ``Requires=``.

We want cjdns to be started when network.target is set as reached though, so we have to implement a relationship using ``WantedBy`` (same source as above):
> Installs a symlink in the .wants/ resp.  .requires/ subdirectory for a unit. This has the effect that when the listed unit name is activated the unit listing it is activated too.
I don't know of any, are you talking about malicious content in the Gravatar profile return? The only parameter (Hash) is generated by JabbR and not user input.
The only one I wouldn't be 100% on is the returned value from the Name portion of the response as that could be set by the user.
Well, that's a bit unfortunate but that would require an additional parameter for finding the underscored roots like UniversalClassLoader has registerNamespace and registerPrefix. Can this be a followup?
remove the archived_at thingy ma bob.
On 7/11/12 1:52 PM, Jesse Reynolds wrote:

> Except that I'm setting ack_str as well in one of the cases

that's already set to the empty string under those conditions by the 
clause above.
I would drop this all together
Any reason to use a String[] here instead of a List<String>?
howard, instead of having a JGroupsBroadcastEndpoint that does 2 things, i.e use a file and use a channel you should abstract this stuff out
either have a JGroupsBroadcastEndpoint and an AS7JGroupsBroadcastEndpoint (then using reflection would make sense) or abstract the part that creates the channel, something like
AS7ChannelFactory.createChannel and ChannelFactory.createChannel and use the interface for these in JGroupsBroadcastEndpoint.
OK, I buy that argument, can we change the rest of them to this format then?

On Thu, May 31, 2012 at 8:18 PM, Min RK
<reply@reply.github.com>
wrote:
>> @@ -86,6 +86,15 @@
>
> I'd rather not, I think forcing lower-case and no spaces on what are essentially GUI documents is terribly ugly.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1822/files#r912781



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
oups sorry , read to fast never mind
Yes, thanks. It fixes the issue. I pushed the patch.
This check depended on fixConsole stripping `\r`.  You will have to make a different fix that prevents creation of the HTML element if there is no text to display.
Store return value of Logger.getAnonymousLogger() in a field?
ListenableFuture Optional Map String, String
strange, can't find that one only transform entries and values. anyway it would still be expensive.
Wouldn't "break;" be clearer than "finished=true;continue;" ?
I wish. Delegate insertion sadly isn't possible with these methods in the same way that [NIRadioGroup](http://latest.docs.nimbuskit.info/NIRadioGroup.html) and [NITableViewActions](http://latest.docs.nimbuskit.info/NITableViewActions.html) work.
:WARN: this test still fails! I want to investigate BYSETPOS more, but maybe its time to split this PR into two as its nearing 2k lines.
Think you need to be checking the error return value here and on the next couple lines.
Did you meant to update vendor here?
This `append` parameter is similarly orphaned, now that we aren't showing the welcome page on firstrun. We should remove it too!
Same here, I don't think this is actually Swedish. Please look through and change and translate lines, as its really important you dont just delete them :)
This is how nodejs's http.request() works. It passes an http.Agent instance to the Request. ConnectionManager is nodejs's http.Agent.

Also, if keep-alived is implemented the Request may have to give the connection back to the ConnectionManager once it has finished with it, so Request would need the ConnectionManager.
if you are using it this way, you cannot accept an array for the question (whereas you document you do).
Thus, it is not consistent with other methods of the helper as they are not coloring the question themselves.
I agree that this interface probably isn't the best place, but I didn't want to add a `FormTypeResolverInterface` just for that simple purpose. It definitely doesn't belong into `addType`, since adding and getting should be synchronous. If you add `A`, you want to get back `A`, not `B`.
If you remove the test using the fixture, you should also remove the fixture file
This need to be reverted.
Wouldn't it require to deep clone all properties, as you can still modify the objects by reference? So it's not really made sure that all properties are immutable.
no need for elseif, previous statement returns
Wrapping titles in a paragraph ? seriously ?
it was just to make sur test pass
indeed, even better
why this ? There is nothing requiring the event dispatcher here AFAIK
missing `$this->lazy[$option] = false;` here ? to avoid resolving concret options (when they overload a lazy one) ?
What is the second parameter for?
{{{}}}} == unescaped HTML
Can't see where `owner_name` is used in this test.
这些嘛，细节问题~随便改~
For rus translations, the file contain french and not russian translations.
For the move, I will change that by noon tomorrow.
Same deal, try to get this OS-detection into a function if you can.
If we want to guard against people who don't wait for callbacks to complete, then we have other problems. For example, people might read variants before they are loaded.

The reason the code is written the way it is is that the current implementation relies heavily on a global. We can either switch the global out, or we can pass in a registry object with every call.

Passing in a registry is obviously architecturally more pure, but it means that we would have to change all callers

```
variants.loadFile(registry1, 'one.json', function () {})
...
variants.getFlagValue(registry1, 'can_see_homepage')
```

I figured that a call to switch out the global would be the easiest way to get the functionality we want given where we started from, although I agree that it does leave these kinds of potential pitfalls.

What do you think? Does the strategy of switching out the global seem ok to you?
Метод `getArch()` нужно переименовать в более подходящее, потому что он же не возвращает объект `arch`, а модифицирует его.
Так же назовёт методы во всех классах `Node`, которые модифицируют правила сборки.
how about:
    while((p = strchr(p, ',')) != NULL) {
        num_pubsubs++;
    }

I've used syntax like `*p++` in the past, but in this case you also have `while (*p)` so it looks a bit too clever
The order of these comparisons looks weird. It's not something you have to change, but I thought I would point it out.
`decorator`
This JS hacks don't work if you for example only specify the search parameter. Better do proper query string parsing: an [example](http://paulgueller.com/2011/04/26/parse-the-querystring-with-jquery/)
This is very similar to Item_Model::scale_dimensions in that it's preserving the aspect ratio - can we combine the two?  I hate having functions like this in a template, we should pull it out into a common helper.
Change "And" to "When".
Since you're using jQuery's `.attr()` method everywhere else, why not here?
`span.attr('class', 'img_expanded');`
before after saving all the items on the screen, we were seing edit views. this is an attempt to turn all views readonly after saving the dashboard. let me know if this doesnt work on your dashboards. (ie if after clicking the navbar's save, you still see edit views)
I don't really like this, but at the same time I don't really see a better solution. 

The only other thing I can thing of is have a reserved "jboss.invocation.context" key, and the client interceptor puts a map with the context data into the private data map under this key (so basically the invocation context data is added as an attachment). WDYT?
I guess this one should be obsolete?
Here is where you choose if you order by DESC priority or ASC.
return $a['priority']<$b['priority'] ? -1 : 1; => ASC
return $a['priority']>$b['priority'] ? -1 : 1; => DESC
we should use parameter for the strings, covering all the possible cases from none to plural:
'''pinAttemptMsg         = {[ plural(n) ]}
pinAttemptMsg[zero]   = No tries left
pinAttemptMsg[one]    = {{n}} try left
pinAttemptMsg[two]    = {{n}} tries left
pinAttemptMsg[few]    = {{n}} tries left
pinAttemptMsg[many]   = {{n}} tries left
pinAttemptMsg[other]  = {{n}} tries left
'''
You may want to remove this event listener when the screen is turned off and add it back when the screen is turned on.
because it makes the next line span two lines, but done.
Let's actually hook-up the save functionality before landing this patch.

As you can see in the mailapi at https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/data/lib/mailapi/mailapi.js#L81 we have a modifyAccount method on the account.  Although it's missing a lot of functionality, it does provide password-changing right now.

So the call would look like:
```
  account.modifyAccount({password: newpass});
```

We should take care to ensure that we only change the password if the user actually enters a new password.
That’s my only nit: why do we need a specific rule for this item? I have to ask, as we’re trying to improve the UI consistency in the Settings app…
nit: transform is unprefixed
Negative dates hurt my brain. But if you want to do it this way, we don't need to run getMidnight on the output on the next line because it will already be midnight.
classlist?
this should be removed, the policy is to keep the logcat as clean as possible
So the new transition is to transit the `iframe` itself?
Do we really need this `goog.require`, looks like it's only used for the demo.html
line probably too long break it up on newlines?
Does this break backwards compatibility with MK? Is there specific version we need due to this change?
This may well be me not understanding the model states correctly... 

I guess I need to add these 2 states (repo_install_ok & yum_install_ok) to lib/project_razor/model/redhat.rb so that they are understood...
SG: "Use imports for packages and modules only."
Unfortunately, because of erasure, the first branch won't work (it can't know the type of what's inside `Some`. You could rewrite it to `case Some(b: Block)`, similar to what you suggested on the other branch.
Do we need all these imports. #6
add 'return' and get rid of the else
Get rid of the extra newline.
Catch `Exception` as a last resort. Instead, catch whatever the specific exception is that can be thrown here and do the following.
I wonder if we should skip the search and just check the last row. If it doesn't appear as the last, then that could be an issue.
We should be using the official Freeseer Headers. Please copy it from any of the other code files.
Rather than separating and using multiple button records in one dictionary ID, make a new Button class (or something similar) like Shape or Sprite that has records and condactions as properties.

Then in SWFCrew in PlaceObject it can just read them the same way as Shape and Sprite.
you downgraded evernote sdk :)
... or null if wholeBlockUpdate
why not just `setText(new ChatArguments(arguments));` ?
you mean no space before method params?
I believe the extra `:` is optional (see http://buildbot.net/buildbot/docs/latest/manual/cfg-global.html#database-specification)
it's not really a method anymore :)
agreed - `.get` is far more readable
+ or
@minggo Declaring s_SharedDirector static here is file-scoped.  Don't you want to put it static in the header file's class definition instead?  Then it would be a Class Variable, not an instance variable, and not file-scoped.

The comment on line 73 refers to the case where it's not static, but an instance variable.

很抱歉，这是更容易观察。
don't bother about using ``DIRECTORY_SEPARATOR`` everywhere. It is useless in PHP 5.3 as it accepts ``/`` even on Windows.

The only case where it is important is when you need to do some string manipulation with the path
this should be on the previous line, and spaces are missing after ``if`` and before the opening curly brace
I just found this too: https://groups.google.com/forum/?fromgroups=#!topic/clojure/LF3au6OZehM

Thoughts?
Also, please check source alignment with tabs/spaces here too, the code review tool makes this look bad
すみませんでした。再度追加しましたのでご確認ください。
Please make any method in a controller that is not an action private.
We need to figure out how to do sub-repositories, so that this actually just checks out the updated ck code.  We don't want to have to keep ck up-to-date manually.
I'm not sure why this isn't needed anymore?  if it isn't, then remove it, don't comment this out.
We definately want the Compressed back in here
other keywords that support ranges (like urilen) us <> for a range, can we use that here as well?
yes, this will protect the code.
If it defaults to @fields, then it behaves the same as now, but it's behavior is more understandable?
While technically this is correct, it will break for people which have made customisations. I would prefer to keep this unchanged, perhaps use 

* $g_calendar_js_date_format_short
* $g_calendar_js_date_format_long
nit: I prefer reading function definition before following usages.
Maybe factor out to reuse.
that, sir.  is one PILE of css changes.  I'm going to review these by testing on different devices to ensure usability first, and beauty second.
I can't repro the test failures. What's the exact command-line incantation you're using?
Yeah that would be clearer, will do.
How is it handled? Do you have some docs?
Same as for the circular buffer, can we use some general variable names please for easier porting?
I don't talk about a neat markup but a more flexible way to show off tooltips for certain elements.
I don't really know, and I doesn't care about it really. ;)
Because it was grabbed from `comm-central` as I above said, I simply trust in this piece of code. :)
I've just realised that this will actually break as soon as a Show and Tell event is thrown into the mix. Need to investigate a different way of changing the first-level slug to Birmingham, Leamington or ShowAndTell depending on some other factor.
Can we also remove inf? Would it have raised the deprecation warning before? It seems to also represent a number but I suspect might have missed the warning.
>= ?
Guess it would be however often Hummingbird polls, once a minute?
@weierophinney I was working on the commits you see at the beginning of this pr and I was thinking about how we managed to throw out Di completely and make it so difficult to get back to it again :)
That is just a joke, but really, currently, you can only get `DiAbstractFactory` only once the controller couldn't be fetched from the controller factory.
That happens at https://github.com/zendframework/zf2/blob/master/library/Zend/Mvc/Service/ControllerLoaderFactory.php#L80
So I was trying to make a `DiLazyAbstractFactory` that initializes `Zend\Di\Di` only when it is really needed. That way, we would have back our `Di` functionality without loosing performance. The problem is that both methods of the interface it should implement (`AbstractFactoryInterface`) must pass in the service locator, otherwise it is impossible for me to build something like following:

```php
<?php

class DiLazyAbstractFactory implements AbstractFactoryInterface 
{
    protected $di;

    protected function initialize(ServiceLocatorInterface $serviceLocator)
    {
        if (null !== $this->di) {
            return;
        }
        
        $this->di = $serviceLocator->get('Di');
    }

    public function canCreateServiceWithName($name)
    {
        // won't work, can't have Di here
    }

    public function createServiceWithName(ServiceLocatorInterface $serviceLocator, $name)
    {
        $this->initialize($serviceLocator);
        return $this->di->get($name);
    }
}
I'll update the tests for this shortly.
CS (whitespace)
Missing namespace declaration for exception.
Move the work into the method body, not the conditional. As an example:
```php
if (!$this->buffering) {
    $this->writer->write($event);
    return;
}
// do rest of work here.
```
why running the testsuite with a different set of deps than the one you will deploy ?
no $row variable set at this point, above 2 lines will result in notice warnings
This was inspired by the config of Adaptable. Would like to hear what your concerns are, eg seperate set & get?
We came to the conclusion that embedding consume() into batch() makes a lot of sense, also for error collecting.
-> `filterFnc: function ( item ) {`

Space around argument and after `:`
Not an important remark but we don't need to make TODOs that concern other branches. Merging branches correctly is an impicit, always true, work to do :)
@samiluukkonen Tässä voi olla wheressä tila ja alatila niin ei pääse vahingossa päivittämään vääriä tilauksia. Jos vaik antaa getissä jonku ihan random arvon $tunnus-muuttujalle
@yrashk i particularly prefer, in most of the cases, to write the function declaration, since we also write the argument names. But nothing against delegation. Both are correct.
How does legacy kernel do this?
If not dealt with now, add a todo to optimize this in the future.
use `Popcorn.foreach` plz:D
if you want to be 100% certain then change this to:
SQLPREP("SELECT `value` FROM `%1config` WHERE `server_id` = ? AND `key` = LOWER(?)");

should work on mysql and sqlite
I don't know a sensible way to set the PYTHONPATH in a merged rule
for nosetest3 this problem (currently) does not exist, you can call nosetest with python3 and get the same thing
I don't think we want to set the height and width properties?
The current mixin forces the elements height and width, which may be different from the image-dimensions and background-size.

A user might want to do:
```scss
background-image: url(...);
background-repeat: no-repeat;
background-size: 60px 50px;
height: 300px;
width: 300px;
````
Sorry, that should go in the `class Meta:`
Yes. Maybe `_removeChild` and `_addChild` should be public?
Would you like to mention Perl there? Or even the module name?
Minor design idea: The answer box seems a little cluttered. Perhaps it would look a little better if the text boxes were not as long. Perhaps we could try adding something like this to the top to see if it looks a little cleaner?

    <style type="text/css">
        #answer_area input[type=text] {
            width: 40px;
        }
    </style>
echo???
@jeremyworboys Probably right! But it's kinda irrelevant anyway as that line won't do it's job properly as I said in https://github.com/daneden/Baseline.js/pull/1#issuecomment-6455619
Here I'd think that a constructor `NodeMapping(outputPaths, siblingPaths, recDefNode)` would make sense, unless those things aren't needed to be provided together.
I think `getStringTypePrefix` is enough. As the length is the only parameter, it reads "get string type prefix from / according to length".

@gnugat What do you mean when you assume that `$length` can be null ? If the fonction is meant to be called without the parameter, you should add  `= null` to the prototype.

On top of that, why do you enter the loop and only then test if `$length` is not null ? You should just bypass the loop in this case, as your test does line 81.

Finally, why do you return 'LONG' by default ?
I don't like this at all.
See 3a58055
Ah gotcha. I'm pretty sure that's iff but I was more curious about iif. Prolly doesn't really matter

Sent from my iPhone

On Jun 1, 2012, at 21:13, Jordan West<reply@reply.github.com> wrote:

>> @@ -37,12 +37,12 @@ class RouteSpecs extends Specification with ScalaCheck { def is =
>>     "Routes with data parts"                                                        ^
>>       "if the route does not end in a star term"                                    ^
>>         "if the route contains string terms"                                        ^
>> -          "path matches iif each token that has corresponding string part matches"  ! MixedRoutesNoStar.testMatchesIIFStringPartsMatch ^
>> -          "path does not match if >= one token does not match corresponding string" ! MixedRoutesNoStar.testStringPartDoesntMatch ^
>> -          "path does not match if it has less tokens than route parts"              ! MixedRoutesNoStar.testLessTokensThanParts ^
>> -          "path does not match if has more tokens than route parts"                 ! MixedRoutesNoStar.testMoreTokensThanParts ^
>> -          "path data always has as empty dispatch path string"                      ! MixedRoutesNoStar.testDispPathAlwaysEmpty ^
>> -          "path data always has an empty path tokens Seq"                           ! MixedRoutesNoStar.testPathTokensAlwaysEmpty ^p^
>> +          "path matches iif each token that has corresponding string part matches"  ! MixedPathNoStar.testMatchesIIFStringPartsMatch ^
> 
> if and only if? however that may have honestly been a typo
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jrwest/scalamachine/pull/3/files#r918793
Now we're discussing two separate issues.

First, we can eliminate the use of singletons by doing something like the following:

 module ConfigFoo
   @@parsed = false
 
   def self.init
     @@parsed = true
     puts "Parse, parse, parse... Done parsing!"
   end
 
   def self.get(var)
     init unless @@parsed
     "<value of #{var} in foo conf>"
   end
 end

Second, rather than defining ConfigFoo, ConfigBar, ConfigBaz, and so on, one module for each conf file, we can centralise everything into a single module:

 module Config
   @@parsed = {}
 
   def self.init(conf)
     @@parsed[conf] = true
     puts "Parse, parse, parse... Done parsing #{conf}!"
   end
 
   def self.get(var, conf='main')
     init conf unless @@parsed[conf]
     "<value of #{var} in foo #{conf}>"
   end
 end

Having written the example code above, I am more inclined to go with the central-Config module approach.  Does the example I just gave look to you like a good approach?
Should we default these to a value as they are not required in the rest endpoint?
In real scenarios this wouldn't be a problem. But down the road we should avoid caching in the domains themselves.

Down the road, with a proper plugin system, we would likely have a `ctx.clear()` method that is similar to Hibernate's `Session.clear`. The context could emit a 'clear' event.

Then your plugin would have:

```javascript
ctx.on('clear', function() {
  delete _isGlobalAdmin;
  delete _isTenantAdmin;
}
```

Certainly out of scope for this. Just an aside, really.
It looks like you can just do `module.exports = {...}`. This would avoid us having to specify the .config every time.
I renamed it to oae-config and changed all require statements.
I agree that it's spiraling a bit out of it's original intent.
FWIW, all the non-standard fields will always be set at `user.extra`. When retrieving a user (from Cassandra) all "core" properties (things like locale, visibility, timezone, ..) will be placed on the `user` object. Anything that we don't recognize gets placed at `user.extra`. It's just a matter of storing those properties that's becoming a bit annoying.

The `updateUser` functionality allows for storing whatever a developer wishes (which is something we should probably tighten up a little bit as I *think* a user can change his tenant by simply posting tenant=foobar to /api/user/<foo>, or post a ridiculous huge string that would block an appserver for a second or ..).
Maybe we should store "core" data as we're doing now and anything we don't recognize we run it trough a filter and store them in `extra_<name>` columns?
I believe this could potentially be accesed by different threads (``initialize/vmStarted/vmTerminated``). It may be a good idea to declare it volatile to prevent visibility issues.
Postgres or PostgreSQL, please. Postgre looks weird, and I've never seen it used as such.
А можете сказать, зачем здесь `@autoreleasepool`?
Yep, `packet` is better for that case.
Add the mysql dependancy for cmyth MythTV add-on
For consistency, should be "Diamond protocol".
Instead of a try/catch here, why not disable the editing functions when the view model states that the selected document is not editing? 

ie: Bind the IsEnabled property of the controls to SelectedDocument.IsEditing
Sorry to ask for one more thing, but a test will ensure I don't accidentally break it or remove the functionality in the future. Thanks!
Perfect.

Just a note: I've already added this method [inside platform](https://github.com/gpongelli/joomla-platform/blob/dbNewMethods/libraries/joomla/database/driver/postgresql.php#L798), as you can see I haven't used reference for **$columns** and I've to change it,  I've handled *boolean* differently, I've added _timestamp without time zone_ type and [doing its test](https://github.com/gpongelli/joomla-platform/blob/dbNewMethods/tests/suites/database/driver/postgresql/JDatabasePostgresqlTest.php#L1151) I've seen that _numeric_ needs to be different, including a comma in its **$field_name** value, it's not handled otherwise.

So some suggestion to improve this method: 
1. make this method protected because no one externally have to call this.
2. try to use my changes about types (*numeric*, *boolean*, *timestamp without time zone*)
3. test if cms works with these changes, so I can merge this branch and change this method inside platform


Really thank you ;) !
In the nodeForPartition method in DefaultLoadBalancerHelper.scala, it checks whether the endpoint can serve request and is capable then, it sets the states information. Isn't it required in this code?

-- From line 93 of DefaultLoadBalalncerHelper.scala
          if(endpoint.canServeRequests && endpoint.node.isCapableOf(capability))
            if (states(i % es).compareAndSet(true, false))
              return Some(endpoint.node)
            else if ((i - idx) >= es)
              states(i % es).compareAndSet(false, true)
--
I don’t know what you are doing, for me the URL returned by `metashare.repository.models.resourceInfoType_model.get_absolute_url` does not have the `http://` prefix (as expected).

Regarding the link you mentioned: I do not doubt this at all; I just assume that the Django `sitemap` app takes care of creating a full URL from the one returned by `location()`. That would at least explain why they say [it was “Bad” to have an `http://` prefix returned from `location()`](https://docs.djangoproject.com/en/1.3/ref/contrib/sitemaps/#django.contrib.sitemaps.Sitemap.location).
```evoked : instance of Evoked or list of Evoked
    The evoked datasets```

this docstring is very old before Evoked class appeared.
Dropped or kept?
Maybe None is the most sensible option and we should support only this.
can it really be an array? you can to block multiple bands in one pass?

will it work with method='fft' below?
It was faster to just delete it and see compilation errors which needed fixes. From the dev list thread it is ok to delete.
just change here exports.salsita to exports.internal ? Right ?
This would fail with a: NameError: name 'wrap_socket' is not defined
Perhaps 'Global' is a better word. Discard 'options'.
Should be:

    ```</body>``
“漏桶”的方法，固定
“漏桶”的方法——固定
速率的单位是请求每秒（r/s）。如果请求的速率不到每秒一次，就需要使用请求每分钟（r/m）的单位。
I think these three methods could be avoided by using `File.dirname(__FILE__)`
If it's for testing, can we keep it in src/test ? Or at least put "test" in its name and use a URI scheme like "filetest://" instead of "file://"?
Just a naming convention, I prefer 'virtual path' to 'fake path'.
workfows from dmri don't follow this pattern
Changing the semantic role of a parameter based on object identity is IMHO a bit too magical here. I'd prefer to use `jac=True` or `jac="combined"` or some other non-callable special value to signal the changed behavior.

I wonder if one should be careful with the comparisons, as the object `jac` passed in may in principle implement a `__eq__` method. Seems rare, though, but if yes, for a string, `isinstance(jac, string) and jac == "combined"`, and for boolean, `not callable(jac) and bool(jac)` could do it.
Here, and in other places in Scipy, it would be nice to used named tuples (although we need to bundle the implemetation in `scipy.lib`, as we want to support Pythons < 2.6). However, this can be changed also after this is merged.
Я бы не писал вообще Show ... button. Вместо этого групбокс с именем `User actions`, и в нем чекбоксы `Private Message`, `Block user`, etc. Аналогично для `Psto actions`.
А оно само не обновляется шоле? Вот говно!
.clearfix 應該和 pics-group-spot 同層 (因為 pics-group-spot float)
Newing up the instance should also be inside the `try` block. In `finally` then, you'd check to see if the stream is `null` before closing it.
Why use "let" here?  The following is equivalent:

(-> results :columns first :to_display :content)
remove or uncomment?
If @aradabaugh is game for making the improvements, that'll be faster than waiting for me, and probably better implemented to boot.

One note: I had copied the format and conventions exactly from CGPathAddLines, in the hopes that it would be up to the project's standard.  Any improvements needed here are probably needed in that other function too.

Thanks for moving forward with this pull request!
This should not be removed, but changed to group
The workflow I am thinking is: make build-nova-gridcentric. Modify some code. make build-nova-gridcentric. Ideally we would want the tests to run both times, not just the first.
This text implies the option is only relevant when a cluster is in place, so why not make it a configuration of clustering configuration rather than locking configuration? The configuration name gives no clues either.

Also, how realistic is this configuration option? We already have a gazillion amount of configuration options and I think we should be more conservative adding more config options.
Dan asked the same question. I discarded that approach on the basis that we can not as easily rely on CH to find appropriate intermediate keys - the results of map phase. If you recall map phase outputs intermediate keys which are CH hashed and stored on the cluster in tmp cache. Then reduce phase easily picks them up for reduction. Clean and simple!
Ok, let's leave it as it is. I was just asking because I wouldn't want some of the code checking hotRodWrapping and other parts using rawValues for the same purpose.
The original formatting was much nicer! We use indentation in this style on purpose to make sure it's clear at which configuration level you are.
Please revert this formatting changes as well.
Yeah seems there is a bit of confusion in the libgit2 naming. Been discussing it in the library room with @arrbee this morning.
It will go into this but on line 17 `"%(run_name)s"`
Да, есть. Но сюда можно передавать не только Closure но и подобные вещи: array($myClass, 'publicFunction')
Собственно все с чем работает call_user_func_array и что, видимо, начиная с 5.4 называется [collable](http://ru.php.net/manual/ru/language.types.callable.php)
We're using callback({'code': .. in the jquery callback error handlers, should we be using these here as well?
Do you think it would be worth versioning this bundle as 1.0.7.Nakamura or 1.0.7.20120618 to avoid conflicts if Sling releases a 1.0.7?
I hope to eventually encapsulate the mode selection code under here, so all the user need to do is execute this
function for hyperparameter learning.
s/Ruby and Rails and more/Ruby, Rails, and more/
Good point. Not sure which one to leave in. The original code was copyright Silverstripe and the BSD license requires I keep both copyright notice and license text. But its now heavily modified.

Regarding @package tags - we probably shouldn't have a URL in those at all - but use @link instead.
Also @subpackage is now deprecated (http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/subpackage.html)
Both of those our out of scope for this anyway - I'll add a ticket to track that
Hidden field to pass in the id
Maybe this would make more sense as "cache_file_open", "files open in the cache", without mention of btree or LSM?
Fair enough -- I don't think we take snapshots of the stats in other cases either.
Are you sure that you can access the property "TYPES" as it is declared private in class "JMS\SerializerBundle\Metadata\LinkMetadata"?
Maybe just right in the arguments list there:

* relationship - `{id: <relationship id>, properties: <new properties object>}` - Old properties are fully replaced by the new properties.  I.e. existing properties not defined in the new object are removed.
@hhamon keeping ``localized`` in the name is a good idea IMO. Twig already has filters to format date and numbers in the core. The difference here is that these filters are using intl
One does not simply `count` an infinite sequence. Use `empty?`.
See the other note, this is gone but it's not rendering in the pr for some reason.
Can you remove the blank line? We don't usually put a blank before closing }
This line is uncommented in WL-2354 which is the next task.
it has to be done from the test folder no ?
/tmp wont work on windows? I would suggest to figure out the tmp dir in a different way?
No need for space in `<a />`.
Space after `(`.
This is probably not needed? You have `<div id="content">` around from `plain.html`.

Don't forget to indent.
It's not a problem in that. I tried adding msgstr[3] and it doesn't help. But if I add msgstr[435] (if the value is 435) then it works.
Ehm, `panel.get_layout(columns) or PanelState()` is probably nicer?
`"` for user exposed strings.

*Panel depended on by:* -> *Panel is required by:*
`button` class -> `buttons` class.
Space between.
Probably some fields are required? And have to be unique with others, no?
Account? Not home?
Write out all arguments function in `each` gets. Everywhere.
Ist der username ist hier garantiert getrimmt?
absolutely, fixing now
Correct format with # ... at end of source line
I think you can force it to true in the setNormalizers method :)
The second one looks better, but you tell me if it's possible.

A doubt on the first version: what happens if I create a new entity having 

    "author" : "Guillaume", "title" : "What is a JUG ?"

as Id, and merge the object?
Will it use the same ObjectId and update the existing row, or will it generate a new number for the ObjectId? That would be very wrong.
I did consider rack middleware, couldn't think, as you said, how we would get a user object there.

I didn't consider an after_filter, I prefer that and will see if I can make that work.
add error-handling to log the error in $logger->warn().

Something like (this is the error handling in pf::SNMP::Nortel):

```perl
    # Error handling
    if (!defined($result)) {
        $logger->warn("Asking for port information failed with " . $this->{_sessionRead}->error());
        return;
    }

    if (!defined($result->{"$oid_rcVlanPortType.$ifIndex"})) {
        $logger->error("Returned value doesn't exist!");
        return;
    }

    if ($result->{"$oid_rcVlanPortType.$ifIndex"} eq 'noSuchInstance') {
        $logger->warn("Asking for port information failed with noSuchInstance");
        return;
    }
```

Instead of the above, what you could do is handle the success case first (return result if defined and not 'noSuchInstance') and then do the error handling stuff.
yes, sorry ;)
this should always happen because tcpdf does not come with this bundle
co to tu robi?

czemu backbone-widgets ma wiedziec o price, unit_of_measure, owner itp?
copied Fixtures.java and dome DebugProtoTest.thrift from thrift (retained the licence and added a comment about there this copied from).
This is even better since we would codegen using the current thrift compiler, rather than always using 0.5.0 compiled classes.
Good suggestion, updating.
I was talking to @pquerna about this, and some mail servers will take a payload and interpret the "to" header without using the rcptto command... thoughts on this?
I agree with you on all three points, for me was important only the ability to easily manually find and delete cache records, so I didn't want to use nested directories nor some unreadable hash as a file name.

I think the best solution would be to prefix the file name with some non-cryptographic hash of the file name ("/foo/bar" -> "tsb9oq_foo_bar"), another solution could be using some character that cannot occur in proper URL instead of underscore or I can simply turn every underscore in the URL into two underscores, which would also avoid the problem since multiple slashes are turned into one by path.normalize()
Shouldn't this be `{..., id=ship.shipId}`?
The switch statements here are pretty similar. Maybe you can put think of a way to generalize and put it into its own method (maybe something like `changeSearchMode:direction`)
i found regexp are almost always faster than anything when it comes to strings. maybe with other regexp it will be faster:

```ruby
key.match /\A#{filter}\(\d{1}i\)\z/i
```
Potential implementation, to be discussed
Again, I think this is related to the way the first stage is performed: your aircraft example clearly shows that the best solutions at stage 1 do not generalizes well at stage 2. A larger `n_keep` should not improve the results, otherwise this would mean that the best solution on the whole dataset has a very small link with the best solution at stage 1 and we should therefore question the use of such a two-steps algorithm.
What do you think?
It's not necessary because it inherits from BasicObject
= render '/presentations/new'
Non ?
Hm, those comments were moved a bit around because you updated the pull request while I was commenting.
So those problems were when a `@returns` was followed by other pieces of syntax: DOxygen doesn't seem to like that and wants returns to come last.  When the `@returns` statement is all there is, it looks OK, but it doesn't really mesh with the other DOxygen function layouts so I think I might prefer not using @returns at all and go for what you suggest.  I'll push.
Yes, I was worried about them getting out of sync!  I just pushed a version in which I tried to (a) make a combined version in the PowerSpectrum class description and (b) made all subsequent descriptions of that parameter refer back to the PowerSpectrum class description.  Can you check it out and see what you think?
Why not return a UTC date string? In fact, the date returned here doesn't have any timezone information, nor millisecond information, which is less information than we had before... Also, why introduce all the variable names?
I see:  look at the last one, only pop it when it's successfully handled (end of the loop).  Fine.
It doesn't look like this function ever returns an error object, so you should remove that option from the documentation. If it did, however, you'd use the fully-qualified name of the class: liberated.rpc.error.Error
Would be nice to assert the other fields are being picked up correctly (e.g. they aren't swapped or whatever).
And that average() gives the right result as well.
Apache is usually not running as root, and needs to log nonetheless. What is the idea behind this change?
why so many imports?
This likely has to happen in a privileged block.
might be easier, less null nervous to use Multimap<String, NodeMetadata> vs Map<String,List<NodeMetadata>>
If we don't want this just remove it. Don't commit commented codes.
I would use a subclass for this change too, as the webdav response is simple something different than the normal response object. I also would ignore the fact that the $statusTexts variable is public as i do not like the way manipulating a static variable outside of the object.
This proc is called if the Cleanup() proc (Which is called before the connection is used) determines that the zones of the associated turfs have changed.  It will update the relevant zones properly. (Yes, it is can handle any situation thrown at it!  Both zones change?  It will update all four zones!)
Вот так более читаемо

```javascript
var result = this.coming()
    .filter(function (events) {
        return events.start < now;
    });

return result;
```
Typo in this variable name (and in a few other places as well), it's `deferred` not `deffered`.