labofsahil/github-event-dataset-2012 huggingface dataset:
A docstring would be useful here - the api docs will automatically generate a section for properties, and it will get whatever docstring you put here.
a small doc about what units `?TTL` are in would be good
Should we be expecting to get messages here? Maybe a lager debug msg if do?
move to urls.py
You could have something like

```python
def get_resource(regex, res):
    if (isinstance(res, dict)) and 'resource' in res:
        return res['resource']
    if (isinstance(res, basestring) and regex.match(res):
       return res
    raise ValueError("Cannot find resource id for %s" res)

def get_dataset_id(dataset):
    get_resource(SOURCE_RE, dataset)

# the same for the rest
```

and avoid the cut-and-pasting.  I'm not sure if the format string in the ValueError above is correct, i just made it up.
I've committed the correction. (Seems it's automatically attached to this pull request.)
Ok, will change those to str
This is non-WIN32 code, no?
I'm just asking myself, why not all Thread use ``IMPLEMENT_RANDOMIZE_STACK``? Even if this is unrelated to this pull, what's the reason for that?
For users on the main branch, thats fine.  For users on a stable branch, the stable branch's file can provide information on which versions in that branch are or are not secure.
I wont ever use a goto in C-like languages ^^ ... you would have to force me to do this :D!
I think using _requirePresence sounds odd next to allowEmpty as the tense is different.

```php
$validate = [
  'title' => [
    '_requirePresent' => true,
    '_allowEmpty' => true
  ]
];
```
Reads more naturally to me than:

```php
$validate = [
  'title' => [
    '_requirePresence' => true,
    '_allowEmpty' => true
  ]
];
```

Lastly requirePresent is 1 character shorter :wink: . I'm fine with either in the end, as both are an improvement over 'required'.
The codesniffer should be tweaked imo.
You could just `$this->assertNull()` the return of `startup()`.
Why a CRLF here?  I don't see why you need any whitespace at all really.
What about returning the output of parseChildren() children here? If false it would break the loop (no need to test for result a few lines above?).
A "return true" at the end of the function would then be more consistent.
Because the source facility offers a generic resource so it doesn't matter what you request.
Yeah, support was added in IE9, but don't we also run on IE8?
please remove the typehint (the right typehint would be ``callable`` if we were 5.4+ only)
What's the meaning of an optional simulation?
I pushed the suggested change. Thanks @josh
Arr.. yeah . forget to mention in the description . It prevent them spam to console from several games
Even if they do, I imagine 99% of dynamic things you'd put in the prompt are ascii.
I was sure that was the case, but didn't know the appropriate portable version.
A `rename` function that can also save non existing notebook feel strange. 
Is it a docstring mistake or can the function really do that ?
need endpoint property passed through
We need to store the OS error code on Windows too!
add `storage_names[:default] = "messages"`
Marshall Culpepper wrote:
> IIRC we actually require the10.6  SDK in our AOSP build, but I guess10.7  (or10.8)  worked for you in Mountain Lion?

There is no 10.6 SDK in Mountain Lion; only 10.7 and 10.8. I admit I 
didn't actually test the 10.8 SDK, which is why it's a last resort 
fallback. We can remove that if we're not comfortable leaving that in.

But the 10.7 SDK worked fine for me.

-- 
Eric
Good call, the channel page is an old test page I was building so we can actually just remove it.
Why the bottom margin?
Haha yeah that's why this took so long. I kept thinking I was done and then I'd find something else...
This is really obscure. Could you please add a comment on each route to explain what each parameter is?
yeah, `create` is when you want to save stuff to the db. `build` is when you want to avoid a save. but, yes, I'd like to [eventually forgo the `version_factory` crap](https://github.com/mozilla/zamboni/pull/543/files#L0R591), since we rarely care about versions in tests. there are like, what, 15 tests that depend on them.
The `);` should go on next line
Good question! I believe you can just edit your files and then there should be an option on GitHub to either re-submit or update the submission (It's been a while since I've made a pull request since I've been mainly working on Pyro) - either that or just delete it and re-add it.

Adam
The tests look really good for your first tests. There is always improvement ;-)
should simply be ``if`` instead of ``elseif``
The interface is taken from PSR proposal and I've tried to keep accurate to it. Should I still make this change?
>**I** should be deprecated in 2.2 and removed in 2.3.

Please Fabien don't get deprecated or even removed. We need you. ;)
if you don't need $attributes, you'd better use 
```php
foreach (array_keys($loaderIds) as $id)
Public methods should be placed before private ones. 
And here it might be better to use `__toString()` instead.
@mezis this return statement is not required, neither the `sql =` before that.

could you update that? :)
I am sure you can do that.
Lines 5-7 are repeated on 21-23, 33-35, etc. I'm cool with no `before do` blocks, but shouldn't we at least extract stuff like this into helper methods just to DRY it up. What happens if you need to change something about these lines it seems like a pain to do it over and over again.
I don't think there's anything clumsy about this block, but not sure if there's any overhead to calling rows.Err() or not, or if it's guaranteed to return the same result if called multiple times, so it may be a good idea to call it just once.
a.ip are netaddr.IPAddresses, so they act like ints.

Converted to sorted()
we could now change the width to 16em
You can omit the second argument so that it always fires.
Missing semi-colon here is causing jshint failures.
I'd vote for having both mechanisms. I like having possibility of simple customizations for the most common tasks (adding buttons to the empty widget) with the possibility of completely changing everything under the hood if so desired.
I can't grasp what exactly is going on here. What is the pending object holding? Can you explain this in more detail in the comments and rename `x` to something more descriptive?
See my line note at EJB3Subsystem12Parser line 114 -- doing that will take care of this problem. It will only marshall if the value is actually set.
It is used for the home page, I don't want to display all browser on the home page (including FF4-10), but don't display just currentDesktop either.

Once I implement ClientsAction (#72), we can drop this "default" browserSet and instead make SwarmstateAction (and on HomePage, naturally) return browsers that either 1) have online clients, 2) have pending runs.

Also note that this "default" is not the default browserSet for addjob. Addjob has no default.
That would explain why batch edit is still a bit funky

----- Original Message -----
> 
> 
> In app/views/batch_edits/edit.html.erb: > @@ -1,8 +1,8 @@
> -<%
> javascript 'bootstrap-modal.js'%>
> -<% javascript
> 'bootstrap-tooltip.js'%>
> -<% javascript 'bootstrap-popover.js'%>
>
> +<% javascript_include_tag 'bootstrap-modal.js'%>
> 
> These aren't drawing to the page, (no <%= tag) Do we still need them?
> 
> —
> Reply to this email directly or view it on GitHub .
lets extract this into another file
Here you have:

<pre>
adb shell "for x in `busybox --list`; do ln -s /sbin/busybox /sbin/$x; done"
</pre>
@jlebar: but you're right, the steps in the algorithm that follow that sentence make it clear that the first entry is the vibration time.  

In testing, I get a satisfactory pause between vibrations as it is, so I'll just replace the code with mozVibrate(100)
@fabi1cazenave do we have to wait for the `localized` event before doing this?
IMEs is used in some non-Gaia code, with different platform requirements (hence the shim). I will not remove this.
`<h1>` is used in the main header structure `<h2>` is used as subheader so `<h3>` seems legit to be used, maybe we could use just `<header>My title</header>`  for avoiding getting complex with the headings chain.
Don't you want to call showIME if the type of the keyboard change?
What about a 

function log(str) {
  print ('  +-+ OfflineCache: ' + str + '\n');
}

so it will be easy to enable/disable those? Or maybe you really want them to be visible?
Can you add this format to the localized string?
Suggestion: I propose to let css determine everything you does here. Set the `ftu` class in javascript would be enough.
And you really don't need hide statusbar by yourself.  `fullscreen-app` does that for you.
The 'un' comes from the fact that you can 'Select All'  or 'Unselect all' as this button toggles its functionality. In any case my proposal is 

selunsel --> selectAll
Because adb shell returns with "error: service name too long" and I dont know how to fix it. Furthermore if we can include the list with the backups maybe is better to maintain a separate script in charge of back files up and the perform the symbolic links. What do you think?
The >> 64 is a no op. The reason you got to it is that you skipped >> 24 :)
I actually like it better briefer. It doesn't have to be updated every time there's a minor release, and it teaches students to read and understand command output rather than just eyeball matching a string of gibberish.

Plus the version you have is actually incorrect on many systems -- remember, the install_rvm_and_ruby page is linked from several places.
Heroku actually broke `-v`? Do they even know UNIX works?

Thanks for catching this.
No, I'm just learning API to find out how to make thread pools die.  But I'll give it thought.  I intended to contribute more here after M4. That's just a random answer.
~~~
とメッセージがでます。
~~~

→

~~~
とメッセージが出ます。
~~~
I don't think ``:matplotlib:`savefig` `` is valid restructuredtext. writing

    matplotlib's `savefig` function

 should be sufficient.
I think we should take type parameters here:

```
case class WritableSequenceFile[K <: Writable : Manifest, V <: Writable : Manifest](p : String, f : Fields) extends FixedPathSource(p) with Mappable[(K,V)] {
  override val fields = f
  override val keyType = manifest[K].erasure.asInstanceOf[Class[_ <: Writable]]
  override val valueType = manifest[V].erasure.asInstanceOf[Class[_ <: Writable]]
}
```
Does that work? This way the compiler can actually see what the tuple inside is (K,V) (hopefully that works....)
I think taking an IndexedSeq[T] would be more idiomatic scala.
please give a better name.  For instance, ```allSolutionsForSize``` or something.

Note, Algebird now has Semigroup[T] that is only associative. I think we should be using that here.
use fileprovider
Break this out in to multiple lines. If you need to use a `\` in your list comprehension, that's a sign it's too long :P
What exception are we trying to catch here? If possible, we should use specific exceptions so that unexpected things aren't accidentally silently swallowed.
@peterflynn found out that the `preventDefault()` doesn't suppress the context menu--it just prevents the lineSpace from taking focus, which is what we want.
Looks both libvirt_vm and your ovirt_vm don't allow a vm name with something like '' and 'None', so better to raise Exception here directly.
in db, or in data?
Need to remove `category=None` here
Either way, I don't think they're providing particularly useful information -- at least, not information that won't be repeated later.
I agree.  why are they here? and why are they creating and adding to static maps?
pretty sure they're just passing it on to openssl verify via the api. Could be wrong though. not looked at the c.
I don't like this approach because I care about my code. What I'm doing actually depends on that value having been changed, not having been clicked. You can click on a radio input and the value wouldn't change for example.

I want to handle IE7 specific bugs in a separate file that I might even include in a conditional comment, for example, or even remove IE7 support in the future.

But I still want to write code that is meaningful for correctly implemented browsers and have some fallback code to support IE7 because my client wants it.
20 - please use self-speaking constants
I tried moving the field into the ```f:entry``` , but then it does not work anymore
damm, that is really horrible macro which depends on two variables. I quickly look over code and I think that it show more serious error, as it is used in many place where error is set just before return, so it is useless.
I think that using silly code that too avoid warning is not good approach. We should try to clean code in this case. I think that in SET_ERROR should be 2 parameters, one is error_msg and second is msg itself and it should just call g_set_error. If someone need addional set of local variable, then he should do it himself.
@tgoettlicher  what do you think?
I prefer 'block.call' instead of yield since it's more explicit, and from the function definition you can see it uses &block and you can search down for where block used.
Why does the table header need to know about the pagination state?
I would just called it `getOwnerWindow` or `getContainerWindow`.
Let's return `null` if tab is destroyed to be consistent with other properties.
hmm I think think my cherry-picking didn't work out well, I will clean that up..
is there any concern of multiple xhr_complete events triggering, and causing multiple setTimeouts to be setup, when only one is needed?
Yeah, I mean a DVCS is a directed acyclic graph of revisions, so technically it's correct to call a revision a "node", but it's not very clear because "node" is a much more generic term, it could be just about anything.
Use statement order by name if I remember ;)
As mentioned in http://projects.puppetlabs.com/issues/11612 standby interfaces are marked by an asterisk and have no ip address.<pre>#> netstat -in
Name      Mtu  Network         Address         Ipkts              Ierrs Opkts              Oerrs Coll
lan1*     1500 none            none            0                  0     0                  0     0</pre>This way facter will complain issuing something like "Could not retrieve network_lan1: invalid address" so I'd propose to ignore these interfaces and change the line to <pre>     output = %x{/bin/netstat -in | sed -e 1d | grep -v none'}</pre>
use `uncomment` method here
This no longer removes the backup file; can you manually delete that alsoL
@zaphod42 I was debating this technique anyway. I've modified the pull request to reflect this. Take note though - our exceptions don't use Puppet::Error as a parent, so I've reimplemented in this case - but I'd like to hear your thoughts on weither we should just inherit Puppet::Error.
Both of these should probably support "truthy" values, not just boolean true, so that you can have, eg, `:virtual => 1` work as expected by Ruby users.
dependencies = ['numpy']
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Whitespace#Whitespace

Also, 'Image' is also a dependency (sadly).
Oh, thanks - I saw you fixed this already : )
What about merging this with the rule above? ul, ol {...
removed the activation strategy ;)
sorry, this is not true.
the protected property $saveHandlerTableConfig will be initialized BEFORE setUp is called, so it's too late, to just skip the tests in setUp. You will get a fatal error, because the expected Zend\Db classes could not be found.
@mjreich just added this option to avoid encoding, I'm not seeing it used anywhere so not sure of the motivation, perhaps you two talked and using http_build_query handled the problem in a better way? Other than that, http_build_query seems like the right way.
Your call Emily, this is bikeshed to me.
You should also remove the method in the extension if you don't use it anymore
Should be add
`var word = (left > 1) ? "items" : "item";` -> `var word = left === 1 ? "item" : "items";`

The first one will show `0 item left` which should be `0 items left`.
This should use [`is(':empty')`](http://api.jquery.com/empty-selector/)
this is wrong. It does not always return an ArrayCollection. As soon as it comes from the DB, you will receive a PersistentCollection here. So the only valid phpdoc is the one mentioning the Collection interface
Extra space between index name and `=>`.
this is wrong and should be reverted
is it compatible for python 3 and py 2.X series? I'm the owner of the "feedgenerator" module, I can probably do something for it? (like releasing a py2 and py3 compatible version)
Two empty lines before this.
OK, thanks.  Added a default of null, as I want to retain the current behaviour as default.
Unless you need it somewhere else, you can drop the `Http404` input now.
Not related to this gcode issue, but while you're in the file... We're trying to use the new and more concise Rails syntax for rendering partials, which is that when rendering a partial and passing in a hash of local variables, you don't need to specify that, partials and locals are self-understood.

So it would be:
<code><%= render 'work_blurb', :work => work %></code>

It's not mandatory by any means, just a nice-to-have. :)
Here, logging would be possible but the error would only be visible after startup, making it useless if the user wonders why liquidsoap doesn't find some plugin. On the other hand, this also results on liquidsoap writing on stderr on every single run (including e.g. liquidsoap -h <plugin>) because it cannot load RGB (unhandled number of inputs). I'm not sure what to do... perhaps could we treat this specific expected error specifically?
I wanted it to be a "dumb" delegation, so if the arguments in `ReminderMonitor` change this won't have to. Is this the way to do that?
Why does this take varargs and a block?
"Before it actually gets served" is also misleading here (wtf did that even mean?). Better to rewrite the sentence as "The wrapSite function allows you to modify this toplevel Handler."
The project is aeolus-incubator. Aeolus guys will rename the namespace
soon, actually I was told the next sprint. 

https://github.com/aeolus-incubator/bundler_ext

LZ

On Thu, Dec 06, 2012 at 06:22:32AM -0800, Sam Kottler wrote:
> > @@ -2,13 +2,22 @@
> >  
> >  require 'rails/all'
> >  
> > -# If you have a Gemfile, require the gems listed there, including any gems
> > -# you've limited to :test, :development, or :production.
> > -if defined?(Bundler)
> > -  Class.new Rails::Railtie do
> > -    console {Foreman.setup_console}
> > +if File.exist?(File.expand_path('../../Gemfile.in', __FILE__))
> > +  # If there is a Gemfile.in file, we will not use Bundler but BundlerExt
> > +  # gem which parses this file and loads all dependencies from the system
> > +  # rathern then trying to download them from rubygems.org. It always
> > +  # loads all gemfile groups.
> > +  require 'aeolus/ext/bundler_ext'
> 
> This loads stuff from aeolus?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/foreman/pull/264/files#r2335253

-- 
Later,

 Lukas "lzap" Zapletal
 #katello #systemengine
I discussed with Ben and studied [UX spec] (https://www.dropbox.com/sh/b0kyykhzcfkpm8b/fdA0gFkf5U/Gaia_AppInstall_20121011.pdf), it will be okay because the UI flow for installing app looks mostly the same.
note: would rather not pass in name just for the failure message so let's make the message generic
Since the message itself is untyped (`Any`), this method is giving a false sense of type-safety. It should either be `Any => Any` or you need to attach a type parameter to `CamelMessage` (which can get out of hand quickly).
"parsed from class" does not really describe where these flags come from.
Something like: "Get all Flag instances added through loadOpts method."
What happens here? The `outdated_specs` are never used as on line 51 an empty array is returned instead.
Oh wait, it's not `4 nPr 3` since not every permutation is valid -- the points have to be non-colinear, so it's `3 nPr 2 * 3` which is 18, so never mind.
This method will be called *a lot*. We'll want to optimize this method to work more efficiently for most cases. For example, most of the time the `localSourceKey` will exist, and so the first check will be false. Also, switching the key type to NodeKey (see earlier comment) means we wouldn't have to check whether it's a valid format.

Perhaps a TODO (since this still is a work in progress).
Oops, sorry about that.  Do I need to fix and issue pull request again?
Ne need to chack type of the variable. str(value) anyways
It looks like this would be lost in this commit. Does this list need the tablesorter?
ご指摘の通りです。ありがとうございます。
I did not really take ownership of this great poem, but rather the file itself.
и у всех наследников.
название не соответствует комментарий
Yeah, my ide can do it that way, just had to turn it on.
I feel like this should be a git pull, or a git fetch followed by a git merge. Because I'm pretty sure that git fetch won't actually merge any changes to the remote repo into the working directory. I could be wrong though.
We should extract out some sort of SQL-set-membership query, as that's basically what this function and resource-metadata-exist? do. Both functions have essentially the same code.
The if can be removed when createComment and createReply are consolidated.
`.length` should be assigned only once and not re-invoked on each iteration. This applies to other instances as well.
I've never seen an API change the username "under the hood" to create / access users, and it doesn't sit right with me. I think we need to manage exact representations of the "external ids", and come up with a different strategy for our internal representation: e.g., store users an internally generated UUID: c:cam:sldkfjOSDIFjskdfj++  ; or maybe a shortId would work in its place.
I'm hoping to persuade people familiar with those distributions to provide equivalent details. If no-one does, I'll find time to do some research.
we are... but I don't like using a tags with no href attribute
I think a tags are sacred and should only be used for real links
a button makes more sense
whitespace around r.response
Please follow style guide, bracket on a new line... Also add a space after if
A constructor must always be public!
Does this even work?
Поскольку А соединяется только с Т, а G с C, то при генерации приходится учитывать предыдущий "ген". Поэтому добавляю по 2 за раз. Хотя в задании этого нет, конечно.
Внёс исправления в метод. Теперь ген обязательно мутирует.
Ну, что я и хотел сказать - индексы упорядочены. Главное, что на результат это не влияет.

Кстати, буквально сегодня меня как в голову ударило от того, что не сделал одной очевидной вещи раньше: если мы меняем 100% - то можно и не использовать скачки по случайным индексам. =) Решил внести исправления в свой алгоритм. Одна дополнительная проверка, с помощью которой можно много всего отсечь и тупо в цикле менять значения элементов подряд.
@Senior-Student ну для всего метода mutate - это я загнул, конечно. Имею в виду, если сам метод mutate будет зависеть от одной рекурсивной функции.
Return Armor for chaining
I'll do that, sorry about this.
So, changing *JDatabase::insertObject* with platform's code will fix these issues because JTable::store calls *JDatabase::insertObject* and *JDatabase::updateObject*. I'll try this.
:heart: !
If I’m not mistaken, this and similar templates (which have been replaced with a newer version) should be deleted now that they are unused.
from nose.tools import assert_equal
assert_equal(correct_bads, raw_new.info['bads'])
不错的做法
这里只是好想法
或者简单说很好也可以
Ah, alright. So the confirmation token gets set to `nil` when updating the password, thus making it vulnerable to `nil` being passed in to the subsequent update password request. Makes sense!
Feels a little strange to have a class with all class methods. Would be nice to convert them to instance methods.
Needs a comma after this line.

Picked it up by validating JSON files using http://jsonlint.com.
maybe _, validation, we're not really using the resp
I believe "expect something to equal something" is correct english and shorter, so I woul remove the `be`.
ok I see, that must've been why I had to remove it.
I'm not too happy with abusing the `extraTemplate` argument... But the whole docextra loading code needs to be rewritten, for the moment I'll accept this patch as it is.
The tests can be improved by using 

    Assert::EqualMsg(true, CheckExportOptions ("sec=none:kerb5"), "colon is a valid char in options");

That way you get a much better output for a failed test than

     true
    -true
    +false
     true
И тут везде тоже.
This will breaks JSONP support as JSONP will only works when enableXDR is enabled. What is the reason to change it?
Please use a meaningful name
If you're defining the colon (:) delimiter in multiple places you might want to define it as the prop delim globally.
We do use only Clojure's built-in data structures at the moment, but that is not all that Clojure offers, it was just the simplest solution for a small codebase.  It's also convenient because it maps directly to JSON, which is what the API expects - if you use objects you need a constructor and destructor from the values produced and accepted by the API. 

If you want custom types and type-based dispatch, Clojure has that (we rarely use it at the moment): http://clojure.org/datatypes  I have nothing against exploring using them.  My gut feeling is that they are overkill, but I think it'd be worth our time to do a spike to experiment with using them.
Hier wird nur noch $sCategoryID für die lokale Verwendung gesetzt, $_GET['sCategory'] wird also nicht mehr überschrieben.
I had no idea about angular.equals()
The math is right, but I think this is the mean and not the median. :)
Sorry, sir. I really don't know about this. I have defined all the helper functions with defn. It can run normally. I think it is a pity for me to lose points because of this. Can I modify them?
I revert the commit.
I do have intl. I don't know why, but `\Transliterator::create('ASCII-Latin', \Transliterator::FORWARD);` return `null` :(
What changes to boilerplate.py are required?
Is it necessary to explicitly cast this dtype to be floats?  I'm not against it, I just don't see it done elsewhere.
Should `stack` have a closing backtick?
That's sensible.
Not entirely. The error I was getting was a -1 index because of the vacancy count was 0. (0 * 2 -1 = -1)
We should at least fix the CSS that's applied to the same element, that looks broken to me.
Went through all my code and fixed what I found.
in the CMachine code, there is :

bool result = train_machine(data);

	if (m_store_model_features)
		store_model_features();

and in init() , set_store_model_features(true);

It seemed more semantically correct to put this code into store_model_features(), i've tested it and it seems to work.
However, if you judge it better at the end of train(), then i'll put it back there
eeeew, isn't it weird to use directly the returned json here? I would expect create_definition to return me something else that only the id, what do you think?
As a media size overwrite, there are no "more specific" selectors - it's the same selectors, but they have to get redefined the smaller we get. In this case if there is a more specific selector, it also needs to be used in the normal CSS.
Isn't this a bit odd for Travis::Services::Base to include Travis::Services?
No, because serializing will not work then.
I am concerned about these asserts too. If they should crash the agent then please print something and use exit()
Got catch, fixed in 7fa43818723fe037819bc09eff8a9cf8a93320fb.
Are you sure you want to override the parameter ``$response``? This often makes code less readable.
damn, thanks!
Use $this-> pagesCurrent instead. The get() method is deprecated.
We should at least allude to the breaking change here.
YES. I have a note to reconcile them with these changes.
For some reason the logo can't be found anymore. When creating the help locally it's missing, and it also is missing on the server. I just don't get why it's working before the patch.
and one more "fundamental" question: why do we talk about publish workflow in this interface? it could be any sort of access control and the interface would not look different... can we call this AccessControlInterface and call the method canAccess($document, $request = null) ?
Construct HTML elements through jQuery. See how we are doing for user list panel, for example.
Do you really need data attribute? You do know that hidden and input fields are siblings in DOM (are they?) or at least that order of hidden inputs is the same as checkboxes.
No need for the message because you are returning to the same page. You would need this if you would be redirecting to some other page and would need to give the user feedback.
Much done, but still some fixes necessary
Yes sorry, was just doing that. But this one is the last
Maybe I should just try to make a new Pull request?
The idea of curse is that you put this into base.
I really don't understand why are you changing completely valid code? Why removing `for` from labels? Why removing class from `li`?
Please read example in documentation carefully.
OK, what if we leave it as it is, do a pull request. And then you go and try to change it? So that we get a working version in, and then play and see if we can simplify it?
Move all those to one line.
More fragileness. When we wanna support other protocols, we'll have to come back and modify this.
```ruby
if item.is_a?(Array) || item.is_a?(Hash)
  # Swap with else
else
  # Swap with if
end
```
I think it's too heavily emphasized in our requirements to take it out. This model could actually function as a TaskInstance for this release though, since it doesn't deal with frequency or anything like that, so leaving it with a single assigned field I think is fine for now, but I think it'll need some overhaul next release.
Out of curiosity what happens if the `url` portion is passed as variable name that doesn't resolve?
All tests disabled by default?
Place `api_class=API):` at end of previous line, if the length of the line is at most 79 characters (I think it should be, just from eyeballing it).
There is an `Array.isArray` function that I think could be used instead.
doloz tutaj

```coffeescript
attributes:
  type: 'text'
```
made into stub
"Service Bus" is a proper noun and should have initial caps.
Missing t() on text.
Please use:
qCritical() << "Something went wrong while daemonizing, exiting...";
Can you use constat names for the modes? Or an enum?
That looks **much** better.
Ah, I see. Nice catch! In that case the only thing I'd suggest to do is to update `README`, because it contains misleading example with lowercase components names.
This is too big to nest under an if condition.

Also, I don't like the idea of returning `null` from a method whose interface claims to return Pheanstalk_Response.

Perhaps something along these lines?

```php
if ($command->wantResponse())
{
	$this->_readResponse($command, $socket);
}
else
{
	return new Pheanstalk_Response_NullResponse();
}
```

Basically an [Extract Method](http://martinfowler.com/refactoring/catalog/extractMethod.html) refactor.

And then you'll need a NullResponse, something like this:

```php
class Pheanstalk_Response_NullResponse
  implements Pheanstalk_Response
{
	public function getResponseName()
	{
		throw new Pheanstalk_Exception(__CLASS__ . ' has no response name')
	}
}
```

Does that seem sane?
transport may be null here
now c2g-contact@class.stanford.edu
removed from controller
Perhaps move the FIXME from line 30 to here, and include as a javadoc comment.
Mark field as deprecated?
Wrap in try-catch to guarantee exceptions get logged?
I expect Brooklyn's entity.invoke will log it anyway though...
localhost only, for use e.g. with cloud foundry command-line tool 'vmc'

have updated javadoc
Ca fait ref a quoi `This should be a simple problem` ?
All text needs to be translated. Use the translation structure already setup in the i18n directory, and pre-fill foreign languages with the english version. Then send me an email requesting translations, and I'll pass this onto our translation guys.
It's just my own personal preferences, I don't really like preprocessor directives if they can be avoided.

And yeah, you're definitely right about the NullReferenceException, didn't really think it through. Maybe we can solve both problems with something like `String.IsNullOrEmpth( (gitPath ?? "").Trim() )` ? It's more cumbersome, but then the same code works for both frameworks.
Sure; though I have some thoughts -

1) Conceptually: We'd have to backport features from .net 40 to .net 20 or live with the "least common denominator" in terms of functionality. I'm not sure if that's the best way to proceed, but hey ... you're the repo owner :). Also I've tried to be very careful and ensure that we don't have very different functionality between different frameworks, but we do take advantage of newer features, where available.

2) The pre-processor #defines are being auto-generated in the .csproj... so there's not much chance of someone defining NET40 while building for .net 20.... 

3) Nitpick: We'd need something other than 'this.gitPath.Trim()' (if gitPath is null then the Trim() will throw)... 

Lemme know if you want me to make a new commit - without the #if statements....
What you could do here is
`u['username'] ||= u['id']`

Then change the line below to `security_group << u['username']`

And all other references to `u['username']` should be backwards compat since it will get set to `id` if it didn't exist.
We _DO_ change the read preference to primary (if it had been changed before) here - but we still return false.. That seems wrong to me
I guess this bit splits up dc:east into key/value pairs? Perhaps a comment would be nice?
My gut reaction is that we should check `#to_ary` and use `Array.new(actual)` instead of `actual.dup`. `Array.new` will take in a thing that responds to `#to_ary`.

What do you guys thing?
Why not have a tuple instead of list?
Shame on me for the `</input>`
I'd like to remain consistent with the syntax used in switchToWindow(), but I agree both ways work.  Here is how that method is currently...

```php
    /**
     * Switches to specific browser window.
     *
     * @param string $name window name (null for switching back to main window)
     */
    public function switchToWindow($name = null)
    {
        $this->wdSession->focusWindow($name ? $name : '');
    }
```
Linia cu comentariul?
Oh the GCS side we have a lot of things that are board specific (e.g. config hardware widget, image for bootloader, the output channels).  I think this architecture will prove useful but agree we should factor the constants (e.g. board type / revision) into a shared/include folder.  I dont' think anything about this architecture precludes that though.
Is much clear with a class. There is many packages using that format. I'll prefer to keep it.

You are sure "Pref.something" is a global, also this avoids to set "global something" to every value there, avoids the definition on global scope, avoids collisions of similar names if the code grows. Not sure if there is more. :)

Will prefer to have
`settings.add_on_change('reload', settings_changed)`

since this is unique to this package.
Well, that's why I call it a "fast hack", at least we're using it since I submitted it and it helped us much, no problems with the height of the menu (not too long no too short).
Das ist nicht notwendig, da du Adminrechte voraussetzt um die Applikation zu starten!
Using an over arching chain of promises to run the tests since this allows for timeouts in between runs. Which allow the stack to clear
There's a helper function you can use: https://github.com/danielbachhuber/Edit-Flow/blob/master/modules/custom-status/custom-status.php#L569
А, я тебя обманул. Надо checkCast() использовать
Понял. Спасибо.
That won't work if the styleeditor is already open. Use `select`.
I don't think there should be such a thing as an unregistered target, should there?
`Toolbox.jsm` doesn't have a `Target` export, looks like an extraneous import.
this method hides a error under a false it should be removed...
read-only and required don't make sense for a response IMO
Remove subtraction of `centre_r` here as you add it mostly again everywhere below?
Since we are allocating c data structure shouldn't we move that to ``__cinit__`` (see [1])?


[1] http://docs.cython.org/src/userguide/special_methods.html
testing githubs ``fuckups``
Otherwise if not None, reuse the `X_norm_squared` array as working buffer instead of allocating new memory.
This test fails under python 2.6, because the output is printed as a tuple with parentheses.  That being said, does this mean we should do a ``from __future__ import print`` in these doc tests?  I'm not sure.  The other option is to use string formatting so that the output is the same in 2 and 3.
I get an error message for line 53: undefined local variable or method for c
If you don't define the "multilang" setting in your config, "locales" won't be required.  I just tried without setting multilang, it works well.
Better use example.org or something similar
The usual style is to put both `else` and `if` on the same line.  (Except when doing horrible things with the preprocessor)
Spelling: Parameter
I considered it but decided against it as it's not the default path and having a space in the path is likely to cause issues.
the idea is that `alert` is the shortcut, `createAlertDialog` is to show a native dialog control.

What David proposes works to send to the console, but that's not the longterm solution, `createAlertDialog` needs a c++ implementation
I think a single wrapper could work if you override the `configure` method and proxy all other calls to the wrapped command...
can you remove the empty javadocs.
If you write something in it they are welcome, otherwise it's cleaner to just remove them
No, this should not happen. Either we have something to add or the superfile doesn't get created.
In fact, maybe I should still be checking size if !wholerecord (or getFlags() unavailable) anyway (?)

Because in theory if not whole record, the key meta _could_ be bigger than the row ?
They do, since I have hit the asserts inside this code. The simpler ones got optimised before getting here, so no harm done, but the more complicated ended up inside there and did assert (that's when I made the typo, fixing another typo).
The help text from the command still suggests there shouldn't be a | and the eclserver isn't optional.
It will call thorAllocator->getRowAllocator, which in turn will call createRoxieRowAllocator, which links 'meta' in CachedOutputMetaData member
I would have this call outside the if.
These methods are the same than the RepositoryUtilsInterface methods. I'm wondering if we should make this interface extend the other one. Another solution would be to add ``getRepoUtils`` in this interface instead. What do you think ?
/cc @l3pp4rd
Yes, it's needed. Maybe we'll need to add more arguments only for one of these events, and I don't want users to change their code just because we didn't create classes for specific events. Even now it's useful in cases where you use the same listener for both events (maybe for logging, for example), and you need to determine which event was fired just checking the class of the args.
And ``requests.get`` is a function that calls a middleware service and returns the result (see https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/crashstats/models.py#L120 ). And that result should be a JSON string mocking what the middleware returns. Thus, what I am returning here is exactly what the middleware returns (see http://socorro.readthedocs.org/en/latest/middleware.html#id42 ). 

If you tell me my previous statements are wrong, I'll need some explanations, because this entire test / mock thing will stop making sense to me.
Is that not mocking what the middleware returns, and not what the model returns?
It doesn't mean much more than xul/base.

We are trying to abstract low level xpcom things, whereas, we shouldn't try too hard, especially in that case.
It is all about some XPCOM internal details. So that people using these methods will have to know XPCOM details,
and they will most likely know them before reaching this code or will have to learn them through idl and all.

So what I'm trying to say is that we should not try to erase all scent of XPCOM when it is all about XPCOM.
And in parrallel, I understand that you try to find small words and remove superfluous terms,
but we should not go too far on this track as we may loose hints that are helpfull while reading code.
if there is not a primary fetcher then there shouldn't be a secondary, it is just not clear

This is an argument of the zend cache service you set, but how it relates to the Zend Cache fetcher service. If it is a object that gets delegated tasks? then i would say ancillary_fetcher or fallback_fetcher but all in all the fetcher thing is perhaps creating the problem imo to really understand what those new services  do
There are indentation changes for these lines, I am wondering why?
Ah, roger that.
I have to say I prefer the simplicity of the syntax in @yuhunglin's approach. @christianv do you see any down-side?
@shacker It's good to know about it, but I don't think right now is a good time right now to extend Angular that way. As soon as we understand the deeper concepts, we could try to come up with something ourselves.

I think our time is better spend on trying to write tests with the current `isAllDay` functions.
Please put a comment to this effect in the code.
use the methods from Post::File when possible please. They are platform and session type independent.
Ternary operators are the devil.  Rewrite with if/else, please.
This is a confusing idiom. ```!!(foo)``` is much more readable.
That doesn't sound right to me.  If you request a file that doesn't exist, you will still get a response, but an empty body.
res.body.scan do |view_id|

end

no {}
I think you can actually gather the temp directory from the environment so you don't have to hard code it.
I would like to check res.code before res.body. I can add it by myself when merging. No prob.
typo: "thie" -> "this"
Ignore me. A wrapper function is unnecessary.
You need to save off `this` to use in in this callback. Causing an airbrake that @dadah89 found, on new tickets: https://zendesk.airbrake.io/groups/52057297/notices/7145675633
all backslashes within brackets now removed
Noted on this. :)
Setting the width or height of a canvas clears the canvas, even if the values are set to the same values as they already were.
This constant is a duplicate of the one in `CameraController`.  Now that that one is public, you should use it.  Also, this still seems like a minimum height to me, not a maximum.  Also, why do we need to limit the camera's height at all?
It's all about trade-offs.  What trade-offs are better?  Where does performance matter more?  Where does cleanness?
Spacing is a bit off here and below if you care.
Occasionally, a proxy is created with just `-[TiProxy _initWithPageContext:]` and may not have an `executionContext` there, either. This needs to be handled as well.
I would think this should cause a problem since I don't see the route being added back later in the method.  The purpose of this method as the update to removing the route does not match the earlier behavior.
K, I was under the assumption that you were saying scoping for runId was different in the context of this line.  I will move the declaration above the error check.
$.jqplot is used a lot, cache it into a separate variable
0.12 is a magic number REFACTORING OPPORTUNITY!
Also, when we say "developers" we mean developers of other produces which use markdown libraries. Not developers of markdown libraries.
malformed header? why was this reformatted?
this.loggedOutService
i tracked this down to the addItem method adding properties in the node array. this is cleaned up in https://github.com/jackalope/jackalope/pull/97

btw: the original check you improved was unnecessary, as the situation that a deleted item is still in the objectsByPath is impossible anyways and would lead to serious problems elsewhere in the om. i plan to further clean up the om in the hope to get rid of unnecessary complicated code.
直接rails s
лучше в i18n
The while is already processed in "while(n >= longLag)".
After that while we are guaranteed that i + n < 2*longLag.

In theory, I could have just started with i+=n and looped on "i"... But there is an integer overflow risk there => Loop on "n", finish the last iteration on n + i.

I'll add an in-code comment for posterity.
Well, I think it boils down to this: Will *Phobs* ever be built for such environments?
and ditto
I was thinking about whether using the length for loop termination could be faster, but as `r1.empty` is probably going to be inlined, doing it this way is probably preferable…
insert whitespace appropriately
my bad. data- won't  show up in render tree :)

this seems fine, but maybe use package:unittest and then you can write:

    expect(query('div').dataAttributes['hi'], equals('hi'));
Rename to `make_R_install_cmdline`
Looking really good!  I just did a little fly-by review.
Please create issue for both extensions at least
On Oct 8, 2012 10:08 AM, "Felix Mayerhuber" <notifications@github.com>
wrote:

> In
> components/ekb/persistence-persist-edb/src/main/java/org/openengsb/core/ekb/persistence/persist/edb/internal/PersistInterfaceService.java:
>
> > @@ -65,6 +72,7 @@ public SanityCheckReport check(EKBCommit commit) throws SanityCheckException, EK
> >       */
> >      private void runPersistingLogic(EKBCommit commit, boolean check, boolean persist)
> >          throws SanityCheckException, EKBException {
> > +        enhancer.enhanceEKBCommit(commit);
> >          if (check) {
>
> About the hooks: maybe a pre-commit and post-commit for the persist
> interface makes sense. It would also make it easier for the people of this
> sql workaround since they already get the model classes and no edb objects.
>
> About the regulations: I thought it would be sufficient to make that
> changeable by configuration file? And there I need to think of if it is
> enough to make it decidable through boolean values or if an enum is needed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/776/files#r1782547>.
>
>
Does this actually work? With some of the enter database sid stuff, this has failed.
? It doesn't seem totally obvious to me what this code does...
Hi Kevin,

Sorry about that.
I fixed that issue as well.

Thanks

-- 
*Henry Demirchian*
(818) 624-7657
henry@demirchian.com

On Tue, Oct 30, 2012 at 5:42 PM, Kevin Yank <notifications@github.com>wrote:

> In repositories.json:
>
> > @@ -1,6 +1,7 @@
> >  {
> >  	"schema_version": "1.2",
> >  	"repositories": [
> > +		"https://github.com/hdemirchian/CSSFormat",
>
> You have the correct URL now, but this line should still be placed in
> alphabetical order, rather than at the very top of the list of repositories.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wbond/package_control_channel/pull/717/files#r1987051>.
>
>
can you split this over multiple lines for better readability?
Alright well I disabled it for now, we can always re-allow it later on.
No not really. But 7 years ago, it was the practice, and with PHP 5.2.. as
well.


2012/7/13 Christophe Coevoet <
reply@reply.github.com
>

> >  });
> >
> > -if (class_exists('PropelQuickBuilder') &&
> class_exists('TypehintableBehavior')) {
> > -    $class = new \ReflectionClass('TypehintableBehavior');
> > +if (class_exists('Propel')) {
> > +    set_include_path(__DIR__ . '/../vendor/phing/phing/classes' .
> PATH_SEPARATOR . get_include_path());
>
> Well, does phing itself relies on the include path, or is it only Propel
> assuming that Phing is in the include path ? In the first case, it should
> be done by phing in its composer.json
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/FriendsOfSymfony/FOSUserBundle/pull/714/files#r1159155
>
I'll follow up in an email
is this a fix for the calculation of the horizon?
I believe you meant "after_script" instead of "after_sript" here.
Do you need the trailing slash here?
I find the current indent just fine.