labofsahil/github-event-dataset-2012 huggingface dataset:
Not quite if we have to consider double-byte characters and high-ascii  characters. Anyway, we can leave it for users who can't stand to read encoded url to log an issue.
When decoding an entire URL, you should use decodeURI(). decodeURIComponent is used when decoding individual pieces (i.e. components) of a URI .
I'd looked at the code (line 164 of jquery.smart-autocomplete.js) and there doesn't seem to be any harm in it -- it just never follows through with a UI update in that case.  I just tested with the code stubbed out to always reject() and it seems to work as I'd expect.
I'm not using %s on a dict?
The jetty server tends to pull in a notoriously bad version of the servlet api. Use

<dependency>
      <groupId>org.eclipse.jetty</groupId>
      <artifactId>jetty-server</artifactId>
      <version>${dep.jetty.version}</version>
      <exclusions>
        <exclusion>
          <groupId>org.eclipse.jetty.orbit</groupId>
          <artifactId>javax.servlet</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

instead.
Indeed, but this method exists in both ruby 1.8.7 and 1.9.x without having to `require 'active_support/core_ext'`.
If you want I can change it.
Why are you reimplementing this and not using signals provided by django-pushserver?
yes, there are other plugins that use classList
I like that you're reusing the `plugindropped` feature here. However, this exists in a more central place: https://github.com/mozilla/butter/blob/master/src/main.js#L145

Instead of binding this implementation to track-view (which seems a bit arbitrary), is there a way you could hook it into `main.js`'s `trackEventRequested`?
No this was me disabling Mongo and forgetting to enable it! My bad.
maybe add others here :).
No idea, actually. It was always there, I just fixed up the whitespace because I did for the other events that go hand in hand with it.

I cleaned up the other events whitespace because I touched them.

Personally, I don't mind if it serves no purpose other than completeness.

There was an empty onTrackEventMouseUp before I did this patch, so I just used it. I appreciated it, actually.

The real reason it is there is a mystery!
If the shim isn't ready yet, add a comment here to explain. Perhaps this line can be moved down inside the `init` function instead, when we know the shim exists.
I dont know why pip did not work for you, but either way this is a good change since this is the best way to package python with all its packaging nuisance.
more than 80 columns
I think that in order to make this a bit more descriptive, we should make this field called renewalDayOfMonth.  In the long them (maybe it makes sense to add it now) I would see a renewalDayOfWeek [Mon, Tue, Wed,...] for weekly subscriptions, and renewalMonthOfYear [Jan, Feb, Mar, ...]
changed this look like this
Ternary operator might be cleaner here:

progress = @provider.task_status && @provider.task_status.progress ? @provider.task_status.progress : "finished"
This should go in the doc instead IMO
Pyflakes told me that too, but it is used in the return statement. Maybe a pyflakes bug?
Should this debugging code be left in? It may be that it makes our jobs much easier when trying to debug people's issues, but just wanted to check if it was intentionally left in.
This could possibly be done with some metaclass wizardry in `SphericalCoordinatesBase`.  I can take a stab at it if anyone wants.
this is the only place used, but I suppose that might change, so done
Fixed! Commit pending...
good point - fixed
因为autoRegister的方法还没合进来，就先注释掉了。

另外我倾向于把这些东西包到一个叫boot()的方法里面去干，这样index干净一点。
See my other comment, this should be 

    // Without UI, FinishShutdown can simply be started in a new thread
    CreateThread(FinishShutdown, NULL);
Does this mean that the tool is deactivated only if at least one result is received from serve? It will be not deactivated if no result is found, right?
Is there any live example I can have a try with?
if you like typing the word "struct" a lot it's OK yeah.
This was easier than I thought it would be. ;)
That makes sense. I have to say I'm not convinced that this is the best way of handling the db though - FeinCMS probably does too many queries at the moment imo. I've not looked at it all in detail yet, but I believe pulling all of the content types out (but only once) will be better than getting them as-needed most of the time.
Just use the renamed `modes` variable throughout for readability.
Actually, this is more about decoupling gson.  While not  quite done, we've spent considerable effort towards json library independence.  Is it possible for you to declare a static inner class and inject an instance of Json to extract this?
Is this the unused return value warning you were talking about? Because there's another `p_chdir` a couple lines before that hasn't been wrapped.
If you're keeping a pointer, you cannot use `weakptr`. Use the normal accessor and free the ODB when freeing the builder.
The shop instance is passed as a keyword argument too. Use `shop.redirect` instead.
You should probably add a cache decorator to get zeus to cache this for some amount of time to avoid extra load.
wow, how did none of us think of having this before?! <3
I wouldn't mind seeing a before and after for this count to show they're the same.
@bluegr: I could, but as I told you last night in PM, I don't want to. I'm not sure why after our private conversation you had to also bring this up in public. Same goes for the other two comments related to this.
Are there not methods to set the data without NMS? I'm not sure if this would work, but you can try making a new BlockState and then updating it. Which should do the same thing just more bukkity.
Alright, thanks. Fixed.
Is template inheritance taken into account somewhere now ? it [was before](https://github.com/symfony/symfony/blob/2.0/src/Symfony/Bridge/Twig/Extension/FormExtension.php#L315).
why `^` ?
I'm not sure about that. In BaseNode::normalize() it first validate the type and then it call the normalizeValue(), so the type check fall before I'm able to cast it to float...
What I can do is to be less restrictive in the validateType(). What do you prefer?
The exists function should help you there. But who would store false in cache anyway? And even so, if you are using Cache\CacheProxy then it shouldn't be a problem to retrieve false from the cache.
Oh wait, `[MD]{1,4}` would also match `MMDD` and not split it into two different formatting tokens. It would need to be `M{1,4}|D{1,4}`
Fix what?
Does the call "YaPI::ActiveDirectory::Read"  read the samba config? As i don't see into this much, would be it clear from reading the logs that this call was done by yast service?
I didn't know that.  Thanks for explaining.

My code was counting on utc being nil and now it is an empty string.  I have to retest.  This may take 15 minutes.
You might want is_valid_ref here rather than comparing with Ref.null
Sender shouldn't be nil. That was a temporary fix I forgot about for a bad factory. Fixing the factory instead.

Agree with tell-don't-ask, although I'm loath to add more functions to `User`. Any alternatives?
naghshe figure inja chiye ? :D
hamoon div khoobe
Add comment for the strange "+5" at the end of the line.
I think it's better to throw IllegalArgumentException if n < 0, because it doesn't make much sense to hide user's error and return empty string in this case.
Column should always be lower case
There is a box missing here, because it's an I/O, and could fails => def getLastId: Box[Option[Int]]
That lines should not be modified
I've commented them out of the build. Obviously the page itself isn't in a TOC tree anyway.
we should probably move all of the test files over to this syntax if it's beneficial (for searching within editors maybe?)
Good point.  I just moved the the initialization of `result_array` to after the error checking
C'est normal qu'il y soit plus ?
this is slightly more efficient since you only pull the data out and call the ToString() method once
Ember instead of Ember.js, to match the new style
yep, in fact the values of quickmusic and so on are just integer (1 to 4) which can be set in settings. Indeed they trigger the 4 quick settings you can set up  on the Denon ;)
I think you could simplify this to `Dir[File.join(path, '**', '*_test{s,}.rb')]` (and remove the next line).
@mecathcart avoid navigating through the views whenever possible if you are in a model, this will create blank screens if the views have not been created yet.
i18n logging is _not_ required for TRACE level messages https://community.jboss.org/wiki/LoggingInCoreJBossApplicationServer7
no worries, the code needs better documentation ;)
double quotes, spacing, no second argument
Uninitialized vars at the top, on their own line:

```js
var subMenus,
    that = this;
```
I dislike this constructing of link in template. This should go some place else, if possible.
also the variable names are not currect
Steal the value from style/zindex.css
I thought about that, but I suspect in the future we might need to store something than screenshot in the db.
I like using early returns at the start of a function, but at the end of a function I find the plain if() {} else {} clearer to read, might be a personal preference though, I wouldnt block on it
nit: add a name to the anonymous function.
I dont think there should be different logic for default favicons and linked ones, linked ones can still fail to load and I think we should expect the same behaviour from both, seems like we could get rid of GlobalHistory.isFailed and keep that logic inside setAndLoadIconForPage
It's custom header, custom body. We've already got the full dehydrated response from the first pass, sending it through the whole cycle again would be an issue.
Instead of calling Parser, we should call it handler.   The scenario is, once parse the body, different handler may have different way of handling it.

(1) Git will do a typical git fetch
(2) Dropbox will do dropbox sync (no git).
(3) Hg may use Hg client.
Yed, there is a bigger issue with swiz / valve tests. Most of the existing tests do that which is wrong and we should fix it. They just happen to work correctly because the methods currently don't perform any async work.

As far as this pull requests go, just fix your (new) tests for now.
@brunomachado this can be removed together with `width: 100%` below.
Good note, I combined the two methods into one `color` method.
I don't understand how any of this documentation has to do with getting entities. Can you clarify?
You can comment this out for now, not trivial to explain - I'll document this later. Used for performance instead of setTimeout(fn, 0) on frequent operations like repositioning the map while dragging or resizing, so that the operation happens not more often than the browser can render it but still as fast as possible - https://developer.mozilla.org/en/DOM/window.requestAnimationFrame
Yeah when I wrote the Transform thread-safety a few months back I had no idea it was going to be abused this way. I think TransformComponent internally needs a rewrite to ensure it is safe as well.
It's unfortunate that Badger has no way of unregistering so this needs its own ZooKeeper connection.  Should talk to the badger team about getting that supported in the future.
This should probably be `None` so that users who are adding --umask to the twistd invocation aren't surprised.
Ah, you’re right. `controller` and `action` doesn’t have to be reserved. I forgot that we had split up `params` and routing `options` to avoid such clashes. Then it should be safe and easier, I agree!
Same comment as before, make sure you use the Type class helper methods instead of hardcoding descriptors as strings.
I am confused... is the field accessor available at this point? this change is inside a XXXDescr class, where everything should be string based... a field accessor is created during compilation, so it would not be available at this point, would it??
exit code should depend on eeprom fill level. If eeprom_config_t doesn't fit, return 1.
Ok, I'll revert the last commit :)
You are absolutely right, So I will close this pull request.
This is currently relying on my fork of the gu sbt-require plugin, as @ironsidevsquincy is going to be changing the entire plugin in the coming weeks. Is this ok for the time being? Or shall I submit a pull request to the original plugin?

@gklopper ?
Using reduced-redundancy as the default storage parameter is a bad idea. The file in the S3-bucket might get lost by using this option, and the cost-hit by using STANDARD is really negible unless you run a TB-sized site.
Can you format this differently? Separate flags from other defines. Also align values.
ok, thanks for the explanation. This will influence cob3-2 too, because it uses the same urdf (torso_v0), so I will manage that.
Interesting approach. The good thing is if we put it into find_by_email_or_alias it will also affect this validation.  I wonder how such a flexible finder would work though. Ahhh... I can imagine a map function that emits all records that have similar email addresses. Actually this is probably easier than in sql.
Nit: "read-only" requires a dash. Ditto for usage below.
1) The path in here looks wrong.  The first \\ seems out of place.
2) This seems like the wrong way to solve this problem, since we really do not know where a search page is located.  What is needed is a general way to mark a page as non searchable.
We will have to distringuish system from "jetpack system"/std modules.
system can go off manifest, std can't.
I think moving doc comments for `adjustPopupNode` would make it little easier to follow.
console.log will print that, that's how we usually show in sdk docs!
`target` already has a meaning in the web which seems close enough to what we're talking about here that we should avoid it to save confusion. `attachTo` reads well for all of the cases to me, but unless there is a better option for Bug 755963 we should avoid it. I guess `applyTo` is too similar as well. I'm traditionally poor a picking names out of my head, but maybe `windowTypes` or something along those lines?
This discussions says to me that when we release bigtent, we must have extremely high confidence in it.  There is no turning back, and errors affect 60% of our users.

--lloyd


On Jul 10, 2012, at 10:26 AM, Shane Tomlinson<reply@reply.github.com> wrote:

>> @@ -48,6 +53,20 @@ exports.process = function(req, res) {
>>     if (urls) {
>>       urls.type = 'primary';
>>       res.json(urls);
>> +    } else if (proxyidp.isProxyIdP(email)) {
>> +      var bigtent = proxyidp.bigtentHost(email);
>> +      primary.checkSupport(bigtent, function(err, urls, publicKey, delegates) {
>> +        if (bt_done) {
>> +          return;
>> +        }
>> +        bt_done = true;
>> +        if (err || ! urls) {
>> +          logger.warn('error checking BigTent for IdP details: ' + err);
>> +          return httputils.serverError(res, "BigTent unavailable");
> 
> @ozten - I politely disagree.  Having a fallback mechanism for the user in case of the Persona server being unable to connect with the BigTent server is WAY better than just throwing up an error screen.  A fallback isn't as clean/easy as I initially thought because of the variety of cases, but it is workable, and I think it would offer a better overall experience.
> 
> If address-info returns primary for users who are trying to add an email to their Persona account - all is good, the user may have to set a password on their account, but nothing worse. The next time a user accesses their Persona account, if BigTent is available, it takes over.
> 
> If address-info returns primary for users who have previously registered a BigTent address and are trying to authenticate while BigTent is unavailable - if the user has a password associated with their account, perhaps let them use it.  The user *has* verified they own the account, though whether we want to honor that verification in this situation feels slightly dirty.  If the user does NOT have a password associated with the account, that's the trickiest of all.  Perhaps send them down the secondary flow to create a new account or if they have a session already, add the email to an existing account?
> 
> With the reset-password flow, we *do* have the notion of an unverified email, so we can easily send them down the "go verify your ownership of this address" flow.  Perhaps that could work here.
> 
> It's not an easy change, but there is room for improvement over a hard error.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/browserid/pull/1753/files#r1133176
is this the first time we're exposing userid to the client, or is this the userid we're already exposing to the client? Is the only other place it exists in the encrypted cookie?
Good call Shane and Sean. I'll remove.
Removing the `display: table` and `display: table-cell` from `.table` and `.vertical` fixes an issue where very long emails would push the content off the screen instead of cutting off the email with an ellipsis (screenshot of bug: http://d.pr/i/OFfn)
I don't document my code often, but when I do... it's with wonky comments.
this console.log should be removed
For this to work for all of the existing code in the repo you're going to need to find every occurrence of `DatazillaModel()` and change it to `PerformanceTestModel()`.  It looks like you caught a few of them but I've found `DatazillaModel()` in views.py and most of the manage commands.  Make sure to do a recursive grep at the top of the repo.
I'm not sure I understand what this line does, can you explain your intent? <code>self.is_the_current_page</code> is already inherited from <code>BasePage</code> here https://github.com/mozilla/qmo-tests/blob/master/page.py#L20
`float32` or `float64` ?
It would be great to have acceptance tests around Augeas. The way they're written is quite different and it's not easy to get them running locally, unfortunately. I'd be happy right now if we could just be confident that these specs test the Puppet interface to Augeas, and assume the underlying library works.

I'd be happy to help with getting some acceptance tests in in the future.
Why do we have two different ways of preparing a compiler?  If the other "prepare_compiler" method isn't actually general enough to use *everywhere* that you might want one during testing, it should probably be named "prepare_compiler_for_some_purpose" or so - to make it clear to people what it actually does.
Again, I think some of this should exist in the topics/router documentation.
`@@stubs` will need to be reset the same as `@@all`
element example: validity error : Element example content does not follow the DTD, expecting (((title | titleabbrev)* , info?) , (itemizedlist | orderedlist | procedure | simplelist | variablelist | segmentedlist | glosslist | bibliolist | calloutlist | qandaset | example | figure | table | equation | informalexample | informalfigure | informaltable | informalequation | sidebar | blockquote | address | epigraph | mediaobject | screenshot | task | productionset | constraintdef | msgset | screen | literallayout | programlistingco | screenco | programlisting | synopsis | bridgehead | remark | revhistory | indexterm | funcsynopsis | classsynopsis | methodsynopsis | constructorsynopsis | destructorsynopsis | fieldsynopsis | cmdsynopsis | caution | important | note | tip | warning | anchor | para | formalpara | simpara | annotation)+ , caption?), got (title para CDATA programlisting para para para )
If the given logger instance === the already registered logger, perhaps it would make sense to return true (not sure that's something that can be retrieved)?
@Freeaqingme that would conflict with the standards found here http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-VariableSubstitution and is inconsistent with the preceding block.
Perhaps we should add the the description of wrapElements here as well.
Zend\Mvc\LocatorAwareInterface does not exist
It's also AbstractActionController, not AbstractAction.
But I can rename to AbstractExplicit, if this is more preferred.
can be, but if the todo is neither completed nor edited, the output would be <li class=" "></li> 
i personally don't like this, but i accepted your suggestion...
always space after key
My thought here is that when debugging I normally declare what the software is doing, do it, then report any errors (declare-action-report). If I put the logger.debug in the try block after the delete command we get an error without the message that we are attempting to delete the file in the first place. It's why I used the phrasing deleting vs deleted.

I think either way this is semantical and I'm not attached to the declare-action-report method of debugging. I'm fine with action-declare|report if you really want it changed.
@lstrojny the proxy factory cannot edit the code of your own classes. We don't want this at all
We are currently using subSelects for all search operations, so this is valid.

The SortClauseVisitor creates joins, so this is also an option, but Petar is right, this might require changes here and there. If it shows that inner joins are a performance requirement, I guess those changes should be made. Back then, afair, I decided for the simpler implementation.
> PHP Fatal error:  Class 'eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\TrashItem' not found
> in /home/eddie/ezp-next/eZ/Publish/Core/REST/Server/Tests/Output/ValueObjectVisitor/TrashItemTest.php on line 405

You forgot to update getTrashItemVisitor() method (including PHPDoc :))
Math.abs() returns Integer.MIN_INT when it's called on Integer.MIN_INT.
Should be `index == 0`.
What is this return for?
Spaces around =, after : and , in the entire file
youo should simply use ``if`` instead of ``elseif`` as the if returns
I would use rather shorter attributes, like "min", "max" (similar to min/max for type="number"), "range-maxdays", "range-input"
Shouldn't all the tests here be using the @pytest.mark.nondestructive mark?
If you just want a line break, I'd just use a `<br>` tag. It's a line break tag and that's what it's for.

Though you could also just wrap each section you want to be on its own line in a `<span>` and declare them blocks so they'd clear each other.

But in this case I honestly think a line-break tag -- as you're just adding a line break to a block of text that's all "address" is fine.
I don't propose that you add daily to the other jobs but to make the change above in the tinderbox pull request.
Hm, I see this is a for loop, not sure how to do it better with a while loop.
It just seems that there is no way to change $charset to UTF-8 if need be. Is there a way that I am not aware of? I am fetching some HTML from an UTF-8 page and returning a the contents of a div. Although later the default charset in the addHtmlContent function is UTF-8 it seems that it's being forced to ISO-8859-1 in the addContent function.
@ohadlevy, this is not necessary for validation if validations are off, but it is used to generate a the documentation (description) to tell the user that a dot(.) is allowable.

"Must be an identifier, string from 1 to 128 characters containing only alphanumeric characters, dot(.), space, underscore(_), hypen(-) with no leading or trailing space."
surely we don't need this one;)
> You mean this group: https://github.com/vim-jp?

Yes, but not all.

> Do you closely work together, or even know each other in person?

No. :)
I'm just an user of vim-localrc. :)

> (I'm German, but married to a Japanese woman, and been to Japan twice.)

Oh, you know japanese well :)

> I was surprised how quickly you (@mattn) picked up my pull request, although it was for @thinca 

I often talk to him about vim plugins. :)

vim-jp is working group that hope to make developer's network, and fix vim bugs, provide binary packages, writing blog entries, provide commonly plugins.
We discuss in japanese and send many patches to vim-dev.

http://vim-jp.org/
it is an abbreviation for "a3 user db" ;-) Fixed
Yes. pwnd by auto-complete...
[They are verbatim strings] (http://msdn.microsoft.com/en-us/library/362314fe.aspx). I just forgot and left that in... I'll also add the missing braces on the ``else``.
I'm not 100% in terms of rails controller action naming conventions but in order to be REST-ful you would have any creation operations (create, new) use POST. GET is used for read-only operations to be purely REST-ful.
So the comment is trying to say that: we used to have a "live" field, so life was simple. We don't any longer, so translate from the API format.

I haven't made any steps to change the forma of the API - would it be correct to take "state" rather than "live" in the API?
See __init__.py. there's a method, get() that handles these operations (constructing the url with params)
Use string interpolation? http://docs.python.org/2/library/stdtypes.html#string-formatting
this will throw if the file doesn't exist
Well, this change is the same as https://github.com/concrete5/concrete5/pull/671 and is not strictly associated to this pull request.
You must add a blank line before return.
yeah, one reason I like it because it can  highlight strange bugs from string typos sooner.  A NameError right out of the gate is guaranteed to raise on you if executed, vs. a string typo which might slip by.
there are two tests for this exceptions somewhere. i will "skip" them as they fail.
there is really no exception path in a sort method. thats the point.
it would be "Barbara Liskov"-unintuitive to fail here.
why is ['north'] hardcoded?
We could rename this to something more suggestive, item is too general.
The success/error should be handled in MessageComplete() and not in disconnect. One socket can be used for multiple requests when pipelining is performed. You can then delete this method and go back to just calling deleteLater().
Just an empty line
You probably want to use https://github.com/alienscience/cache-dot-clj for that (and, if you don't already, in other memoized / cached locations); it wraps a variety of solid strategies well, and delegates to some fancy-pants tools (like the ridiculously capable ehcache) if you really want to go all out and have, y'know, multi-machine distributed coherent caching or whatever.
`now` and `expiresAt` isn't used here.
Is the sentiment the same for the other `get*Param` methods below? I thought it was rather accurate, based on other frameworks I've worked with (e.g., I think OSGi had a utility for getStringProperty, getBooleanProperty etc... which worked similar to this).

I could be swayed with a suggestion, though.
We probably shouldn't require `file.name` to be set if we don't use it.
I think you don't need ``"T" -> Type`` (wild copy/paste? :-))
(promise!)
Same comment as above about formatting. I think it'd look nicer using this style:

    trans_args = {
        'blah': blah,
        'blah': { 
            'blah': blah,
     ...
Looks like you're behind on merging from master. Please update so we don't have things like this sneaking in.
Gebruiken we deze, of alleen horizontal platform?
почему константа static или почему определена в хедере?
Hi Andrey, removing the &nbsp; shouldn't be a problem.  However, i think it maybe better that we do a .html_safe on the tag it is calling thus change the &nbsp; to a space.
ExtensionString is just a std::string on the Mac and std::wstring on Windows. It would be easiest to set the initial value in the ShowSaveDialog function, since you need to set it to `""` on the mac and 'L""` on windows (for wide string).
Reviewer says: "this line was pretty good"
It's so deprecated, it's invisible!
Kunne vi sluppet å sjekke inn `spec/javascript/lib/bootstrap.js` og `spec/javascript/lib/require.js` hvis denne fila ble generert av en rake-task? Er litt fristet til å prøve å bli kvitt de.
We have ~2000 images in the site_media folders. We really don't want the extra traffic of indexing irrelevant images (especially the "sexyimages" ones). 
I could disallow the irrelevant images and javascript and leave everything else to be available fo indexing.
should be lh_vertno
wait I messed up
+1 for removing it, then.
use copy not return_copy. copy is used elsewhere to stay to work inplace.
I vote for hiding it for now, so I will remove it.
But wait, all is fine. If not preloaded no copy of self._data because it
doesn't exist.
else it in fact gets sliced to the events selected by the key. Where is the
issue?


On Thu, Dec 6, 2012 at 5:28 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> But this one is more difficult, I fear. If not preloaded, all is fine. If
> preloaded, what then? Additionally slice / reduce the data According to the
> key?
>
>
> On Thu, Dec 6, 2012 at 5:24 PM, Christian Brodbeck <
> notifications@github.com> wrote:
>
>> In mne/epochs.py:
>>
>> > @@ -463,19 +493,30 @@ def __repr__(self):
>> >      def __getitem__(self, key):
>> >          """Return an Epochs object with a subset of epochs
>> >          """
>> > -        if not self._bad_dropped:
>> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
>> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
>> > -
>> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
>> > -        epochs.events = np.atleast_2d(self.events[key])
>> > +        epochs = self.copy()
>>
>> You are still duplicating self._data
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2337111>.
>>
>>
>
>
good job in this test.

Please don't make the line too long. If it would be better to continue on a new line.
One cannot be sure of the results returned from this method due to the way the datasets are managed in this test class.  I need to know how to clear **just** the concept dictionary so that I can add a dataset to be used just with testing this method.
Is it still necessary for running it locally? As I recall, I had to add this to get the tests to run.
Not sure this belongs in `git_steps`. We won't be able to find this easily later on. `debug_steps` maybe?
This is a candidate for a helper or decorator.
Please add  since tag
missing validator ?
I don't know that, I will render it tomorrow on my own computer and check them all out, please wait merging this PR as long as I didn't test it.
I did consider doing just that, however, QUnit.log fires on every assertion. You can have a whole lot of assertions in your test, so if I were to use QUnit.log there could be a situation where the number of failures would be greater then the total number of tests. I could switch the counter to count the number of assertions instead of number of tests, but that counter would be populated much later in the process then it currently is. I will investigate a middle ground approach, where I will wire up QUnit.log and collect all stack traces, and then use testDone to dump then into testacular.
Плохо. Лучше добавь в каждый предыдущий енам макс-элемент, а в следующем отталкивайся от него.
Почему бы не хранить QSet<T> из тех, кто должен быть развернут, вместо QHash<T, bool>? Один фиг же.
strlen(srequest+1)? shouldn't it be (int)strlen(srequest)+1 Actually i'm surprise this compiles, but certainly it's a bug that can could introduce memory garbage on the message sent
please restore extralines
use multiline
I just discovered a critical bug! For rem units, if $base-font-size is not 16px, the line-height will not be correctly computed in establish-baseline, because on the html element 1rem is always 16px (the initial value). Right now 1rem is treated as if it were $base-font-size. I need to solve this before this can be pulled in.
In the merge into a new version could you please remove the extra space so that chunk lines up with chunkBytes please?
Restarting *sFINALLYul* ??
@anistor moved the validation to a separate method
I think Builder should be enough and improves readability leaving the interface with just one generic.
A suggestion for the future: if you're comparing for equality, using `AssertJUnit.assertEquals()` is more suited, because if the values vary, it'd also give you information about the value that is different.

This assert call will just say: true/false
@anistor I thought you wanted to move this comment?
I think Mircea's comment is really orthogonal to mine... he's concerned about the executor's lifecycle, I'm concerned that it's too hard for a user to determine whether an executor is appropriate here. CallerRunsPolicy and WithinThreadExecutor are just two concrete problematic scenarios that we've found, but I'm sure users will encounter others.
Headers should have Public visibility in the framework target.
You're right that it *should* but for some reason if I remove that the compiler complains of my usage of `_hunks` in the getter. I assumed clang bug and added the synthesis.
Yes, this was added as part of Python 2.7 (http://docs.python.org/dev/whatsnew/2.7.html#pep-3106-dictionary-views).
Already imported on line 67.
This is a bad break.  Make it two separate lines.
```python
filetypes['jpeg'] = 'Joint Photographic Experts Group'
filetypes['jpg'] = filetypes['jpeg']
```
Or use a temporary variable to hold the string.
A comment here would be nice. I think this is using a bisection method to find an optimum solution, but it would be nice if I had some confidence that that was the case.
"Uw conventies zullen..." in plaats van "Uw conventies zouden..." om document in toekomstige tegenwoordige tijd te houden.
Red is my favorite color.
Why are these hard-coded?
@arnodeclercq please remove the style changes in this file
Ah, I didn't catch this before.
please avoid the multiple ifdefs here: you can use the ifdef SWIGPYTHON in the NICE_DENSEFEATURES macro to do nothing or just define the macro to be empty.
Ok, cool, let me know when done so we can submit.
Are we using uppercase `Array` for this hinting? Looking at some code examples on php.net people simply just use `array` in lowercase.
shouldn't this be ordered by `sequence `?
no we just leave it nil, I'm just saying if you call is_experiment_enabled? but there's no enabled attribute set yet, it should simply return true or false (ie the default), doesn't have to set anything (or should not make a difference whether it sets this bool or not, bc the next time it's called it should return the same thing assuming you didn't explicitly set it in between).

and why would the db hold any other value? I guess we can put a check in set_experiment_enabled to make sure it's a bool being passed in.
Should this be in the same bullet point, rather than a new bullet point?
use windows types only for values passed to / return from win32 api calls.
Why doesn't getParameters either retrieve all parameters itself, or have an extra parameter to tell it to import more parameters?
I think more often than not, plugins use the @send operation rather than
@reply. When thinking about an IRC like chat room this makes sense, but in
the context of yammer, I think it doesn't play nice. I'd like to see the
response in its thread in yammer.
So one option is go and fix all the plugins that use send when they should
use reply. And another option is to adjust the semantics to the medium, in
this case I think this is the right thing for yammer.

On Thu, Oct 18, 2012 at 10:58 PM, Aurélien Thieriot <
notifications@github.com> wrote:

> In src/yammer.coffee:
>
> > - reply: (user,yamText) ->
> > -   @resolving_user_id user, (user_id) =>
> > -      if user_id
> > -         params =
> > -            body          : yamText
> > -            direct_to_id  : user_id
> > -
> > -         console.log "reply message to #{user} with text #{params.body}"
> > -         @create_message params
> > + send: (user, yamText) ->
> > +   if user && user.thread_id
> > +     @reply user, yamText
> > +   else
> > +     og_url = null
> > +     og_fetch = false
> > +     urls = yamText.match /\bhttps?:\/\/[^ ]+/
>
> Perfect
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/athieriot/hubot-yammer/pull/10/files#r1883485>.
>
>



-- 
/Ran
http://tavory.com
add data interval to the same title object
We don't really want to bring unnecessary attention to this, so I would not actually document it in away that shows up in the generate docs (or at all).
This is just an idea... to replace h1,h2,h3,h4, which often inherit things accidentally
you could use ``if`` instead of ``else if`` here. And all JS best practices I know of recommend using ``===``
right, did it on the spec and forgot to port it back here where it really matters.
currently you are forcing people to set url and port, the default value should be null.
Worth nothing that "quack like a hash" is on the roadmap for 2.0 (see #666)
For poor ignorants like me, maybe a comment on these overloaded methods to say that they're here so they'll be picked up by intellisense?
OK, I think it was only a warning anyway. Gem list says I'm on sinatra 1.3.1, for reference. I'll try and retest.
(OK, in this particular case it could work also "3 dni", but I am not sure how correct is that. :-) )
I deleted it in the next commit.
But you do have `div` around, class `content`. `main` is just a temporary class used for home page to hold some content currently.
as_expr is the method that Poly uses
Переименовать в addResources
Patch looks good. Curious: where did this routine come from?
Maybe we can also refer to the FAQ: http://www.packetfence.org/support/faqs/article/restrict-communications-in-registrationisolation-vlans.html

It explains briefly VLAN mapping in reg/isol.
this will still cause an issue if a user passes some other Reporter that is not Reporter.NULL.

Can you paste here how you are invoking getRecordReader()?
It was required because I had an object extending URI that didn't get its URL property set in the constructor. The URI class tripped over this pattern. This approach is much cleaner.
A button was discussed briefly, but I don't like the idea. Some times you want to see one or the other, sometimes you want to see both, but you don't want to press a button to do it.
That's a good idea.  It also cleans things up not to be expected to include the offending directive in the error message in ParseSetOptionsN.  Error messages now look like:

    nginx: [emerg] "pagespeed" directive "FileCachePath var/mod_pagespeed_cache": must start with a slash in /home/jefftk/nginx/conf/nginx.conf:23

Based on the config having:

    pagespeed FileCachePath var/mod_pagespeed_cache;
Done in aba611c.

We save a `Merge()` but not a `Clone()` because `NewCustomRewriteDriver(custom_options)` takes ownership of the options you pass it.
Wrong section, you are under "General tab" here but your checkbox should be in "connection tab"
fit and show some results.
а что ты имел в виду этим тестом?
Please comment a bit this value: describe how you can get your own, what are current settings of this custom search engine.
All @Ignores need an explanation, or to be removed.
RegistryError.errorCode is required per the DTD.  We shouldn't test this invalid case.  (In fact, you might even have the error extractor through some sort of error if it finds one - fail fast.)
(there's a tab at the start of this line that should be replaced w/ 4 spaces)
Hi Rachel,

Very good spot.  I've pushed a fix for this: 

https://github.com/GalSim-developers/GalSim/commit/6779021cb8f87ba64a7c56287d6c3b8bbc3ea936

I think that will work a lot better?
I chose to put the question ID as a query parameter, instead of in the URL, because it was tough to do reverse lookups otherwise.  It seems like we are doing that in a few other endpoints too.
Perhaps initialize in constructor (defaulting to `getClass().getSimpleName()+"-"+System.getProperty("user.name")`, rather than doing that on each call to create())
Do we really want a different groupId for sandbox?
I just checked in jclouds, and there sandbox does not do that.
This should be `NSInteger`.
s/will do/will perform/
On Mon, 24 Sep 2012, Hannes Magnusson wrote:

> > @@ -59,7 +59,7 @@ char *mongo_server_create_hash(mongo_server_def *server_def)
> >  }
> >  
> >  /* Split a hash back into its constituent parts */
> > -int mongo_server_split_hash(char *hash, char **host, int *port, char **database, char **username, int *pid)
> > +int mongo_server_split_hash(char *hash, char **host, int *port, char **database, char **username, char **auth_hash, int *pid)
> 
> This will conflict with https://github.com/mongodb/mongo-php-driver/pull/176

Yes it will - I'm sorry :-/
On Thu, 28 Jun 2012, Hannes Magnusson wrote:

> > +echo is_object($db) ? '1' : '0', "\n";
> > +
> > +$db = $m->selectDB(array('test'));
> > +echo is_object($db) ? '1' : '0', "\n";
> > +
> > +try {
> > +	$db = $m->selectDB(NULL);
> > +} catch(Exception $e) {
> > +	echo $e->getMessage() . ".\n";
> > +}
> > +
> > +$db = $m->selectDB(new stdClass);
> > +echo is_object($db) ? '1' : '0', "\n";
> > +?>
> > +--EXPECTF--
> > +Warning: Mongo::selectDB() expects exactly 1 parameter, 0 given in %s/mongo-selectdb_error.php on line 3
> 
> %s/filename doesn't work on windows...
> It should be %smongo-selectdb_error.php

Argh, that slipped my scrutiny. I doubt any of the tests really work on 
windows anyway... have you tested? :)

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
This can get rather slow in organizations with a large number of roles.  Since we already have all possible nodes from a previous search (line 70), we should simply process that list using Ruby rather than searching inside a loop like this.
Will this complain if the `merge_branch` has already been checked out? Or will this just force it?

For example:

```
$ mergerequests master daily_build/2012-05-09 1250
$ git checkout master
$ mergerequests master daily_build/2012-05-09 1251
```
3cacddebccae668a815241e7e9dc542e0f2f36bf
Сторінки в портфоліо розбиваються по 6 проектів на сторінку. В абстрактному классі тести підлаштовані під 3 сторінки. В цій фікстурі вставляється 2 проекта поза циклом. Змінив цикл під умову 18 / 6
Why do we need unique=True?  It causes a problem with MySQL which won't allow unique indexes on fields with max_length>255.  Perhaps we can solve the problem by storing a hash of the slug and making that unique.
This is my code and the header is just a copy from an other file.

Note that we should probably fix the `@since` and the other stuff @stof has mentioned before merging if you decide to do so.
Let's make this a separate patch!
kind of seems like its just testing if the URL is formatted correctly
Не по "ГОСТу" название. Аббревиатуры пишутся так же, как и обычные слова -- EolnNormalized...
Если пользователь введёт слишком большое число, надо ему об этом писать.
И выполнение продолжится?
Массив boolean для ключей?! Так не пойдёт, по коду надо понимать, что делается.
Consider refactoring this code (which is identicial to the lines in 539-546) into a "createCopyBlobResult" helper method.
this locator is not used
removing it
Can you please add the copyright header here?  You can just copy and paste from one of the other classes in this package.
I don't think we need this comment here and in all other files.
I think including which target-vector ``k`` causes the warning could be useful.
nice catch ...
@pprett proposed https://github.com/ndawe/scikit-learn/pull/11 to fix that. I guess you can already merge that in if you want to.
note this PR doesnt yet actually use the locales, but it could be used f.e. in the Router or inside the Admin UI
I'm also not sure why is a "|" character in the URL part of the regexp
    (.*[^ \t]|)
because it's not it any of the examples
OK change it.  This is required on Portal Coding StyleCop
What's this {{{$post}}} value from?
Fix the indentation.. you dropped a level of nesting by removing the if.
I prefer that they not be reimplemented in inherited classes in the first place.  Can you remove them, this way when dave's work is complete it should just work and not require any rework
url property is relative to current folder. Won't work this way for relative paths.
In the commit you changed rsPropName to ResetPropName. I think you may need to change it in this section of the code too.
In this case, it should return empty array.
if isItem(i) returns false then it's also a corrupt superfile....
`localTransfer` can still be named plain `xfer.hg`, so this line could be reverted.
@peterbe not sure what you mean by "protects it from running"; it's basically a switch/case but with if/elif.
This supposed to work.
Missing break; after this line? (spotted by Gabriel403)
As ``false`` is the error condition, I think it should use an exception.
Can you delete the spaces contained in the parenthesis?
the ``implements`` part is useless as the parent class already implements it
I suspect you don't need to specify window, but instead can just do:

open: {
   path: ...
}

on the top-layer
please use css path
@christianv Yep, per discussion, we're deciding to streamline all JSON feeds, even if they're not being mashed with others. See latest commit.
So if I understand correctly, target="_self" will force a full page reload. But I'm not clear why we want to do this here.
This is incorrect. No points.
Indenting like this makes lets easier to read

~~~clojure
(let [[rect1 rect2] rectangel
        [x1 y1] rect1
        [x2 y2] rect2
        [x y] point]
  ...)
~~~
I'm sure they're initialized elsewhere, but it does look weird to have filterType and localeHelper uninitialized after the constructor.
error.join.chomp
but if the order is irrelevant, why do you have to change it in the test fixture ?
Once, again, you should use the static versions in cas these properties are not Cartesian3 instances.
Putting an algorithm in controller?
Service Bus Namespaces / Storage Accounts would also be nice.
K, that makes sense

On Wed, Aug 8, 2012 at 1:21 AM, pingwang2011 <notifications@github.com>wrote:

> In
> android/modules/ui/src/java/ti/modules/titanium/ui/ActivityIndicatorProxy.java:
>
> >  		return table;
> >  	}
> >
> >  	@Override
> > -	public TiUIView createView(Activity activity)
> > +	protected void handleShow(KrollDict options)
>
> Activity Indicator is a normal view now but it's a little special because
> by default it's hidden. So we need to handle a special case that we call
> activityIndicator.show() before the window is completely opened (note:
> window.open() is async). For example, in app.js, we have something like:
> var win = xxx;
> var activityIndicator = xxx;
> win.add(activityIndicator);
> win.open();
> activityIndicator.show();
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/appcelerator/titanium_mobile/pull/2693/files#r1327700>.
>
>
The define() callback function needs to return "api".
We should avoid multiple declarations per line according to our coding standards.
addressed in the next update
This solution should not work for the reason mentioned in the comment.  We support back to the 2.2 API level so another solution must be implemented.  Put a TODO in place for API lvl 12 so that we come back to simplify things down the road.  Perhaps you can implement a similar solution using getNumber or getUnicodeChar which are both API level 1 API points.
Need to make Ti.Platform a dependent.
Can you put more arguments per line?
Can you handle them? 
If so, remove todo
if not, document it (or fix it)
Ok, great advice @lonvia. I got a bit confused when looking at the code, although there are some comments I think the documentation could have been better :-) As in all software projects I guess :-)
missing verb in the message
Not at all. Let me revert that. Not sure how that got in there.
I don't get this comment. Is it relevant here?
Хм, ну вот возможно я гоню, но смотри есть событие `click`, которое явно генерируется как просто `click`. Я могу подписаться с тегом `.on('click.myTag', lalala)`, и потом отписать свой обработчик `.off('click.myTag')`. Или сразу все свои обработчики, если я подписывался не только на `click` : `.on('click.foo')`, `.on('lick.foo')`, `.off('.foo')`.

А генерируются всегда чистые. И если наоборот генерировать `.trigger('lick.foo')`, то потом нельзя будет отписаться `.off('.foo')` — это не сработает.
а кто же его удаляет?
This method aspect a string in format model.field (ex: User.id) so **for me** modelName is "User" modelField is "id".
There is a docblock that explains what you should go to method, so there is no problem, I will do as you say.