labofsahil/github-event-dataset-2012 huggingface dataset:
It looks like the jar on clojars doesn't reflect this change.  Could you please push an update to clojars?
uhmm... good thoughts.

about

    protocol_start = ProtocolStart.objects.create(name="blah blah")

is there any way we can refer to its parent? I'd think something like

   protocol_start = ProtocolStart.objects.create(name="blah blah", protocol=Project.objects.get(name="parent_protocol"))

where ProtocolStart has a relationship with the main Protocol table. 

Also, let the integer field that you will add be known as ```order```
     ProtocolStart(Model):
         ... #some stuff
         order = models.IntegerField(null=False)

#Thoughts
I think we are about to nail the model. Is it running properly in your test environment? Are you able to run ```python manage.py shell_plus```?
test it then, i really cant say if it will help your problem
I think there should not have a difference between behavior with id or with index. Why do not use a IdOutOfSetException else ??
Behavior of removeNode(*) should return the node when really removing it, return null if node not found and strict disabled, or raises an ElementNotFoundException if node not found and strict mode enabled.
One behavior by method should bring some confusion.
We maybe need to discuss this point with the whole team !
FWIW, this patch is not on gerrit (that I can find).
How does this work if you pass in an array?
This is how I run them using jenkins:
```
if [ $django_version = 'trunk' ]; then
    pip install -e git+https://github.com/django/django/@master#egg=django
else
    pip install django==$django_version
fi
pip install -r tests/requirements.pip
python tests/manage.py jenkins
```

This should suffice:
```python tests/manage.py test```
Ooh, ik had niet door dat het op een branch stond.  Mijn excuses.

Trouwens: jaargroepen met hun e-maillijsten gaan nu ook fout.  Bijvoorbeeld leden hernoemen naar internen zou niet werken.
I tried :image_name.:format but it didn't work
I believe the TODO is wrong. The next sibling is always an element in this case because it's a 'copy' of the container (not a deep one, just the same tag with almost the same attributes) created by splitting the container in two.

If the container is a paragraph then the next sibling (the 'copy') is also a paragraph. The reason I'm replacing a paragraph with another paragraph is just to keep the code generic like in Line plugin: the same code will work for instance if the container is a heading (pressing Enter in a heading generates a new paragraph).
Additions are correct. The rest look like articles that just need to be purged (the cache is stale).

ATTACH_(LEFT|RIGHT)_PEC should not be 40.
don't you wanna remove `patch` method from real `$http` as well ?
Otherwise LGTM.
Fixes #3282 (typo)
A small correction that changes 17000 lines!!!!!
It's DOS line endings again.....these are a pain to kill when they get onto linux computers.
Yes, I think we want `module.controller()` so that it's consistent with other apis.

Btw, having this as a separate service, might be useful, consider this idea (for DFA, based on Closure's inheritance):
You override the `$controller` service, which implementation, that inject not only `$scope`, but `parentConstructor` as well....

````javascript
// pseudocode of parentConstructor
var Cls, scope, opt_args
var parentConstructor = Class.superClass_ ? function(instance, opt_parentArgs) {
    $injector.invoke(Class.superClass_.constructor, instance, extend({$scope: scope}, opt_args, opt_parentArgs));
} : noop;
````

Which means, instead of asking for `$injector` and invoking parent constructor, along with passing the scope... You would do just call `parentConstructor(this, opt_otherArgsToInject)`
It does say for `uses` that " each line should list only one class".  Is that what you mean?
Is this overridden at boot in production?
plz giv me patch for gunship battle
It could possibly be CORS related as tiddlywiki.com is NOT CORS enabled.
I like your proposal :)

-----
Maybe could move `if(control.title!=""){element.title=control.title;}` to `createControlMarkup`, thinking of separating the appearance of the control and the button that represents it.
use tokenMap.contains with ? it looks better than a null check
Can you merge this to master?
Er what is this?
`closeManager` isn't exported, and has the exact intention that it cannot be reused. I think the one issue is that any existing connection may try to put their `ConnInfo`s back into it, in which case we need to have something more substantial than just putting an `error` in there (unless we do some exception catching as well).

How's this:

* Add a new record `mIsOpen :: IORef Bool`
* At the beginning of `closeManager`, switch it to `False`
* Whenever trying to replace a connection, first check if it's still open.
* Adding `clearManager` is an orthogonal discussion, which I'm not sure is really necessary (we have the reaper running after all).
* If we make the change to `TVar` (most likely will happen) change `IORef` to `TVar`
Yay, awesome :D
Are you planning on adding something like in those comments?
https://github.com/Bukkit/Bukkit/commit/ec2ccae9793b00aa9b93a536c57268dc44dfd23a#commitcomment-869579
missing ``private $em``
Ah you mean private as from the package name _impl_ ?
Yes I can remove the deprecation and make the ctor private if you prefer.
I doubt this file is actually needed. Is it?
Nice one. I think the urlpattern needs to have a separate name though. It can still point to the same view just how you have it.
That said -- I hate having to bring back the old implementation in an `if/else` branch. Got a clever way to refactor it away?
Does this ever hit in normal circumstances? Would it OK to use __atttribute__(aligned(...)) when available on the memory view structs to disable this check? (I would imagine that in the circumstances where an atomic increment is possible, it would also be possible to ensure that the integers are always aligned...)
I tried but none worked except my workaround.
Sorry I thought ?0 was broken and now isn't
Не пиши просто "should new". дескріпшн повинен бути більшь описовим, краще напигв щось типу "should initialize instance variable user" or "sets @user" шо ще простіше і зрозуміло.
It's: 
MSG_READY_CHECK = 0x584E                       // cmsg and smsg different structs in client
SMSG_READY_CHECK_CONFIRM = 0x9857,    // only smsg found in client
MSG_READY_CHECK_FINISHED = 0xCE67,     // cmsg and smsg different structs in client
SMSG_READY_CHECK_ERROR = 0x4C46,      // only smsg found in client
NB: deliberately remove use of @masterGlobalMemorySize ,
in favour of just single common @globalMemorySize

@masterGlobalMemorySize has never been used and don't think particularly useful to distinguish.
Closes #4526
why not with AccountMgr::IsModeratorAccount(GetSecurity()) ?
There is no standard necessary.
In Line 347 HOSTNAME is defined anyway.
  347 HOSTNAME=`uname -n`
All that is done by this patch is to reduce the number of syscalls:)

Regards
Erkan
@paulmillr: see the `i` flag 2 lines below
You are right. A doc string on the class does not hurt ;) Writing some documentation with examples is on my TODO list (see PLIP).
Num Num Nums. This will do. :-p
Added to MyTardis master as of mytardis/mytardis@4afc3004c974269a0deab369ca7f0f7862c32b2e.
Wirklich hübsch ist das ja aber auch nicht ;)
Please can you look to this comments from your another project? https://github.com/Venugh/TrinityCore/commit/258799483ffc127376f60442e8891633be02efe6#comments it is crashing ... I am testing it now thx :)
Done: cb3350df4cd5980a42bbb1750971b66c4a351e8d.

I did a push and the commit shows up, but it doesn't seem to show up in the master branch on Github.
Sweet, I was just about to let you guys know about the :contains bug and then noticed you updated last night, definitely made my day! :)
`.innerText` fails on firefox and it's weird if your DOM-shim emulates `innerText` since it's not part of the DOM.
oh man,

you checked in tons of generated files and you lost the commit history by doing it this way.
Webmachine requires adapter for you. You are having this problem because you require 'webmachine/adapters/rack' before you require webmachine itself.
We will install tarball contents under `/usr/local/phantomjs` and symlink `/usr/local/bin/phantomjs` to `/usr/local/phantomjs/bin/phantomjs` (or whatever the exact location is).
This means responding to OPTIONS with special headers, right?
I'd probably use FILTER_UNSAFE_RAW for passwords because we don't want to strip any characters from a user's password.
ok, a ver si mañana puedo actualizar /señalar Walkum /pasarMarron JAJAJAJAJAJ
[!] Might cause problems.
Well I have added a hex arrangement to the squares (now each well has six neighbors)... easy enough and doesn't make the well generators crazy to write. :-)
it's going away, it's just there as a placeholder as I roll in support for Uint8Array
Did you forgot to update the version number before releasing the new version...?
I did indeed. I always forget about the plugins.
These selectors are not in alphabetical order.
ok. I will change it
Ah, git fail.  Thanks for the quick corrections.
So it's a bit expensive to do the reflection on every request like this.  It would be preferable to cache this.  Additionally, I wouldn't do it with a filter - I would likely want to do this at BootStrap
See the commit I.just submitted :)
Ah yeah, you told me that before. Ok. I just noticed cause I it wasnt resizing my 1920x1200 desktop images :)
Darn.. was that really it. Thats what I did but I thought it cant be all there is too it... hahaha
@simon-weber What are your thoughts on this? My previous method of returning tracks was [as a class](https://github.com/dpogue/gmusic-daap/blob/master/googlebackend.py#L79-134) but that runs into issues when the two APIs return different key names.

I'm also not sure how much responsibility you wanted the API to have over the data compared to the user. Right now it's up to the user to parse/store the track dictionaries.
The last pikachoose is 4.4.4. please fix this
Wyclif--this test fails with a NPE when run against OpenMRS 1.8 and above... I'm guessing it has something to do with the change in the way getPreferredName works... it is conceivable that could be a trunk bug.

Can you take a look? Thanks.
If you have time, you can take a look at the markdown syntax http://github.github.com/github-flavored-markdown/ to format this file better :)
Let' continue a party. Does your autocmplete library can handle three autocompleted fileds on one page? Seems it's impossible in current implementation.
OK so my understanding is that I merge this doc change.
Ok, good start. Waiting for the rest :)
You don't need to setup the PathInfo for this script, since you're going to be doing any walking.
This still looks like the elasticache version. Would be swell to link to the docs page for the request, for people who want more info
Is the Quartz dependency used in the management app?
we really shouldn't throw illegal argument exception?  If this is an AJAX call, it should somehow set the status code for bad input
I know, but my point is that it doesn't always protect against that. I think you should throw exc as suggested by Björn.
ok, will do, maintainAddressTerminatedSubscription has an optimization check on a, so it wasn't waay, just way
This is a constant as well, could be a "val".
hey, this looks a lot like sample_ball...
if it ends in ? it should return true or false, right?  so "!!" ?
I'd refactor this a little for clarity.
if source and destination directory match exactly
=> build error
if OS is linux (or should you use the casesensitive attribute on the fileset)
=> use Directory.Move
if source and destination directory match when case is ignored
=> use staged move
otherwise
=> use Directory.Move

Ensure you have (platform specific) tests for this.
I don't see any mention of this in the task docs, but could be wrong.
From what type of files?
I thought context['user'] and context['userobj'] would both always be the requesting user (if logged in), because  they're put there by CKAN not by the user? If that's not right then this auth function should be fixed yeah
Give field name for internationalized strings
Incorrect docstring, the return type is a list.
Same mistake as above.
interesting.  closing and opening is necessary?  can't we do SmartName.lookup = self or some variant?
Looks like there will be trouble if the sample size ever is larger than then hardcoded BUFFER_SIZE, maybe allocate the m_pcmBuffer size as a multiple of GetMaxOutputSampleSize() ie m_dmaxwritebuffer?
The info seems available in the correct order in Init()
make that N330 pretend it's a single core with no HT and you should see any issues :)
(make test)++ yay!
Identation problem that needs fixing.
Ok, you're right, I've just looked at the method.
Yes, true. Which one do you prefer? I will use that one, and purge the  
others.
Probably, this was more intended as a warning for future developers when new Twig_{Function,Filter}_* classes are added. Will remove it.
@franzliedke solved in https://github.com/fluxbb/core/pull/7
Shouldn't this rather be `TITLE_FILE`?
Ahhh...

So the really nasty but slightly less hacky way to do this:

```objc
#ifndef __clang_analyzer__
// stuff that confuses the analyzer
#endif
```
`_controlFlags.tracking` can't be `NO` here, by definition (see the outer `if` statement).
Maybe support optional whitespace, so that `spark-cluster[1, 1, 1014]` works.
Ok. Could you please commit these tests?
I think it might be better to retrieve the title directly from the existing columns (e.g. the opposite of line 171), immediately after the get_sort_column_id().
Je comprends pas pourquoi tu as commenté le fichier. Pourquoi ne pas le supprimer si tu es pour le commenter au complet?
Decremented .
Implement this ?
This error-checking took me a moment to puzzle out. I'd prefer the slightly-longer:
```
if (mit == NULL) {
    return NULL;
}
Bind(mit, a)
Reset(mit);
return mit;
```
* @require ...

dependency missing in file header.
These three lines can be replaced by `RETURN_STRING(id, 0)`. The `0` means that the string won't be duplicated, so PHP will take care of freeing it.
Sorry, my mistake - I just looked at the string above and didn't notice that you were actually doing the call with ``qiime_system_call``.
лишний сдвиг — два таба
Ну, это комментарий такой :)
скобочек не хватает
Wow that's the last time I user the github editor for anything that isn't a readme. By all means we can squash. Can we pull it do it on your end? I don't have access to my work computer atm.
Just a detail but there are two spaces just after the  dot (even on the line 605). :)
There's an extra space at the end of the regexp :)
I think this test shouldn't be killed, should it?
It's not clear to me that there's any performance cost at all. Actually I'll make a stronger statement and say this figures to be faster, because decomposing the data and having it all in one place will create easy opportunities to avoid re-performing the same work. It's not like an allocation of "case class Tuple3" is any cheaper than "case class Applied", and Applied also wins by virtue of offering exact argument types rather than T1, T2, T3. The couple of kilobyte bytecode cost of having an additional class is lost in the noise.
I can't actually say with much confidence anymore what I should expect when, because of reflection - but as far as the compiler goes, that's right, @volatile here is not going to be relevant.
I'm very sorry for my wrong and confusing "Going to take some time to study" (was sleepy). In this situation name is never NO_NAME in related tests, it is symbol that is NoSymbol (which is frequent case for selects (e.g. if they are created by name, not by sym, or if their sym was erased)), and sym.name that is NO_NAME. And when sym is NoSymbol, then sym.name is NO_NAME, and we should do reifyProduct(tree), because nothing is renamed. When we remove sym == NoSymbol, then cases when sym is, are end in reifyProduct(Select(qual, sym.name)), where Select with NO_NAME is thus created.
I didn't find that one. I'll see if I can generate variations on the test to motivate it, but even if I can't it looks preferable.
I agree that fixArguments is the worst part of this code. I've felt that way since I wrote it. Your simplifications will be taken into account.  I'm also thinking that I should memoize it because it's kind of complicated and it's called rather a lot.
On second thought I think andThen should not be there. We don't have any precedent for this kind of duplication, right?
I remember EmbeddedControls.scala is used in scala-virtualized, better also ping @adriaanm of this change!
this is for 64bit systems - like mine
Not sure I agree with this change.

First off, I'd admit that I haven't heard of or seen anybody using the `Activator` class outside of using it for promotions. That doesn't mean that nobody's using it.

I'm fine with making the change and seeing who complains... but on the other hand, I don't like making people complain. It's a tough choice.
it seems like this should be called `set_sort_key`
To both questions: because I do not know how exactly the original code works.  This seems like the simplest step-by-step approach to me (obviously I may be quite wrong). At the moment for the definition for a constant used by all the original code is "starts with a C and ends in a number". I have just filtered that out just before calling `return`. At some point the internals should be updated to actually use this.

If this is the most serious blocker it would be nice to point it out in the description of the pull request and maybe open an issue for it. The pull request can just stay open until I can focus on this instead of the `diffgeom` stuff.
1. Yep, done.
2. Oh yeah, this function needed this refactoring very badly, apparently.  After I have split it up, the code has become much shorter and clearer, even to myself :-)

I do know that large functions are bad smelling code, and I believe that I avoided such ugly style in my later work.
On the PHP documentation this is not mentioned at all - http://php.net/manual/en/function.create-function.php
In such layout test looks inconsistent: classes "NewComponent", "NewBehavior", "NewBeforeValidateBehavior" and "NewFormModel" are placed in separated files and included to the test, while "BehaviorTestController" and "TestBehavior" are declared inline.
Some server configuration may not allow you to chmod or perform other file operations. Even if you know the reason, there's no way to fix them (because you don't have control of the server). Other than using @, I don't know other better solutions. With @, at   least you have the option of changing error reporting flag so that the error is not inhibited by @.
Please mark overridden methods with @Override
I think this is a good idea. Maybe would be a little simpler with:

max_values_len = max_values_len if max_values_len else 10
sample_values = list(islice(iterable, 0, max_values_len))
has_more = True if list(islice(iterable, max_values_len, max_values_len+1)) else False
if has_more:
    raise AssertionError( message with elements )
elif sample_values:
    raise AssertionError( message with first N elements )

Also you do not use "message" parameter, guess it should print given message and do this if user didn't provide a message already.
len(link_list)==0 ---> len(link_list) == 0
this would be faster, and more cleanly indented, if the anonymous functions were defined outside the iteration
You also need to keep the current check to be sure that there is at least one element in the array.
Changed to follow your style.
И тесты конечно же напиши, о которых я тебе говорил
Use our log. By the way, if you are missing some functionality, please contact me/Yaron we will fix this.
Let's reserve ````SecurityTransgression```` for user initiated security errors in the controllers only.  Here, the caller would have to be code we've written (in the controllers or other models).  Let's use ````IllegalState```` instead (already defined in ````lib/exceptions.rb````.
would love if there was a more efficient way to do this down in C via ruby-core...
change to "a Date value was"  to match "as an unsigned integer".
nit: be consistent with `foo: bar` vs. `foo : bar`
Default to `$acm_type` instead of `'phpbb_cache_driver_file'`.
doesnt generate_text_for_display() do the bbcode_nl2br() ?
Curly bracket on new line
Should be fixed by this commit: 81a1a211
IIRC the brace should be on the same line as `function ($key)`, but I can't find any reference of that so perhaps a dev can shine some light on this.
I've seen if()'s broken up across lines in other code sections, and it greatly helps with readability (don't need to scroll horizontally), so I'm okay with this.
c7c9a67
@padolsey please add his MIT License note to our LICENSE file.
Yeah, you could totally set it to false after the server starts, I just changed the things needed to make 3.5.1 run, I know little to nothing about what Mojito is doing under the hood ;)
Сории что долго не отвечал. Вот примерная структура бд

```
Нода пишет в эту и только в эту таблицу
CREATE TABLE `statistics` (
  `date` date NOT NULL,
  `unit_name` varchar(140) CHARACTER SET utf8 NOT NULL,
  `shows` int(11) NOT NULL,
  `clicks` int(11) NOT NULL,
  UNIQUE KEY `date_name` (`date`,`unit_name`),
  KEY `unit_name` (`unit_name`),
  CONSTRAINT `statistics_ibfk_1` FOREIGN KEY (`unit_name`) REFERENCES `unit` (`unit_name`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;


CREATE TABLE `statistics_cache` (
  `unit_name` varchar(140) CHARACTER SET utf8 NOT NULL,
  `date` date NOT NULL,              -- Это дата последнего подсчета кеша
  `shows` int(11) NOT NULL,
  KEY `unit_name` (`unit_name`),
  CONSTRAINT `statistics_cache_ibfk_1` FOREIGN KEY (`unit_name`) REFERENCES `unit` (`unit_name`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

Отсюда нода читает данные
CREATE TABLE `unit` (
  `unit_name` varchar(140) NOT NULL,
  `type` enum('image','html') NOT NULL,
  `title` varchar(255) NOT NULL,
  `weight` int(11) NOT NULL DEFAULT '1',
  `link` varchar(512) NOT NULL,
  `status` enum('active','delete','inactive') NOT NULL,
  `image_url` varchar(512) DEFAULT NULL,
  `html` text,
  `constraint_show` int(11) NOT NULL,    -- Ограничение по показам
  PRIMARY KEY (`unit_name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

```

И сам крон для деакстивации баннеров

```
CREATE DEFINER=`root`@`localhost` EVENT `units_inactivation` ON SCHEDULE EVERY 5 MINUTE STARTS '2012-11-17 05:00:32' ON COMPLETION NOT PRESERVE ENABLE DO update unit left join statistics_cache on unit.unit_name = statistics_cache.unit_name set status = 'inactive'
where constraint_show <= ifnull(statistics_cache.shows, 0) + (select sum(shows) from statistics where date > ifnull(statistics_cache.date, '1000-01-01'))
and status = 'active';;
```

Я решил сделать крон прямо в базе, на ивентах. Так будет намного проще. И он выполняет тот запрос, про который ты спрашивал - для всех баннеров проверяет статус. Обрати внимание: используется ifnull для того, чтобы скрипт правильно работал когда в кеше статистики нет записи, соответствующей баннеру. Плюс, испольуется sum(shows) на случай если кеш статистики не будет отставать на один или несколько дней.

Ещё нужно будет дописать событие для генерации кеша статистики и работу с ограничениями по кликам.
are  you sure about this line - i seem to remember recently chaning it to cast to (array) as laster on we presume it is an array
Yes, it's working :)
Would it make sense to have the searchQuery as part of this representation? How useful is only knowing the name and description? We won't be able to see what date the patientlist is for and what the encounterType is.
I think this function can be removed completely in the future (and cartopy functionality be used instead). Not for this PR though.
On two lines for readability
I guess I don't understand why it's passed in, but always true. Either don't have the param or don't ignore it. It's confusing as is.
How much does this test overlap with other planner tests? Can we share the test cases between the base planner tests and the ad-hoc tests with some abstraction?
The comment above claims partitionToUse can be null -- are we relying on the NPE here?
It would be slightly cleaner to pass the verbspace into _create_package and let it extract verbspace.name, verbspace.version, and verbspace.description.
maybe use keyword arguments for better readibility
Indentation looks incorrect here
So the way this test works isn't obvious. I now get that this SubMaterial get's added to the static material list, then the decay function is called at the given interval. Could you push some documentation? What's not clear is that it gets added to the list and is therefore "part" of the simulation at that point. 

I think this is a good reason why we should move that out of the constructor. There are times when (given our current system) you make a material object to simply provide a transaction request. There's no reason for that to material to be decayed. 

In any case, this implementation isn't a pull-stopper, but I'd like to see some sort of documentation on how this test is expected to work (for the reasons given above - it's not easy to tell at first/second glance).
the return value here needs some units.
To make my life easier, can we change this back to how it was

Mostly for coding standards which are in place, and there being no real reason to call multiple import statements since they're the same module.
There is too much of those is the source :
FetchMode is the vocabulary used for the public interface, so we can't change it,
and FetchStyle is the vocabulary used internally, and there are too many occurences.
see grep fetchstyle lib/Doctrine/DBAL/ -Ri
This documentation suffers from the opposite problem – it doesn't explicitly clarify that `nil` is handled.
That's the code from https://github.com/haf/gollum/blob/feature/gitcode/templates/helper_wiki.rb

If lambda has 1.8.7 issues then it'll have to be replaced.
Even if the test cannot pass for now, should still add the assertions and expectations
Why did this move to after the manipulation?
Is there an issue we can reference here?
As a doxygen format, this is unreadable.   You'll need pre or verbatim or something.
Also wonder why you don't use operators but functions.
Think you can just disregard this, I hadn't taken the spotify playlist name → uri flow into mind.
Jinja is a little weird and defines `none` (lowercase) as the test for `None`:

```jinja
{% if days is none %}
```

This is really what you want here, I think.
If find them in `Cellar/omniorb/4.1.6/src/lib/lib/python2.7/site-packages` after installing, so the last part of the directory is already fine. Perhaps just setting `"--prefix=#{prefix}"` will do the trick. Then, in the brew link step, they get linked correctly.
Need a dep on automake for at least Xcode 4.3, and potentially all platforms depending on the outcome of #10824 (which may also make this line unnecessary if we decide to dupe everywhere).
Should we take into account the odd case that somebody names their first layer 'data02'? Say, use `name = "data%02d"%n` and increment `n` as long as `data in self.data`?
I'll give that a try - THX
remet le quand même ;) c'est pas top mais ça doit être dans la version "que l'on prevoie de distribuer "
There's only a difference for old-style classes. Switching to `type()` for nice-looking-ness.
А что смущает? Согласно словарю Ожегова «восстановить — привести в прежнее состояние».
Исходный вариант примерно так и звучал: «вернуть сервер в то состояние, в котором он находился ...».
This probably won't occur, but good call adding it just in case.
Ich denke hier sollten wir de_DE nehmen, das wird wohl am haeufigsten gebraucht
@gharlan bin die ganze zeit am überlegen, ob wir es auch bei getConfig() bzw. rex_config hinbekommen, bzw. ob es sinn machen würde, auch dort diese typecast geschichte einzubauen (wie in rex_request)
Why not `"scalaz.scalacheck.*` ?
Yeah I think a lot of these tests could/should be refactored, but I tried only to alter the logic of the ones that actually broke as a result of switching to VCR.
stringified? you can just say "Returns a type name". No need to make up words!
You're absolutely right, I did some tests to verify that. Re-adding that method (I seem to recall I deleted it because I had some trouble getting the right methods to be called, but that problem isn't there any more, so..)
Sure. I can take that out.
I'd recommend calling these `*_activities` so we don't have two forms of the word running around to confuse people. Nesting like `activities/*` might be cool, but I don't know if the harness supports that kind of thing.
Just making `commitColor()` public might be a good step to take right now since we already call it from the outside (in InlineColorEditor).
Similar to the function name, I find this prefs key easy to misread as applying to the _current_ version only.  Maybe rename to something like "allVersionsInfo"?
update comment for return value
Nit: "if the bookmark still exists _and_ color becomes invalid"

(can fix this in a later pull request's commit if you want)
We now have strings for lines 1, 3, & 4. Should these be re-numbered to 1, 2, & 3?
You shouldn't use `parseInt()` here since jQuery's `width()` function returns the width as a number (of pixels). It's probably working because JS is coercing the number to a string, and then you're converting it back.

(`css('width')` returns the actual computed style value, which would include the units abbreviation.)
Should use the KeyEvent.* constants
So, two things:

1) It's entirely possible the whole 'more_tables' loop doesn't fire for a single query in our codebase. It's for queries of the form `SELECT * FROM a, b, ...`, which we basically never do.

2) The TABLE_MATCH regex will actually be pretty fast. If you look at how the state machine will compile, it looks for 8 different characters, and filters non-matches out pretty quickly, doing capture groups only after keywords where we're guaranteed a match. It'll be a surprisingly speedy regex.
mmmm, ok
since cfg.py has this logic and its also settable in the config I called it good. true the assert wont hurt.
I don't see anything wrong with this code here, although replacing zeros with 1e-4 in the covariance matrix might make the Cholesky decomposition unstable. How does it blow up?
The C comma is a strange beast.
Not always? You are allowing both `date` and `datetime`:

```
if self.upper_limit and not isinstance(self.upper_limit, (datetime.datetime, datetime.date)):
```
I don't know if that makes much sense since they're essentially logged out only from our site - not facebook. A message like "You have been logged out of facebook" would make no sense, since they wouldn't be logged out of facebook (they can still go on facebook and do w/e) but only from our site that is linked to facebook. I don't think the distinction is necessary.
Please freeze the version.
Can you do keyword-based string interpolation?
Remove the console.log please.
What was the conclusion about Dave's comment?
namePrefix is the only one that's common, so yes to that one.  I don't it for root, nameSuffix, etc.
loading_error_message instead of err_message?
这里也需要相应修改下，?imagePreview/xxx 接口已经废弃了，新版图像处理就只有 ?imageView 跟 ?imageMogr
http://docs.qiniutek.com/v3/api/foimg/
I think there's retry=0 statement missing. As I understand from MBDOC48.pdf and your multitelegram case, there could possibly be 3 retries for each "send-receive" transaction.
ugh, this indentation issue is fixed with commit 22b2372. Is it possible to include that in this pull?
超过了80列
Eikö tähän löydy valmis metodi standardikirjastosta, joka tekee halutun asian? Jos ei ole haluttua, niin voisi olla privaatti metodi getPostDate() tjsp, mitä tuo nyt tekeekään, sillä se kutsu kertoo paremmin mistä on kyse.

Kannattaa myös miettiä, jos välität tässä jotain muuta tietotyyppiä kuin Stringin ja sitten käyttävä osa muuttaisi sen tarvittaessa Stringiksi.
I don't think that the ALT attribs here serve any purpose.  The w3c might try to mandate them, but here they're useless and will only serve to make the site even more confusing than it already is for anyone using lynx.
How does this check work in regards to internal product names?
mmm, I think it is completely misleading unless you treated as an exception. Setting the message in the exception code.
I have some javascript code for that if needed. I need to find it on one of my old machine but I have wrote that for png/jpeg/gif a few years ago.
You would need to `uninit` the `jsonStorage` after the data has been populate to indexedDBStorage, before calling the callback.
if (!this.sliding)
      return;
I think this (and below) should now be ``format``, and the default is ``'57d17m44.80625s'``
I suggestion to consider: perhaps this (and other propogation methods) should have a signature like:

``propogate(self, lefterror, righterror, leftvalue, rightvalue, resultvalue, operandnddata)``

This is basically just syntactic sugar, because the left and right values and erros are available from `self.parent` and `operand` right now, but this makes it easier/faster to write the subclass methods.
I find it confusing that the following works:

```
In [54]: a.format(sep="hms")
Out[54]: '57h17m44.80625s'
```
Was removing this return intentional?
Nope, that is the way it currently works, setting -proxy=... shows up in the GUI as it should.
You don't need to reserve space here, so please don't do it. "Premature optimization is the root of all evil".
Any reason not to use nTimeBestReceived here?
Doesn't Qt have it's own format time function? There's no need to put this in clientmodel as this requests nothing from the client.
How can I access nClientStartupTime in other cpp's then? I was not succesful with extern or placing nClientStartupTime in util.h as it was above GetTime(), which was missing then ;).
It was necessary when netbase.h included util.h.
Yeah something like that would work.
Please add a comment for Gregorian calendar hard code
switch back to destroy
please don't use underscores in `Identifiers`
To summarize another idea, you could load the BackendModuleModel into the container as a service, this could be done automatically (via the FileLoader, we could cache the module upon installation), and we could properly inject the Container. This way, we don't have to use static methods.

Another advantage of it is it's sort of in the direction of Doctrine (with EntityRepositories etc.). You could even make a method in your BaseAction that mimiks this, using an EntityManager that routes the Repositories - in our case the models - to the correct class.
Only checking for comments is a rather crude method.
add trailing comma here, or syntax error will prevent highlighting.
I'll change the doc
Priority would be to use the guava 14 version from their codebase
temporarily as that's what we would end up using.  Moreover, it is likely
that Google's oauth works with base64 from google, or at least one would
hope :)

At any rate, make sure theres an explicit encoding test class that shows
the scenarios of base64 considered critical here (eg 'url friendly')

That way, we are free to change the Base64 impl in the future.
On Nov 2, 2012 2:32 PM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/main/java/org/jclouds/oauth/v2/json/JWTTokenRequestFormat.java:
>
> > +
> > +   private final Function<byte[], byte[]> signer;
> > +   private final Json json;
> > +
> > +   @Inject
> > +   public JWTTokenRequestFormat(Function<byte[], byte[]> signer, Json json) {
> > +      this.signer = signer;
> > +      this.json = json;
> > +   }
> > +
> > +   @Override
> > +   public <R extends HttpRequest> R formatRequest(R httpRequest, TokenRequest tokenRequest) {
> > +      HttpRequest.Builder builder = httpRequest.toBuilder();
> > +
> > +      // transform to json and encode in base 64
> > +      // use commons-codec base 64 which properly encodes urls (jclouds's Base64 does not)
>
> oauth's and bouncycastle's base64 alphabets aren't url safe either.
> I agree that adding a huge dep just for base64 is not ideal. Should I
> simply copy commons-codec Base64 class (and the required hierarchy) into
> oauth? later we can remove it when we migrate to guava 14 (I can be in
> charge of that).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r2021427>.
>
>
This is great. Swap Println for Fprintf(os.Stderr,....) and you got yourself a shipit.
Revert these guys as well.
This is... heuh... I'm not too sure of this. @peff, does core Git do the walk twice?
This broke the Windows build, @carlosmn. ^^
`@method Communicator.clearCaches` not `@function`
Any suggestions here?
You should just put the jQuery code in here and remove the `!` in the if statement.
Shouldn't this be: {{ media(/img/firefox/whatsnew/facebook-hero-win.png)  }}
I was thinking `var results = {};` which makes the lookup easier `results[title]`.
Oh, right. Sorry, I misread and thought you meant line 228. Fixing.
good point! I was thinking the key (string or whatever is passed) would be hashed by the cache client or by memcached itself. But I realize now that might be a bad assumption.
I don't know the cost of method calls in JavaScript.  My C++ geometry classes inline basically everything and they are not virtual calls so they don't cost anything more than manually inlined code.
Make sure to change the success message above.
Addional space to remove before `$pluginAlias`
This is done on purpose. The user story is:

1. I create a blog post.
2. I tweet out the link, send it out on reddit, use digg (haha, ok kidding)
3. Decide to change the title and dont notice slug changes
4. 1000 users see a 404 page

Now, this can change if we automatically generate a redirect for the old slug to the new slug? It would need to do that before I can merge as this will break expected functionality.
We should never compare floats for strict equality, use an epsilon instead!
Maybe mention this is for all rack apps and how this and the sinatra version interact with each other? Which one gets run first? Can they both be set? Things like that.
it should be ``false !== $lock``
Ok will use it as static method call.
I can not figure out how to achieve that.
Your implementation returns the current instance, but the FormInterface doesn't say anything about the return value. So it should probably be added in the interface (or this phpdoc needs this addition). Same applies to the `remove` method.
you should use ``&&``
I don't understand your last message, but there are no security issues. When calling trustProxyData(), we know just assume that are trusting the last proxy, and as such we return the last value of the x-forwarded-for header.
I optimized rendering a bit, here are the results of my little benchmark:

```
+----------------+-------------------+--------------------+
| columns x rows | Before (s)        | After (s)          |
+----------------+-------------------+--------------------+
| 3 x 10         | 0.009207010269165 | 0.0074009895324707 |
| 3 x 100        | 0.20063400268555  | 0.059360027313232  |
| 3 x 1000       | 14.763768911362   | 0.61125707626343   |
+----------------+-------------------+--------------------+
```
(though i do agree-- this seems likely to be a hotspot)
Seems like this is already done in the Meta class so this TODO should be removed.
Would prefer to see this as a property given that it's our convention across the rest of the codebase.
Interesting. I'm down to rename, but not sure what to rename it. scheduled_tasks.rake?
Which name?
This should be the same as the function getting tested `def test_retrieve`
Same has above: the IO can fail, and so it must be wrap into a try/catch and a Failure.
This comment isn't still true now that we use -isystem for boost right?

Maybe update it so we remember which parts of the code need these?
this should instead check if the file is commited in the git repo
this type should have godoc some comments
Мне мерещится, или что-то с отступами периодически творится?..
did you mean to have ", or" here?
Yeah I see the issue with RegExp, Date and even Function. The instance of Stateful check seems unnecessary unless there is some case where an instance of a Stateful won't also be an Object.
absolutely, good catch
Good catch, it's just a typo.
nakanohito fabricator を作ってはいかがか
and _preprod _staging _myenv
Make sure your editor is set up to use 4 spaces per indentation level.
Should we perhaps remove them, then?
why so many comments?
Nevermind. I'm reading the rest of the code and that's ok. Maybe you want to check for something else than 'LI', a good className or whatever.
Ok fine, thx for the clarification!
We can use spanOfMonths to create the timespans then do something like this:

````js

var span  = Calendar.Calc.spanOfMonth(new Date(2012, 0, 1));
var daysInWeek = 7;
var days = span.daysBetween();
var weeks = days.length / daysInWeek;

// iterate through slices of days they are ordered so should be from first day of week to last.

````
Please don’t add Media Storage in the same pull request.
Nope, if you access the DOM object via dataset instead of getAttribute(...) -> https://developer.mozilla.org/en-US/docs/DOM/element.dataset
ok so add both alternatives in the CSS is what you mean right?
<pre>
button.accept, button[type="submit"] {
...
}
</pre>
nit: Here yo use window.navigator. Earlier you use navigator only. Both are fine to me but make a choice :)
You can inline both this file and xhr_current_location in turbolinks.rb. No need to have these as separate files imo.
Same observation about wrapping isinde `askOption`.
Agreed that we should just pay the reversal.

Given the OOM issues, I almost wonder if we should get rid of these and force people to use take or sortedTake... (btw, I keep meaning to add takeRandom, which is basically mapPlusMap{x => (math.random, x)}{t => t._2}, but using the SortedTakeMonoid)
move to constants?
This, and all other calls to random number generators throughout the code should use a numpy RandomState object, and use a fixed seed. E.g.

    rng = np.random.RandomState(seed=0)
    bgrand = rng.randint(0, n_bg, n_ex)   #or whatever the proper syntax becomes

This way we have a reproducible but pseudorandom data generation process, which makes reproducibility much easier. 

This sort of issue comes up a few times in the code, I'll point out the ones I see .... but @pbattaglia maybe you could make all the changes all at once?  I don't think it would be that hard.   I'm not in fact saying that we need to regenerate all the images .... because all the specific parameters for each image are in fact known.   But for the future, here and elsewhere .... it would be good to use this policy.
This should definitely be an issue on GitHub.
That won't do if you're doing multiple requests at one time.
Use inline functions:

``` coffee-script
load = =>
  ...
  @textContent = 'hurr durr'
```
I see. Sent a mail to moot, so it should be updated soon™.

Actually I think it'd be better to separate /f/ errors to normal errors. That way we will just strip it when it's not needed anymore without touching the sane code.

```coffeescript
else if err = $ 'center', doc # /f/-type error
  err = $('b', err).nextSibling # text node
else if err = doc.getElementById 'errmsg' # error!
  ...
```
Rather than use the session, the normal way of doing something like this is to pass in the user id (from the URL) as an argument to the view. In the [django tutorial](https://docs.djangoproject.com/en/1.4/intro/tutorial03/), the poll_id is an example of this pattern.
You could generate 2 tables, but probably not a big deal.
def system_output(command, timeout=None, ignore_status=False,  retain_output=False, args=())

Thanks for reminding, as the ignore_status is False in default. Will update this line.
If the default for ```sourcestamps``` is ```{}```, then that should be the default of the argument to ```trigger```, rather than having one default, and then later changing it.
Personally, when I see two pieces of code that have the same shape, I'm inclined to think they are likely the same, and not notice small differences between them. The first couple of times I compared `_full` and `_doShallowClone`, I didn't see any differences. Hence my suggestion to combine them.

The combined function wouldn't look at `self.shallow` or `self.clobberOnFailure`, it would just take an argument indicating whether to abandon. Then the calling code can decide what to pass.
Standard coffee loops are perfectly fine. I don't use them because they don't create new scope though.
@stof no, @jeremyFreeAgent Stof is not always right, you should mind that and also his mother language is French and not English.

ok so what i meant was that I was not talking about update command. I am always talking about require. So that is why I am trying to get the tests for this.
Wrapped, thanks !
we should not duplicate annotation declarations between the expressions and the top level parser. A single definition should be used and both use the same.
Yup. Just pushed that to my fork. 

Once I get the commented test passing, is the procedure here to just make another pull request?
why without .row_title ?
or hex value for green?
Do you mind deferring further improvement on this until we get new manifest format ?
I'm expecting these exceptions to be used by all cfx modules, in order to classify kind of errors and print the most meaningfull error message we can. And especially distinguish user error from internal errors.
Otherwise, implementation wise, I've just followed this page: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Error
I'm fine with dropping the prototype usage in favor of your code snippet, but I think it make sense to keep this module in order to reuse these normalized errors?
What's that `apply(mix, mix, concat(` ?
Can't we do `mix(sources, options, {...})`
Please use mozilla specific code if it can helps writing such code!
This is part of the design
The site/ link was used for unit testing so that we could dynamically render main site templates to the DOM between each test. With the dynamic creation of templates, this should no longer be necessary.

Can we use this as an opportunity to remove the site/ link from the resources/static/dialog/views directory?
nit: lift this into a `const` at the top, so we only ask config once.
as well you should.  This is a converter to be used with 'from_string_converter'.  Only strings are allowed: 'Alpha, Beta'.  In fact, the configman code that calls this function does so with a dispatch table based on type.  It won't even call the function if the type isn't a derivative of basestring. 

Is this a candidate for a more appropriate name?  I think not, the other converter functions in this file have similarly structured names.  Maybe they all need renaming.
__whimboo__ wrote:
> [...]
> For SeaMonkey does it mean gBrowser is available in each of the windows?

Yeah, currently overlayed `chrome://navigator/content/navigator.xul` does have `gBrowser`.
I already modify the pull request range to include latest commit.
This is my early understanding of how to update an IDM.
After creating this new bean, I realize that all will be done in SurveyDao.updateModel

So, I already delete this class, IdmUpdater and also its package model.editor
Should be ``AMQPExchange::delete($exchangeName = null, $flags = AMQP_NOPARAM)``
This is done in the new TB
There is quite a bit of duplication in these tests. If nothing else it detracts from what is actually varying in each one.
what would be in the per-module config file? a special hierarchy that only applies to the module?

trying to understand the use case -- wouldn't we just need to include a data file that has a default value for each parameter?
I think we should have an "extension message" function in the user namespace, so we can just send messages by giving the content.  I think that would simplify these sorts of functions tremendously.  So the html function could just be something like: `sagecell.send_custom_message(dict(type='text/html', data=html))`.
Rather use a docstring than a comment e.g.
class Build(build):
  """"Custom build class that checks for dependencies before building"""
   ....
use `process.recursive`, it'll be a bool.
If you remove the default value then the argument is not longer optional.
Shouldn't this be "className"?

Actually, to be quite clear: use "class_name" as the option key. This is safer from a validation standpoint.