labofsahil/github-event-dataset-2012 huggingface dataset:
Лучше запускать через COA API, тогда выполняющиеся строки кода имеют шанс попасть в test coverage report.
А так — точно не попадут.
Tady bych použil mojí větu, je spisovnější a srozumitelnější, jen bych použil plurál místo množného čísla.
Mmm... This should get handled by the ngettext stuff. I don't know offhand how that works in django, though. So... I guess we can leave it like this for now, but we should fix this later. Ditto for categories and speakers below.
I'm not sure we should expect users to understand "ZoL". Other parts of the man page say "Linux".  I don't think it's necessary to list possible scripting languages. The custom script should definitely not have a .sh extension. If the hook script is optional (which I think it should be), the man page should say that. Finally, the behavior on failure of the hook script should be documented (is the share unshared)?
I'm hoping to test with Solaris today. But from what I can see online, it looks like Solaris does one target per zvol as well. I'm thinking maybe the best answer is to push forward with one target per zvol for now and worry about getting the rest of the patch in shape.
I agree. Sorry I missed these lines. Removed.
No change required for the PR; however, with the changes coming to allow for the refresh to be done async, refresh will be renamed 'refresh_view'.
Which dependency? I meant to remove `RavenFormatter`. `RavenHandler` still depends on `RavenClient` (in line 16). Or maybe you wanted me to keep a defintion of `getDefaultFormatter`?

Let me know what you meant and I'll try to turn it around quick.
I don't think forcing to use the stacktrace is a good idea. It should be configurable in the constructor
I don't think this section = foot is necessary if you're using a footer immediately below
Building the docs on this branch causes a warning which I trace back to this line.  The problem is that the numpy sphinx extensions get confused and think that this is a documentation section name "Table: Table name here".  Adding the space after the first line fixes that, which why it was in the exisiting code.  There may be some other way to make it not think this is a section, or perhaps the numpydoc extension needs to be altered... But regardless, right now this gives a doc build warning.
measure**d**
Should be 'adapter'
these 2 parameters are strings
This should probably be `bonuses` given that there could potentially be more than one?
yes code would be more readable as you propose it.

for the types i think having just <type> and no wrapping <types> should be fine i think. if there is global stuff, we can use attributes of the collection, if there is per-type stuff its inside the type. we can even mix other xml elements directly under collection if there ever is something.

i would specify the other types in rdf types rather than php classes, as we did in the controller attribute. does that make sense for you or is there a particular reason you wrote class into your example?
No problem, but that AdministrationService is not a direct Api connector such as CloudApi or InfrastructureApi. It delegates in strategies to perform more complex operations, so I decided to use this named convention.

I took the example from clouds-chef context: https://github.com/jclouds/jclouds-chef/blob/master/core/src/main/java/org/jclouds/chef/ChefContext.java
Maybe it was not the right decision, but I think this *Service classes that are more similar to the ChefService than to the *Api ones.

It is ok for me to do the change, but it may be a bit confusing to have, at context level, a "getAdministrationApi() (providing strategy based functionality), getApi(), getAsyncApi() (providing access to direct api calls)". I followed the example from chef context because to me it seemed more clear.
If you confirm these kind of services should be refactored to *Api I'll do the changes!
the responsibility for separating out tags from usermetadata in implementations like ec2 is *ToNodeMetadata.  Let's not leak this behavior here.
Doesn't it have to be this way anyway (same minute/second), unless its a BYSECOND or BYMINUTE rule?
On Fri, 21 Dec 2012, Paul T. Bauman wrote:

> I'm not sure templating will work in teh ProjectFEMSolution case
> because the algorithm is slightly different because of the
> construction of the FEMContext object (in particular, the element
> and variable loop order is switched to avoid superfluous element
> reiniting).

There shouldn't be any problem with switching the loop order in the
ordinary solution projection case.
This is going to bite us in the ass. $20 says that `-O3` drops this line altogether.
Instead of concating strings for the key (which is hacky), why not use a Pair for the key? There's one in the commons lang, which is a part of datafu.
I noticed this when I noticed it broke break/continue :panda_face:
I think php_url() mostly provides the locale URL prefix, which, for the mozilla.org svn repo isn't necessary (vs. mozilla.com repo) links.
yeah, the tests are still incomplete, unfortunately.  trying to hop on that this and next week.
It is coded this way in the commit, as you can see in the diff. :)

If you don't mind, I'll change the exception name when I refactor all those implementations, for the moment I define it in several places and that should be in one single place instead. I'll also need to change the way I handle connection in several files.
I'm very happy about the removal of all this code from the middleware directory.  For the other configmanized apps, however, we're keeping parallel versions of the old apps so that we can gracefully switch between using old and new.  It looks to me that the old is going away and the only way to go back to the old version is to revert.  Are you comfortable with this?
wm doesn't really give any structure to POST because by spec, POST is sort of a free-for-all. We use POST-as-create and we have to tell wm this. In this case, create_path gets called to return the URI of the created resource.
Should be:

    $cwd = isset($options['cwd']) ? $options['cwd'] : getcwd();
For the redirection I didn't though about it yet.

For the connection creation, you are right, but that also means that the connection is established even before the user decides to send the request. It also means that Request instances are created asynchronously by the Client, and the interface would look like this:

```
$client->request(function($request, $error) {

    if ($error) {
        // connection errors
        return;
    }

    $request->on(...);

    $request->end();

}, "GET", "http://www.example.com/");
```

This adds an other level of callbacks, in which you have to `use` any variable needed by inner code (including variables used by inner callbacks).

Still the actual connection creation is handled by ConnectionManager.
Move the definition for `Postage` to `usps/package_response/postage`
This is only for parsing the HTTP entity. We only attempt to parse it for non-500 error codes except for 502 and 503.
Why do you pass `$object` here?
Thanks!

Is fixed now.
buildViewBottomUp should be left unmodified IMO as it is deprecated anyway. People wanting to use the new argument to access the options could simply use the new ``finishView`` method instead
Well, we are not responsible if something stupid is done manually by the developer. So a ViolationPath would just be as wrong as an array or a subclass of PropertyPath that behaves strange. We can only make sure it's flexible enough and  that's what the interface is for in the first place.
`ejs.compile(str, { filename: 'fake.js' })` is fine
If that UIAlertView is on screen there has to be a VenueInfoViewController behind it.
Does `Rubber::Util.has_asset_pipeline?` return `true` for you?  If not, we could use that as a check here.  I figured if you weren't using the asset pipeline, the config would be benign.  Obviously it isn't.
This isn't a file you want to commit.
That's awesome. If it will really work over port 80, then I'd say we don't need to do anything else. Better test it, though.
Change VALID_USERNAME to have a one character minimum `{0,33}` instead of `{3,33}`, and then make the check be `VALID_USERNAME.match(params[0].replace("*","").replace("?","a")`

That would make "?" a valid nickmask but "*" invalid (you can't just ban every nick :/)
I've coded it both ways and thought this looked cleaner. I'd hope the interpreter would optimise out the lambda.
We should be using `||` rather than `or` here, according to the style guide.
this should probably be a ``DeprecationWarning``. The feature is already deprecated in 2.3, and will be killed in 2.4, so in accordance with Django's deprecation policy, we should warn loudly in 2.3.
Just to provide more info here - The code means ((v is an instance of dojo.Stateful) or (v is a plain object)). As Ed pointed out, we need to keep non-plain objects like Date, RegExp, etc. intact.
Ok thanks. I might have merged the test by mistake in this branch.
I don't really like the notion of letting people provide their own describe handler, as that leads to bugs :)

but there is a valid use-case for it, especially as it introduces the contract for defining it
Get rid of the 'if' and just do EJB3SubsystemRootResourceDefinition.ENABLE_STATISTICS.marshallAsAttribute(model, writer);
It's might be unavoidable, but we ideally don't want to change bundle keys. I'm not sure how hard it is on the translators when keys change like this. Maybe Zanata can copy some stuff over, but we have to be 100% i18n compliant and changing keys slows down the process.
I believe this is the logic that Scott's approach is intended to eliminate the need for. However, it raises quite a few questions about whether it breaks existing functionality. All current demos work, but we need to create some new demos/tests that show problematic usecases.
// When hardware volume key is pressed, we need to decide which channel we should toggle.
    // This method returns the string for setting key 'audio.volume.*' represents that.
    // Note: this string does not always equal to currentChannel since some audio channels follows other settings keys.
nit: early return possible here.
Selectors like `#foo > #bar` don’t make much sense, please use the good old `.getElementById()` instead.
How you crop the image here has the same idea as my cropImage() in utils.js, and I don't know what kind of cropping does visual design prefer, so let's just keep this way. Letterbox is also a good choice if they want.
Okay, I don't see how you can reuse more of the notification code, this is fine.

But can you extract all the fake notification code to a `system/js/voicemail.js` and keep only the status bar icon management here?
Remove the console.log calls to not pollute the debug console.
Can you comment that this line actually do translate the document by triggering l10n code.
var self = this;
    
    AlarmsDB.getAlarmList(function al_gotAlarmList(list) {
      this.fillList(list);
    });
> Hmm, what do you mean by “markup independent icons”?

I mean what you've done in https://github.com/mozilla-b2g/gaia/pull/5680, using icons without adding extra tags.
As i want this landed as soon as possible (as there is a lot changes) i will add a wrapper for the string meanwhile we discuss the proper way using icons inside the buttons.

Thx!
`createHighlightHTML`
I just took a look at the mediadb.js, and suddenly I realized what you meant by "omit"! Sorry I did not get you :P
This time I am sure it should looks like this <code>searchHandle = musicdb.enumerate(tv_showResult.bind(this));</code>
Thanks for the reminder, but there actually exist many "white" in the css. Do we need to sync whole the color code to Hex one day?
If +13px is for the scrollbar you can remove it. I will land https://bugzilla.mozilla.org/show_bug.cgi?id=770453 that should solve it.

Same for the transition hack. It should be resolved by https://bugzilla.mozilla.org/show_bug.cgi?id=777672
You don't need to encode the message in the URL.
In the system message handler you can access:
* `message.imageURL` (like you are already doing), but also
* `message.title` and
* `message.body`

Those are the title and body pass to the notification,
According to Spanish grammar, only the first letter of a sentence or a proper name must be in upper case. Since "Avanzada" is just and adjective, please, replace by "avanzada".
The reason was that those tests requires jar file for specs1 and scalachecks wrapper runner, which is not available in any public maven repo yet.  We could enable them when the required jar goes into public maven repo.  Anyway, I have added the reason in the comment in this commit:- https://github.com/skyluc/scalatest/commit/0a90d7866abd891985573e2a676f948cbab56685
This translation has been reverted to english. Why?
you right, it should probably just test if step size is an integer > 0
re-add the `unless @finishedDrawing` statement otherwise you can keep drawing after mouse up!
"at the application level"
Make this a TODO and add an issue for it on GitHub.
>`path = url = something`

what are you doing
just do `path =  something`,  add the post ID hash to the path, and then `return "#{url}#{path}"`.
I am not familiar with mobile redirects, but this didn't work for my BlackBerry device with the MR3020. I will look into it again and see if I can find the issue.
Shouldn't these be within ChatChannelManager?
Good call, I'll change that.
All right. Wouldn't it make sense to consider those that are called from the tests (such as db manipulation helpers) to be public as well ?
Ah yes... I wonder why the compiler didn't catch that for me :/
Ok that's fine by me.
Shouldn't we name it "SQLite3 Component" as in "WinRT Component"?
What's a?.. Why just not to set pluginTags to: ['core', 'desktop', 'linux', 'windows', 'mac']?
I don't think it hurts to leave it.
I think `@packaging` should be defined in bootstrap or cuddlefish. It is jetpack specific.
it's used in other places atm, and this is all Traits code that will go soon anyhow, so I'd rather not make `browser(this._public).internals = this;` with `browserWindowPrivate = this;`change atm..
+1 to making that configurable
Please reduce the variable to 'TabGroup' so we stay in sync with 'TabTitle' and others. Also please kill the last part of the description content and use 'Tab Group' instead of 'TabView', e.g. 'Current Tab Group'.
Some errors are rised because in `schema.xml` there are fields marked as
"not null" but, inside the tests, they are not valorized. If you don't set
mysql safe mode, a warning is emitted but the object is persisted evenly
(`$a->save()` works without exceptions, even If you have a null value for
fields marked as not null in schema.xml).
with mysql safe mode, insted, an error is rised so Propel emits an
exception, without persisting object.
Imho, the first thing to do is set a default value for all those fields
marked as "not null" inside `schema.xml` or, if you think it's better,
valorize all those properties in tests code.
Il giorno 16/set/2012 00.23, "Jérémy Romey" <notifications@github.com> ha
scritto:

> In tests/Propel/Tests/Generator/Builder/Om/GeneratedObjectTest.php:
>
> >          $a->setAge(0);
> > -        $a->save();
> > +        //$a->save();
>
> @willdurand <https://github.com/willdurand> can you tell me what to do
> about that too ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/propelorm/Propel2/pull/306/files#r1614040>.
>
>
Could you please add readd the whitespace between the comma and the parameter name. Without whitespaces it is less readable.
alpha order of imports
I wont want to get nuts with hasOwnProperty stuff, if someone chucks .Reporter on Object.prototype that's their own deal
This should be `if (!$test) {` here
Fix indentation of other params.
This should be assertSame() -- assertEquals() can compare two objects for equality, without them being the same object. I'll update this on merge.
I surrender, changed :)
Please add spaces between operators, not sure this will pass CS
Do you want empty lines start and finish like the others?
Um... how about back up the old `.hgrc`? Do a `mv ~/.hgrc ~/.hgrc.orig` instead of an `rm` please.
Ekhm `sidebar-developers-list` ?
campaign.php
Should be `<button>`, see template.

Also, does PlastronJS have any templating?
String concatenating is plain bad.
this should be avoided.
Nope, just used it myself, so I found it handy. Happy to have it declined

On Aug 7, 2012, at 10:36 AM, Brian Waldon <notifications@github.com> wrote:

> In readme.md:
> 
> > @@ -14,7 +14,13 @@ the prototype 1 environment == 1 instance.
> >  
> >  Use setup.py to install cloudenvy and the dependencies:
> >  
> > -python setup.py install
> > +    python setup.py install
> > +
> > +### Hacking with Virtualenv
> I know I'm being picky here, but do we really need to add this? This isn't something specific to this project and not everybody likes to use virtualenv. You can use 'python setup.py develop' without using virtualenv, as well.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Please add a use statement for this class
you should typehint the arguments whenever possible. It will make it easier for people using an IDE
`Collections` ? Like common? Not sure, but now it clutters the persisters namespace imo.
Shouldn't this probably be
```$mappings[$fieldMapping['name']] = $mapping;``` ?
you should wrap the lines shorter to be consistent with the other parts of the file
please remove trailing whitespaces
this is not returning NodeInterface like the contract of QueryInterface tells, but PHPCR-ODM documents.

i was looking on doctrine orm but it seems there is no query interface, only the implementation directly operating on AST and whatnot, so nothing to borrow from there. i suggest we keep implementing the phpcr QueryInterface but mark it very visibly that execute returns documents. or could we use a different method name maybe? we could call the method that returns documents ``getResult`` to be compatible with doctrine orm.
and all the other empty asset files.
This selector needs to be more specific. We don't want to impose no underlining for *all* links on the site which is what this would do.
This should be done as config injected in constructor instead, is would be possible to reuse setting in several places.

But I would like to avoid having to pass field types to Storage Engine in the first place, this means certain logic is handled slightly in Repo and slightly in Persistence, which is violating separation of concerns.
Could you not randomly change whitespace? Just set your eclipse XML file editor to 4 spaces and do a Crtl-Shift-F to get rid of the problems :-)
Yes, I did, and I sent few emails about this, and I haven't changed anything since then, not sure why you don't see the new branches.
Yes I realized that it is a many-to-many :)
Style: too much whitespace.
Could you add a newline at the end of this file?
@jeffperrin I think we need the S but not the apostrophe and the comma should remain. In your change the CMS owns 'everything' which doesn't sound correct.

I think it should be `With most CMSs, everything...`
Please correct me if i'm wrong. My grammer is horrible usually.
I know this isn't part of this PR and won't affect this r?, but shouldn't these at least be wrapped in a `if settings.DEBUG`?
Do you need to cover the case where query is empty?
I thought about that, and I'm really not sure here. People might want to be able to localize that URL (e.g. `mozilla-de.org/contribute` or something), but maybe we don't want them to be able to. Who can we ask? David Boswell?
This area of the code had some changes in a recently merged pull request, so now it can't be merged automatically. Sorry!

Could you merge the latest master into your branch and solve the conflicts, please? :)
use `and` and `isnt` instead of `&&` & `==` as it’s idiomatic coffee
Ok, I've renamed source to be source_url. I've updated production data to
be consistant.

I will not be accepting this pull request since it is no longer necessary.

Todd


On Tue, Nov 20, 2012 at 11:56 AM, Todd Sedano <todd.sedano@sv.cmu.edu>wrote:

> It seems like the real fix is to alter the show action to handle documents
> that don't exist in the system. We still haven't answered why
> this implementation is different from articles.
>
> Todd
>
>
>
> On Tue, Nov 20, 2012 at 11:55 AM, Sky Hu <notifications@github.com> wrote:
>
>> In app/views/katas/_kata.html.erb:
>>
>> > @@ -26,7 +26,7 @@
>> >    <br><br>
>> >    <% unless kata.source.blank? %>
>> >      <div class="entity-source-url">
>> > -      <h4><b>Source: </b><%= link_to kata.source.truncate(130),"#{kata.source}", {:target => '_blank'} %></h4>
>> > +      <h4><b>Source: </b><%= auto_link(kata.source, :html => { :target => '_blank' }).html_safe %></h4>
>> >      </div>
>>
>> Also, if user puts mixed string in the source field:
>>
>> "http://www.example.com from Clark Kent"
>>
>> auto_link can still nicely handle it.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/professor/Hibiscus/pull/31/files#r2185859>.
>>
>>
>
>
Yes, that's a fix that's coming in the next commit
the reason of putting the include in the html part, was thats an optimization only needed for the html view.
not sure if its required, as we monkey patched nil class to include an empty method.
boolean conditional with side effect in parens
I think this should just be

```javascript
if(obj.description) newItem.abstractNote = obj.description.join("; ");
```
Even worse:

    > 1 / -0
         -Infinity
    > 1 / 0
          Infinity
nit: You can just say `random()` here (and generally anywhere else in the HTML file you can leave off `KhanUtil.`)
Could you add some parentheses to make more sense of what the ^ and % operators are doing?
As mentioned in the header, I'm not sure if a warning should be printed here, but I figured on the off chance someone has a symlink they expected to get linked but the symlink was broken, some message should be displayed to the user.

Comments would be appreciated.
Indents are funny around here
:heart: this so much
Would be nice to indent this part :)
надо бы добавить компаратор для Length
I like the idea. Should we allow just *one* folder for static files or more than one? Express allows you to set multiple places for your assets (which goes in contrast of having a root).
少了两个-
oups my bad removing the not.
Yes. Facebook is changing its size every time you open it. This is to counteract that.
The code has its origins in the system-ui code. The reason it is class-level static is that then the same constant can be used from an unit test. Then again, I suppose the unit test could test that the used extension is correct... I can make these file level statics.
This is *nice*!
Should call `inflateEnd()`.
I think this readme is superfluous.
Agreed, see my suggestion here https://github.com/resolve/refinerycms/pull/1343#issuecomment-4567100
This should be marked as an optional parameter.
Wouldn't it be easier if checkPassword would return an error if the password isn't correct?
I think the line above was right and less complex.
Would it still be possible to run the build using the local profile? I think we could still use something like that for testing. Right now it 'worked' by having a profile with no remote repositories, but the new parent pom seems to have them always.
One more thing, I just deleted the ``var name`` and no compilation errors, i.e., it was unused :)
I need to make this better, so it doesn't wait forever. But the test code cannot be run from the listener code, it needs to be run on the main thread. I'll check what I can do with a thread gate.
коментарі пиши до коду
Looks like a random comment that will break the app (as you know)
Please fix the indentation of the declared vars?
Fixed.  Thanks for the point-out!  :-)
В принципе - согласен.
Могу отметить, что мутация у меня решена в лоб (возможно, мне хотелось попрактиковаться в массивах :) ).
Мне кажется, что можно решить задачу и более С-ным путем без хранения предыдущих значений.
Примерный алгоритм:
1) получаем кол-во элементов, которые подлежат замене = Nc;
2) генерируем случайное число в пределах ( 0 - (N - Nc)), делаем замену по этому индексу; Nc -- ;
3) далее двигаемся прыжками по массиву, пока Nc != 0 , и чтоб длина куска массива, в котором не было изменений была не меньше Nc.
Если длина куска = Nc , то можно заполнить и просто с помощью for. 

Интересно было бы проверить идею, но не было времени :(
I intended mProcessedResources as an object, not an array.
But I made a mistake:
  mProcessedResources = new Array();
So, I'd like to fix as follows:
  mProcessedResources = new Object();
тесты на права доступа
I don't believe so because there is no public interface for it
Is this cucumber original line? Does this line not work correctly?
I'd consider using `mail` instead of mutt. More systems are likely to have this installed by default.
extension_id is just the primary key of the installed component, which is the same value of $row->$key. I'm just callind $key by primary key name: extension_id. 

The real value of extension_id is set inside JDatabase::insertObject, which is called by JTable::store, which call insertid in right context (just after setQuery). Calling insertid here again is redundant and may lead to unexpected results.
Would it be reasonable to assert the current branch / head commit are as expected?
don't like the use_ sorry
is there a reason to keep the commented lines?
Good point, neither am I--but this is just temporary HTML until we get the universal nav code in the next few days, so I took some shortcuts. I have added a comment explaining this.
Interestingly there's a mismatch in the actual file names (e.g. FileInfo.ts and the reference ///<reference path='fileInfo.ts'/>). I'm not sure how this pans out in a OS with case sensitive filenames.
Is that intentional? That way no frameworks will be added at all.
I don't think this is necessary. It has no effect.
same for this example
I'm not good in English grammar, but I think this should be:

    If, for some reason, you need to define some configurable requirements,
You should add a `php` format aswell.
很多情况
requires a change to how mailbox types are instantiated, see above.
Can we use the same logic as for symbols (which uses spaces or commas)? Perhaps use the function from that routine if there is one. And if there isn't, perhaps this should be put in utilities (misc?) for splitting a string giving a list of things in a sympy-standard way.
Потому что перенес их в *.h
Quedó un espacio de sobra acá antes de los story points. (Perdón por fijarme boludeces.)
```layout_decl (csym->Stree);``` should do just fine.
`return item.data();`
Ah crap, I'll fix that
potential conflict that could be caused here, it might know whether or not extending Command refers to org.bukkit.command.Command or the Command class in the project.
sub-class
remove call to the deleted GV in /api/monitor/ too
It will be done!
Yeah, I'll switch to that.
I've seen None being passed as input to memory_string_to_pages. Can we please add a None check at the top, or a catch AttributeError here and default to target zero?
Just so everyone is aware, we are changing the checking of the loop because xmlns may (or may not) come back in the list of these items for wonderful XML. We are also removing the else since the message is not valid. itll just look for any of the existing keys from above (flavorRef, volume)
Modifying parameters is bad style. Shouldn't the caller check the tx as well?
Again, not used, so remove. 

Besides, we don't tend to cache isDebugEnabled(), only isTraceEnabled()
Why did you remove this? I'm testing this in the mean time...
change "capture." to "capture/" to work with the requested change above
Parameters in a block type should use the same style as method or function parameters, so `NSString *` is preferred over `NSString*` here.
Hmm. I think that's an improvement. Let's see what the others have to say.
The original was not strict PEP8, but it was more readable, so I would put it within PEP8 flexibility for readability.
It seems that you `elif` have additional levels of indentation (it should be one tab before)
it looks like this is req'd by a test. any reason why it was deleted?
Ah okay. Anyone can work on the PageRegion object. It's simply extends Page and takes a WebElement as an argument for the root element. Then in the Page methods you can simply check if you have a Page or PageRegion using isinstance and find the element appropriately. I think the only thing I wasn't sure about it whether the PageRegion should be passed an element or a locator for the element.
Could you give some context to these locators? Just a comment above each block to associate it with a page or flow?
do you need to test this here? you didn't just create a suite.
All right, I can see that. If it's hard to make these selectors more efficient, I wouldn't worry about it. It's a minor optimization anyway.
Помоему имелось ввиду что-то другое. Про BaseTransaction и DBTransaction я думаю все так же - из-за них begin, commit и т.д. в базе объявлены deprecated но при этом их самих использовать неудобно + inTransaction свойство по ощущениям очень привязано к базе, а за базу отвечает именно DB класс. С другой стороны из DB сложную логику нужно выносить, т.к. вроде бы он достаточно перегружен и всякие наворотам c queue и queueFlush там не особо место, пожалуй.
What does stop do, what unregisterConnector doesn't?
Does Stop() delete the connector?
Rather use an actual "const" for that?
I think benchmarks in the docstring are really fragile and don't help with the understanding of the function; it's a lot to change if you change anything about the function. I'd have an entirely separate project with these benchmarks, to be honest -- this should really come out. (Good stuff, though!)
Nitpicky is good, makes the code better :-)

I'd say don't merge yet, tomorrow I'll try to improve the performance a
little and fix the tests. I'm not sure about the dateutil, though...
El 04/05/2012 0:53, "Robert Bruce Park" <
reply@reply.github.com>
va escriure:

> >  from gi.repository import GdkPixbuf, GObject
> >  from re import compile as re_compile
> >  from pyexiv2 import ImageMetadata
> >  from time import mktime, clock
> >  from calendar import timegm
> > +from datetime import datetime
> > +import dateutil.parser
>
> Sorry, read a bit more and realized that KML takes more timezones than
> just UTC, my bad. I'm not sure what to think now...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/robru/gottengeography/pull/48/files#r771421
>
please use SG_ADD instead of m_parameters->add
I could move the customizsations to the generic .cms ... stylesheet. Probably a better solution. 

It's just for the look and feel ;)
Why is this in this pull request?  Is it part of the problem or an unrelated issue that came up?
No mě to pořád přijde nějaký divný, nemělo by to záviset na maximální velikosti toho čítače, takhle, když to na ní nezávisí, tak kdyby byl třeba 64 bitovej místo 32, pořád by to vyšlo stejně. Možná mi to pak budeš muset zítra ukázat na papíře :)
Even a small apidoc could be nice! :)
true! thnx ;)
I cannot find the effects of this change in UI, where can I see them?
This is an assignment. Please use an extra line.
do we really want to replace textarea controls with textfields?  I would think that we would want to show the alert that text area is not supported or disable the list entry.  Otherwise it may confuse people in thinking that text area is supported.
When parameter type is `UnionType[Element?]` then result of `unit.getDefiniteType(type)` is `IntersectionType[Element&Object]` and to html is rendered `Element&Object?`
More precisely, I wanted to mean "first to a controller then to its actions". Now I feel that expressing things too specific is meaningless and not helpful to the audience.
I want to confirm we need to still send server_name along with events. If we do, I'm going to make it optional (though we'd still need at least suggest they set it for compat).
It would be nice at some point to have an article which explains <functional> constructs like bind2nd, etc.. Here we use bind2nd and std::less but don't have the chance to explain them. I think that's fine for this case, but perhaps we could link here for curious users: http://www.cplusplus.com/reference/functional/.  We could then change this link to an internal one once we have an article that explains the use of <functional>
This exception is being swallowed - i'm having a tough time (11pm, and a full day of driving for me tomorrow) figuring out why this got fed only part of the json, but the entire json string was in the log just prior to this trace.
there are also some CS issues in this file
We haven't done per-cookbook git ignores because generally there aren't things that would show up accidentally. Why would there be a tmp file/dir?
Vaadin-resources make posible StaticResources locate plugins containing vaadin resource
Useful for distributed css
(So that we start with what has to be entered.)
This is a good question. Is JSON always safe in HTML way safe? So Django supports only HTML-context automatic escaping. By marking it safe, you are saying that JSON is safe to be included in HTML context as it is. Is this really true? In any calling context?

I think it is better to not assume this and leave to users to use filters in templates to mark this. So when user knows that context is safe, she can use `safe` template filter additionally after your tag.
This is not good. User does not have `is_published`.
Ups, there is indentation missing. :-)
One line too much. :-)
No, you should access `request.node`.
*Potrebno* -> *Obvezno*. *Potrebno* has a bit strange connotation. :-)
Not sure about that.  Those are coming in from binary format and still not sure what I am going to do with those.  They may be changed later but right now they should stay.
If you make a new test, wouldn't I still be able to use the *Devil's Advocate* technique and create an implementation that passes both (all) tests but is still incorrect?
Chance = MaxChance - (ratio * MaxChance / 10);
I just found the files at https://github.com/micheldumontier/php-lib 

May be useful to include a note for this rdfiser that it relies on that library being checked out in a certain location, or include a git-submodule in common/php/ for it.
btw, changing the hash makes the browser scroll to put the query at the top, which is confusing IMO.
enforcement not Enforcement (aligns with other single word naming convention)
On first reference, should we spell out the words *and* include the abbreviation in parentheses—e.g. The Document Object Model (DOM)?
This should not be the case. Pig loader (ThriftPigLoader) does not loop. Of course, the loop here does not harm.
Maybe have this comment as a doc block?
I'm little tired of this styling issues. In SDK we explicitly forbid cuddleing both `catch` and `else`. As a matter of fact we also allow single line `if else` without braces and many more. I'm just pointing this out here because SDK is on it's way to mozilla-central and there were no plan for additional reviews or stylistic changes.

Now that being said, I really can't care less about anything, but style. It's just switching back and forth between incompatible styles is painful and there is no way to share code that would be compliant with both styles.

Please lets defer all the styling issues for now and if SDK code has to be trans-styled we'll do it all together.
why "notNullOrEmpty", why not just "notNull"?
I agree that `createList` is not perfect name for that, could you suggest something else?
@jmarantz 
done
Good point -- to be consistent, I will remove earlier assignments to __file__.

I agree that changes to __file__ are significant. All tests pass on Python 2.7.2 / Windows 7 and Python 2.7.3 / Ubuntu 12.04; I don't have access to a Mac.

Looking through the Python standard library + packages I've installed, __file__ is primarily used to obtain the path to the current Python module, rather than the exact filename; given that PyInstaller sets __file__ to a non-existent filename, I'd argue that at least providing a valid path is an improvement. Looking at the hooks, I notice many must work around this non-existent path by setting environment variables (TKinter), run-time hooks to set paths (PyQt), etc. I believe this change will ease hooks and make more packages work with less effort.

Your opinion?
Yes, it's possible to turn off completion after it's on, but I doubt anybody will do it since it requires to `unfunction` a bunch of functions. It's unlikely that anybody will do it. That said, `fasd` should be bullet-proof for those who do not use a Zsh configuration framework. You should always check that the completion functions are available or make your completion autoloadable (best).
日志的路径名 -> 的文件名称
I think there may be some cases where having the dimensions is helpful (although I can't think of any offhand), and since MAP gives you the dimensions, I think we should provide them when possible. I think it's just not worth the trouble to get the dimensions for remote images because of the latency problem. If people want the dimensions, it's got to be local, because that's the only way we can guarantee we can actually get the dimensions.
As TNArchipelVirtualMachine and TNArchipelHypervisor are both subclasses of TNArchipelLibvirtEntity, why you just put this method in TNArchipelLibvirtEntity?
Hard coded path... The current working directory could be anywhere. Change this to use something like:

    here = os.path.abspath(os.path.dirname(__file__))
    confd_path = os.path.join(here, "../../local.ini")
This should be done across the board then, in all the stub methods.
We can get rid of it. I used it for debugging.

So done.
I will recover it.
Perhaps default to "file"?
We care for several reasons:

- as other web services, it's better to be able to parse all response bodies in JSON 
- if you want to add in the future a more detail status than "OK" you will be able to do it without breaking backward-compat
Can this not be done where we set `isExpired` when receiving an expiry message? I would rather not add an observer is there is a synchronous way of doing this.
You could use ``Em.compare`` to compare the two arrays (guarded by an ``isArray``). There's also ``isEqual``, which doesn't seem to work for arrays afaict.
That's mostly because it's how we've done it everywhere (docs included).
Could you wrap that to fit on 80 columns (running |gslint --nojsdoc homescreen.js| is a good praticte too)
Since isalnum etc. might locale dependent we should really just allow it for ASCII values IMHO (and EOF of course). So probably we should check for either (c == EOF || (c >= 0 && c <= 127)) here.
I'm not saying that we don't need what's there, I'm saying I think it needs more. But I wouldn't block merging this in on it because the property names are self descriptive.
Can you update this to explain what this file does?
What utility does this offer?
Thanks Yi.  I want a second opinion.  Zac?
Не только пробел является разделителем слов.
encode all of them keeps the consistency.
I would  suggest adding one more test, where we return 200 on the second try, and make sure we get the 200 response from the call, and also that num_retries is 2 ?
nope we get all the applied filters that in some scenarios are 3
Stick to the coding conventions (`$bulkStrings`), or even better name it `$chunks`
Requires Windows 2008 due to Task Scheduler API Changes
ahojnnes: Concerning peak_local_max: You mean returning the coordinates of the very one centre-of-mass as opposed to returning the coordinates of all pixels, if peaks are flat (i.e. multiple pixels have exact same intensity)? (NOTE lines 13-14 of current peak.py)

PS: How do you markup a function name so that 'peak_local_max' displays like in your post? Thanks.
Also of course the ``where`` would be unnecessary.
I could do a ``safe_boolean_indexing`` helper function but that feels a bit overkill...
You might also set self.classes_ to None if the attribute do not exit in the underlying estimator.

You could add a test with an ckassifier and regressor, for instance sklearn.linear_model.LinearRegression and sklearn.linear_model.Perceptron,  which do not define any of those.
I have some code that does this in a way that is a bit more stable/efficient with the Cholesky decomposition. Should I send you a pull request?
The other bad thing that can happen is when sumcn = 0 because all the values are really small and you might wanna go down the same block.

It might be worth simplifying things and always doing the check.
See [comment regarding localized pathauto patterns](https://github.com/dingproject/ding/pull/24/files#r538402) above.
If we remove this error message, following `Example` compiles WITHOUT errors.
It is another regression (see bugzilla issue 7786 and the outputs in 2.058).
Don't leave commented out code (or externs).. just remove it it's not needed.
To remove `else` for the general cases, and avoid goto warining:

```cpp
if (Type *t = targ->trySemantic(loc, sc))
    targ = t;
else
    goto Lno;    // errors, so condition is false
```

I think this enhancement will make an **exception** of *IsExpression*. In current, all *IsExpression* features test the traits which related to type.
But, `== template` does not. It tests a trait related to symbol (A template dedlaration is a symbol). So I like which the code for the enhancement looks specially in the code.
I'd like to separate the inherited native objects. The base class (NativeObject) should implement these methods. The TiObject classes should only know about the abstract class "NativeObject".
rename parser to avoid confusion.
I don't know where you saw that in the docs.  Make sure to use the latest version.  From the 2.1 left and top documentation:

> This is an input property for specifying where the view should be positioned, and does not represent the view's calculated position.
has been refactored to use stl
This function can be combined with the one with a parameter. Just give the param a default of NULL and check that.
The default is "blackberry.py [options]", which probably not what we want.
Just delete 84-88
Copy-paste issue (tabs vs. spaces)
This was a common issue with e.g. the Blank MFX designed for other-runtime-only support - it would return 0 for expressions and crash MMF2. Above with the Condition function, I'll have to find out if PARAM_CMPSTRING is being used and do the same - but I left that for now.
Don't you want to try and make these line up?
how about numRows(), since maxRows() implies some type of limit?
Why is .swp ignored if this isn't?
Actually, I think this should be:

```
def __init__(self, data, current_versions, *args, **kwargs):
    super(QueryForm, self).__init__(data, *args, **kwargs)
```
and then in the views... 

```
form = QueryForm(request.GET, api.get())
```
Finish with a `raise NotImplementedError(options['url'])`
It was previously Spree::UrlHelpers, but both will work in latest 1.0 and 1.1 releases and Spree::UrlHelpers will be deprecated in 1.2.  

--  
Ryan Bigg


On Sunday, 8 April 2012 at 18:29, Bounmy Stéphane wrote:

> > @@ -0,0 +1,7 @@
> > +module Spree
> >  
>  
>  
> does spree 1.0.3 has Since Spree::Core::UrlHelpers ? looks like it have been added on spree 1.0-stable only 10 days ago
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree_paypal_express/pull/42/files#r658970
>  
>
`dummy` sounds like "dummy interface" and doesn't tell exactly what it's done, imho.
I suggest `sub_lock_mode`. What do you think?
Ah ouais mais toi le champ position est déja pris par le poste...
Thats a chef'ism.  That is the nasty nested structure you have to go through to get an IP for a particular interface.  I could have made the cookbook reliant upon the following ohai plugin, which gives you nice interface assessors, but didn't want to couple the cookbook to that.

https://gist.github.com/1040543
Consider trimming what you are comparing this too.. so that you don't have that many spaces
we can, but the intention is to completely remove the triple database, which is composed of all the files in this folder.  This seemed like the cleaner way.
If I just generate a payload outside of an exploit, can and should I depend
on something in Exploit? The original motivation was for executables or
macros not tied to an exploit. And anyway, the bug I was fixing happened in
the Metasploit startup process when each payload was created to determine
how big it was. The PrependMigrate default false somehow got turned into a
string "false" in the datastore not a boolean false. (see msfdev list
discussion) So datastore['PrependMigrate'] would evaluate to true because
the datastore was not normalized. So the current implementation of
prepend_migrate? would not work, and the extra string check is necessary
here. The prepend_migrate? implementation will work, however, in an
exploit, where the datastore gets normalized.

On Mon, Oct 22, 2012 at 11:08 AM, jlee-r7 <notifications@github.com> wrote:

> In lib/msf/core/payload/windows.rb:
>
> >  		ret
> >  	end
> >
> >  	#
> > +	# Overload the generate() call to prefix our stubs
> > +	#
> > +	def generate(*args)
> > +		# Call the real generator to get the payload
> > +		buf = super(*args)
> > +		pre = ''
> > +
> > +		test_arch = [ *(self.arch) ]
> > +
> > +		# Handle all x86 code here
> > +		if (test_arch.include?(ARCH_X86))
> > +
> > +			# PrependMigrate
> > +			if datastore['PrependMigrate'] and datastore['PrependMigrate'].to_s.downcase == 'true'
>
> Why not the shiny new prepend_migrate? method?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rapid7/metasploit-framework/pull/939/files#r1905526>.
>
>
often you break these up into individual test cases - don't bother fixing until you need to edit this file again
sorry thats a sublime text tick i believe
Use @alias instead of @name.
Good idea.  I didn't know the camera had it.
Should use event.getX() since we want "X coordinate of the event from the `source` view's coordinate system."
this name is confusing because it's use in code looks just like the builtin "util" library. Calling it anvilUtil or something similar would improve readability (it threw me for a loop at first).
Isso não duplica a função de https://github.com/ssjr/rails-template/blob/17c91a6ee0c223393739b9a079d9e9df0ac88936/files/app/assets/javascripts/app.js.coffee#L7 ?
deltaAngle
We should simplify this. We don't need all these options, just one canonical one. Looks like that shoud look like this, once 1.10.0 is out:

```
jqueryUi: {
  stable: {
    "version": "1.10.0",
    "label": "Stable, for jQuery 1.7+"
  },
  legacy: {
    "version": "1.9.2",
    "label": "Legacy, for jQuery 1.6+"
  }
}
```

Until 1.10 is out, we'd just leave out the legacy property. You can still convert the top-level object to an array where that's more useful.
Yes, use of roles will have to be documented and RFCen I suppose. I've already started trying it out myself, and think I have mentioned it on the norwegian hiking pages that I've made on the wiki. Should be fine to mention it here though, as long as it is not documented on the wiki / decided upon.
Thank you for the link. Also, your rephrase is better, so I'll use that.

I'll also make better use of `LREF` in the future.
Why isn't `len` declared in the for loop?
I wasn't 100% sure it was actually valid code, or if the compiler was just erroneously accepting it. I havent seen this usage *anywhere* else in Phobos.

I knew `Take!Range` was correct, but wasn't sure about `Take`.

Anyways, I'll change it back. Want me to do it for repeat/cycle/take too?
These parameters should be set into HudConfig (position, size, color).
Can you do it?
Do you have a reference of an easyblock that integrates this so I can have a look? Currently, I don't know what I should favor because your point (@boegel) sounds also valid to me.
I wasn't sure how to wrap extremely long lines like this. How should it be done?
Note that if an error occurs half-way through here, you'll end up with neither living nor dead.

Insert the deletion first, *then* delete from the main table.

Also, if you're going for this behavior, consider extending the Fennec `FormHistoryContentProvider` class instead. It can do all of this work (adding one, deleting the other) in a single transaction.