labofsahil/github-event-dataset-2012 huggingface dataset:
it will work, but the "buttonClick" is an event fired by a module, and we prefer not to map events directly to other methods.
I guess `<header>` is OK, but I kinda expect there is some HTML5 thing for that (legend or something?).
I was trying to change <tt>location.href</tt> and location itself with no results. But I try <tt>location.hash</tt>, it would be super! Thanks.
You can do a local variable of parts[1].
if ( -> space between if and (
Please don't commit changes to this file.
You can't raise an exception. We don't know how the args are coming in. If you raise an exception for WEB, CLI never gets done. Validate ARG is a per var validation. It may for may not be a stopping point. Which is why the Slice does the exception raising. This is just a util method. The Slice hold the gating logic.

It is checking if it is not empty + and is not an empty JSON object.

It is not just an empty Ruby var. And notice above in 1.8.7 an empty hash does not show as empty which is why the rspec test failed.
You're setting this explicitly, then testing for it, which is redundant. Did you mean to include `requireScrolling` as an option?
"take the win" is clearer.
of == on ?
Oops - did I add these?
I'm pretty sure exec'ing `python` invokes `python2.5`, and not Python 2.7 (which isn't installed on the VMs by default and I don't see changes here to install it). We definitely need this to be Python 2.7 - can you look into changing this?
If easy, change only the query string.
no need to `url =` if you return it
`filetag: filetag`
I don't see why using 2 sets of braces around it would be a best practice
No need to force to `Boolean` value as comparison would be already `Boolean`.
#nitpick params plze
blank? :-) nice... should I change the pull request or will you make the changes?
This looks like a weird change. Why isn't the prefix needed any more?
here GetXFFIP is called with flow lock (because of stream callback)
265 | ERROR   | Whitespace found at end of line
Could you send the `parent.location.href` as well, to check that both `top` and `parent` are as expected?
For something that is part of the API used by subclasses, I would generally not use an underscore prefix.
nit: please fix the indentation of the dot. It should be under the 'C'
If aOptions.length was 0 this._length is now 60. I don't think that 0 is even a legal parameter.
Avoid the use of AbsoluteModelPathExpression, it doesn't make sense in this case.
I renamed `this.unpin` to `this.unpinned` to avoid collision with the new method of the same name.
s/g/graph for readability
clearfix isn't necessary if you use my favorite inline-block hack.

I always feel compelled to mention it. Because floated columns are messy.
actually this was needed in order to get the tests running.
Shouldn't this be typehinted?
I removed it on purpose for readability (continue statements are more difficult to follow). As we see now that is just a matter of opinion :)

What does the coding guideline say? I'll be happy to change it if needed.
Why is this needed, exactly?
This entire class needs commenting.
Requires license
Please do not use global variables.  I don't like this solution at all.
also, re: isalnum - apr_isalnum is used in cas_char_to_env which ends up expanding to isalnum (http://apr.apache.org/docs/apr/0.9/group__apr__ctype.html#g4fa78e6e7272dae64731768a17a2e003).  Will add a commit soon with our own local implementation which checks for [a-zA-Z0-9] via isupper(), islower() and isdgit() which seem not to rely on locale.
Lower possibility to create collision ?
I'm a little bit confused as to what this function is doing.. can you explain?
We want to be able to obtain the Enchantment object, not an enum.
getOwner().getData()
What is the purpose of the try block?
It's a class method, so there's no instance to know self.caches - the caller only has access to the download_id
well, it is about handling the Selectable implementation for the PersistentCollection using the persisters, and all other stuff managing the work in the PersistentCollection is in the Persisters namespace. So IMO, it can stay here
This actually never gets used. Or at least hasn't so far, the form for making a comment is in a partial, views/partials/_comments_form.html.erb.
I believe a lot of generated code regarding comments is never used
Fair point

On Wed, Oct 31, 2012 at 4:37 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/enum.ex:
>
> > @@ -68,6 +68,8 @@ defmodule Enum do
> >    `{ key, value }` tuple.
> >    """
> >
> > +  @type t :: list() | tuple() | fun()
>
> The iterator is already a protocol and as such it already defines its own
> type. All we need to do is: @type <https://github.com/type> t ::
> Enum.Iterator.t :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/601/files#r1990852>.
>
>
Seems that `array_merge()` is used here on purpose. Maybe let a comment here in order to avoid regression on refactoring :smiley:
Why not? :P
add an extra `##`
This probably could be DRYed.
Why not `get_absolute_url` ?
Max int is db backened specific right? Is this the MySQL value? Even so this seems unnecessarily large.
That link doesn't go anywhere.
Ok cool my mistake.
1. If the name filter is already part of the added filters, do you really need to OR it with fullname? Perhaps filters in es_filters are joined by AND instead of OR during the search? If so, then you'd have to remove the original name filter to make this work correctly.

2. You don't need to create dicts here and then deconstruct them into keyword arguments, just use kwargs directly:

```python
es_filters.append(F(name=query)|F(fullname=query))
```
Oops, the change is actually below, not above.

But we do need this, or need another solution to the problem.
The classes here should be navigation actions and the role should be navigation.
doh! got it!
yes, you can easily see this stuff doing git diff before you push
This would make the graph for the single trend show all the trends again.
i think this should not be a debug level, info or warning?
Should the cursor for the disabled state be the new CSS3 `cursor: not-allowed`?
We need to extend this now. Are you familiar with "currying" functions? Have a look at this for example http://code.activestate.com/recipes/52549-curry-associating-parameters-with-a-function/

I think something like this could work too:
`upload_to=lambda *a: _upload_to('event-placeholder', *a)`

You get the idea. Basically, the type of file (based on the model field name) would be part of the file path.
Oops yeah :/
Do you want to just delete all these?
nit: you're missing periods at the ends of these sentences.
This section is what's new in our public Binary extension of `javax.jcr.Binary, so this is really the only part that changes for clients. The Key is immutable (we don't have visibility to our @Immutable annotation), so I think it's okay to expose it.

But this is what I'm most concerned about. Is this acceptable? Do we want to avoid this?
```js
server.listen(0, function () {
  port = server.address().port;
});
```
I don't mind removing them in order to stay consistent with the rest of the module rather than satisfying PEP-8. ;)
I strongly object to "just picking" SI, because I agree with @adrn that this would lead to far more confusion because it potentially introduces a new unit that wasn't in either of the left and right operands.

If you really don't like picking either the left or right unit, I think the only option would be to raise an exception if the units don't match.  And maybe that's better in all honesty, because that's what `NDData` does (and we want to be consistent)? 

Also, addition over reals is commutative, but if you remember group theory, there are plenty of non-Abelian groups... and anyway, the actual addition operation itself is still commutative (as long as you cast into the same unit at the end).
Alternative way:

```ruby

<ul class="unstyled">
  <%= content_tag_for(:li, @subscribers) do |subscriber| %>
    <%= image_tag subscriber.avatar_url, alt: subscriber.name, class: 'avatar img-rounded' %>
    <%= link_to "#{subscriber.name} (#{subscriber.github})", subscriber.github_url %>
  <% end %>
</ul>
```
Just index, since it keeps track of us visiting this item. 

CURR_DIR_ITEMS counts the number of items we have actually added to a directory, but since we don't add the "teckentolkad" items, we don't count them.
How about we assume the server will return a `:message` key in its response, and just output that? That way we can change the URL without having to update the clients.
Don't believe this namespace is used in here
should respect "visibility options"
This can now be tested.
After discussion, we agreed to let this go as the additional line would not simplify any of the other lines.
I'm still tempted to not pass in the %% signs and construct these inside of the API instead.
The userid should not be directly on the request object anymore. It should be retrieved from req.ctx.user()
I would actually prefer to leave this as is. _multiGetAuthzGroupMembershipAncestry hasn't done any validation on the values it passes into getRolesForPrincipalsAndResourceType as soon as we're past the initial loop. I'd look to keep the validation just as a sanity check.
Locale and timezone should be optional and should default to default values if not provided (which can be configurable later on).
It should test that the scala library is placed on the bootclasspath, and not on the user classpath when the build manager compiles code. If it's white, let it be white. :)
Ooops. Sorry, my mistake.
Why taking only the first 5 stack frames?
Maybe:

```
if original_path and original_path not in new_elements:
```

would be clearer.
Is there a special reason for making and calling this as static?
Thanks narfbg, forgot about objects, booleans, etc. I'll fix and include changelog modification, then check if the user guide needs changes. The docblock already says "mixed" as the $rules param type.
I changed this to APC while I was testing locally, never changed it back.
А если x>100?
чертовски опасное сравнение слева. вам в задании сказали что X это проценты. как только мы поменяем размер цепочки с 100 на любое другое число, в этом месте неявно, незаметно, вы станете сравнивать проценты со штуками. искать эту ошибку будет очень трудно. лучше бы так не делать.
причем вы и комментариями это все не снабдили. через месяц вы потратите уйму времени на то чтобы разобраться в вашем собственном коде.
после ревю исправлю)
Since we calculate the build number above, seems redundant to also do it in `setBuildNumber.sh`.
I just added the prefixes in another commit, for form (didn't hurt). Either way, just be sure to remove the option in .csslintrc if so.
Here lies the basic effect for the in-app notifications. My idea is that this is expanded out, and pulls from a json feed maybe?

Notifications can then be queued, only displaying the most recent notification for each session however to prevent lots of notices for the same session.
I'd use a code format for this @article_pages
The real effort of this block is replacement of "insertid" with "returning" JDatabasePostgresqlQuery element.
I'm thinking a better solution than existing and than this change.

Ps
platform code has to pass some code style check, this change will not pass them.
`} else if {` should be on the same line
Interesting part starts here
Thinking about it more, I agree with Checkout requiring a working directory and throwing a `BareRepositoryException` otherwise. In this case, would it be best to add another method that handles just updating the active branch? I can update those existing tests (maybe combine with some of the other tests I added) to run against a standard repo.
This should rather be the following, shouldn’t it?
`update_resource(storage_json, resource_xml_string, digest)`
My idea was to add it so people could easily inspect the projs, similarly to ch_names (which shouldn't be modified by users either).

I'm not really opposed to removing it..
Would add a pointer here as well. May be we should do it everywhere we use it.
Also run L21 and check that we get the same
+1 to both these comments
same here, you can get rid of the local variable
Hm, maybe we should make the parameter `a` lazy too? So it should have type `Function0<A>` instead of `A`.
Fixed. Returns a resolved promise now.
:+1: win
Say that again?
To make this more clear, I suggest to not use a method but directly put in an array:

    $availableLocales = array('fr', 'en');
This should be `// ...`
This code will change once we support third-party apps.
This is not a mailbox either
Слот поехал и пробел перед скобкой нужен.
ListingRole::ID
Я думал об этом. Придется еще один сигнал в ядро добавлять
¿Quisieras que siempre mande fecha-hora y que descarte la hora del lado del cliente?
suggest one function:

```
(defn add-package [system-name {:keys [packages package-groups]}] ... )
```
variables names should be lowercase
Check for duplicated file based on their sha256 check sum
Seems like the above options should be stored in ui.config as defaults?
@icedfish 

最后那个 & 写的好狠

是不是注明一下 *inx Only
Outch right. Refactoring Hell. Extracted method and changed signature Duh. Will fix
looks like this change is not needed.
`sort` is definitely not what you want here. I think you might need `reverse`, but you should fix that issue in `my-take-helper` instead. You just need to construct the new-coll in right order (which would be just the opposite of this). No points from this one.
Yeah, oops, fixed.
This will execute `DC_RSS_NS()()`.
Same here as per my `test_browser_cell_data` comment.
Sorry, I forgot about responding to this - I've added a commit that deals with that now.  Thanks for the feedback...
`Ma préférence est de garder` is not fluid french...
But how could I write this different, so that there is not only one if?
@nicolaasmatthijs Missing space between `)` and `{`
Podle tý podmínky a konstrukcí v timer_callback to teda nejspíš vypadá, že je to seřazený logicky, tzn. první na začátku. Nemůžu se ale ubránit pocitu, že tady máš chybu. Když ten while cyklus skončí, tak tmr->abs_expiration_time je menší než i->abs_expiration_time, tzn. patří logicky do seznamu před něj - ale ty ho dáváš za něj.
Koukni na to prosím - pokud mam pravdu, mohlo by to vysvětlovat, proč mi ty timery nefungujou..:D
Why don't we use rspec-mocks? Is it not relevant if save was called?
I think we should use a font-family name that's more specific to the library, so it's less likely to collide with other things on the page. How about `__webfontloader_test__` instead?
I'm also inclined to return the htmlentities, including the quotes and utf8 options, to handle the character encoding issues that come up.
I'd have gone with something other than "old_XXX", maybe "orig", maybe "starting", "old" sounded strange in my head.
Are you sure ``$this->resultId`` has the correct type as ``resource|null`` is not a sub-type of ``resource``?
My comment can be removed now.
I was ignoring potential invalid stuff, looks like a wrong move....
This is wrong. The library is using the MIT license.
I don't think so.  Phantomjs has supported an X11-less setup since [v1.5](http://code.google.com/p/phantomjs/wiki/ReleaseNotes#PhantomJS_1.5_"Ghost_Flower").
Asynchronous function doesn't usually return value in a way that we can use it like this. The boolean is carried over by the  `exists` value you get in the callback. Can you drop this if statement around `fs.exists` ?
the calculations in calendar.jsp are based on teaching starts date
see also the modifications re daisy/nondaisy courses and applyFrom text
Can't find this string, I will remove it.
@thoughtfusion I commented this out because it was causing the test to fail. The hotel type returned wasn't correct to have bed types.
Does that information reveal an issue with the gem?
Hmm, I tried looking, but I don't think I found any (well, `backends.py` lists fields, but not types). Is there an example for docstrings?
You can install pymongo manually:

```
pip install pymongo==2.3 --install-option='--no_ext'
```

Does this work for you?

Can you comment here which exactly command for running celery are you using? I think it is time that we add instructions on how to run everything on Windows because there are problems again and again.

> can't compare offset-naive and offset-aware datetimes

Can you provide me stacktrace or more detailed information about where does this come from?
We have space after the colon, but not before.
So here should be something like:

```
url(r'^api/', include(v1_api.urls)),
```
Confirmed good for now, change for next release.
Why did you indent `$map` so far
@ntalbott I fixed this, defaults to false & added some param cleanup code
CamelCase for members.
And what's up with the struct name? i dont see anything "random" here.
There was a discussion on aeolus-devel and there was agreement to embedded the xml instead of cdata. You brought up security/exploit concerns which are valid. We probably need to discuss this a bit more. There is a nesting issue with cdata which may or may not hit depending on how the deployable xml evolves: https://lists.fedorahosted.org/pipermail/aeolus-devel/2012-December/013516.html
check against new commit

this section is messy - see your revised ncbi gene parser.
I will add this to check, to ensure that the owner is not the current user before setting the sharedACL.
camel case method name?
why a new util module since it's used both used in circus/ and circus/commands.  Sounds like we should keep a single util module in circus/
Does not seem needed since qBtSession stores the default save path in a member.
This header should be called Notes.
This was a typo that affected all LikelihoodModel, not just l1.  However, it seemed like a whole new pull request just for this would have been overkill.
That has subtly different semantics in that it makes :namespace take priority over :prefix_key but if you're happy with that then fine.

The problem with the original ||= approach is that it winds up creating an options entry with a nil value if neither is set, which then stops the default value being applied.
CollectionUtils.isEmpty
Yo dawg, I heard you like videos, so I recorded a video of a video so you can watch while you watch.
On Jul 4, 2012, at 12:04 PM, Mike Jarvis wrote:

>> @@ -453,6 +456,8 @@
>>     /**
>>      * @brief Linear interpolant
>>      *
>> +     * The linear interpolant is a poor choice for SBInterpolatedImage, as it rings to high
>> +     * frequencies.  (See Bernstein & Gruen 2012 for details.)
> 
> This comment and the one for Nearest only apply when doing FFT convolution.  When doing photon shooting, both of these are quite efficient.

Very good point, updated.
The way I read etc/maglev.demo.key it doesn't restrict the numbers of cores.
Resource handlers are fully initialised in BrooklynService (in a single thread) before starting accepting requests.
StringBuilder is better for single-threaded as not synchronized (but too minor to care about here).
hmmm nope, $name is not what we want. If we provide aliases, they *have to* be in the certificate. They are in the generated CSR.
In our usage, $name is something like project_name, while aliases are correct URLs.
Using $name will break most of our projects, break deploy method and so on. bad idea then.

OK for port number, I'll have a look at that.
The problem is space - there's only so much room to show numbers here. We'll need to rethink the UI if we want to show more. 

Your original tooltip code is here: https://github.com/google/tracing-framework/commit/538fb2485a3fd67549f73ac719026aa3959a0906#L3R404
I can't get it to behave in a way that doesn't blow out the numbers, make them so uneven as to be distracting when scanning (12.456, 12.4, 12.39, 12, etc), etc. If you'd like to tweak this some more please feel free!
Shorten things up:

    every 1 year

Becomes

    yearly
> The client doesn't know what the condition is, no?

It does and should.

> I was thinking about having a special header X-Lock header that we could use to handle this kind of case..

you are reinventing the wheel.

Here's the protocol, roughly:

1/ GET a value - that returns the value with a ETag header that's a hash of the response for example

2/ the ETag can be used to cache the values in the next GETs, by using the If-None-Match header with the previous ETag value.
   The server can return a not modified error if the value has not changed

3/ on PUT, use the If-Match header with the ETag value you got from the GET, the server will return the 412 id the ETag does not
    match the existing server-side value (==someone else changed the value)
I can no-op the logout function. If anything, though, this enforces the idea that we really do not want to include preventDefault() on the action.
I'd prefer a comment explaining what the line below does rather than providing this info; the link above is enough instruction.

In fact, this line explains itself, although the `navigator.id.request();` above could use a comment like `// Triggers Persona login dialog.`.
This should probably include the `.browserid-login, #browserid` selectors from above, in case the `.display` class is used by the site already.

`.visible` might be a better name for this as well, given that we're using visibility over display.

So something like:

```css
.browserid-login.visible, #browserid.visible {
```
Shouldn't the `clean` method take care of this version-specific logic?

Otherwise client code will have to inline the same checks used in this test.
No, you have this:

```
gist L<gist|https://gist.github.com>
```

it should be
```
L<gist|https://gist.github.com>
```
I just committed and push to my own origin master. Is there anything else I need to do? Appreciate the help.
fixed up per your comments
Well, the code as it is now makes it extremely simple to insert an assert, error, or warning call in there to deal with badly behaved client code. Since I don't know how exactly you would like to do it, I think it would be best if you make this 1-2 line change after puling this request, no?

Of course, if there are other changes you'd like to see, let me know.
Please create a seperate pull request for this part. It is not part of the Async functionality of the rest.
s/IDentifier/Identifier
I realize the current name is kind of a mouthfull, but I feel like "enableLogging" is misleading- we're actually logging about a particular thing. I tried variations on "logMessages", "logMixpanelMessages", etc but the word "Messages" by itself is ambiguous- it sounds like I'm talking about a "log message" rather than "log when you send messages", thus the giant "AboutMessagesToMixpanel".

There is probably a better name (and I like getting rid of the boolean) - any other naming ideas?
two "the"s, here
We should use triple double quotes here as per pep8 http://www.python.org/dev/peps/pep-0008/#documentation-strings
可能性があるに修正しました。
元々の意図として可能性があるだと失敗しない時もあるように読めて、モック生成に失敗している場合はカスタムのencodeAsXXXの呼び出し時に必ずMissingMethodExceptionで終了するはずだと思ったのですが、きっとencodeAsXXXをテストのなかで呼び出していない場合もあるから「可能性がある」で良い気がしました。
All parameter validation should be done int ``fit``.
This is because for example grid search ``clone``s an estimator and then sets parameters using ``set_params``, not via ``__init__``.
Also, I wouldn't do the ``lower``. I think users can be expected to adhere to the docstrings ;)
What is a typical license for these sorts of things?  I'd like to make licensing as painless as possible.
For readability, I would prefer if you could write this 'normalize(transmat, axis=1)'. Thanks!
> If I get your point, I can just safely delete the this function and the next
> function for now as they are not implemented?

Yes
Since you used `//` division on the previous line, the `int()` call is redundant. Likewise, you should probably use `//` instead of `/` on this line as well.

`int()` is redundant on the next line as well.
The if this block is in can be removed, right?
There are four states: outside of the contract, inside invariant, inside in contract, and inside out contract.
And I use bit5 and bit6 to represent that. So this is intended.
Please try to find better names for the enum members, or at least move the documentation from CallExp::semantic here. I've already done quite a bit of DMD hacking, but still find many pieces of code much harder to read than necessary. For example, with all those undocumented integer suffix symbols (`toParent2`, `toMerge2`, `toCBuffer2/3`, …), you pretty much have no other choice for making sense of them than either looking at the implementation or searching the source code for other occurrences and trying to infer the sometimes subtle difference in meaning from there. This is incredibly disrupting if you are really just trying to make sense of a mostly unrelated piece of code.

Well, here you could argue that `2` represents the number of parameters, but that's far from obvious, at least given the suffix »convention« used elsewhere in DMD, and in any case much less clear than necessary.

What about e.g. `PROPufcsGet`?
Because `unittest` doesn't appear in generated header file.
I would expect that the issue would be raised at the time of creation..

In any case, that's deserving of a comment.
I can rename it queryResult
I will remove all the conditional code.
Doh - yes
ignore that you're wanting it as a floating point number
I can remove that now, I had it as npm install -g less and if I ran that without sudo I ran into problems but, because we are going to leave the instruction for installing LESS as a local module, sudo is also not needed anymore.
Any particular reason for carrying this `CDATA` cruft in? If we're not going to do byte by byte warts comparison I would do away with it now.
Change this test to not depend on mocking `request.get`
I'd recommend calling it "private" or "public" and making it a Boolean - any network choice for showing certain bookmarks to friends only can be adapted later, but making this a string will give us a lot of headaches.
can Likeable::Dislike be a subclass of Likeable::Like ?
you should split this messages on multiple lines, ie:

```Objective-C
AFOauthAccountCredential *credential = [AFOauthAccountCredential credentialWithOAuthToken:[responseObject valueForKey:@"access_token"]
                                                                              tokenSecret:[responseObject valueForKey:@"client_secret"]];
```
Kan je overal de 'remark:' lijn aanpassen zodat hij conform is met de rest, zie bvb florennes_ctr om te zien hoe je het doet.  Hoe conformer alles is, hoe beter en hoe properder...
Should be: `$this->isRetweet;`
I don't see the purpose of this change. ``client.get`` returns an HTTPResponse, while ``RequestFactory.get`` returns a Request.
I think it is useful most to test if we don't break compatibility with these versions. The code standards must be compatible from PHP 5.2+ since we use and support it into CakePHP 2.x.

One exemple that could break the compatibility is the new sniffs for CakePHP 3.x, which use namespaces, traits, etc.
`(or (apply <= a-seq) (apply >= a-seq))` would do the same
Tässä pyydettiin käyttämään destrukturointia. Ei pisteitä.
Typos.
s/PoweShell/PowerShell/
s/path the a/path to a/
I believe there are some ConnectionErrors that shouldnt be rescued here (as the original logic). At one point ConnectionError didn't include HostUnreachable
If you don't, it will automatically add a blank space when there is not a role descruption.
Is there a reason you are manipulating the GUID rather than just calling `createGuid` directly?  If there is a good reason for it, we should at least have a code comment indicating it.
> Again, not sure about console.* calls.

Well without this the problem will be silently ignored, which seems bad.  To avoid the console.log, you just need to add a handler for the error event, even if it does nothing.
You are mistaken.  You can absolutely call the local private methods in public functions, but instead of using the `this` parameter in the local function, you have the first parameter be the instance parameter and use that.

```
function myPrivateFunction(Material material, arg1, arg2)
{
    material.someValue = arg1 + arg2;
}

Material.myPublicFunction = function()
{
    //do stuff in my public function

    //call private helper function
    myPrivateFunction(this, arg1, arg2);

    //do more stuff
};
```
This should be:

    logger.error(__('Unknown project template %s', cli.argv.template) + '\n');
I didn't think we really needed a new class for "repeatable", since whatever the styling on "optional" is/was, I  imagine it's just fine for "repeatable".  And I guess with jsduck in use now, it doesn't really matter??
validate the form*
Same comment--why leave the other method around if we're just delegating to this one? Couldn't we just widen the parameter type it takes, without breaking anything?
It might be better to use [`Socket.gethostbyname`](http://ruby-doc.org/stdlib-1.8.7/libdoc/socket/rdoc/Socket.html#method-c-gethostbyname) here: the `resolv` library implements a full DNS stack by hand, while `gethostbyname` uses the standard NSS path to resolving the target system.  They should be similar in most cases, but it feels more "right" to go through standard NSS.
Это не приватный метод же, это в том смысле что напрямую вызывать нежелательно. Исправлю энивей.
как @pipe по-моему нельзя, там this ставится в дефферед только внутри аргумента к $ .Deferred
working on that @lsmith77 @Seldaek
You could make this test cover both litmus. They're quite similar.
If we end up agreeing to not add a global `DollarToken` we might migrate it inside this type.
Please don't use "l" as a variable name.
You'll probably want to remove the "+2" at the end, it only makes sense when accounting for the [ ] brackets in my particular use case.
Doesn't `jasmine` gem need to be listed in the gem spec?
Yeah, sounds good to rename this. I like notifyChanges, notifyWatchers, or notifyObservers
Thats what I was thinking also, but noticed when launched from eclipse the ```TERM``` variable is set to ```xterm```.  I'm definitely open to other ways of doing this, just not sure if environment provides it directly.
I just noticed this comment is wrong. fixing...
Does JMeter only support JUnit as testing framework? Or could we use TestNG here as well?
This sentence is confusing. How does this sound:
The REST exception is first handled by RestExceptionMapper, which then delegates it to the DeltaSpike RestExceptionHandler. That handler uses the ResponseBuilderProducer to create a instance of a javax.ws.rs.core.Response.
I'm not sure that service registration file is what the JAR specification calls service providers. Worth double checking.
I can live by that; but pls add comments to the interfaces in this case

On Wed, Jul 4, 2012 at 12:16 PM, Felix Mayerhuber
<reply@reply.github.com>
wrote:
>> @@ -27,24 +27,25 @@
>>   * The EKBCommit class contains all necessary information to do a commit to the EDB through the EKB PersistInterface.
>>   */
>>  public class EKBCommit {
>> -    private List<OpenEngSBModel> inserts;
>
> But in the addInsert, addInserts and so on I will stay with object, since otherwise the user would have to check and cast the models on his side.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/700/files#r1099362
Also Latin obviously doesn't have the word "Internet" so I had to improvise a tad using the Romans' thought process and cultural background.
Added, I don't know enough about this ;)
I wonder if `<label/>` is more semantic than `<span/>`.  `<label class="label">` is just overkill...as you obviously identified.
There's already a global toggle for subtitles. No need to enable/disable on a per engine basis.
Whoops, that's wrong.
Creates a <href="CustomPropertiesDictionary"/> instance with default parameters.
constants are all caps
fixed this same bug, but you've beaten me to it!
~n is not needed.
This array is going unused, as immediately below you're calling a function which is returning a _new_ array and assigning to this variable. Collapse these calls into one:

        float[] size = makeDataArray(fields);

and then delete the `sizeArrayLength` declaration above.
Symfony does not split the use statement into several groups
Hast du das getestet?
Kann mir nicht vorstellen, dass das funktioniert!
чому в suggest? заюзати DoctrineFixturesContext можна лише, якщо є фікстури, а їм потрібна бібліотека "doctrine/data-fixtures".
ups, this must have worked because of using some stale code in my setup. thanks for spotting
Я поставил дефолт как в kvirc
Yes; won't hurt; it's not worth a new JIRA/PR just for that; just put a note in the commit comment.
I think you can simplify the overall logic by always setting an expression (uri or uri-expression)
We do it in many places
You'll have org.springframework.expression.common.LiteralExpression for url and the logic you have for uri-expression, than in HttpRequestExecutingMessageHandler you can have a single attribute (e.g., uriExpression)
That test just asserts that the iterator() returned 3 groups (correct), but this test case did not detect that the groups (incorrectly) contained zero messages because the keys didn't match.

    assertTrue(group.getMessages().size() > 0);

Add that, and then 

    git checkout master spring-integration-redis/src/main/java/org/springframework/integration/redis/store/RedisMessageStore.java

and you'll see what I mean. If this assertion had been there originally, the bug wouldn't have made it into the release.
I think we should, reason being, we are internally changing the implementation but the behavior of the adapter should be consistent with pre 2.2 version.
Amol, Artem's comment is not about the @ Override annotations (that is the correct setting - to include them - but NOT for interfaces, which is a Java 6 change).

His comment is there is no need to override these methods at all, because the override does exactly the same as the super class (false and true respectively).
true ;)
Yeah - I guess it is quite ambiguous.
I'll merge in the other changes shortly - thanks for the contributions!
please remove one #
you need to add the missing key at the end of the file, and add the key on each catalogue
Let's simplify this form: 1) remove labels 2) display the month drop down first.
Okay... so this makes more sense after talking to walt. Couch does this funky thing with _all_docs:

curl -XPOST -H "Content-Type:application/json" -d '{"keys":["stuff"]}' http://learnreg1.sri.com:5984/resource_data/_all_docs 
{"total_rows":433280,"offset":0,"rows":[
{"key":"stuff","error":"not_found"}
]}
and I had already changed, so I'm reverting to previous state
Each length of text starts its numbering back at 0 so we only need to check the largest text length numbering.
Ya unfortunately it can, each if statement will keep lowering the endBlockNumber, its easier to chain if statements rather than use min because ceiling can return null and the code is even messier.
Do you need a visibility `public` here?
Correct channel name is _#mantisbt-help_ and I think it should be mentioned that it's on freenode too.
Will this require retranslation? To be completely accurate, yeah - but for now it has the same key so other languages will still say 'Data'
Leaflet does have a `stable` branch, but I don't know how closely that tracks official releases. I also don't know what Leaflet's schedule is as far as getting a release that includes for example the RTL fixes. @mourner?
це english?
the hardest line is missing, we will need this for tomorrow:
`blog.setInRelationToFormattedAnnouncement( ??? );`
Is there a default?
No problem. Do you want me to remove it from this patch too, or will you fix both in one go?
I came back to this issue, and I'd like to say that this very piece of extra code is to solve my issue with `create_role` function creating roles with higher and higher `id` (PK) values. It irked me that after importing the roles all of a sudden they had different id's than before, so I wanted roles' id to stay the same if possible.

After giving this problem a second thought, I have come to the conclusion that your first allegation concerning lower PK autoincrement than imported id's is really valid. I've missed this case because our installation is uniform and this problem does not occur.

Now I think the code should do this: first check if old `id` which was exported to XML is lower than `id` of newly created role. Only then the check if no role with old `id` already exists, and possibly update should be performed.
Pelkkä `""` riittää.
I tried changing it based on your suggestion and then realize the real problem is that the lang array must be declared dynamically. So I must first find out which language it is and declare the array if it hasn't been declared. I have to keep it the way it is.
@kwallis Perhaps this is your domain. Do you want constants to be enumerable based on the above understanding?
I'd still revert this.
I am going to remove the `datetimeoffset` and `time` data type assertions. I have no idea if these are even correct and until FreeTDS supports them, I do not want to canonize tests for them.
Ah, that makes sense.  Let's add something to the docs to point people in the right direction.
This certainly doesn't belong into the PR.
`(* -1 x)` = `(- x)`