labofsahil/github-event-dataset-2012 huggingface dataset:
I think it's okay.. maybe change the extension from .mdown to html and
leave it at that? If you decide to update the why.html you can just copy
paste it / make a script that does this. It's painful to go rewrite all
that html in markdown again.

On Tue, Feb 28, 2012 at 10:25 PM, t-saideep <
reply@reply.github.com
> wrote:

> I think markdown provides primitives for most of the formatting and HTML
> is probably not necessary. I'll take a look at this.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/t-saideep/link-board/commit/3abd8a26098e09fa432bad6f54b1321400189fa8#commitcomment-1024191
>
Theres no need to remove it, I will push my changes soon and you should pull the selectmenu branch before working local again.
With word = new Word() , we can easily add a Word.help property to show this word's help message. The help will be going together with the word. Very easy for reference. This is an example.
Is there any reason why this is not still "javax.mail.internet.MimeUtility"?
People have to develop also in browser < IE9 to test the side, so local is an important part. Can you add it locally? I think we should use modernizr, as boilerplate also uses modernizr. at the moment we have too much features, but you never know ;-)
On Mon, Feb 20, 2012 at 2:11 AM, Keshav Kini
<reply@reply.github.com>
wrote:
> Hi William,
>
> You should base these commits on the branch `master` and not the branch `github-master`. The latter contains an extra file (README.rst) which you won't want in your eventual trac patch. To fix this now, do:
>
> {{{
> $ git checkout lfun
> $ git rebase upstream/github-master --onto upstream/master
> }}}

deep:sage wstein$ git remote add upstream git@github.com:sagemath/sagelib.git
deep:sage wstein$ git rebase upstream/github-master --onto upstream/master
Usage: git rebase [--interactive | -i] [-v] [--force-rebase | -f]
[--no-ff] [--onto <newbase>] (<upstream>|--root) [<branch>] [--quiet |
-q]

>
> (The `--onto` stuff might be a bit confusing. Normally you shouldn't need to do rebasing, though.)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/williamstein/sagelib/commit/f4104efd87cb421923f884f8ea5c571fa52d583b#commitcomment-985116



-- 
William Stein
Professor of Mathematics
University of Washington
http://wstein.org
Yes, these are coroutines, you can't call them directly (instead of returning a value they call produce()). The top example here: http://julialang.org/manual/example-programs/ shows how you can call these functions. I used coroutines as Jeff suggested because of the staggering size of most combinations and partitions, and also because I'm not as familiar with the methods to write like an nth_combination() or nth_partition().
There are comments. 

They mostly come out at night...

.. mostly.
Just trying to keep formatting consistant in each file :D
--header-html should be --footer-html
Is the find count updated during other load operations from gc.com? If not  with this optimization ```cgBase.getActualCacgesFound() ``` would always return the same value for each online log. Right?
Thanks to @schmittjoh for setting up the issue for this: #748
Whitespace! aaahhhhh!

TextMate should just set these by default when you install it. Then vim people won't go crazy.

[core]
    whitespace = trailing-space,space-before-tab
[apply]
    whitespace = fix

Just have to use git add -p instead of git add . or similar and it'll filter trailing whitespace.
and by cod, I don't mean the delicious type of fish you find in fillets.
Yes I saw this before I started work on the schema support, but forcing arrays means that every property gets turned into an array, which is certainly not going to be desirable in many (most?) cases.
Let's add a comment here explaining that data-url is required for no-js operation.
`hlistFilter1`?
Probably I will not finish this rewriting because of my lack of interest in mangos lately... But still nothing is settled.

Whatever will happen, what was written is and will be available for anybody who wants to use it/change it/rewrite it in better style etc. ;)
There should be a new bus message that'll notify all components that language resource was changed and they need to reload their strings.
The change in UIServices entails the following API tools error in this linie:
The minor version should be incremented in version 2.1.1, since new APIs have been added since version 2.1.0
CloudFoundry. For the record, this was later discussed by me and Josh on IRC.
Wasn't this done already? I don't understand... are you using the AXRWrapper from the parser somewhere new or was it an oversight on my part?
creo que si, coincidio justo que lo subi y se jodio.
Instead of Rare Salvage, maybe you should lose 1 Trauma die? Makes more sense with the flavor text.
des segfault? >.<
Utilise le debuggeur, ça devrait montrer la ligne ^^
Not saying that it's a bad idea to do it the other way.

I did it that way with C.Tx and it's pretty messy after a while to keep track of those flags, since I tend to add more logging to my code than what's in the MT codebase.

So: If (Flag) Log speed > Lambda speed > format everything speed

It's really just a preference kind of thing...
Do we need this, since we already have another mutator that show how the mutators for applicative messages work?
Done. Now the MessageMutators assembly is droppable and registration of the mutators will be done automatically,
Did this really compile ? :o
its really working?
See:
https://github.com/travis-ci/travis-cookbooks/commit/9dd192a73db1db1840a59a6b2ce334832152c04d
https://github.com/travis-ci/travis-cookbooks/commit/9b32755ef5d74830191e647c6ed6caa679b01558
https://github.com/travis-ci/travis-boxes/commit/4fc21f30d6c447cbb76a6d6d72b7d900b2b053f1

:-)
Then you wouldnt need the xundo after the kick in my opinion
Good move.  Thanks bob!
I did too much tries…. I'm not very good with ipv6. So that's a mistake.
You mean including package prefix?
no release if you haven't used method that starts with "new" or "alloc"
You forgot to add the updated .ui file for Pokeedit, so I can't compile this.
Apparently github does have live-preview I just didn't spot the button :-/
On the whole, it looks pretty good Philipp!  I'm hoping to get a chance to try it out in the next week or so.
In re: We might think about adding .ENEE150CompilerOutput to the .gitignore patterns list.

If you're putting the file in the user's home folder, it won't be in the GIT controlled subtree
https://gist.github.com/1844853 - that's a gist of a basic, working rack/unicorn setup with webmachine_ruby that I have worked out
public String translateWord(...) - ის ნაცვლად რომელიც \n - ით კონკატენირებულ სტრიქონს აბრუნებს ხომ არ ჯობია ჩანაწერების ობიექტების მასივი დააბრუნოს? მაგ: public ArrayList<TranslationEntry> translateWord(...).

იტერაციამდე:
ArrayList<TranslationEntry> result = new ArrayList<TranslationEntry>();

for(...) {
  String source = ASCII2UTF8Converter.toUTF8(cursor.getString(0));
  String target = cursor.getString(1);

  result.add(new TranslationEntry(source, target));
}

...

return result;

ხოლო ფორმატირება გააკეთოთ მხოლოდ იქ სადაც უშუალოდ აპირებთ უკვე ამ ტექსტის გამოტანას.
Check how parsing code in execute method handles situation when it optional.
the project creator is working against the new paths in develop but deploy examples will be broken...  I need to fix one issue with osx recursive folders but besides that, it's almost there.   will check it in shortly in dev apps....
I don't think so. One goal of this functions is type less. `db->q` is even shorter, but is not intuitive understandable. `db->sql` is.

Also, I think the word `sql` is logical when module can only three databases: mysql, pgsql and sqlite.
I won't load local suffix test for this app because of wrong suffix

The correct variable should be ```LETSVOTE_CONFIG_LOCAL_SUFFIX```
You can just have this filter in add_menu_page.... no need for a separate method
Stick to uppercase - it's what the specs use, and some user agents may be case-sensitive.
Take a look [here](http://docs.python.org/library/configparser.html):

    Configuration files may include comments, prefixed by specific characters (#
    and ;). Comments may appear on their own in an otherwise empty line, or may be
    entered in lines holding values or section names. In the latter case, they need
    to be preceded by a whitespace character to be recognized as a comment. (For
    backwards compatibility, only ; starts an inline comment, while # does not.)

So we might want to support `#` as inline comment starter. We have no backward compatibility issues as python.
No, that's the whole point of this patch (rendering on devices without the external_image extension)
I totally agree with you. It gets messy quick. Both the ```suffix``` and ```middle:``` keys would be used frequently in the database, and expanding the ```additional:``` into an array for multiple surnames seems like a reasonable model for the time being.
Ah ok, thanks. I was coming from some forum link and didn't look that hard ;)
Yes for identification purposes only you could only use one of them then that way you use less code. 

Sent from my Jailbroken super awesome iPhone 4


On Jan 27, 2012, at 7:36 PM, Jimmy Kane<reply@reply.github.com> wrote:

> I didn't mean that kind of protection. Anyways I can put it back just for reference and statistics. 
> I'm my min as I thing I can  find useless code and dump it in favor of stability and robustness. So the assistant fell into that loophole. I can see now that it has some use in relating friends and devices. Although new are generated every week :-) (to keep in mind) 
> 
> On 28 Ιαν 2012, at 0:07, thpryrchn<reply@reply.github.com> wrote:
> 
>> Yes, But the server status already doesn't show all of it unless they are logged in as Admin. So it can't be spoofed, and banned.
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/jimmykane/The-Three-Little-Pigs-Siri-Proxy/commit/4a13114d5d780d788dd93233905161e322f42792#commitcomment-909896
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jimmykane/The-Three-Little-Pigs-Siri-Proxy/commit/4a13114d5d780d788dd93233905161e322f42792#commitcomment-910146
It's also a program size issue - if a function is in the vtable it will be transitively linked in even if never used.
Good catch, definitely inconsistent.
Unsure.  Stills needs to be investigated.  Those are 2 new tests, so the option was to either leave them out, or mark as ignored.  Since it works in all other browsers and SV passes all other manual & automated tests in IE, I opted to leave it in as ignored until more time can be spent to determine the appropriate cause & resolution.
Same as above comments
Camel with big C. Capital letter after dot.
Previously @rkuhn had an idea of that routees should be created by sending messages to the router actor. I didn't go that path because I don't think it is possible (without major rethinking) because we rely on immediate return of routee ActorRef.

We can discuss further improvements to the router design on Monday. I'm not sure that major redesign should go into this ticket though.
Jut as a FYI: com.eaio will be dropped, I've added a ticket to move the things from org.jboss.netty.akka.util to akka.util.
com.typesafe.config will become an explicit dependency as well, instead of an embedded one. This will hopefully clean up the exportPackage
In case Scala changes visibility for other JVM languages, I think we need to.
cluster.convergence must be('defined)
Ok. Will do. Thanks.
Ok, it's done. :-)
ditto on the one above, probably shouldn't take these parts, or look at them independently to see what parts of this is wanted if any.
There's a small problem here - in 1.8.7, there's no `Symbol#empty?`:

    test_html5_data_attributes_with_nested_hash(EngineTest):
    NoMethodError: undefined method `empty?' for :c:Symbol
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:439:in `flatten_data_attributes'
        (test_html5_data_attributes_with_nested_hash):1:in `inject'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `each'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `inject'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `flatten_data_attributes'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:439:in `flatten_data_attributes'
        (test_html5_data_attributes_with_nested_hash):1:in `inject'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `each'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `inject'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:438:in `flatten_data_attributes'
        /Users/norman/work/haml/haml/lib/haml/compiler.rb:365:in `build_attributes'
        /Users/norman/work/haml/haml/lib/haml/buffer.rb:196:in `attributes'
        (test_html5_data_attributes_with_nested_hash):1:in `to_html'
        /Users/norman/work/haml/haml/lib/haml/engine.rb:185:in `to_html'
        /Users/norman/work/haml/haml/lib/haml/engine.rb:185:in `instance_eval'
        /Users/norman/work/haml/haml/lib/haml/engine.rb:185:in `to_html'
        /Users/norman/work/haml/haml/test/engine_test.rb:106:in `render'
        /Users/norman/work/haml/haml/test/engine_test.rb:1523:in `test_html5_data_attributes_with_nested_hash'
My bad, I misread the code to be value == typeof (string)
It's mostly error checking. If bval is small we could have one of the following situations:

1. bval = 10, bvec = [1, 0, 0]; gradient should be [10, 0, 0]
2. bval = 10, bvec = [0, 0, 0]; gradient should be [0, 0, 0]
3. bval = 0/10, bvec = [nan, nan, nan]; gradient should be [0, 0, 0]
4. bval = 10, bvec = [99, 99, 99]; This doesn't make much sense but we sill make gradient [0, 0, 0]
5. bval = 0; bvec = __anything__; gradient = [0, 0, 0]

I believe the function below takes care of all these cases. (bvec * bval) would fail in 3 and 4.
Also I want to update gt.bval and gt.bvec in cases 3, 4 and 5 to be consistent with the gradient table we make. ie
GradientTable(gt.gradients).bvecs == gt.bvecs
I probably messed up when naming all the activity streams action functions. I went for `user_activity_list`, `package_activity_list`, etc. trying to be consistent with existing functions like `user_list`, `package_list`, etc. But maybe I should have called them `activity_stream_user`, `activity_stream_package`, etc.
Should this test suite be renamed to reflect that it's the consumer scheduled manager instead of schedule cud manager?
@tenderlove There's the \@files assignment at the top of the method so we can't reassign but could do `+=`

@lgierth why isn't `start_with?` enough? What else needs to be removed?
also, my code is pretty ugly here so I see how you missed that.  feel free to polish so it's clearer
nevermind.  code is different in other branch
Update() is the only place you read this, right?  An alternate to a bool member is passing it in (perhaps a whole heap of changes though).
> одна услуга закрывается, удаляется из списка услуг кейса и вместно нее делается новая, в которой этого assignedTo уже нет

зависит от типа услуги и внешних событий. при закрытии одной услуги может быть создано несколько новых, при этом у некоторых из них `assignedTo` может быть такой же. Однако за время существования действия `assignedTo` может поменяться (супервайзером вручную или же автоматически, если пришло время действие выполнять, а у соответствующего оператора выходной).
You are right, concerning the memory consumtion. But the speed of call is better, as no wrapper function is required.
Thanks for pointing this out. Certainly something that should be taken into consideration.
I'm new to Composer and had troubles with getting it to work correctly until I setup this alias. Should it be set as you have it?
chunks get totally refactored here.  That is the main theme of rendering to objects.
For consistency, add a newline after colon.
I didn't want to change the existing routine because people are concerned about performance. So I added a simple if-clause that should not affect the performance and tried to leave everything else as it is.

If you use "{{{" then the existing preg_split()

```
$tags = preg_split('/\{\{([^\}]+)\}\}/', $strBuffer, -1, PREG_SPLIT_DELIM_CAPTURE);
```

will leave over the closing "}}}" in the follwing tag so they have to be removed :-)
So ```$tags['$_rit+2]``` would look something like this:

```

[2] => }}}</p>
</div>..........
```
It becomes very confusing to use remote/local terminology because it changes dependning on from where you view it.
in this case I think "endpoint" or "target" are more fitting
That is frankly horrible. Sure it works, but seriously what reason is there to use something unnecessarily obfuscated?

And that article mentioned that terrible trick as a way to convert to a boolean, which isn't what we're explicitly doing here.
None of these initialization calls in the init method should be using setters. I don't see where they could cause a problem here, but for all general purposes it's recommended to be safe and use the ivars instead.

This applies to all the below as well.
May be 
```js
throw new Error('Unknown encoding: ' + encoding);
```
also, for perf sake you might want to cache a tip array:
```js
tips = _.filter( Mapper.$scope, function( item ){
  return ( item.getAttribute( 'data-lu' ).indexOf( 'Tip' ) > -1 );
} )
```
I prefer using the builtin errors also, but deriving from ValueError would be a good second choice.
I don't think this is right. `current_mask` should possibly be a non C-Contiguous array, in which case (with some exceptions) `.ravel()` will create a copy. Maybe this is the wrong thing to optimize, and `.flat` assignment should rather be optimized?
```python
if not argnames.issuperset(exclude):
```
Yes, waste of cycles ... strcatalloc() should be binary safe bw. ..
Yeah, my original logic behind that was I wanted to show that it was setting something other than the default, but I wasn't nearly explicit enough. Updated.
Yes, it is a sample code which is poor performance here. I wish somebody could write a new version
I'll fix it.  We should just do a `gem netaddr` in the pg adapter code.
To lift this restriction, we could follow Java's example and generate super accessors in any derived class that loosens access restrictions.

```
  ~/code/scratch/20120611 find . -name '*java' | xargs cat
package pack1;

/*public*/ class Base {
        public void print() { System.out.println("A.print"); }
}

package pack1;

public class Mediator extends Base {

}

package pack2;

public class Derived extends pack1.Mediator {
        public void print() { super.print(); }
}

  ~/code/scratch/20120611 find . -name '*java' | xargs javac
  ~/code/scratch/20120611 javap -classpath . -v pack1/Mediator | grep --context=5 "public void print()"
   4:   return
  LineNumberTable: 
   line 3: 0


public void print();
  Code:
   Stack=1, Locals=1, Args_size=1
   0:   aload_0
   1:   invokespecial   #2; //Method pack1/Base.print:()V
   4:   return
```
I can add more correctness tests, I looked at the existing ones (not in PR) and they appeared to cover correctness.

For performance, we a lacking in any meaningful test kit that can do either Heap usage (what this commit fixes) or speed.    We're actively working on such a thing, but I think we can agree that needless reallocation of immutable objects is OK.
Type ascription police!

Since this is a public api, let's see:

`final val maxPreciseDouble: Double = 9007199254740992d`

Just in case someone ever drops the 'd' from the end in a crazy fit of refactoring.
http://groups.google.com/group/scala-internals/browse_thread/thread/e3507f461d0fac11
``shape`` is never used, I assume it can be removed?
Actually, what I said above is incorrect, this change **does not** break any activators as [they are still](https://github.com/iloveitaly/spree/blob/multiple-product-promotions/promo/app/models/spree/promotion.rb#L59) activated. 

I meant to restrict those activated to `Spree::Promotions` in that piece of code, but never got around to it. Although I would rather not have `Spree::Activator` models referenced in `Spree::Promotion` this might be the best compromise for now.
Not sure I understand the justification for this change. Why was this done? What does this change?
might want to update this :)
At the moment I use a MatrixExpr for this (there is a test to this effect).  I'd be happy to switch this all over to some generic Permutation object if one should appear.
Yes, we should. I'm not sure why this doesn't trip the ``test_args`` test.
I disagree. This is a "noun phrase" not a sentence. My father forced me to learn these rules well :)
It's better to use Mul, Pow, and Add with evaluate=False.
> rm_id is often paired up with an unpack which turns Add(x) into x for any x. I thought it made sense to separate out the extraction behavior. In general, as Sergiu points out, each rule tries to be atomic. It tries to do no more than one thing.

In that case, I would make a different rule go from `Add()` to `0` (either unpack, or a new rule).
On Mon, Jun 11, 2012 at 8:27 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>> +fields. But it is perfectly legitimate (although in this case uninteresting)
>> +to factorize over polynomial rings such as `k[Y]`, where `k` is some fixed
>> +field.
>> +
>> +Thus the polynomial manipulation algorithms (both
>> +complicated ones like factoring, and simpler ones like addition or
>> +multiplication) have to rely on other code to manipulate the coefficients.
>> +In the polynomial manipulation module, such code is encapsulated in so-called
>> +"domains". A domain is basically a factory object: it takes various
>> +representations of data, and converts them into objects with unified interface.
>> +Every object created by a domain has to implement the arithmetic operations
>> +`+`, `-` and `\times`. Other operations are accessed through the domain, e.g.
>> +as in ``ZZ.quo(ZZ(4), ZZ(2))``.
>> +
>> +Note that there is some amount of *circularity*: the polynomial ring domains
>> +use the level one classes, the level one classes use the level zero functions,
>
> On 11.06.2012 15:40, Christopher Smith wrote:
>>> +fields. But it is perfectly legitimate (although in this case uninteresting)
>>> +to factorize over polynomial rings such as `k[Y]`, where `k` is some fixed
>>> +field.
>>> +
>>> +Thus the polynomial manipulation algorithms (both
>>> +complicated ones like factoring, and simpler ones like addition or
>>> +multiplication) have to rely on other code to manipulate the coefficients.
>>> +In the polynomial manipulation module, such code is encapsulated in so-called
>>> +"domains". A domain is basically a factory object: it takes various
>>> +representations of data, and converts them into objects with unified interface.
>>> +Every object created by a domain has to implement the arithmetic operations
>>> +`+`, `-` and `\times`. Other operations are accessed through the domain, e.g.
>>> +as in ``ZZ.quo(ZZ(4), ZZ(2))``.
>>> +
>>> +Note that there is some amount of *circularity*: the polynomial ring domains
>>> +use the level one classes, the level one classes use the level zero functions,
>>
>> should level one be "L1"?
>>

It just caught my eye because the documentation started out by
explaining the L0-L4 levels (which I think is good terminology and not
too hard to translate as one reads) so I would be more in favor of
just making that the default way to refer to those poly levels. Other
opinions may vary.
can you wrap that long line (and the one below) by putting a backslash just before the "-tan" of the rhs?
You don't need S2 to protect S during iteration over the permutations; don't forget to play in the sandbox :-)

```
>>> ok = []
>>> s = set(range(4))
>>> for p in permutations(s, 2):
...   ok.append(p)
...
>>> len(ok)
12
>>> ok = []
>>> for p in permutations(s, 2):
...   ok.append(p)
...   if s: jnk = s.pop()
...
>>> len(ok)
12
```

Also, if you need to make a copy you can make it more explicit by doing `S2 = S.copy()` which is a little more self documenting.
No, I just mean the extra `"""` :)
pe_sys += e.kinetic_energy(frame)
It looks like this crept in from one of your other PR's.
the purpose of a dlg component is to NOT LISTEN to any events.
There is an existing issue: https://github.com/travis-ci/travis-ci/issues/216
There are chances for obtaining MSSQL support. :)
You're right. I think that i've typed this dot by mistake.
How about turning the above block of code into a method so that child classes can more easily override it?
I prefer inline links, please.
Maybe comment that his is the local element number?
what if the result is an array ? the cast would trigger a warning on 5.4
Leave the newline at the end of the file please… although I don't think this `#import` will be necessary.
The one issue with that is that the QueryRunner is no longer thread-safe.  It can only be called once.  Actually, though, thinking about this change in general, it might break the thread-safety of the QueryRunner already anyway...  It's not a big deal because we only use the QueryRunners once and throw them away right now.  But, the semantics of the QueryRunner in my head (not sure if I documented it...) was that they could be called multiple times without changes in behavior.
Crash resistent or crash resilient?

What operators?

Are you saying that if journaling is enabled and the primary in a replica set crashes, that the secondaries don't need to resync from a clean secondary?
Added two filters "is_false" and "is_true" to handle jinja's incompatibility with "is False" and "is True" accordingly. What do you think?
This still needs doing. Its for use when the template engine is standalone.
This does not match the behavior - is_numeric check will return false for options that exist.
`if (!$style_tree)` or `if (empty($style_tree))`
A bitfield is something else. See http://en.wikipedia.org/wiki/Bit_field
Changed in ccfc342

client:log(PRIORITY, message, ...)

Good call... I think this looks cleaner.
See the patten that tests follows: `agents/monitoring/tests/init.lua` so `agents/monitoring/collector/init.lua`
example: 
https://github.com/joyent/libuv/blob/master/test/test-fs.c#L778-786
Sorry Victor,

I answered your previous mail from my phone, I did not read carefully…

The  test should be if ($lat != 0 && $lon != 0) (logical AND, not logical OR, otherwise does not filter as wanted)

Sorry about that…

Ciao

Andrea

 

Da: Victor Berchet [mailto:notifications@github.com] 
Inviato: martedì 21 agosto 2012 16.45
A: vicb/VisuGps
Cc: abarcellona
Oggetto: Re: [VisuGps] Update visugps/php/mvg_track.php (#7)

 

In visugps/php/mvg_track.php:

> @@ -119,21 +120,25 @@
>          $lon = floatval($data[1]);
>          $lon = (intval($lon)) + ($lon - intval($lon)) * 100 / 60;
>  
> -        $insert .= sprintf("(%d, %f, %f, %d, '%s'),", $flightId
> -                                                    , $lat
> -                                                    , $lon
> -                                                    , intval(abs($data[2]))
> -                                                    , $date);
> -
> -        if ($flightNeedDate) {
> -            $query = "UPDATE flight SET start = '$date' WHERE id = '$flightId'";
> -            mysql_query($query) or die ('Query error: ' . mysql_error());
> -            $flightNeedDate = false;
> +        if ($lat>0 && $lon>0) {

should it be if ($lat !== 0 || $lon !== 0) instead ? (to allow < 0) 

—
Reply to this email directly or view it on GitHub <https://github.com/vicb/VisuGps/pull/7/files#r1424896> . 

Immagine rimossa dal mittente.
Changed this. adapter.error will now be called with a non-200 status code on IO call.
То есть я имел в виду не в прямом смыле ошибку, а непривильную логику работы. Тупо потеряется кусок статистики. И будет очень тяжело делать каждый раз проверку если ли для баннера уже запись или нет
> ну я доки по иннодб почитал, нигде не нашел что могут быть проблемы с записью неверных значений

Да, это я загнался, сам себя перехитрил можно сказать. Такое будет в очень редких случаях, которые ещё нужно постараться создать.

> интервал задается отдельной переменной или вместе с дефолтным обновлением баннеров делается?

Отдельной.
Can you pull this file out as its included in #53?
I guess you don't need this file - please remove it
Style nit: Add space on each side of the `>` operator.
The fix is needed ... but it's in the wrong place. It needs to be down at the cartopy Axes level (at least). Will move it in my PR.
Can you confirm that all deletions in this file are intentional?
я уже взрыв делал, назвал просто explosion
Is this RELYING on the fluke of all tables being listed for all children? That seems risky. It would seem better to be agnostic to whether the tables are listed redundantly like this or cleanly separated per table.  I am thinking about something like a single HashSet member (or one at function scope, here) to enforce table uniqueness for all the actually used tables -- currently found via scanColumns -- across ALL the children of the ParsedUnionStmt.
Thanks - I meant to add it to the message.
単純にデグレじゃないですか？
XoopsX/legacyの[master](https://github.com/XoopsX/legacy/blob/CorePack/.gitignore)には書いてあるのですが、それが酒井さんの[コミット](https://github.com/bluemooninc/legacy/commits/CorePack/.gitignore)では削除されていますね。
See previous note about naming conventions
Great! I included this in this pull request only so that you can actually run the test suite (after the dependency_order fix it never runs). I'll rebase the code to master when I get home :)
Still one error here - sorry for not spotting this earlier. This should of course say a frozenset of fields to update...
Args usually go on the same line, unless there is a docstring separating them. Nitpicking :)

(defn site-id []
  "MACADDR")
Yeah the bitwise op is not as obvious. In this case we're looking for strings *starting* with "background" right? So you could check for 0 and use `!!name.indexOf()` but checking for -1 is probably the most obvious.
I have not tested in next.
what is wrong with this if it is only in source file (cc). It should not affect anything except this file ( if you don't include it , which is really corner case).
Are we sure if arg0[elem_idx] is NULL?  I suggest adding "else" for this condition just in case.
Out of curiosity, why is this a link to #?
The above two lines happens automatically, don't need to do it manually.
Ok, @jacknagel what is the suggested portable idiom?
(we should think of the guys trying to port homebrew to linux and such)
I find this type spec confusing. First because I don't think that is the conceptual type that init is expecting and second because I think the type is actually incorrect :)

The `sqerl_row()` type is list of `{binary(), term()}`, but it looks like we call the callback init like this:

    Config = [{host, ev(db_host)},
              {port, ev(db_port)},
              {user, ev(db_user)},
              {pass, ev(db_pass)},
              {db, ev(db_name)},
              {idle_check, IdleCheck},
              {prepared_statements, read_statements(ev(prepared_statements))},
              {column_transforms, ev(column_transforms)}],
    case CallbackMod:init(Config) of


So I think this should be `[{atom(), term()}]`.
Good question!  Thought I'd let it slide and print out a big warning.  I guess 0 is okay but maybe not < 0.  Still, there could be a bug with the decoder and the duration cannot be returned and yet the file is still playable?
The documentation from line 301 should probably be here as well.
Does the failure also print the original request that was tried? Would be helpful when debugging (though not necessary).
So should I drop the second commit?
Do we need both `cabbage-bundle-dir` and `cabbage-bundle-repositories`? I think you should rename `cabbage-bundle-repositories` to `cabbage-bundle-dirs` and remove the other variable. This way the naming is consistent with the vendor variable.
Too many files. I think this should be an inner interface of StaticInjection . . . like Factory or something
Access to the whole AST sucks at doing whole-world analysis?  I admit I haven't been deeply into the javax.tools infrastructure, but if you don't use them, aren't you stuck with not being able to have your errors show up as Javac errors?

Or do you just mean for the analysis?
This variable is not actually used.
Gunna say that it is required. `Hash` uses the `hashKey` of an object to pick what bucket to store an object key in and then uses `isEqual` to check all the entries in that bucket (that have collided with the same `hashKey`) to check membership or whatever. This means that for the `Hash` guarantee of "two objects who are `isEqual` won't ever be in the same hash at the same time", those two objects need to have the same `hashKey` for them to ever collide and thus the `isEqual` to be checked.
I think this can be taken out in the integration test?
Yes—there will always be one screen that's never shown (depending on what kind of content is given), and it will always fall back on the default text feed if it can't parse out any media feed attributes.
I've added comments, but the basic gist is I'm polling the style in the stylesheet, which I don't actually want to use; I have to restore it for a split-second to allow JS to read it. It's a hack, but it allows all the colors to be defined with SCSS variables.
It does work for `<style>` blocks in the same HTML file--Peter F made that work awhile ago. I don't think inline CSS is an important use case since the code is right there anyway :)
Same comment as above.

(I think the main thing that bugs me is that we pretend the 2nd var should be true just to get it to run, when actually it'd be more proper to say that var is either false or "n/a" in that case).
typo: promised -> promise
Did you sync with the latest changes to PopUpManager? I'm seeing a bug I saw when looking at that code yesterday (that will hopefully be fixed by syncing to those changes):

1. Open any main menu and verify that you can close it with Esc key
2. Pop up recent-projects menu and dismiss with Esc key (don't think it matters how it's dismissed)
3. Open any main menu again adn notice that Esc no longer closes it
Typo ``ver``?
Nice suggestion!

Yes, simpler in code, but not so simple in logic. :)
This is spec'ed as requiring a normalized descriptor (and indeed it seems to require that), but Menus passes it the raw descriptor that it got as an arg.  I think that is fallout from Ty's original Menus refactoring, but we should probably try to fix it since it could lead to things like different menu items listing modifiers in a different order.  Should we spin off a new bug for that?
Please update this comment to something like:

  // If folder does not exist on disk then remove the project from the list
by the way, we use revision 353 from the astyle sourceforge svn repo; it has some fixes not present in the latest release; I'll definitly make note of this stuff in the README
Good catch. I can't see how this was ever working.
I'd generally prefer

```javascript
self.$uploadElem = $(self.uploadElem);
$('.hqm-upload-list', self.$uploadElem)[...]
```
throughout. Whether or not it's actually faster, it think it's cleaner and less error prone (what if you forgot to put a space in `' .hqm-upload-list'`?)
merged, but boo long lines!
Done in 48dadee.
You don't need a permission check here if you used it in the decorator.
sitemap is not exactly static. Do you want that moved to?
useless cast. I've seen many of these recently in monomap... this is not java 1.4 anymore ;-)
cc @nicolas-f  :p
There is more of this one everywhere with `ArrayList` and co.... :(
But I cannot extend mongoengine User. By extending I am thinking of ExtendedMongoUser(mongo.User). 

I can add another class AdditionalUserData(Document) and reference a user there but I cannot use/return/pass that class in backends because it is not an instance of mongoengine User. I mean I can still add the data to AdditionalUserData but I can only return default mongoengine User then. 

What bothers me is how can we access these additional user data from a template? With current (I agree) crappy solution is as easy as user.gender.
Wathever you like more, I just wrote those things because i was using translation tool called "Poedit" and I couldn't save the file without filling out the blanks.
I really like how you're consistently prefixing everything :)
Can this be moved up to where resetContainer is defined? Otherwise this function is getting defined every time a drag happens
space after <code>if</code>
SCM section is wrong.
Why freeze this to a specific revision? Wouldn't `~> 3.0` be better?
Diese Konstante scheint es in 2.5 nicht mehr zu geben. Da muss man erst mal schauen, ob man das jetzt anders mitteilen muss, oder ob das nicht mehr notwendig ist. Oder ob vielleicht non-utf8 gar nicht mehr geht..
Fixed in 1dd303552a6664a5867eba23ef13369bd9a0a266
the problem is that the object that used to be created with RDFGraphQueries passed a graph object in the methods. In most of these frameworks, especially Sesame, the process of wrapping a graph so that it can then become queriable is expensive. I think that in most situations if one wants to query a graph once, one will want to query it a lot more often. So it makes more sense to have a case class, such as SesameGraphQuery(graph) which one can use a number of times to query a graph. 
So simply put, since sparql engine gives me the methods to query something, I thought I might as well re-use the signature then, as the methods are going to be identitcal here.
please make 80 characters per line
These changes should go in a different commit
I see, this is the alternative to the C-like approach you used in your earlier draft. Interesting. Trades off a bit of code complexity for doing the conditional once at compile-time instead of repeatedly at run-time. Presumably the likely slightly higher overhead of using a parameterized type is still better than if statements everywhere?
Is this needed? I would rip this off and get rid of that sed in spec.
I corrected this mistake in my project but not in repository, now it shoud be ok.
If you use createTextNode in the strategy of using createElement etc I suggested, you won't have to do any html-specific escaping.
nope, all of the slicing is copy by reference
 to copy:

```python
a = NDData(...)
b = a[1:56] # reference
c = NDData(b) #copy
All mentions of Legacy in these list comps can go too.
riak_test guarantees a pristine cluster, so the only thing in the log at this time will be the startup messages from rt:build_cluster. If the intent here is to make sure that old runs don't affect this run, this is overkill. If you're trying to get rid of the startup messages, this will do it.
I don't like the name "FinishShutdown" much. This is not finishing the shutdown, it is the only real shutdown functionality, the other functions are just queuing it to happen.
Bitcoin is the blockchain and its protocol. Not software.
This code becomes reasonably ugly.
Would it be possible to redefine TRY_CRITICAL_BLOCK to use the scoped locks and keep this code (approximately) the same?
Shouldn't this be `$salt = Configure::read('Security.salt');` ?
> because cjdns is actually a networking interface and should thus be available when network.target has been reached

Then shouldn't it be `[Unit] Before=network.target` and `[Install] WantedBy=multi-user.target`?
These lines can probably be removed completely - they don't seem to be used for any other <a> tags other than the one explicitly addressed in main.css.scss
Not really shure...
That's true that someone used to git-tfs who know exactly what is he doing don't need this warning when he clone from a branch...
In fact, it's more for a new user that will clone the entire repository (or a sub-directory) without the `--with-branches` option and after when he want to use branches will be blocked. That was the goal of this warning (because that's just a warning).

But you're question give me ideas and perhaps I could find something better...
You won't need to specify these extensions anymore when you provide samples. It looks like you have a `.lasso` and `.lasso9`. It'd be great to have ones for `.las` and `.ldml`.
2012 -> 2008 ? If I remember correctly we said original year no ?
Scratch that, I don't know what I'm thinking of.  Leave check_period as Float, but neither of these should be casting (Float/Integer not CFloat/CInt).
Yep, added it in the latest version.
Ah, good point!  Let's play it safe and keep it as-is then.
mmmmmmmmmm I'm not sure exactly. `map` is nice because we're essentially calling context on a list, and so we get the list back.
I don't quite get this comment. Aren't you able to send chunked data to the server? Or are you referring to this particular instance? 'Cos we're going to need chunked support for pushing.
What's the point of ```String.valueOf("0")``` ? Why not just ```"0"``` ?
Interesting!  We should make sure the profiler addon folks know about this too.
The validator doesn't seem to like the empty `datetime=""`. I think we can put a dummy date since it will get filled in correctly by js.
This should be a PERFORM instead of a SELECT. Otherwise, good to go.
I guess it should be 
```
if not percentage:
    # accept not matter what the conditions are
    return False
```
Good idea, close() is called explicitly once but this makes more sense than trying to manage it by hand... since the script has a known (low) number of connections and exits when it's done I think it's not super critical, but we might as well do it right.
I'm planning to go through all new-style services and rewrite that part to have something more coherent. When I do that I will add error JSONs and better error responses. For now I'll use the above code example. 

The funny thing about you reviewing is that you always find something new to say. My code has been like that in the last 3 PR you reviewed, you know? ;) (No offense, of course, I like the fact that all that code is getting better and better. )
you could just return the iterator with:
```python
def new_iter():
    return ((x,) for x in range(10))
```
fixed in 53847a6
This is a can of worms.

I would prefer that ts always represent UTC and that to get a non-utc representation, you MUST explicitly supply the TZ offset to be used to make the representation.

The problem is that there are applications that assume local time stamps and there are clocks that get set to local in environments where no TZ is available.  Under these circumstances, the internal ts values will be whatever the clock says.  We have one DISA sample where records have multiple time stamps separated by nearly integral hours.  The explanation that the sensor and collector were in different TZs was wrong as the error placed the collector east of the sensor and it was west.  I think the clock was actually set to PT at the factory on the sensor and this was used as though it was UTC.

Wireshark, for exanmple, always displays timestamps in the local TZ for the machine it is running on.  For the DQ project done for DARPA while I was at CERT, the test range was in San Antonio (CT) the analysis in Pittsburgh (ET).  We finally got the range to keep notes in UTC and set the clock on the analysis machine to the 0 TZ so we had the same frame of reference.

Drop the "localtime" concept from the library.

John
There's something I'm not sure about with this as the constructor of UrlMatcher only has two parameters and we are sending three to it, see src/Symfony/Component/Routing/Router.php#210 Should I remove the third parameter as well?
Stylistic issue.
The `*BeforeClass` static methods were introduced to handle static fixtures which are not recommended as they violate the entire principal of unit testing (this is also documented at phpunit). Each test case should have a completely clean state, so the setUp/tearDown ensures a clean state between tests. In the future if more tests were added one would not have to consider the environment since each test case runs from a clean state. Unit tests are not the place for micro-optimisation and as much as possible, we should follow established testing practices (somethings which is unfortunately not the case for a certain proportion of unit tests in the codebase).
I'm confused, I can't find any XSD file in the SecurityBundle ...
There's one for all the other core bundles in Resources\config\schema but this folder doesn't exist in the SecurityBundle. Am I missing something?
Could you prepend "[BC BREAK]" please ?
no as we catch PHP notices to convert them to exceptions... except if we modify the error handling we have right now. But I'm not a big fan of PHP notices/warnings anyway as people don't really read them.
it can also be null
@schmittjoh is it ok to return early here or should we go through the decision process again ?
fixed. Thanks for the feedback
`SELECT COUNT(token)` ?
I don't really know whether this happens at all, it's a safety measure since ICU tends to get nasty with no-break-spaces and similar stuff.
Why initializing them to empty strings ? It is useless as the constructor always overwrites them
True, for count ==  0 and count == 1 there will be 1 row, but the layout should be different. When there is a helper text - no line separator needed.
Probably could extract these two lines into a single method, which takes a `user`.
T_T 粘过来的。。。杯具。。。
Sorry please can you explain in more detail option 2)?
I'm not sure what CXBMCRenderManager::PrepareNextRender() does. Do I call it after the RenderUpdate() of step two (line 735) and then delete the line m_presentstep = PRESENT_IDLE?
Yes - the caching makes the copy necessary. Removing the caching doesn't mean we need to remove the copying though. I'm tempted to keep this (so that some state information could be kept by subclasses if they so desire).

Do you have a strong opinion that the copying should be removed?
2 x `'resolution'`
While we're at it, the config entry is called "downloads" but would be better as "downloaders" (unless I've misunderstood what it contains!).
Besides the link being incorrect, use wiki link markup for internal links. Also, links should be descriptive, rather than the word "here". eg:

You can read more about Riak's [[Network Security and Firewall Configurations]].
Even though I think we've come a long way from C89, I'll move the declaration to the top!  Also, good call on using `gettimeofday()`.
If I'm making this one optional (`if node.respond_to?(:tags)`), it would work even without the mentioned commit in `gherkin-ruby`.
What do you think ?
It looks like devserver.py is meant to hold the development version of the server wrapper. I think I stuck that in __main__.py in ceilometer.api, but devserver.py is a good name for it. I would not put the app there, though, since you'll want to reuse the same basic app instance for development and production to ensure they have the same routes.
Should this be renamed to `replace()` since it actually does a replace of the target and not a replace with the target ...
@ghalliday yes, the libhdfs.hdfsOpenFile creates the full path and file if it doesn't exist.
now the app will only ask us if we want to go, if we have unsaved data, or if we have unsynced data.
I removed this as it was redundant. The root pom already skips the deploy and this pom will inherit.
Same issue with the cast.
Introduce a local variable to prevent modifying the arguments array.
I know.. but there will be any scenario where 'name' or 'number' are different than a String? I thought It was the only possibility...
That's really a hack. And this should be done differently. The best solution I can propose right now is to: open the homescreen as a regular application at launch with the window manager and flag it like as the current homescreen.Then use this flag in the window manager to do what you want. That a lot of new work so let's not block on that but please open an issue in github and add the reference here.
It took me a little while to figure this code out since it is above where it is used. I think if it was me I'd just have this function nested inside the anonymous one below.  Or I'd add a comment, at least.
nit: I’m pretty sure this comment would fit on a single line ;-)
goTo. Also it seems really dirty to have 2 things in your case. If you have a goNext/goPrevious just handle changes into them. If you don't use them and use full html to navigate like I did in the first version then you can use hashchange.