labofsahil/github-event-dataset-2012 huggingface dataset:
This comment is in the wrong place.  It should be part of the API docs!
`sendChunked` should be prefixed with `this`. Also I think the entire if/else section should be refactored to it's own method with a descriptive name.
Remove blank line (OCD for the win!)
Add new line before // When
low pri but we should get these strings internationalized with i18n
Indentation of the whole block seems wrong: looks like you accidentally added tabs => to be replaced by blank spaces.
or just ==
1. missing __unicode__ method
2. why not TimeTrackable?
This was actually the source of the bug. Yoffset is now equal to prev_function(coordinate) - this_function(0).
Pass the method itself rather than a string you need to lookup.
`return if page.nil?` - the page might not exist
Good call.  I added another commit.
Im not sure we need this part since the nova packages also do this
Concern noted.
The much preferred way of writing unit tests is [like here](https://github.com/madlib/madlib/blob/master/src/ports/postgres/modules/regress/test/linear.sql_in).
No, currently not. But we might in the future.
Nit: This uses double quotes, but should use single quotes.
`MacOS::CLT.installed?` ;)
Don't want the whitespace changes here and at the end of the file.
Preferred Homebrew style is

```rb
(HOMEBREW_PREFIX/'share/zsh/site-functions').mkpath
```
It *should* work just to use `HOMEBREW_PREFIX` here.
This couples the importer and distributor again, something we've tried to get away from. The idea of cleaning up previously published things feels like it should purely live in the realm of the distributor, is there no way it can track it on its own?
I think you mean `M8[us]` here
Hmm bei der spracherkennung ueber den browser brauch man aber die locale oder? In der locale steckt eben am meisten information drinn. Da es ein ISO code ist spricht ja dann nix dagegen, dass der verwender daraus die iso sprache "extrahiert", z.B. Mittels explode/substr
da Millisekunden nun default sind, kannst du den Parameter auch weglassen, also `$timer->getFormattedDelta()`.
I'm not sure it is -- are you differentiating between "the attr doesn't exist" and "`attr_locks` doesn't have an entry for it"? Ideally, an attr should never exist without a lock, but let's handle those cases distinctly.
This is a bug. We need to generate the set of static injections based on the incoming @Inject-annotated class, not on the module.

The issue comes up when you compile different sets of .java files in different modules. Suppose I have ModuleFoo that refers to static injection of class StaticBar. And suppose these get compiled into different .jar files. The class 'StaticBar$StaticInjection' needs to be generated when StaticBar.java is compiled. Generating it with ModuleFoo won't work because the generated class will go into the wrong .jar.

Another way to think about it: if two modules both request static injections of the same class, we should still only generate one artifact.
Ahhh . . .  tricky. I thought we were going to do the Guice-migration work in Guice itself?
OK, I'll back off the hit request.  It was a vain hope that we'd be able to kill off my misbegotten mistake of years ago.
The `--gen-key` within the XML comment causes  the mvn (3.0.4) pom parser to complain.

`Non-parseable POM ...`
`in comment after two dashes (--) next character must be > not g`
This looks incomplete.  Is that true?
I'm gonna be that guy, and nitpick about code formatting: `if` statements should have a space after them, and there should be a space between the `)` and `{`

And `==` should be `===`. JSHint will complain otherwise.
1) Ok, sounds fair, I will keep the original selection. In Aptana I'm used to see the full lines selected, that's why I did it in this way ;)

2) I agree, that should be way better, I still need to get familiar with the CodeMirror APIs.
OK, I removed it and just directly call _codeMirror in color editor code.
Yes and yes. Just trying to get it to work before I make it pretty :/
It also HUGELY improves the percentage of reads that are shunted to the slave.
why cast to int?
In fact that was use in the first version of the Choropleth Wizard when the table was editable and after a change run a computation of the other cell. But now i'm not sure that i need that type of listerner again
The readme says not to use run.sh What's it still here for?
`.toLowerCase().toLowerCase()`? :p
Uh, this is ugly. I think some other way should be used to fix this. For example, to render first and last radio buttons with some additional CSS class and use that here?
It looks like this is purposeless now.
I actually did try to do that, ... and it returned different results...

I'll try again though because you're right.
not needed (rgb = ie8)
For all the TO-DOs that are listed at various areas of the code, is something already filed about it?
I think it's because it'll declare that function everytime it goes into add(), so it's a valid reason to complain about it. We'd need to another another closure and function outside the add() function to get the lexical scoping we desire though :/
If `executable` contains spaces (as is common with Chrome on Macs), this will fail. You should either wrap it in quotes (e.g. `'"' + executable + '"' + ...`), or use Node's `child.execFile()`. If you go with quotes, can you please check that wrapping in quotes works on Windows? Thanks!
0.9.2 also fixes a number of bugs found when running on Python 2.6.
`-1` in a Multi-Bulk does not always mean that the watch condition was not met. It can also mean that the key you ask for does not exist[1]. 

[1] http://redis.io/topics/protocol#nil-reply
This is getting kinda indentation heavy.  One thing would be to to val blah = request.params.... and then return the Some(blah) version. Perhaps break the time_annotation part into a private method? I dunno.
It would be better to evaluate the return value and report an error if it fails.
fixed in 8a3bbe2
No problem at all.  Addressed with e4d3fe0beae3b439f988577d623644170b46953c .  It looks like we have similar issues elsewhere in the code, so would be good to do a single scrub through the code base.
Because its a JavasScript file not a Java file.  Java mode gives bad indentation.
The format for the "Returns" section is exactly the same as for "Parameters" or "Other parameters".  So the item after the color is the return *type*, not a description.  The description goes underneath (and indented).  It also seems to be a big finiky about complicated constructs underneath, and anyway the docuementation standard says that you should use complete sentences where possible.  So I'd suggest the following:

```
Returns
-------
Returns
-------
default: `np.ndarray`
    `array` convolved with `kernel` if `return_fft` is False.  If 
    `return_fft` is True, this is fft(`array) * fft(`kernel`). The 
    shape is the same as `array` if `crop` is True, otherwise it is
    the fft-padded size.
```
These variables should be written in uppercase as they are constants
You could even have a new clause of handle_event like this:

```erlang
handle_event({monitor, Pid, large_heap, _Info}, State)  when Pid == self() ->
    erlang:garbage_collect(),
    {ok, State}
```
I have a pull that removes any client name. Simply Show / Hide.
I don't really like special-casing 0. Either;
- Keep it as "txdelegate->unit = model->getOptionsModel()->getDisplayUnit();", and remove the parameter again
- Pass a valid parameter everywhere you use this function.
./tinyformat.h:557:31: warning: implicit conversion changes signedness: 'int' to 'unsigned int'
      [-Wsign-conversion]
                extraFlags &= ~Flag_SpacePadPositive;
Add in that this one allows for cloud hosting in strengths. As for the questions marks, this one gave me some trouble understanding its pitch. This first point is simply that it can integrate with major version control systems, the last one is that there seems to be some kind of built in branching system (building a branch for testing?)
Big S for String. methods
I'd rather not refer to it as xtermOSC52, outside of VT100Terminal. There may be other escape codes that control clipboard access in the future and then this name will be too generic.
I thought that static url was dooing a little more than that, and appending a `?v=filesha`
es la primera
Is this file necessary for the repo? It looks like it might be coming form IDEA.
put long comments on multiple lines.
>info->index != NULL

I'm not sure about this. The result may vary depending on when this is being evaluated. From what I remember:

 - `git_repository_open()` doesn't deal with the index at all
 - `git_repository_index__weakptr()` will delegate to `git_index_open()` which will either load the index from disk (if it exists) or build a new in-memory one.

So, invoking this after the opening of a repo will always set `has_index` to `false`. And invoking this after a call to `git_repository_index()` will always end up with `has_index`set to `true`.

On a personal side, I don't feel very at ease with the automatic generation of the index upon a call to `git_repository_index()`. How about:

 - expose a `get_repository_hasindex()` accessor returning true if an index is currently loaded or if an `index` file exists in the gitdir
 - add a `bool create_if_absent` parameter to `git_index_open()`, and preven `git_repository_index()` from triggering the dynamic creation of a new index.

/cc @carlosmn
@nulltoken I'm on the fence. I don't want to kick this off as a large project, but I agree that auto-creating the index for the repository is undesirable in this case. Let me read over the relevant code again...
You're right, that's the keep-alive interval. I changed it in the code, but forgot the docs :)
I would rather set the name afterwards with `.attr()`. I'm just paranoid since we have has xss issues by doing string concat like this before.
@twobraids I'd rather not mess with it now. This approach makes it so that both the old and new middleware can co-work at the same time. Right, @AdrianGaudebert
@AdrianGaudebert you mean /products/versions/ or /products/versions/versions? I'm thinking the first one...
Ops, you're right, i missed it!
Well, I did bring this up in public because I went through the code again, and these seem out of place (almost everything in the engine is using enums, apart from these values). Anyway, as I said, it's just nitpicking.
3. undo that change please
this looks wrong for subrequests. Your nagotiator builders are tied to the request (at least the one added here) but the same negotiator is reused for subrequests.

If you want to be safe, the negotiator should be a stateless object, and the state should be kept elsewhere (probably stored in a request attribute as it is tied to the request)
Why?
Short syntax is valid as well, check [phpdoc.org](http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.param.pkg.html):
```php
@param bool|int $bar
```
and [php.net](http://php.net/manual/en/language.types.integer.php):
```php
var_dump((int) (25/7)); // int(3)
```
I don't like this method, as the loader is not stateless anymore, thus leading potentially to side-effects when loading several files
typo: ``generated``
hmm, I thought ``localStorage`` was not supported in IE8. But as the preferences are even used for the toolbar, I think it should still fail gracefully when localStorage is not supported, as people using Sf2 may want to support IE7 on their website, and so test it with IE7.
IE7 does not need to have a fallback for the preference storage IMO, but it should not break the JS
could be merged in the previous if (using a ternary operator)
Duplicated check for: `!is_array($data)`
this phpdoc is wrong
isn't foreach faster ?
but will the other 2 chars be read again by ``fread`` on the next loop ?
I don't think that using array as a type hint is required everywhere. It forbids the possibility to pass an ArrayAccess object for instance (which sometimes might works).
This is a nice improvement, thanks! I found it very annoying when including this library in other libraries that are also used from the command-line interface, that even when it was merely included somewhere, it would take over and start outputting random messages in the script about "Must use -get", even when that wasn't at all appropiate. Thanks!
Will the job and event runtimeNames ever be mismatched? Not sure what the use case for that scenario might be. Perhaps simplify this method to `supportsRuntime` -> `return data.event.runtimeName == 'pig'` ?
I don't know, looks like I somehow removed a bunch of spaces from the end of some lines?
all your checkInTimes should really be NSTimeInterval's  (which is a double, not an int)
代码规范，增加空格。
 if((p.top>=top)&&((p.top+h)<=bottom)&&(p.left>=left)&&((p.left+w)<=right)){
改为 
 if( ( p.top >= top ) && ( ( p.top+h ) <= bottom ) && ( p.lef t>= left ) && ( ( p.left+w ) <= right ) ){
link to cgal.org?
Makes sense. Normalize at the end, rather than intermediate steps.  OK.
Thanks for pointing out that it didn't merge @bblay . I've rebased and this was where I had a conflict (all looks fine now).
some of these functions don't make any sense in this context. Can you trim this file to only what's used by BaseReader
This change is a bugfix entirely unrelated to MMQ. See pullreq #222
this can add a fair bit of overhead,, I'd suggest an import at the top and setting a flag:

    try:
        import numpy as np
        has_numpy = True
    except ImportError:
        np = None
        has_numpy = False

then just 

    if has_numpy and isinstance(p, np.ndarray):
I clearly needed more sleep. ;-)
PUT est idempotent : 2 appels de suite doivent pouvoir être joué sans 
conséquence (ce qui n’est pas le cas de l’hire puisque ça change l’état 
du serveur).
See http://valtechtechno.github.com/cours-du-soir-http/#verbs-slide

On 12/20/2012 04:14 AM, Eric wrote:
>
> In java/mepc-server/src/main/java/resources/Soldiers.java:
>
> > @@ -78,13 +82,20 @@ public JSONWithPadding allSoldiers(@QueryParam("callback") final String callback
> >  		return new JSONWithPadding(allSoldiers, callbackName);
> >  	}
> >
> > -	@PUT
> > -	@Path("hire/stalonne")
> > +	@POST
>
> Pourquoi un POST et pas un PUT comme avant ?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ericlemerdy/mepc/pull/1/files#r2473691>.
>
好的～
Why cannot we keep the old AbstractWellKnownRecord here? All WellKnownRecords have the type in common. We should use it in the decoders/encoders.
Hi Brian,
It would be beneficial to external callers too, for example the GWT-based management GUI should really use it (instead of the remove-then-add which it does now).

I understand about the restriction to changes to the 7.1 API. However this is purely an addition. I mean it won't break anything (it's not a Java interface ;).
I guess I could make this DMR API private in 7.1 and public in 7.2 but thats a bit messy too.

What do you think is the best way to go?
Header corrections now in same branch, 
5a5c103548cc39f2be98b2126eff5cac268b9391
This still does not look like it takes super class info into account, if there are security role info on the super class it looks like it will still be ignored
@yaoli  if you fix just this bit here with the try / catch, it's ready to pull.
(non blocking comment)

If the variables is self-contained within this scope then you don't need to prefix them with `_`.
The validator may be experimental but it works well. http://dev.w3.org/html5/spec-author-view/the-header-element.html#the-header-element

Besides, that’s not the only error the w3c validator mentions. To make it clear: I’ll never merge a building block that doesn’t pass the validator.
these are all nits, of course, but you left off the ", false" like you had above.
Or,

    navigator.mozApps.getSelf().onsuccess = function(evt) {
      systemAppOrigin = evt.target.result.origin;
    }
I guess we need a better design for the pin lock interface :( @patrykdesign @rafaelrebolleda @PeterLa
nit: Probably want "Adds an action to the queue" rather than actions an action.  It may be technically correct, but I don't hold with such extreme parallel construction.
When you set CSS transitions they dont get immediately applied (as per the bugzilla bug)

accessing clientTop will force gecko to flush the styles and let the css transitions to be applied, this is what the settimeout previously did but settimeout is a much less reliable hack, this one is hacky but the only way do it currently
`} else {`, but let's not block that unless this generate lint error.
I have no opinion on that, but thanks for giving some insights before Web Activity is implemented.

If you think checking `icon` is better than `hackHiddenFromHomescreen`, I will do it in this pull request tomorrow.
element with IDs begin with `#lockscreen-` should be handle exclusively by `lockscreen.js`. You should rename the IDs if you are moving CSS and probably moving the handling code in your next pull request.
I was going to say the indent is broken, but I agree consistency trumps indent rule.
Avoid naming a variable `manifest` that will not be pointing to `app.manifest`.

Use `if ( ...) {} else {}` instead.
Is the user supposed to have already done any encoding and such when they pass in this._options.xoauth?  Doing the encoding here means that the user doesn't need to know the specifics of the authentication - they just need the OAuth2 token.
It isn't clear what this cleanup is intended to do; can you elaborate?
We override this function to make it cross browser: 

  function getElementsByClassName(node, className){
    if(typeof node.getElementsByClassName !== "undefined"){
      return node.getElementsByClassName(className);
    }
    var re = new RegExp("\\b"+className+"\\b");
    var nodes = [];
    for(var i=0; i<node.children.length; i++){
      var child = node.children[i];
      if(re.test(child.className)){
        nodes.push(child);
      }
      nodes = nodes.concat(getElementsByClassName(child, className));
    }
    return nodes;
  }
it's not a real idea. the problem is that the hash value is based on the way id. So when you have an arraylist with ways, and some way is not in it, but all ways have an id=0. if you ask arraylist.contains(way), then it aswers "true", because it only seems to check the id's.

This made the last junit test fail.
`__invoke` was been added in 5.3. It works with both 5.3 & 5.4
I think that test names are already long enough, even without "test_should_" prefix. Every character is precious :)
Consider something more intelligent here. The AppController always picks localhost if that's an available option - consider that here as well.
That is needed for the CSS triangles that form the pointer at the top/left of the header.
You should change `(bool)` into `(boolean)` to be more consistant =)
These settings needs to be put in map options just a bit above
```coffeescript
      clone = el.cloneNode true
      clone.id = if nav is 'boardNavDesktop' then 'toggleCatalog' else 'toggleCatalogFoot'
      $.add $.id(nav), clone
```

or

```coffeescript
      $.add $.id(nav), $.el 'span', innerHTML: # etc...
```

keep it DRY
More useful to include the full error text and a more descriptive error message to help with debugging.
This will only work on windows.
There's a race condition here - if these tags are inserted between the select above and this insert, then the insert will fail.  There are a few other places in the DB API where we deal with this kind of problem, usually by looping until the desired result is achieved.
? src/chaplin/views/view.coffee#L65
po co ta zmiana?
Yes, addDecisionId takes a literal id (see below) to look up the package, this function was simply a duplicate.
you should keep it on the previous line
btw, there is no reason to create the global file when the repository is added locally
Line should be wrapped at 80 chars.
This is because it seems that cpp does not like "#logconsole" or in general lines starting with "#" that are not cpp directives.
Go ahead. It's not a big deal.
o motivo de pedir o nome do site é que ele precisa estar criado a priori.. certo?
In the various test cases, I think that this is exactly how you would bind to these event hooks. One thing would be to clean up the interface. Maybe extend the browser model like this:

browser.on_backbone_event('board-update', function(){
  // handle the backbone event.
})

Going with this route we could wrap every single backbone event and fire corrosponding DOM events in the test suite. In our tests then we can bind our browser to any aspect of the board/game that fires backbone events
Is there any specific reason behind the creation of a `onFennec` function that use duck typing, instead of using the "xul-app" module?

```javascript
const { is } = require("api-utils/xul-app");

if (is("Fennec")) {
    // do something
}
```
It looks like `internal(this).parentMenu` is already exposed via `parentMenu` won't it be better to just use `this.parentMenu` instead ?  In addition there seems to be `internal(this).options.parentMenu` in mix with two other `parentMenu`-s it's really confusing.
If the content script is evaluated on `load` event, the website can still catch these events on DOMContentLoaded.
@ozten - Is it dirty because it is a middleware to override the x-frame-options or just the code?  Maybe to keep things a bit more DRY, you could use an array of path names and .indexOf to see if the current path is a match to remove the header.

```
var paths = ['/relay', '/communication_iframe'];
if(paths.indexOf(req.path) > -1) {
  res.removeHeader('x-frame-options');
}
```
I will open a separate issue for refining the regex.  It is not a regression from before, so shouldn't block this merge, but heck, we should improve it.
Separate events can share the same signature.  So it's more of a gang tattoo than a signature proper.  That lets ArcSight correlate different events with a common signature.  It also unfortunately prevents me from auto-generating the signature and thus getting rid of this argument altogether!

I'm going to propose that ArcSight rename this field to GangTattoo.
Ah, it looks like it's due to the if statement above not being closed. I think we can safely remove the if statement.
Can you turn this into  a load method which gets called by the body onload setting? Then remove the global tooltipElements declaration and make use of the "for (var node in nodes) call.
All the pluses make me cringe. But hey this is JS it's okay. Breathe. BREATHE.
Ah, that explains it. In that case it would be enough to do `if (PopupNotifications)` which implicitly checks for the type and returns false if undefined or null.
I know it'll be annoying, but can we have a separate var for each constant? :) I'll be forever grateful :D
image_true = (image_true > 0).astype(...)
i have push the new code without h1 tag.
can you please change this to connect.call(self, done) and use `this` instead of the `self`param in the connection method below?
newline after and before each def would be great
i'll fix this but we should be iterating here instead of using recursion
related code should sit together, and this method is used only in big foreach, so it should be read before if there is not some race condition constrain. If os, then it must be documented properly, so it is not accidently moved in future.
All fields has `255` length. Is this justified?
We *could* split it up. The reason for not doing it was to have a one to one mapping of the glibc part here, which allows for easier comparision between the two codes and thus easier enhancements when something in glibc changes.
I just noticed PR #1798 and the argument for having an element per form input type (which makes sense). Was curious about this since I was working on the Form Element docs.
Is this PR a Work In Progress?
Why a GIF sprite? This should be a PNG.
These changes seem to already be in Master. Is there something weird going on there?
do feature detection instead of hard version checking if possible
I believe this message still gets sent even if the player is not damaged. Take snowballs for example.
-> `<li class="<%= (completed ? 'completed' : '') %>">`
Np, me neither ;)
This is now {bool this.completed: false}
Any insights on this mundane TODO?
According to a test I made http://jsperf.com/array-null-filtering it appears doing it with brackets is noticeably faster than using in.
Align "=" signs
Ok :)

This is basically required to identify what has to be lazy loaded, since that's either a field or an association in doctrine/common.
So should every `session[:return_to] = request.url` be in a `before_filter`?
Fixed in 486cbd8
Changes in this file should be reverted, and if at all sended as another PR.
I ended up changing this to one string because it was throwing an exception when trying to call the equation method. It didn't like the string concat (guess it was not trying to actually concat but trying to add two different types or something)
I've had good luck with http://fgnass.github.com/spin.js/
`jingo.render` is deprecated
Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=767415
You also need to remove the definition of `validType()` above
Data processes, to my knowledge can have (no) input data products...
selectタグのオプションで利用するならそれ用のhelperがあるので調べてみてください
Adjust all traces to one format.
That's a good point, sorry. Will update the PR in a matter of minutes with this.
Hey @zacc, unfortunately I don't think we can wait on the form reset (merely clearing the comment field) on that because the post is an AJAX call; the reset happens immediately while the send goes on for a few seconds (on my cellular connection) https://github.com/mozilla-b2g/gaia/blob/master/apps/feedback/js/feedback.js#L62
- exposing NodeKey's would trigger a lot more existing code changes, considering all the places where "get" is being used from.
- same as above - exposing the Document except the SchematicEntry would trigger a lot more changes

i'm not sure those are worth it
This is a common pattern that I have used in multiple Teiid sequencer-related classes. I like the fact that the code in the debug code blocks are not included in the compiled class when "DEBUG" is set to false. I can write up a jira to make the changes you suggest across all the Teiid sequencer-related classes.
This is an example of a method that we can fully implement in the abstract class.
It could, but in dev it made it harder to rerun and pick up additional Artefacts. 

If the script runs properly, it won't change any data on subsequent runs, because that tag will have been changed, and it won't be possible to tag artefacts with the old tag.

If the script runs and errors, then we can address problems and rerun until fixed.
Just curious: Why you are doing this here? IMHO its just coping the pointer into a local variable
Turning the Pika buffer warnings into exceptions that we then pick up in bin/beaver to force a respawn of the worker. I saw these warnings pop up when the connection was closed from the RabbitMQ side, and Pika was not raising an exception for it.
I think we could be better about the "public API" and figuring out what needs to be stable and easily discoverable.
Why -shfc instead of just -hfc or something else more clear?
@haus : updated
Reflective face up I guess
Shouldn't this be `get '/about-us'...`?
Separate controller spec please :-)
Events would be a good way to do this, and a good way to hook additional functionality into the system. I had a hard-time wrapping my head around the Principals API, and how we could emit events from there as we extend both users / groups in principals. I'm sure it's do-able, and at worst case have a PrincipalsEvents.on(...) that we could subscribe to.

I had outscoped those thoughts out of this PR though. Events would be good to implement as we tackle activities, and porting the search indexing could happen at the same time.
Typo: currentBehavir
I'm not sure where this has to be passed, but I'd go for an explicit value.
Why 250/255.0? should  be much tighter to be honest. Make it 254/255 I would say
You should capitalize Jon.
Blah. I gave in and removed the interface in ae9411f.
@davidtyh this is found in your spec:
#pragma hicuda loop partition [over tblock [(distr-type)]] [over thread]
The over thread clause does not have such a sub-clause, and the distribution strategy is always CYCLIC.

so, do we need two strategy?
I'm not saying that it should be in the same dimension/level, you can do the following, prior to line 287:

    if ( ! in_array($val, $this->_test_items_visible))
    {
        continue;
    }

The Unit_test class provides a way to set which items should be **visible** in the report and with that check removed - you're removing that functionality.
Needs a space after `if`, to comply with the [coding style guidelines](http://codeigniter.com/user_guide/general/styleguide.html).
While you're at this line, you can change `==` to `===` as well. :)
I should probably fix this.
Зачем сравнивать с DNA_LENGTH, если эта переменная уже "заложена" в x?
@crmaxx отвечал с почты, так что отвечал на сообщение. Сейчас посмотрел... и вроде бы мы с вами уже обсуждали это. Лично я не вижу ничего плохого, хоть сам и делаю по-другому.
This is a platform independent way of checking if a file exists or not.
этот файлик все так же не нужен
Still shouldn't be using factory_girl.
thanks for the lesson in list comprehensions...i had seen the example in the book but hadn't quite figured out how to apply it to the real world.

also, yay for catching possible type conflicts!
could you move this into a different pull request just so we isolate changes?
Maybe a clearer way to put it is that this scheduler does not count as "current scheduler", so `+currentScheduler` won't return it.
Looks like you accidentally removed `party.image = ` here.
Also, we should consider the case where there are no frequencies between fmin and fmax. I vote for throwing a warning and putting a nan in there.
let me know when I should review
this should also speed up things as rescale will be only called once...
EU calls this `doctype` with no space and no underscore (though it will soon join ElasticSearch and call it mapping type).
Not sure if "slave*" is needed here. Since we target a single minion, it is best to not use wildcard and make sure we have a single match.
So better::

    salt 'slave' test.ping
Why is this a ConcurrentHashMap?
We can refactor it to uppercase.
Нахрена? Тебе же известно, когда виджет удаляется из окна — его parent plugin кидает removeTab.
auto :(
Hay varias tareas que ya tienen story points. ¿Deberían formar parte de este grupo?
actually it would be smarter to do: array_keys(reset($this->data))
that would return the first element no matter what it's id is
While you're editing CPApplication.j, could you please wrap line 222 `window.status = " ";` like this:

```objective-j
#if PLATFORM(DOM)
    window.status = " ";
#endif
```

#if/#endif is not indented at all.
Even admins can be stupid.
Checking if  graph title is provided.
Unfortunately, this isn't an option. The files will conflict with each other -- that's the real reason I split out a common package.
Just to head off any concern, this is not our long-term strategy for asynchronous calls, but was something I could do without getting into the discussion of how the task manager should work.

When the task manager (or whatever mechanism we design) is finished, we can change the body of this function to call it instead.
Yeah we didn't add it to the python agent... so really didn't have a need to add it before.
This is to protect from broken .equals() implementations which don't check for a null param ?
This should be done in a finally section, in case there's any exceptions in the lines before.
What's the role of all these synchronized (this) calls? 

You seem to be protecting multiple variables: transfersBySource, transfersBySegment, isTopologyUpdate, topologyId... and it's not clear what the relationship between them is and whether from a performance perspective you really need to avoid checking whether a key's state transfer is in progress if you're updating the topology id.

From a debugging perspective as well, it looks rather complicated to find a problem with the logic. If all parameters need to be synchronized, why not wrap them in a mutable object and synchronize on it?

...etc, this needs some rethinking to make it easier to reason about.
oops oops oops ;)
Did you consider other options rather than thread locals?
*recommended
why ist this public?
Thanks! I'll make sure to add that.
Not sure I like the comments personally, I think this would be better documented in the README. I would at least remove the repeating of the attribute in the comment, and perhaps put a blank line between each:

    #requires b2g
    b2g = true

    #requires sim/carrier
    carrier = true

    #requires an sdcard
    sdcard = true

    #requires the emulator
    qemu = true

    #requires wifi
    wifi = true

Trivial though, and personal tastes. Should not block.
I think I understand what's going on here, but here's a question:

I read this as "Starting from half of the height and width of where the lockscreen would be handled, we swipe up to -100 pixels below the handle location." Is that right?

If that's the case, i don't understand why the X-axis plays any factor here - this should be a pure swipe up on any portion of the lockscreen. Only the Y-axis changes are important.
Should we just always hide the statusbar? Probably not necessary to do right away, I guess this can stand for now..
this should probably be `widgetData[widgetId]` ?
@arnodeclercq Can't we change this to `border: none` instead?
please ifdef your code with

#ifdef HAVE_LAPACK
Done. Now checks that it's a RelationList.
And not only on this at all :) I suggest to worry about compatibility later, after we'll complete the first alpha.
Похожая форма уже есть в ```edit```. Можно было бы (как и в других местах) делать ```render 'form'```, если выделить её в отдельный файл
Yes, but it was sort of a cop-out. I didn't feel like writing a new Cucumber step for it.

I've just pushed an improvement in a1bc6df
I guess this isn't really needed since `nil != true`.
b/c enabled isn't an attribute of the experiment itself but in the db.
We previously had a WT_PUBLISH for this case, and you asked me to think carefully about that.

Here's why I think it's necessary: without a barrier, clearing the modified flag could theoretically be sequenced sometime after the checkpoint thread has read a page.  In other words, we could clear the modified flag after an application thread has installed an update that the checkpoint has skipped.

A `WT_PUBLISH` here makes sure that the flag is cleared before the checkpoint thread examines any pages.
The assignment to ``$_POST`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Is it possible to add a ``@param`` annotation for parameter ``$username`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
var sum, content = fs.readFileSync(filepath, 'utf-8'); 一个空格和编码。这样后面就不用toString了。
are these "typeof != undefined" tests necessary?  in the end it's still the same value as before using test, and the `e.rowData.test` and `data[e.index].test` didn't need testing for undefined before.  Applies  to all places where the test has been added
Personally, those br's are confusing. Elsewhere you've made links just plain text or single non-code quotes, so I would stick to that convention. Either way either make all URLs code-quoted or not code-quoted.
Whoopsie, adding back now...
如果data是buffer怎么办？
Why not use ofPolyLine?
Hi @henrikbjorn  - This is the first time i've done it. Why is the coding standard wrong?  :)  If using a proxy, CURL was the cleanest solution. It is is however slower than fsockopen (although for us we're on a 10gbit internet connection so we don't notice any speed issues) You don't need to accept this pull request, I just thought it would have been nice for anyone else who happens to need to use a proxy to have this configuration option set-up and ready to use.
Maybe "Cancelar subscripción"
Maybe warning in case we are using the X mode, but that might be hard to tell. Anyway, probably not good idea to show this every time gem is called: at least moving to the install_using_packagekit method would be better.
Not good. You cannot assume that in all languages number comes before "days ago" string.
*Update* -> *Updates*, *insert* -> *inserts*.
Uh, this is not the best way to check for undefined in JavaScript. It is really a crazy language. :-) Please [read about that](http://stackoverflow.com/a/416327/252025).

Anyway, here would probably be enough simply to test `if (last_post_id) ...`, no?
Sometimes think about reusing existing other functions. For example, here you could call first `get_layouts` and then process its outputs.
It's not okey this add to document ready because they every time return false at the first time (beacause second input is empty) so i add on keyup on second input if they go back and retype password on in password1 field
Comma after *if not*, before *you should create one*.
This makes the assumption that error traces are of the form `{error, Reason}`, which they currently are, but that's an implementation detail that could change.  It's nit picky but thought I'd point it out.  There is also the macro `T_ERR`.
Did you mean `static quotient` ? Maybe add a test for `\=`.
I was thinking about this - I think it makes sense
Extra space around `delay`
This is a speed optimization.
`StringData` is a data:uri, so it can a *very* long string. It may not be in base64, so by using `pos` as fromIndex of a lastIndexOf call we limit the search to a few dozen characters instead of potentially millions of characters.
Copied that from client.js, all similar declarations have the same white spaces.
Retry on EINTR.
Please remove this useless line.
Can you remove this line ?
I think the problem originates from different vie.js versions.
You can combine those two imports:

```
from django.contrib.auth import backend, models as auth_models
```
Second strings are translatable.
could you replace "python2.7" to some constant (and probably fallback from some environment variable as for PDF_TEST above)
where is the implementor?
what about websphere and weblogic?
> For this, I added an optional parameter for the weight field: include_obj_var, which defaults to False, but which the user can set to True to include the object variance in the calculation of the inverse variance.
> 
Very useful, thanks!
I'm racking my brains: is this ever likely to be an issue?  I guess if we convolved two separate SBAdds it might cause an issue, which I guess is the point of the shuffleConvolve() method...
Keeping parallel lists is kind of a clunky data structure, don't you think?  I would prefer to see a list of tuples or a list of dicts
idiom: remove everything up until the last slash from argv[0[
No, this is just copy-paste/cargo-cult code ;)
Should this return Response.status(Response.Status.NOT_FOUND).build() if no application with that name is found?
I see the destroyInBackground will be a no-op if not found.
what does it mean for matched/claimed machines if they then become blacklisted?
So this is actually a rip off of WebFilings mixin which is a ripoff of Django mixin.  Ripped it off of WF because theirs works with GAE datastore.  Just lets you put Timestamped or other models as a secondary inheritance.

Currently timestamped is the only one in this project that uses ModelMixin
This is probably the only one I don't agree with. Are "methods", as defined by underscore, function properties or callable properties? I would define it [as in es5](http://es5.github.com/#x4.3.27) and leave the test as it is now.
Say `Rails.logger` isn't quite configured right, I don't know how Rails works but I would say it shouldn't stop the site from running.

My main priority is to have a running site and logging isn't core to that. I can go away and find out keys, etc and sort logging out but I don't want that to be a hands-in-the-air-the-site-is-down thing.
Umm, you left the title. :poop:
You use an optional array here, but it's not part of the prototype in line 1084.
The "ifyour" needs a space.
There are 2 about links on the page and according to the locator this one is for "About Mozillians" link in the footer area. We should rename this to <code>_about_mozillians_link_locator</code> to avoid confusion.
to be honest we should make it so that the partial can be supplied the items too as using the ivar `@items` seems like bad practice in a partial.
Added a test for writing unicode to the socket.
а якщо я в фыкстуры ще кілька проектів додам? можемо якось абстрагуватись від конкретних цифр?
yep, that should be a default in the DI if you don't set any plainTextTypes
bin/vendors is gone
For now, this is okay.
What is the and/or binding here:
u.email = ?1 OR u.username = ?1 and u.password = ?2
is it :
(u.email = ?1 OR u.username = ?1) and u.password = ?2
or this:
u.email = ?1 OR (u.username = ?1 and u.password = ?2)
Because they would do different things.
White space. Please remove.
Instead of `depends_on 'gfortran'`, the recommended way is to put `ENV.fortran` in the `install` method. See `brew info gfortran`. That would allow other gfortran compiler.
Не желательно использовать *не*-латинские символы. Лучше - `start_date`
Can we try this as just 
match '/*' ? 
'url' seems like we're trying to grab an arg that doesn't exist.
This step should be removed, it's exactly the type of logic in page objects that @davehunt wants us to avoid.

The test itself should perform the login or logout prior to this refund procedure. by automatically logging in here the test might deviate from the test case, for example the test was to attempt to request a refund without being logged in, that would be impossible because this would always log the user in. it would subvert the test case.
Ok, removed. It was only there because the mediaportal plugin which I used as a reference also had the file in this location.
It looks like this wasn't updated correctly. Running `check_bento_build` shows that the following lines should be added:

    Extension: skimage.filter._denoise
        Sources:
            skimage/filter/_denoise.pyx

And the `ccomp` line shouldn't be deleted (it goes with the block below these added lines).
> sigma_range is in respect to the x, y position
> sigma_color is in respect to range of color values, here [0, 1] as we useimg_as_float`. If we pass an ubyte image, we'd need to change the sigma_color accordingly.

Thanks, that clarifies things. I feel like these parameter names could be tweaked. In particular `sigma_color` is quite misleading since it affects grayscale images. Maybe `sigma_intensity` (a bit too long) or `sigma_value` (value is a bit ambiguous, but better than color). `sigma_range` is not misleading, but maybe `sigma_space` or `sigma_spatial`?
It should be ``eigen_solver``. This is a name commonly used in sklearn.
Good to know you can pass a sequence to permutation, thanks for the tip. Done as well.
I wonder whether, for the sake of readability, I would not prefer using a '[0]' at the end of the line, rather than a ',' on the left hand side.
if you pass a subset don't do the do over all the features
Return**s**
Yeah, exactly. But shouldn't ~100 samples be enough? and that should be pretty instantly, right?
Well, as I said, just nitpicking on a high level ;)
No, this way you only get the coefs that are active at the solution. The ever_active_set contains all features that have been active EVER.
Maybe make this `ct.match(/json$/)` to match any json response. Some servers use non-standard content-type headers in their responses.
@richardmiller: let me know if you have an opinion here. I'm fine either way, I suppose.
Since we know how many children there are, shouldn't we pass this along to `Array::New()`?
As we discussed, for all the UI elements width, left, top, height, should be implemented in UI.View , since David has posted patch on it, i suggest to add todo here, and re-factor this code later , when the UI.View will be ready.
Please, do not separate Class names with _ or a blank space
It's implemented by the AbstractDeviceAwareViewResolver. I started out with the interface, then decided I needed the abstract class. Neither of which is entirely necessary. I simply wanted to establish guidance for alternate implementations.
Does ```cur->queryChild(1)``` means the if block? What about the else block?
Do you need !index, if indexCapacity is set to 0, then checking !index is superfluous isn't it?
Fair enough - I will release a fix
I'm not sure I understand the logic here, if you're removing _a_ Cluster.. above (in the // Remove Cluster from Logical file, section) it removes a "Cluster", with removeTree..
but if continues to here, isn't it going to remove the whole logical file still ?
and ```--server```
2012/11/25 Randall Leeds <notifications@github.com>

> Thinking more, maybe we should keep the original author and filter it on
> the way out.
>
That would be certainly logical from the technical point of view.
However, Dan has explained to me that this might become a privacy issue
later;
we don't want to receive requests to disclosure confidental information of
something come up.

From this point of view, best way is to really drop that piece of
information, so that it's permanently lost, even to the site owners.

     Kristof
Ahah this script tag is evaluated and prints an "hello" dialog on page load :)
For some reason, this code block isn't highlighted.
I'd perform the `escape` in `render_link` rather than require the value to be escaped before it's passed in.
remove the float: none here
I wonder if this worked
I’d say ur1.ca would be »tools« rather than »social«. What do you think? cc @jhuet
cuddle this with the if above:

} else {
Well... basically I'lll add a check for res.code in all the response checks ! :P
Add tests for GeometricTransform, AffineTransform, etc.
I don't think this is what we want as 'coords' shouldn't be rescaled to the range [0,1] as this array defines the vertices of the polygon.
Or the above you can break down into two lines if you prefer.
you should add the comma at the end to avoid nasty diff when adding a new item (which occurs here for the previous line). Same for the Nelmio namespace
It does take into account the curvature of the ellipsoid.
Your code would result in an index of 0 for any NaN values, my code as is would end up returning undefined for null or any number number outside of the array and throwing for NaN.  I should probably be checking for >= 0, so I may make that change.

Yes, technically I should be checking for null if I wanted to be as "correct" as possible.  But I was speaking with @shunter yesterday and me and him agreed that for the sake of our code base, null should not exist.  I plan on updating the coding standards to discuss this as well as opening a pull request to clean up and eliminate our own usage.  Though I'm not completely convinced if that's the best choice or not.

Ultimately, error checking in Javascript is a fairly fruitless effort, there's no way to catch all of the cases and it slows things down.  The general idea is to "fail early" with bad developer input.  Accidentally passing in a non-number or undefined is a common occurrence, and my above check will catch those cases (or rather throw them ;).  Passing in null by accident will pretty much never happen and probably isn't worth checking for (though maybe it's worth it).

We've also thrown around the idea of having more robust error checking functions that we could call and do all sorts of validation with, but we would then remove them automatically as part of the "build" process.  This would give developers better exceptions as they are coding, but would remove all checking and overhead at runtime.
I see the optimiation, but it feels hacky.  What other options do we have?  In C++, this certainty wouldn't be thread-safe.  With web workers, I suppose each worker gets a copy making this less bad.
Why not call this `shows`?  In our terminology, show is something set by the user, and visibility is something determined by culling.
Why commented code?
This constant has been deprecated in iOS 6. Group style table views still default to using the standard iOS group table view background texture if **no** background color is specified. However, specifying this constant explicitly on iOS 6 and above results in a black background color.
Should be `NSURLErrorCancelled` constant instead of magic number.
std::auto_ptr< thePimpl > m_pimpl;