labofsahil/github-event-dataset-2012 huggingface dataset:
@marcphilipp 
I know the a cool idea, i am happy what you have done for #332, and i am glad to release Mavn staff. But let's do it step by step. The 4-11 can have new big changes that we improve the JUnit.
Separate function is nice because it can be used by a test template.  Removing `validateJsonById` would be nice if its ok with you.
So this is saying when the primary key isn't `id`, any `id` keys in the JSON should just be ignored? I think I can get behind that. It means that unless `id` is the primary key you can't have any other keys with `id`. Also, why would the built up `obj` ever have an `id` key? There shouldn't be an encoder for it as the encoder for the previous primary key gets removed when you change the primary key.
Good observation... how about `transition` or `execute`? Its the name of the transition/event that comes in here, not the next state.
This is pulling the audio player up too high. When I deleted lines 202-205, the audio player looks vertically centered to me.
At the very least, please add a comment to explain this (CSS comments look like `/* ... */`)
Also, why plural here? should be VK_EQUAL.
How about testing with a conflicting key binding by having an extra call of addBinding with an already used key? eg. KeyBindingManager.addBinding("test.foo", "Ctrl-A");
This should be ignored and won't be in the expected keymap.
Done for both functions.
Wouldn't hurt to clarify this a little more, i.e. explaining why clicking the triangle sometimes changes the selection (it's an edge case, so it's not immediately obvious that it can happen) and noting that we don't want to toggle twice from a single click.  Or maybe that sort of comment belongs up in the ```toggle_node``` listener now that we'll need more complicated logic there?
Just noticed this--is there a reason we're doing `this.closeOnSelect === false` in various places instead of just `!this.closeOnSelect`?
Fixed. Added Menus,ContextMenuIds enum.
Also case-sensitive
@njx did you file a separate bug for this? I commented on #1485 about this. I'll go ahead and close #1485 instead and follow up with the new issue number.
Lennart thinks its ok
Comments as strings is wasteful. Also this isn't a particularly helpful comment.
I think this code could be much simpler then:

``` ruby
if rescuable?(e.class)
   handler = 
else
   raise 
   handler = ...
end
```
(You should probably remove some from `INSTALLED_APPS` setting.)
It lost importance, when I added the body ul {} class.
I don't know how :/
I think this is unnecessary?
for the create tests, yes
That's awesome, never knew that. Thanks!
Shouldn't even be here.
remove the extra indent here
We inject Popcorn, do we need this?
srcElement eh.... :P
I only need `_this` for inside the setTimeout, otherwise I just use `this`
`document.head.querySelectorAll( "*[data-butter-include]" )` => `head.querySelectorAll( "*[data-butter-include]" )`
with the change above, `if ( url ) {`
Right, but this won't work if the row or column is 0 (and they are sometimes in the way I've structured it), since 0 is not a truthy value.
I do not understand this comment? Where should I move the code to?
Ahh okay. Yeah, I'd re-write it to be something closer to

```js
if (data.data['description']) {

}
Right; will unlock before calling SetHasPendingUpdates
These two methods need javadoc with examples of what you mean in the context of the real bundle.
That looks way better!
No particular reason, just changed it
Du coup, idem.
Well I have no clue where this one is used.. May be I 'll remove this file. lemme check
Also, as a practical matter, doesn't `delete` wreak havoc at the "hidden class" level of things (how V8 represents objects under the covers)?
`@return void` is commonly understood across multiple languages to mean that you're not returning anything. IMO it should stay.
Remove the Gaia.UI namespace.
Actually, one question for @iguananaut - in the PyFITS header, how do you choose the order?  That's the biggest difference I see here - there are a lot of coordinate systems that use `ra` and `dec` as keywords, but in pyFITS usually you have more information available to select which is the unique HDU class, right?  So here a user might end up thinking they were getting FK5, but instead getting ICRS if they give only `ra` and `dec`.
I'm not sure if that is a nice string and understandable by users ...
Why change it to protected?
Changed to use single quotes
Also, can we not abbreviate `Ns` and `Dir` and actually use the non-abbreviated variable names?
isn't icon_size_menu 16x16? that's different from the 20x20 you're asking in other places
Why is this called ClientValidator? That doesn't make sense to me. Instances of this class will always live on the server.
too long for one line?

    @logger.warn "File is readable by the public internet." if public_readable
You don't need to create a new instance of InteractiveShell here, we set one up in a particular way for the tests. You can call `ip = get_ipython()` anywhere, because we inject get_ipython into the builtins.
please put comment or javadoc on the parser extension classes about why they exist
Ditto should this be `> 0`?
you can use `(comment ..)` form to comment out valid clojure code
There should be an interface added to change these values, since experiments tend to use difference values (even though they shouldn't)
I wasn't sure exactly how much change to APIs I should make, so I wasn't sure if I should change the name of the argument here too. I wanted to get feed back first, but since you said something, I will go ahead and change it.
AFAICT this is exactly the same as `_group_query_filter` above. So maybe rename it to something more generic and reuse?
None of these test the "ES is down" situation. You should probably run these in a regular TestCase as well as the ElasticTestCase. That might be good enough to simulate the ES is down situation.

Alternatively, create a new TestCase class and change the ES_HOSTS.
I don't see how this div gets added to the page?
removed this one, too.
I'm now using ``not params.uuid`` as that uuid variable is either ``None`` or a string, so ``not`` will return ``True`` if that variable is ``None`` or an empty string. Same goes for the signature check up in the file.
这里`config.host`不应用依赖配置中的host，要不然本地调试配置的url就无效了。应该根据req.headers.host 来获取。
What is the reason for this change? and how is it relevant for solving the issue at hand?
Might be better to use `assertTags` everywhere
Minor nitpick: Probably should be "Disabling" instead of "Disable"
якось цей код генерації картинки дивно виглядає. в лібі нема вбудованих методів для цього?
typo: ``thrown``
Why don't you also do the validation of the values here instead of calling `validateWidgetDatePartType` below?

```php
if (is_array($options['widget']) && 0 < count(array_diff($options['widget']), self::$allowedPartWidgets))) {
    throw new ...
}
```
Maybe change this a bit to something like:

```
if (defined('PHP_WINDOWS_VERSION_BUILD')) {
    if ($this->headers->has('X_ORIGINAL_URL')) {
        // IIS with Microsoft Rewrite Module
        $requestUri = $this->headers->get('X_ORIGINAL_URL');
    } elseif ($this->headers->has('X_REWRITE_URL')) {
        // IIS with ISAPI_Rewrite
        $requestUri = $this->headers->get('X_REWRITE_URL');
    }
} elseif (..) {
And here the file is opened.
Please refer to ...
i think `be_a` should work too, no?
Yes, boost pointers are fine for internal code, I just want to avoid non-standard-C++ types for the public APIs.
> 1. it will cause a TypeError if v is `null`

sorry - that comment is wrong.  you can ignore it.
Perhaps "create singleton instances of each class, and assign them as properties on the router."
API nit: please put the $q param before the $album param since it's the high order bit
This should be done in a privileged block.
Hi Kabir, the addDependency is in an:

"if (jts)"

For JTS, there is the CORBA requirement.

Hope that clarifies,
Tom
It is a test case as Richard pointed out
No, contact already checked while calling updateMsgWithContact.
nit: What means 'f' ?
Why would the PDF viewer needs to hide the status bar?
defer here will still be helpful. it makes the browser keep loading and parsing the DOM without blocking on execute this script.
Resolved, load function removed.
I think that for B2G, getDeviceStorage() is always going to return just a single element in this array, so we'll probably be able to simplify this.  Its fine this way for now, though.  I still hope we'll have a utility library that will replace all this code for the media apps.
Sounds good to me ;-) Moving all the related USSD/MMI code to ussd.js inside the UssdManager ;-) Thanks!
`}, this);`
Can we do this in a follow-up? We have a demo soon. I'll work on that just after it.
Unless the items covers the entire area of the parent, there is a possibility that the user might click on the parent itself.

Check it with `if (!action) return;`
r+ from me, thanks!
this is used so we'll get a copy of the object, and not a reference. otherwise any changed we perform on it will be applied to the original object.

we also can't use shortcuts.slice(0), since it's not a simple array (['ascs', 'sdvsdv', 'bdbdfb']).
okay. I see.
might have been while working on it, removing
Please use ``$( commands )`` instead of backticks.  It is more readable and safer.  :-)
Should probably multiple lines, consistent style.
Why is there no `CONSISTENCY_ALL` option?
we might as well do `/\.css$/.test(path)`
Titles should now use hyphens: https://github.com/alphagov/frontend/pull/46
Sylistically, I think I remember Dustin&Tom saying to always add "return" on a line after "defer.returnValue" just for cliarty that the function is over ... its a little more readable to people not 100% down with inlineCallbacks rules
I didn't take it into ac-count :)
ok for the var_dump, but the ! before the class_exists is the main part of the bug-fix
Line 8 is still needed since Bootstrap only includes the black and white versions of the icons. I wasn't sure if .icon-black was needed or not (since it's Bootstrap's default .icon background),so I left it in and pointed it at the right background image.

Since I don't see the .icon-black class used anywhere else in the stylesheets or templates I can go ahead and get rid of that line.
What's a?..
var middleware = null;
move it to namespaces like `lib/tasks/gitlab/update_hooks.rake` and also include it to gitlab:app:setup
This has to be defined in this function.  Different schedulers (EDF) use different active runqueues.  Define it to be per-cpu here, but it has to be here.
"A Base rule is applied to an element using an element selector, a descendent selector, or a child selector, along with any pseudo-classes. It doesn’t include any class or ID selectors. It is defining the default styling for how that element should look in all occurrences on the page."
Should be safe to perform the `replaceAll` unconditionally—then this becomes a one-line patch (well one line per test case at least).

Bonus points for fixing the `UI_INHERITANCE_UNSAFE_GETRESOURCE` FindBugs warning.
Why prefixing it with `g` ? In jetpack we don't use `g` prefixing pattern, as we don't have **g**lobals. Also in this case it does not looks like a global.
Let's figure this out, but I find activate here confusing.
It would be cool to define only a getter, so that contentScriptOptions will throw an exception or print a warning if someone try to modify it.
I'm wondering if you can do remote the setter and just do:
  `this._contentScriptOptions = options.contentScriptOptions;`
Instead of:
  `this.contentScriptOptions = options.contentScriptOptions;`
In worker, symbiont and everywhere where you set it?
This function could use a test to make sure it is operating how you expect it to.
right, ok, sounds good!
Actually to be honest, when would we fail? It should never happen except syntax failures in the `ExtensionManager` class we would see in either way. I don't see a reason for the else case here.
Makes perfect sense.  Sorry. :)
What's exactly the no go ? The whole block of code or the selectors in the last line?
Never mind -- I see it was moved to the listener.
Not possible, since $validator if $this->validator is anything other than InArray or Explode, $validator will be empty.  Or am I missing something?
Point noted. I believe that should be handled in the writer, then, as it seems to be a requirement of the log destination. @Maks3w, would you agree?
There is no error message param
Could kind ever be null?
What's the reason? I have php files and I don't want them to be checked in, even by mistake.
no 1 talk about ZfcBase
2 about ZfcUser
Suggestion is to move everything to be served by a web server into a web/ directory to match pub package layouts.
Given the previous comments the block in lines 173-184 will be something like this:
else {
    return url.replace(/Thumbnail/, format === "Medium" ? "Medium" : "OriginalJpeg")
}
Need to put the actual URL here.
This is a view concern and should be a helper.
CS Nitpick : One argument per line
use an 
insinto & doins 
construct
eutils not needed in the ebuild
vsc.fancylogger !
determine bin dir
whuh?

I must be missing something here... self.cfg is no longer the dict it used to be?
Introspection of URLS to extract application semantics is a REST anti pattern. It may be the case that these JS libraries and web services have agreed to a convention to make it easier for programmers not used to REST to use their APIs but that doesn't mean we have to do likewise.
Nope. I'm saying "root of the JBoss directory" -> "root of the JBoss server directory". JBoss as a brand is overloaded, and we have to be careful using it.
we have also Boolean now
It's probably quite the edge-case too. No big, just wanted to make sure it wasn't an oversight if it _were_ easy.
Too many indents.
Makes sense. So lets make that change.
Yep, sorry for the extra work. I'm only half a step ahead of you in figuring out what we need for the backend stuff so I apologize for the vagueness.
ooh fancy!
also fixed indenting
that is the next step planned
Again, this is generated by scaffolding, and we don't have a strong reason to delete it at present AFAIK. We have a requirement for a JSON API for GS.  We haven't figured out yet exactly which things we want accessible via the API and in what detail, but starting with "everything" is pretty close.
We discussed changing this to `-1` rather than `Integer.MAX_VALUE`. I'll make that change and re-test.
This class has changed as a side effect for removing AddInterfaceCommand, replacing it for AddInterfaceToLRCommand.
It is not the purpose of this patch to fix chassis capability design. In this patch I've only introduced the minimum required changes for CreateLogicalRouter to behave the same way it did.

ChassisCapability requires a refactor. It has no capability logic, and it exports no service interface right now. It's interface is just ICapability with its sendMessage method.
I think creating a special case in sendMessage() for ActionConstants.CREATELOGICALROUTER and adding this logic there is pointless, as it should be refactored anyway.
Furthermore, I guess logical routers and chassis should be two different capabilities, so adding that there may only difficult the split.

That's why I've put it here. I think it's more simple and keeps the structure of the whole capability.
Debugging left over. I suggest you remove this rather than uncomment it.
It's probably better to do a direct check against `None` here.  (Though it's not clear to me how `inputs` and `outputs` are being used:  is there some magic that means that they take part in the `exec` statement, or is it just that they're not needed for this simple `IExecutable` instance.)
Does not follow the pattern suggested by Y.Widget, see http://yuilibrary.com/yui/docs/widget/#widgets-renderer-method
I would add a guard clause to this method similar to:
```
if ( $langID === false )
    trigger_error( "Since 5.0 $langID === false is not supported any more. See http://issues.ez.no/19549" );
```
Yeah ... my sublime text plugin might not be a strict as I like.
Is there not a more programmatic way of creating this? Try to use loops, when you can. I'm not going to hold up the merge for it, though.
hum... 404 is one of my favorite number...
This can probably move outside of the changePassword function, in line wit the other APIs.
The only reason for not doing it is because it might be confusing for users that have no experience with our APIs.
If we make the description clearer everywhere and say it's a Content/Principal/Tenant object my worries disappear.
My vote would be to do that.
We should not recalculate _.keys and .length on each iteration, especially not multiple times.

```javascript
for (var i = 0, keys = _.keys(changes), numKeys = keys.length; i < numKeys; i++) {
  var principalUuid = keys[i];
  ...
}
```
The tenantId value is now retrieved from the row and I removed tenantIds.
I thought that's enough to get an idea who might need a longer timeout. I can print the whole stack trace instead.
How about renaming this ``DebugLaunchConfiguration``. Wouldn't it better express what the class does?
аналогічно https://github.com/stfalcon/BlogBundle/pull/9/files#r1565055
org.bukkit.craftbukkit.entity.Craft* is no longer considered proper (will throw class errors with bukkit.jar).
overrides browser default margin for buttons
`@requires` is not used in Geocoder
I was confused by this for a moment. This comment lists a series of OR clauses, but the lack of a Pig step is a precondition for them all. This is super nitpicky, but please use "Only if" at the beginning.
Annotator messed up - can you remove all the annotation and do 'rake annotate:models' again please.
Строки 22-25 нужны исключительно для меня самого, потому что я путаюсь в граничных значениях. Как индексы могут повторяться, это же множество, повторение элементов в нем невозможно, насколько я знаю, или в Objective-C не так или я что то упускаю?
Все расширения нужно выносить в отдельные файлы.
Простите, но в задании чётко сказано, что нужно сделать свою имплементацию метода init, а не выдумывать свой конструктор.
Вывалится при ошибке доступа к indexes[0], а он до while.
Ну вобщем-то это и есть массив. А вот так ```int indexesToChange[dnaSize];``` , боюсь что не скомпиллируется, так как ```dnaSize``` - это переменная, а не константа.
Per discussion. Randy will update his pull request. Mine should be compatible with XP. Randy used an API that works in Vista or greater.
As you other PR this does not use the coding style used by doctrine.
with the given *value
The fix for fetching from empty repos broke capability detection in HTTP (and probably cloning, come to think of it). I'm fixing this in the library now.
I'm indifferent to it.  I don't much about rspec.
On Nov 27, 2012 8:48 AM, "Justin Campbell" <notifications@github.com> wrote:

> In spec/lib/easystats_spec.rb:
>
> > @@ -5,6 +5,8 @@
> >
> >    it { should respond_to :average }
> >
> > +  it { should respond_to :wma }
>
> I'd prefer to not add this shorthand. Polluting the namespace and whatnot.
> @mgrigajtis <https://github.com/mgrigajtis>?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mgrigajtis/easystats/pull/7/files#r2235199>.
>
>
I would return "[], events"
Great, i'll do it tonight
please send this fix as a separate PR as it is unrelated and could be merged separately.
--dev --prefer-source :)
Что делать? Я о таком первый раз слышу
well, I was searching for something like tmap, but haven't found it in clojure libs. This one looks like the thing I have been looking for.
Yeah, that's a deeper problem if there are duplicate ids.
You can just do:

```
automobile.is_a? Vehicle
```

And that'll test the same thing
I'm also fine with merging as is (as not all lines are formatted that way, anyhow). I meant that more as a tip for future merge requests.
This change doesn't work as expected. Base64 string outputs with some &lt;br&gt;:

data:image/png;base64,&lt;br&gt;iVBORw0KGgoAAAANSUhEUgAAABgAAAAYEAYAAACw5+G7AAAACXZwQWcAAAAYAAAAGAB4TKWmAAAA&lt;br&gt;BmJLR0QAAAAAAAD5Q7t/AAAACXBIWXMAAABIAAAASABGyWs+AAAAWklEQVRYw+3XQQoAIAhE0eb+&lt;br&gt;hy6wdWRphPDnAMVjdKG6pZWNsgCy7F+a/0kAsgFeUBlAuR2IjthtM2GAd/ZfjRI7cAoBAAAAAAAA&lt;br&gt;AAAAwEn5r4Ey98AKkt3AAO4DP5jjTlC3AAAAAElFTkSuQmCC&lt;br&gt;

I have saved the article in GoldenDict (File > Save Article) and edited the html file to stript out those line break and it worked.
No idea, we discussed it on IRC. Let's get a test case done and send it to core.
good point, I'll add a method to return the availability of the sites in the cluster.
That's the thing that's really not implemented yet. In JBoss Cache, we had used different global marshalling mechanisms, and it had allowed us to switch between them. In Infinispan however, we have really stack to the same marshalling mechanism, which is JBoss Marshalling.

Sure, we've varied things over time, but we havent't really worried too much about backwards compatibility when individual commands change. I've found ways to workaround things, as part of https://issues.jboss.org/browse/ISPN-2034, but these are really hacks.

The backwards compatibility requirements are still up in the air from what Mircea told me a few weeks back, hence why I stopped ISPN-2034 until that was properly defined.
The test might fail in many places, and based on sout message I can jump to the appropriate log section. I found it more convenient that  way that editing a log4j config file.  :-)
why not just: SELECT 1 FROM tableNAME LIMIT 1
This is a method on the interface.
I don't think we need such unknownAsBin option. Just return false if it's not known filetype.
I thought about that, but I think it would be too "loud" because of the code examples that would have to go inside the note box as well.
This deserves some explanation.  Some backends, such as WebAgg, do not support blitting.  In the case of WebAgg, it's because blitting is not possible -- we don't have direct access to the window/screen buffers anyway, so there is no advantage to it.  This allows code that was written to expect blitting (such as all of the `examples/animation` examples) to still work.  There should be consistent behavior across backends, even when certain features are not available.
Is there any way to make this only wrap to two lines instead of three?
If code isn't needed, remove it.
Could you fix indentations in this file? OCD...
please put on 2 lines
The distinction isn't about whether the material is a tutorial -- it's about information for people writing applications vs running them.  I've put those sections into the programming page
I might be ok with keeping hardcoded colors if they are used elsewhere already to keep the diff size down.
sounds weird to me... `Enablable` is not a good choice either (it would imply `setEnable` or something like this)
The socket is intentionally 0666. Apache, which may run as a different user than the app process, must be able to connect to the socket. Security is enforced with a password. The directory containing the sockets is sticky so that other users cannot unlink the file.
you should change the indentation of the whole block as you removed a ``if`` level
buttons for the players in the battle GUI
Looking API docs it's true there is no header property for TableView. but  it is used in the code - like this
data[2] = Ti.UI.createTableViewRow({hasCheck:true,title:'Header should be Bar',header:'Bar'});
and it is actually working for example on Android.
From API docs  - headerTitle is actually property for TableViewSection object so I have changed the comment to mention precisely the module and property which are needed.
woops, nice catch!
some more CS violations in this file
We are going to merge it as it is, and then you can open a ticket so we continue on this small issue
I wonder what’s needed to make `iOS Simulator` show up in Spotlight searches (with Applications enabled in Spotlight). I’ll try placing it in `/Applications` and will let you know.
I don't mind this change if you really care about it, but I think that 6881 should be the default, regardless.
We go into new line after `}`.
No, don't format it like this. Date formatting should be done so that it depends on the language used. Find one Django template filter for that. :-)
Not correct. You have smaller blocks you can extend. You are still copy-pasting too much. What you need: you just need some additional information after each field, no? So which available block would be the most suitable for that?
Move static JavaScript code to external file.
Bind to both keyup and change (what about copy/paste into the input box).

There is no reason to have an anonymous function which just calls `checkPassword`. Just bind `checkPassword`.
Corrected :).
Don't we have a string that is used in other gateways for this? Something like "ActiveMerchant Version 1.29.0"? If we don't its not a big deal, thought I saw something like that at one point.
I don't have to Decoder this, I was told to convert and drop script_texts only
This updates always change the same row in db, action_menu_id allows to show a new gossip_menu when you click on the gossip_option, and it's a different field than menu_id
You can get entry of menus executing this (notice that id of npc_text can be found on cpp script)
```sql
SELECT * FROM `gossip_menu` WHERE `text_id` IN (13778,13779,13780);
```

Also take a look of Neltharaku's SAI (ID = 21657), also works the same way than this
Same explanation for your comment below.
LOL. Ooops! You got nova right above, but you doubled the owner line and left out group! :)
Looks like there's not an entry in parent pom.xml dependencyManagement section for this artifact.. Does a simple "mvn clean" work?
added a raise when kind is not socket/watcher
list_documents
It's set in directory.zsh using CDABLE_VARS hence your search didn't find it
One of the test failures is coming from here. I think you just want vstack instead of concatenate + reshape. (That is if you still want to keep row vectors, which I suspect you might not.)
Need to get rid of the print statements.
are we sure about this? we might run into conflicts with https://github.com/doctrine/phpcr-odm/blob/master/composer.json#L15 for example... but if symfony-standard is doing it, i am ok with keeping it for now
Small stylistic simplification would be nice.
````java
if (contentXML == null) {
  return true;
}
// rest of method
````
I think this is clear enough.  Thanks.
Please move down into alpha order.
This should just be if/else rather than an if and then an unless.
Is this a "TODO"? Or a statement of desired behaviour?
Instead of commenting out, we could say `\@Test(enabled=false)` and include the TODO?
I really don't like commented out code :-)
Also, there is no LocationSummary. That's another asymmetry with entity (possibly justified - I'd need to think about it a lot more).
I pushed a changeset to remove the pre tags.

On 2012-11-13, at 10:11 AM, Jonathan Green <notifications@github.com> wrote:

> In ucla_pdf.module:
> 
> >    module_load_include('inc', 'ucla_pdf', 'ucla_pdf');
> >    $out = ucla_pdf_format_datastream_text($object, $dsid);
> > -  $out .= "<br/><a href='download_translation'>Download as txt</a>";
> > +
> > +  // Add a link to download the text using Islandora's RESTful api.
> > +  global $base_url;
> > +  $download_url = $base_url . '/islandora/object/' . $object->id . '/datastream/' . $dsid . '/download';
> > +  $link_text = t('Download as txt');
> > +  $out .= "<br /><pre>" . l($link_text, $download_url, array('attributes' => array('class' => array('ucla-pdf-link')))) . "</pre>";
> Can you pull out the pre tag around the link here?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
ああ ><
駄目じゃないんだけど、欲しいのは UserGlossary の id だからURL的に紛らわしくないですかね。
それとも普通の CRUD にして UserConfig の id とUserGlossary の id を両方受け渡す方がいいんですかねえ？
You can't really rely on order here, I might have PRIMARY/SECONDARY the other way around. That's why I used a count.
Rewrote it. Should be much clearer now.
it could be very useful, but we need to keep modularity in mind as well. If we move to providing api's as npm packages e.g. this might be more annoying then helpful in the long run IMO. Maybe we need to create a dependency scheme in T3.3?
pyflakes found it. It said, "Mmm... this isn't used." and I said, "Wait, really? Even with that massive comment?" and it replied, "Yes, really. Please don't question me in the future." Then I felt bad for making it cross.
CS too. You have to use an indent of 4 spaces.
Wow one would not expect such a bug in the ST library.
and here, too.
Will we iterate twice as many times as necessary because we're adding to `toInclude` as we go? I think it's clearer, and probably more efficient, to use two different objects, one as the input and one as the output. If the regular expression matches, you can hack off the `-#` before adding to the output, otherwise, you can just add it.
yeah please. sorry
Сделай тест, в котором метод выбрасывает исключение. И проверяй, что прилетает корректное исключение в вызывающем коде.
Если interupted, то это значит уже вызывался close(), и например мы ожидаем удаления из списков
Можно упростить: ```return countOfDigits - countOfOperands == 1```
This factory object is what I'm currently using to put together a sequence of worlds to be played in order, along with their descriptions. It would probably be much better as some sort of DSL, or even a JSON file.
`was_refund_successful` :)
But the locator targets .visible as the class. I think it's better to use `is_element_present` because this is an explicit wait itself, we don't need the implicit wait in `is_element_visible`
> In scikit-learn, we are used to put a trailing underscore to all fitted
> attributes (self.W_).

In addition, we know try to avoid single-letter variable names. Can you
find a more explicit name?
On Sat, Sep 29, 2012 at 09:54:36AM -0700, Satrajit Ghosh wrote:
> hi @GaelVaroquaux, i have to disagree with the variant statement. i
> think that's precisely what you want to do is to allow variants, unless
> things become practically unmanageable, which we are not close to
> reaching and giving users choices is the point of a library, not to
> constrain it.

I still disagree, on both points.

* Giving choice: you use an Apple computer, don't you. Well the thing
  that Apple understood really well is that user's don't like choice. You
  want choice because part of your work is to compare algorithm. Many
  people tell me that the amount of different options implemented in
  scikit-learn is daunting. If we add more algorithms, which we are going
  to, they need to bring a real added value.

* We are not at the point of things becoming unmanageable, but we are
  putting on weight. In addition, we have to think preemptively. If we
  integrated every variant of each algorithm already in the scikit, we'd
  be in trouble. The way I go, with regards to what I put in the scikit,
  is that I try a few variant in my research, wait a put to gain insight,
  and only then do I choose what I push in the scikit.

  Besides, speaking of things getting unmanageable, I nowadays spend more
  time doing infrastructure work and cleaning up than doing new
  algorithmic development in the scikit. We have grown quite a lot with 65
  Klocs and it is starting to slow us down. This is a fundamental law of
  software development: complexity grows approximately as the square of
  the number of features or options [1]. Feature creep and the associated
  growth in complexity and entropy is a major trap for software projects
  (see point 4 on
  http://dotmac.rationalmind.net/2010/08/17/some-lesser-known-truths-about-programming/
  ).

> fortunately, in this particular case, the diffusion map embedding has
> both theoretical and practical implications that are not captured by
> the current spectral embedding method and has a growing literature
> behind it.

I am interested. What material can you offer us to back this statement?

>   • saying that the current spectral embedding generates a diffusion map is a
>     little misleading if our point is to be precise

Could you elaborate a bit more. What are the exact differences that you
see?

> just to keep things separate and to demonstrate it's efficacy in some domains,
> i'll put some work into this and submit as a separate estimator. we can always
> refactor after looking at the practical implications.

Indeed, if you can show some clear cut benefits on specific applications,
I'll buy your variant :).

[1] An experiment on unit increase in problem complexity, SN Woodfield
    1979.
grammar? ;)
And maybe also that U and V are still orthogonal.
Please remove commented old code.
do you mean "as close as possible to"?
you'll need to add kalman/tests once the test_kalman is added
в мене просто чомусь при виконанні фікстур в базу не заносилися потрібні поля (пароль та ще деякі). я пробував різні варіанти і зупинився на тому, що у мене запрацював
You could inline the len() call here since you aren't using count anywhere else.
Was this really supposed to be here? What is the value of printing the graph database to stdout when getting a NPE from broker.getMasterReally()?
You are right, and I cannot remember why I selected `1`/`0` instead of `MATCHxxx`. Will do.
Please make this description more useful and complete by adding such details as what this class represents, how to use it and how it relates to other classes.
should be TI_BATTERY_STATE
Pour le code postal, tous ne sont pas français, ils peuvent parfois être plus long ou plus court. Le mieux c'est de ne pas mettre de contraintes
I think this list blocks should be unindented
I assume this comment is inaccurate?
I don't want to assume anything now. We can leave the clang warnings for other requests...
Yes, but I think we should change all over (ie. helpers, transforms, etc) altogether, rather than half now and half later.
Regardless, we need to change this line. Or remove the whole function. I'm fine either way.
Please add a space between the ``if`` and the oepning parenthesis
I had to run the T4MVC T4 template again and it cleared out these extra spaces. There's a bunch of these, I suggest skimming past them ;)
Yeah serialize does some funcky staff and I did not wanted to go into inverting all of that. Also serialize is not really compatible with node's one. But as mentioned in description this is not perfect and some tests are disabled, but it's good enough for `request` module so I though we could land this and iterate on `querystring` module later to make it better. At the moment I can not all of this somewhere at the top of this file.
ah yeah, I forgot that the fetcher was excluding replies so users cannot really need this method
I'm not sure I understand what this aspect is for: why would we want to dynamically generate forms on the fly for RESTful web services?
This looks pretty complicated, and will likely be hard to maintain. The gist seems simple though, so consider simplifying the code. Something like this would be simpler, and achieve the same thing:

    boolean isPrevClientHandlerException = false;
    for (Throwable scan = cause; scan != null; scan = scan.getCause()) {
        if (ServiceException.class.isAssignableFrom(scan.getClass())) {
            return populate(exception, serviceName, (ServiceException) scan);
        } else if (UniformInterfaceException.class.isAssignableFrom(scan.getClass())) {
            return populate(exception, serviceName, (UniformInterfaceException) scan);
        } else if (isPrevClientHandlerException && SocketTimeoutException.class.isAssignableFrom(scanClass)) {
            return populate(exception, serviceName, (SocketTimeoutException) scan);
        }
        isPrevClientHandlerException = ClientHandlerException.class.isAssignableFrom(scanClass);
            
Unless there is some subtlety that I'm missing.
Ah dang, I should make all the urls into templates.  Thanks for reminding me.
@bodepd yup, I found them both in the docs, would you still prefer I use start? If so I'll resubmit now.
Is it a format string bug, or an overflow?
if not res or not res.body

I actually prefer if !res or !res.body, but whatev
typo: `downsampling` -> `upsampling`
Since `bindings` isn't initialized unless `bindTo` is invoked, will this cause errors if the view is removed without ever binding to anything?
I'd expose an argument that is a quality/speed tradeoff and then do `Math.min(maximumAnisotropy, context.getMaximumTextureFilterAnisotropy())`.

For example, in my and @shunter's app, in low quality `maximumAnisotropy` will be `1`, in high quality, it might be `8` or `16`.

I dont't know what a good default is, maybe `Math.min(8, context.getMaximumTextureFilterAnisotropy())`.
Formatting is off here in Sandcastle.  Tabs vs. spaces?
Fair enough +1
android has INPUT_BUTTONMODE_ONFOCUS
I would say leave it, but comment it out.
Can this be defined above with the rest of the variables?
Maybe we can just rename it something like:
@Kroll.method(name="_fireEventToParent")
If it's not a kroll method, it can not be called from events.js
This seems like two distinct errors, and we shouldn't lump them together into one.
"/themeroller" and "/resources" are on the same level. An alternative would be "/resources/images..." instead of "../resources/images..."/
Sí, es mejor que sea una lista.
use `each` or `each_with_object` (from active_support)
There are a sufficient number of steps here that it may be useful to use `Async.chain`.
This line should go after bundle. Whoops.
Retirei o ";" (Ponto e virgula) no início da linha, pois embora possa ser útil em situações raras não é necessário se quem estiver programando o fizer da forma certa.

Outro motivo pelo qual também removi o undefined dos parâmetros é que ao minificar o arquivo, este seria inútil assim como o ponto e virgula que seria retirado caso esteja usando UglifyJS
При объявлении метода лучше указывать скобки - выглядит более читабельно.
Я бы вообще везде указывал скобки :).
Does this belong to user documentation?
There is no nitpicky when it comes to documentation. Besides, I've proven I'm not a master of the English language...
I don't think that's a strong argument. By that logic, even `File` would be a function call, or any other `struct` constructor...
I'm presuming that's in line with semver.org, which I think is broadly sensible, but I haven't seen people reference explicitly?
I am so messy. Will fix.
This sounds like a great idea. So great that I actually doubt we are the only ones needing such a thing
I just named it after the svn hook type. What about EDBBeginCommitHook?
Looks weird compared to the next line, you need to use tabs as separators on both of them.
What should it be securing then? The callback is called on the implementers side, so I guess you're in trouble yourself if you do weird things with callbacks?
You didn't add the OpenMRS license. If you're using Intellij, make sure you set this up as a COPYRIGHT.
When I first opened the solution in VS and ran the unit tests in ReSharper I kept getting a BadImageFormatException. Turns out that ServiceStack.Text.Tests has a dependency on ServiceStack,Common.Tests which built targeting x86 (probably because it has a dependency on Sqlite).

I had to make this change to be able to run the unit tests.
The font-family should be variable-ized.
Thinking about it, I would drop the URI detection altogether and just try the namespace one.
Spaces around % and after ,
Spaces aorund =, after :
you should fix the typo here
That's a very good point @nicolaasmatthijs. Seems like we should be using mouseout on the affected element there instead, if possible
Missing space before `{` throughout this function and below too - need a pass through this whole file for it, so I'll refrain from line by line commenting on it
Neither new nor old code works for `const`.

It looks like it's impossible to work correct with `shared` because of this:
```D
int i = 0;

struct S
{
	~this ()
	{ ++i; }
}

struct SS
{
	shared ~this ()
	{ ++i; }
}

void main()
{
	S s;
	typeid(S).destroy(&s);
	assert(i == 1); i = 0; // ok
	typeid(shared S).destroy(&s);
	assert(i == 1); i = 0; // failed

	// can't use S here because of compiler bug (but can use in `shared S[1] sarr`)
	shared SS ss;
	typeid(SS).destroy(cast(void*) &ss);
	assert(i == 1); i = 0; // ok
	typeid(shared SS).destroy(cast(void*) &ss);
	assert(i == 1); i = 0; // failed
}

```

Anyway, I completely forget about `shared`. Will change to mimic old `destroy` `shared`-rejecting behavior.
as an option I would suggest smth like
```
bash "Create /usr/lib/jvm-exports/java if possible" do
  flags "-ex"
   code <<-EOH
     rm -rf /home/pg_xlog/*
   EOH
end
```
`placeholder.children('canvas').length > 0` -> `placeholder.children('canvas').length` -> `placeholder.children('canvas')`, no?
Diego, i cant recall now, did you suggest that I put this in a two-dimensional array? so that I did not have to supply the separate list of interfaces?

something like the following
"interfaces[eth0][IPADDR]" string => "192.168.35.11";
"interfaces[eth1][IPADDR]" string => "172.16.210.65";

How do you suggest that I iterate over the second dimension of the array? I could build a list of allowable values, but that also kind of pushes this bundle more specific to redhat which i guess also leads to my question of renaming the bundle to signify its redhat specificities.

If there is trick to be able to getindicies on the second dimension then this bundle still has a shot at being generic enough to be adaptable to other distros as well.
ReportServiceImpl.class

you don't need getName
`created` &rarr; `create`
Great question! One email account is the current use case, and will be the
only use case for the foreseeable future.
On Nov 30, 2012 10:26 AM, "mbellotti" <notifications@github.com> wrote:

> In application.py:
>
> > @@ -0,0 +1,42 @@
> > +from flask import Flask, render_template
> > +app = Flask(__name__)
> > +
> > +import imaplib
> > +from email.parser import HeaderParser
> > +
> > +
> > +@app.route("/")
> > +def main():
> > +	mail = imaplib.IMAP4_SSL('imap.gmail.com')#tested with gmail but should work with any IMAP email
> > +	mail.login('some_email@gmail.com', 'password')#set this
>
> On that note ... show I be designing this project with the idea that only
> one email account will be accessed? Or that multiple email accounts may
> want to be visualized in the same way?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CodeMontage/mentor-editor-monitor/pull/5/files#r2278895>.
>
>
My only question is looking at Pydoc http://docs.python.org/library/functions.html#hasattr for hasattr(), it just tests for existence not if it's None or empty. I ask becase don't all docs coming out of couchdb have an id?  I'm just wondering because I'm not understanding how this fixes the problem.
and the requirements on the other bundle should be resolved by composer for you
may be "Jagger Easy Deploy" ?
i totally missed that this was a CLI param vs a YML config option.  it'd be nice to add a CLI test for this if possible.
@khawkins  Since SFForcePlugin is basically just adding a method to CDVPlugin, should I have used a category instead?
isEmpty check should not be required, containsKey should suffice
Implementing the interface is not strictly necessary anymore; considering we don't implement other interfaces represented in the Module class, we either need to add all of them, or omit this one, for consistency.
What is `blockQueue`? This isn't clear to the outside world without looking at the source code for TiMessenger
I would be fine just making ASSERT stop execution when it catches a failure. ASSERT should only be used to verify some state that
if incorrect can lead to a crash or critical failure. So stopping the program would be ideal. Otherwise just using regular LOG macros when
you don't want to stop execution would be another choice.
Dead code??

// << " __name:=" << packageNodeName.second;

En wat met parameters? (eg. cameraNode CameraNode 0 1 Deltalens.xml)
Ympäröivä `if` on tarpeeton. Lausekkeella `(== (mod n divisor) 0)` on jo haluttu totuusarvo
for w in work: BatchTask(parent=batcher_key)(*w)