labofsahil/github-event-dataset-2012 huggingface dataset:
please dont do that ... i've tested and got everything working with javascript generating iframe. what is the usecase of this?
we've talk with rob about this how to eliminate that initial blink and generating iframe with javascript was best solution. since this reduces initial requests needed to show toolbar. please revert this.
Hi subbu
  As you have mentioned in your previous reply I downloaded uidai_prod_stage.cer and uidai_auth_stage.cer and i tried to run the application but i am getting the below erorr plz have look and are you sure about that their is no need to add any file except those two TEMP_STORE_CERTIFICATE and TEMP_STORE_KEY_CERTIFICATE  and thanks for your previous reply

Erorr:
====
Digital Signature using XML Security
Segmentation fault

Thanking you
Madhu
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |          0.5 |
| advanced  |          0 |
| not storing pointless input | 0.25 |
| **Total** |          0.75 |

> I actually had a little trouble grading this assignment for you with my scripts.  You didn't show up as missing but I couldn't find the info on the tag.  Anyways, that's neither here nor there.  Make sure to leave the homework in the proper homework directory going forward.

Overall well done.  I like the part where you don't store the `raw_input` you don't use.  The only issue is that you didn't follow step one *exactly*.  In the rest of your code you missed a couple things it was testing: string concatenation and a raw_input with a prompt string.

Here is the full step one code.

```python
# Step 1
name = raw_input("Enter your name: ")
print ""
print "PrissyBot:  Hello there, " + name + "!"
resp = raw_input(name + ":")
print "PrissyBot: You mean, \"" + resp + ", sir!\""
```

Anyways, for hurting my feelings, I give you the [asterisk](http://youtu.be/JTVpxxzb2Dc) award

![award image](http://scienceblogs.com/pharyngula/upload/2006/10/asterisk.gif)
character_aura db need reset @Sethi
Looks good to me except for that stuff in the deploy folder that still gets committed. Is there a way to get rid of everything in the deploy folder in a separate commit?
Need to investigate why deploy is still commited.
he puesto 100% el del r2 a ver si va bien
You makin me feel stupid looking at how easy was the encoding thing :(
I agree, but the if-statement that was checking for a max chunk size was currently set to exactly that, so that is what I used for this specific patch.

I'm not entirely sure how wild-west we get with drivers, especially being anyone can push/pull, but I chose to opt for the leaving things functionally the same for now and as I get more comfortable with the process I can do things more in the form of what I think is right and not so much what I think is less incorrect.
Now that we added some stuff to the model you can add some tests into here :).
Agreed. Internals are not that great, I guess. What do you suggest, just rename it to model_class?
I'll make this lowercase.
I vote this goes up on the canonical repository.
changing the default behavior to True is on my todo list. I'll try to do it later today
Nice @ Foto :-D
btnクラスはButtonクラスにも足したほうがいいかも？
Doesn't it make sense to leave this as is, since todo.txt-touch is the name of the git repo folder?
Cheers. it make sense!

-Vivek
Looks good.  I think keeping hyphens in the HTML attribute names is still acceptable, given that this is all in line with the HTML5 spec, but we might want to indicate it with comments either in the PHP or the JS for newcomers (like me yesterday! ;-) )
Actually no, the removal of /etc/powervr-esrev, just allows the pvr script to run fully again. (in the pvr script there's an if statement that looks at the file, if it saved the same same ES version as what's running it doesn't copy any files, kinda not helpful when i'm tweaking that files in that ES directory..)

The "/etc/powervr.ini" surprising actually fixes the 0x3001 error caused by running "./eglinfo"  so right now, all the test bin's that are in /usr/bin/ESx.0/ now work with no errors and report lots all SGX compatibles.. But any demo is now erroring out with a DRM DRI2 issue... (yay)  In the sgx km sources there's a drm based framebuffer driver (dc_omapfb3_linux), so i probally have to build that too (it didn't exist before).. That's going to be my test this morning..

https://github.com/RobertCNelson/stable-kernel/blob/sgx_4.05.00.03/patches/sgx/0001-TI-SGX-Merge-4.05.00.03-into-4.03.00.02.patch#L786

Regards,
Su ana kadar hic bir sorun cikarmadi. GTK ayaralari duzgun yapilinca 
sorun yok gibi
Zaten Iceweasel Firefox ile %100 ayni sey. Sadece debian ' daki ismi 
Iceweasel
Yine de Firefox , Chromium ve Opera diye uc browser ile de cikilabilir

On Tue, 28 Feb 2012 11:04:33 -0800, nano68 wrote:
> bence iceweasel olmasın.Firefox veya chrome olabilir.Çünkü iceweasel
> gtk sorunları çıkarabiliyor
>
> ---
> Reply to this email directly or view it on GitHub:
> 
> https://github.com/adakteknoloji/magmalinux_12.3/commit/cffffc87f1432afbb8795378b1e17f46df7deba3#commitcomment-1022461
I didn't actually reset the head, I added a new commit that renamed the file.  So everything is fine.


On Feb 15, 2012, at 12:19 PM, John Myles White wrote:

> Could you check this didn't kill my other changes? This could in theory affect both file names and directory layout.
> 
> -- John
> 
> On Feb 15, 2012, at 12:08 PM, Drew Conway <reply@reply.github.com> wrote:
> 
>> Rolling this back so that the file names for chapter 1 are consistent with the book.
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970208
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/johnmyleswhite/ML_for_Hackers/commit/3a7a3d52b562b0738de05d23c01dcf888ce34e70#commitcomment-970251
I've done some research: playing the VirtualVideoAction MPG is not broken by this commit, but by c761b087141e99bc2417f734f52220ea38da6309.
I wondered about that, but saw it in a few styles. Also, I suspected they were not needed since you had not fixed anything there. However, my reasoning was double:
- could it not make sense that a dependent style could want a locale different from its parent in some cases?
- if/when the style becomes independent later, we have already the locale set (OK, not a very strong argument!)

I am sorry if this discussion has already been brought up before.
Make these properties (strong). Remove readwrite and nonatomic.
estas vuelven a estar mal escritas
Nee, echt niet. De Accept-header is bedoeld om de beperkingen en voorkeuren van een client aan te geven, onafhankelijk van individuele requests. 

Ga je in dit geval de Accept-header gebruiken dan maak je het nodeloos ingewikkeld voor gebruikers, en soms zelfs onmogelijk, wanneer ze een client gebruiken waarin die header niet is aan te passen. Een gemiddelde webbrowser, bijvoorbeeld. 

En dat hier de keus is tussen twee formaten die verschillende mimetypes hebben is arbitrair. Het zou even goed kunnen gaan om een keus tussen twee formaten die hetzelfde mimetype hebben.
FIXME detected : where are the tests ? can we remove this after next commits ?
Why are you turning this on?
This should be GridFieldRelationAdd?
These options should be moved to the WCF core (because of the DatabaseObjectActions) :).
Whoa no, it wasn't. I copied this file over from my changes to the version of the file in here https://github.com/andreasgal/B2G/tree/master/glue/gonk/device/samsung which is over 17 days old, so these files are out of sync. Great catch, I'll test it with the latest code tomorrow and do a pull request then.
Certainly an interesting take on the parsers.  I can certainly see how it is much easier to work with.  I worry a little that performance may be impacted, but the larger concern I would have would be with nested values (perhaps beanstalk just doesn't have these).  There are cases in other AWS services where say "Object" appears in more than one context and I'm not sure this setup provides a way to differentiate (I could be wrong, maybe your setup does do that).  I would say that this is probably good in that it consolidates the complexity instead of spreading it across a number of different files and repeating things.
There isn't much point in reimplementing most of [`add_option_group`](http://hg.python.org/cpython/file/a9341ce35abc/Lib/optparse.py#l1335) when the only 'stateful' thing it does is append to `option_groups`. I'm also fine with `self.parser.option_group.insert(idx, group)`, but I really think my solution is good enough, so I'll let you sort it out anyway you find appropriate post-merge.
Do we expect users to ever call these functions explicitly?

If yes, they need documenting.
If no, they need to not look like user-visible functions.
Why does it throw if it returns an Option? In that case just return a Try instead of an Option?
Wow, what happened? (I assumed that "val n = removeChild(..)" was moved to the top and that the second removeChild was removed?)
No returns
def dequeue(): Envelope = storage.pull().map(deserialize).orNull
At least capitalize "just" since at the beginning of a sentence. ;) And change the order of "to" and "below"
addresses is a Set, right? then this should probably use mkString to construct a nice logger name
That's not how we roll, create an ADT
i need to look through a little more, but is there a good spot to apply this flag to new clients? perhaps at subscription time?
These parameters now use active_support/configurable.

I can't set these as defaults in the gem because they would be unresolved, and I don't want any dependencies from name_logic to wagn things, only in the other direction.
I held some stuff over from WikiContent, but it isn't clear that I need any of it. @not_rendered and @pre_rendered, etc.
This comment is outright wrong, isn't it? Looks like copy and paste, though, the same wrong comment is in also in rsync.pm and CVS.pm. And a different incorrect comment is in point.pm. Wow, how did we managed to do that?? :)
Returned back
It is not re-implemented.
Will do - hopefully sometime this weekend.

On Thu, Nov 1, 2012 at 5:26 PM, MrBago <notifications@github.com> wrote:

> In dipy/reconst/dti.py:
>
> > +    sig = np.maximum(flat_data, min_signal)
> > +    log_s = np.log(sig)
> > +    D = np.dot(inv_design, log_s.T).T
> > +
> > +    # Flatten for the iteration over voxels:
> > +    ols_params = np.reshape(D, (-1, D.shape[-1]))
> > +    # 12 parameters per voxel (evals + evecs):
> > +    dti_params = np.empty((flat_data.shape[0], 12))
> > +    for vox in xrange(flat_data.shape[0]):
> > +        start_params = ols_params[vox]
> > +        # Do the optimization in this voxel:
> > +        this_tensor = opt.fmin(_nlls_err_func, start_params,
> > +                               args=(design_matrix, flat_data[vox],
> > +                                     weighting, sigma),
> > +                               disp=False)
> > +
>
> hey ariel, when you have time can you try using scipy.optimize.leassq,
> from my experience leastsq is 5-10 times faster than fmin.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/54/files#r2012225>.
>
>
`type` is a python keyword. I Changed it to `preview_type` in 8b0975dca9032df151b.
+1 to this. This feels a ton better in a handler package, arbitrary as it may be from a technical standpoint.
Remove extra blank line while you're in here.
what's the 'changed' event?  shouldn't this just be `self.on('change', self._displayCheckedValues)`?
One presumes you could use m_label.scrollSpeed here, as that is what is set in the constructor, thus dropping the requirement for this member?
Seem pointless..
Good catch. This is part of TODO 7 in the list on the main PR message. After thinking about a better way to do this and talking to @amet over the weekend, I'll be putting this back in.
Deberías utilizar BigDecimal para este tipo de variables
Missing `@return …`
Unfortunately all these carefully formatted C-style comments didn't survive the reindentation properly.  We have two choices: (1) Fix them up by inserting some leading spaces, or (2) Just replace them with the doxygen single-line style comments.  I prefer choice (2), so we'd have in this simple case,

  /// Close the connection to the piqsl display server.

Of course, there's choice (3) which is put up with the code being slightly less readable after the reformatting than before but I don't like that one at all ;-)
All `private` functions should be declared after `protected` ones.
Ah, I forgot to add that!
@jwilling in init?
Use an explicit state removal here ```Placeholder.removeState( PLACEHOLDER_STATE )```
I like the use the classifiers here.
do you need to glob? i think you can use the path you created. besides output img is a File not a list, right?
Not sure what happens to scalar indices and slices, for that matter, when fancy indices are present. Good point. Will investigate, and also check the empty case.
When working, it will disable the desktop scrolling, but it will let you scroll the windows' content. By now it locks everything, so it's disabled
No. I mean that I treat window as a DOM element. It's the onload event of
the window, not the magical global onload event.

Why are we arguing?
The problem is that you allocate s but do not free it. It creates memory leak. It should be fixed.
To ensure an SPKAC is created, I should modify that to be

```c
if (sizeof(s)!=8) {
```
Yeah - needs `using defaults` in the grammar. Substituting those details is as trivial as setting defaults on `routeParams`.
You're right. Fixed and pushed.
Why use `method_missing` instead of ruby's DelegateClass (from the stdlib's "delegate") which copies the public methods and exposes the public API?
Yep, much better. Updated.
I think the previous was correct.
I find this line very difficult to read without parentheses around the method call.
The comment here is not exact now.
thx for the comment. done.
You mean "case-insensitive"?
Perhaps:

```scala
kindErrors match {
  case Nil =>
    def notWithinBounds() = NotWithinBounds(tree, prefix, targs, tparams, Nil)
    isWithinBounds(pre, owner, tparams, targs) || {notWithinBounds(); false}
  case errors =>
    def kindBoundErrors() = KindBoundErrors(tree, prefix, targs, tparams, errors)
    (targs contains WildcardType) || {kindBoundErrors(); false}
}
```
PIL is required to read in PNG files outputted by OpenJPEG.
I think that    `...: except (AttributeError, TypeError):` works in most versions of python.
I'll rewrap
The docstring should be updated to reflect this.
> `return t.op(*map(construct, t.args))` 

This is done in the case of a few special objects. I'm happy to add any other type up here that has some built-in method to avoid auto-evaluation. We can expand or change construct in the future to suit our needs. I'd like to merge and close this PR and make this into an issue. This is the same issue we had in `rules`.
No need to use var $joinTableName. Remove 1046 and make 1047 like:
```
if(($joinTable=$schema->getTable($this->relation->getJunctionTableName()))===null)
```
Please rename `$um` to `$urlManager`.
Rest looks good to me.
Suppression accidentelle. Mais rien de grave.
Hmm, it looks like I made a mistake and backed out the change to 0.8f with c2734ae. The first two commits in this PR are not identical to the OU versions (I pulled them forward in history from earlier work by @Skoader), so it's possible the intended effect of c2734ae was introduced in those.
Note to self: Read this line of code before making the above comment.
When referring to client IDs, always disambiguate from server IDs by using something like `this.parentClientId = options.parentClientId`.
Defaulting these to an empty array is going to cause the if's later on to always evaluate to true.

I think this may be worth a test case to not break things.
There is another possibility, which is the simplest one: inject the app object instead of the request one, and get the request from the app whenever you need it.
I think `mixed` should be `array`. The parameters param should always be an array, because in the Symfony\Component\Routing\Generator\UrlGenerator::doGenerate() method (this method will be called) we use `array_replace(..., $parameters)` and that throws an error when `$parameters` isn't a array.
I'd move it before the `var t` line and just skip everything in this method if we're not visible.
As I can understand file size is calculated by file stat module. This module doesn't use any IO operations like file open. So it don't analyze content. 
binmode help you read bytes instead of symbols, but it don't have influence of file stat.
File.stat(filename).size should give you valid results even on files that can't be open (Windows pagefile for example).
?print_params
Should this line not just get removed?
For unit testing?  We can just make the tests verify the messages and it should be the same thing, right?
Maybe also check that there is an `error` message in the `messages` to avoid possible future regressions.

See example here https://github.com/mozilla/remo/blob/master/remo/profiles/tests/test_views.py#L202
are we always going to assume number_of_reps is ALWAYS guaranteed to be an integer? might be nice to force parseInt(number_of_reps, 10) before assuming... and if it is NaN then you know a string was arbitrarily passed and your script won't die.
These changes to index.php are simply a reversion of the changes made by the previous front controller implementation. I have not double checked this, but index.php should now be the same as it was before the old method was introduced.
This is a misuse of accept header in any case.
And why are we doing it? What are we paying the db drivers for?
I know this is empty, it's just a placeholder for now.
Wait a minute, *you* wrote that extension acp test.

Here is the current situation:

1. Vanilla phpbb has no extensions (ext directory does not exist at all).
2. You have some extensions in the tree, at which point your board is no longer an unmodified phpbb board.
3. As a result you have test failures.

You need to clear out *your* ext directory before running tests.
I personally think, block_var_name should replace pagination, and not be prepended.
you could than still specify xyz.pagination but you could also go without the nested loop if you want to.
This code is wrong in either case. If you want to show the effective style, replace the query with a select count(*) from users when style override is in effect.
Yes, this was how I had it in the tutorial, but that wasn't for core contributions. When adding to the actual core source, it should be added into the array properly, like so:
    
    'notify' => request_var('notify', (bool) $user->data['user_notify']),
    'selecteditor' => request_var('selecteditor', (bool) $user->data['user_selecteditor']),
`#` intentional or typo?
we should double check to see if friendly_name is nil.
Are you sure `100` makes sense? We set Orbit to `60` for example.
- Swap _PropertyDescriptor_ to _var_
My goal for SimpleOwinAspNetHost was to just have a single file. That means I will now have to maintain two different version of SimpleOwin. Should I just rather reference the SimpleOwin.Hosts.AspNet.dll instead of file then?
Just the other day my mom was saying she was reviewing a case with a patient -- 33 and 81. She then asked me which was the BMI, and which the age? Oh, America...
dont commit commented code
Why device+model and not "device" only?
Use layer constants defined in models_ci.py instead of 7
At least with Cocoa / Mac, these extension checks should be done with `gl::isExtensionAvailable()`, since they'll always be defined but may possibly be defined to 0.
Missing empty lines here, see pep008
Doesn't this line need to be outsite the `{% for %}` loop? Otherwise it gets called for each `o` and won't actually cycle...
Extra tab.
Since `.buildFragment()` isn't a public API we really shouldn't be using it in unit tests. How do we get fragments like this via the public API?
Why do we need this check, as coeff is coef * coef and should be positive value.
just always `return modal;` no need to do a check here if it's falsey
This has to be raw text parsing. Good point though and I will do text parse instead ofJSONP evaluation.
Fix the indent here
This ends up turning on any colorbars that had previously been hidden which can be problematic in cases where you've removed earlier views, since for the life of me I cannot figure out how to actually kill a mlab.colorbar actor and thus a lot of the removal returns just hide those.
insert line here
I'm pretty sure we want a sync there as well. The sync is part of the protocol for all prepared queries regardless of SELECT or UPDATE.

    http://www.postgresql.org/docs/9.1/static/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY

Or do you have a different interpretation?
On Thu, May 10, 2012 at 4:44 AM, Dirk Uys
<reply@reply.github.com>
wrote:
>> +@login_required
>> +@organizer_required
>> +def edit_participants_organizer_delete(request, slug, username):
>> +    """ remove username as an organizer for the course """
>> +    participation = get_object_or_404(Participation,
>> +        project__slug=slug, user__username=username, left_on__isnull=True)
>> +    organizers = Participation.objects.filter(
>> +        project__slug=slug,
>> +        user__deleted=False,
>> +        organizing=True)
>> +    if len(organizers) == 1 and participation.id == organizers[0].id:
>> +        messages.error(request, _('You cannot delete the only organizer'))
>> +    elif request.method != 'POST':
>> +        http.Http404
>> +    else:
>> +        participation.organizing = False
>
> should this also be done when adding an organizer, since currently we do not know when someone got promoted to organizer?

Yes we should probably do it at that time as well.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/p2pu/lernanta/pull/115/files#r800481
Il faut maintenant spécifier le type de message de retour qu'on attend
is this `maybeDeferred` here because of `handler` possibly being `self.unknown_request`?
Agree on the docstring change. I would also like to modify the function name itself. However this change will obviously break some client programs, so we should be a bit reluctant about doing that. I want to do at least another breaking change. Lets look at the total amount of breaking changes at the end and see whether it is enough to warrent a breaking update to praw or if we need to wait for more breaking changes.
the one-var-statement rule :)
I kept alphabetical order here since it's independant from the initialze method.
This immediately reminds of the best LT ever: http://delete-your-code.heroku.com/ esp. Slide 21 :)
I was going to give you a cookie...
Adding or removing the 'playing' class should be in `_setIsPlayingAttr`.
If you've moved the start/end lines, you should adjust the start/end ch too -- you want to include all of the new start/end line, not just part of it.  E.g., with this code:

```
    if (blah) {
        foo;
        bar;
        baz;
        
    }
```

Select from before the ```if``` to the end of the blank line (note: the blank line should be indented to the same level as the line above it -- markdown loses the spacing here).  Then invoke block comment: the ```baz;``` part will get left out of the comment even though it was entirely contained within the selection.
Comment needs to be tweaked for this script
Interesting. I swore it returned "en-US" always before. Looks good.
This one came back as "Go now!". Just double checking with you for context.
Oops, never mind... now that I've read below I see _loadedAgents is actually an array of indices into agents, not the agents themselves.  Could we clarify that either by renaming this array or at least by adding docs where it's declared?

Also, the hasOwnProperty() check can go away now that you're using forEach().
I think this case falls under the "If a JavaScript string literal contains code within it, use single quotes within the string to avoid escaping." case, so please backout this change.
Null check is unneeded: it'll just fail all the equality tests below and return from the bottom just like any other unrecognized mode.
Yeah, this only affects autosave settings, and it wouldn't hurt in case autosave wasn't even there. We want to disable autosave while we are resolving external change situations.
Here, your `onError()` function requires the callback for the second argument.
Should there be a constant for "workspaces"?
You have to use this function to wrap the registration form class. So where are we providing/giving the registration form class? Use this function together with that and add request to it. Simple.
Please don't do inline JavaScript.
This feels out of place to me, I'm not sure it shouldn't be in the restmail module
Should this not be `DEFAULT_ZOOM` instead of `_zoomFactor`? I would assume the same thing would get passed into all the `zoom` properties/functions of the subsidiary components.
I noticed that the message doesn't actually show up in Firefox. This is probably why: https://developer.mozilla.org/en/DOM/window.onbeforeunload#Example
This looks like it isn't being used for anything, can this be removed?
This should probably be `UAParser`.
same here, do we have access to the classList shim?
Fair enough; sounds good.
OK, will update
It seems like it'd make sense to make sure the system clock is set to [build_time, max_time) prior to firing things off.  Otherwise, won't a 1970 date ruin ssl cert verification? (if ca_racket != 0)
I'm having a hard time picking non-generic step definitions, maybe i should start specifying different app or database names for different scenarios when i can't reuse the steps.

I like to test it from the UI because it also verifyes the controller and the view in the same step, that's why i've renamed it to:
```
    Then there should be a new app on the page
    And the app on the page should have a database
```

`page.find('#database').text.should_not be_empty` i've moved it to `And the app on the page should have a database` step
If it were me I would have combined this with RegisterTemporaryFolderHandler and make the class factory a parameter. The rest of the code looks identical.
Since we're running out of time, let's just put a TODO here in that case describing the issue.
Any reason why you moved this into the singleton rather than in an the class instance? Keeping state in singletons can be scary
Sorry about those :(
These two lines should not be needed to render the pretty shadow on tupane's.
doesn't this apply on headpin mode?
can we have katellopw for password please? Just to be different from username and schema.
Yeh its just for the assoc array
@wkerzendorf  @taldcroft - if you actually look at the standard ways of doing coordinate transformations (e.g., SOFA), they all work by defining cartesian rotation matricies, transforming spherical coordinates to cartesian, applying the transformations, and then going back to spherical. In some cases, they assume unit vectors, but the point is that you need some distance in there anyway, so we might as well give the option. 

@taldcroft - I'm not sure I fully understand what you're saying.  You mean you want a way to move reference frames back in time (e.g. objects with proper motions or RVs), or are you talking about accounting for SR or GR effects? I definitely agree we should leave in necessary hooks to allow for this, but the point I'm making is that the first attempt at this will already be a lot of work without trying to include all of that as well.  Or am I missing some point you're making?
I agree, that would be nice.  Not sure if I'll get to it given I'm trying to finish today.
"…how many partitions each *node* wants…"?
:P a missed doc update during a rewrite. should be `acc`
Can't see much use in this change if that's the case then - why not introduce a menu option instead to resend? Is this fixing a problem that actually exists? If it does exist, is it fixing it in the right place?
Shouldn't this be `params.size() > 0`?
I don't think this code belongs in the main dialog. Can we move it to updatedialog.cpp and make the functionality self-contained?
This is way too simplistic. 0.4.7 is secure, but 0.5.0 isn't.
I'm lacking some background information here, sorry :). Is the format defined / described somewhere?
It's also possible to deprecate it for new code and phase it out slowly (as another Satoshi-ism). We don't like change-stuff-all-over-the-place commits.
At least on Windows, the first parameter of select is ignored ``nfds [in] Ignored. The nfds parameter is included only for compatibility with Berkeley sockets.``, which should be no cause for an error then.

So hSocketMax is 0, when hListenSocket is 0 or all pnode->hSocket are 0. This results in all fdset vars to contain .fd_count == 0, which results in the select() 10022 error code (``The time-out value is not valid, or all three descriptor parameters were null.``).

The longer I think about it, the more I feel like NOT calling select() when all fdset vars are empty, which of course is perhaps more expensive in that part of the code, then simply ignoring 10022 ;).
Heh sorry I meant the debug statement. I see you fixed it already :)
Looks like a few `_isRequired` got left behind.
Since both our core readers have `dump()` and `Configure::dump()` does no checks before trying to call a reader's `dump()` method whether the method actually exists, I thought it would be best to add this method to the interface. We can document this in the migration guide. People using custom readers would be a very small minority anyway.
Renamed both.
Remove. Again, add an internal message
I think for the semantics of a context manager to work properly, you need a try/finally block:

```
try:
    yield
finally:
    os.chdir(save)
```
This can be removed after newer changes then
@tanoku I notice that you cleaned up the special treatment of `GITERR_OS` that I had added earlier. It is definitely much cleaner the new way. The reason that I had done it in that strange way was that I wanted to capture the value of errno _before_ the call to `vsnprintf()` in case that overwrote the errno value.

I have left it the way you reordered it (with a couple slight changes to exclude errno 0 and to try `GetLastError()` on win32) but I'm still concerned about getting accurate errno values. I suppose I should just write some tests. :wink:
Just checking for clarification here. We are looking for instances where there is 1-to-1 matches in path directives, right? If so, we should check that rule.path is a string (not a function) before invoking replace()
If `simulator.permissions` always returned `SStorage.storage.permissions`, then it wouldn't be necessary to reassign `simulator.permissions` after modifying `permissions`, because they would both be references to the original object, which would have been modified in place. That's not just one less line of code, it's also a simpler model, since it makes `simulator.permissions` always be a reference.

So I would make the `simulator.permissions` getter always return `SStorage.storage.permissions` via something like the following:

```
get permissions() {
  return SStorage.storage.permissions ||
         (SStorage.storage.permissions = {});
},
```

And then I would remove the `simulator.permissions` setter, so it isn't possible to set it to a different object, just to retrieve and modify it (which is sufficient for our purposes).
This method name + parameter seems a little clumsy. I don't have a better suggestion off the top of my head though.
c этой шнягой пора бы разобраться. и с кодом атвоматического создания пользователей
хай буде ексепшн
Isn't there a problem with this commit ?

--> https://groups.google.com/group/symfony2/browse_thread/thread/8544abac6f540d98?hl=fr
Really nice! Haven't tested it yet but looks very good!
the curly brace should be on its own line for methods
What's the "$code, $previous" part about?
@Tobion : Check the comments to line 280. I think this cases are identical.
I updated it. Can you describe a situation in which it wouldn't work?
Ha, I'm even the one who removed it.
I moved to using `strndup` to fix the potential out of buffer write!  Also, although you are right about the writing the '\0''s, I think having a pointer to the beginning of the key and value is clearer that just working with the buffer.
``RuntimeError`` seems to generic. If necessary, create a new exception class in ``cms.exceptions``.
Two things:

 1) you'll want to bring the "f" in for under the "g" in groups

 2) you're still returning an object that isn't serializable.

If we didn't want to go any further into the object chains, then you'd want to return an attribute on that object, and not the object itself -- as long as the attribute you returned was serializable!

I'm fine with merging something like that for now, and we can later refine how much of the nest we want to return.
We are not using `expected_node`
I looked into the connection handover spec but unfortunately there are no examples :( 
Have you seen any connection handover NDEF records in the wild that we could use for the test cases?
I must admit I didn't read the whole comment :-) However, if two threads add a transformer at the same time there is a slight chance of them adding on different lists, one of which disappears.

if (transformers == null) {
     synchronized (this) {
        if (transformers == null){
           transformers = new CopyOnWriteArrayList();
           }
        }
     }
}
{code}
If you use a ServiceVerficationHandler you should be able to print out a message here that is the same as a normal deployment failed message, by getting the failure description
the problem is that when you supply -P release to maven it won't enable the activebydefault profile "all" (this is the name I have given it, not some default).

You have two choices:

mvn -P release,all

Or I am sure maven will have a way for release to activate another profile (maybe I was wrong: http://stackoverflow.com/questions/943411/can-i-make-one-maven-profile-activate-another) (lmgtfy link available on request)
Mhh, wanted to add a ticket but some wild python tracelog appeared ;-)
Perhaps output an error message if neither condition is true?
`slientOff`? If leaving the silent mode means more than the `normal` state...
> Some design and code flow conversation happened offline. @alivedise will fix those before merging. Thanks!

I was talking about the above comment. I did leave a comment mentioning offline conversation!
Start with a lower case, please.
ok, go ahead
All of these `else if` should be converted into a `switch ... case`
Use click event for `areaUnlock`
This is dependent on the way that gecko converts the style value into a string. The slice() arguments here assume quotes and no spaces. But the value in your HTML file doesn't have the quotes.

Did you originally have code here that used a regular expression to do this correctly? If so, then I apologize for asking you to take it out. Using a regexp would be the better solution here.  

something like this:

var backgroundImage = e.target.style.backgroundImage;
var src = backgroundImage.match(/url\(\s*['"]?([^\s'")]+)['"]?\s*\)/)[1];
Yeah, that doesn't make sense, good point!
I think here you can just check
imageFormatList.indexOf(fileNameExtension) != -1 instead of taking every element in imageFormatList to indexOf() imageFormat,
You will know which format (index) is matched then maybe use a switch cases to handle it, to map for correct MIME types.
I mean, it's cleaner than before! This code looks so nice (the old code regarding this part was a mess).
a little bird told me that we should indeed use `window.location.protocol` everywhere
receips -> receipts
Should we wait to have it landed as 'stable' one?
will this be printed frequently?
That's a different 'evt' coming from https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/trusted_dialog.js#L34
I need the original mozChromeEvent id.
This line just calls stat() a second time; it doesn't make any sense.

Do this:

var statreq = this._deviceStorage.stat();
statreq.onsuccess = function() {...};
statreq.onerror = function() {...};
Ok, here i see is an array, but do we need it, or is just for keeping the 'symmetry' with the other params?
Nothing bad here, just that I love how the code looks now, so elegant!
That won't work with the CSP, can you move that inside a js file.
We are not determine available slots here, what we need **is** all slots, because even if a slot is used, custom scheduler code might want to free the slot and use it for some other topology.
The npm issue is addressed. The output you saw was the error stream which was correct. This change makes the "Error occured" show up in the console.

It's a little hacky (hence the HACK:) since we write live output directly to the console and the GlobalLogger *is* also attached to console. So I need to Log an error here so that the code in kudu.exe knows that there was an overall error (Since this exception doesn't make it's way up to the exe),
Is this correct? Are you trimming the "kudu_"  prefix from the result?
I moved the check_connection out of the nested if. That meant that I 
also had to add a return statement to the else case.

I didn't change the logging since different messages are logged. Not 
sure what we'd gain by moving that out.

On 2012-10-24 18:20, Daniel Pittman wrote:
>
> In lib/project_razor/persist/controller.rb:
>
> > @@ -19,6 +19,10 @@ def initialize(config)
> >            logger.debug "Using Mongo plugin"
> >            @database = ProjectRazor::Persist::MongoPlugin.new
> >            check_connection
> > +        elsif (config.persist_mode == :postgres)
> > +          logger.debug "Using Postgres plugin"
> > +          @database = ProjectRazor::Persist::PostgresPlugin.new
> > +          check_connection
>
> Seems like the |check_connection| and the logging can fall outside 
> this block, since they are not dependent on anything but the 
> configured option.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930440>.
>
%%%%%%%%%%%%%%%%%%%%%%%%%%%%
这种东西不应该出现在作品中啊！太网络化了。
thanks -> that was the old test, will delete that!
Just copying the specs for POP3, I need to return `true` for this line https://github.com/fatfreecrm/mailman/blob/imap/spec/mailman/receiver/imap_spec.rb#L22

`@connection.disconnect unless @connection.disconnected?` will return `nil` if `@connection.disconnected?` is `true`, failing the spec
You don't fetch from ports.
typo here: ``s/y/i``
maybe you can get the process's working folder from the process object, that way this would work even if they aren't using app data folder.
Hmm, looks like I may have messed something up here. Will double check this...
Simply using Composer to download and install a required package from a VCS instead of from the PEAR repository in the example.
I think we can skip this one, it's not very useful, and depends on which driver is loaded anyway (the mysql lib or mysqlnd) so it makes it a bit irrelevant.
what is tk, and why is it outside of our main.js?
A number of the changes in this chunk seem to eb purely formatting? unrelated to the patch?
``` ruby 
def zeus?
 @options[:zeus] || false
end
```
seems simpler no?
why not replace it directly with `js-on`

```document.documentElement.className = document.documentElement.className.replace(/\bjs-off\b/g, ' js-on ');```
ACK.  I will test this out tonight & commit if it works like we think it will.
is there a typo here? "w" is defined twice.
If this getting into master, this will come back to bite us.  For now, we can just filter this in.  An even better way to deal with this would be reading the meta information added to our project by maven.
> Why not using [f, this].concat(Array.slice(arguments)) instead?
> or var args = Array.slice(arguments); [f, this].concat(args)
> It highlights the issue of arguments, and we are used to Array.slice in our codebase.

This pull request was importing library that is not written for moz-js in standard js you don't have Array.slice. Also slice is suboptimal for such hotspot codepaths. I have being doing diff profiling to identify fastest option.
I don't want to overcomplicate examples in docs, but I could provide links to more convincing use cases like:
https://github.com/Gozala/streamer/wiki/stream
https://github.com/Gozala/meta-promise

If that would help.
That's the intent.  This happens via the internal api when getting a silent assertion only.  The only way into that code should be through paths that don't involve the user.
Good call @seanmonstar on the future expiration.  an expires of -1 turns the cookie into a session cookie.  To delete the cookie, I set the cookie to expire in the past.
I would remove ```is_page_title_correct``` as well because the page title will include the tag name and therefore will never be a straight expected == actual scenario.
Why `setMappingSchema` instead of `setSchema`?
Do `map` and `collect` do the same thing? If so, should we be consistent at least within this file?
We should have an index on ident.
Have no idea. In master branch the commented line is missing completely.
Perhaps we could add some tests that test invalid globs? See if they're handled correctly nonetheless, and that those while(true) loops dont result in some segfault ;)
Not tested but this one should be much more performance:

if (is_subclass_of($object, $type)) {
    return true;
}

if (version_compare(\PHP_VERSION, '5.3.7', '<')) {
    return false;
}

// Workaround for PHP < 5.3.7
$class = $object;
if (is_object($object)) {
    $class = get_class($object);
}

if (!class_exists($class, true)) {
    return false;
}

$classNormalized = ltrim(strtolower($class), '\\');
$typeNormalized   = ltrim(strtolower($type), '\\');

static $cache = array();
if (!isset($cache[$classNormalized])) {
    $parents = class_parents($class) + class_implements($class);
    $parents = array_map('strtolower', $parents);
    $cache[$classNormalized] = $parents;
}

return in_array($typeNormalized, $cache[$classNormalized]);
`Symfony2` ;-)
ah no, the logic was written directly in the command...
Spacing, linebreak.

This is one of many.
Might be useful to pass the `{asList: true}` option so you get a ModelList instance back from this.
if FEED is disabled, then FED_RSS should be as well, isn't?
You have a very valid point. It looks more and more like eZ Publish 5.x will not use eZ Components and so there seems to be no reason to even bother with the core goal of this pull request as it is not a real eZ Publish requirement per say ... We saw a recommendation in debug that the extension should upgrade to the latest API supported today in CB2012.03 aka eZTemplate::factory() and so we created a helpful pull request to address that concern and try to help improve the documentation at the same time.
Why remove this? I think it makes sense here.
can you remove the empty line?
@andrerom The idea of `PurgeClientInterface` is to provide an agnostic interface. That's why this method is not type hinted.
js convention is to set a variable for the length as well so it's not calculated on each iteration, like:

`for (var i = 0, j = self.options.ignoreUrls.length; i < j; i++) {`
Is this the correct name for the function? Why no setup? or set_up? Function names should not be CamelCase iirc. (check with Jens)
self.log.error exits
you should avoid doing the call twice for the same value
Java EE, not JEE :-)
Easy to add with ANTLR!
"お気に入りのエフェクト"...
Huh, didn't know you could specify error messages on a model. Will change.
I don't think this line belongs here, since it also appears below on line 26. If it does belong here, it's missing the opening <=% and closing %>
Thanks for the explanations Sam, it makes sense in this case to have `Utils` and `Stdlib`. However, perhaps it's a good occastion to rationalize a bit the organization of `tools/`, there are a lot of stuff there that we coded once and never re-organized. Think of `Rutils` for instance, neither David nor me could remember exactly why its code is there..
findを2回以上するならフィルターにしてほしいなぁ
^ skipping since it's in management
Not sure if we actually want to do this. What about names like McDermott?
better to assign "1" to constant variable.
I saw that. Geek cred to you! 
But isn't the pull request simpler then? Seems like it to me.
If you write in your commit message somewhere "close #xx" github will automagically close the issue for you. Very handy.
If you created a `Quantity` from a value that contains a unit (like an `Angle` or another `Quantity` you wouldn't need to specify `unit`.
this should be EnabledState.DISABLED, just as it was before
Yes, I think it would be a nice opportunity to fix these tests.  (Someday we should go back and fix the originals, too.  But not today ...)
@staabm : I'm cool with getValue. It should just always return the string version. setValue I also don't mind, if we can determine sensible ways to handle different types of values.

I do think I would prefer `getFields` and `setFields` or `getParts` and `setParts` instead of `setArray` though. It describes 'what we're setting' rather than 'what type we're using to set it'.
детский сад.
Perhaps checking for text in the element is not the most robust solution. Is there a locator that we can use instead to check the displayed state?
This looks a little fragile. Could we simplify it to `(By.CSS_SELECTOR, '.addon-listing .item')`?
Yeah, I hadn't actually read the Pivotal Task when I added my comment. I would question the validity of the task, and I'm not sure adding this complexity is worth the slight reduction in code duplication. Page objects should not include logic if at all possible.
Is there a bug or a pivotal story that we can link to in this comment block?
no Returns message?
good catch, done.
Since this is the IsTimeIncluded method, I would think that the method should return true if the cron expresion matches, not the opposite, which is what happens now.
As long as it gets added to the change log for 2.0.4 I don't mind this bugfix
plus `.content_for?` could be expanded to mean more things in your context [though overriding] so it opens the door to more flexibility for the developer which is sometimes a good thing ;-)
It feels like addGroupMember and removeGroupMember have significant overlap with applyGroupMembershipChanges and maybe applyGroupMembershipChanges could be used as the only function.
Fixed here and in one other place in the test.
What's the return value supposed to be? I see there are two erroneous values, `None` and `Some(Version(0, 0, 0))` It would be good to document that in the scaladoc.
See comment about channel_icon()
If hasKeys access data files, it will introduce the same amount of load to
servers as getAll. Won't it defeat the purpose of this function? - Which is why there is a "exact" flag. I anyways introduced a new function that reads only the key now in the data file. Though performance-wise I don't think that'll be a big deal unless the value size is really huge.
Ok, this was just to test multiple modules, will change it.
I THINK @derekjones said we're getting rid of the 4 line property comments. Will a one-liner still work for phpDoc?
В данном случае создается пустой массив, а countDNA используется при его заполнении. Естественно, можно было (и нужно) создать сразу массив с заданным количеством элементов, проинициализировав предварительно countDNA. Невнимательность.
Я имею в виду, что можно сделать проверку в самом начале на xPercents: если значение неверное, то дальнейший код выполнять бессмысленно. И сравнивать с DNA_LENGTH тогда будет не нужно.
В дискусиях - обсуждение проекта 1. Исходя из задания - тоже где-то там написано, про 100% сказано в контексте того, что мы не можем заменить один элемент дважды. При вычислении возникает много споров - в какую сторону и каким образом правильно округлять. Как Вы видите я считаю, что округлять надо в меньшую сторону, а не по законам математики, потому что если из процентов выходит какого-то объекта 0,7 - то это никак не целый объект (конечно это только в случае изменения размера массива - что по заданию тоже не требуется). 
И все таки все это очень спорно, для чего я и внесла выше написанный комментарий.
nah it's fine, just for internal usage