labofsahil/github-event-dataset-2012 huggingface dataset:
About 10% faster with both `dmd -release -O` and `dmd -release -O -inline`.

If we really want some extra speed in regards to back iteration, then we should consider having a decodeBack:

When you write string.back, the current implemention is:

```D
    size_t i = a.length - std.utf.strideBack(a, a.length);
    return decode(a, i);
```
Which is definitely not an optimal approach. I'll look into doing that, but after everything else I've done is all well and good.
Let's just accept that and leave it to client code to do the appropriate rounding etc.
Couchapp needs to have a Map returned with "rev":"revID" for each document that was pushed; otherwise, it will throw the following error:

````
2012-03-12 22:03:29 [CRITICAL] 'rev'
...
 File "/Library/Python/2.7/site-packages/couchapp/client.py", line 396, in save_docs
    '_rev': r['rev']})
KeyError: 'rev'
````

 In lines 704-710 of do_POST_Document_bulk_docs the response for each document is constructed:

````java
Map<String, Object> result = new HashMap<String, Object>();
            result.put("ok", true);
            result.put("id", docID);
            if (rev != null) {
                result.put("rev", rev.getRevId());
            }
            results.add(result);
````
These comments appear to be about nothing :-)
This is really simplistic: it's just statically cached, so no thread fanciness at all.  Happy to document that fact.  No clean-up needed.
I'm not sure what you mean. The only responsibility of the proxy is to transform arguments
this would make things entirely more readable
messed up license
Needs to be commented. It's very specific to annotations as comments, since it's here only to allow deletion of annotations as comments (as XWiki.XWikiComments objects).
Looks like $logger is never used here.
`github issue tracker` or `issue tracker on github` would be nicer.
Removed these methods in the commit 7f241b467e15c1ffc4b071493e16b538e274610a (above), but refactored the render_copyright to use the newer syntax anyways.
I'm sorry for being picky, but, can you call this class `CIRunner`?
yes true, but then the actual html elements were not being checked or unchecked<in short>
Where do you initialize flow_flag?
this should be `args[1]`; the `product_version` variable will not exist when this code is hit
Consistency and readability.
We should be careful with return statements inside of $.each methods:
http://pure-essence.net/2011/09/02/jquery-each-vs-javascript-for-loop/
http://stackoverflow.com/questions/1244605/returning-false-in-javascript-jquery-within-an-if-statement
You should probably add this warning back in and print the parameter that is given.
I don't trust that. The code also needs to run on AMD and Via processors (and in fact, that code needs to work on some old 32 bit CPUs with really funky cpuid behaviour). It's a simple matter of wrapping it in:
if (max_cpuid >=7)  {...}, and then it's guaranteed to work on all systems.
Yes, they do work. For instance, `DateTimeException` is an alias for `TimeException`, and it shows up in the docs. I just didn't put ddoc on the alias, because `clear` wasn't actually documented in the first place.
That, I agree with, but that means that he needs to change it again, because he misunderstood you and made the cases line up with the switch.
You can move the `resolve(m_trace)` call to the foreach loop if the `traceResult` variable is never used. Also try to avoid using `auto` in library functions unless it's a complex template type which isn't easily representable in code.
BTW, empty @ param is ok, it's empty @ return that emits a warning.

You can see these warnings by running './gradlew api'

There __is__ one warning in JPA...

````

...spring-integration/spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java:242: warning - 
Tag @link: can't find parameterSourceFactorymeterSourceFactory in org.springframework.integration.jpa.core.JpaExecutor

````
wrong indentantion between if and else
My email is just chris@ puppetlabs if you don't have it already.
Still on the fence about this. I have this task `ensure_packages` in the rakefile, so this line isn't needed then.
My gut feeling is that it should be here. Thoughts?
Oh, my bad, I'm sorry!
This line is a bit long. I think it fails the Symfony2-coding-standard-coding-standard :smile:
@christianv The idea behind the confirm boxes was to give a confirmation that was quick, simple, and concise; knowing that this is not a public-facing feature but something seen only by administrators.
I think this should be the two letter country code.
此id为何是字符型？
extra blank line here, fyi
Could we break that list out into a local variable in case we need to change it later, or maybe do something like `for project in $(cat projects-list); do` instead?
do we need all this print stuff?
@ArtSabintsev , @wedkarz - I just submitted a pull request that doesn't have the flashing problem on load for iOS 6 - Could you see if it has a better result for you?
The `force_insert` / `force_update` stuff seems good but it'd probably make sense to make it as a seperate pull req, rather than a single pull req for various different bits of functionality.
I'll change this next time I commit the tutorial, which will be soon.
Good points, resolved in 1bd5c99dd8e901e0941ba5d81d582d71b2a70287 and ef6157494223b87263df022e08debe5a6b78c3fc
Is there a need/reason for usage of `*[ ... ]` here?  Could it just be:

    OEmbed::Providers.register(
      OEmbed::Providers::Youtube,
      OEmbed::Providers::Vimeo,
      OEmbed::Providers::Flickr,
      OEmbed::Providers::SoundCloud
    )

Or, if you're anticipating DRYing things up later, then a constant:

    PROVIDERS = [
      OEmbed::Providers::Youtube,
      OEmbed::Providers::Vimeo,
      OEmbed::Providers::Flickr,
      OEmbed::Providers::SoundCloud,
    ]
    
    OEmbed::Providers.register *PROVIDERS
defaults to PROVIDER_NETWORK but I guess might be safer to not call this out.  perhaps also note that only provider is active at a time in this mode?
Don't rely on instanceOf 'ArchiveView'. EnterpriseArchive/WebArchive/JavaArchive's are just view interfaces and are not necessarily what the Container understands. use e.g. archive.getName().endsWith(".jar")
`public synchronized`. (But I can be persuaded.)
… you don't `advance()` if we don't upload a client record…!
I'm still a little confused here.
Do I call registerForXLink for an existing connector, or does this method also create the connector?
Correct SmartStore.java only understand "smart" queries.
Interface definition should avoid such hack ;)

just use the ExportFields method from the ModeManager...
ummm, confused now, so does the spec call orientation writable or not?
Would be interesting to see what the os does in these situations. I know, tracy and I were seeing it default to the language locale (fr) when the region wasn't available.

From: Eric Pearson [mailto:notifications@github.com]
Sent: Tuesday, November 20, 2012 07:27 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Localized blackberry.app.name and blackberry.app.description (#277)


In ext/app/client.js:

>      value = readOnlyValues ? readOnlyValues[field] : null;
>      Object.defineProperty(_self, field, {"value": value, "writable": false});
>  }
>
> +function getLocalizedText(data) {
> +    var locale = navigator.language.toLowerCase();
> +
> +    if (data[locale]) {
> +        return data[locale];
> +    } else if (data[locale.split("-")[0]]) {
> +        //Region specific locale [i.e. fr-CA]
> +        return data[locale.split("-")[0]];


Are you sure this is ok? If this is portuguese and you return pt for pt-BR a lot of people are going to be confused as the language is pretty different. Same goes for mandarin and cantonese with zh-CN and zh-HK.

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/277/files#r2189066>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Should probably also state the jQuery dependency here:

<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js"></script>
Has to be on same line as the one above
No, you've a lot of with i18n_catalog option for translation of field labels.