labofsahil/github-event-dataset-2012 huggingface dataset:
hmm, maybe you're right. It seems more suitable. I should change many of them then.

By the way, should I change that in my forked repo, and then make a pull request again or you'll change that afterwards? (it's my first pull request)
There are at least three reasons, each one gives a benefit.

1) It is better to put django queries in a Manager. It is a pattern widely used in django applications
2) I don't want to have all the curves in memory (django also cache the queryset by default)
3) I don't want to make the queries only on the master node, but I prefer pass a Querier object (in this case a closure) to each worker.
I think it can be done in a single query with no extra():

```python
result = Input.objects.filter(input2calc__hazard_calculation=calc_id)
if input_type is not None:
    result = result.filter(input_type=input_type)
return result
```
const correctness is a nice thing to have.
That will give `"null"` and `"undefined"` for `null` and `undefined` won't it?
No, actually I don't have any idea of the expected number of groups.  If it's only two-digits at most, it may be ok.   It is always true my assumption doesn't work when some crazy man shows up, which bothers me.  Especially performance issues.
https://github.com/madlib/madlib/blob/master/src/ports/postgres/dbconnector/FunctionHandle_impl.hpp#L78
Makes sure all slashes are forward slashes (work everywhere), because back slashes don't work in bash on Windows.
Sorry please ignore this file (downloadmgrImpl)
This needs to be set after Hitpoints_Max has been, right now chars are always starting with like 30hp.
We might want to consider a switch to m3u8 files for UTF-8.
Strictly speaking, instead of concatenating these, it's better to use the `.text()` method. That will safely insert the innerText of the element, escaping any HTML. (I know that's impossible based on how these are defined above, but that may not always be true.)
Ah, ok. Sounds good.
I'll do it in cleanup branch.
`http://tesseract-ocr.googlecode.com/files/tesseract-ocr-#{tess_version}#{tess_src_minor_version}.tar.gz`

I just copied and pasted it, but I'm pretty sure it won't take me somewhere.
Peut être un peu beaucoup ... A voir dès qu'on aura vraiment du monde :-)
^its
Are you moving this documentation elsewhere?
this check never works for windows systems. the reality is that this method is called recursively until node runs out of stack memory when running ``raind`` in a folder that is not a RAIN project (or inside a RAIN project) on windows.

moreover, the modules using the ``getProjectRoot()`` function only work because they have a ``try - catch`` clause which catch the stack exception.
Defining a one-off variable is less clear (at least to this Python reader), because I then have to scan up, see where it is defined, and scan the logic to see if it ever gets modified.  Just use ``load_dict['id'] = max_id + 1 + load_count``.  That saves a line and is immediately clear about what is happening.  I didn't even know that ``enumerate`` can take an argument!   so don't do that in most cases :-)
Ohhh.  I handled this in ModuleAdapter, but not in the at-inject stuff.  Check.
should be 'final': true
Should be able to do `this.set('media', media);` -- `dojo.hitch` is only for cases where the current `this` isn't the `this` you want.
Yeah. This is a bridge we'll have to cross, but probably not right now.
Watch whitespace.
I think it has to be``:input`` selector to include ``textarea`` that does not have ``type`` attribute.
I did not have time to port searching for mongoid
ah, cycle isn't right for that.
I think we can make this message better.
Thanks for the tip - I have made this change also.
Again no need for the quotes or #
This is a bit of a contrived example. It would be nice to find something more "useful".
Clean the error message at the bottom 10s after it appear.
OK. It is not in the form. Just in the model.
Please also commit .mo files. So that clone is readily useable.
change here, need a different default
don't really need this newline do we?
make it a one-liner: `return allTrackEvents.filter( _filterTrackEvents );`
While you are at it, extra newline removal?
I'm assuming `data-butter-preview` will get filled in. Otherwise, it shows a blank preview for this thumbnail (when you click on "Preview").
default is a javascript keyword, which is why it prefers it in array-like access in this case
Technically don't need to delete the ID do we?
Maybe I wasn't clear with what I said, but the following lines can be shortened to:

    if ( _uiConfig.value( "ui" ).enabled ) {
      if ( _uiConfig.value( "onLeaveDialog" ) ) {

We should also store a reference to `_uiConfig.value( "ui" )`
What was the thought process behind making this a separate variable?
same counter thing as above
The save file without UTF8 header (most of text editors have this option)
Comment here is a dupe of the above one. I think you meant "hard-delete (without callbacks)"
For some reason i always thought that a variable first used in a if/else/end statement would be only local to the if/else/end statement, that's why i used an instance variable. I've fixed it in the code.
It's probably worth writing a test to make sure this works. It'd create a few videos, then do an opensearch_suggestions request and make sure the json output looks sane. This will help us later on if we decide to fiddle with the SQS.
Fixed on 828c99f =).
You MAY want to clean this up...
What about throwing an error message with 'Please ensure you don't have |ac_add_options --disable-tests| in your mozconfig.'
I thought the opposite?
starkos is always talking about finishing 4.4, and then eventually getting on with 5.0-dev.
Why wouldn't we remove all the legacy non-ng stuff right now if this is actually a 5.0 dev branch? That could half the size of a lot of these files, which remain clogged with the old non-ng actions.
I haven't closely examined the `TimeFormat` classes yet so this question may be premature. But is there no way around creating an extra array of zeros?  If val2 is left as `None` can't any computations that use it just be skipped if it's `None`?
Seems timer resolution on Windows is always in the ms range, I tried that function.
`init` receives the plugin's target, not a config.
clarification: a template for displaying the vote icon
Sure.  Which one makes more sense?  (this is part of the code I have never spent much time in).
Fixed. The code has been (a little bit) reformatted in order to shorten the lines.
Sorry, this makes the diff a little bit messy.
Try `property alias model: repeater.model`, after giving the `Repeater` an id of `repeater` (or `property alias sprites: repeater.model` if you want to keep calling it "sprites").
Shouldn't this be marked for l10n?
I've got one in my branch, too. It looks similar, but I think I have an additional default.
Just place it below 'if mozinfo.isMac' or use a try/except around. I would prefer the first option.
Again `assertEqual` would assert and equally good job :)
is there ever a risk this might cause a KeyError? I noticed you were so careful on the lines above with the `jsonDocument` using the get() method.
??? :)
For some reason this is all shown as changed, I think it's down to different whitespace. Please make sure you're using tabs everywhere.
Would *an error occurred in the underlying stream error* be ok ?
HashMap --> LinkedHashMap
Missing JSDoc comments
IMO an other unfortunate name what not `normalizeKeys($enabled = true)` ?
Indeed, better would be "Creditcard type niet-ondersteund of ongeldig nummer. "
It seems, `$failureHandler` should be as optional parameter.
Can you add a comment about when this occurs? (a reference to phar files should be enough)
これもこの describe 節で共通のテスト対象ですよね。まあこちらはそこまで個人的には強く言わないかも （RSpec の制約で共通化できないことがあるので）
Yep - Joe linked to the Data Clump article, which is a good explanation. A more common interpretation would be using some sort of money class that encapsulates both value and currency. A tiny object that exposes those three pieces of data would be perfect, and as the article suggests, it's a good place to put additional logic as it comes up.

Interested in seeing how this evolves!
I think attributes makes sense, just with the defaults that you've already used here
This doesn't really make a lot of sense. Why have have a method called "set_shared" that sets statuses that has a docstring about parallelization. I don't understand what this is used for. A check shouldn't know or care about whether it is being run in parallel or not.
Oh, I may have mis-spoken in an earlier email.  We tend to use threads==0 as shorthand for (use the hardware concurrency).  Use threads==1 to mean "I really want exactly one thread."
'By default, the ...' sentence is missing an 'is'. Might be worth splitting as well.
My latest commit adds the "crs" and "feature" modules to the "cartopy" namespace.
`rails_best_practices` is awesome, just like Richard Huang
commites ptet pas ce fichier.
As it stands 5 sec is the value we use within Remoting JMX  without any complaints, by this point the TCP/IP connection is established and authenticated if it takes longer than 5 seconds to open a channel I think they have bigger issues!

Also until we get a Remoting upgrade Remoting does not tell you the channel does not exist.
should this be get_event_rating?
Please see 57ecee889d1443b37f0cc2e870a5209292e0472b
You probably want to ensure here that the times are different by a larger margin, to prevent timing bugs. Just substracting a few seconds from the start should be fine to prevent any potential problems
@davidflanagan I found that in 
https://github.com/davidflanagan/gaia/blob/03772d0abcc0e6dbca166274c2da8cda71c9c8b7/apps/music/js/metadata.js#L253
id3.advance(id3.readUint32()) should be id3.advance(id3.getUint32()) ?

The log says: TypeError: id3.readUint32 is not a function.
Wikipedia says: ISO-8859-1 was incorporated as the first 256 code points of ISO/IEC 10646 and Unicode.

So this wouldn't be safe if I was converting Latin-1 to utf8, but since I'm converting to utf16 JS strings, this is okay, I think.
Same as above we do generate things dynamically.
if (!settings)
the class for this button should be: fillflow-row action action-add
I think es-ES is not part of the default set of locales in Gaia anymore. It should leave on the l10n repository, so you can remove it from this PR.
is there some screen estate limitation for this one?
nit: leave an empty line
Hi Vivien,

  I've just implemented your improvements in the last commit and added you as collaborator in my branch so you can continue your improvements if you want in this branch and so avoiding rebased problems

Thanks guys
A difference from my condition.
I used buffered.end() to get the duration.
Also add this to comment. Thanks! @vingtetun
why we need here the assignment to the dataset ?
gecko does handle files with spaces in the name :)
transition no longer needs to be prefixed: https://developer.mozilla.org/en-US/docs/CSS/transition
This isn't really the tabs badge, it's a close button for the awesomescreen and should be styled differently. The current implementation is confusing to use. We can wait on visual design for this though.
Bench is maybe a confusing section name here, I think.
true, plus the first condition also makes that condition unnecessary, I will remove it.
We do need the name is some places, like in predicates, so we don't end up with having to store the method name in a property
why did you change these lines?
We need to not bind this here. We will need to support XML responses also possible for some slices. And the razor bin should be agnostic to module logic. Another option is to test for either and just leave a TODO for XML.
Why is this test uncommented? Do we still need it? Otherwise you could just delete it ...
Probably better to jump to beginning-of-line here, in case point is inside the include-string.
Added the TODO below (just above the Monoid trait).
Can we just implement the exact same hash method, that way we can be pretty sure we didn't break anything.

Also, I don't see the need for the seed, and then transforming it by going through Random. That is not adding any entropy, so I'd rather just be clear and fix some long.  I don't think the seed is going to impact the algorithm at here. It might come into play when we want a family of hash functions (as Edwin's code for count-min-sketch, I think, does).
Not really now.  Will add test functions as we discussed.
On Dec 4, 2012, at 5:37 PM, Stefan Radomski <sradomski@mintwerk.de> wrote:

> On Dec 4, 2012, at 5:31 PM, Martin Hurton <notifications@github.com> wrote:
>> In src/socket_base.cpp:
>> 
>> > @@ -1012,6 +1011,15 @@ void zmq::socket_base_t::terminated (pipe_t *pipe_)
>> >      //  Notify the specific socket type about the pipe termination.
>> >      xterminated (pipe_);
>> >  
>> > +    // Remove pipe from inproc pipes
>> > +    for (inprocs_t::iterator it = inprocs.begin(); it != inprocs.end(); ++it) {
>> > +        if (it->second == pipe_) {
>> > +            inprocs.erase(it++);
>> > +        } else {
>> > +            it++;
>> Just drop the ++it from the for statement.
>> Or split it into two parts. Find the element you want to remove. If found, remove it. This can be done as at most one such element can be in the map.
>> 
> I went for the while loop - if you insist on the for loop, I will change it accordingly. Thank you for spotting this, I always iterate my STL containers via while, especially when erasing items so it's rather hard-coded in my brain.

Then again, you are right of course: there can only be a single such pipe and I can break the loop early, hang on, I will rewrite once more
Missing space before the ``$bom_collection_ids``
``instanceof MetadataSupporter`` as you have a use statement
I had an error message which said that these functions need to be called static, so the issue is maybe somewhere
&view=profile has been deprecated...
please don't ignore Gemfile.lock ;-)
Particularly since there is `full`, `_full`, and `_doFull` for example.
I tried to ``del``ete source after converting it to [source]. But ``del self.source`` resulted in an error during the tests. hasattr returned true on 'source' but still we were not able to delete it.
Probably change this error message to `the itemView property must be defined (or the getView must be overridden)` or something similar.
Does not harm if it fails. Works for me with `Git Bash` on windows. I guess this depends which console you use (?).
we should use a helper method here rather than assigning variables in views
ok, I'm going to change that too, thx :D
So why do you depends on speex?
@indexzero need your approval here. I changed it and tests still passed, but I'm sure you had changed this for a reason?
Will Akka timeout the future sooner anyway? Or is the async call not done with Akka?
If this is optional, use the `Optional()` validator or `URLField`'s built-in validator will complain about blank strings being invalid URLs.
Yes, I had thought about something like an ```--output-basename``` option, too. However, it feels to me that this would be a rather clumsy way of make a very simple operation (namely, converting a single notebook to a file with given output name) just about possible. What's more important, it exposes the way we as programmers think about implementation details in the UI, which I don't believe is a good idea.

Ideally, the UI should be simple and intuitive and the implementation should just do The Right Thing (TM), i.e. it should do what the user expects in cases that are unambiguous, and print a helpful warning in cases that cannot be resolved automatically (but ideally these should be as few as possible).

I'm 99% sure we can achieve this by designing the UI in the right way, and again I'm happy to give it a try and ask for feedback on a sample implementation (although it may take me a few days until I get around to it).
unfortunately this is not the same, because `addWeakPrivacyTransitionObserver` is not in FF14, I guess it was added in 15 or 16, because it is in FF 16
It looks like you don't really need this  function. In fact I would prefer following instead:

```js
const globalHash = new function GlobalHash() {
   // your init function body here
}
```
Nit: I think of Bugzilla like a friend I've known since college, so it should be a proper noun and be capitalized.
instead of activityCount, can't you just check the length of activities?
Removed. In php, `var_export` function does the same thing.
I recommend marking this method as a public or private in order to clearly express our intent.  Given the lack of a clearly defined API, _everything_ ends up being a valid integration point, which is a colossal PITA to maintain.

When in doubt, I recommend marking it private.  Less pain that way.
@daniel-pittman yeah, it was definitely broken before. It would be great if you could fix that, because now it's just calling `Pathname('c').realpath rescue 'c'` everytime. I'm not sure offhand if ruby on windows raises each time or not.
Looks like William wrote it (at least, the file's attributed to him and there's no note otherwise in the docstring for that specific function.

Also, I wonder if it would be better to try and use the metadata attribute that you've been working with (https://github.com/ihanson/sagecell/pull/4) to let the frontend know "this is raw html code", as opposed to what's happening here.
Sounds good… sorry, just seeing this now.

-Meg


On Apr 17, 2012, at 9:19 PM, Sascha Depold wrote:

>> @@ -11,13 +12,33 @@ module.exports = (function() {
>>     this.queue = []
>>     this.activeQueue = []
>>     this.maxConcurrentQueries = (this.config.maxConcurrentQueries || 50)
>> +    this.poolCfg = this.config.pool
>> +    if (this.poolCfg) {
>> +      //the user has requested pooling, so create our connection pool
>> +      if (!this.poolCfg.maxConnections) {
>> +        this.poolCfg.maxConnections = 10
>> +      }
>> +      var self = this
>> +      this.pool = Pooling.Pool({
>> +        name: 'sequelize-mysql',
>> +        create: function (done) {
>> +            connect(self, done)
>> +        },
>> +        destroy: function(client) {
>> +            disconnect(null, client)
> 
> same for here. `disconnect.call(null, client)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sdepold/sequelize/pull/146/files#r699256
Instead of using the `hsla()` function, you could write `fade(@color, @alpha)`.
using a Map has a side-effect that this will occupy much more memory. Making this note in the comments would be great.
better doc please
I don't think this change is necessary -- again, soft limit of 80 chars, hard limit of 120. This was still readable.
Quantify that statement, @denixport -- is using the regex truly sufficient, and will creating another object really be more expensive? I'd prefer we don't add code that could produce bugs later on, if possible...
DO we really need ext/hash if we only use http://php.net/manual/function.md5.php
Accord your changes this should be `Decorator`
Good catch ! I don't really understand this attribute, as it is equivalent to no step... But well, it's added :p.
Same comment as last -- rename to `assertNotHasResponseHeader`
This was from original Escape so I haven't touched it, but most people would not expect recursion by default I would think. Note to self, RECURSE_NONE is missing unit test coverage...
You can trim/format/whatever things here instead of when you read them out of the list in decensoror.decensor() (see my comment on line 17). This way you only trim/format/whatever them once, instead of everytime you see a new word to decensor.
basically "nothing is enforced" - I'll reword this so it makes more sense
I was just following the Riak way, but yeah I'm not the biggest fan of it either.   I can remove it.
This started syncing my `~/Downloads` to `~/Reference` when running specs
yeah, that would work too. There are two patterns that let you give a more precise field type:
- abstract Dynamic getter/setter on base class, concrete field on derived classes
- Dynamic getter/setter on base class, override with typed accessors that call "super"

Unfortunately #2 breaks "this." initializers (you have to call super), and it's probably less efficient, so I went with #1
It looks like I had stupid leftovers?
Ok. I'll remove that.
The `shutil.*` calls above (lines 88-89) will also fail. I was mainly trying to fix #530 without mixing in any other fixes. The shutil failures probably deserve a separate issue and patch?
I am sure I am missing something here, but should you not join _all_ the arguments? Instead of using + ?
OK, did not know.
Sadly so! eg, http://developer.yahoo.com/oauth/guide/oauth-requesttoken.html
should be </code>
If there's no class here this attribute isn't needed.
+1 to clean up patterns :)
This never seems to be used? Did you mean to assert that this was true somewhere in test_search, or elsewhere?
Where do you test if the user is already logged in?
What happens with this test if this scenario occurs?
I don't follow this comment. What is lost where?

If we have to do this lets show this into a IE specific module so others don't have to pay for IE's sins, particularly mobile.
che, acá quedó un binding.pry :D
get -> new
really - will this break brew updates?
nit: maybe rename to `shouldSkipProblem` because we don't skip when consecutiveSkips is too many even if it is a dupe.
btw, this can be `_.invoke(axes, "toFront")` according to [underscore.js docs](http://underscorejs.org/#invoke).
example.pem or test.pem mayhaps?
May be you want to explicitly mention exception ?
Perhaps the safe and simple condition is:

```
!conf.styles || !conf.styles.length
```
Looks to me you actually have a very specific reply string in mind. Maybe the right thing to do was to parse the reply using an XML parser and then do an assertEquals check on the resulting XML document. That way you get a semantic check for correctness.

I don't expect you to change this just now, but just something to remember for the future.
слишком много операторов нужно будет определить.
It doesn't answer my question why we need urllib in our file regarding the unquote() call.
The comment and the code here disagree. Comment says `global`, but `var client` says local.
Hm, why I try that, I get an illegal invocation error. For example, in console,

```
print_func = console.log;
print_func("test")
> TypeError: Illegal invocation
```

```print_func(console, "test")``` sort of works, but that won't work in the context.
Log value of `rel`
It provides an alternate starting point for the sequence, so that the titles will always be alphabetical. I thought this would help debugging since the page's slug could have a number appended to the end. With "a" as the starting point, the titles will go "Test title a", ... "Test title z", Test title aa", etc.
Agreed. Can we make this into a separate issue? I will fix it straight away but would prefer to get this PR into master, I've been having merge conflicts all day.
Here you're blanking out the schema in a different process tick than it will be reloaded in. So when the cache is refreshed, you'll have a period of time where accesses to it result in a blank schema. You should probably prepare the full new schema, then do an atomic swap:

`cachedSchema = newSchema`

To avoid a period of no schema config.
Please use `forEach` instead of `for (...)` unless you specifically need the `for (...)`.

Don't worry about changing this, my application lifecycle touches this code and I'll incorporate it in there.
It's a bit of a micro optimization but maybe we can split this one out in a 'public' and 'private' method?
ie:
`getRolesForPrincipalsAndResourceType` performs all the parameter validation and then calls `_ getRolesForPrincipalsAndResourceType` to do the actual work. That way, `_multiGetAuthzGroupMembershipAncestry` can call the private one directly and all validation can be skipped.
If we do `ConfigAPI.initializeConfig(callback);` it will pass in the parameters `getConfig` gives back and trigger an `Error initializing server` error.
Perhaps we should make the parameter order of the model similar to the createContent method?
Never mind, I see now that it's to make a distinction between the user his visibility and the various profile sections.
I'll incorporate this in https://github.com/sakaiproject/Hilary/issues/174
It probably makes sense to add a validator for contentId and commentId here. I know the called functions do this as well, but it makes it more explicit as to what this function expects.
Nice, much clearer now!
Wouldn't it make more sense to give the list of binary packages instead of this command line? After all, `apt-get` is not the only way in install packages on Debian(-based) distributions. Also the command line points to python2 packages only, some users might want to install python3 ones. Then, linking elements of the list to Debian / Ubuntu (and other distros) package page could be useful, e.g. to see which versions are available. E.g.:
- python-scipy: [Debian](http://packages.debian.org/source/python-scipy) [Ubuntu](https://launchpad.net/ubuntu/+source/python-scipy)
- python-numpy: [Debian](http://packages.debian.org/source/python-numpy) [Ubuntu](https://launchpad.net/ubuntu/+source/python-numpy)
- python-matplotlib: [Debian](http://packages.debian.org/source/python-matplotlib) [Ubuntu](https://launchpad.net/ubuntu/+source/python-matplotlib)
Sure, either way. I guess I see `npm test` becoming the default way to test a library, and running in the cli is one step vs two (and could be hooked up to a CI server or something).
И такое было. =)
Ошибка в мутации порождена именно тут. Вы не делаете копию массива, вы работаете с  указателями.
Для проверки этого утверждения очень кстати будет ваш метод printDnas.
[oldDNA printDnas:self.dna]
меняем в self.dna любой элемент и повторяем метод.
Вы увидите, что  изменения произошли в обоих ДНК, как раз по причине работе с указателями, а не с копиями массивов.
Я несколько невнимательно осмотрел кусок кода. Действительно, довольно-таки интересно закрутил: сначала формируешь массив от 0 до DNA_SIZE-1, затем в цикле сначала случайным образом выбираешь ключ, за которым будет скрываться случайное значение, удаляешь его из массива индексов и меняешь букву на отличную от исходной.
Вы не учитываете, что х по заданию - процентный показатель. А надо бы.
Рекомендуется, если размер массива заранее известен (как у нас), инициализировать его, выделив память под нужное количество элементов. Для этого у объекта NSMutableArray есть метод initWithCapacity:
Это объявление -(id) init; есть в наследуемом NSObject. Здесь повторять не нужно.
Полезное замечание, спасибо!
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Isn't there a res.sendFile or something like that?
Can you fix the spacing here.  Instead of using tab use spaces.
Note that the mapping logic itself has not changed. It appears in this diff because of the indentation change when moving it to ``doLoadMetadata`` but you can check this when viewing the diff [excluding space changes](https://github.com/doctrine/mongodb-odm/pull/350/files?w=1)
It's not clear one way or the other in the documentation, but the naming of the method makes it sound like it should be invoked only _after_ the arguments are set (i.e., "retain your current arguments").
Mindfuck much, deze moet in app/config
Is the build system always Linux? If not, this will fail on other build systems.
gofmt please.  This should also have a blank line above it.
I see. So the problem is rather our `Site` configuration. I have [fixed that](https://github.com/cspurk/META-SHARE/commit/04d0a8c3e1147fc6f171f2c8c8a78f7a671a4826) and will issue a pull request when Jenkins is also happy with the fix. In the meantime, you can try again with my fix locally, if you like.
ok, also the init will prevent that..

On 01.12.2012, at 23:18, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -75,7 +76,12 @@ def __init__(self, fnames, allow_maxshield=False, preload=False,
> >                   verbose=None, proj_active=False):
> >  
> >          if not isinstance(fnames, list):
> > -            fnames = [fnames]
> > +            if not op.isabs(fnames):
> > +                fnames = op.abspath(fnames)
> > +            fnames = [op.abspath(fnames)]
> This line fortunately only executes in the case where it's not a list (the line above checks for that).
> 
> —
> Reply to this email directly or view it on GitHub.
>
isn't that redundant with evoked_type?
yes, had it mind but lost it while fighting with the fiff. Thanks for the reminder

On 11.12.2012, at 20:30, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/preprocessing/tests/test_ica.py:
> 
> > @@ -162,14 +163,42 @@ def test_ica_additional():
> >      # epochs extraction from raw fit
> >      assert_raises(RuntimeError, ica.get_sources_epochs, epochs)
> >  
> > -    ica = ICA(n_components=3, max_n_components=4)
> > -    ica.decompose_raw(raw, picks=picks, start=start, stop=stop2)
> > -    sources = ica.get_sources_epochs(epochs)
> > -    assert_true(sources.shape[1] == ica.n_components)
> > +    for cov in (None, test_cov):
> > +        ica = ICA(noise_cov=cov, n_components=3, max_n_components=4)
> > +        ica.decompose_raw(raw, picks=picks, start=start, stop=stop2)
> > +        sources = ica.get_sources_epochs(epochs)
> > +        assert_true(sources.shape[1] == ica.n_components)
> > +
> > +        # test reading and writing
> > +        test_ica_fname = op.join(op.dirname(__file__), 'ica_test.fif')
> use tempfile see #247
> we need to find a better way then auto generated random tmpfiles as if you run the tests many times it fills up your disk. Happened last night on the build bot… PR welcome on this...
> —
> Reply to this email directly or view it on GitHub.
>
devops vs DevOps
When you said commit, did you mean comment ? :P
We generally avoid ending methods with explicit returns. `Object#tap` is a good fit here:

```ruby
model.create_reflection(self.class.macro, name, options).tap do |reflection|
  model.defines_has_many_finder_method(reflection.name, reflection.klass)
end
```
Are these used anywhere?
This if/else block is a prime candidate for a presenter or helper method
You should use:

     ``false``

Instead of a single backtrick.
`primaryString="true"`

It's a boolean value, not a numeric one.
Thanks for the tip @WouterJ. I'll do what you say.
Hey Thibault!

What is your thought behind removing this completely? It does have a typo - an extra space between the first two `.` chars.

Thanks!
用句号
At the end of every [keyUp](https://github.com/SpenserJ/subway/blob/600123bcdf5b5e8914a0c02fbf7611a15891dedb/assets/js/views/chat.js#L165) we trigger [$('#chat-input').change(), ](https://github.com/SpenserJ/subway/blob/600123bcdf5b5e8914a0c02fbf7611a15891dedb/assets/js/views/chat.js#L71)which enables or disables the input based on whether there is actually content. More of a restructuring than anything, so that all of the enable/disable code is in a single location.
I think the question mark got lost when this method was renamed.
I'd use `sortAttachmentsBy` instead, shortcuts aren't nice.
its faked input (config file) only.
Like so often, the best way to find out is to go for it. I think that editing should be interrupted by:

- loss of connection
- file deletion
- password change

We should open a branch for this soon. Maybe I'll do it but I think it's a two man job.
Set `pass` to NULL. `PKCS12_parse()` will treat it as an empty string, you can drop `passAllocated` and do an unconditional `free()` on exit.
shouldn't this be skipped in (thorugh a tag) in doctest testing? Have you run nosetest with doctests?
Should this have `ShowInTray=false`?
why not 
```
def as_json(options = {})
  # no need to options || = {}
```
exception message must not be translated
Well there aren't many elegant ways to build these links and get the right http/s and endpoint--I can't just snag them from nova because nova's endpoints are necessarily different from the ones we want to return.
I've already moved it to the views, I'm just accumulating fixes for a commit to follow shortly.
Probably missing `first` here. No points.
StringTokenizer should be replaced by value.split(",")
Ups! My bad then. Are you fixing the online docu too?
"based on MongoDB project"

should either be
"based on the MongoDB project"
or
"based on MongoDB"
It looks like most of this code could be moved out of the loop?

Up to _withFlags_ as this method potentially returns a new cache instance; just the _put_ method should be in the loop.
Endless wait not good...
Maybe turn this into a test too?
I'm deleting it.
Does it also fix it with tight_layout()?  I thought that it only had to do with bbox_inches='tight'
Assumes ISO-8859-1 encoding, but folder comes from database which is UTF-8 encoded. Perhaps,

```php
mb_convert_encoding($this->srvstr.trim($folder), 'UTF-8', 'UTF7-IMAP');
```

*Probably not an issue for 1.7, but something to keep in mind for the full internationalized version*
Tots.
Hmm; then yes, the Windows service will need to make sure and pass the same options to rad.
I already use _.isUndefined - it is changed.

On Wed, Sep 5, 2012 at 8:40 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> > @@ -63,10 +63,30 @@ var quantrule = function( foundok, rulename ) {
> >    }
> >  }
> >
> > +var lenrule = function( islenok ) {
> > +  return function(ctxt,cb) {
> > +    var conditionallength = ctxt.rule.spec
> > +    var value = ctxt.point
> > +
> > +    if( !_.isUndefined(value) ) {
> > +      if ( _.isNumber(conditionallength) ){
> > +        var valuelen = _.isObject(value) ? Object.keys(value).length : value.length
> > +        if ( !_.isUndefined( valuelen ) ){
> > +          if ( !islenok( valuelen, conditionallength ) ) {
> > +            return ctxt.util.fail(ctxt,cb)
> > +          }
>
> use _.isUndefined
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/9/files#r1535899>.
>
>



-- 

*malex*
I was wondering what you think about the facter requirement. Should I add this to the README?
Why remove the version pinning for the jpi gem? Is there a more recent release that has new goodies?
Refactored into updateNode() and createNode(), which also means that those two uses of the logic are split in two methods. So no inline utility methods. Could do a simply jQuery plugin in lib.js, but frankly, its three lines of code :)
This should be `&& !basic.exists)`.
I found a nasty race condition in the code today. You should change this check here to: `OXT_UNLIKELY(pool == NULL || process->detached())`
棋牌游戏。[斗地主](http://ddz.dapai.in)，Node.js + Socket.io + MongoDB + Ali Cloud
x does not seem to be used anywhere after this - plus I don't think it's good practice to use a it this way (it's a special variable for instances after all)
Is there some functionality change here that I'm missing, or is this just formating?  Let's avoid unnecessary white space change as that causes merge headaches later.
Sorry, I'm being slow. Can you give me an example of a situation where this check will fail, assuming postMessage is supported?
if (empty($this->asset_id) || (isset($currentAssetId) && $currentAssetId != $this->asset_id && !empty($this->asset_id)))

would be one option here. 

or you could add
else 
{
    $currentAssetId = 0
}

where $currentAssetId is set for the cases where $this->asset_id is !empty.   Or just put it before and save 3 lines of code.
It is a bit confusing, but the reason is that params is only one of the options to `ActiveResource#find`.  We want to pass through any other options supplied to the underlying find call.  We actually use this feature in our code to get all players for a team since the url is non standard (we use the `:from` option).
We're not always generating the thumbnails; we're only generating them for JSON results since that's what the widget uses.

That being said, I'm not opposed to returning a thumbnail of a constant size, hosted by us, instead of sometimes linking off-site.
Oh great, there will be a merge conflict then.
already defined a few lines above?
This seems like a kind of weird thing to ask people to do; open to discussion, though.
You do understand that you are editing a generated file here?
Calling this multiple times will return different results. Better named as `createTimestamp`?
Good point. Yes, I'll change it to a timestamp.
Does `Rails.root` exist here? If so, we could do `Rails.root.join *%w(app assets javascripts)`...
This field is defined in user document?
Double space before "welcome page".
And scope?
Next to login.html, in `/piplmesh/account/templates/user/`.
`generate` -> `create` (similar to `createDOM`).
OK, we should decide if we are confirming e-mail or confirming e-mail address. And should stick to this terminology everywhere.
There is nothing wrong with an empty line here and there. ;-)
Use braces to make the boolean expression obvious to the reader.
Just for you Conor <3
It's (mainly) for diffs or viewing files of an older revision. There is no alternative to temp-files, since those files are not available elsewhere (those have to be extracted out of the git repo history).
Second bit: WargamesEnabled
Old habits die hard, I actually noticed the full exposed window, but somehow my fingers just type 'w'
Ah, stimmt, gar nicht gesehen... ich denke das macht Sinn!
_path='/tmp/alk8a9dfa9sdfa9sdfa9sdf.jpeg
'
When I wrote this, I still had SessionFactory implementing SessionOwner. I did it this way because SessionFactoryImpl doesn't have a reference to the session, so it would have no way to determine the setting for isAutoCloseSessionEnabled().

Also, it didn't seem appropriate to override what was explicitly set by SessionBuilder.autoclose().

I suppose there could be an SessionOwner.getAutoCloseStrategy with methods that take a Session, sort of like CustomEntityDirtinessStrategy.
Can go to previous line, indent one less for the next lines.
Changed the name to _col_or_row
Okay, reasonable. We'll just have to careful not to use no-brace if statements. Got bitten by that once when using one of the ngx_queue macros.
"But when n grows the computation time increases, due to the LS regression on h-subsets and the n residuals that need to be calculated each time. TO avoid doing all the computations in the entire data set, we will consider a special structure."  (R & VD)
So the splitting part is mainly there to speed-up things, right?

They seem to stick to a splitting scheme with runs in sets respectively of size 300, 1500 and n_obs. I wonder if this is not a bit of over-fitting...
Now that I'm looking at this in a bit more detail. As I think Josef mentioned why is there is separate class for this? If this isn't an EL estimator then it should really just be an option to OLS as you've done elsewhere.
statistics question: does this work for any distribution?  (with some restrictions like finite moments)

I was once looking for statistical tests for skew and kurtosis, but found essentially only normal distributed examples, not for other distributions.
use "when" instead of "test"
IMO this should be debug (and 'outdated').

I would also lower "Upgrading old Nexus configuration file (version 1.4.0)" from DefaultApplicationConfigurationUpgrader to debug level.
Open TODO.
Why is this whole class ignored?
I think we're predominately using this pattern for cleanup, right?  I wonder if we should rather just fix everything to use events.
I'll look into this in more detail when I work on #200.
I think the documentation of the wrap() function probably does this implicitly.  But we can add something more if you think it's warranted.
Yes, they should be changed to PSF, HDU, and GalSim unless I'm talking about keywords which are supposed to be lowercase.  I'll go through and make sure they are all consistent.
The function returns values in the range [1-9].
the previous time value needs to get set on this too,
the best way to set time is to call setKeyframeTime(keyframe, time) that way subclasses that respond can do so too - confusing i know
$Result['path'] is also defined in line 63 and it's the same. I think we can move it before whole "if" condition, and thanks to that we will have it only in one place.
don't do too much -- let's merge in what we have then discuss the "right" set of options (i've just tossed out ideas, let's kick it around a bit before coding it)
You replaced it with `auto`, it should be `cocoa.id`.
please use english names
I am thinking this exception class should go into a new file altogether - it makes finding them in the code a lot easier.
what if `options['yes']` is undefined?
No, how do I merge this into my current branch?
Ok. Then. We always use binstubs and path install in ours projects. But I'll change it.

Should I remove the `--without production` too?
What's wrong with a latest version?
What if they have multiple accounts set up?
If they have no accounts, is granted false?
Wouldn't we just cast the id to a string and proceed?
я хочу хешсет, который хранит уникальные строки не обращая внимания на регистр 
чтобы не писать свою обертку строки, кладем в и проверяем наличие для ловеркейсовых строк
А где реализация интерфейса?
Должно браться просто название класса. Т.е. ```<classForSerializationMethods>```
We should move this import at the beginning of the file.
ok fair enough for now
maybe "on a severed sphere" instead?
Perhaps it would be good to add some Wikipedia links for some of these terms like *photon flux*, *quasars*, etc.
Oh. I didn't think about that. :P
@NinjaZidane How would you know what world to set the time of? If we want this we need a world name param in the command.
No. Some expressions 
- `FileExp`, `AssertExp`, `DelegateExp` ... derived from `UnaExp`
- `IndexExp`, `RemoveExp` ... derived from `BinExp`
might not need save starting of alias this recursion.
But other expressions always need to do.
Shortcut.  Just like in underscore, for example.  I think I ended up using it only once, however, after a few iterations of the code.  Since it gets referenced inside a "each" iterator, I don't want it to be recomputed every time.
We should throw an exception is the arguments are not correct
Doesn't matches get leaked here if we're using -v?
What about next? Is it zero by default?
closing </form> must stay.
That doesn't look right, it's supposed to be a file path spec.

Didn't look right before though either, e.g. for non-windows systems.
As mentioned in the general discussion for the pull, this is no good; we still want `--rev` when cloning. It is true that `hg clone -U -r $tag ... $repo && hg -R $repo up -r $tag` does not work, since the tag changeset is not part of the repo in that case. But `hg clone -u $tag ... $repo` leaves unrelated and unnecessary changesets in the workspace too. `hg clone -r $tag -u $tag ... $repo` seems to do what you want. But then `testChangeSet` should be committed in `master` first, as a baseline since it already works.
You know need to use a 'T' in that date instead of a white space.
Replicating the functionality here isn't appropriate. Even if it wasn't dangerous replication of functionality, it skips the new file verification behaviour.

Is there a reason why you can't change the data file URLs when the dataset & datafiles are created by `AtomPersister`?

(The use of `tardis://` urls also has to be a mistake, as the core no longer knows how to handle them.)
this doesn't really need to use ensure_resource (b/c its probably safe to assume that this is the only class that would try to install this package)
Hmm I cant seem to find reference to this in the docs or with a google search. Can you point me towards where I should be looking for these things?
I'm not sure if this is necessary. Local variables are not parameters.
If its really a big deal one could just put the license in the root of the repo
@maethu please check my commit. File: select_all.js
.attr('selected', none) doesn't work to deselect.
Yes, I was thinking the same thing but tabled the idea for now. It's definitely sloppy as it is, though.
I guess it depends on how redis expires keys.
please remove these comments.
remove all  gratuitous spacing.
This makes it impossible for me to restore a campus default value once I've overridden it. After I've entered a new preferred name or profile link, I can't delete it, I can only edit it. Given the really basic UX, I can see you don't have much room to maneuver, and so we may just have to mark that as a known bug for now and move on. What do you think?
Can we test that nothing happens when we're exactly at the limit?
The commit d6f226d only changed require parameter. Puppet exec resource needs unless, onlyif, creates, or refreshonly+subscribe to conditionally execute. Otherwise both execs will always run and log output on every puppet run.
because i use it in the connect() method below, and didn't want to pass it through run_host() method as well
Personal preference: Lines like this scare me. It makes it too easy to make mistakes or have others in the future mess up the logic accidentally. I would much rather have this be a multi-line condition.

Also, the return will only happen if `reopen()` doesn't return `false` or `nil` — are those intentional cases?
Before the template is loaded, why don't we just assign $current_tab to $default_profile_tab if it's not set.
Perfect.  Thanks.
Let's use `Color.floatToByte` throughout now.  Actually we should add a function to `Color` to convert all components.  CC @mramato
This needs to be `var getJson = function(url) {` for documentation to work.
Although I have used the Scott Meyer's `lhs` and `rhs` abbreviations many times elsewhere, we probably shouldn't put them in our public interfaces.  Perhaps `left` and `right` are preferred.
Yep, this entire switch block is debug code that will be deleted before we merge terrain to master.
Children can still have percent widths. Percent is not supported for contentWidth. So the original condition is valid.
Agreed. This was addressed for another PR. https://jira.appcelerator.org/browse/TIMOB-9147
Windows support will be part of a separate PR
`#define` should be updated here as well.
The use case is odd because if you remove the base activity in the task, the developer no longer has control over the display of that layer.  In the case of a dashboard model, the base activity would likely be a window with buttons, background, etc etc and a tab group would be opened over it.  When closing the tab group in this case you would go back to the dashboard which is intuitive.

This is like saying when the user is at the dashboard in a normal app and they hit back, the app would not exit (which is not have normal apps work).  The default exit when the tab group is the base activity for the task stems from this being the normal use case.  Most of the time, a tab group in a titanium app IS the dashboard so the normal expected behavior is to exit when the group closes.

The issue with the back button sounds like a bug rather than a parity issue.

To be clear, this is more of a "what is the common use case" versus "is it possible".  A good question to ask is "how many existing titanium apps depend on this behavior currently and would break if the default was changed?".
We should though, that doc you wrote was sexy as hell man.  I think we'll get more points because of it!
You can remove this method and just do the logic inline down below.
This seems like it might be a bit overkill for just checking if the tag is in the entries.
I will test it again. I thought I verified that this did work for (epsilon) and (2pi - epsilon), but I only tested Chrome. I suppose I ought to check some other browsers as well.
Whoops - no, fixed in a new commit
I'm well aware that the if is like that in the current code, but it's a mistake. In almost all cases, every template parameter should be checked in a template constraint. Yes, `randomSample` should catch it, but that doesn't excuse `RandomSample` from checking its parameters - especially when it's public and could be constructed separately, even if that wasn't the intent (if `randomSample` were written now, `RandomSample` would almost certainly be internal to it, but that could break code, so we've left it outside).