labofsahil/github-event-dataset-2012 huggingface dataset:
You have to load the icon also, if loading the machine fails (not in the try block).


If a machine can't be loaded, only the filetype icon and the filename should be displayed on the welcome screen.
How important is this one?
Hi Danny. I already switched back to charge_only_mode from motorola/common and separated our liblights from sholes repo. Currently, I'm building our liblights as lights.omap3, though I may switch to more specific lights.mapphone_umts later. (I'd like to respect the Motorola naming, so I want to keep the board defined as 'sholes'.) So I was able to resolve the conflict between the two sholes devices in a cleaner way then via releasetools.
Consider it done, I have no more issue with your changes to charge_only_mode :).
Thanks! It works fine for me.
Mixing `INFO`, `printf` and `std::cout` in same function.
there should be no code between </head> and <body> ?!
oh wait it is there
Not sure we can stick to that rule for fetch functions that return a single object. I rather think we should standardize on returning `false`. Most libraries standardize on `null` when the object can't be found (e.g. `getElementById`), but we're already using false almost everywhere.

I suggest this policy: 

 * Try to have a single return type, using false-equivalent values like `0`, `""`, and `array()` as flags.
 * Mix the return type if the user must be able to distinguish between similar values such as `0` and `false` (e.g. `strpos()`).
 * Return `false` when a single object cannot be found under normal circumstances.
 * For functions that should _always return an object under normal conditions_, throw an exception if the object is unavailable.
There are more JIT menus -- entity, river, etc.
The problem is I never received any emails about any further comments, and
no one bothered to follow up, which is concerning because my feedback
wasn't just formatting, it was design feedback.

I'm happy that you're willing to continue the discussion (and I appreciate
that), but we can't just merge pull requests with outstanding design
feedback (and I know you didn't actually do the merge!)

Does anyone else have problems with GitHub email feedback? I also don't get
emails if a discussion has started and I wasn't already in it (though I get
emails about portlets that I don't care about :-)).



On Mon, Aug 6, 2012 at 2:11 PM, Misagh Moayyed <
reply@reply.github.com
> wrote:

> > @@ -118,6 +127,17 @@
> >      int getEvaluationOrder();
> >
> >      /**
> > +     * Get the name of the attribute this service prefers to consume as
> username.
> > +     *
> > +     * @return Either of the following values:
> > +     * <ul>
> > +     *  <li><code>String</code> representing the name of the attribute
> to consume as username</li>
> > +     *  <li>{@link #DEFAULT_USERNAME_ATTRIBUTE} or <code>null</code>
> indicating the default username</li>
>
> I think it was assumed that all comments were accounted for given the  3-4
> days in between the feedback and upcoming fixes. We could certainly carry
> on the discussion to apply any further suggestions and fixes though.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Jasig/cas/pull/93/files#r1314089
>
context.system is fine, thx
Exactly what I was originally looking for, but didn't found then. I have changed to your suggestion.
Not needed, see LogSource:

    implicit val fromActorRef: LogSource[ActorRef] = new LogSource[ActorRef] {
        def genString(a: ActorRef) = a.path.toString
      }
Why don't we just reuse the same config option to use a dispatcher for all of the remoting?
I think any real failure detector would need some config, (and logging) so I think we should say that the constructor takes a system as parameter
class ScheduleInReceive(var target: ActorRef) {
  def this() = this(null)
  …
}
This will allocate a new PF every call to it.
Rich, what Patrik means is that side-effecting calls should always use parens
because that is the only way to shut up the compiler, I fear
The query that's generated would have to incorporate a GROUP BY clause. So,  when the $column is an array, select COUNT(*) and group by the $columns. Only if the $group_by column isn't set. This will still change the output in some cases, but has the least affect.
Oops, add this back ...
if_card removed
I think it still needs wrapping, as otherwise the server is going to fetch the URL directly rather than via the texture cache?
We (team-xbmc) care about keeping the code clean and consistent...
Might be true, but we are going to want real parsing here eventually.
On Oct 30, 2012 8:39 AM, "Rainer Hochecker" <notifications@github.com>
wrote:

> In xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxPVRClient.cpp:
>
> >        st->iChannels       = props.stream[i].iChannels;
> >        st->iSampleRate     = props.stream[i].iSampleRate;
> >        st->iBlockAlign     = props.stream[i].iBlockAlign;
> >        st->iBitRate        = props.stream[i].iBitRate;
> >        st->iBitsPerSample  = props.stream[i].iBitsPerSample;
> > -      st->m_parser        = m_dllAvCodec.av_parser_init(props.stream[i].iCodecId);
> > -      if(st->m_parser)
> > -        st->m_parser->flags |= PARSER_FLAG_COMPLETE_FRAMES;
> >        m_streams[props.stream[i].iStreamIndex] = st;
>
> I was wondering if this is required because I couldn't find any audio
> codecs in ffmpeg with a split function.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1690/files#r1975826>.
>
>
And you really should just make it `unit2` instead of `unit2 discover`, and move `discover` down to the `test` target.
pdb do usuniecia
If you have no problem with duplicating methods per each instance, why don't you use constructor-closure privacy?
+1 douche;igt. Var god och ändra tillbaka.
Nother blank lilne comment.
Looks like indentation got screwed up here...
no, if `fw[row]` is truthy there is a foldwidget on row, and click on it is already handled above
Recursive remove is not necessary here
since this is in RemoteTransport, is it also used for the new remoting? if yes, how will this take into account multiple transports?
In tests no additional tap event is being issued for any mouse events as our other tap is issued from mouseup and our normalized gesture up, neither of which are trigged in this case and the inverse is true as well.
use a typethint instead of doing the validation here.

And btw, an exception with an empty message is bad for debugging
Sorry, bad habit of mine! I seem to think that's neater... I'll fix that in the next commit.
This is so confusing, why do the `worker.on('exit')` have `exitCode` and `signalCode`, but `cluster.on('exit')` don't.
L'utilisateur ne devrais pas voir cet Id, mais bon je comprends que tu as fais ça machinalement.
assert tout court avec un message aurait été plus approprié.
I think that choosing to make the timeouts configurable is an independent design decision because it applies to non-scatter-gather I/O as well.

The defaults for non-scatter-gather I/O are zero timeout, so this scatter-gather code is consistent with the other non-scatter-gather code-paths.
This is fine --- in fact, I think it's necessary.  All that oned does for PyArrayIterNew is return early to allow the caller to avoid the expense of preparing the iterator when the caller is just going to special-case this.   Because this is not being special-cased here *after* the call in fact we need to make sure oned is 0.
Can we combine `fields` and `propertyNames` into a single field, like

    {name: "getfeatureinfo"}

with values like

    {
        propertyNames: {}
        fields: []
    }
if (data.isEmpty)
закомментированный код убрать
With just name_cont, I was not getting any results back in the json response, regardless of what I searched for. It was returning just an empty array. There may have been something else that was influencing that, though.
`Concurrent::Cache#fetch` is slightly different from `Hash#fetch` and behaves similar to `AS::Cache::Store#fetch`: it stores the return value of the block, so the `[]=` call at the end is unnecessary.
Yes, but there are teats which explicitly check that the result is an empty string.
This should change too
I don't think this'd be used anywhere besides the other point I've commented, would it? If it's not, I'd lean to remove this.
To put a simple HTTP cache in front of your app, add rack-cache to your bundle and set `config.action_dispatch.rack_cache = true`.
For large-scale production use, consider using nginx, varnish, or squid as caching reverse proxies.
@jeremy should we add ```config.action_dispatch.rack_cache = true``` to default production.rb or leave it as hidden option?
`.  A quick` Two whitespaces, Is it intentional? :scissors:
How about: `assert_equal [1,2,3], c.keys.sort`?
The producers have decided this was too controversial and have rounded out the story.
```scala
scala> "ab\ncd".lines.take(1).mkString
res0: String = ab
```
pep8: space after comma
On Thu, Mar 22, 2012 at 11:12 PM, Alexey U. Gudchenko <
reply@reply.github.com
> wrote:

> > @@ -824,7 +837,6 @@ def primitive(self):
> >              c = terms.pop(0)
> >          else:
> >              c = None
> > -        terms.sort(key=hash)
>
> Note that this doctest failure is the resyult of experiment.
> Is it possible (mathematically, algorithmically) for ` _split_gcd` to
> split the source list into the two parts without dependability  of orders
> in source list?
> Have it the seance for the algorithms that uses it, that they depends of
> the order of Add.args?
> As I understand it is related with "sqrt_deenest".
>
>
Rather than start with term 0 it could start with whichever surd has the
smallest base.
doctest + docstring missing.
This should have a docstring or (since it seems internal) a prepended underscore.

Actually, I think both would be good (no need for a doctest, just explain what the function does and that it is internal.)
Add spaces around `+`.
Typo: physucs -> physics.
move `else` to the end of last line, now I use` ifelse` function.
That's necessary to silence a clang warning (= vs == in a if statement).
*sigh* this python crap needs a total rewrite. Lines like this make me sad.
I don't have a strong opinion, but tend to say 3). Maybe `kotti.url_normalizer.make_ascii` or `ascii_only` is even clearer?  You decide.
I only set non-nullable values using these default values.  I'm ignoring the mysql default values.  Too much confusion if I introduced those.  The problem with using mysql default values is that a column in mysql could be non-nullable and have no default value.  In these cases I would not be able to instantiate the model object without a default value of my own.  Thus, I decided to just use the same default values for everything when you create the object instead of mixing in both mysql and other default values.
it should work... what i meant is this...

``` js
// somewhere outside
var hasPerf = win.performance && win.performance.now


 // then inside the frame method...
var time = duration || thousand
      , self = this
      , diff = to - from
      , start = +new Date()
      , stop = 0
      , end = 0
    live(run)

    function run(t) {
      var delta = (t < 1e12 && hasPerf) ? t - win.performance.now() : t - start
      if (delta > time || stop) {
        to = isFinite(to) ? to : 1
        stop ? end && fn(to) : fn(to)
        die(run)
        return done && done.apply(self)
      }

// ...
```
The whole module could be refactored to use `meck_sequence` and `meck_loop` instead of `sequence` and `loop`. Then this function would be uneccessary.
Actually, that only applies to this comment (saying I will take care of it in the transform branch)
How is .equals() defined for StudyOutcomeMeasure? Remember that the (reference to the) included variable is mutable, so if som.equals() compares the variable, don't use som.equals() here. It is probably OK to use d_som == other.d_som in that case because we really are interested in material identity.
Defines go at the top, right below the includes.
No, I'm writing data from this local address.
`spacePath` is hydrated for readability purposes.
we can put :ref:`Write Concern <write-concern>` in today, and it'll automagically point to the right place when we redirect things.
for many operations, clone has identical functionality and a more simple syntax than copydb. 

I think it's good to avoid telling people that something is more straightforward, particularly if they're confused or find something difficult.
Since this is using PDO and is for test cases only, it can stay here. I've mentioned before though that I think we should split this class up into subclasses with db specific code.
This can probably be rewritten in a safer way without a switch statement that has cases that may never be executed. An array of lang key / text pairs perhaps.
Style names are not related to directories, so that would be incorrect. Simply renaming directory will make style installable.
as always: protected
It's fine, it's how the language files all are.
This seems like a common-enough word that it might be already in common.php. I have not checked, but please confirm that it is not already present in other language files that would be included on this page as well (i.e. common, acp, etc.)
we're not using @ api
Not really as the meta-data only needs to be used by the extension admin and not via CLI tools etc. And the extension manager manages extension statuses etc. which makes this slightly out of its remit?
we generally check for err first then fall through if no error.
DATACENTER_FIRST_RECONNECT_DELAY
> HWND* display;

well thats not a display :) for windows handle there is a OpenGLWindow::window attribute. I guess there is no alternative for Display in windows.
This looks like a lot of repeated code, but I'm thinking it's necessary, I do see an opportunity for a helper in the base controller.  How's this look?

```coffeescript
# BaseController
respond_to = (response) =>
  if @request.params.format is 'json'
    @response.contentType 'application/json'
    @response.send response.json()
  else
    @response.render response.html()

# UsersController
index: ->
  users = User.find({}).populate('team').asc('username').run (error, users) ->
    throw error if error
    users

  respond_to(=
    json: ->
      JSON.stringify(users)
    html: ->
      'users/index', { title: 'List of Users', users: users }
  )
```

My syntax may be a little (or a lot) off, but it's possible
Ah great, I misunderstood.
Prefer to move the comment inside the else block and put the else on the same line as the } rather than splitting this way.
Test name should start with `Should_xxxxx`
Please add comment to this file explaining how you generated it. Also, need to make sure this file gets minified before deployment.
please dont send commented out code in a pull request. Best to keep it in your private fork/branch.
We should have the 'read' boolean here as well
```dtype``` is undefined. ```numpy_dtype``` perhaps?
we can refactor this block of code, since the js is exactly the same. 

Copypasta?
Should there be a "break" ?
Since sem is a (sem_t **), is there code in the calling context that's relying on (*sem != 0)?
For consistency, invalid parameter counts should be tested and handled prior to testing for extracted constants, rather than testing and handling here AND in getCleanParams above -- the presence of constants should not change the error message (as it does now). So, the checking done now in getCleanParams should be an assert -- it's already redundant in 2 out of the 3 places getCleanParams gets called.
doesn't work, because the `tests.js` file is inside node.js / mocha context

`app.js` and `vendor.js` => jsdom
`tests.js` => mocha / node.js

that's why I modified the require definition for tests a bit - if the module can't be found inside the current context, try the jsdom context (by calling `window.require`)
i changed it back. prefixing looks like EBNF
I see. An alias `ArrayRef[T] = CoordinateRange[Pointer[T]]` might be nice to have too.
@rwldrn Yeah, I wasn't too thrilled about that either, but the fix depends on getting a style off of the object returned from `getComputedStyle()`. The reason I went ahead and saved it off to a variable was to get around the `Expected an assignment or function call and instead saw an expression.` JSHint error. I could save it off to an existing variable such as `i`, but that felt weird too.

I am thinking of pulling out a feature detection into the jQuery.support module to test for this strange bug so that it can be scoped to only IE9/10 not affect the performance of other browsers.

With this support feature, I will still need to save the style to a variable for JSHint to like it. Would you recommend renaming the variable, reusing another variable, or something else?
over here you can just say `return;` without a value, and it'll no to look up the property normally.
I knew about `JSON_FORCE_OBJECT` but the solution I went with in the next amendment  (casting `(object)`) is basically exactly the same (people commonly doing that lead to PHP implementing `JSON_FORCE_OBJECT` natively as of PHP 5.3).

I guess I'm still getting used to the fact that PHP 5.3+ is okay nowadays :)
I tried in PG8.4.
don't think you need this translateY…
I'm not a bit fan of raising exceptions that cause pages to have HTTP 500 errors. But if you think it's sufficiently unlikely that this will happen, you can leave it as is.
This should be `depends_on :autoconf => :build`. The symbol version of `autoconf` has some magic which determines whether the system already comes with an autoconf, and fishfish builds fine with the version of autoconf that comes with Xcode pre-4.3.
Am I reading this incorrectly or does sqlite give a different behavior then the other backends.

sqlite seems to replace the existing row when the key already exists while the other backends don't change anything.

Also mysql has it's own syntax for both cases which would probably give a better performance
If you're going to log this, log the content of the message as well: `debug('Inbound message: $s' % (msg,))`
I don't think so, but this is copied from the HTTP API.
There don't seem to be formatter tests, or any tests for `hex_str`, obviously, these aren't those tests, but perhaps setting one of the ids to be >= 10 to prove it is hex may help coverage a bit?
Use a single var statement here.
Maybe we could call a `set_default_crumb` if it's defined in the controller.
Then it does not set any crumb by default and allows inheritance from `ApplicationController`.
Off how?
Is this hand-written, or exported from a tool?
I'd prefer this be kept private and you add a resetId() to SpoutEntity instead. ID is a component of entities, not players.
Nope I'm OK with it.
Seems like we can consolidate ``enableAutomatic`` and ``disableAutomatic`` to ``setAutomatic(boolean)``.
Throwing an error for a duplicate id seems a little harsh. We could just return the existing menu object.

This same comment probably applies to top level menus also as described in issue #954.
This works fine as long as brackets is a standalone repo. If brackets is a submodule of brackets-app, then `brackets/.git` is a file instead of a directory.

This is not a big deal since the brackets-app is deprecated and brackets should be a standalone repo, but we may want to mention this in our release notes in case anyone still has the old repo layout (like me :-) )
To disambiguate, "things" here means the shadow and triangle correct?
Since we're searching by id, we could probably skip the "#main-toolbar .nav" part of the selector.  For something this simple, maybe we should even just bypass jQuery and directly do a ```window.document.getElementById()```?
I don't understand this label either ;-)
Are we changing those values? Don't `mongo_models.MongoEngineBackend` already defines them in the way we like?

I would like that our user model supports all those.
exactly. I forgot to load picasa by gems.
I reverted all this changes.
Thanks.
This is supposed to be a fallback if you're testing locally with no internet connection, I guess the plugins wouldn't work anyway though. I can just take it out
Change the comment to be more specific (instead of smiley)
Yes. The ioshandle stuff is great.

On Sep  7, 2012, at 8:47 AM, chuckcranor <notifications@github.com> wrote:

In src/IOStore.h:

> +    virtual int Chmod( const char*, mode_t )=0;
> +    virtual int Close( int )=0;
> +    virtual int Closedir( DIR * )=0;
> +    virtual int Creat( const char*, mode_t )=0;
> +    virtual int Fstat( int, struct stat*)=0;
> +    virtual int Fsync( int )=0;
> +    virtual int Ftruncate ( int, off_t length)=0;
> +    virtual int Lchown( const char*, uid_t, gid_t )=0;
> +    virtual int Link(const char *,const char *)=0;
> +    virtual off_t Lseek( int fildes, off_t offset, int whence)=0;
> +    virtual int Lstat( const char*, struct stat * )=0;
> +    virtual int Mkdir( const char*, mode_t )=0;
> +    virtual int Mknod( const char *path, mode_t mode, dev_t dev )=0;
> +    virtual void* Mmap( void *, size_t, int, int, int, off_t)=0;
> +    virtual int Munmap(void *addr, size_t length)=0;
> +    virtual int Open( const char*, int )=0;

I think this is resolved with the IOSHandle changes, assuming you like the
revised close stuff I sent yesterday?

—
Reply to this email directly or view it on
GitHub<https://github.com/plfs/plfs-core/pull/88/files#r1555229>.
set/get_watermark 不倾向于是 RS 的 API。
You've left a `puts` statement here.
So this should be enough?
```
  def show_new_button?(manage_promotion, manage_deletion)
    if @environment.library?
      manage_promotion && @next_environment
    else
      manage_deletion || (manage_promotion && @next_environment)
    end
  end
```

And what about `@environment.organization.environments_manageable?` ? Do I still need to check that?
TheLoader is not really descriptive name, what about LoaderInstance or something like that?
should the text be in _() vs N_() ?
Please use camelCase names (both for class properties and variables)
That seems wrong
Without that there are errors...
var frame = frames[origin] and use that where it is possilbe
Also this is a bit weird that you can update the passcode with more than 4 characters and some beeing invisible. I think this.currentCode should not be updated if there is already |n| characters.
Actually, yeah, you're probably right - just replacing it with ``.to([1., 1000., 5000.])`` might be better, anyway.
Added test in d7e21aa.
I've just noticed by code includes detail of the node it's requesting to. Is this ok, or shall I make it dependant on a command-line option?
@wumpus I think this is too long for a tab; "Messaging" is already pretty clear in English IMO, especially considering that to get this one needs to enable "FIRST_CLASS_MESSAGING" (from source) or "1stclassmsg" (Gentoo).
I dont have any strong opinion as to which is significantly more readable, but it seems like a ton of this pull is just diff for diffs sake, which seems overly confusing, makes it hard to verify the pull, and just seems pointless?
using strpos without type safe checks is never a good idea!
We got our own validation rule for uuids:

	$pattern = '=[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}=is';
	preg_match($pattern, $uuid, $matches);

Maybe we could add uuid() as validation rule instead? then there is no need to make this method here public and one could still validate uuids.
I would use ``false ===`` to cancel only if the user returned false. currently, you cancel also on ``null``, meaning the default behavior for an handler is cancelling
"The", and remove the trailing period I guess.
Here's a [Stack overflow post](http://stackoverflow.com/questions/2050973/what-encoding-are-filenames-in-ntfs-stored-as) confirming the above, so that should be a good approach.
Well, 99% isn't particularly relevant - right now in master, `\w` is essentially nonfunctional because of this.  The same will be true of `\u` with nonascii usernames, even after this PR with the stricter casting (I will fix that here, in a second).

This will still fail:

    USER="éric" ipython --PromptManager.in_template="\u will fail"
as below, no reason to change the default value here.
No worries, I only meant it if it would cause you extra grief to make the doctests pass.  I don't think that is too bad in that mode, so I'm fine leaving it.
I thought `IPython` namespace was shallow enough in dashboard, where do you want me to put it ? should I split  the autorefresh between both `clusterlist` and `notebook_list` ?
typo?  /code?
ah yes of course :( me being silly.
This was my mistake, I committed this. Please revert this change so that the main download button doesn't point to the mobile version :)
Oo--I didn't know that.
None is a singleton, so you can do "if mode is not None ..."
FYI these changes were for Kadir and unrelated to this bug. But since they were questions changes I thought I would just include them here rather than a separate patch.
oh and inside `cleaned` it should be `voted`?
split calls out to get_list_url and get_detail_url to be more clear.  also used pk for detail.
Are these notes still needed here?
For what we're doing (e.g. `urllib2.urlopen`) I don't think there's any benefit with using `requests`.
Was it old style?
you can do `getattr(request, 'amo_user')` instead of hasattr + request.amo_user.
`</a>`
Yes, sorry Phil for all these unvolontary changes. As I explained to Jerel (see comments), I'm a Github newbie and got things a little mixed up trying to apply my changes to a fresh 2.2 version.

In addition to the language files, my intervention was supposed to be very simple, on only "system/cms/modules/wysiwyg/js/wysiwyg.js" and "system/cms/modules/wysiwyg/views/files/index.php" (I have no idea about changes in system/cms/modules/wysiwyg/ckeditor/plugins/pyroimages/plugin.js
or system/cms/modules/wysiwyg/controllers/files_wysiwyg.php).

My apologies again. Maybe I should start all over?
so? use the instanceof operator
Yes also as query string param is should be passed as param to the path function because additional params when generating urls will be added as query string. Your code is broken, if you change the `_wdt` route later to not include the token in the path but instead in the query string. It would generate something like `/_wdt?token=xyz?position=normal.

I don't see how the correct host is passed to the subrequest. Because the render function uses `Request::create($uri, 'get', array(), $cookies, array(), $server)` and without host, the created request will have the default `localhost` as host. Or not?
you wouldn't need that if ResponseHeaderBag::getCookies() PHPDoc was `@return Cookie[]` I don't know what other thinks but i prefer the latter
This class doesn't really handle inexistent `$offset`s. In `replace` it will create a invalid array index warning (`PropertyPathInterface::getElement` doesn't really define this case). But `replaceByIndex` will create (and not really replace) this $offset although it might not be sequential.
Why defaulting to null here whereas the XmlFileLoader always sets a string ?
Can you remove the @todo tag?
@stof Done
sorry, i still don't get why you are not asserting vs the result of toArray(), you don't need to test if it didn't blow up as if it does blow up the test will fail anyway and that's what we want to do (mark the test as failed if it fails)
Changed this to use isinstance(), but will leave the larger change for a separate commit, if that's OK?
Why do you send the user id? Can't you just get the user by calling user() inside the controller?
If this is for debugging purposes, please remove it.
Wanted longer error text that's not right on the disappearing HUD. Pull-to-refresh also not always obvious whereas error UIAlertView gives refresh button.
I moved this function into ocaml_backend/ and bundled  it with the Client code.
Style: `count == 0` can be `empty?` Does the `count` under the hood. I like the predicate method but your call on which one you prefer.
the info of bachelor should not exist in sample of master.
Merge it with other information or just delete it if it's not used.
Unfortunately I didn't understand how to easily verify that we are inside the JetDotQualified element, so, I think that the check for the next leaf is not bad too.
1. The previous paragraph looks to be obsolete.
2. Sorry - neither description managed to make me understand what was happening. I had to read through the code and cross-reference with how it was used in the tests.

This seems to be the only place the contents of cartopy.config['downloads'] are documented (cross-reference from cartopy.config to here would help), so an example would be super useful.
RIAK_VERSION=1.2.0 is no longer required. Just `middleman` is fine.
Done in 7a1dafb.
Yes. Should it be `_` prefixed?
I also thought that maybe we could use `container` api to track active view instances. Not sure if it is suitable/desirable.
а зачем надо отдельный haveAnswers, это не то же самое что !childs.isEmpty() ?
Is the delay the time of the transition? If yes you may want to add a comment explaining why you're doing that (i believe this is for repaints?)
interactiveMode is not a boolean; it's a string that's either 'interactive' or 'noninteractive'.  So this check should be if (!newsletterMode || interactiveMode !== 'interactive')
hmm, i think I understand finally. Maybe it means using an iframe is a bad idea?
Ahah, can't `deps.js` require it's own dependencies? :)

(btw I know this is the part of the code we now have less control on, I won't block on this)
I tried this manually and it does not work? ( I can't go back )
Please refer to these elements as “radio buttons” and “checkboxes” instead of “switches”.
I recommend REPEAT_LIST and REPEAT_SONG
Same found here
This comment does not bring too much new information :)
I have just added that
Yup, will change it and will ping @borjasalguero to review the changes in the library side.
Can you help me undertand why we need to set all of these on the swipe manager object? Feels a little messy.
Let's waiting on the spec and bring this back.
Please remove the CSS file from style folder!
`return this.alarmList[i];`
Yes, "this" is the jQuery object given in "context".
The unwrap is used to remove the empty div (the "this" object) we have added before the AJAX request as a placeholder. That's way, we finish with the same HTML as before and we didn't have to modify the easyWidget plugin.

By the way, we have forgotten the unused "//container_object = $('#' + placeId);" line. Oups. I remove it.
Why do you bind to `this`? if there are no references to `this` inside your forEach loop?
We should comment this and the format that we expect that file to be in.
Is this even used other then getting val from query string?
Good point, I'm not a huge fan of `|&` either. We took this bit from the Puppet broker so if we update one, I'd suggest we might want to update them both. Perhaps something like `2>&1` instead?
What about calling `name = name.to_sym` outside the loop, and then comparing against `name` inside it? It seems unnecessary to do it every iteration.
@solnic `Aliases#each` only iterates over the source aliases as those are the ones you need when renaming the left side for a join. The target side is left "untouched", or rather, it always uses the default base relation aliases (`"#{relation_name}_#{field}"`), so it just uses `target_node.aliases`.

I renamed `AliasSet` to `Aliases` because that goes inline with veritas naming. I'm totally open to other suggestions tho, or just changing it back.

Currently `Aliases` internally uses `@header` to do it's work. At any time, this contains the header for the relation the aliases are attached to, i.e. it equals `mapper.attributes.header` at any time. So I'm confused why we need something else?
Include には "" がない
「」 to ""
please remove parentheses :wink:
prefix with edts, an appropriate name might be edts-debug-buffer-node-name, which is pretty consistent with the function names in edts-project
oops :) Thanks!
because u ask the following in line 171:
if match_include and isinstance(match_include, types.BooleanType):
given that you are now versioning this database, you probably want to ensure a Uniqueness criteria on the version key index.   Have a look at 

http://api.mongodb.org/python/current/api/pymongo/collection.html#pymongo.collection.Collection.ensure_index

You probably want to call 

     self.col.ensure_index('version', unique=True) 

somewhere here.
It only returns the keys? It doesn't return actual values as well?
I have a problem with this code: shadow marker icon is all black - it`s not nice. Why?
-> default_round_corners
``written``
This cannot work as in Finnish we have Vs: and in other languages the string could be anything else. There can also be multiple Re: Vs: Re: in the reply.
```
axaj: (form) ->
  data = new FormData(form);
  ...
```
HURR
No space between { and 'base_fields'
logging.warning('target: <%s> must be a directory' % pool_target)

^^^Output the variable to the warning
I think careful use of Mocks like this are OK - these tests are specifically ensuring that `addBuildset` gets called with the right parameters.  At any rate, this will end up being a data API update call soon, so I think the FIXME is built into the development plan.
I suppose you mean `(``)`
we aren't optimizing here for anything...lets not do unlikely.
I think my FPU is deterministic but add a test for `_.aspectRatio == main.aspectRatio` floating point division coming out the same so the more timid of us can sleep at night.
is there still?
Maybe <strong> or <italic> is better so it's visually distinct ?
can you just remove this trailing `//` or add a comment there?
I am still wondering if you want to use "primary_email" here instead of notMe, that would force the email address to be re-provisioned with the updated IdP.
Why is removing a cron entry for update_pushlog part of this branch?
nit: missing empty line
It might be nice to unify this check with isStandalone() function as it does the same check.
IMHO data providers must provide neutral data and not specific PHPUnit values.

If there are more tests in other parts of the repository like that then will be changed where needed, but I think that we can start to do new data providers with a better design now.
This has moved to the ZF2 documentation repo.
Typo `specifications`
Appended and squashed.
This should preferably be split off in a separate function.
There is no reason for such phpdoc, it's controller action. This exception will be translated to 500 page with error message mentioned above.
Please less one-character variable names. The only one-char vars I personally condone are for-iterator variables.
The for loop you specified would throw an exception in the first loop. `tasks[ tasks.length ].id` would try to get the `id` property of `undefined`. So no, it wouldn't be better.
Suggest pass in response.data to dataDecoder() - since decoder would only want to deal w/ data response (and facilitate sharing from ctor)
Why use posts_per_page=50 instead of -1? I'm assuming there's a performance reason, but it limits the blog to 50 templates.
I started by using "HYDRATE_OBJECT" but then I started writing methods like "setObjectClass" which doesn't sound right as we are talking about Documents. I realised that this is in conflict with Doctrine, but it just seems to make more sense. A PHPCR Node is also an object.

As for the numbers, again I know this is in conflict with Doctrine. When I wrote the constants I asked myself which number to assign to "HYDRATE_PHPCR_NODE", but then realised that any number I assign is not future proof and could potentially conflict with those assigned in the ORM, so copying the numbers from Doctrine didn't seem a valid thing to do. I went for strings as they are more transparent for debugging and I have never understood the benefit of assigning numbers to constants (other than perhaps forcing the programmer to remember the constants and not the values). But happy to change in any case.
found this variant in a template package.json somewhere a dark corner :)
If the constructor is empty, it might not be necessary to declare it.
maybe an alternative solution to this could be to bind this plugin to a different signal, once everything had been read? I would feel more confortable with this approach than with the lazy loading version you're doing.
My pythonic heart would try a feature and catch an exception, but this is not Python... btw you have no constraints on Zpeto nor ender versions?
That sounds to me as the idiomatic way to make this check.
This hack for the sanity check is not acceptable to get merged into. 

This basically circumvents the sanity check, which is there for a very good reason.

Please fix these.
Good point, break it is. There should be only one hit though.
This is wrong. It breaks other features: the account connector, the registration form and the registration form handler are not configured anymore when using the config.
If you < and > here you can get a much simpler link syntax :-)
As before, the flow isn't quite right here.
This has been there from the beginning. The diff is just offset. 
Removed.
When start using /b/ in staging test not having the trailing slash after some page links causes some tests to fail.
Okay that makes sense... really the base URL should not determine the protocol...
Use `from base import BasePage` here
You should do the context update first if it does determine state. The way it is now is pretty confusing and delays getting positional data by one fetch()
I2C constructors won't need `this.mode` :)
whats the point of this change?
Fixed with commit c56f483
sounds to me this is not open stack specific, so we could probably extend the parent class with all of these attributes.
I'm having trouble finding something documenting the behavior on MSDN, here are some links that dance around the issue but don't quite get to the meat of it:

http://ajaxian.com/archives/the-problem-with-innerhtml
http://www.julienlecomte.net/blog/2007/12/38/
http://james.padolsey.com/javascript/replacing-text-in-the-dom-its-not-that-simple/

This fix at the very least will allow all of our unit tests to pass on IE9. Do mind if we merge this in for now and revisit more IE madness when / if we approach IE8?
> >
> >  		// I hope these are all the escape characters!
> > -		value = value.replace(/[|\<\>\~\^\\]/g, mapEscape).replace(/([\#\$\%\&\_{}])/g, "\\$1");
> > +		//First escape all curly brackets in the Zotero fields, then do the mapping/replacing of other characters
> > +		value = value.replace(/[{}]/g, "\\$1").replace(/[|\<\>\~\^\\]/g, mapEscape).replace(/([\#\$\%\&\_])/g, "\\$1");
>
> I have no idea if you actually want this, but wouldn't this produce bibtex
> that looks like {\\textbackslash}{ for { or {\\textbackslash}] for ],
> since backslashes are mapped to {\\textbackslash} in the second replace?
>
yeah, you're right - I'll try to think of something smarter.

> The first replace does not look correct. $1 refers to a capture, but
> there is no capture in the regex. You want $0.
>
> similarly, the last replace, you can do .replace(/[\#\$\%\&\_]/g, "\\$0")I.e. no capturing parentheses.
>
of course.

>  —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/506/files#r2401082>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
Semicolon after {
general (spacing) nit: we do `"converse":` or just `converse:`
Add ModelSEED::utilities qw( args verbose set_verbose );
Should probably add some additional error handling here.
I recommend making the block private (`_block`) and regenerate it when `code` changes.
Yes. I made sure it worked against the base django bcrypt password hasher. Perhaps I should write a test case for this?
лучше работать с уже конкретной компанентой, а не  v<v<i>>::back()
я надеюсь, что это вообще уйдет в отдельную функцию
Well, we have known-good commits for 1.3, and this project isn't *really* under active dev. Let's go ahead and update to 1.4 in the requirements.
qApp->applicationVersion() (if that's even set)? Or does this mean something else?
Should use base_url here or just assert on the domain path so it will work cross-domain
Please format this correctly.
This file should be moved out into a tests folder, it shouldn't be in the root.
As mentioned above, this would be used instead of sending the full configuration back. I can change it though.
I would check that the first comment of the retrieved comments is the one we expect (createdBy, body, level, etc.)
I wonder if it makes sense to start to move the actual UI out to a folder in 3akai-ux and start assuming that we serve this through Nginx. Then this UI can share some of the core actions like retrieving me data, i18n, l10n, templating utilities, etc. and we don't have to re-invent all of this.
Ok, I've introduced an EmptyIndex val and replaced all usages of `GlobalIndex(Nil)` in the Scala IDE.
Yuck! If you're circumventing name mangling it means you should just add accessors. Luckily, `BoundRelationship` and `Relationship` are both open for your code editing pleasure.
should we pass the parameters to getRoute(s)ByName(s) or not? on the one hand it could have potential for optimizations, on the other hand the risk is to put too much logic into the provider. should we support it or not?
Not sure you need this. The `@cohabitant` ivar will have an errors hash if it failed to save (i.e. is invalid).
In the same way, "why not" is not a reason enough to change working code (which is my primary concern).
Not worth the argument anyway ...
you should have a look on my code firstly even it is pointless to you. 

The new LOG library supports log_message('INFO', "hello", 'application').
These 2 lines can be replaced with this:

    $name = str_replace(array('\\', '/'), DIRECTORY_SEPARATOR, $path);
у тебя нету определения количества элементов для изменения. Как говорил @freetonik То что в ДНК 100 символов это счастливое совпадение, а программу нужно написать, чтобы она работала с любым количеством символов в ДНК
Зачем тут ты меняешь объекты местами в массиве? получается ты делаешь мутацию не portion %, а portion*2 %! Потому что ты с начала portion раз сделал перестановки, а в следующем массиве и еще и начал менять в первых portion ячейках значение и в итоге у тебя цепочка меняться на 2*portion %
Стоит передать методу в качестве процента "-1" и он будет идти довольно-таки долго.
Чтоб снова и снова не создавать этот массив — можно было бы сделать метод класса Cell для генерации случайной буквы. В нем же объявить этот массив и использовать этот метод везде. Если массив объявить static — будет вообще замечательно.
Надеюсь, я понятно объяснил? В самом начале мутации мы имеем два одинаковых массива! Вы берёте случайный индекс, заменяете по этому индексу элемент, и проверяете, не сходится ли он с тем, что был на этом месте в копии? Но выводите почему-то не до того, как сформировать новый индекс, а после, а ведь так как мы успели поменять только один элемент, по-любому значение по новому индексу будет сходным у двух массивов.

И ещё замечание: в задании указано, что элемент может меняться только один раз. Ваш алгоритм этого совсем не гарантирует.
У Вас в описании довольно мало написано по 1 и 3 пунктам задания. Добавьте пару предложений о том, что именно она решит ( развитие зрительной памяти, реакции и т.д,) и для кого именно оно создано. А так все ок.
@jerboaa I don't understand the coment. @ybo can you please look over this? (I believe @ybo  recommended this relation, I am not entirely sure how it works)
If we remove the `hasEnabledFilters()` method, this can assert the count of the returned enabled filters (which should be more exact).
We couldn't make createInputStream(in) to invoke createInputStream(in,
decompressor) because we need to pass a flag to LzopInputStream constructor
tell it whether it needs to return/reuse the decompressor. The reason we
had to introduce a new flag in LzopInputStream's constructor was discussed
yesterday that we cannot create a decompressor in LzopInputStream's
constructor before the super.() call.

On Tue, Apr 24, 2012 at 11:36 AM, Raghu Angadi <
reply@reply.github.com
> wrote:

> > @@ -86,7 +87,16 @@ public CompressionInputStream
> createInputStream(InputStream in,
> >
> >    @Override
> >    public CompressionInputStream createInputStream(InputStream in)
> throws IOException {
> > -    return createInputStream(in, createDecompressor());
> > +    // Ensure native-lzo library is loaded & initialized
> > +    if (!isNativeLzoLoaded(getConf())) {
>
> I see, you can keep the check. just make the other createInputStream()
> invoke this one.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kevinweil/hadoop-lzo/pull/1/files#r728050
>
mne_analyze
should be assert_equal or assert_true(epochs_ts.ch_names == epochs.ch_names)
what should i use ... for (var i=0; i<array.length,i++) ????
Imo, we should show `AllowOverride All` and not include the mod rewrite options here. Then, we can add a note saying that for performance, you may choose this other option.

My goal is to keep this as simple as possible, so people understand the minimum required. Imo, I think we should also remove the `Options ...`, `Order allow,deny` and `allow from all` lines - they're not strictly needed to get things up and running. Same thing with `ServerAlias` and `ServerAdmin`.

But, if anyone disagrees on any points, please let me know!
this should link to the related doc
I think adding an API url for this class can be usefull.
已减
`md to json` -> `Markdown to JSON`
use private[akka]
Yes - that works fine. I've pushed a new commit with your suggested change.
yes, same reason like sympy/galgebra/examples/testsymbolicGA.py
Зачем всю `FilePath_`? Лучше `<em>QFileInfo (FilePath_).fileName ()</em>`.
I extracted this out to try and focus the already complicated `initialize` method.
Me parece que no vale la pena por lo siguiente (avisame si se me escapa algo):

* Si se cae el la aplicación, al levantarse nuevamente se vuelve a iniciar el pooling que se realiza cada 3 minutos.
* Si se cae el proceso a mitad de una generación, lo peor que se puede pasar es que envíe algún email repetido y se retrase 3 minutos la generación del pedido, ya que no se marca como procesado hasta el final.
I was thinking the same thing, however I want the citation tool to be used with multiple inputs and outputs, and i thought this way they wont have to instantiate a new one for every input.
use API to get task settings
Need to update these post-merge to avoid pointing to sandbox-dev in the master branch
this is where you call chocolateyinstall.ps1 right?  had you thought about calling it with params?  I feel like the packages I am making have 

$binroot="env:something"
$packagename="notepadplusplus"
`version` does not belong to `this` anymore.  you should use `this.serverInfo = 'node-static/' + exports.version.join('.');` instead.
more import space...
gotcha let me see what i can do.
I think using Collections.synchronizedList() + an synchronized iterator would make more sense then. I agree with your performance point, but people reading the code(such as me) might wonder what's the point for using an CopyOnWriteArrayList here and it's the time they spend wondering I'm concerned about :-)
Hmmm, you're only throwing the exception with the message, but no cause stacktrace, which might hinder error debugging. Was this done on purpose?
Don't you mean for interoperability with direct access to the remote cache in embedded mode? RemoteCacheStore already uses a RemoteCacheManager, so there shouldn't be any interoperability issues with other RemoteCacheManagers.
The comment is in the wrong place (not your fault) and is therefore misleading. Should be on the function itself.
You can remove this line, the one at the end is sufficient.  Once you've done this I'll merge the PR.
I am referring to def top_crasher(self):

(singular)
We have a Util.isElement that it makes sense using here.
Squelch this?
from the logistic namespace.  Not sure why they were there.
This comment is really for the next line. We shouldn't be committing binaries to the source repository.
O render foi construído inicialmente com as necessidades do catalog root, conforme forem adicionados mais funcionalidades nele a idéia é que seja implementado um TestUnit específico
please also add yourself as sole copyright holder - after all you wrote the code :)