labofsahil/github-event-dataset-2012 huggingface dataset:
@smichr sorry for making such a mistake .
А зачем вообще добавлен ````!@highest_point.nil?```` ? Ведь если будет nil, то левая часть вернет true и до данной проверки дело вообще не дойдет?

````
> @a = nil
 => nil 
> @a = 1 if (@a.nil? or raise)
 => 1 
`````
I'm okay with this as-is. Thanks.
This serves only demonstration purposes.  Should be extended before the next release.
A lot of these could be made shorter/more readable with ``map(self.to_user, ...)``.
`while (1) {`
add: 
require 'params'
LGTM, you can remove the comment
'', again :)
Should probably be renamed to `$revision_id` so it is clear what the variable holds.
Would you like me to mark all strings as strings, too?

Seriously though, it's obvious enough already?

```php
'delete_topic'    => array('DELETE_TOPIC', $auth->acl_get('m_delete', $forum_id)),
```
Why is this twice?
$result = $db->sql_query($sql);
, then?
+1 on "To change your password, your email address..."
Yes, should be 'SORRY_AUTH_TOPIC'. I don't like the "SORRY" in the language key, especially since it isn't in the language itself, but since you're just doing what was already done before, it'll be okay for consistency.
Well my last point still stands. the first part doesn't need double quotes.
I also added more Boolean value testing as well (now 3 tests for false and 3 for true),  hence the moving of the comment.  Change this as you'd like, though.
That might be cool.  For now I'm just moving things to a really really poor man's template using String.format()
In that case we wouldn't even need `case 'rad'`.  But `parseAngle('2whatever')` would return `2 (rad)`.  :(
well `read_until`'s easiest signature is to just match a single char.  i'm actually being a bit permissive here on purpose.  kestrel also doesn't exactly follow the spec here - it's to allow people to netcat in and run commands in os's that don't do the \r.
You could omit the `notifierToPatch` attribute and use `"$out"/bin/fsnotifier*` instead.
TODO should be linked to a bug #. commented code should be removed.
This is wrong. Might want it to be ```http://SciTools.github.com/iris``` anyway.
Yet more use of axis... (I think I wrote this bit in the first place). Getting the x and y coordinates is by far the biggest use case for "axis" usage. Is it worth looking into providing a more elegant solution?
This does get me past many of the errors, yes.
This is a great docstring, thanks!
интересно зачем здесь нужна переменная )
This feels like a lot of code to duplicate to add this test. Can you just add some extra tables to the existing testenv?
Indeed. I duplicated them to make the matches in `process_stream/3` less nesty. There's a comment in `pipe_mapreduce/5` about it.
To remove some indentation levels, I would format it this way:

```php
if ( ! isset($field['default'])) {
    return empty($field['notnull']) ? ' NULL' : '';
}

if ( ! isset($field['type'])) {
    return " DEFAULT '".$field['default']."'";
}

if (in_array((string) $field['type'], array('Integer', 'BigInteger', 'SmallInteger'))) {
    return " DEFAULT ".$field['default'];
}

if ((string) $field['type'] == 'DateTime' && $field['default'] == $this->getCurrentTimestampSQL()) {
    return " DEFAULT ".$this->getCurrentTimestampSQL();
}

if ((string) $field['type'] == 'Boolean') {
    return " DEFAULT '" . $this->convertBooleans($field['default']) . "'";
}

return " DEFAULT '".$field['default']."'";
```
Johan Tibell <notifications@github.com> writes:

>>  
>>  withJobLimit :: JobLimit -> IO a -> IO a
>>  withJobLimit (JobLimit sem) =
>> -  bracket_ (waitQSem sem) (signalQSem sem)
>> +  bracket_ takeJob putJob
>> +  where
>> +    takeJob = do n <- takeMVar sem
>
> What about asynchronous exceptions (e.g. if someone tries to kill this thread).
>
I suppose this is true. I'll try adding some exception safety.
You need to compare the entire TextNode text which according to your .vtt file would be some thing like "Test Space Escape character test: &nbp"
perhaps this should be 

```
offset = testEl.getBoundingClientRect();
```

that way we don't have to worry about the infinite loop at all.
This code kinda scare me, allowing traversal like this without a whitelist or blacklist feels like something that could get us into trouble.
Why does this need to return a 301 to the same page, instead of just continuing to render the page? Is it to switch from POST to GET? This is unclear to me.
You might be able to use mobility.middleware.USER_AGENTS which is a regex that includes the setting from settings and also the default agents.
FYI there is a trailing SP on this line.
Now that X11/XQuartz stuff are in MacOS::XQuartz (as of yesterday) this method is `MacOS::XQuartz.installed?`
What is this line checking?
desireable -> desirable
Jo ist auch net wichtig. Passt.
This shows the right column to be "FSS-B" but it is really FSS-A.  Just delete this line.
Please see my comment at the pull request level. You can add commits to this branch and they will appear in the pull request.
I think for Solr `Action.UPDATE` and `Action.ADD` should be the same. In fact, if you look at Solr, it only has UpdateRequestHandler, no AddRequestHandler, so `Action.UPDATE` should be the only supported operation, if any ;)
Don't need empty line.
Why not just ask for an options object? Especially if some of these terms are optional.

Also, `deviceType` isn't used—does it need to be?.
Sure, I commented it out just to make sure that it is indeed obsolete.
See my comment above. I don't think we want it for all types of attribute value hints.
It seems like the cursor movement/statusbar updating feels a little laggy on my 2012 macbook air. Especially when scrolling down by holding the down arrow. I tried using webkitRequestAnimationFrame but that only helped slightly. Are you seeing any issues?
- Why are you using Sync methods? Also in any case, there is no need to execute `existsSync` twice, it's a waste of resources. 
- Please put the path in its own variable to DRY.
There are two things wrong with this fix:
1) This function is in util because it is used for many elements. You have now hardcoded trFiles (which might not even exist) instead of using amlNode
2) More importantly. This is half a patch. It fails when there is only one node in a folder (after delete the parent should then be selected)
3) The actual bug is in apf. It should be fixed there.
we should document this better in the README...

we use [astyle](http://astyle.sourceforge.net/) on our C stuff, specifically this command line:

```
astyle --style=1tbs --lineend=linux --convert-tabs --preserve-date \
        --fill-empty-lines --pad-header --indent-switches           \
        --align-pointer=name --align-reference=name --pad-oper -n <file(s)>
```

the rest of your changes look fine, but this line would get the curly brace police all over it :)

also, we notably *dont* run `astyle` on code we've imported that isn't ours (like the md5/murmur files)
Should you join these fuckers?
The readme for the theme indicates that it only works in Emacs 24 or higher. We're about to support Emacs version requirements for recipes (#737), so once that is merged you should just have to add `:from-emacs-version 24` to the recipe file.
Fixed in b312cec thanks @sbrunner
應該用 relative 會比較好?!
Datum rojstva?
No, it is a very good practice to use external template. Really. This makes things more modular and easier to customize. You really do not want HTML in Python code. Python is done by programmers, HTML is done by designers. This is why we like MVC paradigm. It makes easier to split tasks. And also you do not need to give designers access to the code. You can be assured that they can break only design. :-)
You don't really need the above three scripts included do you?
Why border: none? Are iframes not set to border:none in the reset?
To make it easy on the eyes though, I'll certainly change it :).
I don't think this has a purpose here.
Same as above. This gets run once, and there aren't thousands of dialogs. Hot loop necessary?
Extra '/' here.
Perhaps that should be the name of this function. ;)
perhaps match on a return so we don't continue if drop fails?
do we need this commented code ?
What about the time out so it doesn't get into an infinite loop?
The same thing applies in other places too.
void
ngx_minheap4_insert(...)
Entä jos nämä ovat tyhjiä merkkijonoja?
Needed ? <code>props.match(/url\((['"]?)(.*)\1\)/)[2];</code> to match url(sprite.png)
There is no tag in the repo. From the [README](https://github.com/CocoaPods/Specs/blob/master/README.md):

If the library, that you are creating a specification for, does not yet have any tagged versions in its repo, then it’s best to start with the lowest version ‘0.0.1’, which will ensure that once the author does add tagged versions they will be equal or higher than ‘0.0.1’. It is your responsibility to ask the author of the library to tag versions, luckily we have [a template](https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template) for this.
why pull this out to its own method?  is it used elsewhere?
hmm, interesting.  Will have a think how to handle that.

On Tue, Jul 10, 2012 at 5:40 PM, Jeremy Stanley <
reply@reply.github.com
> wrote:

> > +   * the response is finished.  It also hooks into 'Set-Cookie' to
> ensure that the
> > +   * cache headers have already been set appropriately.
> > +   *
> > +   * Responses should have an explicit cache policy set and no cookies
> should be
> > +   * sent on a response that is publically cacheable.
> > +   *
> > +   * @private
> > +   */
> > +  function _hookRequestResponse(req, res) {
> > +    var writeHead = res.writeHead
> > +    var setHeader = res.setHeader
> > +    var end = res.end
> > +
> > +    var allHeaders = {}
> > +
> > +    res.writeHead = function (status, reason, headers) {
>
> might want to factor in case-insensitivity
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Obvious/matador/pull/85/files#r1137217
>
Is this the only place where you need this check?
I like having the current axes as default, but this should be `ax=None` in the parameter list, with a check for `None` below.  Mutable default parameters can cause unexpected problems...
I don't think there's a need for the `if` clause above.  Just try `to` and let the exception bubble out.  That will let us provide the "nice" error messages for units everywhere.
Maybe this should be named something to make it clear that this formula is typically a bad choice for astronomers.  To me this looks like the astropy coords default function for computing spherical distance since it has a generic name (unlike the others).  

Perhaps the `sphere_dist` function can be a wrapper function that calls `haversin_dist_atan` or maybe `vicenty_dist`.  Then if people are worried about performance they can choose other methods.
I wonder if we should leave the default value out completely. Users shouldn't be playing with this setting at all.
ok, i will work on that now.
Sold. I'll try to get something running tomorrow.
I disagree. The whole point of Validation is to sport relying on Exceptions.
Isn't `(prefixes s :min-length x)` just `(drop x (reductions conj [] s))`?
Ik zou hier ook weer -whatever bijplaatsen, om custom php builds te supporten (of anders misschien geen STATUS_ERROR maar STATUS_WARNING smijten, da ge niet kunt geranderen dat fork perfect zal runnen op hun PHP_VERSION, maar ze toch kunnen installeren op hun build)
Maybe call this class `notification_widget`.  It was a bit confusing to me at first to have the different notification classes.
I've never used gevent - is this standard? What is it monkey patching? Can we have a comment explaining it? Thanks.
Cython does not use a `~/.cython` directory at the moment, but what about if it did in the future?  Maybe we should stay within our namespace by using something like `~/.ipy_cython_magic`?
Careful with brackets here - you're doing `glob((a) or [a])`, but it should be `glob(a) or [a]`.
Ah, cool  i'll update magic_save too then.
Brian E. Granger [notifications@github.com] wrote:
> In IPython/core/pylabtools.py:
> 
> > @@ -97,10 +97,22 @@ def print_figure(fig, fmt='png'):
> >
> >      fc = fig.get_facecolor()
> >      ec = fig.get_edgecolor()
> > -    bytes_io = BytesIO()
> > -    fig.canvas.print_figure(bytes_io, format=fmt, bbox_inches='tight',
> > -                            facecolor=fc, edgecolor=ec)
> > -    data = bytes_io.getvalue()
> > +    original_axes_colors = []
> 
> Can you comment on the purpose of this change?

As described in the PR, I believe this is related to making PNG's and SVG's
transparent.
This would make CMake consider `src/compat/fnmatch.h` as a source file, instead of just the C files.
Change this to `os_error` to avoid confusion.
The `define` with the defaults makes my spider sense tingle. Instead: set the default automatically when any of the options is 0. Also, the indexer stats should be outside of the options struct so they can always be made optional. :+1:

~~~~
int git_checkout_index(git_repository *repo, git_checkout_opts *opts, git_indexer_stats *stats);
~~~~
We have a `p_snprintf` that is not beyond-braindamaged under Windows. We need to use it here and everywhere else.
Wouldn't this launch b2g in gdbserver with profiling enabled?  Why would we want to do that?

Is there a separate pull request coming that adds a run-profiler.sh script or something like that?
sweet! +1
This was for filtering the search result suggestions to only articles of that product. Do we want to dump it?
negative values and lack of parameter checking are the same thing; the params should never be negative. I agree with you, though in general I think we don't parameter check well.

endTime should be now + timeout, strictly. If I say I mean it to end in 5 secs, I don't mean 5 secs + the repeat interval.

But see below.
Could you provide some guidance here? If I take this out of the method scope I am no longer able to retrieve the screenshotPath. No errors, but the screenshot is saved in the temporary directory.
the simpler way to calculate the length of an iterator is to list it.

```python
self.assertEqual(len(list(ooid_source)), 5)
```
Do we not have any integration tests at all? I think this is quite important.
All of this...
i tried but it show me the original one and not the one i edited before...i'm new on github...
You need to change the autoescaping to the ``js`` context. It does not make sense to escape with the ``html`` context here
you can factorize the checks
Ok, I get it that the and as less precedence than the && and if I try:

$buf = 1;
$val = ($buf += 2 && $buf += 2);
$val is false

and

$buf = 1;
$val = ($buf += 2 and $buf += 2);
$val is true

Am I right?
If they are not delimited then you can not guess the htmlPattern.

PHP: the pattern `/foo/` matches both `foo` and `beforefooafter`,
HTML5: the pattern `foo` matches only `foo`, not `beforefooafter` (which is what is detailed in the linked doc).
What do you mean? It's not the firewall that is going to use the handlers but the authentication listeners. By using as the firewall id here it causes to redefine the handlers multiple times. If the correct behavior is to have a single handler per firewall I think it should be injected by the SecurityExtension instead.
Hm since most people simply check for Boolean with `if ($absolute)` it would also evaluate to true for the string values. So this change might not worth it, as people who implemented their own generator need to be aware of the new values anyway.
`StubIntlDateFormatter::setTimeZoneId()` already does this but using `date_default_timezone_get()`. It's the right point to change.
2 is a reserved error (misuse of shell builtins). For user-defined errors, you must use exist codes in the range of 64 - 113. But as we are not using those anywhere else, what about just using exceptions?
This code probably is redundant with [testDirectory](https://github.com/symfony/symfony/pull/4056/files#L2R26) and [testUnreadableFile](https://github.com/symfony/symfony/pull/4056/files#L2R33).

Should I remove it?
Remove extra spaces before and after the exclamation point.
There are an awful lot of these magical layout constants in the codebase. 
Consider exposing the the parent view the from/to fields are sitting in and replacing with:

quietTime ? fromToView.frame.origin.y + fromToView.frame.size.height : fromToView.frame.origin.y;

This eliminates a dependency should someone make another layout change.
http://blog.moertel.com/articles/2007/02/07/ruby-1-9-gets-handy-new-method-object-tap
新pull了，应该没有这些错误了。
Das clone ist wichtig, da sonst alle Trainingseinheiten die selbe Objekt-Referenz enthalten. Fuer jeden Durchlauf wird dann fuer ALLE Trainings das Datum um einen Tag erhoeht. Und am Ende bekommen alle den letzten Tag der Woche. Als noch nach jedem Durchlauf ein flush() gemacht wurde, ist das nicht aufgefallen, weil die abgeschlossenen Durchlaeufe zwar auch noch (faelschlicherweise) veraendert wurden, aber halt nicht mehr an die Datenbank geschickt.
Not sure what action to take on this. Any advice?
Pretty sure createInventory sets the inventory immediately afterwards...was there an issue with this?
It run_list is `None` in either case you will get an exception
We usually follow the "Should ... when ..." convention, that is:
"Should return a 404 when requested plugin does not exist"
@wagenet I can't find any reference to Ember using the view's `target` property in the code

From https://github.com/emberjs/ember.js/blob/master/packages/ember-handlebars/lib/helpers/action.js#L263-L267
```js
  if (hash.target) {
    target = getPath(this, hash.target, options);
  } else if (controller = options.data.keywords.controller) {
    target = get(controller, 'target');
  }
```
@daanporon disagree for app_ because it's possible to have multiple front controller named like i want eg (frontend backend api or app)
@nfrp I was referring to the versions mentioned.
We are not allowed to modify a released XSD (alpha/beta releases don't count). You need to create a 1.3 xsd, copy the parser, and make the corresponding changes to the new XSD.
convenience?
Any reason to prefer this over pow(2, floor(log2(ma, 2))) ?
Expect us :)


_(will fix)_
Remenber that ESCAPE is only a second class citizen. You need to handle HOME too.
\o/ oh yeah good catch
please drop the async_storage lib (and the comment) and defer the icc_menu.js one.
ok, sorry it belongs to other prs, deleting
Oh, my bad. Fixing.
Remove L74 - L76... you don't need them and they are useless.
Started, with 1 actually. I noticed a difference in behavior. I think its actually 4 these days.
Mmm, that is ok for me, we will have our main buttons in buttons.css and these ones in buttons_lists.css or do you suggest any other name?
Thx!
Typo: getHighlitedName -> getHighlightedName
Should I remove from 1271 to 1275 then? Is the contact automatically reloaded on mozvisibility?
Indent this block, please.
Same comment as above about the fact that you don't need the intermediate |settings| variable.
I'm just a bit worried by the poking around in the internals of participant. Maybe `participant` needs `.batch_completed()` and `.poll_completed()` functions?
This just splits off everything before the first command. If #order! does that also then the results are the same.
Would it be better to throw here?
Why do we have data in game logic?
Yes, that would be perferred....maybe something like:

``` ruby
status = if $!.nil?
  0
elsif $!.kind_of?(SystemExit)
  $!.status
end
```
Passing this up will make AppScale unstable. I will remove the print.
you should send him a PR with a composer.json so that it gets registered on Packagist :)
Solved in https://github.com/SpoutDev/SpoutAPI/pull/416 & https://github.com/SpoutDev/Spout/pull/2071
Since you fixed it in CCDictionary, please ignore the patch. Thanks.
Please don't change this submodule address.
Yeah I'm all for never aligning except when it's long lists in arrays or such. The alignment wasn't mine. I just added the other line, anyway will fix in next push.
why don't you add it in last place to preserve BC ?
what is the goal of extending the class with only private methods ? you will never be able to use them
Not generic enough to be added to the config. It has to be agnostic of the project we are working on. You can either use iTerm default directory, or add that to your
Improving your testing skills is always a good thing.. that's one of my weak points too, but contributing to a project like this will definitely help. :grin:
In general if you don't use them in the controller they should go to app/helpers/ ;)
Yeah it's slightly confusing. The links are no longer remote; the new JS code captures the click, pushes the history state and returns false so the click doesn't go through. Then because of the History change, `statechange` is called and we fetch the last URL via Ajax and update the page.
Edition is already a JS variable on the page.
Nice one. :) I've changed it (also in ```convertes/base.py```).
resource://gre/modules/toolkit/foo.js -> resource://gre/modules/foo.js
recommend -> recommended
You need to add the nondestructive mark for this test: 
@pytest.mark.nondestructive
I've seen this mark is not used in other tests, is this intended or why is that?
adding a %{which git} here wouldn't hurt, in case the user has rsynced a git tree over or something.
change this line to:

```js
var self = e ? $(e.currentTarget)[this.type](this._options).data(this.type) : this
```
"/etc/localtime" looks like a constant (used also in tests)

size(localtime_path) also looks like a constant
Thanks. Fixed, will show up in next push.
I added this out of convenience, so you wouldn't have to check if it exists and create a new instance manually  then add to Headers.
This can be simply:
```
if (!$events) {
```
getSharedManager() can return either null, false, or a SharedEventManagerInterface instance.
There's a lot of code here that seems identical to the code in prepareStatement(). Is there any benefit of refactoring out the commonality to a shared method?
Cached the return value of array_keys in a local variable to avoid loop twice along $fields
We should keep the logic in this conditional; otherwise we break all backwards compatibility for the helper. Do the following:

- If the model is a scalar, reset it to an empty array
- If the model is a non-ModelInterface, non-View\Variables object, do the logic in the "elseif (is_object($model))" conditional, and capture the results to a variable

Then pass the model as an argument to render() (which you already do).
it's T-Shirt.
Calling getError in a draw function. Do we really want to propogate discouraged practices in samples on the khornos site?
afaik i cant check $_GET["errmsg"] != "" before I tested ( $_GET["errmsg"] wthout triggering a STRICT error
I ll never reach the second if if $_GET["errmsg" is not defined
if its going to take a long time fuck it, but if its easy run with it.
Instead of dropping the `if` block entirely, it should probably be changed to `if (($class = get_called_class()) === __CLASS__) {`.
From the App Spec:

Components should be split up into separate files and placed into folders where it makes the most sense.

Example:

js
├── app.js
├── controllers
│   └── todos.js
└── models
    └── todo.js
I took the compression out because Symas disabled compression.  As a side note, I originally had all these changes in a version called db_bench_wtsymas.cc instead, to keep the symas version of the benchmark separate from just a port of the benchmark itself to WT.  I could go back to that.

Compression was working, with the name change shown above, prior to the symas-related changes.
Rather than removing it completely, you might want to redirect the other way; that is, if they request `index.html`, point to the template-rendered resource instead.
let's keep it to be future-proof. it does not hurt to check it properly.
The style of the casting here should be" (process_data_t)&window".
Some stuff just so the saucelab video is recording the bottom of the screen.
alright, I'll add check in
@harjis t-funkkarit pitäisi olla läpi linjan.
@vesak Kenties näin: Tuoteperheiden lapsituotteille lasketaan asiakashinta ja -alennus.
This can actually bring to problems when Bundles/Modules define same native queries (`allUsers`?). I guess there's no solution for that :S
Yes, it can be turned off, but the way it's implemented the code is still being evaluated, which massively slows down the processing.

The correct way to do the debug call is to stuff the debug content into a block so that it can be deferred until the method yields it.
docstring, also for suite()
take care that ``$config['target_path_parameter']`` may not exist as it has no default value
s/checks/Checks/ and add punctuation. (Yes, I'm a language/grammar Nazi).
I think we should still mention --embed-file and -preload-file in emcc, since lazy loading will only work in workers (should mention that here).
Can you please make that modification then and i'll pull the request.

    With most CMSs everything...
Currently teardown always exists. We create it if it does not.

We do this because we want to call end on all track events if they are running when the teardown is called. So, we extend the function.

Although, this might still be better moved. I'll look into it.
I'm going to agree here; I thought that Popcorn.defineProperty was something that already existed. We known that Object.defineProperty is already supported in all of the browsers we currently support
This happens when you hit the cancel button on the form.  If you're "sure" you want to cancel, it's a submit/redirect.  If you're not sure, you stay on the form to continue editing or whatnot (i.e., you hit cancel by accident).
The cache key would have to be different for each possible parseOptions probably ... likely best to just not cache, except for the no-options load().
You're right. This is a bug.
For testing you can remove if(m_bIsAllocated) and its block at the beginning of Initialize(), I doubt it's really needed anyway 'cause WASAPI would return an error if we tried.
Tabs on this line as well...
I'm wondering if this should be kept private, and to add a `protected final Logger logger()` method (or even `getLogger()` method; whatever you think) to provide access to subclasses. Since it's not a final field, an implementation could technically change the reference. WDYT?
Sounds good. It works for things like `git` and `path`, but not for `site` or `(blank, use default site)`
Can't this be done better with a `System.Collections.Generics.Stack<T>`?
Two o's are unnecessary. This will save hundreds of developer hours in the future.
Previously ccm_arrangeMode was boolean, now it's:
0: not in arrange mode
1: in normal (single) arrange mode
2: in multi arrange mode (the new mode!)
это дольше существенн, чем удалять итератор.
давай попробуем удалять все-таки итератор, но без той ошибки
Hello David,
I just wanted to differentiate the N, but there is no problem with erasing the underbars.

Regards
Victor
You mean something like Ruby on Rails :unauthorized ? Because I don't know if Sinatra has this kind of feature.
Haha, I'll agree it's a bit wordy.

How about

"Now create a new instance of AutoComplete componen by setting `contentBox` to our HTML element's selector. Also, we should populate some suggestions by adding a simple JavaScript array to `dataSource`. Finally, let's render it!"
I don't particularly mind this. At the very least, it shortcircuits a conversion to string, which is probably for the best.
We do this in four other places so I was going for consistency.
`const` will blow up in old, crappy browsers...
as discussed, there's no real need to document things that are very obvious, so i wouldn't have bothered here
thanks, changed
Now I am become regex, the destroyer of codes.
we should use the isResourceId validator here.
Might be worth adding here who can see the comments (everyone with access to the content)
Aus Konsistenzgründen bitte Tabs statt Spaces und https nutzen.
This change does not filter anything, so `listLike` is (or not) in the list just as before. I just tweaked the relevance. Of course, I could test that it's not in there, if that's what the existing completion engine does, but I'm not sure.
This has been changed by your PR, so it does relate to your work.
Actually, I'm no longer of the idea we should have a timeout here (so, yes, I should fix the comment).

The reason is that the list of ``futures`` is executing blocking calls on potentially any actor, hence it's hard to forseen how much time it is ok to wait to get an answer. I'll be thinking about how to fix this, let me know if you have any idea.
Changes look good overall. Trying to understand why we make a read() after, clientRequest has been marked complete (setting to null happens there)
The template name is the file name in the mailer views.
Sorry to bounce it back again, but this method doesn't exist. `_minify_script_style()` maybe?
Да, вы правы.. Исправлю.
В лекции было сделано именно так, посему и решил что это все таки не bad practice.
Нет, так как он уже подключен в файле категории. Файл подключается только один раз.
I fixed both commands. Without this patch.
вместо этого всего можно просто написать

    self.tags << arr.map {|el| Tag.find_or_initialize_by_name(el.to_s)}
Why not assume JSONP unless `cors: true` is specified as described here https://github.com/aerogear/aerogear-js/pull/8#issuecomment-10568305
var is sufficient on all these completer declarations I think.
Yes makes sense, especially as you return the scores.
This makes it even more easy and prevents 'over-logicing' it.
(comments below).

+1 for the associated proposals

2012/10/28 Alexandre Gramfort <notifications@github.com>

> In examples/preprocessing/find_ica_sources.py:
>
> > +# setup reasonable time window for inspection
> > +start_plot, stop_plot = raw.time_as_index([100, 103])
> > +
> > +# plot components
> > +ica.plot_sources_raw(raw, start=start_plot, stop=stop_plot)
> > +
> > +from scipy.stats import pearsonr
> > +
> > +#  create function that iteratively applies the pearson correlation
> > +#  to sources the sources and returns and array of r values
> > +corr_r = lambda x, y: np.array([pearsonr(a, y.ravel()) for a in x])[:, 0]
> > +
> > +# get source with maximum absolute correlation to the ecg signal
> > +# as we don't have an
> > +source_idx = ica.find_sources_raw(raw, target='MEG 1531', score_func=corr_r,
> > +                              criterion='max')
>
> I think we should return both indices and scores.
>
> and I would rename criterion to select_mode = 'all' | 'max'
>
> one might want to remove the sources for which corr > 0.9 ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1960917>.
>
>
you have it twice
collapse is not standard numpy naming. Do you mean concatenate?
data.fill(0.) is faster
be careful with Bunch object as funky stuff can happen when you modify then and rely on deepcopy. If you know the attributes it's much better to use a namedtuple
Should this uses `try/except self.get_model().DoesNotExist`? Or let the error bubble up?
Ah! ok
Should the pipe() happens after on("end") below?  The point is in Async it should not matter; however in Sync (properly not support by node), one might miss the end call.

  readStream.on("end", deffered.resolve);
  readStream.pipe(writeStream);
  readStream.on("error", deffered.reject);
  readStream.on("error", deffered.reject);
There should be a way to use `EnumMap` for all of these and still have it work with JMX.
Can implement `ActionRoute` in terms of `Reader`;  explicit `Monoid` instance will not be needed
@Seldaek I think that the test classes should never be filtered out. The are an integral part of the software and they documentation purposes are great. But I guess that's not the place nor the time to discuss it.
Hmm, this one is harder :). How about:

> Since the best way to learn is to see an example, start by securing your application with HTTP Basic authentication.
Why is it indented ?
You are right.. let me fix this! Thanks
Like you can talk ;)
I think it should work like this... piping colors to a file doesn't make sense.
didn't get the problem... If you have `prompt('enter something')` in your code, you get what the user typed because there is no default, especially if he types nothing your get an empty string.
When you have `prompt('enter something', 'default value')` you get the 'default value' if he types nothing.
Btw: When we call that function without the default value, we already know that we did not add that parameter. :)
Няша-няша-няша-ня.
Espacio antes de (bug).
"za sekundę"
You don't need the instance variables or the multiply variable. This method could just be:
```ruby
def multiply(number1, number2)
  number1*number2
end
```
please bind a route name
Check colorspace
Better to call the designated initializer:

```objective-j
self = [self initByReferencingFile:@"" size:CGSizeMake(-1, -1)];
```
Can you add one more test and make sure it passes:

    assert_nothing_raised Sass::SyntaxError do
      evaluate("font-files('/font/name.svg?mightbedynamic=true#fontId')")
    end
oops fixed !
No, that's correct. '@{upstream}' is a syntax that git understands to be the upstream of the current branch. Perhaps you don't have an upstream set?
for now lets remove root from this list and _only_ put os_admin on it.
One future per cluster or one future per node?

I think it would have been interesting to have DistributedTask implement Future as well, so the user can get() all the results at once or cancel() the task on all the nodes.
testName ?
"I agree it might fail, but how are you gonna trace this when it fails when running the paralell testsuite and you're having to go back and figure out which thread printed this? Or at which time exactly?" <-- okay, let me explain a bit how I used and plan to use this flag in the future. I've run the ConcurrentOperationsTest only for about 2 days to fix various race conditions in the concurrent operation code.  By having stuff printed at the console I could look directly into the relevant area in the log file (quite a big one as you might expect from a stress test) vs. scanning the entire log file to see where the failure was etc. Of course this can be achieved by adding a new category for this class in a log4j .xml file and making this category log to console. But when I'll see this test fail, I know I can just edit one line in it, and get early debug information. I'm quite familiar with log4j configuration, and I would definitely not use this approach in any production code, but in the cope of a test suite I really don't see any problem with this approach.
"Got" ??
Is this meant to stay? It looks like temporary debugging code.. but useful; I'd add it to the Logger interface with a proper error message.
As above, we should remove the declaration here (after fixing whatever warning requires it).
Do you want me to fix this variable name ? I'm not sure what it corresponds to, so I'm not sure what a good variable name is for it.
<3 I'll remedy this right-quick
The capitalization is incorrect for a constant, it should be all caps (i.e. _FILE).
This is more of a mental note for the UI, not the admin pages.
`boolean` is a technical term -- use `@tech` to reference it.
Seems like this was only still visible in the comments but not the code.

Chiyuan Zhang <notifications@github.com> wrote:

>> @@ -4,7 +4,7 @@ VALGRINDOPTS=--tool=memcheck --error-limit=no
>--trace-children=yes --leak-check=
>>  
>>  INCLUDES=-I/usr/include/atlas
>>  LIBS=
>> -LIBS_ADD=-lshogun
>> +LIBS_ADD=-lshogun -lpthread
>
>Oh, sorry. I remember I fixed this, no idea why it is still there.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/shogun-toolbox/shogun/pull/679/files#r1328760

-- 
Sent from Kaiten Mail. Please excuse my brevity.
How'd that become public? That should be private :)
The condition variable is used to wake up the cache pool server so that it can quickly give cache to a new connection.

It's also used to ensure timely shutdown on close.
Why do you remove the assert? Are you running into a situation where the group name and node name are so long that they don't fit inside USHRT_MAX?
Are you sure that you can pass ``$this->options...SaveOptions()`` to ``array_replace()`` as the parameter ``$array`` expects a reference?
>
> Could you please inform me about the naming-convention for bundles, bodies, classes and vars? I didn't find clear guidelines for it. The only thing I've found was the last point mentioned in the Sketch coding guidelines, which says "...prefix them with a unique string...", which is pretty vague.


Dear Sil,

  identifiers in cfengine 3 can consist of alphanumerics and underscores.

Yours,
Aleksey
I will try and test that, though this happens the same if I was running cfengine from the console with -K iirc.
in the situation where 'data' might be null or returns in error, we should capture that so that the rest of the code doesn't puke if it doesn't match.
I'd leave this one around. Since we don't catch the RuntimeException that could be thrown by JDatabaseDriver::getInstance() it would look from the outside like it throws a RuntimeException. The other alternative would be to catch & rethrow the exception.
I think there should be a filter option too - like get method has.
please don't use short open tags. They are deprecated
@squarefrog what exactly are you trying to pas in as a parameter? Can't you convert it to a string before adding it to the parameters dictionary?
## Introdução
This is the text of a cell to send the user to the iTunes App Store review page
Just go ahead and get rid of it completely, don't leave it in there commented out.
Wow that's a lot of browser specific hacks.
Oh okay, I thought that patch was already in. :-)
The configuration options have been removed as now RSpec parses the `.rspec` file in the project's root. `spec.opts` has been renamed
Lower case please.
Wouldn't it be better to use `choices` for this? So to provide only fixed set of possible types.
No need for `:`. And it is obvious that it is a list. So just "Contributors". :-)
No, we do not need that.
@dkubb yeah use a different word so that people won't be confusing it with AS :)
No. I'll add docstrings describing the intended semantics of the two reply methods.
```php
$modelClass = $this->class;
$validatorChain = $this->class::getSchema()...
```
Sure thing. Will do.
@dscataglini: So it turns out this fails in timezones other than US Eastern; see http://travis-ci.org/#!/Shopify/active_merchant/jobs/1000594/L92

Any ideas on a fix? The tricky part is that ```Date#to_time``` always uses the local timezone, so it seems we either have to make the underlying code not use that method (using something that consistently converts to UTC) or else make the test dynamically take time zone into account.
use break;
def get_form(self, post_data):
Add space before and after else.
_split_ is going to compile a regular expression.
Could you extract the regular expression in a constant, so that we reuse it ?
`event_handlers`
More idiomatic:

```c
ngx_str_set(&x_pagespeed->key, kPageSpeedHeader);
ngx_str_set(&x_pagespeed->value, MOD_PAGESPEED_VERSION_STRING);
```
Use StrAppend.
Same here, i recommend to put this on `.gitignore`
Sorry, you mean that for the key 'bookid', it will always be an int? In that instance, you could do:

```python
for key in keys:
    val = getattr(book, key)
    if hasattr(val, 'decode'):  # e.g., is a str, unicode, bytes, etc. object
        val = val.decode('utf-8')
    metadata[unicode(key)] = val
```

I'm not sure I understand your comment entirely though.
I've noticed this. Another solution, which I mentioned in one of my comments in the pull request, is to re-cache when users changes their `.zshrc`. Are you talking about turning off completion after zsh starts up or turning completion off in `.zshrc`? Is there a way to turn off completion after it's on? As much as I like to keep fasd self-contained in one file, maybe providing extra files for zsh could be a better solution. I'll look into it.
Cool, thanks for the tips! My rails work is pretty crude. I added your suggested syntax and bumped the version #. I'm getting failed build notifications, but that stuff is a bit beyond me to be honest. Needs tests?

	Cheers,
	Tristan
________________________________________________________

Tristan Kromer 
  Business Model Canvas for User Experience

i@mNotaNinja.com 
i@mNotaRockstar.com 
+1 (415) 412-6438
                     
________________________________________________________

On Nov 30, 2012, at 7:41 AM, miles <notifications@github.com> wrote:

> In lib/omniauth/strategies/meetup.rb:
> 
> > @@ -21,7 +21,10 @@ def request_phase
> >          {
> >            :id => raw_info['id'],
> >            :name => raw_info['name'],
> > -          :photo_url => (raw_info['photo'].present? ? raw_info['photo']['photo_link'] : nil)
> > +          :photo_url => (raw_info['photo'].present? ? raw_info['photo']['photo_link'] : nil),
> > +          :urls => { 'public_profile' => raw_info['link'] },
> > +          :description => (raw_info['bio']),
> > +          :location => (raw_info['city'] + "#{ if !raw_info['state'].blank? then ', ' + raw_info['state'] end }, " + raw_info['country'])
> cool. thanks very much for this!!
> 
> yeh, maybe could be a little cleaner if you do something like this for location?
> 
>   [raw_info['city'], raw_info['state'], raw_info['country']].reject(&:blank?).join(', ')
> or even
> 
>   raw_info.slice('city', 'state', 'country').values.reject(&:blank?).join(', ')
> —
> Reply to this email directly or view it on GitHub.
> 
>
oops thanks, not sure what I was thinking here
What is `w`? Please use variable names which make code easier to read, not more cryptic.
Yeah I think scoping to the view / form / something is a good idea.
Isn't this done? (or at least the optional setting via kwarg)
Wouldn't it be clearer to just write:
```
if filetype.upper() is "FITS":
    ...
elif filtype.upper() is "ASCII":
    ...
else:
    ...
```
NP, will do it tonight when I add the lensing engine stuff.
This link actually goes to the landing page on OneProsper, instead of a direct link to YouTube. This is so that if the friend chooses to donate, they can do so right there, and correct campaign tracking data will be in the URL.
You're right, it doesn't. That was stupid.
I just did a quick test to see what would happen with closures as call backs. They work fine, so perhaps "function_name" is not a good name as argument? I'd suggest we change that!
you should use simple quotes around the string
In case subject.json is not present or broken (for example the first time you run it) the .bak file is used... Should I rename it?
This is something I tried to tackle (and failed) on the error rewrite. Besides switching the return value to a `bool`, I don't quite like the idea of `_check_dir_contents` having an `append_if_exists` flag. I understand it's a common use case and this prevents us from building the string twice (once for the check, and a second time if we want to keep it), but it strikes me as unnatural... Can you help me come up with something different?
Error at this line:
Messages.create_message
does not exist. It is createMessage
Please test throughly before committing.
brackets after if statements
events on load
uhhh... we probably have this all over from what we inherited... I'm pretty sure this is a giant gaping SQL exploit:
![bobby tables](http://imgs.xkcd.com/comics/exploits_of_a_mom.png)
maybe we should explain my shit somewhere :) in the readme for example or phpdoc. 
To explain that `e:` is the entity alias in the query
Copyrights need updating
Not sure about the annotation, instead of having some "getAuthToken" to an internal only API.

I guess I am not -1 on the annotation usage :) , but -0 ;-)
Should this be bracketed more? e.g.

```javascript
var NS4 = ((navigator.appName == "Netscape") && (parseInt(navigator.appVersion) < 5));
```

And should parseInt have it's base set when it's used?

```javascript
parseInt(navigator.appVersion, 10)
```

Also, should we be using browser detection scripts at all or rely on feature detection?
Woo hoo

Galaxy::CardLink#link sends PUT to /card_links/:id/link.json
     Failure/Error: cl.linked.should eq true
     NoMethodError:
       undefined method `linked' for nil:NilClass
classExample.equals(Boolean.class)
В открытом пул реквесте я написал так как я понял. Если я неправильно понял, напишите туда.
Это лишнее. Надо просто у method смотреть в getDeclaringClass()
@shacker does every single user has to do this?
It would more appropriate to add button to the name:
_back_button_locator
on Addon-Tests I just added an explicit wait to this function. It's an ajax popup here so sometimes was a bit flaky
thanks. 「データベースの接続なしに」は上とあわせて「データベースを必要とせずに」にして

    ドメインクラスとしての振る舞いは@DomainClassUnitTestMixin@を使用することで、データベースを必要とせずにテストを行うことができます。この実装はGORMの振る舞いを擬似した、メモリ上の@ConcurrentHashMap@です。この実装は実際のGORMの動作と比べて制限があることに注意してください。以下のHibernateに対するGORMの機能はIntegrationテストでのみテストできます。

とします。
there's socket code in /lib/platform. could you please use that instead
right they aren't even passed? then we can just pass the correct one right away.
Also blows up without a client, should clients perhaps be mandatory or default 'internal' or whatever?
Yep, done
Good point. Docstring coming tonight.
what is epsilon ? It doesn't appear in the docstring
I think adding `y=None` to all unsupervised model with a transform method was required when used in the early stages of a pipeline. AFAIK we never had a use case for unsupervised grid search in the past hence it was never addressed explicitly.
> The ever_active_set is also needed in the basic use case (Simple, one alpha fit with ElasticNet)

Why? I don't understand. All we need is to learn the coefficients.
I should be named `X_``

everything that is estimated from the data should end with ``_``
+1 for making then effort to use meaningful english names when possible.
```
norm_ones  = np.empty((n_samples, 1))
norm_ones.fill(1. / n_samples)
```
whoops sorry, forked from wrong branch. just a sec.
I'm not sure about it. it will not add the maxOccurs for the spool and antiflood anymore
Also, if you are going to have D_ILP32, you need D_LLP64 too to accommodate for Windows 32bit systems too.
Should this use container_?
Don't remove this line, it's useful for debugging
Looks like a missing test here.
Not sure how or why that got in there. Removing, thanks.
When does that happen exactly?
See here: http://stackoverflow.com/questions/563045/can-someone-explain-this-definition-of-the-dirent-struct-in-solaris
d_name on Solaris is declared as char[1]

Although I may not need the + 1. And the memcpy below could possibly just be a strcpy?
I avoid multiple assignments.  Possibly ok in initializers, but here I think you are obscuring what the code is doing.  It probably depends how used to the idiom you are.

Here it should more logically  say 

lastGood = cur = cur+matchLen;

but two lines I think is clearer.

in fact it is confusing to update lastGood until after the subsequent match.
Decimal types use _ as the separator.
You don't need !superfile here, we also want to add sub-files when the super already exists... ;)
yes, probably better as a separate commit

maxlength (whether fixed or variable ) - is now passed in to the builder, and will ultimately be set into the header as keyLen
But in variable case, it could just use the abs. max regardless internally.
There shouldn't be implications on read (in OSS), if a row exceeded keyLen (as it should effectively only relate to legacy maxlength).
But need to make sure there aren't any max sizes buffers, where it isn't correctly deserializing the key and expanding to whatever variable size is actually there.
Either no need for the test on record, or should return NULL immediately.  Rest of function assumes it is non null.
just do `api = models.CurrentProducts()`
What's this import for?
I think this calls for some refactoring. hint hint; helpers.py :)
if you wanted to make a generic ThreadStorage class why you support to store only two levels of nested attributes?
я казав спробувати. в цьому PR давай без нього
Sure. I had been avoiding typedefs for our structs, but I am happy to switch to typedefs if we wanna go that way.  I'll add a commit for this.
it's no unheard of for a cdn to throw a redirect to the "actual" url. You might want to change this to r.status_code < 400.
I would pass a parameter instead having two methods doing the same