labofsahil/github-event-dataset-2012 huggingface dataset:
I see. 
Maybe We should not define any ctor of subclass in tests. So, it will be compatible with JSB and html5. 
I have tested the code, and it works so well. I will merge it soon.
@yuhunglin Could we at least do a `console.log` here & in all the other error functions?

FYI if you look at `plugins.js` we make sure that method exists.
OK - Seems counterintuitive but there it is in black and white!
It would be good to review any uses of -1 in this code.  We shouldn't have to do this test, just check for isValid() (where 0 is the internal representation of invalid), and make sure no one is using -1 as an 'invalid' value.
No, it should stay exactly as it is.
well, if it is a case not supported by the TreeWalker, it should indeed throw an exception instead of a notice
kh kh kh
In general, when returning collections, if something's not found you should return an empty collection, not null, so return Enumerable.Empty<RoleSettings>() instead. Makes it a lot easier on the callers.
This entire paragraph is untrue on mobile web. For us, we don't have a notion of "top-level" controls, outside of convention. A window can be added to a view without anyone complaining (in fact, windows are just views with a few extra methods).

That said, I'm not exactly sure if we should mention this in the docs, otherwise we might give developers bad ideas :). Thoughts?
I still don't agree because it uses less memory, executes faster, is more readable, and doesn't have any drawbacks compared to the current syntax (they produce literally the exact same object, minus some slight prototype differences), but I'll let it go. For the record, I did not sign off on the original hub, and if I had, I would have brought this up then.
ok. Accepting PR then
Why are we ignoring a NullPointer? If something is going to throw a null pointer exception, we shouldn't even try to call it imo.
If the mime type is application/*, image/*, video/*, or audio/*, it's binary. I track it with the _isBinary flag.
yep, wondering if the application should really continue to work if that is not properly set. Most commands should not work if the file system was not properly initialized
What does this do?
Is this statefull in modules?
lets refactor Category.path() to return root_url + ....
Include the function's name in the error message.
Errr... I might be over analyzing, but just in case:

I apologize if my comments have made it seem as if the contribution is not appreciated - it IS appreciated.

You *did* asked for a review, so that's what the comments are.

We could merge this "as is" and do further changes ourselves, or you could make them over on your fork, so we could *then* merge the version that has the changes. If you can do the latter, that would be most awesome (=\> best for the users of PhpDocumentor2), but it's not a requirement, and your contribution is welcomed either way.
Hmmm, "usage" twice in the same sentence to mean different things... I didn't catch that in my earlier suggestion.  Perhaps these two edits:

s/are two usages of/are two use cases for/

s/definition and usage/_definition_ of the global variable, and _usage_ of the global variable/
enforce(_first);
    assert(_last);
std.algorithm is declared to a top part of code. However, why is it necessary here?
can you make this 0.9.0? 0.13.0 will come out sooner or later and this will break.
Sans doute que c'est moche. Je vai me pencher sur la question mais si t'as
une piste.
J'avais suivi le wiki sans trop regarder de son code.

Le 30 octobre 2012 09:06, Renaud LITTOLFF <notifications@github.com> a
écrit :

> In fr/Contents/chapter4.md:
>
> > +
> > +### Etape 2 : Mise en place d'atoum
> > +
> > +Télécharger [le fichier PHAR](http://downloads.atoum.org/nightly/mageekguy.atoum.phar
> ) et placer le dans le
> > +répertoire vendor qui est à la racine de votre projet.
> > +
> > +Ajouter à votre dossier src/Acme/DemoBundle le dossier Tests/Units/Entity et créer le fichier Car.php dans ce nouveau
> > +dossier.
> > +Ajouter un fichier Test.php à placer directement dans le dossier Tests/Units.
> > +
> > +    [php]
> > +    <?php
> > +    // src/Acme/DemoBundle/Tests/Units/Test.php
> > +    namespace Acme\DemoBundle\Tests\Units;
> > +
> > +    require_once __DIR__ . '/../../../../../vendor/symfony/symfony/src/Symfony/Component/ClassLoader/UniversalClassLoader.php';
>
> C'est extremement moche de devoir ajouter le class loader, l'instancier et
> enregistrer le namespace pour chaque classe de test, non ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/marmotz/atoum-s-documentation/pull/10/files#r1975938>.
>
>
Difficult to test, but as discussed this should only improve performance.
Not sure if you need this.  This also makes assumptions about app structure.
dir_name = "#{settings['logevent']['eventdir']}/#{@event['client']['name']}/#{@event['check']['name']}"

FileUtils.mkdir_p(dir_name)

etc ...
i suck at js as well, but [] is creating an array and {} an object. not sure if js cares about the difference, but the FOSJsRoutingBundle is using objects as defaults configuration as well. i would think {} is the right thing to put here.

once we merged, we should ask people to test this on IE and with and without routing defaults to know if it really works.
Sounds good! Thanks, @hoboman313
the full namespace isn't required here.
Great tests. Should there be one or two testing stacking with sockets and ram?
The double quotes and {} are not necessary
Type is not necessarily an array here, no?
this code is great. clear thinking about the internal data structure, robust against whichever order this method and the add-dicts method might be called, or if they're called multiple times...
Functions should also be camel case, in order to keep the codebase cohesive. Otherwise, people would be thinking that there's some sort of separation between functions and methods. They should use the same naming convention to avoid this idea.
None may work, but `expected` is a string field, so really the "empty" default should be `""`.
Sure, but until the compiler is fixed....
Perfect example of what I was explaining - this assert throws for Windows (and this is the posix module :)

I'd say put ```version (Posix):``` at the top of the file, I do believe that the same thing is done for the sys.osx and sys.windows modules (```version (OSX):``` and ```version (Windows):``` respecitively).
Similarly, spaces of this line are my mistake that is mixed involuntarily.
Np! I agree about
>very corner case

So, never mind and let's stop to discuss it! ;-)
The main issue will be caused when payload and header have reference to the same object and after some payload transformation end-user will be a bit confused why his header changed too.
Wouldn't you rather want to initialize the builder using:

    BeanDefinitionBuilder.genericBeanDefinition(UriVariableExpressionDelegateFactoryBean.class)
overrides on interface methods
Yes, look at RequestReplyScenariosWithTempReplyQueuesTests.messageCorrelationBasedOnRequestMessageId() it reproduces that scenarios exactly.
No, if expression returns null its an exception and doing what you propose would suppress the rule that the payload can not be null
You can combine this into one jQuery call:

```
$('#selectmetric option, #selectmetric_alt option').remove();
```
There's two spaces in front of 'all'
Let's focus on code reuse here. I think Wesley has already written some code to transform an index into a String, in that case, you might want to pass in an index rather than generating a set of random characters.

Note that the microtables won't include all permutations within a certain length, so you will have to be careful with the plaintexts you generate. A simple operation would be:
startingIndex + rand[0, length)

I'd also use the Random object rather than Math.rand simply because it can return integer primitives and allows you to set a lower and upper bound. 

You will also need to think of some way to avoid generating the same plaintext twice - though it might not be here.
not the class, but the nodename of the child node. so its correct
Tämähän ei luonnollisesti ollut tarkoituksena. Ei pisteitä.
Exceptionhandling will have a full page. Perhaps for some of these better to put a blank file in place? (if not present)
That's what I initially used. But 4.4.x are also previous releases.
I think it makes sense to start using Nokogiri as the preferred XML tool (do other collabs agree?) but if so we need to add it explicitly to the dependencies.
`flask.flask.request.url` - merge chestia asta? De ce e nevoie de două flask-uri?
What about https?  It might be reasonable to try downloading any URL with the WebClient.  Ideally the WebClient's proxy settings would be configurable, and perhaps there even ought to be an option to pass image URLs through unmodified, which is appropriate if the CZML and images are on the same server.
Try to put all text constants into DisplayConstants for future internationalization
(remove this too)
This copyright is outdated. We need to update to the most recent one:

/**
* Copyright (c) Microsoft.  All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*   http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
In this branch, shouldn't the output key be pulled out of the tuple rather than instantiated directly?
Yeah, you're right. Let me get back up and running on ds and I'll address this tout de suite
Subtracting the same value from straight and diagonal looks a bit fishy -- any reason to not use a factor (multiply with 0.8 or something like that) here?
Why? I think the closure gets garbage-collected when fit() finishes. And the ability to pickle is tested in test_text.py.
I know explicit is better than implicit and all that, but couldn't this be subsumed by `dtype=bool`?
Typo. Also probably belongs in an Advanced section.
adjusted my comment a bit in case you were quick
This is still only for us. You can write me the line
unnecessary == Boolean.TRUE (since Java 1.5 we have auto unboxing)
should init this variable to 0
The problem is that when you inject the dom is already loaded and DOMContentLoaded will not be fired and that is why the ready event is not fired in the case you inject scripts. The ready state changes but DomContentLoaded doesn't get fired.

a better fix might be to change this listener to readyStateChange

```
document.onreadystatechange = function () {
    if (document.readyState == "complete") {
        initApplication();
    }
}
```
use pure object with no spring if mocking.
how else is this configured?
could the connection be cached?
Consider adding a clause for each Exception you are catching.