labofsahil/github-event-dataset-2012 huggingface dataset:
It might be better to match a `{Module, Function}` tuple, and call `Module:Function()`, because of hot code loading, explained more in [my comment on riak_api's PR18](https://github.com/basho/riak_api/pull/18/files#r2115818)
This is not BC. You should add it at the end instead
`tmp=$(mktemp -d $(TMPDIR)/.XXXXX); $(BORSCHIK_PATH) -t css -i $< -o $${tmp} && $(CSSO_PATH) -i $${tmp} -o $@`
New array notation for a almost new file? :)
Isn't this parameter an array?
`layer.redraw` could be called outside the `if` and `else` blocks.
I suppose that it's automatically calls the server to get capabilities once a choice is made in the combo list.
If so, thanks, this is a nice enhancement I intended to add sooner than later.
@alainbloch  I think for arrays of petitions we should lower this default to 25 petitions, since we might be returning a ton of data if they haven't specified a subset of fields to return.
@davidfowl were you talking about the selector strings or the case statement strings?
Since @sobstel did the change on my recommendation I'd like to jump in on this one.

As mentioned on #122, "if the documentation here, https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Cache/CacheProvider.php#L144 , is right, then fetch will return FALSE in case the value is not found so I don't see a point in doing a trip to the caching server, ask if it has the value in it's cache, if it has fetch it, if not then" we should change the function documentation as it's wrong.

@beberlei what's your input on this?
Consider simplifying this IF:

```php
return ! ($value['lifetime'] !== 0 && $value['lifetime'] < time());
```
Please don't make bad whitespace changes
Instead of using recursion and calling a function that you've written, have you looked at [Directory.EnumerateFileSystemEntries?](http://msdn.microsoft.com/en-us/library/system.io.directory.enumeratefilesystementries(v=vs.100).aspx)
I ask, because we could get an enumerator to iterate through all the files, clear the read only flag, then do a `Directory.Delete` at the end.
you don't need to add that. Git/Github show it well with `git diff master...`
User_highlight is ment to later force the cell highlighting if the user
wish to. It is undefined by design so that if the user set it, it will be
used. But i can explicitely set it to undefined.
Le 10 août 2012 03:39, "Brian E. Granger" <notifications@github.com> a
écrit :
>
> In IPython/frontend/html/notebook/static/js/cell.js:
>
> > @@ -154,6 +154,61 @@ var IPython = (function (IPython) {
> >          this.code_mirror.refresh();
> >      };
> >
> > +    Cell.prototype.force_highlight = function(mode){
> > +        this.user_highlight = mode;
>
> I don't see where the user_highlight attribute is initialized. It should
be set in the Cell constructor to auto.
>
> —
> Reply to this email directly or view it on GitHub.
Hi, it is OK to delete this line before checking in, rather than commenting, since we anyways have history in git.
The original function that was used here does not exist on parser. Can you verify that this makes some sense? It seems to serve the original purpose of the function.
In the interest of completeness, could you add a `test_reset_soft__fails_when_merging`?
A link to the new page and back would be nice. Otherwise, the reading flow stops. (Alternatively, the modelview documentation could (and should) be restructured)
We have a shortcut function for creating pages: https://github.com/mozilla/bedrock/blob/master/apps/mozorg/urls.py#L8

So instead just do:

page('', 'webmaker/index.html')

And then you don't need any views
Talked on IRC. and I withdraw this suggestion.
ahh, thanks.  yeah.  OK, so now I catch the key error and give this error message.  But I also kept the catch on Exception saying "unknown error"  Or does Django have handling for that kind of thing already?
Should this file be removed? `MTModelResource` doesn't seem to be used anywhere.
Replace this with:
```
:ref:`crontabber-chapter`
```
Yes, and those should be pulled from the database and not from config. When I first did this it was a big improvement though... :)
### Don't use a new vector here. 

Use a vector object that is created at initialisation.  You do this with 

     THREE.Box3._vector1 = new THREE.Vector3()


and replace this line with 

      var halfSize = THREE.Box3._vector1.copy( size ).multiplyScalar( 0.5 );


Try to avoid the garbage collection at any cost.
addCrumb on next line (update all others in the meantime ;))
`$c` is not a meaningful name. Use `$crumb` for instance
BUG: if a char is added before the 'http://' string, will return 1 hence true and BUG

better to use === TRUE
`$widegt_folder_check` should be `$widget_folder_check`
Corrected in the amended commit.
Missing space before (.
Missing empty line between docblock and variable.
typo: a field or fields
Is it configurable in PhpStorm?
use ``assertCount`` instead
hmmm, right, looks like we have never created it. Nevermind then.
$j carries no meaning, i would at least rename it to something that other people can read.
This was a copy-paste from another source file. The names are defined here: https://docs.djangoproject.com/en/dev/ref/models/fields/#filefield
I recommend adding this instead to your global `~/.gitignore` and removing `zeus.json` in the project-specific `.gitignore`.
maybe we could remove the filename (just used in EPS comments and unnecessary thanks to ostream)
Табуляция - 2 пробела. Сдвигать вправо настолько не надо
Typically, that logger should only go in dev logs.
I removed some code that operated on the result value, I can remove the result value now as well.
IIRC this doesn't require a ``getattr``. ``edit_mode`` should *always* be set to something. If not, that's a bug in the toolbar code.
Views in app.coffee represent layouts/pages (e.g. they're singletons and never get mixed and matched).  

--  
David Cramer

twitter.com/zeeg
disqus.com/zeeg



On Saturday, October 20, 2012 at 11:19 PM, Burak Yiğit Kaya wrote:

> In src/sentry/static/sentry/coffee/app.coffee:
> > @@ -0,0 +1,132 @@ > +window.app = app = app || {} > +app.config = app.config || {}; > + > +jQuery -> > + > + app.StreamView = class StreamView extends Backbone.View > + el: $('body')  
> So even if this is the "main" view, it should have its own, separate element. Body is the general container so for instance if you ever decide to have more than one views, you cannot have them since there can only be a single body element on the page. Also if you ever to remove that, you cannot do that either since body cannot be removed.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/getsentry/sentry/pull/629/files#r1898198).  
>  
>  
>
What do you think about the following (keeps the namespacing and consistency of the file name convention)?

```ruby
module Stackster::Exceptions

  class Base
    attr_accessor :message

    def initialize(message='')
      @message = message
    end
  end

  class CloudFormationError < Base; end

  class UnknownStack < Base; end
end
```

Then client code could just:
```ruby
begin
  stack.blow_up!
rescue Stackster::Exceptions::Base => e
  puts "it failed #{e.message}"
end
```
I think these are instance fields just to avoid dealing with the need to return 2 items from prepareServiceConfiguration() ? If so, please do something else. :)
`this.uiDialog.find( ":tabbable" )`
This name is confusing, as this is a constructor, not a prototype.
A description of the method itself (why use it?) would be useful.
Why don't you use wifi.js from Settings here? This make me worried.
Okay.
I also need to verify in case of this._isUnderneathCallScreen = false. work or not.
It will turn alarm off and close itself without stop vibration and ring.
If you are going to define all the vars, you could do something like:

var contactPhone,
      contactSelection,
      logItem,
      logItemsLength = logItems.length;
If you assume a precondition for this function that topCandidates is sorted, and you maintain that as an invariant, then you don't have to call sort() each time.  If candidate.rank < topCandidates[topCandidates.length-1].rank, then you can just return and leave the array as it is.  You'll need a special case for topCandidates.length == 0, of course.  And for such short arrays, it might be faster to just loop through topCandidates[] from end to start to find the correct position to insert the candidate at. Then you wouldn't have to call sort() at all.
It would be better to have a function to this in controller.js to prevent duplicate code.
Could be done in a later improvement.
I have not tried this yet, but device storage also apparently supports a storage type of "sdcard". If you use that then you can access any file on the card, regardless of its extension.  So it will be simpler to just use that to get the file you want without having to decide on "music" or "pictures".
don't think this is needed :)
Probably makes more sense to just look at the new file rather then this diff...
oh we should get rid of the `!important` to save the kittens :)
OK, I’ve seen the `data-type="edit scrolling"` and `data-type="extended edit"` items. I’m not sure I like that. :-(
merged, thanks!
Не совсем уверен, что повелительная форма подходит лучше. Все-таки это необязательный параметр...
しかし、場合によっては同時に1つ以上のジョブを実行した方が便利なことがあります。


→

    しかし、場合によっては同時に 1 つ以上のジョブを実行した方が便利なことがあります。

半角スペース
Some other node programs use this method for checking files but I am not sure of the exact reasoning. This method would not recompile a template if it results in the same file size.

This could also be done with `fs.watch(...)`:

    fs.watch(file, function () {
        renderFile(file);
    }

From what I understand that is preferred, but I haven't tried it outside of my own projects. I can try it out a little later.
You've gone away from naming functions with lower case and underscores. Any reason? Why not be consistent? This comment applies to other functions as well.
Remove the `get` here.
Remove these extra newlines.
Include the return value here.
This isn't true, until you change below to actually raise TypeErrors.
If you're adding this for database migrations, you want to use South instead.
Not wrapping here, causes the code to extend outside the code block (and exceed 80 columns).
p4branch?
Not in browser mode... but maybe the browser addon could figure out the full path from the relative one.
it would look nicer if we add a cancel button. That would require not requiring email, password and username. we could "flash" the notifications. Now the user just sees an "X" and not why it's wrong. That could be changed while at it. Adding a confirmation field for the password would be nice too, but there is someone working on that feature
Are you sure that the second parameter of var_export should be omitted?
ah, ok. I read the ticket - it's a hangover from the way the desktop works.
`//Responsible for holding the definition of the two editions and refreshing them with current values.`
Can you add that sandboxes are indexed by module URIs?
I will add comment to explain this.
This is misindented now.
This help text is now out of date.
For the smooth rich experience of downloading 19 megabytes at once.
@m8ttyB, this construction is consistent with what is in sumo-tests, and i consider every page class having the go_to_X_page function even if the tests don't require it good practice.
OK. Removed in effd0a6.
really picky - do you want to sort the white space of the function params
Would rename that to `amqp_object_store_get_valid_object()`. Same for the file (amqp_object_store.c)
Yes, I see the error, will change this.
Addressed in 24d0af7.
That doesn't really help: what does `Puppet::Parser::Compiler.new.clean_backtrack(...)` mean?

Because this becomes part of the public API for a bunch of classes, it needs a very, very specific name that explains exactly what it is used for.

...or, better, make it a clearly named method and call it on another object rather than including it: `Puppet::DSL::Helper.remove_non_dsl_code_from_backtrace(e.backtrace)`

(It might make sense to entirely encapsulate that, by passing the exception and allowing the method to modify it, rather than putting the responsibility for knowing what to update entirely in the hands of the callers.)
I need some advice on how to handle localisation in the IDE integration project.
Bugfix: dupe filters being added on multiple calls to getInputFilter().
This is wrong. Removing this case `double` and `float` do the same of `array`
Add space between if and opening paren. Same comment for lines 38 and 48, too.
This won't work properly, and will likely raise notices with invalid XML files. Also you don't reset it to the original value afterwards.
I need to push a new commit. Tests are still a play ground for me ...
Edo is bad refactorist!!!
I believe that c66f4faeff42db3d27b1a21f5ed68a18e1fa7a85 is a better solution, as it's simpler and does not introduce a new option. Using ".build" is probably safe enough.
What exactly is the purpose of the following methods?
Ok, sure, I agree ;)
here '_title' should actually be 'title' instead
Hello!

We have added the note you requested (above) in the following git commit, https://github.com/brookinsconsulting/AdminAid/commit/deee634be3988df28e8698e2c298ca53a87e86ac

Thank you for your continued support!

Cheers,
Brookins Consulting
I don't think so neither, if you put NUL between the two dots, the path becomes wrong:
Tested with from my home on my linux box:

This works normally:
php -r '$f = "../tigrou/.bashrc" ; var_dump( file_get_contents( $f ) );';
This does not work:
php -r '$f = ".\0./tigrou/.bashrc" ; var_dump( file_get_contents( $f ) );';
COPYING is normally not isntalled as $LICENSE already as the same information. And please use repoman to commit/check etc. There are a couple of nice checks including this one.
Same comments, here  - need to keep the brand consistent.
Might want to have a "batteries not included" message making it clear that the OWSLib is not automatically installed by basemap.
Ok I'll add one. 
I see how that is misleading, but a new user does not have a key, calling `profile.get_api_key()` gets or creates is.
The opposite already exists.
https://docs.djangoproject.com/en/dev/ref/settings/#std:setting-APPEND_SLASH
You can make this a `test(`... since you're not waiting for the video to be ready
Why removing the BS here?
@hdemon :+1:

自分もツッコミ入れようと思ったけどうまくできなかった．
oops, my mistake :)
do you have any idea if the routes are added before / after this matcher? its important, as this matcher is a workarond to a bug in rails 3.0.x
This file conflicts when user has a plugin which does some hack.
hmm, but I have no other idea...
I also want this feature...
Any opinion about using a file to keep track of the last seen specification set? And about the name?
The other alternative was about something like `~/.cocoapods/data` where to keep track of information needed across different executions of the pod command (maybe a YAML o JSON encoded file).
This one might be removed :)
I can check for just 200, but I wanted to make sure that any 2xx response got accepted, as they're all successes. I'll change the if statement
I think it makes sense to change the name of the store from "roads" to something like "shapes" since we are not adding specifically a roads shapefile.
on that <a href>? fixed
I think this makes more sense as a helper function that returns the exception to throw, rather than throwing it itself. The user can do `(throw (limit-exception limit))`.
This should just be `(assoc json-obj :id report-id)`. No need to use `assoc-in` unless it's a nested structure.
It doesn't feel quite right to have the authentication API contain the createUser function. I'd say this should still be in oae-principals, which then calls the associateLoginId function.
It feels like this could actually be an error.
I'm wondering if this needs to be nextTick. It means that it will execute straight after this function, which might not be the desired behaviour for a server on heavy load.

Also, reindexContent could have the nextTick inside of it.
Should be ``private``, and most likely ``@volatile``
Good idea; I'll do that.
http://www.assembla.com/spaces/scala-ide/tickets/1001062-update-ci-server-%28jenkins%29-to-run-ui-tests
This is a particularly bad change. It's supposed to be `instance&&Object.getPrototypeOf(instance)` because if `instance` were to be undefined or null than it would throw an Error.
May I ask why the plugin repository is being pushed back?
Looks clearer, IMO. Shall add spacing though.
*"timezone"* -> *'time_reference'*
поддерживаю очень. но вдруг опечатка или изменение задания и в массиве chars окажется элементов меньше чем N_CHARSET. будет очень сложно отловить эту ошибку. я не решился обьявлять такое
да, согласен. Сначала хотел обойтись без констант. Потом решил сделать в общем виде и не везде сделал изменения.
PS: еще эти ошибки связаны с тем, что этот проект был мной написан в блокноте с компиляцией моим другом.
спасибо за замечание. исправил.
...конечно, можно было бы и через "for (int i = 0; i < LENGTH_ARRAY; i++) { ... }". но мне показалось, через "while ()" - короче. хотя, это, скорее всего, дело привычки и разницей "с какой стороны обрабатывать массив" (через "while ()" он обрабатывается с конца, в отличие именно от этого "for (int i = 0; i < LENGTH_ARRAY; i++)", который обрабатывается с начала)
`v` это уже NSString, можно (нужно) просто `[DNA addObject:v];`
нужно мутировать оба объекта, здесь же мутирует только 1, но 2 раза
Прошу прощения. К моему сожалению, я неправильно понял задание и думал, что нужно иметь полностью рабочее приложение, а не только интерфейс и описание. Гляну вечером еще раз. Спасибо.
Corrected!

On 25/12/2012 10:53, Severin Gehwolf wrote:
>
> In app/views/main/_markus_contributors.html.erb:
>
> >   Jérôme Gazel,
> >   Jiahui Xu,
> >  +Joel Budford,
>
> I think it's "Joel Burford"
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/MarkUsProject/Markus/pull/947/files#r2500166>.
>
Eval's code on a web service, not the hubot, so there is no issue really.
Actually, might be good to separate this into it's own var like r,g, and b up there. Same for the other places.
same here remove XXX
They don't have to match.. we just extract one time series per label, the number of stcs corresponds to the number of epochs. So we get as output a list of arrays with shape (len(labels), stc.data.shape[1]) (maybe it would be better to write len(stc.times))
Hm, this intermediate heading might make it ambiguous what module the following functions are from
I suggested Lluis to move this to a service method in order to use @ Cachaeble, but since it is not possible and you make a fair point Darius let's keep it in the handler. I'm sorry for that Lluis.
BaseOpenmrsData has no id attribute and subclasses all have different names (activeListItemId, encounterId ...).
So up until here, the term netmasks has been used. How is a Subnet Mask different from a netmask? (I know they are the same, but this should be explained.
Could you pleas remove these comments?
Good point, thanks, I have updated the example with this change.
Hmm, how about:

> To see a simple implementation, generate the ETag as the md5 of the content::
There was a minimum length on the token.
small change

```

diff --git a/nipype/interfaces/nipy/preprocess.py b/nipype/interfaces/nipy/preprocess.py
index 9f11749..5ee169d 100644
--- a/nipype/interfaces/nipy/preprocess.py
+++ b/nipype/interfaces/nipy/preprocess.py
@@ -147,10 +147,9 @@ class FmriRealign4d(BaseInterface):
             motion = R._transforms[j]
             #output a .par file that looks like fsl.mcflirt's .par file
             for i, mo in enumerate(motion):
-                string = str(mo.rotation[0]) + "  " + str(mo.rotation[1])
-                + "  " + str(mo.rotation[2]) + "  " + str(mo.translation[0])
-                + "  " + str(mo.translation[1]) + "  " + str(mo.translation[2])
-                + "  \n"
+                params = ['%.10f' % item for item in np.hstack((mo.rotation,
+                                                                mo.translation))]
+                string = ' '.join(params) + '\n'
                 mfile.write(string)
             mfile.close()
```
can't we use a ssize_t instead of npy_intp ? Strictly speaking, intptr_t and ssize_t are not the same (although most likely are on the platforms we support). Using the numpy version of intptr_t feels weird to me everytime I see it used as index or size.
Y si el último envío es de anteayer, está programando el envío para ayer. Eso entendí, ¿estoy equivocado?
Forgive my previous note. A 'count' key is returned in each level
this might make this easier
http://api.rubyonrails.org/classes/ActionView/Helpers/DateHelper.html#method-i-time_ago_in_words
This repeats the repeat_arg that is passed in exactly 3 times and will not work for any other number of times. It makes the test pass, but only because it is hard-coded for the test.
not exactly the same code (TO_DELETE), would need a side effect
If you're concerned about jshint/jslint it is going to complain about the ==
True. Let's leave it in though generally I don't like regexes for URL checks. They are close to useless in important cases.
We need a order by user here
If everything from this line to the end of the else block was moved to a new method or free-standing function it would be easier to read.
add instanceof TxCompletionNotificationCommand here?
great. let's not have extra words
I found that 30% / 17% / x / 7% fit better for very old files (long dates)
Can we maybe guarantee that `error` will be set to `nil` on success, to get rid of the last parameter?
Michael, this and every other "with" statement will fail in python2.4.  Since 1.1.x is out last python2.4 compatible branch, we can't have any of these.
Because fname can be both a string or a file-like, this line reads a little strangely. Would you mind adding a comment? Something along the lines of:

```
if we've been given a file-like object, and it has a name defined, get the extension from the name.
```
I do not see a reason why we need two except clauses here. Whenever an error is returned by the server we always hit the HTTPError exception, or? So we should take this one and use the message from the Exception case.
This function is unused. Remove it
You guys sure people only log strings?
attr_accessor? I think attr :foo, true is deprecated in 1.9.
Adding these into a loop would be a little cleaner. Prolly not worth putting the first gem with the version param into the loop though.
You can keep the method definition in the superclass as a nop if you like the symmetry (I also like symmetry...), but please don't bother calling it from inside the methods in the subclasses for now. If there ever grows to be more than a nop we can add the call in later. 

You have to realize that element_start and element_end are essentially tight inner-loops and that makes them performance-critical.

Thanks.
@dooremont please fix the spaces
remove obsolete comment please
Can you please fix the coding conventions here? http://doc.silverstripe.org/sapphire/en/trunk/misc/coding-conventions#if-else-elseif
Also further down in the file.
вьюхи тестить не нужно
When you get to the reports download page,  for those who choose to select all, they now have to do that twice. Select all for approval status, and then select all for additional data. Makes sense?
You are correct. I moved it to the abstract class and made it le protected.
Sorry, it still doesn't scale well. Think about several millions of products and 100 000 categories. You definitively have to fetch the referenced products in the same loop that's process the items.
Are you sure ``'0aa'`` has the correct type as "string" is not a sub-type of "integer"?
TazeTSchnitzel: How about just using instance_create and with(Plugin) { execute_file(...); }?
Does this line break legitimate ongoing uses of the `#` as an anchor? I'm not sure if it affects us, but would be nice to limit the automatic redirecting to when the hash includes the `!`, so we retain the option of using traditional `#`s where appropriate.
else ist nicht nötig...
.`prop( 'checked', val === 'true' );` works as well. Potential invalid values are also ignored that way.
"that the getting started for" => "that the getting started guide for"
I just prefer mockery and I think efforts would be better spent increasing
coverage of other areas rather than rewriting my work.
On Nov 10, 2012 6:45 PM, "George Petsagourakis" <notifications@github.com>
wrote:

> In composer.json:
>
> >          "symfony/config": "2.*",
> >          "symfony/class-loader": "2.*"
> >      },
> >      "require-dev": {
> > -        "mockery/mockery": "*@dev"
> > +        "phpunit/phpunit": "3.*",
> > +        "phpunit/dbunit": ">=1.2"
>
> No need for DBUnit you are right, it is in there since I initially assumed
> that we are dealing with databases and it got me thinking that there might
> be a use for it while testing. Alas Phpmig is actually using adapters that
> should be tested on their own.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/davedevelopment/phpmig/pull/23/files#r2091508>.
>
>
Ok, I'll have a look and see if I can quickly understand why it is so.
Maybe we can remove some of these newlines?
good oh
What if e.type isn't defined? Is this always true in the legacy case (I didn't check)? If so e.type !== undefined might be all you need.
Any reason to not use shell_out here?
spaces around = pls
it looks like you don't need these two imports
For CollectionArgs above, the value for all is 0. Here it's -1. Does the Java SDK normalize this somehow?
I don't mind. You will just have to do new pull request with this cleaned code. :-)
???

We are not using Django User object.
Write out all function arguments a function can take. For example, here, it should be `event` object you get as an argument. This allows developers later on to know what is available.
When posting we get location from header with full URI: http://127.0.0.1:8000/api/v1/......, but when getting this value over ajax field resource_uri has only the last part from /api/v1/.... i'll make a regular expression for that
Exactly here is good. Those three values tell us which connection we are speaking about. (The cookie is handled automatically by Django.)
Doesn't it do this automatically?
`StringField`? This should be `DateField`.
Don't concatenate HTML like this. Who will escape your all possibly user provided data here? Do it similar to how we are doing it above:

```
$('<li/>').text(data.username)
```

If you would update from main repository, you would get more examples.
Trust me I've searched the whole google with different keywords and the only answer I've got is: it is impossible. In IE of course, other browsers are not a problem. Well maybe i'm not very good at searching so I experiment a bit and found out this fix with positioning works. And it works okay in all browsers - why not use it? :)

And I have no idea why we are using sprites. I can fix this.
I dont know what you want me to do here. If I dont have this method overwritten, it checks if value is male or female but we want to have empty value too "".
Use `context.update` structure, as it is easier to extend later on.

Rename `panels` to something else. `dependencies`? Something which tells what the content is.
It was just an idea. You decide.
Django uses it for cryptographic signing, which we aren't actually making use of. So we may not actually need it, but I'm just going off what the docs say to do. It gets used for things like generating urls for password resets which we will at some point be doing.
So the big question is, do we just want a class that will handle stuff like `has_next` and `has_previous`, or do we want a class that can do the slicing as well?

I can add a couple of parameters to `Pagination.__init__()` to keep the functionality that exists but also allow us to paginate in Mongo, or I can switch to the snippet. By using `skip()`, `limit()`, and `count()`, we don't have any immediate need for anything beyond the snippet, but if we think we will, I don't want to throw it away.
Might be just my ruby noobness, but this looks a little odd when compared with line 8. Are they both needed?
I'm confused about how there wasn't a comma after 'compressor' before?
`g` ?
elephant-bird functionality does not depend on it. If I do what you suggested, any one who pull elephant-bird module will end up pulling this jar as well, right? If someone actually wants this module, then can depend-on/include it explicitly.
Usually I'd agree. But given that this pull request is 7 months old, has 210 open issues and 66 pull requests, out of which a number of them duplicates the functionality provided by this one, what I'd worry primarily about is whether or not this one might get one day pulled in, before putting any more effort into it.
Sorry, my bad! Done.
Maybe.. I am not sure what's the best way to handle the patching of thread and zmq.
Also, this is a `while` loop with the following characteristics:
 - create and initialize a variable;
 - continue while this variable fulfills some condition;
 - at the end of the loop, increment the observer.

Generally, such loops are rather written as `for` loops.
I don't see much value added if `strripos` is used instead of `substr` also the implementation here is recommended by the community check [this topic](http://stackoverflow.com/questions/834303/php-startswith-and-endswith-functions)

all functions used here and from native PHP library
after another discussion with frenzqse I think we could not really work around that field. as much as I hate it. Maybe with some better description we could bare it... in addition we might could rename it to something like: fuckYouMicrosoftForMakingUsAddingThisFuckingField :-)
What do you mean, "That will get stringified later"? No, I think you're right, when it's "" I'd rather show nothing than the dash. I didn't realize it could be null too, but that's caught too then. Changed line to title = win && win.title && (" – " + win.title);
I would not add a version constraint for this just yet.
You can get rid of these blank lines
а зачем?)
I needed to be able to say nobody:nogroup because there is no group nobody on ubuntu.
This pom is incorrect.  You do not specify the dependencies.  Look at your ~/.m2/repository/com/icegreen/1.3.1b/*.pom for the correct dependencies.
Looks like you're removing the gdata recipe but you still have it in the role definitions "class2go/chef/roles/*.rb" so that will surely fail.
Better to use `Collections.<String>emptyList()` so that don't get generics warning...
I think I've missed something here.
Seems strange to instantiate a new entity type here. Is it to get the default values for the config keys? Feels like there should be nicer way to get hold of that, without executing constructor code that does unknown things... But I expect such a thing doesn't exist (yet).

Also, it's worth checking that the class loaded really is of type Entity.
We'll leave it as this for this pull request, but needs addressed. Please kick off discussion with me and/or Andrei when ready.
"Page"
Does the spec say its case sensitive?
Correct. I must have had something in mind initially. :P
Will remove.
OAuth2 is not coupled to Rails, just ActiveRecord. So maybe rather than call these Rails_x_x they should just be the different versions of activerecord.

WDYT?
this seems like a bad idea, so maybe there's some additional checks we can make. but i verified that this does correct the problem on android 2.2 with the android emulator
Oh, you do magic with join ' ', @ARGV
its  for the log-output a few lines later to show that loading of the icon failed
Can you use 2 spaces as a separator?
Hey hey,

Just clarifying previous comment - Rather than separate fwrite/log statements, a single string for both the fwrite and the log would be good, ie, something vaguely like:

```

$request .= "POST " . $urlParts['path'] . " HTTP/1.0" . "\r\n";
$request .= "Host: " . $urlParts['host'].':'.$port . "\r\n";
$request .= "Content-type: application/x-www-form-urlencoded" . "\r\n";
$request .= "Content-length: " . strlen($postData) . "\r\n";
$request .= 'User-Agent: ' . self::USER_AGENT . "\r\n";
$request .= $oauthHeader . "\r\n";
$request .= '' . "\r\n";
$request .= $postData . "\r\n";
$request .= '' . "\r\n";

```
I was thinking about this, and I think you are on to the right idea, but more concretely, we need to implement some form of datagramming service on top of the session, this could be a nice addition to the paper for making practical systems in anonymity systems.  What you've got started is in the right direction, but we certainly don't want to be throwing away packets somewhat silently.
Same stuff here as earlier.
Sure, good point, though you could still simplify the 1st half of the check with my example
Названия методов со строчной.
Ага. Во-первых, ещё -i должен быть указан.
Во-вторых, фильтрацию после сортировки надо делать без HashSet, и без toLowerCase().
А что за ошибка?
I dont like this approach, previous was more clean and elegant
change the name/url to something like helloworld-jdg to no colide with previous existing helloworld quickstart
It isn't just mac, it is FreeBSD which (obviously the mac man page is derived from):

http://www.unix.com/man-page/FreeBSD/1/test/

-Randall

On Apr 4, 2012, at 7:01 PM, Stuart Eichert wrote:

>> @@ -1,5 +1,11 @@
>> #!/bin/bash
>> 
>> +SOURCE="${BASH_SOURCE[0]}"
>> +while [ -h "$SOURCE" ] ; do SOURCE="$(readlink "$SOURCE")"; done
> 
> Randall, Randall, Randall.  You are quoting the man page from Mac OS X.  I am referring to the man page from Ubuntu Linux.  However, if you insist, we can change it to -L.  
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/isis-project/isis-project/pull/5/files#r648629
you shouldn't need to do the string formatting here, just comparing the two propertes should be fine.
Or a property that returns a list of just the premium apps then click the first one?
Any reason why you changed this? Should be careful about changing these things because lots of other tests will use this same property. We could break them if we change this property.
``@return void`` should be omitted
You sure you want to have it as Android 4.1.1.4? Sloppy IDE setup :wink2:
Mind finishing with a `.` (very nitpicky, I know :P)
What about html strings ... ?
It came in via your PR, I believe.
Thanks. I mostly thought of `` # num nodes of tree with depth 10`` which was there before but the more comment the better ;)
The user does not have access to this ``sparse`` parameter (it is automatically set by the abstract classes either sparse (set to True) or not sparse (set to "auto"). I think this error message should be changed to something more understandable for the user.
Actually that would break the `__setattr__` and `__getattr__` override so please ignore my previous comment.
It seems to me that other parts of the scikit don't record the random state in an attribute (they pass it around instead).
Do you think it is possible to split this into several lines to make it a bit more readable?
Also, maybe you should try computing ``contigentcy[nnz]`` only once. Atm it is computed 3 times.
I agree with both but I tend to say no big deal either
I would rather store the effective number of estimators in a dedicated attribute if required: `self.n_estimators_ = len(self.estimators_)` or just don't store it at all as it's trivial in this case.

A second call to `fit` on new data should forget all about the previously fitted state and reuse the original constructor parameter values. The scikit-learn model API should behave as a "curification" of the fitting procedures with the constructor parameters. or something akin to a partial function application.
Header for this with author info? :D
Forgot the clear* functions?
This include is not needed anymore after removing getValue, please remove at merge time.

Same goes for TiObject.h which is not needed either.
Does this need to be inside the loop?
Of course even better might be

queryExtra(expr)->appendName(string);

which added %<n>
It would be great to see this <80 characters.
You're missing a '%', I don't think this will run.
I should not see in element by css "([^"]*)" node values:
Remove this code if not used
Yes, it overrides the Report method, which sends, outputs to stdout, or to file. The problem with the file implementation is that it assumes the report is JSON.
nit: Could you move this function just before `newTopWindow`, as it is only used by this function, it would be easier to see.
NIT: Missing semicolon
Yeah, would be nice if you could do it. Also it would be great if you could rebase all of your commits into a single one with a proper description, which also references this pull #. Thanks.
It seems to me that there is never, ever an excuse for doing this other than with wrap enabled.  If there is we need some documentation in the code to explain when, and why, you would turn that on.
Good catch.  I honestly can't remember if I was aware of this deficiency or not.  In any case, redis doesn't have a setnxex... which is too bad, because that would be awesome.  I don't think you can use a MULTI to get the desired effect here since we need to check the return value of SETNX before we issue the EXPIRE.  Let me know if you think of something clever.  At the very least, probably should have a comment there documenting the problem.
Yeah, I'm not too sure either. Keep this as an issue maybe? Otherwise it's not perfect but works for the time being.
That's not totally right. The handle_callback method requires that its redirect_uri matches the redirect_uri from the request initiated by request_authorization. State is unneeded (and not part of the comparison) in handle_callback.
Getting 403 here as well, I thought I did test it but not 100% sure. 403 is strange though because repository is public
@sam-falvo: Didn't notice it. I withdraw my comment.
Good catch on the reversed parameter name and type.
cuz I don't like to type, but you're right, shall I edit and resubmit?
Does `anonymize()` do this for us now? Or is it just not needed? Just curious (either way is cool).
this should fail in the old format right?
Yes, you're right. Those fields are not actually imported.

Could you confirm that this was working as intended to start with?

On my end, the current MODS translator in the master branch also fails to import all those fields, but maybe it's just my setup that's weird.
Let's not do this now, but an optimization - depending on the hardware/driver - would be to clear color/depth/stencil together for first frustum, instead of clearing color, then depth/stencil.  However, for all we know our two clears are queued up in the driver, and sent as one to the hardware.
I'd still really like to have an option that tells rdmd what kind of linker *interface* it is dealing with and a separate option that tells it the *path* to that linker (if the latter option is unset, it can just default to the name of the linker).
This is a pseudotype, not a set of method parameters, so we can use the "platforms" tag here.
Also, I don't think gradients are supported on Android at all.
I know it's long, but I really feel people need a full example in order to quickly understand the format. There is a lot of confusion in the Q&A about contacts for this reason.
Cap. Also, wonder if we could be a little clearer here, like:

"Timer duration value couldn't be converted to a number."

Might be overkill. But if this timer duration is coming from user code at some point, it could be good to be clear.
I think alphabetical listings are the standard as I that's how it is throughout the rest of the docs
This is for pinch detection I believe, which I think should be removed b/c it is unreliable when both "twofingertap" and "pinch" eventListeners are added
Indent fix would nice
I think the only pros would be portability to other OS'es. Cons simplicity and performance I guess. But, it's pretty quick to change.
Can we simplify the comment? Perhaps "No font-family fix"?
Как знаешь. Как по мне, это метод штуки, у которой есть подобные сеттинги с конкретной структурой, а не утилита.
ns.markAsDragArea
Please fix this comment to reference "MemChaser", now.
Please don't change any of the calls to use the new lambdas if the're not in the examples. This is _much_ uglier with the new lambdas.
I apologize, I must be dense, but I still don't understand. Could you illustrate with an example how "moveOver" would not work ? :/
This logic does not match what's in `FILETIMEToStdTime`. It may do the same thing, but it's not doing it the same way. I don't know which way is better, but they should match.
var8 really?
Just prefixed it.
don't you want to get out some of this code into sub methods?
Is there any way that `{{ index }}` can contain something that won't be appropriately appendable to `?index=`? That's the only thing I can think to check, but otherwise this is good to go.
Is the plan to ship with this?
Some of these version numbers are unsettlingly low :-/
Good catch. If you've got a fix for it, feel free to create a pull request.
These lines still expose the render logic in the view. It reads like there's a possibility of both partials rendering.

A better pattern would be `<%= assessment_form.form_footer %>`. Then, conditionally render in the presenter.
Also, is there a reason that priority classes don't get a 1.5 multiplier in the weight?
or just `[canonical.downcase]`
May be. Schmittjoh has annotation with the name @Expose for those properties, that have to be serialized.
I think this this would be better if you need nanos somewhere else.

    public long getDuration() {
        this. getDurationNanos()/1000000
    }

I just noticed that my tests running for years :)
Thanks for the array performance page. My test results (using BrowserStack):

- Chrome 16: ```[]``` is always better than ```Array(len)```, 3 times better on average
- Chrome 14: ```[]``` is always better than ```Array(len)```, with ```Array(len)``` numbers that vary a lot from one run to another 
- FireFox 10: ```[]``` and ```Array(len)``` yield similar numbers, but FireFox 10 aggressively optimizes this use case, with runs about 5 times faster than in Chrome 16
- FireFox 3: ```[]``` is 1.4 faster than ```Array(len)``` on average
- Safari 5.1: ```[]``` and ```Array(len)``` yield similar numbers
- Safari 4: ```[]``` and ```Array(len)``` yield similar numbers
- Opera 11.6: ```[]``` and ```Array(len)``` yield similar numbers
- Opera 10: ```[]``` and ```Array(len)``` yield similar numbers
- IE 10 : ```[]``` and ```Array(len)``` yield similar numbers on average, results are unstable
- IE 9 : ```Array(len)``` is slightly (x 1.04) faster than ```[]```
- IE 8 : ```Array(len)``` is slightly (x 1.04) faster than ```[]```

In IE 6 and 7 the page doesn't display unfortunately. It would be interesting to also know what the results are in these browsers.
I totally just looked at the filename and not the whole path. Makes sense now.
Remove extra space before `id`
@author @since (5.2) etc tags should be used :-)
> The Logging adapter and the JPA adapter 

Unfortunately, not only: take a look into Amol's PR #558
If it's necessary I can investigate entire project. 
Nevertheless, I have some doubt to intruduce **igrone-case capability**: e.g. tx:advice's propagation doesn't have it yet...
What other guys think about this one?
Right - I understand that; I raise the issue because if someone is monitoring their broker they might wonder why an extra temp reply queue is hanging out there.
Thank you, Gary.
I know about necessity to change 'Reference Manual' & 'Migration Guide' and going to start new Documentation sub-task about it, but I should know that everything OK in this PR
explains is misspelled
Please use log resource instead of Chef::Log.info 
and add indentation to comment sting, 
First letter must be capital
This is not passenger logs - this is rails application logs
passenger logs are combined with httpd logs by default
if we use 
PassengerDebugLogFile /var/log/rails

passenger will redirect rails application log output to /var/log/rails only if /app_name/log folder is unavailable:
```
cat /var/log/rails/passenger.log
Rails Error: Unable to access log file. Please ensure that /home/pr_repo/myapp/log/development.log exists and is chmod 0666. The log level has been raised to WARN and the output directed to STDERR until the problem is fixed.
```

about  application_name:
if we plan to use multiple vhosts support, we will have multiple apps, so i think this will be nice if we will have separate log folders for each application.
See how we have documentation configuration in [django-pushserver](https://github.com/mitar/django-pushserver/blob/master/docs/conf.py#L55), where we set version from `setup.py`.
Maybe it shuld declare the call to appendClientTransformer on the service definition?
You can combine these like so ````jWorkflow.order(...).start(...);````
Copy generate_id to this app.
this service should be marked as private: it does not need to be retrieved dynamically from the container and so we can let the optimizations inline it when it is possible (which is the case here as it is referenced only once)
Don't you need to separate the zval to not modify the original array here?

Infact.. I don't see where the input argument is ever forced as array?
It's best to keep `assert*` methods like this outside of the test classes they're used.  Invariably, you end up wanting to use them elsewhere if they're useful.  If this is to be moved anywhere, it should be in to `armstrong.dev` so the method is available everywhere.
I don't think the status code has already been set set here.  I have tested it and it seemed to work fine (showed the 'Error getting screenshot' message)
This really needs to go, all instances of it. This is a professional project, there is no reason for it.
minor note but coding conventions would state that is should be lowerCase and you should include visibility keywords on the methods below (i.e public function setIsFolder()).
By only checking persistent, you're enforcing to be always declared on configuration.
I'd rather prefer:

```php
if (isset($server['persistent']) && $server['persistent']) {
```
Double **for**
However, I know Mark makes polishing ;-)
This is unnecessary line. Non-documentary comments should be removed.
I don't understand the purpose of these 4 lines of code. why are you pushing an empty object `options` in to an empty array, with the arguments as the context of the call?
Ok it sucks :)
Also this example is talking about the browser version of this file
I don't have that boilerplate blurb, please email it to me.
Twig is also required in prod, shouldn't be in require section ?
This one is for very simple link columns. If complex one needed, you can use column  expressions. I guess an example of column expression would be good here.
I think it does make the server side code simpler, alternatively you could also have the tasks send random ints to the client and have the client format them as css color.