labofsahil/github-event-dataset-2012 huggingface dataset:
> ... solution. It makes the code a lot more confusing for no reason. I'm not a fan of being a slave of your quality metrics if they aren't actually improving your quality.

@nicolaasmatthijs Definitely agree with that. I was just saying that there a different ways of solving the issue.
Ok, je regarderais ça dès que j'ai terminé la partie sur les formations !
I think you should add:
EnvironmentFile=/etc/conf.d/apache
ExecStart=/usr/sbin/httpd -k start $OPTIONS
ExecStop=/usr/sbin/httpd -k graceful-stop $OPTIONS
ExecReload=/usr/sbin/httpd -k graceful $OPTIONS
`IOAcknowledged` should lose the `d`, too. :)
@michaelklishin, The `remote_file` seems to be downloading the file even when it has been previously download. Are you observing similar behaviour?
what do you mean? 720p recording is not possible on leo atm. so why waste profile slots for stuttery recording presets that noone uses?

this way the user has the choice whether to record at w720 or w800.
can change this when (and if) hd recording is possible on leo.
here, the behavior is permissive, maybe it should deactivate by default.
Con is that is would force you to authenticate users.
maybe add [navicat](http://www.navicat.com/) which is our current best postgres option until SequelPro supports it?
Thanks for your feedback! 
`1.0.5` should be released after January the 19th, during the next week-end i guess.
I applied this commit to the "dev" branch of FSB, but it seams it comes with only the histogram chart file only. The changes in the other file absent. Are they overwritten by previous merging?

I saw  some minor issues in the histogram chart and wanted to fix in my dev branch. 
For now I'll make some comments here on the code of the file.
I agree no_attribute_check is horrible :-D

The use case is we have a has_many :sites association on our users. and I want to limit creation based on the sites they are allowed access to

So, given a user can have multiple sites, and a Sprocket belongs_to :site, this is the rule file

```ruby
has_permission_on :sprokcets, :to => :create do
  if_attribute :site => is_in { user.sites }
end
```
Then this

```ruby
class MyController < ApplicationController
   filter_resource_access :additional_no_attribute_check => [:new]
end
```

allows the "new" action to proceed but forces the create action to check attributes (e.g. ensuring the user didn't pick/fudge a site they don't have access to)

the other thought I had for fixing this was to simply make :no_attribute_check additive only.

And as for the case of :nested_in being possibly set as well, yes that could happen, BUT in that case I wouldn't need to set :additional_no_attribute_check most likely..
I know thought I'm pretty sure it's useless anyways.
Awesome. Could you send a pull request for this?
Thanks. As you can see, I was very confused when reviewing all this :) I think it was not obvious to me that method-level constraint and parameter constraint was the last one to describe as opposed to an intermediary step in the node creation
Bingo... I found where it sets the usb serial number from shared memory.  My C's really rusty and it's late, so I might have to look tomorrow.

This is the function where it is throwing the error from...

https://github.com/alanorth/kernel_huawei_u8160/blob/cm7/arch/arm/mach-msm/board-msm7x25.c#L3148
Row 78-82: Forgot to change "rapporterad" to "rapporterade"
Row 127: Should be "Ny Tag"
Row 136: Could be "länk" or "länka" depending on context.
Row 175-176: Dunno at the moment.
Row 211: Misssed. Should be "Ladda upp stora filer"
It looks like that library only supports retrieving by array offset. The library is simply a magic SimpleXMLElement object wrapper for the raw XML the web service returns.

Any changes would require modifying that external lib and then updating the bundled library. Might be worthwhile creating a new issue for the other project and tracking changes there.
Это удалит файлы только внутри данной директории.
This doesn't build it, these are just the specialized files for qcom devices. This is still used.
deep idle ist schon an, nur wird von den nstools ausgelesen, dass deep idle aus ist,

"Deep Idle" Status "Off"

wenn man auf "Idle Stats" geht, zeigt er aber eindeutig "Deep Idle (Top=ON)" 22342210 (ms)

an,

naja, wobei wir wieder beim Problem wären, dass es bei manchen Geräten zu funktionieren scheint, bei anderen jedoch nicht :/
maybe better method name would be hasSingleCondition
Nvm I misunderstood the + was actually part of the float print/ln() representation.
hmm, I take that message just as an FYI to the user about how to upgrade an individual package, that was satisfied during the current installation, not as a tip on how to redo the last installation command to get certain packages upgraded.
No, why autoGenerate this?  It's not required and we don't do it for other labels (slider for example).  Instead use 'defaultValue: "Label"'.
according to the next line shouldn't ths be $navModel? ;)
Oh, it's in the package. Cool.
if the first is true and the second is false, then one should be set to the other, no?
thought some more about this, you are right, that was a safe net that was not needed, removed, thanks
To avoid an object creation: the result of `c get name` is an `Option[ChildStats]`.
How do I remove a callback?
What if these terminate?
I like this way better, so you are welcome ;)
These are from lib/packs/default/* in case the renames don't track.
That may be debatable, but I changed this case back.  I did notice the same pattern two other places, and I wonder if you find it the same there.
Gone, replaced by show_device_details
I presume this isn't really for the user?  If it is, we need to document the interface better.  If not, simply modify this string.
This goes almost twice as far as the 80-column limit recommended by PEP-8.
There were bugs opened for this on RHEL 6.2 so definitely was an issue.  Need to verify this has been resolved with the python actually packaged for RHEL 6.
did you run into any cases where we weren't passing in a model? seems like we should guarantee that any time cssClasses is called, a model is passed in.
I would prefer that the optionparser be a member variable of the EMRio class, and then you extract all useful info from there and pass it in as variables, without tossing the optionparser around.
If you're looking for one object in collection - consider using break;
Is there a reason for not having the fully qualified name `Predis\Connection\ClusterConnectionInterface` here and below?
On 07/06/2012 11:17 PM, Tuncer Ayaz wrote:
> Same for ``tests=foo`` if the module has both ``foo_test`` and ``foo_test_``?

No, then only run foo_test() since it's the shortest match.

    /Richard
https://github.com/peters/pty.js/commit/6980995c423d9bf03fc3bf37ddf2f224418d3c1c
I don't understand why we have classes and types for the AkkaPdu things but here we are dealing with ByteString exclusively, and without documentation on what it means.
Good to know. Switched over to named functions.
variable may not be defined (when $callable is false).
Sure.  That line doesn't really have to be there.  It's only interesting if it's failing anyway.
Right, like that. Landed in 93efc7f and 47643d2, thanks.
You'll need to add that licence header that's on all the files here.
Maybe DRY this?
ca devrais pas etre declarer dans un fichier de mixin?
Compiler should optimize this into a single string, which should be more efficient than the proposed patch.
Is there any reason you check if the datagram channel is connected before suspension?  Regardless the datagram channel is connected or not, a user should be able to resume and suspend reads.
NO!  Not all transforms end with .txt.  We almost never use .txt internally.

Affine.txt
Affine.mat
Afffine.h5

could all e possible versions.

Hans

=================================================================
Hans J. Johnson, Ph.D.
Assistant Professor, Department of Psychiatry

Mailing Address:
W274 GH                             Email: hans-johnson@uiowa.edu<mailto:hans-johnson@uiowa.edu>
200 Hawkins Drive                   Phone: (319) 353 8587
The University of Iowa
Iowa City, IA 52242

From: Chris Filo Gorgolewski <notifications@github.com<mailto:notifications@github.com>>
Reply-To: nipy/nipype <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Friday, October 19, 2012 12:21 PM
To: nipy/nipype <nipype@noreply.github.com<mailto:nipype@noreply.github.com>>
Cc: Hans Johnson <hans.j.johnson@gmail.com<mailto:hans.j.johnson@gmail.com>>
Subject: Re: [nipype] ANTS: Removed unnecessary copyfiles and added output_image option. (#471)


In nipype/interfaces/ants/resampling.py:

>          if opt == 'transformation_series':
>              series = []
>              affine_counter = 0
>              for transformation in val:
> -                if 'Affine' in transformation and \
> +                if transformation.lower().endswith("txt") and \


@hjmjohnson<https://github.com/hjmjohnson> are you ok with this change?

—
Reply to this email directly or view it on GitHub<https://github.com/nipy/nipype/pull/471/files#r1892500>.



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________
That makes sense, but there are two glPushMatrix calls in this method, and it ends with two glPopMatrix calls. I think we just need the one to retain old state, no?
Just for consistency, could you move this and other db (sqlite/postgresql) charset tests to the end of the file instead? (like with `DatabaseTasksCharsetTest`). Also there's a typo in the class name:  `Charst => Charset`.
I'm not sure if this should be here. It depends on coding style and requirements, `js.erb` templates are not superior over using javascript callbacks for all of the cases.
Please, use 1.9 hash syntax. Thanks.
Columns need to be typecasted in both scenarios, otherwise `pluck` would work differently when using 1 and more columns.
@carlosantoniodasilva how about this?
This check can go in `wrap_with_time_zone` so `method_missing` isn't concerned with converting return values
Is there a reason to leave these lines in if they are commented out?
Nitpick-- with respect to: "is prepared to properly manage the blocking" This is still a bit vague, no?
https://github.com/scala/scala/blob/master/test/files/jvm/serialization.scala
Ah yes. Nested objects are disallowed both in universal traits and value classes. Nested classes are only disallowed in value classes.

I'll fix it. Thanks.
No, just push a new commit fixing it into the branch.
view() conflicts with ndarray.view()
Another unevaluated "warning".
> Gilbert wrote all the original documentation with "mass center" instead of "center of mass". There are about 50 instances of sentences with this. I assume a simple search and replace would suffice, but I guess it is possible that it the sentence could read incorrectly too.
>
> And then what about the attribute name? do you suggest changing the attribute to:
>
> "center_of_mass" or "centerofmass"

what about comass (but that looks weird), cofmass, or cmass?
I would format `(sqrt(3)/2 )* up` as `(sqrt(3)/2) * up`.
you can copy source file to tmp destination, then compare it e.g. by system("diff file1 file2") and at the end of test restore test file
just tested and with class_exists it is 4 times slower than on check for instanceof. But we have no chance, we need it for BC.
I wanted to make an exception in this case, since these are examples I wanted to intentionally put in both options and only implement one.
I think if catbox is not installed tests should not fail, since the plugin is not a core part of the system and should be treated optional.
There should be an upper bound here, like

```
                       conduit              >= 0.4     && < 0.5,
```
IMO this name is wrong. Somethink like `session.db_options` would be more precise about what it is.
This must be modified in the previous example also.
Superfluous cast. Also, prefer `sizeof(**cpu_infos)`.
missed one here!
There is either insufficient or insufficient clear validation going on.
I believe .data('refresh') should be used instead of .attr('data-refresh') - if not defined, it will result in "undefined", too, but it is according to HTML5 specifications and newest jQuery development way...
I personally don't see the need in this comment - it's fairly self explanatory, and most people know what it does anyway.
Please use the truncate_string function.
OH, I was reading this wrong. It finds one for every root path, never mind.
Since $style is changed to $phpbb_style, this can just be called $style then.
If it is not set or true, the function only returns the options of the timezone selector and not the options for th e"what time is it at your place" options aswell.

It is basically there to be able to use the function the way you used it in 3.0
This is the way it is in topic_notify.txt, what phpBB originally used. I do not know if this is correct or not because of British English can be rather odd.
If idx is always found, add a comment to that effect, ideally with an explanation why.
Nu e nevoie de paranteze
IMHO auxiliary verb here is not mandatory:
XRandR development headers required
Ah, I was confused about `raise` vs `rescue` requiring a subclass of `Exception` and failing if anything else is provided.  The reason I went with a `retryable_exception?` method is that it allows for the same flexibility you're describing with `===`.  I'll make the code change.
chera enghadr `/` dare !

```html
<img src="data:image/git;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==" />
```
I think the version should be 2.4.3, correct?
suggest adding a comment or creating a CONSTANT in order clarify the view that "1" refers to. This is especially helpful once you have many setActiveItem commands, or if you want to refactor code and update the numbers throughout.
It might not be a good idea to do a substring and hardcode the index here.
Instead use StringTokenizer and use '&' and then '=' as delimiters
I'm happy to pull together a list of packages for linux mint.
what is the scenario that $dbw is not used?  memcache miss?
json格式。不要理想化。
OK. Also, since this PR is orthogonal to the cython issue, we could still get a further speedup by cython-izing this PR.
the main gradient method (in gradient.py) , as far as I checked, does not replace the None with zeros_like or anything similar. I'm not sure myself about the official convention. I thought it was that we will pass None around when we are dealing with a non-differentiable path (as opposed to overloading 0 with this semantic). That way we can differentiate between paths that are not differentiable and those which result in 0 if we need to, 

But I remember we had some discussions on this and I'm not sure of the decided approach. I can equally change the main gradient method to pass 
in zeros_like instead of None if that is the official correct thing to do.
Same question about throwing. This probably also applies to parsing string values?
This is a fine addition to .gitignore, but ideally should be in a separate commit.
A comment here about what this class is trying to do would be helpful. Inside the class, a few method level comments might be helpful, like explaining what the difference between partitioned and independently partitioned is.
Why CRC the text? Just CRC the fragment id, or precompute the CRC of the text
We don't need to set the timezone on client now. The auction beginning time and ending time is set in stored procedure.
githubのアプリで不要かなと思ってingore登録したんですけど操作ミスですかね？
コミットに含めるとの事でignore外してみます。
![nonono](https://f.cloud.github.com/assets/55281/29768/c9242ffc-4dc3-11e2-930b-777aa5406dcb.gif)
why not use queryset directly?
you are right, I fixed the parameters.
isn't Buzz able to handle this ?
Need to add `Distribution.Client.ParseUtils`.
Also Oxford comma after the "or".
Please use random() from the database porting layer instead of calling rand() directly.
I added a request handler at the oauth level that happens before the oauth1/oauth2 request handlers to handle common logic. i'm setting req._serviceName to make it available to the subsequent request.
That seems like a stab in the right direction, but what about online access tokens? Currently, they work just fine with nothing touching meteor, but I believe they do in fact update the access token with each log in?

This code currently exists to specifically handle the case of later logins through meteor - services will never return another refresh token, so we don't want to override them with a null on a login past the very first. I'm not sure any of the other fields behave similarly.
What is with the funky multi-level list comprehension, could you find a way to make this more readable?
I looked at that pretty hard, but it just goes into the URL.
Maybe `dry_run?`
Alternately: `curl https://raw.github.com/gist/3769372/98e0a084470d2d6be7b4b61551ef00d44c682b4a/elf.h > /usr/local/include/elf.h`

Is there a reason this file doesn't ship with crosstool-ng?
ok cool. fwiw, the docs did say to use the full path for bsdmake...
This is an unversioned download, so the formula will break every time it is updated.
Vérifie la requéte
Hum ... Par très beau tout ça
Tak trochu to vypadá, jako by to nahrazovalo silné typy: JS je strašně free jazyk, kde se nemusíš starat o to, co s čím děláš, ale, ach né, pak ztratíš kontrakt "tahle funkce vrací takovéhle objekty"! V takovém prostředí jsou asi unit testy nutné všude, ale je to IMHO větší otrava, než unit testování netriviálních funkcí a silné typování ve většině programu.
should this throw? seems like we'd get an empty string in this case and that isn't what we want
The README didn't fix the calls to ObjectGraph.get()
Actually, I'd prefer them only on public, non-experimental, non-internal classes.  I think that "@since" gives the impression of something being stable public API, when it isn't, necessarily.
Why the assignment to w here?
I think, this is up to you, since some maven projects used to declare their license in the pom.
Should i remove it?
I think some Windows linebreaks snuck in here, which is causing the huge diff even though only one line is changed.
Oops sorry, misread the diff
Good call. I removed the id parameter from addMenuDivider() and made it generate the id internally

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 5:07 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +    MenuItem.prototype.nameChanged = function (e, command) {
> +        var $menuItem = $(_getHTMLMenuItem(this.id)).find(".menu-name");
> +        $menuItem.text(command.getName());
> +    };
> +
> +
> +    function init() {
> +
> +        /*
> +         * File menu
> +         */
> +        var menu;
> +        menu = addMenu(Strings.FILE_MENU, appMenuBar.FILE_MENU);
> +        menu.addMenuItem("file-new",                Commands.FILE_NEW,         "Ctrl-N");
> +        menu.addMenuItem("file-open",               Commands.FILE_OPEN,        "Ctrl-O");
> +        menu.addMenuItem("file-open-folder",        Commands.FILE_OPEN_FOLDER);

Should we make addMenuDivider() generate its own id by calling that method automatically?  Based on the usage here, it looks like extensions will be unable to add menu dividers because that id-generating utility is private.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r879155
Btw, since this is such a thorny issue I think we should put more detail in this var's docs about why it's needed.  That it's not just e.g. for efficiency, but rather an essential mechanism for ensuring that we never create two Document objects for the same file even if multiple requests come in concurrently.
Also, maybe for sum it would be good to have the "Sum of all..." prefix automatically added to the label.  That would save potential confusion if anyone changes the operator but forgets to update the string passed to logTestWindow().
It was a relatively simple way to deal with an order-of-operations issue. The problem was that after telling the current code hint provider to process an insertion, CodeHintManager would close the code hint. However, if that code hint provider itself decided that it wanted to cause another code hint menu to pop up, that would close the current code hint and set hintList to be the new code hint list, and then CodeHintManager would then close that new list (because it wouldn't know that it was different from the original). Rather than try to add some code to detect this specific case, it seemed more generally robust to make this re-entrant by making the code hint list not be a singleton. I'm open to other solutions though.
If KeyMap-test.js is obsolete, can we remove it?
Yes, they're affecting the side bar and menu bar.
Copyright header should be added.
gets if true if ? :-p
hehe, I believe in my bayesian filters,  bring it on spam lords!
Just `link`?
`_this`?
Each one of the lines in this `if` evaluation has brackets. That's just unnecessary and confusing, no?
ahha! :P
Add some spacing after `if`.
You need to add back iframeCover.style.display = "none";
above 3 lines need to be over to the left by 2 spaces
Something tells me you want to watch this movie.
Same as above. Indentation be important.
Have to agree with Dave, cache, cache, cache.
My existing aliases don't survive this. I narrowed it down to this one, possibly among others.
```
alias scala3doc='( cd /scala/inst/3/doc/scala-devel-docs/api && open index.html )'
```
so if those callbacks are called on save, and what you want to do in this case is just save without the callbacks, then you should probably ask whether they should be used as callbacks on save.  Perhaps your class should have a different interface that is not so dependent on callbacks.

It's in this kind of circumstance where starting by defining the class's interface (maybe with some basic, failing unit tests) and working your way down to the implementation can help.  You write code using the methods you wish you had, and then implement those methods.

To be honest, I am not sure what the 'best practice' for using these callbacks would be.  Maybe there's some standard pattern that makes it all easier to test.
Two periods.
Any reason this isn't named *.properties?  Then license muck can figure out how to put a header on this?
Config expects an apply() method without any parameters.
Why is it necessary to have a separate form for this when the metadata field has already been added to the main upload form?
I guess it should be a validation method. This is just for data members, as the return type doesn't match, the code doesn't compile.
already done :)
Should we consider defining these colors somewhere for re-use?
@param noheading
This line triggered https://bugzilla.redhat.com/show_bug.cgi?id=858678 I guess. Going to remove it.
I am not sure those terms of use apply or are appropriate upstream.
Memory stream doesn't get flushed so it needs to be cleared.

Replaced Reset content with:
_stream.SetLength(0);
It's triggered a single time in the success method from negotiate.  Here's how we used to do it:

Negotiate -> onStarting -> TransportStart -> onSending

Now we do it
Negotiate -> onStarting 

Since we combined the two together.
This sub must be called badHostnameMsg
shall we call this "manifest" or "manifestPath" just to be clear what it's for?

If we were going to keep this for a while I would also suggest you include the actual filename of the manifest here too because it doesn't always have to be called manifest.webapp, but as a temporary solution I think it's fine.
//<space>pass
Not a good idea to use this for a footer
This should be `1.0 - Om`  (if you decide to leave the class in).
yes, just as you did with `interpolate` and `convolve`... so it's consistent.
I know this was copied verbatim from my original sim code, but should we take the time to add a function to `chash.erl` to alter a chash so that we don't need to assume knowledge of an opaque tuple here?
`debug` level might be appropriate.
I had this in here as a safeguard if we use any other user method in the
future. Doesn't hurt even if we're only using github, right?

What's the best way to check email validity?

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Mon, Nov 19, 2012 at 1:53 PM, Luke Steensen <notifications@github.com>wrote:

> In db/migrate/20121114025229_create_users.rb:
>
> >        t.timestamps
> >      end
> > +    validates_uniqueness_of :name
> > +    validates_uniquness_of :email
> > +    validates_format_of :email, :with => /^([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})$/i
>
> If we're getting all this from github, we shouldn't need to worry about
> any of this. Also, email regexes are bad.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/11/files#r2171830>.
>
>
Making this static breaks test/DoS_tests.cpp
NACK. For Windows it makes somehow sense to keep the .txt extension. Without it there won't be any program associated with it "COPYING" and everyday-users could have problems viewing the license.
I wonder if we couldn't reduce all this wonderfully verbose code to about two lines of C++ string manipulation? :-)
@laanwj  Shouldn't this be ``this`` instead of ``qApp``? qApp is the QCoreApplication->Instance(), but we just need this filter for the QMainWindow (which is the object with the statusbar), which is our BitcoinGUI object.
I do like the constants header, as it keeps all the tweakable values together. But regard it more like a hard-coded configuration header than really "constants" as the values are arbitrary and changeable.
A bit more elaborate: why is the coin selection a property of CWallet being set and unset? It should just be passed to the coin selection functions.
The indentation is wrong here. In vi, the editor setting that would fix this (i think) is expandtab. Is there an equivalent in emacs? It seems to be chronic with your xml files.
I don't think that this test would actually fail if you we were to remove your changes to the DocParser.

You have declared the ApiTestAlias class inside a namespace, so it actually is ``Doctrine\Tests\Common\Annotations\Fixtures\ApiTestAlias``. You would need to declare this class in a separate file. Could you then also remove the ``class_alias`` thing, and directly use the class name that causes problems?

And please check that your test actually fails without the modification of the DocParser.
there is no need to do any special logic. UniversalClassLoader was adding an artificial distinction between namespaced classes and unnamespaced ones whereas PSR-0 does not. And Symfony 2.1 introduced a ClassLoader which has a simpler API by avoiding this distinction (just like Composer avoids it too)
Leave a comment or #ifdef for "NSDateComponents.quarter" property
These scenarios should be indented.
Ok for planets and moons.

Rope have the same issue as bullets: they are multi-points.  Either delete and recreate on the other side, or teleport the whole object.  Updating the 'pos' object isn't enough.
Function names should be camelcased.
probably comment why credentials are not available, or initialize a variable to null and comment there.
Raw isn't getting used though!
Adding a dummy date is not a good idea imho, Why don't you create the time-elemet with js when you have a correct date?
We have been avoiding doing distribution-specific instructions for these sorts of things since we haven't figured out a good way to:

1. document them effectively without a ton of document bloat
2. make sure they're maintained going forward -- out-of-date documentation is sometimes worse than lack of documentation

So I'm inclined to say that this section shouldn't get added. I've got a similar set of docs for Debian Testing and I think James has one for Fedora.

James started an install script that installs requirements and does the work you're listing below. Putting this stuff there is probably a better idea.
The real servers reports: "Content-Type: text/plain; charset=utf-8" - from:

curl -i https://marketplace.cdn.mozilla.net/public_keys/marketplace-root-pub-key.jwk
That is extremely odd. That field is only accessed from methods in that class, so `private` is appropriate.

Please treat this as a separate issue.
lol, thanks :P
On the other hand it's better to use read-write access than the read-only one.
if there are multiple candidates to choose among, select the shortest possible region with an extractor match.

That is, when trying to find prefix and there are multiple choices, it chooses the last one (the first one in the reversed tokens set) that gives a result between each prefix candidate and the end limit of the scan. Then, when trying to find the suffix, it searches it between the found prefix and the end limit of the scan, as normally, but again, if multiple candidates, tries the first one.
Sure, I can do that. Do you have more example patterns -> regexps?
It is in the super class AbstractChipState
this looks weird ! Could it be move to `Options::offsetSet()` ?
As far as I see, lines 56-60 are useless, as they are covered by the `$emptyValueFilter` in the method `setDefaultOptions`. Can you please remove them? Otherwise this patch looks good.
well, if we don't allow passing anything else than a FormBuilder, it does not make any sense to have a FormBuilderInterface
IMO `new self` is enough. Late static binding is not really usefull here as a potential subclass could not make use of a costum constructor anyway.
Same applies in the `filter` method.
well okej!
hmm must have messed it up at some point ill close and reopen
problem is that my server returs "text/plain" which is ont in `acceptableContentTypes` of `AFJSONRequestOperation`. To make it work I'd have to subclass it overwrite that method, do you think thats worth it?
id is an object type.. (strong, nonatomic)
I think this should be called ```not_zero_poly```.
This should not be becessary.  It can be handled in the same way as the related or report-a-proboem snippets.
strike actually
Thanks bryanforbes, I will make the changes.
I was trying to compile it for the .md optimizer therefor I had an even number of ! and 1s.
Merci pour le merge à la mano....
BTW ^^ is not my reason for not merging, rather I didn't look properly at all the removals in VirtualFileAdaptor and WSVirtualFileFilter
I think you're right! <tt>updatePreferenceWindow</tt> function is only called on checkbox and radio buttons.
No, it is not needed. I removed it.
用 userInstance 作为名称，因为其它地方都是 userInstance, 和其它地方统一。
I am not going to repeat the styling comments for each line.
Please help use the same coding style for the whole block of SVG.
Thanks.
I think that you can delete this line, could you test?
nit: i don't believe you need to speak so loud in the code. Please use lowercase after the initial uppercase char. :)
yes, this has to be refactored to use only the fb.utils one.
Is there not an icon for pause?  Looks like you're still using two vertical bars?  I'd say you should file a bug and get @patrykdesign to create a pause icon for you.  (Or actually, I bet the video app has one you could use)
right but you're already inside your own little scope, aren't you? So nobody should interfere with it!
please make sure your changes pass the linter
yep, just in case, but as we are not handling the error (while inserting), there is no way of know if the transactions failed for sure, just counting.

Not the best solution, but don't want to introduce more changes to the RecentsDBManager that is quite solid and does the job perfectly :)
I'm see too many messages and crossed-communication between the iframes. Wondering if there is a simpler solution
@steveck-chung  Dont worry Steve... We had a deadline for QA Testing this evening and of course we know that with one unified 'deleteMessages'  will be more efficient for sure! But we  will go step by step, so once we have our new cool 'deleteMessages' method code will be better. If you like we could work together in this small refactoring code in a shared branch.
AFAIK, untranslated text should not appear in the properties file. It should fallback successfully to English on its own.
Implement what when what is ready?
Thanks for spoting it, will check with @gtorodelvalle :)
Nit: this should probably be moved to the `apps.css` file.
Looks like the BB style will give the span a <code>margin-bottom: 0.5rem</code>, would you please add another class to override this, or it will not be vertical align, thanks.
Missing the `APP` trick
this code has been removed as it was not necessary and it was crapy at the same time ;)
Do you need the `li` in the selector?
Added second comment into lines.
ye, but you wouldn't need a regexp at all then :p
you should have try { .... } finally { Algorithms.closeStream(is) }. IOException can be thrown also while reading, it is good to close opened streams in such case. You don't have to close is, if you close br. Algorithms.closeStreams just try to close the stream silently.
@snusnu looks like we don't always have all field names available in aliases instance. Is this expected? I'd imagine that after joining two aliases instances (damn, why did you rename to aliases from alias_set?) we get attributes from both sides. It actually works with 1:1 and 1:m but not with m:m.

Another thing is that we need to come up with a nice interface to generate a header for projection. Using Aliases for that is probably a good idea, right?
same here, the above 2 lines should join?
we should destroy 'pusher' if we create it here ...
Why not implement as a new response type?
I prefer the positioning of the command arguments here. Using `set` or `show` right after `config` makes it a lot more clear what the user wants to do.

I'm going to play around with cmd's built-in help and see if it's possible to do it that way (off my head I'm guessing no).
Because *waves hands* ... *hangs head* I blindly copied from above where I removed it from. Will update.
It does - see `start` in `master/buildbot/steps/source/base.py`.

The original (`branch or 'master'`) is intended to implement the "default" branch, for when a source stamp comes in with no branch specified.  The name varies per VC (default on hg, trunk on svn, master on git).  Is master wrong for Bzr?  If so, what's reasonable?
```self.description``` and ```self.descriptionDone``` are not used, as the slave steps do not have or inherit a ```describe``` method that uses them.
done @ 7852b76
@Seldaek The cert you have is perfectly valid. PHP just hasn't been updated to support Subject Alternative Names in line with common practices - something we noticed recently when digging into PHP's SSL/TLS support in depth. The current cert also works fine with Curl.
haha cool, remove that and I am good to stage this
@SaitoWu @ariejan if target or source branch updated - its marked as unchanged here
+1. unless with else is unreadable
name of the variable must match with contents
space between '-fdoc' is missing.
This should be ```typedef struct steel_slist_node {```
I know it is not directly related to your modification, but this namespace usage seems unecessary.
IMHA, it would be just enough to replace `browser(browserWindows).internals` with `browserWindowsPrivate` here,
and here https://github.com/erikvold/jetpack-sdk/blob/fa3121b8b2402a6d6d0a8e0be6360cb77aa8e982/packages/addon-kit/lib/windows.js#L234
Replace `browser(this._public).internals = this;` with `browserWindowPrivate = this;`.
I think you should say something like "Failed to parse locale file ..." instead, since this comment is little misleading and quite similar to one from `readURI`.
Can we call it something else but manifest ? It's pretty confusing since we'll be call `manifest` something completely different. Maybe `install-rdf` or something like that ?
This is a little confusing, but I see after a second look why. Looks like a good re-usable way to do this.
Ooooh yeah that makes sense. I don't see a downside... I'll add it then :D
that's cool.  didn't know about doing that.  fixed it here and elsewhere.
I think everything from here on out should be pulled into a utility method - perhaps even a method directly on `DatazillaModel`. Writing tests is a lot easier if the management command itself just handles the command-line UI (options validation, etc), and all the real work happens in a function or method that can be more easily isolated for tests.
Can we move up all this code right under the local variable declarations of this method?
I thought I understood your comment but now I'm not so sure..

Would the new dprime() code (https://github.com/dicarlolab/bangmetric/blob/6d48df3ea74131fb712aaf434b064fb0c287b387/bangmetric/dprime.py) be okay for you?
There are a bunch of different places that have this exact same code in them.  It should ideally be unified, rather than having to fix every single place when we want to change behaviour around this.
Ah.  Won't it fail calling `String#exported=` then?
Fixed in the newest commit
Why did you change this spec? I would keep cleaning up stuff separate from adding new specs.
Can you flatten this to `class Gem::CustomRequire`, most other RubyGems classes are created this way.
Sorry, I copy/paste bit me.
Why not reusing this counter?
Sorry, but I'm not going to spend more time on this if it would take another 2 months to get another review or to get it incorporated...
The key should be set according to ``this.itemLabel``
just realized that this could be combined into this.hide().off(this.options.ns)... if you like.
Missing class-level docblock.
How about instead have a separate interface, "InitializableElementInterface", with the "init()" method? (Alternately, create a `Zend\Stdlib\InitializableInterface` for that.) That allows for typehinting, and then the ElementInterface in ZF3 can extend it -- or it can remain an opt-in feature.
Great, missed that you had done that. I'll update the webapi component as well. 

-Mike

On Apr 30, 2012, at 10:54 AM, Luke Opperman<reply@reply.github.com> wrote:

>> @@ -68,6 +68,8 @@ public function __construct() {
>>        
>>        $this->addEvent('GatherJSFiles');
>>        $this->addEvent('GatherCSSFiles');
>> +        
>> +        A('AliasManager')->setAlias('FileHandler', "\\Cumula\\Components\\IncludeFileAggregator\\IncludeFileAggregator");
> 
> There's already a default set in AliasManager for the name 'FileAggregator', is this just a redo?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Cumula/cumula-core/pull/78/files#r751003
Yeah, I guess I forgot to add that.  So is that something that I should do on another pull request or add that functionality in this one?

On Oct 23, 2012, at 12:38 PM, nathanfriemel wrote:

> In wordpress/wp-content/plugins/txsilc-cil/txsilc_cil_admin.php:
> 
> > @@ -0,0 +1,107 @@
> Doesn't look like there is a way to edit/delete existing CILs. Probably should at least add delete so if there is a mistake they can start over.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
There is no special reason. We're trying to fix.
I'm not sure how notifications work on github, but please check out my comment here: https://github.com/UnionOfRAD/lithium/pull/669#issuecomment-9845498
Does this also happen when a value gets replaced by a new value? Or is that just a signal?
-> $( document.body )
I was hesitant to change this as I couldn't figure out how to get config to load properly from the procfile with /etc/govuk/unicorn.rb  and I'd rather not kill everyones vm's by running 3 workers per app which is the default without a config (imo this could be lowered to one worker per app in dev)
That it does... It is located in the helpers spec folder
Hi Rick, this is what I meant, blocks for this selectors csc-place-owner and csc-place-placeName are not in the src/test/uispecs/place-search.json and src/test/uischema/place-search.json
@samiluukkonen "SELECT * from kirjoittimet" ajetaan jo rivillä 339. Vois varmaan sen while-loopissa esim. trigeröidä joku zebramuuttujajuttu niin ei tarvii ajaa koko kyselyä uudestaan.
2 empty lines before this
Yes and no same time =) But it's your call =)
s.add_development_dependency "rake" in gemspec, instead of Gemfile
Can you remove this console stuff? It looks fragile with the custom indentation.
Pete - I'm honestly not going to have time to write a CLI script for this,
as small as it is, for a few weeks.  I don't want to be any more of a
bottleneck than I already have been.

Should we go with the documentation as is (significant updates to it)?

Tosi

On Mon, May 7, 2012 at 12:15 PM, Pete Muir <
reply@reply.github.com
> wrote:

> > +
> > +What is it?
> > +-----------
> > +
> > +This example demonstrates how to setup and log different levels of
> information in *JBoss AS 7*. An example of asynchronous logging is also
> included in the configuration.
> > +
> > +The example contains just one class file and one jsp file that, once
> accessed, fires off the logging information.
> > +Also included in the example are an updated standalone.xml and
> logging.properties files.
> > +
> > +Follow these steps to better visualize the logging working:
> > +
> > +1) First deploy the jsp file and access it at <
> http://localhost:8080/jboss-as-logging>
> > +
> > +2) Look at your log files, located at *JBOSS_HOME*/standalone/log.
>  What information do you see there?  What came from the application?
> > +
> > +3) Copy the provided standalone.xml and logging.properties files.  Both
> of these files will go in your *JBOSS_HOME*/standalone/configuration
> directory.  Be sure to make a backup of your original files beforehand.
>
> Yes, I think you could do this via the CLI fine.
>
> On 7 May 2012, at 15:57, Joel Tosi wrote:
>
> >> +
> >> +What is it?
> >> +-----------
> >> +
> >> +This example demonstrates how to setup and log different levels of
> information in *JBoss AS 7*. An example of asynchronous logging is also
> included in the configuration.
> >> +
> >> +The example contains just one class file and one jsp file that, once
> accessed, fires off the logging information.
> >> +Also included in the example are an updated standalone.xml and
> logging.properties files.
> >> +
> >> +Follow these steps to better visualize the logging working:
> >> +
> >> +1) First deploy the jsp file and access it at <
> http://localhost:8080/jboss-as-logging>
> >> +
> >> +2) Look at your log files, located at *JBOSS_HOME*/standalone/log.
>  What information do you see there?  What came from the application?
> >> +
> >> +3) Copy the provided standalone.xml and logging.properties files.
>  Both of these files will go in your *JBOSS_HOME*/standalone/configuration
> directory.  Be sure to make a backup of your original files beforehand.
> >
> > Yeah, modifying standalone.xml is going to be a bad route, and not even
> the recommended approach.  Do you know if the CLI would allow me to make
> those changes - modifying log settings?  If so, I could write a script to
> do it, but then we are expecting the user to be able to execute the CLI
> script.  Is that any better?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/jbossas/quickstart/pull/114/files#r781451
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/114/files#r782391
>
plz remove this white space
Hm. Comming soon...
Just remembered that `Math` should be in scope here so you can just do `abs(M) !== 1`.
I think this hint needs a little bit more explanation about when to use or vs and. If you want to have different hints depending on a variable, you can use our `data-if` construction. You can see this in a lot of our exercises, or in the "Templating" section of our [Formatting wiki page](https://github.com/Khan/khan-exercises/wiki/Writing-Exercises:-Formatting).
This still seems wrong, and shouldn't be in the commit since it's defined in our parent POM.
This description doesn't seem to match the example.  It's returns an array with a hash in it, as far as I can tell from the example.
Probably shouldn't track upstream owner ID. A little confusing in our code but redundant data as well, we can get this info if we need it by going to upstream consumer.
This is making me quite nervous, it seems safe although it initially looks like we're allowing every call in if you just don't specify creds. AuthInterceptor actually catches that, but I can't really see any gain in adding the requireAuthentication onto principal. It's kind of confusing to throw yet another factor into the equation here and I can't see how it would be giving us any real performance benefit. I would just check for "anon" here as well on the annotation, and if it's there just skip the code. Let me know if there's something I'm missing.
Fixed to git pull
Qt5 barks on this line...
As of this commit, no... but I'm aware of it and the tests will all pass before merge.
That's excellent.  I'll look it up.
Would be nicer to always use TRUE and FALSE here instead of 0 and 1.
Right the magic incantation is the following:

```ruby
pattern = "#{javascripts.split("/").join(File::SEPARATOR)}*.js{,.*}"
```

Enjoy
Just wondering if "resource" could be given a better name. We're planning to use this for group membership as well ...
I think I curled it in here but then didn't remove it. Fixed now.
It doesn't look like this should be here ?
If an anonymous user tries to view a profile section that is public, I think you get an exception here because `context.user() === null`
Won't happen
..I just want you to update the worksheet and the play plugin ;-)
I don't see the ``@Test`` mention in the class :-)
Where is the event-dispatcher used?
Confirmed: as long as the async/await keywords are not introduced, this works fine with .NET 4 and VS2010.
Allows ```$autoload['libraries'] = 'email';``` without error, which is generally handled by the loader functions (single string vs. array), but has to be done externally here to check for "database".
Это, безусловно, хорошо для вас. Но мне кажется это не обязательно для всех. Я, например, не приступал к 3-й лекции пока не закончил ДЗ ко второй (отчего б не делать всё по порядку?)
Хотя если у вас есть время и желание вашими знаниями поделиться - буду только благодарен.
как вы потом будете "отдавать" код (бинарник) ?

Представьте себе, сколько по тексту может быть такого "для тестирования"?

Вы будете каждый раз удалять их из проекта, когда отдаете кому то код и каждый раз добавлять или держать отдельную рабочую копию?

Можно было бы в каком то заголовочном файлике сделать
#define debug 1

и потом в коде использовать 

#ifdef debug
ваш тестовый метод
#endif

тогда только в одном, заголовочном файлике можно убрать define debug
) ДА нужно.. По возможности добавлю..
Сергей, у вас есть время до 22.00 (МСК) 29 ноября, чтобы поправить алгоритм. Механизм своей проверки метода mutate я уже описывал в комментариях.
Перед тем, как так делать, нужно проверить, не отрицательное ли length?
Moved to getspout/spout, and now I cannot amend my commit because I deleted a file and added a new one. I am now officially doomed and I think I am going to make a new PR if you have no suggestions.
Author says: "Yes, but I thought it could be better"
"contains".  But by now I'm confused about what goes into the scope cookie and how.  So, now that you've defined the purpose of the scope cookie, perhaps you should go to the ABNF, and underneath define each header.
this is great work!  so nice to have all these tests and your enhancements to the connector, too.  I'm looking forward to improving the apis so that some of your enhancements can be simplified.  This really shows me more of what is needed.  I think I should perhaps do a pass where I really open up filtering in the api LOTS more than it is.  Clearly that would be useful!
"Document" can be lower-case