labofsahil/github-event-dataset-2012 huggingface dataset:
угу. не прошло и 5 лет, как зоркий глаз догадался что лошадей сперли (то есть зона обновлений в мангосе цилиндрическая). даже не смешно.
`langObj` isn't used in this file.  You can remove the preceding 3 lines.
This breaks in a lot of situations because `existing.first` can be nil:

     # NoMethodError: undefined method `using_object_ids?' for NilClass:Class
     # [GEM_ROOT]/gems/mongoid-2.4.0/lib/mongoid/extensions/object_id/conversions.rb:34:in `convert'
    # [GEM_ROOT]/gems/mongoid-2.4.0/lib/mongoid/relations/nested_builder.rb:72:in `convert_id'
    # .... truncated ....
    # [GEM_ROOT]/gems/mongoid-2.4.0/lib/mongoid/attributes.rb:132:in `assign_attributes'

and nil doesn't respond to `using_object_ids?`
If `-x` is a CPython feature, i'd rather see:

    if is_cpython:
        cmd.insert(1, '-x')
Hmm, is this typically necessary with methods that learn sigma? (Just curious, I have no experience with learning sigma.)
@FabriceOllivier I reverted the logic to parse the metric because it's too restrictive. We don't do anything by default and get the host from the agent config.
nice, work - now we can minify crafty-dev.js ;)
Awesome, good to know it's been fixed. I've seen the release notes for FeinCMS 1.5 and they look pretty good - what's holding it up at present?
My inclination would be to put this stuff in `seesaw.event`. It's nice to be able to just `:use` the namespace, but that's actually frowned upon a bit, i.e. it's better to `(use .. :only)` or `require`.  Maybe the key-specific stuff should be in keymap or keystroke? Just thinking.
I'm getting `scala.xml` flashbacks.  :-)
This was delivered as part of #80.
already done as `@border-gray`, also i backed out the helpers, i fixed this in header.less also
hmm, does this mean we require this? :)
Yeah we should, I just lost interest in writing a test with lots of mocks at the top. Good idea though.
Yo doo, I think that code is janky doo
Sir, that is one heck of a typo.
Yep I totally agree. This is actually the reason I didn't open a pull request. I was going to try to read the raw bytes without using `rmagick` but that seemed like way too much effort.
whitespace goes wonky here again
@artzstudio 
A global **require** function is one that is available in the global scope, similar to define(). The behavior of global require() is not defined by this API, and for interoperability it should not be assumed. (c) https://github.com/amdjs/amdjs-api/wiki/require

I think it means that most libraries will define *require*. And it means that users who are too lazy to read docs will look to global _require_. So, it might be good idea to export it.
Ahh, that's why the colors didn't get copyed right!
Was commenting this out necessary?
Not only did it show how to use aliases but it provided a helpful one.
Maybe I'm just being picky with this default being changed.
Non atopo lugar para deixarche un erro, desculpa por facelo aqui.

o caso é que montei un pod de diaspora, e cando os usuarios seleccionan idioma galego, no lugar do stream sae un erro.

estiven mirando as traducións de diaspora, e semella que as linguas que estan por debaixo do 80% de traducion completada dan o mesmo erro. 

a pregunta é: como levas a tradución? precisas axuda? pódesme contactar en pedro@blogaliza.org

grazas!
ach Deadii ist auch ein Deutscher xD
nope, this makes my day.  with your 1337 skills cleaning up my code, makes me feel good to fix bugs :)
Nono, definitely not. I fixed it, but I forgot to push the latest changes from my work-machine, so I'll merge everything and update to 0.4.1 tomorrow. Thanks for reporting.
This doesn't guarantee the order in which waiting tasks will become one of the executing tasks. Is the order important?
I'm still having some issues; specs pass for me in isolation and I occasionally get a successful run, so something about the order of the specs is causing them to fail.
Since you don't have an email (according to Github), I can't exactly message you, so I'll just put it here:

Is there any revision that actually works on ICS?

Most of the time when I try to run this on my tablet with ICS 4.0.3, I get the message "Unfortunately Droidsound has stopped working", and it just closes. The app doesn't even make it to the GUI before it says that.
should need scope _test_?
curly .. you know what :)
We moeten wellicht dit hiaat ergens noteren.
Интересны, ещё как интересны.
Rather than use a LAST_URL_CACHE, we could add native support to Feeds to track all previous urls they've accessed.
You're right and this is why we are now doing the more major changes in a pull request. See https://github.com/resolve/refinerycms/pull/1208

So yeah, sorry that it's been a bit painful so far, but we're trying to make it better.  I've taken what you've said onboard and will be more mindful of this from now on.
Thanks, but web still have two issues for this commit.

* http://startrack.herokuapp.com/projects/1/tasks/99
* http://startrack.herokuapp.com/projects/1/tasks/100
не тут нету alive.h =)))
我勒个去……
ooops, sorry for that !

I'll modify immediately!

Tnx,
Salvatore

Il giorno 25/gen/2012, alle ore 15:13, Michael Ströck ha scritto:

> Please ALWAYS use NSLocalizedString when setting user-visible strings!
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ViennaRSS/vienna-rss/commit/44604699035eadb1872fdd378da137735bae1499#commitcomment-900209
Yep - Previously the gear was visible sometimes and hidden others (discussion vs comment), and the gear was on the left of the star on the discussions page and on the right of the star in a discussion (or vice versa, I can't remember). In the end it was decided to put the gear beside the checkbox because their functions are similar - and then it looked dumb if the gear kept hiding because there was a big space between the star and the checkbox. In the end I just decided that the gear graying out a bit was enough - admins & mods are the only ones who see it (on comments), anyway.
is_blank() will return true if $p_date is null, so this should be 
```
if( !$p_allow_null && ( is_blank ( $p_date ) || date_is_null( $p_date ) ) ) {
```
I am a little bit concerned that this may delete my libraries that I have manually put into ./libs. Is it possible to restrict the sub-dir deletion to a list of know architectures?

How does "ndk-build clean" act?
I updated to this commit and deployed to Heroku, I am getting production errors because it is trying to load: /assets/print.css from my CDN but it was not uploaded with the rest of the assets
No, you've done it correctly.
On second thought -- I think we have some partial retry logic already implemented, thanks to the fact that we are inside a block passed to retry_execution.

The way we're using retry_execution, it seems that we are making an assumption that yum, apt-get or zypper will return a non-zero exitstatus if ANY of the packages fails to be installed.

I confirmed that this is the case for apt-get (exitstatus 100). Don't know about zypper. Based on the ticket, we can assume that yum returns success in at least some cases when a package install fails and that this is the root cause of services' frustration, but probably good to test this.

My take is that we should have consistent behavior for all three packaging commands. In other words, we should do one of two things:

1) Be dumber: detect yum failures and handle them by next'ing a non-true value from our block, as we do with apt-get or zypper failures, thus causing yum install to retry until the counter runs out.

2) Be smarter: detect unknown packages for all three install commands, and fail immediately (auditing the specific missing package names) instead of retrying for awhile.
Исправил нормально, сейчас выложу.
Ca arrive un oubli =)
Hmm, well I don't know if we can have 2 escort scripts for the same npc.
just make the query, i'll take care of the thread.
Looks great! Why use the window object for the interval timer and then assign it to a variable you aren't using anywhere else? Is it for later use?
No pb Matt. I'm struggling with git myself ;)
ahh ok, now I got it. thx
looks good, please use git cherry-pick to apply also to 2.3 branch.
And right after the commit, readme disappears from Habr. =)
Yep. Thought I'd add the comments. I don't work with Java so probably not likely to get round to setting this up and doing the edits.

There's plenty of open-source projects I could be spending my time working on, or reddit browsing I could be doing, so I doubt I or anyone from reddit is likely to help develop these projects unless there's some utility for us or the community as a whole.

If you want to work with a team and other people's code, the best thing is to start doing pull requests that solve your problems on popular or reasonably popular projects. The more popular, the more likely you would be to get ignored, so if you picked a project that you regularly use, but maybe not extremely popular but you see a flaw or something that could be improved then you may well get your changes accepted.

You can't really just setup a github account and expect a flood of pull requests unless you already have some popular project that just doesn't happen to be on github.
Well, it does not seem to be the problem here, if you say the problem remains after removing include to types.h from m68k.h (right ?).
shared.h is not included by 68k core so there shouldn't be any conflict.

It seems to me more a problem of stdlib.h on linux including sys/types.h and triggering an error either because it conflicts with an existing included file (which should only be stdio.h, limits.h and macro.h) or maybe something defined in m68kcpu.h as it is included before m68kops.h . Having a deeper look in /usr/include/stdlib.h and /usr/include/sys/types.h (especially the lines mentioned) would probably 
solve this mystery. The error message itself is quite intriguing and it's better to first understand what it means.

Btw, if you do a quick search on google, that error message seems to be quite common so it can give a better indication of something that have bene undefined and is needed by stdlib.h or sys/types.h
Nothing, yet. It's work in progress and I hope that with the code on master it will get more attention.
> I think the command should definitely contain the full path to nrsysmond-config since that program is being installed by the module.
Sure, but overriding any default path for egrep and such is not so good :-)
I don't understand why ensure would modify these variables....
Won't there be a risk for race conditions if, for example 2 threads save sagas with the same values at the same time?
Uhm closes #5263
No offense, but if you are reverting 1846 to 1864, shouldn't you be deleting 1846?
Worgen verkleidung.
It doesn't need to be modified in the sync. Only one thread would have
the lock to complete the tx at any given time.

Sent from my mobile phone

On 14 Jan 2012, at 13:07, Sanne Grinovero
<reply@reply.github.com>
wrote:

> txComplete was previously modified in the synch. Was this not needed?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/maniksurtani/infinispan/commit/c65461e2f8fbdedf7dd92c950c1f4ce9a583b922#commitcomment-867210
Reviewed :-)
Actually I probably remove the convenience methods from future releases. I do not believe anyone uses them. They were broken for a while and nobody complained.
TODO: ```wdn/templates_3.0/css/variations/media_queries.css``` will need to be updated with these new locations.
Damn fucking straight! It's getting a rewrite, so it works better (hopefully), trying to get it ready for the next series.

Andrew Lowther
Developer

+44 (0) 121 200 2627 (ext. 054)

Made Media Ltd
mademedia.co.uk
105 Carver Street, Birmingham B1 3AP

Registered in England & Wales 4530365
105 Carver Street, Birmingham B1 3AP
VAT registration 799893229


On 27 Feb 2012, at 14:11, Mark James wrote:

> Hashticuffs is back!
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/AndrewLowther/Hashticuffs/commit/457db9cd1950b603a8c9dbebc3494a7f26702896#commitcomment-1015031
敬語?
To use `respond_with` add `respond_to :html, :json` here. If your controller also responds to `xml` or `js` you can add those to this list as well.

More on `respond_with` http://apidock.com/rails/ActionController/MimeResponds/respond_with
It appears that slime.el ignores that security setting for the command ':eval-no-wait' anyway, which swank-clojure already supported.
Separate into separate var statements.
联盟的，加到一个联盟里就有了
patchSet is not part of the Change JSON data structure from Gerrit.
It is a sibling to change in the event.

I suggest you change the scheduled and remove methods to take the PatchsetCreated event as a parameter instead.
es que tio, todo lo que ponemos aqui está testeado, pero luego en RS funciona diferente, ya lo sabes, por eso el 80% de las veces damos palos de ciego con los bugs :S
Can we change this to 'When a file is added for the first time'? Minor thing :) Thanks!
Yes, that worked. Thanks for the quick fix.
Hmmm...this is tricky because permission strings can include commas themselves. A better separator would be ; or a new line.
Two problems here.

Firstly, the string you return should be acceptable to the server:

http://docs.services.mozilla.com/storage/apis-1.1.html#headers

That means — for API 1.1, at least — decimal seconds, not milliseconds.

(There's another bug that I just spotted elsewhere. Heh.)


Secondly, you need to handle whatever error will result if the X-Unmodified-Since header results in failure. Most likely you should loop, with a decrementing counter, fetching and processing commands until either a command causes an abort, or we get a clean reupload.
> rnewman, maybe we could merge at least that commit?

Merged Part 0 and Part 1.
Gah! Now [I'm doing it](e257484)! Try [this](http://gitready.com/advanced/2009/02/11/pull-with-rebase.html).
Nit: blank lines between methods.
this line is throwing an error on iphone, GL_UNSIGNED_INT is undeclared.
Doesn't `{assign var='__jsID' value='.'|str_replace:'_':$objectTypeName}` work?
see changes in 0.3.0 release.

Refactored the Decorator to reflet all changes in Bootstrap 2.
Thanks for fixing the "Uninitialized string offset" issue, with your analyzer I finally got my search engine support Chinese language. However, after I changed my default analyzer, my search won't show anything related to numbers, yet it worked with numbers before. How would you solve this issue? Cheers.
that is to say that the errors were corrected but there are several issues (popup and notifications) that need attention though.
Yes, the problem I see with that is that it makes traversing over a given path a bit more complicated. With the current proposal we have everything needed on `Node`, so one can simply iterate over a path, check the attributes of each node and print them etc.
With a sub-type based approach one would have to check each node for its type (either via `instanceof` or via dedicated methods such as `isMethod()`, `isParameter()`) and then down-cast the node to that type. 
Compared to that I felt that adding the three to `Node` doesn't add too much complexity much while keeping things simple for clients of `Path`. But it's definitely something which should be pursued.
I think it's good to be consistent with the other configurable artifacts (`ConstraintValidatorFactory` etc.).
Base config should be pulled from DefaultSamlSecurityConfig.groovy
Good point. The current patch handles that case by returning false and not attempting to remove the bucket (line #19), however, I need to also handle  the failure to delete any subdirectories (line #22)
Yes, let's eliminate decideTests()
this section makes an local native installation of libffi
I understand your point. I removed the process_x call,  but i think that if you are providing dynamic query string parameters , in the future you will end with a lot of if-else code for parameter processing vs. a simple function call to a developer-specific function.
getMatchingProperties() returns a object, like matchedProps = {'tap': 'balabalaba' };

I searched it solution in internet, but there's not better way than 'for' - http://stackoverflow.com/questions/2673121/how-to-check-if-object-has-any-properties-in-javascript
Thinking again about this, maybe we want to leave it here anyway because the static code generator will support C initially as well.
We should change this to User::isLoggedIn(); sure it does the same but it would respect the abstraction layer.
this could potentially benefit from being a FSM, e.g. with Initializing/Buffering/Writing states

I’d also remove the `active` vs. `handleOption` duplication: just have handleOrActive, where `None` means “active”
why not context.system.deadLetters?
`Message.MessageExchangeId`
1. By the same reasoning I'll refute the claim that "it's not needed here" by requesting a benchmark that shows that it's not needed here.
2. See 1
3. Anyone who is not comfortable with Unsafe and is working within the Akka codebase should definitely spend the required time to learn it.

I'm OK with leaving it as a FIXME, but please, "optimize when you have a performance problem" is not a design philosophy that I will ever agree to. Design needs to be done with performance in mind, otherwise you'll both give users performance problems AND you'll risk having to break binary compatibility to change the design to be performant.
I tried that and got a weird exception. I can look into it again but it was hard to diagnose.
It's in ```object ByteIterator``` now, like it was done for the ```ByteString``` implementations in the past. Is that enough for binary compatibility, or should it also be ```private[akka]```?.
You are relying on a hairy bit of overload resolution here: the case class has an `apply` which would also work with zero args. Is this really necessary?
I'd probably unwatch them as you iterate over them in the fold above. Turns O(3N) to O(N)
sealed case class? what is wrong with "final"?
* Isn't L56 the same as `if n in ('Infinity', 'Nan')`
* Perhaps we should catch DecimalException so the TypeError can propogate?
This method needs to be used in a few more places.  Or the underlying 'set.reset_set_patterns', which iterates through the set members resetting the patterns on each one.
What does `NB` mean? I'm having trouble parsing this acronym.
Is that kind of notation (SV) is allowed in pep8 ?
That ColorProperty sounds like a great idea :)
You can use the previously defined `d` here instead of `(self.max - vmin)`
OK - done. I had to make a lot of other changes as well, because a lot of
tests were using 'get_sphere'.

I had to do some manual conflict resolution to make it rebase cleanly on
master. Hope it merges cleanly.


On Mon, Oct 8, 2012 at 12:31 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

> In dipy/viz/projections.py:
>
> >      Returns
> >      -------
> > -    fig : figure
> > -        Matplotlib figure
> > +    ax : axis
> > +        Matplotlib figure axis
> >
> >      Examples
> >      --------
> >      >>> from dipy.data import get_sphere
> >      >>> verts,faces=get_sphere('symmetric724')
>
> Yes, @arokem <https://github.com/arokem> please change get_sphere to
> return a sphere object. I can happily merge after that.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/79/files#r1788088>.
>
>
Which line does this refer to? Both the signal and the noise here (in the Rician case) are supposed to be strictly positive, so, as I understand it abs(signal + noise) is the same as signal + abs(noise).
what about allowing 

1 day
also whitespace issue eg I use 2 spaces or a tab?

how about `'(?P<days>\d+)\s+days?'`

same with other options
typo: should be "repo_working_dir"
I didn't want to check this in but I had a feeling I was going to mess that up. It was a temporary thing to get around qpid issues. I'll uncomment.
This should not be needed. overlay decoder should know enought to setup start time and stop time properly
I was wondering if this is required because I couldn't find any audio codecs in ffmpeg with a split function.
graph comment changed.
Why is it desirable for newtuple(int) to work in one specific case, and runtime exception otherwise? That seems like asking for a bug.
Need to add the old index back!
Good find....fat finger ;)
If you don't know the length when you create the object, use an ArrayList instead. I'd rather not have a separate field for the length of the array.
i believe this is a recipe for trouble,
it would be more useful if we were syncing text as well (for search google, or linux middle click)
but right now i don't see why updating this on every selection change is needed
Weren't those custom mime types supposed to move to `plugs/` and not be handled in `tree` ?
Overrides should always invoke `super` if possible, because it leads to consistent subclassing behavior.

Consider the case of two `TUITableViewCell` subclasses, which exist separately at first, but then one is later made a subclass of the other. If its `prepareForDisplay` method isn't updated, the behavior will suddenly be incorrect. It's safer to just always expect a `super` call.
How about `darkScrollerTrack` and `lightScrollerTrack`?
Can you add a comment here explaining why the code looks like that?
Keep 10 s traffic history in memory to control throttle.
Do we really want to support ppc?  I'd rather not.
Sorry it is my first pull request. Should I make new or it is good as example to fix the error?
repoInfo.isEmpty()
There is something solvable but unsolved, which is a way to link to the API (or viceversa) that links to edge in edge, and to stable in stable.

Absolute or relative paths work out of the box for in-guides or in-API links, but we need to invent something for cross-references.
I think we can get rid of this parameter.
I've collapsed them into a single check and squashed into the commit.
I'll put it on top if someone wants to merge it, keeping it there will keep the merge-button green + I do not get a merge conflict on the next rebase.
If you can + want to merge it, let me know :)
Is there a specific reason why you are referring to the `attribute` with the name `method`?
Before my eyes well shut with sand,  how do I get an instance of a
treeBuilder from global?  My grep reveals things in Parser, which I thought
would be easily obtainable from global.

I'd love to use makeNew to avoid having to recreate the whole tree, but it
doesn't seem to be exposed anywhere besides on a parser, and I don't know
how to get one.
I bet you meant to write u.nme.defaultGetterName(method.name.decoded, index + 1) rather than hardcoding "$default$".
OK, I've added a few newlines here and there ;)
yeah but it's a pain in the ass when trying to copy and paste. i don't like them either.
Again, are these placeholders for functionality that should be added?
We need some logic here to trigger the calling of `Density.doit` to get the density operator into a sum of `OuterProduct`s.
Change Matrix here to SparseMatrix
Ok no, but the function already exist in AbstractGenerator
Instead of having the logger in test_discovery and importing from everywhere else we can just use logging.getLogger('testify') in all importers. logging manager will give us the same instance anyway.
Added commit to use ClassRegistry.
Yeah, maybe. However, as a user, if you don't request anything about the extension, would you expect the method to do something special about it? I don't.
I love that you're using simple quotes as much as possible! :+1:
Does _linux means also mac? Just add this to comment, no need to change the suffix.
Oleg brough this up earlier, can you use a $this->lang('key') function instead? That function should throw an error if the language variable is empty. Otherwise we might not notice errors cause empty strings are pretty much guaranteed to be "contained" ;-)
I turned it into bunches now, so we don't run a query for every user anymore.
Is this run for each extension (i.e. so it looks in every extension  for an X.html) and one file is returned for each one? What is the order of extensions it searches in?
@russellhaering There is no logic leakage here - interface is just more generic and future-proof so it can also be re-used with code which already knows the type (aka plugins in the future).
AppSettings.Domain is already a string.
Rename `func` to `convention`
SessionCache
is this a duplicate file (of index.html) which should be removed?
Make sure jar is put in repo or added as dependency to fetch upon built
I don't see Theano as ever thinking about MPI at a high level the way it does with GPUs. Theano in this case is being used my some other MPI-aware program.
It's confusing for the type of sem to be (sem_t *) in one function (main) and then (sem_t **) in the subsequent function (controller_main).  How about changing sem to psem in controller_main?
Maybe querying the tables AFTER inserting into them would be a fairer test?
"if self.model and self.model.type == DeviceType.rack"
All above is equivalent to:

```
old_cores = 0
for span in HistoryCost.objects.filter(device=device).order_by('-end'):
    old_cores = span.cores
    break
```
It is an idea/style that definitely has benefits, but it is quite unconventional in my experience.
Added statement at top of the page where it is first used.
That's over my head, but note that I have tested it without problems (see description), and [the documentation doesn't mention it](https://docs.djangoproject.com/en/dev/ref/templates/builtins/#now). I don't think I checked if I really needed to escape all of them though.
It should have! just fixed. :) Thanks!
I started with that. Then things got out of hand. :wink:
Thats <a href="http://jsperf.com/length-vs-no-length">cool</a> and all, but it's costing 35 bytes, even though i compensate it by moving variables definition around given -43 bytes.
Right. It will be changed to text_svec.
There is a link to `/mopidy/` further down, which uses `mopidy.html` as its default page.
This line is longer than 80 chars. Format it as follows to make flake8 happy:

``` python
        return [
            SpotifyTrack(track=t)
            for t in album_browser if t.availability() == 1]
```

Same applies to the two next return statements.
I couldn't find a good way to get SimpleIndex from the signal handler in a generic way, so I added a way to get it.
I think you could code this in a way that doesn't use `ENV.macosxsdk` so that it gets pulled and we get a working wxmac on Lion, by using `if MacOS.xcode_version >= "4.3"`.  Even though your work on XCode w/o CLT is pretty awesome, it would be nice to disconnect these issues for now.
Usually, if we say "with system's foobar" we mean the one provided by OS X. 

I'd just remove this option alltogether and always build with it because the biggest fan of cloog seems to be gcc and gcc wants cloog with isl. 
Isl builts nice and quick, so I'd vote to make it the default.
How does altering the wiki settings for a request effect the rest of the application? Are we sure that changes only effect the current user? Do we need to add something to ensure that it gets reset properly after the processing?
Sure will add a bit more.
Uh, but you shouldn't be hard coding includes here at all.
Don't hate to ask.  It's how I initially did all the delegating classes, but moved to Lists for a bunch of reasons that are no longer valid in the re-worked code.  Done.
`if !isMac && !isLinux; then`
neither am i. german. we are known for bad english ;)
This guy is only for our test node environment.
This check is only done on the base url, which we decided is encoded. We only check special chars (`[ ^[]{}<>\"?`) and not content, so it seems like a reasonable check.
I think omitting ``return false`` is causing this new bug #2193
I think ``resolveNativeFileSystemPath`` is a more appropriate example. Thoughts?
It's in beforeEach(), but outside the `if` block above, so it will run before each testcase (each `it()`).
This whole map tracking the inline widgets feels a little sketchy to me... @GarthDB, could you clarify what this is used for?

The core inline-widget functionality already prevents opening two inline editors on the same line, so we don't need any code here to do that...
This docstring is good, but we should try to use more narative docstring.
Rather than writing what the test does, we should try to write what the test is expected to do.

For this test, the current docstring is ok and no need to update it:

For example:

    The temporary folder allows creating any files with writable permissions.
tests generally don't use the author annotation. It is only used for the code itself
I'm still reading into resque, but making unrelated changes like this is generally bad practice in a PR. Not sure if @hone cares or not.
Instead of adding style="cursor: default" to each of these, you can add some css wherever `.filled` is defined. Something like

```css
.filled > label {
    cursor: default;
}
```
It technically wouldn't matter since superfeedr cannot ping back and nobody could subscribe. It'd just look like noise. Catch the exception instead.
@karolherbst
No no, we will not go over `HTTP_REFERER`. It does not work always and especially not when using HTTPS (browsers do not send it with HTTPS).
Do you need to finish/flush the response somehow? My browser just waits until something resembling a timeout occurs.
Move this above the `if ( listener )` check at 239, then get rid of that check totally, since you'll know listeners is non-null.
I'm not sure this should be here. I think you want to use the `-f` command-line switch to _add_ these files. `-f` means force, so you'd be circumventing this `gitignore` file by specifying it. Media files are ignored here on purpose, so the tree doesn't become bloated. If you want to add them explicitly, use `-f`.
add a space after this line
strange whitespace here
is this link still what we want?
the tabindex must be unique (and changed for the next buttons/controls)
This should be
```python
if count == retries:
```
since you changed the while condition to `count < retries` and since this will never be reached if the retries are infinite.
I would replace with a

```python
import youtube_dl
version = youtube_dl.__version__
```

This would work, right?
As a general rule, you'll probably not want to add any new variables here, but instead use Einhorn::State.

Einhorn::State persists across reloads, whereas all of these variables will be blown away.
change 'son' to 'child'?
Should probably add an /rss/ version of the no slug url, too. Either that or (probably better) re-write these url patterns so the slug is optional.
Changed to commit as author is unresponsive re tag.
Andrei, I fully agree with you ;-)
One of the problems right now is that what we call "patch releases" are indeed not really patch releases because LHCb is not ready to go to v6r6... Therefore this PR was supposed to go to certification prior to going to production. Indeed I should have put this code into the development machine, but most likely due to my ignorance, I don't really know how to do that, neither how to test an agent locally. I'll try and learn on how to do it and then come back with this PR, which is not urgent now that the DB schema was changed...
Apologies about that :(()
Le 11 nov. 2012 à 12:04, Andrei Tsaregorodtsev a écrit :

> In TransformationSystem/Client/TaskManager.py:
> 
> >        oRequest.setSubRequestFiles( subRequestIndex, requestType, files )
> > -      requestName = str( transID ).zfill( 8 ) + '_' + str( taskID ).zfill( 8 )
> > -      oRequest.setRequestAttributes( {'RequestName':requestName} )
> > +      oRequest.setRequestAttributes( {'RequestName':self._taskName( transID, taskID )} )
> > +      oRequest.setCreationtime()
> This is a bug setCreationtime() -> setCreationTime().
> 
> A general remark: the bug itself is not a large problem as it can be fixed easily. The point is - are the changes in this Pull Request actually tested ? This PR is supposed to be part of a patch release which will not go into certification testing. So, the test of the changes are under the responsibility of the developer, which is of course a certain risk considered to be acceptable for patch releases. If even me and other developers try to look through all the PRs for evident inconsistences, we do not actually test the changes. Therefore, the rules of thumb for the patch PRs:
> 
> put in the patch PR only changes needed to fix a particular problem
> do not mix in in the patch PR other code changes ( beautifications, syntax sugar and other pylint recommendations ). These changes complicate the code changes inspection and sometimes can introduce unexpected bugs
> try to test the changes in the developer environment as far as it is reasonably possible
> —
> Reply to this email directly or view it on GitHub.
> 
> 

-- 
Dr Philippe Charpentier
J09210, Physics Department, CERN, CH-1211 Genève 23
LHCb Experiment Distributed Computing Coordinator
Office 2-R-007, Tel : +41 22 767 4244 ,  GSM : +41 76 487 0167
mailto:Philippe.Charpentier@cern.ch  http://cern.ch/Philippe.Charpentier
The indentation changes look unnecessary. why were these changes present?
how come we don't need these in promotions anymore?
Done

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/plannodes/UnionPlanNode.java:
>
> >      public UnionPlanNode() {
> >          super();
> > +        m_unionType = ParsedUnionStmt.UnionType.UNION;
>
> NONUNION should be the default to make sure we are always explicitly
> setting the correct value wherever we need to instead of accidentally using
> UNION.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665953>.
>
>
You mean something like `ScreenManager.toggleScreen(bool waitForPaint);` ?
This is wrong. We never render `background.html` onscreen, keyboard shouldn't be the exception here.

This should be `index.html`.


I understand this is necessary for `postMessage` hack -- actually not setting up `mozbrowser` for the background service iframe is incorrect -- so let's leave this for now.
Does each script get its own unique set of job numbers? This %1 won't accidentally kill some other job running in the user's terminal, will it?
I haven't seen job control used in shell scripts before.  (Though I don't go around reading shell scripts very often :-)
I think I need to comment this change. 
I introduced a new local variable to store the flag IsNavigationLocked because without it access to the private variable m_isNavigationLocked in m_webPage after calling 'emit' crashes PhantomJS.
Perhaps this should be changed to a private function and used only inside the property (or just move the actual implementation there?  It's a bit confusing to have two different ways to get the physical type (unless there's some case where this sometimes needs to be used instead of the property)
@astrofrog probably good idea. I think as release for 0.1 is getting closer, we should put this on the 0.2 milestone. What do you think?
Here it looks like you don't accept ``d`` and ``º``. I wonder whether maybe these lists should be made module-level constants?
Fair point. Fixed.
ACK, that describes better, what can be done there. Will update.
Where is IS_LOCKED defined?
This looks great. The only test I would add is one investigating the transaction built in buildTransaction for some state set up by the test.
Missing line break before and after. They are 3 independent logical blocks.
"prepare_toolkit" might be a better name for this function. It doesn't always set the common toolkit, and it actually creates and returns a toolkit instance.
BTW, I just looked through the source code, the "rel" attribute isn't used inside of createphp, but is needed by Create.js. But there is one use of "rev" in the REST handler when it tries to find the parent for an object that is about to be created. AFAIR, the difference is that "rel" causes Create.js to send child identifiers for an entity while "rev" causes it to send the parent identifier (i.e. about attribute). So rel might be "dcterms:hasPart" and rev might be "dcterms:partOf". So effectively, collection has to be validated to have both, but AFAICT, they can have the same name, because they are never sent at the same time for one entity (although I don't know what would happen if the entities are nested three levels deep).
`mgc` may be just a function here, in which case this will raise AttributeError on im_class.  To see this, simply run this block in the qtconsole on master, where `%guiref` is such a magic.
Remove setup2.py, we do not have it anymore.  You are going to have to manually insert the changes you made into the single setup.py.
This PR is meant to decouple the code cell, kernel, and notebook objects in JavaScript.  It doesn't change the weak notebook/kernel coupling in the notebook server though.  That is a separate issue.

Sent from my iPad

On May 8, 2012, at 1:42 PM, Min RK<reply@reply.github.com> wrote:

>> @@ -46,46 +49,45 @@ var IPython = (function (IPython) {
>>         return msg;
>>     };
>> 
>> -    Kernel.prototype.start = function (notebook_id, callback) {
>> +    Kernel.prototype.start = function (notebook_id) {
> 
> I don't understand, isn't this coupling precisely the issue this PR is meant to resolve?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1697/files#r791160
Fixed in c4958e6818399f401f03986db8772016a97377d7 :fire: :fire_engine:
Glad you commented on this one, because I wanted some feedback on the method signature as well.

The two optional params, `raw` and `gzip` seem awkward to me. Basically, I want 3 options, raw only, gzip only or both. What's the best way to implement that?
More possible `php_url` usage spots
'model' holds the name of the model. Instead of searching by doctype, we're going to filter on the model. The model value is cls._meta.db_table.
This should get a docstring about what it does.
`window.location.href`?
That's there so they can check the data. The reason that error handler gets
invoked is because the JSON couldn't be parsed meaning the server returned
bad data. This usually happens when an nginx server error happens and we
end up with an HTML error page getting returned. We return the data so they
could check the bad data / html error page returned by the server, and
debug.

On Thu, Oct 25, 2012 at 2:56 PM, felix <notifications@github.com> wrote:

> In lib/tools/index.js:
>
> >            }
> >            try{
> >              data = JSON.parse(data);
> >            }catch(e){
> > -            console.log(data);
> > -            callback({
> > +            return callback({
> >                error: 500,
> >                msg: "Bad response from server. Check response data"
> >              }, data);
>
> it's odd to pass data back when also sending an error - is anything
> expecting this?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ordrin/api-node/pull/5/files#r1945057>.
>
>



-- 
Jason Teplitz
not doing this per-request is very good
you should rename it to ``route name``
extra space here :)
you should wrap this call as it will fail for Windows users, making the vendors script unusable.

Btw, is it really necessary ? Travis uses Composer now in master
you should make it more clear that the selected value is a a *key* of the ``$choices`` array
How do you feel about ISO8601via toISOString() ?

perhaps we can pass in a date format instead of just `true`?  if the format is "ISO" or "ISO8601" it does it that way?
For prepared queries, the '?' are just expanded and the replacement happens on the server. This allows for calling prepare("select * from table where id in (?)", 1 to 10) as opposed to prepare("select * from table where id in (?,?,?,?...", 1 to 10)

For regular queries, the parameters have to be replaced. This also allows for cleaner client apis that don't require StringBuilders and String concatenation to build a sql statement.
Are you sure you wan to commit this settings?
trebuie să fie în controller încărcarea din bază.
I suggest putting neigh as a mutable data member, so as to have only one dynamic allocation.
Add "neigh.clear()" here.
cleanup too?
a rien
When I look an ellipse with aspect ratio of 1.4 or 1.5, it seems too oblong for one sample; two samples looks more appropriate to me.  But when I  look at an ellipse with aspect 1.2, two samples seem wastefully close to each other.  Around 1.3 I'm on the fence.  This is just my intuition looking at the ellipse and saying "where would I plop circular samples to cover this area well?"

For a more principled approach, the "real" formula ought to be nsamples = int(2*aspect-1).  I can explain the derivation if you want, but it helps to draw pictures, but basically that's what you need for "perfect" coverage. Note that this kicks in the second sample only when aspect >= 1.5 (as you suggest), but also makes twice as many probes for high aspect ratios, which really adds to the expense without (as I tested) making a quality difference I could notice.  I was hesitant to increase the expense for no visual gain -- so far all my changes in this patch are performance-neutral, only improve image quality.

An open question is whether tweaking just a bit -- keeping asymptotic nsamples ~= aspect, but changing the offset to 0.5, makes a visual difference.  I will run a full set of production tests that compare ceil(aspect-0.3) [my code], ceil(aspect-0.5) [your suggestion], and floor(2*aspect-1) [what the papers and my math say should be ideal] and see if there are any visual differences.

I'll get back to you on this, SIGGRAPH and all, but I ought to be able to squeeze enough time to kick off benchmarks during idle moments.
Could do.  It was partly due to the symmetry of gem_dependency_with_name vs locate_gem, which have quite similar implementations, and partly a lead-in to https://github.com/jdelStrother/bundler/commit/d5cb470405975f364c29a9f88b5a97e87d6a1bc1, where it seems like there's enough going on to justify it's own method.
But I'll recommit with your suggestion if you'd prefer.
no need to implement DescriptionProvider anymore
Bartosz Baranowski tried to include reloads in integration tests for 7.1.2, but we found it screwed up the test suite on the client side (the reload would close connections and the clients wouldn't recover.) I don't know if this has been improved while I've been on PTO. I'll check into this next week when I'm back in my office.

Anyway, I don't think we should need to reload the server to clean up after this test -- if we do that's a sign that something isn't working properly.
As far as I remember, this method was added specifically for purpose of rewriting/mocking this class. Well, it turns out to be not the most flexible solution.
Instead of introducing more complexity to it, I'd recommend to look at it from different angle:
* Have the mailer instance in the state of this object (represented in the `_mailer` attribute) with "lazy initialization" getter. And implement setter.
* Or rather pass the mailer as argument to the `send()` method

Both approaches supposedly will give more flexibility and remove necessity to rewrite the class. Besides, such changes can be covered by a unit test (unlike the proposed solution which is too coupled to application instance, hence integration tests)
oops need to kill that was going to do something fancy to reduce the addEventListener('complete') calls but it turns out addEventListener was smarter then I thought!
This is also a case where we want to use the mail address parser logic to potentially split the string into name and address.  Please put a // TODO comment here for that too.
wouldn't be ok if we call activityAction from here? we are doing the same checking again
it would be better to call contacts.List.getContactById , thus we will not be duplicating code here 

thanks
This variable seems unnecessary.  I'd just use fileSize below.
Can you open a github issue for that and reference the issue number here.
is |typ| a typo ?
I like your idea to disable the buttons in the HTML, so I did it!
Absolutely ;-) Just received the corresponding images. Thanks! ;) Including the image files right now... :-)
renderThreads: function "cl_renderThreads"(pendingMsg). Please sync the naming change.
Ok then :smile:
Also, rename method to `set_xhr_current_location`.
I will take a look :eyes: /o/
You forgot this commented out line, which is a duplicate of the one below
Sounds good. Gotta get those Scala folks to fix this shit up!
A few things:

1) It appears this only works for TupleEntries of primitives. Is this right? Or rather, it just calls .toString on each item. Can we get a comment to this effect?

2) This is not reversible. Do you want to add transformForRead that creates TupleEntry of strings?  Cascading's type coercion would make things work properly for the primitives.
Why not put it in the LowPriorityTuplePackers?
Perhaps we should centralize these checks at some point...
You have a number of row generators - why not extract them outside of these inner functions?
main => primary.
Which translates into
```
if (postID[1] === 'submenu') {
  o.type = postID[0];
}
```
How does that make no sense?
You should use StringBuilder not StringBuffer
Also, this class and its methods should be documented in `database.rst`
from what I know of some other implementation of jsonRPC server side (e.g. gerrit), the features I dont implement are optionnal
I think spaces before and after `[]` are unnecessary here, for consistency with L229 etc.
I think "Suggestions are displayed" would be less confusing, because installed packages sounds like it might be the suggested package that is installed.
undefined property infoCache
How would it map 'EFDataManager' to 'mainBundle'? Would it still by default use the main bundle?
It was needed at first. I decide to keep it as we have two different objects.
Query is missing catid: please make sure that it's not used!
I guess in this case you could just use `Map` since `workerWindows` will hold a reference to `WeakMap` keys
preventing GC to claim values. Also `Map`'s are iterable so having one Map would have replaced WeakMap and array.
I think you can export them directly, no need for ERRORS
Can you please use il/else if/else?
Turn that frown upside down!
oops.  removed.
I'm trying to find the style guide that says this, but I like:

```javascript
Capitals = require('ForClasses');
camelCase = function() {} || 'non-top-level-classes';
var local_variables = 'should be underscores';
```

Thoughts @ednapiranha or @brianloveswords?
pep8 like a new line at the end of the file
Actually no, it is with minus when you want to calculate gamma from
the velocity, in this case (as Andreas wrote, thanks again) it is the
relativistic momentum, so when one does the calculation, it gets exact
with + sign. I will try to find the calculation and post it.

2012/5/19 Kirill Streltsov
<reply@reply.github.com>:
>> @@ -0,0 +1,19 @@
>> +package org.openpixi.pixi.physics.solver.relativistic;
>> +
>> +import org.openpixi.pixi.physics.ConstantsSI;
>> +
>> +public class SolverRelativistic {
>> +
>> +     protected double c;
>> +
>> +     public SolverRelativistic(double c) {
>> +             this.c = c;
>> +     }
>> +
>> +     /**gamma = sqrt[1 + (u / c)^2]*/
>
> This is not gamma!
>
> Gamma is Sqrt[1 / (1 - (v / c)^2]
>
> I understand that you do not do the division but rather divide by gamma in the solvers, maybe that increases accuracy so its fine but you are definitely missing a minus sign there!
> https://en.wikipedia.org/wiki/Lorentz_factor
>
> If this is intended pelease add an explanatory comment.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openpixi/openpixi/pull/19/files#r849620
Hmmm...I guess I totally disagree ;-)  

If I'm going to use a library called Underscore, it should try to have the same signature as the original if possible: 

```
_.each([1, 2, 3], function(num){ alert(num); });
=> alerts each number in turn...
_.each({one : 1, two : 2, three : 3}, function(num, key){ alert(num); });
=> alerts each number in turn...
```

If you really want to supply a safe version, I would provide both _.eachArray/_.eachDict and _.each without block type check. If people are unhappy with the lack of type safety on _.each, they can use the safe version. But give them the choice! (personally, I would not use _.eachArray and _.eachDict).