labofsahil/github-event-dataset-2012 huggingface dataset:
Yeah, I wasn't exactly sure what to do about the case where every parent
would have no node.  It will fail the same way, it just tries harder ;)  If
there are no parent nodes, where would we render something....floating
layer, appended at the end of the document, etc.?

On Sat, Sep 15, 2012 at 3:27 AM, Ben Combee <notifications@github.com>wrote:

> In source/dom/Control.js:
>
> > @@ -629,7 +629,7 @@ enyo.kind({
> >  		}
> >  	},
> >  	getParentNode: function() {
> > -		return this.parentNode || (this.parent && this.parent.hasNode());
> > +		return this.parentNode || (this.parent && (this.parent.hasNode() || this.parent.getParentNode()));
>
> took a moment there, but I see it's recursive now... it could still return
> null, but only if no parent in your chain has a node.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/enyojs/enyo/pull/143/files#r1613400>.
>
>
I knew someone would ask that... the reason I'm drawing into nothing is because otherwise the cell doesn't calculate its knob rectangles. I'll see if I can work around this messy drawing xD

What return value am I ignoring?
`__block` is not sufficient to make a variable weak under ARC. This should be:

```objc
__unsafe_unretained TUIActivityIndicatorView *weakSelf = self;
```
I suggest dropping this test or move it to test/disabled/
That doesn't look correct: `sizeof(const char *) - offset_`?
I think the main idea was to make `worker.on('exit')` match `child_process.on('exit')`.  This makes sense to me - ideally, anything a developer learns about using the child_process module, should be transferrable to using the workers produced by the cluster module as well:

using child_process:

    var cp = child_process.fork(process.argv[1]);
    cp.on('exit', function(code, signal) {
       // ...
    });

using cluster:

    var worker = cluster.fork();
    worker.on('exit', function(code, signal) {
      // ... works the same as child_process
    });
Might be more efficient to move the regexp out of the loop.
And spaces between function arguments.
This needs to be reworked. I think a separate plugin should provide the SelectFeature control, and it should be reconfigured whenever a feed layer is added. Otherwise this will only work for the topmost feed layer. That plugin should also use addOutput for the popup, and use a GeoExt.Popup instead of OpenLayers.Popup. The content for the popup should be generated by an Ext.(X)Template, which is configured on the feed plugin.
Good catch, I wonder how it even compiles

> -----Original Message-----
> From: Anatoliy Belsky [mailto:reply@reply.github.com]
> Sent: Wednesday, July 04, 2012 9:43 AM
> To: Clint Priest
> Subject: Re: [php-src] Property get/set implementation (#32)
> 
> > @@ -34,6 +34,23 @@
> >
> >  #define FREE_PNODE(znode)	zval_dtor(&znode->u.constant);
> >
> > +#define IS_ACCESSOR(purpose) ( purpose >= ZEND_FNP_PROP_GETTER && purpose <= ZEND_FNP_PROP_UNSETTER )
> > +
> > +#define MAKE_ZNODE(zn, str)	 \
> > +	{															\
> > +		zn.op_type = IS_CONST;									\
> > +		INIT_PZVAL(&zn.u.constant);								\
> > +		ZVAL_STRINGL(&zn.u.constant, str, strlen(str), 1);		\
> > +		zn.EA = 0;												\
> > +	}
> > +#define MAKE_ZNODEL(zn, str, l)	 \
> > +	{													\
> > +		zn.op_type = IS_CONST;							\
> > +		INIT_PZVAL(&zn.u.constant);						\
> > +		ZVAL_STRINGL(&zn.u.constant, str, l;, 1);		\
> 
> that ';' on line 50 is obviously a typo
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/php/php-src/pull/32/files#r1100500
Where does the 50 come from?
Этот код нужен?
I mean, you could go with:

```ruby
(defined_app_const_base? ? defined_app_name : File.basename(destination_root)).gsub('.', '_')
```

Also you could use `tr` instead of `gsub`.
I'm not sure how does javascript vs js.erb relates to asset pipeline. Both features were available before assets pipeline.

Also, I'm not saying that I don't like documentation of how to handle ajax form in rails using `:remote => true`. I'm just saying that I don't believe that any of this approaches is superior.
Thank you for reviewing.

I agreed and updated :-)
Yeah, I just noticed this. Should I go ahead and fix? Any preference between amend/force push vs. multiple commits in a feature branch?
Also it's not overwriting any original roles, the `Array(role).each` is looping through all the given attributes for that role, then if there is an inherited role it will gather those attributes as well, then the `+ args` below will gather the current roles attributes.
You are correct.

-- 
Sent from my iPhone
[This can receive `nil`](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/form_tag_helper.rb#L644) when you don't give an explicit `authentication_token`, it's actually required to test `!= false` for it to generate one automatically.
@dragos @harrah Just thought I'd check: are you guys overriding `logThrowable` or otherwise plugging into the crash handling methods?
"Reasoning: we should try to outdate-proof the docs."

This line of thinking is "comment nirvana" for me.
Are you talking about the commenting or something about the code?
I agree. let's change this before we include the pull request.

how about adding a "julian_date" kwargs that defaults to False. If it's true, the values are both treated as julian dates; otherwise the second parameter is treated as an offset if it is an int or float?
Nevermind, just saw it at the bottom.
You need to worry more about None than 0 and 1 in the assumptions.
Inertia_tuple -> inertia_tuple (PEP8)
This is the `usympy.py` file
null'a gerek yok, undefined'a hic gerek yok.
besides, `fig.pos` is not a good name; it has been used in http://yihui.name/knitr/options to denote the figure positions in LaTeX, so I recommend you to use `fig.paths` here
把else单独放一行是个坏习惯，它应该跟在别的语句后面。如：

```r
if(options$fig.align == 'default') swfhtml else
  sprintf(paste('<div align = "%s">\n', swfhtml, '\n</div>'), options$fig.align))
```

对这个特定的函数来说，以下是我个人的风格：

```r
if(options$fig.align == 'default') return(swfhtml)
sprintf(paste('<div align = "%s">\n', swfhtml, '\n</div>'), options$fig.align))
```

主要原因是它能避免一级缩进。
@senz Good books about Refactoring will tell you more. Refactoring its not about idiotic duplicates eliminating. Its **smart** process. You have get:

>I don't like the new methods mkdir() and getModeFromOptions().

You say:

>I do not agree

You get more explain:

>I totally agree big chunk of duplicated code or code that are repeated many times should should be refactored with methods...

You say:

>I do not agree (not literally)

What do you expect on that?
Add: $editprofileForm->setAction('updateprofile');

Dafür in der Form selber... im Init die Action nicht setzen!
So wird die Form wiederverwendbar... Und der Verwender muss selber bestimmen, wohin die Form geschickt werden soll
chapter user manual gots lost?
Style: align the backslashes on colum 79.
Integrate the gem with our log gem. Don't set the log filename, it is automatically set as default. Yaron will make automatic different log file for each executable.
The meaning of the value is default value which can be nil.
Please resolve this URL on server
Yep, you're right
Oh snap. @TooTallNate got a PR with better wording? I do think Socket.io is an example of the energy that a custom TLD can turbo boost.
real_file_name
Should probably exit with an error code. E.g exit(3); rather than return.
I measured 0.02s.

I do see your point, but then I need to add:
global $phpbb_container;
$phpbb_container->get('notification_manager');

to all the functions that use this, which could make testing significantly more difficult for these functions.

What do you believe should be done in this case?
The test to make sure they are logged out is below.
Not sure, that is a generated file. I didn't modify anything related to symfony.
fixed in fb07fbc
Sounds like movable vector, not movable object. Sets movable object's position I suggest.
Not quite sure what this line is about but I've removed it now.
Last one (sorry)
To make this consistent ``get_connection`` and ``get_queue``, could you please make it return worker for the ``default`` queue? If we don't have this we won't be able to do what we recommend in the testing docs :)

```
    def test_something_that_creates_jobs(self):
        get_worker().work(True)  # Processes all jobs then stop.
```
I did that initially, but then thought of "search-app" that does not use that convention for their addons. If the norm is "xxx-addon", sure we can proceed the original way.
Unfortunately `process.cwd()` doesn't point to the app's directory in Manhattan, so I think you'll need to use something like `libpath.join(__dirname, '..', '..')`.
Well, the idea is to provide an abstraction layer, not only for process, but for any kind of data storage based on our definition of data scopes. For that, and special the client side, YUI has the `cache` module and `offline-cache` as well sharing the same api that supports expiration, maximum, etc. And this is the API that they use today where request and response are generic data structure, and they can be serialized when needed.

http://yuilibrary.com/yui/docs/cache/
Replacing the block above means this should be removed.  Specifying zmq prefix and explicit lib/include dirs should be separate.
) { - так правильно
code style - should be 

}

else

{
Use `process.platform` for better version compatibility (I think 0.4.x doesn't have `os.platform()` or something like that).
Ah, right. I think it is okay in there for now as long as we are keeping the code.
is it used or not? should you delete it?
Wouldn't this break this test?
Please vertically align long_name. You don't need ```units="1"``` either as it is the default.
@bjlittle 
> At the very least, I'd agree to adding a fuller comment.

I'd say that would be nice. I
Maybe just make a fuller note right here, like ..
```
        # Ensure data is row-major contiguous, needed for the zlib.crc32 call
        # used for checksum calculations in Cube._xml_element.
        if not self.data.flags['C_CONTIGUOUS']:
            self.data = numpy.ascontiguousarray(self.data, dtype=numpy_dtype)
```
?
This pull request is complete. The op is still a work in progress, in that it doesn't implement many important cases.
Copy/paste issue at end of line?
They still don't.
The case seems to be (and you're right, I didn't fully understand the function when I hoisted it for re-use) that {repl, TS} is always the ultimate or penultimate state when you calculate timings. Meaning that line 49 then gets the reply timestamp from the list, as `undefined` is matched as the 3rd argument to the function.

Options are: 
1. refactor so the function does what it seems to be supposed to do (calculate times for all states up to reply time or
2. Document the assumption that `reply` is the final or pen-ultimate` state in the list of timings

I think 1 is the right thing to do, but will require more review from you.
Why don't you need this anymore?  Must be included in another header already?  We should settle on a style for this (if we don't already have one).
Indented wrong.
You don't need this, it's just ``frozenset``.
Stupid nitpick: `bytes` is a builtin; shadowing builtins is usually frowned upon. I'd say it's worth changing here (e.g. to `bytelist`) since what we're doing in this module is relatively byte/string related. Could bite us later (pun unintended.)
i agree, so let's move into that direction

I guess you are not on #guzzlephp too much


On Wed, Oct 31, 2012 at 2:58 PM, Michael Dowling
<notifications@github.com>wrote:

> In src/Guzzle/Plugin/Oauth/OauthPlugin.php:
>
> > @@ -68,12 +68,15 @@ public function onRequestBeforeSend(Event $event)
> >      {
> >          $timestamp = $event['timestamp'] ?: time();
> >
> > +        $microTime = microtime(true);
>
> Good catch @glennpratt <https://github.com/glennpratt> . I also think it
> would be better to use uniqid instead of microtime.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/guzzle/guzzle/pull/153/files#r1997357>.
>
>
you know that this is no typo?
Oh, no, that's just the current state of accounts-ui. All of the underlying code is (or should be, at least) set up to support multiple login services. A user can have services.password, services.facebook, services.twitter all set up, and all of the code around updateOrCreateUser should do the right thing.
Then, I try to delete it assuming it to be a Windows style symlink, by using `del` and `rmdir`. This way a `rm` will not directly cause all files in the `node_modules` folder of ` dev_bundle/lib` to be removed, but do remove a Linux style symlink. As I use `||`, the first command to succeed will prevent later commands from being ran.
Whoops--the sucky thing about diffs is that they don't show the full file. I see the other call to GIT_SUBMODULE now, so this should be fine.
It's is indented, but using tabs. I'll replace it with spaces.
Thanks, I would have had them installed anyway. I'm an idiot.. I was actually just looking at another repo that does that. I'll rebase and push again.
haha ^^ [but still](http://www.slate.com/articles/technology/technology/2011/01/space_invaders.single.html)
@jacknagel it reads so nice with `Formula.installed` :-)
There is no formula for expect in core.
I think that you should only mention LeaveOneLabelOut as an example of usage, rather then the main purpose of this entry.
List is for all keys, show is intended for a single key.  Rhc app list will show all apps, rhc app show an individual app.  Domain show is for a single domain today, eventually will be domain list.
That's not cache, that's looking up in the mapping table which username belongs to which DN (or UUID). The thought behind this is, when a username exists, it must exist in the mappings table (triggered by a getUsers or similar method, which e.g. is called when creating the sharing dropdown).
> Предлагаю избавиться от запятых, упростив его так

Не уверен в таком варианте. Особенно "восстановление сервера" смущает.
Ah, hmm. good point. `asobject_tz_box` is actually not doing the right thing (and it disturbs me that the test passes). The issue is that there is a base time zone object that is obtained from `pytz.timezone` and Timestamps actually receive one of its tzinfos:

```
In [4]: tz._tzinfos
Out[4]: 
{(datetime.timedelta(-1, 68400),
  datetime.timedelta(0),
  'EST'): <DstTzInfo 'US/Eastern' EST-1 day, 19:00:00 STD>,
 (datetime.timedelta(-1, 72000),
  datetime.timedelta(0, 3600),
  'EDT'): <DstTzInfo 'US/Eastern' EDT-1 day, 20:00:00 DST>,
 (datetime.timedelta(-1, 72000),
  datetime.timedelta(0, 3600),
  'EPT'): <DstTzInfo 'US/Eastern' EPT-1 day, 20:00:00 DST>,
 (datetime.timedelta(-1, 72000),
  datetime.timedelta(0, 3600),
  'EWT'): <DstTzInfo 'US/Eastern' EWT-1 day, 20:00:00 DST>}

In [5]: type(tz)
Out[5]: pytz.tzfile.US/Eastern
```

So the fact that that unit test passes is an accident. i'll remove it
Die Frage ist, ob man das ganze "rekursiv" denkt und die filter beim aufbau des baumes ausschließen will, oder ob man eher im gedanken von erstelle zuerst den gesamtbaum und dann prüfe jedes item gegen die filter...
minor -- please use single quotes for consistency
Technically, this should go above `@base_url = format_url(options)` since that method uses the options hash.

However, `format_url` doesn't actually do anything with `options`, so it's not a big deal here.
they must not be defined here, if they are in global.h! All globals are defined in main, because then EXTERN is defined to nothing. I think your code should give even wrong results in this way.
`-j8`是什么选项？

因为我的基本态度就是不赞成用make的方式安装，所以`--enable-R-shlib --with-x`也就免了，让真正好奇的猫自己去探索吧。
Did you intend to leave this paragraph in?  You removed it in the other cases.  Thanks for this!
I like assertComparable(x, LESS_THAN, y)

LESS_THAN doesn't need to be something generic like a Hamcrest matcher. I suggest making it an enum. The code for assertComparable() would look like this:

    public static <T extends Comparable<T>> void assertComparable(String message, T left, Comparison c, T right) {
      if (c.fails(left, right) {
        failComparable(message, left, right, c.getDescription());
      }
    }
Sure thing. Just to confirm, you're saying that we should leave `addJsonSchema` as a separate function, right?
Good point. We could solve this by storing an object instead of a string in the stack, and include referrer info in the object. Not sure it's worth it to solve this til we have a clear case where it's a problem. Thoughts?
This API call should be more descriptive to distinguish this from the project tree. Also since both indexes are specified, I think it's more of a *swap* than a *switch*. Maybe swapWorkingSetIndexes.
This is ignores case when sorting, and id's are case sensitive.
Awesome documentation! I think the section at the top about registerHintProvider() would be more useful if it was moved down closer to the function itself.
Perhaps you could leave a comment stating what cases attr.name would be " "
Please don't do this. `if(packed) {`
Shouldn't this just be an attr_accessible?

Also, I notice that the first line of ConnectionProxy#initialize appears to be a no-op.
what about applying the ``nl2br`` filter on the description (available as of Twig 1.5) ?
No, just add it and push. It should append to this pull request.

That said, it's not up to me whether this should go on. Actually it can be up to me, but since Dan knows tick marks and labeling and I haven't really paid any attention to it, I abdicate this decision entirely.
should this just be @memoized?
A victim indeed :+1:
Well, I am searching solution for this, but I'm not sure what to do. Is this statement the key: {% autoescape on %}{{ body }}{% endautoescape %}?
Can we just return the value regardless? Doesn't seem like there needs to be a restriction.
Add a semi-colon here
You check for existence on `popcornOptions` but use  `_cachedValues` instead, doesn't seem right
I need some form of an if check to ensure that I'm not appending a line break the first time through the loop. I can make it a little better but not too much.
The point of this is to test whether the add function works without a callback passed to it. Since this is just part of a controlled test environment anyway, this isn't a big deal.
hmm, do we really need to iterate over the whole block here or can this be determined in a better way?
这里 $params 变量描述明显是错误的，代码里边字段名是大写
Shoutout to @blast_hardcheese here. I used some of his [top.sls](https://github.com/blast-hardcheese/blast-salt-states/blob/master/top.sls) as an example
%d -> %ui
.gz need not be appended to the file name here?
Appears to be an errant space here.
Don't touch the `background_service.js`. Move the code to `keyboard_manager.js` instead.

You can remove the `mozbrowser` all you want there.
I am sorry I have to point this out one more time ....

Let's do

    if (!this.hasPincode) {
      console.log("No PIN code provided, can't unlock.");
      return;
    }
I just submitted a pull request and in it I just added a kwarg for `table_id`.  I think that's a common case that is easily handled this way.  As for the other metadata, I'm not sure...
That's the problem; neither do I.  I *suspect* that there can be different numbers of header lines, but I have not confirmed that.  I had it hard-coded originally but figured there is reason to allow limited flexibility if I'm uncertain.
You're right, it's not used anymore.  I'll remove it.
I re-introduced that now, sorry ...
reminder: I guess we are going to make <sleepImpl> placeholder to override the whole method including the signature itself
Here $filter values are not sanitized, and subsequently they're sent to functions like getBadBehaviorLogEntries() which send them directly to the database.

$filter values are sanitized and validated only at #L120, afaics. I'd reverse this order.
Sounds good.  I noticed that some of the specs are including comments and others are not.  I tended to match whatever the spec was already doing, but I think your approach is probably the best.
do we still need this line? The exception is no longer used here according to the diff.
Arguments should be called $startDate and $endDate to better represent its contents.

Even better: use timestamps :)
Wrm is dit aangepast?.
Maybe these should be bitflags instead, so we can clear them all with a single statement.
Aha, thanks for the history! :)
This is the only instance that didn't get converted to use the constant. Is that deliberate?
is a `map` necessary here? I think `each` will be enough. WDYT?
redo this class like Tag (keeping the ctor properties)
https://github.com/jclouds/jclouds/blob/824ea1fd0a25fdd825abd89927d875f358d4a69f/apis/ec2/src/main/java/org/jclouds/ec2/domain/Tag.java
globals should always be UPPERCASE
It's not worth changing, but I've found it convenient to have my `...set_error()` helper functions elsewhere just return -1, so you can just write `return net_set_error("Error receiving data");` and have that return -1 in a single line.
Is there a reason this can't be blank?
IMO it's worth given how easy this would be to cache, although I'm curious why you'd only cache it for a minute. How often do these files change on production? Is memcache cleared when we push?
It'd be nice to leave a TODO here reminding us to enable this parameter for all builds and not just aurora.
Thanks for clarifying, here is the output:

**frame.persisted['screenshotPath']:**
> undefined

**frame.persisted:**
> {}

**frame:**
> [JavaScript Error: "[Exception... "Component returned failure code: 0x80520009 (NS_ERROR_FILE_INVALID_PATH) [nsILocalFile.target]"  nsresult: "0x80520009 (NS_ERROR_FILE_INVALID_PATH)"  location: "JS frame :: resource://mozmill/stdlib/utils.js :: saveScreenshot :: line 562"  data: no]" {file: "resource://mozmill/modules/frame.js" line: 650}]
it's possible to put multiple items in for that in a tuple.  but since I only use one, I'll remove the parens.
Where is the $logged_in variable set in the UI?
may be better to redirect to a simple page having the message
Just to clarify. Without packages it means, that it remove it from configuration for locales, so in future it will be installed and with --packages it will also resolv current missing locale right?
And I think there is typo and should be ```Remove locale from```
can we get `chef_user:parse_binary_json` to handle the undefined and `<<>>` cases so that we don't have to branch here?
Probably you should use Elaistca_Query_Abstract. The one you use now is working?
This was fetching an entry from a hash in O(1); now it's an O(N) linear scan over an array.

I imagine there's a reason for this change but it's not obvious to me...we should discuss on Monday.
*shakes fist at author tags*
Типи, параметри і коментарі повинні бути вирівняні. Якщо більше одного параметра, то коментарі обов’язкові для всі параметрів. Так каже Code Style
I think that makes sense.  Such sanity checking should be done as low-level as possible so that higher-level code doesn't need to re-implement it multiple times.
Wrong indention (should not be aligned with `@param`).
usually there is no dot at the end of `@param` and `@return` (multiple occurences)
values in the array that were not mapped in the form would remain present in the array after binding. Actually, I'm not sure if this was already so by design. If so, I'll remove this line.
you are right, that should work.
using `utf8_encode` looks wrong to me. Using `base64_encode` instead like done in the PDO driver should be better.
LGTM, we can ditch the comment though I think it's pretty obvious
might be nice to also support `log.error('request', err)` directly, expanding to `{ message: m, stack: s }`, both would be nice then you could just `--type error --map message` and get a nice list
Can we build the URL off kLinkedInAPIUrl?
please define and use a constant for this number to document it (`#define kHeightOfSomething 304`)
please use `kButtonYOffset` naming style, it's more common for ObjC. Capital case is more C style.
raise a NotImplementedError if it must be overridden.
I don't see how the language of the RFC makes you think that, but the way it says "visible" and defines it that way made me think it was supposed to mean what you read it as when it said "visible," so I agree it's totally confusing.

The two reference IRCds I used did completely different things with no WHO parameters: UnrealIRCd (as implemented on DesertBusNet) appeared to return everyone on the server as if I'd just run WHO *, and InspIRCd (as implemented on ChatSpike) returned an error regarding the lack of parameters (and, because ChatSpike has syntaxhints on, it told me what it expects:
> :kenny.chatspike.net 461 Alchy WHO :Not enough parameters.
> :kenny.chatspike.net 304 Alchy :SYNTAX WHO <server>|<nickname>|<channel>|<realname>|<host>|0 [ohurmMiaplf]

The 0 in the parameter hints functions identically to WHO *, which returns two people because it sets +i by default.)  Because I'm shown such wildly different things by these two IRCds, I figured we had room to decide what we want to do here, but stuck with the RFC as much as I could (which, as you've pointed out, required some interpretation).  Since nothing else agreed with it, I figured it wouldn't be a huge problem if I ended up being "incorrect."
```apt-get```-ting cython provided a nice speedup :smile:
fallback for wildcard since there is no support to remove all classes and another loop didn't seem to make sense... there is an issue with the wildcard (existing) where removeClass("*") gives invalid argument error.

String("*").isEmpty() => true
This is not an error condition.  The SMART Python client library explicitly calls `parse_ontology()` after requesting the ontology via `HTTP GET`.
Will this crash if the album has no children?
we now have two activity feeds, maybe late rwe can turn them into a tabbed view
Why does it need client API changes? I know we could add some convenience functions, and would have to update the documentation, but wouldn't this just be treated like a normal attachment on the client side?
Must be replaced by 
String keyAsString = new String(handshakeKey);
 System.out.println("Shared Key:" + keyAsString );
Otherwise, the displayed key in console is incorrect.
Same for line 255
Да, точно NPE
now that change has been committed
I don't like also this `data-items` but as the current implementation of` box flex` is deprecated and the new one is not ready yet for using it, we need a way to specify how many items do we have for setting the properly width.
Thx!
I would remove this part, but I could explain first:
They'd like a push and pull effect when search page is coming and leaving.
When search page coming, the search icon should come ASAP when there's enough space for it to show.
When search page leaving, the search icon would leave unwillingly until the first app page reaches its right side.
:-\
Move this to Line 208 before `// Finally ...`. That's where the sprite animation actually ends.
// We give a chance to the FTE to cancel hiding the attention screen.
`grid.dataset.zIndexLevel`
It's shared, but 'lazy-load' is only working from Settings & System... I've tried to implement it in order to retrieve the file from  '/shared/resources', but It was impossible (Im getting an error...:S), that's why I've added this comment. Do you know if I need to change any param for getting '/shared/resources' reachable from Communications?
Ok, I'll study the change because there is a lot of work bound here and I don't want break anything.
Don't worry, that's not a z-index of the imminent children of `#screen`. If `#lockscreen` comes with a `z-index` then this will be fine.
Yes it is. Please remove this line and thank you for taking care of all the changes.
nit: would it be better to name `this.onCancelTransferTask`?
I'm wondering if having app.downloading would not be sufficient here ? and maybe even better because it would be done when the app is updating, right ?
This represent only a class here. Should i use a data-field even if it's not representing a data ?
not: indent
why not use readAsDataURL instead? https://developer.mozilla.org/en-US/docs/DOM/FileReader#readAsDataURL%28%29
In fact, the only part which is reusable are the latest 2 lines, since the this.getNextFontSize takes a different variable (the latest one) depending on each case since the keypad screen and the on call screen have distinct initial font sizes.

Including these changes right now ;-)
5 is number
Is it removed on purpose?
I think "Initializing" is better here because it's in the meantime user checked wifi enabled.
ok, indeed.
Why do we swallow it?
Well, it does make some things easier, but it's definitely a PITA to keep your fork up to date. First you have to add a remote, then remember to fetch it, then pull/merge/rebase or whatever. Agreed that we need a (separate?) instruction on how to do that.
This require isn't need anymore, right?
~~~
最終的に、XML 形式でのジョブ定義のエクスポート・インポートについて理解しておくべきです。
~~~

→

~~~
最終的に、XML 形式でのジョブ定義のエクスポート・インポートについても理解しているはずです。
~~~
`func && func()` ftw
Fixed. Also it's logged as to why it failed.
How do you check if something that executes is currently active or is that not possible?
Actually this is not more efficient, since Java will produce better bytecodes using a local variable. But is nicer :).
Why would the channel hold a message?
I mean "to string". And I don't get those line above, if you cast something to string, AFAIR it will raise an php warning if it can't be casted to it, don't it ?
Why this page is not in the navbar ?
You are indeed correct, myself and @ironsidevsquincy discussed modifying Router.js to accept an array of URL's rather than just one string.  but this meant hacking around with how it handles/generates the regex's so we thought this would surfice until it gets out of hand. 

I don't mind giving it a stab when I have some more free time though.
Yes <button>'s
state is changed, so write lock needed
You're making Capybara dependent on jQuery??? A *huge* no to this.
I think @gregglind is removing this `catch(e if ...` stuff in another branch, so it's probably better to avoid it.
oh, very cool.  ok.  yeah, I did this.  would you check that I put self.full_clean() in the right place in the save() method?
This is a different situation than the perftest data structure or the push log sample.  The perftest data structure that you built mimics incoming JSON, the perftest_ref_data.json structure needs to mimic data retrieved from the database containing reference data.  The reference data deposited in the database depends entirely on the default structure that `sample_data.perftest_data()` produces.  The only way to test the reference data structure retrieval is to build a reference data structure from the default data that gets inserted into the perftest schema.  I could use different default data but it would still have the same relationship to the reference data.

I could write methods that dynamically build the reference data using methods from `sample_data.perftest_data()`, I would have to guess at the auto_increment values.  I think that code would be just as easy to break as the json structure, maybe even easier.

it would provide the ability to test specific data attributes but that is not required at the moment.

I would like to remove the reference data structure entirely and retrieve the reference data dynamically with each query.  I'm also not convinced the UI that uses this is going to be around for much longer so I'm leery of putting much more time into it.
`the` => `The` ^^
Ass opposed to a "non actual fact resolution" ? (is this a "concrete fact resolution mechanism") ?
What does "These" refer to ; "actual facts resolution mechanisms", "fact resolution mechanisms" ?
I doubt it, but it's certainly worth guarding against.
again, default cap deploy generated file... I can remove those...
it is a bit unfortunate that the whole file appears to be reformatted.
Should the this.open statements be using the internal _open?
These were running as of beta3. Should not skip these.
So you're proposing that, looks like that's not currently how you're doing it?
You're firing two events since .teleport fires an event too, and you are discarding the first event's data.
I'm still a bit fuzzy on what determines this, but in this case I don't think so. This is an issue that potentially affects every version of WebGL.
you should do the same for the JS files to be consistent
What should i do ? I shouldn't use import (? - and I did not manage to resolve internal errors with it).
I am using calendar in a colinf/datepicker. And for example when selecting date of birth, it is a common requirement especially when dealing with children to list years in reverse starting from current year.

BTW reversing can only be invoked if you accept my pull request (or an improved version of it!) to component/range.

Cheers, Colin
@harjis Eiks tää tsämälleen sama koodiblokki oo jo tos just ylempänä? D.R.Y.
There are 3 that I do (irritating, I know):

    [Date, Time, DateTime].each {|klass| klass::DATE_FORMATS.merge!(:xml => '%Y-%m-%dT%H:%M:%S.%L') }
Hi,
While working on the webassets plugin with relative urls, I was also a bit surprised by these urls starting with `.././`. I already have a fix that I just need to finalize and submit.
Code style: spaces around =
This looks ugly. YMMV, but I'd start the second argument on the line below.
and actually, you don't use the index at all so it will always be 0 here
I think this might change the way this works. To mimic the current behavior, we should use:
```
 $header = $site_catalyst->getHeader();
if ($omniture_hooked_vars = module_invoke_all('omniture_variables')) {
    if (isset($omniture_hooked_vars['header'])) {
      $header = $omniture_hooked_vars['header'];
    }
```
Since the previous behavior is to override the header completely (ikr)
remove the comments later
also, a space after comma and `''`
would it make more sense to change the my_hosts to include the admin test
should we be using drupal static here? Or even letting the caching in tuque take care of it, instead of creating another cache?
Why would you ever want to share a `TradeManager`? A bot will only be able to have a single trade, this would make things only more complicated. 

In my opinion, these should be seperated because:

 * A `Trade` is **only** responsible for adding a nice API to Steam Trading, which means it's essentially a wrapper around the API.
 * A `TradeManager` creates new Trades and manages the threads for them. Although stopping a `Trade` would be a _bit_  more complicated, I think it supports a clean API. Canceling would just happen with a `Cancel()` method which would emit a `TradeCancel` event. The manager listens for that and terminates the thread if necessary.
Why the double definition here and in _vars.scss ?
Our public API should always have complete JavaDoc.
We do, for the VIPs...
Yep so elapsed time was already ahead of timeout before we entered the loop causing the if condition inside the loop to always hit and print the message, which was not good because it was conveying a wrong message for that moment.

let me know your thoughts, i ran this patch against a 3.1.2 cloud and it failed during associate, this is not a bug in eutester but a bug in eucalyptus because eucalyptus 3.1.2 does not give an ip address on a dns enabled cloud , instead gives a name which fails the comparison. no escape there :100:
Can you rename it to `$resource`? Thx
Why not put the prototype in the abstract class?
Yes, this for testing, but also a separation of concerns instinct.  I tend to use slim controllers whose primary concern is aggregating required arguments and executing a command then returning results.  Plus, a controller is responsible for many requests and they can get quite cluttered.  I like separate file to clear away clutter.
It's good that the property name matches the locator name.  When you make the change for the locator, you can make the same change here.
Thanks for the clarification. You should probably add a comment referencing the bug.
Little nitpick: [RFC 1035](http://www.faqs.org/rfcs/rfc1035.html) states that domain names should start with a letter. Also, I can't find any RFC for that, but ISTM that valid domain names should be at least 3 chars long.

Really, that's me nitpicking here, but the domain names could be invalid so I think we should at least use valid domain names, even if we're not resolving them.
If you used a `READ_KEY_OR_FAIL`-style macro here as described above, you'd risk leaking `*l`.  Meh.
Need Help with space.
Look at use of slingshot's `try+` macro for this. We use it inside of command.clj...see the `fatality!` function, for example. With `try+`, you can throw/catch any object you want (so you can just use a map as the "exception" instead of heavyweight Throwable)
Ah ok. So it won't change the shell dir?
Definitely on the last, and I'm going to reformat it, if not refactor it — I'm not really sure how you would make it more concise.
Comment applies to more instances within this PR as well.
We can probably reduce indentation here as well.
If possible, these should go beyond one page of results and should verify that threaded replies respect paging.
Are you relying in this case that having an implicit `Manifest[A]` makes this pattern match safe from erasure? I think it is, just pointing it out.
I would prefer pattern matching over if-then-else. Don'y you think the following is cleaner (and shorter :))

```scala
(applyMethod, applySpMethod) match {
    case (Some(m1), Some(m2)) if sameBytecode(m1, m2) => applyMethod
    case (Some(_), Some(_))                                                 => applySpMethod
    case (Some(_), None)                                                      => applyMethod
    case (None, _)                                                                  => applySpMethod
}
```

And ``sameBytecode`` would be defined as follows:

```scala
private def sameBytecode(m1: Method, m2: Method): Boolean = m1.bytecodes.sameElements(m2.bytecodes)
```
why not adding an implicit for the ``IDebugEventSetListener`` creation (I saw it in many places). I think it would make the testing code much nicer.
What about ``NoSymbol``?
I added new parameters to the StringUtils.Join() methods, which will allow for the "glue" for the last two elements to be different, which, in the case of lists with three or more items, will be proper english.

StringUtils.Join(array, ", ", ", or ", " or ") will format each of the following as such:
if 2 elements: a or b
if 3 elements: a, b, or c

So, whenever you think about it, use these new parameters instead.
now i notice that this should either extend the ProviderBasedGenerator or follow the same pattern. lets decide on the question there before i change it.
I don't like the look of this, it really should be using the existing routine. Not sure why the need for the distinction.
Maybe i've made a mistake but it was not working for me... I'll try again
You need to preserve this check.
Something's wrong with the spacing/alignment here ... switch to tabs if you've used spaces.
Мелочь: Название категории не соответствует условию задачи
countDNA. Оно создано таким образом, что его можно изменить - свойство readwrite, и к нему автоматически создаётся геттер и сеттер. Так как на этом свойстве многое завязано, нужно либо делать свойство readonly, либо переписывать сеттер для себя (чтобы он соответствующим образом менял псоледовательность - делал её либо больше, либо меньше).
Да, проглядел этот момент
Не думаю, что это так страшно.
Поправляю. Речь идет не о расширении списка азотистых оснований, а о расширении модели. Например, мы захотели моделировать вступление составляющих ДНК азотистых оснований в реакцию под воздействием ферментов. Для этого недостаточно будет объекта NSString, его придется заменить на объект, реализующий модель азотистого основания более точно. В моем варианте для этого достаточно возвращать объекты NitroBase (по этой причине в проекте вообще появился класс NitroBase, ведь ту же функциональность можно было бы реализовать в классе Cell).
Конкретно здесь уже писать метод в интерфейсе нужно, и его нужно реализовать, тут ок. Но мой совет, лучше делать копирующий конструктор, т.е. что-то типа initWithCell:(Cell *)cell, обычно всё-таки так делают.
I would change it to `$this->imagick->hasNextImage() || $this->imagick->hasPreviousImage()` same for gmagick driver
more brunch style way

```coffeescript
defines = @config.stylus.defines
Object.keys(defines).forEach (name) -> compiler.define name, defines[name]
```
This is where the Function/eval is. The stringify is there to get the code escaped to one line so Function works properly. It's the same approach Substack uses in Browserify.
Style: ternary expression within parentheses
Can you add tests for these filters? I'm not sure how they're supposed to work.
Interesting,  I struggled with the same kind of conflict. The one is more compact, the other definitely clearer. So let's change this.
instance of SourceEstimate
It's good to illustrate methods to users -- how about specifically pointing them to look at the source code in viz.py, assuming that's where it could go? If you anticipate many people using this specific order-defining code because it's generally useful and a good default (my thought), then it would make sense to include it in the package rather than make people cut-and-paste the code into their own source code. Unless you think it's too specific and/or users should need to understand it?
please change the message in the log to something more useful.
this is not the XML namespace auto-generated by the extension class for AcmeHeelBundle. I think it should be changed to be consistent
Why the unused options?
"Pull requests must be in JSON format"
Use `url.parse()` here, makes it obvious that it's an external function.
Sure.  It is there for the case someone performs a getRestParams() **without** first checking the REST verb (if they don't actually care about the verb), thus not knowing if they should call getDeleteParams or getPutParams.  It's for convenience only.
Ты уверен, что стоит вызывать основной разработчик всегда, а не в `else`-бранче? Типа, зачем это делать, если ты уже обработал tooltip event?
Почему бы не передать по ссылке?
`final` on the parameter.
The # sign before a name indicates that it is a method. For example: calculator#sum indicates that sum is a method on the calculator class. This syntax is important when you get to Rails.
Why save the reason transliterated string ?

There's not way to translate a transliterated string. You have to save the check classname if you want to be able to get the message
I see what you are trying to do here with the quoting. I believe that `current_assets.join("\n").gsub("\"", "\\\"")` is more correct.
Here the separation is by no means complete - renderer provides the style_function which is specific for HTML output
No. Both of those use Popen, which is what subprocess.call uses.
the whole file or just the line?
The `accum` is not needed.
Olisiko tässä tehtävässä siis tarkoitus jakaa *aidosti* monotonisiin pätkiin? En keksi nimittäin mitään muuta mahdollista vikaa.
That was because I organized imports on a file that got changed by refactoring Parser->ParserRegistry
Would it really make things better ? I am not scanning classes looking for annotations, I am getting the annotation on a specific class.
On Thu, Dec 6, 2012 at 11:39 AM, Eric Firing <notifications@github.com>wrote:

> Specifically, de-denting to align the starting single quotes--I hope that
> is what you mean, @pelson <https://github.com/pelson>.
>

+1

-- 
Damon McDougall
http://www.damon-is-a-geek.com
Institute for Computational Engineering Sciences
201 E. 24th St.
Stop C0200
The University of Texas at Austin
Austin, TX 78712-1229
I agree.  Is there any point to have it this way?  My best guess is to purposely swallow extra args from a call to this function in a sub-classed animator, but I don't know if that would be a good idea.
I don't think that using imshow is appropriate here, first because interpolation doesn't make much sense for a histogram, and second because the bins kwarg can specify unevenly spaced boundaries.  imshow is restricted to a uniform grid.  Take a look instead at Axes.pcolorfast, which I think is better suited for the 2-D histogram, either as-is, or as a model for using PcolorImage in place of imshow.
Just for future reference we intentionally made this with an upper-case B so that it matches exactly the string selected on the page. This is for the benefit of joining the code on the page with the steps in the test for people - new contributors, non technical staff, etc - who are unfamiliar with it. It doesn't sound like much in this circumstance but it helps a lot when we use this style across all of our test suites!
Using a decorator here is weird because it obscures the flow of assertions. I'd suggest adding something like this right below your ``run_script()`` call:

    self.assert_js_failure()

then you could put that method in a shared base class.
cool then add this to the .netdoc

On Tue, Aug 7, 2012 at 4:19 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/ActiveMQ/ActiveMQProtocol.cs:
>
> > +        /// Format, which activeMQ uses to marshall/unmarshall messages
> > +        /// </summary>
> > +        public static OpenWireFormat format;
> > +#endregion
> > +        #region Constructors
> > +        public ActiveMQProtocol() {}
> > +        public ActiveMQProtocol(Object obj, int socketNumber)
> > +        {
> > +            this.SocketNumber = socketNumber;
> > +            this.Message = (Command)obj;
> > +            if (obj is WireFormatInfo)
> > +            {
> > +                format.RenegotiateWireFormat((WireFormatInfo)obj);
> > +            }
> > +        }
> > +        #endregion
>
> This is mainly from ActiveMQ. AcitveMQ send for each communication a
> Wirefromat, which has some diffrent parameters. This parameters are then
> used, to configurate the own Wireformat so that both have the same
> configuration. The idea behind this line is that when a wireformat is set,
> that all the ActiveMQ protocols have the same WoreFormat.
> "RenegotiateWireFormat" is from ActiveMQ
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321632>.
>
>
Oh, I see. The method is named badly, it doesn't actually use the size to search. As @qrush says below, nuke this method.
Is there a reason for deleting the alt message here?
Are all talks always in an mp4 container?
`|safeOutput`
I'd prefer to remove this line if it's not needed, rather than comment it out. Why is `Embed-Dependency` used in the `11.2.0.2.0` profile but not in the `11.2.0.3` profile?
please use new MyClass(); here
What do you mean by "I think we should have one LookupTable per mapping"? In terms of data-import, do you actually mean mapping or definition? Or maybe something else?

Let's call the lookups id dictionaries for the moment to be more precise.

I thought of saving the id dictionaries in the execution plan in a similar way as the definitions. If a definition is created the dsl also creates an id dictionary with the same name as the definition.

`lookup` passed to the constructor of the script and import definition is just to ensure backwards compatibility. As soon as we release a stable version, this can be dropped.
unless its the general style of this gem, can you go through and put parens around method calls?  we generally only like to omit parens in dsl-style declarative statements.
Hi Alex,

> This change looks good. It should please go ahead and merge.

Thanks!

Our normal approach would be for the reviewer to click the "merge pull request" button to finish this off.  Can you please do that?

Then it might be instructive to see the automated tests fire off in Jenkins...

Michael.
Not off hand. I updated to the latest compiler which I believe was causing similar issues in the past. That should have been resolved.

Sent from my iPad

On Nov 19, 2012, at 5:29 PM, Philip Schatz <notifications@github.com> wrote:

> In css/ccap-biology.less:
> 
> >  
> >  /******************************************************
> >   * Generic Elements
> >   ******************************************************/
> >  body { font-size: 9.5pt; }
> >  
> > -img {
> > +img { 
> Aside: Any idea where these spaces keep coming from?
> 
> —
> Reply to this email directly or view it on GitHub.
>