labofsahil/github-event-dataset-2012 huggingface dataset:
Are you sure ``'Zend\\Uri\\Http'`` has the correct type as ``string`` is not a sub-type of ``object<Zend\Uri\Uri>``?
I'd say you may want to ignore more than just the Canaryfile here so this should be configureable and look something like this:

```ruby
BuildCanary.ignored_files.include?(File.basename(file_path)
```

`ignored_files` can be populated from a config file or a CLI parameter, etc. By default it's contents should contain "Canaryfile" and the default values should not be able to be removed.
Kann man bestimmt noch generalisieren. Gibts nicht irgendwelche sehr einfach gehaltenen Template Parsing Libraries?
I don't understand this code. Why is this doing something different to `unit.getDefiniteType(type)`?
index -> length
What about SelfAwareContainerInterface?
agreed with @jaugustin
Rename file to lower_with_underscores.
Use fast or slow.
No no. We group by packages. So, first are built-in. Then Django. Then celery. Then ours.
Ehm. Can you please grep for 77? ;-)
Is there any with ticket==1 in Ljubljana?
This module is not needed anymore.
Space before `=`.
Indent. You do not have to use non-braking space. Just put a normal space there and this is it. Don't use `<b>`, use span with class and style that with CSS.
Are you sure it should be `panels_pool.has_panel` and not `panels_pool.panels_pool.has_panel`? This is quite tricky, but here we import first `panels_pool` module, which has `panels_pool` attribute. I think it should be `panels_pool.panels_pool`. Have you tested this?
Move this lower.
But then that check didn't work for you?
Can we do something that is more in line with existing Homebrew idioms? We try to avoid shelling out when possible.

One can do e.g. `prefix.install 'foo'`. If the concern is that the man pages will get installed in the wrong place this way, it can be done after the `man1.install ...` line.
Could you add a comment describing the `n >= 0 && n <= 7` condition?
... which i would start with "if (config.maxQueueAge.isDefined &&" to shortcut out right away unless a maxQueueAge is defined.
Totally agreed. Iterating through all the constructors is necessary at this point. In fact, I have just reproduced what you describe by creating a type with two *compatible* constructors.
you know, actually, I can just do that once it's merged. it won't really be a problem.
`getTargetModelClass`
This println should probably be taken out.
this is broken as soon as you have some logic in the loop, for instance a ``if`` check
> We do realize these are strong limitations, so while it might be interesting to try it out, for real usage we suggest for now to use either Hibernate Search FullTextQueries or whatever query technology the NoSQL storage exposes "natively". 

We do realize that this are strong limitations and render this feature interesting for experiments only. For actual production code we suggest for now to either use Hibernate Search FullTextQueries or the native query technology of the NoSQL storage you are using
Yeah, that's what I meant. Sorry, I was looking at a dictionary example.

I don't know how much of a difference it would make, but in theory, it might help when there are several types to process.
os rename it is then, there now lies the issue of how to deal with the RDF data and pointers
You might supply a link to your blog post in the docs.
@camertron, I thought it over and decided that delegating method should not care about signature of the method it delegates to as its role is to pass everything along to the actual method. With that in mind delegating method should look like

```ruby
def self.get_resource(*args, &block)
  resources.resource_for(*args, &block)
end
```

Finally, I came across `SingleForwardable` module from the standard library and used it instead of writing delegating method manually. Hope you wouldn't mind.
不编译link doc="http/ngx_http_gzip_module.xml">模块，该模块可以压缩HTTP服务器的的回复。该模块需要zlib库才能编译和运行。
Great.  Good to know.  Might as well leave the recommendation to do --with-math, even though I'm not sure if it's required.
Is this replicating code in `chord` ? If so, can we do without the former now?
yes, whoops :smile:
method doesn't appear to be used... exposed for clients?  perhaps give it a bit of javadoc then.
Hi Aled,

the defaults are for a locally running mysql database. 

I can remove it, but then I also should remove other defaults like host, driver etc.
Again, also keep default constructor with warning
`return Objects.hashCode(spec, name, config);`
When it's auto-generated, I just about accept having the verbose version, but as soon as we're modifying the code we should put in the easier-to-read-and-maintain approach.
I think it's a good idea to rename to getClient() and return a fully configured retry-aware Jersey client.
me too, i'd like to see util cleaned up and backfilled with tests. there is almost certainly overlap with ExecUtils.  this code was sitting in Ssh* somewhere so I've just moved it out, for now.

creating a new pojo no-dependency brooklyn.util project would be cool, also a brooklyn.util.groovy

but a separate issue
we could, but that means we have to modify chipmunk js
why ignore the exception?
This line no longer seems necessary.
Why is this cassandra_model_part2_spec and not part of cassandra_model_spec?  We have a standard naming convention for our spec files to follow the respective name/path convention of the class they are testing.  We should adhere to this standard.
в setImageFile нормально? я видалю звідси ці коментарі
Yes, this is true.  I thought about it briefly yesterday but decided to skip it in order to get the pull request out.  Looking again, I think it would be a good idea as it would make the confirmation email editable within the dashboard (once I implement the email editing pages).

I'll have a look into this today or tomorrow (I need to work on some other projects today sadly).
The plan was to provide high level API to get this information. Having webinos variable sounds good to me. can you do it?
nah. It's only a convention (maybe a suggestion is a better phrase). If someone wants to twist the gem by modifying the CONSTANTS I'm fine with that. :smile:
please fix CS here
On 09/03/2012 09:29, Ben Francis wrote:
>> @@ -3,6 +3,9 @@
>>
>>   const kDefaultWait = 2000;
>>
>> +// Until we have a better mechanism, disable mozbrowser for testing
>> +SpecialPowers.setBoolPref('dom.mozBrowserFramesEnabled', false);
> Ouch. That's going to make writing tests for the browser app pretty much impossible. Why is this necessary?
I wonder if I can use events to magically remote that. let me look.
Well, I did this because i wanted the list to be a mutable thing (e.g. you can add more) while individual spec,result pairs should be immutable ... Maybe that's dumb
Can you doublecheck that `errno` is set on Win32? I don't think that's the case, there must be a different way to set the error message.
this is not the right place for this. This ``if ($type instanceof FormTypeInterface)`` check is about registering the types when you don't call them by name, not about merging the options.
Your code will call ``addType`` again for all types referenced by name, which is a bad idea
Why do we need the coffee script version?
Open an issue instead of XXX and add the number here.
There is something wrong with this changeset. This must not be here.
Sorry :( Fixed it!
JW How does verify peer get affected?
machinelist.  Not machines. >:(
I only have ready access to a SL box, but I recall testing this on a Lion machine a little while ago and it didn't work unless this was there. I'll try to retest if I can.
we should not hard code that header name ...

in the end (see JavaScript) the value of the header should configurable;
Ok, leave it as is.
I don't think it will be a problem ... Simply, the url is givent twice :)
Dann muss ich umbauen. ich brauch die an anderer stelle in CAPS
Почему не используется компаратор.
Parag change
#85 emits a `"ready"` event from toolbox. Other places in this PR check for `"ready"` too, not `"toolbox-ready"`
This field and the ones below it that are the same should have their names prefixed with `type_` so that the tester/user knows the action that they're doing.
Give reference.
Done in ndawe#12.
two comments about the example: maybe comment about using an imbalanced dataset and / or about making iris binary?
Also: wouldn't it be more natural to change C  than to go to rbf?
Consider using handleError in util.go
Store a reference to `[].slice` up front.
Nasty Linq!  Resharper?
put a comment on these saying the unit is pixels
No need for `NativePlatformInterface::`, you can call `instance()` directly
The best way to fix browser compat would be to use constants like IDBTransaction.READ_WRITE, or more specifically $.indexedDB.IDBTransaction.READ_WRITE. Worst case, they throw warnings, but I check if they exist and populate them.
The error could be more descriptive, looks like the only way checkLogicalName can return false is if it's a query format.
Perhaps checkLogicalFile should return reason for failure to use in this exception.
You could, but I'm not sure that you want to.
fair enough... it won't make it slower anyway. ;)
This method is probably unnecessary (see comment in `Cache`).
Its the same basic pattern used for polling throughout rest_connection. So I'm ok with it if you are.
一般的には"."でつなぐ方法でしょうか？
例えば、"the.composite"のような
Please define this as a type, i.e.

```c
struct beancounter_s { ... };
typedef struct beancounter_s beancounter_t;
```

Then allocate a `beancounter_t` on the stack. Using this as a global variable, one that looks like a type definition at first glance, is confusing.
`_property` never gets set actually but used in the code. Does that make sense? `_elementSerializer` is never set either. Why is it even present in this class then?
will this work for all env with these creds? I dont think it will.
this will throw a notice if the response is not an array (for instance if fetching the json failed and you don't have a valid json string)
The usual convention is to specify, for the input image ``(M, N) ndarray`` or ``(M, N, 3) ndarray``, and then again use M and N here.  But that's not set in stone, this is fine too.  Then it should just be  ``(width, height) ndarray``.
Actually those are different enough to do a classification.
Running against the latest on RubyGems, I except with the following stack:
/Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `initialize': can't convert nil into String (TypeError)
  from /Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `new'
  from /Users/scotthyndman/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/json/common.rb:148:in `parse'
  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/base.rb:348:in `unwrap_json'
  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/api.rb:429:in `search_json'
  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/api.rb:370:in `search'
  from /Users/scotthyndman/.rvm/gems/ruby-1.9.3-p0/gems/rdio-0.0.98/lib/rdio/types.rb:672:in `search'
  ...(application code)

My Gemfile.lock:
GEM
  remote: http://rubygems.org/
  specs:
    activesupport (3.2.2)
      i18n (~> 0.6)
      multi_json (~> 1.0)
    addressable (2.2.7)
    awesome_print (1.0.2)
    chronic (0.6.7)
    faraday (0.7.6)
      addressable (~> 2.2)
      multipart-post (~> 1.1)
      rack (~> 1.1)
    i18n (0.6.0)
    launchy (2.0.5)
      addressable (~> 2.2.6)
    multi_json (1.1.0)
    multipart-post (1.1.5)
    nokogiri (1.5.0)
    oauth (0.4.5)
    rack (1.4.1)
    rake (0.9.2.2)
    simple_oauth (0.1.5)
    twitter (2.1.0)
      activesupport (>= 2.3.9, < 4)
      faraday (~> 0.7)
      multi_json (~> 1.0)
      simple_oauth (~> 0.1)
    whenever (0.7.3)
      activesupport (>= 2.3.4)
      chronic (~> 0.6.3)
Throughout: might as well pre-allocate this array and the objects now since we're going to have to do it later with the command tree.

In fact, you can even consider introducing a new class, `Command`, that has all these properties and a `destroy` function.  It might cleanup the code overall, make doing the tree a tad easier, and be a performance win in the short-term.
The only change I made was to tweak equalsEpsilon so that it works for objects which also implement an equalsEpsilon function.
It's not necessary, but it's good practice for several reasons.

1. The underscore is just convention, it doesn't actually make anything private, so someone could muck around, accidentally or on purpose, with the implementation.  Making it local makes it really private.
2. Since it's not on the prototype, it doesn't muck up the debugger view of the object and so looking at Materials instances while debugging is easier.
3. It is actually faster to call a local method than a prototype method, since no prototype chains have to be following.

Eventually, all of the old code will be changed as well, we should probably update the coding conventions.
This shouldn't be in `Scene`; it is a renderer-level construct.  In general, we should start looking at `Renderer` more as the 3D engine (and less as the WebGL wrapper), and starting look at `Scene` as more of the virtual globe engine, not both the 3D engine and the virtual globe engine.  For example, `Scene` knows how to manage terrain and imagery layers (virtual globe engine), and `Renderer` knows how to cull and sort draw calls (3D engine).
Didn't it always return that?  What did you really do?  You swapped the order of the arguments.  Why not show an old code snippet and a new one, and encourage users to call `Scene.pickEllipsoid` instead.
s/hasOrginHeader/hasOriginHeader
I'm not 100% sure why we need this, but we'll leave it in just in case. I wonder if we should put it before the for loop, so that it certainly would overwrite whatever _alive value was there prevously, then it would get deleted by the for loop. We can revisit later.
Talked with Sabil. The underscore is unnecessary and needed only in namespace conflicts.
The width and height variables are not needed, you can set those directly in the returned object.
It doesn't seem your modified values are ever reset to false.  You will want to do that after you save or something.
See issue #348.
As we discussed, changed to a simpler QueryString decoder for 1-depth key=val pairs string. No Arrays supported.
I like that you've put this into the post suite, though I'm concerned that if there's an issue during the install ( ^C ) there will be zombie VMs remaining. I think placing this logic in the CLI.rb's [outter ensure block](https://github.com/puppetlabs/puppet-acceptance/blob/master/lib/puppet_acceptance/cli.rb) might be a better way to go. (Or refactoring the CLI code to allow the post-suite step / final ensure to be merged....
this shouldn't be changed tho
I wanted to address your points quickly, and didn't actually have access to my test box.

I should really learn to be more patient :/
What do you mean a breaking change for `isSafe` for non-functions? And any code which uses `isSafe` is inherently broken anyway, since `isSafe` has never worked.
Oh yes !  :+1:
I like how you tried to follow the existing style of using named constructors here :)
However I was planning to change it. I think named bool arguments would be better. Would you mind changing it to:
```dart
AttributeInfo(String value, {this.isStyleMap}) : bindings = [value];
```

Then the call site can be:
```dart
elemInfo.attributes[name] = new AttributeInfo(value, name == 'data-style');
```
Created JIRA: https://issues.jboss.org/browse/RF-12484

I'm not sure if that's the correct location.
hmhm じゃあそっちに移動しますかねー
Split out the assignment from the conditional for clarity, please.
I had forgot to remove this line...
I'll update!
My bad, that raise was there solely for my own debugging and needs to be removed. Will do so in a bit.
Shouldn't we keep these? Or are they covered under a top-level .gitignore?
The default page will be included when you link to a directory, in this case [index.php](https://github.com/jquery/jquery-mobile/blob/1.0-stable/js/index.php).  That file just concatenates all the js files in the directory.  So essentially you get all the js files included simply by including the one line.
Good point.  Probably not needed based on how this pattern has evolved.
`"Digest: ,SHA-1="` can be seen as:
```
Digest:
Digest: SHA-1=....
```

It is translated in visitormanager to `";;SHA-1="`, and then `getParameter("SHA-1", ...)` is run on that, which succeeds, and then DTA.Hash is constructed from the returned value, which is also valid. Maybe they changed the mimeheader implementation post fx-14 to choke on it?
Еще не закончил делегает. Будет еще
Google, Bing and OSM are three major data providers. I'd keep them in the light build.
Should be `<div/>`
@shacker Can you remove all the changes that appear in the diff that are unrelated to your direct changes, like this line, the empty lines below in this diff, and throughout this pull request? Thanks!
Think about incorporating the acceleration signals here instead of time differentiation.
опечатка "возвраения"
sample of a identifier in mode "AUTO" on MongoDB :   string("4f69bbb5f14a13347f000092")
is_numeric fails :(
Fixed on https://github.com/xi-project/xi-bundle-breadcrumbs/commit/a9883fc5a9a838ba6dce01b5e4e948da5bce3451
Ok converted to use a properties file



On 21/07/12 18:58, Martijn Verburg wrote:
>> +import java.util.Collection;
>> +import java.util.HashMap;
>> +import java.util.Map;
>> +import java.util.Map.Entry;
>> +
>> +import javax.annotation.Nullable;
>> +
>> +import com.google.common.base.Optional;
>> +import com.google.common.base.Predicate;
>> +import com.google.common.collect.Collections2;
>> +import com.google.common.collect.ImmutableMap;
>> +import com.google.common.collect.Iterables;
>> +
>> +public class PackagingInstructions {
>> +
>> +    public static final ImmutableMap<String, Collection<String>> PACKAGING_DEFINITIONS =
> An enhancement would be if this could be passed in via a properties file
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AdoptOpenJDK/PatchReviewUtilities/pull/15/files#r1211014


-- 
John Oliver

InsightfulLogic
http://www.insightfullogic.com
alternatively make the executable field in `Tool` public.
this should use ``elseif``
Would you make this more clear if this is the original or the new.
Fixed the formatting error and tested, lines were verified to be properly broken up by linefeed.
Good point; I was going for bare minimum change to get it to pass. Filed issue #85 to track fixing this.
When **performing** cascading validation?
This follows the pattern in @bryanhiggins automated tests. The only way to make sure the ui-agent executes these steps in order is to put the next step inside of runs (after pausing the test with waits)
Can we add another example as well that uses `my_query` instead of `query` to make it super clear that we are passing the variable name as argument?
Cindy, it's 2012 :)
I like taking it out for now. Good catch.
Are these functions ok? They replace variables, but since they need to be changeable by TEST_LetsDoTheTimewarpAgain, I just made them into functions.
A [[self player] cancelAllThumbnailImageRequests] might be good above this line in case the end dev called this method a second time before the player was done with the first batch.
Hi, if its a boolean, and not Boolean, it will return 'false' by default, wont it ?
This is unnecessary due to #PageContainer replacing #Container in the current build due to integrating script-based ad takeover support. I think it's a good idea to sick with CamelCase for element ID's and dashes for classes. What are your thoughts on that?
I think the same can be done for the reader as well used at the top of this function, saves a bit of memory
i'm not sure you can call success on an async callback? @jeffheifetz?
Can you add this to your class as a static function? I would like to do this going forward for better organization and less clutter of the namespace
why are you removing the field ?
shouldnt the services include equiplet id? because it is equipletNode specific
The constants reflect the system names. I use constants because they are likely to be used multiple times (i don't think that's the case now).

Getting rid of the 's' at the end is correct. I'll merge this!