labofsahil/github-event-dataset-2012 huggingface dataset:
So what happens if an argument after the first one is not a ddl file? What kind of error do I get? Is it fed to hsql even if it has an extension like .jar?
Multiple repetitions introduced here. Consider refactoring into one method, when changing this code in the future
Put them on separate lines?
I've moved the generated test stuff in a seperate directory inside public/ (see brunch-with-chaplin)
That way users can protect this directory, and we can check the joinTo config if the generated filename starts with test/
Is this ok?
This is one of the reason bad comments are worse than no comments.
These views allow passing either a model or a queryset. ``self.model`` is not an instance of a model but the actual model class and thus ``isinstance`` won't work. The None check is that if ``self.queryset`` is used instead of ``self.model``, ``self.model`` will be ``None`` and the first arg to ``issubclass`` must be a class, not ``None``.
Providing the field objects, which themselves provide the column names for the fields specified in the unique_together (as, for example, an FK will have a different column name)
That patch looks to me like it might be better represented as a small override to effective_default, perhaps? I'm keen not to add _too_ many things to DatabaseFeatures...
Is the if-else needed here? Will it work if you always use this:

```
lapply(vp$children[[i]], function(x)x$name)
```
That's just awesome and so elegant, I so hated the trickeries in there ><
Maybe just store the height, scroll and compare the new height with he stored one?

As the originally bug was described this should fail without this fix...?
No, that wouldn't work either. On iOS, the window.innerHeight changes when you scroll. On other platforms, it does not necessarily. So sure, we could write a passing test like that for iOS, but it would fail on all other platforms.
use `asyncTest`
This seems like a failure in the regex to prioritize, but I don't understand yet what is being fixed here.
Eigen::Index
I think elog() cannot be used in C++ without PG_TRY()
its disabled and never called, but you can simply activate it in line 875
Stamp is a timestamp, (in milliseconds), that is used as a loop counter below. In particular, it does what the comment above the try block says. I will comment this better.
This line prevents the order of includes changing, thus overriding our choices of libraries that are used. Should prevent most such build-troubles.
Yuck. We should be able to tell cmake where to put these files; maybe look at the mysql formula?
hosts_and_ports_descriptions << line if line.index(IP_AND_PORT)
We have a `VumiError` class that we should subclass for this kind of thing, probably.
Done, but it didn't touch this line.
I see why you added this, but it's technically not correct. The pulp-admin script doesn't have to run on the server, it can be run remotely. Not sure that means this needs to be changed, just throwing it out there.
And now I read your comments ;-). I'd be inclined to stick to Python-style indexing (zero-based, half-open intervals) unless there's a compelling reason not to, because that's what we're already used to working with.

But I'd still prefer to use an actual list of widths, rather than from/to pairs. It's also easier to change if you have to expand a column.
That wasn't my change, just got affected by running the tabs to spaces. It was introduced by your commit: https://github.com/bengourley/control/tree/1d1e991116f208bbd4d440f50965781fa996285f
We always put the ``{`` on a new line so it becomes:

```cpp
for(xyz)
{
/// bla bla
}
```
Sleep 5 sounds a bit arbitrary - isn't it possible to get triggered i/ wait for a change?
postInterval is in seconds, not ms.
Yep creating them within the job works if your precursors are execute serially.
But, what I wanted to do was make it easy to execute precursors in parallel, and then only trigger the successor when all the precursors finished.

By the way, the example "QoS" runs all of these types of combinations if you want to see it in action.

Cheers.

- Dan



On Mar 16, 2012, at 12:24 PM, TJ Holowaychuk wrote:

>> +    name: 'Jim Steele',
>> +    email: 'js@steeleinc.com'
>> +}).save();
>> +
>> +var config = jobs.create('customconfig', {
>> +	title: 'S5',
>> +	color: 'sprint blue',
>> +	transmission: 'dsg'
>> +}).save();
>> +
>> +var charge = jobs.create('change', {
>> +    email: 'js@steeleinc.com',
>> +    car: 'S5',
>> +    charge: '$59,000'
>> +}).after(newcustomer).after(config).save();
>> +```
> 
> I like this, I was doing similar but just creating the jobs within the job processor haha
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/LearnBoost/kue/pull/105/files#r568644
`{` should be on previous line
We can't remove quotes as without quotes will crash Brackets on launch.
Remove this `return` too
Should tests like this one do anything to assert that the inline _hasn't_ closed yet?
Passing false for autoAddRemove causes the popup to never get removed from the the _popUp array, so the array grows by 1 for every code hint menu that pops up! I thought that CodeHintsManager was always passing the same menu, but the (temporarily added) index lookup always returned -1. This might work is CodeHintManager only calls PopUpManager.addPopUp() once, but currently it calls it for every popup.
use

     <dependency>
        <groupId>javax.servlet</groupId>
        <artifactId>javax.servlet-api</artifactId>
      </dependency>
NSToolbarDelegate is 10.6+, I assume that's ok.
This is where I filter out the get variables, it may need some final tweaking
You should pass here the limits for the date.
I like to have variables named the same as function parameters. Can you change `code` to `token`?
uppercase colours please
Yeah, I don't see the reason for deleting this. Please re-add
No, this is right.  The file is just called that, but there is only HTMLVideoElement and HTMLAudioElement.
Doesn't look like we make use of this anywhere in the plugin or it's editor.
remove the extra indentation here
This makes lint angry. Can you just leave it out for now so we can merge this onto master without hassle?
So, if we're just drawing inside the width of the viewport now, why are translations by the value of `scrollLeft` necessary?
I have a feeling this should link to `#firefox-marketplace`.
nit: "There were changes found at mozilla-central."
shall we destroy every page we are printing or can we keep cached visible?
quote vars, but avoid quoting globbing part of expression.
Wonder if we do this kinda thing in other places in the model. would prefer the caller calling save! on the changeset
Well, I would leave it there, both upstream and downstream: http://www.gnu.org/licenses/gpl-howto.html

"For interactive programs, it is usually a good idea to make the program print out a brief notice about copyright and copying permission when it starts up"

"If the program does terminal interaction, make it output a short notice like this when it starts in an interactive mode:"
I wonder if we can drop these `"\\N"` values and replace them with empty strings? It'll be another big character saver. Maybe?
As soon as this code gets a second primary developer, I'll happily excise this stuff. That said, *I* find it helpful.
Why not simply using ``array_merge`` ?
I'm assuming the correct parameters resolving (ie. deserializing from JSON) is the responsibility of the method provider - params passed are raw ones, coming from hub request.

I moved the parameter binding code almost unchanged from `HubDispatcher` to extension method `Adjust` (in `SignalR.Hubs.Lookup.Extensions.MethodExtensions`). The fixes should happen there.
Fair enough, but this isn't even my code (copied from the vcxproj code)
alright, I'll leave it for now given the power of inertia :) We can re-examine this when we actually do the array integration if people start to find it confusing.
Delete this file, no longer being used
How about having genbuild.sh write to stdout, and pipe it to build.h here?
Ok, did it in a much more contained way, though I have to say delete this; is pretty ugly...
Why did these tests get deleted?
Ohh man, feature blindness on that one!
Fixed
My bad, I meant to cache the case statement strings :). Don't cache the selector strings. If anything cache the whole element.
ok, I just saw that the value can only be an array
``false`` should be written lowercased
remove `archive` and add back `only: :destroy`
Was this a bug? What is the difference between the two?
This whole block should be commented by explaining what it does. It is not clear for me, despite reading the K&P book.
No, autogeneration is fine I think (with the caveat that I'm not sure what would happen in create.js if both rel and rev use the same rdf name). The property attribute mentioned in #11 is automatically removed again during the rendering call if the entitiy is marked readonly at this point anyways, so this won't interfere with the driver (and this logic needs to be replaced with the new create.js config options anyways)
I tried merging this now into my testbed installation and this is one of the places where it trips up. I suppose for the moment I could just alter my config so that has exactly one type name, but I wanted to ask more generally what the implications of this are: I thought in the discussion about the other PR we agreed that type resolution should be done via the rdf type name, not the storage class name. If so, this would be a bit inconsistent and impossible to configure: Because you either identify your types by raf name in the configuration or by classname, I don't see how working with both can work (but I might be missing something here)
I understand what you are doing here.  we need to refactor this once we switch to jackson which enforces use of constructors, as this should be done only during construction time.
lameish but makes clone much faster
so, while i am implementing your request regarding mocking utcnow, i would like to point out that by doing so, we would not catch if the modified_on value was not changed at update, because the timestamp given to modified_on at create time is the same as the timestamp given at modify time.
oops, that should have been deleted.  this was the processor registration process on the wrong thread.  The old processor did it this way.  While it worked for us, if a small installation that few crashes had an interval where no crashes arrived for a period longer than the processor checkin time, the processor would fail to checkin.  That could mean that the monitor would mark a live processor as dead and stop assigning crashes to it.  The processor would then remain forever idle.
In fact, I'd much rather replace that string with something like `open('../revision.txt').read()`. And equally for the breakpad. I do not like the weirdness of a sed job that re-writes the python code. In fact, this is part of git now so we can't use that. 

What do you think @rhelmer? Is it reliable to do an `open(...).read()`?
why not return the full path anymore?
Whitespace here, and on 56 and 57
is this cast really needed?
comment is wrong. will fix
There's definitely a bug in that code - the question is whether the if-clause is wrong of the equation...
Yes, but i think is better leave it in english because is most familiar, if you want translate, by the way, the word is "utente".
You probably need to check the version here as well...I believe the simplecov is 1.9 only.
`$name` is never used. Same in loop below.
"I'm talking about this Request class"

Yes, I know. When I find some time I will take up again to do the tests for this class and I'll improve this test.
Please remove this. Classes are loaded by the autoloader
Done and squashed
you should typehint the interface instead, to allow passing a CachedReader.
Can you make a PR so that it is not lost? (same for the other comment)
Calculating the sha1 of the file can take a very long time depending on the size of the file. Not sure this is really needed in the general use case.
It would be good to split `$autoValidation` maybe: the lastModified header could be set by default and the ETag only if explicitly required.
Yeah, will memoize this. Thanks.
Indent 2 spaces for this whole block.
A little thing that slipped through with "over".

I will prepare a separate small pull request with this fix and another one for 'over' later.
global variables sucks: `regex`, `matches`
Shit, will that em-dash cause issues?
It's still going to return an array. What if the original was a special array subclass? The inverted will just be a normal array.
now there is only one seracheditview, and it is the embedded one, not fullscreen
This write handler should be registered on any HC, or the master will not be able to propagate changes to the slaves.

There's separate logic for preventing any user-initiated write to the domain portion of the model on a slave HC.
From a performance point of view we should first check if there is a security manager present, and short circuit the access controller check if this is the case.
We are not supposed to have non-localizable exception messages. 

To make this localizable add a new method to org.jboss.as.web.WebMessages and use this class to create the exception.
I'm not aware of the full requirement of the global valves feature and whether or not we allow valves to be defined in any jars on the the filesystem. Is there a JIRA which I can read up to understand the requirement?
that looks good.

LOCAL/NONE/XA are the values used by the messaging model
LOCAL_TX / NO_TX / XA_TX are the values used to setup IronJacamar config. We could get rid of this one and used directly IronJacamer TransactionSupportEnum instead. That'd be less confusing
I wasn't thinking about specific widgets at this point, but more as a common way to configure widgets with common ARIA attributes (specifically relationship attributes such as  aria-labelledby, describedby, controls, etc.). For example, a slider may have multiple handles that all need to reference the same external ID as part of their aria-labelledby or aria-controls value. Or if dialog were to get more toolbar buttons.  In some cases you can add such attributes on the original element, but in other cases (e.g. DatePicker) the relevant elements are created from scratch.

I just mentioned roving tab index in case we or someone else wants to have a widget where the developer can choose whether activedescendant or a roving tabindex should be used to focus sub elements (e.g. because a roving tabindex is more backwards compatible.   

I agree on not spreading strings between options, if there is already a `messages` option then aria strings should go in there as well. Again, in this particular case a `role` option would suffice. So that means the menu widget could be configured with a role of menu (implies menuitem as inner role), listbox (implies option as inner role), or null (implies no inner role, no activedescendant).
зачем текущего пользователя еще раз сюда передавать, а потом сверять что он равен текущему? И так же все есть
I don't think so, because this is a customized CSS about prompts, the one that we should use inside `/style/bb/` has to be the original ones without modifications.
So the code would be: 
if (!document.mozHidden) {
    Recents.render();
    Recents.startUpdatingDates();
  } else {     
    Recents.stopUpdatingDates();
  }
Right?
In passing... this is a great opportunity to write a test. The `handled_call.js` file is almost 100% covered and we can keep it that way :)
Keep this line :)
typo:  s/autmatic/automatic/
Isn't the point of your ns helper function so that code doesn't need to do this?
I think that this new specification is not available yet, even the article says there is basic support from gecko 12.0
I'm going to answer both questions here. I've seen that there are visuals for implementing these 'modal screens' in System (also 'confirm dialogs', 'alerts'....), and we could have messages like 'Deleting %i messages', messages.length... that's why there is an 'update' method.
As I told you I have seen that in future these screens will be part of System, so I've preferred to create it separately in order to remove easily in the future.
What a big fail, sorry for that... xD
Let's change the deail of the  `app*` events to `{ origin: origin }` to avoid confusion.
I suspect you are right, but, wanting just a quick fix for our migration, this code worked for me. Before the patch, svn2git was failing, and afterwards it was succeeding. I don't see doubled or tripled quote marks in my new repository's logs, either. I didn't fully trace how the output of the `escape_quotes` function is used; might those extra quotes be necessary somehow?
Sorry, I misread the code. The more 'correct' way to do this is to call `Path.GetDirectoryName(_path)`.
Actually, I see where it uses `alias_for`, and thus `@prefix`. What about having a method on `Mapper::AttributeSet` where you pass in @prefix and it handles returning an index for you?
When using `try .. except`, it's best to only surround the line that you expect raise an error. So this can go right under the line that calls `get_axes` (I think). Also, parentheses aren't necessary here.
small note, I think this is the exact same as:

```scala
require(left.size == right.size, ("IndexedSeqSemigroup is only defined for sequences " +
   "of the same length, but left.size == %d and right.size == %d").format(left.size, right.size)
```
are you new to reddit, or have you been on there since 2011?
Does this mess up our ACID transaction semantics? Regardless, add an issue for this on GitHub.
This clause is confusing. Why not just do the if statement as usual and move this into an else clause?
Indicate that it generates a Google App Engine app.
The ID is sorted. Concerning the header, I considered that we may want to add further content to the header bar at a later date, in which case we could just do a yield. But there are other ways of implementing that when needed, so I'm inclined to agree and reduce the markup for the user up front. I'll remove the explicit header tag.
Should the accordianHeader be seperate from the accordion group? Why don't we simply pass the header title as a parameter to the group. Also, can you not use the natural view hierarchy instead of the id references to the body? 

Something like https://gist.github.com/3402878
Let's try to keep direct quartz usage to the scheduler package
Well, you could simply pass whether to abandon in as an option to `_full` then.
meh, after thinking a bit, this won’t work because `item` is different.
IMO yes ;-)
This is useless, as you use QString::fromUtf8 a line below with the length specified
This can be on one line, I think.
No empty strings... It's id should be 'top-stories', assuming the url is 'http://m.guardian.co.uk/top-stories'
what do you think of

No orderred dict, ` default = 'rst' ` and `if key is default` , no `enumerate` 

And it's better than the one I thought of.
What's the purpose of separating out a wrapper method `validate!` and a separate method `validate_context_response`? Unless you plan to use `validate_context_response` elsewhere, I'd say just do the work in `validate!`
Indent needs to line up inside the open paren, or these should stay on separate lines.
We used to create the cert ourselves if we ran out of certs. But this will probably not be possible with the ca being on a different machine. Also it kind fo defeats the purpose of the whole seperation. So raising an error instead.
o que acontece sem isso, ele tenta continuar antes da pagina carregar?
I'll use onSelect.
I guess it's would be better to jus remove `a return`
Added comments explaining this.
fixed the first part of this, transaction part pending new story possibly... x.x
yep, I know..
Hehehe - the ordering here is potentially contentious. So I've done a quick survey:

* Darwin: /usr/sbin:/sbin
* Debian/Wheezy: /usr/sbin:/sbin
* Redhat 5: /sbin:/usr/sbin
* OpenBSD 4.9: /sbin:/usr/sbin
* DragonFly BSD 2.10: /sbin:/usr/sbin
* FreeBSD 8.2: /sbin:/usr/sbin
* Solaris: only /usr/sbin oddly enough by default?

So I'm mainly worried about Solaris behaviour to be honest, as I know they have a habit of adding static commands to /sbin versus linked commands in /usr/sbin. The behaviour shouldn't change - but you never know :-). In our case, we would be introducing /sbin as a fallback and it may not have been there before.

I think a quick comparative test on these OS would be warranted. I'm happy to do this once we are happy with the code (as it takes time - yes I need to automate this to save me the pain :-).
This entire section should be extracted to a method so that the run method is not cluttered with this logic.
Regexp inheritance is pretty evil, and very poorly defined.  You should turn this into a hard error instead.
Setup code goes in a before action.
I've made this change in my local branch—no need to change here.
Remove this empty line (and all the others for the properties and functions, we don't have an initial empty lines in CS.
Removed this check
IMHO for this case it's better do `if ($locale === null)`
display the title as:

```latex
{\bf THE TITLE}\\
```

(only if there is a title after converting it with ```self.convert(title)```
How about using method result here?
```php
<php
$self->_initializers += array(
'meta' => function($meta) {
    ...
    return Inflector::tableize($meta['name'])
});
```

Passing it as a reference and modifying the array directly opens up for discrete bugs where your `title` initializer sets the `source` value.
On the pro side, merging everything to one initializer would perform better, leaving more room for optimization.
ok, we don't remove ie.js...
You'll need to specify the preview url as an environment variable, thinks
it's better that it works by default in the vm and you configure it outside
(not the other way round) but this is up for discussion.

sent from my sg2
On 13 Dec 2012 15:29, "Chris Parsons" <notifications@github.com> wrote:

> In config/environments/development.rb:
>
> > @@ -28,7 +28,7 @@
> >    # Expands the lines which load the assets
> >    config.assets.debug = true
> >
> > -  config.slimmer.asset_host = ENV["STATIC_DEV"] || "https://static.preview.alphagov.co.uk"
> > +  config.slimmer.asset_host = ENV["STATIC_DEV"] || "http://static.dev.gov.uk"
>
> Not sure I understand this correctly, but won't this break the app in
> development outside of a VM?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/whitehall/pull/98/files#r2407585>.
>
>
Why isnt this a link? You are not submitting anything.
you should remove the ``@return void``
Againt, evaluating ```gt``` seems superfluous. But maybe GHC can optimize it away?
make function that returns this (it's used quite a bit)
This part is from Sensio Connect, I trust they tested it (even if they don't give official tests in repo) =)
We don't need PROC and PROGRAM here for the cinwords.
"a kwarg" ;)
Extra whitespace between '}' and ')'
woops, I had meant to do it with two args
create! would raise an exception if unable to save, so it ensures that validations are correct.

find_or_create_by would always create an object, but not always save it to the database, and that was the real error we had, we had an os object without a name.

that object has no idea, and later on some where in rails relationship code you would get something like

```
host.operatingsystem_id = operatingsystem.id
```

which caused the os relationship to be removed, as the id == nil.
Type: `inshance` should be `instance`
If you could look into using a custom solution type so that people can type lowercase versions of the answer, that would be helpful. (e.g. If the answer is "D9", it should accept "d9")
nit: I'm not sure we actually use this anywhere (everything is keyed off the filename), but for consistency we should update the title here
Is this the internal node's key? Sounds like it's the key for this projection (which isn't right).
BLeah, the names ar edifferent, seems like PacketGenericItem in SPN is called PacketCustomItem in SPC... will take a few mins to figure out what's going on :/
You don't want those above 5 lines. Use directly firewall['ipv4']['TCP']
Move JS into body
This would make more sense to me nearer the end of the function. When I see a variable reference I tend to scan upwards in order to see where the variable is introduced.
what about this??

```js
if (exports.favicon.indexOf("//") > -1) ...
```
According to the above changes, eZURLAliasML::setLangMaskAlwaysAvailable() first parameter cannot be false anymore, this should therefore be changed, right?
Не понятно. Предлагается переписать для TypeNameVer = int, или подумать как убрать map для общего случая?
We should  keep the empty line here as per pep8 rules.
you can just do `return selected == 'bold'` :)
This is a snippet from one of my commits that's showing up in this diff.
I wonder if LESS has some magic for sprites built-in ``</thinkingoutloud>``
You might bust this out into utils.  It is going to be needed for DE tournaments as well. 

I feel like this function really needs to have some unit test coverage as well.  We should do something about that soon.
I know this is nit-picky, but ruby methods should use underscore_notation instead of CamelCase. CamelCase is used in js code.
This is standard stuff when creating a gem with "bundle gem" which was my starting point.
I think the traditional way we've approached these things is to pass the context into the service api method and have the check in there.
Does that mean this can be merged then?
`@private` doesn't seem to render properly in the UI.
Mais, heu.
I think I'll squash the coming commit ...
В принципе, далее в коде count нигде не меняет своего значения, так что можно убрать эту переменную и использовать CAPACITY.
Объявить константу нужно в одном месте - например, в Cell.h. Или в Cell.m. но никак не в двух местах.
-(id)init - это конструктор класса. Обычно конструкторы описывают в самом начале класса, ведь там задаются значения оснвных переменных., параметров и т.д. , а потом уже описывают и другие методы.
В вашем случае реализацию init можно заменить на
- (id)init {
    return [self initWithLenght:100];
}
http://developer.apple.com/library/ios/#documentation/general/conceptual/DevPedia-CocoaCore/MultipleInitializers.html
It would be good to have tests for routes we depend on. Could add tests for this? assert_recognizes should do this for you. There should be some existing tests around using it.
So, am I supposed to change something here?
I noticed this is also (and originally) further down in the method's `$class->fieldMappings as $mapping` loop. Was it a bug that the field also wasn't skipped in this loop?
It looks like there's invalid JSON here; missing comma
I don't like the redundancy of word evoked in the parameter list of init of the Evoked object. Can we find better?
We don't put such comments in code. The same info is stored by git and you can easily view it using blame or in Eclipse Team -> Show Annotations. Please remove it from here.
PUT and DELETE are not unsafe methods, since the only way to make a browser issue a PUT or DELETE request is using AJAX, and if an attacker can make a victim browser issue an AJAX request, then that means they've found an XSS vulnerability, and if they can run Javascript, then they can read the token out of the form, so CSRF projection is useless.  The only methods that an attacker can exploit with CSRF are POST and GET.
maybe, maybe not. the confirm will present which gems are about to be shipped, allowing the user to decide if its good to go
That depends, is this article compatible with 2.0? I would hope that it would be. If so, after merging this into 2.0, we'd make the changes necessary for 2.1 (including `parameters.yml`).
Why 2.1.5 ? 2.1.0 was using Composer too
Not recommended in general, see akka.util.NonFatal
fixed, now uses akka.amqp.timeout
These can all go on one line, separated by commas. Enclosing them in parentheses allows the line to be wrapped as it grows:


```
import (a, b,
    c, d)
```
А ты виджеты-то по их смерти прибиваешь из этого хеша? Разрастется же со временем пипец как.
I still don't understand what you are trying to do here.  Let's do a hangout and we can talk about it.
If you wrap a `require` in a module, does the required code get executed inside that namespace?
What does the is_unique thing do?
right now, it's reading from shared preferences, so i think it's okay - but if we switch to storing the bookmarks in a database, then yes, we'll need it on a thread.
it should be test gainst 0  ``strpos($file, $registry->get('GV_X_Accel_Redirect')) !== 0``
Seems to work so no need to drop it for now
if there's an exception at line 231 then the suspend @ 237 won't be invoked which is bad. 
IMO this if should only happen if we didn't get an exception during apply mods (we are in finally here so this code might be executed even if an exception was thrown).
Here's my suggested logic:
- if 1PC and the replayModifications succeeds commit tx
- if 1PC and the replayMods failed rollback tx and propagate the exception
- in 2PC, even if it's a success or failure, put it in the remote2localTx map (if failure propagate the exception)

it is critical that tm.suspend should happen even if any of the commits/rollbacks below fail

Thanks!
Are these changes necessary?  Have we added classes called *Command elsewhere in the code base that are not, in fact, commands?  ;)
Yeah, that makes sense. It is not an urgent issue to tackle but some basic checks should be made. Currently users can specify name of this cache in MapReduceTask constructor.
Not sure why seperate devDependencies were here in the first place, but if its a dependency, there's no need to also list it as a devDependency.
It would be more readable if there were parens around the multiplication part here.
Shouldn't this be (By.ID, 'product_version_select')
je ne l'avais pas vue celle la mais je dois aller dans le sens de MoOx, unilinéaire n'est pas adapté, mais je ne suis pas sur du mot qui irais mieux pour etre honéte
put onVIsibleIndexChanged's logic in a function, call it on Component.onCompleted and onVisibleIndexChanged, then there's no need for the hack, or the comment
All this needs to be translated too, but that's an easy patch.
Great idea actually. Will do.
I suggest adding the keyword 'advanced'
The typical solution is to rely on RightScale::Platform.filesystem (from right_agent gem) for all base paths. Also use File.normalize_path(File.join(...)) semantics to ensure fully 'normalized' paths on all platforms.
Is there a reason for not using `getUserLocale`?
I think I tried that initially. That was at least a month ago now though, so I'm uncertain.
Note: the namespace needs to be changed, because we can't entwine onmatch twice to the same selector within the same namespace (the original onmatch is in LeftAndMain.js). If we don't change the namespace, the other onmatch will not run, and the CMS will not load :)
Are you sure ``$item`` has the correct type as "object<Symfony\Component\Finder\Iterator\type>" is not a sub-type of "string"?
Is it possible to define the element type for the array of parameter ``$event`` (using ``array<SomeType>``, or ``SomeType[]``)?
Are you sure ``$mockConnection`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Db\Adapter\Driver\Sqlsrv\Connection>``?
reverted back and added scaleX and scaleY scaling parameters to be multiplied to original values
The 'has-permalink' is injected into headings (i found h2, h3) at runtime. I cannot see a visual difference in the rendered page.
On 05/31/2012 12:07 AM, Oleg Efimov wrote:
> Current master is good for me :) I do not know Pyton library so much.

Well this is what collaboration is good for :-)
#nitpick - strictly speaking, google comes after github alphabetically.
Probably need something like this again, to prevent overwriting other filters.

```js
style.filter += ' alpha(opacity=100)';
```
please see my previous comments about spaces and operators
Match variable name with dict key name (or form field name).
`$('<ul></ul>')` -> `$('<ul/>')`
Hm, aren't comment resources nested to post? They do not need to be independent.
It does not seem to be just for testing, you are using it also elsewhere, this function?
Because for Facebook we do GET, and you have to do POST, it seems. Read how you do that with urllib.
Thanks for that hint. I've now added such a test which adds "UNKNOWN" to unsupportedData if that happens. Then, removeUnsupportedProperties removes all frames that successfully cast to UnknownFrame, if the given list includes the keyword "UNKNOWN". This doesn't seem super elegant to me, though ... perhaps there is a better way to deal with the issue.
Down the line, we'll probably need to make this customizable. Just throwing it out there...
Avoid qualifying with namespace.
nice line!
you again! seems strange to return 1 on an error...
@maxtaco -- @michaelficarra, as part of my refactoring of this commit in 34be878257b9206e02046cb4ab10101e6266cd9f, I removed this change. No tests failed after I did so. Was this needed for some behavior?
Я бы как минимум написал 
_type = NotImplemented

Это совсем не обязательно, но ошибка если забудешь проставить _type в наследнике будет, наверное, более понятной.
Постараюсь это получше рассказать в субботу.
Do you mean "into the watcher startup".

Maybe should we name this worker_hooks? To differentiate between future other hooks for instance.
ok, I removed this line and pushed the branch, sorry I don't know how to revert a commit :/ if there is a good way, tell me. thanks
Does it really make sense to zoom out to 0.5? And, why 0.5?
Yeah I think the solution you made sounds good.
Ok.
Done
Interesting. I realize this is from another change (so this is mostly for Dan) but why shouldn't this just generate an error?
Format in the way to move `{` one line up.
No, this is not OK. We are using Django app template discovery.
I would use DROP instead of 'remove'. Just to use same terminology as UI.
Wee as in pee? ;) ;)  I'm guessing this is "we check"!
The uniform deviate should be provided as a parameter.  We will want the ability to use deterministic seeds.
I didn't change the documentation for this function at all, since I thought it would be worth waiting for the functionality to be finalized.  e.g. Should we split this into two functions?  Here or in 248?  

But I think the gridded shears are always saved.  And they are regenerated whenever the user provides the `grid_` parameters.  They are reused when they don't provide the `grid_` parameters.  So if we defer to 248 for any further work on this function, then it won't be too hard to add a description of this behavior to the doc string.
It now uses the abstracted _executeSql to keep all SQL flowing through the same function, but mainly so logging can happen when debugging.
This is an ident issue. I don't remove code here.
Is the problem this is supposed to fix specific to redhat ? Wouldn't it be an idea to define that 3.0.17 should be *the* activerecords version we want on every puppetmaster, create rpm/deb packages instead ?
addCaretLocation() isn't exist.

I seen setCaretLocation(), on that code in the original SWT.
I had issues making it work.  My current thinking, but it might be best to compile this and FPM it.  thoughts?
I wan't to get rid of this. Although i like the idea, this only works on unix, not on windows. Second, I think the synchronization of the project version should be achived by a leiningen plugin that calls out to the scm system defined in :scm, see https://github.com/technomancy/leiningen/blob/master/sample.project.clj#L271 for an example.

We should investigate https://github.com/relaynetwork/lein-release or https://github.com/ato/lein-release (i like the changes by ato)
Ah thanks, silly question. I shouldn't have read just the diff.
I'm curious why you chose yellow?  Most diff tools use green.
this is weird - but I'm guessing there's some reason to setting this?  why not a blank function?
Ah yes, you're right.  I replied on the PR detail page which didn't show as much code context.  

When I was working on this, I was going through tests removing unnecessary DB activity (or spitting it off to the ``tests/integration``) folder.  Not the case here though, I probably removed ``create`` then realised that I had to save the voucher to exercise the test but didn't bother reverting to use ``create`` again.
I did not add this to IConnection to avoid a breaking change to inheritors.
afaik there should be a space after the ``(array)``
Should start with capital letter and end in full stop
Got ya... I didn't get down into the Guzzle part of it. Sounds good
Revert all changes after this line.
Hrm.  Thought I diked out these due to retardedness.  Let me go re-dike-them-out.
This could break easily if new types of items are added that shouldn't be possible to pick up. Rather than a blacklist, I'd suggest a whitelist.
Каждый поток надо закрывать по отдельности (в try..catch). Если упадёт закрытие одного - другой может закрыться.
Надо закрывать ресурсы.
Using a real memory store makes Webrick not return 500 when it's looking up already-cached pages.
undupe
I would like `click_submit_review` to be taken out as you don't write the review on the details page. I'd prefer the action for that specific page to be kept in that page object, so on the test side it would look like this:

add_review_page = details_page.click_submit_review()
review_page = add_review_page.write_a_review(rating, body)
New proposed version does not have that line if I read correctly
Not sure how $attr[$n] is allowed to be undefined here, but I've run across circumstances where it can be, so I'm just checking to make sure it "isset" first before displaying it. Same thing with line 2403.
CC @amueller @ogrisel ?
The description at the beginning of a docstring should be a short description. I think that the pros and cons of using this rather than K-means should be detailed in the Notes section of the docstring.
The mailing list disagrees. Maybe comment there?
train -> training
I'm a bit unhappy with the fact that it does something very similar to DictVectorizer but is in another module. As long as they reference each other, it shouldn't be too bad, though.
The name `arrayCount()` is wrong as objects that implement the `Countable` interface are also handled by `PHPUnit_Framework_Constraint_Count`.
Again @ZNickq if you do all of your PRs in separate branches you would be ok
Add support for NumberObject. The same for other places.
Do not change the ordering of params in existing functions, ipAddress should come after ndk
Il faut spécifier une URL de redirection
What happens if doNextGroup() throws an exception?
An insertion sort? I guess the list doesn't get long enough for that to matter, but it's still painful to read. Isn't there a method to sort a StringArray ?
NB: this has mostly moved into start_slaves
Even though I removed the TreeExpressionDumper, I'm keeping the base class. I'm not sure yet to which future the IRDumper will move, and don't want to make things more difficult later on.
I see. It's optimization. 

However, unless you have hundreds and hundreds of rows, I'm sure python will be fast enough to create a whole new query string each time. It's no IO but just some python string and basic types manipulations so it's probably fast enough. 

Good catch though!
Nope, that's covered in detail by the tests outside of these context blocks.
муу биш буруу
We do not for `contentScript` and `contentScriptFile`, I just did the same.
should we really use ``assert`` in many places of the solver ? This may help when debugging the solver but leads to crappy reporting to the user (see the issue tracker)
Please keep my original comment.
Shouldn't this be `self.assertEqual`? `assertTrue`'s parameters are an expression and a message so this would have passed before the patch.
I think this has to be rewritten to something like  **Page Should Contain Element** or **Element Should Contain**.

see http://rtomac.github.com/robotframework-selenium2library/doc/Selenium2Library.html
same as all the others. No locators in tests.
Is this testing pagination or is there some other purpose for this method.
Since we're starting with "coming_up", the overdue checks will all be no-ops, right? (I don't think overdue is a requirement for the merge, I just want to clarify the expected outcome of the merge with a comment somewhere.)
I'm importing all the calcentral specific stuff after the foundation things so we can re-use the foundation variables.
That's also why I prefixed everything with cc-
Odd, did you get any kind of error message?

Tom


On 3 December 2012 17:51, otsix <notifications@github.com> wrote:

> In www/index.html:
>
> > +    <th scope="row">Archlinux 2011-08-19</th>
> > +    <td>http://iweb.dl.sourceforge.net/project/vagrantarchlinx/2011.08.19/archlinux_2011.08.19.box</td>
> > +    <td>565MB</td>
> > +  </tr>
> > +  <tr>
> > +    <th scope="row">CentOS 6.3 x86_64 minimal</th>
> > +    <td>https://dl.dropbox.com/u/7225008/Vagrant/CentOS-6.3-x86_64-minimal.box</td>
> > +    <td>310MB</td>
> > +  </tr>
> > +  <tr>
> > +    <th scope="row">CentOS 6.3 x86_64 + Chef 10.14.2 + VirtualBox 4.1.22 (with guest additions)</th>
> > +    <td>https://s3.amazonaws.com/itmat-public/centos-6.3-chef-10.14.2.box</td>
> > +    <td>445MB</td>
> > +  </tr>
> > +  <tr>
> > +    <th scope="row">CentOS 6.3 32bit (Ruby 1.8.7 &amp; Chef 10.14.2)</th>
>
> This machine is not on the list? But link is working...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/garethr/vagrantboxes-heroku/pull/43/files#r2295597>.
>
>
Whoo hoo Manipulators!
Using destructuring, it could be written like this:
~~~clojure
(defn contains-point? [rectangle point]
  (let [[[x1 y1] [x2 y2]] rectangle
        [x y] point]
    (and (<= x1 x x2)
         (<= y1 y y2))))
~~~

The other exercises in this series would also benefit from destructuring.
Nice, looking good!
well, in my test env, connecting to the computer's domain DC actually works, with no domain user account (or with system). 
I assumed computer credentials (which is on the domain) where used.
It's probably a good a idea to use the transpose to the x, y coordinates as @emmanuelle suggests. The original Harris example code should be changed too, but that can wait for a separate PR.
please indent things inside the ``{% if %}`` block according to the Twig coding standards: http://twig.sensiolabs.org/doc/coding_standards.html
What's going on here?  Would it help out the user to explain what we're doing and why?
why not StringBuilder builder = new StringBuilder(address1);  ?
Surround Water with back-ticks, and markdown will highlight it.
opptional. Defaults to true
Are we missing a 'returns' section here?
Correct. Should be 'or'. Fix the yml and then we can merge.
Correct. Fixed in 6483956294d0a977bfa2c497873d5da47f69cbcf
I've inlined `return callback();`, since return has no meaning to async.series() anyway; saving a line.
weird header reformat
remove this debug statement
In theory, this could still not be enough if a user-defined type had a `min` property with a type different than what expected, but I'm not sure if this is worth considering (should probably be fixed in `mostNegative` then anyway).
const should be fine it it just works
I swear I was only referring to the placement of the comment on the same line as the brace, but now I'm glad you found an actual issue :o).
Thought more about this and a rank function that yields the dimensionality of an array (be it static or dynamic) may be useful. Since the first line in the documentation is "Gets the rank..." let's just call it `rank`. As such these should pass:

    static assert(rank!int == 0);
    static assert(rank!(int[]) == 1);
    static assert(rank!(int[42]) == 1);
    static assert(rank!(int[7][8]) == 2);
    static assert(rank!(int[42][]) == 2);
    static assert(rank!(int[][42]) == 2);
    static assert(rank!(int[][]) == 2);

A corresponding `staticRank` could be defined but I don't think it has much generic utility to it.
`opSlice` _must_ be relative.  For instance,

    auto slice = range[5 .. 15];

must be equivalent to

    range.popFrontN(5);
    auto slice = range[0 .. 10];

If that's not currently the case with your code, then I clearly didn't read it over carefully enough, and it needs to be fixed before it can be merged in.
hud has defined previously in pauseButton, score and life tables, hasn't it ?
Move `rextension.py` to `easybuild/easyblocks/generic/`, just like `pythonpackage.py`.
I think all these links should be clickable :-)

Also, indenting appears to have gone weird here?
ups? :-)
checked it, they didn't get exported
hmm, fair comment. 

@kylemcdonald @bilderbuchi i would be curious to get your opinions on this..
This was more of an issue when we ran 1.8 and GC was slow. I am not sure how much or little this improves performance in 1.9.

But shard_name() seems to be called very, very often:

I added this to my local shard_selection.rb file:

```ruby
def shard_name(klass = nil, try_slave = true)
  @@count ||= 0
  puts "- shard_name count #{@@count += 1}"
```

And started the console:

    ./script/console

    - shard_name count 1
    ...
    - shard_name count 21889
    - shard_name count 21890
    ===== YOU ARE ON SHARD 1 =====
    >> User
    - shard_name count 21891
    - shard_name count 21892
    => User(id: integer, account_id: integer, is_active: boolean, roles: integer, name: string, time_zone: string, uses_12_hour_clock: boolean, updated_at: datetime, created_at: datetime, crypted_password: string, salt: string, external_id: string, phone: string, details: text, openid_url: string, organization_id: integer, notes: text, restriction_id: integer, is_private_comments_only: boolean, delta: boolean, locale_id: integer, is_moderator: boolean, last_login: datetime, permission_set_id: integer)
    >> User.count
    - shard_name count 21893
    - shard_name count 21894
    - shard_name count 21895
    - shard_name count 21896
    => 11
    >> Rule.count
    - shard_name count 21897
    - shard_name count 21898
    - shard_name count 21899
    - shard_name count 21900
    - shard_name count 21901
    => 139
    >> Account.count
    - shard_name count 21902
    - shard_name count 21903
    - shard_name count 21904
    - shard_name count 21905
    - shard_name count 21906
    - shard_name count 21907
    - shard_name count 21908
    - shard_name count 21909
    - shard_name count 21910
    - shard_name count 21911
    - shard_name count 21912
    - shard_name count 21913
    - shard_name count 21914
    - shard_name count 21915
    - shard_name count 21916
    => 5

Do I have a bad setup? Maybe there should be written a performance test specifically for this method?
Also, are you sure that `getAttribute` returns an integer? I thought it returned a string -- if this is the case, you're doing string concatenation...
I noticed several failures due to missing kernel parameters, but I'm going to fix that after merging this down.
Does runtest work? in this case, don't comment it out.
Микрорайон, если есть
Could you move that to an ``@author`` tag on the class?
I don't really like it in the ApplicationController, that's for sure. I'm open to it but I just wouldn't know where to put it.
Must not use CPUID 7 without checking that it is supported on this CPU.
s/./,/
Since you are in onInit() method which relies on and validates the current state of this class may be Assert.state would be more appropriate here since it wil result in IllegasStateException where the current code is IllegalArgumentException (think that this method has no arguments. . . could be a bit confusing)
Read my comment. Basically as long as this method was executed the this.contentTypeExplicitlySet must be set to true signaling that whatever the current value is was set intentionally
I am almost positive that it was an issue even though it was not included in the comment for that commit. I remember discussing whether it should be an error or a log message.

I'm okay with leaving it out (agree it's noisy), but I think we need to track down the related issue and add a comment to it if we do decide to remove the warning message.
You can configure which messages are sent (started, completed). You may have removed the started message on your instance.

It seems like a good idea to add a configurable message for "Nothing built" and have it send that in this case.