labofsahil/github-event-dataset-2012 huggingface dataset:
Please use git add -p xkcd.py to stage only parts of a file for committing, if necessary. In this case, it would be better to separate the commit for fixed indentation from the new feature announced; makes it much easier to find whatever one's looking for in the code.
Yeah, I saw that it was deprecated but that was about it.  I figured I'd be safe rather than sorry. :)
I would suggest that we use the jQuery.trigger()/bind() event system rather than creating our own one :)
あ、しかも owner 消えてしもた。
When I forked from the fog pool, there was no this paragraph of code. let me check it and make the merge
Let's remove commented out code
Why/how was this line modified?
Does it mean that each time "getProperty" is called, "accessDate" changes?
Why 200? Shouldn't it be 400?
This should throw an exception if used from an event-based context, i.e. within an actor of future.
this is junit, right? Then you can use:

    @Test (expected=Exception.class)
No, this reads fine. Using `List` or `Vector` as arguments is more readable. It's only in the case where there is an explicit conversion, that I think it needs to be overstated.
That's a great explanation to put in a comment above this method!
why not inline this?
That said, I do find default arguments hard to refactor, especially of such a meaningless type as `Boolean`, so please pass it explicitly where this message is created, and use the argument’s name to be perfectly clear.
I think toIndexedSeq can be optimized to return "this" to[IndexedSeq] doesn't. OTOH I think it's a code smell with all these toX methods...
So for performance we might want to use toX but with a TODO to switch to to[] when it is smarter
Ok. I created a branch wip-2579-squashed-scheduler-drift-akshaal and squashed wip-2579-squashed-scheduler-drift-akshaal into it.
I don't know whether it's possible to update this pull request or should I create a new one...

Here is the commit:
https://github.com/akshaal/akka/commit/3783be2f58d4380e900891d7b8331f4333dc7d86
This is the main part of the json support.  It makes the content into an array, which isn't important for Xml/Html, but is for Json.  Essentially it is like uses render_array, which is similar to render! so that it gets the chunks in an array with the text content.  Very much like the children of a DOM node which are a mix of texts and elements.
I'm certainly not going to do that now, or without discussing first.
Maybe you could copy over the docstring examples from numpy here, so they get tested.
You need to add the new offset param to the docstring of each of the action functions you added it to
The @return is wrong, it says "href" but it will be "_href".
This doesn't belong here.  If it is needed, do it when the errors are actually copied down in the model code.  It is supposed to just report all errors on the "card with account".
got it, then we can remove?
I still think we should generated the pmt change packet right here. Any in progress PES will very likely belong to a stream that will continue after the change. So it is not a problem for it to be output after the PMT packet.
Well the chance for a failed CommitTransaction() is very very small so IMO this change is acceptable but can you add a comment like
```
//TODO: move this below CommitTransaction() once UPnP doesn't really on this anymore
```
so we don't forget why it is there and that it would ideally be placed differently.
oh yeah, begging your pardon arne

On 6 November 2012 12:39, Sascha Montellese <notifications@github.com>wrote:

> In xbmc/music/MusicDatabase.cpp:
>
> > @@ -2194,8 +2196,8 @@ int CMusicDatabase::Cleanup(CGUIDialogProgress *pDlgProgress)
> >    }
> >    if (!CleanupSongs())
> >    {
> > -    RollbackTransaction();
> > -    return ERROR_REORG_SONGS;
> > +    ret = ERROR_REORG_SONGS;
> > +    goto error;
>
> @cptspiff <https://github.com/cptspiff> has the final word these days on
> PRs being merged ;-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/1739/files#r2041680>.
>
>
bump the version to 0.6.1?
What i must doing in this situation, how i can test this? @ya.ru is necessary? I'm used gmail.com on github.
This cast needs to be removed.
As above, implicit synthesis takes care of this.
What SDK are you building against?
For clarity, they should be left as `unsigned int`, even if they are identical once compiled.
lol, whoops. Done.
`args[0]->IsUint32Value()`?
I'll test this PR on windows.
assigning the same list?
Need a hint about this situation. Anyone?
Yes, your correct.  Should be 'settings.MAX_DOCSTRING_WIDTH'.  

Again warning that I didn't test these changes - and this makes it very obvious.
и табуляции не торт
не надо ничего делать с квадратиком!
он тут по историческим причинам, возможно, самый древний сохранившийся доселе код. 
бороться с ним тоже не надо, пусть будет.
Sorry, I was unclear. The original space was non-breaking.
Still, I prefer new approach. @rafaelfranca, WDYT?
Okay, sorry. ^^
SNOWMAN BLOCKER
To tell the truth, the original signature was `rebind :: Any => Unit`, but when I changed it to be non-mutating I thought that `bind` would fit better.
This must be `findAllMatchIn` instead of `findAllIn` in the example.
Is there a specific exception that happens in this instance? I would really like a less generic rescue here than simply from `Exception`.
Why have all of these functions been stripped of perm? I would think the convention of starting with an underscore (_) doesn't apply here.
You have a few objects that don't inherit from `Basic`.  If these contain mathematical information about an expression then they should be Basic so that other sympy utilities can manipulate them (through subs, replace, free_symbols, rules, etc...)
Furthermore, note that I intensionally used `expand_multinomial` here, which doesn't even take a hints argument.  The `expand_hint()` functions are designed to be for that hint *only*.

But actually, I guess some hints apply to other hints, like `force`.  So I guess that API should be changed.
set off "an element of ``self``" with parens or commas?
Maybe these could be defined automatically somehow.
@flacjacket I think this does come under a AskImaginaryHandler for example the cube root of unity.I think we already discussed on this issue previously.
This is ambiguous. When I first read it, I thought you meant that it assumes that the coefficient ring is the zero ring.
Fixed.  This one was crazy, sorry.
Nice. i think this is probably a pretty effective the pattern to use throughout matrices.
template.carouselItems returns an array of Items(objects). So; I've renamed the variable which is being assigned with the returning value and used appendChild.
merge these two lines by `fig.name = str_c(sub(str_c(fig.num, '$'), '', x[1]), 1:fig.num, '.', x[2])`
Not necessary bottom of the page. If it fits a subsection it's OK to use it in this subsection. I think we have some links to external resources in the guide. At least to PHPUnit docs, I think.
…and Images.
`request.user` should always exist, no?
Do you want to maybe change that line to avoid duplication with gitconfig?

  alias glg='git lg'
Line removed !
Idk, may be I should declare enum instead?
>> @@ -19,12 +19,13 @@
>>  # IN THE SOFTWARE.
>>
>>  E=
>> -CSTDFLAG=--std=c89 -pedantic -Wall -Wextra -Wno-unused-parameter
>
> I am not happy with this change. That `--std=c89` isn't used because it
> looks so nice.
Will revert.
That's the one I said "You can revert".
Note that with musl, reverting it makes for an FTBFS (the headers are
written for C99).
Why not something like ````sq.question_setup = Factory.build(:question_setup)````?
Summarize the end of the paragraph and the beginning of the next as: 

" Before version 2.0, clock skew could cause increases the probability of problems with distributed locks, particularly when drift exceeds 5 minutes. This skew can lead to failed distributed locks and potential data loss. Always run `ntpd` to minimize clock skew.
Ah. Je comprends. Bon. Effectivement, le fluid ca utilise des largeurs relative, donc ça remplis tout l'espace. Le non-fluid c'est static et la largeur de la page est fixe (en incrément selon le responsiveness).

Ok. Dommage, car la plupart des sites web hot sont pleine largeur. On a ici un site web assez classique à la wordpress. Mais, c'est ce que Eric voulait j'imagine.
`new SphinxClient ()` -> `new SphinxClient()`
It's actually never explained what searching by an exact phrase is to begin with, but I guess that needs to be fixed in a separate PR for the other search backends.
$request->variable() instead of request_var()
Use a different editor? vi for example won't show it and in fact I don't know how you would delete it in vi.
Thats nice. Please let me know what the ticket will be. Ty.
please put space between args
Assuming that “Check” meant “did it” – maybe you didn’t push?
Might be nice to document the callback parameters, such as `@param {function(obj)} callback`.
Note that this alters the semantics of the prior version, which let dest fall through to the final loop which would copy over properties. As long as we only want the blending operation to work on "content" this version is fine. But if we were to put any metadata on the Array instance it would be lost in this new version.
Remove `System` prefix
Can delete all PatientList comments
申明不要在分支中。
e gone?
I don't think this is a good enough explanation of the concurrency strategy. Not knowing anything else I would wonder if there is a deadlock where this code calls out to something else that is trying to acquire the lock object in here.
Is name being null an error? Or can this happen normally?
Why is an additional store needed for filtered data?
Couldn't find it in the documentation.
Maybe use (some modification of) CopyRegularFileDisk() here.
Would only affect existing code relying on that. Internally, Knockup does not care. Since there hasn't been a dot release and we aren't fully using it yet, it won't have much of an impact if at all.
Don't you want to use DatabaseCreation._digest() here?
Should probably check for the specific error that was encountered as well.
And fit 80 char limit here too, please.
`coordinateRange(begin(S), end(S))` can be `StringLiteralRef(S)`.
I'm getting my repos all mixed up now, I have a jQuery.noConflict() in the jquery-compat plugin tests. :see_no_evil:
`return ret.join( glue[0] );`
Why the change in behavior?
Variables with initial assignments should not share a line, and (for better compressibility) the `for` loop should match others in the file:
```js
var i = 0,
    len = tokens.length,
    selector = "";
for ( ; i < len; i++ ) {
```
If we can use it safely for all versions of databases, I am very happy to use it instead. Please confirm for us. Many thanks.
No, DECLARE_UDF is a macro for declaring the C++ UDF implementation first, and then a macro for declaring the C export afterwards.
I see. I did not get an update from your design document which said that hessian is not advisable for Cox. So, this means you somehow find a way to do it using Newton's method?
I mentioned it because we talked about generators and I was curious as to why you decided not to use them. Not using them seems like a good idea here. bd
Since this function is called by functions for getting paths for html, css, headers, and js files, it seems odd to have this conditional in here that assumes it's an HTML file. Perhaps there should be a default for each type of file? (It could be added pretty concisely by using e.g. `filename or "index.html"` in place of `filename` where this function is called)
This can be just

```rb
system "autoreconf", "--install" if ARGV.build_head?
```

but the formula also needs to declare dependencies on autotools as they are no longer shipped with Xcode, e.g.

```rb
if MacOS.xcode_version.to_f >= 4.3
  depends_on 'automake' => :build
  depends_on 'libtool' => :build
end
```

same for #11669.
True. I wanted `brew list` and other still to function even if no compiler/Xcode or whatever is found since raising an exception may be too harsh.
Probably needs deps on autoconf/automake/libtool then?
I probably had a reason for it once ;) Reverted.
Also, I'd suggest calling ```translate.setHandler()``` here instead of below. It's more confusing to separate the calls and if this detect function ends up in Zotero.Translate, it won't take a callback, because everything else in Zotero.Translate uses ```setHandler()``` and a callback would be redundant.
Style in the JUnit self-tests is to always put the annotations on a separate line: https://github.com/KentBeck/junit/blob/master/CODING_STYLE
I have a default attribute set to nil, though, and "defined?" evaluates to true on a variable set to nil.
Not `new Array()`, `[]`.
It returns the path of the window that it's called from, so if it's called from the test window, it returns the test path. Maybe it could have a better name.
The fail case also needs to clean up the  `_pendingDocumentPromises` entry (otherwise all future retries will fail immediately since they'll be looking at the old promise).
We should explicitly return a string here: ``return Number(keycode - KeyEvent.DOM_VK_0).toString()``
Ditto -- remove `return`
I think this should be onClosed(), not onClose() -- to match the base class function in InlineWidget.  As it stands, I don't think this will be called when the widget is closed "from outside," e.g. by pressing Esc... which will cause us to leak memory by never removing it from _colorPickers.

Note that the onClose() call in InlineColorEditor.close() needs a corresponding rename too.
Indentation should use 4 spaces.
OK, I made some necessary changes in InlineColorEditor.js so that we can use onClosed to match the base class function in InlineWidget. That also fixes the focus restoring to main editor after closing the inline color editor.
Oops. Gotcha
So this also means this method should not have the call to dirname()
Make a helper function called `message_para(message)` that returns `Markup('<p>%s</p>' % escape(message))`. Both `Markup` and `escape` can be imported from `flask`.
I do not understand why is copy-pasting necessary? You ought to be able to just extend the User document from mongoengine `auth.py` and add additional fields and methods. Why is this not working?
This won't cause trouble, will it? I'm guessing you only need popcorn for this closure, and not when export happens?
need this be capitalized?
Add some spacing after `null`.
Oh, I see! So, this is just to correct what is spewed out. This is fine then.
Should we use `SCROLL_MODIFIER` for the Firefox-specific scrolling as well?
Dev versions vs. production, will be fine in the real world.
It's actually unnecessary for this `if` statement to have an `else` clause. Note that `oldPreviousModel` and `oldNextModel` will never both be defined from the logic above, so they won't both be saved. My main reason for structuring it like this is to make it look like it's saving every single model that was changed (which is the point) rather than paralleling it to the code above.
Actually, it doesn't. See the actual function code in green below.
We should not be looking at the user agent. Use feature detection instead. See https://github.com/kriskowal/es5-shim/blob/master/es5-shim.js#L599 for inspiration.
Indeed, it surely is. I wonder why the spec testing the old-style hashes didn't fail when I changed that. I'll push a fix back.
This should be `etc/salt` (no `/` at the beginning) ?
If this arg is renamed to ``pkgs`` it should allow any existing code to work correctly.
So you are saying collision will happen 100% of the times name is bigger then 3 chars?  It doesn't make sense.

I will use the constant instead of nanoTime.
Should we change the default copy number, the same as Haproxy?
В главе про заморозку — да. Но ок, продублирую.
Why is it Try? Why would it fail?
Typo "easil". 

Haddock doesn't use backticks, you should use `'static'`. 

Please use @s surrounding code-like text so that it may appear with a monospaced font: `@addStaticContent@`, `@\_ _ _ - > return Nothing@`, `@Settings/StaticFiles.hs@`.
I didn't say anything about transforming objects, just putting the logic of matching Layers and Records into the backend instead of having it in the views.  I would argue that this is more about choosing appropriate abstractions than adding new ones - is a catalog backend just a slightly smarter wrapper around owslib's CatalogueServiceWeb, or is it responsible for bridging the divide between Django models and Catalog records?  I think we can choose the latter without adding bloat here, and isolating the catalogue record-wrangling code from the template-slinging seems worth it to me.
Oh, this is all a GitHub-ism. I've hoped to keep these out of Pkg.
@tstrachota could you comment, please.
@iNecas was suggesting just the ID and you initially suggested ID - what is your reasoning for this? The HAML? We can get that info from the controller...
when you generate apipie api documentation with the new tool for generating https://github.com/pitr-ch/katello/blob/gh-pages/generator/generate it will be generated in `apidoc` directory
Can you make this ```describe CalendarController do``` and then a nested ```describe "index action" do```? That way we can have several nested describes that are split up depending on which controller action is being tested.
nit `PathMatcher` since it's a constructor.
Sorry, I was imprecise. I meant that I usually start noun phrases (that is, the things that introduce variables, a/o/t methods) with a lower case. This was the only one of those in the file.

In any case, I'll aim to go with the flow in this regard, on an ongoing basis.
I don't understand the `memset()` reference. Is it a leftover from the memory_funcs thingie?
text did not fit, you will get those more when German will be introduced.:)

I'll do more work on the contacts entry form later - layout gets  there
Same here, also check for `\`. You should probably make a method called `_verify_container_name` or something like that.
Thanks for the PR! I don't think the other meta-data are important for now - the table ID is important because it's used to identify the table when reading.
But in the end this pull is not mergable like it is?
Internally, proxies can be selected separately for each network, and for hostname-based destination. The config and GUI right now are pinned to assume the IPv4 one is the only one, so they read NET_IPV4, and modify the NET_IPV4, NET_IPV6, and named ones simuitaneously.

It's just a temporary measure, I expect the GUI config panel will be extended with more proxy options, and for RPC maybe we can move to a "getnetconfig" command that returns this kind of information, including connected peers and some statistics?
Nice one! I will.
Shouldn't the `'/'` also be `DS` ?
Default value of `null` would be better than `false` for $password, as it better denotes "no value".
Add ```Defaults to `false`.```
I'm not sure I fully understand what should or should not be indented.
How so? I don't see the bug.
WIF has an http module that will trigger the signin process if the PassiveRedirectEnabled flag is = true and the user is not authenticated (principal.Identity.IsAuthenticated). In general is a good practice to deny all anonymous users to a site. 

Jabbr is a single page app and for the case that you use the selector I override the flag PassiveRedirectEnabled and remove the authorization section so that the default.aspx page can be shown and the identity selector is rendered.

I could get rid of this, fallbacking to "jabbr.state" cookie as the mechanism to detect if the user is authenticated or not and redirect via javascript in default.aspx. This is also related to the last item in the TODO list... I think I will get rid of the WIF cookie all the way and just use WIF for the initial authentication. I will do the rest of the things first and then try to tackle this one which is more heavy.
We don't need these checks anymore? (Ci.nsIDOMHistory and "StorageList").
Did you test it?

Honza
This file is generated periodically from markdown found here: https://github.com/gnachman/iterm2-website/blob/master/_posts/2011-01-08-documentation.md
Please send a separate pull for that file.
Since you're merging it you can remove publish:false, bump it to 0.0.1, and
publish it to npm, so browserify can use it. I put it in in case you didn't
merge, in which case I'd need to pick a different name before publishing.

Does the external thing decide whether you check for 2x images? If so maybe
you should make it configurable which sites you skip the check on.
On Jul 6, 2012 7:19 PM, "Casey O'Hara" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,13 @@
> > +{
> > +  "name": "retina.js",
> > +  "version": "0.0.0",
> > +  "publish": "false",
> > +  "devDependencies": {
> > +    "mocha": "*",
> > +    "should": "*"
> > +  },
>
> Should we also add `"http-server": "*"`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/imulus/retinajs/pull/27/files#r1117760
>
I think this logic to get the calling scope should be inside the `embed_kernel` function in `ipkernel`, so that it has exactly the same API if it's imported from there.
Yes as target is a generated dir.
On Oct 31, 2012 7:17 AM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/test/java/org/jclouds/oauth/v2/functions/OAuthCredentialsfromPKCS12FileTest.java:
>
> > +import java.security.UnrecoverableKeyException;
> > +import java.security.cert.CertificateException;
> > +
> > +import static org.testng.Assert.assertEquals;
> > +import static org.testng.Assert.assertNotNull;
> > +
> > +/**
> > + * Test loading the credentials by extracting a pk from a PKCS12 keystore.
> > + *
> > +
> > + */
> > +@Test(groups = "unit", testName = "OAuthCredentialsfromPKCS12FileTest")
> > +public class OAuthCredentialsfromPKCS12FileTest {
> > +
> > +   public static OAuthCredentials loadOAuthCredentials() {
> > +      OAuthCredentialsFromPKCS12File loader = new OAuthCredentialsFromPKCS12File("foo",
>
> not clear what you mean... do you mean changing "target/test-classes" to
> "src/test/resources"?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r1992461>.
>
>
should set embedPlayer.userSlide to avoid interface updates ?
That won't happen with the current usage but fair enough, I hadn't thought of that case.
but the way it's commented out is lars-style
Tables added!
Can you change this to only prepend exec for non-Windows environments?
It's a BC break but nobody could have used it at all. Just setting the parent will create inconsistencies (the parent is set but the parent will not have the routecollection as child) and result in undefined behavior.
errors are already logged in debug mode when they are turned into exceptions (as exceptions are logged). Logging deprecations is because they are not turned into exceptions, and logging fatal errors is because they are turned into exceptions only in the shutdown
If I'm not completely off, this parsing is too optimistic. It will break as soon as one of the characters used in `explode()` appears in the value of a parameter. Consider e.g. the following Accept header:

`text/html;q=0.9,text/plain; charset=utf-8; param="this;should,not,matter"; footnotes=true`

The current code interprets `not` and `matter` as parameters whereas they really should be part of the value of `param`.

I'm not sure if the adding complexity for these corner cases is worth it, but at least this limitations should be documented properly.
It's also worth noting that MySQL conflates character sets and collations at the protocol level, so 33 is "utf8_general_ci" collation, and you could see many other values here for utf8 collation.
I noticed that some models miss the statement
```ruby
require 'yast_service'
```
even if there is the constant YastService in use. This is the case for the whole network plugin. I thought there is such a dependency explicitly mentioned in the Gemfile, but  the Gemfile is not there at all. 
Is there this dependency implicitly expected somewhere in the upstream stack?
Obviously if the observer feature has been removed from rails I can't disagree too much. The reason I liked Rails Observers (RIP) is that they allowed you to create publisher/subscriber relationships in apps, which I always thought of as mini-SOA. I like the idea of being able to add functionality (or adding subscribers) to the app without modifying existing classes. In this particular case the actions are very appropriate for this model, but I've seen cases where the call back methods resulted in actions that were obvious separation of concern issues.

All of that said, I'm not opposed to this code or callbacks. I just posted the comments more for the sake of conversation than anything else.
does LUA have a 'break' for loops similar to C++?   If so, might want to 'break' after this.
It looks okay, but are you sure you can find scores from Naive Bayes?


On Fri, Nov 16, 2012 at 1:53 PM, Ajay Gavankar <notifications@github.com>wrote:

> In server/models/Article.py:
>
> >      pass
> > +
> > +class Reader(db.EmbeddedDocument):
> > +    user = db.ReferenceField('User', dbref = False)# the false setting here will make mongoengine use ObjectId strings here, i think
> > +    score = db.FloatField(min_value = 0, max_value = 1, default = 0.5)
>
> @AkarshES <https://github.com/AkarshES> is this fine or should score have
> a different implementation?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Arun-UB/Readless/pull/11/files#r2149328>.
>
>
昨天merge的时候有点急，没很仔细的看，所以今天才看了一下代码和编译效果。
关于verbatim，那就先搁置吧。
No doubt that this works on Linux, my concerns are the other platforms. A renderer might not support buffering, check m_pRenderer->GetMaxProcessorSize(). In this case you can't increase MiNumRenderBuffers to 3 and waevex2 should not be allowed. Adding software decoder to supported methods for buffering should work.
In NotifyDisplayFlip only set to 2 frames behind for waevex2. The number of allocated buffers e.g. vdpau is limited.
Should this be calling `unbind` and not unbind_all ?
I'm not keen to stop people passing their own transform instances through. My prefered test would be:

```
if isinstance(t, ccrs.CRS) and not isinstance(t, ccrs.Projection):
   ...
```
Same here with "Leggings" :p
je pense que c'est cette conf qui fait merder le deploy sur cloudbees, notamment l'ajout de db=...
Вроде нормальные же, нет?
Ok,but let us keep the hierarchy as simple as possible. 

Think about the developers: does it make sense to catch a specific exception? 
If not, so let's use only NdefException with an appropriate message.
You should handle the option in AbstractChosen like others, to allow handling the default value.

And ``do_not_split`` does not seem a good name to me. What it is about ? Existing options related to configuring the search are all using ``search`` in their name (``disable_search``, ``search_contains``, ``disable_search_threshold``)
These commented code can be removed, i found the bug it was just a missing model in Activities
I'm totally unfamiliar with this, so: Is having corba an absolute requirement?
if (iccCommand)
We should make sure that 49 is the correct value taking a look to page.js library
Changed to use createElement(), appendChild() and contentText() without escaping HTML.
Januarar -> Januar
`       this._timeout = window.setTimeout(function longpress(id) {`
This seems fragile. Why not using an 'id' instead?
Do we still need this "onreturn" calling for SleepMenu?
This `display` rule will raise an issue if devs want to use a `hidden` attribute on the target element (we already have this issue with `buttons.css`).

Please extract it with something like:
```css
nav[role="scrollbar"] li .icon-search:not([hidden]),
nav[role="scrollbar"] li .icon-favorites:not([hidden]) {
  display: inline-block;
}
```
Same comment as the similar code in settings/
Resolved, moved into db.open.
I can do `if (resizeActivityFrame === false)` but I rather not to do it...
Thanks for the note! I will rip it out by hand for now and do something in caldav.js later to make it permanent.
Shouldn't this be called TestRequestContext?
String.Empty (casing)
orly? I always thought I had to put that in `$()`
There should not be a special this.scheme property. Instead, if an endpint uses auth without explicitly stating a strategy, look for default. Also need to prevent configuring routes with no strategy when no default has been defined.
I don't understand this. Why would a function "which handles integer protocol buffers" return a void protcol buffer? Explain this function better.
I would leave this field empty if user hasn't set the name. This field also clearly needs a lot better description.
this chunk seems a little difficult to feature out what's going on, not unlike a lot of stylus internals already haha but we should try and add some inline comments around to summarize the intent of these larger blocks of somewhat cryptic code
Don't hard-code this URL. You can leave the action blank if it should always hit the same page, or you should use a url template tag.
Indeed there should be; nice catch. Just fixed it in my current branch and will be in the next pull request.
We could make this cancelable?  

Not sure if reaping is the only way chunks are unloaded.  I think player log off can also cause it.
Well, those are the options and behavior we already had on autotest-local, but for sure we should deal with it.

While `--quiet` does what it says (do not include DEBUG messages), it's really not needed: we should just make verbose explicitly default to False.

I'll post an incremental patch, and If we want to make `--quiet` reappear in the future, It should really prevent all the output of all (or maybe almost all) messages.
You could just add another option to self.checks that says "expect a list"..
any reason not to use inlineCallbacks here?
Yup and also to the like ones below.
getResourceDirectory?
Can you call that $directories and fix up the docblock perhaps to look more like findShortestPathCode's argument?
Sure, while I'm at that I can make it print-only.
Move to header.m4.
Nope. Could you add it cuz I dunno what exactly I should implement in that case
Also I botched the bottom ones a bit so you get that inverse-crop effect on the bottom of her bodice, but I'm hoping this is a good enough start that you can clean it up from here.
yes, slightly. even if undef and define is not so nice, maybe we should add there some TODO or FIXME note.
This particular change (using require relative to __FILE__) seems like a bug or misconfiguration on your end - How did you 'require "logstash-event"' if you do not have the gem's lib already in your loadpath?
sem mudança
Maybe using a getter is a better option here.
Is known no longer used?
This is the end of the modification of the template
Existe pas
@vrthra we should add the `has_feature :upgradeable` to the sun provider, so that when `ensure => latest`, the package type will invoke the provider's `latest` and `update` methods to upgrade the package. Or take those methods out if they don't actually work.
> Also, I can't think of a good use case for this. When would you ever want a handle on the original value? Even if you could argue it, why not just leave it to the user to assign the real value to a variable?

This came out of rspec-fire, where [we need to keep a reference](https://github.com/xaviershay/rspec-fire/blob/master/lib/rspec/fire.rb#L223-227) to the old value.  This is necessary because when you do `fire_replaced_class_double("MyNamespace::MyClass")` it gives you a test double that verifies each stub or mock expectation you set on it against the interface of `MyNamespace::MyClass` if the constant was already defined.  That way, if you stub a method that doesn't exist, you get an error immediately.  The reference to the old value is necessary to make this possible.

When I ported this from rspec-fire, I had to decide where to "split" the code there, and this is what made sense at the time.  In my head, I thought that returning the original value would be generally useful, but I can't think of any specific use cases beyond what rspec-fire is doing right now.  As for leaving it to the user/rspec-fire to assign the original constant value to a variable...that's certainly doable, although in the case of rspec-fire, it's not as simple as your `real_thing = THING` example...rspec-fire will have to recursively get the real constant since it just has the string representation.  Not a huge deal, but it's work that rspec-mocks will also do, so it's a bit wasteful to do it multiple times (admittedly, the perf cost will be unnoticeable unless people are doing crazy stuff where they have a constant nested thousands of levels deep).

Anyhow, there was another thing we had in rspec-fire that I originally ported [but then removed](https://github.com/rspec/rspec-mocks/commit/f77357e65f11c2d4d193be98fb29829e528953cd): `find_original_value_for(constant_name)`.  We still need that functionality in rspec-fire and I was planning to add it back there (since it didn't feel like it belonged here, originally), but if there's interest in keeping that here, it would solve the problem as well...then we could just let users use that to get original values if they want them and don't want to stash original values in a variable.

Whatever you guys want me to do here is fine; my perspective is very much colored by how we used this in rspec-fire, but I want to make this feature generally useful and not couple it to what the needs of rspec-fire are.

> I think if it's going to return anything by default it should be a double.

`double` is probably the right thing to have it return if we're going to have a default.  I lean a little towards not making a default for now, though, unless there's near-unanimous support for that.  We can always add the default later, but if we add it now and later decide something else makes more sense, we'll be stuck with it.

/cc @xaviershay
you're now managing two classes - active and inactive - yet they are literally boolean - the absence of one should presuppose the other state
Yeah you're right about the duplicate `$.isFunction`, but getting around it is not very much possible. At first I thought of the following:

```js
source = window[this.source] ? window[this.source] : this.source
items = $.isFunction(source) ? source(this.query, $.proxy(this.process, this)) : source
```
But that could cause non-function window properties to be set as the source of the typeahead.
@sindresorhus How can I avoid this.options.coffee ? 'coffee' : 'js' checking ?
This is confusing. Since the line does not exceed 120 chars, revert.
CreateElement is technically faster but i wouldn't worry about it.
Sollte per Annotation gelöst werden...
Removing source will make the template HTML invalid.
uhm i dont know your patch well enough yet to really answer this .. but i guess fields need to be covered by ``hasField()`` :)
Parens, undef.
I have a hunch this merging is incorrect and is leaving keywords with unnecessary entries.
According to what I've seen, the "standard" for inline variables doc is /** @var $varname Type */. At least for Eclipse / Netbeans.
CS: declare the closure next line (with indentation)
May be add 
MY_P="PsychoPy-${PV}"
typo `erflogreich` should be `erfolgreich`
Please make it true instead of null (doesn't actually matter, but slightly easier to understand: "socket: yes, this is a socket" ;) )
always best to have a coma at the end of every item in Python. Less error prone.
This should also be wrapped in a `gettext` call:

    <button type="button" class="span2 btn">{{ _('Previous') }}</button>
make this easier to ready by declaring each one on a newline
Good point, thanks. I just followed the old plugin structure, but this obviously sounds like a better way.
Oh, sorry, one more thing! The h is part of the old translation format and can be removed.
The previous example illustrates passing a block to `EDN.register` (lines 102-104).
Ok. You have a while in the feeding loop though.. Is this while loop blocking?
あれ、もしかしてこの部分自動生成されるとか？ だったらごめんなさい。でもはずしたい。
Right, on some machines this works fine while on some others hardwareisa is not set.. I swapped them around as you suggested. Looks good on my setup (+60 hosts of all different arch flavours).
This might be an ERROR more than INFO?
Both do get called in order, so first the islandora_object_load will be called then islandora_datastream_load will be called. For menu items that use %islandora_datastream I just pass the data stream object to the callback.
Should I make it less transparent? I could also try making the radius larger as well.
I just copy pasted it from my IDE. Fixed in second commit.
Straight quotes, please
Given logicalPort parameter has no IP address.
Action should fail on checking parameters with provided one.

We should either provide a LogicalPort with an IPProtocolEndpoint, or change the interface definition to make setIPv4 accept LogicalPort, ipAddress and mask.
Should probably remove this line.
Nm, figured it out. Is the class issue I noted in my comments further up.
How do we set auth token?
На мой взгляд некрасиво, чтобы что-то где-то торчало, пусть даже в специально отведенном месте.
копировать все не очень круто. теряется смысл сжатого хранения :(
May be add volatile keyword for 's' variable?
According to PEP 8 we should remove this extra blank line. See http://www.python.org/dev/peps/pep-0008/#blank-lines
the option.... which is?
What's the meaning of this variable?
It's also globally assigned.
Again, a bit worried about the query and serialisation impact of this.
Good point, I'll add these in.
One additional note, but probably out of scope for this review. If we use a `slug` column in the AuthzMembershipsCache CF, we can reduce the number of queries on cache hits by 1-per-request.

1. Rather than delete the row for a user, insert a column whose name is `_` to the value 'invalid'
2. When memberships are exploded and persisted, store _ with value 'valid' (delete the row as well to remove old columns)
2. When querying AuthzMembershipsCache, rather than first querying first 2, simply add `_` to the list of column names. If _ is the value 'valid', then you can use the result of the query. If it's 'invalid', return the result

When paging the results for access, we'll need to know to exclude this slug, as well.
Does this mean that for example the library search type will have to live inside of the search module? It feels like it should be possible to register from the content module.
Do you mean global server or tenant server ?
Please consider using Helenus' `row.forEach` here.
Please remove whitespace
Yes, sending the user back to / sounds good.
I don't like using integers like this. It should be an enum, but anyways, I don't really like using magic numbers like this anyways. Instead, use a hash map, and use the enums.name() to get the key.
Есть также метод isNotEqualTo
Предлагаете сделать что-то типа:
-(NSMutableArray *) DNA
{
        return self-> DNA;
}
?
@slebedev Суть ясна и так была :) Собственно, об этом я написал в предыдущем своём комментарии.
Количесто элементов массиве DNA может быть больше или меньше ста. Заменить надо столько элементов, чему равно количество процентов от размера массива DNA (x = DNA.count/100 * percent)

В общем сейчас не программа считает сколько эелементов нужно заменить.
All modules that already store their coords use private int xCoord/yCoord/zCoord.
Is there any reason for breaking style like this?
и проверка здесь что есть на страничке нужна
Add ``CefRefPtr<CefProcessMessage> response`` argument here to fire callback from ``CloseLiveBrowserFireCallback``.
I removed the recalculate call in my latest commit: https://github.com/houqp/kindlepdfviewer/commit/ae1c489a0fb94317bef1fa5a60b4d320af4f8ea6

So we might have a conflict for your next RP, but we can handle it manually later.

BTW, if you have better idea for the implementation, just ignore my suggestion ;P
I figured since I was adding "reset" to the API class, I should just add both for completeness.
This is fine, but I meant that you should update the readme doc. It's unlikely that anyone will read this, unless they generate the rdoc.
Huh, what the heck? Just a copy/paste error :)
Why not just return a string?
can you add some pl.subplots_adjust that micmic as pl.tight_layout() (not available in old pylab)

otherwise the ticks in all figures can be outside of the figure.
The reason why I didn't use  mne.fiff.Raw as input is that the function modifies the data, if someone uses  compute_proj_ecg directly from python this could be a problem.

I can save the events and proj here, no problem.
style: spacing after single before the (
*nod*. Updated.
Calling `#html_safe` on a String gets you a new instance of ActiveSupport::SafeBuffer, so at the least this is redundant.

This looks like a fancy map, also.
`set-screen-title` should probably be moved to the screen module along with maybe, `zstyle -t ':prezto:module:screen' auto-title`, but I think that's still *screenrc* dependent.
why adding backslashes before dots ? It is not a regex here
http://symfony.com/doc/current/contributing/documentation/format.html states that when code contains ``<?php``, it should be defined ad html+php
This part will be removed anyway
Can you just require `cucumber/rails` instead of `cucumber/rails/X,Y,Z`?
I'm not sure either...Tommy do we actually need that?
Rename to `expectedMessages` (or just `expected`) would be nice.
i havent come up with one yet that is descriptive and short. plural because you are setting it globally for all deps (./rebar g-d alt_urls=true) i'm open to changing this to anything better we can come up with. i'll keep thinking.
Why is this called a Mailbox when it is not?
for(cp <- channelParameters; sdl <- cp.shutdownListener) ch.getConnection.addShutdownListener(sdl)
Thanks for looking this over, Matt. This is now in.
uummm, what, don't you need to check the transport address? What if people write their own transports?
I also see a big risk here, if people can't get it to "just work", it means that their code will be hardcoded to the transport being used.
'i' global variable. Include too.To exclude problems in the projects.
Why was this style removed? This completely breaks WindowCommands
You could use logging for your print statements too.  If the main concern is that you want some messages to go to console, some to a file, you can add another handler to your logger:

log = logging.getLogger("console")
formatter = logging.Formatter(
                "%(asctime)s (%(levelname)s) %(name)s : %(message)s")
console = logging.StreamHandler()
console.setFormatter(formatter)
console.setLevel(logging.DEBUG)   

This way you could use log.info, log.debug instead of print statements, without actually writing anything to file.
This shouldn't be here I guess.
As this method return the status it should be prefix by a get
@return \task_manager
Need javadoc on the methods for this class
The 'Basic' model for frequently used nodes
why are we importing from reddwarf here. maybe im missing something
Tässä pitäisi vielä tarkistaa, että listojen alkiotkin ovat samat:
~~~clojure
;...
(not= (first a-seq) (first b-seq)) false
;...
~~~
Please avoid whitespace changes where possible. It's fine with this commit, but for the future :)
I think we should but this is out of the scope for this PR. So I'll create a jira to investigate this later.
It seems there are a lot of tests that only make sense for clustered caches, shouldn't then (Clustered)DistributedExecutorTest inherit from LocalDistributedExecutorTest?
Is there a reason why you want to change order in which are these methods execued?
s/function/Function/
Precisely. Any tips?
Yes. On package rename we only provide the (or a virtually) last version and obsolete older ones.
I'm not sure about this formatting. Unfortunately I can't find a de-facto matplotlib docstring. Do any of the devs have any resources to look at regarding the target format for mpl docstrings?
Double new line was intentional here.
75? I thought we did 80?
I can see that.

I think that more advanced SEO options should you want them should be available, but I think thats someting for the future.

With that said I will go with good system defaults and no user input for now.
+1 thanks for adding base_url!
It's fine to have it in setup, but I was suggesting sticking it in the global test class setup function as every sub test case inherits from that. To do that, we would do a check if a test var is set in GaiaTestCase and then execute the below wifi setup logic. That way, any test can reuse the wifi setup logic easily by just setting a test var for the ssid.
The name `options` this one is a little misleading even though the locator says `options`. Do you think we could improve the name?
I guess there's no real reason why I'm using `stdout.write` instead of `print`. I've seen that used in a lot of other managment commands, so I was thinking that `stdout.write` was the _proper_ way to put stuff on the screen.

Personally, I'm cool with either way. I'll with whatever you prefer ;)
Please do not mix conditions and instructions in the same line.
Whoops! You're right. Definitely reversed that logic
This comment doens't make sense here as the next line doesn't start the REPL. Remove?

Is Common the right place for the option? Not really sure where it fits. If common is right, move -C up above -v.
imagine that payee or account have been modified. I believe that this line is setting modified to False if tags is not modified. Can you confirm?
Space between 0,0: 0, 0, _screenWidth ...
@bp323 Shouldn't the `label for` attribute be `newcreategroup_allowthemechanger`?
Instead of triggering a click we should hide/show the appropriate elements.
@stof I'll keep that in mind in the future, thanks.
wtf does these things mean o_O. sadd?

I feel like this logic would make more sense if it you just made it into one if statement

if implicity
add to participations && converted && conversions
else check member and then add to converted and conversions.

right now it's kinda weird with that false statement.
Same here. Hm thinking about my own code, we should avoid the redundancy here and use the same regex than in FtanParser.
- Are you sure the variable ``$domains`` exists, or did you maybe mean ``$domain``?
- Please always use braces to surround the code block of FOREACH statements.
Use === and !== instead of == and != as per appcel's js best practices.  Applies for other occurences of ==
Yup, you're right, would you like me to change it or will you change it?
Does this class work at all if the DB creation throws an exception? You should probably just pass the Exception along instead of masking it.
Wie du schon gesagt hast, den tagName sollte man noch bisschen sichern. Ich denke alle Zeichen ausser [a-zA-z0-9] zu enfernen würde schon einiges nützen. Obwohl, so gross ist das Problem wohl nicht, da wir den tagName ja nicht in einer stringartigen Query, sondern nur als Stringparameter verwenden.
This would definitely need to be `_.filter(calls[event], ...)` since Array#filter does not exist in old IEs.
I think `_.isObject` is probably more appropriate here considering that `typeof null === 'object'`.
**kwargs (double *)
I think I'll just remove these options and leave it to the developer to figure out?  

What I meant was that the IPA will still be created if they don't provide a provisioning file or developer_idientity.  Do these survive in the .app from the original build?
Do we have examples of the lut1d section in use?  In the meantime (before we implement support for lut1d) would it be more appropriate to fail on loading a .look file if lut1d is found?
Now I'm following this. The oLabel = statement is logically under the var statement, and should be indented to show this relationship.

Although, with really long blocks, it may be straining too much to continue the same var statement. Starting a new one is worthwhile at some point to keep things clear and obvious.
The legacy JView class.  Renamed to deconflict with the new MVC JView interface.
You'll be just fine!  You can do it!!  Just think of your vacation when you're gone 3 weeks.
You hardcode here views. If you would really want to do this, it would be much better to require whole Python path to the view where you would then here import the module and use that view.